26302c2257
Merge pull request #9280 from blaahaj/OpenGL-ES-3.1-ARB_shader_storage_buffer_object
...
Fix bounding box incorrectly disabled on OpenGL ES 3.1, 3.2
2020-11-27 15:56:50 +01:00
9b03cdf93e
Merge pull request #9101 from sepalani/fix-ip-fallback
...
IP/Top: Fix fallback IP address
2020-11-27 02:39:15 +01:00
2a85534805
Merge pull request #9283 from JosJuice/config-get-speedup
...
Common: Optimize Config::Get
2020-11-27 02:36:33 +01:00
324de7fa02
VideoCommon: Use Common::SavePNG() to write textures.
2020-11-26 23:55:05 +01:00
33c1a5b941
InputCommon: Use Common::SavePNG() to write images.
2020-11-26 23:55:05 +01:00
2de3b12e9d
Common: Add SavePNG() function that writes PNGs using the simplified libpng API.
2020-11-26 23:55:05 +01:00
978e5469af
Core: Remove commented out logs
...
Commented out logs shouldn't be kept around, since it makes performing
renames and migrations harder, as tooling generally doesn't inspect
comments.
2020-11-26 07:49:37 -05:00
ffbf3d71f0
Frontends: Migrate logs over to fmt
2020-11-25 21:19:08 -05:00
4c9ffb58fa
Merge pull request #9250 from Dentomologist/fix-fst-error
...
Fix file rename errors on Windows
2020-11-26 02:09:30 +01:00
e00572dd07
Merge pull request #9282 from lioncash/core-log5
...
Core: Convert logging over to fmt pt.5
2020-11-26 02:06:41 +01:00
d573ce34d7
Merge pull request #9281 from AdmiralCurtiss/iofile-write-string
...
IOFile: Replace fprintf with WriteString/fmt.
2020-11-26 01:39:56 +01:00
3891ac2682
Merge pull request #9232 from AdmiralCurtiss/show-result-value-in-expression-editor
...
Qt/IOWindow: Show result value in expression editor.
2020-11-26 01:30:12 +01:00
1734cf55d8
Fix file rename errors on Windows
...
On Windows, when the Rename function fails to replace an existing file
it will now retry the operation multiple times with increasingly long
delays between attempts. This fixes transient rename failures.
I've been getting sporadic yet annoyingly frequent errors saying:
'IOS_FS: Failed to rename temporary FST file'
These typically appear on startup but I've also gotten them randomly.
Investigation shows this happens when the Windows ReplaceFile function
returns the error ERROR_UNABLE_TO_REMOVE_REPLACED. That happens in the
context of using ReplaceFile to perform an atomic file overwrite, which
is required when saving updates to a file to avoid corruption. The
error mainly happens with the /Wii/fst.bin file but I've seen it
happen with multiple other files as well.
I haven't been able to definitively pin down why the error occurs,
though online discussions suggest antivirus scanning may be a major
culprit. That said, I've excluded the Dolphin folder from Windows
Defender scans to no avail and don't have any other antivirus running,
so this is likely to be a problem others are experiencing as well.
The number and duration of retry delays is arbitrary but I feel like a
combined second or so in the worst case is an acceptable tradeoff for
the reduction (actually elimination in my experience) of those errors.
This is even more true when you consider the time it takes to read and
dismiss the error dialogs.
2020-11-25 16:12:58 -08:00
11e226a91a
Qt/IOWindow: Remove Apply button.
2020-11-26 00:47:37 +01:00
334100509b
Qt/IOWindow: Show the current value of the expression.
2020-11-26 00:46:51 +01:00
ddfb8fa404
Qt/IOWindow: Apply expressions immediately so we can query the current value of the expression.
2020-11-26 00:45:31 +01:00
45d4746a5d
IOFile: Replace all fprintf string writing with calls to WriteString.
2020-11-25 22:11:21 +01:00
ef75e9acd8
Core: Convert logging over to fmt pt.5
...
Converts the remaining PowerPC code over to fmt-capable logging.
Now, all that's left to convert over are the lingering remnants within
the frontend code.
2020-11-25 13:23:48 -05:00
2f264c6448
Common: Optimize Config::Get
...
The way Config::Get works in master, it first calls
Config::GetActiveLayerForConfig which searches for the
setting in all layers, and then calls Config::Layer::Get
which searches for the same setting again within the given
layer. We can remove this second search by combining the
logic of Config::GetActiveLayerForConfig and
Config::Layer::Get into one function.
2020-11-25 16:26:13 +01:00
9c590e215f
IOFile: Add WriteString() method to replace fprintf string writing.
2020-11-25 15:41:25 +01:00
e2a019ae9a
Merge pull request #9276 from lioncash/core-log4
...
Core: Convert logging over to fmt pt.4
2020-11-25 13:21:23 +01:00
140daf5960
Merge pull request #9268 from leoetlino/devicememcard-minor-cleanup
...
EXI_DeviceMemoryCard: Medium cleanup
2020-11-25 10:07:44 +01:00
12a215c232
Merge pull request #9277 from JosJuice/gles-vertex-uber
...
Fix vertex ubershader GLES compile errors
2020-11-25 10:04:45 +01:00
4a21be5d77
Merge pull request #9278 from lioncash/latent
...
Core: Convert missed log calls over to fmt
2020-11-25 09:58:40 +01:00
bf0fe0281a
Fix bounding box incorrectly disabled on OpenGL ES 3.1, 3.2
2020-11-24 21:22:39 +01:00
d01f85cfd8
Add Rock Band 3 MIDI PRO Adapter to known Wii peripherals
...
Based on info from https://forums.dolphin-emu.org/Thread-emulate-midi-pro-adapter
2020-11-24 14:25:19 +01:00
eedfe2abf1
Core: Convert missed log calls over to fmt
2020-11-23 12:20:02 -05:00
6cd718163f
Core: Convert logging over to fmt pt.4
...
Continues the migration of logging in the Core library. This part
finishes up the remaining log calls within the IOS code.
2020-11-23 11:53:21 -05:00
28c696fa74
Fix vertex ubershader GLES compile errors
...
Regression from 51724c1
2020-11-23 11:42:41 +01:00
b555f0fb93
Merge pull request #9265 from lioncash/core-log3
...
Core: Convert logging over to fmt pt.3
2020-11-23 02:46:58 +01:00
b53127a1fa
Merge pull request #9274 from JosJuice/av-register-all
...
FrameDump: Re-add call to av_register_all
2020-11-22 12:45:59 +01:00
79f50cd4fd
IP/Top: Fix fallback IP address
2020-11-22 15:34:27 +04:00
5d9eb8f6ce
Merge pull request #9271 from leoetlino/warnings
...
Fix several warnings and only enable extra warnings for our own code
2020-11-22 02:04:53 +01:00
118d056410
FrameDump: Re-add call to av_register_all
...
This was removed in 4902146329
2020-11-22 00:11:23 +01:00
cbbf044064
Core: Convert logging over to fmt pt.3
...
Continues the migration over to fmt up to IOS' ES module.
2020-11-21 05:56:37 -05:00
41b79a66c7
Merge pull request #9270 from leoetlino/dtm-gameid-null
...
Core/Movie: Fix a likely out-of-bounds read for PanicAlertT
2020-11-21 01:53:15 -05:00
9efc81ae98
Fix variable shadowing warnings
2020-11-21 02:08:09 +01:00
7840f61524
Silence "missing switch cases" warnings
2020-11-21 02:08:09 +01:00
6ab1ab1f12
Fix -Wmaybe-uninitialized warnings
2020-11-21 02:08:09 +01:00
82f1e6204d
Fix -Wsign-compare warnings
2020-11-21 02:08:09 +01:00
83b9feff90
Core/Movie: Fix a likely out-of-bounds read for PanicAlertT
...
gameID isn't null terminated since it is just an std::array<char, 6>
and .data() returns a char* so {fmt} would go way beyond the bounds of
the array when it attempts to determine the length of the string.
The fix is to pass a std::string_view to {fmt}. This commit adds
a GetGameID() function that can also be used to simplify
string comparisons.
2020-11-21 01:30:02 +01:00
d6ce8eef36
Software: Use same logic for colors as hardware backends
2020-11-20 15:54:06 -08:00
51724c1ccd
LightingShaderGen: Always calculate lighting for both color channels
...
Cel-damage depends on lighting being calculated for the first channel
even though there is no color in the vertex format (defaults to the
material color). If lighting for the channel is not enabled, the vertex
will use the default color as before.
The default value of the color is determined by the number of elements in
the vertex format. This fixes the grey cubes in Super Mario Sunshine.
If the color channel count is zero, we set the color to black before the
end of the vertex shader. It's possible that this would be undefined
behavior on hardware if a vertex color index that was greater than the
channel count was used within TEV.
2020-11-20 15:54:04 -08:00
e4ceed2bed
Common: Assert that translatable strings use positional arguments
...
Like PR 9260, but for a different requirement (see PR 9253).
2020-11-20 20:24:30 +01:00
e63b00e562
Fix translatable strings which contain non-positional arguments
2020-11-20 20:24:30 +01:00
f82145d9dd
EXI_DeviceMemoryCard: Use std::array
2020-11-20 19:41:23 +01:00
f81062f561
EXI_DeviceMemoryCard: Use enum class for Command
2020-11-20 19:38:07 +01:00
b2f00be637
EXI_DeviceMemoryCard: Fix member variable names
2020-11-20 19:37:39 +01:00
1f15119f80
EXI_DeviceMemoryCard: Use override rather than virtual
2020-11-20 19:36:34 +01:00
279197b278
EXI_DeviceMemoryCard: Use more efficient overload of find_last_of
2020-11-20 19:36:34 +01:00
4ad88ce2e4
EXI_DeviceMemoryCard: Clean up casts and implicit conversions
2020-11-20 19:36:33 +01:00
e144d20dd6
EXI_DeviceMemoryCard: Remove unused include
2020-11-20 18:51:16 +01:00
2631243379
EXI_DeviceMemoryCard: Rename variables to follow our naming conventions
2020-11-20 18:51:16 +01:00
542c49bab0
Core: Fix invalid lambda captures
...
PR #9260 made the MsgAlert macros use lambdas so that local
constexpr variables can be added while keeping the ability to
return a boolean from the macros.
Unfortunately, C++17 forbids referring to structured bindings in lambda
captures. This is fixed in P1091R3 but we cannot rely on C++20 yet...
2020-11-20 18:27:56 +01:00
f45a4a5916
Merge pull request #9263 from lioncash/core-log2
...
Core: Convert logging over to fmt pt.2
2020-11-20 16:36:47 +01:00
88cc1b7c8a
DSP: Fix one DEBUG_LOG call
2020-11-20 16:21:05 +01:00
a0f9b041a0
Core: Convert logging over to fmt pt.2
...
Continues the core migration of logs up to the EXI handling code.
2020-11-20 10:05:44 -05:00
419dfe4be4
Merge pull request #9260 from leoetlino/fmt-checks
...
Common/Log: Add compile-time format string checks
2020-11-20 16:05:25 +01:00
a20e69ff51
Vulkan: fix validation error in bSupportsGeometryShaders=false case
...
In CreateDescriptorSetLayouts(), one less dynamic binding is created when
bSupportsGeometryShaders=false. Reduce the dynamicOffsetCount argument by
one in that case. Avoids this validation error:
Attempting to bind 3 descriptorSets with 2 dynamic descriptors, but
dynamicOffsetCount is 3. It should exactly match the number of dynamic
descriptors. The Vulkan spec states: dynamicOffsetCount must be equal to
the total number of dynamic descriptors in pDescriptorSets
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
[Applied clang-format]
Signed-off-by: Léo Lam <leo@leolam.fr>
2020-11-20 12:23:34 +01:00
c580a70a12
Merge pull request #9210 from Dentomologist/regions-show-hide-all
...
DolphinQt: Add Show/Hide All options to gamelist region menu
2020-11-20 11:35:22 +01:00
7ded075561
DolphinQt: Add Show/Hide All options to gamelist region menu
2020-11-19 20:39:49 -08:00
7f7fd4d8d3
Merge pull request #9220 from jordan-woyak/ext-crypto
...
WiimoteEmu: Implement extension encryption edge case.
2020-11-20 02:28:17 +01:00
bca82bb942
Merge pull request #9239 from altimumdelta/FFDUMP_Separate_Logging
...
FrameDump Logging: Separate log type and migrate to fmt
2020-11-20 02:21:57 +01:00
5921a93d71
Merge pull request #9247 from Dentomologist/fix-updater-temporary-folder
...
Fix updater not always cleaning up temp directory
2020-11-20 02:01:43 +01:00
eff566b318
Merge pull request #9258 from lioncash/core-log
...
Core: Convert logging over to fmt pt. 1
2020-11-19 20:32:19 +01:00
958cbf38a4
Core: Convert logging over to fmt pt. 1
...
Converts up to the DSP-related files for easier reviewing, the rest will
be progressively moved over after this change gets merged.
2020-11-19 14:21:06 -05:00
e3247b567d
Merge pull request #9185 from Losuc/skipEFBaccessHotkey
...
Add a Skip EFB Access Hotkey
2020-11-19 17:28:45 +01:00
dde6090e98
Common/MsgHandler: Add compile-time format string checks
2020-11-19 17:09:24 +01:00
62eeb05519
Common: Validate the number of {} fields in format strings
...
Unfortunately, {fmt} allows passing too many arguments to a format call
without raising any runtime or compile-time error [1].
As this is a common source of bugs since we started migrating to {fmt},
this commit adds some custom logic to validate the number of
replacement fields in format strings in addition to {fmt}'s own checks.
[1] https://github.com/fmtlib/fmt/issues/492
2020-11-19 17:09:24 +01:00
47c91696ee
Common/Log: Check format strings
...
Helps with catching incorrect format strings.
PanicAlertFmt already uses FMT_STRING and fmt::make_args_checked.
2020-11-19 17:09:24 +01:00
83c235b7cb
WiiUtils: Create Wii Shop log files when installing a WAD.
...
Fixes https://bugs.dolphin-emu.org/issues/12269
2020-11-19 03:26:27 +01:00
4eecb8fd11
Merge pull request #9248 from lioncash/video-fmt
...
VideoCommon: Migrate over to fmt
2020-11-18 11:10:48 +01:00
3d9b2aa005
VideoCommon: Migrate over to fmt
...
Migrates off the printf-based formatting where applicable.
2020-11-17 21:23:58 -05:00
eb1581bbcc
Merge pull request #9246 from JosJuice/translation-eot
...
DolphinQt: Don't return 0x04 bytes from tr
2020-11-18 02:31:13 +01:00
31d7be521c
Merge pull request #7714 from cristian64/avoid_leaking_gamelistmodel
...
DolphinQt: Avoid leaking the GameListModel instance to gracefully shutdown the GameTracker and prevent a crash on exit
2020-11-18 02:14:51 +01:00
0339889806
Merge pull request #9251 from sepalani/sockopt
...
IP/Top: Add missing sockopt
2020-11-18 02:10:37 +01:00
52c615f1b1
Remove a redundant i18n comment
2020-11-17 18:23:27 +01:00
9a01c3fb9f
Use positional arguments in all translatable fmt strings
...
We want to use positional arguments in translatable strings
that have more than one argument so that translators can change
the order of them, but the question is: Should we also use
positional arguments in translatable strings with only one
argument? I think it makes most sense that way, partially
so that translators don't even have to be aware of the
non-positional syntax and partially because "translatable
strings use positional arguments" is an easier rule for us
to remember than "transitional strings which have more than
one argument use positional arguments". But let me know if
you have a different opinion.
2020-11-16 13:28:11 +01:00
6dcf7643e5
Fix updater not always cleaning up temp directory
...
Updater was only deleting TempUpdate folder when an error occured.
2020-11-13 12:25:53 -08:00
53da97208a
DolphinQt: Don't return 0x04 bytes from tr
...
tr calls with more than one argument would have a 0x04 byte
in the returned string when no translation was found
(which always is the case when using Dolphin in English).
2020-11-12 19:44:44 +01:00
8a621c2d5e
Merge pull request #9236 from lioncash/log-backend
...
VideoBackends: Migrate logging over to fmt
2020-11-12 14:51:28 +01:00
ec5313fe24
Merge pull request #9204 from fbastos1/master
...
fix emulator issue #12139
2020-11-12 14:43:35 +01:00
d8e1921b57
InputCommon: Migrate over to fmt-capable panic alerts
...
Continues the migration over to fmt.
2020-11-12 02:29:26 -05:00
689eec5304
DiscIO: Make use of fmt-capable panic alerts
...
Migrates the DiscIO code over to fmt.
2020-11-11 01:09:42 -05:00
ae83685b0b
Merge pull request #9237 from lioncash/msghandler
...
Common/MsgHandler: Add fmt-capable variants of the alert macros
2020-11-11 00:34:45 -05:00
f44b13ffcd
FrameDump Logging: Separate log type and migrate to fmt
2020-11-10 17:17:43 +01:00
0a2564a89d
Merge pull request #9234 from lioncash/rename-fmt
...
ShaderGenCommon: Rename WriteFmt() to Write()
2020-11-09 22:08:42 -05:00
ff4b7ca7f4
Remove Android-specific settings from UISettings.cpp
...
They are unused, since there is no C++ code that touches
these settings. See the discussion in PR 9152, which is
a PR that adds a lot more Android-specific settings.
2020-11-09 21:41:00 +01:00
e260f9815c
Android: Move orientation setting to main settings screen
...
I moved it from the main settings screen to the in-game menu
in PR 8439 so that it could be changed while a game is running,
but now that the main settings can be accessed while a game is
running, there's no reason to not put it in the main settings.
https://bugs.dolphin-emu.org/issues/12067
2020-11-09 21:41:00 +01:00
7b21f7af2e
Common/MsgHandler: Add fmt-capable variants of the alert macros
...
Adds an interface that uses fmt under the hood, which is much more
flexible than printf, particularly for localization purposes, given fmt
supports positional formatters in a cross-platform manner out of the box
with no configuration necessary.
2020-11-09 08:48:17 -05:00
43e2f0e88f
Merge pull request #9235 from lioncash/ui-log
...
UICommon: Migrate logging over to fmt
2020-11-09 07:28:28 -05:00
ee52f465b1
Android: Fix rotating EmulationActivity after boot fails
...
Time for yet another new iteration of working around the
"surface destruction during boot" problem...
This time, the strategy is to use a mutex in MainAndroid.cpp.
2020-11-09 10:38:49 +01:00
21dd7a8ebb
Vulkan: Migrate logging over to fmt
...
Migrates the vulkan backend over to the fmt-capable logger.
2020-11-09 03:26:16 -05:00
23a8baa605
Software: Migrate logging over to fmt
...
Migrates the software backend over to the fmt-capable logger.
2020-11-09 03:14:01 -05:00
413d64e7fc
OpenGL: Migrate logging over to fmt
...
Migrates over to the fmt-capable logger.
2020-11-09 03:09:09 -05:00
4d9a7c7a54
D3DCommon: Migrate logging over to fmt
...
Migrates the logging over to the fmt-capable logger.
2020-11-09 03:03:26 -05:00
2345d5f98d
D3D: Migrate logging over to fmt
...
Migrates the logging over to the fmt-capable logger.
2020-11-09 03:02:00 -05:00
d7834bd6b4
D3D12: Migrate logging over to fmt
...
Migrates the logging over to the fmt-capable logger.
2020-11-09 02:59:51 -05:00
52f2fadb36
UICommon: Migrate logging over to fmt
...
A very simple change that continues the migration of the logs over to
fmt.
2020-11-09 02:39:55 -05:00
a5b28f1f07
ShaderGenCommon: Rename WriteFmt() to Write()
...
Now that we've converted all of the shader generators over to using fmt,
we can drop the old Write() member function and perform a rename
operation on the WriteFmt() to turn it into the new Write() function.
All changes within this are the removal of a <cstdarg> header, since the
previous printf-based Write() required it, and renaming. No functional
changes are made at all.
2020-11-09 02:31:49 -05:00
add2b44eb7
Merge pull request #9197 from lioncash/uber-pixel
...
UberShaderPixel: Migrate over to fmt
2020-11-09 02:13:57 -05:00
77dc289517
CPUDetect: Indicate slow PDEP/PEXT only for Zen1/+/2 (Family 23)
2020-11-08 14:27:24 +01:00
cae741584b
InputCommon: Return error, if any, from ControlReference::SetExpression().
2020-11-08 01:04:33 +01:00
70df5446d3
Android: Make the handling of SAF open modes more robust
2020-11-06 17:40:03 +01:00
a348efe947
Fix dereferencing nullptr BootParameters
2020-11-06 09:34:53 +01:00
4e32ec35a7
IP/Top: Add missing sockopt
2020-11-05 19:51:20 +04:00
28aa04312c
Common/LinearDiskCache: Replace std::fstream with File::IOFile
...
File::IOFile is better suited to this type of task.
Split out from a future PR.
2020-11-05 00:31:17 +01:00
a9c643e698
WiimoteEmu: Implement extension encryption edge case.
2020-11-04 15:22:06 -06:00
069840fb7e
Merge pull request #9218 from JosJuice/aarch64-hle-hooks
...
JitArm64: Implement HLE function hooking
2020-11-04 10:29:37 +01:00
3cd4c56645
Merge pull request #9203 from nick-michael/virtual-notches
...
Logic & UI for "Virtual Notches"
2020-11-03 17:10:54 -06:00
55dd3d7337
Virtual Notch settings and UI for octagonal stick
2020-11-03 22:06:27 +00:00
d2f80a4595
Merge pull request #9138 from martymac/VK_NULL_HANDLE-fix
...
Fix build on FreeBSD i386 - nullptr vs VK_NULL_HANDLE
2020-11-03 08:28:11 -06:00
fe986b6161
JitArm64: Implement HLE function hooking
...
Closely based on the x86-64 implementation.
Fixes https://bugs.dolphin-emu.org/issues/10965 .
2020-11-03 09:48:22 +01:00
d456e2e391
Resolve VkDeviceMemory/nullptr type mismatch to fix build on FreeBSD i386
2020-11-03 07:47:43 +01:00
cbaf8f82ec
Merge pull request #9214 from OatmealDome/macos-bind
...
Top: Set port when connecting a socket to find the default interface
2020-11-02 22:17:38 +01:00
5b9cd83137
Merge pull request #8758 from sepalani/so-shutdown
...
Socket: Abort pending operations on shutdown
2020-11-02 21:52:28 +01:00
dd688f4eb0
Top: Set port when connecting a socket to find the default interface
2020-11-02 13:27:38 -05:00
4bb0ac918b
Simplify Arm64GPRCache::Flush
...
`flush = cond ? flush : true` makes little sense when `flush`
is always true at that point.
2020-11-01 19:48:57 +01:00
407ef8b596
Add a Skip EFB Access from CPU Hotkey
2020-10-29 21:03:06 -03:00
72e1131123
Common: Fix logger related crash when HTTP response is empty
2020-10-29 21:20:59 +01:00
d7fa75ef64
modify file export to create folder in OS when explicitly extracting a directory
2020-10-29 15:20:46 -04:00
fe727ed1d0
Merge pull request #9194 from leoetlino/offsetof-warning
...
IOS/USB: Fix -Winvalid-offset warnings
2020-10-29 12:53:11 -04:00
752b1048df
Merge pull request #9196 from Dentomologist/update-register-view-debug-font
...
DolphinQt: Update register view font when Debug Font changes
2020-10-29 12:52:02 -04:00
5fe7528855
DolphinQt: Update register view font when Debug Font changes
...
Resolves https://bugs.dolphin-emu.org/issues/12261
Co-authored-by: Léo Lam <leo@leolam.fr>
2020-10-29 09:31:14 -07:00
6a3a71cfd7
Merge pull request #9141 from Techjar/but-for-how-long
...
Re-enable GPU Texture Decoding under MoltenVK
2020-10-29 01:22:13 -04:00
447de580ab
Source/Core/Common/Config/Config.cpp: add missing <mutex> include
...
Noticed missing include as a build failure on gcc-11:
```
[ 15%] Building CXX object Source/Core/Common/CMakeFiles/common.dir/Config/Config.cpp.o
Source/Core/Common/Config/Config.cpp:23:24:
error: 'unique_lock' in namespace 'std' does not name a template type
23 | using WriteLock = std::unique_lock<std::shared_mutex>;
| ^~~~~~~~~~~
Source/Core/Common/Config/Config.cpp:11:1:
note: 'std::unique_lock' is defined in header '<mutex>';
did you forget to '#include <mutex>'?
```
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
2020-10-28 08:53:15 +00:00
dc72edf0e2
UberShaderPixel: Migrate over to fmt
...
Completes the migration over to using the fmt-formatting WriteFmt
function. The next PR will rename all usages of WriteFmt, while
simultaneously getting rid of the old printf code.
2020-10-27 13:25:11 -04:00
2ebe02fd1b
dolphinqt msbuild: do not moc TASSlider.h
2020-10-26 18:37:46 -07:00
2d921da860
FileUtil: Fix format string
...
Fixes a recent regression: https://github.com/dolphin-emu/dolphin/pull/9187#issuecomment-716835091
2020-10-26 22:47:56 +01:00
d2a2ec870d
Merge pull request #9171 from lioncash/pixel
...
PixelShaderGen: Migrate over to fmt
2020-10-26 20:35:47 +01:00
07e6d008bd
Merge pull request #9187 from lioncash/commonlog
...
Common: Migrate logging to fmt
2020-10-26 19:01:26 +01:00
7f66de062c
Merge pull request #9188 from jordan-woyak/stop-caring-about-old-avcodec-versions
...
VideoCommon/FrameDump: Remove code for older versions of avcodec.
2020-10-26 18:55:48 +01:00
aae72c3e75
Merge pull request #9195 from jordan-woyak/mem-warning
...
DolphinQt: Add a warning to the MEM1/MEM2 override setting description.
2020-10-26 18:49:33 +01:00
23c9179fb6
Merge pull request #9071 from orbea/cmake
...
cmake: Silence warnings.
2020-10-26 18:48:42 +01:00
15914b749c
DolphinQt: Add a warning to the MEM1/MEM2 override setting description.
2020-10-25 12:54:42 -05:00
8b9a0c9e09
IOS/USB: Fix -Winvalid-offset warnings
...
Unfortunately, compilers will issue warnings when using offsetof with
non-standard layout types even when offsetof actually works fine here;
just having a virtual function is enough to trigger the warning...
Let's just stop the scan threads explicitly in destructors instead of
relying on member destruction order.
2020-10-24 14:02:38 +02:00
8a4773bc91
VideoCommon: update vcproj file to set HAS_OPENGL
2020-10-23 17:08:53 -05:00
a34745926e
VideoCommon: remove HAS_OPENGL from VideoBackendBase
2020-10-23 17:00:32 -05:00
272717b3f4
VideoCommon: update vcproj file to set HAS_VULKAN
2020-10-23 17:00:05 -05:00
d12380f26b
VideoCommon: rename USE_VULKAN to HAS_VULKAN in VideoBackendBase
2020-10-23 16:59:22 -05:00
5de2244acf
PixelShaderGen: Migrate over to fmt
...
Continues the migration of the shader generators over to fmt.
After this, all that remains in the Ubershader pixel generator.
2020-10-23 17:17:55 -04:00
4902146329
VideoCommon/FrameDump: Remove code for older versions of avcodec.
2020-10-23 14:43:50 -05:00
4e8df93f41
Common: Migrate logging to fmt
...
Continues the migration of our code over to the fmt logger.
2020-10-23 14:58:03 -04:00
285b926e92
Merge pull request #8782 from Pokechu22/missing-serial-version-data
...
Explain how to fix "Serial and/or version data is missing"
2020-10-23 20:44:06 +02:00
e89db89d9e
Merge pull request #9098 from jordan-woyak/wm-report-duplication
...
WiimoteReal: Only duplicate data reports when speaker data is enabled.
2020-10-23 20:38:25 +02:00
f375ee72a2
CMake: Add option to enable/disable Vulkan video backend
2020-10-23 20:14:46 +02:00
908d6f8fa0
Merge pull request #9179 from leoetlino/available-video-backends
...
VideoCommon: Get rid of the global g_available_video_backends
2020-10-23 20:02:21 +02:00
4f5c8bb42a
Merge pull request #9177 from JosJuice/android-savestate-time
...
Android: Show how long ago each savestate was created
2020-10-23 13:59:43 -04:00
ce6eda7c71
Merge pull request #9184 from lioncash/inputlog
...
InputCommon: Migrate logging over to fmt
2020-10-23 19:59:22 +02:00
87e4a0785a
Merge pull request #9182 from jordan-woyak/frame-dump-cleanup
...
VideoCommon: FrameDump fixes/cleanups.
2020-10-23 13:59:00 -04:00
c42b80a156
Merge pull request #9186 from JosJuice/rtl-pot
...
DolphinQt: Move QT_LAYOUT_DIRECTION string to qt-strings.pot
2020-10-23 13:37:10 -04:00
a5e1415e74
InputCommon: Migrate logging over to fmt
...
Continues the migration of the logging calls over to the fmt capable
ones.
2020-10-23 13:16:18 -04:00
7841fb7337
DolphinQt: Move QT_LAYOUT_DIRECTION string to qt-strings.pot
...
Now that we have a .pot file specifically for strings from
Qt itself, it makes sense to move this into it.
2020-10-23 18:45:35 +02:00
64f7a4448b
Merge pull request #9178 from lioncash/disclog
...
DiscIO: Migrate logging over to fmt
2020-10-22 22:07:53 +02:00
e93fbb7c5e
DiscIO: Migrate logging over to fmt
...
Eliminates quite a bit of the PRI* macros used for handling 64-bit
values.
2020-10-22 15:41:42 -04:00
e8bb88c2a1
DolphinQt: Don't call UICommon::InhibitScreenSaver if already in desired state.
2020-10-22 13:19:01 -05:00
4807a5e157
VideoCommon: FrameDump fixes/cleanups.
2020-10-22 12:17:26 -05:00
89b01cd6d3
Merge pull request #9169 from lioncash/uber-vert
...
UberShaderVertex: Migrate over to fmt
2020-10-22 01:21:31 +02:00
08f9ed043b
Merge pull request #8846 from nyanpasu64/fix-cmake-zlib
...
Fix Windows CMake builds with shared zlib
2020-10-22 01:11:27 +02:00
96ce3e5f49
Merge pull request #9176 from lioncash/audiofmt
...
AudioCommon: Migrate logging over to fmt
2020-10-22 01:03:16 +02:00
88bc32b638
Explain how to fix "Serial and/or version data is missing"
2020-10-21 15:39:26 -07:00
dcb0c910af
Common/Matrix: Allow TVec classes to be used in constexpr contexts
...
Much of these classes are operating on integral types and are pretty
standard behavior as far as vectors go. Some member functions can be
made constexpr to make them more flexible and allow them to be used in
constexpr contexts.
2020-10-21 17:44:02 -04:00
de96fe0860
Merge pull request #9162 from jordan-woyak/quaternion
...
Replace stateful rotational matrices with quaternions.
2020-10-21 17:34:11 -04:00
e553197c67
Merge pull request #8880 from AdmiralCurtiss/gcmemcard-sketchy-code-cleanup
...
Sketchy code cleanup in GCMemcard and GCMemcardDirectory.
2020-10-21 23:13:22 +02:00
21d3ea523c
Android: Show how long ago each savestate was created
2020-10-21 22:49:59 +02:00
7b9a464c93
Merge pull request #8895 from sepalani/card
...
GCMemcard: Rename unknown field to m_dtv_status
2020-10-21 22:32:09 +02:00
18b2553538
Merge pull request #9078 from JosJuice/android-metadata-from-core
...
Android: Get game metadata from core
2020-10-21 22:29:21 +02:00
d08b80828d
VideoCommon: Simplify VideoBackendBase::GetDefaultBackendName
...
Now we can just call GetDefaultVideoBackend to get the default backend
and get its name by calling GetName.
2020-10-21 22:00:10 +02:00
aaaa3896c0
VideoCommon: Get rid of the global g_available_video_backends
...
Replace it with a function-local static that is initialized on first
use. This gets rid of a global variable and removes the need for
manual initialization in UICommon.
This commit also replaces the weird find_if that looks for a non-null
unique_ptr with a simple "is vector empty" check considering that
none of the pointers can be null by construction.
2020-10-21 22:00:10 +02:00
e86d713600
Android: Attach CPU thread to JVM early
2020-10-21 21:10:28 +02:00
fd5f9f4c26
Merge pull request #8927 from Filoppi/wiimote-pan-fix
...
Fixed volume of emulated wii mote speakers not being native.
2020-10-21 21:02:39 +02:00
cf8b52735f
Fix volume of emulated wii mote speakers not being native
...
As in the comment, the panning was denaturalizing the volume (when the panning was at 0).
Unless users actually want to use panning, their wii mote volume should not be reduced, it should come out at the same volume the samples were.
If users want to reduce the volume of the wii mote speakers, they can do so from the wii home menu.
I opted for this instead of adding another setting "Enable Panning" as it would have been confusing, and the changes in the panning formula are unlikely to have any negative effect, as it still works.
2020-10-21 20:54:21 +02:00
97de366b0f
Merge pull request #9160 from jordan-woyak/xinput2-stuck-keys
...
Linux/XInput2: Fix keys being stuck pressed on focus loss.
2020-10-21 20:47:32 +02:00
3a0917371e
Android: Don't show game ID after game title
2020-10-21 20:02:52 +02:00
b6fcfcb9c9
Core: Always call Host_TitleChanged on boot
...
A title change to a title with no game ID is still a title change.
2020-10-21 19:57:27 +02:00
1ddf7277b9
Core: Set bWii before calling Host_TitleChanged
2020-10-21 19:57:27 +02:00
22a79289d3
AudioCommon: Migrate logging over to fmt
...
printf specifiers, begone!
2020-10-21 13:32:28 -04:00
09e87b79f1
Merge pull request #9173 from lioncash/fmtlog
...
Common/Log: Add basic fmt-capable functions to the interface.
2020-10-21 19:11:19 +02:00
425f2aa013
Common/Log: Add basic fmt-capable functions to the interface.
...
Provides a basic extension to the interface to begin migration off of
the printf-based logging system.
Everything will go through macros with the same style naming as the old
logging system, except the macros will have the _FMT suffix, while the
migration is in process.
This allows for peacemeal migration over time instead of pulling
everything out and replacing it all in a single pull request, which
makes for much easier reviewing.
2020-10-21 10:49:35 -04:00
f265c412b4
Merge pull request #9152 from Ebola16/SP1
...
Android: Convert SharedPreferences to INI Settings (simple cases)
2020-10-21 16:48:18 +02:00
642eccbfd0
Merge pull request #9174 from lioncash/os
...
Common: Move OSThreads into Core
2020-10-21 15:39:29 +02:00
57534777d4
Common: Move OSThreads into core
...
Common shouldn't be depending on APIs in Core (in this, case depending
on the PowerPC namespace). Because of the poor separation here, this
moves OSThread functionality into core, so that it resolves the implicit
dependency on core.
2020-10-21 07:35:42 -04:00
144f799bbb
ARDecrypt: Resolve seedtable at compile-time
...
We can boot the formation of the table off to the compiler at
compile-time, rather than building the table at run-time.
2020-10-20 19:11:04 -04:00
7e197186b9
Merge pull request #9172 from lioncash/compile
...
ExpressionParser: Add missing <functional> include
2020-10-20 15:23:14 -05:00
faf509e315
ExpressionParser: Add missing <functional> include
...
Unbreaks Windows CMake builds.
2020-10-20 16:18:32 -04:00
353a67824d
Android: Add AndroidOverlayButtons INI section
2020-10-20 12:03:41 -04:00
751d67a59a
UberShaderVertex: Migrate over to fmt
...
Continues migration of the shader generators over to fmt.
With this, all that's left to move over are the pixel shaders (regular
and ubershader variants)
2020-10-20 09:24:10 -04:00
ce59b026c0
Merge pull request #9168 from lioncash/ifconst
...
DataReader: Make use of if constexpr where applicable
2020-10-20 14:56:24 +02:00
299adf537d
Merge pull request #9021 from AdmiralCurtiss/gui-memcard-format-sram
...
Qt/GCMemcardCreateNewDialog: Use zero values for formatting instead of accessing g_SRAM.
2020-10-20 14:55:23 +02:00
70ab3bf7b3
Merge pull request #9025 from cyrozap/fix-build-with-older-cmake
...
Fix builds with system LZMA when using versions of CMake before 3.14
2020-10-20 14:51:15 +02:00
7bc2bbc508
DataReader: Make use of if constexpr where applicable
...
We can make use of if constexpr for cases where booleans will always
statically be known at compile-time.
2020-10-20 08:42:32 -04:00
dc5ae5ee66
Merge pull request #9165 from lioncash/ubercommon
...
UberShaderCommon: Migrate over to fmt
2020-10-20 14:42:19 +02:00
f653bd7559
Merge pull request #9142 from jordan-woyak/expose-fov
...
WiimoteEmu: Expose IR camera FOV to adjust IMU pointing sensitivity.
2020-10-20 14:32:02 +02:00
b2709b81a0
Merge pull request #9166 from JosJuice/encryption-cache-move
...
DiscIO: Make WiiEncryptionCache moveable
2020-10-20 14:29:46 +02:00
2e86e1a998
Merge pull request #9146 from JosJuice/android-disable-cover-download
...
Android: Allow disabling cover downloading
2020-10-20 13:31:01 +02:00
49b7f10b39
Merge pull request #9163 from lioncash/fbgen
...
FramebufferShaderGen: Migrate over to fmt
2020-10-20 13:25:50 +02:00
83db7a707c
UberShaderCommon: Migrate over to fmt
...
Continues migration of the shader generators over to fmt.
2020-10-20 06:22:48 -04:00
7b1e0dba9b
Merge pull request #9164 from lioncash/geoshader
...
GeometryShaderGen: Migrate over to fmt
2020-10-20 11:59:45 +02:00
5b6f604d90
DiscIO: Make WiiEncryptionCache moveable
...
Fixes the following warning:
../../../../../../Core\DiscIO/DirectoryBlob.h:156:3: warning: explicitly defaulted move constructor is implicitly deleted [-Wdefaulted-function-deleted]
DirectoryBlobReader(DirectoryBlobReader&&) = default;
^
../../../../../../Core\DiscIO/DirectoryBlob.h:205:22: note: move constructor of 'DirectoryBlobReader' is implicitly deleted because field 'm_encryption_cache' has a deleted move constructor
WiiEncryptionCache m_encryption_cache;
^
2020-10-20 11:33:38 +02:00
fc3b474cce
Merge pull request #8318 from iwubcode/dynamic_input_textures
...
InputCommon: Dynamic Input Textures
2020-10-20 02:10:29 +02:00
911704611e
Merge pull request #9096 from jordan-woyak/calibration-cleanup
...
ControllerEmu: Improve and simplify UpdateCalibrationData.
2020-10-20 02:01:16 +02:00
98875346bd
Merge pull request #9104 from JosJuice/cmd-unicode
...
DolphinQt: Handle non-ASCII characters in Windows cmd arguments
2020-10-20 01:45:28 +02:00
680ff4d168
Merge pull request #9136 from JosJuice/volumeverifier-partition-invalid-override
...
VolumeVerifier: Make "no valid data in partition" hide some other errors
2020-10-20 01:39:18 +02:00
5475a8d6eb
GeometryShaderGen: Migrate over to fmt
...
Continues migration of the shader generators over to fmt.
2020-10-19 19:22:02 -04:00
8a8dc3db83
Merge pull request #8613 from jordan-woyak/expose-disable-ss
...
Config: Expose "DisableScreenSaver" in the UI and default it to true.
2020-10-20 01:20:24 +02:00
df11615bde
FramebufferShaderGen: Migrate over to fmt
...
Continures the migration of the shader generators over to fmt.
2020-10-19 18:49:01 -04:00
1dae834c62
WiimoteEmu: Tweak IMUCursor total yaw setting tool-tip.
2020-10-19 17:08:02 -05:00
6b2eebf1f9
WiimoteEmu: Expose IR camera FOV to adjust IMU pointing sensitivity.
2020-10-19 17:08:02 -05:00
907fdd26fc
WiimoteEmu: Use quaternions for orientation.
2020-10-19 16:34:45 -05:00
09431635f3
InputCommon/WiimoteEmu: Replace stateful rotational matrices with quaternions.
2020-10-19 16:33:55 -05:00
39030ea33c
Common/Matrix: Add Quaternion class.
2020-10-19 16:18:31 -05:00
bb03280462
VolumeVerifier: Make "no valid data in partition" hide some other errors
...
Not much use in knowing that the H3 hashes are wrong when the
partition consists of complete garbage.
2020-10-19 21:15:49 +02:00
b93adeaad7
VertexShaderGen: Fix unescaped { in D3D shader.
2020-10-19 20:05:07 +02:00
5e70dda4cc
Android: Allow disabling cover downloading
...
In case someone wants to be very careful with how much bandwidth
they use or with what data GameTDB.com collects on you.
This is already an option in DolphinQt (though in DolphinQt it
will switch entirely from using covers to banners when turned off).
2020-10-19 20:03:47 +02:00
bbb12a7560
Linux/XInput2: Fix keys being stuck pressed on focus loss.
2020-10-19 11:46:01 -05:00
cb14b65aad
CMake: Fix build errors exposed by making common dependent on fmt
2020-10-19 14:36:09 +02:00
1084cfec1a
Add helper function for fmt::format(GetStringT(...
2020-10-19 14:36:08 +02:00
d100c1dc37
DiscIO: Make use of fmt where applicable
...
Once nice benefit of fmt is that we can use positional arguments
in localizable strings. This a feature which has been
requested for the Korean translation of strings like
"Errors were found in %zu blocks in the %s partition."
and which will no doubt be useful for other languages too.
2020-10-19 14:30:47 +02:00
c9b2fbb64b
Merge pull request #9099 from sepalani/so-linger
...
IP/Top: Add SO_LINGER optname
2020-10-19 07:58:51 -04:00
abfae46a2c
Merge pull request #9100 from sepalani/gethostid-log
...
IP/Top: Log IOCTL_SO_GETHOSTID properly
2020-10-19 07:58:15 -04:00
49c7a5b289
Merge pull request #9121 from Sammi-Husky/bat-registers
...
DolphinQt/Debugger: Fix DBAT and IBAT registers in RegisterWidget
2020-10-19 07:56:42 -04:00
fc5fbf5134
Merge pull request #9127 from Sintendo/fselx-movsd
...
Jit64: Optimize fsel a bit more
2020-10-19 07:55:40 -04:00
cec47b9c32
Merge pull request #8981 from lioncash/vtx-fmt
...
LightingShaderGen/VertexShaderGen: Migrate over to fmt
2020-10-19 07:52:55 -04:00
5722c680a4
Merge pull request #8006 from JosJuice/qt-rtl
...
DolphinQt: Enable RTL layout
2020-10-19 07:46:40 -04:00
0de6a32f4c
Qt/QtUtils: Fix accidental recursion in ParallelProgressDialog
...
Seems to be a typo.
2020-10-19 12:39:10 +02:00
b3cb08830b
Merge pull request #9155 from JosJuice/tas-slider-right-click
...
DolphinQt: Reset TAS input slider to default on right-click
2020-10-19 12:09:23 +02:00
50ec747840
Clean up screen saver inhibition and apply setting change immediately.
2020-10-18 16:31:48 -05:00
fa83a3a114
DolphinQt: Expose "DisableScreenSaver" setting in the UI.
2020-10-18 16:31:46 -05:00
50384cfab7
Config: Make "DisableScreenSaver" default to true.
2020-10-18 12:26:00 -05:00
6670226a44
DolphinQt: Reset TAS input slider to default on right-click
...
This is a feature which existed in DolphinWX. Seems like it got
implemented in DolphinQt for IRWidget/StickWidget but not sliders.
2020-10-18 13:47:00 +02:00
af2a881a85
Source/Core/DiscIO/WIACompression.cpp: add missing <limits> include
...
Noticed missing include as a build failure on gcc-11:
```
[ 26%] Building CXX object Source/Core/DiscIO/CMakeFiles/discio.dir/WIACompression.cpp.o
../../../../Source/Core/DiscIO/WIACompression.cpp: In lambda function:
../../../../Source/Core/DiscIO/WIACompression.cpp:170:31: error: 'numeric_limits' is not a member of 'std'
170 | std::min<size_t>(std::numeric_limits<unsigned int>().max(), x));
| ^~~~~~~~~~~~~~
../../../../Source/Core/DiscIO/WIACompression.cpp:170:46: error: expected primary-expression before 'unsigned'
170 | std::min<size_t>(std::numeric_limits<unsigned int>().max(), x));
| ^~~~~~~~
```
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
2020-10-15 19:56:53 +01:00
ab2e226df8
Merge pull request #9105 from JosJuice/volumeverifier-small-low-severity
...
VolumeVerifier: Make high severity "too small" hide low severity "too small"
2020-10-14 12:41:57 +02:00
c3cdac4863
Merge pull request #9137 from JosJuice/zstd-ram-usage
...
DiscIO: Decrease RAM usage during zstd compression
2020-10-14 12:35:38 +02:00
b24223c178
Merge pull request #9135 from JosJuice/show-nkit
...
Show NKitness in file format string
2020-10-14 12:19:53 +02:00
5ab95d7f6a
Merge pull request #9145 from jordan-woyak/sound-touch-defaults
...
AudioStretcher: Keep default parameters.
2020-10-14 12:16:58 +02:00
3e6599b890
AudioStretcher: Keep default parameters.
2020-10-11 12:43:45 -05:00
5a939ccfaf
Merge pull request #8833 from Ebola16/Panic
...
Android: Use DialogFragment for AlertMessage
2020-10-10 21:03:52 +02:00
0c01712d13
DriverDetails: Remove bug for broken GPU Texture Decoding
2020-10-08 10:13:40 -04:00
de2d099200
Re-enable GPU Texture Decoding under MoltenVK
2020-10-08 10:11:02 -04:00
3feea108db
DiscIO: Decrease RAM usage during zstd compression
...
By calling ZSTD_CCtx_setPledgedSrcSize, we can let zstd know
how large a chunk is going to be before which start compressing
it, which lets zstd avoid allocating more memory than needed
for various internal buffers. This greatly reduces the RAM usage
when using a high compression level with a small chunk size,
and doesn't have much of an effect in other circumstances.
A side effect of calling ZSTD_CCtx_setPledgedSrcSize is that
zstd by default will write the uncompressed size into the
compressed data stream as metadata. In order to save space,
and since the decompressed size can be figured out through
the structure of the RVZ format anyway, we disable writing
the uncompressed size by setting ZSTD_c_contentSizeFlag to 0.
2020-10-07 16:40:06 +02:00
d64fc67b04
Show NKitness in file format string
...
To make people more aware that they're not using a normal disc image.
2020-10-06 19:35:00 +02:00
63f5fa6e19
Replace geckocodes.org with mirror codes.rc24.xyz
2020-10-05 22:18:04 +02:00
c2975c8cb5
Merge pull request #9131 from JosJuice/nkit-mgs
...
Add Metal Gear Solid: The Twin Snakes to NKit warning message
2020-10-05 10:50:48 -04:00
568f226937
Add Metal Gear Solid: The Twin Snakes to NKit warning message
...
Unlike Super Paper Mario, this game doesn't crash as soon as you
try to start it, but rather if you try to skip a certain cutscene.
Thanks to JMC for letting me know about this.
2020-10-04 12:22:27 +02:00
4fff04db3c
Core: Load custom textures after inputs has been loaded and avoid sending force texture reload during startup for dynamic textures. This ensures that custom texture loading only happens once and users don't see any weird flashes on startup
2020-10-03 17:10:36 -05:00
fd3af4c5d3
InputCommon: Introducing the "Dynamic Input Texture". Configuration links an emulated input action to an image based on what host key is defined for that emulated input. Specific regions are called out in configuration that mark where to replace an input button with a host key image.
2020-10-03 17:10:35 -05:00
8a1539f948
VideoCommon: Make a reusable free function for getting top level directories that have a matching gameid text file underneath
2020-10-03 17:10:35 -05:00
3499cedde4
Jit64: fselx - Skip MOVAPS + MOVSD (SSE4.1)
...
For the non-packed variant of this instruction, a MOVSD instruction was
generated to copy only the lower 64 bits of XMM1 to the destination
register. This was done in order to keep the destination register's
upper half intact.
However, when register c and the destination register are the same,
there is no need for this copy. Because the registers match and due to
the way the mask is generated, BLENDVPD will end up taking the upper
half from the destination register, as intended.
Additionally, the MOVAPS to copy Rc into XMM1 can also be skipped.
Before:
66 0F 57 C0 xorpd xmm0,xmm0
F2 41 0F C2 C6 06 cmpnlesd xmm0,xmm14
41 0F 28 CE movaps xmm1,xmm14
66 41 0F 38 15 CA blendvpd xmm1,xmm10,xmm0
F2 44 0F 10 F1 movsd xmm14,xmm1
After:
66 0F 57 C0 xorpd xmm0,xmm0
F2 41 0F C2 C6 06 cmpnlesd xmm0,xmm14
66 45 0F 38 15 F2 blendvpd xmm14,xmm10,xmm0
2020-10-03 18:28:41 +02:00
9ac324aed3
Jit64: fselx - Skip MOVSD (AVX)
...
For the non-packed variant of this instruction, a MOVSD instruction was
generated to copy only the lower 64 bits of XMM1 to the destination
register. This was done in order to keep the destination register's
upper half intact.
However, when register c and the destination register are the same,
there is no need for this copy. Because the registers match and due to
the way the mask is generated, VBLENDVPD will end up taking the upper
half from the destination register, as intended.
Before:
66 0F 57 C0 xorpd xmm0,xmm0
F2 41 0F C2 C6 06 cmpnlesd xmm0,xmm14
C4 C3 09 4B CA 00 vblendvpd xmm1,xmm14,xmm10,xmm0
F2 44 0F 10 F1 movsd xmm14,xmm1
After:
66 0F 57 C0 xorpd xmm0,xmm0
F2 41 0F C2 C6 06 cmpnlesd xmm0,xmm14
C4 43 09 4B F2 00 vblendvpd xmm14,xmm14,xmm10,xmm0
2020-10-03 18:28:27 +02:00
a8df2caba9
Merge pull request #9125 from stenzek/vulkan-validation
...
Vulkan: Use VK_LAYER_KHRONOS_validation for validation
2020-10-02 20:18:13 +10:00
ee13e6ec80
Improved responsiveness when refreshing game list.
2020-10-01 22:10:16 +02:00
4ca92464c0
**Refresh** and **Purge Game List Cache** now correctly enabled/disabled as notified by GameListRefreshRequested and GameListRefreshCompleted.
2020-10-01 22:09:45 +02:00
bada677c5a
Avoid using unnecessary RunOnObject() calls in GameTracker's worker thread to prevent deadlocks on shutdown.
2020-10-01 22:09:45 +02:00
dc7b92651f
Ensured that GameTracker's internal worker thread is flushed on exit to avoid crashes when accessing stale, already-destroyed data, and to favor responsiveness.
2020-10-01 22:09:45 +02:00
213610e95d
Extended WorkQueueThread class with Clear(), Cancel() and IsCancelled().
2020-10-01 22:09:45 +02:00
5b757024c4
GameListModel instance ownership transferred back to the GameList instance. The GameListModel instance will be passed as a constructor parameter where needed.
2020-10-01 22:09:45 +02:00
0d02e70d4a
Removed all references to GameListModel from the Settings component.
2020-10-01 22:09:45 +02:00
6675186520
Socket: Set SO_NOSIGPIPE on macOS
2020-10-01 13:25:34 +04:00
24bb947eff
Vulkan: Use VK_LAYER_KHRONOS_validation for validation
...
VK_LAYER_LUNARG_standard_validation is deprecated.
2020-10-01 17:21:46 +10:00
31524288e3
Merge pull request #9116 from jordan-woyak/fix-wm-netplay
...
Core/NetPlay: Fix Wii Remote syncing.
2020-09-30 17:42:30 -04:00
fa866062ca
DolphinQt/Debugger: Fix DBAT and IBAT registers in RegisterWidget
2020-09-29 22:11:21 -07:00
ebdcddfcd0
Merge pull request #9120 from JosJuice/controller-defaults
...
Fix controller defaults being empty on fresh run
2020-09-29 18:38:11 -04:00
623340bbbb
Fix controller defaults being empty on fresh run
...
A very early call to Config::Save is now creating empty
controller INI files.
https://bugs.dolphin-emu.org/issues/12283
2020-09-29 21:49:22 +02:00
0295d470b1
ControllerEmu: Increase "IMUPointer" "Total Yaw" default value to match that of regular "Point" settings.
...
Removed "Total Yaw" from included Wii remote input profile to take on the default value.
2020-09-28 18:09:34 -05:00
f766c89a08
ControllerEmu: Increase Total Yaw/Pitch default values to compensate for new FOV and to reach screen edges in the Wii Menu.
2020-09-28 18:09:34 -05:00
f9280d0f66
ControllerInterface/Wiimote: Add "IR Distance" input providing a calculated distance from sensor bar in meters.
2020-09-28 18:09:34 -05:00
761f7798c9
WiimoteEmu: Increase Camera FOV constants to 42 by 31.5 degrees.
2020-09-28 18:09:34 -05:00
1063c4e940
MathUtil: Add Population (vs Sample) versions of Variance and StandardDeviation to RunningVariance.
2020-09-28 18:09:33 -05:00
8f8509afc3
Core/NetPlay: Fix Wii Remote syncing.
2020-09-27 13:10:19 -05:00
6cb14a9a54
Merge pull request #9115 from jordan-woyak/default-modifiers
...
Core: Unbreak default keyboard mappings.
2020-09-26 10:20:57 -05:00
24771aac5a
Core: Unbreak default keyboard mappings.
2020-09-26 08:25:56 -05:00
aea0239071
Merge pull request #9109 from stenzek/msaa-efb-readback
...
FramebufferManager: Fix EFB readbacks with MSAA on
2020-09-26 17:46:16 +10:00
431eb4d60d
ExpressionParser: Improve hotkey suppression logic. Allow activation with simultaneous press of modifier and final input.
2020-09-25 22:51:33 -05:00
44927da420
ExpressionParser: Replace ScopeGuard with custom deleter unique_ptr.
2020-09-25 22:51:33 -05:00
48b76ff90f
InputCommon: Improve input detection to produce buton combinations.
2020-09-25 22:51:32 -05:00
d8ad8c3861
InputCommon: Make hotkeys and input detection aware of Ctrl -> L_Ctrl / R_Ctrl hierarchy.
2020-09-25 20:29:18 -05:00
aae913fbc6
InputCommon: Clean up modifier ignoring logic.
2020-09-25 20:29:18 -05:00
f7bf26cd60
Core: Clean up default hotkey expressions.
2020-09-25 20:29:18 -05:00
f015c99a51
ControllerInterface: Add platform consistent names for modifier keys.
2020-09-25 20:29:18 -05:00
d2729df281
ExpressionParser: Allow duplicate and superset modifier hotkeys to function.
2020-09-25 20:29:18 -05:00
b3acc7403f
InputCommon: Support detecting combinations of inputs. (Hotkeys)
2020-09-25 20:29:18 -05:00
e6ba495486
ExpressionParser: Suppress inputs when hotkey modifiers are pressed.
2020-09-25 20:29:18 -05:00
52547379c9
ExpressionParser: Add Hotkey syntax.
2020-09-25 20:29:18 -05:00
991eb6ae83
Android: Use DialogFragment for AlertMessage
2020-09-25 11:50:04 -04:00
880f7ca6bb
FramebufferManager: Fix EFB readbacks with MSAA on
...
Regression from #8827 .
2020-09-25 20:58:02 +10:00
a9b15dfe3c
Merge pull request #9107 from JosJuice/qt-disc-0
...
DolphinQt: Use 1-based disc numbering in InfoWidget
2020-09-23 12:29:15 -04:00
54e570a95f
Merge pull request #8902 from JosJuice/android-convert
...
Android: Add disc image conversion
2020-09-23 12:27:43 -04:00
0ddd296cd9
DolphinQt: Use 1-based disc numbering in InfoWidget
2020-09-23 11:42:22 +02:00
402643fe4c
VolumeVerifier: Call CheckDiscSize from Finish
2020-09-23 11:19:03 +02:00
f33767f19c
Merge pull request #9088 from JosJuice/android-sysconf
...
Android: Add Wii SYSCONF settings to GUI
2020-09-22 14:03:56 -04:00
4f62960fb1
VolumeVerifier: Make high severity "too small" hide low severity "too small"
2020-09-21 21:00:04 +02:00
17e02838b0
DolphinQt: Stop using qtmain
2020-09-21 17:27:10 +02:00
16d2ef1ea9
DolphinQt: Handle non-ASCII characters in Windows cmd arguments
...
CommandLineParse expects UTF-8 strings. (QApplication, on the
other hand, seems to be designed so that you can pass in the
char** argv untouched on Windows and get proper Unicode handling.)
2020-09-21 17:26:29 +02:00
8488eb9793
IP/Top: Log IOCTL_SO_GETHOSTID properly
2020-09-20 20:46:49 +04:00
50b5224d06
Merge pull request #8840 from Techjar/evdev-combining-phys
...
ControllerInterface: Combine evdev devices with the same physical location in addition to unique ID
2020-09-20 09:28:09 -05:00
faa1eb71ef
IP/Top: Add SO_LINGER optname
2020-09-20 11:40:25 +04:00
8587ebba86
WiimoteReal: Only duplicate data reports when speaker data is enabled.
2020-09-19 20:04:27 -05:00
2e753abcc9
Update state version.
2020-09-19 18:02:25 -05:00
32ef8a46a1
Core/BTEmu: Change a member variable to a local variable.
2020-09-19 18:00:22 -05:00
0ca73355a8
ControllerEmu: Improve and simplify UpdateCalibrationData.
2020-09-19 08:40:55 -05:00
29460b946e
Qt/MappingWindow: Add support for built-in profiles
2020-09-18 06:32:42 -04:00
6ada03fca2
Merge pull request #9075 from JosJuice/android-osd-left-margin
...
Android: Move OSD out of the way when menu is open
2020-09-16 16:42:04 -04:00
655308255e
Merge pull request #9073 from darkain/patch-1
...
Adding AmdPowerXpressRequestHighPerformance
2020-09-16 15:56:04 -04:00
7749e8c10c
Only automatically override SYSCONF settings when it has an effect
...
Any call to Config::SetCurrent will cause the relevant setting
to show up as overridden in the Android GUI, which can be confusing,
so let's not do it when the new value is the same as the original.
2020-09-16 20:34:14 +02:00
f01ccfdb82
Android: Only allow conversion when appropriate
2020-09-16 18:48:25 +02:00
3805b84906
Android: Add content provider support to File::Delete
2020-09-16 18:38:53 +02:00
6e1e6d2311
Android: Add content provider support to File::IOFile
...
Taking the hit now to prepare us for when Google Play will
force us to use scoped storage...
2020-09-16 18:38:53 +02:00
ca46028cde
DiscIO: Use std::function for compression callback
2020-09-16 18:36:50 +02:00
161f99b864
Android: Move OSD out of the way when menu is open
...
https://bugs.dolphin-emu.org/issues/12256
2020-09-16 18:36:15 +02:00
9c97654603
Config: Add SYSCONF to IsSettingSaveable
...
SYSCONF very much is saveable. Whether it's in IsSettingSaveable
or not hasn't mattered until now since the SYSCONF settings use
separate config loader code that doesn't check IsSettingSaveable,
but the next commit will require SYSCONF to be marked as saveable.
2020-09-16 12:15:50 +02:00
e4e50691fb
Merge pull request #9086 from JosJuice/wiimote-init-order
...
Core: Run Wiimote::Initialize before HW::Init to avoid crash
2020-09-16 02:26:17 -04:00
e0117a86ad
Merge pull request #8819 from JosJuice/panic-alert-deadlock-pause-on-focus-loss
...
DolphinQt: Fix the panic alert deadlock, Pause on Focus Loss edition
2020-09-15 11:46:46 -04:00
de7ef47548
Core: Run Wiimote::Initialize before HW::Init to avoid crash
...
Fixes a crash on Android (probably nogui too?) caused by PR 8985:
std::__ndk1::__throw_out_of_range(char const*) stdexcept:265
std::__ndk1::__vector_base_common<true>::__throw_out_of_range() const vector:319
InputConfig::GetController(int) InputConfig.cpp:160
WiimoteCommon::GetHIDWiimoteSource(unsigned int) Wiimote.cpp:71
IOS::HLE::WiimoteDevice::WiimoteDevice(IOS::HLE::Device::BluetoothEmu*, int, std::__ndk1::array<unsigned char, 6ul>) WiimoteDevice.cpp:71
IOS::HLE::Device::BluetoothEmu::BluetoothEmu(IOS::HLE::Kernel&, std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&) BTEmu.cpp:64
IOS::HLE::Kernel::AddStaticDevices() IOS.cpp:435
IOS::HLE::Init() IOS.cpp:837
Core::EmuThread(std::__ndk1::unique_ptr<BootParameters, std::__ndk1::default_delete<BootParameters> >, WindowSystemInfo) Core.cpp:442
2020-09-15 12:19:00 +02:00
9e3c08394a
Merge pull request #9085 from Techjar/better-monospace
...
Qt: Use better method of getting default monospace font
2020-09-15 05:01:15 -04:00
601ff182db
Merge pull request #9084 from Techjar/custom-rtc-tz-fix
...
Qt/AdvancedPane: Force UTC time for custom RTC entry
2020-09-15 04:58:26 -04:00
0759ead9b6
Qt: Use better method of getting default monospace font
...
This should give us a nicer font on Windows, while also not severely
impacting the existing behavior on Linux.
2020-09-15 04:48:44 -04:00
4d15fb62d9
Qt/AdvancedPane: Force UTC time for custom RTC entry
2020-09-14 22:09:14 -04:00
4f1f849c9d
Merge pull request #8985 from jordan-woyak/btemu-cleanup
...
BTEmu/Wiimote: Fixes and Cleanups.
2020-09-14 02:09:27 -04:00
2bb7d207b7
DolphinQt: fix other widgets that use lambdas (capturing this) without setting the receiver
2020-09-12 17:53:17 -05:00
a83bf8bc59
DolphinQt: properly remove slot connection for ConfigChange when object is destructed
2020-09-12 17:35:58 -05:00
1335df8eb5
Merge pull request #9039 from shuffle2/bt-dll
...
windows: keep an extra reference to BluetoothApis.dll
2020-09-11 04:28:55 -04:00
dcbe9da279
Merge pull request #8743 from Techjar/apple-pls-support-standard-api
...
VideoBackends: Disable GPU Texture Decoding under MoltenVK
2020-09-10 09:54:11 -04:00
4e443ed857
Adding AmdPowerXpressRequestHighPerformance
...
Adding AmdPowerXpressRequestHighPerformance
This will allow AMD drivers to detect the request to use the dGPU instead of the iGPU on compatible hybrid graphics systems.
Reference: https://community.amd.com/thread/169965
2020-09-09 22:09:34 -07:00
c74ea6696e
Settings: Fix incorrect config key for enabled analytics.
2020-09-09 20:19:30 +02:00
a31c204ca8
Merge pull request #8765 from AdmiralCurtiss/jit-reuse-memory
...
Jit64 codegen space reuse.
2020-09-09 08:16:09 -04:00
2bfbc4d79f
cmake: Silence warnings.
2020-09-08 21:18:40 -07:00
8423f848d0
ControllerInterface: Combine evdev devices with the same physical location in addition to unique ID
2020-09-08 18:52:15 -04:00
3d33b1c2c5
Merge pull request #9060 from Pokechu22/ignore-pi-reset-code
...
Ignore PI_RESET_CODE resetting DI in Wii mode
2020-09-08 01:56:19 -04:00
b350cf043b
Merge pull request #8976 from JosJuice/port-some-settings
...
Port some settings to the new config system
2020-09-07 22:37:46 -04:00
fa91b47863
Merge pull request #9054 from sepalani/hle-cleanup
...
HLE cleanup
2020-09-07 22:36:19 -04:00
8e505ad8d5
Merge pull request #9055 from JosJuice/gc-sample-rate
...
AudioInterface: Use 32029/48043 Hz in more places
2020-09-07 22:35:00 -04:00
48cfc32bf3
Merge pull request #8935 from JosJuice/di-read-latency
...
DVDInterface: Increase the latency for read commands
2020-09-07 22:31:18 -04:00
69358b2186
VideoBackends: Disable GPU Texture Decoding under MoltenVK
...
It's broken and causes spectacular artifacts and crashes.
2020-09-07 17:28:05 -04:00
e7e5175606
Merge pull request #8861 from JosJuice/netplay-hash
...
Make netplay's "same game" check more robust
2020-09-06 17:14:08 -04:00
bd44106fec
AudioCommon: Get initial sample rates from AudioInterface
2020-09-06 15:37:20 +02:00
c8c4ec28ce
Merge pull request #8644 from JosJuice/rework-tgc
...
DiscIO: Rework the implementation of TGC reading
2020-09-06 07:06:26 -04:00
6eefc3c524
Make default graphics backend not show up as empty
...
Fixes https://bugs.dolphin-emu.org/issues/12245 .
I considered making a change to DolphinQt instead of
the core, but then additional effort would've been
required to add the same fix to the Android GUI once
we start using the new config system there.
2020-09-06 12:56:45 +02:00
8142712c88
Ignore PI_RESET_CODE resetting DI in Wii mode
...
Fixes bug 12241
2020-09-04 16:54:00 -07:00
db067104ed
Merge pull request #9047 from JosJuice/wia-header-heuristic
...
DiscIO: Adjust WIA/RVZ header size heuristic
2020-09-01 17:58:51 -04:00
936702bd04
Merge pull request #9033 from leoetlino/scan-thread
...
IOS/USB: Move scan thread logic into a separate class
2020-09-01 17:56:33 -04:00
c63ac38c83
Socket: Abort pending operations on shutdown
2020-09-01 19:26:44 +04:00
42a7c959e1
Merge pull request #9056 from JosJuice/supportsreadwiidecrypted-parameter
...
DiscIO: Add parameters to BlobReader::SupportsReadWiiDecrypted
2020-09-01 07:25:31 -04:00
6bd7687893
Merge pull request #9050 from stblr/memory-watcher-fix
...
MemoryWatcher: Do not follow invalid pointers
2020-09-01 07:24:05 -04:00
bdd28c0edf
DiscIO: Expand WIA/RVZ header size heuristic comments
2020-08-31 14:46:13 +02:00
e0b64e0ef8
Merge pull request #9049 from Ebola16/GCAC
...
GCAdapter_Android: Minor cleanup
2020-08-30 19:48:07 -05:00
e601bc5532
windows: keep an extra reference to BluetoothApis.dll
2020-08-30 17:46:32 -07:00
0a63340c20
Merge pull request #9037 from shuffle2/code-cleanup
...
Code cleanup
2020-08-30 19:43:23 -05:00
ff168469b7
MemoryWatcher: Do not follow invalid pointers
2020-08-30 10:29:40 +02:00
047bb80337
DiscIO: Add parameters to BlobReader::SupportsReadWiiDecrypted
...
It's possible (but rare) for a WIA or RVZ file to support
this for some partitions but not all, and for the game and
the blob code to disagree on how large a partition is.
2020-08-29 15:18:52 +02:00
1a1b89e7e8
AudioInterface: Use 32029/48043 Hz in more places
...
In particular, I wanted to do change this in
AudioInterface::Init so that dumped GC audio doesn't need
to have a file split (changing from 32000 Hz to 32029 Hz)
when the emulated software initializes the AI registers.
I've also made the same change to DI's DTK code.
2020-08-29 13:24:39 +02:00
4c75b96254
HLE: Improve naming
...
Replace 'function' with 'hook' when appropriate
2020-08-28 20:29:05 +04:00
969ea6e4f5
msvc: enable /Zc:preprocessor and make build compile cleanly
2020-08-27 21:58:48 -07:00
4db06bf85b
ogl: init ProgramShaderCache::s_ubo_align to 1.
...
silences a warning that it may cause div-by-zero.
2020-08-27 15:15:52 -07:00
d35514399e
msbuild: fix a typo
2020-08-27 15:15:52 -07:00
5981a1929d
Add support for FreeBSD/arm64
2020-08-27 21:54:04 +01:00
17ad2ac719
HLE: Rename GetFunctionIndex functions
2020-08-27 22:12:15 +04:00
6b05e48bd6
HLE: Make naming closer to the current coding style
2020-08-27 22:01:04 +04:00
e0605d7911
HLE: Remove unused OSBreakPoints
2020-08-27 21:41:32 +04:00
79bfb48d68
HLE: Remove unused function
2020-08-27 21:07:42 +04:00
acd717ffae
GCAdapter_Android: Minor cleanup
2020-08-26 16:40:22 -04:00
4b91c071c1
Qt/GCMemcardCreateNewDialog: Use zero values for formatting instead of accessing g_SRAM.
2020-08-24 19:33:28 +02:00
b175c203e4
GCMemcardDirectory: Avoid undefined behavior in ClearBlock().
2020-08-24 19:32:10 +02:00
131eb9107b
GCMemcard: Avoid undefined behavior in the static Format().
2020-08-24 19:32:10 +02:00
87135db492
GCMemcardDirectory: Clarify data writing in FlushToFile().
2020-08-24 19:32:10 +02:00
306a5e6990
Jit64: Keep track of free code regions and reuse space when possible.
2020-08-24 19:31:32 +02:00
fdab9783c7
Externals: Add rangeset.
2020-08-24 19:31:32 +02:00
5b52b3e9cb
x64Emitter: Check end of allocated space when emitting code.
2020-08-24 19:31:32 +02:00
fcc8dfd189
Common/Assert: no longer needs special impl for msvc
2020-08-23 13:57:05 -07:00
89b6a4cbee
DolphinQt: resolve Qt5.15 deprecations
2020-08-23 13:57:05 -07:00
c629af6319
replace is_pod with is_standard_layout && is_trivially_copyable
2020-08-23 13:57:05 -07:00
12ea56a6b2
remove extraneous WIN32_LEAN_AND_MEAN definition
2020-08-23 13:57:05 -07:00
181e0dba21
apply `if constexpr` in a couple places
2020-08-23 13:57:05 -07:00
ccbc4c2d99
fix possible dangling shared_ptr ptr in ios
2020-08-23 13:57:05 -07:00
3ee4c53d65
wiimotereal: add some error handling. replace malloc with make_unique
2020-08-23 13:57:05 -07:00
938fd4e438
use constexpr for some compile-time expressions
2020-08-23 13:57:05 -07:00
79f5ea0474
initialize some variables which need to be
2020-08-23 13:57:05 -07:00
c22748dc38
windows: fix some incorrect string lengths
2020-08-23 13:55:15 -07:00
b021573a70
GekkoDisassembler: fix rld*
2020-08-23 13:55:14 -07:00
49590c9a42
FileUtil: handle some error conditions
2020-08-23 13:55:14 -07:00
3bc8a26083
don't use std::move on const variables
2020-08-23 13:55:14 -07:00
1b1fc39f02
handle to GetFileVersionInfoW must be zero
2020-08-23 13:55:14 -07:00
6ef9d70701
name some threads
2020-08-22 17:22:07 -07:00
a769dff1d0
windows: additionally set thread name via SetThreadDescription
2020-08-22 17:22:07 -07:00
4a34b74e68
Merge pull request #9035 from shuffle2/vs-pretty
...
misc vcxproj cleanup
2020-08-22 20:13:25 -04:00
cff4806d8d
windows: fix build if pch were to be disabled
2020-08-22 16:18:24 -07:00
af55938538
msbuild: use the moc dispatcher from Qt's vstools
...
The new method supports build parallelism and cleaner
integration into msbuild dependency flows.
2020-08-22 16:17:51 -07:00
03a263db20
msbuild: fixup linking of discord-rpc
2020-08-22 16:17:50 -07:00
2f47f486af
msbuild: re-enable standalone vcxproj processing
2020-08-22 16:17:50 -07:00
1f8cda6281
DolphinQt: sort the files in vcxproj
2020-08-22 16:17:50 -07:00
390f509bbf
windows: disable C4200 directly in libusb.h
2020-08-22 16:17:50 -07:00
94bf48b67c
msbuild: refactor stuff out of project files (for dolphin)
2020-08-22 16:17:50 -07:00
3a0d8c0208
msbuild: enable D3DCommon to use pch
2020-08-22 16:17:50 -07:00
36ace8eb52
prettify some constructs in vcxproj files
2020-08-22 16:17:50 -07:00
f7f0fa2d85
DiscIO: Adjust WIA/RVZ header size heuristic
...
The heuristic was not allocating enough space for Metroid: Other M,
at least when using the default settings. (This didn't break the
file, it just caused some headers to be placed at the end of the
file instead of at the start and wasted a few hundred kilobytes.)
2020-08-22 22:26:55 +02:00
f859da112e
Update Windows build to use Qt 5.15.0.
2020-08-22 20:08:38 +02:00
fc6c1931fa
VolumeVerifier: Adjust problem descriptions for new netplay check
...
The new hash check catches essentially all desync problems
that VolumeVerifier can catch, so from the user's perspective,
such problems will result in Dolphin refusing to start the
game on netplay rather than actually getting a desync.
2020-08-19 17:21:38 +02:00
d1439a1fa9
IOS/USB: Move scan thread logic into a separate class
...
This moves the scan thread logic and variables into a separate
ScanThread class. By turning ScanThread instances into members of the
most derived class, this ensures that the scan thread is always
properly stopped when the most derived class is destructed and fixes
a race condition that could cause the scan thread to call virtual
member functions from a derived class whose members have already
been destructed.
A drawback of this approach is that the scan thread must be the last
member variable, so this commit also adds static assertions to ensure
that the assumption stays valid.
2020-08-17 15:14:45 +02:00
55c931d624
Merge pull request #8995 from Tilka/warnings
...
Fix some more GCC warnings
2020-08-17 14:49:28 +02:00
6104018fe1
Merge pull request #9020 from Tilka/usb
...
IOS/USB: fix potential race condition
2020-08-17 12:15:26 +02:00
9a5a705d01
Fix comparison to invalidated vector iterator.
...
GetFstEntryForPath may modify the children vector,
so do it before taking an iterator to the vector.
2020-08-16 15:17:11 -07:00
deb73d0167
msvc: temporary workaround for C4789 false positive
2020-08-16 12:49:00 -07:00
0ad123bdbb
BTEmu: Fix home menu inquiry assigning multiple wii remotes to wrong slots.
2020-08-16 11:38:13 -05:00
6a6f1451ff
Update state version.
2020-08-16 11:38:13 -05:00
13ee6bd7bb
BTEmu/Wiimote: Cleanups/Fixes.
2020-08-16 11:38:13 -05:00
2c5920dccc
Merge pull request #9028 from cristian64/netplaybrowser_deadlock_on_exit
...
DolphinQt: Prevent deadlock when exiting the NetPlay Session Browser dialog
2020-08-16 08:57:35 -04:00
ddeb2236ae
Removed RunOnObject() usage to prevent deadlock on exiting the NetPlay Session Browser dialog.
2020-08-16 12:32:50 +01:00
6fc7135047
Merge pull request #8855 from shuffle2/dol
...
DolReader: treat overly large data segment as bss
2020-08-16 06:02:39 -04:00
89ca9b51ad
Bluetooth/WiimoteDevice: Remove some silly comments.
2020-08-15 21:23:37 -05:00
1cddf9c527
BTEmu: Remove a wrong INFO_LOG.
2020-08-15 21:23:37 -05:00
eee1589aa3
Restoring NetPlay Session Browser dialog's settings before connecting widgets, to prevent multiple refresh requests on change.
2020-08-15 22:29:23 +01:00
07a0d44b36
Merge pull request #8571 from Pokechu22/di-interrupts
...
Fix gamecube games not noticing disc changes
2020-08-11 20:03:41 +02:00
bd87285f3a
FrameDump: Don't ignore the time base numerator
...
Fixes a regression where f72b756
2020-08-11 11:17:22 +02:00
c2de1d041a
Fix builds with system LZMA when using versions of CMake before 3.14
...
The "FindLibLZMA.cmake" module in CMake versions prior to 3.14 do not
set an alias like how Externals/liblzma/CMakeLists.txt does, so builds
performed using one of those older CMake versions will fail if the
system LZMA library is detected. To fix this, we need to link against
"lzma" instead of "LibLZMA::LibLZMA".
Fixes: b59ef81a7e
2020-08-11 02:53:16 -05:00
ca61b6c1ab
DiscIO: make use of std::nullopt
...
This also fixes a bogus GCC warning.
2020-08-08 21:53:27 +01:00
d2b06f4786
Fix various -Wshadow warnings
2020-08-08 21:45:03 +01:00
ee0d4661ab
IOS/USB: deduplicate scan thread stopping
...
Unlike other functions, base ctors/dtors are always called automatically.
2020-08-08 21:40:23 +01:00
1f4b9adbf5
ISO/USB: fix potential race condition
2020-08-08 21:40:23 +01:00
a161e58591
Merge pull request #8914 from JosJuice/jit64-low-dcbz
...
Jit64: Implement low DCBZ hack
2020-08-08 21:19:16 +01:00
8b236fc8f8
Merge pull request #8986 from jordan-woyak/button-pressed-no-ext
...
WiimoteEmu: Don't check extension button press for Wii remote reconnection.
2020-08-08 21:06:46 +01:00
c0fde32d80
Merge pull request #9019 from JosJuice/verify-wad-split-tmd-ticket
...
VolumeVerifier: Split TMD error from ticket error for WADs
2020-08-08 21:05:21 +01:00
76228fa482
Jit64: Implement low DCBZ hack
...
I was hoping this would improve the performance of Cars 2 by
avoiding interpreter fallbacks, but it doesn't seem to have
made any measurable impact.
2020-08-08 22:03:34 +02:00
3101d957b6
Merge pull request #8886 from JosJuice/stack-check-instruction
...
PatchEngine: Attempt to fix crash in IsStackSane
2020-08-08 20:59:48 +01:00
6356cc8b08
Merge pull request #8910 from OatmealDome/os-deprecated-cleanup
...
Analytics: Replace usage of Gestalt for retrieving macOS version
2020-08-08 20:53:14 +01:00
f17b5dd41b
Merge pull request #8804 from iwubcode/dsu-improvements
...
DolphinQt / InputCommon - Support multiple DSU servers
2020-08-08 20:45:57 +01:00
7ef0bc0359
VolumeVerifier: Split TMD error from ticket error for WADs
...
When I first made VolumeVerifier, I figured that the distinction
between an unsigned ticket and an unsigned TMD was a technical
detail that users would have no reason to care about. However,
while this might be true for discs, it isn't equally true for
WADs, due to the widespread practice of fakesigning tickets to
set the console ID to 0. This practice does not require
fakesigning the TMD (though apparently people do it anyway,
at least sometimes...), and the presence of a correctly signed
TMD is a useful indicator that the contents have not been
tampered with, even if the ticket isn't correctly signed.
2020-08-08 21:15:51 +02:00
76b955e090
Merge pull request #8940 from RenaKunisaki/master
...
add Break On Hit and Log On Hit for instruction breakpoints
2020-08-08 19:46:10 +01:00
6d0bc03e00
Merge pull request #8992 from Sintendo/fselx-avx
...
Jit64: Avoid unnecessary MOVAPS instructions
2020-08-08 19:38:48 +01:00
d7a96f927c
Merge pull request #9002 from OatmealDome/renderwidget-sheet
...
MainWindow: Attach quit emulation sheet to RenderWidget if shown on macOS
2020-08-08 19:18:32 +01:00
4c64446afe
Merge pull request #9005 from OatmealDome/macos-psn-arg
...
DolphinQt: Ignore "-psn" command line option on macOS
2020-08-08 19:11:39 +01:00
340c08a88d
Merge pull request #9008 from Sintendo/dspjitlea
...
DSPJit: Various minor improvements
2020-08-08 19:08:24 +01:00
3201944208
Merge pull request #9016 from JosJuice/jitarm64-fctiwzx-fcvt
...
JitArm64: Avoid double rounding in fctiwzx
2020-08-08 17:55:49 +01:00
8b4f16a310
JitArm64: Avoid double rounding in fctiwzx
...
FCVT doesn't necessarily round to zero, so the result
might be inaccurate if we use it. To ensure correct
rounding, we use FCVTS from double FPR to 32-bit GPR.
Unfortunately, FCVTS can't do double FPR to single FPR.
2020-08-07 22:44:04 +02:00
a77977d0aa
Merge pull request #8999 from AdmiralCurtiss/input-expression-math
...
Add a few input expression functions (trigonometry, sqrt, pow, min, max, clamp)
2020-08-07 14:40:29 -05:00
de5d0e54be
Merge pull request #9013 from JosJuice/savescreenshot-wait-for-completion
...
Remove wait_for_completion parameter from Renderer::SaveScreenshot
2020-08-06 19:44:43 -04:00
7385e9129c
Remove wait_for_completion parameter from Renderer::SaveScreenshot
...
This is now unused. Seems like it was an improper fix
(there would be a race if saving the screenshot took longer
than 2 seconds) back when it was used too.
2020-08-06 21:57:12 +02:00
363f3f82bb
DSPJitRegCache: Simplify WriteReg
...
The intent here is to generate a more compact instruction if a 32-bit
immediate can be zero-extended to the desired 64-bit immediate.
Nowadays the emitter is smart enough to do this for us, so this logic is
redundant.
2020-08-05 10:23:28 +02:00
618d261b91
DSPJitMultiplier: addpaxz - AND constant directly
...
There's no need to load the 64-bit immediate into a temporary register.
x64 will sign-extend 32-bit immediates to 64 bits, giving us the exact
value we need in this case.
48 C7 C0 00 00 FF FF mov rax,0FFFFFFFFFFFF0000h
48 21 C2 and rdx,rax
48 81 E2 00 00 FF FF and rdx,0FFFFFFFFFFFF0000h
2020-08-05 10:22:51 +02:00
49a4e09719
DSPJit: Replace/optimize LEAs
...
- LEA is a bit silly when the source and the destination are the same. A
simple ADD or SHL will do in those cases.
66 8D 04 45 00 00 00 00 lea ax,[rax*2]
66 03 C0 add ax,ax
48 8D 04 00 lea rax,[rax+rax]
48 03 C0 add rax,rax
66 8D 14 D5 00 00 00 00 lea dx,[rdx*8]
66 C1 E2 03 shl dx,3
- When scaling by 2, consider summing the register with itself instead.
The former always needs a 32-bit displacement, so the sum is more
compact.
66 8D 14 45 00 00 00 00 lea dx,[rax*2]
66 8D 14 00 lea dx,[rax+rax]
2020-08-05 10:22:50 +02:00
5c1693587f
DolphinQt: Ignore "-psn" command line option on macOS
2020-08-04 15:55:51 -04:00
b0f9bb9f13
Port some settings to the new config system
...
Other than the controller settings and JIT debug settings,
these are the only settings which were defined in Java code
but not defined in the new config system in C++. (There are
still a lot of settings that are defined in the new config
system but not yet saveable in the new config system, though.)
2020-08-03 15:07:53 +02:00
fae8f8d68b
MainWindow: Attach quit emulation sheet to RenderWidget on macOS
2020-08-03 05:48:57 -04:00
6020133f5b
LogManager: Add missing include
2020-08-02 19:52:10 -04:00
5cad82137d
Allow translations and custom names in GameFile::GetNetPlayName
...
There is no longer any major reason for why this function would
need to return the same result for all players.
2020-08-02 22:46:53 +02:00
a41166bb37
Make netplay's "same game" check more robust
...
Instead of comparing the game ID, revision, disc number and name,
we can compare a hash of important parts of the disc including
all the aforementioned data but also additional data such as the
FST. The primary reason why I'm making this change is to let us
catch more desyncs before they happen, but this should also fix
https://bugs.dolphin-emu.org/issues/12115 . As a bonus, the UI can
now distinguish the case where a client doesn't have the game at
all from the case where a client has the wrong version of the game.
2020-08-02 22:46:53 +02:00
cdf2a29b5e
Qt/IOWindow: Add a handful of math functions to the function dropdown.
2020-08-02 22:09:09 +02:00
2281cde28b
InputCommon: Add a handful of math functions to the expression parser.
2020-08-02 22:09:09 +02:00
234eaa0ff9
Merge pull request #7252 from Ebola16/Log
...
Android: Add Log Configuration to UI
2020-08-02 22:00:48 +02:00
08bdeefe05
Jit64AsmCommon: Use AVX in ConvertDoubleToSingle
...
Using AVX we can eliminate another MOVAPS instruction here.
Before:
0F 28 C8 movaps xmm1,xmm0
66 0F DB 0D CF 2C 00 00 pand xmm1,xmmword ptr [1F8D283B220h]
After:
C5 F9 DB 0D D2 2C 00 00 vpand xmm1,xmm0,xmmword ptr [271835FB220h]
2020-08-02 18:07:47 +02:00
f775e9b99d
OnScreenDisplay: fix names rgba -> argb
2020-08-02 01:37:20 +02:00
dbacffd75d
Merge pull request #8731 from Pokechu22/dsp-lle-cpu-int-crash
...
Fix crash when using DSP LLE with CPU interpreter (or fastmem off)
2020-08-01 15:26:27 +01:00
13f20ecd34
DolphinQt: Don't capture local pointer by reference
...
This may be the cause of a crash that has been reported on the
forums, but I'm not sure since I can't reproduce it myself.
2020-07-31 11:33:48 +02:00
0aaddf8b19
Merge pull request #8990 from JosJuice/wia-conversion-warning
...
DiscIO: Fix conversion warning
2020-07-30 21:45:24 -04:00
9183c0c482
Bump state version
2020-07-29 16:57:37 -07:00
e5e23c6b27
Mark several DVDInterface functions as static
2020-07-29 16:57:36 -07:00
4415df463f
Remove DVDInterface::Reset
...
It only resets the registers, which isn't something that needs to be done except for in DVDInterface::Init
2020-07-29 16:57:36 -07:00
0fa96df818
Remove DriveState::DiscChangeDetected hack
...
Since both GameCube and Wii resets now work correctly, this hack is not needed anymore.
2020-07-29 16:57:36 -07:00
a73eaf5712
Fix DVDLowReset spinup flag being read incorrectly
2020-07-29 16:57:35 -07:00
9a8d426645
Implement PI_RESET_CODE resetting DI
2020-07-29 16:57:35 -07:00
b8715b42d2
Only reset drive chip state (not DI registers) when changing discs
...
Resetting the DI registers disables interrupts, which means any errors reported (for instance) are just not sent though.
2020-07-29 16:57:35 -07:00
537e40afb5
Only update DIMAR and DILENGTH if transfer completed without error
...
Turns out, Gamecube games actually do check DILENGTH, and if DILENGTH is at 0, they'll think the transfer completed successfully even if DEINT is used, since after all, surely that means everything was sent. That caused all sorts of issues, from audio looping when a disc is removed since it's re-using the same buffer to just flat-out crashing instead of showing the disc removed screen.
2020-07-29 16:57:35 -07:00
fba51b2956
Split drive state and drive error into 2 fields, and fix some inaccuracies
...
In particular:
- Trying to play audio in a non-ready state returns the state-specific error, not an audio buf error
- Audio status cannot be requested in non-ready states
- The audio buffer cannot be configured in states other than ReadyNoReadsMade
- Using the stop motor command while the motor is already stopped doesn't change states
Additionally, the internal state IDs are used (which distinguish ReadyNoReadsMade and Ready), instead of the state IDs exposed in request error. This makes some of the weird behavior a bit more obvious.
State and error behavior of the seek command was not implemented in this commit.
2020-07-29 16:57:34 -07:00
2e8c5b4521
DolphinQt: Show a warning when launching an NKit disc image
...
It is my opinion that nobody should use NKit disc images without
being aware of the drawbacks of them. Since it seems like almost
nobody who is using NKit disc images knows what NKit is (hmm, now
how could that have happened...?), I am adding a warning to Dolphin
so that you can't run NKit disc images without finding out about the
drawbacks. In case someone really does want to use NKit disc images,
the warning has a "Don't show this again" option. Unfortunately, I
can't retroactively add the warning where it's most needed:
in Dolphin 5.0, which does not support Wii NKit disc images.
2020-07-29 21:05:57 +02:00
31755bc13a
Jit64: fselx - Optimize SSE4.1 packed
...
Pretty much the same optimization we did for AVX, although slightly more
constrained because we're stuck with the two-operand instruction where
destination and source have to match.
We could also specialize the case where registers b, c, and d are all
distinct, but I decided against it since I couldn't find any game that
does this.
Before:
66 0F 57 C0 xorpd xmm0,xmm0
66 41 0F C2 C1 06 cmpnlepd xmm0,xmm9
41 0F 28 CE movaps xmm1,xmm14
66 41 0F 38 15 CC blendvpd xmm1,xmm12,xmm0
44 0F 28 F1 movaps xmm14,xmm1
After:
66 0F 57 C0 xorpd xmm0,xmm0
66 41 0F C2 C1 06 cmpnlepd xmm0,xmm9
66 45 0F 38 15 F4 blendvpd xmm14,xmm12,xmm0
2020-07-29 17:28:48 +02:00
afb86a12ab
Jit64: fselx - Optimize AVX packed
...
For the packed variant, we can skip the final MOVAPS and write the
result directly into the destination register.
Before:
66 0F 57 C0 xorpd xmm0,xmm0
66 41 0F C2 C1 06 cmpnlepd xmm0,xmm9
C4 C3 09 4B CC 00 vblendvpd xmm1,xmm14,xmm12,xmm0
44 0F 28 F1 movaps xmm14,xmm1
After:
66 0F 57 C0 xorpd xmm0,xmm0
66 41 0F C2 C1 06 cmpnlepd xmm0,xmm9
C4 43 09 4B F4 00 vblendvpd xmm14,xmm14,xmm12,xmm0
2020-07-29 17:06:52 +02:00
a05b1f9ab9
DiscIO: Fix conversion warning
...
Should fix https://bugs.dolphin-emu.org/issues/12208 .
2020-07-29 10:55:02 +02:00
b354e343a7
Merge pull request #8988 from JosJuice/no-refresh-rate-round
...
VideoCommon: Don't round the refresh rate
2020-07-28 17:17:34 -04:00
a52774ca63
Jit64: fselx - Add AVX path
...
AVX has a four-operand VBLENDVPD instruction, which allows for the first
input and the destination to be different. By taking advantage of this,
we no longer need to copy one of the inputs around and we can just
reference it directly, provided it's already in a register (I have yet
to see this not be the case).
Before:
66 0F 57 C0 xorpd xmm0,xmm0
F2 41 0F C2 C6 06 cmpnlesd xmm0,xmm14
41 0F 28 CE movaps xmm1,xmm14
66 41 0F 38 15 CA blendvpd xmm1,xmm10,xmm0
F2 44 0F 10 F1 movsd xmm14,xmm1
After:
66 0F 57 C0 xorpd xmm0,xmm0
F2 41 0F C2 C6 06 cmpnlesd xmm0,xmm14
C4 C3 09 4B CA 00 vblendvpd xmm1,xmm14,xmm10,xmm0
F2 44 0F 10 F1 movsd xmm14,xmm1
2020-07-28 23:17:18 +02:00
f72b756778
VideoCommon: Don't round the refresh rate
...
We now provide a double to the FPS counter and exact values
to FIFO recording and frame dumping.
2020-07-28 21:01:38 +02:00
bdfb320b3d
WiimoteEmu: Don't check extension button press for wii remote reconnection. A real remote doesn't. We won't either.
2020-07-26 11:20:23 -05:00
1ca3710bd2
DSPLLE: Use Memory functions isntead of directly using Memory::physical_base
...
Fixes bug 11980
2020-07-24 15:06:39 -07:00
59dc7cfe7d
Use size_t in some DSP code code
2020-07-24 15:06:39 -07:00
f9b856aeda
WiimoteEmu: Mark several getters as const
...
These don't modify internal class state, so they can be made const.
2020-07-24 15:48:27 -04:00
fdcc6a436b
Android: Add Log Configuration to UI
2020-07-24 13:59:13 -04:00
4b21bc7508
LightingShaderGen: Transition over to fmt
2020-07-24 13:50:09 -04:00
7f7db6d3e7
VertexShaderGen: Transition over to using fmt
2020-07-24 13:34:47 -04:00
062dd5ab0a
DolphinQt: fix -Wunused-variable warning
2020-07-24 17:44:32 +01:00
5bd2b2699c
DolphinQt: fix -Wsign-compare warning
2020-07-24 17:44:32 +01:00
750cb1f830
DolphinQt: fix -Wunused-but-set-variable warning
2020-07-24 17:41:37 +01:00
bf5b1092b2
DiscIO: fix -Wreorder warning
2020-07-24 17:41:37 +01:00
04b31e7eee
IOS: work around incorrect -Wunused-but-set-variable warning
...
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96311
2020-07-24 16:38:54 +01:00
fbd34f72ad
EXI: fix -Wunused-variable warning
2020-07-24 15:35:35 +01:00
7b2e93eea8
EXI: fix -Wreorder warning
2020-07-24 15:35:24 +01:00
781662c6ad
Merge pull request #8793 from iwubcode/dump-texture-options
...
DolphinQt / VideoCommon: Add additional texture dumping options
2020-07-24 01:38:10 -04:00
213c1841f7
Merge pull request #8903 from AdmiralCurtiss/gcmemcard-file-identity-check
...
GCMemcard: Change behavior of TitlePresent() to more closely resemble how saves are actually identified.
2020-07-23 17:44:16 +02:00
9c8338ec4c
DolphinQt / VideoCommon: Add additional texture dumping options. Specifically, this enables users to choose whether to dump mip maps, base level textures, or both.
2020-07-22 19:30:27 -05:00
d7a91316da
Merge pull request #8974 from Filoppi/patch-4
...
Fix disc image conversion button not being clear #3
2020-07-22 17:24:23 -04:00
f6ba54b74e
Fix disc image conversion button not being clear #3
...
It wasn't clear whether the conversion would create a new file or replace the old one
Recreated #8952 directly from github
2020-07-22 23:00:20 +03:00
26536832c3
Config: Simplify IsSettingSaveable
...
Should make it both easier to edit and faster to run.
2020-07-22 11:46:47 +02:00
ae2348023b
Merge pull request #8964 from JosJuice/list-wad-file-type
...
DolphinQt: Show WAD as "WAD" instead of "" in file format column
2020-07-19 17:35:34 -04:00
fe5e92f706
DolphinQt: Show WAD as "WAD" instead of "" in file format column
...
https://bugs.dolphin-emu.org/issues/12190
2020-07-19 21:30:48 +02:00
ae44f17667
HW/GCPadEmu: Adjust gate radius values to more closely match the real hardware.
2020-07-19 09:45:33 -05:00
487cd7abd9
Merge pull request #8905 from JosJuice/jni-encoding
...
Android: Use correct encoding when converting strings
2020-07-18 22:13:14 -04:00
0ede5d1537
Use range loop (if possible)
2020-07-18 18:29:16 -05:00
97c9cf3e21
DolphinQt / InputCommon - add DSU string validator to avoid crashes, limited backwards compatibility support
2020-07-17 14:53:39 -05:00
58aa0150e1
DolphinQt / InputCommon: Support multiple DSU servers
2020-07-17 14:53:39 -05:00
aa4896fb3f
DolphinQt: Add i18n comment for "Surround"
2020-07-17 19:10:31 +02:00
8b3e9e6a81
DolphinQt: Replace unusual Qt::InitialSortOrderRole usage with a custom role.
2020-07-16 20:27:07 -05:00
a7e475e57b
Merge pull request #8958 from jordan-woyak/sort-fix
...
DolphinQt: Fix default sort direction of game list.
2020-07-16 21:20:43 -04:00
ecf016e80a
DolphinQt: Fix default sort direction of game list.
2020-07-16 19:21:14 -05:00
037aa2192f
NetPlay: Limit nickname length
...
Ridiculously long nicknames cause UI silliness, so 30 characters seems
like a reasonable limit, as it's the same as the forum.
2020-07-16 19:03:54 -04:00
92812d0b0b
QtUtils: Add UTF8CodePointCountValidator
2020-07-16 19:03:46 -04:00
c59648337a
Merge pull request #8955 from JosJuice/android-no-ashmem
...
Android: Don't access /dev/ashmem on newer Android versions
2020-07-16 14:23:51 -04:00
00cde7cbbd
Android: Don't access /dev/ashmem on newer Android versions
...
Fixes a critical regression where 95945a0
2020-07-16 20:06:58 +02:00
f2cc3a2948
Add Android check for strerror_r variant
...
I don't know why Android does it like this, but at least
it's easy to fix. (We are currently at __ANDROID_API__ == 21.)
2020-07-16 18:51:58 +02:00
1a2b6ca2d6
Fix Windows CMake builds with shared zlib
...
On Linux, if shared zlib is present, zlib.h is always available and -lz
links to zlib, even if you don't run find_package(ZLIB).
For some reason I have zlib installed on Windows (possibly from vcpkg),
so find_package(ZLIB) succeeds and ZLIB_FOUND is true.
When Dolphin uses shared zlib on Windows, the problem is that zlib.h
is not in the default include path, and the CMake target is called
ZLIB::ZLIB and there's neither a target nor a library called z.
However, both find_package(ZLIB) and add_subdirectory(Externals/zlib)
create a target called ZLIB::ZLIB, so I'll switch to that instead.
Hopefully this change doesn't break anyone's build.
2020-07-15 23:25:18 -07:00
556e93f357
GCMemcard: Change behavior of TitlePresent() to more closely resemble how saves are actually identified.
...
This modifies GCMemcard::TitlePresent() to match my findings of how the GC BIOS and various games behave when you alter the fields in the directory entry.
It looks like for a save to be recognized by a game, the following have to be true:
- Game code and maker code must exactly match what the game expects.
- Filename is only checked up to the first null byte. All bytes afterwards can be whatever.
The BIOS itself does a full compare of the filename when checking for whether it should allow copying a file from one card to another, but behaves oddly in some cases when there's non-null bytes after the first null. See the big comment in `HasSameIdentity()` for details.
2020-07-15 19:17:22 +02:00
695a96498a
Merge pull request #8922 from Filoppi/timer-fixes
...
Timer fixes
2020-07-13 00:16:45 +01:00
3c70fb7277
Merge pull request #8950 from jordan-woyak/double-time-fix
...
Common/Timer: Fix integer underflow in Timer::GetDoubleTime for dates before ~2008.
2020-07-12 15:52:15 -04:00
eab07866a3
Common/Timer: Fix integer underflow in Timer::GetDoubleTime for dates before ~2008.
2020-07-12 12:55:02 -05:00
4d36f6a5b0
Merge pull request #8936 from jordan-woyak/wiimote-extension-calibration-fix
...
ControllerInterface/Wiimote: Provide fallback values for extensions with bad calibration.
2020-07-12 12:46:15 -04:00
d9e7d0514c
WiimoteEmu: Allow writes of the i2c bus to play speaker data.
2020-07-11 21:19:16 -05:00
5299e902aa
ControllerInterface/Wiimote: Provide fallback values for extensions with bad calibration data.
2020-07-11 19:55:14 -05:00
a553f22385
Add Break On Hit and Log On Hit for instruction breakpoints
2020-07-11 13:38:58 -04:00
ed32a2a1fe
Merge pull request #8946 from jordan-woyak/unbreak-mayflash
...
InputCommon/GCAdapter: Unbreak Mayflash GCAdapters by allowing libusb_control_transfer call to fail.
2020-07-11 11:56:30 -04:00
f7c32bc04e
RVZ: Fix split seed reads
...
This could cause read errors if chunks were laid out a certain
way in the file and the whole chunk wasn't being read at once.
Should fix https://bugs.dolphin-emu.org/issues/12184 .
2020-07-11 17:45:16 +02:00
b350d3cca3
InputCommon/GCAdapter: Unbreak Mayflash GCAdapters by allowing libusb_control_transfer call to fail.
2020-07-09 17:17:44 -05:00
9c7704c0ac
DolphinQt: Attempt to fix ParallelProgressDialog constantly reopening
...
I believe the value returned by value() resets when we call
setValue() with the maximum (due to auto-reset). I have been
unable to test this because I can't reproduce the issue, which is
described at https://bugs.dolphin-emu.org/issues/12158#note-9 .
2020-07-09 15:45:29 +02:00
aeeb85aa3a
DolphinQt: Replace QTBUG-10561 workaround with better workaround
...
This workaround is not timing sensitive, unlike the old one.
Hopefully fixes https://bugs.dolphin-emu.org/issues/12158
and https://bugs.dolphin-emu.org/issues/12180 .
2020-07-08 20:29:26 +02:00
f5da6e07d7
Android: Use correct encoding when converting strings
...
The functions with "UTF" in the name use "modified UTF-8" rather
than the standard UTF-8 which Dolphin uses, at least according
to Oracle's documentation, so it is incorrect for us to use them.
This change fixes the problem by converting between UTF-8 and
UTF-16 manually instead of letting JNI do it for us.
2020-07-08 14:52:05 +02:00
38791eec18
Common: Never convert from UCS-2 in WStringToUTF8
...
Probably not something we would run into in practice since
Windows uses a separate implementation, but let's do it
for the sake of correctness.
2020-07-08 14:51:35 +02:00
15d9fab0bb
Common: Rename UTF16ToUTF8
...
This function does *not* always convert from UTF-16. It converts
from UTF-16 on Windows and UTF-32 on other operating systems.
Also renaming UTF8ToUTF16 for consistency, even though it
technically doesn't have the same problem since it only was
implemented on Windows.
2020-07-08 14:51:35 +02:00
87287181dd
Merge pull request #8907 from JosJuice/android-overlay-stick-gate
...
Android: Use octagonal stick gate in overlay
2020-07-08 08:50:47 -04:00
4c50eadf34
Merge pull request #8908 from jordan-woyak/wiimote-battery-hax
...
WiimoteCommon: Tweak battery level math.
2020-07-08 08:46:58 -04:00
b9ae7c350e
Merge pull request #8926 from JosJuice/sysconf-sound
...
DolphinQt: Expose SYSCONF sound setting
2020-07-08 08:41:23 -04:00
0bff77d9e4
Merge pull request #8925 from JosJuice/tas-turbo-interval
...
DolphinQt: Allow customizing TAS input turbo interval
2020-07-08 08:40:46 -04:00
a1195fbf91
Merge pull request #8933 from jordan-woyak/gcadapter-nyko
...
InputCommon/GCAdapter: Fix offbrand "GCAdapters".
2020-07-08 08:38:52 -04:00
6f298378a1
Reword "Please avoid forcing Dolphin to use MSAA by the driver" message
...
Some users who get this error don't seem to gain much understanding
of how to resolve the problem from reading the error message.
2020-07-08 11:34:36 +02:00
f2fd5c7f90
InputCommon/GCAdapter: Fix offbrand "GCAdapters" with a libusb_control_transfer call.
2020-07-07 14:45:19 -05:00
327b985718
DVDInterface: Increase the latency for read commands
...
Hardware tested using cached reads.
Fixes Ed, Edd n Eddy. https://bugs.dolphin-emu.org/issues/10373
2020-07-05 18:57:39 +02:00
7a45ca0334
DolphinQt: Mark Zstandard as recommended for RVZ
2020-07-05 12:52:59 +02:00
74f74ac928
DiscIO: Use Volume::IsDatelDisc in VolumeVerifier
...
I forgot to do this in the PR where I added Volume::IsDatelDisc.
2020-07-04 20:24:26 +02:00
4f98653ec6
Merge pull request #8930 from JosJuice/datel-scrub-ignored
...
DolphinQt: Fix scrubbing not being disabled for Datel discs
2020-07-04 14:49:34 +01:00
c5a3882617
Merge pull request #8929 from JosJuice/datel-covers
...
DiscIO: Fix downloading covers for non-GNHE5d Datel discs
2020-07-04 14:07:46 +01:00
5360ec80c8
DolphinQt: Fix scrubbing not being disabled for Datel discs
...
The code for disabling scrubbing for RVZ was overriding the code
for disabling scrubbing for Datel discs.
2020-07-04 15:06:05 +02:00
fb922781e7
RedumpVerifier: Treat Datel game IDs as empty
...
Replacement for the reverted commit
f9705fd117
2020-07-04 15:00:02 +02:00
f24566bf39
DiscIO: Add Volume::IsDatelDisc
2020-07-04 14:51:13 +02:00
f9aaf8b971
Revert "Return nothing from VolumeWii::GetGameTDBID if Datel"
...
This reverts commit f9705fd117
2020-07-04 14:45:15 +02:00
9c12a843f8
Merge pull request #8884 from iwubcode/freelook_performance_fix
...
VertexShaderManager: Only look for freelook config changes if we're using freelook
2020-07-04 14:19:59 +10:00
e1e57fc359
DolphinQt: Expose SYSCONF sound setting
2020-07-02 22:25:41 +02:00
0441d6aa5e
VertexShaderManager: Avoid accessing freelook control type configuration each call which caused a performance hit, move check to RenderBase where it is checked when config changes
2020-07-02 12:55:08 -05:00
1c4088e203
DolphinQt: Allow customizing TAS input turbo interval
...
As a side effect of 9c5c3c09c5c3c0
2020-07-02 16:58:29 +02:00
4b5ca9923c
Fixes the timer returning 1 when it should return 0. The case mentioned by the comment does not exist anymore.
...
Also added a IsRunning function as it was impossible to know whether it had been started or not (I will use it in later PRs but it should be there anyway)
2020-07-01 22:29:30 +03:00
a10447eae2
JitArm64_Paired: Fix ps_msub when d == b
2020-07-01 20:11:54 +01:00
a04ac23794
JitArm64: no intermediate rounding for paired FMA
2020-07-01 00:24:08 +01:00
2a46c1f86f
JitArm64: annotate intentional fallthrough
2020-07-01 00:10:15 +01:00
4ff560a6e4
Merge pull request #8913 from JosJuice/msvc-preprocessor
...
Support the new MSVC preprocessor
2020-06-30 04:34:10 -04:00
5792881eeb
Merge pull request #8912 from JosJuice/fix-profiler
...
VideoCommon: Show profiler output again
2020-06-29 14:01:57 +02:00
293745afce
Support the new MSVC preprocessor
...
Intends to fix https://bugs.dolphin-emu.org/issues/12170 .
2020-06-29 13:50:59 +02:00
81d399a4f2
VideoCommon: Show profiler output again
...
This profiler was added in 94d9d13
2020-06-29 11:59:47 +02:00
4095fb6c20
Merge pull request #8911 from OatmealDome/arm64-fastmem-off
...
JitArm64: Don't assume fastmem arena is available
2020-06-29 09:20:19 +02:00
089ffb9ef4
JitArm64: Don't assume fastmem arena is available
2020-06-29 00:42:56 -04:00
0a22df3a9d
Analytics: Remove deprecated usage of Gestalt to get macOS version
2020-06-29 00:37:50 -04:00
d382c6bab9
WiimoteCommon: Tweak battery level math.
2020-06-28 19:40:26 -05:00
db75509ec5
Android: Enfore correct stick gate in overlay
...
Currently, the touch controller overlay uses a square gate for
sticks. This commit changes that so that it instead uses the
stick gate configured in the INI, which ensures that the values
sent to the core are appropriately scaled regardless of what
is configured in the INI and makes the overlay look nicer
if the INI is set to a stick gate that matches the graphics.
2020-06-29 01:20:02 +02:00
961f937010
Merge pull request #8853 from CrunchBite/feature-xlink-kai-bba
...
Feature XLink Kai BBA
2020-06-27 23:32:49 -04:00
27e49c00b3
FreeLookCamera: Fix savestate branch inconsistency.
...
Fixes https://bugs.dolphin-emu.org/issues/12168
2020-06-28 02:31:37 +02:00
2e8d1dd1db
Merge pull request #8889 from JosJuice/movie-frame-update-frequency
...
Core: Call Movie::FrameUpdate per field, not per line
2020-06-27 18:10:08 +01:00
b36ab8360e
Merge pull request #8820 from iwubcode/freelook_field_of_view
...
Core / VideoCommon / DolphinQt - allow tweaking freelook camera's field of view
2020-06-27 18:00:48 +01:00
067667fda5
Add XLink Kai UDP BBA
2020-06-26 14:52:30 -04:00
1ab37990b1
Merge pull request #8808 from sepalani/net-widgets-block
...
NetworkWidget: Add Blocking column
2020-06-26 07:38:52 -04:00
bb6582783b
Core: update save state version
2020-06-25 13:35:47 -05:00
69bd6bbdef
DolphinQt: change freelook fov by the step size
2020-06-25 13:34:42 -05:00
8ccb684711
VideoCommon: change freelook camera fov step size and expose it
2020-06-25 13:34:42 -05:00
dc4b938526
DolphinQt: use hotkeys for field of view to modify freelook camera
2020-06-25 13:34:42 -05:00
7aa153d57e
HotkeyManager: Add hotkeys for freelook field-of-view x and y
2020-06-25 13:34:42 -05:00
3d7d4dfc8a
VideoCommon: Use freelook field of view to change the perspective of the camera
2020-06-25 13:34:42 -05:00
98de22a1e6
Merge pull request #8900 from JosJuice/disc-deduplicate
...
DiscIO: Deduplicate some VolumeGC/VolumeWii code
2020-06-25 16:10:04 +01:00
a2c51e027f
DolphinQt: Fix a -Wshadow warning in ConvertDialog
2020-06-25 16:44:02 +02:00
d17b801518
DiscIO: Deduplicate some VolumeGC/VolumeWii code
2020-06-25 16:37:21 +02:00
94fd583147
DolphinQt: Fix a -Wswitch warning in ConvertDialog
2020-06-25 16:34:43 +02:00
6468978dd0
Merge pull request #8897 from JosJuice/qt-file-format-columns
...
DolphinQt: Add columns with file format details
2020-06-25 15:21:44 +01:00
4eb4b1d2b7
Merge pull request #8898 from JosJuice/windows-cmake-new-lambda-processor
...
Replace Windows CMake lambda constexpr capture workaround
2020-06-25 15:19:09 +01:00
502ab789d9
Merge pull request #8813 from nbouteme/master
...
Make SO_POLL complete asynchronously in IOS_NET SO
2020-06-25 08:20:56 -04:00
c9edfa0eaa
Replace Windows CMake lambda constexpr capture workaround
...
While manually capturing constexpr variables used in lambda
expressions does work, it's really easy to forget doing so since
we don't have a Windows CMake builder and the workaround isn't
necessary anywhere else. Fortunately, MSVC has a flag that fixes
the constexpr capture behavior, so let's use that instead.
2020-06-25 13:11:29 +02:00
265e0d00d6
DolphinQt: Add columns with file format details
2020-06-25 12:49:36 +02:00
26ed3b318c
Merge pull request #8891 from JosJuice/file-details
...
Show file format details in game properties
2020-06-25 11:00:49 +01:00
7f3c4b19b9
GCMemcard: Rename unknown field to m_dtv_status
2020-06-24 23:39:59 +04:00
b68ab560dc
Make SO_POLL complete asynchronously
2020-06-24 12:59:41 +02:00
0eb9ac7777
Include SRAM in savestates
...
This fixes an issue with saving after loading a savestate in Pokemon Colosseum.
2020-06-24 02:42:50 -04:00
cf36877608
Merge pull request #8879 from AdmiralCurtiss/gci-folder-savestates
...
Keep memory card header and use it to reinitialize GCI folders on mismatch. (Fix savestate with GCI folders)
2020-06-24 08:36:58 +02:00
8c205ef8f3
DolphinQt: Show version number for WIA/RVZ introduction
2020-06-21 21:16:10 +02:00
d494e0230c
Show file format details in game properties
2020-06-21 20:47:23 +02:00
9982251899
Merge pull request #8538 from JosJuice/wia
...
Add support for the WIA and RVZ disc image formats
2020-06-21 11:40:58 +01:00
660d81a10b
RVZ: Bump version number to 1.0
2020-06-21 12:38:03 +02:00
9eb36afeb0
Core: Call Movie::FrameUpdate per field, not per line
...
Fixes https://bugs.dolphin-emu.org/issues/12066 .
I must've only tested the frame counter with an earlier version
of the PR that broke this, not the final version...
2020-06-20 19:32:08 +02:00
03e0d2c820
Merge pull request #8885 from delroth/spr-thrm
...
PowerPC: partially implement thermal related SPRs
2020-06-19 03:48:30 +02:00
dc2733ce24
Socket: Fix ENOTCONN error code
2020-06-18 22:23:57 +04:00
364ef76ba1
PatchEngine: Attempt to fix crash in IsStackSane
...
HostIsInstructionRAMAddress uses XCheckTLBFlag::OpcodeNoException,
so we should also use XCheckTLBFlag::OpcodeNoException when reading,
to ensure that we use the IBAT (as opposed to the DBAT) for both.
2020-06-18 11:57:00 +02:00
dd1fc711c7
PowerPC: partially implement thermal related SPRs
...
Doesn't support triggering interrupts when the thermal threshold is
exceeded, but allows polling for temperature information.
The THRM[123] registers are documented in most PPC datasheets, see e.g.
this PPC750CX one: http://datasheets.chipdb.org/IBM/PowerPC/750/750cx_um3-17-05.pdf
2020-06-18 07:37:44 +02:00
a65ef35f1a
VideoCommon: Clean freelook camera dirty state when getting the new view
2020-06-17 12:07:40 -05:00
224c6e799d
RVZ: Extend GroupEntry
2020-06-17 13:48:45 +02:00
f2c38c0e67
RVZ: Make m_rvz a template parameter
...
Needed for the next commit.
2020-06-17 13:48:45 +02:00
ca4e4a6207
WIA/RVZ: Move (de)compression to a different file
2020-06-17 13:48:45 +02:00
2ec608f059
DolphinQt: Set block size to 128 KiB by default
2020-06-17 13:48:45 +02:00
3f753fc87d
RVZ: Detect junk data in the same block as a file
2020-06-17 13:48:44 +02:00
4b74993374
RVZ: Store pseudorandom junk data efficiently
2020-06-17 13:48:42 +02:00
1e92b54bf5
WIA/RVZ: Skip some memory allocations when reusing chunks
2020-06-17 13:48:16 +02:00
f5ef70fc76
RVZ: Don't store redundant exceptions when chunk size is < 2 MiB
2020-06-17 13:48:16 +02:00
b06c50ed2e
RVZ: Support chunk sizes between 32 KiB and 2 MiB
...
WIA doesn't support smaller than 2 MiB.
2020-06-17 13:48:15 +02:00
0d433baeb5
RVZ: Remove PURGE support
...
PURGE isn't especially useful, while requiring some annoying
special handling in the file format. If you want no compression,
use NONE. If you want fast compression, use Zstandard.
2020-06-17 13:48:15 +02:00
1f7c0b636f
RVZ: Add Zstandard as a compression method
2020-06-17 13:48:12 +02:00
e2ae2b3b0b
Add new file format RVZ based on WIA
2020-06-17 13:47:34 +02:00
f21a254042
WIA: Implement multithreaded compression
2020-06-17 13:47:34 +02:00
9dea8169e0
WIA: Write all headers at the start of the file
...
Gets rid of the need to seek to the end of the file
when opening a file.
The downside of this is that we waste a little space,
since we can't know in advance exactly how much
space the compressed parts of the headers will need.
2020-06-17 13:47:34 +02:00
e5b9e1ba1f
WIA: Reuse groups when writing
...
This is useful for the way Dolphin scrubs Wii discs.
The encrypted data is what gets zeroed out, but this
zeroed out data then gets decrypted before being stored,
and the resulting data does not compress well.
However, each block of decrypted scrubbed data is
identical given the same encryption key, and there's
nothing stopping us from making multiple group entries
point to the same offset in the file, so we only have
to store one copy of this data per partition.
For reference, wit zeroes out the decrypted data,
but Dolphin's WIA writer can't do this because it currently
doesn't know which parts of the disc are scrubbed.
This is also useful for things such as storing Datel discs
full of 0x55 blocks (repesenting unreadable blocks)
without compression enabled.
2020-06-17 13:47:34 +02:00
40e46aee57
WIA: Store all-zero data efficiently
2020-06-17 13:47:34 +02:00
e8b019ac29
WIA: Implement compression
2020-06-17 13:47:30 +02:00
e936c4acd8
WIA: Write hash exceptions
2020-06-17 13:43:54 +02:00
3b8c44fd0e
WIA: Decrypt Wii data when writing
2020-06-17 13:43:54 +02:00
115edea34e
WIA: Add early support for WIA writing
2020-06-17 13:43:54 +02:00
791e363c9a
WIA: Make use of the exception lists
2020-06-17 13:43:54 +02:00
47067f661a
WIA: Properly check for overlapping data
2020-06-17 13:43:53 +02:00
04089f24f9
WIA: Implement re-encryption of Wii partition data
2020-06-17 13:43:53 +02:00
e3d291a529
WIA: Check the internal WIA hashes
2020-06-17 13:43:53 +02:00
827437c036
WIA: Fix the handling of chunk sizes larger than 2 MiB
2020-06-17 13:43:53 +02:00
0b407228b7
WIA: Add documentation
2020-06-17 13:43:53 +02:00
01a77ae8a1
WIA: Implement caching and partial decompression
2020-06-17 13:43:53 +02:00
b59ef81a7e
WIA: Implement bzip2, LZMA, and LZMA2 decompression
2020-06-17 13:43:52 +02:00
1579e061a3
WIA: Correctly handle data with size not divisible by chunk size
2020-06-17 13:43:52 +02:00
3c373c8aa8
WIA: Treat groups with size 0 as containing only zeroes
2020-06-17 13:43:52 +02:00
36991e2dde
WIA: Implement PURGE decompression
2020-06-17 13:43:52 +02:00
3672bd79f3
WIA: Implement ReadWiiDecrypted
2020-06-17 13:43:52 +02:00
2a5fcc9c25
WIA: Add reading raw data
2020-06-17 13:43:51 +02:00
8da5d0c4fe
Add an early version of WIABlobReader
...
It can currently only read the first 0x80 bytes of a disc image,
which is enough for identifying it but not for doing anything else.
2020-06-17 13:43:51 +02:00
b45f2c2ad3
DolphinQt: Disable convert dialog dropdowns when they have one option
2020-06-17 13:23:58 +02:00
ec3ea6c1df
DolphinQt: Allow converting to same format
...
Mainly useful for WIA and RVZ, but also has some use for GCZ.
2020-06-17 12:44:16 +02:00
864dcd40b5
Revert "DolphinQt: Disable converting from TGC"
...
This reverts commit d006a8b52f
2020-06-17 12:32:40 +02:00
31ecc6c214
Revert "DolphinQt: Actually disable converting from TGC"
...
This reverts commit c236d89f64
2020-06-17 12:32:39 +02:00
75d032161f
DiscIO: Rework the implementation of TGC reading
...
Fixes https://bugs.dolphin-emu.org/issues/10654 .
To quote the documenation file included with the program tgctogcm:
"TGC's are miniaturized .gcm images with a 32kB header.
The embedded gcm contains some bogus data, namely:
-FST Location (0x424 in gcm)
-DOL Location (0x420 in gcm)
-FST File offsets (all files are offset/spoofed by a certain amount)"
Dolphin has been handling the values at 0x420 and 0x424 by simply
overwriting them with a working value (just like tgctogcm does),
but it has used a different approach for the file offsets in the FST.
Instead of changing the offsets that are stored in the FST, Dolphin
changed where the files actually are placed on the virtual disc.
My hope was that this would make the loading times more accurate to
how they are when running a TGC file as part of a larger disc.
However, there are TGC files where we would need to move files
backwards on the disc in order to do this (this is what issue
10654 is about), so the approach we have been using is flawed.
This change makes Dolphin overwrite offsets in the FST instead, like
tgctogcm does. Other than making Dolphin handle the affected TGC files
correctly, this change also makes it so that unnecessary padding data
isn't written if you use Dolphin to convert a TGC file to an ISO file.
This feature is not actually implemented in Dolphin as of now, but I'm
planning to add it in the near future as part of a larger feature.
2020-06-17 12:32:39 +02:00
476c95900d
EXI: When loading a savestate with a mismatching GCI folder memory card, reinizialize it with the header from the savestate to let a game still recognize it as the same card.
2020-06-17 01:44:46 +02:00
8b13e1882a
EXI: Store data for regenerating a GCI folder memory card header in EXI_Channel and pass it down to the memory card device.
2020-06-17 01:44:46 +02:00
e810d492f2
GCMemcard: Split off HeaderData from Header to have a compact block of data for consistent initialization.
2020-06-17 01:44:46 +02:00
cc52558c0e
GCMemcard: Assert struct requirements in header.
2020-06-17 01:30:42 +02:00
07bd200596
GCMemcard: Remove dependency on g_SRAM and force the caller to provide the relevant values instead.
2020-06-17 01:30:37 +02:00
1f505870a9
Merge pull request #8873 from AdmiralCurtiss/gcmemcard-namespace
...
GCMemcard: Move into a Memcard namespace.
2020-06-16 19:55:06 +01:00
de5941d6f8
Merge pull request #8878 from JosJuice/actually-disable-tgc-conversion
...
DolphinQt: Actually disable converting from TGC
2020-06-16 19:39:40 +01:00
914ebdf0dd
GCMemcard: Move from global namespace into a Memcard namespace.
2020-06-16 20:18:39 +02:00
2e1bfe073c
GCMemcard: Split out MemoryCardBase into its own header, which is the base class for the raw and folder memory cards and has little to do with the actual memory card data structures.
2020-06-16 20:18:39 +02:00
c236d89f64
DolphinQt: Actually disable converting from TGC
...
When I made PR 8773, I only covered the case where multiple files
are selected, not the more common case where one file is selected.
Oops
2020-06-16 11:21:44 +02:00
d4418a2b43
Merge pull request #8877 from JosJuice/convert-fail-message
...
DolphinQt: Make conversion error messages actually show up
2020-06-16 09:59:03 +01:00
20a3119d7a
DolphinQt: Make conversion error messages actually show up
...
I don't know why QErrorMessage doesn't work, but ModalMessageBox
works, so let's use ModalMessageBox.
2020-06-16 10:39:40 +02:00
2b25e1d6b9
DolphinQt: Don't show success message when converting missing file
2020-06-16 10:35:00 +02:00
349cdd5136
DolphinQt: Fix crash on right-clicking multiple games
...
GetSelectedGames() constructs a new list each time you call it.
2020-06-16 10:33:18 +02:00
f9f4734237
Merge pull request #8850 from JosJuice/block-size-warning
...
Show an OSD message when running a disc image with a large block size
2020-06-14 15:03:32 +01:00
ad85012172
Merge pull request #8843 from Techjar/fastmem-ui
...
DolphinQt: Add fastmem option to debugger UI
2020-06-14 14:54:32 +01:00
9f5e6edc34
Merge pull request #8809 from Ebola16/ABB
...
Replace some acronyms
2020-06-14 14:30:52 +01:00
2a70d86d55
Replace some acronyms
2020-06-14 08:37:24 -04:00
cb54fc7543
Merge pull request #8857 from JosJuice/qt-bounding-box-width
...
DolphinQt: Use QFontMetrics::boundingRect instead of QFontMetrics::width
2020-06-14 12:10:33 +01:00
0ef9b998ce
Merge pull request #8658 from orbea/glslang
...
Externals: Update glslang.
2020-06-13 18:43:53 +01:00
17498dbb4c
DolReader: if data segment goes off end of file, treat it as zero-fill (bss)
2020-06-09 18:00:24 -07:00
87330ae524
DolphinQt: Use QFontMetrics::boundingRect instead of QFontMetrics::width
...
See https://kdepepo.wordpress.com/2019/08/05/about-deprecation-of-qfontmetricswidth/
2020-06-08 12:32:36 +02:00
595e1197b6
Rename existing BBA to BBA (TAP) to prepare for new BBA
...
Based on work by tommy1019
2020-06-07 23:17:28 -04:00
d5c00b8909
DSPSymbols: fix off-by-one error
2020-06-08 03:41:45 +01:00
162e3be82b
Show an OSD message when running a disc image with a large block size
...
This is intended to catch WIA files which have been created using
wit's default parameters (40 MiB block size), once the WIA PR is
merged. The check does however also work for GCZ files – not that
I think anyone has a GCZ file with a block size that large.
2020-06-07 14:11:00 +02:00
94f317010e
Merge pull request #8847 from Techjar/faster-file-path
...
Qt/GameListModel: Use absolutePath for file path column
2020-06-06 22:56:38 +01:00
d89162c8ad
Merge pull request #8848 from JosJuice/fix-build
...
Fix build
2020-06-06 15:46:32 +02:00
b4584abaa6
Fix build
...
There was a race condition between two PRs incrementing the
array size. CI didn't catch it because the PR that was merged
last (PR #8824 ) wasn't rebuilt after the first PR was merged.
2020-06-06 15:09:48 +02:00
9f7c72b7eb
Merge pull request #8824 from Techjar/sd-read-only
...
Add option to disallow SD card writes
2020-06-06 07:02:02 -04:00
fa208c4acd
Qt/GameListModel: Use absolutePath for file path column
...
canonicalPath is orders of magnitude slower as it has to perform actual
disk I/O to resolve symlinks, which makes sorting by this column
ridiculously slow for large game lists, especially if the games are on
a NAS. We probably don't need that, simply resolving relative paths
should be sufficient.
2020-06-06 05:24:23 -04:00
f1ec4fb70a
DolphinQt: Enable RTL layout
...
Fixes https://bugs.dolphin-emu.org/issues/11508
2020-06-02 22:24:49 +02:00
74ae02f979
DolphinQt: Support gettext contexts (Qt disambiguations)
2020-06-02 22:24:49 +02:00
5c38727651
DolphinQt: Add fastmem option to debugger UI
2020-06-02 06:18:52 -04:00
209308a4d6
Replace usage of std::result_of with std::invoke_result
...
std::result_of is deprecated in C++17, and removed in C++20. Microsoft
has gone ahead with the removal as of Visual Studio 16.6.0, so before
this change our code is broken there.
2020-06-01 17:33:18 -04:00
b0258af530
DSP/Interpreter: fix comments not matching opcode table
2020-05-31 15:21:20 +01:00
198a307db3
DSP/Interpreter: simplify switch
2020-05-31 15:21:20 +01:00
89de40a22e
DSP/Interpreter: remove redundant masking
2020-05-31 15:21:19 +01:00
ba2d04b793
Externals: Fix build failures with the newer glslang.
...
v2: Don't include glslang project wide.
2020-05-30 18:54:21 -07:00
52e0294166
Add option to disallow SD card writes
2020-05-28 15:11:37 -04:00
b3c705fa96
Merge pull request #8829 from stenzek/fix-macos-again
...
Core: Use window instead of surface for ControllerInterface updates
2020-05-28 16:56:13 +10:00
b4e063311e
Merge pull request #8827 from stenzek/adreno-more-like-brokenreno
...
FramebufferManager: Fix invalid readback of EFB D24S8 depth
2020-05-28 16:55:42 +10:00
86f8768268
VideoCommon/ShaderGenCommon: Make template functions regular functions
...
These are only ever used with ShaderCode instances and nothing else.
Given that, we can convert these helper functions to expect that type of
object as an argument and remove the need for templates, improving
compiler throughput a marginal amount, as the template instantiation
process doesn't need to be performed.
We can also move the definitions of these functions into the cpp file,
which allows us to remove a few inclusions from the ShaderGenCommon
header. This uncovered a few instances of indirect inclusions being
relied upon in other source files.
One other benefit is this allows changes to be made to the definitions
of the functions without needing to recompile all translation units that
make use of these functions, making change testing a little quicker.
Moving the definitions into the cpp file also allows us to completely
hide DefineOutputMember() from external view, given it's only ever used
inside of GenerateVSOutputMembers().
2020-05-25 21:12:29 -04:00
e3506ff4ef
VideoCommon/ShaderGenCommon: Convert helper functions over to fmt
...
A very trivial conversion, this simply converts calls to Write over to
WriteFmt and adjusts the formatting specifiers as necessary.
This also allows the const char* parameters to become std::string_view
instances, allowing for ease of use with other string types.
2020-05-25 21:12:29 -04:00
68706973d2
Merge pull request #8828 from stenzek/gles-readpixels
...
FramebufferManager: Copy to color format for depth readbacks on GLES
2020-05-25 08:57:20 +02:00
aaa19acbd0
DSP/Interpreter: simplify opcode table by masking
2020-05-24 15:51:52 +01:00
e651592ef5
Misc cleanup
2020-05-24 15:51:52 +01:00
a660033e8c
Merge pull request #8792 from leoetlino/video-backend
...
Migrate video backend setting to the new config system
2020-05-24 15:26:44 +02:00
1203e626b3
Merge pull request #8800 from sepalani/kd-shutdown
...
IOS/KD: Implement IOCTL_NWC24_REQUEST_SHUTDOWN
2020-05-24 15:24:51 +02:00
166633bf27
Merge pull request #8826 from iwubcode/try_parse_any_base
...
Common / Core: Update StringUtil to allow specifying the base
2020-05-24 15:13:49 +02:00
7449c7153c
Merge pull request #8830 from JosJuice/delete-empty-rfl-db
...
CheckNAND: Delete RFL_DB.dat if empty
2020-05-24 15:12:39 +02:00
f71ebfe9c1
CheckNAND: Delete RFL_DB.dat if empty
2020-05-24 11:04:23 +02:00
ff92357b63
Core: Use window instead of surface for ControllerInterface updates
...
Fixes crashes with Vulkan on macOS.
2020-05-24 17:39:56 +10:00
bf74553878
FramebufferManager: Copy to color format for depth readbacks on GLES
...
glReadPixels() with depth formats is not supported.
Should fix broken EFB access on GLES.
2020-05-24 16:11:11 +10:00
ad373950a2
FramebufferManager: Fix invalid readback of EFB D24S8 depth
...
Fixes assertion tripping when saving state on Adreno.
2020-05-24 15:36:04 +10:00
85e11cd4ab
Common / Core: Update StringUtil to allow specifying the base, default to 0. Fix ActionReplay code to use this instead of prepending '0x' in front
2020-05-23 18:40:10 -05:00
1df1a9abe6
IOS/KD: Implement IOCTL_NWC24_REQUEST_SHUTDOWN
2020-05-22 19:19:36 +04:00
8df56cb319
Migrate video backend setting to the new config system
...
Fixes https://bugs.dolphin-emu.org/issues/12087
2020-05-22 16:54:53 +02:00
393ce529af
Merge pull request #8771 from Leseratte10/master
...
Add /dev/dolphin interface to allow game to read the REAL product code
2020-05-22 16:49:31 +02:00
6d3b0db041
DolphinQt: Fix freelook description typos
...
cControls -> controls, axis -> axes, removed leading spaces.
2020-05-20 21:56:04 +02:00
cc330afa6b
DolphinQt: Fix the panic alert deadlock, Pause on Focus Loss edition
...
why are there so many ways to trigger this issue
2020-05-18 19:38:56 +02:00
abe125aea7
Merge pull request #8816 from JosJuice/qfontmetrics-width
...
DolphinQt: Remove another usage of QFontMetrics::width
2020-05-18 00:19:41 +01:00
f87e32840f
DolphinQt: Remove another usage of QFontMetrics::width
...
QFontMetrics::width breaks building with CMake on Windows,
due to a deprecation warning which gets promoted to an error.
2020-05-18 00:39:57 +02:00
10870a0f74
Config: Migrate SSL options to Onion config
2020-05-17 20:37:10 +01:00
2250fbce0e
Merge pull request #8802 from leoetlino/wiiroot-mii-db
...
WiiRoot: Fix empty files being created when source is missing
2020-05-17 20:11:11 +02:00
099197b480
Merge pull request #8797 from iwubcode/save-state-CLI
...
Core: Add support for booting a save state from command line
2020-05-17 17:34:08 +02:00
cea779cc84
Merge pull request #8767 from iwubcode/freelook-camera-type
...
Expand freelook camera with control options
2020-05-17 17:33:04 +02:00
2137fb7813
Externals: Add zstd
...
I had to rename Source/Common/Compiler.h because the VS build
confuses it with Externals/zstd/lib/common/compiler.h otherwise.
2020-05-13 20:53:10 +02:00
4bf7c3e051
NetworkWidget: Add Blocking column
2020-05-13 11:53:29 +04:00
ac9b246809
Core/UICommon: Fix EnableScreenSaver preprocessor directive
...
The include for X11Utils.h (and by extension Xlib.h) is gated behind
HAVE_XRANDR, as well as the declaration for this function, but its
definition was mistakenly gated behind HAVE_X11. Therefore, if we have
X11 but not Xrandr, the build will fail due to declaration/definition
mismatch and the missing Window type.
2020-05-13 02:11:29 -04:00
2488e4a587
Merge pull request #8795 from WamWooWam/master
...
InputCommon: Use the Window handle when initializing DirectInput.
2020-05-10 19:16:15 +10:00
daf1c30a94
GCAdapter: add libusb error logging on reads/writes
2020-05-10 09:26:49 +02:00
76ae1d4070
Apply fixes to all platforms
2020-05-09 22:35:20 +01:00
47ee5ac284
WiiRoot: Fix empty files being created when source is missing
...
CopyNandFile must not create empty files on the destination filesystem
if the source file doesn't exist.
Otherwise, this can lead to an empty Mii database being created in the
session Wii root if there's no database in the configured Wii root and
netplay or Movie is used -- that database would then be copied back to
the configured root, which causes games like MKW to complain about
corrupted Mii data even when the player has stopped using netplay.
This commit also simplifies CreateFullPath usage.
There's no need to manually extract the directory from the path,
FS::CreateFullPath does it automatically just like File::CreateFullPath
2020-05-09 16:47:45 +02:00
cdf5490d56
Core: Add support for specifying a command line option to boot the game into a save-state
2020-05-06 22:10:30 -05:00
74b2410d7e
Merge pull request #8760 from JosJuice/multithreaded-compress
...
DiscIO: Implement multithreaded compression
2020-05-06 15:25:30 +02:00
b93bbbf2e5
DiscIO: Implement multithreaded compression
2020-05-06 14:18:51 +02:00
78e8ccea6d
Update ControllerInterface.cpp
2020-05-06 01:30:49 +01:00
bb75050f68
Jit: fix warning -Winvalid-offsetof
...
Remove the warning:
warning: offsetof within non-standard-layout type ‘JitBlock’ is conditionally-supported
JitBlock contains non-trival types now. Split the fields with trival
types that needs to be access from JIT code into JitBlockData structure.
2020-05-04 18:26:56 +02:00
7c0ef725ab
Merge pull request #8744 from cristian64/save_restore_netplay_browser_settings
...
DolphinQt: Saving and restoring NetPlay Session Browser dialog's settings.
2020-05-04 00:50:26 +02:00
c53ecdd689
Merge pull request #8686 from sepalani/thread-tab
...
Debugger: Add a Thread widget
2020-05-04 00:50:10 +02:00
947d6732a8
Merge pull request #8712 from sepalani/console-type
...
Boot: Add ConsoleType enum class
2020-05-03 23:10:44 +02:00
9e2560b825
Merge pull request #8790 from leoetlino/ras-syndrome
...
Remove redundant "Emulation" from "DSP HLE Emulation"
2020-05-03 16:47:05 -04:00
aed7319ef8
DolphinQt: Expose freelook camera control to UI
2020-05-03 13:34:13 -05:00
e125c61d47
VideoCommon: remove VertexShaderManager functions instead preferring the direct freelook camera methods
2020-05-03 13:34:13 -05:00
5bd7cc8bac
Core: Add freelook camera control type setting
2020-05-03 13:34:13 -05:00
6e7d1e0e71
VideoCommon: Add Free Look camera with separate modes
2020-05-03 13:31:47 -05:00
bf12bb3d43
Boot: Add ConsoleType enum class
2020-05-03 20:55:09 +04:00
39d34e133f
Debugger: Add a Thread widget
...
DebugInterface: Add GetThreads
WatchWidget: Update widget on AddWatch
2020-05-03 20:48:30 +04:00
9ffa72ad1f
Merge pull request #8691 from howard0su/warning_wiimote
...
WiimoteEmu: Cleanup warnings of -Wparentheses
2020-05-03 18:31:57 +02:00
297bbceadf
Remove redundant "Emulation" from "DSP HLE Emulation"
...
HLE stands for "high-level emulation", so "DSP HLE Emulation" would
mean "DSP High-Level Emulation Emulation"
2020-05-03 17:54:05 +02:00
16f0864a4f
DolphinQt: Saving and restoring NetPlay Session Browser dialog's settings.
2020-05-03 17:45:52 +02:00
907b1302b0
Merge pull request #8775 from leoetlino/rect
...
MathUtil: Fix Rectangle::GetWidth/Height for unsigned types
2020-05-03 15:41:38 +02:00
920cf38889
Merge pull request #8757 from sepalani/so-cleanup
...
IOS/KD: Cleanup sockets on IOCTL_NWC24_CLEANUP_SOCKET
2020-05-03 15:41:14 +02:00
1b26929119
Merge pull request #8789 from JosJuice/windows-cmake-errors
...
Fix Windows CMake build errors
2020-05-03 15:33:58 +02:00
07ab79db64
MathUtil: Fix Rectangle::GetWidth/Height for unsigned types
...
`std::abs(x - y)` where x and y are unsigned integers fails to compile
with an "call of overloaded 'abs(unsigned int)' is ambiguous" error
on GCC, and even if it did compile, that expression still wouldn't
give the correct result since `x - y` is unsigned.
2020-05-03 14:41:58 +02:00
0ab9475f8e
Merge pull request #8786 from JosJuice/user-style-not-path
...
DolphinQt: Store name of user style, not path
2020-05-03 14:11:55 +02:00
bf57abc0d5
Fix Windows CMake build errors
...
Lambda expressions with uncaptured constants were leading to errors,
and there were also some warnings about deprecated functions
(QFontMetrics::width and inet_ntoa).
2020-05-03 14:10:24 +02:00
90ba73c6c2
Merge pull request #8787 from leoetlino/config-config
...
Remove redundant Config prefix from ConfigInfo/ConfigLocation
2020-05-03 14:07:41 +02:00
f27278f7f4
Add /dev/dolphin interface to allow game to read the REAL product code
2020-05-03 09:46:01 +02:00
19da101164
Remove redundant Config prefix from ConfigInfo/ConfigLocation
...
Both structs are already in the Config namespace.
2020-05-02 14:40:14 +02:00
aab694e6b5
DolphinQt: Store name of user style, not path
...
This makes user styles not break when for instance
moving a portable.txt install between different folders.
2020-05-02 02:13:01 +02:00
47d1dec723
Merge pull request #8783 from JosJuice/i18n-comments
...
DolphinQt: Add some i18n comments for recently added strings
2020-05-02 02:12:27 +02:00
9932a02565
IOS/KD: Cleanup sockets on IOCTL_NWC24_CLEANUP_SOCKET
2020-05-01 16:33:42 +04:00
423241b8a2
DolphinQt: Reword memory override description
2020-05-01 14:11:08 +02:00
b7db7ebbc7
Don't assume fixed width for "Emulated memory size mismatch!" message
...
Panic alerts don't use fixed width fonts, and translators are
unlikely to preserve the exact spacing unless they are given
specific instructions to do so and are willing to fight against
the Transifex interface a bit.
2020-05-01 13:40:34 +02:00
492bb5ccee
DolphinQt: Add some i18n comments for recently added strings
2020-05-01 13:22:54 +02:00
312a3ba8c8
WiimoteEmu: Cleanup warnings of -Wparentheses
...
Add parentheses around operator ^.
2020-04-30 08:07:02 +08:00
9fd1385733
Externals: Fix OpenAL include directory.
2020-04-29 13:07:51 +02:00
fc0df37d94
Fix windows build system.
2020-04-29 12:56:52 +02:00
990acbb17d
Externals: Fix ed25519 include path.
2020-04-29 12:55:42 +02:00
f8f592c345
Externals: Update minizip search path.
2020-04-29 12:41:36 +02:00
ae2d567f59
Externals: Fix include path for picojson and discord
2020-04-29 11:45:59 +02:00
239cde8aea
Externals: Alter the soundtouch include directory.
...
We must not provide the /Externals directory as global include directory.
Here, this yield a crash because of external minizip header and system library mismatch.
Soundtouch itself recormends to include it with <SoundTouch.h> and -I/usr/include/soundtouch, so this should fit better.
2020-04-29 11:30:26 +02:00
b7db359081
XFMemory: SETPOSMTXINFO should be SETPOSTMTXINFO
...
It actually maps to postMtxInfo, not posMtxInfo (which isn't a thing).
This is especially confusing because there *are* position matrices (as
opposed to post-transform matrices).
2020-04-29 05:26:02 +02:00
2a7f150561
Merge pull request #8774 from JosJuice/volumeverifier-ios9
...
VolumeVerifier: Treat IOS9 as always present
2020-04-28 21:24:44 -04:00
e921cbe57c
GCMemcardManager: Add GUI to create new memory card.
2020-04-28 23:59:15 +02:00
5b722b775a
VolumeVerifier: Treat IOS9 as always present
...
Fixes a false positive for Mario Party 8.
2020-04-28 23:40:01 +02:00
4b00ddf9aa
Merge pull request #8722 from Minty-Meeo/master
...
Configurable MEM1 and MEM2 sizes at runtime via Dolphin.ini
2020-04-28 22:11:12 +02:00
cc858c63b8
Configurable MEM1 and MEM2 sizes at runtime via Dolphin.ini
...
Changed several enums from Memmap.h to be static vars and implemented Get functions to query them. This seems to have boosted speed a bit in some titles? The new variables and some previously statically initialized items are now initialized via Memory::Init() and the new AddressSpace::Init(). s_ram_size_real and the new s_exram_size_real in particular are initialized from new OnionConfig values "MAIN_MEM1_SIZE" and "MAIN_MEM2_SIZE", only if "MAIN_RAM_OVERRIDE_ENABLE" is true.
GUI features have been added to Config > Advanced to adjust the new OnionConfig values.
A check has been added to State::doState to ensure savestates with memory configurations different from the current settings aren't loaded. The STATE_VERSION is now 115.
FIFO Files have been updated from version 4 to version 5, now including the MEM1 and MEM2 sizes from the time of DFF creation. FIFO Logs not using the new features (OnionConfig MAIN_RAM_OVERRIDE_ENABLE is false) are still backwards compatible. FIFO Logs that do use the new features have a MIN_LOADER_VERSION of 5. Thanks to the order of function calls, FIFO logs are able to automatically configure the new OnionConfig settings to match what is needed. This is a bit hacky, though, so I also threw in a failsafe for if the conditions that allow this to work ever go away.
I took the liberty of adding a log message to explain why the core fails to initialize if the MIN_LOADER_VERSION is too great.
Some IOS code has had the function "RAMOverrideForIOSMemoryValues" appended to it to recalculate IOS Memory Values from retail IOSes/apploaders to fit the extended memory sizes. Worry not, if MAIN_RAM_OVERRIDE_ENABLE is false, this function does absolutely nothing.
A hotfix in DolphinQt/MenuBar.cpp has been implemented for RAM Override.
2020-04-28 12:10:50 -05:00
d006a8b52f
DolphinQt: Disable converting from TGC
...
This should not be exposed to users before the merge of PR #8644 .
(PR #8738 was unintentionally merged before PR #8644.)
2020-04-28 18:49:52 +02:00
116cef572b
Merge pull request #8738 from JosJuice/convert-dialog
...
Replace the compress/uncompress actions with a convert dialog
2020-04-28 12:37:17 -04:00
165c2e3017
Merge pull request #8772 from JosJuice/create-backup-dir
...
Core: Call CreateFullPath before using Backup directory
2020-04-28 12:35:05 -04:00
95a0897491
Core: Call CreateFullPath before using Backup directory
2020-04-28 17:53:12 +02:00
ee200d09eb
Jit64/Jit64_Tables: Construct tables at compile-time
...
Utilizing constexpr, we can eliminate the need to construct the tables
at runtime and just do all the work at compile-time. Making for less
moving parts overall.
The general structure is more or less the same, however rather than one
single initialization function, each table is built off an immediately
executed lambda function. This is nice, since it narrows the scope of
the table building logic down to the tables that actually need it.
2020-04-28 17:12:24 +02:00
19115c84dd
DolphinQt: Use qOverload where applicable
...
Provides the same behvaior, but in a much more concise manner.
2020-04-28 16:54:19 +02:00
8288bdce03
Fix Hotkey Controller Profile display with boxes for each Wiimote
2020-04-28 15:55:53 +02:00
93abbc66aa
Merge pull request #8688 from howard0su/cleanup_strncpy
...
Remove warning of -Wstringop-truncation
2020-04-28 14:28:30 +02:00
7390767008
Merge pull request #8668 from sepalani/rso-autodetect
...
RSO: Auto-detect RSO location in RAM
2020-04-28 14:27:13 +02:00
0fe4985f8d
Merge pull request #8689 from howard0su/cleanup_sign
...
Remove warnings of -Wsign-compare
2020-04-28 13:36:21 +02:00
f3d7b82f83
Cleanup warnings of -Wswitch
...
Add default branch to the switch-case.
2020-04-28 13:16:30 +02:00
586af0a55e
Merge pull request #8695 from howard0su/warning_hw
...
HW: cleanup warnings of -Wtype-limits
2020-04-28 13:13:22 +02:00
8f578fd2b9
Merge pull request #8704 from JosJuice/setting-txt-output-null
...
SettingsHandler: Don't output null bytes
2020-04-28 12:02:39 +02:00
5e33cd48da
Debugger: Add a Network widget
...
Display socket table, SSL context and options
2020-04-27 21:47:00 +04:00
88ae4c7914
Merge pull request #8729 from JosJuice/android-touch-ir-default
...
Android: Use touch emulation of IR by default
2020-04-27 17:56:01 +02:00
5909d13236
Merge pull request #8710 from Ebola16/QTDP
...
Qt: Display default Paths
2020-04-27 17:49:31 +02:00
e6351e1d4b
Merge pull request #8719 from CookiePLMonster/dolby-pro-logic-quality-fixup-ii
...
AudioPane: Do not enable DPL II quality slider with HLE audio on init
2020-04-27 17:11:56 +02:00
18a4afb053
Android: Use touch emulation of IR by default
...
While having motion control emulation of IR enabled by default
makes sense in situations like using a DualShock 4 on a PC,
Android has the additional option of touch emulation of IR
which seems to be better liked, and the default value which
was chosen with PC in mind was carried over to Android
without any particular consideration. This change disables
motion control emulation of IR by default on Android only.
2020-04-27 17:02:53 +02:00
1ca682e6a1
Merge pull request #8723 from seanyeh/fix-confirm-dialog-enter
...
Qt/GameList: Use KeyPress instead of KeyRelease
2020-04-27 17:00:58 +02:00
71f409dac4
Merge pull request #8726 from xperia64/dns_improvements
...
Respect Core::WantsDeterminism for DNS servers on Linux
2020-04-27 16:43:24 +02:00
9d44af4c31
Merge pull request #8696 from howard0su/cleanup_shadow
...
Cleanup warnings of -Wmissing-declarations
2020-04-27 15:33:01 +02:00
bab04155b6
Merge pull request #8745 from AdmiralCurtiss/savestate-load-callback-qt
...
Qt/Debugger: Refresh on savestate load.
2020-04-27 15:29:55 +02:00
75e79ece73
Merge pull request #8751 from jordan-woyak/point-fix
...
WiimoteEmu: Apply "Tilt" and "Point" rotations separately for proper tilted pointing.
2020-04-27 14:55:19 +02:00
bacf0d629d
VolumeVerifier: Show desync warning for dual layer discs too
2020-04-25 19:47:08 +02:00
99c8ce9d8d
DolphinQt: Add info about formats in convert dialog
2020-04-24 15:11:20 +02:00
466b2d7202
DolphinQt: Make block size configurable in convert dialog
2020-04-24 15:11:20 +02:00
acd00723ad
DolphinQt: Make scrubbing configurable in convert dialog
2020-04-24 15:11:20 +02:00
6ffcbcee70
DiscIO: Move scrubbing code out of ConvertToGCZ
...
This way, scrubbing can also be performed when converting
to other formats.
2020-04-24 15:11:20 +02:00
04c7892b93
DiscIO: Add GameCube disc scrubbing support
...
The code was actually already rather well adapted for this.
We more or less just have to skip ParseDisc and run
ParsePartitionData directly. This required the PartitionHeader
struct to be removed (which wasn't that useful anyway).
2020-04-24 15:10:36 +02:00
cefc2a7baa
DiscIO: Fix edge case where blocks could get scrubbed accidentally
...
If we start 31 KiB into a 32 KiB block and want to mark 2 KiB
of data as used, we need to mark 2 blocks as used, not just 1.
This problem is avoided when calling MarkAsUsed from
MarkAsUsedE, since MarkAsUsedE aligns to 32 KiB on its own.
Most calls to MarkAsUsed are from MarkAsUsedE, which is why
this hasn't been a noticeable problem in the past.
2020-04-24 15:10:36 +02:00
dae2c14f7f
DolphinQt: Turn the compress/decompress action into a dialog
2020-04-24 15:10:35 +02:00
42f6913bcc
Move DiscIO::ConvertToPlain to FileBlob.cpp
...
There is no longer anything GCZ specific about it.
2020-04-24 15:10:35 +02:00
8a9597e32e
DiscIO: Allow converting from formats other than ISO and GCZ
...
The constant DESIRED_BUFFER_SIZE was determined by multiplying the
old hardcoded value 32 with the default GCZ block size 16 KiB.
Not sure if it actually is the best value, but it seems fine.
2020-04-24 15:10:35 +02:00
432f342bc8
DiscIO: Use a struct for Wii hashes
2020-04-24 14:44:29 +02:00
da9e0fb598
DiscIO: Parallelize the re-encryption code
2020-04-24 14:44:26 +02:00
319c508978
DiscIO: Implement re-encryption of Wii partition data
2020-04-24 14:24:12 +02:00
a4c7100bcc
DiscIO: Use partition data offset for ReadWiiDecrypted parameter
...
Instead of the partition offset (which is usually 0x20000 less).
2020-04-24 14:16:55 +02:00
7e94d6ed37
Merge pull request #8740 from JosJuice/fix-decompress
...
DiscIO: Fix decompressing writing the wrong number of bytes sometimes
2020-04-24 10:42:46 +02:00
703f7d4fc0
Merge pull request #8755 from Sintendo/jit64intopts
...
Jit64: More addx and subfx optimizations
2020-04-24 07:40:07 +02:00
523954e03a
Analytics: Report correct quirk for mismatched xf/bp colors
...
Looks like a copy-paste error. The quirk for mismatched xf/bp texgens
was used twice.
2020-04-24 02:22:51 +02:00
2673280614
Merge pull request #8389 from sepalani/fix-so
...
Socket: Abort pending ops on close
2020-04-22 07:19:25 +02:00
5ec80a554c
Socket: Abort pending operations on close
2020-04-22 08:48:37 +04:00
a5bd263dfb
Merge pull request #8714 from JosJuice/progress-dialog-thread
...
DolphinQt: Run tasks that use progress dialogs on separate threads
2020-04-21 23:59:37 -04:00
19dda51a0d
Jit64: subfx - Use LEA when possible
...
Similar to what we do for addx. Since we're calculating b - a and
because subtraction is not communitative, we can only apply this when
source register a holds the constant.
Before:
45 8B EE mov r13d,r14d
41 83 ED 08 sub r13d,8
After:
45 8D 6E F8 lea r13d,[r14-8]
2020-04-21 22:45:47 +02:00
89646c898f
Jit64: addx - Skip ADD after MOV when possible
...
We can get away with skipping the addition when we know we're dealing
with a constant zero. Just a MOV will suffice in this case.
Once again, we don't bother to add separate handling for when overflow
is needed, because no titles would ever hit that path during my testing.
Before:
8B 7D F8 mov edi,dword ptr [rbp-8]
83 C7 00 add edi,0
After:
8B 7D F8 mov edi,dword ptr [rbp-8]
2020-04-21 22:45:47 +02:00
50f7a7d248
Jit64: addx - Prefer smaller MOV+ADD sequence
...
ADD has a smaller encoding for immediates that can be expressed as an
8-bit signed integer (in other words, between -128 and 127). MOV lacks
this compact representation.
Since addition allows us to swap the source registers, we can always get
the shortest sequence here by carefully checking if we're dealing with a
small immediate first. If we are, move the other source into the
destination and add the small immediate onto that. For large immediates
the reverse is preferrable.
Before:
41 BE 40 00 00 00 mov r14d,40h
44 03 75 A8 add r14d,dword ptr [rbp-58h]
After:
44 8B 75 A8 mov r14d,dword ptr [rbp-58h]
41 83 C6 40 add r14d,40h
Before:
44 8B 7D F8 mov r15d,dword ptr [rbp-8]
41 81 C7 00 68 00 CC add r15d,0CC006800h
After:
41 BF 00 68 00 CC mov r15d,0CC006800h
44 03 7D F8 add r15d,dword ptr [rbp-8]
2020-04-21 22:42:02 +02:00
2481660519
Jit64: addx - Emit MOV when possible
...
When the source registers are a simple register and a constant zero and
overflow isn't needed, emitting LEA is kinda silly.
This will occasionally save a single byte for certain registers due to
how x86 encoding works. More importantly, LEA takes up execution
resources while MOV does not.
Before:
41 8D 7D 00 lea edi,[r13]
After:
41 8B FD mov edi,r13d
2020-04-21 22:36:20 +02:00
1c25e6352a
Jit64: addx - Emit nothing when possible
...
When the destination register matches a source register, the other
source register contains zero, and overflow isn't needed, the
instruction becomes a nop and we don't need to emit anything.
We could add specialized handling for the case where overflow is needed,
but none of the titles I tried would hit this path.
Before:
83 C7 00 add edi,0
After:
2020-04-21 22:35:17 +02:00
f1c3ab359d
Jit64: addx - Deduplicate branches part 2
...
No functional change, just simplify some repeated logic in the case
where we're dealing with exactly one immediate and one simple register
when overflow isn't needed.
2020-04-21 22:06:46 +02:00
72fbdf1a6b
Jit64: addx - Deduplicate branches part 1
...
No functional change, just simplify some repeated logic for the cases
where the destination register matches one of the sources.
2020-04-21 22:06:39 +02:00
c33565295d
Merge pull request #8713 from sepalani/dbg-printf
...
HLE: Add more debug functions
2020-04-21 12:58:34 -04:00
d845b31579
Merge pull request #8717 from stenzek/mismatched-xf-bp
...
VertexManagerBase: Skip drawing objects with mismatched xf/bp stages
2020-04-21 10:07:36 -04:00
d6dfb3a553
WiimoteEmu: Rename some variables from "cursor" to "point".
2020-04-18 13:20:50 -05:00
bd067875e7
WiimoteEmu: Apply "Tilt" rotations separately and before those of "Point" and "Swing" for proper tilted pointing.
2020-04-18 13:15:52 -05:00
b2cf106ae9
IOS/FS: Fix FST write failure on some platforms
...
On some platforms (like Windows), the temporary file must be closed
before it can be renamed.
I guess nobody noticed this for so long because (1) the FS code has a
failsafe for missing FST entries (because existing users do not have
a FST), and most games do not care about file metadata;
(2) the write failures can only be seen in the logs.
Because we don't want this to break, I have turned the ERROR_LOGs into
PanicAlerts.
2020-04-18 12:42:12 +02:00
9de3717c50
Merge pull request #8340 from stenzek/max-res
...
DolphinQt: Don't overwrite >8x IR scale in ini, add maximum internal res option
2020-04-16 21:01:14 -04:00
935b12d785
Merge pull request #8730 from JosJuice/frame-advance-duplicate-frame
...
Core: Skip duplicate frames when using frame advance
2020-04-16 18:29:16 -04:00
85a8325701
Merge pull request #8733 from JosJuice/di-baten-kaitos
...
Adjust s_DIMAR/s_DILENGTH behavior (fixes Baten Kaitos music)
2020-04-16 18:28:09 -04:00
19fc43f190
Merge pull request #8708 from Ebola16/Wii
...
Android: Add Insert SD Card and update the description
2020-04-16 18:27:51 -04:00
55ed980620
Merge pull request #8711 from Ebola16/SDDE
...
Set Insert SD Card default value to true
2020-04-16 18:25:47 -04:00
3629e75dd2
Merge pull request #8716 from Pokechu22/properties-leak
...
Delete properties dialog on close
2020-04-16 13:53:37 +02:00
19e9a9c945
DiscIO: Clean up decompression size calculation
...
We can use subtraction and std::min instead of
modulo and explicit if statements.
This commit does not change the behavior.
2020-04-15 22:15:40 +02:00
330c80055d
Qt/Debugger: Refresh windows on savestate load.
2020-04-15 00:12:35 +02:00
744abab478
Merge pull request #8741 from cristian64/add_checkbox_to_filter_ingame_netplay_sessions
...
DolphinQt: Added checkbox to filter out NetPlay sessions that are already in-game.
2020-04-13 08:52:23 -04:00
c0ae9cbc45
Merge pull request #8584 from jordan-woyak/widescreen-heuristic-fix
...
VideoCommon: Tweak widescreen heuristic.
2020-04-13 05:57:19 -04:00
bb99062f18
IOS/USBHost: Skip starting threads when determinism is enabled
...
The threads can't actually be started when determinism is enabled, as
the behavior would not be deterministic, but Open() still tries to
start the threads and wait, resulting in a deadlock when booting
certain games and homebrew in NetPlay.
2020-04-12 23:44:53 -04:00
dab4f8b36e
DolphinQt: Added checkbox to filter out NetPlay sessions that are already in-game.
2020-04-13 00:42:03 +02:00
3aa463cdae
DiscIO: Fix decompressing writing too much sometimes
...
This issue cannot happen with good dumps due to their size,
but it can happen with trimmed dumps.
2020-04-12 21:47:10 +02:00
26b21e3186
DiscIO: Fix decompressing writing too little sometimes
...
This issue cannot happen with good dumps due to their size,
but it can happen with trimmed dumps.
2020-04-12 21:45:55 +02:00
d3dc81ba74
Fix bug 11920
...
DSP LLE Interpreter does not have a DSP thread, so trying to wait would hang. (DSP LLE recompiler also has no thread when in determinism mode).
2020-04-10 12:15:06 -07:00
b2c9149cf8
Remove outdated comment from Movie::FrameUpdate
...
9c5c3c0
2020-04-10 00:18:53 +02:00
94f83db2b5
Adjust s_DIMAR/s_DILENGTH behavior (fixes Baten Kaitos music)
...
https://bugs.dolphin-emu.org/issues/11997
The problem seemed to be that s_DILENGTH would get set to 0
at times when it shouldn't. Simply not changing it in case
of NoReply or DTK seems to fix the problem. However, we can
actually go one step further in accuracy and use data.size()
to change s_DIMAR and s_DILENGTH as partial reads (NoReply
commands) complete, instead of jumping directly to 0 when
the whole read completes.
2020-04-09 22:13:45 +02:00
812ad4257c
Core: Skip duplicate frames when using frame advance
...
It used to be the case that frame advance skipped duplicate frames
(i.e. it would take 30 frame advances to get through one second
of emulated time in a 30 fps game), but this broke in 9c5c3c0
2020-04-09 11:39:29 +02:00
1a42355f96
Core: Clarify Callback_VideoCopiedToXFB and FrameUpdate
2020-04-09 00:21:04 +02:00
9a2d8a9623
Merge pull request #8715 from JosJuice/panic-alert-deadlock
...
DolphinQt: Fix the panic alert deadlock (a.k.a. "Question" issue)
2020-04-08 17:20:32 -04:00
a2f4fafe86
Vulkan: Switch from vkCreateMacOSSurfaceMVK() to vkCreateMetalSurfaceEXT()
...
Since we are calling this off the UI thread, we can't use anything which
accesses the underlying NSView object. We create and set the Metal layer
on the UI thread before the video backend is initialized. This extension
is both compatible with MoltenVK and gfx-portability for accepting a
layer at surface creation.
2020-04-07 18:56:55 +10:00
b4e49dc656
Respect Core::WantsDeterminism for DNS on Linux
...
Previously Core::WantsDeterminism was only checked for setting the DNS on WIN32.
Same check should apply to Linux too.
2020-04-06 15:45:43 -04:00
74d8697ea3
Qt/GameList: Use KeyPress instead of KeyRelease
...
This fixes a bug where pressing Enter in the "Do you want to stop the
current emulation?" confirmation popup also triggers a KeyRelease in
GameList, which starts a new game.
2020-04-03 23:01:21 -05:00
55f787b898
Remove unused function Host_UpdateProgressDialog
2020-04-03 12:53:38 +02:00
c6ee767851
DolphinQt: Run tasks that use progress dialogs on separate threads
2020-04-03 12:53:38 +02:00
e11a2bda56
Delete properties dialog on close
...
Fixes the game file being locked until Dolphin closes.
2020-04-02 16:14:37 -07:00
ff7180cac4
Analytics: Add quirk for mismatched xf/bp texgens/colors
2020-04-02 12:52:16 +10:00
a9c1dcf656
VertexManagerBase: Skip drawing objects with mismatched xf/bp stages
...
Hardware tests have shown that if the number of texgens/channels do not
match, you get garbage rendering. Presumably because the output
registers from the XF stage are fed into the incorrect input registers
for TEV/BP.
Currently, this causes Dolphin to crash/generate invalid shaders with an
assertion failure in the hardware backends. Instead, we log an error.
Perhaps in the future we should just spit out all texgens/colors anyway
from both stages, and let cross-stage optimization take care of DCE'ing
it away. But doing so would require changing the UIDs and invalidating
everyone's shader caches.
2020-04-02 12:51:41 +10:00
bb27da06ae
AudioPane: Do not enable DPL II quality slider with HLE audio on init
2020-04-01 22:40:45 +02:00
ef778723a2
DolphinQt: Fix the panic alert deadlock (a.k.a. "Question" issue)
2020-03-31 21:00:32 +02:00
a3ff20a5f9
Android: Add Insert SD Card and update description
2020-03-31 14:58:00 -04:00
85cd59c585
HLE: Add more debug functions
2020-03-30 17:46:50 +04:00
fdc9ea6ca0
Set Insert SD Card default value to true
2020-03-30 06:15:17 -04:00
999e651ed5
Qt: Display default Paths
2020-03-30 06:06:38 -04:00
5988d20917
Merge pull request #8698 from howard0su/warning_capture
...
Cleanup warnings of -Wunused-lambda-capture
2020-03-26 10:37:33 +01:00
81f8099cc6
Remove warnings of -Wsign-compare
...
Cast the variable to the coresponding type.
2020-03-25 07:57:14 +08:00
5d6f23e424
SettingsHandler: Don't output null bytes
...
https://bugs.dolphin-emu.org/issues/12019 , take two.
2020-03-24 17:01:15 +01:00
651595c521
Merge pull request #8701 from howard0su/static_wiimote
...
Wiimote: Cleanup warnings of -Wmissing-variable-declarations
2020-03-24 23:14:46 +10:00
7885fdb1ae
Remove warning of -Wstringop-truncation
...
Fix the right length when strncpy. And use specific version of copy
to copy GameID.
2020-03-24 20:26:20 +08:00
b6ff15c130
Cleanup warnings of -Wmissing-declarations
...
Add static to the functions which is not intentionally
export to big scope.
2020-03-24 20:16:10 +08:00
da223a2271
Cleanup warnings of -Wunused-lambda-capture
...
Remove unused lambda captures.
2020-03-24 20:14:10 +08:00
9dec1e9998
use s_ prefix for local variables
2020-03-24 20:13:20 +08:00
5b10f4b71e
Merge pull request #8673 from JosJuice/preserve-setting-txt
...
Boot: Do a better job of preserving certain parts of settings.txt
2020-03-24 10:16:17 +01:00
b3ad3c3b07
Merge pull request #8683 from AlexApps99/cmdl
...
Parse arguments before Qt
2020-03-24 10:02:24 +01:00
323bffed01
Merge pull request #8700 from howard0su/add_override
...
NoGUI: missing override in PlatformX11
2020-03-24 18:34:48 +10:00
3f72bc3e7e
HW: cleanup warnings of -Wtype-limits
...
ROM_BASE is 0, and address is unsigned. It is always
true that address >= 0. So just compare with ROM_SIZE
and don't use IN_RANGE macro to avoid the warning.
2020-03-24 09:11:24 +08:00
76b97a4183
Merge pull request #8680 from Leseratte10/master
...
SettingsHandler: Always decode the whole settings.txt file
2020-03-24 00:21:29 +01:00
aee9c7390d
Merge pull request #8699 from howard0su/cleanup_move
...
Cleanup warnings of -Wpessimizing-move
2020-03-23 19:58:13 +01:00
a6d1fe59a3
Merge pull request #8693 from howard0su/warning_xinpu
...
InputCommon: cleanup warnings of -Wclass-memaccess
2020-03-23 19:18:08 +01:00
6fab09951b
Merge pull request #8692 from howard0su/warning_unused
...
Cleanup warnings of -Wunused-[const]-variable
2020-03-23 19:10:52 +01:00
623a50786d
Merge pull request #8702 from sl1pkn07/Qt5.15
...
Fix build with Qt 5.15+
2020-03-23 18:35:09 +01:00
4f7ea79ae4
Fix build with Qt 5.15+
2020-03-23 17:58:39 +01:00
0bd6016ad0
Wiimote: Cleanup warnings of -Wmissing-variable-declarations
...
While I am here, make g_wiimote_scanner as static as well.
2020-03-23 16:43:21 +08:00
fb7fbb4a7b
NoGUI: missing override keyword GetWindowSystemInfo
2020-03-23 16:35:45 +08:00
964a2e1e70
Cleanup warnings of -Wpessimizing-move
...
moving a temporary object prevents copy elision. Remove std::move.
2020-03-23 16:31:15 +08:00
500820b352
Cleanup warnings of -Wunused-const-variable
2020-03-23 16:28:25 +08:00
997cfa49fc
InputCommon: cleanup warnings of -Wclass-memaccess
...
Initialize m_state with the default constructor.
2020-03-23 14:26:36 +08:00
7c7a41ecd8
Cleanup warnings of -Wunused-variable
...
remove unused variables.
2020-03-23 14:24:27 +08:00
d44c51b30c
DiscIO: cleanup warnings of -Wmaybe-uninitialized
...
replace {} with std::nullopt.
2020-03-23 14:14:00 +08:00
d6fb0b44d7
Parse arguments before Qt
2020-03-22 17:49:32 +13:00
9ec5391bfb
Improve "Generate Symbols From > RSO Modules"
...
Add auto-detection option
2020-03-21 12:03:12 +04:00
303b18ddaf
Qt/CodeWidget: Typo in settings key.
2020-03-20 20:51:26 +01:00
cba4acc54b
SettingsHandler: Always decode the whole settings.txt file
2020-03-20 16:08:25 +01:00
9ac28054df
Merge pull request #8678 from JosJuice/setting-txt-code-default
...
Boot: Change pre-defined setting.txt CODE values
2020-03-20 02:06:07 -04:00
4a438db2c9
Qt/GameListModel: Use native separators in File Path column
2020-03-19 18:03:35 +01:00
21d6c0a11a
Boot: Change pre-defined setting.txt CODE values
...
As suggested by
https://github.com/dolphin-emu/dolphin/pull/8673#discussion_r394945753
2020-03-19 13:05:44 +01:00
53c34d962d
Merge pull request #8665 from AdmiralCurtiss/debugger_columns
...
Qt/CodeViewWidget: Make columns resizable by the user and set sensible defaults.
2020-03-19 01:40:30 +01:00
e8dfb8f78d
Qt/CodeViewWidget: Make columns resizable by the user and set sensible defaults.
2020-03-18 22:27:53 +01:00
4711b76cc4
Merge pull request #8655 from Techjar/fix-hotkey-groups
...
Core/HotkeyManager: Fix group names in config
2020-03-18 12:03:07 +01:00
bb430fb5a5
Merge pull request #8675 from Pokechu22/disc-update
...
Fix Load Wii System Menu not updating after performing a disc update
2020-03-18 11:54:07 +01:00
d1e8e3e903
Merge pull request #8671 from leoetlino/bt-passthrough-error
...
BTReal: Improve error handling for device opening
2020-03-18 11:52:22 +01:00
c59120f089
Fix Load Wii System Menu not updating after performing a disc update
...
For a fresh install, the button was completely disabled even after the disc update; otherwise, the text on it was just out of date.
2020-03-17 19:59:48 -07:00
099e6bfab9
DolphinQt: Fix gyro mapping indicator's "jitter" drawing.
2020-03-17 19:19:58 -05:00
ae0c91805c
Core/HotkeyManager: Fix group names in config
...
For some reason every button group was shoved into the same config
group called "Keys" which caused buggy behavior once someone tried to
have hotkeys with the same name in different groups. This fixes that,
and converts existing configs to the new group names so they don't get
reset.
2020-03-17 05:42:26 -04:00
1b844067aa
Back up Wii setting.txt and SYSCONF while emulating
...
When booting a Wii game, Dolphin can overwrite certain settings
in the SYSCONF file, such as turning off PAL60 for NTSC games.
Normally, these settings get reverted at the end of emulation, but
this does not happen if Dolphin crashes or force quits in some other
way. (Personally, I have a tendency to use Visual Studio's Stop
Debugging button, which kills the process...)
Dolphin also overwrites certain values in setting.txt when booting
a Wii game. Unlike with SYSCONF, we currently make no effort to
preserve the original values in this file.
This change fixes both of these problems by copying SYSCONF and
setting.txt to the Backup folder when booting a Wii game, and then
copying them back either when launching Dolphin (in case the
previous run of Dolphin crashed) or when ending emulation.
2020-03-16 21:04:19 +01:00
5f6598f9e9
StringUtil: Add PathToFileName function
2020-03-16 21:03:34 +01:00
e06bdaf426
AddressSpace: Fix constness
2020-03-16 23:48:03 +04:00
3614e9fcc2
Boot: Preserve MODEL value in setting.txt
...
It doesn't necessarily start with RVL-001.
2020-03-16 20:38:07 +01:00
36c92294df
Boot: Preserve CODE value in setting.txt if it already matches the region
...
This is a part of fixing https://bugs.dolphin-emu.org/issues/11930 .
2020-03-16 20:34:40 +01:00
c86832849a
Merge pull request #8535 from JosJuice/movie-save-detection
...
Movie: Make checking for existing GC saves more reliable
2020-03-16 00:19:14 +01:00
cb0fe3fc30
Movie: Make checking for existing GC saves more reliable
...
The old code only handled a raw memory card in slot A, not taking
GCI folders into account at all.
2020-03-15 23:56:34 +01:00
57274cbf91
Merge pull request #8565 from Pokechu22/log-scroll-bar
...
Always display the horizontal scroll bar when log word wrap is off
2020-03-15 23:14:23 +01:00
a66ee4ea42
Merge pull request #8597 from SirMangler/master
...
Hotkeys: Toggle Freelook Hotkey
2020-03-15 22:40:51 +01:00
d9eec2ef04
Merge pull request #8609 from jordan-woyak/separate-hotkey-background-input
...
DolphinQt: Give hotkeys their own "background input" setting.
2020-03-15 22:35:49 +01:00
466c079bf4
Merge pull request #8604 from Techjar/netplay-index-direct
...
Core/NetPlayServer: Fix session not being added to index on direct connection type
2020-03-15 22:22:00 +01:00
73e7f2a839
BTReal: Improve error handling for device opening
...
This commit attempts to improve error handling for device opening by
reducing panic alert spam when opening one or several devices fails.
Currently, Dolphin shows a panic alert for every device that we fail
to open, and another panic alert at the end if no usable device was
found. That is certainly a bit excessive -- we should only keep the
very last panic alert (the one that is shown if everything fails)
and we can just put the error for the last device open operation there.
This also changes the PanicAlert to a CriticalAlert to ensure the
message is visible even if the user has disabled regular panic alerts.
The message has also been reworded and should hopefully be clearer.
2020-03-15 22:10:24 +01:00
d297080f52
Merge pull request #8669 from container1234/mbp
...
Breakpoints: Fix crash after clearing all memory breakpoints
2020-03-15 18:40:05 +01:00
3c1f5c675d
Merge pull request #8628 from iwubcode/texturepack_game_id_file
...
VideoCommon: Allow texture folders to be determined by a <gameid>.txt
2020-03-15 18:37:46 +01:00
bba92019dc
VideoCommon: Allow texture folders to be determined by a <gameid>.txt file
2020-03-15 12:34:04 -05:00
24a01642e0
Merge pull request #8642 from AdmiralCurtiss/debugger_branch_arrows
...
Qt/CodeViewWidget: Implement branch arrows.
2020-03-15 16:45:36 +01:00
9c98b659f1
Qt/CodeViewWidget: Indent branch arrows based on free space rather than reserving a full column for each.
2020-03-15 16:14:35 +01:00
19a46dd67b
Merge pull request #8652 from sonic2kk/qtshortcuts
...
Qt: Use Builtin QKeySequence Shortcuts
2020-03-15 15:07:47 +01:00
4944e4b429
Merge pull request #8647 from jordan-woyak/minor-input-cleanups
...
InputCommon: Minor ReshapableInput related cleanups.
2020-03-15 15:06:54 +01:00
0bf05009d0
Merge pull request #8650 from jordan-woyak/ir-cleanup
...
HW/WiimoteEmu: Camera logic cleanups.
2020-03-15 15:04:48 +01:00
cd2cf137ba
Use ZoomIn/ZoomOut QKeySequence in GameList
2020-03-15 14:58:33 +01:00
eda31c782e
Qt: Add Configuration shortcut
2020-03-15 14:58:31 +01:00
b82f54762b
Qt: Use builtin Find and Quit key sequences
2020-03-15 14:58:24 +01:00
3487e5037e
Fix settings.txt parsing in case of weird line endings
2020-03-15 00:12:19 +01:00
75a69b1145
Breakpoints: Fix crash after clearing all memory breakpoints
2020-03-14 21:57:09 +09:00
cdb0aa850d
Qt/RenderWidget: Remove fill background functionality
...
We no longer need this since the video backend handles clearing the
window, and it fixes MoltenVK with Qt 5.14.
2020-03-11 23:13:45 +10:00
2f016295a6
Core: Render a blank UI frame before booting
...
This is related to https://bugs.dolphin-emu.org/issues/10958 which
uses Qt to clear out the window so the game list isn't displayed
while the core is booting. Instead, we use the video backend to
render a black screen, which means Qt doesn't have to flip between
paint engines.
2020-03-11 23:13:18 +10:00
fb947296b0
Vulkan: Pass CAMetalLayer to MoltenVK instead of NSView
...
Gets rid of the warning for calling [NSView layer] off the main thread.
2020-03-11 23:11:26 +10:00
a545344268
VideoBackends: Make it possible for PrepareWindow to change the surface
...
Again, needed for MoltenVK.
2020-03-11 23:10:30 +10:00
86db015c23
Common: Add a render_window field to WindowSystemInfo
...
We need this because we need to pass the layer to MoltenVK, not
the view handle. But the input subsystem still needs the window.
2020-03-11 23:09:30 +10:00
18127e2554
Qt/CodeViewWidget: Implement branch arrows.
2020-03-07 01:52:53 +01:00
d1f6f12f78
AudioPane: Do not enable Dolby Pro Logic II quality slider if DPLII is disabled
2020-03-06 21:13:45 +01:00
dcaabcac03
Merge pull request #8580 from AlexApps99/master
...
DolphinQt: Add "File Path" column to Game Grid
2020-03-06 08:22:44 +01:00
879e8364af
Source/Core/Core/DSP/DSPTables.cpp: include <cstdio> for sprintf
...
Without included header build fails on gcc-10 as:
```
[ 52%] Building CXX object Source/Core/Core/CMakeFiles/core.dir/DSP/DSPTables.cpp.o
../../../../Source/Core/Core/DSP/DSPTables.cpp: In function 'const char* DSP::pdname(u16)':
../../../../Source/Core/Core/DSP/DSPTables.cpp:492:3: error: 'sprintf' was not declared in this scope
492 | sprintf(tmpstr, "0x%04x", val);
| ^~~~~~~
```
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
2020-03-05 21:20:34 +00:00
0478ce72f5
Source/Core/Common/StringUtil.h: include <limits> for std::numeric_limits
...
Without included header build fails on gcc-10 as:
```
[ 13%] Building CXX object Source/Core/AudioCommon/CMakeFiles/audiocommon.dir/CubebUtils.cpp.o
In file included from ../../../../Source/Core/AudioCommon/CubebUtils.cpp:13:
../../../../Source/Core/Common/StringUtil.h: In function 'bool TryParse(const string&, T*)':
../../../../Source/Core/Common/StringUtil.h:84:20: error: 'numeric_limits' is not a member of 'std'
84 | if (value < std::numeric_limits<LimitsType>::min() ||
| ^~~~~~~~~~~~~~
```
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
2020-03-05 21:20:34 +00:00
465e7c2521
Used whole path instead of relative path
2020-03-03 11:58:59 +13:00
7408c388d6
Add path to File Name column of game grid
...
Fixes https://bugs.dolphin-emu.org/issues/10567
2020-03-02 17:38:28 +13:00
08c95883e9
Common/IniFile: Add Exists function for section name only
2020-02-29 01:39:36 -05:00
ccdfa43a3e
HW/WiimoteEmu: Fix Classic Controller triggers.
2020-02-26 15:40:58 -06:00
2451a41a48
DolphinQt: Fix calibration cancel behavior.
2020-02-25 18:36:56 -06:00
2c843ae06b
DolphinQt: Clean up calibration drawing a bit.
2020-02-25 17:58:32 -06:00
ed24f32c5b
InputCommon: Specify ini value default when saving calibration "center".
2020-02-25 17:19:48 -06:00
bd43e084f4
InputCommon: Clamp calibration values within square shape.
2020-02-25 17:19:48 -06:00
f8cca9fe5d
InputCommon: RoundStickGate's ideal sample count can be 1.
2020-02-25 17:19:48 -06:00
8233255b11
Qt: Re-enable Dark Mode support
2020-02-25 23:27:44 +01:00
ef777c4186
HW/WiimoteEmu: Fill IR data with 0xFF on failed bus read.
2020-02-24 19:45:02 -06:00
5361e66459
HW/WiimoteEmu: Camera logic cleanups.
2020-02-24 19:44:15 -06:00
6b109bd2a6
DolphinQt: Tweak indicator raw-input/input-shape color for better contrast in some dark themes.
2020-02-24 16:26:28 -06:00
122984b46e
DolphinQt: Eliminiate redundant swing indicator logic.
2020-02-24 16:26:28 -06:00
d80fd13b17
DolphinQt: Clean up mapping indicator code and draw lines on "pixel centers".
2020-02-24 16:26:26 -06:00
f79ca680cb
DolphinQt: Eliminate redundant cursor indicator logic.
2020-02-24 16:25:06 -06:00
38f36be9ae
DolphinQt: Break mapping indicators into separate classes. Ensure "state lock" is held on redraw.
2020-02-24 16:25:06 -06:00
7accd9825f
InputCommon: Remove racy UpdateInput call in DetectInput.
2020-02-24 16:25:06 -06:00
1a3b4d91bf
InputCommon: Mark GetStateLock with [[nodiscard]] and fix discarding calls.
2020-02-24 16:25:06 -06:00
25d5f0d9ef
Merge pull request #8633 from spycrab/tas_window_fixes
...
Qt/TAS: Improve TAS windows
2020-02-24 07:26:49 +01:00
c70e004f53
Qt/CodeViewWidget: Use named constants for column IDs.
2020-02-23 18:49:27 +01:00
da12f3eebc
InputCommon: Constify Device::Input::IsDetectable function.
2020-02-22 10:27:43 -06:00
29c7c12016
Qt/TAS: Improve TAS windows
...
- Use the Dolphin Icon in TAS Windows
- Prevent deformation of the stick widget (#11988 )
- Improve visual appearance
- Set a reasonable minimum size
2020-02-18 16:13:31 +01:00
06a9f6ef82
Core/NetPlayServer: Fix session not being added to index on direct connection type
2020-02-17 21:05:32 -05:00
70ac9ad2e6
InputCommon: Remove Wii Remote real-time calibration of M+ in favor of functionality provided by ControllerEmu.
2020-02-17 16:14:03 -06:00
58448d74c5
InputCommon: Add real Wii Remote support to ControllerInterface. Add option to connect additional Wii Remotes.
2020-02-17 16:14:01 -06:00
4176cc77e1
InputCommon/ControllerInterface: Make devices mutex recursive so RemoveDevice can be used within UpdateInput.
2020-02-17 15:58:06 -06:00
5af2081c75
Core/WiimoteEmu: Add functions to Nunchuk, Classic Controller, and MotionPlus extensions to get/set data without duplicate bithacks everywhere.
2020-02-17 15:57:58 -06:00
8343dadd58
InputCommon: Add types to ControllerEmu that represent raw controller inputs and calibration data to calculate normalized input values.
2020-02-17 15:57:43 -06:00
259a7191d2
Common: Add additional Vector operations.
2020-02-17 15:57:43 -06:00
1e652d7d34
InputCommon: Add calibration functionality to IMUGyroscope.
2020-02-17 15:57:43 -06:00
9efcd08ea3
MathUtil: Add RunningMean/RunningVariance classes.
2020-02-17 15:57:43 -06:00
82a3aa5ff6
InputCommon: Add "Dead Zone" setting to raw gyro inputs.
2020-02-17 15:57:43 -06:00
2d6a72e941
Merge pull request #8632 from jimbo1qaz/windows-menu-font
...
Windows GUI: Use QMenu font (Segoe UI) for entire application
2020-02-17 15:04:37 +01:00
44f602fe51
Windows GUI: Use QMenu font (Segoe UI) for entire application
...
On Windows, Qt's default system font (MS Shell Dlg 2) is outdated.
Dolphin previously used over 15 lines of code to compute a font
closer to the proper font, but with an approximately correct font size.
Using the QMenu font directly is both more concise and more elegant
(in my opinion).
2020-02-17 05:37:54 -08:00
44b4c2db49
Common: Avoid std::function overhead in ScopeGuard
...
So far in all our uses of ScopeGuard, the type of the callable is
usually just a lambda or a function pointer, so there is no need
to rely on std::function's type erasure.
While the cost of using std::function is probably negligible, it still
causes some unnecessary overhead that can be avoided by making
ScopeGuard a templated class. Thanks to class template argument
deduction in C++17 most existing usages do not even need to be changed.
See https://godbolt.org/z/KcoPni for a comparison between
a ScopeGuard that uses std::function and one that doesn't
2020-02-15 21:33:31 +01:00
62046d93ce
Merge pull request #8542 from Itrimel/fix-gecko-loading
...
Fix Gecko codes loading
2020-02-15 16:28:32 +01:00
fe900e057b
Core/GeckoCodeConfig : Fix Gecko codes formatting
...
Some locales (e.g. fr_FR.UTF-8 on ArchLinux) don't split the string stream on a space. As such, when extracted formatted data from te stream, it will return the two numbers as one for the first call, effectively overflowing the u32 variable, then will do an out-of-bounds read for the second call. Forcing the use of the C locale on the streams where it would cause a problem allows to workaround this behavior.
2020-02-14 11:51:36 +01:00
213a9adcff
CMake: Fix building ARM64 on Windows
2020-02-12 12:29:31 +01:00
903db48280
DolphinQt: Give hotkeys their own "background input" setting.
2020-02-10 20:06:29 -06:00
a9dc4ac3f0
Merge pull request #8603 from jordan-woyak/deadzone-too-dark
...
DolphinQt/Mapping: Tweak "Dead Zone" and "Gate" colors.
2020-02-10 23:28:56 +00:00
103b3abf66
Merge pull request #8621 from JosJuice/volumeverifier-invalid-partition
...
Fix VolumeVerifier not showing a problem for invalid partitions
2020-02-10 09:33:29 +00:00
47877ecf2c
InputCommon: Clean up creation of inputs.
2020-02-09 19:08:26 -06:00
01d69ba81a
Merge pull request #8624 from jordan-woyak/setting-expression-input-gate
...
InputCommon: Only update setting expressions when the input gate is enabled.
2020-02-10 00:47:30 +00:00
53f2e275af
InputCommon: Only update setting expressions when the input gate is enabled.
2020-02-09 18:42:42 -06:00
c598772052
Merge pull request #8622 from JosJuice/volumeverifier-invalid-partition-biggest-offset
...
VolumeVerifier: Ignore invalid partitions in GetBiggestReferencedOffset
2020-02-10 00:31:49 +00:00
d129fae8fc
Merge pull request #8623 from spycrab/qt_5.14.1
...
Update to Qt 5.14.1
2020-02-10 00:06:11 +00:00
db65b9a766
Merge pull request #8616 from jordan-woyak/threshold-cleanup
...
InputCommon: Eliminate some duplicated button threshold logic.
2020-02-10 00:05:10 +00:00
6a3bd259a7
Update to Qt 5.14.1
2020-02-09 22:30:57 +01:00
7cbb9822c1
VideoCommon: Remove widescreen heuristic debug logs.
2020-02-09 13:22:27 -06:00
10223da6a8
VideoCommon: Tweak widescreen heuristic and clean up some related Renderer logic.
2020-02-09 13:22:25 -06:00
829f3cff6f
VolumeVerifier: Ignore invalid partitions in GetBiggestReferencedOffset
...
Otherwise GetBiggestReferencedOffset might treat garbage data as a valid
large offset, making Dolphin incorrectly say that the disc is too small.
2020-02-09 19:05:44 +01:00
07df6597a5
Fix VolumeVerifier not showing a problem for invalid partitions
2020-02-09 18:58:15 +01:00
f07457b6cc
InputCommon: Eliminate some duplicated button threshold logic.
2020-02-09 10:37:18 -06:00
55e8601192
Fix another implicit false-to-nullptr conversion
2020-02-09 15:51:30 +01:00
aa21fe17b8
Merge pull request #8618 from encounter/debugger-floating-fix
...
DolphinQt/Debugger: Fix crash with floating debugger windows
2020-02-09 15:50:47 +01:00
166e86b97f
Merge pull request #8619 from JosJuice/directoryblob-check-seek
...
DiscIO: Check for DirectoryBlob seek failure
2020-02-09 15:49:37 +01:00
fb0f543777
Merge pull request #8574 from JosJuice/volumeverifier-assert-small-file
...
VolumeVerifier: Improve the messages shown for files that are too small
2020-02-09 15:48:57 +01:00
5ab846ad12
Merge pull request #8614 from jordan-woyak/xinput-battery
...
InputCommon/XInput: Expose battery as input and cleanups.
2020-02-09 09:29:00 -05:00
9a348ae654
DiscIO: Check for DirectoryBlob seek failure
...
Someone reported a problem with DirectoryBlob at
https://forums.dolphin-emu.org/Thread-feature-request-thread?pid=502820#pid502820 .
I'm not sure if the change in this commit actually fixes that problem,
but it's something I found that should be changed regardless.
2020-02-09 11:21:10 +01:00
3e94366fe0
DolphinQt/Debugger: Fix crash with floating debugger windows
2020-02-09 02:32:04 -05:00
3cec5443cd
Merge pull request #8605 from Techjar/netplay-hostpoll-doc
...
Core/NetPlayClient: Add documentation for SendPadHostPoll
2020-02-09 02:32:50 +00:00
2e2540317e
Merge pull request #8417 from jordan-woyak/setting-expressions
...
InputCommon: Allow controller settings specified with input expresions.
2020-02-09 01:37:30 +00:00
0043a2cf3c
Merge pull request #8615 from jordan-woyak/std-abs
...
Cleanup: Use std::abs instead of abs.
2020-02-09 00:39:30 +00:00
4f47cccd9f
Cleanup: Use std::abs instead of abs.
2020-02-08 18:21:14 -06:00
0a1634bedf
InputCommon: Allow Wii remote extension to be set with an input expression.
2020-02-08 16:03:13 -06:00
e7400cafd2
InputCommon: XInput cleanups.
2020-02-08 15:51:02 -06:00
86e8745169
InputCommon: Expose XInput battery level as an input.
2020-02-08 15:03:56 -06:00
e8152b700f
InputCommon: Allow controller settings specified with input expresions.
2020-02-08 14:01:55 -06:00
6a857df219
Merge pull request #8606 from jordan-woyak/tab-key-navigation
...
DolphinQt: setTabKeyNavigation(false) on QTableWidget and QTableView.
2020-02-08 14:18:09 -05:00
3b0b264c84
Merge pull request #8608 from jordan-woyak/stereoscopy-hotkeys
...
DolphinQt: Fix stereoscopy hotkeys.
2020-02-08 14:17:42 -05:00
dc5447fb30
Merge pull request #8612 from jordan-woyak/unused-members
...
DolphinQt: Kill some unused member variables.
2020-02-08 14:17:15 -05:00
f94726068d
DolphinQt: Kill some unused member variables.
2020-02-08 10:52:06 -06:00
e323f47ceb
Merge pull request #8472 from degasus/jitsetting
...
Core/Jits: Adds an option to disable the register cache.
2020-02-08 13:49:33 +00:00
9a34091b8b
DolphinQt: Fix stereoscopy hotkeys.
2020-02-07 15:47:40 -06:00
b9f34bc822
DolphinQt: setTabKeyNavigation(false) on QTableWidget and QTableView.
2020-02-06 20:48:45 -06:00
e8e41d8529
Core/NetPlayClient: Add documentation for SendPadHostPoll
2020-02-06 07:24:00 -05:00
b1a71b959b
DolphinQt/Mapping: Change "Dead Zone" color from shadow color of palette to a transparent black or white depending on theme. Tweak order of "shake" indicator axis colors so red is more often shown.
2020-02-04 16:08:51 -06:00
a205ecb446
Merge pull request #8602 from lioncash/fmt
...
Externals: Update fmt to 6.1.2
2020-02-04 21:59:22 +01:00
91deb40a22
Common: Amend includes to handle the upgrade to fmt
2020-02-04 15:03:51 -05:00
aea76c7901
Core: Amend includes to handle the upgrade to fmt
2020-02-04 15:03:48 -05:00
abd2897377
VideoCommon: Amend formatting code to handle the upgrade to fmt
...
It seems that the newer version of fmt gets tripped up by bitfields
within structs. However, we can just specify the intended type where
necessary to get around this.
2020-02-04 14:55:20 -05:00
f8355d0f82
VolumeVerifier: Don't return early when file is too small
...
Not sure why that was there.
2020-02-02 17:09:58 +01:00
e449d23929
VolumeVerifier: Don't show an assert for files that are too small
2020-02-02 17:09:58 +01:00
0491831483
Merge pull request #8592 from phcoder/devid
...
ButtonManager: Fix handling of empty device id.
2020-02-02 16:52:12 +01:00
06d0b1ad48
Merge pull request #8594 from leoetlino/fs-createfullpath-fix
...
IOS/FS: Fix CreateFullPath to not create directories that already exist
2020-02-02 16:50:02 +01:00
4c9b1f3e0b
Merge pull request #8599 from Pokechu22/di-interrupt-mask-ioctls
...
Fix DI interrupt mask ioctl names
2020-02-02 16:49:27 +01:00
f527f382e8
Report use of DI interrupt mask commands as a game quirk
2020-02-02 00:44:12 -08:00
d6515eee41
WiimoteEmu: Fix default IMU accelerometer mappings.
2020-02-01 23:32:09 -06:00
bb5e5fd8f2
Fix assignment of DI interrupt mask ioctls
...
0x85 is actually DVDLowMaskCoverInterrupt, while 0x89 is DVDLowUnmaskCoverInterrupt. I'm also fairly sure that 0x87 is DVDLowUnmaskStatusInterrupts.
2020-02-01 16:56:48 -08:00
69ee15e5ef
Merge pull request #8478 from jordan-woyak/dsu-client-cleanup
...
ControllerInterface/DSUClient: Minor cleanup.
2020-02-01 11:29:29 +10:00
ac34911f32
Added Toggle Freelook Hotkey
2020-01-31 20:45:08 +00:00
08cc73108a
Vulkan: Treat VK_SUBOPTIMAL_KHR as VK_SUCCESS on Android
...
Android 10 seems to expect a prerotated/transformed swap chain for optimal
presentation. For now, until we implement that, just ignore the hint.
2020-01-31 19:16:06 +10:00
ead65b0d8c
Vulkan: Log when a swap chain resize is occurring
...
This may help us debug performance problems in the future.
2020-01-31 19:11:43 +10:00
bbc8631357
IOS/FS: Fix CreateFullPath to not create directories that already exist
...
This fixes CreateFullPath to not create directories when it is known
that they already exist, instead of calling CreateDirectory anyway
and checking if the error is AlreadyExists. (That doesn't work
now that we have an accurate implementation of CreateDirectory
that performs permission checks before checking for existence.)
I'm not sure what I was thinking when I wrote that function.
Also adds some tests for CreateFullPath.
2020-01-30 18:07:03 +01:00
f1f293bd49
WiiRoot: Fix CopySysmenuFilesToFS directory creation
...
Fixes a regression from #8539 .
CreateDirectory was the correct function to use for creating
directories since parent directories already exist and are
not owned by the system menu.
2020-01-30 13:53:39 +01:00
02c5d292fa
ButtonManager: Fix handling of empty device id.
...
Device id is "" on ChromeOS when using gamepad
2020-01-29 02:47:18 +01:00
57f4837e4d
Merge pull request #8589 from lioncash/translatable
...
DolphinQt/GCMemcardManager: Mark string as translatable within GetErrorMessagesForErrorCode()
2020-01-27 23:20:03 +01:00
7eaa769527
DolphinQt/GCMemcardManager: Make use of QLatin1Char within GetErrorMessagesForErrorCode()
...
Same behavior, but eliminates the use of a program lifetime Qt string
literal.
2020-01-27 15:59:33 -05:00
585ae8aedf
DolphinQt/GCMemcardManager: Mark string as translatable within GetErrorMessagesForErrorCode()
...
This is a string that can potentially be seen by a user, so it should be
marked as translatable, like the other strings are.
2020-01-27 15:57:36 -05:00
dca201d5f3
DolphinQt/GameConfigWidget: Remove unimplemented EditUserConfig() member function
...
This isn't implemented anywhere, so we can remove the member function
prototype.
2020-01-27 15:46:52 -05:00
2fd628d017
DolphinQt/GameConfigEdit: Remove unimplemented SetReadOnly() member function
...
This isn't implemented anywhere, so we can remove this prototype.
2020-01-27 15:44:52 -05:00
c69cbceb59
DolphinQt/MainWindow: Surround prototype of OnSignal() with relevant ifdef
...
This is only used on Apple and Unix-like machines, so we can enclose the
prototype with an ifdef like the implementation is. This prevents
false-positives about an unimplemented function prototype.
2020-01-27 15:26:41 -05:00
e8ee4e835e
DolphinQt/NetPlayDialog: Remove unimplemented SetGame() prototype
...
This isn't implemented anywhere, so the prototype can be removed.
2020-01-27 15:25:04 -05:00
f36c735856
Merge pull request #8586 from Techjar/d2s-no-pext
...
Avoid using PDEP and PEXT on AMD Zen
2020-01-27 03:15:43 +00:00
3a3dc28d54
VertexLoaderX64: Don't use PDEP on AMD Zen
2020-01-26 22:12:00 -05:00
a106c99826
Jit64: Don't use PEXT in DoubleToSingle on AMD Zen
...
This was causing severe slowdown in some games.
2020-01-26 22:10:46 -05:00
185e49d2a9
x64CPUDetect: Add flag for slow PDEP/PEXT on AMD Zen
...
For some unknown reason PDEP and PEXT are ridiculously slow on AMD Zen
architecture.
2020-01-26 22:09:46 -05:00
52b52631c2
x64CPUDetect: Add detection for AMD Zen architecture
2020-01-26 22:09:13 -05:00
47239ddaac
Merge pull request #8587 from lioncash/const-qual
...
DolphinQt/TASCheckBox: Mark GetValue() as const
2020-01-27 12:52:10 +10:00
b493bdb912
DolphinQt/TASCheckBox: Mark GetValue() as const
...
This doesn't actually modify the checkbox's state, so this can be marked
as a const-qualified member function.
2020-01-26 21:41:31 -05:00
5dfc9196ab
Merge pull request #8548 from jordan-woyak/wiimote-source-cleanup
...
Core/WiimoteReal: Wii remote connection pool and source change cleanup.
2020-01-25 23:04:50 +00:00
9ac77dc91f
Merge pull request #8552 from jordan-woyak/extension-calibration-data
...
WiimoteEmu: Nunchuk and Classic Controller calibration accuracy improvements.
2020-01-25 23:01:57 +00:00
73aea8af6b
Merge pull request #8539 from leoetlino/fs-accuracy
...
IOS/FS: Reimplement many functions in a more accurate way
2020-01-25 23:00:10 +00:00
2edcb29706
Merge pull request #8582 from jordan-woyak/osd-disabled-fix
...
VideoCommon/OSD: Process OSD messages even when they are disabled.
2020-01-25 21:11:37 +00:00
a632bc7324
Merge pull request #8579 from jordan-woyak/rvalue-cleanups
...
Common/Core: Minor rvalue reference related cleanups.
2020-01-25 21:09:22 +00:00
14ebdf0e9d
Merge pull request #8585 from JosJuice/volumeverifier-read-error
...
VolumeVerifier: Report read errors to the user
2020-01-25 21:07:01 +00:00
b0e040431a
Merge pull request #8581 from jordan-woyak/ciface-ar-aware
...
InputCommon: Make "Cursor" inputs aware of the rendered aspect ratio.
2020-01-25 20:28:01 +00:00
9827aa7a37
Merge pull request #8577 from jordan-woyak/shared_mutex
...
Common/Analytics: Replace mutex with shared_mutex and minor cleanups.
2020-01-25 20:08:22 +00:00
5e3472eba9
Common/Analytics: Replace mutex with shared_mutex and minor cleanups.
2020-01-25 14:04:00 -06:00
de26fec0af
VolumeVerifier: Report read errors to the user
2020-01-25 20:21:12 +01:00
119ccc5e4f
Merge pull request #8556 from Sintendo/bestrest
...
x64Emitter: Avoid 8-bit displacement when possible
2020-01-25 19:10:47 +00:00
709862b818
Merge pull request #8120 from MerryMage/cdts
...
Jit64: Make DoubleToSingle a common asm routine
2020-01-25 19:10:37 +00:00
c02e7de55a
IOS/ES: Remove now unnecessary title sorting hack
...
ES now uses FS to access the filesystem and FS's ReadDirectory now
returns file lists that are correctly ordered.
2020-01-25 17:54:58 +01:00
d4ba0acb3a
UnitTests/FS: Add path validity and splitting tests
2020-01-25 17:54:57 +01:00
484cfb9328
UnitTests/FS: Add metadata tests
2020-01-25 17:53:39 +01:00
142b7e048b
IOS/FS: Actually implement SetMetadata
2020-01-25 17:53:35 +01:00
e4dd582d1d
IOS/FS: Implement GetMetadata properly and remove GID hack
...
Now that all FS functions that create new inodes are properly
implemented, we can make GetMetadata actually return correct file
metadata rather than giving fixed information. The hack for the DQX
installer can also be removed now since our ES and FS keep track of
caller UID/GIDs now.
2020-01-25 17:53:34 +01:00
396429d582
IOS/FS: Implement ReadDirectory properly and remove sorting hack
...
With the CreateFile/CreateDirectory fix and this commit, we can
finally return correct results in ReadDirectory and the sorting
hack -- whose purpose was to prevent certain versions of the
System Menu from crashing -- can be removed too.
2020-01-25 17:53:19 +01:00
a40f297d1d
IOS/FS: Implement Rename properly
2020-01-25 17:53:18 +01:00
53ceb6c693
IOS/FS: Implement Delete properly
2020-01-25 17:53:05 +01:00
8517528f8c
IOS/FS: Implement CreateFile and CreateDir properly
2020-01-25 17:52:45 +01:00
8f74d02659
Core: Fix a few misuses of FS::CreateDirectory
...
CreateDirectory does not create missing parent directories. If that
behaviour is desired, CreateFullPath should be used instead.
(These small misuses went unnoticed since the previous implementation
of CreateDirectory automatically created parent directories.)
2020-01-25 17:52:07 +01:00
36676d2628
IOS/FS: Implement Format properly
2020-01-25 17:52:03 +01:00
a83d9e5600
IOS/FS: Make sure FS root directory exists
...
Previously, the FS root directory would get created as a side
effect of calling CreateDirectory during boot (since the
implementation was sloppy and used File::CreateFullDir).
Since CreateDirectory no longer does that, it is necessary to ensure
that the FS root directory does exist by creating it explicitly.
2020-01-25 17:51:52 +01:00
0543598574
IOS/FS: Move /tmp clearing back to the IPC interface
...
Prevents /tmp from being cleared unnecessarily; clearing /tmp is
normally only done once every time IOS is reloaded.
2020-01-25 17:51:43 +01:00
f743f100b1
IOS/FS: Add base FST functions
...
Some official titles rely on implementation details of Nintendo's
FS sysmodule and will not work properly if those are changed.
Notably, some games and older versions of the System Menu appear
to be relying on the order of files returned by FS::ReadDirectory
and will either fail to find their save data (for Bolt) or
outright crash (for the System Menu).
Some titles also actually expect filesystem metadata to be correct.
One title that has been confirmed to do this is DQX, which generates
paths based on the GID of files within its own title directory.
While it is easy to make workarounds for these issues -- and in fact
we already do have some for the sysmenu and DQX, having hacks
is obviously nonideal and adding yet another hack would be required
to fix Bolt -- one that would be even uglier.
Furthermore, while it is currently unknown whether any official
title cares about permissions, the lack of FS metadata means that
we are unable to implement them if that turns out to be desirable
or necessary.
By adding a FST, we can implement things correctly and solve all
those problems without hacks.
Apart from DQX, the sysmenu and Bolt, this changeset also fixes
the Photo Channel complaining about corrupted system files
on the initial launch.
This first commit adds the basic structures and functions that
are necessary to load, save, query and update our version of the FST.
For simplicity, a binary format that is inspired from Nintendo's FST
structure was chosen for serialization. It is not expected to ever
receive an update.
PS: an update on the NAND image backend:
A long time ago I had planned to add another FS backend which would
be using a NAND image/blob as the storage. While I have already
written an implementation that has been tested, solves all the
aforementioned issues and more, produces images that are fully
compatible with IOS's FS driver, I feel like NAND images raise too
many issues: savestate sizes, code complexity and maintenance cost.
Since many fixes and additions that are part of that implementation
(e.g. FS timings, utility structures, FST) have already been merged
or will be submitted as part of this changeset, I will likely not
submit the branch.
2020-01-25 17:51:37 +01:00
d185bc6f09
IOS/FS: Move path validity check functions
...
They will be used in more places than just HostBackend/FS.cpp.
Also fix the check and make it accurate while we're at it.
2020-01-25 17:47:42 +01:00
e3a7922e12
Merge pull request #8336 from Ebola16/PS
...
Add Dolphin version and current video backend to shader compilation logs
2020-01-25 11:52:14 +10:00
c08671c4ce
VideoCommon/OSD: Process OSD messages even when they are disabled.
2020-01-24 11:00:58 -06:00
b92f6480a0
InputCommon: Make "Cursor" inputs aware of the rendered aspect ratio.
2020-01-24 09:20:41 -06:00
e5f6d9320f
Add Dolphin version and current video backend to shader compilation logs
2020-01-24 03:29:38 -05:00
732032cdb2
Common/Core: Minor rvalue reference related cleanups.
2020-01-23 22:58:23 -06:00
42c03c4dad
Merge pull request #8576 from lioncash/texture-cvt-shader-fmt
...
VideoCommon/TextureConversionShader: Convert over to using ShaderCode
2020-01-24 11:53:51 +10:00
a0b7c1beae
Merge pull request #8366 from Techjar/high-dpi-auto-adjust
...
Qt/RenderWidget: Account for devicePixelRatio when auto-adjusting window size
2020-01-24 11:31:09 +10:00
687f1f0330
VideoCommon/TextureConversionShader: Make use of fmt where applicable
...
Now that we've converted the shader generation over to ShaderCode, we
can now make use of the fmt-capable WriteFmt function.
2020-01-23 14:19:40 -05:00
aa77dff3a2
VideoCommon/TextureConversionShader: Convert over to using ShaderCode
...
Migrates the shader generator off the use of a global array, eliminating
the use of some global state. This also allows us to move the shader
generation over to using fmt in a subsequent change.
2020-01-23 14:19:36 -05:00
ea9b96370d
Merge pull request #8573 from JosJuice/ciso-size
...
DiscIO: Fix CISOFileReader::GetDataSize()
2020-01-22 19:20:36 +01:00
956c63ef9b
DiscIO: Fix CISOFileReader::GetDataSize()
...
Fixes being unable to run CISO games after the merge of PR 8558.
2020-01-22 18:57:50 +01:00
f0669f5aa6
Merge pull request #8570 from Techjar/always-sync-sram
...
Core/NetPlayServer: Sync SRAM on every game start
2020-01-21 20:55:52 -05:00
a63510a55a
Merge pull request #8554 from stenzek/present-duplicate-frames
...
Add an option to present duplicate frames
2020-01-20 12:04:26 +10:00
f61d77a5e2
Merge pull request #8568 from jordan-woyak/imu-accel-ordering
...
InputCommon: List IMUAccelerometer's Up/Down inputs first for consistency.
2020-01-19 16:05:53 -05:00
de27dcebf6
Core/NetPlayServer: Sync SRAM on every game start
...
This solves the issue of booting games locally while connected to
NetPlay causing desync.
2020-01-19 03:57:41 -05:00
a61dff67da
InputCommon: List IMUAccelerometer's Up/Down inputs first for consistency.
2020-01-18 13:56:11 -06:00
8b1051abb9
Update Qt5_DIR path for ARM64 in CMake project
2020-01-18 11:28:42 +00:00
89b0ab2d22
StringUtil: Add IsPrintableCharacter and use it
...
Add a function that safely returns whether a character is printable
i.e. whether 0x20 <= c <= 0x7e is true.
This is done in several places in our codebase and it's easy to run
into undefined behaviour if the C version defined in <cctype>
is used instead of this one, since its behaviour is undefined
if the character is not representable as an unsigned char.
This fixes MemoryViewWidget.
2020-01-16 00:22:26 +01:00
0a6a53e301
Always display the horizontal scroll bar when log word wrap is off
...
Otherwise, a line that's too wide for the log widget will cause the horizontal scroll bar to appear, which reduces the vertical height, and causes the most recent line to be off screen. Since that line is off screen, the log widget no longer scrolls as new lines appear, unless it's manually scrolled to the very bottom again.
2020-01-15 13:59:09 -08:00
1cc7ef356b
Merge pull request #8558 from JosJuice/volume-oob
...
DiscIO: Add out of bounds checks for blob reading
2020-01-15 13:48:00 +00:00
1ac3264d5d
Merge pull request #8545 from jordan-woyak/imu-cursor-centering
...
WiimoteEmu: IMU pointing behavior improvements and code cleanup.
2020-01-15 12:10:57 +01:00
d2efad58af
Merge pull request #8562 from jordan-woyak/sens-slider
...
Core/DolphinQt: Fix IR Sensitivity slider.
2020-01-15 00:29:24 +01:00
b416389248
Core/DolphinQt: Fix IR Sensitivity slider.
2020-01-14 17:08:21 -06:00
297b790e4f
DiscIO: Add out of bounds checks for blob reading
2020-01-14 18:59:31 +01:00
21c152f51f
Fix Error #001 (alternative solution)
...
This is an alternative to PR 8557 and PR 8558. The way this PR solves
the problem is essentially the same as what we had before PR 8394
(except the code we had back then only worked because it was broken).
2020-01-14 16:47:14 +01:00
ddba80133a
Fix launching DTK games with MIOS
2020-01-13 20:07:59 -08:00
d67c4f34d1
Fix crash when launching gamecube games with MIOS (from the Wii menu)
2020-01-13 19:48:19 -08:00
11ba623f26
Add an option to present/skip presenting duplicate frames
...
Currently, we do not display every second frame in 25fps/30fps games
which run to vsync. This improves performance as there's less rendering
for the GPU to perform, but when combined with vsync, could cause frame
pacing issues.
This commit adds an option to force every frame generated by the console
to be displayed to the host, which may improve pacing for these games.
2020-01-14 10:57:35 +10:00
f5d9b78a3c
DolphinQt: Properly hide Wii remote extension motion tabs when no extension is selected.
2020-01-13 18:34:04 -06:00
efc1ee8e6a
Merge pull request #8537 from degasus/fastmem
...
Core/HW -> PowerPC/JIT: Fastmem arena construction
2020-01-14 09:38:15 +10:00
6106f780a7
ControllerInterface/DSUClient: Eliminate m_accl/m_gyro state by accessing the pad data directly like every other input.
2020-01-13 17:35:33 -06:00
eacbff76dd
Merge pull request #8474 from jordan-woyak/dsu-battery
...
ControllerInterface: Exposse DSU client battery level as an input.
2020-01-13 18:30:53 -05:00
e2d5c92c76
ControllerInterface: Remove and re-add device when combining nodes.
2020-01-13 16:50:58 -06:00
aabe8d2ccd
ControllerInterface: Don't consider the empty string a valid unique ID.
2020-01-13 16:50:58 -06:00
ac907ef977
ControllerInterface: Combine evdev devices with the same unique ID.
...
This works around Linux drivers for DS4 (Playstation 4) controllers splitting the device into three separate event nodes which makes configuration difficult.
To prevent collisions of input names in combined devices more descriptive names are now used when possible.
2020-01-13 16:50:56 -06:00
2b9fa0597a
ControllerInterface: Minor DSU client device cleanups.
2020-01-13 16:32:02 -06:00
da59f97278
Merge pull request #8549 from leoetlino/clang-format-9
...
Require clang-format 9 and reformat source code
2020-01-13 23:30:26 +01:00
f0534cabc6
ControllerInterface: Exposse DSU client battery level as an input.
2020-01-13 16:29:24 -06:00
48fd27cdab
Merge pull request #8451 from rlnilsen/motion-input-nunchuk
...
Add motion input support to nunchuk
2020-01-13 17:08:03 -05:00
966e1b31ba
Merge pull request #8394 from Pokechu22/misc-di-gpio
...
Various DI improvements
2020-01-13 17:17:24 +01:00
ae6d3be449
Merge pull request #8530 from s-daveb/master
...
MacOS: Fixes configuration hang; bump MacOS SDK.
2020-01-13 20:21:08 +10:00
bdcdd763fe
x64Emitter: Remove unused macros
...
No users, and one them seems to do the same as stddef.h's offsetof()
already used elsewhere.
2020-01-13 08:43:42 +01:00
f82c38e156
X64Emitter: Remove obsolete TODO
...
TODO was already taken care of in PR #941 .
2020-01-13 08:43:42 +01:00
bdfc472751
x64Emitter: Refactor OpArg::WriteRest
...
Shorter, displacement is now handled in one location.
2020-01-13 08:43:42 +01:00
cde3a3b448
x64Emitter: Avoid 8-bit displacement when possible
...
Due to the way the ModRM encoding works on x86, memory addressing
combinations involving RBP or R13 need an additional byte for an 8-bit
displacement of zero.
However, this was also applied in cases where it is unnecessary,
effectively wasting a byte.
- MatR with RSP or R12
8B 44 24 00 mov eax,dword ptr [rsp]
8B 04 24 mov eax,dword ptr [rsp]
- MRegSum with base != RBP or R13
46 8D 7C 37 00 lea r15d,[rdi+r14]
46 8D 3C 37 lea r15d,[rdi+r14]
- MComplex without offset
8B 4C CA 00 mov ecx,dword ptr [rdx+rcx*8]
8B 0C CA mov ecx,dword ptr [rdx+rcx*8]
2020-01-13 08:43:42 +01:00
d9bd714143
WiimoteEmu: Nunchuk and Classic Controller calibration accuracy improvements.
2020-01-12 09:48:37 -06:00
d8b2be9d06
DolphinQt: Support compiling on ARM64
2020-01-12 15:23:42 +10:00
0aacf3a627
WiimoteEmu: Make the "Total Yaw" setting work again.
2020-01-09 13:11:13 -06:00
4cc2d97294
Require clang-format 9 and reformat source code
...
This updates the lint script to require clang-format 9 and reformats
existing source code. Since VS2019 ships with clang-format 9 this
should make auto reformats less painful.
This also updates the clang-format configuration to set
BraceWrapping.AfterCaseLabel to true to ensure consistent brace
style; otherwise clang-format 9+ defaults to putting braces on
the same line as switch case labels.
2020-01-08 22:18:15 +01:00
a8c33f4ef6
Fix trailing whitespace
2020-01-07 12:52:05 +13:00
21528c3e72
Document the evdev "interesting" heuristic
...
Was checking over this old code, and saw a comment calling me out for a lack of documentation.
It might be half a decade late, but better late then never.
2020-01-07 12:46:24 +13:00
98f645daac
Merge pull request #8158 from Sintendo/jitopts
...
x64 micro-optimizations
2020-01-06 14:09:43 +01:00
f17f03ea3c
Merge pull request #8551 from Sintendo/jit64addx
...
Jit64: addx optimizations
2020-01-06 13:15:17 +01:00
6e18dfb600
Merge pull request #8133 from Sintendo/mov64imm32
...
x64Emitter: Emit shorter MOVs for 32-bit immediates
2020-01-06 13:12:56 +01:00
12fcbac2a3
Jit64: addx - Emit LEA for register + immediate
...
Prefer LEA over MOV + ADD when dealing with immediates.
Before:
44 8B EE mov r13d,esi
41 83 C5 20 add r13d,20h
After:
44 8D 6E 20 lea r13d,[rsi+20h]
2020-01-05 23:39:13 +01:00
8e7b6f4178
Jit64: addx - Prefer ADD over LEA when possible
...
The old logic would always emit LEA when both sources are in a register
and OE is disabled. However, ADD is still preferable when one of the
sources matches the destination.
Before:
45 8D 6C 35 00 lea r13d,[r13+rsi]
After:
44 03 EE add r13d,esi
2020-01-05 23:23:56 +01:00
c1f9bfce30
IOS/ES: Add SetUid exception for the Wii U Transfer Tool
...
The ES sysmodule in IOS62 (v6430) has an exception for the
Wii U Transfer Tool in the SetUid function.
If the active title is the Wii U Transfer Tool, then calling SetUid
is always allowed. (The UID is still checked first, though.)
Fixes https://bugs.dolphin-emu.org/issues/10985
2020-01-05 18:16:54 +01:00
956339df4e
Core/WiimoteReal: Make wiimote source type an enum class and add Get/SetWiimoteSource functions. Add connected real Wii Remotes to a pool when a slot is not available.
2020-01-05 10:15:22 -06:00
f35f4f2bf0
Merge pull request #8541 from jordan-woyak/float-parse-fix
...
StringUtil: Make TryParse of floats handle comma and dot decimal separators.
2020-01-05 12:12:09 +01:00
3b5d20e12c
Bump state version
2020-01-04 11:43:33 -08:00
51f8a3606e
Return error code to game when using unimplemented commands
2020-01-04 11:43:32 -08:00
af5f0b20bb
Report use of various unimplemented DI commands as game quirks
2020-01-04 11:43:32 -08:00
f1dc908883
Clarify emulated behavior for ReadBCA
2020-01-04 11:43:32 -08:00
6c0399103f
Handle partitions in /dev/di, not DVDInterface
...
Partitions are Wii-exclusive, and don't happen at the DVDInterface level in
IOS. This isn't quite the cleanest fix, but it gets rid of the assumption that
a partition is open on starting the game at least.
2020-01-04 11:43:32 -08:00
71e8fb278f
Return more errors from DTK
2020-01-04 11:43:31 -08:00
55a88ba2ed
Track drive state better, reporting errors if the state is wrong
...
Also, fix DVDLowStopMotor logging (which was based on the ioctl parameters)
2020-01-04 11:43:31 -08:00
7d6b9bcb40
Check for error 001 out of bounds reads in DVDThread
...
All out of bounds reads should return the appropriate DI error, but it also
makes sense to have the error 001 read happen there.
2020-01-04 11:43:30 -08:00
ef2fc5a49b
Split /dev/di commands from DVDInterface
...
The various ioctls sometimes have different arguments than the DI command
registers, though they generally overlap. There are also a bunch of ioctls
that don't even normally go into DVDInterface, just returning various data.
Some of the implemented ioctls are new to Dolphin.
2020-01-04 11:43:30 -08:00
a8ae5fa21a
Expose setting DVDInterface errors and split setting into two parts
2020-01-04 11:43:30 -08:00
3110599559
Increase DIMAR by DILENGTH after a command
2020-01-04 11:43:30 -08:00
d3aad1d6d5
DIMAR only ignores bits 0-4, not the upper bits
...
Based on a hardware test on a Wii. The alignment code was originally added in 743641965a
2020-01-04 11:43:29 -08:00
c564d64104
Remove unused drive debug command constants
...
The corresponding code that used these was removed in 2009 with 93b83f8d65http://hitmen.c02.at/files/yagcd/yagcd/chap5.html#sec5.7.2 and https://web.archive.org/web/20070328200323/http://tmb.elitedvb.net/dvd-game/index.php/CMDFE . Those constants only relate to the 0x11 subcommand, which is one of many. Most can't be properly emulated unless we LLE the drive firmware (in which case, they don't need to be reimplemented).
2020-01-04 11:43:29 -08:00
84f099cf62
Tidy and eliminate some of the DI register unions
2020-01-04 11:43:26 -08:00
11bd132650
Implement RTC flag, which is counter-intuitively disc drive related
2020-01-04 11:43:26 -08:00
77189e74cd
Implement Broadway GPIOs
...
SLOT_LED and the AVE ones are not implemented yet, but the other Broadway ones are.
2020-01-04 11:43:26 -08:00
a695b05b21
Add support for std::optional to PointerWrap
2020-01-04 11:43:26 -08:00
0e8d4cb6ac
StringUtil: Make TryParse of floats handle comma and dot decimal separators.
2020-01-04 07:19:15 -06:00
ad75215bb0
Fix several warnings
...
A small, nonexhaustive set of warning fixes. The DiscIO Volume change
is a workaround for a GCC bug [1] that causes returning an unengaged
std::optional to emit annoying -Wmaybe-uninitialized warnings.
This last change alone fixes pages upon pages of warnings since
Volume.h is included from several files.
-Wstringop-truncation is another irrelevant warning for us, but
unfortunately there seems to be no way to disable it without
adding ugly pragmas wherever the warning appears.
2020-01-04 12:11:39 +01:00
94c5460693
Merge pull request #8546 from jordan-woyak/default-num-mappings
...
HW: Add ticks to default mappings that are valid numeric literals.
2020-01-04 10:41:45 +01:00
671defd8b9
Merge pull request #8543 from jordan-woyak/gcode-download-minor-fix
...
Core/GeckoCode: Fix DownloadCodes function assuming HTTP data is null terminated.
2020-01-04 10:18:44 +01:00
2a9a04a1ec
HW: Add ticks to default mappings that are valid numeric literals.
2020-01-03 22:08:49 -06:00
b505004d61
Core/GeckoCode: Fix DownloadCodes function assuming HTTP data is null terminated.
2020-01-03 20:14:10 -06:00
723115b7b6
WiimoteEmu: Allow Recenter button to adjust the pitch.
2020-01-03 18:08:45 -06:00
72c2be52ed
WiimoteEmu: Clean up ComplementaryFilter math.
2020-01-03 16:16:26 -06:00
120c6dc850
DolphinQt: Fix accelerometer indicator math.
2020-01-03 12:34:11 -06:00
540a3ce665
DolphinQt: Use FromQuaternion for a more accurate gyro indicator.
2020-01-02 15:46:18 -06:00
8ab3694f51
Common: Add Matrix33::FromQuaternion.
2020-01-02 15:16:37 -06:00
b1a6cbc3b4
MacOS: Dispatch GL calls to main thread to prevent crashes on Catalina
2020-01-01 23:06:19 -05:00
11339d77c6
IsSettingSaveable.cpp: Significant code size reduction.
...
- Refactor the Config::System::Main check so we check system once,
then we check for the section.
- Use an std::array<> instead of std::vector<>.
- Use an array of pointers instead of an array of ConfigLocation.
The latter contains two std::string objects, whereas pointers
are only 8 bytes (on 64-bit).
Code size comparison: (64-bit Linux, gcc-9.2.0, release build)
text data bss dec hex filename
16136 0 40 16176 3f30 IsSettingSaveable.cpp.o [before]
3933 720 0 4653 122d IsSettingSaveable.cpp.o [after]
-12203 +720 -40 -11523 -2d03 Difference
2019-12-29 23:45:02 -05:00
f5fe692842
Use pre-increment for iterators instead of post-increment.
...
Pre-increment is more efficient, since it doesn't have to return the
old iterator.
2019-12-29 23:45:02 -05:00
c2dd2e8a2e
Use std::istringstream or std::ostringstream instead of std::stringstream where possible.
...
This removes std::iostream from the inheritance chain, which reduces
overhead slightly.
2019-12-29 23:45:02 -05:00
6e549bb668
InputConfig::LoadConfig(): Convert num[] to an array of std::string_view.
...
NOTE: The explicit std::string() conversions later are needed. Otherwise,
gcc-9.2.0 throws all sorts of errors because it can't find a matching
operator+() function.
2019-12-29 23:45:02 -05:00
a23b3d26f4
GLExtensions.cpp: Use arrays of `const char *const` instead of `std::string`.
...
The strings end up being copied, so we might as well initialize the
std::string in the unordered_map directly.
2019-12-29 23:45:02 -05:00
05101b251c
OGL/Render.cpp, InitDriverInfo(): Use std::string_view to eliminate string copies.
...
Consolidate the NVIDIA Tegra and non-Tegra checks into one branch.
2019-12-29 23:45:02 -05:00
1d7f128693
GetSysMenuVersionString(): Use a char instead of std::string for the region letter.
...
Append the region letter after determining the version number.
2019-12-29 23:45:02 -05:00
9f3b9acad9
PowerPC.cpp: No need to explicitly initialize ppcState.
...
"ppcState{}" is stored in the .data segment, which means the full ~4 MB
is stored in the executable.
"ppcState" is stored in the .bss segment, which means it only stores a
note that tells it to allocate and zero ~4 MB at runtime.
2019-12-29 23:45:02 -05:00
afe2e7de0f
VolumeVerifier.cpp: Verify that the string arrays are sorted before using std::binary_sort().
...
Debug builds only, since this is wrapped in assert().
2019-12-29 23:42:55 -05:00
d660aba20f
VolumeVerifier.cpp: Use arrays of string_view objects instead of strings.
...
string_view is a thin wrapper around C strings, so it's more efficient
for constant strings than C++ strings.
The unordered_set<> also adds extra runtime overhead. For small arrays,
a simple linear search works. For larger arrays, std::binary_search()
works better than linear but without the unordered_set<> overhead.
ShouldBeDualLayer(): Removed a duplicate "SK8X52" entry.
2019-12-29 23:42:55 -05:00
aad8aab698
Jit64: Disable the fast address check if fastmem is disabled.
...
This was a huge speedup with disabled fastmem, but it still requires the fastmem arena.
So let's disable it for now, even if this commit has a huge performance hit with disabled fastmem.
2019-12-28 13:41:57 +01:00
d735943aa2
Jit64: Use safe memory helpers for psq_l* without fastmem.
...
RMEM won't help if there is no fastmem arena, so let's use our memory helpers.
2019-12-28 13:41:57 +01:00
74cb692591
Jit64: Only activate dcbz fastpath with fastmem.
...
The code is safe not to create memory errors, but it accesses the fastmem area.
2019-12-28 13:41:57 +01:00
c6019f9814
PowerPC/Jit: Create fastmem arena on init.
2019-12-28 13:41:57 +01:00
ccbadf6e72
Core: Refactor fastmem arena construction.
...
This shall be called by the Jit, not by the emulation start itself.
2019-12-28 13:41:57 +01:00
9d88180df7
MMU: Use the Memory helpers for physical memory.
...
physical_base is a fastmem helper. Its access is unsafe and might not be available without a Jit.
2019-12-28 12:57:51 +01:00
d744c5a148
Compile fixes for Windows-on-ARM64
2019-12-28 19:20:41 +10:00
6fcb1c6c46
Add an ARM64 target to Visual Studio projects
2019-12-28 19:20:41 +10:00
5a65031611
Add a Win32 NoGUI platform and project
2019-12-28 08:56:27 +10:00
0755f92979
Merge pull request #8534 from JosJuice/netplay-index-empty-strings
...
Properly check for missing netplay session name/region
2019-12-25 21:52:22 -08:00
0341288af2
Merge pull request #8525 from Techjar/axwii-ub
...
HW/DSPHLE: Fix struct aliasing undefined behavior in AX ucode
2019-12-24 08:35:28 +01:00
0c12dbe860
DolphinQt: Properly save netplay session settings when changed
2019-12-23 23:14:13 +01:00
8e278b8053
Check presence of name and region in NetPlayServer
2019-12-23 23:14:13 +01:00
2fa4ef729f
DolphinQt: Check presence of region in NetPlaySetupDialog
2019-12-23 23:14:13 +01:00
5c996dec89
DualShockUDPClient: downgrade spurious NOTICE_LOGs
2019-12-23 18:36:18 +01:00
eae959238e
HW/DSPHLE: Fix struct aliasing undefined behavior in AX ucode
...
This fixes Old AX Wii games having no audio when compiled under VS2019.
This also includes some minor code cleanup and moving a function to
avoid duplication.
2019-12-22 14:48:47 -05:00
79092cdda0
Common/BitUtils: Implement BitCast(To|From)Array
2019-12-22 14:48:47 -05:00
21f42fafb7
MacOS: Fixes configuration hang; bump MacOS SDK.
...
Removed conditional use of std::mutex instead of std::shared_mutex on MacOS.
Because MacOS < 10.12 did not support std::shared_mutex, a previous commit
naïvely substituted std::mutex, which does not have the same behavior.
Reverses PR #8273 , which substitues std::mutex for std::shared_mutex on
macOS, and results in several bugs that seem to only affect MacOS
- https://bugs.dolphin-emu.org/issues/11919
- https://bugs.dolphin-emu.org/issues/11842
- https://bugs.dolphin-emu.org/issues/11845
This change eliminates conditional code for MacOS in the core configuration
layer code and enables the use of modern language features that are more
secure and thread-safe.
2019-12-22 00:49:17 -05:00
6a0067fd26
FrameDump: Set first_frame if movie frame number <= 1
...
The frame number is incremented before the first frame is swapped out.
Fixes ffmpeg creating invalid video files on output if the emulator only
runs for a single frame, e.g. FifoCI.
2019-12-22 11:54:34 +10:00
222bc6a443
Include <memory> for std::unique_ptr in DXContext.h
2019-12-19 14:25:12 -08:00
74dedc57fd
Merge pull request #8519 from JosJuice/setupwiimemory-region-override
...
Boot: Optionally allow preserving region settings in setting.txt
2019-12-19 20:47:56 +10:00
e3a30fbdf2
update minilzo to 2.10
2019-12-18 22:20:11 -08:00
3cf2857aac
Merge pull request #8520 from lioncash/analyst-tidy
...
PowerPC/PPCAnalyst: Remove unimplemented LogFunctionCall prototype
2019-12-15 12:07:38 +01:00
7c12081693
PowerPC/PPCAnalyst: Remove unimplemented LogFunctionCall prototype
...
This doesn't have an implementation, so it can be removed.
2019-12-15 00:23:32 -05:00
208c6a3011
Boot: Optionally allow preserving region settings in setting.txt
...
See the discussion in https://bugs.dolphin-emu.org/issues/11930 .
(This probably doesn't really fix that issue, but it's something
I thought would make sense anyway.)
2019-12-14 19:03:20 +01:00
6cd2f5a76d
Merge pull request #8501 from lioncash/byteswap
...
GCMemcard: Remove byteswapping functions and macros
2019-12-14 14:28:01 +01:00
49fcc71565
Merge pull request #8506 from lioncash/cache
...
PPCCache: Make arrays constexpr where applicable
2019-12-14 14:25:06 +01:00
a980a39807
Merge pull request #8518 from stenzek/more-wiimote-reset-crashes
...
Core: Reset Wiimotes/rumble/memwatcher on emu thread
2019-12-13 13:44:22 +10:00
0cb3257d3f
Merge pull request #8435 from firodj/pr-fix-macos-qt-plugin-cocoa
...
DolphinQt: Fix qt.qpa.plugin on MacOS
2019-12-10 17:41:02 +01:00
e5485ca499
Core: Reset wiimotes/rumble on emu thread instead of main thread
...
This was causing a race which was crashing the FifoCI runners. The main
thread called Stop() which in turn called ResetAllWiimotes() while the
emu thread was still exiting, also shutting down the Wiimote class.
By shifting the reset to the emu thread, all cleanup operations happen
on the same thread where they were initialized.
2019-12-09 20:07:00 +10:00
c602cb2e2f
Core: Reset memory watcher on same thread which allocates it
2019-12-09 20:06:14 +10:00
e05bc33899
Vulkan: Call VertexManagerBase initialize
2019-12-09 19:16:15 +10:00
07c43b192f
D3D12: Call VertexManagerBase initialize
2019-12-09 19:16:04 +10:00
a21fb96638
Merge pull request #8516 from JosJuice/scrub-unencrypted-again
...
Fix scrubbing unencrypted Wii disc images (for real this time)
2019-12-08 12:25:16 -08:00
711b36075c
Fix scrubbing unencrypted Wii disc images (for real this time)
...
Unlike what my past self apparently thought, % is in fact not the
"round down" operator.
https://bugs.dolphin-emu.org/issues/11906
2019-12-08 19:41:40 +01:00
bac8c060b5
Merge pull request #8508 from lioncash/fmt-tex
...
VideoCommon/TextureConverterShaderGen: Convert over to fmt
2019-12-07 18:41:14 -08:00
9ef50a1d4b
Merge pull request #8509 from lioncash/shader-str
...
VideoCommon/FramebufferShaderGen: Minor clean up
2019-12-07 18:40:56 -08:00
19ea546a0a
Merge pull request #8511 from lioncash/if-constexpr
...
VideoCommon/OpcodeDecoding: Make use of if constexpr
2019-12-07 18:40:15 -08:00
fdb78b64e1
Merge pull request #8513 from lioncash/bounding-box
...
VideoCommon/BoundingBox: Make interface for querying bounding box data
2019-12-07 18:40:02 -08:00
b39756dbce
Merge pull request #8512 from lioncash/index
...
VideoCommon/IndexGenerator: Eliminate static state
2019-12-07 18:38:06 -08:00
81edcca8db
Common/Network: Use std::nullopt in StringToMacAddress
...
Prevents unnecessary zeroing out of std::optional's internal buffer in
some implementations.
2019-12-06 09:59:11 -05:00
cbfacc41ba
Common/Network: Remove unused header inclusions
...
Removes unused header dependencies.
2019-12-06 09:51:28 -05:00
f06461d208
Common/Network: Make StringToMacAddress use a string_view
...
This function only ever reads the contents of the string in a non-owning
manner, so we can change the parameter over to being a string view.
2019-12-06 09:45:25 -05:00
2c9ec6cb8a
VideoCommon/BoundingBox: Move PixelShaderManager::SetBoundingBoxActive() calls into Enable()/Disable()
...
Now that we have an actual interface to manage things, we can stop
duplicating the calls to to the pixel shader manager and remove the
need to remember to actually do so when disabling or enabling the
bounding box.
2019-12-05 11:57:58 -05:00
9bd533ebe4
VideoCommon/BoundingBox: Make interface for querying bounding box data
...
Rather than expose the bounding box members directly, we can instead
provide an interface for code to use. This makes it nicer to transition
from global data, as the interface function names are already in
place.
2019-12-05 11:48:42 -05:00
10f7674651
VideoCommon/IndexGenerator: Eliminate static state
...
Now that we've extracted all of the stateless functions that can be
hidden, it's time to make the index generator a regular class with
active data members.
This can just be a member that sits within the vertex manager base
class. By deglobalizing the state of the index generator we also get rid
of the wonky dual-initializing that was going on within the OpenGL
backend.
Since the renderer is always initialized before the vertex manager, we
now only call Init() once throughout the execution lifecycle.
2019-12-05 10:49:32 -05:00
159947ab68
VideoCommon/IndexGenerator: Make use of if constexpr
...
We can use if constexpr with the template functions that pass in a
non-type template parameter, allowing the removal of branches that
aren't taken at compile time.
Compilers will generally do this by default, however, we now give a
gentle prodding to the compiler if this would otherwise not be the case.
2019-12-05 10:49:32 -05:00
fb3fda775f
VideoCommon/IndexGenerator: Move stateless functions into anonymous namespace
...
These don't rely on any of the static members within the IndexGenerator
class, so we can make all of these functions fully internal to the
translation unit.
2019-12-05 10:49:29 -05:00
69f2ca2230
VideoCommon/IndexGenerator: Make use of anonymous namespace
...
More things will be moved into this in subsequent changes. While we're
at it, we can also make use of std::array.
2019-12-05 09:36:41 -05:00
1f46a6a64b
VideoCommon/OpcodeDecoding: Make use of if constexpr
...
We can make use of if constexpr in several scenarios here to allow
compilers to exise the relevant code paths out.
Technically a decent compiler would do this already, but now we can give
compilers a little more nudging here in the event that isn't the case.
2019-12-05 09:13:06 -05:00
99353c3baa
VideoCommon/OpcodeDecoding: Remove unused headers
...
Nothing provided by these headers are used, so we can remove them.
2019-12-05 09:13:06 -05:00
6339a5ea8e
VideoCommon/OpcodeDecoding: Resolve implicit signedness conversion
...
cmd2 is a u32, so any bitwise arithmetic on it with a type of the same
size or smaller will result in a u32 value. This is also implicitly
converted to an unsigned type in the if statement as well, given that
size_t * int -> size_t.
This is just more explicit about the operations occurring and also
likely silences a sign conversion warning.
2019-12-05 09:13:06 -05:00
4710b82f43
VideoCommon/OpcodeDecoding: Remove use of goto in Run()
...
With the use of a lambda and a change in switch fallthrough, we can
completely eliminate the use of goto within Run().
2019-12-05 09:13:06 -05:00
f74503cce0
VideoCommon/OpcodeDecoding: Make use of anonymous namespace
...
Provides a region for all internal utilities.
2019-12-05 09:13:06 -05:00
6b4e340995
VideoCommon/OpcodeDecoding: Amend comment formatting
...
Amends a documentation comment that acquired some wonky formatting
during the introduction of clang-format a few years ago.
2019-12-05 09:13:06 -05:00
b2a9c36501
VideoCommon/OpcodeDecoding: Move g_bRecordFifoData into namespace
...
Keeps the global localized with the code that it's primarily related to.
Now it's obvious from a glance what the global variable is affecting.
2019-12-05 09:13:03 -05:00
d8063e9c54
VideoCommon/OpcodeDecoding: Normalize variable naming
...
Provides consistent naming of variables within the translation unit.
While we're at it, we can mark them const where applicable.
2019-12-05 08:05:29 -05:00
f29730944f
VideoCommon/FramebufferShaderGen: Make use of std::ostringstream internally
...
We only use these string streams to output into a final std::string
instance, we don't read into types with them. Because of this, we can
just make use of std::ostringstream, rather than the fully-fledged
std::stringstream.
2019-12-05 00:18:00 -05:00
fff445cc10
VideoCommon/FramebufferShaderGen: Make use of std::string_view where applicable
...
Prevents the use of the null pointer as an input to any functions.
2019-12-05 00:15:37 -05:00
3405815f09
VideoCommon/FramebufferShaderGen: Remove unused Config struct
...
This isn't used anywhere within the codebase, so it can be removed
entirely.
2019-12-04 23:54:15 -05:00
3a8d17c140
VideoCommon/FramebufferShaderGen: Use an anonymous namespace where applicable
...
Places all internal helpers and types within an anonymous namespace.
2019-12-04 23:51:26 -05:00
eefd6a10f5
VideoCommon/FramebufferShaderGen: Add missing initial source file comments
...
Makes the source files consistent with the rest of the VideoCommon code.
2019-12-04 23:48:59 -05:00
f8c90f0484
VideoCommon/FramebufferShaderGen: Collapse stream insertions
...
No behavioral change. This is intended to make the transition to fmt
less noisy in subsequent changes by combining insertions of multiple
string literals into one where applicable.
2019-12-04 23:45:15 -05:00
965781ea9d
Motion Input: Add nunchuk support.
2019-12-04 23:21:26 +01:00
0f28f4049b
VideoCommon/TextureConverterShaderGen: Convert over to fmt
...
Easily the most straightforward to convert over, given the lack of
significant formatting arguments.
2019-12-03 05:05:02 -05:00
8af6bfb8b0
VideoCommon/ShaderGenCommon: Add function for writing fmt-based strings
...
Begins the conversion of the shader generators over to using fmt
formatting specifiers.
This also has a benefit over the older StringFromFormat-based API in
that all formatted data is appended to the existing buffer rather than
creating a completely separate string and then appending it to the
internal string buffer.
2019-12-03 04:49:48 -05:00
474e210cd5
PPCCache: Make arrays constexpr where applicable
...
Two of these arrays were stored within the save state when the exact
same data is constructed all the time.
We can just build this into the binary rather than the save state,
shrinking a little bit of the save state's overall size.
2019-12-03 04:05:09 -05:00
1d5ce4708f
PPCCache: Make use of std::array where applicable
...
Allows simplifying a bunch of initialization and filling code.
2019-12-03 04:05:05 -05:00
15fc71cfcf
Merge pull request #8498 from stenzek/update-vs2019
...
Update VS projects/solutions to VS2019
2019-12-03 13:03:49 +10:00
52e2e32193
Core: Only reset wiimotes in Wii mode
...
This was causing the FifoCI runners to crash, as the Wiimotes were not
initialized in the first place.
2019-11-30 15:41:38 +10:00
33c0abd1ab
Disable warning C5054 on DolphinQt
...
They're all in the Qt headers, and quite noisy.
2019-11-30 13:42:52 +10:00
dd23a1ee79
Update VS projects/solutions to VS2019
2019-11-30 13:42:52 +10:00
4a0611df54
Merge pull request #8487 from lioncash/video-fmt
...
VideoCommon: Make use of fmt outside of shader generators
2019-11-28 15:03:23 -08:00
b5656df7e8
Merge pull request #8502 from lioncash/log
...
Common: Unify logging namespace with Common
2019-11-28 15:01:49 -08:00
ef32a10d69
InputCommon: Decouple ButtonManager and Touchscreen from Android
...
Changes were also made for codestyle compliance.
2019-11-28 15:20:51 -05:00
c792961000
Common: Unify logging namespace with Common
...
Previously the logging was a in a little bit of a disarray. Some things
were in namespaces, and other things were not.
Given this code will feature a bit of restructuring during the
transition over to fmt, this is a good time to unify it under a single
namespace and also remove functions and types from the global namespace.
Now, all functions and types are under the Common::Log namespace. The
only outliers being, of course, the preprocessor macros.
2019-11-28 05:13:21 -05:00
e33c366502
GCMemcard: Remove byteswapping macros
...
We can just specify the functions directly instead of relying on
preprocessor textual replacement.
2019-11-27 23:15:31 -05:00
1f1a02151e
GCMemcard: Replace ByteSwap with std::swap
...
There's already a standard library function that does what this function
is doing.
2019-11-27 23:15:26 -05:00
c2c8a14966
Merge pull request #8348 from JosJuice/mmu-setting
...
Disable full MMU by default and add it to global config GUI
2019-11-27 16:04:40 -08:00
9822a2d582
Merge pull request #8465 from CookiePLMonster/d3d-common-cleanup
...
D3DCommon: Cleanups and resource leak fix
2019-11-27 16:03:44 -08:00
66ca83e6af
Merge pull request #8479 from nokturnusmf/master
...
Fixed #11874 (leading 0s ignored by debugger)
2019-11-27 15:57:54 -08:00
155016531f
Merge pull request #8439 from JosJuice/android-native-motion-controls
...
Android: Native motion controls
2019-11-27 15:40:43 -08:00
34a1df1c68
Merge pull request #8493 from JosJuice/android-audio-volume
...
Android: Add audio volume setting
2019-11-27 15:36:54 -08:00
e33acc07f9
Merge pull request #8332 from CookiePLMonster/dsp-lle-deadlock
...
DSPLLE: Put DSP thread in idle state when it's paused
2019-11-27 15:34:34 -08:00
44f85bbc5e
Merge pull request #8496 from JosJuice/volumewii-check-decrypted-order
...
VolumeWii: Check SupportsReadWiiDecrypted before m_encrypted
2019-11-27 15:33:43 -08:00
f20c1c2f8d
Merge pull request #8499 from JosJuice/volumeverifier-super-paper-mario
...
VolumeVerifier: Detect broken Super Paper Mario
2019-11-27 15:31:05 -08:00
59633f5309
VolumeVerifier: Detect broken Super Paper Mario
...
https://bugs.dolphin-emu.org/issues/11900
2019-11-27 18:26:22 +01:00
9938585702
DolphinQt: Remove "Experimental" from "Export Wii Save"
...
It's pretty well tested at this point.
2019-11-27 17:23:58 +01:00
cf8208ace9
Android: Add audio volume setting
2019-11-26 21:10:27 +01:00
23fc5f9e35
VolumeWii: Check SupportsReadWiiDecrypted before m_encrypted
...
Fixes using DirectoryBlob on extracted games that were unencrypted
prior to being extracted.
(One day I'll make DirectoryBlob actually support raw reads and then
the order of these two won't matter...)
2019-11-26 20:09:40 +01:00
ac77df9e90
Merge pull request #8490 from vadosnaprimer/dumping
...
2 minor dumping fixes
2019-11-25 10:38:44 +13:00
45ba745bc8
Merge pull request #8320 from CookiePLMonster/cpu-lock-yield-fix
...
Do not yield to UI from PauseAndLock
2019-11-24 20:12:04 +01:00
cb6a632c60
fix missing frame when you start another dump without closing dolphin
2019-11-24 18:02:38 +03:00
15e6e7ddd2
figure out new segment on the fly right in FrameDump::Start()
2019-11-24 18:02:36 +03:00
b28db1d4e6
UICommon: Make use of fmt where applicable
...
Continues the migration to using fmt.
Notably, this allows safely converting a map within USBUtils over to
containing string view instances, rather than std::string instances, as
fmt safely handles the formatting of string views.
2019-11-23 19:41:40 -05:00
ec895f544c
Merge pull request #8486 from lioncash/dualshock
...
InputCommon/DualShockUDPClient: Minor cleanup
2019-11-24 00:46:19 +01:00
6fbbc2683e
VideoCommon: Make use of fmt outside of shader generators
...
Migrates most of VideoCommon over to using fmt, with the exception being
the shader generator code. The shader generators are quite large and
have more corner cases to deal with in terms of conversion (shaders have
braces in them, so we need to make sure to escape them).
Because of the large amount of code that would need to be converted, the
conversion of VideoCommon will be in two parts:
- This change (which converts over the general case string formatting),
- A follow up change that will specifically deal with converting over
the shader generators.
2019-11-23 16:00:45 -05:00
fe9e7d5578
Prefer MessageBoxW to MessageBoxA
2019-11-23 13:56:05 +00:00
5dbabef355
Simplify wstring to QString conversion
2019-11-23 13:23:46 +00:00
334e2768f5
InputCommon/DualShockUDPClient: Use an alias for the clock type
...
Makes code slightly less verbose without exposing the whole chrono
header to the current source file.
2019-11-22 17:06:10 -05:00
db9e592765
InputCommon/DualShockUDPClient: Use deduction guides for lock_guard
...
With C++17, we can use template deduction guides provided by the
standard library. This allows the omission of the mutex type itself.
2019-11-22 17:06:10 -05:00
278d03f737
InputCommon/DualShockUDPClient: Make use of std::array where applicable
...
Provides the same semantics of a C array, but is much nicer to work
with.
Notably, it makes all cases of performing comparisons with said arrays
significantly less reading-involved.
2019-11-22 17:06:07 -05:00
5be9505ab3
Signal DSP thread after unlocking DSP mutex
2019-11-22 23:00:42 +01:00
a06da596e5
Merge pull request #8485 from lioncash/imu
...
InputCommon/IMU*: Remove unnecessary includes
2019-11-22 22:31:57 +01:00
af37d09b0f
Merge pull request #8484 from lioncash/input-func
...
InputCommon/FunctionExpression: Minor cleanup
2019-11-22 22:31:31 +01:00
e30ff7c327
DSPLLE: Put DSP thread in idle state if it's paused to prevent a deadlock
...
DSP thread is considered "idle" when it signals s_ppc_event and waits for s_dsp_event,
without putting it in this state when m_dsp_thread_mutex is locked it was possible to
create a deadlock between a DSP thread, emulation thread and Qt thread by accessing
Config menu immediately after booting up the game
2019-11-22 22:07:41 +01:00
67097b4574
InputCommon/DualShockUDPClient: Relocate settings to top of source file
...
This is a small namespace, so we can move it to the top of the file to
get it out of the way of everything else.
2019-11-22 15:56:29 -05:00
4488719a76
InputCommon/DualShockUDPClient: In-class initialize members where applicable
...
Deduplicates members within the constructor's initializer list.
2019-11-22 15:56:29 -05:00
544d6cbe52
InputCommon/DualShockUDPClient: Add missing header guard
...
Prevents potential inclusion issues from occurring.
2019-11-22 15:56:26 -05:00
91993b46d9
InputCommon/IMU*: Remove unnecessary includes
...
Trims out unnecessary includes to avoid unnecessary header dependencies.
This also resolves indirect inclusions of <optional> within
IMUAccelerometer.h and IMUGyroscope.h
2019-11-22 15:41:38 -05:00
814fd165af
InputCommon/FunctionExpression: Use Yoda conditions, we do not
...
The general convention in the codebase is to compare the non-constant
value/string with the constant value/string, not the other way around.
2019-11-22 15:36:18 -05:00
1f6077922b
InputCommon/FunctionExpression: Remove unnecessary 'else' in MakeFunctionExpression()
...
Given all conditional bodies only contain a return, the use of else here
isn't necessary.
This has the benefit of consistently vertically aligning the names.
2019-11-22 15:36:18 -05:00
10fea99d80
InputCommon/FunctionExpression: Make MakeFunctionExpression() take a std::string_view
...
There's nothing within this function that requires a copy of the string
to be made, so we can make use of a non-owning view
2019-11-22 15:36:18 -05:00
ddf8abf507
InputCommon/FunctionExpression: Remove unused LOOP_MAX_REPS constant
...
This isn't used anywhere in the translation unit, so we can remove it.
2019-11-22 15:36:18 -05:00
64bc6f53fd
InputCommon/FunctionExpression: Remove cyclical include
...
This header was including itself, which is likely not intended.
2019-11-22 15:36:18 -05:00
cb8fbe872e
InputCommon/FunctionExpression: Collapse namespaces
...
Since we target C++17, we can collapse the namespaces into a single
declaration specifier.
2019-11-22 15:36:14 -05:00
6586ecc7a8
InputCommon/FunctionExpression: include <algorithm>
...
std::min/std::max are used within this translation unit, so it needs to
be included to prevent potential compilation failures.
2019-11-22 14:41:13 -05:00
e8edc49bbe
InputCommon: Make use of fmt where applicable
...
Continues the migration over to fmt
2019-11-22 14:38:26 -05:00
5b6e7aabcf
Fixed 11874 (leading 0s ignored by debugger)
2019-11-22 19:16:34 +00:00
bc449fb98f
Merge pull request #8480 from JosJuice/volumeverifier-block-future
...
VolumeVerifier: Fix a copypaste error
2019-11-22 11:42:50 -05:00
4e713238d9
VolumeVerifier: Fix a copypaste error
...
This was completely wrong, but I guess it happened to work correctly
anyway due to timing reasons (MD5 is faster than SHA-1 + AES).
2019-11-22 13:39:04 +01:00
a9cf8670e0
Merge pull request #8224 from Pokechu22/wiimote-eeprom
...
Write the entirety of the Wiimote EEPROM, in a per-Wiimote file
2019-11-20 22:03:53 +01:00
c8b8a60033
Android: Let WiimoteEmu know whether we have accelerometer/gyroscope
2019-11-20 20:13:36 +01:00
b143df91be
Android: Native motion controls
2019-11-20 18:22:20 +01:00
d66050375c
Merge pull request #8347 from hosaka-corp/frame-advance-alignment
...
Align frame advance and movies to full field boundaries
2019-11-19 19:26:35 +01:00
dae01b1a3b
Merge pull request #8346 from DacoTaco/master
...
GCMemcardManager : icon drawing takes to much cpu time
2019-11-18 23:37:11 +01:00
9c5c3c055e
Align frame advance and movies to full field boundaries
2019-11-18 15:05:06 -06:00
282470e312
DolphinQt: Fix accelerometer mapping indicator flipped X axis.
2019-11-17 16:41:06 -06:00
4d4a095c76
Reset Wiimotes on force stop and when starting MIOS
2019-11-17 12:20:26 -08:00
a23609562d
Replace magic disconnect channel number with a constant
2019-11-17 12:20:25 -08:00
5477409847
Write the entirety of the Wiimote EEPROM, in a per-Wiimote file
...
Previously, only Mii data was written. Additionally, the file containing mii data was shared for all Wiimotes, which made it a lot less useful.
Additionally, the file was read/written on each Wiimote read, even though the whole EEPROM was kept in memory. This was bad for performance and not particularly necessary (it did enforce that the data was properly shared between all Wiimotes, but that's not something I want).
2019-11-17 12:20:19 -08:00
d6eb75b272
GCMemcardManager : Performance boost
2019-11-17 20:45:24 +01:00
97f9f252cc
Merge pull request #8464 from jordan-woyak/wm-emu-errorcode
...
WiimoteEmu: Minor accuracy fixes.
2019-11-17 10:39:18 +01:00
bc1aa3640b
Merge pull request #8302 from AdmiralCurtiss/gcmemcard-comments
...
GCMemcard: Read comments, banners, and icons via logical data offsets instead of physical ones.
2019-11-17 10:34:06 +01:00
3b67d0d90a
GCMemcard: Read icons according to logical data offsets instead of physical data offsets. Also gets rid of some undefined behavior.
2019-11-17 01:42:26 +01:00
110d6c1da3
GCMemcard: Read banners according to logical data offsets instead of physical data offsets. Also gets rid of some undefined behavior.
2019-11-17 01:42:26 +01:00
2f119bd206
GCMemcard: Move Icon and Banner constants to the GCMemcard header.
2019-11-17 01:42:26 +01:00
58f21830bd
GCMemcard: Read file comments according to logical data offsets instead of physical data offsets.
2019-11-17 01:42:26 +01:00
770605bc80
GCMemcard: Add method to read an arbitrary block of bytes from a save file.
2019-11-17 01:42:26 +01:00
85c2841643
Make "Do you want to stop emulation?" application modal and disallow multiple instances at once
...
Fixes numerous issues with this dialog spawning multiple times
and putting Dolphin in a weird state.
2019-11-16 19:51:55 +01:00
af92a88aa0
UI: Allow to specify modality of ready ModalMessageBoxes
2019-11-16 19:51:00 +01:00
b712cc106b
Merge pull request #7909 from LAGonauta/dplii-quality-slider
...
Add slider to change DPLII decoder quality
2019-11-16 18:13:58 +01:00
a77108236e
Merge pull request #8418 from lioncash/core-fmt
...
Core: Replace usages of StringFromFormat with fmt where applicable
2019-11-16 18:09:58 +01:00
3ebcc445de
Core/Jits: Adds an option to disable the register cache.
...
This will help to disable all inter-instruction dependencies.
So android users can check if only a single instruction is broken without compiling dolphin on their own.
2019-11-16 13:05:54 +01:00
fe39e1e6d8
Merge pull request #8440 from rlnilsen/motion-input-tweaks
...
Motion Input enhancements
2019-11-15 14:08:45 +01:00
c23da15a22
Merge pull request #8470 from BreadFish64/patch-2
...
Fix typo in comment
2019-11-11 22:34:04 +01:00
0334dde2cf
Fix typo in comment
2019-11-11 13:20:04 -06:00
cfbabd4c41
SI_Device: Provide proper insertion/extraction operators for SIDevices enum
...
Allows the enumeration to be safely used with our type parsing
functions.
2019-11-11 07:33:01 -05:00
febd1c3dba
Core: Replace usages of StringFromFormat with fmt where applicable
...
Migrates usages of StringFromFormat over to using fmt.
2019-11-11 07:32:57 -05:00
08787ebc4a
Centralize logic to detect when the DPL2 decoder should be used.
2019-11-11 08:03:36 -03:00
4daeacba35
Fix malformed manifests
2019-11-11 11:47:10 +01:00
4d24f160e3
WiimoteEmu: Minor accuracy fixes.
2019-11-10 20:38:21 -06:00
913cb08066
Merge pull request #8456 from jordan-woyak/input-gate-race-fix
...
InputCommon: Make the "input gate" not racy.
2019-11-11 10:59:49 +10:00
066012b80d
Merge pull request #8454 from jordan-woyak/motion-input-indicators
...
DolphinQt: Add accelerometer/gyroscope mapping indicators.
2019-11-10 18:57:31 +01:00
499f065b83
Merge pull request #8466 from jordan-woyak/evdev-float
...
evdev: fix bad integer division.
2019-11-10 18:53:22 +01:00
df32e3fdfd
Merge pull request #8445 from Leseratte10/master
...
Add /dev/dolphin for homebrew to get information about Dolphin
2019-11-10 17:34:07 +01:00
0c57887839
evdev: fix bad integer division.
2019-11-10 10:10:37 -06:00
a68789a70c
D3DCommon: Remove unused GetDebugObjectName and tidy up SetDebugObjectName
2019-11-10 16:07:32 +01:00
8445644e05
D3DCommon: Migrate few remaining raw pointers to WRL::ComPtr
2019-11-10 16:07:32 +01:00
e85e51e5ce
HW/WiimoteReal: Replace invalid select call with poll.
2019-11-09 19:22:58 -06:00
59ebaed81c
HW/WiimoteReal: Remove an old comment. We block infinitely now.
2019-11-09 18:45:09 -06:00
eebc64aaf8
Merge pull request #8460 from jordan-woyak/evdev-motion-data
...
InputCommon: Detect when evdev exposes acceleration/gyroscope data.
2019-11-09 23:34:51 +01:00
9e0b09ddf4
Disable full MMU by default and add it to global config GUI
...
Requested by JMC.
2019-11-09 23:26:55 +01:00
c167543eb3
Merge pull request #8185 from Techjar/memcard-manager-auto
...
Qt/GCMemcardManager: Load configured memory cards by default
2019-11-09 23:06:57 +01:00
08b191ee8e
Merge pull request #8313 from JosJuice/gamelist-xml
...
GameFile: Support HBC-style XML metadata
2019-11-09 22:59:26 +01:00
f4e12f85bc
Merge pull request #8393 from CookiePLMonster/long-paths
...
Support Windows 10 long paths
2019-11-09 21:10:16 +01:00
6cb60f8d36
Merge pull request #8385 from iwubcode/pathes-update
...
DolphinQt: Add ability to override ResourcePack and Load directory
2019-11-09 20:39:15 +01:00
1180c231a6
InputCommon: Detect when evdev exposes acceleration/gyroscope data.
2019-11-09 13:34:29 -06:00
8ef25ddd84
DolphinQt: Add accelerometer/gyroscope mapping indicators.
2019-11-09 09:59:45 -06:00
2d55a6b0b7
Add /dev/dolphin for homebrew to get information about Dolphin
...
Adds a /dev/dolphin interface that can be used by
Dolphin-aware software to get information like the
real system time and the Dolphin version.
2019-11-09 15:31:51 +01:00
a6b3a2cd4f
DolphinQt: Hide unused buttons in the advanced mapping dialog.
2019-11-08 17:47:19 -06:00
1e028025e5
Common: Add additional Matrix/Vec functions.
2019-11-08 15:46:45 -06:00
d8c62b5965
Merge pull request #8396 from jordan-woyak/mapping-input-list-states
...
Qt/Mapping: Show current input states in advanced dialog.
2019-11-08 22:15:45 +01:00
422c3f79da
Merge pull request #8382 from tkln/verify-widget-switch-none-warn
...
VerifyWidget: Handle Severity::None case in Verify()
2019-11-08 11:23:32 +10:00
62f331dd13
Merge pull request #8431 from ferrrry/game-window-class
...
Qt: Add "renderer" window role to render window
2019-11-08 11:22:49 +10:00
71b098a69d
Merge pull request #8399 from CookiePLMonster/gametracker-fixes
...
Qt: Game Tracker fixes
2019-11-08 11:22:09 +10:00
9700b1e320
Merge pull request #8367 from JosJuice/missing-company-ids
...
DiscIO: Add missing company IDs
2019-11-08 11:15:27 +10:00
a89fdb628c
Merge pull request #8343 from stenzek/fbdev
...
DolphinNoGUI: Add a FBDev platform
2019-11-08 11:05:53 +10:00
2ebea1bfa7
Merge pull request #8433 from JosJuice/settings-onemulationstatechanged
...
DolphinQt: Call OnEmulationStateChanged when creating config window panes
2019-11-08 11:01:14 +10:00
47677ecaa7
Merge pull request #8437 from JosJuice/batch-render-to-main
...
Disable render to main when using batch mode
2019-11-08 11:00:18 +10:00
9db1ce8ef9
Merge pull request #8436 from JosJuice/vi-wii-freeloader
...
VideoInterface: Don't crash when running Wii Freeloader
2019-11-08 10:56:25 +10:00
28ce9330a8
Merge pull request #8444 from booto/vi-fields
...
VI: Adjust start/end of ACV region for fields
2019-11-08 10:51:32 +10:00
18ba1fd723
Merge pull request #8452 from JosJuice/android-emulationactivity-rotation-crash
...
Android: Replace emulation rotation crash workaround with proper fix
2019-11-08 10:45:21 +10:00
7c8a255ce1
Merge pull request #8450 from jordan-woyak/mapping-button-fix
...
DolphinQt: Fix output mapping button spacebar activation and tooltip.
2019-11-08 10:30:33 +10:00
b554b636bd
Merge pull request #8449 from JosJuice/disable-bt-pt-buttons
...
DolphinQt: Fix the enabling/disabling of ControllersWindow buttons
2019-11-08 10:27:49 +10:00
5440be96e7
Merge pull request #8378 from stenzek/quad-buffer-stereo
...
Various quad-buffered ("HDMI 3D") stereo fixes
2019-11-08 10:26:58 +10:00
85ceb37ccd
InputCommon: Make the "input gate" not racey.
2019-11-06 16:31:02 -06:00
93d7b3d159
Merge pull request #8432 from jordan-woyak/hotkey-indicator-fix
...
DolphinQt: Make HotkeyScheduler call UpdateInput when hotkeys are disabled.
2019-11-07 10:05:54 +13:00
c007dd1852
Android: Replace emulation rotation crash workaround with proper fix
...
The workaround was added in 0446a58de632fc
2019-11-05 09:28:40 +01:00
32cf4b76be
DolphinQt: Fix tooltip of output mapping buttons.
2019-11-03 18:20:08 -06:00
1bdf43dd78
DolphinQt: Fix spacebar not activating output mapping buttons.
2019-11-03 18:17:51 -06:00
ef1bae5320
DolphinQt: Fix the enabling/disabling of ControllersWindow buttons
...
Without this change, calling OnEmulationStateChanged undoes part
of the enabling/disabling that OnWiimoteModeChanged has done.
2019-11-03 15:03:58 +01:00
f7a50545e3
Motion Input: Add "enable" checkbox for motion controlled cursor.
2019-11-03 11:56:01 +01:00
d67a2304b0
Input: Add optional "enable" setting to the ControlGroup class.
...
The setting is exposed as a check box in the QGroupBox instance that visualises the ControlGroup instance.
The setting is saved under "[control group name]/Enabled", but only when it is "false". The default value is "true".
2019-11-03 11:55:52 +01:00
490fd0c3b3
DolphinQt: Add way to override "ResourcePack" folder that controls the location of resource packs
2019-11-02 13:42:40 -05:00
876a1ccc3e
DolphinQt: Add way to override "Load" folder that controls the location of custom textures
2019-11-02 13:30:44 -05:00
56d37d773b
RedumpVerifier: Show an error when datfile lacks serials or versions
...
This happens if someone manually downloads a regular datfile from
redump.org and puts it where Dolphin stores datfiles. Dolphin needs
"special" datfiles that contain fields for serials and versions.
Before this change, all discs (except Datel discs) would show up as
"Unknown disc" when using a regular datfile.
2019-11-02 16:49:20 +01:00
3006c73bf6
Qt/RenderWidget: Account for devicePixelRatio when auto-adjusting window size
2019-11-01 14:37:29 -04:00
49d9c63908
Motion Input: DSU Client config UI: Enable server IP address and port fields only when "server enable" is checked.
2019-11-01 03:35:07 +01:00
371e3f1021
VI: Adjust start/end of ACV region for fields
...
This wasn't changed when halfline counts were changed to 0-based. Also
included is a diagram showing an understanding of how the values in the VI
timing registers maps to the video signal.
2019-10-31 21:04:22 -04:00
16f103ab42
Vulkan: Exclusive fullscreen support via VK_EXT_full_screen_exclusive
2019-10-31 22:45:59 +10:00
6fc6444687
Vulkan: Explicitly enable VK_KHR_get_physical_device_properties2
...
This was missing from the subgroup PR way back.
2019-10-31 22:45:59 +10:00
230190fc36
Vulkan: Allow runtime querying of enabled extensions
2019-10-31 22:45:59 +10:00
d3ee0a4535
Merge pull request #8379 from stenzek/mali
...
Vulkan: Optimizations for Mali with EFB2RAM on
2019-10-31 22:44:19 +10:00
fd4bf5f0a2
Merge pull request #8438 from JosJuice/tilt-tooltip-string
...
Change Wii Remote tilt tooltip string based on translator feedback
2019-10-30 05:39:13 -04:00
78fad0aafa
Merge pull request #8443 from JosJuice/redumpverifier-datel-wii
...
RedumpVerifier: Fix handling of Datel Wii disc serials
2019-10-30 05:37:08 -04:00
f9705fd117
Return nothing from VolumeWii::GetGameTDBID if Datel
...
RedumpVerifier relies on this.
2019-10-30 10:23:33 +01:00
42ec861469
RedumpVerifier: Fix handling of Datel Wii disc serials
...
GC Datel discs have empty serials, but Wii Datel discs have
serials starting with DS followed by some digits.
2019-10-30 10:11:24 +01:00
49977446dd
RedumpVerifier: Don't crash on missing hyphen in serial
2019-10-30 09:58:37 +01:00
e2ef248260
VolumeVerifier: Fix "The data partition is missing" false positive
...
My bad...
2019-10-30 09:38:18 +01:00
379f264aa8
Disable render to main when using batch mode
...
https://bugs.dolphin-emu.org/issues/11888
This also includes another change: DolphinQt will now exit with an
error if you use --batch without specifying a game using any method
(unlike in the past where --batch would be ignored if you didn't
specify a game using --exec, even if you had used --nand-title).
The main reason why I did this was because coding the alternative
(ignoring --batch) would be annoying with render to main involved.
2019-10-29 18:32:43 +01:00
1f3d1a9b7f
Merge pull request #8352 from rlnilsen/motion-controller-support-via-cemuhook-protocol
...
Support for motion controllers like the DualShock 4
2019-10-28 16:39:10 +01:00
f4da08eb13
Change Wii Remote tilt tooltip string based on translator feedback
2019-10-28 11:16:55 +01:00
0dbb58112a
CommandLineParse: Don't ignore video_backend/audio_emulation when not using -C
2019-10-28 10:36:56 +01:00
10d972789a
DolphinQt: Make WiiPane connect itself to EmulationStateChanged
2019-10-27 21:26:35 +01:00
da1f153b47
Rename all instances of "CemuhookUDPServer"/"UDPServer" to "DualShockUDPClient"/"DSUClient".
2019-10-27 16:05:22 +01:00
332cad21a4
Wiimote Mapping UI: Motion Input tab: Rework mapping warning, add explanation of and button to open Alternate Input Sources window.
2019-10-27 15:59:36 +01:00
090f04e01c
VideoInterface: Don't crash when running Wii Freeloader
...
Datel's Wii Freeloaders set m_PictureConfiguration.WPL to 0 for
a while. Not sure if the fix in this commit is a proper fix or
just a hack, since I'm not very familiar with this code.
With this change, it's possible to run a Wii Freeloader if you
are running an old enough version of the Wii Menu, but the
"coloured bars" that Datel reference in their documentation
never show up. The screen just freezes for a few seconds instead.
2019-10-27 15:46:33 +01:00
14e47e43f9
add custom command to install_name_tool -add_rpath
2019-10-27 07:27:21 +07:00
427d4501bc
Merge pull request #8429 from JosJuice/redump-create-path
...
Create necessary folder when using Redump.org integration
2019-10-26 15:51:25 -04:00
cc6a1193b0
Merge pull request #8430 from JosJuice/eof-i18n-comment
...
InputCommon: Change "EOF" to "end of expression" in user facing string
2019-10-26 15:02:48 -04:00
8833e2a7fa
DolphinQt: Call OnEmulationStateChanged when creating config window panes
...
Otherwise UI elements won't be disabled correctly if the config
window is first opened while a game is running.
2019-10-26 17:50:54 +02:00
9d18402d07
DolphinQt: Make HotkeyScheduler call UpdateInput when hotkeys are disabled.
2019-10-26 10:03:57 -05:00
5ff79499a5
UDPServer: Add configuration UI.
...
Accessed through button "Alternate Input Sources" in the "Controller Settings" dialog.
2019-10-26 02:20:18 +02:00
8aec424191
Controller Settings Dialog: Rename "Advanced" group box to "Common".
...
The only setting inside, "Background Input", doesn't seem advanced to me, but it is used for both GC an Wii input.
2019-10-26 02:20:17 +02:00
4cb3baba5c
Add support for motion controllers via the CemuHook controller input protocol.
...
This is done by:
1) Implementing said protocol in a new controller input class CemuHookUDPServer.
2) Adding functionality in the WiimoteEmu class for pushing that motion input to the emulated Wiimote and MotionPlus.
3) Suitably modifying the UI for configuring an Emulated Wii Remote.
2019-10-26 02:19:53 +02:00
ae337dbea9
Qt: Add "renderer" window role to render window
2019-10-25 22:51:05 +01:00
c6b4438c62
InputCommon: Change "EOF" to "end of expression" in user facing string
...
This is hopefully clearer, since we're not dealing with a file.
2019-10-25 23:49:20 +02:00
2210a0a70c
Rebuild D_REDUMPCACHE_IDX path when needed
2019-10-25 20:49:28 +02:00
2f1b2c6adf
Create necessary folder when using Redump.org integration
...
This was making it impossible to use the Redump.org integration
without first manually creating a Redump folder in the Cache folder.
https://bugs.dolphin-emu.org/issues/11885
2019-10-25 11:07:50 +02:00
742aa765c6
VolumeVerifier: Don't show problems with good dumps of Wii Freeloaders
2019-10-25 10:03:12 +02:00
c6da1f050b
Merge pull request #8376 from tkln/watch-widget-sign-compare
...
WatchWidget: Fix integer comparison signedness warnings
2019-10-23 20:20:51 -04:00
897d7f634e
Merge pull request #8422 from CookiePLMonster/gamelistmodel-fixup
...
Fixup GameListModel::UpdateGame and columnCount
2019-10-23 20:20:03 -04:00
6991b39289
Merge pull request #8419 from jordan-woyak/xor-op
...
ExpressionParser: Add XOR operator.
2019-10-23 20:18:39 -04:00
291c056c07
Merge pull request #8424 from JosJuice/cpu-core-advanced-cleanup
...
DolphinQt: Cleanup after moving CPU Emulation Engine to Advanced tab
2019-10-23 20:16:32 -04:00
780d34dbca
Merge pull request #8426 from JosJuice/volumeverifier-region-mismatch
...
VolumeVerifier: Improve region/game ID mismatch checking
2019-10-23 20:15:31 -04:00
2c79c63608
Merge pull request #8330 from JosJuice/redump-integration
...
VolumeVerifier: Add Redump.org integration
2019-10-23 16:43:52 +02:00
77b9a70d6c
VolumeVerifier: Don't consider region mismatch for placeholder game IDs
2019-10-23 10:43:34 +02:00
97c4e8ff3a
VolumeVerifier: Include revision when checking region mismatch
2019-10-23 10:39:19 +02:00
2ff646b796
DSP must be set to LLE to select the decoder
2019-10-22 22:55:59 -03:00
3c9eb37381
Allow user to change DPLII decoding quality
2019-10-22 22:55:15 -03:00
95c4423f4c
DolphinQt: Cleanup after moving CPU Emulation Engine to Advanced tab
2019-10-22 20:54:01 +02:00
1c1c19e996
Qt/GCMemcardManager: Fix incorrect placeholder frame timing.
2019-10-21 22:47:17 +02:00
a0111628fb
Fixup GameListModel::UpdateGame and columnCount
...
- dataChanged takes "first" and "last" indices inclusive, not exclusive
- columnCount should return 0 for valid parents
2019-10-20 23:07:08 +02:00
1fe44238b1
ExpressionParser: Add XOR operator.
2019-10-20 09:51:52 -05:00
6282b0d83e
Merge pull request #8326 from lioncash/fmt
...
ActionReplay: Make use of fmt where applicable
2019-10-20 07:30:20 -04:00
d0114ea61e
Merge pull request #8415 from jordan-woyak/try-parse
...
StringUtil: Require TryParse of float types to use the entire string.
2019-10-20 07:29:20 -04:00
ef77101463
Merge pull request #8412 from jordan-woyak/def-warn-fix
...
Core/HW: Fix some explicitly defaulted but implicitly deleted warnings.
2019-10-19 17:47:40 -04:00
9e8181e80e
Core/HW: Fix some explicitly defaulted but implicitly deleted warnings.
2019-10-19 16:35:03 -05:00
68694e0039
Add signals to enable/disable Refresh button
...
Makes it impossible to spam Refresh button and looks better overall.
2019-10-19 23:15:38 +02:00
cc6ffef4a1
Add CommandType::BeginRefresh
...
This resolves a race condition when spamming Refresh button,
which would often end up with duplicates game entries for the entire
duration of the session.
2019-10-19 23:07:10 +02:00
5e7b95db3b
Add missing break to prevent fallthrough
2019-10-19 23:06:58 +02:00
0d254d9cb8
StringUtil: Require TryParse of float types to use the entire string.
2019-10-18 19:56:48 -05:00
bb8d0261be
DolphinQt: Mark ubershader setting names as translatable
...
These were marked as translatable in DolphinWX but not DolphinQt,
yet both DolphinWX and DolphinQt tried to fetch translations for them.
This meant that translations worked in both DolphinWX and DolphinQt
back when DolphinWX existed, but that translations stopped working
in DolphinQt once DolphinWX was removed (because the removal of
DolphinWX triggered the removal of the strings from the .po files).
2019-10-18 23:35:34 +02:00
40d15980c5
DolphinQt/Mapping: Explicitly specify parents of conditionally added widgets to prevent memory leaks.
2019-10-18 12:26:03 -05:00
fa8cbd83e2
Qt/Mapping: Show current input states in advanced dialog.
2019-10-18 12:19:16 -05:00
4a613dad20
Merge pull request #8304 from AdmiralCurtiss/memcard-manager-icon-fix
...
Qt/GCMemcardManager: Fix icon animations displaying incorrectly.
2019-10-17 18:03:21 -04:00
8bc0a92f2c
Merge pull request #7663 from jordan-woyak/expression-parser-improve
...
Expression parser improvements
2019-10-17 17:35:30 -04:00
acf9bd5ebe
Merge pull request #8408 from ethteck/move-cpu-emulation-engine-options
...
Qt: Move CPU Emulation Engine options to the Advanced tab
2019-10-17 12:56:50 -07:00
2647e412ae
Change from radio buttons to combobox, sizing fix and slight reorganization
2019-10-16 21:01:01 -04:00
6a15de58f4
Merge pull request #8403 from jordan-woyak/netplay-wiimote-buffer-fix
...
NetPlay: Allow Wii Remote buffer size to decrease
2019-10-16 16:20:53 -07:00
a21b7b1bdd
Merge pull request #8390 from jordan-woyak/wiimote-emu-tilt-fix
...
WiimoteEmu: Tilt fixes.
2019-10-16 16:14:42 -07:00
2f0ad1b6a0
Merge pull request #8402 from spycrab/qt_about_restructure
...
Qt/AboutDialog: Clean up code a bit
2019-10-16 22:25:26 +02:00
a6daed23e7
Merge pull request #8387 from sepalani/reg-view-in
...
RegisterWidget: Fix view in code/memory
2019-10-16 20:43:32 +02:00
1ce566f9fd
Moved CPU Emulation Engine options to the Advanced tab
2019-10-16 12:41:13 -04:00
b120b08726
ControllerEmu: Clamp results of trigger/slider states to prevent integer overflow later on.
2019-10-15 15:35:07 -05:00
4425d05c4a
Merge pull request #8400 from sepalani/fix-mega
...
SignatureDB: Add missing selectors
2019-10-15 18:24:03 +02:00
bbeb25de48
Qt/Debugger/CodeWidget: Allow pressing 'enter' in address search box.
2019-10-14 21:47:27 +02:00
d39555919d
Merge pull request #8395 from CookiePLMonster/improve-work-queue
...
Improvements to WorkQueueThread
2019-10-13 15:24:56 -04:00
8dc5557995
SignatureDB: Add missing selectors
2019-10-13 22:52:21 +04:00
24a36eb027
NetPlay: Allow Wii Remote buffer size to decrease by dropping reports.
2019-10-13 13:03:57 -05:00
aba23c8d87
Merge pull request #8401 from spycrab/qt_5.13.1
...
Externals/Qt: Update to 5.13.1
2019-10-13 16:27:33 +02:00
1975e57b73
Qt/AboutDialog: Clean up code a bit
2019-10-13 16:11:19 +02:00
ec526fee56
Externals/Qt: Update to 5.13.1
2019-10-13 16:06:56 +02:00
7295458c11
ExpressionParser: Make Lexer ctor explicit and move argument.
2019-10-12 12:28:19 -05:00
72302d9c42
ExpressionParser: Add support for /* */ style comments.
2019-10-12 11:41:02 -05:00
b4e2b3cae3
ControllerEmu: Don't clear expression variables on references update. Hotplug would make that problematic.
2019-10-11 19:42:49 -05:00
4d41bd64c8
ExpressionParser: Show error message with expected arguments.
2019-10-11 19:38:18 -05:00
b57178d246
ExpressionParser: Remove ! character from function syntax. Remove unused serialization functions.
2019-10-11 18:12:18 -05:00
7912dc57dd
ExpressionParser: Remove !while and add optional 2nd argument to !smooth.
2019-10-11 18:12:18 -05:00
ca7ce67450
ExpressionParser/DolphinQt: Added parse results to UI.
2019-10-11 18:12:18 -05:00
c8b2188e19
DolphinQT: Add syntax highlighting from tokenizer data.
2019-10-11 18:12:18 -05:00
e3cf2ae0d4
DolphinQT/IOWindow: Add combo boxes to insert the new operators and functions so people are semi-aware of them. Fixed the "Apply" button. Display an error message on expression parse error.
2019-10-11 18:12:18 -05:00
5cb1248612
ExpressionParser: Clean up some redundant using-declarations and wrong comments.
2019-10-11 18:12:18 -05:00
fae8b15db1
ExpressionParser: Add !pulse function that evaluates to 1.0 for N seconds for each press.
2019-10-11 18:12:18 -05:00
b5b43f8342
ExpressionParser: Add relative input function.
2019-10-11 18:12:18 -05:00
08b291b0f9
ExpressionParser: Fix timer function with negative values.
2019-10-11 18:12:18 -05:00
18b5120441
ExpressionParser: Add !tap function which activates after X (defaults to 2) taps within Y seconds.
2019-10-11 18:12:17 -05:00
f2e499d587
ExpressionParser: Add !hold function that activates after input is held for N seconds.
2019-10-11 18:12:17 -05:00
9e536382c4
ExpressionParser: Add function to smooth inputs.
2019-10-11 18:12:17 -05:00
bbd6b1848f
ExpressionParser: Add deadzone function.
2019-10-11 18:12:17 -05:00
6a2096c419
ExpressionParser: Add optional 2nd argument to toggle function which clears state.
2019-10-11 18:12:17 -05:00
fd07ae8cec
ExpressionParser: Move FunctionExpression type definitions into another file.
2019-10-11 18:12:16 -05:00
d4f9b8c4ef
ExpressionParser: Allow unary functions to be used without parens around the argument. e.g. !`Up`
2019-10-11 17:31:09 -05:00
2a377e35ed
ExpressionParser: Make function names case sensitive.
2019-10-11 17:31:09 -05:00
2b0297489f
ExpressionParser: Rename some functions and return a syntax error on trailing tokens.
2019-10-11 17:31:09 -05:00
258832b1e8
ExpressionParser: Change function argument syntax to something more c++-like.
2019-10-11 17:31:09 -05:00
ccac3f1e49
ExpressionParser: Fix negative literals and support unary minus operator.
2019-10-11 17:31:07 -05:00
7cf903a209
ExpressionParser: Suppport N-ary functions. Arguments are read LISP style. N atoms are read after the function name. Added "if" function and made the "while" function more sensible with an arity of 2. Removed the ugly binary conditional operator.
2019-10-11 17:16:05 -05:00
4dd078568b
ExpressionParser: Replace the timer literal with a timer function that increases from 0.0 to 1.0 and resets after N seconds. e.g. (!timer 2.0) is a 2 second timer. Fixed parsing of unary expressions so things like (! ! 1.0) work.
2019-10-11 17:14:45 -05:00
785eb14432
ExpressionParser: Clean up string lexing and support numeric literals without tick delimiter: e.g. 0.75
2019-10-11 17:14:45 -05:00
fa75ab404f
ExpressionParser: operator precedence.
2019-10-11 17:14:45 -05:00
46c0ae7d1f
ExpressionParser: Add !while loop unary expression. Limited to 10000 reps to prevent infinite loops. Rhs is re-evaluated until it is < 0.5. Added comma operator, which behaves like it does in c++. Added subration operator.
2019-10-11 17:14:45 -05:00
2c89b60298
ExpressionParser: cleanup.
2019-10-11 17:14:45 -05:00
58efc93ed4
ExpressionParser: Conditional operator. A binary op that evals the rhs if lhs > 0.5 else 0.0.
2019-10-11 17:14:45 -05:00
718efce1dc
ExpressionParser: Add less-than and greater-than operators.
2019-10-11 17:14:45 -05:00
35e51ebbaa
ExpressionParser: Clear expression variables on UpdateReferences call. I don't know if this is most sensible.
2019-10-11 17:14:45 -05:00
e896835f86
ExpressionParser: Renamed ControlFinder to ControlEnvironment. Added support for variables and assignment operator. ControlExpression objects now reference a matching input and output so the two can me mixed in any expression. (you can set rumble directly from inputs)
2019-10-11 17:14:32 -05:00
1efcf861ea
ExpressionParser: Add mod operator, sin function, and timer "constant" which can be used for auto-fire and oscillators.
2019-10-11 17:13:58 -05:00
a8f3e9585f
ExpressionParser: Expand ! symbol to allow for named unary functions. Added !toggle function which toggles on/off with each activation of its inner expression.
2019-10-11 17:13:58 -05:00
bf63f85d73
ExpressionParser: Add multiplication and division operators. (division by zero evaluates as zero). Don't clamp result of addition operator. Clamping will be done later.
2019-10-11 17:13:58 -05:00
f3192ca06d
ExpressionParser: Add support for literals.
2019-10-11 17:13:58 -05:00
5be061e27f
Merge pull request #8398 from jordan-woyak/old-wm-comment
...
WiimoteEmu: Fix an outdated comment.
2019-10-10 08:56:39 -04:00
443af3fabd
WiimoteEmu: Fix outdated comment.
2019-10-09 16:12:18 -05:00
7c286064b8
AudioCommon: Don't forget to call Init() on fallback
2019-10-10 00:09:16 +10:00
1c5441aa40
AlsaSoundStream: Don't call join() on invalid thread
...
This can happen if initialization failed.
2019-10-10 00:07:27 +10:00
6e613f4f82
Merge pull request #8386 from stenzek/gcc-array-workaround
...
FixedSizeQueue: Work around GCC generating large amounts of debug info
2019-10-09 15:42:53 +10:00
26ebf5b650
Improvements to WorkQueueThread
...
- Do not use a lambda for std::thread as invoke constructor exists
- Use simpler std::lock_guard wherever possible
- Do not require T to be default constructible
- Move T out of the queue instead of copying
2019-10-08 22:57:33 +02:00
ea8a3059bf
Enable Win10 long path awareness in manifest files
2019-10-07 22:46:37 +02:00
45890c20cf
Remove obsolete "Windows compatibility" macros
2019-10-07 22:46:37 +02:00
689378b435
Move GetModuleName to Common
...
This unifies GetModuleFileName calls between Dolphin and WinUpdater
and allows to gracefully remove MAX_PATH limit from GetExePath
2019-10-07 22:46:36 +02:00
3b21d32865
Remove MAX_PATH limit from:
...
- GetTempFilenameForAtomicWrite
- SetUserDirectory
2019-10-07 22:45:16 +02:00
02ba893803
DolphinQt: When audio backend is invalid, show nothing in dropdown
...
It used to show the first option, No Audio Output (but audio output
would work correctly anyway since AudioCommon didn't use this logic.)
2019-10-06 20:40:31 +02:00
b794737bcf
WiimoteEmu: Disable simulation of centripetal acceleration.
2019-10-06 09:56:41 -05:00
673f13b7ac
WiimoteEmu: Change default tilt angle to 85 degrees.
2019-10-06 09:56:41 -05:00
260cefd60b
WiimoteEmu: Expose maximum tilt acceleration.
2019-10-06 09:56:39 -05:00
b6545ea285
Merge pull request #8370 from sepalani/fix-hle-patch
...
HLE: Fix patching functions with the same name
2019-10-06 05:07:54 -04:00
beeb68d541
RegisterWidget: Fix view in code/memory
2019-10-06 12:25:46 +04:00
9a68eaaa24
Merge pull request #8292 from Pokechu22/ir-calibration
...
Use valid IR calibration data
2019-10-06 17:31:50 +10:00
dba7f3304d
Merge pull request #8361 from ligfx/remove_xaudio2
...
Remove XAudio2
2019-10-06 17:24:48 +10:00
4fd262d0b8
FixedSizeQueue: Work around GCC generating large amounts of debug info
2019-10-06 16:23:45 +10:00
5d03d5dde0
Another AVI fix for WinAPI importers
...
When not using native resolution, FFMPEG automatically selects FFV1 version 3 for whatever reason, and that can't be decoded by VirtualDub/AVISynth.
2019-10-05 23:31:06 +03:00
0dda920c1d
VerifyWidget: Handle Severity::None case in Verify()
...
The case body is empty because VolumeVerifier doesn't actually report
problems with severity of None.
Fixes "warning: enumeration value ‘None’ not handled in switch [-Wswitch]"
warning reported by gcc.
2019-10-05 13:20:29 +03:00
ae83d02e54
Drop 3D Vision Support
2019-10-04 13:40:21 +10:00
e3e682c4ca
WatchWidget: Change type of NUM_COLUMNS to int
...
Fixes integer comparison signedness warnings.
2019-10-03 23:00:41 +03:00
ecdf21a988
Config: Also set CommandBufferExecuteInterval to 0 by default on Android
2019-10-02 22:44:19 +10:00
328d89db70
Vulkan: Add a DriverDetails bug for "slow cached readback memory"
...
Using the cached memory type appears to be slower on Mali drivers, with
~10-15% CPU spent in the __pi___inval_cache_range kernel function.
2019-10-02 21:34:58 +10:00
c557aa4a15
Vulkan: Add strict flag to memory type selection
2019-10-02 21:27:32 +10:00
33a6d265e5
PostProcessing: Use interface blocks for shaders
2019-10-02 12:59:50 +10:00
af849126b3
Renderer: Use interface blocks for ImGui shaders
2019-10-02 12:52:45 +10:00
c98a5f7dfd
Renderer: Draw ImGui interface to both eyes
2019-10-02 12:19:47 +10:00
b44a0980eb
PostProcessing: Use correct layer in quad-buffered modes
...
Previously, only the left eye was being used.
2019-10-02 11:52:54 +10:00
e754c8ab26
D3D11: Initialize shader cache before renderer
...
Otherwise the shaders we need for e.g. postprocessing are null.
2019-10-02 11:50:10 +10:00
e88c269d02
PostProcessing: Don't use GS expansion shader for quad buffering w/ OpenGL
...
OpenGL doesn't render to a 2-layer backbuffer like D3D/Vulkan for quad-buffered
stereo, instead drawing twice with the eye selected by glDrawBuffer()
(see OGL::Renderer::RenderXFBToScreen).
2019-10-02 11:33:25 +10:00
e6ae204600
Merge pull request #8373 from jordan-woyak/stereo-mode-fix
...
DolphinQt/Graphics: Fix NVIDIA 3D Vision support handling.
2019-10-02 10:56:21 +10:00
dafb0173b7
Merge pull request #8375 from stenzek/stereo-switch
...
Fix runtime stereoscopy mode switching
2019-10-02 10:54:53 +10:00
b319f823bf
Merge pull request #8337 from CookiePLMonster/log-widget-improvements
...
Log widget improvements
2019-10-01 23:42:16 +10:00
135f0a1385
ShaderCache: EFB2RAM pipelines should not use a geometry shader
...
Only the left eye is used when creating the RAM copy.
2019-10-01 11:44:31 +10:00
c989e5c50c
ShaderCache: Recompile shared pipelines on shader cache reload
...
Fixes broken stereoscopy when switching on/off at runtime.
2019-10-01 11:43:02 +10:00
d15f08c84a
DolphinQt/Graphics: Fix NVIDIA 3D Vision support handling.
2019-09-30 15:43:55 -05:00
abc97bb0fa
DolphinQt: Don't overwrite >8x IR scale in ini, add maximum internal res option
...
This adds an ini-only setting under GFX.ini -> [Settings] ->
MaxInternalResolution. Setting this will allow the user to select
resolutions beyond the default 8x max scale in graphics options.
2019-10-01 01:17:08 +10:00
d3a9104cee
Merge pull request #8355 from phire/qt_fix_fifo_range
...
QtFifoPlayer: handle FIFO load before window creation
2019-09-30 00:34:39 -04:00
bec433cb40
Merge pull request #8333 from CookiePLMonster/screenshot-timestamp
...
Core: Generate screenshot name with timestamps
2019-09-30 00:32:07 -04:00
06ab51bceb
Merge pull request #8324 from CookiePLMonster/adapter-combo-fix
...
Enable adapter combo only if adapters are supported by current backend
2019-09-29 00:13:55 +02:00
9d648904ed
Merge pull request #8341 from CookiePLMonster/win-utf8-console-output
...
ConsoleListenerWin: Properly output console logging in UTF-16
2019-09-28 18:28:08 +02:00
d8a3218726
HLE: Fix patching functions with the same name
2019-09-28 17:38:43 +04:00
f8a4975274
DiscIO: Make company names match GameTDB's list better
2019-09-25 13:38:39 +02:00
d8958fbdf7
GameFile: Use enums for custom/length parameters
2019-09-25 12:25:59 +02:00
59f27ae4e1
GameFile: Support HBC-style XML metadata
...
This feature was originally exclusive to the previous iteration of
DolphinQt (the one that was the reason for the current iteration
being named DolphinQt2 initially).
https://bugs.dolphin-emu.org/issues/8949
2019-09-25 12:25:33 +02:00
dbc0bf0ccb
Fix import gc save file window title
2019-09-24 19:16:27 +10:00
edfb0f66b6
Merge pull request #8363 from Fullmetal5/patch-1
...
Add Wii Mini system menu version detection
2019-09-23 20:18:45 +02:00
ff90a5855d
Qt/GCMemcardManager: Fix animation frame order and speed.
2019-09-23 01:55:46 +02:00
2300ce385e
DiscIO: Add missing company IDs
2019-09-22 23:12:31 +02:00
8f573cf5f2
Qt/GCMemcardManager: Fix animation frame decoding.
2019-09-22 21:55:06 +02:00
5c4b591536
Add Wii Mini system menu version detection
2019-09-21 12:55:49 -05:00
3efa3d7a42
Fix 2 DTK bugs
...
Bug 1: subcommand 1 of 0xE1 does not actually reset the current position; it just stops playback. 0xE2 returns the same value it would have before stopping playback (other than reporting that the stream is stopped).
Bug 2: subcommand 3 of 0xE2 was incorrectly dividing the length by 4; while this makes sense for positions (which are multiplied by 4 earlier to get a byte offset), it is not correct for lengths.
2019-09-14 21:05:33 -07:00
71c3c5626b
AudioCommon: if backend is unknown, use default backend
2019-09-14 14:16:13 -07:00
0f3695a14b
Remove XAudio2
...
Audio on Windows is provided by the cubeb (shared mode) and WASAPI
(exclusive mode) backends, both of which exhibit lower latency.
2019-09-14 14:08:13 -07:00
677a0903a1
FifoPlayer: Use std::move for saving callbacks
2019-09-09 11:38:21 +12:00
46f4f69cfd
QtFifoPlayer: handle fifo load before window creation
...
Fixes a bug where if you loaded a fifo before opening the fifo
player window (which you can do by dragging a .dff onto dolphin's
main window) then the player's widgets wouldn't be initilized
correctly.
Importantly, the object range widgets would be broken.
2019-09-09 10:36:31 +12:00
c144cde825
Revert "DSP: ARAM cleanup experiments"
2019-09-02 01:47:50 -04:00
03ea0eb27a
Merge pull request #7740 from booto/aram-experiments
...
DSP: ARAM cleanup experiments
2019-09-01 20:09:42 -04:00
a4f13ca57d
Remove double space in GeckoCodeWidget code view
2019-09-01 11:22:42 -07:00
0a75e71672
DolphinNoGUI: Add a FBDev platform
...
And the associated GLContext bits
2019-09-01 14:00:40 +10:00
43fe02ee9b
GLContext: Get size using eglQuerySurface()
...
Also no longer assumes that a nullptr display is not headless (needed for fbdev)
2019-09-01 13:35:11 +10:00
6bfa4fa643
LogWidget: Use FixedSizeQueue for a log messages buffer
...
Messages buffer is intended to be of a fixed capacity (MAX_LOG_LINES),
which cannot be achieved by std::queue unless we manually pop() extra elements.
std::queue uses std::deque internally which most likely results in allocations performed continuously.
FixedSizeQueue keeps a single buffer during its entire lifetime, avoiding any allocations except the ones
performed by stored objects.
2019-08-31 21:18:07 +02:00
b3969e91d9
FixedSizeQueue: Bugfixes and improvements
...
- Fixed a bug where pushing items over queue's size left it in a corrupted state
- For non-trivial types, have clear() and pop() run destructors
- Added emplace(args...)
- Added empty()
FixedSizeQueue has semantics of a circular buffer,
so pushing items continuously is expected to keep overwriting oldest elements gracefully.
Tests have been updated to verify correctness of a previously bugged behaviour
and to verify correctness of destructing non-trivial types
2019-08-31 21:18:07 +02:00
b088fc37d5
LogWidget: Do not use QueueOnObject to construct log queue,
...
instead store a std::string constructed from string_view and convert to QString just before appending
2019-08-31 11:59:09 +02:00
e746d95d01
LogWidget: Stop update timer when log window is invisible so it doesn't continuously update in the background
2019-08-31 11:57:27 +02:00
7cec8601f1
LogWidget: Remove scrollbar tampering code (doesn't seem to do anything), clear text queue on clearing log
2019-08-31 11:57:07 +02:00
eb7d42dfe8
LogWidget: Replace QTextEdit with QPlainTextEdit for better performance
...
QTextEdit is heavy, similar in functionality to WordPad,
while QPlainTextEdit is lightweight like Notepad.
Qt documentation recommends using QPlainTextEdit for log viewers,
and it also allows to set automatic cutoff of oldest messages beyond a fixed point,
which we now set to MAX_LOG_LINES (5000)
2019-08-31 10:46:04 +02:00
eab086b880
ConsoleListenerWin: Properly output console logging in UTF-16 so UTF-8 displays properly
2019-08-31 00:44:44 +02:00
c268aa3a46
SI: Reduce logging.
2019-08-28 22:16:41 -04:00
37ef5a54c9
Core: Use move semantics for Renderer::SaveScreenshot
2019-08-28 19:52:35 +02:00
ff8f978eaf
Core: Generate screenshot name with timestamps instead of only increasing numbers
2019-08-28 19:52:35 +02:00
9e3b867c6a
VideoInterface: start counting half-lines at 0 instead of 1
...
- Re-organize VideoInterface::Update() to count half-lines starting at 0 instead of 1
- Use horizontal position when checking if we should assert some display interrupt
- Add some more descriptive comments
2019-08-26 20:43:26 -05:00
a3d8a8be06
NetPlay: Remove 'reduce polling rate' option
...
With the SI poll line count fixed, pretty much all games are polling
twice per frame anyways, making this option superfluous. Since it's a
bit of a gross hack and makes DTMs incompatible with console, let's
just bin it.
2019-08-26 02:11:49 -04:00
87c5e0b30e
VolumeVerifier: Add Redump.org downloading
2019-08-25 12:53:19 +02:00
3eb360b818
VolumeVerifier: Add zip support for datfile
2019-08-24 16:37:19 +02:00
22933d8502
VolumeVerifier: Add datfile parsing
2019-08-24 16:37:19 +02:00
88522b7a26
Merge pull request #8327 from JosJuice/more-string-view-regression
...
DolphinQt: Fix whitelisting USB devices
2019-08-23 21:32:13 +10:00
c1a0a8f84a
DolphinQt: Fix whitelisting USB devices
...
Revert of https://github.com/dolphin-emu/dolphin/pull/8233#discussion_r306223322
2019-08-23 13:22:33 +02:00
5614594f5e
Qt/GCMemcardManager: Add an 'All Files' option to the filetype selection.
2019-08-22 20:18:21 +02:00
f414d926c1
ActionReplay: Make use of fmt where applicable
...
Converts the ActionReplay logging over to using fmt instead of
StringFromFormat.
2019-08-21 17:59:33 -04:00
f79ca65170
UICommon: Remove Android hacks from GameFile
2019-08-21 18:48:52 +02:00
2a95227f64
Merge pull request #8255 from JosJuice/remove-unsigned-warning
...
Remove "not signed by Nintendo" warning when installing WADs
2019-08-21 09:38:35 -07:00
5f38386575
Merge pull request #8222 from JosJuice/allow-mismatched-region-settings
...
Replace "Override Language on NTSC Games" with "Allow Mismatched Region Settings"
2019-08-21 09:00:06 -07:00
bf9427fafe
Merge pull request #8314 from JosJuice/menubar-movie-more
...
DolphinQt: Fix the enabling/disabling of Movie items even more
2019-08-21 08:58:24 -07:00
35eb63de2c
Merge pull request #8300 from AdmiralCurtiss/gcmemcard-construction
...
GCMemcard: Rework construction logic.
2019-08-21 08:56:31 -07:00
288dd649da
Merge pull request #8273 from CookiePLMonster/config-threading-fixes
...
Threading fixes for config layers
2019-08-21 08:55:03 -07:00
bbae0424a1
Merge pull request #8319 from Tilka/mcrfs
...
Jit64: fix mcrfs
2019-08-20 21:28:52 +01:00
df0ff7f3bb
Enable adapter combo on emulation state change only if adapters are supported by current backend
2019-08-20 20:08:14 +02:00
Markus Wick