d51f504629
Android: Convert SingleChoiceSetting to Kotlin
2023-03-15 17:35:34 -04:00
1fc9f03b27
Android: Convert RunRunnable to Kotlin
2023-03-15 17:35:34 -04:00
62679bacc1
Android: Convert PercentSliderSetting to Kotlin
2023-03-15 17:35:34 -04:00
72be338d56
Android: Convert LogSwitchSetting to Kotlin
2023-03-15 17:35:34 -04:00
56c33890b9
Android: Convert InvertedSwitchSetting to Kotlin
2023-03-15 17:35:34 -04:00
2369977e14
Android: Convert IntSliderSetting to Kotlin
2023-03-15 17:35:34 -04:00
826e849a7b
Android: Convert InputStringSetting to Kotlin
2023-03-15 17:35:34 -04:00
fc97c4d35a
Android: Convert HyperLinkHeaderSetting to Kotlin
2023-03-15 17:35:34 -04:00
f95fd7788e
Android: Convert HeaderSetting to Kotlin
2023-03-15 17:35:34 -04:00
1e2e9e004b
Android: Convert FloatSliderSetting to Kotlin
2023-03-15 17:35:34 -04:00
f7ad065408
Android: Convert FilePicker to Kotlin
2023-03-15 17:35:34 -04:00
1553477c09
Android: Convert StringSetting to Kotlin
2023-03-15 17:35:34 -04:00
2c560e05a8
Android: Convert Settings to Kotlin
2023-03-15 17:35:21 -04:00
dee85cead8
Android: Convert PostProcessing to Kotlin
2023-03-15 17:35:21 -04:00
42f4fb815f
Android: Convert NativeConfig to Kotlin
2023-03-15 17:35:21 -04:00
7c59640f8e
Android: Convert IntSetting to Kotlin
2023-03-15 17:35:21 -04:00
46e68171b9
Android: Convert FloatSetting to Kotlin
2023-03-15 17:34:49 -04:00
3ac72855e3
Android: Convert BooleanSetting to Kotlin
2023-03-15 17:34:21 -04:00
84c23c14db
Android: Convert AdHocStringSetting to Kotlin
2023-03-15 15:49:37 -04:00
a8f3d4291a
Android: Convert AdHocBooleanSetting to Kotlin
2023-03-15 15:49:37 -04:00
f1028b4652
Android: Convert AbstractStringSetting to Kotlin
2023-03-15 15:49:37 -04:00
32f9e48257
Android: Convert AbstractIntSetting to Kotlin
2023-03-15 15:49:37 -04:00
baeeaa2a43
Android: Convert AbstractFloatSetting to Kotlin
2023-03-15 15:49:37 -04:00
5bc2b46983
Android: Convert AbstractBooleanSetting to Kotlin
2023-03-15 15:49:37 -04:00
21e0b5b9d9
Android: Convert AbstractSetting to Kotlin
2023-03-15 15:49:37 -04:00
43fa5cf5e4
Android: Convert SettingsItem to Kotlin
2023-03-15 15:49:37 -04:00
6dc6720250
Android: Convert StringSingleChoiceSetting to Kotlin
2023-03-15 15:49:37 -04:00
98ab893be7
Android: Create extension functions for serializables
...
Getting serializables without explicitly stating the type is deprecated in Android 13. However we still need a way to get a serializable in versions below that. Now with these we can avoid repeating the same if block.
2023-03-15 14:26:37 -04:00
91fca0783e
Merge pull request #11647 from AdmiralCurtiss/perfquery-inconsistency
...
Fix PerfQuery inconsistencies across backends.
2023-03-15 15:20:11 +01:00
fe8be906f3
Android: Use LifecycleOwner instead of subtype
2023-03-14 23:03:13 +01:00
846f5f6671
Android: Clean up outdated comment in AfterDirectoryInitializationRunner
2023-03-14 23:03:13 +01:00
4281606838
Merge pull request #11641 from JosJuice/android-remove-old-config
...
Android: Remove support for the old config system
2023-03-14 15:48:04 -04:00
e83b6e19ab
Merge pull request #11655 from AdmiralCurtiss/dtk-heap
...
HW/DVDInterface: Avoid heap allocation in DTK callback.
2023-03-14 13:45:41 +01:00
4c21cdd0e6
HW/DVDInterface: Do DTK math in blocks instead of in samples.
2023-03-14 13:19:44 +01:00
aceafc9d26
Merge pull request #11652 from t895/header-padding
...
Android: Make header padding appear even
2023-03-14 13:03:19 +01:00
66b6a60afe
HW/DVDInterface: Avoid heap allocation in DTK callback.
2023-03-14 10:58:03 +01:00
3783bedc25
Merge pull request #11635 from Dentomologist/wiimote_fix_disconnection_deadlock
...
ControllerInterface: Fix deadlock when Wii Remote disconnects
2023-03-14 02:41:36 +01:00
aac9647ba2
Divide by MSAA for PerfQuery in all backends.
2023-03-14 02:13:25 +01:00
ddd2b598da
Return quarter value for PerfQuery in all backends.
2023-03-14 02:08:20 +01:00
970ddf0ea0
Merge pull request #11651 from JosJuice/android-profile-off-by-one
...
Android: Fix per-game profile setting off-by-one
2023-03-14 02:02:00 +01:00
43a5d506c8
Merge pull request #11644 from deReeperJosh/trapteamaudio
...
Skylander Portal: Play Trap Team Audio
2023-03-14 01:29:20 +01:00
26605c0184
Merge pull request #11649 from Pokechu22/tas-controller-input-update-widgets
...
DolphinQt: Fix TAS widgets not updating with enable controller input
2023-03-14 01:21:17 +01:00
5c962ea71f
Merge pull request #11650 from AdmiralCurtiss/more-system
...
More passing of System instead of using the singleton.
2023-03-13 23:36:17 +01:00
936c05e600
Merge pull request #11599 from shuffle2/vs17.5
...
vs: update to 17.5
2023-03-13 20:43:48 +01:00
4f610bb354
Android: Make header padding appear even
2023-03-13 15:27:09 -04:00
5818685911
Android: Fix per-game profile setting off-by-one
2023-03-13 18:30:55 +01:00
3006c23c85
Core/CPUThreadGuard: Fetch System from Guard.
2023-03-13 18:13:20 +01:00
31d33d0efd
HW/ProcessorInterface: Store reference to System in class.
2023-03-13 18:13:20 +01:00
ba852a7812
HW/Memmap: Store reference to System in MemoryManager.
2023-03-13 18:13:20 +01:00
026b6a3e0f
HW: Pass System to functions.
2023-03-13 18:13:20 +01:00
137b9d1da1
Merge pull request #11646 from AdmiralCurtiss/si-class
...
HW/SerialInterface: Refactor to class.
2023-03-13 13:09:51 -04:00
a6b2655631
Merge pull request #11636 from shuffle2/updater-test
...
Add test for Updater
2023-03-13 15:47:37 +01:00
3f6b931150
DolphinQt: Fix TAS widgets not updating with enable controller input
...
This regressed in 0300b44d23
2023-03-12 17:58:48 -07:00
f27e8216a5
Skylander Portal: Play Trap Team Audio
...
Asserts and length handling
2023-03-13 13:01:48 +13:00
bf2f901a99
HW/SerialInterface: Refactor to class.
2023-03-12 16:08:56 +01:00
784ce78eaf
Android: Use $applicationId for DocmentProvider authority
...
Fixes side by side installation of debug, benchmark and release builds.
2023-03-12 15:28:21 +01:00
d371b17f37
HW/SerialInterface: Pass System to ISIDevice.
2023-03-12 14:19:38 +01:00
ab05dfc263
Merge pull request #11642 from shuffle2/winupdater-fail
...
winupdater: improve wording of UI::Error
2023-03-12 04:11:16 -04:00
ee28d332b0
Merge pull request #11640 from AdmiralCurtiss/vi-class
...
HW/VideoInterface: Refactor to class.
2023-03-11 18:00:24 -05:00
ab3da5e4ce
winupdater: improve wording of UI::Error
2023-03-11 13:25:38 -08:00
06cb4ffa64
winupdater: fix CR getting into parsed VCToolsUpdateURL
2023-03-11 12:58:33 -08:00
0a8725e4a9
updater: add test for update flow
...
currently windows-only
2023-03-11 12:58:33 -08:00
de0bc06856
updater: flush log after each write
2023-03-11 12:58:33 -08:00
804b94ee9e
Merge pull request #11524 from K0bin/document-provider
...
Android: Implement DocumentProvider
2023-03-11 19:24:19 +01:00
08334015f9
Android: Remove SettingsActivityView parameters from Settings
...
No longer used for anything.
2023-03-11 18:49:43 +01:00
99600ef781
Android: Rework the "global" settings functions
...
getXGlobal() is now identical to getX(), and setXGlobal(int, X) is now
identical to setX(int, X) in the cases where setX(int, X) exists.
We can remove/rename them.
2023-03-11 18:49:43 +01:00
58fc347f8d
Android: Don't require Settings object for reading a setting
...
Made unnecessary by the previous commit.
2023-03-11 18:49:43 +01:00
68fd133057
Android: Remove support for the old config system
...
All settings that we care about from an Android perspective are now
supported by the new config system, so we can remove all the Android code
for the old config system. This should have no impact on users.
2023-03-11 17:51:59 +01:00
53e7090f55
Migrate game INI profile setting to new config system
2023-03-11 17:51:58 +01:00
069280ddc6
HW/VideoInterface: Refactor to class.
2023-03-11 12:50:35 +01:00
2102e64299
HW/VideoInterface: Savestate members individually.
2023-03-11 12:48:02 +01:00
62ff2f1030
Merge pull request #11385 from JosJuice/android-input-overhaul
...
Android input overhaul
2023-03-11 12:37:44 +01:00
84542d915d
HW/MemoryInterface: Refactor to class.
2023-03-11 00:57:16 +01:00
bf95d4012f
HW/EXI: Refactor ExpansionInterface to class.
2023-03-11 00:56:37 +01:00
e4df388128
Merge pull request #11638 from JosJuice/tas-input-motionplus
...
DolphinQt: Add MotionPlus support to TAS input
2023-03-10 16:54:35 -05:00
d31733ce64
HW/DVD: Rename DVDThreadManager to DVDThread.
2023-03-10 20:22:29 +01:00
25e883280a
HW/DVD: Merge DVDThread namespace into DVD.
2023-03-10 20:20:19 +01:00
4d34f86121
DolphinQt: Add MotionPlus support to TAS input
...
Will manually controlling both an accelerometer and a gyroscope at the
same time be reasonable to do? No idea. Was this easy to implement
thanks to the input override system? Yes.
Fixes https://bugs.dolphin-emu.org/issues/12443 .
2023-03-10 19:36:17 +01:00
d26a540253
HW/DVD: Rename DVDInterfaceManager to DVDInterface.
2023-03-10 18:37:46 +01:00
ee35103ed9
HW/DVD: Rename DVDInterface namespace to DVD.
2023-03-10 18:37:18 +01:00
dca8e9dc1e
HW/DVDThread: Refactor to class.
2023-03-10 18:12:59 +01:00
eb25c46a91
HW/DVDInterface: Refactor to class.
2023-03-10 18:12:59 +01:00
929222ffbd
HW/DSP: Refactor to class.
2023-03-09 22:35:29 +01:00
40ff9b25b7
Merge pull request #11633 from AdmiralCurtiss/ai-class
...
HW/AudioInterface: Refactor to class.
2023-03-09 11:59:47 -05:00
1023e5dd4f
Merge pull request #11441 from JosJuice/jit64-lea-fixup
...
Jit64: Fix the offsetAddedToAddress correction
2023-03-09 16:13:25 +01:00
9ed388fc8a
Merge pull request #11557 from AdmiralCurtiss/split-file-reader
...
DiscIO: Add support for CleanRip-style split ISOs.
2023-03-09 16:13:15 +01:00
8c7997d6ca
Merge pull request #11601 from Dentomologist/bluetooth_adapter_missing_message
...
Config: Restore Bluetooth adapter missing message in Controller Settings
2023-03-09 16:10:14 +01:00
234c5dd90e
Merge pull request #11622 from JosJuice/tas-input-nonblocking
...
DolphinQt: Rework TAS input threading
2023-03-09 16:08:30 +01:00
a6b1b2f9a5
Merge pull request #11631 from K0bin/pref-divider
...
Android: Only show divider in settings for headers
2023-03-08 23:56:39 -05:00
d638d2dcb7
HW/AudioInterface: Refactor to class.
2023-03-09 02:40:29 +01:00
d6a8e6caaf
ControllerInterface: Fix deadlock when Wii Remote disconnects
...
In UpdateInput, lock m_devices_population_mutex before m_devices_mutex
to be consistent with other ControllerInterface functions. Normally the
former lock isn't needed in UpdateInput, but when a Wii Remote
disconnects it calls RemoveDevice which results in the mutexes being
locked in the wrong order.
2023-03-08 17:22:27 -08:00
13ed46a488
Android: Implement DocumentProvider
...
This allows users to access the Dolphin user directory.
2023-03-08 23:09:49 +01:00
a1c2651fee
HW/EXI: Pass System to IEXIDevice.
2023-03-08 22:51:17 +01:00
7044cff011
Core/Boot: Pass around System.
2023-03-08 22:41:43 +01:00
912cd456fb
Core: Add System parameter to CPUThreadGuard.
2023-03-08 22:41:42 +01:00
1b47144312
Android: Center list view headers
2023-03-08 18:57:19 +01:00
edde253724
Android: Only show divider in settings for headers
2023-03-08 18:57:08 +01:00
c592c94395
Merge pull request #11630 from AdmiralCurtiss/globals-cpu
...
HW/CPU: Refactor to class, move to System.
2023-03-08 11:52:30 -05:00
0300b44d23
DolphinQt: Rework TAS input threading, part 2 (analog inputs)
2023-03-08 17:49:03 +01:00
11e4d46927
DolphinQt: Remove unneeded out parameters in TASInputWindow
...
IIRC we needed this before the input override system was added.
2023-03-08 17:49:03 +01:00
3eac1fc284
DolphinQt: Rework TAS input threading, part 1 (buttons)
...
This gets rid of a blocking operation, improving performance and fixing
https://bugs.dolphin-emu.org/issues/12893 .
This also makes us no longer directly access the state of certain UI
elements from the CPU thread, which probably wasn't thread-safe but
doesn't seem to have caused any observable issues so far.
2023-03-08 17:49:02 +01:00
3b364c5c16
HW/CPU: Refactor to class, move to System.
2023-03-08 12:23:37 +01:00
f1e4b6a141
Merge pull request #11494 from t895/orientation-jank
...
Android: Rewrite Wii system updates in Kotlin
2023-03-08 01:42:53 -05:00
0b9002ec2a
Merge pull request #11568 from SMarioMan/socket-broadcast
...
Network/Socket: Enable broadcast permissions in socket requests
2023-03-08 00:11:44 +01:00
75ce7a04ca
Android: Use coroutine for system updates
2023-03-07 15:45:41 -05:00
d66d8210bf
Android: Switch to indeterminate progress bar on system update cancel
2023-03-07 15:45:41 -05:00
917ca2273e
Android: Remove hardcoded strings from system update dialogs
2023-03-07 15:45:41 -05:00
410aaef56e
Android: Remove orientation lock on system update dialog
2023-03-07 15:45:41 -05:00
c0868f04a9
Android: Use Kotlin extensions for lifecycle components
2023-03-07 15:45:41 -05:00
5eeb0a540b
Android: Convert OnlineUpdateRegionSelectDialogFragment to Kotlin
2023-03-07 15:45:41 -05:00
0ac4fe763b
Android: Convert SystemMenuNotInstalledDialogFragment to Kotlin
2023-03-07 15:45:41 -05:00
c8907349be
Android: Convert SystemUpdateResultFragment to Kotlin
2023-03-07 15:45:40 -05:00
60cb886cd4
Android: Convert WiiUtils to Kotlin
2023-03-07 15:45:40 -05:00
2b17e0334a
Android: Convert SystemUpdateViewModel to Kotlin
2023-03-07 15:45:40 -05:00
6dfa555099
Android: Convert SystemUpdateProgressBarDialogFragment to Kotlin
2023-03-07 15:45:40 -05:00
16023ece6d
Merge pull request #11621 from deReeperJosh/skylandersfilefix
...
Skylander Portal: Clearing and Reloading fix
2023-03-07 15:24:46 -05:00
6d38dd9821
Qt/WatchWidget: Don't update if not paused.
2023-03-07 20:31:15 +01:00
75fb1a7edf
Android: Disable input device sensor input due to crash
2023-03-07 17:39:34 +01:00
1788a797e7
Android: Add "more settings" button to overlay control setting dialog
...
Some people might wonder where the ability to select an extension
and the Sideways Wii Remote went. This button will take them to the
general settings, which is where those settings now live.
At some point in the future, we should probably move everything to the
general settings. But this pull request is already big enough as it is!
2023-03-07 17:39:34 +01:00
6b5f82c12f
Android: Change how the overlay controller setting works, part 2
...
The previous commit wasn't enough for getting inputs to work for
controllers 2-4.
2023-03-07 17:39:34 +01:00
1b55d7c594
Android: Change how the overlay controller setting works
...
Up until now, there have been two settings on Android that stored the
selected Wii Remote extension: the normal one that's also used on PC,
and a SharedPreferences one that's used by the overlay controls to
determine what controls to show. It is possible for these two to end up
out of sync, and my input changes have made that more likely to happen.
To fix this, let's rework how the overlay controller setting works.
We don't want it to encode the currently selected Wii Remote extension.
However, we can't simply get rid of the setting, because for some Wii
games we need the ability to switch between a GameCube controller and a
Wii Remote. What this commit does is give the user the option to select
any of the 4 GameCube controllers and any of the 4 Wii Remotes. (Before,
controllers 2-4 weren't available in the overlay.) Could be useful for
things like the Psycho Mantis fight in Metal Gear Solid. I'm also
switching from SharedPreferences to Dolphin.ini while I'm at it.
2023-03-07 17:39:34 +01:00
4c326f2030
Android: Remove the in-emulation IR sensitivity options
...
This too can be set in the normal controller settings now.
2023-03-07 17:39:34 +01:00
ee2c7dc24b
Android: Remove the in-emulation motion control options
...
You can set this in the normal controller settings now.
2023-03-07 17:39:34 +01:00
9b9b6d97bc
Config: Simplify IsSettingSaveable's handling of Android section
...
The Android-specific controller mapping system is now gone,
so IsSettingSaveable can be greatly simplified.
2023-03-07 17:39:34 +01:00
32cb41007b
Android: Allow changing controller settings during emulation
2023-03-07 17:39:34 +01:00
c2779aef06
Android: Add the advanced input mapping dialog
...
It's missing a lot of features from the PC version for now, like
buttons for inserting functions and the ability to see what the
expression evaluates to. I mostly just wanted to get something in
place so you can set up rumble.
Co-authored-by: Charles Lombardo <clombardo169@gmail.com>
2023-03-07 17:39:30 +01:00
f389da2a33
HW/HSP: Refactor to class, move to System.
2023-03-07 02:11:39 +01:00
655cc7f75c
DiscIO: Add support for CleanRip-style split ISOs.
2023-03-05 19:23:55 +01:00
4acdbc0e84
Merge pull request #11625 from phire/eventhook_nodiscard
...
Fix KillRenderer config changed regression
2023-03-06 03:09:12 +13:00
901f12c935
HookableEvents: Add [[nodiscard]] to Register
2023-03-06 00:12:26 +13:00
b7db2510ef
Don't discard ConfigChanged callback handle
2023-03-06 00:12:26 +13:00
70cfb46f8e
Fix duplicated FPS
...
This is a small regression from KillRenderer, which caused duplicated
frames to be counted on the FPS counter when the "Skip Presenting
Duplicated Frames" option was disabled.
2023-03-05 23:31:12 +13:00
5bf9ad7d82
msvc: enable compiler checks added in vs 17.5
2023-03-04 14:18:18 -08:00
35bde3e7c8
msvc: bump required version to align with vs 17.5
2023-03-04 14:18:18 -08:00
2585ae9b2c
Skylander Portal: Clearing and Reloading fix
2023-03-04 20:13:54 +13:00
42943672bb
Android: Add selecting input profile per game
2023-03-03 22:28:25 +01:00
1eeded23df
Android: Add input profile management
...
Co-authored-by: Charles Lombardo <clombardo169@gmail.com>
2023-03-03 22:28:25 +01:00
7ef229d908
Android: Show warning when using old pre-defined controller INIs
...
Co-authored-by: Charles Lombardo <clombardo169@gmail.com>
2023-03-03 22:28:25 +01:00
8b78f73e80
Android: Add Default and Clear actions for controllers
2023-03-03 22:28:25 +01:00
ea3200d4ba
Android: Prevent showing mapping dialog with no device selected
2023-03-03 22:28:25 +01:00
a1cc19f443
Android: Add "Create mappings for other devices"
2023-03-03 22:28:24 +01:00
2b1dd52750
Android: Add input device selection
2023-03-03 22:28:24 +01:00
2113bf5e3a
Android: Implement enabling/disabling control groups
...
All this code for just a single checkbox... Ah well, it has to be done
2023-03-03 22:28:24 +01:00
a78dca5fb0
Android: Move Sideways Wii Remote setting one submenu up
...
A slight departure from DolphinQt, but I think it makes sense, because
it will make the important Sideways Wii Remote setting easier to find.
2023-03-03 22:28:24 +01:00
e7530a1cb9
Android: Split Wii Remote settings into submenus
...
Too much stuff on one screen otherwise. This split matches DolphinQt.
2023-03-03 22:28:24 +01:00
0dd8bbbbbb
Android: Add extension selection
2023-03-03 22:28:24 +01:00
1c26a85e35
Android: Add NumericSetting support
2023-03-03 22:28:24 +01:00
2c529b9db1
Android: Add new input mapping implementation
2023-03-03 22:28:24 +01:00
dd8976f18d
Android: Remove old input mapping implementation
...
This old code is of no use now that ButtonManager is gone.
2023-03-03 22:28:24 +01:00
304d898966
Android: Remove copyAsset's overwrite parameter
...
Because of the previous commit, this is no longer needed.
2023-03-03 22:28:24 +01:00
93657cce54
Android: Stop extracting pre-defined controller INIs
2023-03-03 22:28:24 +01:00
9a8a395560
GCPadEmu/WiimoteEmu: Reorder control groups
...
This way, Android (which will show groups in the order they're defined)
will show groups in a more logical order similar to DolphinQt.
The main thing that was annoying me was how early Rumble was for
Wii Remotes. Some of the other changes I'm making in this commit,
like the order of Shake/Tilt/Swing, are more arbitrary and were
made for consistency with DolphinQt. But there are also places
where I didn't go all the way with matching DolphinQt. Most notably,
DolphinQt puts sticks before buttons, but I don't see any reason
to do that for Android.
2023-03-03 22:28:24 +01:00
e0562abb7d
ControllerEmu: Add default mappings for Android
...
Unlike PCs, Android doesn't really have any input method (not counting
touch) that can reasonably be expected to exist on most devices.
Because of this, I don't think shipping with a default mapping for the
buttons and sticks of GameCube controllers and Wii Remotes makes sense.
I would however like to ship default mappings for a few things:
1. Mapping the Wii Remote's accelerometer and gyroscope to the device's
accelerometer and gyroscope. This functionality is useful mainly
for people who use the touchscreen, but can also be useful when
using a clip-on controller. The disadvantage of having this mapped
by default is that games disable pointer input if the accelerometer
reports that the Wii Remote is pointed at the ceiling.
2. Mapping GC keyboards for use with a physical keyboard, like on PC.
After all, there's no other way of mapping them that makes sense.
3. Mapping rumble to the device's vibrator.
Aside from the GC keyboards, this approach is effectively the same as
what we were doing before the input overhaul.
2023-03-03 22:28:23 +01:00
8e33458f48
ControllerInterface/Android: Implement rumble
2023-03-03 22:28:23 +01:00
065481d989
ControllerInterface/Android: Automatically suspend sensors
...
This is a battery-saving measure. Whether a sensor should be suspended
is determined in the same way as whether key events and motion events
should be handled by the OS rather than consumed by Dolphin.
2023-03-03 22:28:23 +01:00
36acb17700
ControllerInterface/Android: Implement sensor input for InputDevices
...
This functionality was added in Android 12 to let apps get motion data
for gamepads.
2023-03-03 22:28:23 +01:00
5e51b56d72
ControllerInterface/Android: Implement sensor input
2023-03-03 22:28:23 +01:00
104ea09892
ControllerInterface/Android: Implement hotplug
2023-03-03 22:28:23 +01:00
d6af294a23
ControllerInterface/Android: Return whether input was handled
...
When Android presents an input event to an app, it wants the app to
return true or false depending on whether the app handled the event or
not. If the event wasn't handled by the app, it will be passed on to
the system, which may decide to take an action depending on what kind
of input event it is. For instance, if a B button press is passed on to
the system, it will be turned into a Back press. But if an R1 press is
passed on to the system, nothing in particular happens.
It's important that we get this return value right in Dolphin. For
instance, the user generally wouldn't want a B button press to open
the EmulationActivity menu, so B button presses usually shouldn't be
passed on to the system - but volume button presses usually should be
passed on to the system, since it would be hard to adjust the volume
otherwise. What ButtonManager did was to pass on input events that are
for a button which the user has not mapped, which I think makes sense.
But exactly how to implement that is more complicated in the new input
backend than in ButtonManager, because now we have a separation between
the input backend and the code that keeps track of the user's mappings.
What I'm going with in this commit is to treat an input as mapped if
it has been polled recently. In part I chose this because it seemed
like a simple way of implementing it that wouldn't cause too many
layering violations, but it also has two useful side effects:
1. If a controller is not being polled (e.g. GameCube controllers in
Wii games that don't use them), its mappings will not be considered.
2. Once sensor input is implemented in the Android input backend,
we will be able to use this "polled recently" tracking to power down
the sensors at times when the game is using a Wii Remote reporting
mode that doesn't include motion data. (Assuming that the sensor
inputs only are mapped to Wii Remote motion controls, that is.)
2023-03-03 22:28:23 +01:00
ca508e4503
ControllerInterface/Android: Handle input events
...
Android doesn't let us poll inputs whenever we want. Instead, we
listen to input events (activities will have to forward them to the
input backend), and store the received values in atomic variables
in the Input classes. This is similar in concept to how ButtonManager
worked, but without its homegrown second input mapping system.
2023-03-03 22:28:23 +01:00
792cb62195
ControllerInterface/Android: Implement device population
2023-03-03 22:28:23 +01:00
68ebb5c33e
Android: Remove old rumble implementation
2023-03-03 22:28:23 +01:00
9e7a2ee0fb
Android: Remove old motion input implementation
2023-03-03 22:28:23 +01:00
0150f521f7
ControllerInterface/Android: Rip out ButtonManager
...
ButtonManager is very different from how a normal input backend works,
and is making it hard for us to improve controller support on Android.
The following commits will add a new input backend in its place.
2023-03-03 22:28:23 +01:00
95ce41ac56
Merge pull request #11399 from JosJuice/jit-one-stack
...
Jit: Don't use a second stack
2023-03-03 22:27:16 +01:00
bf079d6d3a
[[unlikely]] ASSERT
...
and other ASSERT usage changes
2023-03-02 19:54:15 -06:00
6361586a04
Merge pull request #11582 from Pokechu22/software-crash-on-startup
...
Software: Fix regressions from "Kill Renderer"
2023-03-02 15:13:00 -05:00
ab2f8d3475
Merge pull request #11607 from AdmiralCurtiss/sd-progress
...
Qt/WiiPane: Add progress window for SD card conversion.
2023-03-02 15:08:18 -05:00
6fcec80eb0
Merge pull request #11605 from JosJuice/android-mappings-button
...
Android: Add a button for accessing controller mappings
2023-03-02 15:06:47 -05:00
cbbc518bc4
Merge pull request #11612 from iwubcode/custom_texture_data
...
VideoCommon: move hirestexture data to reusable class called CustomTextureData
2023-03-02 15:05:46 -05:00
78e8669bac
Merge pull request #11614 from t895/kotlin-cheats
...
Android: Convert Cheats Activity to Kotlin
2023-03-02 15:04:19 -05:00
1b7969bc62
Merge pull request #11615 from t895/kotlin-riivolution
...
Android: Convert Riivolution Boot Activity to Kotlin
2023-03-02 15:03:43 -05:00
b9fd7e7bd4
Merge pull request #11616 from t895/kotlin-skylanders
...
Android: Convert Skylanders code to Kotlin
2023-03-02 15:03:18 -05:00
9cdc0aca9b
Software: Fix "Auto-Adjust Window Size"
...
This also needs to be handled on the software renderer path.
2023-03-02 11:08:49 -08:00
78428dd8db
Software: Fix crash on startup when using "Compile Shaders Before Starting"
...
When that setting is enabled, m_xfb_entry is initially not present (during the phase where a shader compilation progress bar would be shown). The main path checks for m_xfb_entry, but the software renderer fallback path didn't.
Fixes another aspect of https://bugs.dolphin-emu.org/issues/13172 .
2023-03-02 11:08:49 -08:00
4a2d3c83c7
Software: Implement GetSurfaceInfo()
...
Before, it used a fallback where it returned a default object, where the width and height were set to 0. Presenter::Initialize() used GetSurfaceInfo to set the backbuffer size, then used that size when initializing the on-screen UI (even for the software renderer, where the on-screen UI isn't currently present), which meant that ImGui got a window size of 0 and thus resulted in a failed assertion.
Although BindBackbuffer checks for size changes, it doesn't help because ImGui has already been initialized, and the size hasn't actually changed since initialization occured.
Fixes one aspect of https://bugs.dolphin-emu.org/issues/13172 .
2023-03-02 11:08:49 -08:00
96deb2d897
Android: Hide controller mappings button when controller type is None
...
Also removed the make_sure_continuous_scan_enabled message.
It doesn't make sense with the new UX.
2023-03-02 18:25:10 +01:00
2067c8eed1
Android: Convert ConvertActivity to Kotlin
2023-03-02 01:54:46 -05:00
fb432dd58a
Android: Convert ConvertFragment to Kotlin
2023-03-02 01:54:46 -05:00
078730c873
Avoid altering TCP sockets
...
Co-authored-by: sepalani <sepalani@hotmail.fr>
2023-03-01 20:52:43 -05:00
7efb672be6
Android: Convert SkylanderSlotAdapter to Kotlin
2023-03-01 17:32:19 -05:00
36f1315513
Android: Convert SkylanderSlot to Kotlin
2023-03-01 17:32:07 -05:00
bbc1951afb
Android: Convert SkylanderConfig to Kotlin
2023-03-01 17:32:07 -05:00
71e82d76b5
Android: Convert SkylanderPair to Kotlin
2023-03-01 17:13:42 -05:00
85b30f198b
Android: Convert Skylander to Kotlin
2023-03-01 17:13:01 -05:00
4045e213ba
Android: Convert RiivolutionAdapter to Kotlin
2023-03-01 14:39:18 -05:00
df21663d4c
Android: Convert RiivolutionBootActivity to Kotlin
2023-03-01 14:38:59 -05:00
79d0ff55d2
Android: Convert RiivolutionItem to Kotlin
2023-03-01 14:38:37 -05:00
e37503675a
Android: Convert RiivolutionViewHolder to Kotlin
2023-03-01 14:38:19 -05:00
ec7b811de3
Android: Convert RiivolutionPatches to Kotlin
2023-03-01 14:38:02 -05:00
3935449ca0
Android: Convert TwoPaneOnBackPressedCallback to Kotlin
2023-03-01 13:47:28 -05:00
6bc4ae7438
Android: Convert SettingDisabledWarningFragment to Kotlin
2023-03-01 13:41:55 -05:00
53d404c5a0
Android: Convert HeaderViewHolder to Kotlin
2023-03-01 13:41:02 -05:00
58b7b80902
Android: Convert GraphicsModsDisabledWarningFragment to Kotlin
2023-03-01 13:40:48 -05:00
a8da5902bb
Android: Convert CheatViewHolder to Kotlin
2023-03-01 13:40:28 -05:00
25fb3218d9
Android: Convert CheatsDisabledWarningFragment to Kotlin
2023-03-01 13:40:08 -05:00
fcfde12c52
Android: Convert CheatsAdapter to Kotlin
2023-03-01 13:39:49 -05:00
23d9def613
Android: Convert CheatsActivity to Kotlin
2023-03-01 13:39:23 -05:00
3bcc4a0a59
Android: Convert CheatListFragment to Kotlin
2023-03-01 13:39:07 -05:00
d8c1381155
Android: Convert CheatItemViewHolder to Kotlin
2023-03-01 13:38:27 -05:00
cacbac9152
Android: Convert CheatItem to Kotlin
2023-03-01 13:37:57 -05:00
5f5c95e7da
Android: Convert CheatDetailsFragment to Kotlin
2023-03-01 13:37:21 -05:00
b2dd510d0a
Android: Convert ActionViewHolder to Kotlin
2023-03-01 13:37:07 -05:00
fb177631ef
Android: Convert ReadOnlyCheat to Kotlin
2023-03-01 13:36:53 -05:00
59ecda7939
Android: Convert CheatsViewModel to Kotlin
2023-03-01 13:36:40 -05:00
1b61f2c223
Android: Convert Cheat to Kotlin
2023-03-01 13:35:43 -05:00
fbc617c917
Android: Convert AbstractCheat to Kotlin
2023-03-01 13:35:33 -05:00
37e8cd1789
Android: Convert GeckoCheat to Kotlin
2023-03-01 13:35:14 -05:00
9e090c6bab
Android: Convert GraphicsMod to Kotlin
2023-03-01 13:34:34 -05:00
5f6995fe6c
Android: Convert GraphicsModGroup to Kotlin
2023-03-01 13:34:09 -05:00
9cbe66bce4
Android: Convert PatchCheat to Kotlin
2023-03-01 13:33:16 -05:00
408b6cb50c
Android: Convert ARCheat to Kotlin
2023-03-01 13:32:42 -05:00
42cb3f3904
VideoCommon: remove HiResTexture DDS loading, update hirestexture logic to use custom texture data
2023-03-01 12:11:04 -06:00
3e35255983
VideoCommon: add class to load custom texture data
2023-03-01 11:58:37 -06:00
a4730a9388
Android: Initialize TaskViewModel earlier in User Data Activity
2023-03-01 08:28:44 -05:00
211be4698f
Merge pull request #11515 from t895/user-data-kotlin
...
Android: Rewrite User Data Activity in Kotlin
2023-02-28 23:47:00 -05:00
c904e068f0
Android: Use DialogFragments to direct UserData actions
2023-02-28 22:33:42 -05:00
8d1cf14565
Android: Convert ThreadUtil to Kotlin
2023-02-28 22:21:18 -05:00
e2bd7d1d95
Common/FatFsUtil: Close temp file before deleting it on conversion failure.
2023-02-28 20:31:56 +01:00
fe26b54efd
Qt/WiiPane: Add progress window for SD card conversion.
2023-02-28 20:31:55 +01:00
435d8c39ee
Common/FatFsUtil: Add callback for cancelling SD card conversion.
2023-02-28 20:31:51 +01:00
b6256a57ef
Jit: Move stack handling code to JitBase
...
Deduplication between Jit64 and JitArm64.
2023-02-28 20:30:06 +01:00
86c1f6e1e7
Jit: Don't use a second stack
...
This second stack leads to JNI problems on Android, because ART fetches
the address and size of the original stack using pthread functions
(see GetThreadStack in art/runtime/thread.cc), and (presumably) treats
stack addresses outside of the original stack as invalid. (What I don't
understand is why some JNI operations on the CPU thread work fine
despite this but others don't.)
Instead of creating a second stack, let's borrow the approach ART uses:
Use pthread functions to find out the stack's address and size, then
install guard pages at an appropriate location. This lets us get rid
of a workaround we had in the MsgAlert function.
Because we're no longer choosing the stack size ourselves, I've made some
tweaks to where the put the guard pages. Previously we had a stack of
2 MiB and a safe zone of 512 KiB. We now accept stacks as small as 512 KiB
(used on macOS) and use a safe zone of 256 KiB. I feel like this should
be fine, but haven't done much testing beyond "it seems to work".
By the way, on Windows it was already the case that we didn't create
a second stack... But there was a bug in the implementation!
The code for protecting the stack has to run on the CPU thread, since
it's the CPU thread's stack we want to protect, but it was actually
running on EmuThread. This commit fixes that, since now this bug
matters on other operating systems too.
2023-02-28 20:29:46 +01:00
0cdae98181
Jit: Fix GUARD_OFFSET calculation
...
Seems like this was broken all along. The safe zone is at the lower
addresses of the stack, not the higher addresses.
2023-02-28 19:11:35 +01:00
a0974c18cd
RiivolutionPatcher: Use capitalization of file that exists in the host file system if possible.
...
Fixes https://bugs.dolphin-emu.org/issues/13138
2023-02-28 00:56:34 +01:00
bdb19085c4
Common: Add utility function for case-insensitive string comparison.
2023-02-28 00:56:33 +01:00
b827b155a0
Android: Refactor handleMenuTag
...
It was a bit silly having four functions for effectively the same thing
in all of SettingsFragmentView, SettingsFragment, SettingsActivityView,
SettingsActivity, and SettingsActivityPresenter.
With this change, we split on the four MenuTag types in
SettingsActivityPresenter instead of in SettingsAdapter.
2023-02-27 21:52:17 +01:00
8acc39cc3f
Android: Add a button for accessing controller mappings
...
The settings GameCube Controller N and Wii Remote N (where N is a number)
have two purposes: You can select what controller type you want to use,
and also, when you select a controller type (even if you're selecting the
one that already is selected), the mapping settings open. This second part
is less discoverable than it ideally should be. I'm changing it so that
there now is a button for opening the mapping settings instead.
2023-02-27 20:10:24 +01:00
7586fc8134
Merge pull request #11608 from Dentomologist/fix_dynamicinputtextures_directory_error_logs
...
UICommon: Create Load/DynamicInputTextures directory on startup
2023-02-27 18:07:57 +01:00
251fb92b80
Merge pull request #11606 from JosJuice/control-group-save-enabled
...
InputCommon: Fix ControlGroup::SaveConfig with DefaultValue::Disabled
2023-02-27 12:02:25 +01:00
c730ee2de2
Merge pull request #11596 from AdmiralCurtiss/copyany
...
Common/FileUtil: Migrate CopyDir() to a more clear interface.
2023-02-27 12:02:00 +01:00
a11b9d585f
Common/FileUtil: Remove obsolete CopyDir() function.
2023-02-26 23:17:10 +01:00
4f462b4ef6
Migrate destructive calls of File::CopyDir() to File::Move().
2023-02-26 23:17:10 +01:00
5367bf394c
Common/FileUtil: Add Move() function.
2023-02-26 23:17:09 +01:00
e62162e486
UICommon: Create Load/DynamicInputTextures directory on startup
...
Fix console error spam on Dolphin and game startup if the directory
doesn't exist.
2023-02-26 13:10:15 -08:00
02f7c0213f
Qt/GameList: Also filter by filename when searching.
2023-02-26 19:13:45 +01:00
9b3816c993
InputCommon: Fix ControlGroup::SaveConfig with DefaultValue::Disabled
...
I also changed LoadConfig, but that change doesn't affect correctness,
it's only so it looks neat by matching SaveConfig.
This bug was added in 18a4afb053
2023-02-26 17:45:09 +01:00
26adf78e45
Merge pull request #11602 from JosJuice/cpu-guard-expression
...
PowerPC: Rework CPUThreadGuard handling in Expression.cpp
2023-02-26 11:55:47 +01:00
28956cc6c2
workaround msvc optimizer bug
2023-02-25 23:26:27 -08:00
ad6e95afb4
D3D: Restore workaround for erroneous NaN optimization
...
The HLSL compiler incorrectly decides isnan can't be true, so this
workaround was originally added in 52c82733
2023-02-25 16:27:30 -08:00
19e8569634
Merge pull request #11594 from t895/autofit-grid
...
Android: Responsive autofit grid
2023-02-25 17:30:40 +01:00
a049a0d4bc
Android: Remove unused refreshScreenshotAtPosition interface method
2023-02-25 11:17:16 -05:00
5957d85178
Android: Create AutofitGridLayoutManager
...
Extends GridLayoutManager to make span changes much more responsive.
2023-02-25 11:17:16 -05:00
ae5311d6e6
PowerPC: Rework CPUThreadGuard handling in Expression.cpp
...
See https://github.com/dolphin-emu/dolphin/pull/11554#discussion_r1113949572 .
2023-02-25 16:13:34 +01:00
d18735e82e
Qt/WiimoteControllersWidget: Add bluetooth unavailable message
2023-02-24 14:30:43 -08:00
1ed0e014cd
Migrate non-destructive calls of File::CopyDir() to File::Copy().
2023-02-24 20:32:19 +01:00
884917a6d5
Common/FileUtil: Use non-throwing overload of is_directory() in CreateDir() and CreateFullPath().
2023-02-24 20:32:19 +01:00
e479f92418
Common/FileUtil: Add CreateDirs() function as a wrapper around std::filesystem::create_directories().
2023-02-24 20:32:18 +01:00
616d57e7fc
Common/FileUtil: Add Copy() function as a wrapper around std::filesystem::copy().
2023-02-24 20:32:18 +01:00
5d571b068f
VideoBackends: rework d3d11 to specify samplers/bound textures using a bitset with a constant size, instead of hardcoding each individual enumeration value
2023-02-24 11:32:48 -06:00
2c2fb869a2
use std-provided randomness for JitArm64 unittests
...
decreases runtime significantly and lessens dependency on mbedtls
2023-02-22 12:55:12 -08:00
e52aa52a66
Common/FileUtil: Rename Copy() to CopyRegularFile().
...
This is to clarify that it can only copy files, not folders.
2023-02-22 11:43:58 +01:00
3c4a21315d
Merge pull request #11592 from Pokechu22/fix-delete-ticket
...
IOS/ES: Fix crash when deleting tickets
2023-02-21 10:53:37 +01:00
f2ac3aec94
IOS/ES: Fix crash when deleting tickets
...
This broke formatting the system memory; see https://bugs.dolphin-emu.org/issues/13176 . After calling ticket.DeleteTicket(), ticket.m_bytes was 0-length, but calling ticket.IsV1Ticket() still attempted to read from m_bytes.
This was introduced in 2fd9852ca8929fba08e7
2023-02-20 18:33:34 -08:00
2aedd8f568
Merge pull request #11590 from t895/unused-layout-class
...
Android: Remove SettingsFrameLayout
2023-02-20 23:33:07 +01:00
0fb9105700
Merge pull request #11408 from t895/coil
...
Android: Rewrite image loading with Kotlin and Coil
2023-02-20 20:51:36 +01:00
0638e08989
Android: Remove SettingsFrameLayout
2023-02-20 14:11:08 -05:00
6f21ce7d95
Merge pull request #11555 from CookiePLMonster/wil-todos
...
Address WIL todos in UICommon.cpp
2023-02-20 10:14:49 -05:00
28faca63a6
Android: Replace Glide with Coil image loading
2023-02-20 00:38:24 -05:00
4e6c89fbfd
Qt/CodeViewWidget: Don't read PC in Update() if we don't have a CPU thread guard.
2023-02-20 03:10:12 +01:00
ef1520c2c6
Qt/CodeViewWidget: Don't try to pause emulator in Update() if we happen to be on a breakpoint.
2023-02-20 02:56:04 +01:00
4e6e510003
Debugger: Add string comparison to conditional breakpoints.
2023-02-20 01:40:33 +01:00
f2be35c7cd
VideoCommon: Reword the unknown opcode error message
...
When faced with this error, users often don't try disabling dual core,
even though the error message suggests it. Perhaps the message is just
too long and lists too many things?
To try to improve the situation, I'm rewording the message and making it
say different things depending on what settings you are using.
2023-02-19 16:35:28 +01:00
78c53bfec8
Jit64: Fix the offsetAddedToAddress correction
...
The LEA that the signal handler is trying to undo the effects of is a
32-bit instruction, and the value in the register prior to the LEA is
also 32-bit, so the signal handler should use a 32-bit write.
(Actually, in the end this doesn't really matter, because the first
instruction that reads this value after backpatching is also a 32-bit
instruction...)
2023-02-18 21:14:31 +01:00
e65167f9cd
Merge pull request #11521 from t895/adjust-grid-options
...
Android: Simplify the grid options dialog fragment
2023-02-18 15:42:46 +01:00
8db35e6d04
Merge pull request #11578 from Pokechu22/memory-leaks-feb-2023
...
Fix various memory leaks
2023-02-18 13:56:34 +01:00
c94aacc968
AudioPane: Fix inconsistent initial state of audio stretching labels
...
This resulted in the labels being solid black even when audio stretching is disabled the first time the settings are opened, but then properly being greyed out after changing a setting (even the audio backend or DSP emulation engine, not just whether audio stretching is enabled).
2023-02-17 18:51:41 -08:00
f1f3fd5d9d
InputCommon: Fix memory leak in ExpressionParser
...
We allocate in MakeSuppressor via `return unique_ptr(std::make_unique<...>(...).release(), InvokingDeleter{}`, so it wasn't properly getting freed.
2023-02-17 18:29:36 -08:00
b6d476241a
CodeViewWidget: Fix memory leak
...
Per https://doc.qt.io/qt-6/qabstractitemview.html#setItemDelegateForColumn setItemDelegateForColumn does not take ownership of the parameter, so it was not being deleted. Specifying a parent to QObject (via QStyledItemDelegate's constructor) will allow it to automatically be deleted, per https://doc.qt.io/qt-6/objecttrees.html . The other instance of a QItemDelegate in IOWindow.cpp already used this.
2023-02-17 18:29:32 -08:00
1c5e223532
MemoryViewWidget: Fix memory leaks
...
bp_item/row_item/item were never deleted, and the normal Qt ownership system wasn't applying to them because they were being cloned.
2023-02-17 18:17:01 -08:00
74abf48234
Merge pull request #11576 from yannhodiesne/convert-prevent-file-deletion
...
Check the input and destination paths before converting a game file onto itself
2023-02-17 18:49:15 +01:00
b381df700c
Merge pull request #11577 from JosJuice/android-armeabi-v7a
...
Android: Fix armeabi-v7a build
2023-02-17 17:57:38 +01:00
90b676d368
Android: Fix armeabi-v7a build
...
This very much isn't a build configuration that we're going to ship,
but I want to be able to tell people that they can build it on their
own if they really want to see how terribly it performs :)
Just like before, you'll need to edit two lines in app/build.gradle to
define ENABLE_GENERIC=ON and actually enable armeabi-v7a if you want an
armeabi-v7a build. This commit just fixes some compilations errors that
crop up if you do so.
2023-02-17 16:58:24 +01:00
49e897422f
Use a success count instead of files count
2023-02-17 15:49:31 +01:00
cb42a03299
Check the input and destination paths before converting a game file onto itself
...
Before these changes you could tell Dolphin to convert a game file into the same format it is already in, leading to the FileDialog using the input path as the default destination path
An unsuspecting user could then click Save and Dolphin would try to convert the input file by writing the destination file on top of it... leading to an I/O error and the input file being entirely removed
2023-02-17 14:26:50 +01:00
28331c5905
Merge pull request #11574 from K0bin/val-fix
...
VideoBackends:Vulkan: Fix printing validation errors
2023-02-17 14:52:45 +13:00
0c48324c75
Jit64: Use 5 byte jump in mtmsr for the CP interrupt check.
...
WriteExternalExceptionExit() can write more than the maximum offset of the small jump.
2023-02-16 19:26:19 +01:00
2695666e6d
VideoBackends:Vulkan: Fix printing validation errors
2023-02-16 17:53:15 +01:00
6038a6e2db
Merge pull request #11569 from Hibyehello/patch-1
...
VideoBackend: Make Metal Default on MacOS
2023-02-16 21:08:35 +13:00
74a14c7d1f
ControllerInterface: Fix uninitialized variables in DualShockUDPClient
...
Strangely, this case did not trigger a C26495 warning in Visual Studio's analyzer; instead, I spotted this when using Valgrind.
2023-02-15 19:23:47 -08:00
67381cdb8b
VideoCommon: Remove unused ShutdownImGui function declaration
...
This was moved to the ~OnScreenUI() destructor in 0d4537d60f
2023-02-15 19:20:59 -08:00
8802f96b7e
Fix uninitialized variable warnings (C26495)
2023-02-15 19:18:39 -08:00
8d16aed581
Android: Convert UserDataActivity to Kotlin
2023-02-15 18:50:33 -05:00
cd38ed76e2
Keep Vulkan precedence over OpenGL
2023-02-15 12:22:56 -06:00
546a016dc8
VideoBackend: Make Metal Default on MacOS
2023-02-15 12:05:54 -06:00
301e97f7f7
Remove WinAPI-specific type from socket request
2023-02-15 09:29:21 -05:00
a45f6d9438
Enable broadcast permissions in socket requests
2023-02-15 07:59:38 -05:00
c36994a90d
Add unit test for File::CreateFullPath().
2023-02-15 02:56:10 +01:00
0758e00cfe
Common/FileUtil: Revert behavior of CreateFullPath().
...
This was accidentally changed in 7e6436db34
2023-02-15 02:21:50 +01:00
661b74f4a3
Merge pull request #11564 from JosJuice/jitarm64-cmp-order
...
JitArm64: Fix special cases of cmp
2023-02-14 20:19:07 +01:00
e1d3237dbd
Merge pull request #11342 from TellowKrinkle/GLLayerMac
...
VideoCommon: Fix stereoscopic 3D on OpenGL < 4.3 (macOS)
2023-02-14 20:17:22 +01:00
0049a76775
JitArm64: Fix special cases of cmp
...
This fixes a regression from 592ba31
2023-02-14 19:16:00 +01:00
22ed084209
Merge pull request #11563 from JosJuice/host-lock-cpu-fixups
...
Follow-up fixes for "Properly lock CPU before accessing emulated memory"
2023-02-14 19:04:21 +01:00
5b6784432c
Follow-up fixes for "Properly lock CPU before accessing emulated memory"
2023-02-14 18:44:16 +01:00
f25a0b43b6
VideoCommon: Fix stereoscopic 3D on OpenGL < 4.3 (macOS)
2023-02-14 18:25:33 +01:00
4f6ce51d69
VideoCommon: Clear blend configuration if color/alpha update disabled
...
This works around an Intel driver bug where, on D3D12 only, dual-source blending behaves incorrectly if the second source is unused on. This bug is visible in skyboxes in Super Mario Sunshine, which first draw clouds and sun flare in greyscale and then draw the sky afterwards with a source factor of 1 and a dest factor of 1-src_color (this results in the clouds being tinted blue). This process is done on an RGB888 framebuffer, so alpha update is disabled. (Color update is enabled; note that if you look at this in Dolphin's fifo analyzer, it won't be enabled because they use the BP mask functionality to only change the blending functions and not alpha/color update, for whatever reason.)
2023-02-13 18:22:41 -08:00
5f929d00eb
Merge pull request #11560 from phire/EventHook_construct_on_first_use
...
HookableEvent: Switch to construct on first use
2023-02-14 01:01:03 +01:00
34a459bed7
Merge pull request #11445 from JosJuice/jit64-wraparound-backpatch
...
Jit64: Properly handle backpatching overflowed address calculations
2023-02-14 01:00:13 +01:00
3458c58c7d
Merge pull request #11503 from JosJuice/ppcanalyst-read-cr
...
PPCAnalyst: Actually check if instructions want CR
2023-02-14 00:55:24 +01:00
e2d7b6d079
Merge pull request #11559 from Pokechu22/cache-fix-plru-updates
...
PPCCache: Update PLRU on any cache access
2023-02-14 00:50:54 +01:00
8f91cb62e6
Merge pull request #11426 from shuffle2/stdfs
...
fileutil: use std::filesystem
2023-02-14 00:50:34 +01:00
e1dbea3658
JIT: Fix calls to HLE::Execute.
...
This got broken in 7cecb28bdf
2023-02-13 11:47:47 +01:00
05181f6b88
HookableEvent: Switch to construct on first use
...
A registration might happen during static initialization, which opens
us up to issues with ordering of static initialization.
2023-02-13 18:48:43 +13:00
1fc5d37fd2
Merge pull request #11558 from Pokechu22/vertex-loader-size-assertion-details
...
VertexLoader: Add more info to m_vertex_size == m_src_ofs assertion
2023-02-13 17:34:04 +13:00
cc411c4e41
VertexLoader: Add more info to m_vertex_size == m_src_ofs assertion
2023-02-12 20:10:38 -08:00
14c4f4e7f6
PPCCache: Update PLRU on any cache access
...
The previous code only updated the PLRU on cache misses, which made it so that the least recently inserted cache block was evicted, instead of the least recently used/hit one.
This regressed in 9d39647f9e#11183 , but it was fine in e97d380437
2023-02-12 19:59:19 -08:00
a4729a026f
Merge pull request #11554 from JosJuice/host-lock-cpu
...
DolphinQt: Properly lock CPU before accessing emulated memory
2023-02-13 16:08:36 +13:00
f37113204f
Merge pull request #11550 from iwubcode/set_common_samplers_count
...
VideoCommon: add constant value for maximum number of pixel samplers
2023-02-13 16:05:51 +13:00
2c24d07837
Merge pull request #11538 from t895/disc-speed-stuff
...
Rename "Speed up Disc Transfer Rate" to "Emulate Disc Speed"
2023-02-13 15:46:56 +13:00
0ed64b080f
Rename Fast Disc Speed to Emulate Disc Speed and invert option
2023-02-12 16:20:38 -05:00
d0941342d2
Android: Expose Emulate Disc Speed
2023-02-12 16:20:38 -05:00
300d63b492
DiscIO/FileBlob: Make m_size unsigned.
2023-02-12 20:51:08 +01:00
611e721a4d
Jit64: Properly handle backpatching overflowed address calculations
...
Previously we would only backpatch overflowed address calculations
if the overflow was 0x1000 or less. Now we can handle the full 2 GiB
of overflow in both directions.
I'm also making equivalent changes to JitArm64's code. This isn't because
it needs it – JitArm64 address calculations should never overflow – but
because I wanted to get rid of the 0x100001000 inherited from Jit64 that
makes even less sense for JitArm64 than for Jit64.
2023-02-12 20:48:27 +01:00
c3dee1f11c
Merge pull request #11499 from iwubcode/graphics-mod-pass-base-path
...
VideoCommon: allow graphics mods to have access to the file path where the config exists to load additional files
2023-02-12 19:04:59 +01:00
9f3d3e2b9c
Address WIL todos in UICommon.cpp
2023-02-12 15:05:54 +01:00
6f0266e8de
DolphinQt: Only update call stack if paused
...
This avoids a pseudo infinite loop where CodeWidget::UpdateCallstack
would lock the CPU in order to read the call stack, causing the CPU to
call Host_UpdateDisasmDialog because it's transitioning from running to
pausing, causing Host::UpdateDisasmDialog to be emitted, causing
CodeWidget::Update to be called, once again causing
CodeWidget::UpdateCallstack to be called, repeating the cycle.
Dolphin didn't go completely unresponsive during this, because
Host_UpdateDisasmDialog schedules the emitting of Host::UpdateDisasmDialog
to happen on another thread without blocking, but it was stopping certain
operations like exiting emulation from working.
2023-02-12 12:50:28 +01:00
7cecb28bdf
DolphinQt: Properly lock CPU before accessing emulated memory
...
This fixes a problem I was having where using frame advance with the
debugger open would frequently cause panic alerts about invalid addresses
due to the CPU thread changing MSR.DR while the host thread was trying
to access memory.
To aid in tracking down all the places where we weren't properly locking
the CPU, I've created a new type (in Core.h) that you have to pass as a
reference or pointer to functions that require running as the CPU thread.
2023-02-12 11:27:50 +01:00
508c79a66f
Rename VI Skip to VBI Skip
...
VI Skip was very hard to explain on the blog, so this small changes
clarifies what VI Skip is to resolve that issue.
2023-02-11 20:28:41 -08:00
20dc4401c5
VideoCommon: pass a graphics mod base path to the graphics mod, so it can lookup other relative files if necessary
2023-02-11 00:21:40 -06:00
2f6e7d497d
ENetUtil: Add check for valid socket in SendPacket().
2023-02-10 19:32:40 +01:00
9b5c52ad8d
Merge pull request #11541 from Pokechu22/dsptool-no-redefine-label
...
DSPTool: Fix missing error when redefining labels
2023-02-10 11:02:36 +01:00
3c2933cad2
Merge pull request #11549 from Pokechu22/texturecachebase-bitset-include
...
TextureCacheBase: Remove unused bitset include
2023-02-10 10:55:07 +01:00
258151fe5a
Merge pull request #11523 from degasus/OGL_KHR_subgroup
...
VideoBackend/OGL: Prefer KHR_shader_subgroup over NV_shader_thread.
2023-02-10 04:47:20 -05:00
af313f8419
VideoCommon: add constant value to set the allowed maximum number of pixel samplers
2023-02-10 00:46:11 -06:00
3024ca2146
Suppress memcpy writing to an object with no trivial copy-assignment warnings
...
We need to copy padding in most of these cases, and the objects are trivially copyable; however, BitField prevents trivial copy-assignment.
2023-02-09 16:23:49 -08:00
ac7a17579e
BreakPoints: Fix shadowing warning
2023-02-09 16:23:02 -08:00
3bd655463d
MemoryViewWidget: Fix warning: enumeration value ‘Null’ not handled in switch [-Wswitch]
2023-02-09 16:23:02 -08:00
5c8d8383e2
CodeWidget: Fix shadowing warning
2023-02-09 16:23:02 -08:00
470115fd4f
TextureDecoder: Fix warning: array subscript has type ‘char’ [-Wchar-subscripts]
2023-02-09 16:23:02 -08:00
debed35c10
State: Fix shadowing warnings
2023-02-09 16:23:02 -08:00
9559c45cae
CommandProcessor: Fix shadowing warnings
2023-02-09 16:23:02 -08:00
f1b1f5c013
IOS: Fix shadowing warnings
2023-02-09 16:23:02 -08:00
8d71f542cb
Boot: Fix shadowing warning
2023-02-09 16:23:02 -08:00
39c5d55f03
VertexLoaderBase: Fix shadowing warning
2023-02-09 16:23:02 -08:00
95bee485c9
GraphicsModManager: Fix shadowing warning
2023-02-09 16:23:02 -08:00
7fafb00561
InputCommon/XInput2: Fix shadowing warning
2023-02-09 16:23:02 -08:00
edcc4a6578
AudioInterface: Fix warning: declaration of ‘state’ shadows a previous local
2023-02-09 16:23:02 -08:00
8ad7d58303
DSP: Fix warning: declaration of ‘state’ shadows a previous local
2023-02-09 16:23:02 -08:00
24df509447
DVDInterface: Fix warning: declaration of ‘state’ shadows a previous local
2023-02-09 16:23:02 -08:00
9c52c600c4
EXI_DeviceEthernet: Fix warning: operation on ‘current_rwp’ may be undefined [-Wsequence-point]
2023-02-09 16:23:01 -08:00
1465620721
GCMemcardDirectory: Fix variable shadowing warning
2023-02-09 16:23:01 -08:00
c555a4f0c6
SerialInterface: Fix warning: declaration of ‘state’ shadows a previous local
2023-02-09 16:23:01 -08:00
72b4675c8f
VideoInterface: Fix warning: declaration of ‘state’ shadows a previous local
2023-02-09 16:23:01 -08:00
49a84cbc4c
Resolve various "no previous declaration" warnings
2023-02-09 16:23:01 -08:00
2288ba28ae
Software/Tev: Fix member shadowing warnings
2023-02-09 16:23:01 -08:00
8b98dd9be3
Move s_using_custom_client to DiscordPresence.cpp
...
Otherwise, files that include the header get warning: ‘Discord::s_using_custom_client’ defined but not used.
2023-02-09 16:23:01 -08:00
b316ce6fdd
Fix warning: implicit capture of ‘this’ via ‘[=]’ is deprecated in C++20
2023-02-09 16:23:01 -08:00
af5013b60f
Suppress -Winvalid-offsetof for PowerPC::PowerPCState
...
This code doesn't need to be portable (since the goal is to have a smaller offset for x64 codegen), so if it's not supported there are other problems. Similar code exists in e.g. DSP.cpp.
2023-02-09 16:23:01 -08:00
5283a85205
TextureCacheBase: Remove unused bitset include
...
It was used for valid_bind_points, which was removed in 88bd10cd30606c18210d
2023-02-09 16:04:48 -08:00
a88e5ef390
Merge pull request #11498 from iwubcode/save_pipeline_config
...
VideoCommon: store the configuration used to create the AbstractPipeline
2023-02-09 18:38:49 -05:00
a38e365931
Merge pull request #11547 from JosJuice/fix-gles
...
OGL: Fix GLES crashing on initialization
2023-02-09 18:16:48 +01:00
6dfd582de6
OGL: Fix GLES crashing on initialization
...
Fixes a regression from PR 11522 ("Kill Renderer").
2023-02-09 18:09:03 +01:00
17d7b75a9b
Merge pull request #11544 from jmallach/spng
...
Allow building against system libspng
2023-02-09 14:47:58 +01:00
4b2aa948e6
VideoBackend/OGL: Prefer KHR_subgroup over NV_shader_thread.
...
While the NV extension is totally fine, the KHR extension should be able to support more hardware.
For NVIDIA, the hardware either supports both or neither, it just needs a driver from the last two years.
For AMD, the drivers from late 2022-12 seems to bring support for the KHR extension.
For Intel, the KHR is also supported for some years.
2023-02-09 13:27:02 +01:00
d0c6b6c9ed
VideoCommon: store the configuration used to create the AbstractPipeline on the pipeline itself, so that it's easy to duplicate pipelines with slightly altered configuration
2023-02-09 02:13:53 -06:00
aaad0cd39f
Merge pull request #11539 from phire/improve_workqueuethread
...
Various WorkQueueThread improvements
2023-02-09 20:00:04 +13:00
ccf92a3e56
Merge pull request #11522 from phire/KillRendererWithFire
...
Kill Renderer (with phire)
2023-02-09 19:59:16 +13:00
5c1b3ac61d
Hook up Presenter's ConfigChanged function
...
Fixes issue with post-processing not working
2023-02-09 18:36:20 +13:00
9c1fe59cc9
Insert a more solid abstraction between Qt and Imgui
2023-02-09 18:36:20 +13:00
b2a31103b4
Presenter: Handle blanked frames correctly
2023-02-09 18:36:20 +13:00
83b7b01265
Fix XFB duplicate detection
...
Frame duplicate detection was inverted. Huge problem for 60fps games
where it would see all frames as "duplicates" and nothing would ever be
presented.
2023-02-09 18:36:20 +13:00
d3ddd96cee
Make sure m_prev_efb_format is initilized
2023-02-09 18:36:20 +13:00
59a4b026f6
Better documentation for HookableEvent.
2023-02-09 18:36:20 +13:00
8c8bd0e7ac
Rename to HookableEvent. Because naming conflict
2023-02-09 18:36:20 +13:00
60f2b5af7b
Apply suggestions from code review
...
Co-authored-by: Mai <mathew1800@gmail.com>
Co-authored-by: BhaaL <bhaalsen@gmail.com>
Co-authored-by: iwubcode <iwubcode@users.noreply.github.com>
2023-02-09 18:36:20 +13:00
e0a1631659
Add comment about "end of frame"
2023-02-09 18:36:20 +13:00
43b6a49012
Apply suggestions from code review
...
Co-authored-by: Mai <mathew1800@gmail.com>
2023-02-09 18:36:20 +13:00
05fad53fa0
Update STATE_VERSION
...
Co-authored-by: BhaaL <bhaalsen@gmail.com>
2023-02-09 18:36:20 +13:00
e2de281897
Make sure pixel shaders pick up Initial EFB Scale
2023-02-09 18:36:20 +13:00
cf9a6f8477
Lint fixes
2023-02-09 18:36:20 +13:00
f7ad825736
fix fbdev
2023-02-09 18:36:20 +13:00
628af9d564
Fix builds with FFMPEG disabled
2023-02-09 18:36:20 +13:00
4422af1272
Cleanup headers
2023-02-09 18:36:20 +13:00
5803786beb
Move UseVertexDepthRange() out of Renderer
...
There wasn't really a good place for it, but this will do
2023-02-09 18:36:20 +13:00
2cfc02a116
Move m_prev_efb_format into FramebufferManager
2023-02-09 18:36:20 +13:00
9b5397abdb
Move WidescreenHeuristic to it's own class
...
It's about the only thing left in renderer
2023-02-09 18:36:20 +13:00
31cfe8250d
Lint fixes
2023-02-09 18:36:20 +13:00
11de923dcb
Move xfb tracking and IR scaling out of RenderBase
2023-02-09 18:36:20 +13:00
e009002411
Refactor ClearRegion
...
And fix bug where opengl was getting the wrong coordinates
2023-02-09 18:36:20 +13:00
e6583f8bec
Android: Convert image loading code to Kotlin
2023-02-08 19:34:27 -05:00
4d164fcb77
Allow building against system libspng
2023-02-06 13:30:46 +01:00
e0b3dd0dcf
Remove Imaginators Skylanders from list
...
Add Vicarious Visions variant
2023-02-06 15:16:06 +13:00
ca0b61be91
Merge pull request #11459 from OatmealDome/steam-user-dir
...
CommonPaths: Add Steam-specific user directory and clean up
2023-02-05 23:52:41 +01:00
2ff155f742
Optimise cond_var predicate order
...
m_items.empty() is by far the most likely reason for a notification.
2023-02-05 17:20:00 +13:00
271ffde71d
Prevent WaitForCompletion shutdown deadlock.
...
Adjust shutdown order to prevent potential deadlocks
when one thread calls Shutdown, and another calls WaitForCompletion.
2023-02-05 17:17:16 +13:00
9c012b09b3
Address review feedback
2023-02-05 16:52:53 +13:00
a244cb868b
DSPTool: Fix missing error when redefining labels
...
The logging was broken in 958cbf38a4693a29f8ce
2023-02-04 17:31:06 -08:00
7c4fcc30a3
WorkQueueThread: provide name and function at same time
2023-02-04 15:56:27 +13:00
6594532f10
WorkQueueThread: rework Cancel/Shutdown workflow
...
- Cancel doesn't shut down anymore.
Allowing it to be used multiple times thoughout the life of
the WorkQueue
- Remove Clear, so we only have Cancel semantics
- Add IsCancelling so work items can abort early if cancelling
- Replace m_cancelled and m_thread.joinable() guars with m_shutdown.
- Rename Flush to WaitForCompletion (As it's ambiguous if a function
called flush should be blocking or not)
- Add documentation
2023-02-04 14:58:12 +13:00
acdb0c5be1
WorkQueueThread: Implement thread name
...
Otherwise we will end up with a dozen threads named "WorkQueueThread"
2023-02-04 14:58:12 +13:00
94a0c50bf8
WorkQueueThread: Rework without Flags/Events
2023-02-04 14:31:16 +13:00
9affbfe683
WorkQueueThread: Implement proper Flush
...
and rename the existing Flush to FlushOne.
2023-02-04 14:31:16 +13:00
9badcc6eb8
WorkQueueThread: Add Push
2023-02-04 14:31:16 +13:00
512273a507
WorkQueueThread: Add flush capability
2023-02-04 14:31:16 +13:00
4a97dc7c81
Let VI Skip work if variance > fallback
2023-02-02 20:59:17 -05:00
87d5d39dfe
Set VI Skip Activation to Half The Audio Buffer
2023-02-02 20:55:13 -05:00
680db55239
Android: Add Skylanders Portal
...
Co-Authored-By: Charles Lombardo <clombardo169@gmail.com>
2023-02-02 21:16:14 +13:00
c92de420ef
lint: update to clang-format-13
2023-02-02 04:56:08 +01:00
69b178e95f
Merge pull request #11157 from h3xx/use-gnuinstalldirs
...
Use GNUInstallDirs for installation paths
2023-02-01 19:35:46 +01:00
e55a0f4fff
Merge pull request #11495 from OatmealDome/android-cmake
...
Android: Don't enforce a particular CMake version
2023-02-01 19:35:09 +01:00
2ec7577788
Android: Fix settings being editable when marked otherwise
2023-02-01 00:51:48 -05:00
234de8af09
UICommon: Don't check the registry key or use the old user directory path on Windows builds for Steam
2023-01-31 17:57:09 -05:00
7240290382
CommonPaths: Add Steam-specific user directory
2023-01-31 17:57:09 -05:00
59a44bea50
CommonPaths: Split platform-specific definitions for user directories into two blocks
2023-01-31 17:57:09 -05:00
af33d4f13f
CommonPaths: Split PORTABLE_USER_DIR into "portable" and "embedded" to accomodate macOS
2023-01-31 17:57:09 -05:00
7f962a4146
UICommon: Use NORMAL_USER_DIR for Windows
2023-01-31 17:57:09 -05:00
5e3d77adae
CommonPaths: Rename DOLPHIN_DATA_DIR to NORMAL_USER_DIR
2023-01-31 17:57:08 -05:00
846eef2a05
CommonPaths: Rename USERDATA_DIR to PORTABLE_USER_DIR
2023-01-31 17:57:08 -05:00
2a2ee5d543
Merge pull request #11434 from momocaoo/graphics-mod-folder-button
...
DolphinQt: Add button to open graphics mod folder on settings
2023-01-31 14:35:21 +01:00
e98ab0784d
Merge pull request #11501 from iwubcode/abstract_texture_load_specify_layer
...
VideoBackends: add a way to load data into a specific level AND layer
2023-02-01 00:03:59 +13:00
c6b851c2b6
Merge pull request #11506 from phire/cmake_fixes
...
CMake/MSVC fixes
2023-01-31 23:53:31 +13:00
12431a83ba
Merge pull request #11435 from techydude0713/wc24-utc-fix
...
NetKDTime: Use UTC based timestamp instead of localtime.
2023-01-31 23:40:15 +13:00
6bb2e4d706
CMake/MSVC: Fix warnings about conflicting /Zi and /Z7
2023-01-31 23:21:07 +13:00
854a73dee0
CMake/MSVC: Fix PCH disabled build
2023-01-31 23:21:07 +13:00
1956ce151f
Cmake/MSVC: Fix Qt6 discover for IDEs other than Visual Studio
...
CMakeSettings.json is a Visual Studio only extention to cmake that isn't
supported anywhere else. Not even Visual Studio Code.
So we set CMAKE_PREFIX_PATH inside DolphinQt's CMakeLists.txt instead.
2023-01-31 23:19:46 +13:00
0f037a1af8
Merge pull request #10864 from TellowKrinkle/BetterLogicBlend
...
VideoCommon: Better logic op invert approximation
2023-01-31 01:55:55 -05:00
b753641dd4
Add some descriptions to new classes
2023-01-31 19:41:24 +13:00
abfc75f362
Cleanup headers
2023-01-31 19:41:24 +13:00
ec8f46b02c
Expose Renderer's Framecount
...
We don't want to move it, because we want to complete
this refactor without changing savestate version
2023-01-31 19:41:24 +13:00
3be63221c7
Renderer still needs to track swaps for savestates
2023-01-31 19:41:24 +13:00
3ae78b8e76
Also use events for config changed
2023-01-31 19:41:24 +13:00
0da69055d9
Split out everying remaining from Swap
2023-01-31 19:41:24 +13:00
2a18b34a73
Wire up frame before/after events
2023-01-31 19:41:24 +13:00
154cb4f722
Introduce an Event system to VideoCommon
...
A lot of the remaining complexity in Renderer is the massive Swap function
which tries to handle a bunch of FrameBegin/FrameEnd events.
Rather than create a new place for it. This event system will try
to distribute it all over the place
2023-01-31 19:41:24 +13:00
d6cd8de1a7
Delete unused EFBHasAlphaChannel function
2023-01-31 19:41:24 +13:00
9d125a6e43
Move ConfigChanged out of RenderBase
...
There is this nice VideoConfig file that's perfect for it
2023-01-31 19:41:24 +13:00
ca5ec13e13
Move GraphicsMod out of RenderBase
2023-01-31 19:41:24 +13:00
55d15bdd6e
Move utiltily drawing out of RenderBase
2023-01-31 19:41:24 +13:00
99d3e489ea
Move BoundingBox out of RenderBase
...
They were essentially just pass-though methods
2023-01-31 19:41:24 +13:00
35a69cb1bb
Fix missing include
2023-01-31 19:41:24 +13:00
8ad59f8ccf
Add AbstractGfx for DX12
2023-01-31 19:41:24 +13:00
5a2d119bda
Implement AbstractGfx for Dx11
2023-01-31 19:41:24 +13:00
8bc8e43dd6
Add virtual Initialize() to PerfQueryBase
...
Both DX12 and Vulkan already had one.
2023-01-31 19:41:24 +13:00
3c73707dfe
Fix dead code.
2023-01-31 19:41:24 +13:00
eaae5b4a45
Implement AbstactGfx for Metal
2023-01-31 19:41:24 +13:00
89d9ec0a84
Fix warning
2023-01-31 19:41:24 +13:00
b007b8e104
Replace BeginUI/EndUI
2023-01-31 19:41:24 +13:00
18c799f0b6
Present: Set surface info before initializing ImGui
...
Otherwise you get subtle bugs in vulkan that take hours to track down.
2023-01-31 19:41:24 +13:00
06ae08ca8b
Fix misnamed local variable
2023-01-31 19:41:24 +13:00
f158ff300b
Handle VideoSoftware's present fallback better
...
Not a good idea to abuse bSupportsPostProcessing
2023-01-31 19:41:24 +13:00
26e00c3bb4
Fix warning about using & with bools
2023-01-31 19:41:23 +13:00
74d3b3443a
Fix warning about compare sign mismatch
2023-01-31 19:41:23 +13:00
8f5b196019
Minimise include polution from RenderState
2023-01-31 19:41:23 +13:00
2a2014af09
Implement AbstractGfx for Vulkan
2023-01-31 19:41:23 +13:00
58b70b2fb2
Don't set common globals from Video Backends
2023-01-31 19:41:23 +13:00
d37f83ffeb
Implement AbstractGfx for Software & Null
2023-01-31 19:41:23 +13:00
be8cbe3c66
Merge pull request #11513 from JosJuice/android-scaled-int-setting
...
Android: Create ScaledIntSetting class
2023-01-31 01:05:36 -05:00
f0336a3129
Implement AbstractGfx for OpenGL
...
Mostly involves moving contents of OGLRender
to OGLGfx and OGLConfig
2023-01-31 18:46:04 +13:00
8a23629345
Split AbstractGfx out of Renderer
...
Almost all the virtual functions in Renderer are part of dolphin's
"graphics api abstraction layer", which has slowly formed over the
last decade or two.
Most of the work was done previously with the introduction of the
various "AbstractX" classes, associated with texture cache cleanups
and implementation of newer graphics APIs (Direct3D 12, Vulkan, Metal).
We are simply taking the last step and yeeting these functions out
of Renderer.
This "AbstractGfx" class is now completely agnostic of any details
from the flipper/hollywood GPU we are emulating, though somewhat
specialized.
(Will not build, this commit only contains changes outside VideoBackends)
2023-01-31 18:46:02 +13:00
e57eb04ed3
Rename FrameDump.{cpp,h} to FrameDumpFFMpeg.{cpp,h}
...
The name kind of conflicts with a new FrameDumper class
2023-01-31 18:45:29 +13:00
0d4537d60f
Move Presenting, Dumping and ImGui out of Renderer
2023-01-31 18:45:21 +13:00
c38c76abad
Refactor to remove virtual from RenderXFBToScreen
...
Slightly simplifies the upcoming refactor
2023-01-31 18:29:47 +13:00
a01d5283ec
TextureCache: Add content locking
...
Texture cache occasionally mutates textures for efficiency.
Which is awkward if we want to borrow those textures from texture cache
to do something else, such as a graphics debugger, or async presentation
on another thread.
Content locking provides a way to signal that the contents of a texture
cache entry should not change. Texture cache will be forced to use
alternative strategies.
2023-01-31 18:29:47 +13:00
606c18210d
TextureCache: Refactor with smart pointers
...
The whole ownership model was getting a bit of a mess, with a some
of special cases to deal with. And I'm planning to make it even more
complex in the future.
So here is some upfront work to convert it over to reference counted
pointers.
2023-01-31 18:29:47 +13:00
c1fd4a2013
Move TCacheEntry out of TextureCacheBase
...
Allows for fowards declaration
2023-01-31 18:29:47 +13:00
2843cd10a8
Merge pull request #11492 from mandar1jn/file-improvements
...
Improve the data in the first data block of the skylanders figures
2023-01-31 03:02:39 +01:00
12b8b44a08
Android: Simplify the grid options dialog fragment
2023-01-30 17:09:16 -05:00
c63eb75435
Merge pull request #11520 from lioncash/undefined
...
Common/Network: Resolve -Wexpansion-to-defined warning
2023-01-30 21:17:11 +01:00
600ad5f498
VideoCommon: Better logic op invert approximation
2023-01-30 14:04:37 -06:00
43194b2742
Merge pull request #11519 from lioncash/android
...
AndroidCommon: Make use of std::string_view where applicable
2023-01-30 20:21:44 +01:00
cdd3e636e1
Common/Network: Resolve -Wexpansion-to-defined warning
...
Macros that expand to include the standard define macro are undefined.
This is pretty trivial to fix. We can just do the test and then define
the name itself if it's true, rather than making the set of definition
checks the macro itself.
2023-01-30 14:20:56 -05:00
2e8ad9f105
Android: Create ScaledIntSetting class
...
A little refactoring to cut down on the size of the very big
SettingsFragmentPresenter class.
I ended up adding a bunch of @NonNull annotations in various settings
classes so I could make the parameters `Settings` instead of `Settings?`
in the new Kotlin code.
2023-01-30 20:07:09 +01:00
f0b833a639
Merge pull request #11518 from t895/deprecated-setting
...
Android: Remove unused force filtering setting
2023-01-30 19:56:44 +01:00
96bc0a3063
Android: Remove unused force filtering setting
2023-01-30 13:38:39 -05:00
65c782b3b9
Merge pull request #11517 from t895/slider-setting-adjustment
...
Android: Set each slider step size manually
2023-01-30 19:32:18 +01:00
5c1954c843
AndroidCommon: Make use of std::string_view where applicable
...
Several of these can take a string_view rather than needing to
specifically use std::string.
2023-01-30 13:30:52 -05:00
26c8440ae1
Android: Set each slider step size manually
2023-01-30 13:17:02 -05:00
f20790370a
Core/ActionReplay: Make use of std::span where applicable
...
Generifies the interface a little by not strictly requiring the use of
std::vector.
2023-01-30 13:02:09 -05:00
adb4c0492d
Core/GeckoCode: Make use of std::span where applicable
...
Generifies the interface a little by not strictly requiring the use of
std::vector.
2023-01-30 12:53:50 -05:00
81388eedaa
Use GNUInstallDirs for installation paths
2023-01-30 09:44:44 -06:00
c8a91abadc
Improve the data in the first data block of the skylanders figures
...
* Added NUID
* Added BCC
* Added ATQA
* Added SAK
2023-01-30 16:29:20 +01:00
df9ba70c35
Merge pull request #11507 from phire/Wnullablitly-completeness
...
Ignore nullability-completeness warnings in VMA
2023-01-30 10:03:49 +01:00
ae712c61c2
Merge pull request #11500 from iwubcode/vulkan_copy_rectangle_one_layer
...
VideoBackends: update Vulkan's 'CopyRectangleFromTexture' to copy one layer
2023-01-30 10:03:33 +01:00
e48424065b
Merge pull request #10839 from CasualPokePlayer/fix_sysconf_settings
...
Fix SYSCONF movie settings
2023-01-30 09:50:21 +01:00
1eb69ea0a0
Merge pull request #10936 from TellowKrinkle/FixIncludeDirs
...
CMake: Actually use the include directories specified by dependencies
2023-01-30 09:19:06 +01:00
fa1fec7d48
Merge pull request #11510 from TellowKrinkle/FmtImport
...
CMake: Use imported target for fmt in tests
2023-01-30 09:10:22 +01:00
071ee3d85e
Merge pull request #11512 from JosJuice/android-mem2-crash
...
Android: Fix crash when attempting to change MEM2 size
2023-01-30 09:07:56 +01:00
8edca2039e
Merge pull request #10947 from Zopolis4/opensleuth
...
Restrict OpenSLES to Android via CMake
2023-01-30 09:02:45 +01:00
a2f4606d33
Merge pull request #11205 from TellowKrinkle/AutoPresent
...
VideoBackends:Metal: Default to presentDrawable when vsync is on
2023-01-30 09:01:18 +01:00
6d7303993c
Merge pull request #11509 from Sam-Belliveau/improved-speed-counter
...
Tie Speed to CPU Speed and not VPS
2023-01-30 20:41:03 +13:00
00fdf1ddce
Android: Fix crash when attempting to change MEM2 size
...
The step size for the slider ended up being 10, but Android wanted it
to be a divisor of the slider's range (which is 128 - 64 = 64).
2023-01-29 23:35:54 +01:00
07e98c7790
CMake: Use imported target for fmt in tests
...
This properly adds the header include paths when using system fmt
2023-01-29 14:37:54 -06:00
e4e425b930
VideoBackends:Metal: Assert on pipelines with no render targets
...
This only actually fails on specific Metal drivers, this way doing it will actually fail the CI and we'll notice
2023-01-29 14:36:28 -06:00
1119a9ba32
VideoCommon: Don't create pipelines with no render targets
...
Some backends don't like it when you do that
2023-01-29 14:35:23 -06:00
ebf114aef5
Tie Speed to CPU Speed and not VPS
2023-01-29 13:33:48 -05:00
6ad182edd9
Ignore nullability-completeness warnings in VMA
...
These cause a lot of warnings when compiling with clang.
And the example VmaUsage.h appears to disable them
2023-01-30 03:11:51 +13:00
2eda76cffc
Merge pull request #11474 from MayImilae/cleanup-remove-cdutils
...
Cleanup: Remove CDUtils
2023-01-29 09:50:32 +01:00
05b77925cb
Merge pull request #11460 from t895/reveal-settings
...
Android: Reveal several hidden settings
2023-01-29 07:00:38 +01:00
3b4e17292d
Revert "DSPLLE: Add assertion for bad DMA alignment"
...
This reverts commit e140516130e391a28102
2023-01-28 17:26:47 -08:00
e27339039c
PPCAnalyst: Actually check if instructions want CR
2023-01-28 20:16:17 +01:00
9d2c4aa325
PPCAnalyst: Use bitsets for CR analysis
...
Currently we're only performing CR analysis for CR0 and CR1, but I
would like to do it for all CRs. Bitsets are appropriate for this.
2023-01-28 20:16:16 +01:00
3b57fb1d21
PPCTables: Add new instruction flags for CR
2023-01-28 20:16:16 +01:00
3e21ba55f1
Merge pull request #11496 from t895/analytics-dialog-kotlin
...
Android: Convert analytics dialog to Kotlin
2023-01-28 20:03:49 +01:00
37859ec1da
Cleanup: Remove CDUtils
...
This is a cleaning followup for #11456 .
2023-01-28 03:50:57 -08:00
7bea39b39e
VideoBackends: add a way to load data into a specific level AND layer, default to layer 0
2023-01-27 18:46:53 -06:00
271c60781b
VideoBackends: update Vulkan's 'CopyRectangleFromTexture' to copy one layer, copying more than one layer doesn't make sense given that we provide both the source/destination layer
2023-01-27 18:41:52 -06:00
be2d394b8c
GDBStub: Avoid ppcState global.
2023-01-27 15:22:48 +01:00
dd9907ed93
PatchEngine: Avoid ppcState global.
2023-01-27 15:22:48 +01:00
4c349caabd
MIOS: Avoid ppcState global.
2023-01-27 15:22:48 +01:00
ed633476e6
IOS: Avoid ppcState global.
2023-01-27 15:22:47 +01:00
0a0b4d325f
HW/SystemTimers: Avoid ppcState global.
2023-01-27 15:22:47 +01:00
a784fe1f2f
HW/ProcessorInterface: Avoid ppcState global.
2023-01-27 15:22:47 +01:00
884130f95c
HW/Memmap: Avoid ppcState global.
2023-01-27 15:22:47 +01:00
2bf72de43d
HW/GPFifo: Avoid ppcState global.
2023-01-27 15:22:47 +01:00
e2f7855b0e
HW/DSP: Avoid ppcState global.
2023-01-27 15:22:47 +01:00
18d9ec75f1
HW/CPU: Avoid ppcState global.
2023-01-27 15:22:47 +01:00
078a460446
HW/AudioInterface: Avoid ppcState global.
2023-01-27 15:22:46 +01:00
b52e8fd295
HLE_OS: Avoid ppcState global.
2023-01-27 15:22:46 +01:00
7fd552081f
HLE function hooking: Avoid ppcState global.
2023-01-27 15:22:46 +01:00
30de91d843
GeckoCode: Avoid ppcState global.
2023-01-27 15:22:46 +01:00
1a826b27a6
FifoPlayer: Avoid ppcState global.
2023-01-27 15:22:46 +01:00
8adabb86cf
Debugger: Avoid ppcState global.
2023-01-27 15:22:45 +01:00
bfc951311f
CheatSearch: Avoid ppcState global.
2023-01-27 15:22:45 +01:00
bbdfb4bc14
CodeTrace: Avoid ppcState global.
2023-01-27 15:22:45 +01:00
41ad0490f0
CoreTiming: Avoid ppcState global.
2023-01-27 15:22:45 +01:00
94455ee9e1
Boot: Avoid ppcState global.
2023-01-27 15:22:45 +01:00
51e7980d95
Core: Add PowerPCState reference to System.
2023-01-27 15:22:44 +01:00
485bba238e
PowerPC: Add PowerPCState parameter to UpdatePerformanceMonitor().
2023-01-27 15:22:44 +01:00
61ba516570
PowerPC: Move a few functions to PowerPCState.
2023-01-27 15:22:44 +01:00
0dcf228aaf
PowerPC: Parametrize TU macro.
2023-01-27 15:22:44 +01:00
a7d3315b4f
PowerPC: Parametrize TL macro.
2023-01-27 15:22:44 +01:00
2f241856b6
PowerPC: Add PowerPCState parameter to GQR macro.
2023-01-27 15:22:44 +01:00
814c01162a
PowerPC: Remove SPRG0/1/2/3 macros.
2023-01-27 15:22:43 +01:00
2f8b3ac1b7
PowerPC: Parametrize SRR1 macro.
2023-01-27 15:22:43 +01:00
652113e6ba
PowerPC: Parametrize SRR0 macro.
2023-01-27 15:22:43 +01:00
10dabd9975
PowerPC: Remove rDEC macro.
2023-01-27 15:22:43 +01:00
c13ca271d8
PowerPC: Parametrize CTR macro.
2023-01-27 15:22:43 +01:00
0a343007cb
PowerPC: Parametrize LR macro.
2023-01-27 15:22:43 +01:00
0f301829d2
PowerPC: Remove rPS macro.
2023-01-27 15:22:42 +01:00
0cd4a226d2
PowerPC: Remove rSPR macro.
2023-01-27 15:22:42 +01:00
27ce432012
PowerPC: Remove rGPR macro.
2023-01-27 15:22:42 +01:00
8fccefa3aa
PowerPC: Remove GPR macro.
2023-01-27 15:22:42 +01:00
ba1b624e1b
PowerPC: Remove MSR macro.
2023-01-27 15:22:42 +01:00
4b6b8fa1ae
PowerPC: Remove FPSCR macro.
2023-01-27 15:22:41 +01:00
2f3187eba9
PowerPC: Remove NPC macro.
2023-01-27 15:22:41 +01:00
be8d0b76ca
PowerPC: Remove PC macro.
2023-01-27 15:22:41 +01:00
82f3170876
PowerPC: Parametrize THRM1/2/3 macros.
2023-01-27 15:22:41 +01:00
8bab3ac755
PowerPC: Parametrize MMCR1 macro.
2023-01-27 15:22:41 +01:00
126590c4cd
PowerPC: Parametrize MMCR0 macro.
2023-01-27 15:22:40 +01:00
38529a2d8d
PowerPC: Parametrize DMAL macro.
2023-01-27 15:22:40 +01:00
2374365274
PowerPC: Parametrize DMAU macro.
2023-01-27 15:22:40 +01:00
31483e492e
PowerPC: Parametrize HID4 macro.
2023-01-27 15:22:40 +01:00
6f0ab1b33e
PowerPC: Parametrize HID2 macro.
2023-01-27 15:22:40 +01:00
49eeb986c6
PowerPC: Parametrize HID0 macro.
2023-01-27 15:22:40 +01:00
ab817dcaed
Android: Convert Analytics to Kotlin
2023-01-26 21:14:35 -05:00
14c7d81b54
Android: Create analytics dialog fragment
2023-01-26 20:42:39 -05:00
a534af4dd6
Android: Don't enforce a particular CMake version
2023-01-26 18:46:31 -05:00
f056cec859
Merge pull request #11480 from Pokechu22/dsp-code-alignment
...
DSPLLE: Add assertion for bad DMA alignment
2023-01-26 23:17:09 +01:00
9c9310bf44
Merge pull request #11208 from TellowKrinkle/CPUCull
...
Cull vertices on the CPU
2023-01-26 23:15:23 +01:00
c6a7465529
Merge pull request #11485 from MayImilae/remove-filepath-from-states-messaging
...
Remove Filepath from State Save/Load OSD Messages
2023-01-26 05:29:21 +01:00
0d93a31a38
Common/BitSet: Zero initialize data member
...
Gets rid of the need to remember to initialize them in the constructor,
except when overriding the default initializer.
2023-01-25 04:16:30 -05:00
6446fa7e48
Common/Bitset: Make initializer_list constructor constexpr
...
This was able to be constexpr since C++14.
2023-01-25 04:13:05 -05:00
7413be1487
VideoCommon: Add configuration option for CPUCull
2023-01-25 02:21:56 -06:00
a0e6d7c173
VideoCommon: Explicitly disable fp_contract for CPUCull
2023-01-25 02:21:56 -06:00
1be0149146
VideoCommon: Cull vertices on the CPU
2023-01-25 02:21:56 -06:00
b170ef9651
VideoCommon: Add class for quickly transforming and culling vertices on the CPU
2023-01-25 02:21:56 -06:00
6db2171fd0
Merge pull request #11488 from lioncash/point
...
StringUtil: Make StringUTF8CodePointCount take string_view
2023-01-25 02:33:22 +01:00
9fc959cab0
Merge pull request #11489 from lioncash/init
...
CoreTiming: Zero initialize all CoreTimingManager throttle members
2023-01-25 02:29:32 +01:00
3607c1dc7d
CoreTiming: Zero initialize all CoreTimingManager throttle members
...
Gives two members without explicit initialization default values to be
consistent with the rest of the class and also ensuring deterministic
values on construction.
2023-01-24 17:20:08 -05:00
6fad8ac389
Merge pull request #11467 from Simonx22/remove-titlebar-fps-counter
...
Core: Remove FPS, VPS and speed percentage from window title
2023-01-24 23:04:29 +01:00
1d03835c5d
StringUtil: Make StringUTF8CodePointCount take string_view
...
There's nothing really about this that would need to constrain it to
only std::string instances.
2023-01-24 16:55:43 -05:00
e5b91f00b0
Common: Replace StringBeginsWith/StringEndsWith with std equivalents
...
Obsoletes these functions in favor of the standard member functions
added in C++20.
2023-01-24 14:58:20 -05:00
ba6ee9d7ba
Merge pull request #11413 from t895/sample-window-slider
...
Android: Add slider for Performance Sample Window
2023-01-24 17:22:11 +00:00
f4a8f80228
Merge pull request #11482 from t895/rtl-fixes
...
Android: Fix RTL layout in several views
2023-01-24 16:52:06 +00:00
cb55921971
Merge pull request #11443 from t895/agp-upgrade-eel
...
Android: Update build tools and dependencies
2023-01-24 16:50:40 +00:00
b6d2cf5e30
Merge pull request #11483 from t895/grid-option-fix
...
Android: Fix grid options menu string
2023-01-24 16:49:19 +00:00
5525f011be
Merge pull request #11436 from shuffle2/msvc-Zc
...
msvc: update c++ conformance flags
2023-01-24 16:46:14 +00:00
ed121ee679
Removed filepath from State Save/Load OSD messages
...
Though less important compared to #11470 , save states also show the full path in the OSD message and could potentially dox a streamer who is playing in Dolphin. This is a simple fix - it removes the path from the message and only displays the file name.
2023-01-24 07:55:58 -08:00
c3a1a7d924
Android: Fix rtl layout in cheat details fragment
2023-01-24 08:41:20 -05:00
7741046e6f
Android: Fix rtl layout for about dialog
2023-01-24 08:41:20 -05:00
8d5967ad87
Android: Fix rtl layout on game details dialog
2023-01-24 08:41:20 -05:00
d61dbd06a6
Android: Fix rtl layout for cheat warning fragment
2023-01-24 08:25:47 -05:00
2904e28d91
Android: Fix rtl layout for cheat list items
2023-01-24 08:25:47 -05:00
3fa08833ff
Android: Fix rtl layout for multiple settings activity views
2023-01-24 08:25:47 -05:00
dc11180784
Android: Fix rtl layout for control dialogs
2023-01-24 08:25:47 -05:00
3e1a096f7f
Android: Fix rtl layout in convert activity
2023-01-24 08:25:47 -05:00
82d0501fc8
Android: Fix rtl layout for in-game menu fragment
2023-01-24 08:25:47 -05:00
9bccf58fdb
Android: Fix rtl layout for grid options dialog
2023-01-24 08:25:47 -05:00
ab0ab1aa7d
Android: Fix rtl layout in riivolution boot activity
2023-01-24 08:25:47 -05:00
b35ee27568
Android: Fix rtl layout in user data activity
2023-01-24 08:25:47 -05:00
cd7251cd3a
Android: Fix rtl layout on card_game
2023-01-24 08:25:46 -05:00
a184d70193
convert File::ScanDirectoryTree to std::filesystem
2023-01-24 05:15:11 -08:00
7e6436db34
fileutil: use std::filesystem
2023-01-24 04:51:24 -08:00
014d0573b8
Merge pull request #11455 from t895/about-dialog
...
Android: Add about dialog
2023-01-24 13:16:15 +01:00
caca662dbf
Merge pull request #10994 from shuffle2/fs
...
get rid of HAS_STD_FILESYSTEM
2023-01-24 12:18:25 +01:00
d4d6f3db63
Merge pull request #11331 from deReeperJosh/skylandersportal
...
Emulate Skylanders Portals within Dolphin
2023-01-24 06:56:00 +01:00
7002831c55
Merge pull request #11465 from OatmealDome/qt6-xinput-bug
...
DolphinQt: Add workaround for Qt 6.3+ bug on Linux
2023-01-24 06:21:19 +01:00
c76d2c16eb
Valid block/num checks, rename variables, remove translatable strings
...
Capitalize Skylander in tr strings
Lint and validation method fixes
Proper Attach and Change Interface method
Re-jig code to exit early and read easier
2023-01-24 18:12:24 +13:00
82de765106
Android: Fix grid options menu string
...
Previously the string was "Settings" and not "Grid Options"
2023-01-23 23:44:46 -05:00
e391a28102
DSPTool: Generate an alignment specifier
...
alignas is a C++ keyword since C++11, and can be used in C with a header too (although I don't know the details).
2023-01-23 15:30:49 -08:00
e140516130
DSPLLE: Add assertion for bad DMA alignment
...
I haven't tested this extensively on real hardware, but I do know that bad things happen if the address isn't properly aligned, and libogc says it should be 32-byte aligned.
2023-01-23 15:20:49 -08:00
df6f070a55
Core: Remove FPS, VPS and speed percentage from window title
2023-01-23 21:32:50 +01:00
d0da689eeb
DolphinQt: Add i18n comments for strings containing the word "watches"
...
These new strings could use the same clarification as we have for
the existing string "&Delete Watch".
2023-01-23 20:49:22 +01:00
860f56150a
Android: Add safeguards around skip ipl setting
...
A user shouldn't be able to disable "skip ipl" when they don't have a bios file. This finds the ipl file and tells the setting when toggling is allowed. Additionally, if the user previously disabled the option and then deletes their ipl file, they will be allowed to enable it but toggling will be disabled afterwards.
2023-01-23 12:48:27 -05:00
8d477c65c9
Merge pull request #11458 from shuffle2/winuver
...
windows: prefer os version from registry
2023-01-23 15:53:41 +01:00
a8a4b9c6d0
Merge pull request #11475 from shuffle2/comdef
...
windows: replace comdef dependency with winrt
2023-01-23 15:52:51 +01:00
e5f3a0a9bc
buildfix if discord isn't enabled
2023-01-23 06:39:41 -08:00
c338f9e2a1
windows: replace comdef dependency with winrt
2023-01-23 06:09:01 -08:00
8032a71c4c
Merge pull request #11471 from MayImilae/dont-update-titlebar-with-osd-messages
...
Don't Write OSD Messages to the Titlebar
2023-01-23 06:46:32 +01:00
9df1f0276d
Don't Write OSD Messages to the titlebar
...
Turns out all OSD messages, every single one, are written to the titlebar. We've just never seen them because the FPS is in the title bar and it replaces it in a fraction of a second. This was only visible when saving savestates because it halts emulation for a moment while writing.
This is dumb, let's not do that anymore.
2023-01-22 00:19:51 -08:00
0eb984f030
Merge pull request #11470 from MayImilae/remove-memory-card-path-from-osd-message
...
Remove Memory Card Path from the Wrote to OSD Message
2023-01-22 08:13:51 +01:00
ef0d386954
Remove Memory Card Path from the Wrote OSD Message
...
A few weeks ago, a vtuber tweeted that they had to remove a vod of their stream because Dolphin Emulator showed some personal information during the steam, and left a warning to everyone else that Dolphin shows the account name of the computer. And yea, we do, we show the full directory of the memory card every time a memory card is written, and due to mandatory Microsoft account nonsense, that is very likely to contain someone’s real name.
Fortunately this is very easy for us to solve. This change simply removes the filename from wrote memory card contents string. That’s it. All functionality of the wrote memory card OSD message remains the same, it just doesn’t say where the memory card is anymore.
There are lots of other potential solutions to this but after talking on IRC it seems the simplest one is the best.
2023-01-21 21:19:51 -08:00
18fd0d7dcd
Use Core timing instead of thread
...
Skylander code tidy ups
Convert c array to std::array and fix comments
Formatting fixes/review changes
Variable comment
Migrate portal to System Impl and code tidy ups
Use struct
Restore review changes
Minor fix to schedule transfer method
Change descriptors to hex and fix comments
2023-01-22 14:50:30 +13:00
f76a6789a0
Emulate Skylanders within Dolphin
...
Ported the code from RPCS3, with improvements made to the handling of control messages and audio transfers, Co-Authored with @mandar1jn
Missing new line chars
Co-Authored-By: mandar1jn <49076509+mandar1jn@users.noreply.github.com>
2023-01-22 14:50:30 +13:00
9fe1d80920
Merge pull request #11457 from delroth/remove-stable-track
...
DolphinQt/Settings: remove 'stable' track from auto-updater options
2023-01-21 06:48:04 +01:00
597f8f1b87
Externals: Convert gtest to a submodule and update to v1.12.1
2023-01-20 11:43:34 -08:00
d40dbe4670
DolphinQt: Add workaround for Qt 6.3+ bug on Linux
...
See https://bugs.dolphin-emu.org/issues/12913 for more information.
2023-01-20 03:06:04 -05:00
a32b85691b
Fix Turntable extension's table range
2023-01-18 19:17:09 -08:00
8d5edb13a9
Merge pull request #11367 from Sam-Belliveau/lagbegone
...
VideoCommon: VI Skip
2023-01-19 01:20:01 +01:00
b598b6ec72
Android: Add about dialog
2023-01-18 15:58:06 -05:00
bbb83054af
Android: Expose custom rtc options
2023-01-18 01:56:05 -05:00
d63462a14e
Android: Add missing headers
2023-01-18 01:55:39 -05:00
6448d6dbe7
Android: Expose emulated memory size override
...
Update BooleanSetting.java
2023-01-18 01:55:39 -05:00
1cd11b8f3a
Merge pull request #11381 from skyfloogle/traversal-fix-1
...
Netplay: Fix traversal connections occasionally not working
2023-01-17 23:40:24 +01:00
a7d1683149
Merge pull request #11432 from Pokechu22/generic-vertex-loader-test-error
...
VertexLoader: Fix loading tangent/binormal caches with NormalIndex3
2023-01-17 23:30:29 +01:00
686ac363ba
Merge pull request #11456 from MayImilae/remove-boot-from-dvd
...
Remove Boot from DVD Backup
2023-01-17 23:27:59 +01:00
c527aea40d
Merge pull request #11453 from JosJuice/revert-open-user-dir-qt-hotfix
...
Revert "MenuBar: Tweak string for open user folder option"
2023-01-17 23:27:09 +01:00
e2db9cd142
NetKDTime: Use UTC timestamp
2023-01-17 13:59:01 -05:00
96c8a7ee1f
Android: Expose texture filtering options
2023-01-17 11:13:02 -05:00
23331e4367
Android: Expose frame dump compression level
2023-01-17 11:13:02 -05:00
dff7f20f9d
windows: prefer os version from registry
...
this value is not modified by compatibility mode
drop reporting service pack numbers. no longer used
2023-01-17 01:38:00 -08:00
3342947446
DolphinQt/Settings: remove 'stable' track from auto-updater options
...
We've decided this track will never be used in the future. Releases will
continue using the "beta" branch internally, though we'll have the
user-visible strings use a different name instead.
(Note: Dolphin provided builds have always defaulted to 'beta' as the
auto-update track, so anyone who set 'stable' did so manually.)
2023-01-17 08:34:55 +01:00
6373c9225b
Android: Expose accurate cpu cache toggle
2023-01-17 01:10:46 -05:00
bc64392692
Android: Expose pause on panic toggle
2023-01-17 01:08:40 -05:00
10fd768898
Merge pull request #11420 from t895/copy-profile
...
Android: Copy baseline profile during release builds
2023-01-17 04:48:30 +01:00
dcc10cff11
Remove Boot from DVD Backup
...
This should be a fairly easy merge, assuming I didn’t mess anything up. TL:DR no one uses it and it’s not great.
Boot from DVD Backup is an ancient feature with origins in the Megacommit. Back then, GameCube and Wii games were quite large relative to drives of the time. For example, in 2008, the most common hard drive sizes were 320GB and 512GB. On the 320GB drive I personally had at the time, as little as 42 Wii ISOs could have filled it entirely! And that’s ignoring any other files one might want to put onto a drive. Backup DVDs allowed users to burn relatively cheap DVD media and store their GameCube and Wii dumps in a Dolphin accessible way that didn’t eat into their precious HDD space. It had compromises, even then, but in 2008… I mean honestly users probably wouldn’t even notice those compromises with how Dolphin barely even worked at all back then.
Obviously, today the storage space concerns are not as big of an issue. According to seagate the average hard drive it sells today is 8TB. For typical laptops purchased now, the -minimum- selection for storage is usually 1TB. You can even buy a name brand 4TB external hard drive for $100. GC and Wii ISOs are not as big as they once were, relatively anyway. Plus flash drives and SD cards are super cheap and way faster than disc drives ever were. For anyone that has limited drive space, removable flash media can fulfill this offloading role far better than backup DVD media ever could.
Also no one has DVD drives anymore. That’s kind of an important detail.
But to see if Booting from DVD Backup even still worked, I decided to give it a try. I have an ASUS BW-16D1HT, a badass Bluray XL reading and burning drive, connected to my Windows 11 Threadripper 5975WX machine. A super fast drive on a super fast machine is as good as it possibly can get for this feature. So I bought a spindle of DVD-Rs, burned a couple of discs and gave it a try. Surprisingly, it does still work. However, as expected, it introduces a lot of stuttering. Testing Prime 1 and Prime 3, in both games stuttering was introduced whenever the DVD Drive had to suddenly seek. Spikes of 50ms occurred constantly, but I observed 150ms and even over 1000ms stutters! The worst was a three second stutter, when loading Elysia in Prime 3. I could even hear the stutters - any time the drive suddenly made a harsh seeking noise, the game would have a hard stutter. It worked but, it has some serious compromises.
Boot from DVD Backup isn’t great, using removable flash media or external hard drives is a FAR better option for anyone with limited storage space today, and no one can even use this feature anymore because their computers don’t even have disc drives. It’s time for Boot from DVD Backup to go!
So I did my best on the cleanup but I’m bound to have left some bits. Especially in translation - I didn’t get any warnings or anything there that could help point me to where to clean that up. Please review!
2023-01-16 18:32:43 -08:00
a3b7510505
Android: Expose skip main menu toggle
2023-01-16 20:39:33 -05:00
716dabde96
Merge pull request #11447 from t895/save-state-fix
...
Android: Fix large strings in save/load savestate fragment
2023-01-16 19:09:37 +01:00
59b276ea87
Merge pull request #11448 from t895/nav-fix-api-26
...
Android: Fix navigation bar buttons appearing invisible on API 26
2023-01-16 18:45:06 +01:00
8f88297122
Revert "MenuBar: Tweak string for open user folder option"
...
This reverts commit 6788bda6c9da0be24b2f
2023-01-16 18:31:16 +01:00
aacd66bd5b
Merge pull request #11451 from OatmealDome/open-user-dir-qt-hotfix
...
MenuBar: Tweak string for open user folder option
2023-01-16 10:47:27 +01:00
bb64b0ee44
Merge pull request #10708 from OatmealDome/win-user-dir
...
UICommon: Change default user directory location to AppData on Windows
2023-01-16 10:34:41 +01:00
6788bda6c9
MenuBar: Tweak string for open user folder option
2023-01-16 04:31:12 -05:00
869aa9eb55
MenuBar: Add action which opens the user folder
2023-01-16 04:08:19 -05:00
cc68d5321f
UICommon: Set UserConfigPath in the registry to AppData User for backwards compatibility
2023-01-16 01:37:14 -05:00
3896934d5e
UICommon: Use the old User directory in Documents if it exists
2023-01-16 01:37:14 -05:00
75d87ff90e
UICommon: Change default User directory location to AppData
2023-01-16 01:37:14 -05:00
b1e05c9125
Android: Remove pre-generated baseline profile
2023-01-15 21:16:55 -05:00
19aa9247be
Android: Copy baseline profile during release builds
2023-01-15 21:16:55 -05:00
7c202ab411
Reset throttle on savestate load
2023-01-16 14:18:42 +13:00
dbe03a4f76
Android: Fix navigation bar buttons appearing invisible on API 26
2023-01-15 18:36:22 -05:00
76ca57ef2e
Android: Fix large strings in save/load savestate fragment
2023-01-15 17:49:48 -05:00
30f0051f9c
Merge pull request #11440 from JosJuice/jit64-negative-guard
...
Core: Allocate 2 GiB of guard pages below fastmem area
2023-01-14 19:19:53 -05:00
33c5f7a129
Android: Update benchmark module dependencies
...
Androidx JUnit 1.1.4 -> 1.1.5
Androidx Espresso 3.5.0 -> 3.5.1
2023-01-14 18:41:18 -05:00
005d7574aa
Android: Update app module dependencies
...
Androidx Fragment 1.5.4 -> 1.5.5
Androidx AppCompat 1.5.1 -> 1.6.0
Androidx Profile Installer 1.2.1 -> 1.2.2
Core android library desugaring libraries 1.1.5 -> 2.0.0
2023-01-14 18:39:43 -05:00
45cdc7357a
Android: Upgrade Java bytecode from 1.8 to 11
2023-01-14 18:35:32 -05:00
27466fd5f9
Android: Upgrade AGP from 7.3.1 to 7.4.0
2023-01-14 18:30:07 -05:00
054b2219d4
Android: Upgrade gradle from 7.5.1 to 7.6
2023-01-14 18:29:39 -05:00
4fa9fa997e
Core: Allocate 2 GiB of guard pages below fastmem area
...
See the comment added by this commit. We were previously guarding against
overshooting in address calculations, but not against undershooting.
Perhaps someone assumed that the displacement of an x86 loadstore was
treated as unsigned?
Note: While the comment says we can undershoot by up to 2 GiB, in
practice Jit64 as it currently behaves won't actually undershoot by more
than 0x8000 if my analysis is correct. But address space is cheap, so
let's guard the full 2 GiB.
2023-01-14 20:35:50 +01:00
9c90b31e6a
Memmap: Remove some remnants from the 32-bit JITs
2023-01-14 11:46:37 +01:00
9d350fd56b
Merge pull request #11437 from t895/grid-options-fix
...
Android: Fix grid options text borders
2023-01-14 09:42:56 +01:00
23ad07b368
Add VISkip
2023-01-14 01:56:37 -05:00
8a1cac9be1
Merge pull request #11348 from Sam-Belliveau/improved-pacing
...
CoreTiming: Throttle Before Every Event Using std::chrono
2023-01-13 21:52:07 -05:00
3910bdd68b
VertexLoader: Don't write position_cache if vertex is skipped
...
This is the behavior in the x64 and ARM64 vertex loaders. I don't know if it makes sense (the whole skipped vertex system seems jank, but several games behave incorrectly without it).
2023-01-13 15:38:00 -08:00
16c0593a52
VertexLoader: Fix loading tangent/binormal caches with NormalIndex3
2023-01-13 15:38:00 -08:00
2d53b73643
VertexLoaderTester: Add assertions for position/binormal/tangent caches
2023-01-13 15:38:00 -08:00
c681d96d46
VertexLoaderTester: Use asserts instead of logs
...
Logs don't show up in unit tests, and since this is debugging functionality (though not enabled for tests by default) it's better to do it this way.
2023-01-13 15:38:00 -08:00
92b6446da1
UnitTests: Add custom main that calls RegisterMsgAlertHandler
...
This prevents a failed assertion from hanging on the MSVC buildbots.
2023-01-13 15:38:00 -08:00
e849172dc9
Limit Throttling to 1200hz
2023-01-13 18:17:24 -05:00
4f397edab3
Android: Fix grid options text borders
...
Previously on displays with a small width, text would appear under the switch. Now the text will break into a new line.
2023-01-13 17:02:53 -05:00
937e08980e
Android: Change slider step size based on range
...
Credit to JosJuice for the slider formula
2023-01-13 16:32:09 -05:00
e70b57fe8a
Android: Adjust width of slider value text view
2023-01-13 16:32:09 -05:00
27e64e6855
Android: Add Performance Sample Window slider
2023-01-13 16:32:09 -05:00
e95c1d55e8
Limit Sleep Calls to 8192hz at most
2023-01-13 11:59:32 -05:00
2a5c699489
msvc: note some things to enable in vs 17.5
2023-01-13 01:36:03 -08:00
9723dba780
msvc: set /Zc:enumTypes
2023-01-13 01:35:17 -08:00
07de7337eb
msvc: dont explicitly set /Zc:lambda
...
it's implied by /std
2023-01-13 01:26:23 -08:00
05ed25d482
DolphinQt: Add button to open graphics mod folder on settings
2023-01-12 21:47:18 -05:00
7abee1a97b
DolphinQt: Fix typo in GBA TAS input window
...
This generated a warning on GCC about the operation being potentially undefined (-Wsequence-point). I'm not sure if that was actually the case, but either way it is a mistake.
2023-01-12 14:33:58 -08:00
5c80a9fd87
CMakeLists: Copy LICENSE files when building for Steam Runtime
2023-01-10 23:21:24 -05:00
fff13c385f
CMakeLists: Copy entire plugins folder on Steam Runtime build
2023-01-10 23:21:24 -05:00
9d81c84db0
Merge pull request #11427 from UltraHDR/patch-1
...
Set LSApplicationCategoryType to games
2023-01-10 19:00:26 +01:00
6b97b64e93
Android: Ignore workaround view height if 0
2023-01-10 12:01:54 -05:00
d51e4e5236
get rid of HAS_STD_FILESYSTEM
...
just use std::filesystem
2023-01-10 05:17:43 -08:00
18454906cf
Set LSApplicationCategoryType to games
...
https://developer.apple.com/documentation/bundleresources/information_property_list/lsapplicationcategorytype
This makes it show up in the Launchpad Games folder
2023-01-10 11:34:42 +00:00
7fe2faff4a
Android: Expose "Log Render Time to File" toggle
2023-01-09 23:29:31 -05:00
f49f3441b3
Android: Disable focus on workaround view
2023-01-09 14:20:50 -05:00
72176641ef
Android: Revert "Make the header focusable"
2023-01-09 14:20:34 -05:00
653e0ccf28
Merge pull request #11365 from iwubcode/cheat_manager_freeze_value
...
DolphinQt: add ability to lock / freeze values in the watches window
2023-01-09 18:41:28 +01:00
993d2ab173
PatchEngine: Use std::span in ApplyMemoryPatches().
2023-01-09 17:24:41 +01:00
21c29bad6b
Merge pull request #11407 from AdmiralCurtiss/globals-gpfifo
...
HW/GPFifo: Refactor to class, move to Core::System.
2023-01-09 17:09:48 +01:00
eeeab3c3be
Merge pull request #11183 from TheLordScruffy/write-back-cache
...
Implement PowerPC data cache
2023-01-09 17:09:32 +01:00
901e4c7697
Reset Throttle Variables In Init
2023-01-09 11:06:12 -05:00
1af8602530
Merge pull request #11411 from t895/managed-device-update
...
Android: Update managed device for baseline profile generation
2023-01-08 13:37:41 +01:00
f7de0e4147
Fix issue that would disable Throttling
2023-01-08 01:20:19 -05:00
d85f6c8298
DolphinAnalytics: Remove ICACHE_MATTERS
2023-01-08 00:17:46 -05:00
825bacde43
PPCCache: Change u32 to u8 for plru, valid, modified
2023-01-07 20:18:59 -05:00
dcded04719
Merge pull request #11410 from t895/fullscreen-fix
...
Android: Fix use of fullscreen modes on Cheats Activity
2023-01-07 19:27:30 +01:00
d32cc1e5eb
Android: Fix workaround view in cheats activity
...
When using a fullscreen mode on some phones that remove the navigation bar, inset callbacks will not be fired. To account for this we set the workaround view at a height of 1px to prevent the view from filling the entire screen due to this activity using a Constraint layout.
2023-01-07 13:08:51 -05:00
811d942222
Improve PPCCache lookup table
2023-01-07 07:30:42 -05:00
d20b71c296
Move x64 DSP JIT into DolphinLib.x64.props
...
Before, it was also compiled on ARM builds, but since it was unused it wasn't linked (and thus its dependency on the nonexistent x64Emitter didn't cause any link issues).
2023-01-06 22:42:21 -08:00
6fe46fcf03
Android: Update managed device for baseline profile generation
2023-01-06 18:33:51 -05:00
bc1cc9eeb4
CoreTiming: Throttle Before Every Event Using Chrono
2023-01-06 17:21:17 -05:00
4d86e44c12
Android: Add hints to allow cheats activity to be previewed
2023-01-06 15:58:29 -05:00
588a72a4fc
PerformanceTracker: Add ownership of m_log_name.
2023-01-06 20:27:25 +01:00
bc46089ab0
PerformanceTracker: Use shared_mutex instead of mutex so multiple threads can read at the same time.
2023-01-06 20:27:25 +01:00
9143eb00fb
PerformanceMetrics: Fix Line Width Issue on Non HiDPI Screens
2023-01-06 20:27:17 +01:00
d33416fc35
HW/Memmap: Zero-initialize members by default.
2023-01-06 05:33:21 +01:00
fbcaf83d30
HW/GPFifo: Refactor to class, move to Core::System.
2023-01-06 05:33:21 +01:00
cc14d60bbb
Merge pull request #11402 from Pokechu22/too-many-indices
...
IndexGenerator: Fix off-by-one in GetRemainingIndices
2023-01-05 15:15:09 +00:00
7b04a6b958
Merge pull request #11089 from sepalani/pcap-share
...
NetworkCaptureLogger: Allow PCAP shared read access on Windows
2023-01-05 04:06:35 +01:00
cefcd9c93c
IndexGenerator: Fix off-by-one in GetRemainingIndices
...
Fixes https://bugs.dolphin-emu.org/issues/13136 .
2023-01-04 10:42:00 -08:00
6c58ba353c
IndexGenerator: Add assertion for overflow in GetRemainingIndices
...
This assertion is currently triggered by Pocoyo Racing (https://bugs.dolphin-emu.org/issues/13136 ).
2023-01-04 10:41:14 -08:00
2fdaf0a86e
HW/ProcessorInterface: Rename member variables to fit naming convention.
2023-01-04 03:17:26 +01:00
74e1577a2c
HW/ProcessorInterface: Refactor to class, move to Core::System.
2023-01-04 03:00:10 +01:00
d91f340c86
VertexManagerBase: Move free space check to after the buffer is reset
...
Fixes incorrect logspam when the buffer needed to be reset on flushes (which we already were doing, but 52feed04dbhttps://bugs.dolphin-emu.org/issues/10312 .
I also converted it to an assert, as if this does happen, things are going to render incorrectly, so we want to make it obvious.
2023-01-03 17:06:51 -08:00
908cec04cb
Merge pull request #11396 from Pokechu22/fbfetch-analytics
...
DolphinAnalytics: Track support of framebuffer fetch
2023-01-03 18:11:17 +01:00
ed9915308b
Merge pull request #11386 from Pokechu22/manual-texture-sampling-stereoscopic-layer-bounds-check
...
PixelShaderGen: Clamp texture layer when using manual texture sampling with stereoscopic 3D
2023-01-03 18:07:06 +01:00
c1b1d8d783
DolphinAnalytics: Track support of framebuffer fetch
2023-01-02 23:17:17 -08:00
c645970578
VideoBackends/OGL: Always check for fbfetch support, not just on GLES
...
GL_EXT_shader_framebuffer_fetch is not restricted to GLES (although GL_ARM_shader_framebuffer_fetch is), and is available on Intel GPUs.
2023-01-02 23:17:08 -08:00
277518837a
DolphinAnalytics: Track support of logic ops
2023-01-02 23:17:02 -08:00
f433da6083
DolphinAnalytics: Fix comment wrapping
...
This was broken in 3570c7f03a
2023-01-02 23:15:04 -08:00
d949aa60bb
Merge pull request #11397 from TellowKrinkle/QuartzMousePos
...
InputCommon:QuartzKB&M: Fix mouse y coordinates
2023-01-02 23:04:12 +01:00
f13f54e3db
Merge pull request #11363 from TheConfuZzledDude/xinput2-scroll-axis
...
InputCommon/XInput2: Added an axis output for the scroll wheel
2023-01-02 23:02:12 +01:00
9d39647f9e
Fix PPC cache code formatting
2023-01-02 02:33:57 -05:00
8659de4d71
InputCommon:QuartzKB&M: Fix mouse y coordinates
...
Cocoa uses a different coordinate system from Carbon (Carbon's origin is the top left while Cocoa's is the bottom left)
2022-12-31 23:42:11 -06:00
20ac2cf781
Merge pull request #11375 from JosJuice/mmu-inf-write
...
PowerPC: Fix theoretically possible infinite loop in WriteToHardware
2022-12-31 18:55:11 +00:00
e31722db1c
Merge pull request #11380 from Pokechu22/performance-sample-window-title
...
AdvancedWidget: Add title for performance sample window tooltip
2022-12-31 18:54:43 +00:00
acdf76bf16
Merge pull request #11374 from JosJuice/jitarm64-breakpoints
...
JitArm64: Implement breakpoints
2022-12-31 18:53:25 +00:00
f6fbeaf355
Merge pull request #11364 from jordan-woyak/udraw-lift
...
WiimoteEmu: Expose mappings for lifted UDraw and Drawsome stylus.
2022-12-29 21:16:57 +01:00
75de461f11
Merge pull request #11393 from JosJuice/android-move-fps
...
Android: Move FPS-related settings to a submenu
2022-12-29 18:16:37 +00:00
a20e41d340
Merge pull request #11389 from Pokechu22/sw-no-alpha-1-hack
...
Software: Remove alpha=1 blending special-case
2022-12-29 13:08:04 -05:00
24d7cf12a5
Android: Move FPS-related settings to a submenu
...
Back when this was just the FPS setting, having it in the top level
of the graphics settings was reasonable. But now it's seven settings.
Let's add a new submenu for them.
2022-12-29 17:34:23 +01:00
c20bb01b47
Merge pull request #11372 from JosJuice/m3u-backslash
...
Boot: Fix handling of M3U file paths containing backslashes
2022-12-29 17:09:38 +01:00
4bc94e4629
Merge pull request #11353 from noahpistilli/fix-mail-account-generation
...
Set checksum for NWC24Config during creation
2022-12-29 17:08:10 +01:00
cb0a603c72
VideoCommon: De-globalize GeometryShaderManager class.
2022-12-29 15:33:19 +01:00
a164c47caf
Core/Boot: Pass System instance to BootUp() and related.
2022-12-29 05:49:26 +01:00
7552deeff4
Merge pull request #11388 from AdmiralCurtiss/globals-vertexshadermanager
...
VideoCommon: De-globalize VertexShaderManager class.
2022-12-29 04:48:24 +00:00
ed5015fa24
Software: Remove alpha=1 blending special-case
...
This was added in #10394 for both the hardware and software backends to work around an issue with Mario Kart Wii, Fortune Street, and Baten Kaitos. However, it seems like the software renderer handles blending well enough that we don't need this (and in any case, it's easy to change blending in the software renderer).
Some experimentation with #11387 (not pushed) showed that the software renderer's logic would also produce correct results on the hardware backends with this hack removed, but would require fbfetch (currently); if a better solution is found the hack can also be removed from the hardware backends.
2022-12-28 14:21:33 -08:00
82e5f438f9
Merge pull request #11219 from K0bin/android-vk-alidation
...
VideoBackends:Vulkan: Migrate to VK_EXT_debug_utils
2022-12-28 14:16:51 -05:00
7e55cc9e90
VideoCommon/VertexShaderManager: Rename private variables.
2022-12-28 16:00:15 +01:00
50625728e0
VideoCommon: De-globalize VertexShaderManager class.
2022-12-28 15:52:29 +01:00
cc768b1ea3
Merge pull request #11357 from t895/elevate-ingame-fragment
...
Android: Elevate ingame menu fragment with color
2022-12-28 10:25:36 +01:00
0900e68986
Merge pull request #11384 from AdmiralCurtiss/globals-pixelshadermanager
...
VideoCommon: De-globalize PixelShaderManager class.
2022-12-28 00:59:03 +00:00
9e9910df8b
Merge pull request #11376 from JosJuice/android-delete-local-ref
...
Android: Make more meticulous use of DeleteLocalRef
2022-12-28 00:57:29 +00:00
b3a368ae06
Android: Add VectorToJObjectArray utility function
2022-12-27 22:59:42 +01:00
f3df3a7727
PixelShaderGen: Clamp texture layer when using manual texture sampling with stereoscopic 3D
...
Otherwise, texelFetch() will use an out-of-bounds layer for game textures (that have 1 layer; EFB copies have 2 layers in stereoscopic 3D mode), which is undefined behavior (often resulting in a black image). The fast texture sampling path uses texture(), which always clamps (see https://www.khronos.org/opengl/wiki/Array_Texture#Access_in_shaders ), so it was unaffected by this difference.
2022-12-27 13:45:13 -08:00
0b9351c194
Android: Make more meticulous use of DeleteLocalRef
...
If we're in a function that isn't just going to immediately return to
Java, leaking local references can lead to problems eventually.
2022-12-27 22:03:44 +01:00
c8202043b6
IOS/NWC24Config: Combine WriteConfig() and WriteCBK().
2022-12-27 21:21:06 +01:00
4549fb4acb
VideoCommon/PixelShaderManager: Rename s_ variables.
2022-12-27 20:20:27 +01:00
725bd64ec2
VideoCommon: De-globalize PixelShaderManager class.
2022-12-27 20:13:24 +01:00
929fba08e7
Fix ESDevice::GetTitlesWithTickets always returning 0 titles owned
2022-12-27 12:18:44 -05:00
19a4653203
VideoBackends:Vulkan: Replace debug_report with debug_utils
...
The former is deprecated and pretty much all modern drivers
support VK_EXT_debug_utils.
Android drivers dont support it. On those drivers,
we use the implementation provided by the validation layers.
2022-12-27 02:48:50 +01:00
c689e9cde0
Netplay: When connecting, ignore packets from traversal server
2022-12-26 23:35:42 +01:00
4e05c569d4
AdvancedWidget: Fix typo in performance sample window tooltip
2022-12-26 14:28:48 -08:00
b675e49c0e
AdvancedWidget: Add title for performance sample window tooltip
2022-12-26 14:20:06 -08:00
6052a5ca9b
Fix Speed Counter Sample Size
2022-12-26 16:47:12 -05:00
288fa635f9
InputCommon/XInput2: Changed axis value reading to be more correct
2022-12-26 17:27:48 +00:00
f4b1155b4d
Merge pull request #11373 from JosJuice/gba-tas-input-turbo
...
DolphinQt: Add settings to GBA TAS input window
2022-12-26 04:37:25 +01:00
4f4285cf5e
WiimoteEmu/DrawsomeTablet: Expose mapping for lifted stylus.
2022-12-25 19:03:15 -06:00
ab9fc3f2e4
WiimoteEmu/UDrawTablet: Expose mapping for lifted stylus.
2022-12-25 19:03:15 -06:00
cf16f49068
PowerPC: Fix theoretically possible infinite loop in WriteToHardware
...
`em_address + size` can overflow and become 0. It shouldn't happen with
the kinds of memory mappings games use in practice, though.
2022-12-25 12:29:13 +01:00
e0fba20f1f
Merge pull request #11360 from shuffle2/vs
...
msvc: remove workaround for arm64 sha1 compiler bug
2022-12-24 22:55:47 +01:00
c744ff4934
JitArm64: Implement breakpoints
...
Plus two miscellaneous debugger features that I found along the way when
reading Jit64's code for comparison: bJITNoBlockLinking and tracing.
Fixes https://bugs.dolphin-emu.org/issues/13127 .
2022-12-24 13:24:01 +01:00
0659827485
Jit64: Check for breakpoint without disabling block link
...
Small optimization. By not calling WriteExit, the block linking system
never finds out about the exit we're doing, saving us from having to
disable block linking.
2022-12-24 13:01:29 +01:00
494b041b34
DolphinQt: Add settings to GBA TAS input window
...
We should expose Enable Controller Input and the turbo settings for
GBA just like we do for GameCube controllers and Wii Remotes.
I just forgot about it when implementing the GBA TAS input window.
2022-12-24 11:30:25 +01:00
582d6b738b
Merge pull request #11358 from t895/close-soft-keyboard
...
Android: Close soft keyboard on panel close
2022-12-24 11:21:56 +01:00
71f1b1db34
Boot: Fix handling of M3U file paths containing backslashes
...
Previously, if a user on Windows launched Dolphin from the command line
and specified a path to an M3U file and included backslashes in this path,
Dolphin would fail to resolve relative paths in the M3U file.
2022-12-24 11:13:27 +01:00
b3bc9c41ea
Merge pull request #11369 from t895/switch-fix
...
Android: Allow users to interact with switches in settings
2022-12-24 09:09:17 +01:00
cf8537576e
Android: Allow users to interact with switches in settings
2022-12-24 02:56:36 -05:00
3611045a6c
DolphinQt: Add more i18n comments
2022-12-24 08:32:49 +01:00
22dd0dbc3c
Android: Upgrade NDK to 25.1.8937393
2022-12-23 21:41:03 -05:00
e1d078ada6
Remove Redundant Access Specifiers
2022-12-23 20:13:01 -05:00
673f81c18a
New FrameTime/VBlank Analyzer + Graph
2022-12-23 19:52:53 -05:00
27d596b89c
InputCommon/Xinput: Cleaned up a bit
2022-12-23 22:35:09 +00:00
c3018fdc3b
InputCommon/XInput2: Added an axis output for the scroll wheel
2022-12-23 22:10:28 +00:00
2345ba178d
Merge pull request #11356 from Sam-Belliveau/update-dear-implot
...
Externals: Add Dear Implot
2022-12-23 22:05:29 +01:00
31bf9d0019
Core: add option to apply memory patch to not store the existing value (used during locking)
2022-12-23 12:31:33 -06:00
190cf5af30
DolphinQt: add multiselection to WatchWidget
2022-12-23 12:31:33 -06:00
c8a6ff6309
DolphinQt: add a 'add to watch' context menu item that allows you to add a memory location found in a cheat search to be added to the watch list
2022-12-23 12:31:33 -06:00
7d7fcdddd3
DolphinQt: add lock state to WatchWidget
2022-12-23 12:31:33 -06:00
8f3e8e4ca3
Core: add locked state to watches
2022-12-23 11:59:23 -06:00
41c9d706cb
DolphinQt: cleanup WatchWidget
2022-12-23 11:59:23 -06:00
3081a781fd
Core: when scheduling an invalidate cpu cache, no need to schedule if we're already on the cpu thread
2022-12-23 11:59:23 -06:00
2f2f906bf5
Core: add ability to add memory patches to the patch engine that will be executed each frame
2022-12-23 03:13:03 -06:00
1f87bcd202
Core: add ability to apply memory patches during a frame update in the PatchEngine
2022-12-23 03:13:03 -06:00
4743d74985
Core: add helper function to apply a memory patch and mark the 'PPCPatches' as final
2022-12-23 03:13:03 -06:00
14179f7565
Follow-up on a four-year-old Android NDK workaround
...
Surely this is fixed by now.
2022-12-22 19:54:46 -06:00
5ca438dd97
Add Dear ImPlot Library
2022-12-22 14:32:42 -05:00
9dcae0b1c3
msvc: remove workaround for arm64 sha1 compiler bug
2022-12-22 00:44:29 -08:00
270d74a324
bump required vs version
2022-12-22 00:43:34 -08:00
05bebee802
Replace BitUtils with C++20: Counting Zeroes
...
With the upgrade to C++20, std::countl_zero and std::countr_zero can replace these home-spun implementations from the BitUtil.h library.
2022-12-21 04:17:00 -06:00
4423afd462
Android: Close soft keyboard on panel close
2022-12-20 17:06:21 -05:00
9c57d6028d
Android: Elevate ingame menu fragment with color
...
Whenever the app is not using the default theme, the ingame menu fragment will be treated as an elevated component like an alert dialog.
2022-12-20 16:39:17 -05:00
d853da3b0b
Merge pull request #11354 from Pokechu22/desert-bus-asnd-ucode
...
DSPHLE: Add Desert Bus libasnd ucode variants
2022-12-20 20:01:21 +01:00
66b3686d84
DSPHLE: Add Desert Bus libasnd ucode variants
2022-12-20 10:02:53 -08:00
5348c8b2c6
Merge pull request #11344 from JosJuice/jitarm64-mw-deps
...
JitArm64: Improve pipelining of lmw/stmw
2022-12-20 15:11:29 +00:00
46bc21291a
Merge pull request #11346 from t895/grid-settings
...
Android: Move game grid options to MainActivity
2022-12-20 15:10:51 +00:00
b59a5c8cf8
Merge pull request #11352 from t895/theme-helper-kt
...
Android: Convert ThemeHelper to Kotlin
2022-12-20 15:04:41 +00:00
43366d2384
Merge pull request #11351 from JosJuice/bitset-cpp20
...
Common: Use C++20 <bit> header in BitSet.h
2022-12-20 15:02:38 +00:00
c01ec96c92
Set checksum for NWC24Config during creation
2022-12-19 20:18:34 -05:00
fb8aa9744e
Merge pull request #11286 from K0bin/vk-query-fix
...
VideoBackends: Query fixes and cleanups
2022-12-19 03:15:48 -05:00
2f5808e7a4
Android: Convert ThemeHelper to Kotlin
2022-12-18 16:54:28 -05:00
547d956278
Common: Use C++20 <bit> header in BitSet.h
2022-12-18 16:51:32 +01:00
9f4d9994bc
Merge pull request #11347 from t895/cheats-background-fix
...
Android: Use colorSurface attribute for cheats activity background
2022-12-18 12:41:15 +01:00
b56411b84b
Fix MemoryViewWidget background colour
2022-12-17 10:37:37 +01:00
6090694eab
Android: Move game grid options to Main/TV Activities
2022-12-17 02:00:48 -05:00
3bfe722c49
Android: Use colorSurface attribute for cheats activity background
2022-12-15 13:32:53 -05:00
a1c4861ad8
Merge pull request #10950 from JosJuice/replace-bitutils-rotate
...
Replace BitUtils with C++20: RotateLeft/RotateRight
2022-12-11 21:19:43 +00:00
aa57d53c90
Merge pull request #11345 from AdmiralCurtiss/globals-pe
...
VideoCommon/PixelEngine: Refactor to class, move to Core::System.
2022-12-11 21:07:30 +00:00
c486baffe6
VideoCommon/PixelEngine: Pass Core::System to methods.
2022-12-11 21:57:30 +01:00
ec8aaf1f30
VideoCommon/PixelEngine: Refactor to class, move to Core::System.
2022-12-11 21:57:19 +01:00
19db7a87a3
Merge pull request #11343 from t895/kotlin-clean
...
Android: Introduce Kotlin support
2022-12-11 20:12:47 +01:00
8226506c84
Android: Introduce Kotlin support
2022-12-11 12:59:58 -05:00
701ba7cd43
JitArm64: Improve pipelining of lmw/stmw
...
The calculation of each address in lmw/stmw currently has a dependency
on the calculation of the previous address. By removing this dependency,
the host CPU should be able to pipeline the loads/stores better. The cost
we pay for this is up to one extra register and one extra MOV instruction
per guest instruction, but often nothing.
Making EmitBackpatchRoutine support using any register as the address
register would let us get rid of the MOV, but I consider that to be too
big of a task to do in one go at the same time as this.
2022-12-11 17:08:12 +01:00
17c14ac4b9
MachineContext: Fix USE_SIGACTION_ON_APPLE on arm64
2022-12-11 13:36:44 +00:00
82e87cf7b9
Merge pull request #9944 from JosJuice/android-nonsquare-buttons
...
Android: Allow non-square overlay control images
2022-12-11 12:10:55 +01:00
454537d53e
Replace BitUtils with C++20: RotateLeft/RotateRight
...
Now that we've flipped the C++20 switch, let's start making use of
the nice new <bit> header.
I'm planning on handling this move away from BitUtils.h incrementally
in a series of PRs. There may be a few functions remaining in
BitUtils.h by the end that C++20 doesn't have any equivalents for.
2022-12-11 08:59:18 +01:00
5f0960ff88
Android: fix compile error
2022-12-11 01:10:30 -04:00
1fd8d476e8
Merge pull request #11325 from t895/extra-dark
...
Android: Add black backgrounds toggle
2022-12-10 21:09:26 +01:00
2b7b3c3942
Merge pull request #11335 from t895/baseline-profile
...
Android: Baseline profile generation
2022-12-10 21:09:18 +01:00
fd7a84b794
Android: Add black backgrounds toggle
...
Makes all background colors black in dark mode when enabled through a ThemeOverlay. Applied the same way as a theme/mode.
2022-12-10 14:53:01 -05:00
932926a4aa
Merge pull request #11329 from t895/elevation-bar
...
Android: Use ElevationOverlay for app bar elevation color
2022-12-10 20:33:56 +01:00
54e01c660e
Merge pull request #11334 from AdmiralCurtiss/globals-fifo
...
VideoCommon/Fifo: Refactor to class, move to Core::System.
2022-12-10 19:13:23 +00:00
128c23dc29
Merge pull request #11336 from t895/material-switch
...
Android: Replace Checkbox with MaterialSwitch
2022-12-10 19:12:07 +00:00
48ce5318e1
Merge pull request #11338 from JosJuice/jitarm64-revert-supposed-tail
...
Revert "JitArm64: Optimize a few tail calls"
2022-12-10 19:11:23 +00:00
c3bed35468
Merge pull request #11337 from JosJuice/aarch64-shrn
...
Arm64Emitter: Fix SHRN/SHRN2
2022-12-10 19:09:33 +00:00
ceae4242fc
VideoCommon/Fifo: Pass Core::System to methods.
2022-12-10 17:16:26 +01:00
5624dd6d39
VideoCommon/Fifo: Refactor to class, move to Core::System.
2022-12-10 17:16:19 +01:00
64bc150b8c
Revert "JitArm64: Optimize a few tail calls"
...
This reverts commit 351d095fff
2022-12-10 11:35:52 +01:00
b5b8871bce
Arm64Emitter: Fix SHRN/SHRN2
...
The "vector shift by immediate" category encodes the shift amount for
right shifts as `size - amount`, whereas left shifts use `amount`.
We're not actually using SHRN/SHRN2 anywhere, which is why this has gone
undetected.
2022-12-10 11:20:23 +01:00
2555e3720b
Android: Replace Checkbox with MaterialSwitch
2022-12-10 00:23:07 -05:00
974003888a
Android: Baseline profile generation
...
This creates a new benchmark module that is responsible for generating baseline profiles and testing them. As part of this commit a baseline-prof.txt file has been included to speed up launch times with the app in its current state. Later, profile generation can be automated and keep up with the app as it changes.
2022-12-09 20:55:10 -05:00
61c10a5644
Merge pull request #11332 from t895/upgrade-dependencies
...
Android: Upgrade dependencies
2022-12-09 22:11:05 +01:00
1d199f4664
Qt/EnhancementsWidget: Combine texture filtering and anisotropic filtering.
2022-12-09 02:02:17 +01:00
ff2cc4d02b
Qt/EnhancementsWidget: Convert texture filtering option to a ComboBox.
2022-12-09 02:02:16 +01:00
8a3b8a925e
Core: Add option to force linear texture filtering.
2022-12-09 02:02:16 +01:00
e97d380437
Implement PPC write-back data cache
2022-12-08 18:18:32 -05:00
c440781ce7
Android: Upgrade dependencies
2022-12-08 14:13:15 -05:00
abf08b5869
Merge pull request #11309 from t895/agp-upgrade
...
Android: Upgrade AGP to 7.3.1
2022-12-08 19:57:59 +01:00
b207611c33
Merge pull request #11274 from TryTwo/PR_Conditional_BP_Add_Memory
...
Debugger: Add conditional breakpoints to memory BPs
2022-12-07 19:55:04 +01:00
000c6c4813
Merge pull request #11321 from JosJuice/jitarm64-accurate-nans
...
JitArm64: Implement accurate NaNs
2022-12-07 00:58:13 +00:00
94faad0d37
Merge pull request #11320 from AdmiralCurtiss/globals-memory
...
HW/Memmap: Refactor Memory to class, move to Core::System.
2022-12-07 00:52:31 +00:00
f2c71a77fe
Android: Use ElevationOverlay for app bar elevation color
2022-12-06 18:41:55 -05:00
2a23aab254
Merge pull request #11327 from t895/settings-animation
...
Android: New settings fragment animations
2022-12-06 22:11:38 +01:00
b9d05c4668
Android: New settings fragment animations
2022-12-06 14:17:04 -05:00
dbfcbcb670
Android: Migrate all strings to strings.xml
2022-12-06 14:11:06 -05:00
a9a603b8cb
Merge pull request #11268 from jordan-woyak/ascii-controller
...
Rename "Keyboard" to "Keyboard Controller"
2022-12-04 21:05:52 +00:00
e9c60f3e65
Android: Have each activity manage insets separately
2022-12-04 13:37:01 -05:00
a17fbe7c65
Expand conditional breakpoints to memory breakpoints
2022-12-04 11:25:33 -07:00
6abcaadd5a
Merge pull request #11314 from t895/menu-cutout-padding
...
Android: Pad menu fragment when expanding to cutout area
2022-12-04 18:59:32 +01:00
b23eb1f550
Merge pull request #11322 from JosJuice/jit64-madds-nan
...
Jit64: Correctly handle NaNs for ps_maddsX
2022-12-04 17:58:16 +00:00
f21edf6d5a
Merge pull request #11270 from t895/theme-mode
...
Android: Add theme mode switcher
2022-12-04 17:56:59 +00:00
3a7ecc851b
Merge pull request #11324 from t895/back-fix
...
Android: Fix cheats layout
2022-12-04 18:51:43 +01:00
2a0939ab98
Android: Pad menu fragment when expanding to cutout area
2022-12-04 12:39:51 -05:00
c60982b248
Android: Fix cheats layout
...
The sliding panel layout was in the way of the top app bar and prevented the up button from being pressed. This anchors the panel to the bottom of the top app bar and removed unnecessary hardcoded padding.
2022-12-04 12:34:36 -05:00
c9f31ad6a6
Merge pull request #11262 from K0bin/present-sync
...
VideoBackends:Vulkan: Synchronize presentation
2022-12-04 14:30:59 +01:00
2b93d5e0d7
Merge pull request #11273 from TryTwo/PR_Conditional_BP_Callstack
...
Debugger: add callstack to conditional breakpoints
2022-12-04 14:16:12 +01:00
2bd47d1435
Merge pull request #11232 from TryTwo/PR_MemoryView_highlighting
...
Debugger MemoryViewWidget: always highlight target address
2022-12-04 14:07:19 +01:00
51dfab6823
Merge pull request #11317 from t895/dialog-adjustment
...
Android: Use progress indicator in short loading scenarios
2022-12-04 09:15:39 +00:00
76bf1b5f7d
Add callstack to conditional breakpoints. Checks entire stack for value.
...
Use: callstack(0x80000000).
!callstack(value) works as a 'does not contain'.
Add strings to expr.h conditionals.
Use quotations: callstack("anim") to check symbols/name.
2022-12-03 20:52:17 -07:00
eeef5363e4
Jit64: Correctly handle NaNs for ps_maddsX
2022-12-03 21:05:05 +01:00
06e60ac327
JitArm64: Implement accurate NaNs
...
For quite some time now, we've had a setting on x86-64 that makes Dolphin
handle NaNs in a more accurate but slower way. There's only one game that
cares about this, Dragon Ball: Revenge of King Piccolo, and what that game
cares about more specifically is that the default NaN (or "generated NaN"
as I believe it's called in PowerPC documentation) is the same as on
PowerPC. On ARM, the default NaN is the same as on PowerPC, so for the
longest time we didn't need to do anything special to get Dragon Ball:
Revenge of King Piccolo working. However, in 93e636a
2022-12-03 19:41:32 +01:00
5c41d3b602
JitArm64: Refactor temp reg handling in fp_arith/ps_arith
2022-12-03 19:08:27 +01:00
839db591d9
HW/Memmap: Refactor Memory to class, move to Core::System.
2022-12-03 13:27:02 +01:00
64733b2504
Android: Use expanding Extended FAB
...
This adds text to the FAB when expanded and shrinks the FAB on scroll. The text will return when scrolling up as well.
2022-12-02 22:12:33 -05:00
af5596720f
Merge pull request #11315 from t895/motion-dialog-fix
...
Android: Greatly simplify MotionAlertDialog theming
2022-12-02 20:55:29 +00:00
6b514e81f9
Merge pull request #11316 from Pokechu22/jit-widget-fixes
...
Jit widget fixes
2022-12-02 20:54:48 +00:00
6a95c565ae
Android: Use progress indicator in short loading scenarios
2022-12-02 15:16:10 -05:00
b9fffa2e66
Android: Add theme mode switcher
...
Similar to app themes, theme modes have to be loaded before directory initialization is ready. So we save the proper key the same way.
2022-12-02 13:31:57 -05:00
3d6bfcd236
JITWidget: Convert to fmt
2022-12-01 17:44:41 -08:00
6a6d24550e
Clean up DisassembleBlock and JitInterface::GetHostCode
2022-12-01 17:43:35 -08:00
5842b90bee
Show JIT blocks widget when selecting 'PPC vs Host' in code widget
...
Before, I just assumed this feature was broken since I didn't know what widget it used. Now, it behaves like show memory and show code elsewhere.
2022-12-01 17:43:35 -08:00
0ccfa31ec8
Fix code widget not becoming visible when selecting 'view code' or similar
...
This affected the memory and registers widgets (and possibly others). I'm pretty sure it regressed in 5f629abd8b
2022-12-01 17:43:35 -08:00
4f4bd57fe9
Fix crash when stopping emulation while the JIT widget is in use
...
The call to analyzer.Analyze breaks when it attempts to read an instruction, as it eventually tries to read memory when Memory::m_pRAM is nullptr. Trying to read when execution is not paused in general seems like a bad idea (especially as analyzer.Analyze uses PowerPC::TryReadInstruction which can update icache - this is probably still a problem).
2022-12-01 17:43:34 -08:00
09e350d9a7
Android: Greatly simplify MotionAlertDialog theming
2022-12-01 18:52:13 -05:00
385dfb60a0
Merge pull request #11313 from t895/inset-fix
...
Android: Letterbox content with display cutouts in landscape
2022-12-01 15:09:31 +00:00
32b4f74d44
Android: Letterbox content with display cutouts in landscape
2022-12-01 01:24:09 -05:00
ffb73f43e1
VideoBackends:Metal: Fix min/max lod when setting non-zero-based samplers
2022-11-30 21:11:37 -06:00
700eca1baa
MemoryViewWidget set target address as selected. Fix focus call. Always color selected item blue.
2022-11-30 16:38:56 -07:00
35a6d16d9e
VideoBackends: Rename query_type to query_group
2022-11-29 23:14:23 +01:00
df2e07ad29
VideoBackends:Vulkan: Fix incorrect barriers in StagingBuffer
...
HOST barriers need to be issued regardless of
whether the memory type is coherent
and we need to properly synchronize writes to the buffer.
2022-11-29 23:14:23 +01:00
57b2ea663e
VideoBackends:D3D12: Set query type
2022-11-29 23:14:23 +01:00
6ba7573877
VideoBackends:Vulkan: Fix queries
...
Fixes both checking whether queries are done
and actually resets query pools.
2022-11-29 23:14:07 +01:00
7cd9a78ebf
Merge pull request #11304 from JosJuice/jit64-nan-c
...
Jit64: Correctly handle NaNs for ps_mulsX/ps_sumX
2022-11-29 12:57:43 +00:00
5f22a0054f
Merge pull request #11305 from JosJuice/jitarm64-optimize-ps-merge
...
JitArm64: Optimize ps_mergeXX
2022-11-29 12:57:10 +00:00
ff830c08b6
Merge pull request #11307 from AdmiralCurtiss/globals-command-processor
...
VideoCommon/CommandProcessor: Refactor to class, move to Core::System.
2022-11-29 12:56:30 +00:00
6941d2e7e6
VideoCommon/CommandProcessor: Refactor to class, move to Core::System.
2022-11-29 08:15:01 +01:00
e3cc42069f
VideoBackends:OGL: Creating vertex formats shouldn't unbind anything
2022-11-28 21:28:24 -06:00
2e63c6c3ee
Android: Upgrade AGP to 7.3.1
2022-11-28 15:52:17 -05:00
2f1a8ee1b9
Jit64: Skip HandleNaNs for operations that can't generate NaN
...
Operations that have two operands and can't generate a default NaN,
i.e. addition and subtraction, already have the desired NaN handling
on x86. We just need to make sure to not reverse the operands.
This fixes ps_sum0/ps_sum1 outputting NaNs in cases where they shouldn't.
(HandleNaNs assumes that a NaN in a ps0 input always results in a NaN in
the ps0 output, and correspondingly for ps1.)
2022-11-27 11:30:10 +01:00
cbceae9176
Jit64: Correctly handle NaNs for ps_mulsX
2022-11-27 11:30:10 +01:00
d3180e3516
Jit64: Refactor HandleNaNs operand passing
2022-11-27 11:30:05 +01:00
44f8b8c100
Merge pull request #11303 from AdmiralCurtiss/coretiming-class
...
CoreTiming: Refactor to class.
2022-11-27 06:00:46 +00:00
64bb9ae9a9
Correctly call CoUninitialize() on Cubeb helper class destruction.
2022-11-27 03:58:50 +01:00
daa70533cd
CoreTiming: Store Globals in CoreTimingManager.
2022-11-27 03:47:12 +01:00
c9558ecb4c
CoreTiming: Refactor to class.
2022-11-27 03:47:12 +01:00
3cdc6e3d4a
Merge pull request #10343 from AdmiralCurtiss/cubeb-2021
...
Update cubeb to mozilla/cubeb@27d2a102b0
2022-11-27 03:26:11 +01:00
f45d3a6a2c
JitArm64: Optimize ps_mergeXX
...
1. In some cases, ps_merge01 can be implemented using one instruction.
2. When we need two instructions for ps_merge01, it's best to start with
a MOV to avoid false dependencies on the destination register.
3. ps_merge10 can be implemented using a single EXT instruction.
2022-11-26 18:14:58 +01:00
e085bf14f9
Core: Use extra thread for Cubeb on Windows to not disturb the CoInitialize state of whatever thread happens to call a Cubeb function.
2022-11-26 05:05:57 +01:00
ca10e92ab9
Core: Abide by COM MTA requirement for cubeb on Windows. Partially based on https://github.com/dolphin-emu/dolphin/pull/8920#discussion_r459746604
...
Co-authored-by: Michael M <mchtly@gmail.com>
2022-11-26 05:05:56 +01:00
59b1419a8e
Externals: Update cubeb to mozilla/cubeb@773f16b7ea and make it a submodule.
...
CMakeLists.txt has been extracted and modified a bit to work with Dolphin's typical build settings.
2022-11-26 05:05:52 +01:00
4273d3754c
CoreTiming: Move static variables into Core::System.
2022-11-26 04:22:32 +01:00
86f17511fc
CoreTiming: Move the 'Globals' instance into Core::System.
2022-11-26 04:22:32 +01:00
70f353fb37
Merge pull request #11283 from AdmiralCurtiss/netplay-save-sync-log
...
Netplay: Add more logging to save syncing.
2022-11-26 03:53:17 +01:00
d189c70d4d
Merge pull request #11230 from AdmiralCurtiss/gci-filenames
...
GCMemcardDirectory: GCI filename cleanup and fixes.
2022-11-26 03:52:43 +01:00
dd2282324b
Debugger BreakpointWidget: Allow editing breakpoints
2022-11-26 03:38:25 +01:00
72eadc6520
InputCommon:SDL: Add SDL 2.26 left and right motion inputs
2022-11-24 15:12:07 -06:00
7be4c90f67
Merge pull request #11166 from AdmiralCurtiss/mmio-system
...
HW: Pass System to MMIO handlers.
2022-11-24 00:58:45 +00:00
d6437b7e46
Merge pull request #11123 from Pokechu22/fmt-9.1.0
...
Externals: Update fmt to 9.1.0
2022-11-23 22:40:03 +00:00
f5d11c1e38
VideoBackends/D3D11: Simplify vertex attribute code
2022-11-23 13:45:43 -08:00
cc5640245c
Fix build errors related to formatting non-scoped enums
2022-11-23 13:45:43 -08:00
ddf63bacb9
Merge pull request #11296 from t895/tv-game-details-fix
...
Android: Fix GameDetailsDialog on leanback
2022-11-23 22:06:49 +01:00
545fee9c94
Core/CommandProcessor: Reformat single/dual core dependent MMIO handlers.
2022-11-23 21:58:18 +01:00
0a6fdb9c13
HW: Pass System to MMIO handlers.
2022-11-23 05:52:21 +01:00
0ef6d30a0d
Merge pull request #11165 from AdmiralCurtiss/audiocommon-pass-system
...
AudioCommon: Pass Core::System to AudioCommon functions.
2022-11-23 04:49:31 +00:00
a47ed2124f
Merge pull request #11253 from AdmiralCurtiss/core-timing-events-pass-system
...
CoreTiming: Pass Core::System to Events.
2022-11-23 04:46:11 +00:00
677121bdbc
Merge pull request #11292 from JosJuice/jit64-imm-ra-update
...
Jit64: Use MOV instead of ADD for updating imm Ra
2022-11-23 04:42:46 +00:00
e573a0bbc2
Merge pull request #11294 from JosJuice/jitarm64-movpage2r
...
Arm64Emitter: Add MOVPage2R utility function
2022-11-23 04:41:31 +00:00
cb232155d9
Merge pull request #11298 from Pokechu22/vertexloader-no-DataReader
...
VertexLoader: Eliminate use of DataReader
2022-11-23 04:40:53 +00:00
e13094766d
Fix VertexLoader.cpp using the wrong size for texture matrix indices without a corresponding texture
...
This regressed in 0a906f553f
2022-11-22 17:49:54 -08:00
0bcd3c79bb
VertexLoader: Eliminate use of DataReader
...
DataReader is generally jank - it has a start and end pointer, but the end pointer is generally not used, and all of the vertex loaders mostly bypassed it anyways.
Wrapper code (the vertex loaer test, as well as Fifo.cpp and OpcodeDecoding.cpp) still uses it, as does the software vertex loader (which is not a subclass of VertexLoader). These can probably be eliminated later.
2022-11-22 17:17:11 -08:00
edb2c90b38
Improve FPS/VPS Counting and Revamp Appearance
2022-11-23 00:11:47 +01:00
5e442f6ffa
Merge pull request #11281 from AdmiralCurtiss/updater-admin-check
...
Updater: Check for write permissions in directory of Updater.exe.
2022-11-22 23:50:13 +01:00
19b6251a3c
Merge pull request #11291 from JosJuice/gba-tas-input
...
DolphinQt: Add GBA TAS input window
2022-11-22 23:49:43 +01:00
132bf6550f
Merge pull request #11236 from AdmiralCurtiss/gci-path-config
...
Add config setting for base GCI folder path.
2022-11-22 23:48:46 +01:00
6e5f546d4e
Android: Fix GameDetailsDialog on leanback
...
Previously the app would crash because Material Dividers inherit from AppCompat and the leanback activity does not. This creates a new layout file with leanback-specific accommodations and code is duplicated in GameDetailsDialog to prevent inflation crashes.
2022-11-22 15:56:15 -05:00
e67788571a
Android: Fix condition where we set grid span too early
2022-11-22 15:19:15 -05:00
81557f611a
Qt/GameCubePane: Display a warning if a GCI folder override is set.
2022-11-22 17:53:20 +01:00
c18d6c3deb
Config: Use JPN for custom GCI folder paths.
2022-11-22 17:53:20 +01:00
86d01c3399
Config: Add option to use JPN as the Japanese region directory in GetDirectoryForRegion().
...
See https://bugs.dolphin-emu.org/issues/13076 for motivation for this.
2022-11-22 17:53:19 +01:00
1089d3cab6
GCMemcardDirectory: Compare GCI files in GetFileNamesForGameID() by their identity instead of their default filename.
2022-11-22 10:54:11 +01:00
4b0312ecf8
GCMemcardDirectory: Decode and strip strings for GCI filenames.
2022-11-22 10:54:11 +01:00
c517e92719
GCMemcardDirectory: Use HasSameIdentity() in LoadGCI().
...
This is cheaper and more accurate than comparing default GCI filenames.
2022-11-22 10:54:11 +01:00
b31b2db5fa
GCMemcard: Remove unused methods.
2022-11-22 10:54:10 +01:00
2132e005c3
Core: Add config setting for base GCI folder path.
2022-11-22 10:48:37 +01:00
5ebb894685
Updater: Delete the file we check for write rights with on Windows.
2022-11-22 02:38:42 +01:00
f0fb8c22b0
Updater: Check for write permissions in directory of Updater.exe.
2022-11-22 01:28:02 +01:00
8f5a58f8be
Merge pull request #11285 from K0bin/cp-checks
...
VideoCommon:VertexLoaderManager: Reduce CPConfig checks
2022-11-21 15:35:06 -08:00
d64c3dc267
Arm64Emitter: Add MOVPage2R utility function
...
This new function is like MOVP2R, except it masks out the lower 12 bits,
returning them instead of writing them to the register. These lower
12 bits can then be used as an offset for LDR/STR. This lets us turn
ADRP+ADD+LDR sequences with a zero offset into ADRP+LDR sequences with
a non-zero offset, saving one instruction.
2022-11-21 23:24:06 +01:00
40571cf13c
DolphinQt: Add GBA TAS input window
...
When emulated GBAs were added to Dolphin, it was possible to control them
using the GC TAS input window. (Z was mapped to Select.) Unaware of this,
I broke the functionality in b296248
2022-11-21 19:16:30 +01:00
22bcf134bf
Merge pull request #11139 from JosJuice/jit64-nans-no-freg
...
Jit64: Don't use fregsIn in HandleNaNs
2022-11-20 13:47:02 -05:00
4b6bad2f9e
Jit64: Use MOV instead of ADD for updating imm Ra
...
The old code would first MOV the old imm into Ra and then do an ADD.
We can skip the ADD and just MOV the new imm.
2022-11-20 10:50:25 +01:00
5d03577189
Memmap: Fix initialization of PhysicalMemoryRegion.
2022-11-18 06:57:54 +01:00
f179fd9c33
VideoCommon:VertexLoaderManager: Reduce CPConfig checks
...
A bit of a micro optimization:
CheckCPConfiguration is called 350 times instead of 35k times.
2022-11-18 01:42:30 +01:00
f1c9774159
Merge pull request #11240 from noahpistilli/es_v1_ticket
...
IOS/ES: Add support for V1Ticket
2022-11-18 00:25:47 +01:00
2fd9852ca8
IOS/ES: Add support for V1Ticket
2022-11-17 17:54:06 -05:00
275e9e3a58
Android: Adjust card_width
2022-11-16 15:33:38 -05:00
9766238649
Merge pull request #11267 from t895/smooth-keyboard
...
Android: Use smooth keyboard animation in cheats activity
2022-11-16 20:48:20 +01:00
cecd4d15fe
Merge pull request #11254 from t895/adaptive-grid
...
Android: Dynamically adapt grid span to card_game size
2022-11-16 20:47:59 +01:00
7ce2be9386
Merge pull request #11256 from t895/animate-focus-change
...
Android: Animate covers on focus change
2022-11-16 20:47:16 +01:00
f0b0fcbb95
Netplay: Add more logging to save syncing.
2022-11-16 04:00:43 +01:00
99a918d884
Merge pull request #11280 from Pokechu22/efb-cache-cleanup
...
VideoCommon/FramebufferManager: Further EFB cache cleanup
2022-11-16 02:22:53 +01:00
43e90ca023
Merge pull request #11105 from vpelletier/si_ignore_setGameId
...
SI: Ignore non-standard setGameID command
2022-11-16 02:08:39 +01:00
1fdf15a1be
VideoCommon/FramebufferManager: Rename m_efb_cache_tiles_wide to m_efb_cache_tile_row_stride
...
This also initializes it in the non-tiled case just for consistency, although it's not actually read in that case.
2022-11-15 16:04:41 -08:00
55e1c3b51d
VideoCommon/FramebufferManager: use !IsUsingTiledEFBCache() in GetEFBCacheTileRect
...
This is for readability only, and should behave identically.
2022-11-15 15:48:56 -08:00
90d05fe37e
VideoCommon/FramebufferManager: Always update frame access mask on depth peeks
...
0e02ddcf52
2022-11-15 15:34:03 -08:00
8a1c28be63
Merge pull request #11172 from K0bin/efb-refresh
...
VideoCommon:FramebufferManager: Mark cache as valid after refresh
2022-11-15 16:33:46 -05:00
d7593dd721
Merge pull request #11243 from Sintendo/arm64mul
...
JitArm64: Optimize multiplication
2022-11-15 04:05:49 +01:00
c9e74801ed
Merge pull request #11269 from vabold/dolphindevice-get-time
...
Add DolphinDevice::GetSystemTime to allow for accurate Unix timestamp generation
2022-11-15 03:48:57 +01:00
6c9b9cbf95
Merge pull request #11255 from JosJuice/disable-sd-convert
...
Disable SD card conversion while emulation is running
2022-11-15 03:44:49 +01:00
09c0321997
Merge pull request #11184 from Lobsterzelda/save-all-nand-files-to-save-state
...
HostFileSystem: Set all NAND folders to be saved in save states
2022-11-15 03:42:26 +01:00
b6503d7585
Merge pull request #11018 from Dentomologist/add_updater_error_messages
...
Add updater error messages
2022-11-15 01:08:55 +01:00
5bdb291d90
Qt/Updater: Remove unused member variable.
2022-11-15 00:56:08 +01:00
f05b0ad669
Merge pull request #11271 from jordan-woyak/mapping-button-expanding
...
DolphinQt: Allow mapping buttons to expand horizontally.
2022-11-15 00:53:02 +01:00
eb060c7356
Android: Dynamically adapt grid span to card_game size
...
In order to avoid getting stuck making a new dimension file every time a new device is found we take a known value for how large the game card will be, take the screen size, and adjust the grid accordingly.
2022-11-13 15:49:29 -05:00
f614f94568
Merge pull request #11272 from t895/tv-update-fix
...
Android: Use progress bar that does not inherit from AppCompat on leanback
2022-11-13 21:01:56 +01:00
2e978ad428
Android: Use progress bar that does not inherit from AppCompat on leanback
2022-11-13 12:25:47 -05:00
2340a7eea6
Merge pull request #11248 from t895/offload-unmangle
...
Android: Offload cover path unmangling to another thread
2022-11-13 14:59:00 +01:00
1e80bcbd57
Merge pull request #11265 from t895/dialog-ripple-color
...
Android: Change alert dialog button ripple color for default theme
2022-11-13 09:16:06 +01:00
2a81fa6c26
Merge pull request #11015 from TryTwo/Conditional_Breakpoints
...
Conditional breakpoints
2022-11-13 01:06:52 +01:00
083b8172e0
Replace `std::time` with `std::chrono::system_clock`
2022-11-12 05:36:49 -05:00
ff1c71cc38
Fix inaccurate function name, add old function
2022-11-12 05:36:49 -05:00
6044bc32a8
DolphinQt: Allow mapping buttons to expand horizontally.
2022-11-11 23:14:03 -06:00
e9af3d945a
DolphinQt: Rename "Keyboard" to "Keyboard Controller" and add warning text.
2022-11-11 22:26:35 -06:00
f28e5607fe
Merge pull request #11263 from tellowkrinkle/NoMipsOption
...
VideoCommon: Add option to disable mipmaps
2022-11-11 17:55:45 +01:00
296959ec58
GCKeyboardEmu: Eliminate unused Options group.
2022-11-11 01:59:09 -06:00
8bfa08fa0e
Android: Use smooth keyboard animation in cheats activity
2022-11-11 00:53:59 -05:00
8a46404329
Android: Change system update dialog title/message when cancelling
2022-11-10 22:46:41 -05:00
4b622ef4d0
Android: Change alert dialog button ripple color for default theme
2022-11-10 21:58:11 -05:00
ed54e1905a
HostFileSystem: Set all NAND folders to be saved in save states when a movie is active
2022-11-10 14:02:29 -05:00
37a51f1d09
VideoCommon: Add an option to disable mipmaps
...
Needed by M1 fifoci to work around a minor non-determinism bug
2022-11-07 22:18:56 -06:00
dca51f3ab0
Merge pull request #11260 from t895/text-alignment
...
Android: Fix list_item_cheat text
2022-11-07 18:52:27 +01:00
3beb22ed7f
VideoBackends:Vulkan: Synchronize presentation
...
Synchronize with the submission thread
if the last present is not done yet.
2022-11-07 02:20:22 +01:00
e79a4b0d8c
Android: Fix list_item_cheat text
...
Sometimes a gecko code would have a title long enough to appear over the checkbox. This is now prevented by marking the text's boundary a 16dp before the start of the checkbox.
2022-11-06 17:30:07 -05:00
60fb151581
Android: Animate covers on focus change
...
Co-Authored-By: JosJuice <josjuice@gmail.com>
2022-11-06 15:52:19 -05:00
a98df18947
VideoCommon: Hold ImGui lock while initializing and shutting down ImGui.
2022-11-06 21:48:55 +01:00
e37aa3ed90
RenderWidget: Fix random crash due to missing ImGui context
...
`ImGui::GetIO` performs an assertion that a context exists, and if one doesn't then things will likely crash. Unfortunately this crash is hard to consistently reproduce.
2022-11-06 21:41:07 +01:00
c931529e7a
Merge pull request #11225 from iwubcode/graphics-mod-textureload-callable
...
VideoCommon: call texture load graphics mod hook when textures are loaded
2022-11-06 18:58:51 +01:00
1348337277
Merge pull request #11246 from tellowkrinkle/PVDMemset
...
VideoCommon: Zero PortableVertexDeclarations on initialization
2022-11-06 18:54:21 +01:00
c75b53c7ed
Merge pull request #11250 from AdmiralCurtiss/memory-widget-menu
...
MemoryWidget: Split Actions into Import and Export.
2022-11-06 18:50:02 +01:00
982afec040
Android: Disable SD card conversion while emulation is running
2022-11-06 18:27:04 +01:00
a36a5c1308
CoreTiming: Pass Core::System to Events.
2022-11-06 17:54:58 +01:00
de93b4dc13
DolphinQt: Disable SD card conversion while emulation is running
2022-11-06 17:48:55 +01:00
ff38fef2e4
Android: Use FrameLayout as root for notouch emulation layout
...
When inflating this layout, the layout inflater doesn't expect a View and rather a descendant of ViewGroup. This resulted in a crash which is resolved by using a FrameLayout instead.
2022-11-06 01:51:12 -05:00
db679ab620
Merge pull request #11249 from JosJuice/load-dol-elf-after-mem
...
Boot: Load DOL/ELF after memory setup
2022-11-06 05:40:54 +01:00
e1f5eb3d8d
Merge pull request #11233 from AdmiralCurtiss/netplay-split-save-sync-function
...
NetPlay: Split SyncSaveData() into two parts.
2022-11-06 05:39:26 +01:00
1c63349984
AudioCommon: Pass Core::System to AudioCommon functions.
2022-11-06 02:13:58 +01:00
e9caa09f7b
NetPlay: Split SyncSaveData() into two parts.
...
This allows the 'save collection' part to run even if no clients are connected. Fixes issue 13095.
2022-11-06 01:51:01 +01:00
cf533df814
MemoryWidget: Split Actions into Import and Export.
2022-11-05 23:05:15 +01:00
89bc1649e3
Merge pull request #11111 from TryTwo/PR_MemoryView_TableUpdates
...
MemoryViewWidget refactor memory table
2022-11-05 22:59:44 +01:00
fb916a4c33
Boot: Load DOL/ELF after memory setup
...
I recently talked to a homebrew developer who was trying to add exception
handlers at link time but found out that Dolphin was overwriting their
exception handlers. I figure that's not the usual way to do exception
handlers, but... making us load the executable after setting up memory
rather than before is easy, and matches what we do when booting discs,
so I suppose there's no reason not to do it. It also matches the intent
of why Dolphin is writing default exception handlers – we're writing
them because some homebrew relies on exception handlers being left
around from whatever program was running before it (see 3dd777be70
2022-11-05 13:55:17 +01:00
d9ed9ae331
VideoCommon: Zero PortableVertexDeclarations on initialization
...
Fixes an issue where the default initializer wouldn't initialize padding, making for fun non-determinism
2022-11-05 02:02:53 -05:00
431301add3
Merge pull request #10771 from TryTwo/PR_AutoStep
...
Debugger: Implement base code tracing logic. and feature to auto-step through code.
2022-11-04 23:32:54 +01:00
26b68f1f84
Merge pull request #11228 from Pokechu22/statistics-macros
...
VideoCommon/Statistics: Require semicolons after statistics macros
2022-11-04 23:15:52 +01:00
8b4e315fb7
Merge pull request #11242 from Sintendo/arm64cmp
...
JitArm64: Optimize cmp
2022-11-04 23:13:09 +01:00
6eb5013359
Android: Offload cover path unmangling to another thread
2022-11-04 14:28:21 -04:00
0e02ddcf52
VideoCommon:FramebufferManager: Cleanup
2022-11-04 01:18:23 +01:00
371935d61e
VideoCommon:FramebufferManager: Mark cache as valid after refresh
...
Otherwise we might never hit the early return
if either depth or color doesnt have any active
tiles.
2022-11-04 01:18:23 +01:00
83ca1ad8a6
VideoBackends:Metal: Headless render support
2022-11-03 02:35:24 -05:00
1d07332657
Merge pull request #11193 from jordan-woyak/ciface-input-backend-interface
...
ControllerInterface: Add InputBackend interface.
2022-11-03 04:42:05 +01:00
274e34ddf1
JitArm64: MultiplyImmediate - Handle -(2^n) + 1
...
Let's take advantage of ARM64's input register shifting one last time,
shall we?
Before:
0x1280005b mov w27, #-0x3
0x1b1b7f18 mul w24, w24, w27
After:
0x4b180b18 sub w24, w24, w24, lsl #2
2022-11-02 21:53:19 +01:00
7073a135c6
JitArm64: MultiplyImmediate - Handle -(2^n)
...
ARM64's flexible shifting of input registers also allows us to calculate
a negative power of two in one instruction; shift the input of a NEG
instruction.
Before:
0x128001f7 mov w23, #-0x10
0x1b1a7efa mul w26, w23, w26
0x93407f58 sxtw x24, w26
After:
0x4b1a13fa neg w26, w26, lsl #4
0x93407f58 sxtw x24, w26
2022-11-02 21:53:19 +01:00
1c87f040a3
JitArm64: mulli - Only allocate reg when necessary
...
If the destination register doesn't equal the input register, using it
to temporarily hold the immediate value is fair game as it'll be
overwritten with the result of the multiplication anyway. This can
slightly reduce register pressure.
Before:
0x52800659 mov w25, #0x32
0x1b197f5b mul w27, w26, w25
After:
0x5280065b mov w27, #0x32
0x1b1b7f5b mul w27, w26, w27
2022-11-02 21:53:19 +01:00
20dd5cadab
JitArm64: MultiplyImmediate - Add comments
2022-11-02 21:53:17 +01:00
c349875cdc
JitArm64: MultiplyImmediate - Handle 2^n + 1
...
By taking advantage of ARM64's ability to shift an input register by any
amount, we can calculate multiplication by a number that is one more
than a power of two with a single instruction.
Before:
0x52800838 mov w24, #0x41
0x1b187f7b mul w27, w27, w24
After:
0x0b1b1b7b add w27, w27, w27, lsl #6
2022-11-02 21:52:44 +01:00
3aaf1a2b8b
JitArm64: MultiplyImmediate - Handle 2^n
...
Turn multiplications by a power of two into bitshifts.
Before:
0x52800817 mov w23, #0x40
0x1b167ef6 mul w22, w23, w22
After:
0x531a66d6 lsl w22, w22, #6
2022-11-02 21:52:37 +01:00
0210d115c2
Merge pull request #11227 from JosJuice/jitarm64-mmio-clobber
...
JitArm64: Move MMIO handler result before popping stack
2022-11-02 10:19:22 +01:00
168a49c87f
ControllerInterface: DSU InputBackend implementation.
2022-11-01 21:59:09 -05:00
2e5cd5d519
ControllerInterface: evdev InputBackend implementation.
2022-11-01 21:59:08 -05:00
44a4573303
ControllerInterface: Add InputBackend interface and SDL implementation.
2022-11-01 21:59:08 -05:00
f25611f388
JitArm64: MultiplyImmediate - Handle 1
...
Multiplication by one is also trivial. Depending on the registers
involved, either a single MOV or no instructions will be generated.
Before:
0x52800038 mov w24, #0x1
0x1b1a7f1b mul w27, w24, w26
After:
0x2a1a03fb mov w27, w26
Before:
0x52800039 mov w25, #0x1
0x1b1a7f3a mul w26, w25, w26
After:
Nothing!
2022-11-01 21:13:45 +01:00
51cb918aa5
JitArm64: MultiplyImmediate - Handle 0
...
Multiplication by zero always gives zero.
Before:
0x52800019 mov w25, #0x0
0x1b197f5b mul w27, w26, w25
After:
Nothing!
2022-11-01 21:13:38 +01:00
080513284c
JitArm64: mullwx - Use MultiplyImmediate
2022-11-01 19:05:33 +01:00
53a8cd1563
JitArm64: mulli - Use MultiplyImmediate
2022-11-01 19:04:50 +01:00
4aa0c0133a
JitArm64: Introduce MultiplyImmediate
...
Add a new function that will handle all the special cases regarding
multiplication. It does nothing for now, but will be expanded in
follow-up commits.
2022-11-01 19:01:38 +01:00
dc046a2470
Merge pull request #11237 from t895/grid-fix
...
Android: Add more game grid sizes for long displays
2022-11-01 19:00:53 +01:00
d0de68c41b
JitArm64: cmp - Optimize general case
...
We can merge an SXTW with the SUB, eliminating one instruction. In
addition, it is no longer necessary to allocate a temporary register,
reducing register pressure.
Before:
0x93407f59 sxtw x25, w26
0x93407ebb sxtw x27, w21
0xcb1b033b sub x27, x25, x27
After:
0x93407f5b sxtw x27, w26
0xcb35c37b sub x27, x27, w21, sxtw
2022-11-01 12:21:24 +01:00
ae6ce1df48
Arm64Emitter: Add ArithOption with ExtendSpecifier
...
ARM64 can do perform various types of sign and zero extension on a
register value before using it. The Arm64Emitter already had support for
this, but it was kinda hidden away.
This commit exposes the functionality by making the ExtendSpecifier enum
available everywhere and adding a new ArithOption constructor.
2022-11-01 12:15:56 +01:00
82f22cdfa1
JitArm64: cmp - Optimize a == -1 case
...
By explicitly handling this, we can avoid materializing -1 in a
register and generate more efficient code by taking advantage of -x ==
~x + 1.
Before:
0x12800015 mov w21, #-0x1
0x93407eb9 sxtw x25, w21
0x93407ef8 sxtw x24, w23
0xcb180338 sub x24, x25, x24
After:
0x2a3703f8 mvn w24, w23
0x93407f18 sxtw x24, w24
2022-11-01 12:00:32 +01:00
592ba31e22
JitArm64: cmp - Optimize a == 0 case
...
By explicitly handling this, we can avoid materializing zero in a
register and generate more efficient code altogether.
Before:
0x52800016 mov w22, #0x0
0xb94093b5 ldr w21, [x29, #0x90]
0x93407ed7 sxtw x23, w22
0x93407eb9 sxtw x25, w21
0xcb1902f9 sub x25, x23, x25
After:
0xb94093b7 ldr w23, [x29, #0x90]
0x4b1703f9 neg w25, w23
0x93407f39 sxtw x25, w25
2022-11-01 11:52:00 +01:00
f5e7e70cc5
JitArm64: cmp - Refactor
2022-11-01 11:47:17 +01:00
dbb8f588c7
JitArm64: cmpl - Optimize a == 0 case
...
By explicitly handling this, we can avoid materializing zero in a
register.
Before:
0x52800019 mov w25, #0x0
0xb94087b6 ldr w22, [x29, #0x84]
0xcb16033b sub x27, x25, x22
After:
0xb94087b9 ldr w25, [x29, #0x84]
0xcb1903fb neg x27, x25
2022-11-01 11:27:45 +01:00
7cd08fde75
Updater: Add/clarify error messages
2022-10-31 23:36:07 -07:00
2808db7f2f
FileUtil: Return success bool from CopyDir
2022-10-31 23:33:02 -07:00
111e965c7e
Revert "MacUpdater: test that os version check is working"
2022-10-31 18:53:22 -07:00
b182abe0ae
Merge pull request #11234 from shuffle2/updater
...
MacUpdater: test that os version check is working
2022-11-01 01:28:20 +00:00
22eb7e6645
OGL: use already known object label lengths
...
Passing -1 means the driver has to call strlen().
2022-11-01 01:10:03 +00:00
4b8fe959d4
OGL: fix compute shader labels
...
This fixes GL_INVALID_VALUE errors when using GPU texture decoding.
2022-11-01 01:04:46 +00:00
f5fecaf964
VideoBackends:Vulkan: Fix 0 size descriptor pools
...
[ VUID-VkDescriptorPoolCreateInfo-maxSets-00301 ] Object 0:
handle = 0x7f1,b8d,3cd,e70, type = VK_OBJECT_TYPE_DEVICE; |
MessageID = 0xa1,70e,236 | vkCreateDescriptorPool():
pCreateInfo->maxSets is not greater than 0.
The Vulkan spec states: maxSets must be greater than 0
2022-10-31 22:41:16 +01:00
349b16aa55
Android: Add more game grid sizes for long displays
2022-10-31 13:11:17 -04:00
7cc8e37aee
MacUpdater: test that os version check is working
...
Adds a key to Info.plist with default value to test
Updater - this commit is intended to be reverted
2022-10-30 13:19:43 -07:00
969309c457
Merge pull request #11220 from shuffle2/macversion
...
MacUpdater: check os version
2022-10-30 15:19:55 -04:00
089886a6f8
MacUpdater: check os version
2022-10-30 12:04:57 -07:00
f277a921a9
Merge pull request #11231 from shuffle2/updater
...
windows: Rename: use std::filesystem::rename for posix behavior
2022-10-30 13:32:10 -04:00
950e1f94dc
Merge pull request #11185 from TryTwo/PR_MemoryWidget_Address_Input_History
...
MemoryWidget: Make search address a combobox that holds address history.
2022-10-30 04:21:14 -04:00
053320b7cf
MemoryWidget: Make search address a combobox that holds address history.
...
Always update the combobox when a new target address is sent.
2022-10-29 22:41:30 -07:00
68875dc06b
MacUpdater: add version info to Updater.app too
2022-10-29 20:32:59 -07:00
836bc74b2d
windows: Rename: use std::filesystem::rename for posix behavior
2022-10-29 19:57:26 -07:00
fe559f3ed3
VideoCommon/Statistics: Require semicolons after statistics macros
...
This is clearer and reduces IntelliSense problems.
2022-10-29 15:39:41 -07:00
0628794cb6
Merge pull request #11226 from K0bin/d3d12-fix
...
VideoBackends:D3D12: Fix hang in Twilight Princess
2022-10-30 00:24:16 +02:00
a07ee729e5
VideoBackends:D3D12: Defer binding framebuffer in SetAndDiscardFramebuffer
...
BindFramebuffer depends on the pipeline which might not be set yet.
That's why the framebuffer dirty flag exists in the first place.
I assume BindFramebuffer was called directly here, in order to handle
the texture state transitions necessary for DiscardResource.
The state is tracked anyway, so we can just issue those transitions there
too and defer binding the actual framebuffer.
Fixes an issue in Zelda Twilight Princess with EFB depth peeks.
Dolphin would bind a frame buffer which doesn't have an integer format
descriptor for the color target before binding the new pipeline.
So it would accidentally use the 0 descriptor.
Debug layer error:
D3D12 ERROR: ID3D12CommandList::OMSetRenderTargets:
Specified CPU descriptor handle ptr=0x0000000000000000 does not refer to
a location in a descriptor heap. pRenderTargetDescriptors[0] is the issue.
[ EXECUTION ERROR #646 : INVALID_DESCRIPTOR_HANDLE]
2022-10-29 23:41:32 +02:00
a6aa651291
VideoBackends:D3D12: Use COMMON as initial state for default heap buffer
...
Fixes the following error in the D3D12 debug layer:
D3D12 WARNING: ID3D12Device::CreateCommittedResource:
Ignoring InitialState D3D12_RESOURCE_STATE_UNORDERED_ACCESS.
Buffers are effectively created in state D3D12_RESOURCE_STATE_COMMON.
[ STATE_CREATION WARNING #1328 : CREATERESOURCE_STATE_IGNORED]
2022-10-29 23:39:32 +02:00
22fecb41fc
VideoBackends:D3D12: Don't query GPU descriptor handle for non-shader visible heap
...
Fixes the following error in the D3D12 debug layer:
D3D12 ERROR: ID3D12DescriptorHeap::GetGPUDescriptorHandleForHeapStart:
GetGPUDescriptorHandleForHeapStart is invalid to call on a descriptor
heap that does not have DESCRIPTOR_HEAP_FLAG_SHADER_VISIBLE set.
If the heap is not supposed to be shader visible, then
GetCPUDescriptorHandleForHeapStart would be the appropriate method
to call. That call is valid both for shader visible and non shader
visible descriptor heaps.
[ STATE_GETTING ERROR #1315 : DESCRIPTOR_HEAP_NOT_SHADER_VISIBLE]
2022-10-29 23:39:27 +02:00
cacdd18ca0
VolumeVerifier: fix bogus "serial/version missing" error
...
When searching for a disc where the revision doesn't match any disc in
the datfile, the loop would never get to the part where serials_exist is
set to true, leading to a bogus error message.
2022-10-29 21:32:57 +01:00
6dcf8a6fc9
Merge pull request #11201 from JoshuaMKW/fix-instruction-patches
...
MemoryPatches: Fix instruction patches
2022-10-29 12:34:00 -07:00
aeb0fcb8ab
Merge pull request #11092 from t895/view-binding
...
Android: Use view binding
2022-10-29 17:20:08 +02:00
5c30f65bbb
Android: Use view binding
2022-10-29 11:05:09 -04:00
7d55e9f9c7
Merge pull request #11202 from t895/androidx-prefs
...
Android: Use androidx preference manager
2022-10-29 16:08:48 +02:00
431ee1c48a
JitArm64: Improve register handling for MMIO loadstores
...
Because of the previous commit, `regs_in_use` must not include `dest_reg`
when calling MMIOLoadToReg. There are also some other registers we can
skip including in regs_in_use just for efficiency's sake.
The `addr_reg_set = false` statements that I've added in this commit are
technically redundant – if `mmio_address` is non-zero then `addr_reg_set`
is already false – but it's just a coincidence that that's the case.
2022-10-29 14:16:53 +02:00
Charles Lombardo