Remove Memory Card Path from the Wrote OSD Message

A few weeks ago, a vtuber tweeted that they had to remove a vod of their stream because Dolphin Emulator showed some personal information during the steam, and left a warning to everyone else that Dolphin shows the account name of the computer. And yea, we do, we show the full directory of the memory card every time a memory card is written, and due to mandatory Microsoft account nonsense, that is very likely to contain someone’s real name.

Fortunately this is very easy for us to solve. This change simply removes the filename from wrote memory card contents string. That’s it. All functionality of the wrote memory card OSD message remains the same, it just doesn’t say where the memory card is anymore.

There are lots of other potential solutions to this but after talking on IRC it seems the simplest one is the best.

Source/Core/Core/HW/GCMemcard/GCMemcardRaw.cpp

@@ -156,9 +156,8 @@ void MemoryCard::FlushThread()
     if (do_exit)
       return;
 
-    Core::DisplayMessage(fmt::format("Wrote memory card {} contents to {}",
-                                     m_card_slot == ExpansionInterface::Slot::A ? 'A' : 'B',
-                                     m_filename),
+    Core::DisplayMessage(fmt::format("Wrote to Memory Card {}",
+                                     m_card_slot == ExpansionInterface::Slot::A ? 'A' : 'B'),
                          4000);
   }
 }