JMC47
8a1cac9be1
Merge pull request #11348 from Sam-Belliveau/improved-pacing
...
CoreTiming: Throttle Before Every Event Using std::chrono
2023-01-13 21:52:07 -05:00
Sam Belliveau
e849172dc9
Limit Throttling to 1200hz
2023-01-13 18:17:24 -05:00
Sam Belliveau
e95c1d55e8
Limit Sleep Calls to 8192hz at most
2023-01-13 11:59:32 -05:00
Shawn Hoffman
d51e4e5236
get rid of HAS_STD_FILESYSTEM
...
just use std::filesystem
2023-01-10 05:17:43 -08:00
Admiral H. Curtiss
653e0ccf28
Merge pull request #11365 from iwubcode/cheat_manager_freeze_value
...
DolphinQt: add ability to lock / freeze values in the watches window
2023-01-09 18:41:28 +01:00
Admiral H. Curtiss
993d2ab173
PatchEngine: Use std::span in ApplyMemoryPatches().
2023-01-09 17:24:41 +01:00
Admiral H. Curtiss
21c29bad6b
Merge pull request #11407 from AdmiralCurtiss/globals-gpfifo
...
HW/GPFifo: Refactor to class, move to Core::System.
2023-01-09 17:09:48 +01:00
Admiral H. Curtiss
eeeab3c3be
Merge pull request #11183 from TheLordScruffy/write-back-cache
...
Implement PowerPC data cache
2023-01-09 17:09:32 +01:00
Sam Belliveau
901e4c7697
Reset Throttle Variables In Init
2023-01-09 11:06:12 -05:00
Sam Belliveau
f7de0e4147
Fix issue that would disable Throttling
2023-01-08 01:20:19 -05:00
TheLordScruffy
d85f6c8298
DolphinAnalytics: Remove ICACHE_MATTERS
2023-01-08 00:17:46 -05:00
TheLordScruffy
825bacde43
PPCCache: Change u32 to u8 for plru, valid, modified
2023-01-07 20:18:59 -05:00
TheLordScruffy
811d942222
Improve PPCCache lookup table
2023-01-07 07:30:42 -05:00
Sam Belliveau
bc1cc9eeb4
CoreTiming: Throttle Before Every Event Using Chrono
2023-01-06 17:21:17 -05:00
Admiral H. Curtiss
d33416fc35
HW/Memmap: Zero-initialize members by default.
2023-01-06 05:33:21 +01:00
Admiral H. Curtiss
fbcaf83d30
HW/GPFifo: Refactor to class, move to Core::System.
2023-01-06 05:33:21 +01:00
Admiral H. Curtiss
7b04a6b958
Merge pull request #11089 from sepalani/pcap-share
...
NetworkCaptureLogger: Allow PCAP shared read access on Windows
2023-01-05 04:06:35 +01:00
Admiral H. Curtiss
2fdaf0a86e
HW/ProcessorInterface: Rename member variables to fit naming convention.
2023-01-04 03:17:26 +01:00
Admiral H. Curtiss
74e1577a2c
HW/ProcessorInterface: Refactor to class, move to Core::System.
2023-01-04 03:00:10 +01:00
Pokechu22
c1b1d8d783
DolphinAnalytics: Track support of framebuffer fetch
2023-01-02 23:17:17 -08:00
Pokechu22
277518837a
DolphinAnalytics: Track support of logic ops
2023-01-02 23:17:02 -08:00
Pokechu22
f433da6083
DolphinAnalytics: Fix comment wrapping
...
This was broken in 3570c7f03a
.
2023-01-02 23:15:04 -08:00
TheLordScruffy
9d39647f9e
Fix PPC cache code formatting
2023-01-02 02:33:57 -05:00
Mai
20ac2cf781
Merge pull request #11375 from JosJuice/mmu-inf-write
...
PowerPC: Fix theoretically possible infinite loop in WriteToHardware
2022-12-31 18:55:11 +00:00
Mai
acdf76bf16
Merge pull request #11374 from JosJuice/jitarm64-breakpoints
...
JitArm64: Implement breakpoints
2022-12-31 18:53:25 +00:00
Admiral H. Curtiss
f6fbeaf355
Merge pull request #11364 from jordan-woyak/udraw-lift
...
WiimoteEmu: Expose mappings for lifted UDraw and Drawsome stylus.
2022-12-29 21:16:57 +01:00
Admiral H. Curtiss
c20bb01b47
Merge pull request #11372 from JosJuice/m3u-backslash
...
Boot: Fix handling of M3U file paths containing backslashes
2022-12-29 17:09:38 +01:00
Admiral H. Curtiss
4bc94e4629
Merge pull request #11353 from noahpistilli/fix-mail-account-generation
...
Set checksum for NWC24Config during creation
2022-12-29 17:08:10 +01:00
Admiral H. Curtiss
cb0a603c72
VideoCommon: De-globalize GeometryShaderManager class.
2022-12-29 15:33:19 +01:00
Admiral H. Curtiss
a164c47caf
Core/Boot: Pass System instance to BootUp() and related.
2022-12-29 05:49:26 +01:00
Admiral H. Curtiss
50625728e0
VideoCommon: De-globalize VertexShaderManager class.
2022-12-28 15:52:29 +01:00
Mai
0900e68986
Merge pull request #11384 from AdmiralCurtiss/globals-pixelshadermanager
...
VideoCommon: De-globalize PixelShaderManager class.
2022-12-28 00:59:03 +00:00
Admiral H. Curtiss
c8202043b6
IOS/NWC24Config: Combine WriteConfig() and WriteCBK().
2022-12-27 21:21:06 +01:00
Admiral H. Curtiss
725bd64ec2
VideoCommon: De-globalize PixelShaderManager class.
2022-12-27 20:13:24 +01:00
Sketch
929fba08e7
Fix ESDevice::GetTitlesWithTickets always returning 0 titles owned
2022-12-27 12:18:44 -05:00
Floogle
c689e9cde0
Netplay: When connecting, ignore packets from traversal server
2022-12-26 23:35:42 +01:00
Jordan Woyak
4f4285cf5e
WiimoteEmu/DrawsomeTablet: Expose mapping for lifted stylus.
2022-12-25 19:03:15 -06:00
Jordan Woyak
ab9fc3f2e4
WiimoteEmu/UDrawTablet: Expose mapping for lifted stylus.
2022-12-25 19:03:15 -06:00
JosJuice
cf16f49068
PowerPC: Fix theoretically possible infinite loop in WriteToHardware
...
`em_address + size` can overflow and become 0. It shouldn't happen with
the kinds of memory mappings games use in practice, though.
2022-12-25 12:29:13 +01:00
JosJuice
c744ff4934
JitArm64: Implement breakpoints
...
Plus two miscellaneous debugger features that I found along the way when
reading Jit64's code for comparison: bJITNoBlockLinking and tracing.
Fixes https://bugs.dolphin-emu.org/issues/13127 .
2022-12-24 13:24:01 +01:00
JosJuice
0659827485
Jit64: Check for breakpoint without disabling block link
...
Small optimization. By not calling WriteExit, the block linking system
never finds out about the exit we're doing, saving us from having to
disable block linking.
2022-12-24 13:01:29 +01:00
JosJuice
71f1b1db34
Boot: Fix handling of M3U file paths containing backslashes
...
Previously, if a user on Windows launched Dolphin from the command line
and specified a path to an M3U file and included backslashes in this path,
Dolphin would fail to resolve relative paths in the M3U file.
2022-12-24 11:13:27 +01:00
Sam Belliveau
673f81c18a
New FrameTime/VBlank Analyzer + Graph
2022-12-23 19:52:53 -05:00
iwubcode
31bf9d0019
Core: add option to apply memory patch to not store the existing value (used during locking)
2022-12-23 12:31:33 -06:00
iwubcode
8f3e8e4ca3
Core: add locked state to watches
2022-12-23 11:59:23 -06:00
iwubcode
3081a781fd
Core: when scheduling an invalidate cpu cache, no need to schedule if we're already on the cpu thread
2022-12-23 11:59:23 -06:00
iwubcode
2f2f906bf5
Core: add ability to add memory patches to the patch engine that will be executed each frame
2022-12-23 03:13:03 -06:00
iwubcode
1f87bcd202
Core: add ability to apply memory patches during a frame update in the PatchEngine
2022-12-23 03:13:03 -06:00
iwubcode
4743d74985
Core: add helper function to apply a memory patch and mark the 'PPCPatches' as final
2022-12-23 03:13:03 -06:00
Minty-Meeo
05bebee802
Replace BitUtils with C++20: Counting Zeroes
...
With the upgrade to C++20, std::countl_zero and std::countr_zero can replace these home-spun implementations from the BitUtil.h library.
2022-12-21 04:17:00 -06:00
Admiral H. Curtiss
d853da3b0b
Merge pull request #11354 from Pokechu22/desert-bus-asnd-ucode
...
DSPHLE: Add Desert Bus libasnd ucode variants
2022-12-20 20:01:21 +01:00
Pokechu22
66b3686d84
DSPHLE: Add Desert Bus libasnd ucode variants
2022-12-20 10:02:53 -08:00
Mai
5348c8b2c6
Merge pull request #11344 from JosJuice/jitarm64-mw-deps
...
JitArm64: Improve pipelining of lmw/stmw
2022-12-20 15:11:29 +00:00
Sketch
c01ec96c92
Set checksum for NWC24Config during creation
2022-12-19 20:18:34 -05:00
Mai
a1c4861ad8
Merge pull request #10950 from JosJuice/replace-bitutils-rotate
...
Replace BitUtils with C++20: RotateLeft/RotateRight
2022-12-11 21:19:43 +00:00
Mai
aa57d53c90
Merge pull request #11345 from AdmiralCurtiss/globals-pe
...
VideoCommon/PixelEngine: Refactor to class, move to Core::System.
2022-12-11 21:07:30 +00:00
Admiral H. Curtiss
ec8aaf1f30
VideoCommon/PixelEngine: Refactor to class, move to Core::System.
2022-12-11 21:57:19 +01:00
JosJuice
701ba7cd43
JitArm64: Improve pipelining of lmw/stmw
...
The calculation of each address in lmw/stmw currently has a dependency
on the calculation of the previous address. By removing this dependency,
the host CPU should be able to pipeline the loads/stores better. The cost
we pay for this is up to one extra register and one extra MOV instruction
per guest instruction, but often nothing.
Making EmitBackpatchRoutine support using any register as the address
register would let us get rid of the MOV, but I consider that to be too
big of a task to do in one go at the same time as this.
2022-12-11 17:08:12 +01:00
Merry
17c14ac4b9
MachineContext: Fix USE_SIGACTION_ON_APPLE on arm64
2022-12-11 13:36:44 +00:00
JosJuice
454537d53e
Replace BitUtils with C++20: RotateLeft/RotateRight
...
Now that we've flipped the C++20 switch, let's start making use of
the nice new <bit> header.
I'm planning on handling this move away from BitUtils.h incrementally
in a series of PRs. There may be a few functions remaining in
BitUtils.h by the end that C++20 doesn't have any equivalents for.
2022-12-11 08:59:18 +01:00
JosJuice
1fd8d476e8
Merge pull request #11325 from t895/extra-dark
...
Android: Add black backgrounds toggle
2022-12-10 21:09:26 +01:00
Charles Lombardo
fd7a84b794
Android: Add black backgrounds toggle
...
Makes all background colors black in dark mode when enabled through a ThemeOverlay. Applied the same way as a theme/mode.
2022-12-10 14:53:01 -05:00
Mai
54e01c660e
Merge pull request #11334 from AdmiralCurtiss/globals-fifo
...
VideoCommon/Fifo: Refactor to class, move to Core::System.
2022-12-10 19:13:23 +00:00
Mai
48ce5318e1
Merge pull request #11338 from JosJuice/jitarm64-revert-supposed-tail
...
Revert "JitArm64: Optimize a few tail calls"
2022-12-10 19:11:23 +00:00
Admiral H. Curtiss
ceae4242fc
VideoCommon/Fifo: Pass Core::System to methods.
2022-12-10 17:16:26 +01:00
Admiral H. Curtiss
5624dd6d39
VideoCommon/Fifo: Refactor to class, move to Core::System.
2022-12-10 17:16:19 +01:00
JosJuice
64bc150b8c
Revert "JitArm64: Optimize a few tail calls"
...
This reverts commit 351d095fff
.
In hindsight, my attempted optimization messes with the return
predictor, unlike real tail calls. So I think it does more bad than
good.
2022-12-10 11:35:52 +01:00
Admiral H. Curtiss
8a3b8a925e
Core: Add option to force linear texture filtering.
2022-12-09 02:02:16 +01:00
TheLordScruffy
e97d380437
Implement PPC write-back data cache
2022-12-08 18:18:32 -05:00
Admiral H. Curtiss
b207611c33
Merge pull request #11274 from TryTwo/PR_Conditional_BP_Add_Memory
...
Debugger: Add conditional breakpoints to memory BPs
2022-12-07 19:55:04 +01:00
Mai
000c6c4813
Merge pull request #11321 from JosJuice/jitarm64-accurate-nans
...
JitArm64: Implement accurate NaNs
2022-12-07 00:58:13 +00:00
Mai
94faad0d37
Merge pull request #11320 from AdmiralCurtiss/globals-memory
...
HW/Memmap: Refactor Memory to class, move to Core::System.
2022-12-07 00:52:31 +00:00
Mai
a9a603b8cb
Merge pull request #11268 from jordan-woyak/ascii-controller
...
Rename "Keyboard" to "Keyboard Controller"
2022-12-04 21:05:52 +00:00
TryTwo
a17fbe7c65
Expand conditional breakpoints to memory breakpoints
2022-12-04 11:25:33 -07:00
Mai
b23eb1f550
Merge pull request #11322 from JosJuice/jit64-madds-nan
...
Jit64: Correctly handle NaNs for ps_maddsX
2022-12-04 17:58:16 +00:00
Mai
f21edf6d5a
Merge pull request #11270 from t895/theme-mode
...
Android: Add theme mode switcher
2022-12-04 17:56:59 +00:00
Admiral H. Curtiss
2b93d5e0d7
Merge pull request #11273 from TryTwo/PR_Conditional_BP_Callstack
...
Debugger: add callstack to conditional breakpoints
2022-12-04 14:16:12 +01:00
TryTwo
76bf1b5f7d
Add callstack to conditional breakpoints. Checks entire stack for value.
...
Use: callstack(0x80000000).
!callstack(value) works as a 'does not contain'.
Add strings to expr.h conditionals.
Use quotations: callstack("anim") to check symbols/name.
2022-12-03 20:52:17 -07:00
JosJuice
eeef5363e4
Jit64: Correctly handle NaNs for ps_maddsX
2022-12-03 21:05:05 +01:00
JosJuice
06e60ac327
JitArm64: Implement accurate NaNs
...
For quite some time now, we've had a setting on x86-64 that makes Dolphin
handle NaNs in a more accurate but slower way. There's only one game that
cares about this, Dragon Ball: Revenge of King Piccolo, and what that game
cares about more specifically is that the default NaN (or "generated NaN"
as I believe it's called in PowerPC documentation) is the same as on
PowerPC. On ARM, the default NaN is the same as on PowerPC, so for the
longest time we didn't need to do anything special to get Dragon Ball:
Revenge of King Piccolo working. However, in 93e636a
I changed how we
handle FMA instructions in a way that resulted in the sign of NaNs
becoming inverted for nmadd/nmsub instructions, breaking the game.
To fix this, let's implement the AccurateNaNs setting, like on x86-64.
2022-12-03 19:41:32 +01:00
JosJuice
5c41d3b602
JitArm64: Refactor temp reg handling in fp_arith/ps_arith
2022-12-03 19:08:27 +01:00
Admiral H. Curtiss
839db591d9
HW/Memmap: Refactor Memory to class, move to Core::System.
2022-12-03 13:27:02 +01:00
Charles Lombardo
b9fffa2e66
Android: Add theme mode switcher
...
Similar to app themes, theme modes have to be loaded before directory initialization is ready. So we save the proper key the same way.
2022-12-02 13:31:57 -05:00
Pokechu22
6a6d24550e
Clean up DisassembleBlock and JitInterface::GetHostCode
2022-12-01 17:43:35 -08:00
Mai
7cd9a78ebf
Merge pull request #11304 from JosJuice/jit64-nan-c
...
Jit64: Correctly handle NaNs for ps_mulsX/ps_sumX
2022-11-29 12:57:43 +00:00
Mai
5f22a0054f
Merge pull request #11305 from JosJuice/jitarm64-optimize-ps-merge
...
JitArm64: Optimize ps_mergeXX
2022-11-29 12:57:10 +00:00
Admiral H. Curtiss
6941d2e7e6
VideoCommon/CommandProcessor: Refactor to class, move to Core::System.
2022-11-29 08:15:01 +01:00
JosJuice
2f1a8ee1b9
Jit64: Skip HandleNaNs for operations that can't generate NaN
...
Operations that have two operands and can't generate a default NaN,
i.e. addition and subtraction, already have the desired NaN handling
on x86. We just need to make sure to not reverse the operands.
This fixes ps_sum0/ps_sum1 outputting NaNs in cases where they shouldn't.
(HandleNaNs assumes that a NaN in a ps0 input always results in a NaN in
the ps0 output, and correspondingly for ps1.)
2022-11-27 11:30:10 +01:00
JosJuice
cbceae9176
Jit64: Correctly handle NaNs for ps_mulsX
2022-11-27 11:30:10 +01:00
JosJuice
d3180e3516
Jit64: Refactor HandleNaNs operand passing
2022-11-27 11:30:05 +01:00
Mai
44f8b8c100
Merge pull request #11303 from AdmiralCurtiss/coretiming-class
...
CoreTiming: Refactor to class.
2022-11-27 06:00:46 +00:00
Admiral H. Curtiss
64bb9ae9a9
Correctly call CoUninitialize() on Cubeb helper class destruction.
2022-11-27 03:58:50 +01:00
Admiral H. Curtiss
daa70533cd
CoreTiming: Store Globals in CoreTimingManager.
2022-11-27 03:47:12 +01:00
Admiral H. Curtiss
c9558ecb4c
CoreTiming: Refactor to class.
2022-11-27 03:47:12 +01:00
Admiral H. Curtiss
3cdc6e3d4a
Merge pull request #10343 from AdmiralCurtiss/cubeb-2021
...
Update cubeb to mozilla/cubeb@27d2a102b0
2022-11-27 03:26:11 +01:00
JosJuice
f45d3a6a2c
JitArm64: Optimize ps_mergeXX
...
1. In some cases, ps_merge01 can be implemented using one instruction.
2. When we need two instructions for ps_merge01, it's best to start with
a MOV to avoid false dependencies on the destination register.
3. ps_merge10 can be implemented using a single EXT instruction.
2022-11-26 18:14:58 +01:00
Admiral H. Curtiss
e085bf14f9
Core: Use extra thread for Cubeb on Windows to not disturb the CoInitialize state of whatever thread happens to call a Cubeb function.
2022-11-26 05:05:57 +01:00
Admiral H. Curtiss
ca10e92ab9
Core: Abide by COM MTA requirement for cubeb on Windows. Partially based on https://github.com/dolphin-emu/dolphin/pull/8920#discussion_r459746604
...
Co-authored-by: Michael M <mchtly@gmail.com>
2022-11-26 05:05:56 +01:00
Admiral H. Curtiss
4273d3754c
CoreTiming: Move static variables into Core::System.
2022-11-26 04:22:32 +01:00
Admiral H. Curtiss
86f17511fc
CoreTiming: Move the 'Globals' instance into Core::System.
2022-11-26 04:22:32 +01:00
Admiral H. Curtiss
70f353fb37
Merge pull request #11283 from AdmiralCurtiss/netplay-save-sync-log
...
Netplay: Add more logging to save syncing.
2022-11-26 03:53:17 +01:00
Admiral H. Curtiss
d189c70d4d
Merge pull request #11230 from AdmiralCurtiss/gci-filenames
...
GCMemcardDirectory: GCI filename cleanup and fixes.
2022-11-26 03:52:43 +01:00
JoshuaMK
dd2282324b
Debugger BreakpointWidget: Allow editing breakpoints
2022-11-26 03:38:25 +01:00
Mai
7be4c90f67
Merge pull request #11166 from AdmiralCurtiss/mmio-system
...
HW: Pass System to MMIO handlers.
2022-11-24 00:58:45 +00:00
Pokechu22
cc5640245c
Fix build errors related to formatting non-scoped enums
2022-11-23 13:45:43 -08:00
Admiral H. Curtiss
0a6fdb9c13
HW: Pass System to MMIO handlers.
2022-11-23 05:52:21 +01:00
Mai
0ef6d30a0d
Merge pull request #11165 from AdmiralCurtiss/audiocommon-pass-system
...
AudioCommon: Pass Core::System to AudioCommon functions.
2022-11-23 04:49:31 +00:00
Mai
a47ed2124f
Merge pull request #11253 from AdmiralCurtiss/core-timing-events-pass-system
...
CoreTiming: Pass Core::System to Events.
2022-11-23 04:46:11 +00:00
Mai
677121bdbc
Merge pull request #11292 from JosJuice/jit64-imm-ra-update
...
Jit64: Use MOV instead of ADD for updating imm Ra
2022-11-23 04:42:46 +00:00
Mai
e573a0bbc2
Merge pull request #11294 from JosJuice/jitarm64-movpage2r
...
Arm64Emitter: Add MOVPage2R utility function
2022-11-23 04:41:31 +00:00
Sam Belliveau
edb2c90b38
Improve FPS/VPS Counting and Revamp Appearance
2022-11-23 00:11:47 +01:00
Admiral H. Curtiss
19b6251a3c
Merge pull request #11291 from JosJuice/gba-tas-input
...
DolphinQt: Add GBA TAS input window
2022-11-22 23:49:43 +01:00
Admiral H. Curtiss
c18d6c3deb
Config: Use JPN for custom GCI folder paths.
2022-11-22 17:53:20 +01:00
Admiral H. Curtiss
86d01c3399
Config: Add option to use JPN as the Japanese region directory in GetDirectoryForRegion().
...
See https://bugs.dolphin-emu.org/issues/13076 for motivation for this.
2022-11-22 17:53:19 +01:00
Admiral H. Curtiss
1089d3cab6
GCMemcardDirectory: Compare GCI files in GetFileNamesForGameID() by their identity instead of their default filename.
2022-11-22 10:54:11 +01:00
Admiral H. Curtiss
4b0312ecf8
GCMemcardDirectory: Decode and strip strings for GCI filenames.
2022-11-22 10:54:11 +01:00
Admiral H. Curtiss
c517e92719
GCMemcardDirectory: Use HasSameIdentity() in LoadGCI().
...
This is cheaper and more accurate than comparing default GCI filenames.
2022-11-22 10:54:11 +01:00
Admiral H. Curtiss
b31b2db5fa
GCMemcard: Remove unused methods.
2022-11-22 10:54:10 +01:00
Admiral H. Curtiss
2132e005c3
Core: Add config setting for base GCI folder path.
2022-11-22 10:48:37 +01:00
JosJuice
d64c3dc267
Arm64Emitter: Add MOVPage2R utility function
...
This new function is like MOVP2R, except it masks out the lower 12 bits,
returning them instead of writing them to the register. These lower
12 bits can then be used as an offset for LDR/STR. This lets us turn
ADRP+ADD+LDR sequences with a zero offset into ADRP+LDR sequences with
a non-zero offset, saving one instruction.
2022-11-21 23:24:06 +01:00
JosJuice
40571cf13c
DolphinQt: Add GBA TAS input window
...
When emulated GBAs were added to Dolphin, it was possible to control them
using the GC TAS input window. (Z was mapped to Select.) Unaware of this,
I broke the functionality in b296248
.
To make it possible to control emulated GBAs using TAS input again,
I'm adding a proper TAS input window for GBAs, with a real Select button
and no analog controls.
2022-11-21 19:16:30 +01:00
JMC47
22bcf134bf
Merge pull request #11139 from JosJuice/jit64-nans-no-freg
...
Jit64: Don't use fregsIn in HandleNaNs
2022-11-20 13:47:02 -05:00
JosJuice
4b6bad2f9e
Jit64: Use MOV instead of ADD for updating imm Ra
...
The old code would first MOV the old imm into Ra and then do an ADD.
We can skip the ADD and just MOV the new imm.
2022-11-20 10:50:25 +01:00
Admiral H. Curtiss
5d03577189
Memmap: Fix initialization of PhysicalMemoryRegion.
2022-11-18 06:57:54 +01:00
Léo Lam
f1c9774159
Merge pull request #11240 from noahpistilli/es_v1_ticket
...
IOS/ES: Add support for V1Ticket
2022-11-18 00:25:47 +01:00
Sketch
2fd9852ca8
IOS/ES: Add support for V1Ticket
2022-11-17 17:54:06 -05:00
Admiral H. Curtiss
f0b0fcbb95
Netplay: Add more logging to save syncing.
2022-11-16 04:00:43 +01:00
Admiral H. Curtiss
43e90ca023
Merge pull request #11105 from vpelletier/si_ignore_setGameId
...
SI: Ignore non-standard setGameID command
2022-11-16 02:08:39 +01:00
Admiral H. Curtiss
d7593dd721
Merge pull request #11243 from Sintendo/arm64mul
...
JitArm64: Optimize multiplication
2022-11-15 04:05:49 +01:00
Admiral H. Curtiss
c9e74801ed
Merge pull request #11269 from vabold/dolphindevice-get-time
...
Add DolphinDevice::GetSystemTime to allow for accurate Unix timestamp generation
2022-11-15 03:48:57 +01:00
Admiral H. Curtiss
09c0321997
Merge pull request #11184 from Lobsterzelda/save-all-nand-files-to-save-state
...
HostFileSystem: Set all NAND folders to be saved in save states
2022-11-15 03:42:26 +01:00
Admiral H. Curtiss
2a81fa6c26
Merge pull request #11015 from TryTwo/Conditional_Breakpoints
...
Conditional breakpoints
2022-11-13 01:06:52 +01:00
vabold
083b8172e0
Replace `std::time` with `std::chrono::system_clock`
2022-11-12 05:36:49 -05:00
vabold
ff1c71cc38
Fix inaccurate function name, add old function
2022-11-12 05:36:49 -05:00
Jordan Woyak
296959ec58
GCKeyboardEmu: Eliminate unused Options group.
2022-11-11 01:59:09 -06:00
Lobsterzelda
ed54e1905a
HostFileSystem: Set all NAND folders to be saved in save states when a movie is active
2022-11-10 14:02:29 -05:00
TellowKrinkle
37a51f1d09
VideoCommon: Add an option to disable mipmaps
...
Needed by M1 fifoci to work around a minor non-determinism bug
2022-11-07 22:18:56 -06:00
Admiral H. Curtiss
a36a5c1308
CoreTiming: Pass Core::System to Events.
2022-11-06 17:54:58 +01:00
Admiral H. Curtiss
db679ab620
Merge pull request #11249 from JosJuice/load-dol-elf-after-mem
...
Boot: Load DOL/ELF after memory setup
2022-11-06 05:40:54 +01:00
Admiral H. Curtiss
e1f5eb3d8d
Merge pull request #11233 from AdmiralCurtiss/netplay-split-save-sync-function
...
NetPlay: Split SyncSaveData() into two parts.
2022-11-06 05:39:26 +01:00
Admiral H. Curtiss
1c63349984
AudioCommon: Pass Core::System to AudioCommon functions.
2022-11-06 02:13:58 +01:00
Admiral H. Curtiss
e9caa09f7b
NetPlay: Split SyncSaveData() into two parts.
...
This allows the 'save collection' part to run even if no clients are connected. Fixes issue 13095.
2022-11-06 01:51:01 +01:00
JosJuice
fb916a4c33
Boot: Load DOL/ELF after memory setup
...
I recently talked to a homebrew developer who was trying to add exception
handlers at link time but found out that Dolphin was overwriting their
exception handlers. I figure that's not the usual way to do exception
handlers, but... making us load the executable after setting up memory
rather than before is easy, and matches what we do when booting discs,
so I suppose there's no reason not to do it. It also matches the intent
of why Dolphin is writing default exception handlers – we're writing
them because some homebrew relies on exception handlers being left
around from whatever program was running before it (see 3dd777be70
).
2022-11-05 13:55:17 +01:00
Admiral H. Curtiss
8b4e315fb7
Merge pull request #11242 from Sintendo/arm64cmp
...
JitArm64: Optimize cmp
2022-11-04 23:13:09 +01:00
Bram Speeckaert
274e34ddf1
JitArm64: MultiplyImmediate - Handle -(2^n) + 1
...
Let's take advantage of ARM64's input register shifting one last time,
shall we?
Before:
0x1280005b mov w27, #-0x3
0x1b1b7f18 mul w24, w24, w27
After:
0x4b180b18 sub w24, w24, w24, lsl #2
2022-11-02 21:53:19 +01:00
Bram Speeckaert
7073a135c6
JitArm64: MultiplyImmediate - Handle -(2^n)
...
ARM64's flexible shifting of input registers also allows us to calculate
a negative power of two in one instruction; shift the input of a NEG
instruction.
Before:
0x128001f7 mov w23, #-0x10
0x1b1a7efa mul w26, w23, w26
0x93407f58 sxtw x24, w26
After:
0x4b1a13fa neg w26, w26, lsl #4
0x93407f58 sxtw x24, w26
2022-11-02 21:53:19 +01:00
Bram Speeckaert
1c87f040a3
JitArm64: mulli - Only allocate reg when necessary
...
If the destination register doesn't equal the input register, using it
to temporarily hold the immediate value is fair game as it'll be
overwritten with the result of the multiplication anyway. This can
slightly reduce register pressure.
Before:
0x52800659 mov w25, #0x32
0x1b197f5b mul w27, w26, w25
After:
0x5280065b mov w27, #0x32
0x1b1b7f5b mul w27, w26, w27
2022-11-02 21:53:19 +01:00
Bram Speeckaert
20dd5cadab
JitArm64: MultiplyImmediate - Add comments
2022-11-02 21:53:17 +01:00
Bram Speeckaert
c349875cdc
JitArm64: MultiplyImmediate - Handle 2^n + 1
...
By taking advantage of ARM64's ability to shift an input register by any
amount, we can calculate multiplication by a number that is one more
than a power of two with a single instruction.
Before:
0x52800838 mov w24, #0x41
0x1b187f7b mul w27, w27, w24
After:
0x0b1b1b7b add w27, w27, w27, lsl #6
2022-11-02 21:52:44 +01:00
Bram Speeckaert
3aaf1a2b8b
JitArm64: MultiplyImmediate - Handle 2^n
...
Turn multiplications by a power of two into bitshifts.
Before:
0x52800817 mov w23, #0x40
0x1b167ef6 mul w22, w23, w22
After:
0x531a66d6 lsl w22, w22, #6
2022-11-02 21:52:37 +01:00
Markus Wick
0210d115c2
Merge pull request #11227 from JosJuice/jitarm64-mmio-clobber
...
JitArm64: Move MMIO handler result before popping stack
2022-11-02 10:19:22 +01:00
Bram Speeckaert
f25611f388
JitArm64: MultiplyImmediate - Handle 1
...
Multiplication by one is also trivial. Depending on the registers
involved, either a single MOV or no instructions will be generated.
Before:
0x52800038 mov w24, #0x1
0x1b1a7f1b mul w27, w24, w26
After:
0x2a1a03fb mov w27, w26
Before:
0x52800039 mov w25, #0x1
0x1b1a7f3a mul w26, w25, w26
After:
Nothing!
2022-11-01 21:13:45 +01:00
Bram Speeckaert
51cb918aa5
JitArm64: MultiplyImmediate - Handle 0
...
Multiplication by zero always gives zero.
Before:
0x52800019 mov w25, #0x0
0x1b197f5b mul w27, w26, w25
After:
Nothing!
2022-11-01 21:13:38 +01:00
Bram Speeckaert
080513284c
JitArm64: mullwx - Use MultiplyImmediate
2022-11-01 19:05:33 +01:00
Bram Speeckaert
53a8cd1563
JitArm64: mulli - Use MultiplyImmediate
2022-11-01 19:04:50 +01:00
Bram Speeckaert
4aa0c0133a
JitArm64: Introduce MultiplyImmediate
...
Add a new function that will handle all the special cases regarding
multiplication. It does nothing for now, but will be expanded in
follow-up commits.
2022-11-01 19:01:38 +01:00
Bram Speeckaert
d0de68c41b
JitArm64: cmp - Optimize general case
...
We can merge an SXTW with the SUB, eliminating one instruction. In
addition, it is no longer necessary to allocate a temporary register,
reducing register pressure.
Before:
0x93407f59 sxtw x25, w26
0x93407ebb sxtw x27, w21
0xcb1b033b sub x27, x25, x27
After:
0x93407f5b sxtw x27, w26
0xcb35c37b sub x27, x27, w21, sxtw
2022-11-01 12:21:24 +01:00
Bram Speeckaert
82f22cdfa1
JitArm64: cmp - Optimize a == -1 case
...
By explicitly handling this, we can avoid materializing -1 in a
register and generate more efficient code by taking advantage of -x ==
~x + 1.
Before:
0x12800015 mov w21, #-0x1
0x93407eb9 sxtw x25, w21
0x93407ef8 sxtw x24, w23
0xcb180338 sub x24, x25, x24
After:
0x2a3703f8 mvn w24, w23
0x93407f18 sxtw x24, w24
2022-11-01 12:00:32 +01:00
Bram Speeckaert
592ba31e22
JitArm64: cmp - Optimize a == 0 case
...
By explicitly handling this, we can avoid materializing zero in a
register and generate more efficient code altogether.
Before:
0x52800016 mov w22, #0x0
0xb94093b5 ldr w21, [x29, #0x90]
0x93407ed7 sxtw x23, w22
0x93407eb9 sxtw x25, w21
0xcb1902f9 sub x25, x23, x25
After:
0xb94093b7 ldr w23, [x29, #0x90]
0x4b1703f9 neg w25, w23
0x93407f39 sxtw x25, w25
2022-11-01 11:52:00 +01:00
Bram Speeckaert
f5e7e70cc5
JitArm64: cmp - Refactor
2022-11-01 11:47:17 +01:00
Bram Speeckaert
dbb8f588c7
JitArm64: cmpl - Optimize a == 0 case
...
By explicitly handling this, we can avoid materializing zero in a
register.
Before:
0x52800019 mov w25, #0x0
0xb94087b6 ldr w22, [x29, #0x84]
0xcb16033b sub x27, x25, x22
After:
0xb94087b9 ldr w25, [x29, #0x84]
0xcb1903fb neg x27, x25
2022-11-01 11:27:45 +01:00
JosJuice
431ee1c48a
JitArm64: Improve register handling for MMIO loadstores
...
Because of the previous commit, `regs_in_use` must not include `dest_reg`
when calling MMIOLoadToReg. There are also some other registers we can
skip including in regs_in_use just for efficiency's sake.
The `addr_reg_set = false` statements that I've added in this commit are
technically redundant – if `mmio_address` is non-zero then `addr_reg_set`
is already false – but it's just a coincidence that that's the case.
2022-10-29 14:16:53 +02:00
JosJuice
0660f12da4
JitArm64: Move MMIO handler result before popping stack
...
Otherwise we might throw the result away.
Fixes https://bugs.dolphin-emu.org/issues/13083 .
2022-10-29 14:16:43 +02:00
Pokechu22
2f3805e1b4
GraphicsSettings: Remove unused FreelookControlType enum forward declaration
2022-10-26 16:23:13 -07:00
TellowKrinkle
fa8134deda
VideoBackends:Metal: Default to presentDrawable when vsync is on
2022-10-24 17:55:30 -05:00
JMC47
b66793194e
Merge pull request #11028 from tellowkrinkle/MetalFixes
...
Various Metal renderer improvements
2022-10-24 15:22:37 -04:00
JMC47
4787b25a7f
Merge pull request #10741 from Pokechu22/audio-dma-one-block-at-a-time
...
DSP: Copy audio dma samples one block at a time
2022-10-24 01:43:22 -04:00
JMC47
33733ff81c
Merge pull request #11199 from JosJuice/translation-fixes
...
WiimoteEmu: Change Shinkansen Start/Select to START/SELECT
2022-10-23 16:07:11 -04:00
JosJuice
7437d2d9ad
WiimoteEmu: Change Shinkansen Start/Select to START/SELECT
...
For consistency with GameCube controllers and GBAs. I missed this
when reviewing the PR.
Also adding some i18n comments while I'm at it.
2022-10-23 21:50:54 +02:00
JosJuice
063c2739b3
Merge pull request #11135 from AdmiralCurtiss/ppcanalyst-unused-stats
...
PPCAnalyst: Remove unused variables and methods in BlockStats and BlockRegStats.
2022-10-23 21:22:54 +02:00
TryTwo
e2df81b0c1
Add logging and error reporting to Breakpoint Conditionals.
2022-10-23 08:22:35 -07:00
JMC47
cdcbe51b2a
Merge pull request #10890 from tellowkrinkle/VertexLineExpand
...
VideoCommon: Add vertex shader point/line expansion
2022-10-23 01:49:26 -04:00
TellowKrinkle
0a42c534c3
VideoCommon: Add configuration to prefer VS for line/point expansion
2022-10-22 20:13:24 -05:00
TellowKrinkle
68f49df0f8
VideoCommon: Add vertex shader point and line expansion
2022-10-22 20:13:24 -05:00
Pokechu22
bac75de79c
Fifo recorder: Fix incorrect calculation of the size of an array
...
The old calculation was stride * (max_index + 1), which fails if stride is less than the size of a component (for instance, if float XYZ positions are used, and the stride was set to 4 (i.e. sizeof(float)) instead of 12 (i.e. 3 * sizeof(float)), it would be missing the last 8 bytes of the final element in the array. Or, if stride was set to 0, then no bytes would be recorded at all (though that's not a useful configuration so it's unlikely to actually exist).
I'm not aware of any games affected by this issue.
2022-10-22 13:36:16 -07:00
Pokechu22
c9ff2a9b3d
Fifo recorder: Fix NormalIndex3
...
This should fix recording the wall in the staircase leading to the basement in Luigi's Mansion (though I haven't tested it, as I don't own a copy of Luigi's Mansion). This uses NormalIndex3, and the index for the normal vector (generally 0x02XX or 0x01XX) there is always lower than the tangent or binormal (generally 0x07XX). Other games seem to usually have a similar range of indices for the normal, tangent, and binormal, so this issue wouldn't affect them.
2022-10-22 13:36:16 -07:00
Pokechu22
24b761acda
Fifo recorder: Fix position's type being used for normals/colors/texture coords
...
In most cases, games will use the same type for all vertex components (either Index8 or Index16 or Direct). However, RS2's deflection towers use Index16 for the texture coordinate and Index8 for everything else, meaning the texture coordinates were recorded incorrectly (the first byte was used, so only indices 0 and 1 were recorded instead of 0 through 0x0192). Worse still, some background elements in RS2 use direct positions but indexed normals or texture coordinates, and those would not be recorded at all.
This is a regression from b5fd35f951
.
2022-10-22 13:36:16 -07:00
JMC47
804e42150e
Merge pull request #11188 from GaryOderNichts/feature/vwii_ancast
...
Support for loading vWii System Menu
2022-10-22 15:57:55 -04:00
Pokechu22
2a83b17ffb
DSP: Copy audio dma samples one block at a time
...
Reverts 9f8e1e2a0d
, but keeps the changes from e4e44909d5
.
This fixes missing audio in Datel titles; see https://bugs.dolphin-emu.org/issues/12281 .
2022-10-22 11:44:38 -07:00
GaryOderNichts
88c57a00a3
Show vWii System Menu version in Menu Bar
2022-10-22 13:36:55 +02:00
GaryOderNichts
82d20ce352
Support for loading Ancast images
2022-10-22 13:35:49 +02:00
JMC47
5b69c67b3a
Merge pull request #11147 from JosJuice/jitarm64-arith-org
...
JitArm64: Merge ps_mulsX, ps_maddXX, and parts of fp_arith
2022-10-22 06:37:27 -04:00
JMC47
b7310a180f
Merge pull request #11170 from JosJuice/jit64-dispatcher-no-check
...
Jit64: Add dispatcher_no_timing_check jump target
2022-10-22 06:19:00 -04:00
JMC47
55d269c9e0
Merge pull request #11190 from jordan-woyak/shinkansen-ui-button-order
...
WiimoteEmu: Shinkansen Tweaks
2022-10-22 05:21:00 -04:00
JosJuice
812067ab7c
JitArm64: Move ps instructions from fp_arith to ps_arith
...
This lets us simplify fp_arith without making ps_arith much more
complicated.
No behavior change.
2022-10-22 11:15:41 +02:00
JosJuice
554a2fd332
JitArm64: Merge ps_mulsX and ps_maddXX
...
They have a lot of shared code, most notably the code for rounding c.
No behavior change.
2022-10-22 11:12:19 +02:00
JMC47
2153276ab9
Merge pull request #10046 from JosJuice/jitarm64-improve-const-stores
...
JitArm64: FIFO optimization improvements
2022-10-22 05:03:43 -04:00
Markus Wick
7a2256469e
Merge pull request #11127 from JosJuice/aarch64-jitasm-macro-op
...
JitAsm64: Reorder instructions in routines to allow macro-op fusion
2022-10-22 10:31:54 +02:00
Markus Wick
583c2b8a0c
Merge pull request #11181 from JosJuice/jitarm64-25-bit-urshr
...
JitArm64: Reimplement Force25BitPrecision
2022-10-22 10:26:07 +02:00
Markus Wick
5c7b5514ed
Merge pull request #11148 from JosJuice/jitarm64-remove-cdts-inst
...
JitArm64: Remove unnecessary instruction from ConvertDoubleToSingle
2022-10-22 10:10:23 +02:00
JosJuice
4dbf0b8e90
JitArm64: Reimplement Force25BitPrecision
...
The previous implementation of Force25BitPrecision was essentially a
translation of the x86-64 implementation. It worked, but we can make a
more efficient implementation by using an AArch64 instruction I don't
believe x86-64 has an equivalent of: URSHR. The latency is the same as
before, but the instruction count and register count are both reduced.
2022-10-22 10:03:52 +02:00
Jordan Woyak
d9d6428189
WiimoteEmu: Replace shinkansen MixedTriggers with Triggers.
2022-10-22 02:42:40 -05:00
Jordan Woyak
d705b8d4b8
WiimoteEmu: Reorder shinkansen buttons in UI.
2022-10-22 02:37:28 -05:00
GaryOderNichts
2fb45660b3
IOS::HLE::Kernel::InitIPC: Replace s_ios check with Core::IsRunning
2022-10-21 20:38:02 +02:00
Lobsterzelda
486a523e0d
IOS: Simplify IOS::HLE::Device savestate method
2022-10-17 23:11:04 -04:00
Admiral H. Curtiss
9992a198f1
IOS/NetKDRequest: Don't abort on first unset bit in subtask mask.
2022-10-16 20:43:59 +02:00
Admiral H. Curtiss
cbc96adfd2
VFFUtil: Invalidate window on mount.
2022-10-16 18:06:51 +02:00
Admiral H. Curtiss
b1725dfb33
Zero-initialize structures passed to FatFs functions.
2022-10-16 17:12:04 +02:00
JosJuice
09f9a58859
Jit64: Add dispatcher_no_timing_check jump target
...
The new `dispatcher_no_timing_check` is the same as `dispatcher_no_check`
except it includes the "stepping check" in debug mode. This lets us avoid
the `m_enable_debugging ? dispatcher : dispatcher_no_check` dance.
2022-10-16 11:22:34 +02:00
Admiral H. Curtiss
c0476fdac3
Merge pull request #11072 from SketchMaster2001/wiiconnect24
...
Add initial WiiConnect24 support
2022-10-16 04:31:28 +02:00
SketchMaster2001
e413d7f5ec
Add initial WiiConnect24 support
2022-10-16 04:19:36 +02:00
Admiral H. Curtiss
fbe782f1a9
Merge pull request #11077 from JosJuice/jitasm-no-breakpoint
...
Jit64: Remove breakpoint check from JitAsm.cpp
2022-10-16 04:02:12 +02:00
JosJuice
351d095fff
JitArm64: Optimize a few tail calls
...
Maybe "tail call" isn't quite the right term for what this code
is doing, since it's jumping to the dispatcher rather than
returning, but it's the same optimization as for a tail call.
2022-10-15 21:45:44 +02:00
JosJuice
2a5f4a2390
Jit64: Don't use fregsIn in HandleNaNs
...
fregsIn will include FD for double-precision instructions, since for
dependency tracking purposes the instruction does read the upper
half of FD. This is not what we want in HandleNaNs.
The consequence of this bug is that if an instruction was supposed to
output a NaN and FD happens to contain a NaN and FD happens to be the
same register as an unused register in the instruction encoding, the
NaN in FD could get used as the output instead of the correct NaN.
This isn't known to affect any games, which isn't especially surprising
considering that there's only one game that needs AccurateNaNs anyway.
2022-10-15 18:11:40 +02:00
Admiral H. Curtiss
cd1f89a02b
Merge pull request #11138 from JosJuice/jit64-quiet-nans
...
Jit64: Turn SNaN into QNaN in HandleNaNs
2022-10-15 18:06:40 +02:00
Admiral H. Curtiss
85f7cf7c1e
Merge pull request #11169 from JosJuice/jit64-speculative-constants-dispatcher
...
Jit64: Jump to dispatcher_no_check from InitializeSpeculativeConstants
2022-10-15 17:46:22 +02:00
JosJuice
ec6a4115eb
Jit64: Jump to dispatcher_no_check from InitializeSpeculativeConstants
...
Jumping to `dispatcher` requires first subtracting the downcount,
otherwise `dispatcher` may unpredictably jump to CoreTiming::Advance,
which could break determinism compatibility with JitArm64. We should
jump to `dispatcher_no_check` instead.
2022-10-15 17:21:38 +02:00
JosJuice
b9aed428e8
Jit64: Remove breakpoint check from JitAsm.cpp
...
The breakpoint check in Jit.cpp makes it redundant.
Normally this redundant check doesn't cause any issues, but if you
create a breakpoint and enable logging without breaking, you get two
log messages if the breakpoint is at the beginning of a block. See
https://bugs.dolphin-emu.org/issues/13044 .
This is also a tiny performance improvement for when debugging is
active, since we no longer check for breakpoints for blocks that never
had any breakpoints to begin with.
2022-10-15 17:06:32 +02:00
JosJuice
dbf5dca11c
JitArm64: FIFO optimization improvements
...
JitArm64 port of 789975e
.
2022-10-15 12:57:18 +02:00
Jordan Woyak
9c1a936ca6
WiimoteEmu: Do send a status report on connection when an extension is already attached.
2022-10-15 03:35:01 -05:00
Lobsterzelda
65c7304bd4
VideoInterface: Simplify VideoInterface savestate code
...
VideoInterface: Simplify savestate code in VideoInterface
2022-10-13 15:21:22 -04:00
Admiral H. Curtiss
e47af664cc
HW: Move MemoryInterface variables to Core::System.
2022-10-13 04:28:17 +02:00
Admiral H. Curtiss
06f74bd7d1
Merge pull request #11152 from jordan-woyak/wm-emu-ir-point-size
...
WiimoteEmu: Improve simulated IR point size accuracy.
2022-10-13 02:18:58 +02:00
Pokechu22
f9fe25291d
Remove most uses of StringFromFormat in favor of fmt
2022-10-12 16:50:47 -07:00
Mai
a5fa95adfd
Merge pull request #11151 from jordan-woyak/quat-fix
...
Fix some bad quaternion math.
2022-10-12 17:35:50 +00:00
Jordan Woyak
bf53e14abe
WiimoteEmu: Fix gyroscope/quaternion conversion math.
2022-10-11 15:01:33 -05:00
Jordan Woyak
3939b32ed6
WiimoteEmu: Improve simulated IR point size accuracy.
2022-10-11 14:57:04 -05:00
Lioncash
dbfb8408d9
HW: Use unsigned indices in RegisterMMIO where applicable
...
base is an unsigned variable, so we can make things little more
consistent by making the loop index unsigned so we aren't doing bit
arithmetic with signed types.
MemoryInterface already does this, so we can leave it alone.
No behavioral changes, just a consistency thing.
2022-10-11 09:27:34 -04:00
Minty-Meeo
a84633f748
Remove #pragma once in DesiredWiimoteState.cpp
...
That shouldn't be there...
2022-10-11 01:16:56 -05:00
Admiral H. Curtiss
a056a1366f
Merge pull request #11131 from Pokechu22/cp-state-savestate-mistakes
...
Include tangent/binormal cache in savestates and simplify saving CP state
2022-10-11 03:42:17 +02:00
Admiral H. Curtiss
333ede5416
Merge pull request #11136 from AdmiralCurtiss/gqr-array
...
Jit64: Convert constantGqr to std::array.
2022-10-10 02:13:30 +02:00
Pokechu22
05f3bbfa4d
Include tangent/binormal cache in savestates
...
This theoretically matters for RS2/RS3, although in practice these games reconfigure it each frame so it shouldn't matter for savestates.
2022-10-09 16:21:49 -07:00
JosJuice
bf492c1ff3
JitArm64: Fix register number typo
...
I think this typo was actually ignored by the code, but nevertheless,
it should be fixed.
2022-10-09 16:46:09 +02:00
JosJuice
04628034bc
JitAsm64: Reorder instructions in routines to allow macro-op fusion
...
Micro-optimization. Some CPUs can fuse CMP+B, TST+B, arith+CBZ, etc.
I also moved things around for CMP+CSET and TST+CSET - which I'm not sure
if any CPUs support - but it doesn't hurt anything, so I might as well.
2022-10-09 16:46:09 +02:00
JosJuice
6e01ab56fa
JitArm64: Remove unnecessary instruction from ConvertDoubleToSingle
...
The upper bits are masked away by the preceding LSR, and the lower bits
are masked away by the following BFXIL.
2022-10-09 14:17:18 +02:00
Admiral H. Curtiss
4c7fcf58b0
Merge pull request #11140 from JosJuice/jit64-inaccurate-single-fprf
...
Jit64: Fix single FPRF when !jo.accurateSinglePrecision
2022-10-09 13:08:53 +02:00
JosJuice
c361f9155b
Jit64: Turn SNaN into QNaN in HandleNaNs
...
Improves accuracy but isn't known to affect any games.
This turned out to be fairly convenient to implement; ORing with the
PPC default NaN will quieten SNaNs and do nothing to QNaNs.
2022-10-09 09:49:52 +02:00
Admiral H. Curtiss
6cf99195c6
Merge pull request #11142 from JosJuice/jit64-handle-nans-no-output
...
Jit64: Remove HandleNaNs's xmm_out parameter
2022-10-09 04:16:57 +02:00
Admiral H. Curtiss
66684a392f
Deduplicate NetPlayServer::Send() and NetPlayClient::Send() into ENetUtil::SendPacket().
2022-10-09 02:25:28 +02:00
Admiral H. Curtiss
da27a3e6bc
Merge pull request #11095 from K0bin/misc-vulkan
...
Remove special treatment for Android in video settings
2022-10-08 22:24:30 +02:00
JosJuice
4b8a720c9b
Jit64: Remove HandleNaNs's xmm_out parameter
...
All HandleNaNs does with the xmm_out parameter is emit MOVAPD at the end
if xmm_out != xmm. The caller might as well do that themselves.
2022-10-08 19:49:30 +02:00
JosJuice
0b1fdee289
Jit64: Fix single FPRF when !jo.accurateSinglePrecision
...
jo.accurateSinglePrecision is always true, so it's not like this
matters much...
2022-10-08 18:35:46 +02:00
Admiral H. Curtiss
1c2182d069
Merge pull request #11134 from Pokechu22/memmap-remove-io-size
...
Memmap: Remove unused IO size field
2022-10-08 13:59:44 +02:00
Admiral H. Curtiss
e7219f7389
Jit64: Convert constantGqr to std::array.
2022-10-08 13:54:50 +02:00
TellowKrinkle
a13f09433c
VideoBackends:Metal: Add config option to use presentDrawable
2022-10-08 04:46:07 -05:00
TellowKrinkle
c08de82e90
VideoBackends:Metal: Bring back unified memory config
...
Turns out it was helpful. (Most improvement in ubershaders.) This time with much better auto mode.
2022-10-08 04:46:05 -05:00
Admiral H. Curtiss
1abffc0b05
PPCAnalyst: Remove unused variables in BlockStats.
2022-10-08 03:30:56 +02:00
Admiral H. Curtiss
a5217c07b8
PPCAnalyst: Remove unused variables and methods in BlockRegStats.
2022-10-08 03:26:42 +02:00
Admiral H. Curtiss
6a2ed5758e
JitCache: Erase address from noSpeculativeConstantsAddresses when block is invalidated.
2022-10-08 02:44:36 +02:00
Pokechu22
be65e96991
Memmap: Remove unused IO size field
...
This existed in the initial megacommit (though I don't know why) as IO_SIZE. It was used in Memmap's Init() to compute totalMemSize, but I don't know if it actually did anything then. That use was removed in 2d0f714546
, but the constant persisted until cc858c63b8
, when it became a static variable.
2022-10-07 17:24:51 -07:00
smurf3tte
85cb4d1bc5
Support memory reads/writes from breakpoint expressions
...
Co-authored-by: TryTwo <taolas@gmail.com>
2022-10-06 21:34:44 -07:00
smurf3tte
1224575b0b
Add cast expression functions u8(), s8(), u16(), etc.
...
This allows for easy reinterpretation of GPRs in an expression.
Co-authored-by: TryTwo <taolas@gmail.com>
2022-10-06 21:34:44 -07:00
smurf3tte
7842f9a715
Debugger: Initial implementation of conditional breakpoints
...
Expression class to store compiled expressions and associated variable list.
Co-authored-by: TryTwo <taolas@gmail.com>
2022-10-06 21:34:44 -07:00
Lobsterzelda
d2db451eba
HW/MemoryInterface: Add data to savestates and initialize on boot.
2022-10-07 01:31:56 +02:00
Admiral H. Curtiss
691135dbc3
HW: Move SerialInterface variables to Core::System.
2022-10-06 22:08:20 +02:00
Pokechu22
4d33f6af7c
GCMemcard: Remove manual std::vector handling in DoState
2022-10-06 11:25:36 -07:00
Pokechu22
e8221d7948
Common/PointerWrap: Remove DoPOD
...
This was added in 385d8e2b15
, but became somewhat redundant with Do in 4c7bbd96e4
, and completely redundant now that std::is_trivially_copyable_v is well-supported.
2022-10-06 11:25:36 -07:00
Mai
7498eb1e6c
Merge pull request #11121 from AdmiralCurtiss/globals-exi
...
HW: Move ExpansionInterface variables to Core::System.
2022-10-06 10:33:22 -04:00
Admiral H. Curtiss
26318e2c51
HW: Move ExpansionInterface variables to Core::System.
2022-10-06 01:19:29 +02:00
Admiral H. Curtiss
de5a98a3fa
Merge pull request #11120 from AdmiralCurtiss/gci-open-fail
...
HW/GCMemcardDirectory: Add error message if opening GCI fails.
2022-10-06 01:09:47 +02:00
Admiral H. Curtiss
662caf91ac
HW/GCMemcardDirectory: Add error message if opening GCI fails.
2022-10-05 19:56:05 +02:00
Admiral H. Curtiss
cf094eb415
Merge pull request #11117 from JosJuice/jitarm64-imm-not-dirty
...
JitArm64: Fix BindToRegister in case Immediate && !set_dirty
2022-10-05 19:31:44 +02:00
Admiral H. Curtiss
9c944d5734
HW: Move VideoInterface variables to Core::System.
2022-10-04 02:25:12 +02:00
JosJuice
b296248b49
DolphinQt: Use input override system for TAS input windows
...
This lets the TAS input code use a higher-level interface for
overriding inputs instead of having to fiddle with raw bits.
WiiTASInputWindow in particular was messy with how much
controller code it had to re-implement.
2022-10-03 22:04:09 +02:00
JosJuice
8fd25259ee
ControllerEmu: Round input floats instead of casting, part 2
...
Like 3bc4968
but for Wii Remote extensions. I'm doing this to ensure
that TAS input values will still roundtrip after the next commit.
2022-10-03 22:04:08 +02:00
JosJuice
cb16d20f2d
ControllerEmu: Add new "input override" system
2022-10-03 22:00:21 +02:00
JosJuice
f4f189c51f
JitArm64: Rename BindToRegister parameters for clarity
2022-10-03 21:41:34 +02:00
Admiral H. Curtiss
e137f7f878
WiimoteEmu: Rewrite serialization of DesiredWiimoteState to optimize for network bandwidth.
2022-10-02 23:25:15 +02:00
Admiral H. Curtiss
ae4b89441c
Qt/WiimoteControllersWidget: Disable remote Wiimote configuration during netplay.
2022-10-02 23:25:15 +02:00
Admiral H. Curtiss
a1563f2def
Netplay: Implement batching for Wiimotes.
2022-10-02 23:25:10 +02:00
Admiral H. Curtiss
aade584180
Netplay: Completely rewrite Wiimote syncing logic to be similar to the GameCube controller one.
2022-10-02 23:22:02 +02:00
Admiral H. Curtiss
f8518b2ff6
WiimoteEmu: Add serialization for DesiredWiimoteState.
2022-10-02 23:14:36 +02:00
Admiral H. Curtiss
a2dadbb2f0
Wiimote: Separate the Input system state update from the emulated state update.
2022-10-02 23:14:36 +02:00
Admiral H. Curtiss
bb5943ae77
Wiimote: Separate the Wiimote index in the Input system from the index of the Wiimote in the emulated system.
2022-10-02 23:14:36 +02:00
Admiral H. Curtiss
b67ffb9ab5
WiimoteEmu: Make Reset() deterministic under WantsDeterminism().
2022-10-02 23:14:36 +02:00
Admiral H. Curtiss
466f0b377b
WiimoteEmu: Update extensions from DesiredWiimoteState.
2022-10-02 23:14:35 +02:00
Admiral H. Curtiss
e7543a9e05
WiimoteEmu: Update MotionPlus status from DesiredWiimoteState.
2022-10-02 23:14:35 +02:00
Admiral H. Curtiss
26fd4ea361
WiimoteEmu: Update IR camera status from DesiredWiimoteState.
2022-10-02 23:14:35 +02:00
Admiral H. Curtiss
9669722dfc
WiimoteEmu: Update accelerometer status from DesiredWiimoteState.
2022-10-02 23:14:35 +02:00
Admiral H. Curtiss
a39f82cb1f
WiimoteEmu: Update button status from DesiredWiimoteState.
2022-10-02 23:14:34 +02:00
JosJuice
42775eed36
JitArm64: Fix BindToRegister in case Immediate && !set_dirty
...
Fixes a Rogue Squadron II regression from 9d73583
.
This set_dirty stuff is pretty tricky to reason about. I thought I
was clever when coming up with set_dirty, but maybe I was too clever
for my own good...
2022-10-02 22:38:00 +02:00
Admiral H. Curtiss
95cace837a
HW: Move DSP variables to Core::System.
2022-10-02 05:13:55 +02:00
Admiral H. Curtiss
c84835c53c
Merge pull request #11114 from JosJuice/jitarm64-divwx-imm
...
JitArm64: Fix divwx BindToRegister condition
2022-10-02 01:10:48 +02:00
Admiral H. Curtiss
f3a23db0e0
Core/State: Minor cleanup around the undo load state buffer.
2022-10-02 00:01:01 +02:00
Admiral H. Curtiss
e0d30e371c
Core/State: Rewrite threading behavior when multiple Save requests are happening. Should improve responsiveness when eg. mashing a save state button.
2022-10-02 00:00:29 +02:00
Robin Kertels
4e204a9a1a
VideoCommon: Remove special treatment for Android in video settings
2022-10-01 20:53:02 +02:00
JosJuice
8984777749
JitArm64: Call GetImm before BindToRegister
...
In case the register we're binding is the same as the immediate register,
we should fetch the immediate before calling BindToRegister. The way
the register cache currently works, calling GetImm after BindToRegister
actually does work, but it's better to not rely on it.
2022-10-01 20:44:51 +02:00
JosJuice
8902d2fe3a
JitArm64: Fix divwx BindToRegister condition
...
a is being used both as an immediate and as a register here.
Since it's being used as a register, it must be loaded.
2022-10-01 19:29:41 +02:00
Sepalani
481ddd1308
NetworkCaptureLogger: Allow PCAP shared read access on Windows
2022-09-29 23:08:25 +04:00
JosJuice
2e8d775df1
Jit64: boolX formatting fixes
2022-09-29 20:27:15 +02:00
Mai
1f2ec9afd6
Merge pull request #11052 from Tilka/shinkansen
...
Add emulated Shinkansen controller
2022-09-29 09:21:27 -04:00
Mai
0c19a1d87c
Merge pull request #11100 from Pokechu22/software-settings-merge
...
Use the same settings for the software renderer as other backends
2022-09-29 09:05:51 -04:00
Vincent Pelletier
fbf9d6ea17
SI: Ignore non-standard setGameID command
...
Avoids a panic when loading recent swiss. Not enough to have it run,
unfortunately.
2022-09-28 22:29:50 +00:00
Admiral H. Curtiss
dafe2c785a
Merge pull request #9481 from Sintendo/jit64boolx
...
Jit64: boolX constant optimizations
2022-09-28 23:40:26 +02:00
Admiral H. Curtiss
95615ab91b
Merge pull request #11096 from Sintendo/arm64boolx
...
JitArm64: boolX constant optimizations
2022-09-28 21:58:06 +02:00
Vincent Pelletier
85d2358157
EXI_DeviceMemoryCard: Drop comment about ChipErase behaviour
...
Tested on an official DOL-014 (251 blocks) memory card by executing the
0xf4 command on a card with content along its entire length and then
dumping the whole card: it reads as 0xff all the way through.
Therefor, the current implementation is already consistent with hardware.
2022-09-28 11:55:46 +00:00
Pokechu22
56fce3ba8a
Software: Remove dedicated texture/frame dumping infrastructure
...
Texture dumping can already be done using VideoCommon's system (and in fact the same setting already enabled *both* of these). Dumping objects/TEV stages/texture fetches doesn't currently have an equivalent, but could be added to the FIFO player instead.
2022-09-26 18:25:54 -07:00
Bram Speeckaert
4914ff25d6
JitArm64: boolX constant optimizations
...
A (partial) port of #9481 to ARM64. This commit adds special cases for
immediate values equal to 0 or 0xFFFFFFFF, allowing for more efficient
or no code to be generated.
2022-09-25 14:58:26 +02:00
Bram Speeckaert
9d73583ea3
JitArm64: Skip redundant imm to register writes
...
When a guest register is an immediate, it may be necessary to move this
value into a register. This is handled by gpr.R(), which lacks context
on how the register will be used. This leads to cases where the
immediate is written to a register, only for it to be overwritten. Take
for example this code generated by srwx:
0x5280031b mov w27, #0x18
0x53187edb lsr w27, w22, #24
gpr.BindToRegister() does have this context through the do_load
parameter, but didn't handle immediates. By adding this logic, we can
intelligently skip the write when do_load is false.
2022-09-25 10:04:51 +02:00
Admiral H. Curtiss
f106bc150a
Merge pull request #11083 from sepalani/bba-check
...
BBA/BuiltIn: Fix a crash during network stack exhaustion
2022-09-24 20:30:46 +02:00
Admiral H. Curtiss
63975556a4
Merge pull request #10175 from dreamsyntax/pause-on-panic
...
Core/DolphinQt: Add Pause on Panic Option for DSI Exceptions and Unknown Instruction
2022-09-24 20:28:09 +02:00
Admiral H. Curtiss
571e300e9e
Merge pull request #11047 from AdmiralCurtiss/netplay-save-options-rework
...
Netplay: Simplify save data options.
2022-09-24 20:26:05 +02:00
Sepalani
34858e934f
BBA/BuiltIn: Ignore UPnP request to itself
2022-09-23 20:54:26 +04:00
Sepalani
df53ebb59f
BBA/BuiltIn: Fix a crash during network stack exhaustion
2022-09-23 18:59:27 +04:00
JMC47
22197c09a3
Merge pull request #10781 from tellowkrinkle/UberVertexLoader
...
VideoCommon: Add dynamic vertex loader for ubershaders to reduce pipeline count
2022-09-20 17:14:07 -04:00
JosJuice
6203c101f8
JitArm64: Enforce correct alignment of SPR_TL
2022-09-20 18:55:28 +02:00
Admiral H. Curtiss
0d095b4d9b
Netplay: Simplify save data options.
2022-09-20 01:37:32 +02:00
Admiral H. Curtiss
39314ac162
Add more logging around Wii save copying for Netplay.
2022-09-20 01:37:31 +02:00
TellowKrinkle
4c629c2bee
VideoCommon: Add dynamic vertex loader to ubershaders
2022-09-19 16:28:23 -05:00
Admiral H. Curtiss
c21f2512c8
HW: Move g_SRAM to System.
2022-09-19 21:47:15 +02:00
Admiral H. Curtiss
0a517ebdbd
Core: Pass Netplay SRAM through boot process.
...
This removes the Netplay classes touching emulated hardware structures before emulation even starts.
2022-09-19 21:47:12 +02:00
Admiral H. Curtiss
9963637463
HW: Remove global state from functions in Sram.h.
2022-09-19 21:42:43 +02:00
JosJuice
720b3f5519
Merge pull request #11071 from AdmiralCurtiss/netplay-settings-style
...
Netplay: Rename variable names in NetSettings to match style guide.
2022-09-19 17:55:36 +02:00
JMC47
6f4f5b0b7b
Merge pull request #11067 from K0bin/cache-vertex-size
...
OpcodeDecoding: Cache vertex sizes
2022-09-18 22:38:06 -04:00
Admiral H. Curtiss
bec4850fc3
Netplay: Rename variable names in NetSettings to match style guide.
2022-09-19 01:25:46 +02:00
Robin Kertels
2db74e7f21
OpcodeDecoding: Get vertex size from the loader
2022-09-19 01:14:53 +02:00
Admiral H. Curtiss
07f86446a6
Netplay: Remove unused m_HostInputAuthority in NetSettings.
2022-09-18 23:00:08 +02:00
Admiral H. Curtiss
bf331ffa45
NetPlayClient: Treat power button event as a netplay stop.
2022-09-13 01:26:45 +02:00
Admiral H. Curtiss
35f6d12acc
NetPlayClient: Consolidate stopping code to function.
2022-09-13 01:26:45 +02:00
Admiral H. Curtiss
c4b3f2302a
NetPlayClient: Consolidate Wiimote buffer waiting code to function.
2022-09-13 01:26:45 +02:00
Tillmann Karras
f5670f870e
Add emulated Shinkansen controller
2022-09-11 17:12:19 +01:00
Mai
dbcf7fd2c9
Merge pull request #11049 from Tilka/tatacon
...
TaTaCon: fix possible hotswap problem
2022-09-11 05:12:12 -04:00
Admiral H. Curtiss
1732071a10
Netplay: Pass netplay settings via BootSessionData.
2022-09-11 04:18:26 +02:00
Tillmann Karras
b418441f4a
TaTaCon: fix possible hotswap problem
2022-09-11 00:16:00 +01:00
Mai
4edb3a8074
Merge pull request #11041 from AdmiralCurtiss/global-state-audio
...
HW: Move AudioInterface variables to Core::System.
2022-09-10 17:10:17 -04:00
Mai
804af55b3a
Merge pull request #11042 from AdmiralCurtiss/global-state-file-monitor
...
HW: Convert FileMonitor::Log into a class.
2022-09-10 17:08:25 -04:00
JosJuice
84507ec420
Merge pull request #10725 from t895/theme-merge
...
Android: App redesign with multi-theme system
2022-09-10 20:08:37 +02:00
Admiral H. Curtiss
b51d37fe49
HW: Convert FileMonitor::Log into a class.
2022-09-09 22:35:51 +02:00
Admiral H. Curtiss
001fe8f94d
HW: Move AudioInterface variables to Core::System.
2022-09-09 04:13:43 +02:00
Admiral H. Curtiss
426b5b1927
Merge pull request #10123 from sepalani/ai-cleanup
...
AudioInterface: Cleanup
2022-09-09 00:37:58 +02:00
Admiral H. Curtiss
d4fe54147e
Merge pull request #10757 from AdmiralCurtiss/show-memcard-path-in-gui
...
Qt: Show currently configured Memory Card path in the config window.
2022-09-08 21:12:21 +02:00
Mai
74851fe94a
Merge pull request #11029 from AdmiralCurtiss/global-state-dvd
...
HW: Move DVD variables to Core::System.
2022-09-07 23:40:16 -04:00
Admiral H. Curtiss
dbb0cfbc09
DSPLLE: Remove dead DSPSymbolDB.
2022-09-03 22:20:24 +02:00
Admiral H. Curtiss
2d45ce5c4e
HW: Move DVDInterface variables to Core::System.
2022-09-03 21:54:25 +02:00
Admiral H. Curtiss
c4d5804f60
HW: Move DVDThread variables to Core::System.
2022-09-03 21:54:25 +02:00
Sepalani
9b9f701ac5
AudioInterface: Add setters for AIS/AID sample rate
2022-09-03 23:36:34 +04:00
Sepalani
59eb1253a3
AudioInterface: Use anonymous namespace for static functions
2022-09-03 23:02:28 +04:00
Sepalani
f7a2972899
AudioInterface: Use IsPlaying method
2022-09-03 22:40:38 +04:00
dreamsyntax
78c6819f5e
Core: pause on panic handler option
2022-09-02 13:22:32 -07:00
Charles Lombardo
940a38f172
Android: App redesign with multi-theme system
2022-08-31 18:01:15 -04:00
Admiral H. Curtiss
c310e504cb
AudioCommon: Move sound stream variables to Core::System.
2022-08-31 21:44:21 +02:00
Sepalani
7dc647fd4c
BBA/BuiltIn: Add UPnP HTTP listener
2022-08-28 23:09:09 +04:00
Sepalani
7202cf2650
BBA/BuiltIn: Add SSDP multicast support
2022-08-24 21:29:57 +04:00
Sepalani
f992f8f38c
BBA/BuiltIn: Make network interface consistent
2022-08-24 21:05:18 +04:00
Admiral H. Curtiss
9c9962083d
Merge pull request #10956 from Dentomologist/address_cpp20_todo_comments
...
Address c++20 TODO comments
2022-08-24 17:18:56 +02:00
Admiral H. Curtiss
a7d358a97b
Merge pull request #11003 from sepalani/decode-error
...
Move SocketManager's DecodeError to Common
2022-08-24 17:01:07 +02:00
JosJuice
299aef945b
Merge pull request #11005 from t895/cover-only
...
Android: Add option to disable game cover text
2022-08-23 18:24:51 +02:00
Charles Lombardo
2caa1f3b43
Android: Add option to disable game cover text
2022-08-22 13:50:39 -04:00
Admiral H. Curtiss
1845a13cbe
Merge pull request #10905 from shuffle2/netplay-hash
...
netplay: use sha1 instead of md5
2022-08-22 15:57:49 +02:00
Sepalani
597fb9ff6d
Move SocketManager's DecodeError to Common
...
Fix thread safety issue
2022-08-22 14:02:26 +04:00
JMC47
498c06b85a
Merge pull request #10989 from CasualPokePlayer/fifo_reset_dual_core
...
Fix crashes in dual core mode on a PI_FIFO_RESET
2022-08-18 17:32:29 -04:00
CasualPokePlayer
ab8a8e6f84
Fix crashes in dual core mode on a PI_FIFO_RESET
2022-08-18 13:38:37 -07:00
Mai
39aa5f29a6
Merge pull request #10991 from Pokechu22/dsp-hle-ax-ucode-switch-state
...
DSPHLE/AX: Set state to WaitingForCmdListSize when switching uCodes
2022-08-18 10:34:57 -04:00
Pokechu22
f9e1933111
DSPHLE/AX: Set state to WaitingForCmdListSize when switching uCodes
...
Fixes https://bugs.dolphin-emu.org/issues/13017 . With uCode switching, the existing instance of AXUCode is re-activated when GBAUCode is done, but if the state remains as WaitingForNextTask, it won't be able to do anything. Instead, it needs to be in WaitingForCmdListSize.
(When the AX uCode is resumed, startpc is set to 0x0030, at least for 0x07f88145; this is the same location as MAIL_RESUME jumps to, so DSP_RESUME should be sent when the resuming happens; that's already handled by AXUCode::Update.)
2022-08-17 12:05:53 -07:00
Shawn Hoffman
4ae475b6a1
fix verifying wii dev signatures
...
allows verifying dev-signed discs and wads
2022-08-16 12:47:26 -07:00
Admiral H. Curtiss
650f172637
DolphinQt: Only show raw memory card path if it's not the default.
2022-08-16 00:23:36 +02:00
Admiral H. Curtiss
43d4923e78
Config: Allow passing std::nullopt for the region in GetMemcardPath() to use the region as configured in the path itself. Falls back to the fallback region if no region is in the path.
2022-08-16 00:20:58 +02:00
Léo Lam
be33e1079d
Merge pull request #10972 from AdmiralCurtiss/ios-fs-metadata-nop
...
IOS/FS: Skip writing FST if SetMetadata() changes nothing.
2022-08-11 16:16:45 +01:00
Admiral H. Curtiss
0d39c4a78a
IOS/FS: Skip writing FST if SetMetadata() changes nothing.
2022-08-10 06:28:23 +02:00
Admiral H. Curtiss
dcdba11ded
Merge pull request #10962 from askew-etc/inc-dec-select-state-hotkeys
...
Add hotkeys for incrementing/decrementing select state slot
2022-08-10 01:41:32 +02:00
Sage King
da803adf15
Work around for compiler bug on Debian and FreeBSD
2022-08-09 16:26:54 -06:00
Sage King
66276ac61b
Added type to SyncIndentifierComparison enum in SyncIdentifier.h in an
...
attempt to fix a failed call to operator<< in SendResponse()
2022-08-09 16:26:53 -06:00
Sage King
978b6a8724
Added comment explaining obscure folding syntax in NetPlayServer.cpp
2022-08-09 16:26:53 -06:00
Sage King
a12099404e
Added SendResponseToAllPlayers() and SendResponseToPlayer() to NetPlayServer.cpp and refactored OnConnect to use them
2022-08-09 16:26:52 -06:00
Sage King
477c20e28d
Updated comment explaining enet_peer_timeout's use in NetPlayClient.cpp and NetPlayServer.cpp; Corrected syntax related to PEER_TIMEOUT in NetplayClient.cpp
2022-08-09 16:26:52 -06:00
Sage King
2f367d7a9b
Updated PEER_TIMOUT in NetPlayCommon.h to use chrono literals; Updated NetPlayServer.cpp OnConnect() by putting commonly used code into named functions
2022-08-09 16:26:52 -06:00
Sage King
d81756e9b9
Refactored parameter to OnConnect() in NetPlayServer.cpp from rpac to received_packet
2022-08-09 16:26:51 -06:00
Sage King
9d14d95737
Removed code duplicating comments in NetPlayServer.cpp OnConnect()
2022-08-09 16:26:51 -06:00
Sage King
5dea8aaed0
Added initializer braces to Client player; in NetPlayServer.cpp OnConnect()
2022-08-09 16:26:50 -06:00
Sage King
d11df2b700
Refactored variable declared in NetPlayServer.cpp OnConnect() from npver to netplay_version
2022-08-09 16:26:50 -06:00
Mai
c2dd58c361
Merge pull request #10959 from JosJuice/frsp-subnormal
...
Interpreter: Fix rounding edge case in frsp
2022-08-09 18:17:21 -04:00
Scott Mansell
4c2d707538
Merge pull request #10940 from InvoxiPlayGames/ipc-discord
...
Add Discord presence ioctlv to /dev/dolphin
2022-08-08 08:11:42 +12:00
askew-etc
914f38753a
Add hotkeys for incrementing/decrementing selected state slot (like RetroArch)
2022-08-07 12:20:09 -05:00
Dentomologist
02cd4ecf7d
Core: Use std::chrono time_since_epoch
2022-08-06 13:28:28 -07:00
Dentomologist
ff26f6435e
Use structured binding for pair values
...
dir_path is used by PanicAlertFormatT, which prior to PR 10209 used a
lambda. Before c++20, referring to structured bindings in lambda captures
was forbidden. The problem is now doubly fixed, so put the structured
binding back in.
2022-08-06 13:28:28 -07:00
JosJuice
c5d9514cd9
Interpreter: Fix rounding edge case in frsp
...
Fixes the Dolphin bug mentioned in
https://github.com/dolphin-emu/hwtests/issues/45 .
Because this doesn't fix any observed behavior in games (no, 1080°
Avalanche isn't affected), I haven't implemented this in the JITs,
so as to not cause unnecessary performance degradations.
2022-08-06 18:54:19 +02:00
InvoxiPlayGames
f9e39cf200
Add Discord presence ioctlv to /dev/dolphin
2022-08-06 07:32:29 +01:00
Shawn Hoffman
3ca673a675
WiiSave: protect against a stack buffer overflow
2022-08-05 17:24:03 -07:00
Tillmann Karras
b8e64b1f43
AX: fix comments and variable names (NFC)
...
This command does not upload the MAIN buffers to CPU memory. This was
functionally fixed in f11a40f858
without
updating the comments and variable names.
2022-08-05 15:00:17 +01:00
Admiral H. Curtiss
5508c52a95
Merge pull request #10932 from JosJuice/nfs
...
DiscIO: Add support for the NFS format
2022-08-04 22:20:08 +02:00
JosJuice
a87dffe52d
DiscIO: Replace IsDataSizeAccurate with GetDataSizeType
...
Previously, we had WBFS and CISO which both returned an upper bound
of the size, and other formats which returned an accurate size. But
now we also have NFS, which returns a lower bound of the size. To
allow VolumeVerifier to make better informed decisions for NFS, let's
use an enum instead of a bool for the type of data size a blob has.
2022-08-04 22:00:59 +02:00
JosJuice
3a6df63e9b
DiscIO: Add support for the NFS format
...
For a few years now, I've been thinking it would be nice to make Dolphin
support reading Wii games in the format they come in when you download
them from the Wii U eShop. The Wii U eShop has some good deals on Wii
games (Metroid Prime Trilogy especially is rather expensive if you try
to buy it physically!), and it's the only place right now where you can
buy Wii games digitally.
Of course, Nintendo being Nintendo, next year they're going to shut down
this only place where you can buy Wii games digitally. I kind of wish I
had implemented this feature earlier so that people would've had ample
time to buy the games they want, but... better late than never, right?
I used MIT-licensed code from the NOD library as a reference when
implementing this. None of the code has been directly copied, but
you may notice that the names of the struct members are very similar.
c1635245b8/lib/DiscIONFS.cpp
2022-08-04 22:00:58 +02:00
JosJuice
bb27d4cc95
DiscIO/VolumeWii: Decouple "is encrypted" from "is hashed"
...
Needed for the next commit. NFS disc images are hashed but not encrypted.
While we're at it, also get rid of SupportsIntegrityCheck.
It does the same thing as old IsEncryptedAndHashed and new HasWiiHashes.
2022-08-04 20:29:22 +02:00
Tilka
3ad6e3abc2
Merge pull request #10768 from Pokechu22/dsp-hle-gba-class
...
DSPHLE: Eliminate global state in GBA and AX uCode + accuracy improvements
2022-08-04 13:50:30 +01:00
Tilka
8105d0034d
Merge pull request #10821 from Pokechu22/dimar-masking
...
DVDInterface: Mask upper bits of DIMAR in GC mode
2022-08-04 12:50:49 +01:00
Pokechu22
bf70026728
DSPHLE: Require implementing DoState
...
CARDUCode, GBAUCode, and INITUCode previously didn't have an implementation of it. In practice it's unlikely that this caused an issue, since these uCodes are only active for a few frames at most, but now that GBAUCode doesn't have global state, we can implement it there. I also implemented it for CARDUCode, although our CARDUCode implementation does not have all states handled yet - this is simply future-proofing so that when the card uCode is properly implemented, the save state version does not need to be bumped. INITUCode does not have any state to save, though.
2022-08-03 17:32:12 -07:00
Pokechu22
f2e833b5c4
DSPHLE: Eliminate global state in AX uCode
...
This also increases accuracy as to when specific mail is allowed, and correctly handles masking of the 0xCDD1 mails.
2022-08-03 17:32:12 -07:00
Pokechu22
8d66c29f33
DSPHLE: Eliminate global state in GBA uCode + accuracy improvements
...
The accuracy improvements are:
* The request mail must be 0xabba0000 exactly; both the low and high parts are checked
* The address is masked with 0x0fffffff
* Before, the global state meant that after the GBA uCode had been used once, it would accept 0xcdd1 commands immediately. Now, it only accepts them after execution has finished.
2022-08-03 17:32:12 -07:00
Pokechu22
8b65e84121
DSPHLE: Make all uCode implementations final classes
...
(Apart from AXUCode, which is inherited by AXWiiUCode.)
2022-08-03 17:32:12 -07:00
Mai
27669fc7c8
Merge pull request #10828 from JosJuice/jitarm64-32-bit-exception
...
JitArm64: Pass 32-bit temp GPR to WriteConditionalExceptionExit
2022-08-03 14:36:19 -04:00
Mai
a8b2174ce6
Merge pull request #10872 from shuffle2/timer
...
Timer improvements
2022-08-03 14:30:29 -04:00
Mai
ebb8402a24
Merge pull request #10934 from sepalani/bba-igmp
...
BBA/BuiltIn: Add minimal IGMP support
2022-08-03 14:17:41 -04:00
Mai
f93b04dc94
Merge pull request #10935 from Pokechu22/icache-dont-save-lookup-table
...
PPCCache: Stop storing lookup table in savestates
2022-08-03 14:14:39 -04:00
Minty-Meeo
347dd03c3f
Remove Vestigial Preprocessor Block in Jit64/Jit.cpp
...
"Common/GekkoDisassembler.h" became used by Release builds with commit 77e9aa48bc
, but this got left in by mistake.
2022-08-03 12:30:20 -05:00
Shawn Hoffman
403f3693da
NetPlay: use sha1 instead of md5
2022-08-02 22:25:05 -07:00
Shawn Hoffman
c7ce035a7f
NetPlay: rename md5 -> game digest
2022-08-02 22:25:05 -07:00
Shawn Hoffman
0fe99e9bc8
ThrottleCallback: correct units in log
...
make first invocation a bit more correct
2022-08-02 22:24:06 -07:00
Shawn Hoffman
3384b1385e
move "double time" code into State from Timer
...
Ideally the statesave format could be changed
to just store a u64 in the future
2022-08-02 22:24:06 -07:00
Shawn Hoffman
49218f9695
DolphinDevice: expose elapsed ms in GetSystemTime
2022-08-02 22:24:06 -07:00
Shawn Hoffman
09089eeee0
Common::Timer: use chrono::steady_clock internally
2022-08-02 22:24:06 -07:00
Tilka
e62ceab349
Merge pull request #10902 from shuffle2/aes
...
Implement hw accelerated AES
2022-08-02 18:28:47 +01:00
Pokechu22
134397754e
PPCCache: Stop storing lookup table in savestates
...
These lookup tables total 4 megabytes, and contain data that's entirely redundant to the actual cache state (as part of an optimization, though I'm not sure whether the optimization actually is useful). This change instead recomputes these lookup tables when loading the state (which involves filling the lookup table with a marker (0xff), and then setting the 128 * 8 valid entries (1 kilobyte)).
2022-08-01 16:36:59 -07:00
Shawn Hoffman
46ad8b9d68
Implement hw accelerated AES
2022-08-01 10:00:42 -07:00
Sepalani
4fa65ec9cf
BBA/BuiltIn: Add minimal IGMP support
2022-08-01 12:49:38 +04:00
Sepalani
bfc2d11891
BBA/BuiltIn: Simplify HandleARP
2022-08-01 12:48:33 +04:00
Sepalani
7e9711d738
BBA/BuiltIn: Rename m_fake_mac to m_router_mac
2022-08-01 12:48:32 +04:00
Sepalani
b029b468cd
BBA/BuiltIn: Fix MAC address issues with TCP and UDP
2022-08-01 12:48:32 +04:00
Sepalani
cc7cfe249e
BBA/BuiltIn: Move TryGetDataFromSocket
2022-08-01 12:48:32 +04:00
Sepalani
0f5fe2274a
BBA/BuiltIn: Save current MAC address
2022-08-01 12:48:32 +04:00
Sepalani
ec60416c00
BBA/BuiltIn: Add an ARP table
2022-08-01 12:48:32 +04:00