8cdad9ce8c
DSPHLE: map memory based on console mode
2023-09-29 20:48:10 +02:00
7c995000ae
Merge pull request #12206 from malleoz/ppc_reg_location_assert_improvement
...
PowerPC: reduce location assert cost
2023-09-29 20:08:05 +02:00
6541aa206d
Added RequestImage to AchievementManager
...
Image requests from RetroAchievements have a slightly different format from other requests, on account of being GET calls that return strings of image data, so this is a separate function that makes such calls. To handle this, I create a BadgeStatus object that ties each badge to a boolean flag for whether it is loaded and thus usable.
2023-09-28 22:47:15 -04:00
60e331e2e1
PowerPC: reduce location assert cost
2023-09-28 19:57:03 -04:00
a310b32525
Merge pull request #12207 from malleoz/decrease_emulation_speed_rollover_fix
...
DolphinQt: Fix decrease emulation speed hotkey rollover
2023-09-28 21:55:15 +02:00
908f90191d
Merge pull request #12204 from LillyJadeKatrin/retroachievements-bugfix
...
Retroachievements bugfix
2023-09-28 21:31:43 +02:00
50f04ea456
Refactored FetchGameData to incorporate the request directly instead of a different method, so that game_data can be processed directly under a lock.
2023-09-28 00:57:22 -04:00
6036a6db55
Updated AchievementManager StartRASession to properly lock inputs and outputs without locking during the network call.
2023-09-28 00:55:58 -04:00
7153284e9f
Updated AchievementManager ResolveHash to properly lock inputs and outputs without locking during the network call.
2023-09-28 00:55:58 -04:00
a29ec7d956
Updated AchievementManager VerifyCredentials to properly lock inputs and outputs without locking during the network call.
2023-09-28 00:55:58 -04:00
3c564078cd
Added AchievementManager ResponseType EXPIRED_CONTEXT for when operation inputs change between when an operation is queued and executed, and MALFORMED_OBJECT for when an rcheevos process method goes wrong.
2023-09-28 00:55:58 -04:00
31091fc975
Added GameLoaded check to AchievementProgressWidget.
2023-09-28 00:55:58 -04:00
b53962fd23
Cleaned up some issues with AchievementManager::CloseGame.
2023-09-28 00:55:57 -04:00
45c8597082
Merge pull request #12201 from fabricecaruso/master
...
SaveStates : Fix MainWindow.m_state_slot is not restored from Qt.ini Emulation/StateSlot.
2023-09-28 05:30:48 +02:00
5b6844901f
Merge pull request #12205 from LillyJadeKatrin/retroachievements-bugfix-2
...
AchievementsWindow: Fix rapid popups on initial opening.
2023-09-28 04:21:48 +02:00
a7c5f2fd14
Merge pull request #12200 from itsmattkc/pipe-fifo-fix
...
FileUtil: Don't try to retrieve size for FIFO pipe
2023-09-28 04:14:41 +02:00
2b2fd4217e
SaveStates: Fix MainWindow.m_state_slot is not restored from Qt.ini Emulation/StateSlot.
...
Select slot 2 and exit & launch Dolphin again. Slot 2 is selected in the menu, but saving from selected slot saves to slot 1.
2023-09-28 04:12:49 +02:00
53df01f7d8
Merge pull request #12172 from ArcaneNibble/sd
...
Steam Deck: Periodically reenable gyro
2023-09-28 04:10:27 +02:00
eac318a1d8
DolphinQt: Fix decrease emulation speed hotkey rollover
2023-09-27 21:40:16 -04:00
2a9121b66f
Reorganized the first-round AchievementsWindow startup to prevent items from being visible before their parents, thus getting rid of the rapid popups.
2023-09-26 23:31:04 -04:00
d0de837efd
HIDv4: Check Device Not Null Before Attaching
2023-09-26 18:10:29 +01:00
e16753472c
FileUtil: Don't try to retrieve size for FIFO pipe
2023-09-24 19:36:15 -07:00
def6cb0155
IOS/KD: Fix crash with KD Scheduler
2023-09-24 20:37:20 -04:00
15f42eb5d8
Merge pull request #12195 from LillyJadeKatrin/retroachievements-logging
...
Added log statements across AchievementManager.
2023-09-24 17:13:36 +02:00
c67cd65b53
Merge pull request #12190 from AdmiralCurtiss/fmt10
...
Update fmt to 10.1.1
2023-09-24 00:05:00 +02:00
da00191eb6
Added log statements across AchievementManager.
2023-09-23 01:32:43 -04:00
98dd10a716
Debugger/Memory: Fix unable to search mem2
2023-09-21 23:54:07 -04:00
24950ce0e0
JitArm64: Check packed NaNs without using extra register
...
A small optimization for AccurateNaNs.
2023-09-21 18:19:12 +02:00
8dbbae76de
Jit64: Optimize ps_merge01 with Rd == Rb
2023-09-21 18:03:39 +02:00
63467559b2
fmt 10.0.0-10.1.1 compile fixes
...
Implicit conversion operators and enums was removed for parity with std::format (fce74caa15
2023-09-21 01:19:23 +02:00
579ccb0710
Merge pull request #12160 from AdmiralCurtiss/achievement-log
...
Common/LogManager: Add logging category for Achievements.
2023-09-19 22:01:15 +02:00
9862ba4548
Merge pull request #12155 from krnlyng/jit_block_map_msr_fast
...
JitArm64/Jit64: Extend the fast lookup mmap-ed segment further to avoid needing to check the msr bits.
2023-09-17 15:13:53 +02:00
a79fe768e3
Jit64: Simplify ps_sum1
2023-09-17 11:04:37 +02:00
cc7fadfa4b
Merge pull request #12181 from JosJuice/curl-response-code-long
...
Common: Fix HttpRequest::GetLastResponseCode stack corruption
2023-09-16 16:48:47 +02:00
aa4de6516f
Common: Fix HttpRequest::GetLastResponseCode stack corruption
...
Should fix https://bugs.dolphin-emu.org/issues/13353 .
2023-09-16 16:01:28 +02:00
fd9c970621
JitArm64/Jit64: Extend the fast lookup mmap-ed segment further to avoid needing to check the msr bits.
...
And in order to avoid a double dereference in the dispatcher, directly store
the normalEntry in the map.
The index to the block map becomes ((((DR<<1) | IR) << 30) | (address >> 2)).
This has been chosen since the msr bits change less often than the address,
thus we keep nearby entries together.
Also do not call the C dispatcher in case the assembly dispatcher didn't
find a block, since it wouldn't find a block either due to the 1:1 mapping,
except when falling back to the non shm segment lookup table.
2023-09-15 19:46:15 +03:00
1a821465f4
Merge pull request #12166 from iwubcode/cubemap_shader_texture_integration
...
VideoCommon: add cubemap to ShaderAsset and TextureAsset
2023-09-12 16:56:26 +02:00
308a52a782
Merge pull request #12165 from noahpistilli/scheduler-downloader
...
IOS/KD: Implement Download Scheduler
2023-09-12 16:22:23 +02:00
3dada564bf
Merge pull request #12177 from AdmiralCurtiss/noreserve
...
Common/MemArena: Set MAP_NORESERVE in LazyMemoryRegion on Linux.
2023-09-12 16:21:59 +02:00
392dfbe05f
JitArm64: Deduplicate the gather pipe exception check
...
We had two nearly identical copies of the gather pipe exception checking
code right next to each other, with the only difference being the
register used. Let's unify them, like in Jit64.
2023-09-10 16:34:10 +02:00
d16bedd5c4
Merge pull request #12178 from JosJuice/jit-gp-pc
...
Jit: Use correct address when checking fifoWriteAddresses
2023-09-10 15:58:23 +02:00
92d67df4e9
Merge pull request #12138 from JosJuice/jit-gp-check-discard
...
Jit: Don't discard before gather pipe interrupt check
2023-09-10 15:10:37 +02:00
7869abf0e6
Common/MemArena: Set MAP_NORESERVE in LazyMemoryRegion on Linux.
2023-09-10 14:52:34 +02:00
3f6a976e0f
IOS/KD: Implement Download Scheduler
2023-09-10 07:47:15 -04:00
34b0a6ea90
Jit: Check for discarded registers when flushing
...
This adds a check for the bug addressed by the previous commit.
2023-09-10 12:54:52 +02:00
5902b5b113
PPCAnalyst: Don't discard before gather pipe interrupt check
...
This bug has been lurking in the code ever since I added the discard
functionality. It doesn't seem to be triggered all that often,
and on top of that the emitted code only runs conditionally, so I'm not
sure if people have been affected by this bug in practice or not.
2023-09-10 12:54:52 +02:00
f7f4da2be8
Jit: Use correct address when checking fifoWriteAddresses
...
We need to check for the address of the *previous* instruction, because
checking fifoWriteAddresses happens not at the end of the instruction
that triggered it but at the start of the next instruction.
2023-09-10 12:54:18 +02:00
1a0f0e7e96
Merge pull request #12081 from JosJuice/jitarm64-debug-exit-pc
...
JitArm64: Store PC on debug exit
2023-09-10 02:10:29 +02:00
5e0cf795e3
Merge pull request #12169 from jordan-woyak/widescreen-heuristic-gameini
...
VideoCommon: Expose the widescreen heuristic's standard and widescreen values in onion config.
2023-09-09 16:51:11 +02:00
911c469cf5
Common/LogManager: Add logging category for Achievements.
2023-09-09 14:47:20 +02:00
860acfb15d
Steam Deck: Periodically reenable gyro
2023-09-07 19:56:58 +01:00
57e56f4bc2
Merge pull request #12174 from AdmiralCurtiss/jitcache-32bit
...
Core/JitCache: Don't try to allocate the fast block map on 32-bit builds.
2023-09-07 19:29:04 +02:00
cf2a1f29b7
Core/JitCache: Don't try to allocate the fast block map on 32-bit builds.
2023-09-07 14:48:57 +02:00
422bc7a627
Common/MemArena: A zero-byte allocation is invalid.
2023-09-07 14:41:24 +02:00
c14bc6ea4c
Common/MemArena: mmap returns MAP_FAILED on error, not nullptr.
2023-09-07 13:59:33 +02:00
a20bb3e05b
Common/MemArena: Assert return value of LazyMemoryRegion::Clear()'s mmap() call.
2023-09-07 04:00:22 +02:00
7cc4304918
VideoCommon: Expose the widescreen heuristic's standard and widescreen ratio values in onion config.
2023-09-06 18:45:28 -05:00
c0440df288
Merge pull request #12029 from LillyJadeKatrin/retroachievements-bugfix-2
...
RetroAchievements - Rearranged startup process
2023-09-06 12:23:52 -04:00
3b5b9e0fc0
Merge pull request #12028 from LillyJadeKatrin/retroachievements-bugfix
...
RetroAchievements - Add Rich Presence to Achievement Dialog Header
2023-09-06 12:20:20 -04:00
38bd04c439
Add Rich Presence to Achievement Dialog Header
...
This refactors the Rich Presence generation to store to a member field that can be exposed to the UI to display the Rich Presence in the achievement header. It still updates at its original rate of once per two minutes, but calls an update on the dialog when that ticks.
2023-09-06 10:01:33 -04:00
589834f562
VideoCommon: add cubemap as a sampler target for shaders, add cubemap as a valid texture asset
2023-09-05 21:11:19 -05:00
76a00551d1
Merge pull request #11419 from OatmealDome/widescreen
...
VideoCommon: Allow widescreen heuristic's constants to be overridden by onion config
2023-09-05 13:25:07 -04:00
4938b99600
VertexManagerBase: Allow widecreen heuristic constants to be overriden by onion config
2023-09-05 11:50:49 -04:00
de781a6fa7
RenderBase: Allow widescreen heuristic's transition threshold to be overridden by onion config
2023-09-05 11:49:22 -04:00
9419d92446
Merge pull request #12139 from iwubcode/more_shader_texture_properties
...
VideoCommon: add additional texture sampler types to ShaderAsset
2023-09-04 22:45:56 -04:00
82ea4f4c70
Merge pull request #12137 from iwubcode/custom_pipeline_more_error_checking
...
VideoCommon: additional error checking for CustomPipelineAction
2023-09-04 22:43:41 -04:00
627282473b
Merge pull request #12136 from iwubcode/texture_metadata_struct
...
VideoCommon: add TextureData structure with metadata
2023-09-04 22:40:50 -04:00
d0afe36269
Disable Arbitrary Mipmap Detection checkbox when GPU Texture Decoding is enabled
...
See https://bugs.dolphin-emu.org/issues/13049
2023-09-04 13:24:05 -07:00
b969d89103
Disable Texture Filtering dropdown when Manual Texture Sampling is checked
...
See https://bugs.dolphin-emu.org/issues/13049
2023-09-04 13:24:03 -07:00
efabcaf6ea
Merge pull request #12159 from noahpistilli/evc+rgnsel
...
Add Everybody Votes Channel and Region Select to WiiLink config
2023-09-04 12:00:02 -04:00
348e60cd3f
Rearranged RetroAchievements startup process
...
Moved AchievementManager Init further down in the MainWindow constructor; its original position was because it had an impact on the contents of the menu bar, and this is no longer the case.
2023-09-04 09:32:13 -04:00
3e9c9a3e8d
Merge pull request #12004 from TellowKrinkle/MetalMultiTarget
...
VideoBackends:Metal: Multi render target support
2023-09-03 23:31:38 -04:00
900439ea0d
Merge pull request #12102 from iwubcode/cubemap_custom_texture
...
VideoCommon: add ability to load cube maps into custom texture data
2023-09-03 18:29:00 -04:00
fb852a5062
VideoCommon: Deinit Graphics Mod Manager implicitly
2023-09-03 16:06:08 -04:00
fdaa82f96d
Add Everybody Votes Channel and Region Select to WiiLink config
2023-09-03 15:56:02 -04:00
143a13622f
Merge pull request #12108 from noahpistilli/kd-check-mail
...
IOS/KD: Implement NWC24_CHECK_MAIL_NOW
2023-09-03 19:52:26 +02:00
2154941c2c
IOS/KD: Implement NWC24_CHECK_MAIL_NOW
2023-09-03 13:05:58 -04:00
f063fb31b3
Merge pull request #12149 from noahpistilli/no-response-header-rsa
...
IOS/KD: Check if a file has an RSA signature
2023-09-03 03:50:18 +02:00
fa2bc535f1
IOS/KD: Check if a file has an RSA signature
2023-09-02 21:39:54 -04:00
46a596c0d3
Merge pull request #12148 from Dentomologist/fifo_convert_memoryupdate_type_to_enum_class
...
Fifo: Convert MemoryUpdate::Type to enum class
2023-09-03 03:34:35 +02:00
62fee2f3b6
VideoCommon: add loading cube maps from DDS files and loading it into our custom texture object. Custom texture object now has the concept of slices in addition to levels. Traditional custom textures have a single slice
2023-09-02 20:20:09 -05:00
9cabf20aaa
Fifo: Convert MemoryUpdate::Type to enum class
2023-09-02 18:19:26 -07:00
6d04618921
Merge pull request #12157 from Dentomologist/texturecachebase_add_m_prefix
...
TextureCacheBase: Add m_ prefix to member variables
2023-09-03 03:10:57 +02:00
bd57d17dee
Merge pull request #12079 from JosJuice/blr-no-fastmem
...
Jit: Allow BLR optimization without fastmem
2023-09-02 12:45:39 -04:00
d5d3eb5025
TextureCacheBase: Add m_ prefix to member variables
2023-09-01 22:52:17 -07:00
f1c1c6ded6
JitCache: Fix potentially dangling pointer to fast block map.
...
Whenever JitBaseBlockCache::Clear() got called, it threw away the memory mapping for the fast block map and created a new one. This new mapping typically got mapped at the same address at the old one, but this is not guaranteed. The pointer to the mapping gets embedded in the generated dispatcher code in Jit64AsmRoutineManager::Generate(), which is only called once on game boot, so if the new mapping ended up at a different address than the old one, the pointer in the ASM pointed at garbage, leading to a crash.
This fixes the issue by guaranteeing that the new mapping is mapped at the same address.
2023-09-02 04:03:22 +02:00
5bd7756064
Common/MemArena: Add LazyMemoryRegion to represent a zero-initialized memory region whose pages are only allocated on first access.
2023-09-02 04:02:10 +02:00
4131dffae9
Jit: Allow BLR optimization without fastmem
...
While both fastmem and the BLR optimization depend on fault handling,
the BLR optimization doesn't depend on fastmem, and there are cases
where you might want the BLR optimization but not fastmem. For me
personally, it's useful when I try to use a debugger on Android and have
to disable fastmem so I don't get SIGSEGVs all the time, but it would be
especially useful for iOS users.
2023-08-29 22:55:29 +02:00
af2c32635a
Jit: Add more error checking to ProtectStack
2023-08-29 22:46:50 +02:00
1b2d0c0507
Merge pull request #10575 from JosJuice/jitbase-auto-clear
...
Jit: Automatically clear cache when JIT settings are updated
2023-08-29 15:56:25 -04:00
8c2c665af3
Jit: Check MSR state in BLR optimization
...
When we execute a JIT block, we have to make sure that both the PC and
the DR/IR bits of MSR are the same as they were when the block was
compiled. When jumping to a block from the dispatcher, this is done in
the way you would expect: By checking the PC and the relevant MSR bits.
However, when returning to a block using the BLR optimization, we only
check the PC. Checking the MSR bits is done by instead resetting the
stack when the MSR changes, making PC checks afterwards fail.
Except... We were only resetting the stack on rfi instructions. There
are actually many more ways for the MSR to change, and we weren't
covering those at all. I looked into resetting the stack on all of them,
but it would be pretty cumbersome both in terms of writing the code and
in terms of how often at runtime we'd have to reset the stack, so I
think the better option would be to check the MSR bits along with the
PC. That's what this commit implements.
2023-08-29 19:05:26 +02:00
69db8a615f
Merge pull request #12145 from JosJuice/ubershaderpixel-uint
...
VideoCommon: Fix GLSL uint handling in UberShaderPixel
2023-08-29 12:33:54 +02:00
df120b0630
Merge pull request #12000 from Filoppi/window_res_fix
...
Video: Fix issues with the window presentation
2023-08-28 23:50:50 +02:00
357db03fc8
Merge pull request #12030 from LillyJadeKatrin/retroachievements-bugfix-3
...
RetroAchievements - Fixed Leaderboard Scored message format
2023-08-28 23:28:37 +02:00
5b112dbf2c
VideoCommon: Fix GLSL uint handling in UberShaderPixel
2023-08-28 21:17:01 +02:00
b922f4baa6
JitArm64: Write PC when calling MMU.cpp
...
This functionality was in Jit64 but not JitArm64.
2023-08-27 18:45:34 +02:00
58f247290f
Use latest resolution value for resolution hotkey OSD
...
Because CPU thread config changed callbacks are no longer instant,
g_Config.iEFBScale doesn't yet contain the new value when the hotkey OSD
code tries to read it.
Should fix https://bugs.dolphin-emu.org/issues/13343 .
2023-08-27 15:38:00 +02:00
f982c556b5
VideoCommon: add additional texture sampler types to ShaderAsset
2023-08-26 12:12:37 -05:00
7daa19f40d
JitArm64: Avoid loading compilerPC multiple times if it's already in a register.
2023-08-26 18:14:07 +03:00
85281e76ee
Jit: Remove unnecessary member variables
2023-08-26 17:05:04 +02:00
07d70db46b
DolphinQt: Allow toggling most JIT debug settings at any time
...
There's no reason not to allow this now that these settings are
cleanly integrated into the new config system. (Actually, maybe
we could even have done this before the previous commit...)
2023-08-26 17:05:04 +02:00
28e8117b90
Jit: Automatically clear cache when JIT settings are updated
...
This fixes a problem where changing the JIT debug settings on
Android while a game was running wouldn't cause the changed settings
to apply to code blocks that already had been compiled.
2023-08-26 17:04:56 +02:00
cd31da97d6
Merge pull request #11191 from JosJuice/jitarm64-no-checked-entry
...
JitArm64: Never check downcount on block entry
2023-08-26 17:00:08 +02:00
799ce0dc9d
Merge pull request #12097 from Dentomologist/ios_remove_unused_member_variables
...
IOS: Remove unused member variable from SharedContentMap and UIDSys
2023-08-26 16:41:45 +02:00
2502e412b3
Merge pull request #12117 from JosJuice/config-callback-cpu
...
Don't call RunAsCPUThread in config callbacks
2023-08-26 16:34:46 +02:00
d8e35438bd
Merge pull request #12127 from sepalani/ascii_
...
MemoryViewWidget: Fix some characters being truncated
2023-08-26 14:56:26 +02:00
65a9be581f
Merge pull request #12121 from JosJuice/discscrubber-volume-ptr
...
DiscIO: Don't keep volume pointer in DiscScrubber
2023-08-26 14:31:15 +02:00
dec2990053
Merge pull request #12128 from Dentomologist/gcc_suppress_ppcstate_off_warning_spam
...
GCC: Suppress PPCSTATE_OFF invalid-offsetof warnings
2023-08-26 14:22:04 +02:00
e876045e56
Merge pull request #12135 from Dentomologist/jitarm64_resolve_deprecated_enum_conversion_warning
...
JitArm64: Resolve deprecated enum conversion warning
2023-08-26 14:18:58 +02:00
5c4671f573
Merge pull request #12126 from JosJuice/small-vector
...
Move SmallVector to Common
2023-08-26 14:15:18 +02:00
9223540bf4
VideoCommon: additional error checking for CustomPipelineAction and move the pixel shader asset cache time back to being calculated during texture creation
2023-08-24 00:47:48 -05:00
7c52a52440
VideoCommon: add TextureData structure that contains the raw texture data, a sampler, and the type of texture information
2023-08-24 00:35:31 -05:00
a650a16f4c
JitArm64: Resolve deprecated enum conversion warning
...
Resolve warning caused by using values from two different enums in a
conditional expression which was deprecated in c++20.
The warning in question is clang -Wdeprecated-anon-enum-enum-conversion
and gcc -Wenum-compare.
2023-08-23 14:38:52 -07:00
ba99d17ac0
VideoCommon: Fix custom shader constants on GLES
2023-08-22 19:38:18 +02:00
4223cd0264
Merge pull request #12130 from JosJuice/translation-fixes
...
Fixes to translatable strings
2023-08-22 16:44:36 +02:00
6e88c44d5d
Move SmallVector to Common
...
We had one implementation of this type of data structure in Arm64Emitter
and one in VideoCommon. This moves the Arm64Emitter implementation to
its own file and adds begin and end functions to it, so that VideoCommon
can use it.
You may notice that the license header for the new file is CC0. I wrote
the Arm64Emitter implementation of SmallVector, so this should be no
problem.
2023-08-22 13:19:49 +02:00
55fba7c0ed
VideoCommon/GraphicsModAsset: Error out if config key is not a string.
2023-08-22 02:40:08 +02:00
58ab94c30c
GCC: Suppress PPCSTATE_OFF invalid-offsetof warnings
...
Modify PPCSTATE_OFF and PPCSTATE_OFF_ARRAY macros when using GCC to
avoid useless log spam. Specifically, use a consteval lambda with gcc
_Pragma statements to disable the -Winvalid-offsetof warning inside the
macros.
Each successful build (and many failing ones) on the Android buildbot
generates almost 300 cases of -Winvalid-offsetof, resulting in thousands
of lines of log spam per build. In addition to bloating the log filesize
these spurious warnings make it harder to find actual warnings.
These warnings are generated by calls to the macros PPCSTATE_OFF and
PPCSTATE_OFF_ARRAY, which in turn are used by many other macros used by
the JIT. The ultimate cause is that offsetof is only conditionally
supported on non-standard-layout types, which includes the PowerPCState
struct.
To address potential questions of whether there's a better way to handle
this:
The obvious solution would be to modify PowerPCState so that it does
have a standard layout. This is unfortunately impractical.
To have a standard layout a type can only contain other types with
standard layouts. None of the stl containers are guaranteed to have
standard layouts, and PowerPCState contains a std::tuple and std::array.
PowerPCState also contains a PowerPC::Cache and InstructionCache which
themselves contain std:arrays and std::vectors.
Furthermore InstructionCache derives from Cache, and a derived class can
only have standard layout if at most one class in its hierarchy has a
non-static data member, but both classes have such members. Making
InstructionCache have a standard layout would require duplicating all
the functionality of Cache so it no longer derived from it, as well as
replacing the stl containers. This might require having a raw pointer to
said containers, with the manual memory management that implies.
All of that would be much more disruptive than would be justified to get
rid of some warnings (however annoying they might be). This is
compounded by the fact that PowerPCState hasn't had a standard layout
for a long time, if ever, and if the PPCSTATE_OFF macros weren't working
reliably it would have become obvious a long time ago.
As to why I picked the lambda solution over other potential changes:
- Keeping the define as-is and wrapping some gcc #pragmas around it
doesn't work because the pragmas don't get included when the define is
substituted to the call site.
- Keeping the define as a non-lambda expression and using inline
_Pragma() statements would ideally be better and works fine for msvc,
but fails for GCC with "'#pragma' is not allowed here".
- Turning off -Winvalid-offsetof globally for gcc would work, but there
might be other contexts where offsetof is problematic and GCC seems to
be the only compiler warning about it.
2023-08-21 14:01:11 -07:00
573863703a
MemoryViewWidget: Fix some characters being truncated
2023-08-21 22:02:44 +04:00
e7c2133160
Fixes to translatable strings
2023-08-21 16:29:52 +02:00
5506121685
VideoCommon: add support to graphics mod manager to load in assets and pass it to graphics actions
2023-08-20 18:53:27 -05:00
6ea0d17802
VideoCommon: when graphics settings change, trigger a reload of all custom shaders
2023-08-20 18:53:27 -05:00
931a8aa413
VideoCommon: add milliseconds elapsed time value to pixel shaders as a uniform to be able to support animation effects in custom shaders
2023-08-20 18:53:27 -05:00
c7191382be
VideoCommon: add custom pipeline action
2023-08-20 18:53:27 -05:00
d320366954
VideoCommon: add custom shader cache to VertexManagerBase, supporting custom pixel shaders by replacing the existing pipeline with a modified one
2023-08-20 18:53:27 -05:00
bedbf2b8c6
VideoCommon: add custom shader cache
2023-08-20 18:53:27 -05:00
dbaf24ef09
VideoCommon: add data needed to support custom pixel shaders to graphics mod actions
2023-08-20 18:53:27 -05:00
4283d76718
VideoCommon: uber pixel shader gen changes needed to support custom pixel shaders in graphics mods
2023-08-20 18:53:27 -05:00
e704385fce
VideoCommon: pixel shader gen changes needed to support custom pixel shaders in graphics mods
2023-08-20 18:53:27 -05:00
c3a370839a
VideoCommon: add helper functions to handle generating custom lighting code for a custom pixel shader
2023-08-20 18:53:27 -05:00
0da5cf60a8
VideoCommon: add custom pixel shader definition and custom shader header to shadergen common as it will be used by both the special and uber shader variant of pixel shaders
2023-08-20 18:53:27 -05:00
f19651e49b
Merge pull request #11025 from AdmiralCurtiss/hle-printf
...
HLE_OS: Manually handle printfs from emulated software to prevent emulated software from crashing Dolphin with an invalid printf formatting string.
2023-08-20 01:31:49 +02:00
d34d3bd513
JitArm64: Optimize mfsrin/mtsrin address calculations
...
This does require another register, but we skip having to use shifted
ADD, which takes two cycles on some CPUs, and we gain instruction-level
parallelism.
2023-08-19 21:37:06 +02:00
c70dcf99dd
Jit: Some mcrxr optimizations
2023-08-19 21:13:56 +02:00
5ea1cc5406
JitArm64: Fix mcrxr
...
Likely an incorrect translation of Jit64's LEA with SCALE_2.
2023-08-19 20:57:32 +02:00
5931d74d52
JitArm64: Remove unnecessary BindToRegister calls
...
BindToRegister is only needed when writing to a register.
2023-08-19 19:46:53 +02:00
9192128c50
Jit: Handle imm msr in EmitStoreMembase
...
This makes Jit64::mtmsr more optimized in particular.
2023-08-19 19:45:35 +02:00
0f64df3e3e
DiscIO: Don't keep volume pointer in DiscScrubber
...
Keeping the pointer creates use-after-free opportunities, and we don't
have much reason to keep it around anyway.
2023-08-19 17:30:22 +02:00
d36f0fff4c
Jit64: Actually update membase register after GlobalAdvance().
2023-08-19 17:00:01 +02:00
ed7894924c
Merge pull request #12048 from krnlyng/someothertest
...
Jit: Load the memory register only when the msr bits have changed and do not use jumps to load it.
2023-08-19 09:49:29 +02:00
b6bfa10ace
Merge pull request #11996 from Dentomologist/remove_pointless_pauseandlock_functions
...
EXI: Remove pointless PauseAndLock functions
2023-08-18 21:35:56 +02:00
bb4ed1c450
Merge pull request #12118 from AdmiralCurtiss/tas-window-translatable
...
DolphinQt/TASInputWindow: Make 'Enable Controller Input' translatable.
2023-08-18 21:33:23 +02:00
8a96ce73f6
Merge pull request #12044 from jmlee337/upnpport
...
Do not try portmapping when using traversal server
2023-08-18 21:28:52 +02:00
9a51215af3
Merge pull request #12083 from JosJuice/android-controlled-by-gamepad
...
InputConfig: Update IsControllerControlledByGamepadDevice for Android input overhaul
2023-08-18 21:27:26 +02:00
b3902397cb
DolphinQt/TASInputWindow: Make 'Enable Controller Input' translatable.
2023-08-18 21:02:30 +02:00
3441fe6efc
Merge pull request #11999 from Filoppi/post_process_fixes
...
Video: implement output resampling (upscaling/downscaling) methods
2023-08-18 20:33:09 +02:00
a9ec2a6e41
Merge pull request #12116 from AdmiralCurtiss/log-colors
...
DolphinQt/LogWidget: Restore log window colors.
2023-08-18 09:00:43 +02:00
8bca9a864f
Video: The `Auto` internal resolution scaling wasn't working correctly if the window weird aspect ratios (e.g. 32:9), beacuse it would account for the the portion of the image that will show black bars into the calcuations to find the best matching resolution
2023-08-18 02:14:00 +03:00
6c7f34d5da
Video: The `Auto-Adjust Window Size` setting was calculating the window size based on the resolution of the window in the previous frame if we used the "stretch" aspect ratio setting, so it's result would be self influence in a loop and behave unreliably (e.g. when changing resolution between Auto/Native/2x the automatic window scaling would behave randomly)
2023-08-18 02:14:00 +03:00
cb34d1aafe
Video: There was always a black line around one of the 4 edges (top/left/bottom/right) of the window because the final output size wasn't calculated right (unless the aspect ratio was set to stretch)
2023-08-18 02:14:00 +03:00
fae3aee9e0
Video: The `% 4` that was done on the rendering resolution was only meant to be done when recording videos (due to encoding limitations) but one case was missed (this had no consequences really, as it was just in the code that automatically resizes the window). The hardcoded `4` has been replaced with `VIDEO_ENCODER_LMC` for clarity.
2023-08-18 02:14:00 +03:00
80b453082d
Video: fix post process shaders with parameters failing to build on OpenGL
...
This was because the shader uniforms between the pixel and vertex shaders
were willingly left different, to avoid filling the vertex shader with unnecessary
params. Turns out all backends are fine with this except OGL.
The new behaviour is now much more consistent and well explained,
the "default" shaders are the ones that always run, and the non default
ones are the user selected ones (if any).
2023-08-18 02:00:56 +03:00
39d96a21a8
Video: Improved Tooltips & Bicubic ( #5 )
...
Edited by Filoppi
2023-08-18 02:00:56 +03:00
ca93a5191f
Video: Added Box Resampling
...
Edited by Filoppi
2023-08-18 02:00:56 +03:00
2edf81cdb0
Video: implement output resampling (upscaling/downscaling) methods
2023-08-18 02:00:55 +03:00
1854ff0142
Merge pull request #12003 from Filoppi/auto_hdr
...
Add AutoHDR post process shader
2023-08-18 00:20:08 +02:00
ecf5870a91
Merge pull request #12115 from AdmiralCurtiss/advanced-config
...
DolphinQt/AdvancedPane: UI improvements.
2023-08-18 00:16:59 +02:00
42e893d6be
Merge pull request #12114 from AdmiralCurtiss/color-correction-button
...
DolphinQt/EnhancementsWidget: Use custom tooltip for Color Correction button.
2023-08-18 00:16:47 +02:00
a08792033a
Merge pull request #12103 from iwubcode/asset_load_system_time
...
VideoCommon: asset load time is now stored as a chrono system_clock time
2023-08-18 00:14:29 +02:00
b62c25864f
CPUThreadConfigCallback: Remove some CPU thread asserts
...
Turns out that we have two subsystems that want to register CPU thread
callbacks from a different thread than the CPU thread: FreeLookConfig
and VideoConfig. Both seem to happen from the host thread before the CPU
thread starts, so there's no thread safety issue. But ideally, if we
want to allow registering callbacks from threads other than the CPU
thread, we should make registering callbacks actually thread-safe. This
is an unsolved problem for the regular Config system, so I would like to
leave it outside the scope of this PR.
2023-08-17 19:19:26 +02:00
7197e3abd0
Use structs for config callback IDs
...
This way you can't mix up regular config callback IDs and CPU thread
config callback IDs. (It would be rather bad if you did!)
2023-08-17 19:19:26 +02:00
2b17e89336
Config: Don't clear callbacks on shutdown
...
This fixes a problem that started happening in CoreTimingTest after the
previous commit. CPUThreadConfigCallback registers a Config callback
only once per run of the process, but CoreTimingTest calls
Config::Shutdown after each test, and Config::Shutdown was clearing all
callbacks, preventing the callback from running after that.
2023-08-17 19:19:25 +02:00
71ce8bb6f0
Don't call RunAsCPUThread in config callbacks
...
In theory, our config system supports calling Set from any thread. But
because we have config callbacks that call RunAsCPUThread, it's a lot
more restricted in practice. Calling Set from any thread other than the
host thread or the CPU thread is formally thread unsafe, and calling Set
on the host thread while the CPU thread is showing a panic alert causes
a deadlock. This is especially a problem because 04072f0https://bugs.dolphin-emu.org/issues/13108 .
2023-08-17 19:19:25 +02:00
a9cba9be36
DolphinQt/LogWidget: Restore log window colors.
2023-08-16 19:55:18 +02:00
a34f221782
Core/PowerPC: Return AvailableCPUCores() as a std::span.
2023-08-16 19:25:03 +02:00
51f807b63a
DolphinQt/AdvancedPane: Update all GUI elements from config in Update().
2023-08-16 19:25:03 +02:00
ccee66dc80
DolphinQt/AdvancedPane: Use ConfigBool for MMU, Pause on Panic, and Write-Back Cache.
2023-08-16 19:25:03 +02:00
23ae8c439c
Merge pull request #12112 from JosJuice/hires-texture-encoding
...
VideoCommon: Fix std::filesystem::path encoding conversion
2023-08-16 18:39:18 +02:00
86910f406e
VideoCommon: Fix std::filesystem::path encoding conversion
...
In std::string, you can store strings using any encoding, but in Dolphin
we have decided to use UTF-8. The problem is that if you convert between
std::string and std::filesystem::path using the built-in methods, the
standard library will make up its own assumption of what encoding you're
using in the std::string. On most OSes this is UTF-8, but on Windows
it's whatever the user's code page is.
What I believe is the C++ standard authors' intended solution to this is
to use std::u8string instead of std::string, but that's a big hassle to
move over to, because there's no convenient way to convert between
std::string and std::u8string. Instead, in Dolphin, we have added helper
functions that convert between std::string and std::filesystem::path in
the manner we want. You *always* have to use these when converting
between std::string and std::filesystem::path, otherwise we get these
kinds of encoding problems that we've been having with custom textures.
Fixes https://bugs.dolphin-emu.org/issues/13328 .
2023-08-16 09:56:56 +02:00
177ac0cd44
Merge pull request #12111 from OatmealDome/old-amd-bug
...
Remove `BUG_BROKEN_FRAGMENT_SHADER_INDEX_DECORATION`
2023-08-16 09:20:49 +02:00
10c5da6f62
Merge pull request #12107 from MikeIsAStar/retrieve-page-table-information-from-data-cache
...
Retrieve page table information from the data cache
2023-08-15 22:01:01 -07:00
b969282b72
Remove out-dated hack of AMD driver issue WRT dual-source blending output index.
2023-08-15 23:58:29 -04:00
eeb73460ab
VideoCommon: asset load time is now stored as a chrono system_clock time, so that times can be fabricated in a future feature (without creating a file to do so)
2023-08-15 22:02:28 -05:00
a10d768c63
Merge pull request #12104 from iwubcode/descriptor_sample_size_constant_dx12
...
VideoBackends: update SRVDescriptorTable size in DX12 to use pixel sampler constant
2023-08-15 23:15:19 +02:00
a44606692a
Merge pull request #12096 from Dentomologist/nandpaths_resolve_android_warning
...
NandPaths: Resolve Android tautological comparison warning
2023-08-15 22:23:57 +02:00
2cbc1e6f3e
Merge pull request #12109 from JosJuice/android-adddevice-null
...
ControllerInterface/Android: Add null check to AddDevice
2023-08-15 22:22:45 +02:00
0bb5c88a22
Retrieve page table information from the data cache
...
Thanks to @mkwcat for identifying the problematic code.
2023-08-15 12:44:55 -04:00
1d77bddc3b
ControllerInterface/Android: Add null check to AddDevice
...
The Google Play Console is showing some users getting a crash here,
and indeed, InputDevice.getDevice can return null.
2023-08-15 13:31:18 +02:00
89e2fc1dd3
VideoBackends: update SRVDescriptorTable size in DX12 to use pixel sampler constant
2023-08-13 17:23:26 -05:00
5635a0bdef
DolphinQt/EnhancementsWidget: Use custom tooltip for Color Correction button.
2023-08-13 22:46:46 +02:00
2537f4db91
Merge pull request #12100 from AdmiralCurtiss/tooltip-pushbutton
...
DolphinQt: Add ToolTipPushButton.
2023-08-13 21:44:24 +02:00
4549091f56
Merge pull request #12090 from mandar1jn/figures-split
...
Skylanders: expand and improve character list
2023-08-13 14:29:46 -04:00
31d6aa5117
Skylanders: expand and improve character list
...
The previous list had some issues. A lot of variant id's were set to 0x0000. Althought this works for some figures, on a technicallity implemented into the games, they are technically wrong and don't result in exactly the same experience as the real figures. For example, the previous small fry got a "series 1" text in the summon screen. The real small fry does not have this. I also added figure types so I can add seperate generation logic later.
The Kaos element only applies to 3 items. So, I decided to throw it under others since it's not listed as an element in the manual and you can easily search for Kaos
2023-08-13 19:55:10 +02:00
1c1d2b0873
Merge pull request #12098 from Dentomologist/gcadapter_fix_android_unused_constant_warning
...
Gcadapter: fix Android unused constant warning
2023-08-13 18:58:39 +02:00
5bf760fa0b
Merge pull request #12069 from riidefi/silent-sd-failure
...
Prevent SD data loss from silent resync failure
2023-08-13 18:57:11 +02:00
d50494b88d
Merge pull request #12060 from Sintendo/arm64-bool-logimm
...
JitArm64: Use LogicalImm in boolX
2023-08-13 18:51:05 +02:00
0495a6af4e
Merge pull request #12066 from Pokechu22/main-window-right-click-menu
...
Disable right-click menu on main window
2023-08-13 12:49:56 -04:00
720191d1f7
AbstractFramebuffer: Fix Android reorder-ctor warning
...
Move declaration of m_additional_color_attachments so its initialization
order matches that of the constructor.
2023-08-12 20:48:47 -07:00
274b11e4e9
GCAdapter: Fix Android unused constant warning
...
CONTROLLER_OUTPUT_INIT_PAYLOAD_SIZE is only used by the libusb
implementation.
2023-08-12 20:20:42 -07:00
77d33d61de
GCAdapter: Fix spelling of constants
2023-08-12 20:20:41 -07:00
9ef79dd2f5
IOS: Remove unused member variable from SharedContentMap and UIDSys
...
Resolve unused-private-field warnings on Android.
2023-08-12 14:37:52 -07:00
9ad0d9ca6a
NandPaths: Use initializer_list instead of unordered_set
2023-08-12 14:00:41 -07:00
9955a06dbd
NandPaths: Resolve Android tautological comparison warning
...
Android interprets char as unsigned char, so comparing with 0 triggers a
tautological-unsigned-char-zero-compare warning.
Casting c to an unsigned char and removing the comparison with 0
resolves the warning while needing one less comparison on all platforms.
2023-08-12 14:00:41 -07:00
e6c7f4e14b
DolphinQt: Add ToolTipPushButton.
2023-08-12 21:33:43 +02:00
bc47a28653
Merge pull request #12093 from Hark64/exportWiiSaveErrorFix
...
Disable Wii Save Options When Emulation Is Running
2023-08-12 20:34:47 +02:00
783ff26edd
DolphinQt: Turn of wii save options during emulation
2023-08-12 20:18:22 +02:00
24012cfc7f
DolphinQt: Adjust panel-specific colors and syntax highlighting for dark theme.
2023-08-12 19:43:12 +02:00
c2e29153e9
DolphinQt: Set the theme before constructing the MainWindow, some panels that explicitly request palette colors get the wrong colors otherwise.
2023-08-12 16:54:54 +02:00
d725aaa5bc
DolphinQt: Set the application palette to a matching one when the Windows dark theme is in use.
2023-08-12 16:54:54 +02:00
250d5f55de
DolphinQt: Switch dark/light theme when Windows theme changes.
2023-08-12 16:54:54 +02:00
e2fb8fab2f
DolphinQt: Set window decorations for all top-level QWidgets.
2023-08-12 16:54:54 +02:00
e8d23af0f2
DolphinQt: Add function to set a QWidget's window decorations to dark ones on Windows.
2023-08-12 16:54:53 +02:00
adbe56ce15
DolphinQt: Auto-load embedded dark theme on Windows if the user uses a system-wide dark theme.
2023-08-12 16:54:53 +02:00
ea30651cd7
DolphinQt: Embed custom dark theme for Windows.
2023-08-12 16:54:53 +02:00
5d33f2abd1
DolphinQt: On Windows, detect whether the system is using a dark theme.
...
Co-authored-by: FearlessTobi <thm.frey@gmail.com>
2023-08-12 16:54:53 +02:00
f2300d89cc
CMake: Turn on rcc file embedding.
2023-08-12 16:54:53 +02:00
1f8f3840ac
Disable right-click menu on main window
...
Before, right-clicking on the toolbar would allow toggling all dock widgets, including the debugger ones even when they are disabled. (See https://doc.qt.io/qt-5/qmainwindow.html#createPopupMenu for this behavior, and https://bugs.dolphin-emu.org/issues/13306 for an example of where it caused issues.)
2023-08-11 10:45:31 -07:00
246b7c5bdb
VideoCommon: fix regression with texture load order where the custom texture code was always updating the asset map for each texture with each entry, making it so the last value actually would be loaded instead of the first
2023-08-11 00:36:41 -05:00
5512d19d4b
Merge pull request #12061 from iwubcode/cubemap_backends_only
...
VideoBackends: add support for cube maps for OGL, Vulkan, and D3D
2023-08-10 18:36:48 -04:00
032c77b462
Merge pull request #12064 from noahpistilli/wc24-standby
...
Remove force disable WC24 Standby
2023-08-10 16:07:47 -04:00
b0dc067717
Merge pull request #12087 from Dentomologist/dx12_use_correct_framebuffer_descriptor
...
D3D12: Only use framebuffer integer descriptor if allocated
2023-08-10 19:09:25 +02:00
1ebec40e4d
JitArm64: Prefer MOVI with 64-bit elements for zeroing
...
The Cortex-X2 and Cortex-X3 (and possibly others) recognize MOVI with
64-bit elements as a zeroing idiom, but not MOVI with other sizes.
2023-08-06 12:11:37 +02:00
83f307ec7e
D3D12: Only use framebuffer integer descriptor if allocated
...
Verify that DXFramebuffer's integer RTV descriptor's cpu_handle has been
allocated before using it, and if it hasn't use the non-integer RTV
descriptor instead. This fixes a Dolphin crash in Twilight Princess, and
possibly other games (Issue 13312).
As an optimization to save space in the descriptor heap, DXFramebuffer's
integer descriptor is only initialized if the given abstract texture
format has different integer and non-integer RTV formats. This
previously wasn't accounted for by GetIntRTVDescriptorArray, which could
cause DX12::Gfx::BindFramebuffer to call OMSetRenderTargets with an
invalid descriptor which would lead to a crash.
Triggering the bug was fortunately rare because integer formats are only
used when blending is disabled and logic ops are enabled. Furthermore,
the standard integer abstract format is RGBA8 which has different
integer and non-integer RTV formats, causing the integer descriptor to
be initialized and avoiding the bug.
The crash started appearing in a2702c6
2023-08-04 13:17:33 -07:00
02b0e287cb
InputConfig: Update IsControllerControlledByGamepadDevice for Android input overhaul
...
This only matters for analytics, but still.
2023-08-01 19:35:55 +02:00
262a3be08a
JitArm64: Store PC on debug exit
...
Should fix https://bugs.dolphin-emu.org/issues/13178 .
Jit64 doesn't need to do this because it stores PC directly into
ppcState instead of first storing it in a register.
2023-07-31 16:50:49 +02:00
a912a2c3f5
Merge pull request #12047 from AdmiralCurtiss/nand-stats-user
...
Add file size stats to NAND Check.
2023-07-30 21:51:07 +02:00
d2c5d79614
JitArm64: Use farcode in WriteLinkBlock
...
Now block link nearcode is back to a length of three instructions.
Unfortunately, the code I'm adding to Jit.cpp ends up being a bit messy
because we need to handle the case of already being in farcode...
2023-07-30 15:00:07 +02:00
1813f0fdb5
Jit: Remove checkedEntry
...
It's now always identical to normalEntry.
2023-07-30 14:28:02 +02:00
f78ba9ac55
JitArm64: Never check downcount on block entry
...
Jumping between linked blocks currently works as follows: First, at the
end of the first block, we check if the downcount is greater than zero.
If it is, we jump to the `normalEntry` of the block. So far so good. But
if the downcount wasn't greater than zero, we jump to the `checkedEntry`
of the block, which checks the downcount *again* and then jumps to
`do_timing` if it's less than zero (which seems like an off by one error
- Jit64 doesn't do anything like this). This second check is rather
redundant. Let's jump to `do_timing` where we previously jumped to
`checkedEntry`.
Jit64 doesn't check the downcount on block entry. See 5236dc3
2023-07-30 14:20:44 +02:00
9f817911fd
HLE_OS: Manually handle printfs from emulated software to prevent emulated software from crashing Dolphin with an invalid printf formatting string.
2023-07-29 20:06:09 +02:00
30c4ac34b0
Merge pull request #12073 from AdmiralCurtiss/wiimote-win32error
...
WiimoteReal/IOWin: Use correct error type in the default case.
2023-07-29 18:54:10 +02:00
7f29f0398c
MMU: Add a HostGetU16String() function for wide strings used by emulated software.
2023-07-29 15:11:00 +02:00
dca7c67105
VideoCommon: update NetplayChatUI's chat message input to use a hidden label. This avoids an error thrown by imgui
2023-07-29 00:27:07 -05:00
a2a6473962
Merge pull request #12065 from iwubcode/imgui_update
...
Externals / VideoCommon: update imgui to 1.89.7 (and implot to 0.15)
2023-07-28 17:22:20 -04:00
8bfcd2deb7
JitArm64/Jit64: Load the memory register without jumps and only when necessary.
2023-07-28 14:24:53 +03:00
fb9274c359
WiimoteReal/IOWin: Use correct error type in the default case.
2023-07-28 08:10:54 +02:00
cd923718c3
CommonFuncs: Add GetWin32ErrorString().
2023-07-28 08:10:01 +02:00
f3ad246fff
PPCAnalyst: Simplify gprBlockInputs calculation
...
No need for the gprDefined variable.
2023-07-27 23:10:59 +02:00
8c2d73e8c2
PPCAnalyst: Fix gprBlockInputs calculation
...
This analysis needs to scan backwards, not forwards.
2023-07-27 23:09:46 +02:00
3c6ea825c2
GekkoDisassembler: Remove unused parameter dmode from fdabc function
...
With the removal of m_flags, dmode is no longer used in fdabc.
2023-07-27 10:47:46 -07:00
33dc2a9e6a
GekkoDisassembler: Remove unused parameter dmode from ldst function
...
With the removal of m_flags, dmode is no longer used in ldst.
2023-07-27 10:47:46 -07:00
b3c5021fc4
GekkoDisassembler: Remove unused parameter dmode from rrn function
...
With the removal of m_flags, dmode is no longer used in rrn.
2023-07-27 10:47:46 -07:00
a177c8bcb1
GekkoDisassembler: Remove unused parameter dmode from dab function
...
With the removal of m_flags, dmode is no longer used in dab.
2023-07-27 10:47:45 -07:00
a732647e5a
GekkoDisassembler: Remove unused parameter dmode from nooper function
...
With the removal of m_flags, dmode is no longer used in nooper.
2023-07-27 10:47:45 -07:00
317bb629b9
GekkoDisassembler: Remove unread variable m_flags
...
Writes to m_flags are pointless as it's never read.
2023-07-27 10:47:41 -07:00
350e51951b
VideoCommon: update imgui to 1.89.7 (and implot to 0.15); fix issues with upgrade; keep the demo code in case someone wants to reference it but don't compile it by enabling 'IMGUI_DISABLE_DEMO_WINDOWS' in config
2023-07-27 11:47:34 -05:00
ec5d2a4f41
[Core] Prevent SD data loss from silent resync failure
2023-07-26 13:58:01 -06:00
1e5e319783
Qt/GameConfigWidget: Add Manual Texture Sampling
2023-07-25 00:45:13 +02:00
41f81aca69
Qt/GameConfigWidget: Rename `m_enable_fast_disc` to `m_emulate_disc_speed`
2023-07-25 00:45:10 +02:00
0892998af1
Qt/GameConfigWidget: Add `reverse` argument for `{Save,Load}CheckBox`
...
In order to not hard code `if (key == "FastDiscSpeed")`
2023-07-24 20:48:32 +02:00
0a2afa48b7
Merge pull request #12045 from tupfold/master
...
[Minor Bugfix] Extremely rare HostID collision bugfix
2023-07-24 03:55:45 +02:00
2b80605e7e
Merge pull request #12067 from Pokechu22/debugging-ui-text-show-enable
...
Rename "Show Debugging UI" to "Enable Debugging UI"
2023-07-24 01:15:04 +02:00
c468ca2107
Merge pull request #12057 from iwubcode/config_core_timing_refresh_only
...
Core: save core timing parameters into variables updated during refresh
2023-07-24 01:14:18 +02:00
7e38ff496c
Rename "Show Debugging UI" to "Enable Debugging UI"
...
This will hopefully reduce confusion on e.g. https://bugs.dolphin-emu.org/issues/13306 .
2023-07-23 15:17:04 -07:00
e54b7ac356
Core: save core timing parameters into variables updated during refresh
2023-07-23 14:03:21 -05:00
eb79bf37e2
Merge pull request #12052 from mitaclaw/profiling-is-something
...
Announce RSCRATCH clobbering in Jit64::Cleanup() when profiling is enabled
2023-07-23 20:12:43 +02:00
a76cc146e1
Merge pull request #12055 from iwubcode/skip_dump_async
...
VideoCommon: skip the texture dump if a custom texture is available, regardless if it is loaded or not
2023-07-23 19:53:25 +02:00
c1a4b3f350
Merge pull request #12051 from mandar1jn/J-documentation-improvements
...
Skylanders: Update J command documentation
2023-07-23 19:23:29 +02:00
dd3caa48b2
Merge pull request #12063 from SuperSamus/audio-name
...
cubeb: Change name to "Dolphin Emulator"
2023-07-23 19:15:24 +02:00
a486168448
JitArm64: Use LogicalImm in boolX
...
ARM64 has a special logical immediate encoding scheme, that can be used
with AND, ORR, and EOR. By taking advantage of this, we no longer need
to materialize the immediate value in a register, saving instructions
and/or reducing register pressure.
- orx
Before:
mov w23, #0x1
orr w23, w25, w23
After:
orr w23, w25, #0x1
- andx
Before:
mov w26, #-0x80000000
and w27, w27, w26
sxtw x24, w27
After:
and w27, w27, #0x80000000
sxtw x26, w27
- eqvx
Before:
mov w23, #0x4
eon w26, w23, w22
After:
eor w26, w22, #0xfffffffb
- xorx
Before:
mov w23, #0x1e
eor w23, w27, w23
After:
eor w23, w27, #0x1e
- norx
Before:
mov w25, #-0x2001
orr w23, w23, w25
mvn w23, w23
After:
orr w23, w23, #0xffffdfff
mvn w23, w23
2023-07-23 18:40:53 +02:00
8c2a1c191e
Remove force disable WC24 Standby
2023-07-22 22:24:09 -04:00
e3ef3cb752
Merge pull request #12062 from iwubcode/custom_textures_debug
...
VideoCommon: add startup message to know if custom textures are installed
2023-07-23 03:45:22 +02:00
b5be399fd4
cubeb: Change name to "Dolphin Emulator"
...
To avoid conflicts with KDE's file manager.
2023-07-22 23:12:34 +02:00
fb2b3753b5
Merge pull request #12015 from nyanpasu64/gc-adapter-sleep-detach
...
Fix GC Adapter breaking and burning a full CPU core after sleep-wake on Linux
2023-07-22 03:38:45 +02:00
fd74244339
VideoCommon: add custom texture message to provide a dirty means of debugging whether custom textures are installed correctly
2023-07-21 20:13:27 -05:00
e892b7f1ac
VideoBackends: add support for cube maps for OGL, Vulkan, and D3D
2023-07-21 19:09:40 -05:00
7a7e0ab2f5
Fixed Leaderboard Scored message format
...
Refactored the message displayed when a leaderboard is submitted to so that it properly generates and uses a FormattedValue.
2023-07-21 01:45:50 -04:00
eba5291ec7
Skylanders: Update J command documentation
...
I initially thought the 0x01 side was both sides (equavalent to just C. However, this turned out to be something I forgot I implemented in my personal interface. 0x01 does not seem to change any colors.
Recently discovered how exactly the last 2 bytes of the J command for timing data
2023-07-20 23:58:33 +02:00
f7e78742cf
VideoCommon: skip the texture dump if the texture is using a custom texture, regardless of whether or not it is loaded yet
2023-07-19 23:44:41 -05:00
70b3db93e0
Announce RSCRATCH clobbering in Jit64 when profiling is enabled
2023-07-19 14:15:42 -07:00
79f202ea5c
VideoCommon: fix some compiler warnings for CustomAsset. FreeBSD compiler complained about a defaulted move constructor due to the mutex being implicitly deleted. Additionally, the const owning library deleted the copy constructor.
2023-07-16 19:45:55 -05:00
9ebfcebdde
Merge pull request #12049 from iwubcode/initialize_asset_load_info
...
VideoCommon: initialize load info variables in CustomAssetLibrary
2023-07-16 23:32:13 +02:00
2814e4e283
Merge pull request #12033 from mbc07/ColorCorrectionGUI_fixes
...
Qt: Color Correction window fixes
2023-07-16 23:31:59 +02:00
d7e79683cc
Qt: Color Correction window fixes
2023-07-16 16:48:08 -04:00
5740be15f9
VideoCommon: initialize load info variables
2023-07-16 12:56:03 -05:00
cd5aebe5ac
Qt: Add file size stats to NAND Check.
2023-07-14 05:24:29 +02:00
efae5827f2
IOS/FS: Implement GetExtendedDirectoryStats().
...
Behaves like GetDirectoryStats() but doesn't clamp to the Wii limits, so we can tell the user exactly how overfull their NAND is.
2023-07-14 04:48:23 +02:00
0d9e027a0b
IOS/FS: Move NAND size related constants to FileSystem.h.
...
That way they're available for calculating NAND stats to display to the user. This also adds a few more constants.
2023-07-14 04:47:47 +02:00
c4978edaf6
Fixed a bug where in the extremely unlikely change that HostIDs collide, a new HostID is generated.
2023-07-13 21:33:36 +10:00
550b9782e1
Do not try portmapping when using traversal server
...
using portmapping with hosting while using traversal server (which is possible by checking the option while under "direct connect" and flipping back to traversal server) causes dolphin to request a mapping to external port 0.
In UPnP a mapping to external port 0 is actually the wildcard, which means that connection requests on all
external ports (that are not otherwise mapped) will be forwarded to the client.
Additionally it seems like using port mapping with traversal server is probably not expected behavior, as the option checkbox disappears when traversal server is used.
2023-07-13 01:15:12 -07:00
cbb76c1d4f
Common/Network: Use StrErrorWrapper
2023-07-12 20:52:35 +04:00
92be54d57a
Common/CommonFuncs: Add StrErrorWrapper function
2023-07-12 20:52:35 +04:00
423c7c58cd
Merge pull request #12042 from JosJuice/logic-op-no-win7
...
D3D: Remove Windows 7 mention in logic ops warning
2023-07-11 20:23:16 -04:00
5acebc71c4
D3D: Remove Windows 7 mention in logic ops warning
...
Dolphin no longer supports Windows 7, so the fact that there are (were?)
more people who use Windows 7 than who use a GPU that doesn't support
the required feature is no longer relevant.
2023-07-11 22:41:51 +02:00
93c8db66d6
Skylanders: More List Fixes
2023-07-10 09:59:00 +01:00
fe8a9ac707
Merge pull request #12024 from iwubcode/material_asset
...
VideoCommon: add material asset
2023-07-09 21:49:16 +02:00
77511e8e7c
VideoCommon: add material asset. A material is similar to other graphics engines where it provides data to be used in conjunction with a shader asset to generate a runtime AbstractShader
2023-07-09 12:21:34 -05:00
bd90f6be78
Merge pull request #12017 from Dentomologist/remove_unused_flowlayout
...
QtUtils: Remove unused FlowLayout
2023-07-09 16:06:35 +02:00
90b1f5c60a
Merge pull request #12020 from Dentomologist/gekkodisassembler_remove_unread_variables
...
GekkoDisassembler: Remove unread variables
2023-07-09 16:00:26 +02:00
80c44ea597
Merge pull request #12034 from MaverickAmon02/controller-update-race
...
Fix unsafe netplay code in SI_DeviceGCController
2023-07-09 14:13:44 +02:00
7bb04ff1dc
Merge pull request #12022 from iwubcode/texture_create_gmod_impl
...
VideoCommon: call into graphics mods create texture callback
2023-07-09 04:20:43 +02:00
d122492db7
Fix unsafe netplay code in SI_DeviceGCController
...
By misusing Config, this netplay-related code opened up a race condition between Config::OnConfigChanged() and SerialInterface::SerialInterfaceManager::UpdateDevices() that could cause iterator invalidation.
2023-07-06 11:34:08 -04:00
c8df26554b
Fix GC adapter not being detected when you enable controller in settings
...
GCAdapter::UseAdapter() reads s_is_adapter_wanted, which gets
initialized by config_guard.~ConfigChangeCallbackGuard(). So we must
wait until after destroying the config guard to know whether we have any
controllers set to GC Adapter.
2023-07-05 20:38:22 -07:00
5d0f1bd10b
Switch libusb_config_descriptor to RAII type
2023-07-05 20:38:22 -07:00
c893ccca58
Workaround GC adapter detection breaking when reset fails
2023-07-05 20:38:22 -07:00
559a16da49
Reset GC adapter upon IO error after sleep-wake
...
Fixes GC adapter breaking on sleep-wake on Linux and burning a full CPU
core. This is cleaner than alternative approaches.
2023-07-05 20:38:22 -07:00
afb5eff426
Don't burn a CPU core and spam logs when GC Adapter fails
2023-07-05 20:38:22 -07:00
54850e936c
Fix memory leak in libusb code
2023-07-05 20:38:22 -07:00
79a4b91d68
Skylander Portal: Simple List Fixes
2023-07-04 16:48:51 +01:00
0366122306
Merge pull request #12009 from iwubcode/shader_asset
...
VideoCommon: add a pixel shader asset
2023-07-03 03:24:11 +02:00
da2784a391
Merge pull request #11878 from LillyJadeKatrin/retroachievements-achievements-tab
...
RetroAchievements - Achievement Progress Tab
2023-07-03 03:23:18 +02:00
a2ad3ca6f7
VideoCommon: don't do pointer copies during graphics mod callback iteration
2023-07-02 13:58:07 -05:00
0539bb4a3e
VideoCommon: call into graphics mods create texture callback, providing additional asset dependencies that trigger the texture to be reloaded
2023-07-02 13:45:09 -05:00
6d7bf60071
Merge pull request #11991 from iwubcode/tcache_multiple_texture_dependencies
...
VideoCommon: allow multiple texture assets to associate with a texture cache entry
2023-07-02 20:14:32 +02:00
a93e6e7397
VideoCommon: add support for allowing a TextureCache entry to be associated with multiple assets
2023-07-02 12:50:07 -05:00
c8e276c6f5
GekkoDisassembler: Remove unread variable m_displacement
2023-07-01 20:09:10 -07:00
98c9049184
GekkoDisassembler: Remove unread variable m_sreg
2023-07-01 20:09:09 -07:00
ccc9d0e5ea
Synchronized Achievement Window
...
Expanded the use of the lock mutex already used for loading the player's existing unlock status to guard against races involving the Achievements dialog window reading from data AchievementManager might be in the process of updating. The lock has been exposed publicly and the AchievementsWindow uses it in its UpdateData method, and anywhere else that might modify data used to render that window has also been wrapped with it.
2023-07-01 22:26:30 -04:00
fbaeaf305b
Add UpdateCallback to AchievementManager
...
AchievementManager now has a SetUpdateCallback method for providing a single universal callback for anytime something important changes in the achievement state, such as logging in/out, game load/close, or events such as achievement unlocks. AchievementsWindow sets this callback in its own init to its UpdateData method so that the AchievementsWindow gets updated when one of these changes takes place.
2023-07-01 22:26:29 -04:00
582042de1f
Added AchievementProgressWidget to AchievementsWindow
...
This widget is a tab in the AchievementsWindow that displays the player's current achievement progress: which achievements are locked or unlocked, and the progress of achievements that have progress metrics.
2023-07-01 22:26:29 -04:00
ebe77f149f
Added AchievementHeaderWidget to AchievementsWindow
...
This widget displays a header on the AchievementsWindow dialog above the tabs that shows the currently logged in user (if there is one) and the game they are playing (if there is one).
2023-07-01 22:26:29 -04:00
f700faf6ab
Expose Achievements Data for Display
...
Added some small methods to AchievementManager to expose useful data for displaying in an achievement UI. Also moved a couple things from private to public for the same purpose.
2023-07-01 22:26:29 -04:00
6fe3cfe245
QtUtils: Remove unused FlowLayout
...
FlowLayout hasn't been used since
b65faa0549
2023-07-01 11:33:54 -07:00
eedc1144c1
Merge pull request #11923 from iwubcode/multi-texture-compute-support
...
VideoBackends: support multiple compute images for some backends
2023-07-01 17:47:55 +02:00
179d823852
Merge pull request #11992 from Dentomologist/remove_mtype_and_associated_enum
...
GekkoDisassembler: Remove unread variable and associated enum
2023-07-01 09:00:42 +02:00
ed4403537f
Merge pull request #11916 from JosJuice/ppcanalyst-reorder-loop
...
PPCAnalyst: Reduce number of iterations in ReorderInstructionsCore
2023-07-01 01:06:53 +02:00
82c986816f
Merge pull request #11978 from AdmiralCurtiss/wiimote-S_FALSE
...
WiimoteReal/IOWin: Don't try to print error message for non-errors.
2023-07-01 00:58:42 +02:00
e71f42f819
Merge pull request #11997 from Dentomologist/dspemulator_remove_pauseandlock_parameter
...
DSPEmulator: Remove unused PauseAndLock parameter
2023-07-01 00:56:45 +02:00
94f34260a6
Merge pull request #12001 from Filoppi/patch-21
...
Qt: Fix some Post Process Configuration Widget issues #3-4
2023-06-30 19:11:10 +02:00
fa81006b51
Merge pull request #11955 from TellowKrinkle/CMakeDependencies
...
CMake: Allow ignoring system packages
2023-06-30 19:06:04 +02:00
e4d7ba5554
Merge pull request #12007 from AdmiralCurtiss/cmake-scmrev-at-build-time
...
CMake: Generate scmrev.h at build time instead of configure time.
2023-06-30 18:59:33 +02:00
6ea49c6746
VideoCommon: add a pixel shader asset
2023-06-30 01:32:53 -05:00
ff324ef660
Merge pull request #12010 from TellowKrinkle/AlignUpOpt
...
Common: Better AlignUp implementation
2023-06-29 20:30:13 -04:00
bfb90b7eec
Video: increase the max HDR brightness multiplier to a more appropriate value (400 nits can be too dark in a bright room)
2023-06-29 14:24:28 +03:00
28fafbeef2
Qt: Fix some Post Process Configuration Widget issues n3
...
1 ) When first opened, the (user selected) post process shader config widget would print the wrong values on the text label next to int range sliders. For example if the range was from 1 to 6, and the value loaded from the config was 1, the label would print 0 when first opened, to then start showing the correct value once the slider was first moved.
This mirrors the behaviour of the float slider code below:
```auto* const value_box = new QLineEdit(QString::asprintf("%f", m_config_option->m_float_values[i]));```
2 ) The defautl int slider value would also be set wrong on first load, as it was being divided by the slider max instead of the slider step amount (again, just like for the float implementation). This is a mistake I had made with my previous submission.
2023-06-29 14:13:38 +03:00
d844317a6d
Common: Better AlignUp implementation
2023-06-29 02:35:44 -05:00
4774fe3445
VKGfx: Add parentheses around ambiguous if statements.
2023-06-29 03:59:18 +02:00
2a6f4d879c
CMake: Generate scmrev.h at build time instead of configure time.
2023-06-29 03:23:31 +02:00
3627398cf5
VideoBackends: support multiple compute images for some backends (D3D, OGL, Vulkan)
2023-06-28 17:15:31 -05:00
3384e02098
DolphinQt: Don't translate empty strings
...
Trying to translate an empty string will return a long metadata string
for the loaded translation file rather than the expected empty string.
2023-06-28 18:43:52 +02:00
fc4036af80
VideoBackends:Metal: Multi render target support
2023-06-28 00:11:37 -05:00
766b8605f8
Merge pull request #11994 from JosJuice/skylanders-i18n
...
DolphinQt: Add i18n comments for Skylanders strings
2023-06-27 22:40:14 +02:00
ee684b0798
DSPEmulator: Remove unused PauseAndLock parameter
2023-06-25 20:29:23 -07:00
f151ae3c2a
EXI: Remove pointless PauseAndLock functions
...
The ExpansionInterfaceManager::PauseAndLock function does nothing but
call other functions that have no effect.
ExpansionInterfaceManager::PauseAndLock calls CEXIChannel::PauseAndLock,
which in turn calls IEXIDevice::PauseAndLock. None of the classes
deriving from IEXIDevice override PauseAndLock, and the implementation
in IEXIDevice does nothing.
2023-06-25 20:08:08 -07:00
3a8e7de214
Merge pull request #11903 from noahpistilli/wiilink
...
IOS/KD: Add WiiLink as WC24 service provider by default
2023-06-26 02:27:47 +02:00
f9f8e94e30
Add default support for WiiLink + configuration
2023-06-25 14:57:15 -04:00
09f8f29ae0
DolphinQt: Add i18n comments for Skylanders strings
...
Also changed the spelling of "Superchargers" to "SuperChargers".
2023-06-25 15:38:30 +02:00
2472269d06
GekkoDisassembler: Remove unused enum InstructionType
2023-06-24 13:45:26 -07:00
2cf48bc32c
GekkoDisassembler: Remove unread variable m_type
...
Writes to m_type are pointless because it's never read.
2023-06-24 13:45:26 -07:00
50c929928c
Merge pull request #11920 from Minty-Meeo/kill-ascii-to-hex
...
Kill AsciiToHex
2023-06-23 18:20:36 -07:00
c04536c5d0
Merge pull request #11982 from iwubcode/graphics_mod_create_texture_callback
...
VideoCommon: add graphics mod callback interface for when a texture is created
2023-06-23 18:10:59 +02:00
02909bd1a5
Merge pull request #11850 from Filoppi/post_process_fixes
...
Video: implement color correction to match the Wii/GC NTSC/PAL color spaces (and gamma)
2023-06-23 18:08:23 +02:00
5bf3d55d38
Merge pull request #11981 from iwubcode/move_cached_asset_to_common
...
VideoCommon: move cached texture asset to 'CustomAsset' common code
2023-06-23 17:59:24 +02:00
b5ba51c60a
Core: Remove host thread assert in PauseAndLock().
...
Fixing all the places it's used turned out to be a more complicated task than anticipated. So let's remove this for now so we don't confuse users with cryptic error messages...
2023-06-23 01:18:56 +02:00
445bf8d2c6
Kill AsciiToHex
...
Now superseded by Common::FromChars
2023-06-22 00:06:50 -05:00
bc0e8158b3
IOS/KD/Time: Take into account DST for AdjustedUTC
2023-06-20 22:49:33 -04:00
1d767c3a5b
VideoCommon: add graphics mod callback interface for when a texture is created
2023-06-20 19:26:53 -05:00
2dc24a9148
VideoCommon: move cached texture asset to 'CustomAsset' common code
2023-06-20 18:59:55 -05:00
4ef2f2c710
Rename Symbol constructor parameter to prevent shadowing
2023-06-20 13:38:31 -04:00
00bf5f55de
WiimoteReal/IOWin: Don't try to print error message for non-errors.
2023-06-20 01:54:59 +02:00
cff3e22f84
Merge pull request #11926 from JosJuice/android-host-check
...
Android: Re-add host thread check
2023-06-19 20:37:59 +02:00
5d7b5822c9
Merge pull request #11972 from Minty-Meeo/string-improvements-part-1c
...
Replace std::ostringstream usage with fmt::format
2023-06-19 02:18:30 +02:00
ffabb6c57b
Replace std::ostringstream usage with fmt::format
2023-06-18 18:37:32 -05:00
daddf4cd9c
Qt: add color correction and HDR Qt settings widgets
2023-06-19 01:34:42 +03:00
a2702c6e27
Video: implement color correction to match the NTSC and PAL color spaces (and gamma) that GC and Wii targeted.
...
To further increase the accuracy of the post process phase, I've added (scRGB) HDR support, which is necessary
to fully display the PAL and NTSC-J color spaces, and also to improve the quality of post process texture samplings and
do them in linear space instead of gamma space (which is very important when playing at low resolutions).
For SDR, the quality is also slightly increased, at least if any post process runs, as the buffer is now
R10G10B10A2 (on Vulkan, DX11 and DX12) if supported; previously it was R8G8B8A8 but the alpha bits were wasted.
Gamma correction is arguably the most important thing as Dolphin on Windows outputted in "sRGB" (implicitly)
as that's what Windows expects by default, though sRGB gamma is very different from the gamma commonly used
by video standards dating to the pre HDR era (roughly gamma 2.35).
Additionally, the addition of HDR support (which is pretty straight forward and minimal), added support for
our own custom AutoHDR shaders, which would allow us to achieve decent looking HDR in Dolphin games without
having to use SpecialK or Windows 11 AutoHDR. Both of which don't necessarily play nice with older games
with strongly different and simpler lighting. HDR should also be supported in Linux.
Development of my own AutoHDR shader is almost complete and will come next.
This has been carefully tested and there should be no regression in any of the different features that Dolphin
offers, like multisampling, stereo rendering, other post processes, etc etc.
Fixes: https://bugs.dolphin-emu.org/issues/8941
Co-authored-by: EndlesslyFlowering <EndlesslyFlowering@protonmail.com>
Co-authored-by: Dogway <lin_ares@hotmail.com>
2023-06-19 01:34:42 +03:00
9e06b6964b
Merge pull request #11963 from iwubcode/d3d12_fix
...
VideoBackends: fix d3d12 error when validation layers enabled
2023-06-19 00:33:40 +02:00
8039d10994
Merge pull request #11966 from Dentomologist/convert_xemitter_prefetchlevel_to_enum_class
...
xEmitter: Convert PrefetchLevel to enum class
2023-06-18 15:17:02 +02:00
2d18c9e079
Merge pull request #11976 from JosJuice/emitter-nodiscard
...
Arm64Emitter/x64Emitter: Use nodiscard for FixupBranch
2023-06-18 15:16:42 +02:00
0584f8ae2a
Video: fix Vulkan RGBA10_2 format to the actual most common one (used as swapchain format)
2023-06-18 12:58:40 +03:00
39a8219767
Arm64Emitter/x64Emitter: Use nodiscard for FixupBranch
...
This should prevent future occurrences of the type of problem that was
fixed in b713042
2023-06-18 09:10:20 +02:00
80575c4489
DITConfiguration: Use File::ReadFileToString
2023-06-17 19:38:15 -05:00
04fcf68176
xEmitter: Convert PrefetchLevel to enum class
2023-06-17 16:41:32 -07:00
b71304230c
Jit64: Fix trampolines after #11834 .
2023-06-18 01:31:44 +02:00
93d9e90798
Merge pull request #11962 from Minty-Meeo/to-underlying
...
EnumUtils: Add Common::ToUnderlying
2023-06-17 20:04:25 +02:00
696087cae0
Qt/NetworkWidget: Get rid of some trivial sign conversions
...
In all instances, these variables should be signed rather than unsigned.
2023-06-17 10:48:49 -04:00
7523a62105
Change unnamed enum in NativeVertexFormat.h to u32
2023-06-17 08:13:57 -05:00
79d5850e6a
Merge pull request #11960 from Minty-Meeo/dolphin-tool-code-review-4
...
DolphinTool: Use {fmt} library
2023-06-17 14:18:21 +02:00
07ad75f34f
EnumUtils: Add Common::ToUnderlying
...
Mirrors the C++23 <utility> function, std::to_underlying
2023-06-17 07:15:33 -05:00
ba74902bca
VideoBackends: fix d3d12 validation layer error introduced by multi-output texture breaking logic ops support
2023-06-17 01:48:59 -05:00
e67c196d2a
DolphinTool: Less string copies
2023-06-16 21:51:06 -05:00
410c4ffe75
DolphinTool: Use {fmt} library
2023-06-16 21:45:59 -05:00
5029924ba1
Merge pull request #11954 from Minty-Meeo/dolphin-tool-code-review-3
...
DolphinTool: Use EXIT_SUCCESS and EXIT_FAILURE
2023-06-17 04:44:09 +02:00
1aef85a985
Merge pull request #11918 from TellowKrinkle/DPIScale
...
Improved DPI change handling
2023-06-17 04:07:13 +02:00
089d433996
Merge pull request #11956 from JosJuice/jitarm64-12-bit-asm
...
JitArm64: Micro-optimizations in fres routine
2023-06-17 04:00:22 +02:00
969eeb4b52
DolphinTool: Use EXIT_SUCCESS and EXIT_FAILURE
2023-06-16 21:00:10 -05:00
25c020cbe2
DolphinTool: Ditch OOP design
2023-06-16 20:39:16 -05:00
98b5d72ef1
Merge pull request #11951 from Minty-Meeo/dolphin-tool-code-review-1
...
DolphinTool: Sensible changes
2023-06-17 03:03:26 +02:00
31e78c40a1
DolphinTool: Sensible changes
2023-06-16 18:28:03 -05:00
cbcf5bfac1
Merge pull request #11889 from Filoppi/patch-18
...
Fix video output having small black borders all the times
2023-06-16 17:59:51 +02:00
50301bf1d1
Merge pull request #11957 from lioncash/resource
...
UICommon/ResourcePack: Allow priority helpers to take arguments by const reference
2023-06-16 17:01:19 +02:00
653d6d059f
UICommon/ResourcePack: Allow priority helpers to take arguments by const reference
...
There's nothing going on with behavior here that would prevent these
from being const qualified.
Also better communicates that this function isn't intended to modify the
given resource pack.
2023-06-16 10:20:50 -04:00
f5eea4a957
Merge pull request #11834 from Dentomologist/xemitter_use_pseudonamed_parameter_force5bytes
...
XEmitter: Add enum class Force5Bytes
2023-06-16 15:46:36 +02:00
9c13436e2b
JitArm64: Improve instruction scheduling in fres routine
...
We want to have a low number of instructions between the LDP and the
MADD so that the MADD can start immediately after the LDP finishes
even if we're on a lower-end in-order CPU.
2023-06-15 22:02:39 +02:00
f0f8225ff8
Merge pull request #11424 from Pokechu22/jit-imm-loadstore-update
...
Jit64: Attempt to fix updating stores with an immediate value
2023-06-15 11:32:30 -04:00
5b10a80401
CMake: Use targets for all optionally-external dependencies
2023-06-15 01:41:41 -05:00
5b5124d9ff
JitArm64: Use immediates more in fres routine
...
Not sure why I didn't do this to begin with. Maybe I was under the
impression that the most significant bit of a 12-bit immediate was a
sign bit.
2023-06-14 23:27:58 +02:00
bd125733f0
Merge pull request #11946 from Dentomologist/convert_fromwhichroot_to_enum_class
...
Common: Convert FromWhichRoot to enum class
2023-06-14 13:29:07 +02:00
88ff00a05c
Merge pull request #11942 from Dentomologist/convert_controlleremu_translatability_to_enum_class
...
ControllerEmu: Convert Translatability to enum class
2023-06-14 13:27:47 +02:00
7ff7c9e84f
Common: Convert FromWhichRoot to enum class
2023-06-13 13:25:22 -07:00
708c986693
PPCCache: Remove redundant reinterpret_casts
...
The pointer is being passed to functions that take arguments as void*,
so we don't need to cast here.
2023-06-13 08:25:26 -04:00
6d16a09707
Merge pull request #11941 from Dentomologist/convert_blockingloop_stopmode_to_enum_class
...
Common: Convert BlockingLoop::StopMode to enum class
2023-06-13 11:47:20 +02:00
74c0519c54
Merge pull request #11930 from iwubcode/game_texture_validation
...
VideoCommon: don't reject game textures which have the wrong size
2023-06-13 11:43:35 +02:00
3e27fc7c0b
VideoCommon: don't treat incorrect aspect ratio or sizes that aren't a multiple of native textures as an error
2023-06-12 21:19:29 -05:00
527f8e783c
ControllerEmu: Convert Translatability to enum class
2023-06-12 18:11:04 -07:00
3c80f821c0
Common: Convert BlockingLoop::StopMode to enum class
2023-06-12 17:12:25 -07:00
63090d411d
Merge pull request #11940 from lioncash/debugiface
...
Common: Move DebugInterface.h into Core
2023-06-13 01:59:33 +02:00
f11175d117
Revert "Android: Temporarily disable host thread check"
...
This reverts commit 361171fce0
2023-06-12 23:39:42 +02:00
4c2759f541
XEmitter: Add enum class Jump
...
Replace the bool parameter force5bytes in J, JMP, and J_CC with an enum
class Jump::Short/Near. Many callers set that parameter to the literal
'true', which was unclear if you didn't already know what it did.
2023-06-12 13:04:18 -07:00
c8559a7933
Merge pull request #11863 from Minty-Meeo/nkit-extract
...
Remove NKit data when extracting a GCN/Wii disc volume
2023-06-12 15:37:02 -04:00
635bce2e7b
Merge pull request #11939 from lioncash/condition
...
BreakpointDialog: Mark breakpoint help text as translatable
2023-06-12 20:13:07 +02:00
b4d161ff29
Merge pull request #11938 from lioncash/inits
...
ParallelProgressDialog: Initialize all data members
2023-06-12 20:07:57 +02:00
b3f4006bb7
Merge pull request #11937 from lioncash/sky
...
SkylanderPortalWindow: Detranslate unnecessary strings
2023-06-12 20:07:37 +02:00
41df38cb7c
Common: Move DebugInterface.h into Core
...
The base DebugInterface now depends on the Core's CPUThreadGuard, and
utilities in Common shouldn't be depending on Core facilities. So, we
can move this into the core library instead.
2023-06-12 10:35:31 -04:00
6e9afd9a73
BreakpointDialog: Mark breakpoint help text as translatable
...
We already mark the title of the dialog box as translatable, so it
would be a bit odd to not mark the containing text as translatable too.
2023-06-12 09:50:17 -04:00
9c0cd5c81a
ParallelProgressDialog: Mark WasCanceled() as const
...
This doesn't alter any class state.
2023-06-12 09:38:10 -04:00
b70894b950
ParallelProgressDialog: Initialize all data members
...
Ensures we always have a deterministic state.
2023-06-12 09:36:51 -04:00
001fe6ff61
SkylanderPortalWindow: Detranslate unnecessary strings
...
This doesn't need to be handled by translators, since they're not
user-displayed text or just don't need to be translated.
While we're at it, we don't need to copy each entry of the resulting
list.
2023-06-12 09:26:16 -04:00
cbd2a720bb
InfinityBaseWindow: Remove unnecessary system instance accessor
...
GetFigureList() is a static member function, so we can just call it
directly instead of going through the system instance.
2023-06-12 09:02:20 -04:00
1a0a1e8f12
Merge pull request #10976 from TellowKrinkle/StackFrames
...
Improve stack frames for profilers
2023-06-12 05:00:08 +02:00
fc53dca7bd
Qt: Send SizeChanged on DPI changes
2023-06-11 20:05:27 -05:00
d3110b9521
VideoCommon: Update imgui scale when dpi changes
2023-06-11 20:05:27 -05:00
23bebc5270
VideoBackends:Vulkan: Allow loading custom drivers on Android
...
... using libadrenotools
2023-06-11 13:52:34 +02:00
28ed1f8be1
Common:AGL: Support making temporary contexts from the main thread
...
- Don't crash when making contexts from the main thread
- Don't focus the window when making a context
2023-06-10 14:25:45 -05:00
7752e247f7
Merge pull request #11911 from TellowKrinkle/MTLParallelCompilation
...
VideoBackends:Metal: Enable shouldMaximizeConcurrentCompilation when available
2023-06-10 19:39:24 +02:00
03ec86f248
Qt: Add float config tooltip slider
2023-06-09 22:07:12 +02:00
061ec365a8
PPCAnalyst: Reduce number of iterations in ReorderInstructionsCore
...
We can utilize the fact that if swapping two instructions causes another
swap to become possible, that swap involves one of the two instructions
we just swapped. There's need to search for new swap opportunities as
far back as the beginning of the block; we can just go one step back.
2023-06-09 19:45:51 +02:00
8f51a9d2d8
Merge pull request #11699 from Pokechu22/gl-check-maximum-samples
...
OpenGL: Check the list of supported AA modes instead of hardcoding
2023-06-09 15:07:07 +02:00
092773ad0c
Merge pull request #11859 from iwubcode/backend-multi-output
...
VideoBackends: add support to allow rendering to multiple output targets
2023-06-09 13:40:21 +02:00
ac48b2eea4
EnhancementsWidget: Handle gaps in AA mode list
...
Mesa (llvmpipe) only reports 4x MSAA, and doesn't report 2x (or 1x, but we implicitly add that). The old logic did not handle this correctly, causing selecting 4x to fail and fall back to None.
This also removes VideoUtils::GetAvailableAntialiasingModes, and thus VideoUtils entirely, as its only other function was removed in 1f74653501
2023-06-08 22:07:41 -07:00
b246a634d4
OpenGL: Check the list of supported AA modes instead of hardcoding
2023-06-08 22:07:41 -07:00
c63f0f37cd
VideoCommon: Pass WindowSystemInfo to InitBackendInfo
2023-06-08 22:07:39 -07:00
afa498fa2f
VideoCommon: update DirectFilesystemAssetLibrary to not throw exceptions when a file no longer exists
2023-06-08 22:20:52 -05:00
429b2eca8a
VideoCommon: add logging for loading texture assets
2023-06-08 19:48:45 -05:00
e7f4b7679b
VideoBackends:Metal: Enable shouldMaximizeConcurrentCompilation when available
2023-06-08 18:57:41 -05:00
7845fb00ee
Merge pull request #11681 from iwubcode/asset_management
...
VideoCommon: migrate texture packs to use the asset loader system
2023-06-08 22:21:12 +02:00
f561bd4285
Merge pull request #11910 from lioncash/construct
...
PowerPC/ConditionRegister: Mark PPCToInternal() as constexpr
2023-06-08 21:26:07 +02:00
0d07ebab25
Merge pull request #11908 from lioncash/strcopy
...
Debugger: Remove some trivial string copies
2023-06-08 20:54:21 +02:00
e8c87dc4fd
Merge pull request #11902 from Minty-Meeo/regex-best-practices
...
static const std::regex
2023-06-08 20:52:11 +02:00
e3cae72c18
Merge pull request #11909 from lioncash/spans
...
GCMemcardUtils: Make use of std::span where applicable
2023-06-08 20:46:08 +02:00
09271f365a
PowerPC/ConditionRegister: Mark PPCToInternal() as constexpr
...
This allows the compiler to eliminate a static constructor that
initializes the table, and instead precompute all of the data ahead of
time.
e.g. We get something like so on GCC without constexpr:
_GLOBAL__sub_I_PowerPC::ConditionRegister::s_crTable:
movdqa xmm0, XMMWORD PTR .LC0[rip]
movaps XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip], xmm0
movdqa xmm0, XMMWORD PTR .LC1[rip]
movaps XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+16], xmm0
movdqa xmm0, XMMWORD PTR .LC2[rip]
movaps XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+32], xmm0
movdqa xmm0, XMMWORD PTR .LC3[rip]
movaps XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+48], xmm0
movdqa xmm0, XMMWORD PTR .LC4[rip]
movaps XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+64], xmm0
movdqa xmm0, XMMWORD PTR .LC5[rip]
movaps XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+80], xmm0
movdqa xmm0, XMMWORD PTR .LC6[rip]
movaps XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+96], xmm0
movdqa xmm0, XMMWORD PTR .LC7[rip]
movaps XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+112], xmm0
ret
PowerPC::ConditionRegister::s_crTable:
.zero 128
.LC0:
.quad -9223372032559808511
.quad -8646911280256385023
.LC1:
.quad -9223372032559808512
.quad -8646911280256385024
.LC2:
.quad 4294967297
.quad 576460756598390785
.LC3:
.quad 4294967296
.quad 576460756598390784
.LC4:
.quad -4611686014132420607
.quad -4035225261828997119
.LC5:
.quad -4611686014132420608
.quad -4035225261828997120
.LC6:
.quad 4611686022722355201
.quad 5188146775025778689
.LC7:
.quad 4611686022722355200
.quad 5188146775025778688
and with constexpr, this all get collapsed into:
PowerPC::ConditionRegister::s_crTable:
.quad -9223372032559808511
.quad -8646911280256385023
.quad -9223372032559808512
.quad -8646911280256385024
.quad 4294967297
.quad 576460756598390785
.quad 4294967296
.quad 576460756598390784
.quad -4611686014132420607
.quad -4035225261828997119
.quad -4611686014132420608
.quad -4035225261828997120
.quad 4611686022722355201
.quad 5188146775025778689
.quad 4611686022722355200
.quad 5188146775025778688
completely eliminating the static constructor. MSVC also exhibits this,
whereas clang is a little better and does this anyway, even without
constexpr.
2023-06-08 14:33:13 -04:00
349add0f81
GCMemcardManager: Shorten-up EnumMap definitions
...
We can make a small alias that gets rid of the need to repeat the long
constant.
2023-06-08 13:05:13 -04:00
1044bc40ca
GCMemcardUtils: Make use of std::span where applicable
...
Generifies bits of the interface so that some functions aren't
explicitly tied down to only using std::vector.
2023-06-08 12:59:43 -04:00
fae5ca39ad
InfinityBaseWindow: Move core headers into cpp file
...
Restricts the headers to the cpp file where they're needed and prevents
the headers from "leaking" into other translation units.
2023-06-08 12:39:10 -04:00
2b0a9477d0
MemoryViewWidget: Use QStringView with ConvertTextToBytes
...
Allows for avoiding string copies. While we're at it, we can also mark
ConvertTextToBytes as const.
2023-06-08 12:01:59 -04:00
cfd25f1d7c
CodeDiffDialog: Construct Diff instance in CalculateSymbolsFromProfile() when necessary
...
We can move the construction of the Diff instance into the body of the
if statement, so that we only construct this if the condition is true.
While we're at it, we can move the symbol description string into the
instance, getting rid of a copy. The function itself can also be const
qualified.
2023-06-08 11:55:57 -04:00
496aea54c0
CodeDiffDialog: Pass QString by const reference to create_item
...
Avoids churning string copies when updating
2023-06-08 11:48:09 -04:00
c99b0f2eb8
BreakpointWidget: Pass QString by const reference to create_item
...
Avoids churning string copies when performing updates.
2023-06-08 11:46:16 -04:00
867e7d259d
BreakpointDialog: Pass QString by const reference to invalid_input
...
Gets rid of redundant copying.
2023-06-08 11:45:14 -04:00
d092381d25
InfinityBaseWindow: Collapse lambda into direct member pointer
...
The parameters to this match the requirements of the toggled() function
exactly, so we can pass the function directly into the connect call.
2023-06-08 11:01:34 -04:00
1f874be36e
InfinityBaseWindow: Remove redundant string copies
...
tr() already returns a QString, so we don't need to construct a QString
around it, and FindFigure() already returns a std::string.
2023-06-08 11:01:29 -04:00
d35be7ce40
InfinityBaseWindow: Add missing header guard
...
Prevents potential inclusion issues.
2023-06-08 10:49:09 -04:00
1df482d51f
Prefer static const std::regex
...
std::regex has a relatively expensive constructor, and these are unchanging regexes.
2023-06-08 09:39:23 -05:00
78f5c5f8d2
Merge pull request #11899 from Filoppi/patch-20
...
Video: Fix Post Process shader options issues
2023-06-08 16:12:49 +02:00
3dbdf0472d
Merge pull request #11901 from Filoppi/add_texture_types
...
Video: add R10B10G10A2 and R16G16B16A16F texture types
2023-06-08 15:28:15 +02:00
e4636ad0a2
Merge pull request #11898 from Filoppi/patch-19
...
Video: Fix crash when getting the AA modes
2023-06-08 15:26:40 +02:00
65135190d4
Merge pull request #11897 from JosJuice/spurious-two-analog
...
InputCommon: Don't treat two analog inputs as a spurious trigger combo
2023-06-08 14:28:53 +02:00
cdc53c046b
Video: add R10B10G10A2 and R16G16B16A16F texture types (needed by PR 11850)
2023-06-08 03:17:20 +03:00
c9e61a79b7
Video: Fix Post Process shader options issues
...
-An assert would be erroneously thrown when shaders declared an array of 4 int or float options, despite 4 being the max supported (a simple <= / < mistake)
-When changing the type of a shader option (e.g. from bool to float), the serialization would be stuck appending the value from the previous option type, making the shader fail to build permanently until the cache were cleaned
2023-06-08 02:54:46 +03:00
80d12e3e88
Video: Fix crash when getting the AA modes
...
DX12 would often crash when starting and stopping the emulation many times, due to the device enumerator failing for some reason. Checking for success fixes it.
2023-06-08 02:46:08 +03:00
e831d7b6bb
InputCommon / VideoCommon: remove dynamic input reloading the texture cache, this is no longer needed, assets reload automatically!
2023-06-07 18:30:10 -05:00
ca8d6748d6
VideoCommon: introduce linked assets in TCacheEntry, allowing for assets to be reloaded
2023-06-07 18:30:10 -05:00
e92f8fcbb4
Remove old GCC version workarounds
...
The minimum GCC version is now GCC 10.
2023-06-06 22:49:53 -05:00
bab3229c98
Merge pull request #11874 from AdmiralCurtiss/vi-clock-bounds
...
VI: Prevent out-of-bounds access when clock register is a nonstandard value.
2023-06-06 20:31:42 -04:00
71ac6ec239
InputCommon: Don't treat two analog inputs as a spurious trigger combo
...
I've received a report from an Android user with a gamepad (a "BSP-D3")
where one physical trigger is controlling two analog axes at the same
time. This was causing RemoveSpuriousTriggerCombinations to delete both
axes, which is clearly not a desireable outcome.
With this change, now the axis with the greatest smoothness is kept,
or both in case they have the same smoothness.
2023-06-06 22:07:14 +02:00
a7678f3210
Merge pull request #11694 from jnaidu360/skylanders-portal-window
...
Skylanders Portal Menu Navigational Improvements
2023-06-06 19:20:39 +02:00
afc97ec20f
Merge pull request #11895 from JosJuice/android-no-host-check
...
Android: Temporarily disable host thread check
2023-06-06 18:56:41 +02:00
361171fce0
Android: Temporarily disable host thread check
...
Very broken. Will investigate, but let's revert it for the time being.
2023-06-06 18:39:32 +02:00
e1a986b270
Merge pull request #11893 from JosJuice/dual-core-exit-assert
...
Core: Declare emu thread as CPU thread while shutting down
2023-06-06 18:36:51 +02:00
38b033a476
Merge pull request #11762 from jbosboom/xinput2-raw-event-query
...
Xinput2: use raw events and queries
2023-06-06 18:14:51 +02:00
6bd5473d56
Core: Declare emu thread as CPU thread while shutting down
...
Fixes https://bugs.dolphin-emu.org/issues/13274 .
2023-06-06 18:04:21 +02:00
Pablo Stebler