e06480a8ab
Software/SWGfx: Default destructor in cpp file
...
Fixes a build failure with clang 17.
The destructor needs to be in the cpp file, since we have a forward
declared std::unique_ptr type as part of the class. So technically the
default inline destructor could invoke without seeing the full data type
definition.
2023-12-12 20:33:43 -05:00
7b57a4a37d
Merge pull request #12407 from lioncash/unused2
...
CPUThreadConfigCallback: Mark static ID as [[maybe_unused]]
2023-12-12 23:38:47 +00:00
ea3033731d
Merge pull request #12240 from iwubcode/material_asset_additional_properties
...
VideoCommon: add additional data types to material asset
2023-12-12 18:38:20 -05:00
5b4b8dba61
VideoCommon: add message to XF load assert
2023-12-12 22:35:02 +00:00
c14b3539c9
CPUThreadConfigCallback: Mark static ID as [[maybe_unused]]
...
This isn't used, but is likely kept around so the one-timed execution of
a magic static is taken advantage of.
2023-12-12 17:30:37 -05:00
53a51a6f1b
Merge pull request #12405 from lioncash/shadow2
...
General: Resolve lingering -Wshadow warnings
2023-12-12 22:20:23 +00:00
8c99198251
Merge pull request #12404 from lioncash/guard
...
CheatSearchWidget: Make use of CPUThreadGuard parameter in UpdateTableRows()
2023-12-12 22:18:26 +00:00
e883bbc57a
ConfigFloatSlider: Resolve -Wshadow warning
...
Fairly straightforward variable shadowing.
2023-12-12 17:07:37 -05:00
79c84c98ed
WC24PatchEngine: Resolve -Wshadow warning
...
While not captured, we're definitely shadowing the result variable
outside the lambda.
2023-12-12 17:03:42 -05:00
81d5370141
HLE_OS: Resolve -Wshadow warnings
...
We get a warning about shadowing the va_list type and just
run-of-the-mill variable shadowing, which we can easily fix.
2023-12-12 17:01:32 -05:00
a812a1f938
LightingShaderGen: Resolve -Wshadow warnings
...
Given how the lambda doesn't capture anything, we can move this to a
internally linked function, which prevents any name shadowing.
2023-12-12 16:55:06 -05:00
6184ec655e
Merge pull request #12403 from lioncash/uninit
...
PPCDebugInterface: Silence trivial -Wmaybe-uninitialized warning
2023-12-12 21:49:01 +00:00
995eb779fa
Merge pull request #12402 from lioncash/shadow
...
AchievementManager: Resolve -Wshadow warnings
2023-12-12 21:42:21 +00:00
915e43dfba
CheatSearchWidget: Make use of CPUThreadGuard parameter in UpdateTableRows
...
Previously, the parameter wasn't being used, because it was being
shadowed by another CPUThreadGuard at its only would-be usage point.
2023-12-12 16:41:00 -05:00
b4bfc4feba
Merge pull request #12401 from AdmiralCurtiss/feature-flag-fix
...
JitCommon: Fix feature_flags truncation in index calculation.
2023-12-12 20:56:04 +00:00
8cbb2c2e44
Merge pull request #12399 from lioncash/erasing
...
General: Make use of std::erase_if/std::erase where applicable
2023-12-12 20:54:52 +00:00
99959944eb
Merge pull request #12376 from lioncash/span2
...
VFFUtil: Use std::span with WriteToVFF
2023-12-12 20:50:17 +00:00
4d98c237c7
Merge pull request #12371 from lioncash/span
...
VideoCommon: Use std::span for BoundingBox::Write()
2023-12-12 20:47:08 +00:00
b0b1308160
PPCDebugInterface: Silence trivial -Wmaybe-uninitialized warning
...
We can just initialize register_index, even if it gets overwritten later
on via Common::FromChars.
2023-12-12 15:42:28 -05:00
18032f19a5
AchievementManager: Resolve -Wshadow warnings
...
Renames some variables to avoid shadowing warnings on gcc.
Also gets rid of a FilereaderState struct, since one is already defined
in the declaration of the AchievementManager class.
2023-12-12 15:37:20 -05:00
c1957ac169
JitCommon: Fix feature_flags truncation in index calculation.
2023-12-12 21:16:29 +01:00
c92e402454
Merge pull request #12398 from lioncash/parse
...
RiivolutionParser: Make use of std::span where applicable
2023-12-12 20:07:44 +00:00
198a53e7df
Merge pull request #12397 from lioncash/asset
...
CustomAssetLibrary: Remove unused GetAssetSize() function
2023-12-12 20:02:44 +00:00
ded2d55438
ExpressionParser: Avoid some miscellaneous copies
...
Just some trivial copies that can be eliminated or turned into moves.
2023-12-12 14:03:41 -05:00
a5bbeb721a
ExpressionParser: Mark constructors explicit where applicable
...
Makes for consistency with the surrounding code.
2023-12-12 14:00:27 -05:00
ea71a76ea9
ExpressionParser: Pass control qualifiers by const reference
...
These aren't necessarily cheap to copy, since a control qualifier will
have around 3 std::strings inside of it, so passing by value can churn
allocations a little bit.
2023-12-12 13:50:46 -05:00
9aea481e59
ExpressionParser: Make use of std::erase_if
2023-12-12 13:31:58 -05:00
196f8e5123
MappingCommon: Make use of std::erase_if
2023-12-12 13:31:18 -05:00
888a8692b4
SysConf: Make use of std::erase_if
2023-12-12 13:30:39 -05:00
01d15994fe
PatchEngine: Make use of std::erase
2023-12-12 13:30:08 -05:00
e69ac2d43e
Socket: Make use of std::erase_if
2023-12-12 13:29:33 -05:00
96eac73d11
NetKDRequest: Make use of std::erase
2023-12-12 13:27:54 -05:00
e7f7dde546
Formats: Make use of std::erase_if
2023-12-12 13:27:17 -05:00
df227aa03c
I2CBus: Make use of std::erase_if
2023-12-12 13:26:47 -05:00
ff0e7fbf08
GeckoCodeConfig: Make use of std::erase_if
2023-12-12 13:26:16 -05:00
84ae0c1c7e
ActionReplay: Make use of std::erase_if
2023-12-12 13:25:26 -05:00
50e4dc5dba
Watches: Make use of std::erase_if
2023-12-12 13:24:40 -05:00
b728e37086
RiivolutionParser: Remove usages of global system accessor
...
We can retrieve the encompassing system instance through the
CPUThreadGuard instance instead.
2023-12-12 12:48:40 -05:00
c2e39e0d68
RiivolutionParser: Make use of std::span where applicable
...
The main interface for these only take in patches and iterate over them
in a contiguous sequence, so we can reasonably generify the interface.
2023-12-12 12:38:43 -05:00
4c7a4831cb
CustomAssetLibrary: Remove unused GetAssetSize() function
...
There's a direct analogue of this function within
DirectFilesystemAssetLibrary that *is* used, however, so we can get rid
of this one.
2023-12-11 22:00:52 -05:00
2c6bf2d224
Merge pull request #12394 from lioncash/compare
...
General: Resolve -Wsign-compare warnings
2023-12-12 03:43:12 +01:00
e011c3b383
Core/SyncIdentifier: Default operator==
...
Lets us remove a bunch of code and a dependency on the <tuple> header.
2023-12-11 19:39:55 -05:00
6699acf10c
Merge pull request #12386 from lioncash/setting
...
Common/SettingsHandler: Minor convenience changes
2023-12-12 00:02:21 +00:00
f04d834e8f
Merge pull request #12393 from lioncash/tls
...
DolphinQT/Host: Remove unused TLS variable tls_is_host_thread
2023-12-12 00:29:21 +01:00
0e51c0f8fc
JitArm64_RegCache: Resolve -Wsign-compare warning
2023-12-11 18:15:50 -05:00
4c3a5eb1c5
JitArm64_SystemRegisters: Resolve -Wsign-compare warning
2023-12-11 18:11:34 -05:00
f97316a1e6
TraversalClient: Resolve -Wsign-compare warning
2023-12-11 18:01:29 -05:00
49f44c1334
VertexManagerBase: Resolve -Wsign-compare warning
2023-12-11 18:00:34 -05:00
b48af86148
Merge pull request #12390 from lioncash/string
...
GraphicsModListWidget: Add string specifier to By and Description fields
2023-12-11 23:47:53 +01:00
4f02f526b8
Merge pull request #12392 from lioncash/decl
...
General: Resolve -Wmissing-declaration warnings
2023-12-11 23:39:23 +01:00
Lioncash