476c95900d
EXI: When loading a savestate with a mismatching GCI folder memory card, reinizialize it with the header from the savestate to let a game still recognize it as the same card.
2020-06-17 01:44:46 +02:00
8b13e1882a
EXI: Store data for regenerating a GCI folder memory card header in EXI_Channel and pass it down to the memory card device.
2020-06-17 01:44:46 +02:00
e810d492f2
GCMemcard: Split off HeaderData from Header to have a compact block of data for consistent initialization.
2020-06-17 01:44:46 +02:00
cc52558c0e
GCMemcard: Assert struct requirements in header.
2020-06-17 01:30:42 +02:00
07bd200596
GCMemcard: Remove dependency on g_SRAM and force the caller to provide the relevant values instead.
2020-06-17 01:30:37 +02:00
1f505870a9
Merge pull request #8873 from AdmiralCurtiss/gcmemcard-namespace
...
GCMemcard: Move into a Memcard namespace.
2020-06-16 19:55:06 +01:00
de5941d6f8
Merge pull request #8878 from JosJuice/actually-disable-tgc-conversion
...
DolphinQt: Actually disable converting from TGC
2020-06-16 19:39:40 +01:00
a2b7627d66
Merge pull request #8860 from Ebola16/Emu
...
Android: Disallow multiple launcher activities
2020-06-16 19:38:55 +01:00
914ebdf0dd
GCMemcard: Move from global namespace into a Memcard namespace.
2020-06-16 20:18:39 +02:00
2e1bfe073c
GCMemcard: Split out MemoryCardBase into its own header, which is the base class for the raw and folder memory cards and has little to do with the actual memory card data structures.
2020-06-16 20:18:39 +02:00
ea3c3fd952
Android: Separate GameCube overlay refresh logic
2020-06-16 13:27:13 -04:00
851b438419
Merge pull request #8844 from Ebola16/RGL
...
Android: Refresh game library when resuming (Tv)MainActivity
2020-06-16 18:08:48 +02:00
1e6925e423
Android: Disallow multiple launcher activities
2020-06-16 11:52:58 -04:00
c236d89f64
DolphinQt: Actually disable converting from TGC
...
When I made PR 8773, I only covered the case where multiple files
are selected, not the more common case where one file is selected.
Oops
2020-06-16 11:21:44 +02:00
d4418a2b43
Merge pull request #8877 from JosJuice/convert-fail-message
...
DolphinQt: Make conversion error messages actually show up
2020-06-16 09:59:03 +01:00
20a3119d7a
DolphinQt: Make conversion error messages actually show up
...
I don't know why QErrorMessage doesn't work, but ModalMessageBox
works, so let's use ModalMessageBox.
2020-06-16 10:39:40 +02:00
2b25e1d6b9
DolphinQt: Don't show success message when converting missing file
2020-06-16 10:35:00 +02:00
349cdd5136
DolphinQt: Fix crash on right-clicking multiple games
...
GetSelectedGames() constructs a new list each time you call it.
2020-06-16 10:33:18 +02:00
bebeb935a5
Android: Android INI section
2020-06-14 10:54:08 -04:00
f9f4734237
Merge pull request #8850 from JosJuice/block-size-warning
...
Show an OSD message when running a disc image with a large block size
2020-06-14 15:03:32 +01:00
ad85012172
Merge pull request #8843 from Techjar/fastmem-ui
...
DolphinQt: Add fastmem option to debugger UI
2020-06-14 14:54:32 +01:00
9f5e6edc34
Merge pull request #8809 from Ebola16/ABB
...
Replace some acronyms
2020-06-14 14:30:52 +01:00
2a70d86d55
Replace some acronyms
2020-06-14 08:37:24 -04:00
bf83e3eea0
Merge pull request #8845 from Ebola16/DISC2
...
Android: Display disc number instead of company if mulipart disc
2020-06-14 12:20:36 +01:00
63c53ebc87
Merge pull request #8836 from Ebola16/REC
...
Android: Add recursive game paths to UI
2020-06-14 12:16:08 +01:00
cb54fc7543
Merge pull request #8857 from JosJuice/qt-bounding-box-width
...
DolphinQt: Use QFontMetrics::boundingRect instead of QFontMetrics::width
2020-06-14 12:10:33 +01:00
0ef9b998ce
Merge pull request #8658 from orbea/glslang
...
Externals: Update glslang.
2020-06-13 18:43:53 +01:00
bf11c2b74b
Merge pull request #8842 from Tilka/dsp
...
DSPSpy usability improvements
2020-06-10 09:14:30 +02:00
17498dbb4c
DolReader: if data segment goes off end of file, treat it as zero-fill (bss)
2020-06-09 18:00:24 -07:00
87330ae524
DolphinQt: Use QFontMetrics::boundingRect instead of QFontMetrics::width
...
See https://kdepepo.wordpress.com/2019/08/05/about-deprecation-of-qfontmetricswidth/
2020-06-08 12:32:36 +02:00
1c89e61d53
Android: Add option to disallow SD card writes
2020-06-08 03:45:59 -04:00
a56e6be999
DSPSpy: sync Makefile with current devkitPro template
2020-06-08 04:21:41 +01:00
fb041f75e5
DSPSpy: save and restore $sr properly
2020-06-08 04:21:41 +01:00
3118a68246
DSPSpy: show register names instead of numbers
...
also print summed $prod and individual $sr bits
2020-06-08 04:21:41 +01:00
595e1197b6
Rename existing BBA to BBA (TAP) to prepare for new BBA
...
Based on work by tommy1019
2020-06-07 23:17:28 -04:00
d5c00b8909
DSPSymbols: fix off-by-one error
2020-06-08 03:41:45 +01:00
162e3be82b
Show an OSD message when running a disc image with a large block size
...
This is intended to catch WIA files which have been created using
wit's default parameters (40 MiB block size), once the WIA PR is
merged. The check does however also work for GCZ files – not that
I think anyone has a GCZ file with a block size that large.
2020-06-07 14:11:00 +02:00
94f317010e
Merge pull request #8847 from Techjar/faster-file-path
...
Qt/GameListModel: Use absolutePath for file path column
2020-06-06 22:56:38 +01:00
d89162c8ad
Merge pull request #8848 from JosJuice/fix-build
...
Fix build
2020-06-06 15:46:32 +02:00
b4584abaa6
Fix build
...
There was a race condition between two PRs incrementing the
array size. CI didn't catch it because the PR that was merged
last (PR #8824 ) wasn't rebuilt after the first PR was merged.
2020-06-06 15:09:48 +02:00
9f7c72b7eb
Merge pull request #8824 from Techjar/sd-read-only
...
Add option to disallow SD card writes
2020-06-06 07:02:02 -04:00
fa208c4acd
Qt/GameListModel: Use absolutePath for file path column
...
canonicalPath is orders of magnitude slower as it has to perform actual
disk I/O to resolve symlinks, which makes sorting by this column
ridiculously slow for large game lists, especially if the games are on
a NAS. We probably don't need that, simply resolving relative paths
should be sufficient.
2020-06-06 05:24:23 -04:00
3b1e6f3b7f
Android: Display disc number instead of company if mulipart disc
2020-06-04 04:12:12 -04:00
9ee0740c2d
Android: Refresh game library when resuming (Tv)MainActivity
2020-06-02 16:45:23 -04:00
5c38727651
DolphinQt: Add fastmem option to debugger UI
2020-06-02 06:18:52 -04:00
209308a4d6
Replace usage of std::result_of with std::invoke_result
...
std::result_of is deprecated in C++17, and removed in C++20. Microsoft
has gone ahead with the removal as of Visual Studio 16.6.0, so before
this change our code is broken there.
2020-06-01 17:33:18 -04:00
9ea8f29765
Android: Conditionally respond to modified settings
2020-06-01 07:43:19 -04:00
b0258af530
DSP/Interpreter: fix comments not matching opcode table
2020-05-31 15:21:20 +01:00
198a307db3
DSP/Interpreter: simplify switch
2020-05-31 15:21:20 +01:00
89de40a22e
DSP/Interpreter: remove redundant masking
2020-05-31 15:21:19 +01:00
ce1846e53f
DSPSpy: fix register editing using GC pad on Wii
2020-05-31 15:21:19 +01:00
77f539355d
Android: Add recursive game paths to UI
2020-05-31 10:00:09 -04:00
ba2d04b793
Externals: Fix build failures with the newer glslang.
...
v2: Don't include glslang project wide.
2020-05-30 18:54:21 -07:00
52e0294166
Add option to disallow SD card writes
2020-05-28 15:11:37 -04:00
b3c705fa96
Merge pull request #8829 from stenzek/fix-macos-again
...
Core: Use window instead of surface for ControllerInterface updates
2020-05-28 16:56:13 +10:00
b4e063311e
Merge pull request #8827 from stenzek/adreno-more-like-brokenreno
...
FramebufferManager: Fix invalid readback of EFB D24S8 depth
2020-05-28 16:55:42 +10:00
53aff81c45
Merge pull request #8821 from Ebola16/TV
...
Android TV: Add Open File and Install WAD
2020-05-27 21:41:09 +02:00
86f8768268
VideoCommon/ShaderGenCommon: Make template functions regular functions
...
These are only ever used with ShaderCode instances and nothing else.
Given that, we can convert these helper functions to expect that type of
object as an argument and remove the need for templates, improving
compiler throughput a marginal amount, as the template instantiation
process doesn't need to be performed.
We can also move the definitions of these functions into the cpp file,
which allows us to remove a few inclusions from the ShaderGenCommon
header. This uncovered a few instances of indirect inclusions being
relied upon in other source files.
One other benefit is this allows changes to be made to the definitions
of the functions without needing to recompile all translation units that
make use of these functions, making change testing a little quicker.
Moving the definitions into the cpp file also allows us to completely
hide DefineOutputMember() from external view, given it's only ever used
inside of GenerateVSOutputMembers().
2020-05-25 21:12:29 -04:00
e3506ff4ef
VideoCommon/ShaderGenCommon: Convert helper functions over to fmt
...
A very trivial conversion, this simply converts calls to Write over to
WriteFmt and adjusts the formatting specifiers as necessary.
This also allows the const char* parameters to become std::string_view
instances, allowing for ease of use with other string types.
2020-05-25 21:12:29 -04:00
68706973d2
Merge pull request #8828 from stenzek/gles-readpixels
...
FramebufferManager: Copy to color format for depth readbacks on GLES
2020-05-25 08:57:20 +02:00
aaa19acbd0
DSP/Interpreter: simplify opcode table by masking
2020-05-24 15:51:52 +01:00
e651592ef5
Misc cleanup
2020-05-24 15:51:52 +01:00
a660033e8c
Merge pull request #8792 from leoetlino/video-backend
...
Migrate video backend setting to the new config system
2020-05-24 15:26:44 +02:00
1203e626b3
Merge pull request #8800 from sepalani/kd-shutdown
...
IOS/KD: Implement IOCTL_NWC24_REQUEST_SHUTDOWN
2020-05-24 15:24:51 +02:00
166633bf27
Merge pull request #8826 from iwubcode/try_parse_any_base
...
Common / Core: Update StringUtil to allow specifying the base
2020-05-24 15:13:49 +02:00
7449c7153c
Merge pull request #8830 from JosJuice/delete-empty-rfl-db
...
CheckNAND: Delete RFL_DB.dat if empty
2020-05-24 15:12:39 +02:00
f71ebfe9c1
CheckNAND: Delete RFL_DB.dat if empty
2020-05-24 11:04:23 +02:00
ff92357b63
Core: Use window instead of surface for ControllerInterface updates
...
Fixes crashes with Vulkan on macOS.
2020-05-24 17:39:56 +10:00
bf74553878
FramebufferManager: Copy to color format for depth readbacks on GLES
...
glReadPixels() with depth formats is not supported.
Should fix broken EFB access on GLES.
2020-05-24 16:11:11 +10:00
ad373950a2
FramebufferManager: Fix invalid readback of EFB D24S8 depth
...
Fixes assertion tripping when saving state on Adreno.
2020-05-24 15:36:04 +10:00
85e11cd4ab
Common / Core: Update StringUtil to allow specifying the base, default to 0. Fix ActionReplay code to use this instead of prepending '0x' in front
2020-05-23 18:40:10 -05:00
1df1a9abe6
IOS/KD: Implement IOCTL_NWC24_REQUEST_SHUTDOWN
2020-05-22 19:19:36 +04:00
8df56cb319
Migrate video backend setting to the new config system
...
Fixes https://bugs.dolphin-emu.org/issues/12087
2020-05-22 16:54:53 +02:00
393ce529af
Merge pull request #8771 from Leseratte10/master
...
Add /dev/dolphin interface to allow game to read the REAL product code
2020-05-22 16:49:31 +02:00
7aec045ef7
Merge pull request #8799 from Ebola16/AT
...
Android: Consistent TODO formatting
2020-05-22 16:44:43 +02:00
6d3b0db041
DolphinQt: Fix freelook description typos
...
cControls -> controls, axis -> axes, removed leading spaces.
2020-05-20 21:56:04 +02:00
cfe1687248
Android TV: Add Open File and Install WAD
2020-05-19 03:24:32 -04:00
cc330afa6b
DolphinQt: Fix the panic alert deadlock, Pause on Focus Loss edition
...
why are there so many ways to trigger this issue
2020-05-18 19:38:56 +02:00
abe125aea7
Merge pull request #8816 from JosJuice/qfontmetrics-width
...
DolphinQt: Remove another usage of QFontMetrics::width
2020-05-18 00:19:41 +01:00
f87e32840f
DolphinQt: Remove another usage of QFontMetrics::width
...
QFontMetrics::width breaks building with CMake on Windows,
due to a deprecation warning which gets promoted to an error.
2020-05-18 00:39:57 +02:00
10870a0f74
Config: Migrate SSL options to Onion config
2020-05-17 20:37:10 +01:00
798dc2c532
Merge pull request #8814 from Tilka/dsp
...
DSP: fix DSPTool build and update register table
2020-05-17 20:04:13 +01:00
2250fbce0e
Merge pull request #8802 from leoetlino/wiiroot-mii-db
...
WiiRoot: Fix empty files being created when source is missing
2020-05-17 20:11:11 +02:00
099197b480
Merge pull request #8797 from iwubcode/save-state-CLI
...
Core: Add support for booting a save state from command line
2020-05-17 17:34:08 +02:00
cea779cc84
Merge pull request #8767 from iwubcode/freelook-camera-type
...
Expand freelook camera with control options
2020-05-17 17:33:04 +02:00
a12159f2b6
DSPTool: fix build
2020-05-17 10:47:20 +01:00
2137fb7813
Externals: Add zstd
...
I had to rename Source/Common/Compiler.h because the VS build
confuses it with Externals/zstd/lib/common/compiler.h otherwise.
2020-05-13 20:53:10 +02:00
4bf7c3e051
NetworkWidget: Add Blocking column
2020-05-13 11:53:29 +04:00
ac9b246809
Core/UICommon: Fix EnableScreenSaver preprocessor directive
...
The include for X11Utils.h (and by extension Xlib.h) is gated behind
HAVE_XRANDR, as well as the declaration for this function, but its
definition was mistakenly gated behind HAVE_X11. Therefore, if we have
X11 but not Xrandr, the build will fail due to declaration/definition
mismatch and the missing Window type.
2020-05-13 02:11:29 -04:00
2488e4a587
Merge pull request #8795 from WamWooWam/master
...
InputCommon: Use the Window handle when initializing DirectInput.
2020-05-10 19:16:15 +10:00
daf1c30a94
GCAdapter: add libusb error logging on reads/writes
2020-05-10 09:26:49 +02:00
76ae1d4070
Apply fixes to all platforms
2020-05-09 22:35:20 +01:00
c8aa077f8c
Android: Consistent TODO formatting
2020-05-09 12:33:09 -04:00
47ee5ac284
WiiRoot: Fix empty files being created when source is missing
...
CopyNandFile must not create empty files on the destination filesystem
if the source file doesn't exist.
Otherwise, this can lead to an empty Mii database being created in the
session Wii root if there's no database in the configured Wii root and
netplay or Movie is used -- that database would then be copied back to
the configured root, which causes games like MKW to complain about
corrupted Mii data even when the player has stopped using netplay.
This commit also simplifies CreateFullPath usage.
There's no need to manually extract the directory from the path,
FS::CreateFullPath does it automatically just like File::CreateFullPath
2020-05-09 16:47:45 +02:00
cdf5490d56
Core: Add support for specifying a command line option to boot the game into a save-state
2020-05-06 22:10:30 -05:00
74b2410d7e
Merge pull request #8760 from JosJuice/multithreaded-compress
...
DiscIO: Implement multithreaded compression
2020-05-06 15:25:30 +02:00
b93bbbf2e5
DiscIO: Implement multithreaded compression
2020-05-06 14:18:51 +02:00
78e8ccea6d
Update ControllerInterface.cpp
2020-05-06 01:30:49 +01:00
bb75050f68
Jit: fix warning -Winvalid-offsetof
...
Remove the warning:
warning: offsetof within non-standard-layout type ‘JitBlock’ is conditionally-supported
JitBlock contains non-trival types now. Split the fields with trival
types that needs to be access from JIT code into JitBlockData structure.
2020-05-04 18:26:56 +02:00
7c0ef725ab
Merge pull request #8744 from cristian64/save_restore_netplay_browser_settings
...
DolphinQt: Saving and restoring NetPlay Session Browser dialog's settings.
2020-05-04 00:50:26 +02:00
c53ecdd689
Merge pull request #8686 from sepalani/thread-tab
...
Debugger: Add a Thread widget
2020-05-04 00:50:10 +02:00
947d6732a8
Merge pull request #8712 from sepalani/console-type
...
Boot: Add ConsoleType enum class
2020-05-03 23:10:44 +02:00
9e2560b825
Merge pull request #8790 from leoetlino/ras-syndrome
...
Remove redundant "Emulation" from "DSP HLE Emulation"
2020-05-03 16:47:05 -04:00
aed7319ef8
DolphinQt: Expose freelook camera control to UI
2020-05-03 13:34:13 -05:00
e125c61d47
VideoCommon: remove VertexShaderManager functions instead preferring the direct freelook camera methods
2020-05-03 13:34:13 -05:00
5bd7cc8bac
Core: Add freelook camera control type setting
2020-05-03 13:34:13 -05:00
6e7d1e0e71
VideoCommon: Add Free Look camera with separate modes
2020-05-03 13:31:47 -05:00
bf12bb3d43
Boot: Add ConsoleType enum class
2020-05-03 20:55:09 +04:00
39d34e133f
Debugger: Add a Thread widget
...
DebugInterface: Add GetThreads
WatchWidget: Update widget on AddWatch
2020-05-03 20:48:30 +04:00
9ffa72ad1f
Merge pull request #8691 from howard0su/warning_wiimote
...
WiimoteEmu: Cleanup warnings of -Wparentheses
2020-05-03 18:31:57 +02:00
297bbceadf
Remove redundant "Emulation" from "DSP HLE Emulation"
...
HLE stands for "high-level emulation", so "DSP HLE Emulation" would
mean "DSP High-Level Emulation Emulation"
2020-05-03 17:54:05 +02:00
6e01855e8e
Merge pull request #8770 from Ebola16/ADSP
...
Android: Add DSP Emulation Engine
2020-05-03 17:51:46 +02:00
16f0864a4f
DolphinQt: Saving and restoring NetPlay Session Browser dialog's settings.
2020-05-03 17:45:52 +02:00
907b1302b0
Merge pull request #8775 from leoetlino/rect
...
MathUtil: Fix Rectangle::GetWidth/Height for unsigned types
2020-05-03 15:41:38 +02:00
920cf38889
Merge pull request #8757 from sepalani/so-cleanup
...
IOS/KD: Cleanup sockets on IOCTL_NWC24_CLEANUP_SOCKET
2020-05-03 15:41:14 +02:00
1b26929119
Merge pull request #8789 from JosJuice/windows-cmake-errors
...
Fix Windows CMake build errors
2020-05-03 15:33:58 +02:00
07ab79db64
MathUtil: Fix Rectangle::GetWidth/Height for unsigned types
...
`std::abs(x - y)` where x and y are unsigned integers fails to compile
with an "call of overloaded 'abs(unsigned int)' is ambiguous" error
on GCC, and even if it did compile, that expression still wouldn't
give the correct result since `x - y` is unsigned.
2020-05-03 14:41:58 +02:00
0ab9475f8e
Merge pull request #8786 from JosJuice/user-style-not-path
...
DolphinQt: Store name of user style, not path
2020-05-03 14:11:55 +02:00
bf57abc0d5
Fix Windows CMake build errors
...
Lambda expressions with uncaptured constants were leading to errors,
and there were also some warnings about deprecated functions
(QFontMetrics::width and inet_ntoa).
2020-05-03 14:10:24 +02:00
90ba73c6c2
Merge pull request #8787 from leoetlino/config-config
...
Remove redundant Config prefix from ConfigInfo/ConfigLocation
2020-05-03 14:07:41 +02:00
f27278f7f4
Add /dev/dolphin interface to allow game to read the REAL product code
2020-05-03 09:46:01 +02:00
19da101164
Remove redundant Config prefix from ConfigInfo/ConfigLocation
...
Both structs are already in the Config namespace.
2020-05-02 14:40:14 +02:00
aab694e6b5
DolphinQt: Store name of user style, not path
...
This makes user styles not break when for instance
moving a portable.txt install between different folders.
2020-05-02 02:13:01 +02:00
47d1dec723
Merge pull request #8783 from JosJuice/i18n-comments
...
DolphinQt: Add some i18n comments for recently added strings
2020-05-02 02:12:27 +02:00
9932a02565
IOS/KD: Cleanup sockets on IOCTL_NWC24_CLEANUP_SOCKET
2020-05-01 16:33:42 +04:00
423241b8a2
DolphinQt: Reword memory override description
2020-05-01 14:11:08 +02:00
b7db7ebbc7
Don't assume fixed width for "Emulated memory size mismatch!" message
...
Panic alerts don't use fixed width fonts, and translators are
unlikely to preserve the exact spacing unless they are given
specific instructions to do so and are willing to fight against
the Transifex interface a bit.
2020-05-01 13:40:34 +02:00
492bb5ccee
DolphinQt: Add some i18n comments for recently added strings
2020-05-01 13:22:54 +02:00
312a3ba8c8
WiimoteEmu: Cleanup warnings of -Wparentheses
...
Add parentheses around operator ^.
2020-04-30 08:07:02 +08:00
9fd1385733
Externals: Fix OpenAL include directory.
2020-04-29 13:07:51 +02:00
fc0df37d94
Fix windows build system.
2020-04-29 12:56:52 +02:00
990acbb17d
Externals: Fix ed25519 include path.
2020-04-29 12:55:42 +02:00
f8f592c345
Externals: Update minizip search path.
2020-04-29 12:41:36 +02:00
ae2d567f59
Externals: Fix include path for picojson and discord
2020-04-29 11:45:59 +02:00
239cde8aea
Externals: Alter the soundtouch include directory.
...
We must not provide the /Externals directory as global include directory.
Here, this yield a crash because of external minizip header and system library mismatch.
Soundtouch itself recormends to include it with <SoundTouch.h> and -I/usr/include/soundtouch, so this should fit better.
2020-04-29 11:30:26 +02:00
b7db359081
XFMemory: SETPOSMTXINFO should be SETPOSTMTXINFO
...
It actually maps to postMtxInfo, not posMtxInfo (which isn't a thing).
This is especially confusing because there *are* position matrices (as
opposed to post-transform matrices).
2020-04-29 05:26:02 +02:00
2a7f150561
Merge pull request #8774 from JosJuice/volumeverifier-ios9
...
VolumeVerifier: Treat IOS9 as always present
2020-04-28 21:24:44 -04:00
e921cbe57c
GCMemcardManager: Add GUI to create new memory card.
2020-04-28 23:59:15 +02:00
5b722b775a
VolumeVerifier: Treat IOS9 as always present
...
Fixes a false positive for Mario Party 8.
2020-04-28 23:40:01 +02:00
4b00ddf9aa
Merge pull request #8722 from Minty-Meeo/master
...
Configurable MEM1 and MEM2 sizes at runtime via Dolphin.ini
2020-04-28 22:11:12 +02:00
cc858c63b8
Configurable MEM1 and MEM2 sizes at runtime via Dolphin.ini
...
Changed several enums from Memmap.h to be static vars and implemented Get functions to query them. This seems to have boosted speed a bit in some titles? The new variables and some previously statically initialized items are now initialized via Memory::Init() and the new AddressSpace::Init(). s_ram_size_real and the new s_exram_size_real in particular are initialized from new OnionConfig values "MAIN_MEM1_SIZE" and "MAIN_MEM2_SIZE", only if "MAIN_RAM_OVERRIDE_ENABLE" is true.
GUI features have been added to Config > Advanced to adjust the new OnionConfig values.
A check has been added to State::doState to ensure savestates with memory configurations different from the current settings aren't loaded. The STATE_VERSION is now 115.
FIFO Files have been updated from version 4 to version 5, now including the MEM1 and MEM2 sizes from the time of DFF creation. FIFO Logs not using the new features (OnionConfig MAIN_RAM_OVERRIDE_ENABLE is false) are still backwards compatible. FIFO Logs that do use the new features have a MIN_LOADER_VERSION of 5. Thanks to the order of function calls, FIFO logs are able to automatically configure the new OnionConfig settings to match what is needed. This is a bit hacky, though, so I also threw in a failsafe for if the conditions that allow this to work ever go away.
I took the liberty of adding a log message to explain why the core fails to initialize if the MIN_LOADER_VERSION is too great.
Some IOS code has had the function "RAMOverrideForIOSMemoryValues" appended to it to recalculate IOS Memory Values from retail IOSes/apploaders to fit the extended memory sizes. Worry not, if MAIN_RAM_OVERRIDE_ENABLE is false, this function does absolutely nothing.
A hotfix in DolphinQt/MenuBar.cpp has been implemented for RAM Override.
2020-04-28 12:10:50 -05:00
d006a8b52f
DolphinQt: Disable converting from TGC
...
This should not be exposed to users before the merge of PR #8644 .
(PR #8738 was unintentionally merged before PR #8644.)
2020-04-28 18:49:52 +02:00
116cef572b
Merge pull request #8738 from JosJuice/convert-dialog
...
Replace the compress/uncompress actions with a convert dialog
2020-04-28 12:37:17 -04:00
165c2e3017
Merge pull request #8772 from JosJuice/create-backup-dir
...
Core: Call CreateFullPath before using Backup directory
2020-04-28 12:35:05 -04:00
95a0897491
Core: Call CreateFullPath before using Backup directory
2020-04-28 17:53:12 +02:00
ee200d09eb
Jit64/Jit64_Tables: Construct tables at compile-time
...
Utilizing constexpr, we can eliminate the need to construct the tables
at runtime and just do all the work at compile-time. Making for less
moving parts overall.
The general structure is more or less the same, however rather than one
single initialization function, each table is built off an immediately
executed lambda function. This is nice, since it narrows the scope of
the table building logic down to the tables that actually need it.
2020-04-28 17:12:24 +02:00
19115c84dd
DolphinQt: Use qOverload where applicable
...
Provides the same behvaior, but in a much more concise manner.
2020-04-28 16:54:19 +02:00
8288bdce03
Fix Hotkey Controller Profile display with boxes for each Wiimote
2020-04-28 15:55:53 +02:00
93abbc66aa
Merge pull request #8688 from howard0su/cleanup_strncpy
...
Remove warning of -Wstringop-truncation
2020-04-28 14:28:30 +02:00
7390767008
Merge pull request #8668 from sepalani/rso-autodetect
...
RSO: Auto-detect RSO location in RAM
2020-04-28 14:27:13 +02:00
0fe4985f8d
Merge pull request #8689 from howard0su/cleanup_sign
...
Remove warnings of -Wsign-compare
2020-04-28 13:36:21 +02:00
f3d7b82f83
Cleanup warnings of -Wswitch
...
Add default branch to the switch-case.
2020-04-28 13:16:30 +02:00
586af0a55e
Merge pull request #8695 from howard0su/warning_hw
...
HW: cleanup warnings of -Wtype-limits
2020-04-28 13:13:22 +02:00
fa7d6c8993
Merge pull request #8769 from Ebola16/SCDDD
...
Android: Fix MenuTag typo
2020-04-28 12:06:04 +02:00
8f578fd2b9
Merge pull request #8704 from JosJuice/setting-txt-output-null
...
SettingsHandler: Don't output null bytes
2020-04-28 12:02:39 +02:00
a58942b442
Android: Add DSP Emulation Engine
2020-04-28 00:59:48 -04:00
f3800659b9
Android: Fix MenuTag typo
2020-04-27 17:33:03 -04:00
5e33cd48da
Debugger: Add a Network widget
...
Display socket table, SSL context and options
2020-04-27 21:47:00 +04:00
88ae4c7914
Merge pull request #8729 from JosJuice/android-touch-ir-default
...
Android: Use touch emulation of IR by default
2020-04-27 17:56:01 +02:00
5909d13236
Merge pull request #8710 from Ebola16/QTDP
...
Qt: Display default Paths
2020-04-27 17:49:31 +02:00
d040f91c3a
Merge pull request #8709 from Ebola16/AS
...
Android: Split General settings
2020-04-27 17:13:57 +02:00
e6351e1d4b
Merge pull request #8719 from CookiePLMonster/dolby-pro-logic-quality-fixup-ii
...
AudioPane: Do not enable DPL II quality slider with HLE audio on init
2020-04-27 17:11:56 +02:00
18a4afb053
Android: Use touch emulation of IR by default
...
While having motion control emulation of IR enabled by default
makes sense in situations like using a DualShock 4 on a PC,
Android has the additional option of touch emulation of IR
which seems to be better liked, and the default value which
was chosen with PC in mind was carried over to Android
without any particular consideration. This change disables
motion control emulation of IR by default on Android only.
2020-04-27 17:02:53 +02:00
1ca682e6a1
Merge pull request #8723 from seanyeh/fix-confirm-dialog-enter
...
Qt/GameList: Use KeyPress instead of KeyRelease
2020-04-27 17:00:58 +02:00
71f409dac4
Merge pull request #8726 from xperia64/dns_improvements
...
Respect Core::WantsDeterminism for DNS servers on Linux
2020-04-27 16:43:24 +02:00
9d44af4c31
Merge pull request #8696 from howard0su/cleanup_shadow
...
Cleanup warnings of -Wmissing-declarations
2020-04-27 15:33:01 +02:00
bab04155b6
Merge pull request #8745 from AdmiralCurtiss/savestate-load-callback-qt
...
Qt/Debugger: Refresh on savestate load.
2020-04-27 15:29:55 +02:00
b175e9e6ac
Merge pull request #8748 from Ebola16/WAD
...
Android: Add Install WAD to menu_game_grid
2020-04-27 15:15:39 +02:00
75e79ece73
Merge pull request #8751 from jordan-woyak/point-fix
...
WiimoteEmu: Apply "Tilt" and "Point" rotations separately for proper tilted pointing.
2020-04-27 14:55:19 +02:00
03c569ac16
Merge pull request #8762 from degasus/ext_lib
...
Externals: Add bzip2 and libLZMA.
2020-04-27 12:18:05 +02:00
bacf0d629d
VolumeVerifier: Show desync warning for dual layer discs too
2020-04-25 19:47:08 +02:00
9fd03cda9d
Externals: Add libLZMA.
2020-04-24 15:18:09 +02:00
4385afdb0a
Externals: Add bzip2.
2020-04-24 15:18:09 +02:00
99c8ce9d8d
DolphinQt: Add info about formats in convert dialog
2020-04-24 15:11:20 +02:00
466b2d7202
DolphinQt: Make block size configurable in convert dialog
2020-04-24 15:11:20 +02:00
acd00723ad
DolphinQt: Make scrubbing configurable in convert dialog
2020-04-24 15:11:20 +02:00
6ffcbcee70
DiscIO: Move scrubbing code out of ConvertToGCZ
...
This way, scrubbing can also be performed when converting
to other formats.
2020-04-24 15:11:20 +02:00
04c7892b93
DiscIO: Add GameCube disc scrubbing support
...
The code was actually already rather well adapted for this.
We more or less just have to skip ParseDisc and run
ParsePartitionData directly. This required the PartitionHeader
struct to be removed (which wasn't that useful anyway).
2020-04-24 15:10:36 +02:00
cefc2a7baa
DiscIO: Fix edge case where blocks could get scrubbed accidentally
...
If we start 31 KiB into a 32 KiB block and want to mark 2 KiB
of data as used, we need to mark 2 blocks as used, not just 1.
This problem is avoided when calling MarkAsUsed from
MarkAsUsedE, since MarkAsUsedE aligns to 32 KiB on its own.
Most calls to MarkAsUsed are from MarkAsUsedE, which is why
this hasn't been a noticeable problem in the past.
2020-04-24 15:10:36 +02:00
dae2c14f7f
DolphinQt: Turn the compress/decompress action into a dialog
2020-04-24 15:10:35 +02:00
42f6913bcc
Move DiscIO::ConvertToPlain to FileBlob.cpp
...
There is no longer anything GCZ specific about it.
2020-04-24 15:10:35 +02:00
8a9597e32e
DiscIO: Allow converting from formats other than ISO and GCZ
...
The constant DESIRED_BUFFER_SIZE was determined by multiplying the
old hardcoded value 32 with the default GCZ block size 16 KiB.
Not sure if it actually is the best value, but it seems fine.
2020-04-24 15:10:35 +02:00
432f342bc8
DiscIO: Use a struct for Wii hashes
2020-04-24 14:44:29 +02:00
da9e0fb598
DiscIO: Parallelize the re-encryption code
2020-04-24 14:44:26 +02:00
319c508978
DiscIO: Implement re-encryption of Wii partition data
2020-04-24 14:24:12 +02:00
a4c7100bcc
DiscIO: Use partition data offset for ReadWiiDecrypted parameter
...
Instead of the partition offset (which is usually 0x20000 less).
2020-04-24 14:16:55 +02:00
7e94d6ed37
Merge pull request #8740 from JosJuice/fix-decompress
...
DiscIO: Fix decompressing writing the wrong number of bytes sometimes
2020-04-24 10:42:46 +02:00
703f7d4fc0
Merge pull request #8755 from Sintendo/jit64intopts
...
Jit64: More addx and subfx optimizations
2020-04-24 07:40:07 +02:00
523954e03a
Analytics: Report correct quirk for mismatched xf/bp colors
...
Looks like a copy-paste error. The quirk for mismatched xf/bp texgens
was used twice.
2020-04-24 02:22:51 +02:00
c5c080b235
Android: Run installWAD on separate thread
2020-04-23 19:31:41 -04:00
2d6d0c86cc
Android: Add Install WAD to menu_game_grid
2020-04-22 13:56:44 -04:00
f83addee68
Merge pull request #8718 from JosJuice/android-tv-long-press
...
Android TV: Fix crash when long pressing a game
2020-04-22 04:25:44 -04:00
2673280614
Merge pull request #8389 from sepalani/fix-so
...
Socket: Abort pending ops on close
2020-04-22 07:19:25 +02:00
5ec80a554c
Socket: Abort pending operations on close
2020-04-22 08:48:37 +04:00
a5bd263dfb
Merge pull request #8714 from JosJuice/progress-dialog-thread
...
DolphinQt: Run tasks that use progress dialogs on separate threads
2020-04-21 23:59:37 -04:00
19dda51a0d
Jit64: subfx - Use LEA when possible
...
Similar to what we do for addx. Since we're calculating b - a and
because subtraction is not communitative, we can only apply this when
source register a holds the constant.
Before:
45 8B EE mov r13d,r14d
41 83 ED 08 sub r13d,8
After:
45 8D 6E F8 lea r13d,[r14-8]
2020-04-21 22:45:47 +02:00
89646c898f
Jit64: addx - Skip ADD after MOV when possible
...
We can get away with skipping the addition when we know we're dealing
with a constant zero. Just a MOV will suffice in this case.
Once again, we don't bother to add separate handling for when overflow
is needed, because no titles would ever hit that path during my testing.
Before:
8B 7D F8 mov edi,dword ptr [rbp-8]
83 C7 00 add edi,0
After:
8B 7D F8 mov edi,dword ptr [rbp-8]
2020-04-21 22:45:47 +02:00
50f7a7d248
Jit64: addx - Prefer smaller MOV+ADD sequence
...
ADD has a smaller encoding for immediates that can be expressed as an
8-bit signed integer (in other words, between -128 and 127). MOV lacks
this compact representation.
Since addition allows us to swap the source registers, we can always get
the shortest sequence here by carefully checking if we're dealing with a
small immediate first. If we are, move the other source into the
destination and add the small immediate onto that. For large immediates
the reverse is preferrable.
Before:
41 BE 40 00 00 00 mov r14d,40h
44 03 75 A8 add r14d,dword ptr [rbp-58h]
After:
44 8B 75 A8 mov r14d,dword ptr [rbp-58h]
41 83 C6 40 add r14d,40h
Before:
44 8B 7D F8 mov r15d,dword ptr [rbp-8]
41 81 C7 00 68 00 CC add r15d,0CC006800h
After:
41 BF 00 68 00 CC mov r15d,0CC006800h
44 03 7D F8 add r15d,dword ptr [rbp-8]
2020-04-21 22:42:02 +02:00
2481660519
Jit64: addx - Emit MOV when possible
...
When the source registers are a simple register and a constant zero and
overflow isn't needed, emitting LEA is kinda silly.
This will occasionally save a single byte for certain registers due to
how x86 encoding works. More importantly, LEA takes up execution
resources while MOV does not.
Before:
41 8D 7D 00 lea edi,[r13]
After:
41 8B FD mov edi,r13d
2020-04-21 22:36:20 +02:00
1c25e6352a
Jit64: addx - Emit nothing when possible
...
When the destination register matches a source register, the other
source register contains zero, and overflow isn't needed, the
instruction becomes a nop and we don't need to emit anything.
We could add specialized handling for the case where overflow is needed,
but none of the titles I tried would hit this path.
Before:
83 C7 00 add edi,0
After:
2020-04-21 22:35:17 +02:00
f1c3ab359d
Jit64: addx - Deduplicate branches part 2
...
No functional change, just simplify some repeated logic in the case
where we're dealing with exactly one immediate and one simple register
when overflow isn't needed.
2020-04-21 22:06:46 +02:00
72fbdf1a6b
Jit64: addx - Deduplicate branches part 1
...
No functional change, just simplify some repeated logic for the cases
where the destination register matches one of the sources.
2020-04-21 22:06:39 +02:00
c33565295d
Merge pull request #8713 from sepalani/dbg-printf
...
HLE: Add more debug functions
2020-04-21 12:58:34 -04:00
d845b31579
Merge pull request #8717 from stenzek/mismatched-xf-bp
...
VertexManagerBase: Skip drawing objects with mismatched xf/bp stages
2020-04-21 10:07:36 -04:00
d6dfb3a553
WiimoteEmu: Rename some variables from "cursor" to "point".
2020-04-18 13:20:50 -05:00
bd067875e7
WiimoteEmu: Apply "Tilt" rotations separately and before those of "Point" and "Swing" for proper tilted pointing.
2020-04-18 13:15:52 -05:00
b2cf106ae9
IOS/FS: Fix FST write failure on some platforms
...
On some platforms (like Windows), the temporary file must be closed
before it can be renamed.
I guess nobody noticed this for so long because (1) the FS code has a
failsafe for missing FST entries (because existing users do not have
a FST), and most games do not care about file metadata;
(2) the write failures can only be seen in the logs.
Because we don't want this to break, I have turned the ERROR_LOGs into
PanicAlerts.
2020-04-18 12:42:12 +02:00
cf67b2093e
Merge pull request #8735 from Ebola16/INIT
...
Android: Reload Wii Remote settings upon saving them
2020-04-17 11:31:18 +02:00
9de3717c50
Merge pull request #8340 from stenzek/max-res
...
DolphinQt: Don't overwrite >8x IR scale in ini, add maximum internal res option
2020-04-16 21:01:14 -04:00
096e63d3f9
Android: Set Insert SD Card default setting to true
2020-04-16 19:11:19 -04:00
935b12d785
Merge pull request #8730 from JosJuice/frame-advance-duplicate-frame
...
Core: Skip duplicate frames when using frame advance
2020-04-16 18:29:16 -04:00
85a8325701
Merge pull request #8733 from JosJuice/di-baten-kaitos
...
Adjust s_DIMAR/s_DILENGTH behavior (fixes Baten Kaitos music)
2020-04-16 18:28:09 -04:00
19fc43f190
Merge pull request #8708 from Ebola16/Wii
...
Android: Add Insert SD Card and update the description
2020-04-16 18:27:51 -04:00
55ed980620
Merge pull request #8711 from Ebola16/SDDE
...
Set Insert SD Card default value to true
2020-04-16 18:25:47 -04:00
3629e75dd2
Merge pull request #8716 from Pokechu22/properties-leak
...
Delete properties dialog on close
2020-04-16 13:53:37 +02:00
19e9a9c945
DiscIO: Clean up decompression size calculation
...
We can use subtraction and std::min instead of
modulo and explicit if statements.
This commit does not change the behavior.
2020-04-15 22:15:40 +02:00
330c80055d
Qt/Debugger: Refresh windows on savestate load.
2020-04-15 00:12:35 +02:00
744abab478
Merge pull request #8741 from cristian64/add_checkbox_to_filter_ingame_netplay_sessions
...
DolphinQt: Added checkbox to filter out NetPlay sessions that are already in-game.
2020-04-13 08:52:23 -04:00
c0ae9cbc45
Merge pull request #8584 from jordan-woyak/widescreen-heuristic-fix
...
VideoCommon: Tweak widescreen heuristic.
2020-04-13 05:57:19 -04:00
bb99062f18
IOS/USBHost: Skip starting threads when determinism is enabled
...
The threads can't actually be started when determinism is enabled, as
the behavior would not be deterministic, but Open() still tries to
start the threads and wait, resulting in a deadlock when booting
certain games and homebrew in NetPlay.
2020-04-12 23:44:53 -04:00
dab4f8b36e
DolphinQt: Added checkbox to filter out NetPlay sessions that are already in-game.
2020-04-13 00:42:03 +02:00
3aa463cdae
DiscIO: Fix decompressing writing too much sometimes
...
This issue cannot happen with good dumps due to their size,
but it can happen with trimmed dumps.
2020-04-12 21:47:10 +02:00
26b21e3186
DiscIO: Fix decompressing writing too little sometimes
...
This issue cannot happen with good dumps due to their size,
but it can happen with trimmed dumps.
2020-04-12 21:45:55 +02:00
d3dc81ba74
Fix bug 11920
...
DSP LLE Interpreter does not have a DSP thread, so trying to wait would hang. (DSP LLE recompiler also has no thread when in determinism mode).
2020-04-10 12:15:06 -07:00
0b66310957
Android: Reload Wii Remote settings upon saving them
2020-04-10 10:23:32 -04:00
b2c9149cf8
Remove outdated comment from Movie::FrameUpdate
...
9c5c3c0
2020-04-10 00:18:53 +02:00
94f83db2b5
Adjust s_DIMAR/s_DILENGTH behavior (fixes Baten Kaitos music)
...
https://bugs.dolphin-emu.org/issues/11997
The problem seemed to be that s_DILENGTH would get set to 0
at times when it shouldn't. Simply not changing it in case
of NoReply or DTK seems to fix the problem. However, we can
actually go one step further in accuracy and use data.size()
to change s_DIMAR and s_DILENGTH as partial reads (NoReply
commands) complete, instead of jumping directly to 0 when
the whole read completes.
2020-04-09 22:13:45 +02:00
812ad4257c
Core: Skip duplicate frames when using frame advance
...
It used to be the case that frame advance skipped duplicate frames
(i.e. it would take 30 frame advances to get through one second
of emulated time in a 30 fps game), but this broke in 9c5c3c0
2020-04-09 11:39:29 +02:00
1a42355f96
Core: Clarify Callback_VideoCopiedToXFB and FrameUpdate
2020-04-09 00:21:04 +02:00
9a2d8a9623
Merge pull request #8715 from JosJuice/panic-alert-deadlock
...
DolphinQt: Fix the panic alert deadlock (a.k.a. "Question" issue)
2020-04-08 17:20:32 -04:00
a2f4fafe86
Vulkan: Switch from vkCreateMacOSSurfaceMVK() to vkCreateMetalSurfaceEXT()
...
Since we are calling this off the UI thread, we can't use anything which
accesses the underlying NSView object. We create and set the Metal layer
on the UI thread before the video backend is initialized. This extension
is both compatible with MoltenVK and gfx-portability for accepting a
layer at surface creation.
2020-04-07 18:56:55 +10:00
b4e49dc656
Respect Core::WantsDeterminism for DNS on Linux
...
Previously Core::WantsDeterminism was only checked for setting the DNS on WIN32.
Same check should apply to Linux too.
2020-04-06 15:45:43 -04:00
74d8697ea3
Qt/GameList: Use KeyPress instead of KeyRelease
...
This fixes a bug where pressing Enter in the "Do you want to stop the
current emulation?" confirmation popup also triggers a KeyRelease in
GameList, which starts a new game.
2020-04-03 23:01:21 -05:00
55f787b898
Remove unused function Host_UpdateProgressDialog
2020-04-03 12:53:38 +02:00
c6ee767851
DolphinQt: Run tasks that use progress dialogs on separate threads
2020-04-03 12:53:38 +02:00
e11a2bda56
Delete properties dialog on close
...
Fixes the game file being locked until Dolphin closes.
2020-04-02 16:14:37 -07:00
163b176bab
Android: Use the newly added style for all dialogs
...
For consistency, and in case I missed any cases where not specifing
a theme could lead to a crash on Android TV.
2020-04-02 15:06:34 +02:00
ff0c36b21a
Android: Use the newly added style for the analytics alert too
...
See 85ac06a
2020-04-02 15:03:39 +02:00
4fd42d994e
Android TV: Fix crash when long pressing a game
...
Also fixes the same crash when accessing the game details
(which only can be accessed after long pressing a game).
The problem was that we were not using a theme that had
an AppCompat theme as a parent.
Unfortunately, the game details dialog uses white on white on
Android TV, and I don't know how to fix this in a clean way.
2020-04-02 15:03:24 +02:00
ff7180cac4
Analytics: Add quirk for mismatched xf/bp texgens/colors
2020-04-02 12:52:16 +10:00
a9c1dcf656
VertexManagerBase: Skip drawing objects with mismatched xf/bp stages
...
Hardware tests have shown that if the number of texgens/channels do not
match, you get garbage rendering. Presumably because the output
registers from the XF stage are fed into the incorrect input registers
for TEV/BP.
Currently, this causes Dolphin to crash/generate invalid shaders with an
assertion failure in the hardware backends. Instead, we log an error.
Perhaps in the future we should just spit out all texgens/colors anyway
from both stages, and let cross-stage optimization take care of DCE'ing
it away. But doing so would require changing the UIDs and invalidating
everyone's shader caches.
2020-04-02 12:51:41 +10:00
85ac06a57d
Android: Force an AppCompat theme in the analytics AlertDialog
...
This fixes a crash on ATV devices, because the the AlertDialog is
from the appcompat class, but the theme derived from the parent
view on ATV devices isn't from AppCompat.
2020-04-01 18:46:57 -05:00
bb27da06ae
AudioPane: Do not enable DPL II quality slider with HLE audio on init
2020-04-01 22:40:45 +02:00
ef778723a2
DolphinQt: Fix the panic alert deadlock (a.k.a. "Question" issue)
2020-03-31 21:00:32 +02:00
a3ff20a5f9
Android: Add Insert SD Card and update description
2020-03-31 14:58:00 -04:00
85cd59c585
HLE: Add more debug functions
2020-03-30 17:46:50 +04:00
fdc9ea6ca0
Set Insert SD Card default value to true
2020-03-30 06:15:17 -04:00
999e651ed5
Qt: Display default Paths
2020-03-30 06:06:38 -04:00
4e0fc6cfe5
Android: Reduce Submenu height by 25 percent
2020-03-30 05:15:50 -04:00
fba1e3c7ca
Android: Split General settings
2020-03-30 04:58:26 -04:00
1b97f081b8
Merge pull request #7920 from Ebola16/DISO
...
Android: Add Paths to UI
2020-03-29 15:13:27 +02:00
5988d20917
Merge pull request #8698 from howard0su/warning_capture
...
Cleanup warnings of -Wunused-lambda-capture
2020-03-26 10:37:33 +01:00
81f8099cc6
Remove warnings of -Wsign-compare
...
Cast the variable to the coresponding type.
2020-03-25 07:57:14 +08:00
d15d6e70d7
Android: Don't let onSettingChanged clobber ConfirmRunnable changes
2020-03-24 17:08:35 -04:00
5d6f23e424
SettingsHandler: Don't output null bytes
...
https://bugs.dolphin-emu.org/issues/12019 , take two.
2020-03-24 17:01:15 +01:00
651595c521
Merge pull request #8701 from howard0su/static_wiimote
...
Wiimote: Cleanup warnings of -Wmissing-variable-declarations
2020-03-24 23:14:46 +10:00
7885fdb1ae
Remove warning of -Wstringop-truncation
...
Fix the right length when strncpy. And use specific version of copy
to copy GameID.
2020-03-24 20:26:20 +08:00
b6ff15c130
Cleanup warnings of -Wmissing-declarations
...
Add static to the functions which is not intentionally
export to big scope.
2020-03-24 20:16:10 +08:00
da223a2271
Cleanup warnings of -Wunused-lambda-capture
...
Remove unused lambda captures.
2020-03-24 20:14:10 +08:00
9dec1e9998
use s_ prefix for local variables
2020-03-24 20:13:20 +08:00
5b10f4b71e
Merge pull request #8673 from JosJuice/preserve-setting-txt
...
Boot: Do a better job of preserving certain parts of settings.txt
2020-03-24 10:16:17 +01:00
584eee818c
Merge pull request #8660 from TheRealPSV/master
...
Android: Set up Day/Night mode for system-compatible optional dark theme
2020-03-24 10:03:35 +01:00
b3ad3c3b07
Merge pull request #8683 from AlexApps99/cmdl
...
Parse arguments before Qt
2020-03-24 10:02:24 +01:00
323bffed01
Merge pull request #8700 from howard0su/add_override
...
NoGUI: missing override in PlatformX11
2020-03-24 18:34:48 +10:00
3f72bc3e7e
HW: cleanup warnings of -Wtype-limits
...
ROM_BASE is 0, and address is unsigned. It is always
true that address >= 0. So just compare with ROM_SIZE
and don't use IN_RANGE macro to avoid the warning.
2020-03-24 09:11:24 +08:00
76b97a4183
Merge pull request #8680 from Leseratte10/master
...
SettingsHandler: Always decode the whole settings.txt file
2020-03-24 00:21:29 +01:00
aee9c7390d
Merge pull request #8699 from howard0su/cleanup_move
...
Cleanup warnings of -Wpessimizing-move
2020-03-23 19:58:13 +01:00
a6d1fe59a3
Merge pull request #8693 from howard0su/warning_xinpu
...
InputCommon: cleanup warnings of -Wclass-memaccess
2020-03-23 19:18:08 +01:00
6fab09951b
Merge pull request #8692 from howard0su/warning_unused
...
Cleanup warnings of -Wunused-[const]-variable
2020-03-23 19:10:52 +01:00
623a50786d
Merge pull request #8702 from sl1pkn07/Qt5.15
...
Fix build with Qt 5.15+
2020-03-23 18:35:09 +01:00
4f7ea79ae4
Fix build with Qt 5.15+
2020-03-23 17:58:39 +01:00
0bd6016ad0
Wiimote: Cleanup warnings of -Wmissing-variable-declarations
...
While I am here, make g_wiimote_scanner as static as well.
2020-03-23 16:43:21 +08:00
fb7fbb4a7b
NoGUI: missing override keyword GetWindowSystemInfo
2020-03-23 16:35:45 +08:00
964a2e1e70
Cleanup warnings of -Wpessimizing-move
...
moving a temporary object prevents copy elision. Remove std::move.
2020-03-23 16:31:15 +08:00
500820b352
Cleanup warnings of -Wunused-const-variable
2020-03-23 16:28:25 +08:00
997cfa49fc
InputCommon: cleanup warnings of -Wclass-memaccess
...
Initialize m_state with the default constructor.
2020-03-23 14:26:36 +08:00
7c7a41ecd8
Cleanup warnings of -Wunused-variable
...
remove unused variables.
2020-03-23 14:24:27 +08:00
d44c51b30c
DiscIO: cleanup warnings of -Wmaybe-uninitialized
...
replace {} with std::nullopt.
2020-03-23 14:14:00 +08:00
de5430b222
Android: Don't use SettingsAdapter's static state in file picker
2020-03-23 00:53:22 -04:00
ccda75f33f
Android: Add Paths to UI
2020-03-22 06:43:35 -04:00
d6fb0b44d7
Parse arguments before Qt
2020-03-22 17:49:32 +13:00
9ec5391bfb
Improve "Generate Symbols From > RSO Modules"
...
Add auto-detection option
2020-03-21 12:03:12 +04:00
303b18ddaf
Qt/CodeWidget: Typo in settings key.
2020-03-20 20:51:26 +01:00
cba4acc54b
SettingsHandler: Always decode the whole settings.txt file
2020-03-20 16:08:25 +01:00
9ac28054df
Merge pull request #8678 from JosJuice/setting-txt-code-default
...
Boot: Change pre-defined setting.txt CODE values
2020-03-20 02:06:07 -04:00
4a438db2c9
Qt/GameListModel: Use native separators in File Path column
2020-03-19 18:03:35 +01:00
21d6c0a11a
Boot: Change pre-defined setting.txt CODE values
...
As suggested by
https://github.com/dolphin-emu/dolphin/pull/8673#discussion_r394945753
2020-03-19 13:05:44 +01:00
0ba3f497a7
Android: add lighter accent color for dark mode
2020-03-18 23:57:21 -04:00
53c34d962d
Merge pull request #8665 from AdmiralCurtiss/debugger_columns
...
Qt/CodeViewWidget: Make columns resizable by the user and set sensible defaults.
2020-03-19 01:40:30 +01:00
e8dfb8f78d
Qt/CodeViewWidget: Make columns resizable by the user and set sensible defaults.
2020-03-18 22:27:53 +01:00
0b91ea28c1
Merge pull request #8677 from JosJuice/comma-operator
...
Android/JNI: Remove odd usage of the comma operator
2020-03-18 13:13:16 +01:00
868cc15b71
Android/JNI: Remove odd usage of the comma operator
...
This was probably a copypaste mistake of mine.
(env is used as the first argument when calling ToJString.)
2020-03-18 12:37:28 +01:00
4711b76cc4
Merge pull request #8655 from Techjar/fix-hotkey-groups
...
Core/HotkeyManager: Fix group names in config
2020-03-18 12:03:07 +01:00
bb430fb5a5
Merge pull request #8675 from Pokechu22/disc-update
...
Fix Load Wii System Menu not updating after performing a disc update
2020-03-18 11:54:07 +01:00
d1e8e3e903
Merge pull request #8671 from leoetlino/bt-passthrough-error
...
BTReal: Improve error handling for device opening
2020-03-18 11:52:22 +01:00
c59120f089
Fix Load Wii System Menu not updating after performing a disc update
...
For a fresh install, the button was completely disabled even after the disc update; otherwise, the text on it was just out of date.
2020-03-17 19:59:48 -07:00
099e6bfab9
DolphinQt: Fix gyro mapping indicator's "jitter" drawing.
2020-03-17 19:19:58 -05:00
ae0c91805c
Core/HotkeyManager: Fix group names in config
...
For some reason every button group was shoved into the same config
group called "Keys" which caused buggy behavior once someone tried to
have hotkeys with the same name in different groups. This fixes that,
and converts existing configs to the new group names so they don't get
reset.
2020-03-17 05:42:26 -04:00
5446e7b7d6
Android: Set up Day/Night mode for system-compatible optional dark theme
2020-03-17 01:00:59 -04:00
0461170363
Merge pull request #8672 from JosJuice/wii-setting-backup
...
Back up Wii setting.txt and SYSCONF while emulating
2020-03-16 22:21:15 +01:00
1b844067aa
Back up Wii setting.txt and SYSCONF while emulating
...
When booting a Wii game, Dolphin can overwrite certain settings
in the SYSCONF file, such as turning off PAL60 for NTSC games.
Normally, these settings get reverted at the end of emulation, but
this does not happen if Dolphin crashes or force quits in some other
way. (Personally, I have a tendency to use Visual Studio's Stop
Debugging button, which kills the process...)
Dolphin also overwrites certain values in setting.txt when booting
a Wii game. Unlike with SYSCONF, we currently make no effort to
preserve the original values in this file.
This change fixes both of these problems by copying SYSCONF and
setting.txt to the Backup folder when booting a Wii game, and then
copying them back either when launching Dolphin (in case the
previous run of Dolphin crashed) or when ending emulation.
2020-03-16 21:04:19 +01:00
5f6598f9e9
StringUtil: Add PathToFileName function
2020-03-16 21:03:34 +01:00
d4085382dc
Merge pull request #8598 from JosJuice/channel-sync-android-tv
...
Android: More robust check for whether to sync channels
2020-03-16 20:53:47 +01:00
e06bdaf426
AddressSpace: Fix constness
2020-03-16 23:48:03 +04:00
3614e9fcc2
Boot: Preserve MODEL value in setting.txt
...
It doesn't necessarily start with RVL-001.
2020-03-16 20:38:07 +01:00
36c92294df
Boot: Preserve CODE value in setting.txt if it already matches the region
...
This is a part of fixing https://bugs.dolphin-emu.org/issues/11930 .
2020-03-16 20:34:40 +01:00
c86832849a
Merge pull request #8535 from JosJuice/movie-save-detection
...
Movie: Make checking for existing GC saves more reliable
2020-03-16 00:19:14 +01:00
cb0fe3fc30
Movie: Make checking for existing GC saves more reliable
...
The old code only handled a raw memory card in slot A, not taking
GCI folders into account at all.
2020-03-15 23:56:34 +01:00
f81c0658c0
Merge pull request #8503 from JosJuice/android-stick-calibration
...
Android: Use square stick calibration
2020-03-15 23:42:05 +01:00
5038ae384b
Merge pull request #8427 from CookiePLMonster/wil-submodule
...
Add Windows Implementation Libraries as an external library
2020-03-15 23:28:53 +01:00
57274cbf91
Merge pull request #8565 from Pokechu22/log-scroll-bar
...
Always display the horizontal scroll bar when log word wrap is off
2020-03-15 23:14:23 +01:00
a66ee4ea42
Merge pull request #8597 from SirMangler/master
...
Hotkeys: Toggle Freelook Hotkey
2020-03-15 22:40:51 +01:00
d9eec2ef04
Merge pull request #8609 from jordan-woyak/separate-hotkey-background-input
...
DolphinQt: Give hotkeys their own "background input" setting.
2020-03-15 22:35:49 +01:00
466c079bf4
Merge pull request #8604 from Techjar/netplay-index-direct
...
Core/NetPlayServer: Fix session not being added to index on direct connection type
2020-03-15 22:22:00 +01:00
73e7f2a839
BTReal: Improve error handling for device opening
...
This commit attempts to improve error handling for device opening by
reducing panic alert spam when opening one or several devices fails.
Currently, Dolphin shows a panic alert for every device that we fail
to open, and another panic alert at the end if no usable device was
found. That is certainly a bit excessive -- we should only keep the
very last panic alert (the one that is shown if everything fails)
and we can just put the error for the last device open operation there.
This also changes the PanicAlert to a CriticalAlert to ensure the
message is visible even if the user has disabled regular panic alerts.
The message has also been reworded and should hopefully be clearer.
2020-03-15 22:10:24 +01:00
d297080f52
Merge pull request #8669 from container1234/mbp
...
Breakpoints: Fix crash after clearing all memory breakpoints
2020-03-15 18:40:05 +01:00
3c1f5c675d
Merge pull request #8628 from iwubcode/texturepack_game_id_file
...
VideoCommon: Allow texture folders to be determined by a <gameid>.txt
2020-03-15 18:37:46 +01:00
bba92019dc
VideoCommon: Allow texture folders to be determined by a <gameid>.txt file
2020-03-15 12:34:04 -05:00
24a01642e0
Merge pull request #8642 from AdmiralCurtiss/debugger_branch_arrows
...
Qt/CodeViewWidget: Implement branch arrows.
2020-03-15 16:45:36 +01:00
9c98b659f1
Qt/CodeViewWidget: Indent branch arrows based on free space rather than reserving a full column for each.
2020-03-15 16:14:35 +01:00
19a46dd67b
Merge pull request #8652 from sonic2kk/qtshortcuts
...
Qt: Use Builtin QKeySequence Shortcuts
2020-03-15 15:07:47 +01:00
4944e4b429
Merge pull request #8647 from jordan-woyak/minor-input-cleanups
...
InputCommon: Minor ReshapableInput related cleanups.
2020-03-15 15:06:54 +01:00
0bf05009d0
Merge pull request #8650 from jordan-woyak/ir-cleanup
...
HW/WiimoteEmu: Camera logic cleanups.
2020-03-15 15:04:48 +01:00
cd2cf137ba
Use ZoomIn/ZoomOut QKeySequence in GameList
2020-03-15 14:58:33 +01:00
eda31c782e
Qt: Add Configuration shortcut
2020-03-15 14:58:31 +01:00
b82f54762b
Qt: Use builtin Find and Quit key sequences
2020-03-15 14:58:24 +01:00
3487e5037e
Fix settings.txt parsing in case of weird line endings
2020-03-15 00:12:19 +01:00
75a69b1145
Breakpoints: Fix crash after clearing all memory breakpoints
2020-03-14 21:57:09 +09:00
cdb0aa850d
Qt/RenderWidget: Remove fill background functionality
...
We no longer need this since the video backend handles clearing the
window, and it fixes MoltenVK with Qt 5.14.
2020-03-11 23:13:45 +10:00
2f016295a6
Core: Render a blank UI frame before booting
...
This is related to https://bugs.dolphin-emu.org/issues/10958 which
uses Qt to clear out the window so the game list isn't displayed
while the core is booting. Instead, we use the video backend to
render a black screen, which means Qt doesn't have to flip between
paint engines.
2020-03-11 23:13:18 +10:00
fb947296b0
Vulkan: Pass CAMetalLayer to MoltenVK instead of NSView
...
Gets rid of the warning for calling [NSView layer] off the main thread.
2020-03-11 23:11:26 +10:00
a545344268
VideoBackends: Make it possible for PrepareWindow to change the surface
...
Again, needed for MoltenVK.
2020-03-11 23:10:30 +10:00
86db015c23
Common: Add a render_window field to WindowSystemInfo
...
We need this because we need to pass the layer to MoltenVK, not
the view handle. But the input subsystem still needs the window.
2020-03-11 23:09:30 +10:00
38fa38d424
Android: Add Set as Default ISO to UI
2020-03-11 01:06:32 -04:00
bb7623e3ba
Merge pull request #8659 from Ebola16/Q
...
Android: Fix obscured Dolphin version
2020-03-10 20:10:56 +01:00
18127e2554
Qt/CodeViewWidget: Implement branch arrows.
2020-03-07 01:52:53 +01:00
d1f6f12f78
AudioPane: Do not enable Dolby Pro Logic II quality slider if DPLII is disabled
2020-03-06 21:13:45 +01:00
dcaabcac03
Merge pull request #8580 from AlexApps99/master
...
DolphinQt: Add "File Path" column to Game Grid
2020-03-06 08:22:44 +01:00
879e8364af
Source/Core/Core/DSP/DSPTables.cpp: include <cstdio> for sprintf
...
Without included header build fails on gcc-10 as:
```
[ 52%] Building CXX object Source/Core/Core/CMakeFiles/core.dir/DSP/DSPTables.cpp.o
../../../../Source/Core/Core/DSP/DSPTables.cpp: In function 'const char* DSP::pdname(u16)':
../../../../Source/Core/Core/DSP/DSPTables.cpp:492:3: error: 'sprintf' was not declared in this scope
492 | sprintf(tmpstr, "0x%04x", val);
| ^~~~~~~
```
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
2020-03-05 21:20:34 +00:00
0478ce72f5
Source/Core/Common/StringUtil.h: include <limits> for std::numeric_limits
...
Without included header build fails on gcc-10 as:
```
[ 13%] Building CXX object Source/Core/AudioCommon/CMakeFiles/audiocommon.dir/CubebUtils.cpp.o
In file included from ../../../../Source/Core/AudioCommon/CubebUtils.cpp:13:
../../../../Source/Core/Common/StringUtil.h: In function 'bool TryParse(const string&, T*)':
../../../../Source/Core/Common/StringUtil.h:84:20: error: 'numeric_limits' is not a member of 'std'
84 | if (value < std::numeric_limits<LimitsType>::min() ||
| ^~~~~~~~~~~~~~
```
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
2020-03-05 21:20:34 +00:00
163d9506e8
Android: Fix obscured Dolphin version
2020-03-03 13:19:08 -05:00
465e7c2521
Used whole path instead of relative path
2020-03-03 11:58:59 +13:00
7408c388d6
Add path to File Name column of game grid
...
Fixes https://bugs.dolphin-emu.org/issues/10567
2020-03-02 17:38:28 +13:00
08c95883e9
Common/IniFile: Add Exists function for section name only
2020-02-29 01:39:36 -05:00
ccdfa43a3e
HW/WiimoteEmu: Fix Classic Controller triggers.
2020-02-26 15:40:58 -06:00
2451a41a48
DolphinQt: Fix calibration cancel behavior.
2020-02-25 18:36:56 -06:00
2c843ae06b
DolphinQt: Clean up calibration drawing a bit.
2020-02-25 17:58:32 -06:00
ed24f32c5b
InputCommon: Specify ini value default when saving calibration "center".
2020-02-25 17:19:48 -06:00
bd43e084f4
InputCommon: Clamp calibration values within square shape.
2020-02-25 17:19:48 -06:00
f8cca9fe5d
InputCommon: RoundStickGate's ideal sample count can be 1.
2020-02-25 17:19:48 -06:00
8233255b11
Qt: Re-enable Dark Mode support
2020-02-25 23:27:44 +01:00
ef777c4186
HW/WiimoteEmu: Fill IR data with 0xFF on failed bus read.
2020-02-24 19:45:02 -06:00
5361e66459
HW/WiimoteEmu: Camera logic cleanups.
2020-02-24 19:44:15 -06:00
6b109bd2a6
DolphinQt: Tweak indicator raw-input/input-shape color for better contrast in some dark themes.
2020-02-24 16:26:28 -06:00
122984b46e
DolphinQt: Eliminiate redundant swing indicator logic.
2020-02-24 16:26:28 -06:00
d80fd13b17
DolphinQt: Clean up mapping indicator code and draw lines on "pixel centers".
2020-02-24 16:26:26 -06:00
f79ca680cb
DolphinQt: Eliminate redundant cursor indicator logic.
2020-02-24 16:25:06 -06:00
38f36be9ae
DolphinQt: Break mapping indicators into separate classes. Ensure "state lock" is held on redraw.
2020-02-24 16:25:06 -06:00
7accd9825f
InputCommon: Remove racy UpdateInput call in DetectInput.
2020-02-24 16:25:06 -06:00
1a3b4d91bf
InputCommon: Mark GetStateLock with [[nodiscard]] and fix discarding calls.
2020-02-24 16:25:06 -06:00
25d5f0d9ef
Merge pull request #8633 from spycrab/tas_window_fixes
...
Qt/TAS: Improve TAS windows
2020-02-24 07:26:49 +01:00
c70e004f53
Qt/CodeViewWidget: Use named constants for column IDs.
2020-02-23 18:49:27 +01:00
da12f3eebc
InputCommon: Constify Device::Input::IsDetectable function.
2020-02-22 10:27:43 -06:00
29c7c12016
Qt/TAS: Improve TAS windows
...
- Use the Dolphin Icon in TAS Windows
- Prevent deformation of the stick widget (#11988 )
- Improve visual appearance
- Set a reasonable minimum size
2020-02-18 16:13:31 +01:00
06a9f6ef82
Core/NetPlayServer: Fix session not being added to index on direct connection type
2020-02-17 21:05:32 -05:00
70ac9ad2e6
InputCommon: Remove Wii Remote real-time calibration of M+ in favor of functionality provided by ControllerEmu.
2020-02-17 16:14:03 -06:00
58448d74c5
InputCommon: Add real Wii Remote support to ControllerInterface. Add option to connect additional Wii Remotes.
2020-02-17 16:14:01 -06:00
4176cc77e1
InputCommon/ControllerInterface: Make devices mutex recursive so RemoveDevice can be used within UpdateInput.
2020-02-17 15:58:06 -06:00
5af2081c75
Core/WiimoteEmu: Add functions to Nunchuk, Classic Controller, and MotionPlus extensions to get/set data without duplicate bithacks everywhere.
2020-02-17 15:57:58 -06:00
8343dadd58
InputCommon: Add types to ControllerEmu that represent raw controller inputs and calibration data to calculate normalized input values.
2020-02-17 15:57:43 -06:00
259a7191d2
Common: Add additional Vector operations.
2020-02-17 15:57:43 -06:00
1e652d7d34
InputCommon: Add calibration functionality to IMUGyroscope.
2020-02-17 15:57:43 -06:00
9efcd08ea3
MathUtil: Add RunningMean/RunningVariance classes.
2020-02-17 15:57:43 -06:00
82a3aa5ff6
InputCommon: Add "Dead Zone" setting to raw gyro inputs.
2020-02-17 15:57:43 -06:00
2d6a72e941
Merge pull request #8632 from jimbo1qaz/windows-menu-font
...
Windows GUI: Use QMenu font (Segoe UI) for entire application
2020-02-17 15:04:37 +01:00
44f602fe51
Windows GUI: Use QMenu font (Segoe UI) for entire application
...
On Windows, Qt's default system font (MS Shell Dlg 2) is outdated.
Dolphin previously used over 15 lines of code to compute a font
closer to the proper font, but with an approximately correct font size.
Using the QMenu font directly is both more concise and more elegant
(in my opinion).
2020-02-17 05:37:54 -08:00
44b4c2db49
Common: Avoid std::function overhead in ScopeGuard
...
So far in all our uses of ScopeGuard, the type of the callable is
usually just a lambda or a function pointer, so there is no need
to rely on std::function's type erasure.
While the cost of using std::function is probably negligible, it still
causes some unnecessary overhead that can be avoided by making
ScopeGuard a templated class. Thanks to class template argument
deduction in C++17 most existing usages do not even need to be changed.
See https://godbolt.org/z/KcoPni for a comparison between
a ScopeGuard that uses std::function and one that doesn't
2020-02-15 21:33:31 +01:00
62046d93ce
Merge pull request #8542 from Itrimel/fix-gecko-loading
...
Fix Gecko codes loading
2020-02-15 16:28:32 +01:00
fe900e057b
Core/GeckoCodeConfig : Fix Gecko codes formatting
...
Some locales (e.g. fr_FR.UTF-8 on ArchLinux) don't split the string stream on a space. As such, when extracted formatted data from te stream, it will return the two numbers as one for the first call, effectively overflowing the u32 variable, then will do an out-of-bounds read for the second call. Forcing the use of the C locale on the streams where it would cause a problem allows to workaround this behavior.
2020-02-14 11:51:36 +01:00
213a9adcff
CMake: Fix building ARM64 on Windows
2020-02-12 12:29:31 +01:00
903db48280
DolphinQt: Give hotkeys their own "background input" setting.
2020-02-10 20:06:29 -06:00
a9dc4ac3f0
Merge pull request #8603 from jordan-woyak/deadzone-too-dark
...
DolphinQt/Mapping: Tweak "Dead Zone" and "Gate" colors.
2020-02-10 23:28:56 +00:00
103b3abf66
Merge pull request #8621 from JosJuice/volumeverifier-invalid-partition
...
Fix VolumeVerifier not showing a problem for invalid partitions
2020-02-10 09:33:29 +00:00
47877ecf2c
InputCommon: Clean up creation of inputs.
2020-02-09 19:08:26 -06:00
01d69ba81a
Merge pull request #8624 from jordan-woyak/setting-expression-input-gate
...
InputCommon: Only update setting expressions when the input gate is enabled.
2020-02-10 00:47:30 +00:00
53f2e275af
InputCommon: Only update setting expressions when the input gate is enabled.
2020-02-09 18:42:42 -06:00
c598772052
Merge pull request #8622 from JosJuice/volumeverifier-invalid-partition-biggest-offset
...
VolumeVerifier: Ignore invalid partitions in GetBiggestReferencedOffset
2020-02-10 00:31:49 +00:00
d129fae8fc
Merge pull request #8623 from spycrab/qt_5.14.1
...
Update to Qt 5.14.1
2020-02-10 00:06:11 +00:00
db65b9a766
Merge pull request #8616 from jordan-woyak/threshold-cleanup
...
InputCommon: Eliminate some duplicated button threshold logic.
2020-02-10 00:05:10 +00:00
6a3bd259a7
Update to Qt 5.14.1
2020-02-09 22:30:57 +01:00
7cbb9822c1
VideoCommon: Remove widescreen heuristic debug logs.
2020-02-09 13:22:27 -06:00
10223da6a8
VideoCommon: Tweak widescreen heuristic and clean up some related Renderer logic.
2020-02-09 13:22:25 -06:00
829f3cff6f
VolumeVerifier: Ignore invalid partitions in GetBiggestReferencedOffset
...
Otherwise GetBiggestReferencedOffset might treat garbage data as a valid
large offset, making Dolphin incorrectly say that the disc is too small.
2020-02-09 19:05:44 +01:00
f52a0aba24
Add Windows Implementation Libraries
2020-02-09 19:01:44 +01:00
07df6597a5
Fix VolumeVerifier not showing a problem for invalid partitions
2020-02-09 18:58:15 +01:00
f07457b6cc
InputCommon: Eliminate some duplicated button threshold logic.
2020-02-09 10:37:18 -06:00
55e8601192
Fix another implicit false-to-nullptr conversion
2020-02-09 15:51:30 +01:00
aa21fe17b8
Merge pull request #8618 from encounter/debugger-floating-fix
...
DolphinQt/Debugger: Fix crash with floating debugger windows
2020-02-09 15:50:47 +01:00
166e86b97f
Merge pull request #8619 from JosJuice/directoryblob-check-seek
...
DiscIO: Check for DirectoryBlob seek failure
2020-02-09 15:49:37 +01:00
fb0f543777
Merge pull request #8574 from JosJuice/volumeverifier-assert-small-file
...
VolumeVerifier: Improve the messages shown for files that are too small
2020-02-09 15:48:57 +01:00
5ab846ad12
Merge pull request #8614 from jordan-woyak/xinput-battery
...
InputCommon/XInput: Expose battery as input and cleanups.
2020-02-09 09:29:00 -05:00
9a348ae654
DiscIO: Check for DirectoryBlob seek failure
...
Someone reported a problem with DirectoryBlob at
https://forums.dolphin-emu.org/Thread-feature-request-thread?pid=502820#pid502820 .
I'm not sure if the change in this commit actually fixes that problem,
but it's something I found that should be changed regardless.
2020-02-09 11:21:10 +01:00
3e94366fe0
DolphinQt/Debugger: Fix crash with floating debugger windows
2020-02-09 02:32:04 -05:00
3cec5443cd
Merge pull request #8605 from Techjar/netplay-hostpoll-doc
...
Core/NetPlayClient: Add documentation for SendPadHostPoll
2020-02-09 02:32:50 +00:00
2e2540317e
Merge pull request #8417 from jordan-woyak/setting-expressions
...
InputCommon: Allow controller settings specified with input expresions.
2020-02-09 01:37:30 +00:00
73711ef995
CMake: add DOLPHIN_CXX_FLAGS option
...
Lets you do fun stuff like turning off warnings globally, then re-enabling all warnings + extra warnings + warnings as errors for Dolphin only.
2020-02-09 01:03:36 +00:00
0043a2cf3c
Merge pull request #8615 from jordan-woyak/std-abs
...
Cleanup: Use std::abs instead of abs.
2020-02-09 00:39:30 +00:00
4f47cccd9f
Cleanup: Use std::abs instead of abs.
2020-02-08 18:21:14 -06:00
0a1634bedf
InputCommon: Allow Wii remote extension to be set with an input expression.
2020-02-08 16:03:13 -06:00
e7400cafd2
InputCommon: XInput cleanups.
2020-02-08 15:51:02 -06:00
86e8745169
InputCommon: Expose XInput battery level as an input.
2020-02-08 15:03:56 -06:00
e8152b700f
InputCommon: Allow controller settings specified with input expresions.
2020-02-08 14:01:55 -06:00
6a857df219
Merge pull request #8606 from jordan-woyak/tab-key-navigation
...
DolphinQt: setTabKeyNavigation(false) on QTableWidget and QTableView.
2020-02-08 14:18:09 -05:00
3b0b264c84
Merge pull request #8608 from jordan-woyak/stereoscopy-hotkeys
...
DolphinQt: Fix stereoscopy hotkeys.
2020-02-08 14:17:42 -05:00
dc5447fb30
Merge pull request #8612 from jordan-woyak/unused-members
...
DolphinQt: Kill some unused member variables.
2020-02-08 14:17:15 -05:00
f94726068d
DolphinQt: Kill some unused member variables.
2020-02-08 10:52:06 -06:00
e323f47ceb
Merge pull request #8472 from degasus/jitsetting
...
Core/Jits: Adds an option to disable the register cache.
2020-02-08 13:49:33 +00:00
9a34091b8b
DolphinQt: Fix stereoscopy hotkeys.
2020-02-07 15:47:40 -06:00
b9f34bc822
DolphinQt: setTabKeyNavigation(false) on QTableWidget and QTableView.
2020-02-06 20:48:45 -06:00
e8e41d8529
Core/NetPlayClient: Add documentation for SendPadHostPoll
2020-02-06 07:24:00 -05:00
b1a71b959b
DolphinQt/Mapping: Change "Dead Zone" color from shadow color of palette to a transparent black or white depending on theme. Tweak order of "shake" indicator axis colors so red is more often shown.
2020-02-04 16:08:51 -06:00
a205ecb446
Merge pull request #8602 from lioncash/fmt
...
Externals: Update fmt to 6.1.2
2020-02-04 21:59:22 +01:00
91deb40a22
Common: Amend includes to handle the upgrade to fmt
2020-02-04 15:03:51 -05:00
aea76c7901
Core: Amend includes to handle the upgrade to fmt
2020-02-04 15:03:48 -05:00
abd2897377
VideoCommon: Amend formatting code to handle the upgrade to fmt
...
It seems that the newer version of fmt gets tripped up by bitfields
within structs. However, we can just specify the intended type where
necessary to get around this.
2020-02-04 14:55:20 -05:00
f8355d0f82
VolumeVerifier: Don't return early when file is too small
...
Not sure why that was there.
2020-02-02 17:09:58 +01:00
e449d23929
VolumeVerifier: Don't show an assert for files that are too small
2020-02-02 17:09:58 +01:00
0491831483
Merge pull request #8592 from phcoder/devid
...
ButtonManager: Fix handling of empty device id.
2020-02-02 16:52:12 +01:00
06d0b1ad48
Merge pull request #8594 from leoetlino/fs-createfullpath-fix
...
IOS/FS: Fix CreateFullPath to not create directories that already exist
2020-02-02 16:50:02 +01:00
4c9b1f3e0b
Merge pull request #8599 from Pokechu22/di-interrupt-mask-ioctls
...
Fix DI interrupt mask ioctl names
2020-02-02 16:49:27 +01:00
f527f382e8
Report use of DI interrupt mask commands as a game quirk
2020-02-02 00:44:12 -08:00
d6515eee41
WiimoteEmu: Fix default IMU accelerometer mappings.
2020-02-01 23:32:09 -06:00
bb5e5fd8f2
Fix assignment of DI interrupt mask ioctls
...
0x85 is actually DVDLowMaskCoverInterrupt, while 0x89 is DVDLowUnmaskCoverInterrupt. I'm also fairly sure that 0x87 is DVDLowUnmaskStatusInterrupts.
2020-02-01 16:56:48 -08:00
64953bb63a
Android: More robust check for whether to sync channels
...
This changes channel syncing to happen when the operating system is
Android TV rather than when TvMainActivity is launched. (You can run
TvMainActivity on a phone by specifying a launch activity manually
in Android Studio, which I do sometimes for testing purposes. Without
this change, you get an exception when channel syncing runs.)
2020-02-01 22:07:29 +01:00
69ee15e5ef
Merge pull request #8478 from jordan-woyak/dsu-client-cleanup
...
ControllerInterface/DSUClient: Minor cleanup.
2020-02-01 11:29:29 +10:00
ac34911f32
Added Toggle Freelook Hotkey
2020-01-31 20:45:08 +00:00
534547ee8b
Merge pull request #8595 from stenzek/android-10-vulkan-suboptimal
...
Vulkan: Treat VK_SUBOPTIMAL_KHR as VK_SUCCESS on Android
2020-01-31 15:57:58 +01:00
f83b2fc62d
Android: Fix typo in Skip Presenting Duplicate Frames setting name
2020-01-31 22:14:51 +10:00
08cc73108a
Vulkan: Treat VK_SUBOPTIMAL_KHR as VK_SUCCESS on Android
...
Android 10 seems to expect a prerotated/transformed swap chain for optimal
presentation. For now, until we implement that, just ignore the hint.
2020-01-31 19:16:06 +10:00
ead65b0d8c
Vulkan: Log when a swap chain resize is occurring
...
This may help us debug performance problems in the future.
2020-01-31 19:11:43 +10:00
bbc8631357
IOS/FS: Fix CreateFullPath to not create directories that already exist
...
This fixes CreateFullPath to not create directories when it is known
that they already exist, instead of calling CreateDirectory anyway
and checking if the error is AlreadyExists. (That doesn't work
now that we have an accurate implementation of CreateDirectory
that performs permission checks before checking for existence.)
I'm not sure what I was thinking when I wrote that function.
Also adds some tests for CreateFullPath.
2020-01-30 18:07:03 +01:00
f1f293bd49
WiiRoot: Fix CopySysmenuFilesToFS directory creation
...
Fixes a regression from #8539 .
CreateDirectory was the correct function to use for creating
directories since parent directories already exist and are
not owned by the system menu.
2020-01-30 13:53:39 +01:00
02c5d292fa
ButtonManager: Fix handling of empty device id.
...
Device id is "" on ChromeOS when using gamepad
2020-01-29 02:47:18 +01:00
57f4837e4d
Merge pull request #8589 from lioncash/translatable
...
DolphinQt/GCMemcardManager: Mark string as translatable within GetErrorMessagesForErrorCode()
2020-01-27 23:20:03 +01:00
7eaa769527
DolphinQt/GCMemcardManager: Make use of QLatin1Char within GetErrorMessagesForErrorCode()
...
Same behavior, but eliminates the use of a program lifetime Qt string
literal.
2020-01-27 15:59:33 -05:00
585ae8aedf
DolphinQt/GCMemcardManager: Mark string as translatable within GetErrorMessagesForErrorCode()
...
This is a string that can potentially be seen by a user, so it should be
marked as translatable, like the other strings are.
2020-01-27 15:57:36 -05:00
dca201d5f3
DolphinQt/GameConfigWidget: Remove unimplemented EditUserConfig() member function
...
This isn't implemented anywhere, so we can remove the member function
prototype.
2020-01-27 15:46:52 -05:00
2fd628d017
DolphinQt/GameConfigEdit: Remove unimplemented SetReadOnly() member function
...
This isn't implemented anywhere, so we can remove this prototype.
2020-01-27 15:44:52 -05:00
c69cbceb59
DolphinQt/MainWindow: Surround prototype of OnSignal() with relevant ifdef
...
This is only used on Apple and Unix-like machines, so we can enclose the
prototype with an ifdef like the implementation is. This prevents
false-positives about an unimplemented function prototype.
2020-01-27 15:26:41 -05:00
e8ee4e835e
DolphinQt/NetPlayDialog: Remove unimplemented SetGame() prototype
...
This isn't implemented anywhere, so the prototype can be removed.
2020-01-27 15:25:04 -05:00
f36c735856
Merge pull request #8586 from Techjar/d2s-no-pext
...
Avoid using PDEP and PEXT on AMD Zen
2020-01-27 03:15:43 +00:00
3a3dc28d54
VertexLoaderX64: Don't use PDEP on AMD Zen
2020-01-26 22:12:00 -05:00
a106c99826
Jit64: Don't use PEXT in DoubleToSingle on AMD Zen
...
This was causing severe slowdown in some games.
2020-01-26 22:10:46 -05:00
185e49d2a9
x64CPUDetect: Add flag for slow PDEP/PEXT on AMD Zen
...
For some unknown reason PDEP and PEXT are ridiculously slow on AMD Zen
architecture.
2020-01-26 22:09:46 -05:00
52b52631c2
x64CPUDetect: Add detection for AMD Zen architecture
2020-01-26 22:09:13 -05:00
47239ddaac
Merge pull request #8587 from lioncash/const-qual
...
DolphinQt/TASCheckBox: Mark GetValue() as const
2020-01-27 12:52:10 +10:00
b493bdb912
DolphinQt/TASCheckBox: Mark GetValue() as const
...
This doesn't actually modify the checkbox's state, so this can be marked
as a const-qualified member function.
2020-01-26 21:41:31 -05:00
5dfc9196ab
Merge pull request #8548 from jordan-woyak/wiimote-source-cleanup
...
Core/WiimoteReal: Wii remote connection pool and source change cleanup.
2020-01-25 23:04:50 +00:00
9ac77dc91f
Merge pull request #8552 from jordan-woyak/extension-calibration-data
...
WiimoteEmu: Nunchuk and Classic Controller calibration accuracy improvements.
2020-01-25 23:01:57 +00:00
73aea8af6b
Merge pull request #8539 from leoetlino/fs-accuracy
...
IOS/FS: Reimplement many functions in a more accurate way
2020-01-25 23:00:10 +00:00
2edcb29706
Merge pull request #8582 from jordan-woyak/osd-disabled-fix
...
VideoCommon/OSD: Process OSD messages even when they are disabled.
2020-01-25 21:11:37 +00:00
a632bc7324
Merge pull request #8579 from jordan-woyak/rvalue-cleanups
...
Common/Core: Minor rvalue reference related cleanups.
2020-01-25 21:09:22 +00:00
14ebdf0e9d
Merge pull request #8585 from JosJuice/volumeverifier-read-error
...
VolumeVerifier: Report read errors to the user
2020-01-25 21:07:01 +00:00
b0e040431a
Merge pull request #8581 from jordan-woyak/ciface-ar-aware
...
InputCommon: Make "Cursor" inputs aware of the rendered aspect ratio.
2020-01-25 20:28:01 +00:00
9827aa7a37
Merge pull request #8577 from jordan-woyak/shared_mutex
...
Common/Analytics: Replace mutex with shared_mutex and minor cleanups.
2020-01-25 20:08:22 +00:00
5e3472eba9
Common/Analytics: Replace mutex with shared_mutex and minor cleanups.
2020-01-25 14:04:00 -06:00
de26fec0af
VolumeVerifier: Report read errors to the user
2020-01-25 20:21:12 +01:00
119ccc5e4f
Merge pull request #8556 from Sintendo/bestrest
...
x64Emitter: Avoid 8-bit displacement when possible
2020-01-25 19:10:47 +00:00
709862b818
Merge pull request #8120 from MerryMage/cdts
...
Jit64: Make DoubleToSingle a common asm routine
2020-01-25 19:10:37 +00:00
c02e7de55a
IOS/ES: Remove now unnecessary title sorting hack
...
ES now uses FS to access the filesystem and FS's ReadDirectory now
returns file lists that are correctly ordered.
2020-01-25 17:54:58 +01:00
031c63eb8a
UnitTests/FS: Improve deletion test
...
* Test recursive directory deletion
* Test "in use" check for both files and directories
2020-01-25 17:54:58 +01:00
af416c60b0
UnitTests/FS: Add ReadDirectory ordering test (issue 10234)
2020-01-25 17:54:58 +01:00
8789a6ddb3
UnitTests/FS: Fix file rename tests
...
Files cannot be given a different file name, only moved across
directories.
Add a test for that behaviour and fix the existing
RenameWithExistingTargetFile test.
2020-01-25 17:54:58 +01:00
d4ba0acb3a
UnitTests/FS: Add path validity and splitting tests
2020-01-25 17:54:57 +01:00
484cfb9328
UnitTests/FS: Add metadata tests
2020-01-25 17:53:39 +01:00
142b7e048b
IOS/FS: Actually implement SetMetadata
2020-01-25 17:53:35 +01:00
e4dd582d1d
IOS/FS: Implement GetMetadata properly and remove GID hack
...
Now that all FS functions that create new inodes are properly
implemented, we can make GetMetadata actually return correct file
metadata rather than giving fixed information. The hack for the DQX
installer can also be removed now since our ES and FS keep track of
caller UID/GIDs now.
2020-01-25 17:53:34 +01:00
396429d582
IOS/FS: Implement ReadDirectory properly and remove sorting hack
...
With the CreateFile/CreateDirectory fix and this commit, we can
finally return correct results in ReadDirectory and the sorting
hack -- whose purpose was to prevent certain versions of the
System Menu from crashing -- can be removed too.
2020-01-25 17:53:19 +01:00
a40f297d1d
IOS/FS: Implement Rename properly
2020-01-25 17:53:18 +01:00
53ceb6c693
IOS/FS: Implement Delete properly
2020-01-25 17:53:05 +01:00
8517528f8c
IOS/FS: Implement CreateFile and CreateDir properly
2020-01-25 17:52:45 +01:00
8f74d02659
Core: Fix a few misuses of FS::CreateDirectory
...
CreateDirectory does not create missing parent directories. If that
behaviour is desired, CreateFullPath should be used instead.
(These small misuses went unnoticed since the previous implementation
of CreateDirectory automatically created parent directories.)
2020-01-25 17:52:07 +01:00
36676d2628
IOS/FS: Implement Format properly
2020-01-25 17:52:03 +01:00
a83d9e5600
IOS/FS: Make sure FS root directory exists
...
Previously, the FS root directory would get created as a side
effect of calling CreateDirectory during boot (since the
implementation was sloppy and used File::CreateFullDir).
Since CreateDirectory no longer does that, it is necessary to ensure
that the FS root directory does exist by creating it explicitly.
2020-01-25 17:51:52 +01:00
0543598574
IOS/FS: Move /tmp clearing back to the IPC interface
...
Prevents /tmp from being cleared unnecessarily; clearing /tmp is
normally only done once every time IOS is reloaded.
2020-01-25 17:51:43 +01:00
f743f100b1
IOS/FS: Add base FST functions
...
Some official titles rely on implementation details of Nintendo's
FS sysmodule and will not work properly if those are changed.
Notably, some games and older versions of the System Menu appear
to be relying on the order of files returned by FS::ReadDirectory
and will either fail to find their save data (for Bolt) or
outright crash (for the System Menu).
Some titles also actually expect filesystem metadata to be correct.
One title that has been confirmed to do this is DQX, which generates
paths based on the GID of files within its own title directory.
While it is easy to make workarounds for these issues -- and in fact
we already do have some for the sysmenu and DQX, having hacks
is obviously nonideal and adding yet another hack would be required
to fix Bolt -- one that would be even uglier.
Furthermore, while it is currently unknown whether any official
title cares about permissions, the lack of FS metadata means that
we are unable to implement them if that turns out to be desirable
or necessary.
By adding a FST, we can implement things correctly and solve all
those problems without hacks.
Apart from DQX, the sysmenu and Bolt, this changeset also fixes
the Photo Channel complaining about corrupted system files
on the initial launch.
This first commit adds the basic structures and functions that
are necessary to load, save, query and update our version of the FST.
For simplicity, a binary format that is inspired from Nintendo's FST
structure was chosen for serialization. It is not expected to ever
receive an update.
PS: an update on the NAND image backend:
A long time ago I had planned to add another FS backend which would
be using a NAND image/blob as the storage. While I have already
written an implementation that has been tested, solves all the
aforementioned issues and more, produces images that are fully
compatible with IOS's FS driver, I feel like NAND images raise too
many issues: savestate sizes, code complexity and maintenance cost.
Since many fixes and additions that are part of that implementation
(e.g. FS timings, utility structures, FST) have already been merged
or will be submitted as part of this changeset, I will likely not
submit the branch.
2020-01-25 17:51:37 +01:00
d185bc6f09
IOS/FS: Move path validity check functions
...
They will be used in more places than just HostBackend/FS.cpp.
Also fix the check and make it accurate while we're at it.
2020-01-25 17:47:42 +01:00
e3a7922e12
Merge pull request #8336 from Ebola16/PS
...
Add Dolphin version and current video backend to shader compilation logs
2020-01-25 11:52:14 +10:00
c08671c4ce
VideoCommon/OSD: Process OSD messages even when they are disabled.
2020-01-24 11:00:58 -06:00
b92f6480a0
InputCommon: Make "Cursor" inputs aware of the rendered aspect ratio.
2020-01-24 09:20:41 -06:00
e5f6d9320f
Add Dolphin version and current video backend to shader compilation logs
2020-01-24 03:29:38 -05:00
732032cdb2
Common/Core: Minor rvalue reference related cleanups.
2020-01-23 22:58:23 -06:00
42c03c4dad
Merge pull request #8576 from lioncash/texture-cvt-shader-fmt
...
VideoCommon/TextureConversionShader: Convert over to using ShaderCode
2020-01-24 11:53:51 +10:00
a0b7c1beae
Merge pull request #8366 from Techjar/high-dpi-auto-adjust
...
Qt/RenderWidget: Account for devicePixelRatio when auto-adjusting window size
2020-01-24 11:31:09 +10:00
687f1f0330
VideoCommon/TextureConversionShader: Make use of fmt where applicable
...
Now that we've converted the shader generation over to ShaderCode, we
can now make use of the fmt-capable WriteFmt function.
2020-01-23 14:19:40 -05:00
aa77dff3a2
VideoCommon/TextureConversionShader: Convert over to using ShaderCode
...
Migrates the shader generator off the use of a global array, eliminating
the use of some global state. This also allows us to move the shader
generation over to using fmt in a subsequent change.
2020-01-23 14:19:36 -05:00
ea9b96370d
Merge pull request #8573 from JosJuice/ciso-size
...
DiscIO: Fix CISOFileReader::GetDataSize()
2020-01-22 19:20:36 +01:00
956c63ef9b
DiscIO: Fix CISOFileReader::GetDataSize()
...
Fixes being unable to run CISO games after the merge of PR 8558.
2020-01-22 18:57:50 +01:00
f0669f5aa6
Merge pull request #8570 from Techjar/always-sync-sram
...
Core/NetPlayServer: Sync SRAM on every game start
2020-01-21 20:55:52 -05:00
a63510a55a
Merge pull request #8554 from stenzek/present-duplicate-frames
...
Add an option to present duplicate frames
2020-01-20 12:04:26 +10:00
Admiral H. Curtiss