ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
36,735 Commits 5 Branches 11 Tags 1.3 GiB
Commit Graph

27261 Commits

Author SHA1 Message Date
Pokechu22 2a5016c2f8 Common/MsgHandler: Remove use of lambda, as it breaks __func__ 
Specifically, this meant that __func__ in macros (namely ASSERT) would always be evaluate to "operator ()".
 2022-01-09 12:44:14 -08:00
Pokechu22 558de04cfc Common/Assert: Actually use the ASSERT_MSG's log type parameter 
Since it was unused, nonexistent values were used in a few places.  I've replaced them.
 2022-01-09 12:44:14 -08:00
Pokechu22 bab3ff0157 Common/MsgHandler: Remove non-format variants of PanicAlert 
They're no longer used.
 2022-01-09 12:44:14 -08:00
Pokechu22 82acfa6a46 VideoBackends/D3D: Eliminate CHECK in favor of ASSERT_MSG 2022-01-09 12:44:13 -08:00
Pokechu22 161c627466 Treewide: Remove unused inclusions of <cinttypes> 
Most of these became unneeded when fmt was introduced.
 2022-01-09 12:43:11 -08:00
Pokechu22 44e93e91d7 Common/Assert: Switch to fmt 2022-01-09 12:43:11 -08:00
Pokechu22 1c0ca09e6f Common/Assert: Include the condition and function in the message 2022-01-09 12:43:11 -08:00
Admiral H. Curtiss c82b2dccb5
Config: Port SyncGPU settings to new config system. 2022-01-09 21:29:12 +01:00
Admiral H. Curtiss d8b67bc15f
Config: Port BBDumpPort setting to new config system. 2022-01-09 21:29:12 +01:00
Admiral H. Curtiss 92d2fd9d5f
Config: Port MMU setting to new config system. 2022-01-09 21:29:12 +01:00
Admiral H. Curtiss d8825f5635
Config: Port dual core setting to new config system. 2022-01-09 21:29:11 +01:00
JosJuice e5ef597642
Merge pull request #10172 from JosJuice/reorder-exception 
PPCAnalyst: Less strict interrupt checks in CanSwapAdjacentOps
 2022-01-09 19:41:16 +01:00
JosJuice bcd1831339
Merge pull request #9815 from JosJuice/jitarm64-fmaless 
JitArm64: Implement FMA-less path for FMA instructions
 2022-01-09 19:40:54 +01:00
JosJuice 1d9d9d6a6e
Merge pull request #10354 from AdmiralCurtiss/config-port-core-3 
Config: Port EXI device and SI device settings to new config system.
 2022-01-09 19:40:23 +01:00
JosJuice aa57eb57b1 SystemTimers: Refactor, get rid of s_audio_dma_period 
This static variable was only used within one function,
so we can get rid of it.
 2022-01-09 12:02:22 +01:00
Admiral H. Curtiss 5c325eef38
Config: Port SI device settings to new config system. 2022-01-08 20:08:21 +01:00
Admiral H. Curtiss a0a0bfc5ca
Config: Port EXI device settings to new config system. 2022-01-08 19:57:58 +01:00
Pokechu22 29df17d422 FifoPlayer: Allow changing loop option at runtime 
This option has always existed since it's used by FifoCI, but now it can be changed at runtime.  Looping is something that should almost always be on, but it can be useful to turn it off when frame-dumping is enabled so that hundreds of copies of the same frame aren't created.  Before, turning it off required restarting Dolphin.
 2022-01-06 19:08:16 -08:00
Pokechu22 575062a612 FifoPlayer: Store early memory updates option in the config 
Now, early memory updates is persisted across runs, and can be toggled before starting a fifolog.
 2022-01-06 19:02:13 -08:00
JMC47 4c0dcf42b8
Merge pull request #10346 from iwubcode/fixed_shader_precompile_parallelization 
VideoCommon: Fix shader precompilization detection
 2022-01-06 16:28:15 -05:00
Admiral H. Curtiss eb5bb2993e
Core/AudioCommon: Add config caching to Mixer. 2022-01-06 16:43:43 +01:00
Admiral H. Curtiss ed1a1c1fae
Config: Port WiimoteControllerInterface setting to new config system. 2022-01-06 16:13:57 +01:00
Admiral H. Curtiss 2354fb4466
Config: Port WiimoteEnableSpeaker setting to new config system. 2022-01-06 16:13:57 +01:00
Admiral H. Curtiss 8c554d2e64
Config: Port WiimoteContinuousScanning setting to new config system. 2022-01-06 16:13:57 +01:00
Admiral H. Curtiss b2da738c81
Config: Port WiiKeyboard setting to new config system. 2022-01-06 16:13:57 +01:00
Admiral H. Curtiss f19cf1753b
Config: Port WiiSDCard setting to new config system. 2022-01-06 16:13:56 +01:00
Admiral H. Curtiss 2aa44b10ba
Config: Port TimingVariance setting to new config system. 2022-01-06 16:13:56 +01:00
Admiral H. Curtiss dc7e7d08ad
Config: Port Fastmem setting to new config system. 2022-01-06 16:13:56 +01:00
Admiral H. Curtiss 88d725c918
Config: Port SyncOnSkipIdle setting to new config system. 2022-01-06 16:13:56 +01:00
Admiral H. Curtiss e613cbf395
Config: Port FastDiscSpeed setting to new config system. 2022-01-06 16:13:55 +01:00
Admiral H. Curtiss 7184983ee8
Config: Port DisableICache setting to new config system. 2022-01-06 16:13:55 +01:00
Admiral H. Curtiss d98c6b0b1d
Config: Port GPUDeterminismMode setting to new config system. 2022-01-06 16:13:55 +01:00
Admiral H. Curtiss 68688e7903
Config: Port PerfMapDir setting to new config system. 2022-01-06 16:13:55 +01:00
Admiral H. Curtiss fb47035f97
Config: Port emulation speed setting to new config system. 2022-01-06 16:13:54 +01:00
JosJuice 804f78e0e4 Android: Mark s_android_send_report as static 
Fixes a compiler warning.
 2022-01-06 12:20:09 +01:00
Mai M 7bd14c5d9f
Merge pull request #10338 from Pokechu22/natvis-improvements 
Natvis improvements
 2022-01-06 04:01:25 -05:00
Mai M 6939fd9f18
Merge pull request #10348 from AdmiralCurtiss/config-remove-compare-server-client 
Config: Remove CompareServer and CompareClient settings.
 2022-01-06 03:59:48 -05:00
Mai M c0fada6fec
Merge pull request #10350 from Techjar/netplay-longer-timeout 
Core/NetPlay: Extend enet peer timeout
 2022-01-06 03:58:58 -05:00
Mai M c52485071b
Merge pull request #10351 from JosJuice/rb3-more-devices 
USBUtils: Add/fix some Rock Band devices
 2022-01-06 03:58:00 -05:00
JosJuice 589c267355 USBUtils: Fix 1bad:3110/1bad:3430 mixup 
The wiki and the source code had these mismatched, and a user reported
that 1bad:3430 is the Mustang guitar, so the wiki must be right.
 2022-01-06 09:46:05 +01:00
JosJuice 0de8ccc25f USBUtils: Add "Harmonix RB3 Keyboard for Nintendo Wii" 2022-01-06 09:42:19 +01:00
Techjar 600c8169d5 Core/NetPlay: Extend enet peer timeout 
This extends the timeout to 30 seconds, so users who have brief
connection issues won't be so swiftly disconnected, allowing the
NetPlay session to continue.
 2022-01-06 02:13:19 -05:00
Admiral H. Curtiss 032f0da35e
Config: Remove CompareServer and CompareClient settings. 2022-01-05 21:26:17 +01:00
JMC47 bc14485489
Merge pull request #10340 from AdmiralCurtiss/config-port-core-1 
Config: Port remaining Core settings to new config system (partial).
 2022-01-05 04:53:04 -05:00
iwubcode 9b4e5b00ee VideoCommon: assume the majority of os/drivers support parallel compiling of shaders, we can create bugs if there are issues. Android is assumed buggy 2022-01-04 20:40:07 -06:00
Admiral H. Curtiss 0bfffe4095
Config: Port GC Adapter settings to new config system. 2022-01-05 03:25:19 +01:00
Admiral H. Curtiss e08171fa24
Config: Port remaining Core settings to new config system (partial). 2022-01-05 00:54:15 +01:00
Jordan Woyak 78a9bdf04a InputCommon: Use value of "Modifier" button "Range" setting rather than always applying 50%. 
Make "Clear" button reset "Modifier" "Range" settings to 50%.
 2022-01-04 14:09:50 -06:00
JMC47 3feea704e0
Merge pull request #10342 from JosJuice/vulkan-shader-crash 
Vulkan: Check for vkSetDebugUtilsObjectNameEXT before using it
 2022-01-04 10:47:55 -05:00
JMC47 9a914d33d5
Merge pull request #9414 from DevJPM/master 
Fix CPU Core Count detection and Enable Parallel Shader Compilation
 2022-01-04 10:15:12 -05:00
JosJuice 2ab66390f8 Vulkan: Check for vkSetDebugUtilsObjectNameEXT before using it 
Fixes a crash that has been present on Android (and probably also
macOS) since f6883a0.
 2022-01-03 20:17:57 +01:00
Admiral H. Curtiss 8af737d3bd
D3D12: Fix nullptr dereference when creating a shader with a name. 2022-01-03 17:14:09 +01:00
Léo Lam 04a25818b2
Merge pull request #10330 from aldelaro5/gdb-stub-add-hostinfo 
GDB Stub: add support for lldb's qHostInfo
 2022-01-03 12:43:57 +01:00
aldelaro5 d705a5fe9b GDB Stub: add support for lldb's qHostInfo 2022-01-02 19:58:31 -05:00
Léo Lam 953eb49cd8
Merge pull request #10335 from ssdsnake/dolphintool_fix_20220102 
DolphinTool: initialize user directories before verify/convert operations
 2022-01-03 01:46:22 +01:00
Léo Lam 7abb501e0a
Merge pull request #10334 from AdmiralCurtiss/json-maker 
Core: Add a Maker field for GameModDescriptors.
 2022-01-03 01:43:02 +01:00
Léo Lam 0de008da11
Merge pull request #10332 from AdmiralCurtiss/config-port-general 
Config: Port remaining General settings to new config system.
 2022-01-03 01:40:37 +01:00
Léo Lam 4ee20368f8
Merge pull request #10336 from aldelaro5/gdb-stub-fix-first-packet 
GDB Stub: do not send a packet when we just connected
 2022-01-03 01:40:16 +01:00
Léo Lam cbd1c4969d
Merge pull request #10309 from aldelaro5/gdb-stub-fix-watchpoints 
Gdb stub: fix watchpoints
 2022-01-03 01:33:49 +01:00
Léo Lam 27a2df410a
Merge pull request #10308 from aldelaro5/gdb-stub-fix-unkown-pointer 
GDB Stub: validate the address exists before reading/writting to it
 2022-01-03 01:33:21 +01:00
Léo Lam f5a24ac7b9
Merge pull request #10300 from aldelaro5/gdb-stub-fix-thread-reports 
GDB Stub: fix thread report requests
 2022-01-03 01:32:31 +01:00
Léo Lam 5953c55075
Merge pull request #10271 from Pokechu22/hash.h-merge 
Merge CRC32.h into Hash.h and remove MD5.h
 2022-01-03 01:26:59 +01:00
Pokechu22 8e2b06906b Create EnumMap natvis 2022-01-02 15:36:47 -08:00
Pokechu22 b96297f2ee Improve BitField natvis 
Now, enums are properly displayed, and BitFieldArray is also displayed nicely.  Signed values also work correctly, and 1-bit fields are not treated as bools unless the bitfield is explicitly marked as a bool.
 2022-01-02 14:39:34 -08:00
ssdsnake 4d125064fe DolphinTool: initialize user directories (fix unintential deletion of Wii files) 2022-01-02 12:34:24 -06:00
aldelaro5 4b131bf1ce GDB Stub: do not send a packet when we just connected 2022-01-02 04:35:55 -05:00
Admiral H. Curtiss 2906889804
Core: Add a Maker field for GameModDescriptors. 2022-01-02 06:06:53 +01:00
aldelaro5 bfa675cb9d GDB Stub: validate the address exists before reading/writting to it 2022-01-01 22:00:13 -05:00
aldelaro5 051197b83c GDB Stub: fix thread report requests 
We are always reporting thread 1 existing and also fix an issue with a wrong memcmp size
 2022-01-01 17:38:25 -05:00
aldelaro5 9c784ca8ab GDB Stub: correctly define the breakpoint type values 
Read only and Write only were reversed, now they are properly defined.
 2022-01-01 17:18:32 -05:00
aldelaro5 70b7e16d6c GDB Stub: properly check for wrong breakpoint type 
Fix dolphin erroring out on requests to remove access watchpoints.
 2022-01-01 17:18:30 -05:00
Pokechu22 3d5b46615c NetPlayClient: Use fmt::join for MD5Sum 2022-01-01 11:52:53 -08:00
Pokechu22 301bc49efe Common: Remove MD5.h 
It uses DiscIO, and Common shouldn't depend on DiscIO.  Instead, put this code in NetPlayClient.cpp.
 2022-01-01 11:52:53 -08:00
Pokechu22 afd02b79a5 VideoCommon: Add names for textures and shaders 2022-01-01 11:38:56 -08:00
JosJuice ab8b2f9fe0 PPCAnalyst: Less strict interrupt checks in CanSwapAdjacentOps 
When these checks were originally added, we didn't have the nice
canCauseException attribute. Now we do, so let's use it.
 2022-01-01 20:25:04 +01:00
Pokechu22 0c19f895d3 Replace remaining uses of zlib crc32 with Common/Hash.h 2022-01-01 10:36:38 -08:00
Pokechu22 2652aed85c Common: Merge CRC32.h into Hash.h 
This makes it easier to find the relevant functions.
 2022-01-01 10:36:38 -08:00
Admiral H. Curtiss d590aa88a4
Config: Port remaining General settings to new config system. 2022-01-01 19:02:45 +01:00
Rafaël Kooi b756dc40bb RenderWidget: Add include to Windows.h 
Fixes errors when building with CMake. PCH support is currently broken,
however the code shouldn't have a hard dependency on PCH anyway.
 2022-01-01 17:58:20 +01:00
Léo Lam dc7ea16705
Merge pull request #10284 from JosJuice/no-blr-cr 
PPCAnalyst: Don't treat blr as writing to CR
 2022-01-01 17:39:59 +01:00
Léo Lam 8b6b96a114
Merge pull request #10285 from Pokechu22/cursor-disabled-input-gate 
ControllerEmu: Hide the cursor if the input gate is disabled
 2022-01-01 17:32:54 +01:00
Léo Lam 13939b13d7
Merge pull request #10311 from JosJuice/gles-sampler2dmsarray 
GLES: Fix missing precision for sampler2DMSArray
 2022-01-01 16:49:34 +01:00
Léo Lam 379ab16e1b
Merge pull request #10301 from RA-Kooi/BBAFix 
BBA: Fix TAP detection
 2022-01-01 16:39:41 +01:00
Léo Lam 0a62ba9beb
Merge pull request #10320 from OatmealDome/macos-headless 
VulkanContext: Ensure present queue family is valid before incrementing queueCreateInfoCount
 2022-01-01 02:45:10 +01:00
Léo Lam 9a61514073
Merge pull request #10241 from AdmiralCurtiss/user-dir-consistency 
Ensure user paths are stored in a consistent manner.
 2022-01-01 02:32:24 +01:00
Admiral H. Curtiss b3a3ecd2b4
PPCAnalyzer: Most member functions can be const. 2021-12-31 17:46:45 +01:00
Admiral H. Curtiss d6331c1e71
Config: Port remaining Interface settings to new config system. 2021-12-31 17:40:04 +01:00
Admiral H. Curtiss 247f5d823f
Config: Port USBPassthrough setting to new config system. 2021-12-31 01:15:38 +01:00
Admiral H. Curtiss 526887899e
Config: Port BluetoothPassthrough settings to new config system. 2021-12-30 23:17:19 +01:00
Admiral H. Curtiss 810dcfa0f6
Config: Port Debug settings to new config system. 2021-12-30 22:28:05 +01:00
Admiral H. Curtiss 9c4b2b65b4
Config: Port Input setting to new config system. 2021-12-30 21:50:36 +01:00
Admiral H. Curtiss aa437d9805
Config: Port Movie settings to new config system. 2021-12-30 20:16:17 +01:00
JMC47 1112b2a19e
Merge pull request #10307 from AdmiralCurtiss/config-port-autoupdate 
Config: Port AutoUpdate settings to new config system.
 2021-12-30 14:12:36 -05:00
JMC47 de91afaff3
Merge pull request #10298 from aldelaro5/gdb-stub-fix-registers 
GDB Stub: Fix the id of the registers returned by p and P packets
 2021-12-29 21:02:31 -05:00
JMC47 01f180217b
Merge pull request #10299 from aldelaro5/gdb-stub-add-query-packets 
GDB Stub: add support for various query packets
 2021-12-29 19:37:28 -05:00
JMC47 1c8a7f1867
Merge pull request #10277 from AdmiralCurtiss/memarena-cleanup 
MemArena: Cleanup & interface changes for safer memory mapping.
 2021-12-29 19:06:47 -05:00
aldelaro5 b369d822b1 GDB Stub: add support for various query packets 
These tends to get requested from either pure GDB or Ghidra. They reduce the verbosity of the communications. The QSupported packet is also important to implemnent for future proofing too.
 2021-12-28 23:34:33 -05:00
OatmealDome 9ff7f80aa0 VulkanContext: Ensure present queue family is valid before incrementing queueCreateInfoCount 2021-12-28 21:18:47 -05:00
aldelaro5 beabd56ff8 GDB Stub: Fix the id of the registers returned by p and P packets 
The stub was made with the assumption that the GDB architecture is rs6000:6000, but the closest is actually powerpc:750 which features much more SPR that the gekko supports, but it also has slightly different ID. This commit now assumes the more proper powerpc:750.
 2021-12-28 19:27:34 -05:00
JosJuice 68fd94e063
Merge pull request #10302 from RA-Kooi/CMakeQt 
DolphinQt: Fix generation of /external:I flags
 2021-12-28 20:03:26 +01:00
JosJuice a96cfe2531 GLES: Fix LOD bias int/float mismatch 
Another simple GLES shader compilation error.
 2021-12-28 19:19:22 +01:00
JosJuice 76b508557e GLES: Fix missing precision for sampler2DMSArray 
We don't use sampler2DMS, but we do use sampler2DMSArray.

I can't reproduce it on my phone, but a user who was running GLES
on a Tegra X1 reported a shader compilation error related to this.
 2021-12-28 11:36:11 +01:00
JMC47 2a34118e1e
Merge pull request #10310 from AdmiralCurtiss/interpreter-cycle-count-debug 
Interpreter: Fix cycle counting inconsistency between debug mode and regular mode loops.
 2021-12-28 04:14:13 -05:00
JMC47 01e8e950e8
Merge pull request #10292 from OatmealDome/lodbias-take-two 
PixelShaderGen: Use LOD bias when sampling texture on Metal and OpenGL ES
 2021-12-28 02:45:14 -05:00
OatmealDome 056613ecc5 PixelShaderGen: Add LOD bias to texture() call on systems that don't support it in the sampler 2021-12-28 02:10:45 -05:00
OatmealDome 4e12d6e871 ShaderGenCommon: Add bit for LOD bias 2021-12-28 02:10:39 -05:00
Admiral H. Curtiss ebe27e0140
Interpreter: Fix cycle counting inconsistency between debug mode and regular mode loops. 2021-12-28 05:48:33 +01:00
Rafaël Kooi edb843415d BBA: Fix TAP detection 2021-12-27 22:03:00 +01:00
Admiral H. Curtiss 96fa0919be
Config: Port AutoUpdate settings to new config system. 2021-12-27 21:19:28 +01:00
JosJuice 8d237eb102
Merge pull request #10305 from AdmiralCurtiss/config-port-fifoplayer 
Config: Port FifoPlayer setting to new config system.
 2021-12-27 21:11:41 +01:00
JMC47 ddb3bad9c9
Merge pull request #10288 from JosJuice/jit64-safe-paired-load 
Jit64: Make paired loads always safe
 2021-12-27 14:47:27 -05:00
Admiral H. Curtiss 56f747ebf3
Config: Port FifoPlayer setting to new config system. 2021-12-27 17:56:34 +01:00
Rafaël Kooi d6c9831efd DolphinQt: Fix generation of /external:I flags 
Mainly concerns to building with Ninja, as that's what I tested it with.
Originally it would only prepend the first path with `/external:I`,
however all paths in the list have to be prepended with `/external:I`.
The MS documentation seems to support this, as it makes no mention of it
accepting a list.

This is probably the worst way to implement this, I am unfamiliar with
CMake.
 2021-12-27 14:31:58 +01:00
JMC47 4dcf2327eb
Merge pull request #10286 from Pokechu22/geometry-shader-depth-clamp 
GeomeryShaderGen: Set gl_ClipDistance on Vulkan as well as OpenGL
 2021-12-27 02:04:59 -05:00
JMC47 1f1e78ee7a
Merge pull request #10273 from Pokechu22/fifoplayer-efb-clear-wait 
FifoPlayer: Wait after clearing the screen
 2021-12-27 02:01:02 -05:00
JMC47 66411571fa
Merge pull request #10293 from AdmiralCurtiss/config-port-cpu-overclock 
Config: Port CPU overclock setting to new config.
 2021-12-27 00:16:24 -05:00
Admiral H. Curtiss 5999e9e139
Config: Port GameList settings to new config system. 2021-12-26 23:46:35 +01:00
Admiral H. Curtiss 7625cb7aca
CoreTiming: Cache the overclock factor instead of re-querying it every Advance(). 2021-12-25 23:40:26 +01:00
Admiral H. Curtiss 319b00f1fd
Config: Allow unregistering callbacks. 2021-12-25 23:32:49 +01:00
Admiral H. Curtiss cae4b545bd
Config: Port CPU overclock settings to new config system. 2021-12-25 21:52:50 +01:00
OatmealDome 91cdeb5aa6 SamplerCache: Check for bSupportsLodBiasInSampler instead of IsGLES 2021-12-25 15:17:19 -05:00
OatmealDome 08396c56e5 VideoConfig: Add bool for sampler LOD bias support 2021-12-25 15:16:27 -05:00
Admiral H. Curtiss 269ae6f7e8
Core/UICommon: Use std::move() a bit more. 2021-12-25 20:21:33 +01:00
Admiral H. Curtiss ab56f3ecbd
Calls to File::SetUserPath() no longer need to manually append directory separators. 2021-12-25 20:21:32 +01:00
Admiral H. Curtiss e54657254a
Core: Make format of D_WIIROOT_IDX consistent with the rest of the user directories. 2021-12-25 20:21:32 +01:00
Admiral H. Curtiss 3e1511ce98
Common/FileUtil: Ensure consistency for custom user paths. 2021-12-25 20:21:32 +01:00
Admiral H. Curtiss 1554128560
MemArena: Prepare interface for proper memory reservation. 2021-12-25 20:20:36 +01:00
Admiral H. Curtiss 812cc8b632
MemArena: Split into three separate files for each OS. 2021-12-25 20:20:36 +01:00
JosJuice 1295bc4272 Jit64: Make paired loads always safe 
It's always a good sign when the comments say "this will definitely
crash" and "I don't know if this is for a good reason".

Fixes https://bugs.dolphin-emu.org/issues/12762.
 2021-12-24 19:09:12 +01:00
JosJuice 5dd2ddb1df Memmap: Replace some GetPointer calls 
These GetPointer calls could cause crashes, in part because the
callers didn't do null checks and in part because GetPointer
inherently is unsafe to use for accesses larger than 1 byte.
 2021-12-24 11:03:58 +01:00
Pokechu22 1cd148d4c5 GeomeryShaderGen: Set gl_ClipDistance on Vulkan as well as OpenGL 
Fixes https://bugs.dolphin-emu.org/issues/12548
 2021-12-23 17:56:21 -08:00
Pokechu22 de7c78ef3d ControllerEmu: Hide the cursor if the input gate is disabled 2021-12-23 15:22:35 -08:00
Pokechu22 86f2b39d66 FifoPlayer: Wait after clearing the screen 
If we don't wait, then the copy will be performed at a later time, which may overwrite memory updates.
 2021-12-23 12:35:18 -08:00
Pokechu22 d981944d7c FifoPlayer: Fix uninitialized variable warnings in ClearEfb 
The actual values don't matter since we overwrite all of the relevant fields, but other bits were not initialized (e.g. the top 12 bits of X10Y10), so the warning was semi-valid.
 2021-12-23 12:35:18 -08:00
Pokechu22 85025612bc LightingShaderGen: Make s_lighting_struct not inline 
This generated warnings on the freebsd builder.
 2021-12-22 15:17:52 -08:00
JosJuice e6f40fa015
Merge pull request #10279 from Pokechu22/intensity-alpha 
TextureConverterShaderGen: Set alpha to 1 on intensity formats if EFB lacks alpha
 2021-12-23 00:14:06 +01:00
JMC47 b1f79d9ecf
Merge pull request #10215 from OatmealDome/shader-logic-ops 
VideoCommon: Support shader logic ops on Metal (Apple GPUs) and OpenGL ES
 2021-12-22 16:39:54 -05:00
JosJuice b6395a7c49 PPCAnalyst: Don't treat blr as writing to CR 
This piece of code is rather hard to understand, but my best guess
at what it's trying to do is that it tries to create opportunities
to skip writing CRs back to ppcState if we know that there are no
CR instructions (or branch instructions, etc) between an instruction
that writes to a CR register and the next blr. This is technically
inaccurate emulation, but as long as games don't do anything too
weird with their ABIs, I suppose it doesn't break anything.

So why do I want to get rid of it? Well, other than breaking some
hypothetical weird game, I imagine it could trip up people trying
to debug a game who are looking at the CR contents. And the code
is just plain confusing. (blr clearly doesn't write to CRs!)
 2021-12-21 21:29:55 +01:00
Pokechu22 fd2324e40a Fifo analyzer: Rename mipmap filter to half scale for EFB copies 
The field itself is named half_scale, and it can be used for things unrelated to mipmaps, so reflecting that name in the fifo analyzer helps.
 2021-12-20 11:34:05 -08:00
Pokechu22 2f6953efb6 TextureConverterShaderGen: Set alpha to 1 on intensity formats if EFB lacks alpha 
We were already doing this for non-intensity formats, but it seems like the same applies to intensity formats.
 2021-12-20 11:34:05 -08:00
JMC47 32fed91b0d
Merge pull request #9718 from Pokechu22/better-fifo-analyzer-part-3 
Fifo analyzer improvements, part 3
 2021-12-20 14:27:14 -05:00
JMC47 1714dc64bb
Merge pull request #10120 from Sintendo/jit64arithcxrefactor 
Jit64: Merge arithcx into addx/subfx
 2021-12-20 14:20:49 -05:00
JMC47 9ed368ead7
Merge pull request #9376 from merryhime/rlwimix2 
Jit_Integer: Optimize rlwimix
 2021-12-20 14:20:26 -05:00
JMC47 2d1c7352e4
Merge pull request #10280 from iwubcode/wfs_root_configurable 
Core / DolphinQt: make WFS directory configurable
 2021-12-18 19:02:53 -05:00
Pokechu22 ffa512f5e7 DolphinTool: Remove direct dependency on core 
Videocommon also depends on core, which resulted in linking errors (though I'm not sure why).  Ideally, dolphintool woudln't depend on videocommon... but some stuff in core does.
 2021-12-18 15:24:29 -08:00
Pokechu22 e7d5f8ad5c TextureCacheBase: Re-wrap GetTexture comment 2021-12-18 15:21:48 -08:00
Pokechu22 f4f4dbbc63 Switch to the Play / Record tab when fifo playback stops 2021-12-18 15:21:48 -08:00
Pokechu22 d1cc539476 BPMemory: Correct spelling of MaxAniso 2021-12-18 15:21:48 -08:00
Pokechu22 f0f12ac8d7 Fifo analyzer: Decode floats in primitive data 2021-12-18 15:21:48 -08:00
Pokechu22 27cb704466 Eliminate VarType for ComponentFormat 2021-12-18 15:21:48 -08:00
Pokechu22 1a964891f8 VertexLoader_Color: Use Common::swap24 2021-12-18 15:21:48 -08:00
Pokechu22 95e0f833f9 Fifo analyzer: Display equations for color/alpha combiners 2021-12-18 15:21:48 -08:00
Pokechu22 0afe318b55 OpcodeDecoding: Make s_is_fifo_error_seen static 2021-12-18 15:21:48 -08:00
Pokechu22 d039b1bc0d VideoCommon: Move VertexLoaderManager logic out of CPState 2021-12-18 15:21:48 -08:00
Pokechu22 e4605fa399 Fifo analyzer: Create a new object for each EFB copy 
Previously, EFB copies would be in the middle of other objects, as objects were only split on primitive data.  A distinct object for each EFB copy makes them easier to spot, but does also mean there are more objects that do nothing when disabled (as disabling an object only skips primitive data, and there is no primitive data for EFB copies).
 2021-12-18 15:21:48 -08:00
Pokechu22 d84d695fdf Remove DataReader from LoadXFReg 2021-12-18 15:21:48 -08:00
Pokechu22 b5fd35f951 Refactor OpcodeDecoding and FIFO analyzer to use callbacks 2021-12-18 15:21:36 -08:00
Pokechu22 0441826206 Fix wrapping in FifoPlayer comment 2021-12-18 12:51:56 -08:00
Pokechu22 d5cfac71d0 Refactor object listing code 
This also adds the commands after the last primitive data but before the next frame as a unique object; this is mainly just the XFB copy.  It's nice to have these visible, though disabling the object does nothing since only primitive data is disabled and there is no primitive data in this case.
 2021-12-18 12:51:56 -08:00
Pokechu22 1914087998 Create and use CPArray enum class 2021-12-18 12:51:56 -08:00
Pokechu22 3aaeb2b9ef Convert OpcodeDecoder::Opcode and OpcodeDecoder::Primitive to enum class 2021-12-18 12:51:56 -08:00
Pokechu22 3fc12431c5 Remove parameters to SWVertexLoader::SetFormat 
They haven't been used since efbe5bc4b6.
 2021-12-18 12:51:56 -08:00
Pokechu22 205ab23d80 GeometryShaderGen: Convert to EnumMap 2021-12-18 12:51:55 -08:00
Pokechu22 f53dc6564f UberShaderPixel: Convert to EnumMap 2021-12-18 12:51:55 -08:00
Pokechu22 380b333387 PixelShaderGen: Convert to EnumMap 2021-12-18 12:51:55 -08:00
Pokechu22 2b1d1038a6 VertexLoader: Convert to EnumMap 2021-12-18 12:51:55 -08:00
Pokechu22 327126d1e8 ShaderGenCommon: Add WriteSwitch 2021-12-18 12:51:55 -08:00
iwubcode 5ecd5f010f Core / DolphinQt: make WFS directory configurable 2021-12-18 01:08:35 -06:00
Admiral H. Curtiss 48560135b3
Jit64: Put the exception exit in twX into farcode. 
As a byproduct, this fixes the dont_trap jump not having enough available jump distance to its target in some instances (eg. in Not64).
 2021-12-18 06:05:08 +01:00
Markus Wick 80ccb20931
Merge pull request #10267 from JosJuice/jitarm64-bigger-farcode 
JitArm64: Allocate 64 MB for farcode
 2021-12-16 19:23:31 +01:00
JosJuice 094290792a Core: Add missing header to NetPlayCommon.cpp 
https://bugs.dolphin-emu.org/issues/12765
 2021-12-15 18:57:10 +01:00
Léo Lam 185475fe03
Merge pull request #10187 from AdmiralCurtiss/json-gamelist 
Support for GameModDescriptor files in Game List.
 2021-12-14 11:08:38 +01:00
Admiral H. Curtiss b928900f6e
Core/WiiRoot: Handle the combination of NetPlay and savegame redirects. 2021-12-14 06:15:37 +01:00
Admiral H. Curtiss 387d148357
NetPlay: Add functions to sync folders. 2021-12-12 21:26:10 +01:00
Admiral H. Curtiss 418bb0b087
GameFile: Calculate a sensible sync hash for mod descriptors. 2021-12-12 21:26:09 +01:00
Admiral H. Curtiss 005e850ad6
DolphinQt: Add a 'Save as Preset' button to RiivolutionBootWidget. 2021-12-12 21:26:09 +01:00
Admiral H. Curtiss a2a39cfcfb
Core: Add ability to serialize a GameModDescriptor to json. 2021-12-12 21:26:09 +01:00
Admiral H. Curtiss da161faff4
GameList: Show game mod descriptor .json files in game list. 2021-12-12 21:26:09 +01:00
Admiral H. Curtiss b50861ea44
Core: Require game mod descriptor json to self-identify as one. 2021-12-12 21:26:09 +01:00
Admiral H. Curtiss ea17dd8dba
RiivolutionParser: Create config xml directory if it does not exist yet. 2021-12-12 21:24:36 +01:00
Pokechu22 2025763420 Treewide: Adjust order of includes 2021-12-10 14:49:57 -08:00
Pokechu22 9304fe7124 DolphinQt: Remove 5~5~5~ typos 2021-12-10 13:59:38 -08:00
Pokechu22 824e0c00df JitCache: Remove irrelevant comment 
It became irrelevant in 952dfcd610, when the define was removed; now, the code the comment is referring to is in JitRegister.cpp, and oprofile is controlled by cmake.
 2021-12-10 13:59:38 -08:00
Pokechu22 ea414b06ef ParallelProgressDialog: Add missing license comment 2021-12-10 13:59:38 -08:00
Pokechu22 04d747dd10 GCMemcardUtils: Add missing license comment 2021-12-10 13:59:38 -08:00
Pokechu22 89f0b7b10c DolphinAnalytics: Add missing license comment 2021-12-10 13:59:38 -08:00
JMC47 bfddce425d
Merge pull request #10268 from Pokechu22/code-view-widget-clamp-ub 
CodeViewWidget: Fix undefined behavior when centered around address 0
 2021-12-10 05:59:47 -05:00
JosJuice 2f4ecde5cc
Merge pull request #10253 from Filoppi/fix_input_config_loading 
Fix InputConfig::LoadConfig() not always replacing emu controllers values
 2021-12-09 22:21:02 +01:00
JosJuice e0a61ed9a0
Merge pull request #10248 from Filoppi/fix_input_config_default_device_load 
Fix default input config default device not being loaded/found
 2021-12-09 22:20:55 +01:00
JosJuice d5d21c6533
Merge pull request #10252 from ssdsnake/feature_dolphintool 
DolphinTool: Add CLI tool subsystem + commands for verifying and converting RVZ/ISO/WIA/GCZ
 2021-12-09 22:20:26 +01:00
Pokechu22 5bcbc8fcef CodeViewWidget: Fix undefined behavior when centered around address 0 2021-12-08 21:42:15 -08:00
JosJuice 67787b59d6 JitArm64: Allocate 64 MB for farcode 
My change in 867cd99 caused farcode to fill up much more than before.
Most games still ran fine, but certain games would have multiple
cache clears per minute, on top of being overall slow.

Maybe there's something prettier we can do about this than just
allocating more RAM, but we have the resource budget for making
Dolphin use more RAM, so I consider increasing the size of the
cache to be a good solution at least for the time being.

At least for Prince of Persia: The Forgotten Sands, 48 MB isn't
enough to stop the cache clears, but 64 MB is. (I only played the
game for a few minutes when testing, though.)
 2021-12-08 20:56:00 +01:00
OatmealDome 1c421444ae ProgramShaderCache: Don't define FB_FETCH_VALUE for GL_EXT_shader_framebuffer_fetch 
We will automatically choose between real_ocol0 and ocol0 in the fragment shader.
 2021-12-06 22:36:40 -05:00
OatmealDome 74a979db09 UberShaderPixel: Add shader logic ops support on OpenGL ES 2021-12-06 22:36:40 -05:00
OatmealDome 18b2f6953d PixelShaderGen: Add shader logic ops support on OpenGL ES 
To do this, I had to decouple framebuffer fetch from shader blending. We need to be able to access framebuffer fetch input when using shader logic ops.
 2021-12-06 22:36:40 -05:00
OatmealDome a77ae14d94 UberShaderPixel: Add shader logic ops support on Metal 2021-12-06 22:36:40 -05:00
OatmealDome e0837cb847 PixelShaderGen: Add shader logic ops support on Metal 2021-12-06 22:36:40 -05:00
OatmealDome 426c68b5a0 ShaderCache: Don't turn on logic ops approximation if framebuffer fetch is supported 2021-12-06 22:36:40 -05:00
OatmealDome f87f704f43 ShaderCompiler: Add helpers for Metal framebuffer fetch 2021-12-06 22:36:39 -05:00
OatmealDome 40eb071562 ShaderCompiler: Add new helper define for input attachment binding 2021-12-06 22:36:39 -05:00
OatmealDome c12b9b013b PixelShaderGen: Add logic ops to pixel_shader_uid_data 2021-12-06 22:36:34 -05:00
Filoppi 689545a795 InputCommon: fix InputConfig::LoadConfig() not always replacing emu controllers values 
If InputConfig::LoadConfig() was called once with a non empty/customized config,
then called again after manually deleting the config (dolphin calls LoadConfig() every time it opens the mapping widget),
the second load would fail to clear the values on any non first EmulatedController and would instead keep the
previous config values despite it being deleted (while it would instead correctly default the first EmulatedController).

This is not a big bug though the code is better now.
 2021-12-05 23:37:58 +02:00
Filoppi 125971d9f2 InputCommon: fix default input config default device not being loaded/found 
Fixes bug: https://bugs.dolphin-emu.org/issues/12744

Before e1e3db13ba
the ControllerInterface m_devices_mutex was "wrongfully" locked for the whole Initialize() call, which included the first device population refresh,
this has the unwanted (accidental) consequence of often preventing the different pads (GC Pad, Wii Contollers, ...) input configs from loading
until that mutex was released (the input config defaults loading was blocked in EmulatedController::LoadDefaults()), which meant that the devices
population would often have the time to finish adding its first device, which would then be selected as default device (by design, the first device
added to the CI is the default default device, usually the "Keyboard and Mouse" device).

After the commit mentioned above removed the unnecessary m_devices_mutex calls, the default default device would fail to load (be found)
causing the default input mappings, which are specifically written for the default default device on every platform, to not be bound to any
physical device input, breaking input on new dolphin installations (until a user tried to customize the default device manually).

Default devices are now always added synchronously to avoid the problem, and so they should in the future (I added comments and warnings to help with that)
 2021-12-05 23:35:47 +02:00
ssdsnake 1aa8a4d46f DolphinTool: CLI utility interface and disc image tools 2021-12-03 15:40:19 -06:00
JosJuice 85e5070215
Merge pull request #10257 from Pokechu22/no-bs2-rtc-flags 
BS2Emu: Stop clearing the RTC flags
 2021-12-03 22:39:38 +01:00
Scott Mansell 0327bc2ab6
Merge pull request #10256 from malleoz/show-rerecord-count 
Renderbase: Show rerecord count
 2021-12-03 14:42:10 +13:00
JMC47 c12e4e8ee0
Merge pull request #10244 from phire/ban-timetravel 
Delay singlecore gpu interrupts; Fixes Bomberman Jetters in single core mode.
 2021-12-02 07:21:41 -05:00
Pokechu22 5af18773bf FifoPlayer: Clear EFB before starting playback 
This fixes the bad rendering on the first frame when using the software renderer: the software renderer's Z buffer started out at 0, but most games clear it to 0xffffff instead; this means that things don't render correctly except for in the regions where the screen was cleared by an EFB copy earlier in the frame.
 2021-12-01 19:09:24 -08:00
sowens99 e4fed7cce8 Add Rerecord Count display 
Simply shows Movie::s_rerecords in the ImGui Movie window
 2021-11-30 20:08:29 -05:00
Pokechu22 5134caf68c BS2Emu: Stop clearing the RTC flags 
The system menu does clear the RTC flags, but we currently aren't updating the cache file, and since we clear them the system menu doesn't know to update the cache either.  This means that launching a game via the system menu, and then launching a game directly and exiting via HOME will result in the system menu using an outdated cache and displaying the old game.  This causes it to fail to launch the game on the disc channel (since it doesn't match the cache), resulting in it resetting (though it will ignore the cache after resetting).  Not clearing the cache avoids this issue.
 2021-11-30 14:43:49 -08:00
Mai M fc1ed33c11
Merge pull request #10250 from JosJuice/i18n-save-game 
DolphinQt: Add i18n comment for "Save Game"
 2021-11-30 16:54:20 -05:00
Scott Mansell 57d251c2f0
Merge pull request #10242 from smitdylan2001/master 
Fixed Gamecube naming to GameCube
 2021-11-30 06:58:55 +13:00
JosJuice 6a1a7efdd5 DolphinQt: Add i18n comment for "Save Game" 
It's very easy to assume the "save" in this string is a verb.
 2021-11-27 20:27:33 +01:00
Pokechu22 8cf841ecc7 Fix saving RGBA images 
PNG_FORMAT_RGB and PNG_COLOR_TYPE_RGB both evaluate to 2, but PNG_FORMAT_RGBA evaluates to 3 while PNG_COLOR_TYPE_RGBA evaluates to 6; the bit indicating a palette is 1 while the bit indicating alpha is 4.
 2021-11-24 14:56:12 -08:00
Pokechu22 99e589cc98 Log libpng warnings and errors 2021-11-24 14:56:12 -08:00
OatmealDome 04ec02c06b ConstantManager: Add logic ops to PixelShaderConstants 2021-11-24 17:52:26 -05:00
OatmealDome 8e72136eeb VulkanContext: Set Apple GPUs as supporting framebuffer fetch 2021-11-24 17:52:24 -05:00
Scott Mansell f5c550e9cb Delay singlecore gpu interrupts 
Fixes Bomberman Jetters in single core mode.

When single core mode pauses the CPU to execute the GPU
FIFO it greedily executes the whole thing. Before this commit,
Finish and Token interrupts would happen instantly, not even
taking into account how long the current FIFO window has
taken to execute. The interrupts would be effectively backdated
to the start of this execution window.

This commit does two things: It pipes the current FIFO window
execution time though to the interrupt scheduling and it enforces
a minimum delay of 500 cycles before an interrupt will be fired.
 2021-11-25 11:11:01 +13:00
JMC47 55e331836d
Merge pull request #10243 from JosJuice/jitarm64-push-size 
JitArm64: Fix incorrect push size calculation
 2021-11-24 16:53:06 -05:00
JosJuice 83d2d55aab JitArm64: Fix incorrect push size calculation 2021-11-24 22:39:54 +01:00
Dylan Smit 9de7ef6d8d Fix improper naming 
I'm so sorry
 2021-11-24 17:04:30 +01:00
Léo Lam aa5cb35c86
Merge pull request #10143 from Pokechu22/png-compression-level 
Add option for setting the PNG zlib compression level
 2021-11-23 16:40:34 +01:00
Léo Lam e1e3db13ba
Merge pull request #10228 from Filoppi/fix_android_input_deadlock 
ControllerInterface: fix UpdateReferences() deadlock
 2021-11-23 16:27:03 +01:00
unknown f43122cd8a Trust MacOS not to crash during shader pre-compilation 2021-11-22 15:32:28 +01:00
DevJPM 613c4563c2 VideoCommon: Gate Multi-Threaded Shader Pre-Compilation behind a bug entry 2021-11-22 09:34:28 +01:00
Admiral H. Curtiss 6350c93ae1
NetPlay: Pass Wii FS sync data directly to game boot logic instead of indirectly through globals. 2021-11-22 01:33:46 +01:00
Admiral H. Curtiss 894773f607
Core/Boot: Add Wii FS sync data (for temp NAND/netplay) to BootSessionData and handle it in the boot and shutdown logic. 2021-11-22 01:33:45 +01:00
Admiral H. Curtiss 7b776f3769
NetPlay: Refactor game boot code path to allow passing BootSessionData through it. 2021-11-22 00:52:15 +01:00
Admiral H. Curtiss 83ad84061e
Core/Boot: Refactor storage of boot-to-savestate data into a separate class. 2021-11-22 00:35:35 +01:00
Léo Lam d5b917a6c2
Merge pull request #10237 from AdmiralCurtiss/netplay-server-crash 
NetPlayServer: Clear remaining m_players when netplay thread ends so that their destructors can run while the ENetHost still exists.
 2021-11-21 22:04:12 +01:00
Admiral H. Curtiss 8488ff6884
GBA: Add import and export save options to context menu. 2021-11-21 18:08:23 +01:00
Admiral H. Curtiss e2c4cf49e2
NetPlayServer: Clear remaining m_players when netplay thread ends so that their destructors can run while the ENetHost still exists. 2021-11-21 00:18:44 +01:00
JosJuice 5490797867 JitArm64: Implement memcheck for psq_lXX/psq_stXX with update 2021-11-20 23:39:27 +01:00
JosJuice 61c73061e9 JitArm64: Implement memcheck for psq_lXX/psq_stXX without update 2021-11-20 23:39:27 +01:00
JosJuice 9e43796912 JitArm64: Allow passing temp FPR to EmitMemcheck 
Small optimization. If the caller already has an FPR that
it isn't using, might as well pass it on to fpr.Flush.
 2021-11-20 23:39:27 +01:00
JosJuice 89301b1f91 JitArm64: Implement memcheck for lfXX/stfXX with update 2021-11-20 23:39:27 +01:00
JosJuice 8c96e60cd1 JitArm64: Implement memcheck for lfXX/stfXX without update 2021-11-20 23:39:27 +01:00
JosJuice 1c8ddcdda1 JitArm64: Implement memcheck for dcbz 2021-11-20 23:39:27 +01:00
JosJuice 4fe15e788f JitArm64: Implement memcheck for lmw/stmw 2021-11-20 23:39:27 +01:00
JosJuice b4ffdce800 JitArm64: Implement memcheck for lXX/stX with update 2021-11-20 23:39:27 +01:00
JosJuice 662ae570a0 JitArm64: Make EmitBackpatchRoutine support saving W0 
Being able to preserve the address register is useful for the
next commit, and W0 is the address register used for loads. Saving
the address register used for stores, W1, was already supported.
 2021-11-20 23:39:27 +01:00
JosJuice e316d0e94f JitArm64: Don't update dest reg when load triggers exception, part 2 
If a host register has been newly allocated for the destination
guest register, and the load triggers an exception, we must make
sure to not write the old value in the host register into ppcState.
This commit achieves this by not marking the register as dirty
until after the load is done.
 2021-11-20 23:39:26 +01:00
JosJuice 96190887ce JitArm64: Don't update dest reg when load triggers exception 
Fixes a problem introduced in the previous commit.
 2021-11-20 23:39:26 +01:00
JosJuice ab1ceee16f JitArm64: Implement memcheck for lXX/stX without update 2021-11-20 23:39:26 +01:00
JosJuice 8c905e152a JitArm64: Make WriteConditionalExceptionExit more flexible 
You can now specify an already allocated register for it to use as a
temporary register, and it also supports being called while in farcode.
 2021-11-20 23:37:02 +01:00
JMC47 e5a4a86672
Merge pull request #10055 from JosJuice/jitarm64-reuse-memory 
JitArm64: Codegen space reuse
 2021-11-20 17:35:24 -05:00
DevJPM 61cfd8696e Fix CPU Core Count detection and Enable Parallel Shader Compilation 
This does this following things:

- Default to the runtime automatic number of threads for pre-compiling shaders
- Adds a distinct automatic thread count computation for pre-compilation  (which has less other things going on
and should scale better beyond 4 cores)
- Removes the unused logical_core_count field from the CPU detection
- Changes the semantics of num_cores from maximaum addressable number of cores to actually available CPU cores
(which is also how it was actually used)
- Updates the computation of the HTT flag now that AMD no longer lies about it for its Zen processors
- Background shader compilation is *not* enabled by default
 2021-11-20 16:08:10 +01:00
Filoppi 1badceb455 ControllerInterface: fix UpdateReferences() deadlock 
Removed useless locks to DeviceContainer::m_devices_mutex, as they were all already protected by m_devices_population_mutex.
We have no interest in blocking other threads that were potentially reading devices at the same time so this seems fine.
This simplifies the code, and I've adjusted a few comments which mentioned possible deadlock that should now be totally gone.

The deadlock could have happen if a thread directly called EmulatedController::UpdateReferences(), while another another thread also reached EmulatedController::UpdateReferences() within a call to ControllerInterface::UpdateDevices(), as the mentioned function locked both the DeviceContainer::m_devices_mutex and s_get_state_mutex at the same time.

The deadlock was frequent on game emulation startup on Android, due to the UpdateReferences() call in InputConfig::LoadConfig() and the UI thread triggering calls to ControllerInterface::UpdateDevices().
It could also have happened on Desktop if a user pressed "Refresh Devices" manually in the UI while the input config was loading.

Also brought some UpdateReferences() comments and thread safety fixes from https://github.com/dolphin-emu/dolphin/pull/9489
 2021-11-20 16:54:36 +02:00
Admiral H. Curtiss 0fc563ee2e
RiivolutionPatcher: Use case-insensitive filename comparison when searching for files in a folder patch. 2021-11-20 01:15:18 +01:00
JMC47 dbaebdc585
Merge pull request #10222 from phire/fix-copy-filter-clamping 
Fix copy filter clamping
 2021-11-18 17:48:33 -05:00
Pokechu22 94ccf765af Add option for setting the PNG zlib compression level 2021-11-18 13:10:22 -08:00
Pokechu22 95b9941044 Use Fast Texture Sampling by default 
This commit changes the default value of Fast Texture Sampling to true, and also moves the setting that controls it to the experimental section of the advanced tab.  This is its own commit so that it can be easily reverted when we want to default to Manual Texture Sampling.

Co-authored-by: JosJuice <josjuice@gmail.com>
 2021-11-17 21:29:57 -08:00
Pokechu22 1adff1c467 VideoCommon: Skip textureQueryLevels if it doesn't exist 2021-11-17 21:28:39 -08:00
Pokechu22 bdcfb31187 VideoCommon: Handle custom texture sizes correctly 
Specifically, when using Manual Texture Sampling, if textures sizes don't match the size the game specifies, things previously broke.  That can happen with custom textures, and also with scaled EFB copies at non-native IRs.  It breaks most obviously by not scaling the texture coordinates (so only part of the texture shows up), but the hardware wrapping functionality also assumes texture sizes are a power of 2 (or else it will behave weirdly in a way that matches how hardware behaves weirdly).  The fix is to provide alternative texture wrapping logic when custom texture sizes are possible.
 2021-11-17 21:28:36 -08:00
Pokechu22 93eea7cb13 VideoCommon: Add option to use old behavior (Fast Texture Sampling) 
Co-authored-by: JosJuice <josjuice@gmail.com>
 2021-11-17 21:27:32 -08:00
Pokechu22 ee80298ca4 VideoCommon: Implement diagonal LOD 
Note that both GLSL and HLSL provide a fwidth (fragment width) function defined as `fwidth(p) = abs(dFdx(p)) + abs(dFdy(p))`.  However, it's easy enough to implement this ourselves (and it makes the code a bit more obvious).
 2021-11-17 20:04:34 -08:00
Pokechu22 b9288212a0 Software: Adjust diagonal LOD implementation 
This produces behavior matching the behavior on hardware (see Wario's Gold Mine in Mario Kart Wii).
 2021-11-17 20:04:34 -08:00
Pokechu22 51e3334526 VideoCommon: Use coarse derivatives for Manual Texture Sampling if possible 2021-11-17 20:04:34 -08:00
Pokechu22 ddf2691395 VideoCommon: Manually handle texture wrapping and sampling 2021-11-17 20:04:34 -08:00
Pokechu22 4a9b26de86 VideoCommon: Expose SamplerState to shaders 
The benefit to exposing this over the raw BP state is that adjustments Dolphin makes, such as LOD biases from arbitrary mipmap detection, will work properly.
 2021-11-17 20:04:34 -08:00
Pokechu22 9ef228503a VideoCommon: Provide raw texdims to shaders 2021-11-17 20:04:34 -08:00
Pokechu22 a273b65566 RenderState: Use operator== for operator!= and adjust constructors 2021-11-17 20:04:34 -08:00
Pokechu22 6236a0d494 Eliminate SamplerCommon 2021-11-17 20:04:34 -08:00
Pokechu22 3096f77ba0 Eliminate SamplerCommon::AreBpTexMode0MipmapsEnabled 
This was added in 0b9a72a62d but became irrelevant in 70f9fc4e75 as the check is now self-explanatory due to a rejiggering of the bitfields.
 2021-11-17 20:04:34 -08:00
Pokechu22 d2041b4c2a VideoCommon: Add signed version of BitfieldExtract 2021-11-17 20:04:33 -08:00
Pokechu22 555a93057c VideoCommon: Allow BitfieldExtract in specialized shaders 2021-11-17 20:04:33 -08:00
Scott Mansell 9bbc843542 VideoSoftware: Fix copy filter clamping 2021-11-17 09:29:16 +13:00
Scott Mansell 7128befb39 Fix copy filter clamping regression in Spyro 
This fixes horizontal lines in the bloom effect of Spyro: A Hero's Tail,
which is a regression caused by PR #10204

Screenshot of regression:
https://user-images.githubusercontent.com/138484/142030503-90fcd8d5-63d3-4820-874a-72e9be0c4768.png

Fixed:
https://user-images.githubusercontent.com/138484/142031598-b85ff55c-1302-4e4d-bcb2-57848974056b.png

Spyro uses an 640x80 pixel sub-buffer within the EFB to calculate
it's bloom effects, which it places below the main 640x448 buffer.

EFB layout:
https://user-images.githubusercontent.com/138484/142030573-e933b6ae-c37e-4be6-86d4-0bc779b92535.png
Note: Colors are wrong because the main color buffer uses RGBA6,
      while the bloom is calculated in RGB8

This allows it to do bloom without backing up part of the EFB to
main memory, as most games do.

But, since some of the sub-buffers used in the bloom effect are taller
than 80 pixels, they need to be sliced up into smaller sub, sub buffers
which get combined later when copied to main memory.

At one point, a 320x224 buffer is broken up into 320x80, 320x64 and
320x80 slices. These are copied out with the copy filter set to a
vertical blur.

Because there was an off-by-one errror in the clamping coordinates,
the bottom line of the color buffer would be blurred into
the top of each slice.

Final combined EFB copy:
https://user-images.githubusercontent.com/138484/142031360-2c076839-7c96-4b3b-a093-d899d0a2c7ae.png

Fixed version:
https://user-images.githubusercontent.com/138484/142031370-72e41a35-3b3e-4662-a483-79203e357ecc.png

Before #10204 the copy filter wasn't enabled for efb copies, and most
other games don't do this type of slicing.

FIFO CI shows that a few other games are effected, it's always just a minor difference to the top line where there was previously a slight hint of garbage.
 2021-11-17 06:12:46 +13:00
JMC47 26fdc19c8d
Merge pull request #10204 from Pokechu22/efb-copy-filter 
VideoCommon: Use the copy filter for EFB copies as well as XFB copies
 2021-11-15 17:04:27 -05:00
Shawn Hoffman a69adafdd8 msbuild: use /external:anglebrackets 
Revert usage of ExternalIncludePath, as that var is specifically
for external includes which do not get scanned for changes.
 2021-11-15 00:33:51 -08:00
JosJuice da0be24b2f DSP: Reword inappropriate references to Global User Directory 
These messages apply to the User directory regardless of
whether it's global or local, so we shouldn't specify "global".

Also changing "directory" to "folder", just for consistency
with "GC folder" in the same sentence.
 2021-11-14 22:55:50 +01:00
OatmealDome 2209dc0355 MoltenVK: Use an external project instead of a pre-compiled dylib 
Also, update MoltenVK to match Vulkan SDK 1.2.189.
 2021-11-13 11:43:23 -08:00
JosJuice 3e84279919
Merge pull request #10208 from thatSteveFan/patch-1 
Minor comment fix in Matrix.cpp
 2021-11-13 15:09:28 +01:00
Pokechu22 868de78f16 VideoCommon: Use the copy filter for EFB copies as well as XFB copies 
This fixes the pink screens in EA Sports Active.  See https://gist.github.com/Pokechu22/49455f9094ed0ff017da64e3f7aa0404 for details.
 2021-11-11 17:22:50 -08:00
Shawn Hoffman 58dc9e7049 msvc: fix compile warning on arm64 2021-11-11 08:01:39 -08:00
Shawn Hoffman 4008188654 msvc: update to vs2022 and windows sdk 10.0.22000 2021-11-11 08:01:26 -08:00
thatSteveFan 834a59d89b
Minor comment fix in Matrix.cpp 
Fix comment to say (NxM times MxP).
 2021-11-08 15:30:39 -08:00
Merry 850d281cb8 Jit_Integer: Fix pure rotation rlwimix case 
We are writing to a.
 2021-11-07 14:10:19 +00:00
Mai M 6c72e6814d
Merge pull request #10169 from leoetlino/fmt-localtime 
Use fmt::localtime instead of thread-unsafe std::localtime
 2021-11-07 00:08:14 -04:00
Mai M c89226cbd4
Merge pull request #10203 from merryhime/ctx_lr 
MachineContext: Correct CTX_LR for Apple ARM64
 2021-11-07 00:06:24 -04:00
Merry c385e7e57b MachineContext: Correct CTX_LR for Apple ARM64 2021-11-06 21:46:35 +00:00
Merry 9c75957319 JitArm64_FloatingPoint: Implement fctiwx in ARM64 JIT 
We implement this by first rounding to nearest integer using the current
rouding mode, then converting this value from floating point to an integral
value.
 2021-11-06 20:54:26 +00:00
Merry 7c2b09e156 Arm64Emitter: Add FRINTI instruction 2021-11-06 19:15:26 +00:00
Léo Lam 2c5d11cace
Merge pull request #9721 from linkmauve/fix-warnings 
Fix some warnings found with gcc 11 and ffmpeg master
 2021-11-06 14:38:07 +01:00
Sintendo dfb32040bf Jit64: divwx - Micro-optimize division by 2 
Prefer using eax to isolate the sign bit. This saves a byte when the
destination ends up as r8-15, because those require a REX prefix.

Before:
41 8B C5             mov         eax,r13d
41 C1 ED 1F          shr         r13d,1Fh
44 03 E8             add         r13d,eax
41 D1 FD             sar         r13d,1

After:
41 8B C5             mov         eax,r13d
C1 E8 1F             shr         eax,1Fh
44 03 E8             add         r13d,eax
41 D1 FD             sar         r13d,1
 2021-11-03 21:01:41 +01:00
Sintendo f18f6cd0a2 Jit64: divwx - Improve comments 2021-11-02 21:50:28 +01:00
Emmanuel Gil Peyrot 5a1333026b VideoCommon: Add missing algorithm include for std::none_of 
Otherwise this is an error on gcc/libstdc++, and there are no transitive
includes for this header.
 2021-11-02 13:50:21 +01:00
Emmanuel Gil Peyrot 7590f07b80 FrameDump: Remove deprecated call to av_init_packet() 
This function was deprecated in ffmpeg in January[1], while its
replacement got introduced in 2015[2], so now might be the time to start
using it in Dolphin. :)

[1] f7db77bd87
[2] a9a6010637
 2021-11-02 13:50:21 +01:00
Emmanuel Gil Peyrot 24db6e467a DolphinQt: Fix a -Wunused-result in gcc 11 
Also use the correct error check for other similar calls in the same
file, despite nothing being doable on error.
 2021-11-02 13:50:21 +01:00
Emmanuel Gil Peyrot 25b136ac17 VideoCommon: Fix a -Wclass-memaccess in gcc 11 2021-11-02 13:50:21 +01:00
Emmanuel Gil Peyrot 7e39a0405b DolphinQt, VideoBackends: Fix all cases of -Wswitch in gcc 11 2021-11-02 13:50:21 +01:00
Emmanuel Gil Peyrot 3d662e746b Core: Fix a -Wshadow warning in gcc 11 
This moves the only direct call to zlib’s crc32() into its own
translation unit, but that operation is cold enough that this won’t
matter in the slightest.  crc32_z() would be more appropriate, but
Android has an older zlib version…
 2021-11-02 13:50:21 +01:00
Emmanuel Gil Peyrot ab252aedfa Core, DolphinQt, UICommon: Fix all cases of -Wrange-loop-construct in gcc 11 2021-11-02 13:50:21 +01:00
JosJuice 96a6d6fd95
Merge pull request #10184 from JosJuice/android-riivolution 
Android: Allow starting game with Riivolution patches from the GUI
 2021-10-31 23:44:54 +01:00
Léo Lam fb8b9f3251
Merge pull request #10194 from AdmiralCurtiss/riivolution-edge-cases 
Fix some Riivolution file patching edge cases.
 2021-10-31 21:24:03 +01:00
Sepalani e51119c4ce HLE: Fix hooks overlapping Riivolution patches 2021-11-01 00:07:14 +04:00
Admiral H. Curtiss e91e04fe1e
RiivolutionPatcher: More closely match behavior of filename searching file patches to actual Riivolution. 2021-10-31 05:47:39 +01:00
Admiral H. Curtiss 335a1b5cb5
RiivolutionPatcher: More closely match behavior of folder patches to actual Riivolution. 2021-10-31 05:47:39 +01:00
JosJuice 34021b5ebc Android: Allow starting game with Riivolution patches from the GUI 2021-10-30 23:24:36 +02:00
Pokechu22 ef80d51df1 RenderWidget: Change "imgui.h" to <imgui.h> 
This was originally intended to fix https://bugs.dolphin-emu.org/issues/12717 but this ended up not being the issue (instead it seems like files just weren't recompiled when imgui was updated due to MSVC weirdness).  Still, using brackets instead of quotes is preferable as this is a library include.
 2021-10-29 12:05:21 -07:00
Admiral H. Curtiss 5bb71760d7
Core/CheatSearchSession: Mark class as final. 2021-10-28 06:50:57 +02:00
Admiral H. Curtiss b154ba513c
Core/CheatSearchSession: Make a few methods const. 2021-10-28 02:16:19 +02:00
Admiral H. Curtiss 6e814cbb8f
Qt/CheatSearchWidget: Add a checkbox to force parsing a value as hexadecimal. 2021-10-28 02:00:38 +02:00
Admiral H. Curtiss b3e17d2772
Qt/CheatSearchFactoryWidget: Refuse to start standard memory region searches when no game is running because the memory size and console type may not be accurate. 2021-10-28 01:59:52 +02:00
Admiral H. Curtiss d6ad3fbcb5
Qt/CheatsManager: Save and restory geometry. 2021-10-28 01:03:30 +02:00
Pokechu22 db54e4f2b0 Externals: Update imgui to 1.85 2021-10-26 15:07:57 -07:00
JosJuice 05b4aecf18
Merge pull request #10186 from leoetlino/hle-hbreload 
HLE: Fix hook flag for HBReload
 2021-10-26 22:00:25 +02:00
Léo Lam 7073a90474
Merge pull request #10177 from Dentomologist/gamelist_grid_mode_fix_select_all 
GameList: Fix duplicate selections with ctrl+a in grid view
 2021-10-25 17:22:58 +02:00
Léo Lam 8cb51f276c HLE: Fix hook flag for HBReload 
The reload stub is at a fixed address (0x80001800) so its hook flag
should be HookFlag::Fixed.

Otherwise the hook is installed by HLE::PatchFixedFunctions but
immediately removed by HLE::PatchFunctions (which is called by
HLE::Reload right after PatchFixedFunctions).

Should fix https://bugs.dolphin-emu.org/issues/12716
 2021-10-25 16:54:25 +02:00
Pokechu22 04d8cdfe88 Convert LOG_TYPE and LOG_LEVELS to enum class 2021-10-24 11:48:36 -07:00
Pokechu22 ba107819ec Create EnumMap 2021-10-24 11:48:36 -07:00
Admiral H. Curtiss 4f82810845
RiivolutionPatcher: Use FileInfo instead of IOFile when only checking for filesize. 2021-10-24 00:09:09 +02:00
Admiral H. Curtiss 0efff5167d
IOS/FS: On NAND redirected files, the source and target of a Rename operation may be on different partitions or devices. Implement a fallback for that. 2021-10-24 00:09:09 +02:00
Admiral H. Curtiss fe7f3a6f26
RiivolutionPatcher: Protect against three or more dots in path traversal. 2021-10-24 00:09:09 +02:00
Admiral H. Curtiss 22c6f2fe3b
RiivolutionPatcher: Handle the possibility of the FST already containing a main.dol file. 2021-10-24 00:09:09 +02:00
Admiral H. Curtiss ba3373b476
RiivolutionPatcher: Modify memory patching logic to be more accurate to actual Riivolution. 2021-10-24 00:09:09 +02:00
Admiral H. Curtiss dd64c0e423
Core: Deduplicate Riivolution Patch to BootParameters apply logic. 2021-10-24 00:09:08 +02:00
Admiral H. Curtiss a76fdeee93
DolphinQt: Act like Riivolution and pre-select the last selected patch options when launching via the RiivolutionBootWidget. 2021-10-24 00:09:08 +02:00
Admiral H. Curtiss 2be62d94fc
RiivolutionParser: Add code to read and write the Riivolution config XMLs that remember the last selection. 2021-10-24 00:09:08 +02:00
Admiral H. Curtiss 2d3ed2c3ad
DolphinQt: Add ability to edit the Riivolution XML root directory when launching a patch. 2021-10-24 00:09:08 +02:00
Admiral H. Curtiss d0c11f76b5
Core/BootManager: Disable loading time emulation for Riivolution-patched games until we have proper emulation for that. 2021-10-24 00:09:07 +02:00
Admiral H. Curtiss 6394960f54
Core: Add ability to specify and launch a riivolution-modded game via a .json file. 2021-10-24 00:09:07 +02:00
Admiral H. Curtiss fe242f79ee
Core: Implement Wii NAND path redirects for Riivolution savegame patches. 2021-10-24 00:09:07 +02:00
Admiral H. Curtiss 588c31acb6
RiivolutionPatcher: Ignore last two bits of offset in file patches to match console behavior. 2021-10-24 00:09:07 +02:00
Admiral H. Curtiss 6ec4af7ea4
RiivolutionPatcher: Load external files with a layer of indirection during the patching process to properly resolve the paths given in the XML. 
This also may eventually allow loading patches from sources other than the 1:1 expected file structure host file system, such as memory or an archive file.
 2021-10-24 00:09:07 +02:00
Admiral H. Curtiss 175f225ac1
DolphinQt: Add ability to start a game with Riivolution patches from the GUI. 2021-10-24 00:09:06 +02:00
Admiral H. Curtiss 783b180dc8
Core: Add RiivolutionPatcher to apply Riivolution-style patches to a game's file system and memory. 2021-10-24 00:09:06 +02:00
Admiral H. Curtiss e26b59bab3
Core: Add RiivolutionParser to parse a Riivolution XML. 2021-10-24 00:09:06 +02:00
Admiral H. Curtiss a4da56e5e6
CommonPaths: Add a Riivolution subfolder in Load. 2021-10-24 00:09:06 +02:00
Admiral H. Curtiss 09fc39e2e5
DiscIO: Add CreateDisc/WAD/Volume() overloads that take a BlobReader directly. 2021-10-24 00:09:05 +02:00
Admiral H. Curtiss e3f1de023f
DiscIO/DirectoryBlob: Add a callback that allows patching the main.dol and FST of the game partition during blob construction. 2021-10-24 00:09:05 +02:00
Admiral H. Curtiss 00ef9f2b4f
DiscIO/DirectoryBlob: Allow constructing a DirectoryBlobReader from a VolumeDisc. 2021-10-24 00:09:05 +02:00
Admiral H. Curtiss 3a72a39efd
DiscIO/DirectoryBlob: Allow constructing a DirectoryBlobPartition from a VolumeDisc. 2021-10-24 00:09:00 +02:00
Admiral H. Curtiss b1802f6daa
DiscIO/DirectoryBlob: Add a content source representing a run of padding bytes. 2021-10-23 23:51:23 +02:00
Admiral H. Curtiss f8611f7139
DiscIO/DirectoryBlob: Add a content source that reads data from a DiscIO::Volume. 2021-10-23 16:51:45 +02:00
Admiral H. Curtiss b7a9cc37b1
DiscIO/DirectoryBlob: Add ability to have an offset for a partition ContentSource. 2021-10-23 16:51:45 +02:00
Admiral H. Curtiss a14436fe3f
DiscIO/DirectoryBlob: Add ability to have a start-of-file offset for a file ContentSource. 2021-10-23 16:51:45 +02:00
Admiral H. Curtiss 885e6690c5
DiscIO/DirectoryBlob: Add explanations for DiscContent members. 2021-10-23 16:51:44 +02:00
Admiral H. Curtiss b988ab4441
DiscIO/DirectoryBlob: Consolidate functions that take data for ContentSource to just take a ContentSource. 2021-10-23 16:51:44 +02:00
Admiral H. Curtiss 7f57c24172
DiscIO/DirectoryBlob: Rename the vector-reference variant of DiscContentContainer::Add() to AddReference() to make it clearer at call sites that the given vector must remain in memory. 2021-10-23 16:51:44 +02:00
Scott Mansell b997048cfe
Merge pull request #10142 from aldelaro5/gdb-stub-rework 
Rework the entire logic of the GDB stub
 2021-10-24 01:51:29 +13:00
Admiral H. Curtiss f972ddf32f
Common/FileUtil: Fix incorrect (32-bit) stat struct being used on Windows, which was hidden by a define in CommonFuncs.h. 2021-10-23 03:50:47 +02:00
aldelaro5 6a4d607e09 GDBStub: Add log when break is sent 2021-10-21 08:26:50 -04:00
aldelaro5 7ad586fe2c GDBStub: Make step force pausing even if play was pressed 2021-10-21 08:26:50 -04:00
aldelaro5 2f7a3e59e5 GDBStub: upgrade some logs from debug to info 2021-10-21 08:26:50 -04:00
aldelaro5 1b92f81379 GDBStub: Refactor the whole code 2021-10-21 08:26:50 -04:00
aldelaro5 94a0f416eb GDBStub: remove the cmake option and the ifdefs 2021-10-21 08:26:42 -04:00
aldelaro5 657bb00c01 GDBStub: Cleanly shut down on stop 2021-10-21 08:26:42 -04:00
aldelaro5 b8395280d3 GDBStub: Correctly inform the CPU thread if we are stepping 2021-10-21 08:26:28 -04:00
aldelaro5 b9b7c4ac80 GDBStub: Add support for the T command 2021-10-21 08:26:28 -04:00