ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
28,128 Commits 5 Branches 11 Tags 1.3 GiB
Commit Graph

24251 Commits

Author SHA1 Message Date
Léo Lam 76b031184c
Merge pull request #6341 from sepalani/debug-watches 
DebugInterface: Watches methods added
 2018-05-06 13:25:26 +02:00
Léo Lam 7a9e1a240e
Merge pull request #6757 from JosJuice/qt-filesystem-extraction 
DolphinQt2: Fix disc extraction inconsistencies with DolphinWX
 2018-05-06 13:24:06 +02:00
Léo Lam 32235f974d
Merge pull request #6612 from leoetlino/movie-array 
Movie: Replace some C style arrays with std::array
 2018-05-06 13:23:45 +02:00
Léo Lam 34899e8e71
Merge pull request #6759 from spycrab/updater_warn_launch 
Updater: Show error when trying to launch directly
 2018-05-06 13:11:50 +02:00
Léo Lam 3f087e2ed5
Merge pull request #6760 from lioncash/msr 
PowerPC: Make the PowerPCState's msr member variable a UReg_MSR instance
 2018-05-06 12:02:39 +02:00
Léo Lam 27f6274fc5
Merge pull request #6762 from lioncash/condition 
DolphinQt/MemoryWidget: Fix dead condition in FindValue()
 2018-05-06 12:01:24 +02:00
Stenzek f81d9c3813
Merge pull request #6755 from stenzek/opengl-clamp 
OGL: Fix incorrect clamping in EFB copies
 2018-05-06 18:54:00 +10:00
spycrab 6f65238efc Qt: Fix "Render To Main" 2018-05-06 04:51:13 +02:00
Anthony 2588b5e40e
Merge pull request #6750 from spycrab/qt_render_widget 
Qt: Fix multiple RenderWidget issues
 2018-05-05 18:39:40 -07:00
spycrab 6442b32aeb Qt/AdvancedWidget: Fix "Enable Progressive Scan" 2018-05-06 03:16:43 +02:00
Lioncash 31389bab0a DolphinQt/MemoryWidget: Fix dead condition in FindValue() 
This condition is already checked earlier in the function and exits out
if it's satisfied, meaning it'll never reach this check further down.
 2018-05-05 20:44:38 -04:00
spycrab 49a1b2e5df Qt/Win32: Use better method to obtain the default font 2018-05-06 02:37:52 +02:00
Lioncash 0043b77ccd Gekko: Make UReg_MSR's single-argument constructor explicit 
Prevents implicit construction of MSR instances from integral values.
This is beneficial, considering MSR values have an intended
representation while a regular magic value doesn't. So make these
conversions required to be explicit.
 2018-05-05 17:59:45 -04:00
Lioncash ffcf107dd2 PowerPC: Make the PowerPCState's msr member variable a UReg_MSR instance 
Gets rid of the need to construct UReg_MSR values around the the actual
member in order to query information from it (without using shifts and
masks). This makes it more concise in some areas, while helping with
readability in some other places (such as copying the ILE bit to the LE
bit in the exception checking functions).
 2018-05-05 17:59:30 -04:00
Léo Lam 75d056bc48 Movie: Replace some C style arrays with std::array 
This replaces some C style arrays with std::array to make copying
and comparing arrays slightly nicer.
 2018-05-05 23:40:23 +02:00
spycrab 45995ead03 Updater: Show error when trying to launch directly 2018-05-05 23:32:08 +02:00
Léo Lam 72a6674b73 WiiUtils: Migrate to new filesystem interface 
A followup for the migration work started in 8317a66e
 2018-05-05 19:21:56 +02:00
Léo Lam 9aeb95bc0a WX: Only call IsTitleInstalled when core is stopped 2018-05-05 19:21:56 +02:00
JosJuice 33211d8690 DolphinQt2: Don't show pop-ups in the middle of extracting a whole disc 2018-05-05 18:31:46 +02:00
JosJuice f48fac5b55 DolphinQt2: Allow picking "Extract Files..." on disc/partition 
DolphinWX already does this.
 2018-05-05 18:31:44 +02:00
Léo Lam 58b96eeb9d
Merge pull request #6756 from spycrab/qt_segoe_ui 
Qt/Win32: Force Segoe UI
 2018-05-05 18:09:00 +02:00
spycrab 7d762fd632 Qt/RenderWidget: Restore size when exiting fullscreen 2018-05-05 17:05:32 +02:00
JosJuice 1a74de6462 DolphinQt2: Fix the file structure of extracted discs 
Now all the partitions won't be all jumbled up in one folder,
and the filesystem contents won't be mixed with system data.
 2018-05-05 17:00:27 +02:00
Léo Lam 975689e1f7
Merge pull request #6754 from spycrab/qt_no_whatsthis 
Qt: Remove "What's this" button
 2018-05-05 16:04:52 +02:00
Tillmann Karras 41a553e33e Jit64: warn about code cache flushing 
The game Go Vacation (SGVEAF) currently stutters a lot because it keeps
overflowing the far code cache and all code needs to be re-jitted.
Logging this warning gives a useful hint as to what is causing the
stuttering.
 2018-05-05 14:21:57 +01:00
spycrab ad21282379 Qt/Win32: Force Segoe UI 2018-05-05 12:41:56 +02:00
Léo Lam 31efec623a
Merge pull request #6695 from Ebola16/UbershadersDecrip 
Update Ubershader descriptions
 2018-05-05 11:16:30 +02:00
Léo Lam d8549d172c
Merge pull request #6651 from leoetlino/nand-paths 
NandPaths: Return paths that are relative to Wii NAND
 2018-05-05 11:01:35 +02:00
Léo Lam 983d500d14
Merge pull request #6614 from leoetlino/auto-close 
IOS: Do not manually close devices in destructor
 2018-05-05 10:53:06 +02:00
Léo Lam d848c7e027
Merge pull request #6716 from container1234/qt-cheats-manager 
Qt/CheatsManager: Fix updating search result takes a long time
 2018-05-05 10:42:09 +02:00
Léo Lam bf8b9f4a34
Merge pull request #6739 from spycrab/qt_aesthetics 
Qt: Fix visual inconsistencies.
 2018-05-05 10:37:44 +02:00
Léo Lam 86f56b8047
Merge pull request #6747 from aldelaro5/qt-debugger-setting-ini 
INI: Create a new INI setting for toggling the debugger UI
 2018-05-05 10:33:04 +02:00
Léo Lam 6e6bf689e7
Merge pull request #6751 from spycrab/qt_show_disc 
Qt: Show disc number
 2018-05-05 10:28:40 +02:00
Stenzek 286d594f32 OGL: Fix incorrect clamping in EFB copies 2018-05-05 17:45:54 +10:00
Pierre Bourdon 798639291f
Merge pull request #6749 from spycrab/qt_gcontrols_crash 
Qt/GraphicsControls: Fix more random crashes
 2018-05-05 03:02:43 +02:00
spycrab 69d6c0dccb Qt: Remove "What's this" button 2018-05-05 02:29:16 +02:00
aldelaro5 fee92cd4fc
INI: Create a new INI setting for toggling the debugger UI 
Qt introduced a checkbox to toggle the debugger UI, this makes it work into a setting stored in the INI, it also makes the -d argument only in effect when enabled, in such case, it will override the INI by overriding it.
 2018-05-04 19:23:03 -04:00
spycrab db0e5108dc Win32/FileUtil: Fix IsDirectory() not working for certain directories 2018-05-04 23:53:41 +02:00
spycrab 67f874250a Qt: Show disc number 2018-05-04 22:38:27 +02:00
spycrab e809eef11a Qt/AdvancedWidget: Fix progressive scan checkbox 2018-05-04 21:33:24 +02:00
Léo Lam 8317a66ea5 NandPaths: Return paths that are relative to Wii NAND 
Since all FS access will go through the new FS interface (PR #6421)
in order to keep track of metadata properly, there is no need to return
absolute paths anymore.

In fact, returning host paths is a roadblock to using the FS interface.

This starts the migration work by adding a way to get paths that are
relative to the Wii NAND instead of always getting absolute paths
on the host FS.

To prepare for future changes, this commit also makes returned paths
canonical by removing the trailing slash when it's unneeded.

Eventually, once everything has been migrated to the new interface,
we can remove the "from" parameter.
 2018-05-04 19:52:17 +02:00
spycrab 452cc6b69f Qt/RenderWidget: Show proper icon and title 2018-05-04 14:04:46 +02:00
spycrab 300c3970f3 Qt/GraphicsControls: Fix more random crashes 2018-05-04 13:51:55 +02:00
spycrab 11f83c1e36 HttpRequest/Curl: Use a more intelligent timeout method 2018-05-04 13:30:49 +02:00
Stenzek a5e410b7c9
Merge pull request #6744 from stenzek/ui-disable-vram-copies 
UI: Add Disable EFB Copies to VRAM to Advanced Options
 2018-05-04 12:01:29 +10:00
spycrab 96e488a181 Qt/PathPane: Add dots to buttons 2018-05-04 00:12:08 +02:00
spycrab d97d916758 Qt/Settings: Restore padding 2018-05-04 00:12:08 +02:00
spycrab b741ef81bd Qt/WrapInScrollArea: Make background color more consistent 2018-05-04 00:12:08 +02:00
Mat M 54a6b0f50a
Merge pull request #6726 from spycrab/qt_sort_alpha 
Qt/GameList: Always sort games alphabetically
 2018-05-03 13:13:09 -04:00
Mat M 348125eda4
Merge pull request #6738 from spycrab/qt_fix_empty_adapter 
Qt/GeneralWidget: Fix empty adapter option
 2018-05-03 13:11:00 -04:00
Mat M 689a70a7f1
Merge pull request #6736 from spycrab/qt_bad_range_clear 
Qt/MappingButton: Fix bad range default
 2018-05-03 13:09:26 -04:00
Mat M cf40ebf16a
Merge pull request #6737 from JosJuice/qt-invalid-si-device 
DolphinQt2: Don't crash on invalid SI devices
 2018-05-03 13:07:23 -04:00
Stenzek 3270fadb0d
Merge pull request #6587 from stenzek/macos-content-scale 
DolphinWX: Scale window geometry before passing to backend
 2018-05-03 23:35:21 +10:00
Stenzek be32602769
Merge pull request #6745 from spycrab/qt_fullscreen 
Qt: Call Render::SetFullscreen
 2018-05-03 23:28:21 +10:00
spycrab a61445919d Qt/GraphicsSlider: Fix random crashes 2018-05-03 15:22:40 +02:00
spycrab 68e2b46ba1 Qt: Call Render::SetFullscreen 2018-05-03 15:15:35 +02:00
Stenzek 210a6a37b4 DolphinWX: Scale window geometry before passing to backend 
In macOS, the window size is device-independent points, which may not
match the content/backing framebuffer size.
 2018-05-03 22:01:07 +10:00
Markus Wick 467379c149
Merge pull request #6740 from lucasassislar/master 
Fixed aspect ratio bigger than 16:9 on Android Devices
 2018-05-03 09:01:19 +02:00
JosJuice 1a2b6e2645
Merge pull request #6742 from stenzek/qt-borderless-fullscreen 
Qt/AdvancedWidget: Fix borderless fullscreen option not showing
 2018-05-03 08:07:29 +02:00
Stenzek d4f6c86eec UI: Add Disable EFB Copies to VRAM to Advanced Options 2018-05-03 14:31:04 +10:00
Stenzek 0152f63655 TextureCacheBase: Make "disable vram copies" part of the active config 2018-05-03 14:24:44 +10:00
Stenzek 8a061d6fb4 Qt/AdvancedWidget: Fix borderless fullscreen option not showing 2018-05-03 14:13:35 +10:00
Stenzek 4faac3a627 TextureConversionShader: Don't sample from adjacent rows when not needed 2018-05-03 14:09:32 +10:00
Stenzek a93830056f TextureConversionShader: Fix more implicit conversion errors 2018-05-03 11:32:06 +10:00
Distro Lucas dbeec37b0f Fixed aspect ratio bigger than 16:9 on Android Devices 2018-05-02 22:21:28 -03:00
spycrab 6b5b51831a Qt/GameList: Always sort games alphabetically 2018-05-02 21:57:46 +02:00
spycrab 0595fd498f Qt/MappingButton: Fix bad range default 2018-05-02 21:50:50 +02:00
Markus Wick ef98a21735
Merge pull request #6729 from stenzek/gles-gamma 
TextureConversionShader: Fix compile errors in OpenGL ES
 2018-05-02 21:50:30 +02:00
JosJuice 16b805410f DolphinQt2: Don't crash on invalid SI devices 
This is important if we ever add or delete SI devices.
 2018-05-02 21:50:28 +02:00
Mat M ed6709ac8f
Merge pull request #6731 from spycrab/qt_cache_slider 
Qt/HacksWidget: Fix "Accuracy" slider
 2018-05-02 15:48:33 -04:00
Mat M a2c12f1503
Merge pull request #6735 from JosJuice/ui-ini 
Remove code related to UI.ini
 2018-05-02 15:47:28 -04:00
spycrab b99610f1a3 Qt/GeneralWidget: Fix empty adapter option 2018-05-02 19:20:45 +02:00
JosJuice 6e96f62b41 Remove code related to UI.ini 
We don't use it for anything, we just create it and leave it empty.
 2018-05-02 18:18:27 +02:00
spycrab 3221ca2200 Updater: Fix UI not showing up 2018-05-02 18:17:16 +02:00
Pierre Bourdon 40cf07d8e7
Merge pull request #6733 from spycrab/rename_update_cfg_again 
Core/ConfigManager: Rename Track to UpdateTrack
 2018-05-02 17:55:37 +02:00
spycrab a984d18a14 Core/ConfigManager: Rename Track to UpdateTrack 2018-05-02 17:23:41 +02:00
spycrab e3cebebe51 Qt/MappingButton: Fix Clear not resetting ranges 2018-05-02 17:02:14 +02:00
spycrab 3d7b613be5 Qt/Mapping: Fix "Default" not working properly. 2018-05-02 16:55:42 +02:00
spycrab ef3f660983 Qt/HacksWidget: Fix "Accuracy" slider 2018-05-02 16:36:15 +02:00
Stenzek 7a745e5b0d D3D: Drop gamma parameter from util draw helper 
No longer needed as we perform gamma correction during the XFB copy.
 2018-05-02 21:58:56 +10:00
Stenzek 2c6b20bb03 TextureConversionShader: Fix compile errors in OpenGL ES 2018-05-02 21:54:13 +10:00
spycrab 0d5b34be34 Qt/MappingWindow: Fix saving to incomplete Profile directory 2018-05-02 06:45:11 +02:00
Ryan Meredith 05205ce3d7 Update Ubershader descriptions 2018-05-01 18:57:34 -04:00
spycrab b4dc658b2e OGL/FramebufferManager: Clean up inline GLSL code 2018-05-01 15:03:59 +02:00
Stenzek 6e62d1ab9f
Merge pull request #6722 from spycrab/qt_adapter 
Qt/GraphicsSettings: Save Adapter index
 2018-05-01 21:57:50 +10:00
spycrab 87d6bffcec Qt/GraphicsSettings: Fix various adapter issues 2018-05-01 13:54:01 +02:00
container1234 850afd8457 Qt/CheatsManager: Fix updating search result takes a long time 2018-05-01 18:58:58 +09:00
Léo Lam 78c9bad44f
Merge pull request #6688 from spycrab/qt_dedup 
Qt: Deduplicate settings
 2018-05-01 11:53:39 +02:00
Léo Lam 23f958d766
Merge pull request #6715 from spycrab/qt_path_fixes 
Qt/PathPane: Various fixes
 2018-05-01 11:40:21 +02:00
Stenzek c46882142b
Merge pull request #6369 from stenzek/xfb-copy-filter 
Implement copy filter (deflickering/brightness) and XFB gamma
 2018-05-01 19:31:54 +10:00
Stenzek 42d73deaed
Merge pull request #6723 from spycrab/qt_fix_profile_save 
Qt/MappingWindow: Fix profile saving
 2018-05-01 19:26:22 +10:00
Léo Lam c2ddddc723
Merge pull request #6724 from JosJuice/qt-normal-speed 
DolphinQt2: Translate the "(Normal Speed)" text
 2018-04-30 21:30:45 +02:00
JosJuice 1b830df250 DolphinQt2: Correct the condition for enabling Cheat Manager 
Only the other condition, the one that runs when the cheat setting
changes, was taking into account whether emulation was running.
 2018-04-30 14:19:56 +02:00
JosJuice e74f5c4f42 DolphinQt2: Translate the "(Normal Speed)" text 2018-04-30 13:42:48 +02:00
spycrab c6a0a4318d Qt/MappingWindow: Fix saving 2018-04-30 09:09:27 +02:00
spycrab fcb80646ed Qt/PathPane: Various fixes 2018-04-30 06:44:13 +02:00
Mat M ad836b9071
Merge pull request #6717 from spycrab/issue_11039 
Qt/GraphicsControls: Reload values when settings are changed
 2018-04-29 20:20:36 -04:00
spycrab a2dbf97205 Qt/Win32: Fix console output 2018-04-29 23:26:20 +02:00
Mat M d8b56af342
Merge pull request #6714 from spycrab/qt_fix_toolbar 
Qt/ToolBar: Fix inconsistencies
 2018-04-29 15:20:01 -04:00
spycrab dd6ac93ad0 Qt/ToolBar: Fix checkbox and actual visibility not being in sync 2018-04-29 20:28:11 +02:00
Mat M cad7d2c71f
Merge pull request #6720 from spycrab/qt_ext 
Qt/GameTracker: Match uppercase file extensions
 2018-04-29 14:24:24 -04:00
spycrab f5cfd1ab14 Qt/GameTracker: Match uppercase file extensions 2018-04-29 19:59:50 +02:00
spycrab 2a837a82d4 Qt: Implement Batch flag (-b) 2018-04-29 19:13:40 +02:00
spycrab bc51c34a96 Qt: Implement "Free look" 2018-04-29 13:52:27 +02:00
spycrab 417d191c9e Qt/GraphicsControls: Reload values when settings are changed 2018-04-29 12:17:39 +02:00
Stenzek ea4090d92c Dolphin: Add disable copy filter to graphics options 2018-04-29 19:05:20 +10:00
Stenzek 9e798eec94 Implement EFB copy filter and gamma in hardware backends 
Also makes y_scale a dynamic parameter for EFB copies, as it doesn't
make sense to keep it as part of the uid, otherwise we're generating
redundant shaders.
 2018-04-29 19:05:20 +10:00
Scott Mansell a192a3bb30 While I'm here, fix some chroma sub-sampling bugs. 
RE4's brightness screen is actually very good for spotting these.

Bug 1: Colors at the end of the scanlines are clamped, instead of a black
       border
Bug 2: U and V color channels share coordinates, instead of being offset
       by a pixel.
 2018-04-29 17:56:53 +10:00
Scott Mansell fc96479f12 VideoSoftware: Implement xfb copy filter (Deflickering/Brightness) 2018-04-29 17:56:51 +10:00
Lioncash 167b92ff2c Jit_Integer: Make arrays const in MultiplyImmediate() and twX() 
These are only ever read from, so make the data immutable to be explicit about that
 2018-04-28 14:13:02 -04:00
Mat M 0cd46f4d21
Merge pull request #6690 from lioncash/nand 
Common/NandPaths: Minor cleanup
 2018-04-28 13:43:33 -04:00
Mat M 6b8da197e8
Merge pull request #6689 from container1234/qt-minor-fixes 
Qt: Minor changes
 2018-04-28 13:41:59 -04:00
Tilka 6bb880457f
Merge pull request #6711 from lioncash/handler 
Common/MemTools: Make handler function internally linked on Windows
 2018-04-28 18:41:10 +01:00
Mat M c057eb3c82
Merge pull request #6705 from leoetlino/variable 
IOS/SO: Clean up variable declarations
 2018-04-28 13:40:38 -04:00
Mat M fa44e28ce0
Merge pull request #6708 from spycrab/qt_dynfilter 
Qt/GameList: Ensure resort when new entries are added
 2018-04-28 13:39:56 -04:00
Lioncash 8183360832 Common/MemTools: Make handler function internally linked on Windows 
This doesn't need to be an externally linked function.
 2018-04-28 12:55:38 -04:00
Sepalani 74d4a4478f DebugInterface: Watches methods added 
Move Watches to Common
 2018-04-28 17:46:51 +04:00
JosJuice 8870ffeac4 DolphinQt2: Fix clearing numeric values in controller config 2018-04-28 13:02:26 +02:00
spycrab 7db86c20d0 Qt/GameList: Ensure resort when new entries are added 2018-04-28 12:53:10 +02:00
JosJuice 28138cfde9
Merge pull request #6707 from spycrab/qt_fix_numeric 
Qt/MappingNumeric: Calculate values properly
 2018-04-28 12:42:27 +02:00
spycrab 1fb188a7d9 Qt/MappingNumeric: Calculate values properly 2018-04-28 12:32:23 +02:00
spycrab b88a5875ec Qt/WiimoteEmuExtension: Add "Slider Bar" to Guitar 2018-04-28 11:41:22 +02:00
Léo Lam 4f427de924 IOS/SO: Clean up variable declarations 
Move them closer to their usage and fix the naming.
 2018-04-28 11:13:03 +02:00
container1234 b46bf9b736 Qt/Debugger: Change CodeView background colors to bright ones 2018-04-28 16:53:04 +09:00
Léo Lam cf1adfbe20
Merge pull request #6673 from leoetlino/network 
IOS: Network fixes
 2018-04-28 00:47:18 +02:00
Léo Lam 9c63bae19a
Merge pull request #6687 from spycrab/qt_graphics_caps 
Qt/GraphicsWindow: Disable unsupported options
 2018-04-28 00:35:47 +02:00
spycrab 4caca2bd7a Qt/GraphicsWindow: Disable unsupported options 2018-04-28 00:01:26 +02:00
Léo Lam 3b70da2da4
Merge pull request #6693 from spycrab/qt_missing_paths 
Qt/PathPane: Add missing options
 2018-04-27 23:49:13 +02:00
Léo Lam 393663a0a3 IOS/SO: Use an enum for result codes 2018-04-27 23:35:40 +02:00
Léo Lam 32d51f1699 IOS/SO: Re-implement GetInterfaceOpt(0x4003) 
Use the newly added GetSystemDefaultInterfaceOrFallback() to return
actual information for the default interface, not just dummy
interface details.

This also fixes GetInterfaceOpt(0x4003) and gethostid() returning
inconsistent information. Prior to this change, GetInterfaceOpt(0x4003)
would return 10.0.1.30 and gethostid would give a totally unrelated IP.
 2018-04-27 23:35:40 +02:00
Léo Lam 3ce271991b IOS/SO: Implement GetSystemDefaultInterface for non-Windows 
This fixes gethostid on non-Windows platforms.

Except on Android, where this is left unimplemented because Android
does not support getifaddrs.
 2018-04-27 23:35:40 +02:00
Léo Lam 25b198cac8 IOS/SO: Move default interface code into a separate function 
...so that the function can be more easily reused.
 2018-04-27 23:35:40 +02:00
Léo Lam e4276f2983 IOS/SO: Handle invalid GetInterfaceOpt requests 2018-04-27 23:35:40 +02:00
spycrab 9057a7d50a Qt/GeckoCode: Fix multiple bugs 2018-04-27 22:58:57 +02:00
Anthony 2b9df8eedd
Merge pull request #6697 from spycrab/qt_sort 
Qt/GameList: Sort by title by default
 2018-04-27 19:30:48 +01:00
spycrab eefa6db57c Qt: Fix "Render To Main" not booting into fullscreen 2018-04-27 15:04:26 +02:00
Sepalani e73906ee38 DolphinWx: Prevent a crash on Copy hex 2018-04-27 09:53:11 +04:00
spycrab 7749e18ecc ConfigManager: Enable Auto-Updater by default 2018-04-26 15:12:15 +02:00
spycrab ddcc3451b1 Qt/GameList: Sort by title by default 2018-04-26 11:50:18 +02:00
Pierre Bourdon 1b389398ad
Merge pull request #6696 from spycrab/updater_cpy 
Updater: Use copy instead of move
 2018-04-26 11:10:52 +02:00
spycrab fb268bb04f Updater: Use copy instead of move 2018-04-26 11:00:03 +02:00
spycrab 6e4c5d780d Updater: Implement UAC support 2018-04-25 22:38:10 +02:00
spycrab 82390495ee Qt/PathPane: Add missing options 2018-04-25 21:43:12 +02:00
Lioncash 4637579375 Common: Amend CommonTypes include within BitSet.h 
We do includes relative to the root, rather than direct pathing.
 2018-04-23 00:14:00 -04:00
Lioncash d68f437e67 Common: Move BitSet helper functions into the Common namespace 2018-04-23 00:13:55 -04:00
Lioncash c1c360d9b1 NandPaths: Make function parameters consistent 
Also drops trailing underscores from said parameter names.
 2018-04-22 23:49:20 -04:00
Lioncash 62242331d8 NandPaths: Remove unused header inclusions 2018-04-22 23:49:16 -04:00
Lioncash 2ce0f42c14 Common: Move BitSet into the Common namespace 
This should be under the common namespace, considering where it's living
 2018-04-22 23:43:07 -04:00
spycrab 40a61e7bf5 Qt: Deduplicate settings 2018-04-22 22:26:28 +02:00
container1234 41844c1cc5 Qt/Debugger: Change the row height to same as code/memory widget 2018-04-23 00:52:31 +09:00
container1234 32f6d3f62b Qt: Use HostRead for float and double 2018-04-23 00:46:42 +09:00
Pierre Bourdon 1b63810e85
Merge pull request #6684 from spycrab/qt_wrong_thread 
Qt/Settings: Emit EmulationStateChanged from the UI thread
 2018-04-22 15:36:32 +02:00
spycrab 854fa0f093 Qt/Settings: Emit EmulationStateChanged from the UI thread 2018-04-22 13:04:48 +02:00
spycrab 519fa7529f Qt/RenderWidget: Fix the render widget showing up when it shouldn't 2018-04-22 13:01:18 +02:00
spycrab caa18edc79 Qt: Implement "Keep Window on top" 2018-04-22 11:15:39 +02:00
spycrab c1dccdc0e5 Qt/RenderWidget: Fix getting painted over 2018-04-22 10:15:09 +02:00
spycrab b059b3a646 Qt: Pause on focus loss 2018-04-22 10:15:09 +02:00
Tilka c131b7c3b4
Merge pull request #6682 from spycrab/qt_minor_fixes 
Qt: Minor fixes
 2018-04-22 08:12:42 +01:00
aldelaro5 2f6879f0d9
Qt/log change the notice log color to lime 
It's slightly easier to read than green
 2018-04-21 21:22:16 -04:00
spycrab 7b35c8577a Qt: Fix crashes when closing render window 2018-04-21 23:27:54 +02:00
spycrab b2e5f1d85f Qt/GeneralPane: Disable certain options while emulation is running 2018-04-21 22:09:46 +02:00
Léo Lam 9dcc8131df
Merge pull request #6331 from spycrab/deprecate_wx 
[RFC] Qt/Wx: Turn Qt into the default interface
 2018-04-21 18:36:10 +02:00
spycrab 694df74b0b Qt/Wx: Turn Qt into the default interface 2018-04-21 17:54:00 +02:00
Tilka 7dc16efc9d
Merge pull request #6675 from spycrab/qt_recursive 
Qt: Add "Search subdirectories" checkbox
 2018-04-21 16:07:02 +01:00
spycrab a4526772b9 Qt: Add "Search subdirectories" checkbox 2018-04-21 00:14:55 +02:00
Léo Lam dabfecfd74
Merge pull request #6672 from spycrab/qt_dynamic 
Qt: Make toolbar more dynamic
 2018-04-20 23:41:51 +02:00
spycrab 264c995b0d Qt: Make toolbar more dynamic 2018-04-20 22:44:49 +02:00
Léo Lam 2fcc633c28
Merge pull request #6649 from leoetlino/fs-tests 
UnitTests: Add tests for the Wii filesystem
 2018-04-20 21:34:06 +02:00
Tilka 4c8de9638a
Merge pull request #6674 from Tilka/jit64 
Jit64: avoid an unnecessary load
 2018-04-20 19:23:28 +01:00
Léo Lam bc7bf97f14
Merge pull request #6666 from Ebola16/ASU2 
Update Android Gradle Plugin
 2018-04-20 18:18:22 +02:00
Léo Lam f9340424c8
Merge pull request #6669 from lioncash/thread-local 
Core: Use thread_local directly
 2018-04-20 18:11:32 +02:00
Léo Lam 1176ae6512 IOS/FS: Fix ReadDirectory file list copying 
Each entry can take up to 13 bytes (including the terminating null
character) but should not be aligned to 13 bytes.
 2018-04-20 00:02:32 +02:00
Léo Lam 4c47417a0e IOS/FS: Fix ReadDir returning wrong number of entries 
ReadDir should always write the actual number of entries in the
directory list (`min(max_count, number_of_entries_on_nand)`).
 2018-04-20 00:02:32 +02:00
Connor Roth 3e4725f390 THis fixes issue #08 and #16, the rumble test and slider 2018-04-19 17:48:55 -04:00
Tilka a500347345
Merge pull request #6676 from spycrab/qt_fix_open 
Qt: Fix "Open File" dialog opening twice
 2018-04-19 22:13:38 +01:00
spycrab cd390714c9 Qt: Fix "Open File" dialog opening twice 2018-04-19 23:10:23 +02:00
Tillmann Karras 1737f1bee8 Jit64: avoid an unnecessary load 2018-04-19 21:49:12 +01:00
spycrab c09075209f Qt: Implement Cheats Manager 2018-04-19 10:42:24 +02:00
Léo Lam 396204248d
Merge pull request #6667 from lioncash/si 
SI: Remove unnecessary declarations of internally linked functions
 2018-04-18 18:49:44 +02:00
Lioncash e6405f7b2b
Core: Use thread_local directly 
Both Android and OSX now support it, allowing us to remove the fallback code.
 2018-04-17 19:03:24 -04:00
Mat M df44aa7335
Merge pull request #6668 from JosJuice/remove-hybrid-wiimote 
Remove Hybrid Wii Remote
 2018-04-17 18:09:58 -04:00
Ryan Meredith b00c29b70d Update Android Gradle Plugin 2018-04-17 16:54:14 -04:00
JosJuice 2953cf201d Remove Hybrid Wii Remote 
It simply doesn't seem to work for anything useful, and nobody seems
to care about maintaining it.
 2018-04-17 22:40:21 +02:00
Lioncash d1d8300a46
SI: Remove unnecessary declarations of internally linked functions 
These aren't dependent on calling order so we can just organize all of the statics together
instead of splitting them up over the file. This also allows us to organize a common spot for
file static variables as well.
 2018-04-17 16:33:11 -04:00
Mat M d230194464
Merge pull request #6657 from leoetlino/dedup 
Qt/Debugger: Deduplicate memory view update code
 2018-04-17 10:21:53 -04:00
Mat M b19d77a3ff
Merge pull request #6660 from leoetlino/pause 
Qt/Debugger: Don't pause when already paused
 2018-04-17 10:20:30 -04:00
Mat M e04592e6c4
Merge pull request #6663 from spycrab/qt_fix_columns 
Qt: Fix columns not properly showing / hiding
 2018-04-17 10:19:35 -04:00
Mat M 8bb0e0ee96
Merge pull request #6662 from Tilka/fix_warnings 
Fix some warnings
 2018-04-17 10:17:01 -04:00
spycrab 9ffc600e8d Qt: Fix columns not properly showing / hiding 2018-04-17 15:27:51 +02:00
Tillmann Karras 4cfd900c67 Fix some warnings 2018-04-17 14:10:05 +01:00
Sepalani 04cfddca33 HLE_VarArgs: PowerPC::HostRead_F64 used 2018-04-17 16:25:43 +04:00
Léo Lam 69ad94997c Qt/Debugger: Don't pause when already paused 
Fixes a severe performance issue which would cause the UI to use tons
of CPU time and fail to update when scrolling with a breakpoint on PC.
 2018-04-17 14:21:18 +02:00
Mat M c78b3f6ab6
Merge pull request #4507 from sepalani/host_f 
PowerPC: HostR/W float/double added
 2018-04-17 08:02:07 -04:00
Pierre Bourdon 94f3e27ccd
Merge pull request #6659 from spycrab/qt_tabbed_config 
Qt/SettingsWindow: Use tabs
 2018-04-17 13:52:23 +02:00
Sepalani 048513183e PowerPC: HostR/W float/double added 2018-04-17 08:29:47 +04:00
spycrab 4d4a018ccf Qt/SettingsWindow: Use tabs 2018-04-16 23:15:45 +02:00
Lioncash c23a998f9d
TraversalClient: Use u32 instead of enet_uint32 
Lessens the dependence on the enet library (and we really don't need to rely on a third-party library for a 32-bit integer type)
 2018-04-16 16:46:48 -04:00
Lioncash f1e92a1eae
TraversalClient: Make TestPacket() private 
This is only used by the private InterceptCallback()
 2018-04-16 16:46:48 -04:00
Lioncash 1b8ad49d1e
TraversalClient: In-class initialize members where applicable 2018-04-16 16:46:48 -04:00
Lioncash ca6a2970ea
TraversalClient: Make data externally read-only members private 
These are only ever queried for state, not written. Therefore, prevent writing to the members
and make them private.
 2018-04-16 16:46:44 -04:00
Léo Lam 6c87817d9c Qt/Debugger: Deduplicate memory view update code 
The structure and address calculation were identical.
Only the string generation was different.
 2018-04-16 22:36:32 +02:00
Léo Lam dfd6a228a6
Merge pull request #6654 from lioncash/log 
Common/Logging/Log: Wrap GENERIC_LOG macro's body in do { } while (0)
 2018-04-16 20:38:22 +02:00
Léo Lam d13fc1d2e9
Merge pull request #6655 from lioncash/common-libs 
Common/CMakeLists: Link curl and VTune libraries in privately
 2018-04-16 20:35:31 +02:00
JosJuice 0efbaebe17 Minor fixes to translatable strings 
The usual deduplication between DolphinWX and DolphinQt2, plus the removal
of a now unused ubershader string and a fix for the Euphoria i18n comment.
 2018-04-16 19:08:58 +02:00
Lioncash 236aed9fd1
Common/CMakeLists: Link curl and VTune libraries in privately 
These are only used internally.
 2018-04-16 12:38:24 -04:00
Lioncash b0dc823472
Common/Logging/Log: Wrap GENERIC_LOG macro's body in do { } while (0) 
Enforces the termination of GENERIC_LOGs with semicolons.
 2018-04-16 12:11:32 -04:00
Mat M 6224b9bd37
Merge pull request #6642 from leoetlino/stm 
IOS/STM: Reset the event hook at the correct time
 2018-04-16 09:04:12 -04:00
Lioncash 939c5671a9 Common/Config: Remove unused header inclusions 2018-04-15 22:35:00 -04:00
Lioncash 4836739663 Common/Config: Remove unnecessary function declaration 
This prototype declaration is already provided by the Config.h header
 2018-04-15 22:33:53 -04:00
Léo Lam 3355ddcfb3 FileSystem: Fix member destruction order 2018-04-15 14:29:27 +02:00
Léo Lam 45647df349 UnitTests: Add tests for the Wii filesystem 
This adds unit tests for the Wii filesystem now that the filesystem
interface is neatly separated from the IPC code.

Basic FS functionality is tested, in addition to problematic usages and
edge cases that Dolphin used to handle incorrectly (which of course
broke emulated software).

These tests should make it quite a bit harder to introduce regressions.

Issues that are covered by the tests in particular:

* Metadata: issue 10234 (though tests are commented out for now because
  Dolphin doesn't support NAND images yet so it can't track metadata);

* EOF seeks/reads: https://github.com/dolphin-emu/dolphin/pull/4942

* Read/write operations from multiple handles: see issue 2917, 5232 and
  8702 and https://github.com/dolphin-emu/dolphin/pull/2649
 2018-04-15 14:29:27 +02:00
Mat M eecdb51709
Merge pull request #6645 from JosJuice/tie-constexpr 
x64Emitter: Don't assume that std::tie is constexpr
 2018-04-15 03:11:31 -04:00
JosJuice 8a146d5210 x64Emitter: Don't assume that std::tie is constexpr 
Using constexpr tie broke building with older GCC versions according to
https://forums.dolphin-emu.org/Thread-build-error-on-linux-mint-18-3
 2018-04-15 08:30:01 +02:00
JosJuice 45923696ed
Merge pull request #6648 from leoetlino/master 
WiimoteEmu: Fix turntable_button_names size
 2018-04-15 08:25:44 +02:00
Mat M 615c0decb7
Merge pull request #6644 from leoetlino/uicommon-header 
UICommon: Fix header
 2018-04-14 20:25:22 -04:00
Léo Lam 0a481c0663 WiimoteEmu: Fix turntable_button_names size 
Three elements were removed, but because of an oversight the array
size was not changed to match.
 2018-04-14 23:52:10 +02:00
Léo Lam 783e4ec2fa
Merge pull request #6633 from aldelaro5/wx-debugger-icons 
Wx: debugger icons
 2018-04-14 23:29:57 +02:00
Léo Lam 371f807e67
Merge pull request #6615 from leoetlino/sysconf 
SysConf: Migrate to new filesystem interface
 2018-04-14 23:29:25 +02:00
Léo Lam c73b05e200
Merge pull request #6647 from aldelaro5/qt-fix-mbp 
Qt/Debugger: correctly set the MBP attributes when adding an address one
 2018-04-14 23:22:57 +02:00
aldelaro5 0f8c51dfe4
Wx: Implement the new debugger icons 2018-04-14 17:22:04 -04:00
Léo Lam ee955e37a9
Merge pull request #6564 from JosJuice/translate-certain-button-names 
Translate certain button names but not all
 2018-04-14 23:20:39 +02:00
Léo Lam aafa8a10e1
Merge pull request #6643 from lioncash/oprofile 
CMakeLists: Define an OProfile target and use it
 2018-04-14 23:12:17 +02:00
aldelaro5 1401fbc71a
Qt/Debugger: correctly set the MBP attributes when adding 
Not setting the end address causes the GetMecheck function to never think a matching address MBP exists.
 2018-04-14 17:05:23 -04:00
Léo Lam 2f22c76db1 UICommon: Avoid including Xrandr.h 
Xlib has really terrible headers that declare non-namespaced
macros and typedefs for common words.

Just wasted 10 minutes trying to figure out why a unit test failed
to build before I remembered it was Xrandr.h conflicting with our
enum class members again.

To fix the issue, this removes the Display* parameter from the
EnableScreensaver function (which was unused) so we don't have
to include Xrandr.h anymore.
 2018-04-14 17:14:38 +02:00
Léo Lam 62269572e4 UICommon: Fix indirect includes 2018-04-14 16:42:54 +02:00
Léo Lam e253d3d919
Merge pull request #6640 from spycrab/qt_scale_render 
Qt: Fix render size not matching window size
 2018-04-14 14:56:33 +02:00
Lioncash b31281527a
CMakeLists: Define an OProfile target and use it 
Allows us to bring includes and relevant libraries into scope by explicitly declaring linkage against the target
as opposed to using a variable. Also removes the dumping of OProfile includes into the top-level directory.
 2018-04-13 19:35:17 -04:00
Léo Lam 8bae4b7e51 IOS/STM: Reset the event hook at the correct time 
Just re-disassembled STM and found out I have made a mistake when
I changed STM stuff back in 2016.

I accidentally made STM reset the event hook on close when it should
have been done in the destructor (i.e. when IOS gets reset on console).

Verified in IDA that STM just `IOS_ResourceReply(request, IOS_OK)`
without ever resetting the hook.
 2018-04-13 23:34:35 +02:00
Léo Lam b1bbd8a50e
Merge pull request #6625 from lioncash/evdev-udev 
InputCommon/CMakeLists: Include evdev and udev includes on a by-target basis
 2018-04-13 20:50:31 +02:00
Léo Lam 52905a5fae
Merge pull request #6627 from sepalani/map-strip 
PPCSymbolDB: Do not truncate fixed size symbols
 2018-04-13 20:48:28 +02:00
spycrab a12d4996ed Qt: Use new debugger icons 2018-04-13 20:40:41 +02:00
spycrab 8536e31136 Qt: Fix render size not matching window size 2018-04-13 20:12:13 +02:00
Lioncash b256f873ca
CMakeLists: Link in zlib privately where applicable 
Also, use the target name introduced via find_package(ZLIB) instead
of hardcoding the 'z' name in the link libraries.
 2018-04-13 08:29:46 -04:00
JosJuice 7ed28297b2 ControllerEmu: Use enum instead of bool for translatability 2018-04-13 13:04:26 +02:00
JosJuice 3f13dbe087 Translate certain button names but not all 
Some button names should be translated, for instance Up, Left and such.
At the same time, some other button names shouldn't be translated,
for reasons that might be less obvious. In 0146456af, I removed the
_trans markers for button names that never need to be translated
(such as A and B), but that isn't actually enough to ensure that
DolphinWX won't try to translate them anyway. This commit adds a bool
that explicitly tells the GUI whether a button name should be translated.
Otherwise we'll have problems like the GUI treating the button name "B"
(which isn't supposed to be translated) as matching the translatable
string "B" (being an abbreviation of "bytes"), meaning that the button
"B" will be labeled "o" when running Dolphin in French (after
translations get pulled from Transifex the next time).

By the way, while it turned out that DolphinWX translated all button
names, it also turned out that DolphinQt2 translated *no* button names.
Go figure. This commit makes them consistent with each other.
 2018-04-13 13:04:26 +02:00
JosJuice e604641b12 Remove leftovers of projection hack support 2018-04-13 12:52:42 +02:00
Markus Wick 71dd2d9d4c
Merge pull request #6632 from lioncash/fp 
Interpreter: Don't use a union to type-pun between integral and FP types
 2018-04-13 11:12:01 +02:00
Lioncash a36bf438cd
Interpreter_FloatingPoint: Handle QNaNs properly in frsp 
Essentially the same behavior as the SNaN path, minus the conditional result and setting of the VXSNAN FPSCR bit.
 2018-04-12 19:47:10 -04:00
Lioncash 965b963a6f
Interpreter_FloatingPoint: Handle SNaNs properly in frsp 
If FPSCR[VE] is set, a result isn't supposed to be written to the destination,
just the FPSCR[VXSNAN] bit gets set, and FPSCR[FR] and FPSCR[FI] get set to zero.

If FPSCR[VE] isn't set, then we do write out a result, however, the FPSCR[FPRF]
field is updated to signify a QNaN (yes, a QNaN, the FPRF field doesn't have
a bit configuration for SNaNs).
 2018-04-12 19:47:06 -04:00
Lioncash e28d063539 x64Emitter: Make the Align* functions return a non-const data pointer 
There's no real requirement to make this const, and this should also
be decided by the calling code, considering we had places that would
simply cast away the const and carry on.
 2018-04-12 19:46:55 -04:00
Lioncash ab25eb6449 Interpreter_LoadStorePaired: Don't use a union to type-pun between integral and FP types 2018-04-12 19:44:31 -04:00
Lioncash 7a3158a693 Interpreter_FPUtils: Don't use a union to type-pun between integral and FP types 
The previous code invokes undefined behavior. memcpy will optimize away
to the relevant loads and stores while maintaining well-defined
behavior.
 2018-04-12 19:44:31 -04:00
Tilka bbd1bb8eaa
Merge pull request #6636 from phire/fix_autoformatting 
Fix change in comment meaning by autoformat.
 2018-04-12 22:52:06 +01:00
Scott Mansell 0e6d01220a Fix change in comment meaning by autoformat. 2018-04-13 09:20:27 +12:00
Tilka 27515f4c9b
Merge pull request #6626 from lioncash/dcbz_l-disasm 
GekkoDisassembler: Fix disassembly of dcbz_l
 2018-04-12 22:18:56 +01:00
Léo Lam a287bbc3bd Move SysConf to Core 
It's not common code that could be reused for, say, Citra;
it's absolutely specific to Wii emulation and only used by the Dolphin
core, so let's move it there.

Another reason for doing this is to avoid having Common depend on Core.
 2018-04-12 22:16:37 +02:00
Léo Lam 0856d4a68a SysConf: Migrate to new filesystem interface 
It was discovered that some titles rely on filesystem metadata to work
properly. Currently, in master they either simply won't find their
save files (for example Bolt) or will complain about the Wii system
memory being corrupted (on first use or every time depending on
the title).

In order to even be able to keep track of file metadata, we first need
to eliminate all direct accesses to the NAND and make all kinds of
operations go through the filesystem code added in PR 6421.

This commit starts the migration process by making SysConf use
the new FS interface.
 2018-04-12 22:16:37 +02:00
Léo Lam 3744a6d3f5 FileSystem: Add some more wrappers for convenience 2018-04-12 22:16:37 +02:00
Léo Lam 95aae11164 IOS: Do not manually close devices in destructor 
This used to be necessary for properly cleaning up the FS state because
the old FS implementation used static state and only performed cleanup
in the close function, not in the destructor.

Now that the static state is gone, we do not need to close devices
manually anymore.
 2018-04-12 22:16:10 +02:00
spycrab 40bb9974f2 Reformat all the things! 2018-04-12 21:28:39 +02:00
Sepalani 7d36165489 PPCSymbolDB: Do not truncate fixed size symbols 
Fix comparison warning
 2018-04-10 21:50:33 +04:00
Sepalani 9b8866ba78 PPCSymbolDB: Replace alert with LOG message 2018-04-10 21:49:47 +04:00
Lioncash 1c17329e2f
GekkoDisassembler: Fix disassembly of dcbz_l 
Previously this would fall through and disassemble as a generic "ps_[number]" junk instruction.
 2018-04-10 11:22:01 -04:00
Lioncash 73ebc190fa
InputCommon/CMakeLists: Link evdev and udev in privately 
These libraries aren't directly used outside of InputCommon
 2018-04-10 09:59:55 -04:00
Lioncash d63d0b5069
InputCommon/CMakeLists: Include evdev and udev includes on a by-target basis 
Avoids including the evdev/udev includes in the top-level directory
 2018-04-10 09:59:51 -04:00
Markus Wick 0bfeb37a1f
Merge pull request #6604 from lioncash/dcbz_l 
Interpreter_LoadStore: Generate a program exception if dcbz_l is executed when HID2[LCE] is zero
 2018-04-09 23:04:09 +02:00
JosJuice a66d56aece Use configured locale in UICommon::FormatSize 
StringFromFormat always uses the C locale, so we can't use it if we want
the decimal separator to be locale aware, but we can use a stringstream.
 2018-04-09 19:14:15 +02:00
JosJuice 0dca432836 Remove old code for using default locale 
This isn't needed anymore now that the global C++ locale isn't
set to the classic locale.
 2018-04-09 19:14:15 +02:00
JosJuice 13d060491c DolphinQt2: Set locale 
We want things like number formatting to be done the way the user expects.
 2018-04-09 19:14:14 +02:00
JosJuice 72040600d7 Set locale to "en_GB" if "en" is configured 2018-04-09 19:14:14 +02:00
JosJuice 9417fc6a3a DolphinWX: Set C++ locale 
After 3a83ebc, the Show System Clock feature started using the
unfortunate combination of MM/DD/YY dates (rare outside of the US)
and 24-hour time (rare in the US) regardless of the user's locale
settings. This commit makes it use the configured locale again.

I've noticed one minor difference in behavior between now and
before 3a83ebc: The new way of setting the C/C++ locale seems to
treat "en" as "en-US", but the wx way of setting the C locale
treated it as "en-GB" (at least on Windows).
 2018-04-09 19:14:14 +02:00
JosJuice 7aaaf44229
Merge pull request #6611 from leoetlino/remove-workaround 
Boot_WiiWAD: Remove a timing issue workaround
 2018-04-09 15:46:39 +02:00
Léo Lam 67f8e6e60a
Merge pull request #6620 from lioncash/dvd 
DVDInterface: Deduplicate code in UpdateInterrupts()
 2018-04-09 12:52:38 +02:00
Léo Lam cb88e1256f
Merge pull request #6617 from lioncash/ppcanalyst 
PPCAnalyst: Minor cleanup
 2018-04-09 12:48:16 +02:00
Léo Lam 783cbef638
Merge pull request #6618 from lioncash/symboldb 
PPCSymbolDB: Minor cleanup
 2018-04-09 12:46:28 +02:00
Lioncash 1b3dae918a StreamADPCM: Turn the ADPCM decoder into a class 
Migrates the state to be instance-based as opposed to being a flat
namespace. This keeps behavior localized to its own instantiable unit
(and forces uses of the class to also be localized, lest they cart around
an instance all over the place).
 2018-04-09 03:49:18 -04:00
Lioncash a8088b7365 ProcessorInterface: Remove prefixed underscores from parameters 
These are reserved by the implementation for any use.
 2018-04-09 03:21:59 -04:00
Lioncash 419ed1b46a DVDInterface: Deduplicate code in UpdateInterrupts() 2018-04-09 03:18:51 -04:00
Lioncash a0f943178b Profiler: Move BlockStat and ProfileStats structures into the Profiler namespace 
These should be part of the namespaced API and not be sitting in the
global namespace.
 2018-04-08 22:29:48 -04:00
Lioncash 0461709c8d PPCSymbolDB: Use auto for iterators where applicable 2018-04-08 22:03:11 -04:00
Lioncash b44eb90ee4 PPCSymbolDB: Default destructor and pass to member variables in the constructor initializer-list 2018-04-08 21:56:24 -04:00
Lioncash d6d17eea60 PPCSymbolDB: Remove unused function pointer typedef 2018-04-08 21:54:50 -04:00
Lioncash 9c5115a627 PPCAnalyst: Simplify boolean assignments in SetInstructionStats() 
Ternaries here aren't necessary if all we're checking against is if
something is non-zero
 2018-04-08 21:42:43 -04:00
Lioncash f2b2f5b4c7 PPCAnalyst: Make ReorderType an enum class 
Makes the values strongly typed and doesn't dump them into the class
itself.
 2018-04-08 21:38:19 -04:00
Lioncash 5e5a56bd9b PPCAnalyst: Remove unnecessary includes from header 2018-04-08 21:34:12 -04:00
Lioncash 4bd3b28823 PPCAnalyst: in-class initialize PPCAnalyzer's members 
Eliminates the need to assign in the constructor initializer list.
 2018-04-08 21:32:15 -04:00
Lioncash 433a56636b PPCAnalyst: Move public interface above private interface 2018-04-08 21:31:19 -04:00
Léo Lam 8894b902df Boot_WiiWAD: Remove a timing issue workaround 
This was necessary to work around a FS timing issue which caused small
writes to take much longer than they should.

Now that we emulate timings for the FS module including its file cache,
we don't need to maintain this workaround anymore.
 2018-04-08 11:23:18 +02:00
Léo Lam 9dbc760bb7
Merge pull request #6606 from lioncash/bochs 
CMakeLists: Link bochs in privately where applicable
 2018-04-08 11:08:12 +02:00
Lioncash f1be7cd4a0
CMakeLists: Link bochs in privately where applicable 
Everything that links in core doesn't need to see anything related to bochs, because it's only used internally.
Anything else that relies on bochs should be linking it in explicitly.
 2018-04-08 04:59:58 -04:00
Léo Lam 0a290f5d11
Merge pull request #6607 from lioncash/ppc 
PPCDebugInterface: Remove redundant HostRead_U32() call in Disassemble()
 2018-04-08 10:25:43 +02:00
Léo Lam 2a535d5a55
Merge pull request #6608 from lioncash/gekko 
Gekko: In-class initialize members where applicable
 2018-04-08 10:23:42 +02:00
Léo Lam 219728dbd4
Merge pull request #6609 from lioncash/ufpr 
Gekko: Remove unused UFPR union
 2018-04-08 10:22:43 +02:00
Lioncash 88a80f118c Common/Swap: Amend BigEndianValue's operator= to return a reference to the object rather than returning void 
The general convention is to return a reference to the object that was
acted on, otherwise you can get into situations with errors because the
type wasn't being propagated properly
 2018-04-08 01:22:18 -04:00
Lioncash 5d1349f9c7 Gekko: Remove unused UFPR union 
Using this in its current form would invoke undefined behavior, as it's
using a union to type pun between data types. It's also, well, unused,
so we don't need to keep it around.
 2018-04-07 22:30:26 -04:00
Lioncash d5555b49e9 Gekko: In-class initialize members where applicable 
Allows defaulting the default constructor. Also moves assignment to
initializer lists where applicable as well.
 2018-04-07 22:26:24 -04:00
Lioncash 3e50b0e320 PPCDebugInterface: Remove redundant HostRead_U32() call in Disassemble() 
We already read the necessary information with the
HostRead_Instruction() call. Internally, it calls HostRead_U32() as
well, so there's no difference in behavior.
 2018-04-07 22:20:59 -04:00
Léo Lam f4a2ad3c88 IOS/FS: Emulate read/write/close/seek timing 
Also bumps up the state version.
 2018-04-07 23:35:28 +02:00
Léo Lam 42983c0bd3 IOS/FS: Emulate superblock write timing 2018-04-07 23:35:28 +02:00
Léo Lam b74577ff43 IOS/FS: Emulate GetAttr() timing 2018-04-07 23:35:28 +02:00
Léo Lam 896d875187 IOS/FS: Emulate Open() timing 2018-04-07 23:35:28 +02:00
Léo Lam 32b1409cbd IOS/FS: Use hardware tested minimum reply time 
...instead of an arbitrary guess.
 2018-04-07 23:35:28 +02:00
Léo Lam 7dff069659
Merge pull request #6605 from spycrab/gc_fix_rumble 
[RFC] Core/GC: Fix rumble for "Luigi's Mansion"
 2018-04-07 23:23:30 +02:00
spycrab eed066e8a7 Core/GC: Fix rumble for "Luigi's Mansion" 2018-04-07 22:13:01 +02:00
Lioncash 181539e049
Interpreter_LoadStore: Generate a program exception if dcbz_l is executed when HID2[LCE] is zero 
If the locked cache isn't enabled, dcbz_l is illegal to execute
(locked cache is off, locked cache instructions don't work, makes sense)

This makes exception handling more accurate. It was previously possible to hit the DSI exception
handler when HID2[LCE] is set to zero, which isn't correct.

With this change we no longer hit the DSI handler, however we still have a lingering issue elsewhere
likely to do with exception precedence, we seem to hit the Floating Point exception handler instead
in some cases. This isn't due to the instruction itself directly however, so this is just another bug
to fix elsewhere.
 2018-04-06 23:53:44 -04:00
Anthony 9e2806c181 [AVIDump] fix compilation issues on Linux 2018-04-06 19:53:10 -07:00
Léo Lam a957bd1ecc
Merge pull request #6421 from leoetlino/fs-interface 
IOS: Refactor the filesystem code
 2018-04-06 12:17:09 +02:00
Lioncash 3e946d87e4
DolphinWX/DolphinQt2 CMakeLists: Use cmake -E instead of mkdir -p for creating language directories 
CMake already has this functionality built-in. This lessens depending on the host system environment
and is more cross-platform friendly (which is always nice from a build-system point of view).
 2018-04-05 12:49:33 -04:00
Léo Lam a3bdb5d85e
Merge pull request #6598 from lioncash/target 
DolphinQt2/CMakeLists: Use the target_* equivalents of add_definitions and include_directories
 2018-04-05 17:53:24 +02:00
Léo Lam 4cd5ef76ad
Merge pull request #6537 from spycrab/qt_quick_assign 
Qt/Mapping: Implement "Iterative Input"
 2018-04-05 17:44:30 +02:00
Lioncash 839fc7e749
DolphinQt2/MainWindow: Resolve a memory leak on systems with X11 
In the case we had X11 libs available, we'd allocate an XRRConfiguration instance and pass it
to the GraphicsWindow instance, but it would never actually be freed.
 2018-04-05 09:07:08 -04:00
Lioncash 9c27c7eda8
DolphinQt2/CMakeLists: Use the target_* equivalents of add_definitions and include_directories 
add_definitions and include_directories don't operate on a by-target basis, they act on a
by-directory basis (i.e. if we defined two targets, A and B, in this CMakeLists file, add_definitions
would add the definitions to the COMPILE_DEFINITIONS directory property which both A and B would
implicitly use).

The same idea applies to include_directories, only it appends to the INCLUDE_DIRECTORIES directory
property.

Instead, specify these on the target to keep scope as narrow as possible.
 2018-04-05 07:52:25 -04:00
Léo Lam d0b7c013a1
Merge pull request #6593 from lioncash/headless 
DolphinNoGUI/CMakeLists: Remove the use of SRCS and LIBS variables
 2018-04-05 10:07:31 +02:00
Léo Lam 39cb22ddc9
Merge pull request #6594 from lioncash/qt 
DolphinQt2/CMakeLists: Specify Qt libraries via COMPONENTS in the find_package call
 2018-04-05 10:03:41 +02:00
Markus Wick a9cd67125c
Merge pull request #6597 from lioncash/fp-load-store 
Interpreter_LoadStore: Generate alignment exceptions if an FP load/store instruction's effective address is not word aligned
 2018-04-05 09:55:49 +02:00
Lioncash 912c9490c0 Interpreter_LoadStore: Generate alignment exceptions if an FP load/store instruction's effective address is not word aligned 
This is one of the conditions for an alignment exception documented in
the 750CL architecture reference manual in section 4.5.6, which also
applies to the Gekko microprocessor.
 2018-04-05 00:30:53 -04:00
Lioncash 980f1641b5 Interpreter_LoadStore: Generate alignment exceptions if dcbz or dcbz_l are executed with the data cache disabled 
This is an exception condition documented within section 4.5.6 in the
architecture reference manual for the PPC 750CL, which also applies to
the Gekko microprocessor.

Also moves dcbz_l's implementation out of Interpreter_Paired and beside
dcbz where it belongs.
 2018-04-04 18:44:17 -04:00
spycrab e0ba2a4aeb Qt: Implement "Iterative Input" 2018-04-04 21:51:51 +02:00
Lioncash fb929ab8e5
DolphinQt2/CMakeLists: Specify Qt modules via COMPONENTS in the find_package call 
Eliminates the need to find the individual modules separately
 2018-04-04 15:05:20 -04:00
Lioncash 6f694e435c
DolphinNoGUI/CMakeLists: Remove the use of SRCS and LIBS variables 
Instead, operate on the target directly. This removes the last usages of the
SRCS and LIBS variables.
 2018-04-04 11:42:57 -04:00
Léo Lam 9be505fde2
Merge pull request #6473 from spycrab/qt_dbg_memory 
Qt/Debugger: Implement "Memory" widget
 2018-04-04 16:58:04 +02:00
Léo Lam 4d5adf3dfa
Merge pull request #6588 from lioncash/cmake 
DolphinWX/DolphinQt2 CMakeLists: Remove use of LIBS and SRCS variables
 2018-04-04 16:57:01 +02:00
Lioncash 5e4446c313
DolphinQt2/CMakeLists: Remove usages of LIBS and SRCS variables 
Instead, operate on the target itself. Also removes the variable
representing the name of the target. We can just refer to this directly
 2018-04-04 09:09:45 -04:00
spycrab 95ae4b34d9 Qt/Debugger: Implement "Memory" widget 2018-04-04 13:43:30 +02:00
Markus Wick c6d0d9a01f
Merge pull request #6578 from JosJuice/remove-projection-hacks 
Remove support for projection hacks
 2018-04-04 09:10:32 +02:00
Markus Wick ba42238b0b
Merge pull request #6592 from lioncash/imagine-le-ppc 
Interpreter_LoadStore: Generate alignment exceptions if lmw, lswi, lswx, stmw, stswi, or stswx is executed when the MSR[LE] bit is set
 2018-04-04 09:00:45 +02:00
Markus Wick b82539e927
Merge pull request #6589 from lioncash/jni 
Android/CMakeLists: Remove usages of LIBS and SRCS variables
 2018-04-04 08:57:10 +02:00
Lioncash 3ea0a37d72 Interpreter_LoadStore: Generate alignment exceptions if lmw, lswi, lswx, stmw, stswi, or stswx is executed when the MSR[LE] bit is set 
Improves exception accuracy regarding an admittedly very unlikely
scenario.
 2018-04-03 20:47:40 -04:00
Lioncash 74aff4d9ef
HiresTexture: Correct texture hashes 
Fixes a regression introduced in 2da8d98b2f
 2018-04-03 12:42:05 -04:00
Lioncash 21ee216e63
Android/CMakeLists: Remove usages of LIBS and SRCS variables 
Instead, operate on the target itself.
 2018-04-03 08:05:43 -04:00
Lioncash 516b46845d
DolphinWX/CMakeLists: Remove usages of the LIBS and SRCS variables 
Instead, operated on the target itself.
 2018-04-03 08:04:29 -04:00
Markus Wick 1e0f72f2da
Merge pull request #6585 from lioncash/exception 
Interpreter_LoadStore: Handle alignment exceptions in lmw, lwarx, stmw, and stwcx + fixes for eciwx and ecowx
 2018-04-03 09:52:36 +02:00
Anthony 971a253a88
Merge pull request #6591 from JosJuice/fix-android 
Fix build error on Android
 2018-04-03 00:22:44 -07:00
JosJuice 3fe0051a53 Fix build error on Android 
Caused by 4387432.
 2018-04-03 08:32:55 +02:00
Léo Lam 91f3650fa5
Merge pull request #6586 from lioncash/video-backends 
CMakeLists: Migrate video backends off the add_dolphin_library macro and remove said macro
 2018-04-02 17:10:52 +02:00
Stenzek 9924434cdf
Merge pull request #6573 from stenzek/bad-shader-uid-cache 
ShaderCache: Improve shader UID cache file reliability
 2018-04-03 01:00:09 +10:00
Lioncash de0ed1a5fb
Interpreter_LoadStore: Update the DAR if a DSI exception occurs in eciwx and ecowx 
Also once a DSI exception occurs, execution is supposed to leave the
instruction immediately. It doesn't finish execution.
 2018-04-02 08:34:32 -04:00
Lioncash a013638dcb
Interpreter_LoadStore: Properly update the DAR whenever an alignment exception occurs within eciwx and ecowx 
These should be updating the DAR when an alignment exception occurs,
just like every other instruction that can cause an alignment exception.
 2018-04-02 08:34:32 -04:00
Lioncash c1b78106e7
Interpreter_LoadStore: Flag alignment exceptions on misaligned addresses in lwarx, lmw, stmw, and stwcx 
The effective address given to these instructions must be word (4 byte) aligned,
and if the address is not aligned like that, then an alignment exception
gets triggered.

We currently don't update the DSISR in this case properly, since we
didn't really handle alignment exceptions outside of ecowx and eciwx,
and even then the handling of it isn't really that great, considering
the DAR isn't updated with the address that caused the exception to
occur.

The DSISR will eventually be amended to be properly updated.
 2018-04-02 08:34:26 -04:00
Lioncash 22be923b91
CMakeLists: Remove add_dolphin_library macro 
With all library targets migrated off add_dolphin_library, we can finally remove it
 2018-04-02 08:31:56 -04:00
Lioncash b184923540
Vulkan/CMakeLists: Migrate off add_dolphin_library 
Finishes the migration work started in 3a4c3bbe01
 2018-04-02 08:29:37 -04:00
Lioncash 8b43a31855
Software/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work started in 3a4c3bbe01
 2018-04-02 08:24:40 -04:00
Lioncash a3c53ff754
OGL/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work started in 3a4c3bbe01
 2018-04-02 08:22:39 -04:00
Lioncash d4f8502ad1
Null/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work started in 3a4c3bbe01
 2018-04-02 08:17:00 -04:00
Lioncash 3854e2bcca
D3D/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work started in 3a4c3bbe01
 2018-04-02 08:15:22 -04:00
Markus Wick 2449be7f0c
Merge pull request #6571 from lioncash/rotate 
CommonFuncs: Generify rotation functions and move them to BitUtils.h
 2018-04-02 12:18:22 +02:00
Markus Wick dea30e08bf
Merge pull request #6576 from lioncash/iconv 
CMakeLists: Remove iconv from the LIBS variable
 2018-04-02 11:07:19 +02:00
Léo Lam 80525cfd4e
Merge pull request #6584 from lioncash/async-init 
AsyncRequests: In-class initialize class members
 2018-04-02 10:37:07 +02:00
Lioncash 672665dec0 AsyncRequests: In-class initialize class members 
Prior to this change, it's possible for m_wake_me_up_again to be used
while it's in an uninitialized state from the exposed API.

e.g.

- Using SetEnable after construction would perform an uninitialized read.
- Using PushEvent would perform an uninitialized read by way of operator |=.

internally, an uninitialized read can happen if PullEventsInternal() is
executed before other functions.

Just to avoid the whole possibility of performing uninitialized reads,
we just give the class member a default value of false.
 2018-04-01 19:06:43 -04:00
Lioncash fd9eab73fb CPUDetect: Make CPUVendor enum an enum class 
Avoids dumping the enum contents into the global namespace.
 2018-04-01 17:47:50 -04:00
Léo Lam bf8ffe5bfb
Merge pull request #6582 from lioncash/const 
Jit64/JitRegCache: Make member functions const qualified where applicable
 2018-04-01 23:32:58 +02:00
Léo Lam 7d561c7e0e
Merge pull request #6579 from lioncash/socket 
IOS/Socket: Minor changes to WiiSocket
 2018-04-01 23:31:47 +02:00
Lioncash 0f6c3c7b35 Jit64/JitRegCache: Make member functions const qualified where applicable 
None of these member functions modify class state.

Also makes the parameter name for ScoreRegister's implementation
consistent with its declaration.
 2018-04-01 16:53:00 -04:00
JosJuice c6931ee5b8
Merge pull request #6577 from lioncash/memcard 
EXI_DeviceMemoryCard: Get rid of magic number in SetCS()
 2018-04-01 22:08:36 +02:00
JosJuice 621e1758fb
Merge pull request #6581 from lioncash/const 
DSPJitRegCache: Make FindFreeReg() a const member function
 2018-04-01 22:05:48 +02:00
Lioncash 6cfa9fda6b DSPJitRegCache: Make FindFreeReg() a const member function 
This member function doesn't modify class state.
 2018-04-01 16:01:25 -04:00
Lioncash fe9d989765 DSPJitRegCache: Remove unnecessary casts in FlushRegs() 
We can just use the proper printf specifiers instead.
 2018-04-01 15:49:21 -04:00
JosJuice 91732e2baf Remove support for projection hacks 
This isn't really useful for anything anymore as far as I know.
 2018-04-01 21:41:18 +02:00
Lioncash ad17d9a979 IOS/Socket: Delete WiiSocket's copy constructor 
If the copy assignment operator is deleted, then the copy constructor
should be deleted as well, otherwise it's a hole in the API where copies
can be made (and if this were an intended case, it should be
documented).

So we delete the copy constructor and explicitly default the move
assignment and move constructor to signify this is intended to be a
move-only type.
 2018-04-01 15:38:37 -04:00
Lioncash ad575a1556 IOS/Socket: Place WiiSocket's private interface below the public interface 
In the rest of the codebase we try to position the private interface
below the public interface (unless it's otherwise not possible).
 2018-04-01 15:38:33 -04:00
Lioncash abb33637a3 IOS/Socket: In-class initialize WiiSocket members 2018-04-01 15:27:58 -04:00
Lioncash 8fbd6e2a87 EXI_DeviceMemoryCard: Get rid of magic number in SetCS() 
Keeps the code consistent with other usages of the same constant
 2018-04-01 15:21:20 -04:00
Mat M d8dd7b9e66
Merge pull request #6533 from spycrab/qt_desc_box 
Qt/GraphicsWindow: Decrease description box size
 2018-04-01 14:06:50 -04:00
Lioncash 8db4ab7dd6
CMakeLists: Remove iconv from the LIBS variable 
Adjusts Common to use the ICONV_LIBRARIES variable directly and doesn't
append it to the LIBS variable.

After this, there's only one remaining usage where libraries are added
to the LIBS variable, after which it can be removed once the rest of
the targets are migrated off add_dolphin_library
 2018-04-01 14:00:55 -04:00
Stenzek 2687c55cf6 Renderer: Only recreate frame dump texture if dimensions differ 
This was a typo, been around for a while. == should be !=. May improve
frame dumping performnace slightly, but I doubt much if any.
 2018-04-02 01:15:48 +10:00
Stenzek 8587403e0e ShaderCache: Write currently-known UIDs to cache when re-creating file 
This way, if we load a UID cache where the data was incomplete (e.g.
Dolphin crashed), we don't lose the existing UIDs which were previously
at the beginning.
 2018-04-02 01:13:24 +10:00
Stenzek 36ea2f7a26 ShaderCache: Fix issue where shader cache wasn't recreated when invalid 2018-04-02 01:02:20 +10:00
Léo Lam aaf9f4759f
Merge pull request #6570 from lioncash/lzo 
CMakeLists: Remove lzo from the LIBS variable and make linkage private
 2018-04-01 11:51:06 +02:00
Lioncash a4420d6d94 Jit64: Make CheckMergedBranch() a const member function 
This function doesn't modify class state.
 2018-03-31 20:12:53 -04:00
Lioncash 136f16599f UnitTests: Add basic tests for RotateRight() and RotateLeft() 2018-03-31 18:09:50 -04:00
Lioncash c3483a1823 CommonFuncs: Generify rotation functions and move them to BitUtils.h 
These are bit manipulation functions, so they belong within BitUtils.

This also gets rid of duplicated code and avoids relying on compiler
reserved names existing or not existing to determine whether or not we
define a set of functions.

Optimizers are smart enough in GCC and clang to transform the code to a
ROR or ROL instruction in the respective functions.
 2018-03-31 18:09:45 -04:00
Lioncash eee32c030b
CMakeLists: Remove lzo from the LIBS variable and make linkage private 
The only place this library is needed (core) is already linked in the core target.
Also make the linkage private to create linkage failures if the dependency isn't
explicitly linked in elsewhere where it should be.

Reduces the dependency on the LIBS variable.
 2018-03-31 15:01:05 -04:00
Mat M 76e1a5b892
Merge pull request #6569 from JosJuice/kill-emu-state 
Remove EmuState
 2018-03-31 14:04:30 -04:00
Mat M a6f1c6e2e9
Merge pull request #6568 from leoetlino/dead 
Remove dead code
 2018-03-31 14:02:40 -04:00
Shawn Hoffman 6a0c15491b Remove EmuState 2018-03-31 16:21:17 +02:00
Léo Lam df0d1c8138
Merge pull request #6563 from JosJuice/fix-wii-banner-load 
Fix loading Wii banners for games that initially were cached without banners
 2018-03-31 14:59:09 +02:00
Léo Lam c82da2b978 Remove dead code 
Unused, old code that is intended to be removed should not be left in
comments -- that is what version control is for.
 2018-03-31 14:56:27 +02:00
JosJuice 5847e213af Clean up the end of GameFile::BannerChanged 2018-03-31 14:52:21 +02:00
Léo Lam 329622120f
Merge pull request #6567 from JosJuice/discio-enums-case 
DiscIO: Don't use all uppercase for enum values
 2018-03-31 14:37:26 +02:00
JosJuice 4387432436 DiscIO: Don't use all uppercase for enum values 
Also removing some prefixes that we don't need now that we're
using enum classes instead of plain enums.
 2018-03-31 14:11:32 +02:00
Léo Lam 4e547772da IOS/FS: Make the NAND root path a parameter 
Cleaner than having the backend figure out which NAND root to use.
 2018-03-31 10:58:49 +02:00
Léo Lam c56f31906c IOS/FS: Remove some redundant log messages 
The FS IPC code already logs all commands, so keeping the log messages
in the backend is redundant.
 2018-03-31 10:58:49 +02:00
Léo Lam 2d8be6a77d IOS/FS: Make it harder to forget closing FDs 
Return a FileHandle which will automatically close the FD when
the handle goes out of scope. For the rare cases where this behaviour
is undesirable, the FD can be released from the handle.
 2018-03-31 10:58:48 +02:00
Léo Lam de15e09a4f Log: Rename IOS_FILEIO to IOS_FS 
Let's use the actual name of the system module.

Also, the FS code is not all about files.
 2018-03-31 10:58:37 +02:00
Léo Lam 5a7b966b6d IOS: Rewrite FS to use FileSystem 
This is the large change in the branch.

This lets us use either the host filesystem or (in the future) a NAND
image exactly the same way, and make sure the IPC emulation code
behaves identically. Less duplicated code.

Note that "FileIO" and "FS" were merged, because it actually doesn't
make a lot of sense to split them: IOS handles requests for both
/dev/fs and files in the same resource manager, and as it turns out,
/dev/fs commands can *also* be sent to non /dev/fs file descriptors!
If we kept /dev/fs and files split, there would be no way to
emulate that correctly. I'm not aware of anything that does that (yet?)
but I think it's important to be correct.
 2018-03-31 10:58:37 +02:00
Léo Lam 78478a651d Boot: Move CreateVirtualFATFilesystem to Boot_WiiWAD 
It has nothing to do in the filesystem code.

(It also smells like a workaround for some kind of timing issue.)
 2018-03-31 10:58:37 +02:00
Léo Lam fcfe4e2a26 IOS: Change GetFS() to return a FileSystem 
Now that we have a proper filesystem interface, it makes more sense
to return it instead of the emulated IOS device (which isn't
really usable for any purpose other than emulated IPC).
 2018-03-31 10:45:44 +02:00
Léo Lam 1eec459e30 IOS: Extract existing FS code into a host backend 
Extract the existing FS code into a HostBackend implementing
the filesystem interface.

Compared to the original code, this uses less static state.
The open host files map is now a member variable
as it should have been. Filesystem handles are now also easier
to savestate. Some variable names and log messages were cleaned up.
Nothing else has been changed.
 2018-03-31 10:45:44 +02:00
Léo Lam f1dbb8952c IOS: Introduce a new FileSystem interface 
Add a new FileSystem class that can be used to perform operations
on the emulated Wii filesystem.

This will allow separating the IPC code (reading from and writing to
memory to handle IOS FS commands) and the actual filesystem code
in a much better way.

This also paves the way for implementing another filesystem backend
in the future -- NAND images for more complete emulation, including
filesystem metadata like permissions or file orders, which some games
and homebrew actually care about -- without needing to make any more
changes to the other parts of the codebase, in addition to making
filesystem behaviour tests easier to write.
 2018-03-31 10:45:44 +02:00
Léo Lam 1bdfedf3c6 Common: Add a Result class 
This adds a lightweight, easy to use std::variant wrapper intended to
be used as a return type for functions that can return either a result
or an error code.
 2018-03-31 10:45:44 +02:00
Lioncash e93159e54a
CMakeLists: Link in system framework libraries explicitly on macOS 
Makes our libraries explicitly link in which libraries they need.
This makes our dependencies explicit and removes the reliance on the
LIBS variable to contain the libraries that they need.
 2018-03-30 16:14:10 -04:00
Léo Lam 7833f1a931
Merge pull request #6558 from lioncash/input 
InputCommon/CMakeLists: Link in ForceFeedback library explicitly on macOS
 2018-03-30 14:05:36 +02:00
JosJuice a7ba69e16a Fix loading Wii banners for games that initially were cached without banners 
Fixes https://bugs.dolphin-emu.org/issues/10969
 2018-03-30 12:04:01 +02:00
Mat M c3398c9e2c
Merge pull request #6559 from spycrab/qt_crashes 
Qt/PatchesWidget: Fix segfault
 2018-03-29 18:51:22 -04:00
Mat M fc99b21080
Merge pull request #6560 from JosJuice/invalid-games-in-game-list 
DolphinQt2: Don't show invalid games in game list
 2018-03-29 18:49:38 -04:00
Mat M 65a1065cde
Merge pull request #6561 from JosJuice/uid-version-last-changed 
Put a "last changed in PR" comment next to UID cache version
 2018-03-29 18:48:12 -04:00
JosJuice b065f86270 Translate the netplay chat info message about QoS 2018-03-29 22:44:23 +02:00
JosJuice 01ea10824d Put a "last changed in PR" comment next to UID cache version 
This will create a merge conflict if two PRs try to increment the
cache version at the same time, which makes it noticeable that the
PR that gets merged last needs to increment the cache version again.
We already use this for savestates and the game list cache.
 2018-03-29 22:38:37 +02:00
JosJuice ff2fe73ec9 DolphinQt2: Don't show invalid games in game list 
Regression from 1f1dae3.

This problem doesn't happen in DolphinWX as far as I know, but if
you've ran into the problem in DolphinQt2, it will carry over to
DolphinWX because of the shared game list cache.
 2018-03-29 21:52:21 +02:00
spycrab 55d9df379a Qt/PatchesWidget: Fix segfault 2018-03-29 21:33:36 +02:00
Lioncash b8a4ab23dd
InputCommon/CMakeLists: Link in ForceFeedback library explicitly on macOS 
Makes an implicit dependency explicit. Also makes the macOS libraries link privately
as they aren't used in the exposed interface.
 2018-03-29 11:53:50 -04:00
Léo Lam 53b3da7301
Merge pull request #6555 from Ebola16/ASU 
Android: Updates for Android Studio 3.1
 2018-03-29 15:13:42 +02:00
Léo Lam e4f2ff0f32
Merge pull request #6557 from spycrab/qt_log_font 
Qt/LogWidget: Add "Debugger Font" option
 2018-03-29 15:12:33 +02:00
spycrab 8cb497cab2 Qt/LogWidget: Add "Debugger Font" option 2018-03-29 03:02:34 +02:00
Lioncash b818cc682c VideoCommon/Vulkan: Explicitly link in xxhash 
Lessens the dependency on the LIBS variable (and also makes the required
libraries explicit).
 2018-03-28 17:03:16 -04:00
Ryan Meredith 00db87e304 Android: Updates for Android Studio 3.1 2018-03-28 16:38:22 -04:00
Léo Lam 03a6a9b240
Merge pull request #6546 from spycrab/updater_ui 
Implement Updater UI
 2018-03-28 20:04:32 +02:00
Léo Lam 21a2c0284d
Merge pull request #6544 from spycrab/qt_fix_general 
GeneralPane: Fix settings resetting and improve code
 2018-03-28 20:01:57 +02:00
spycrab 429dc54159 Updater: Implement UI 2018-03-28 17:59:22 +02:00
spycrab f700fcae2e HttpRequest: Add callback option 2018-03-28 17:33:34 +02:00
Lioncash fd7ac0d4a3
VideoCommon/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work started in 3a4c3bbe01
 2018-03-28 09:57:50 -04:00
Léo Lam c28850045d
Merge pull request #6552 from lioncash/uicommon-cmake 
UICommon/CMakeLists: Migrate off of add_dolphin_library
 2018-03-28 12:33:24 +02:00
Lioncash a2a18380a7 UICommon/CMakeLists: Migrate off of add_dolphin_library 
Continues the migration work started in
3a4c3bbe01
 2018-03-28 06:29:09 -04:00
Markus Wick fc59ec6f13
Merge pull request #6547 from lioncash/dead 
PixelShaderGen: Remove dead code in WriteColor()
 2018-03-28 10:43:15 +02:00
JMC47 3cd9465f91 Fix JIT64 mtsmsr issue after PIE support again. 2018-03-28 04:16:41 -04:00
Léo Lam 10f198f3cf
Merge pull request #6551 from lioncash/qt-misc 
DolphinQt: Remove a few unused variables
 2018-03-28 07:50:44 +02:00
JosJuice 748ebf6891
Merge pull request #6550 from lioncash/qt 
HacksWidget: Remove duplicate AddDescription() calls in AddDescriptions()
 2018-03-28 07:33:04 +02:00
Lioncash df4ca7f05e SearchBar: Remove unused class variables 2018-03-27 22:47:02 -04:00
Lioncash 306d132232 MainWindow: Remove unused std::string variable in NetPlayHost() 2018-03-27 22:47:02 -04:00
Lioncash 833c030496 WiiPane: Remove unused variable in OnUSBWhitelistRemoveButton() 2018-03-27 22:47:01 -04:00
Lioncash eb8a853d8e Resources: Remove unused string in Init() 2018-03-27 22:47:01 -04:00
Lioncash 568490fdfb MD5Dialog: Call .empty() instead of testing against an empty string 2018-03-27 22:47:01 -04:00
Lioncash d3283a881f MenuBar: Remove unnecessary c_str() call 
Also uses the character overload for find_last_of
 2018-03-27 22:47:01 -04:00
Lioncash b637163704 CodeWidget: Remove unnecessary c_str() calls 2018-03-27 22:46:51 -04:00
Lioncash 4a1123f519 HacksWidget: Remove duplicate AddDescription() call in AddDescriptions() 2018-03-27 22:36:37 -04:00
Lioncash aa42534fed FilesystemWidget: Pass path QString by const reference instead of by value in ExtractDirectory() 
Makes it consistent with the surrounding API.

Also corrects a typo in ExtractFile's parameter list.
 2018-03-27 22:00:40 -04:00
Lioncash fc531993a9 DiscExtractor: Pass partition by reference rather than by value in ExtractDirectory() 2018-03-27 21:49:42 -04:00
Pierre Bourdon ac97f0463f
Merge pull request #6548 from lioncash/const 
LinearDiskCache: Don't cast away const in Read()
 2018-03-28 03:14:38 +02:00
Lioncash 008442898c LinearDiskCache: Don't cast away const in Read() 
We really shouldn't make the out pointer in the read function const and
then summarily cast it away. Also alters Write to be consistent with
casting.
 2018-03-27 21:09:18 -04:00
Lioncash f10198500e PixelShaderGen: Invert conditional in WriteColor() 
Puts the true condition body first instead of the false one for better
reading.
 2018-03-27 18:53:17 -04:00
Lioncash c9e0045881 PixelShaderGen: Remove dead code in WriteColor() 
The outer conditional executes only whenever destination alpha is used.
 2018-03-27 18:46:25 -04:00
Léo Lam ea166a4812
Merge pull request #6543 from lioncash/cast 
HiresTextures: Remove unnecessary pointer casts in GenBaseName() + minor associated cleanup
 2018-03-27 21:45:56 +02:00
Lioncash 2da8d98b2f
HiresTextures: Use std::minmax or std::minmax_element where applicable in GenBaseName() 
Minimizes repetition.

std::minmax_element can be used for the 256 * 2 case, as it's only performing byte comparisons
and thus, there will always be an element smaller than 0xffff, so it doesn't need to be included
in the set of compared values.
 2018-03-27 15:39:05 -04:00
Lioncash d5a1edba09
HiresTextures: Remove unnecessary pointer casts in GenBaseName() 
swap16 has an overload that accepts a u8*, performing the same behavior
in a well-defined manner.
 2018-03-27 15:19:02 -04:00
Pierre Bourdon 4ed0e10f41
Merge pull request #6541 from spycrab/updater_feedback 
Updater: Provide basic user feedback
 2018-03-27 20:43:36 +02:00
spycrab 7ce147f4d5 Updater: Provide basic user feedback 2018-03-27 20:32:26 +02:00
spycrab 11b15a688b GeneralPane: Fix settings resetting and improve code 2018-03-27 20:27:03 +02:00
Stenzek 92e7830be9
Merge pull request #6540 from spycrab/gcpad_segfault 
Core: Check for initialized GCPad before resetting rumble
 2018-03-28 02:40:53 +10:00
Léo Lam 3c61ee5f7f
Merge pull request #6542 from lioncash/cast 
BPStructs: Remove an unnecessary pointer cast in GetBPRegInfo
 2018-03-27 18:12:56 +02:00
Léo Lam 98f62a3ecd
Merge pull request #6530 from spycrab/qt_hires_icon 
Various icon improvements
 2018-03-27 18:08:46 +02:00
Lioncash 9feb18866b
BPStructs: Remove an unnecessary pointer cast in GetBPRegInfo 
swap32 has an overload that accepts a u8*, performing the same behavior
in a well-defined manner.
 2018-03-27 12:04:16 -04:00
spycrab 4f63d7f204 Qt: Fix low-resolution icon 2018-03-27 17:32:45 +02:00
spycrab 016ef43b27 Core: Check for initialized GCPad before resetting rumble 2018-03-27 16:26:36 +02:00
Léo Lam ceed6890df
Merge pull request #6526 from lioncash/emitter 
x64Emitter: Minor cleanup and changes
 2018-03-27 08:49:36 +02:00
Lioncash 476c71efc1 x64Emitter: Make eligible register and immediate functions constexpr 
Pointer variants aren't eligible as expressions with reinterpret cast
within them cannot be constexpr.
 2018-03-26 18:21:22 -04:00
Lioncash 8b072e1383 x64Emitter: Make remaining eligible functions in OpArg constexpr 2018-03-26 18:21:21 -04:00
Lioncash 964201f2d3 x64Emitter: Use std::tie in OpArg's operator==. Provide operator!= for symmetry 2018-03-26 18:21:21 -04:00
Lioncash 7f583b66cb x64Emitter: Clean up constructors for OpArg 
Default initializes members and moves initial assignments into the
initializer list.
 2018-03-26 18:21:17 -04:00
Miikka Juomoja 7169be242f StringUtil: Fix possible bad free 2018-03-26 23:48:13 +02:00
Léo Lam 793c6d25f4
Merge pull request #4532 from Neui/env-var-usr-cfg 
Use $DOLPHIN_EMU_PATH as an alternative for the user directory
 2018-03-26 23:41:27 +02:00
Léo Lam b0e4e35cc5
Merge pull request #6478 from spycrab/qt_default_btns 
Qt: Replace "OK" with "Close" buttons
 2018-03-26 22:48:26 +02:00
Léo Lam d3f432946f
Merge pull request #6514 from lioncash/inputcommon-cmake 
InputCommon/CMakeLists: Migrate off add_dolphin_library
 2018-03-26 21:25:27 +02:00
Léo Lam c9b4e3959c
Merge pull request #6511 from leoetlino/qt 
Qt: Minor fixes
 2018-03-26 21:24:44 +02:00
Léo Lam 91f61a1be4
Merge pull request #6285 from JosJuice/qt-gametracker-more-thread 
DolphinQt2: Perform more of GameTracker's work on a separate thread
 2018-03-26 21:24:22 +02:00
Markus Wick 9b5726fc23
Merge pull request #6534 from lioncash/dspjit 
DSPEmitter: Remove uses of the DSP JIT global in CompileCurrent()
 2018-03-26 21:12:46 +02:00
Markus Wick 12b99313aa
Merge pull request #6536 from stenzek/glx-swap-interval 
GLInterface: Use EXT_swap_control or MESA_swap_control over SGI
 2018-03-26 21:11:13 +02:00
JosJuice 0a69b42d07 DolphinQt2: Perform more of GameTracker's work on a separate thread 
This reduces the time from startup to the game list window showing up.
 2018-03-26 20:08:06 +02:00
Léo Lam b4e9bef25c
Merge pull request #6519 from spycrab/qt_rw_bg 
Qt/RenderWidget: Draw background on pause
 2018-03-26 19:04:53 +02:00
Léo Lam 2e1edb49b0
Merge pull request #6524 from lioncash/global 
JitArm64/JitAsm: Remove usages of the JIT global
 2018-03-26 18:59:05 +02:00
Léo Lam 674ab6a8ef
Merge pull request #6532 from lioncash/interp 
Interpreter: Remove static state within SingleStepInner()
 2018-03-26 18:50:26 +02:00