ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
37,434 Commits 5 Branches 11 Tags 1.3 GiB
Commit Graph

27741 Commits

Author SHA1 Message Date
Pokechu22 cd9edeacda GCAdapter: Merge Read logic 2022-06-02 19:39:36 -07:00
Pokechu22 9ec65baf46 GCAdapter: Have the read thread control the write thread 
This was done for Android in 6cc40b1235.
 2022-06-02 19:39:36 -07:00
Pokechu22 0fa92694d1 GCAdapter: Exit early if the adapter fails to open on Android 
This is only so that indentation is consistent with the non-android code.
 2022-06-02 19:39:36 -07:00
Pokechu22 749a4ad1ef GCAdapter: Remove check on write size on android 
It was removed for non-android in 56239d1ae1, and android already uses a separate thread, so presumably this isn't needed anymore.
 2022-06-02 19:39:36 -07:00
Pokechu22 27947046af GCAdapter: Harmonize read/write thread variable names 2022-06-02 19:39:36 -07:00
Pokechu22 279888da8c GCAdapter: Remove unused includes 2022-06-02 19:39:36 -07:00
Pokechu22 3ae775e574 GCAdapter: Use determinism hack on Android 
This hack was added in 8f0cbefbe5, and the part of it in SI_DeviceGCAdapter is present on Android already, so I don't see any reason why this part doesn't apply to Android.
 2022-06-02 19:39:36 -07:00
Pokechu22 55922e6d17 GCAdapter: Convert ControllerType to an enum class 2022-06-02 19:39:36 -07:00
Pokechu22 682d86f4da GCAdapter: Fix rumble enabled config on Android 
I believe the setting already existed in the UI; it just wasn't implemented in GCAdapter_Android.cpp.
 2022-06-02 19:39:36 -07:00
Pokechu22 36d4ee0939 GCAdapter: Use std::array for controller read and write payloads 2022-06-02 19:39:36 -07:00
Pokechu22 dd6592698e GCAdapter: Merge GCAdapter.cpp and GCAdapter_Android.cpp 
This is mostly a brainless merge, #ifdef-ing anything that doesn't match between the two while preserving common logic.  I didn't rename any variables (although similar ones do exist), but I did change one log that was ERROR on android and NOTICE elsewhere to just always be NOTICE.  Further merging will follow.
 2022-06-02 19:39:36 -07:00
Mai M f7f47d3cd0
Merge pull request #10692 from Pokechu22/dsp-manual-set40-and-write-backlog 
docs/DSP: Add sections on 16-bit and 40-bit modes and on main and extended opcode writing to the same register
 2022-06-02 20:26:31 -04:00
Mai M c8ab236e0a
Merge pull request #10709 from Pokechu22/dsp-lle-update-sr-16 
DSP LLE JIT: Fix Update_SR_Register16_OverS32
 2022-06-02 20:22:36 -04:00
Mai M 84944625df
Merge pull request #10714 from OatmealDome/macos-mojave-bump 
BuildMacOSUniversalBinary: Bump minimum macOS to 10.14
 2022-06-02 20:20:52 -04:00
Pokechu22 0fc1fb023f
Merge pull request #10678 from Dentomologist/skip_pagefault_test_if_no_exception_handler 
UnitTests: Skip PageFaultTest if exception handlers aren't supported
 2022-06-02 16:21:21 -07:00
OatmealDome 7ce1a5717a UICommon: Add support for portable.txt on macOS 2022-06-02 14:56:09 -04:00
Admiral H. Curtiss a58bb2aa24
Merge pull request #10701 from TryTwo/PR_Memory_Widget_Connections 
Debugger MemoryWidget: Navigate to memory from breakpoint widget and cheat search.
 2022-06-02 20:50:44 +02:00
Pokechu22 4bc42ded80 DSP LLE Interpreter: Remove OpReadRegisterAndSaturate 
Instead, saturate in OpReadRegister, as all uses of OpReadRegisterAndSaturate called OpReadRegister for other registers (and there isn't anything that writes to $ac0.m or $ac1.m without saturation).
 2022-06-01 22:01:49 -07:00
Pokechu22 928f745e36 DSP LLE Interpreter: Fix typo in 'LS 
This was introduced in fc1db5eaa0.
 2022-06-01 22:01:49 -07:00
Pokechu22 e7f78379ec DSP LLE Recompiler: Apply saturation to LOOP and BLOOP with $ac0.m and $ac1.m 2022-06-01 22:01:49 -07:00
Pokechu22 bc206b7a27 DSP LLE Interpreter: Apply saturation to LOOP and BLOOP with $ac0.m and $ac1.m 2022-06-01 22:01:49 -07:00
OatmealDome 803a0de5a4 VKMain: Remove check for macOS 10.14 2022-06-01 22:57:56 -04:00
OatmealDome 1cb3058abe MemoryUtil: Remove __builtin_available for macOS 10.14 2022-06-01 22:57:56 -04:00
OatmealDome 6e2febd404 VideoBackendBase: Remove __builtin_available for macOS 10.14 2022-06-01 22:57:51 -04:00
TryTwo 177dae6a1a Add options for BreakpointWidget, WatchWidget, and CheatSearches to send address to Memory Widget 2022-06-01 01:53:15 -07:00
TellowKrinkle f9c6eb7b98 InputCommon/ControllerEmu: Use more locks 
Loading configs while another thread is messing with stuff just doesn't feel like a good idea
Hopefully fixes Wiimote Scanning Thread crashes on startup
 2022-05-31 20:17:37 -05:00
Dentomologist e0c9ae16b9 FileUtil: Refactor CreateSysDirectoryPath() 2022-05-31 16:18:08 -07:00
Dentomologist c2be78079c FileUtil: Remove GetSysDirectory log spam 
Create and log path the first time GetSysDirectory is called, then just
return the path on future calls.
 2022-05-31 16:18:08 -07:00
Dentomologist 4d563ce4d1 Android: Ensure File::s_android_sys_directory is set only once 2022-05-31 16:18:08 -07:00
Pokechu22 f88b7ab6b3 DSP LLE JIT: Fix Update_SR_Register16_OverS32 
There were 3 bugs here:

- The input register for the full register wasn't actually being used; it was read into RCX but RCX wasn't used by Update_SR_Register16_OverS32 (except as a scratch register).  The way the DSP LLE recompiler uses registers is in general confusing, so this commit changes a few uses to have a variable for the register being used, to make code a bit more readable.  (Default parameter values were also removed so that they needed to be explicitly specified).
- Update_SR_Register16 was doing a 64-bit test, when it should have been doing a 16-bit test.  For the most part this doesn't matter due to sign-extension, but it does come up with e.g. `ORI` or `ANDI`.
- Update_SR_Register16_OverS32 did the over s32 check, and then called Update_SR_Register16.  Update_SR_Register16 masks $sr with ~SR_CMP_MASK, clearing the over s32 bit.  Now the over s32 check is performed after calling Update_SR_Register16 (without masking a second time).  No official uCode cares about the over s32 bit.
 2022-05-30 20:10:55 -07:00
Pokechu22 7c63bd1893 docs/DSP: Fix inconsistency with ADDI and CMPI 
We don't have anything called $amD, though we do have $acsD.  However, these instructions affect flags based on the whole accumulator, so it's better to just use $acD.
 2022-05-29 15:00:09 -07:00
Pokechu22 baf2c710ff DSP: Fix typo with TST 2022-05-29 15:00:09 -07:00
Pokechu22 4dc7208195 docs/DSP: Fix typo with arithmetic instructions that take a 16-bit immediate 
These instructions used an 'r' in their bit list, but a 'd' in the operands.
 2022-05-29 15:00:09 -07:00
Pokechu22 b349254ff4 docs/DSP: Document the behavior when main and extended opcodes both write to the same register (the write backlog) 
For more information, ApplyWriteBackLog, WriteToBackLog, and ZeroWriteBackLog were added in b787f5f8f7 and the explanatory comment was added in fd40513fed, although it did not mention the specific instructions that could trigger this edge case. The statements about which registers can be written by main opcodes and extension opcodes are based on my own checking of all instructions in the manual.
 2022-05-29 15:00:09 -07:00
OatmealDome df22439826 FS: Reshuffle Rename to fix steamrt unit test failure 2022-05-29 13:50:32 -04:00
OatmealDome 09875c6403 DolphinQt: Copy qt.conf into Binaries output folder on Steam builds for Linux 2022-05-29 13:50:32 -04:00
OatmealDome 5c4122ec2a DolphinQt: Copy Sys into Binaries output folder on Steam builds for Linux 2022-05-29 13:50:32 -04:00
OatmealDome 77fb5fa7dc DolphinQt: Copy all Qt libraries into Binaries output folder on Steam builds for Linux 2022-05-29 13:50:32 -04:00
OatmealDome 6b05f5cca8 DolphinQt: Set the executable's rpath to a lib directory in $ORIGIN on Steam builds for Linux 
We will store our Qt shared libraries here.
 2022-05-29 13:50:32 -04:00
OatmealDome e679502a5d GLX: Guard against redefinition of PFNGLXSWAPINTERVALEXTPROC 
This type is already declared in glxext.h in the Steam Runtime.
 2022-05-29 13:50:32 -04:00
Tilka e17a4f49f5
Merge pull request #10668 from Dentomologist/convert_pointerwrap_mode_to_enum_class 
Convert PointerWrap::Mode to enum class
 2022-05-29 00:57:43 +01:00
Tilka 3dbc18060b
Merge pull request #10694 from Pokechu22/dsp-assembler-error-messages-etc 
DSPAssembler: Rework errors and warnings, and related cleanup
 2022-05-29 00:16:23 +01:00
Tilka 57e444cd5d
Merge pull request #10697 from Dentomologist/windows_remove_qt5_code_and_references 
Windows: Remove unused Qt5 block and reference
 2022-05-29 00:14:34 +01:00
Pokechu22 d307c34af1 DSP LLE: Rename CMPAR to CMPAXH 2022-05-27 18:22:38 -07:00
Dentomologist 059cd5f6e1 Windows: Remove unused Qt 5 code and references 2022-05-25 17:51:17 -07:00
Dentomologist c8e20c569b Convert PointerWrap::Mode to enum class 2022-05-25 13:16:46 -07:00
Dentomologist f6b9acccfc Common: Refactor PointerWrap 2022-05-25 13:06:41 -07:00
Pokechu22 2341ff00ab NetPlay: Make messages about non-matching games clearer 2022-05-24 23:20:45 -07:00
Pokechu22 ea9b0bff08 NetPlay: Delete NetPlayClient::GetPlayerList 
It's been unused since DolphinWX was removed in 44b22c90df.  Prior to that, it was used in Source/Core/DolphinWX/NetPlay/NetWindow.cpp.  But the new equivalent in Source/Core/DolphinQt/NetPlay/NetPlayDialog.cpp uses NetPlayClient::GetPlayers instead.  Stringifying (or creating a table, as is done now) should be done by the UI in any case.
 2022-05-24 14:44:28 -07:00
Tilka b6ad5c5902
Merge pull request #10683 from Pokechu22/gamelist-home-end 
GameList: Have home/end keys move to first/last row
 2022-05-24 22:10:38 +01:00
Pokechu22 bd3173e344 DSPAssembler: Rework errors and warnings 
Among other things, this trims trailing newline characters. Before (on windows) the \r would corrupt the output and make them very hard to understand (as the error message would be drawn over the code line, but part of the code line would peek out from behind it).
 2022-05-23 20:27:17 -07:00
Pokechu22 db3d457e5f DSPDisassembler: Remove redundant definition of CW 
CW is used as a fallback to write a full instruction as hex, but we already declare it in DSPTables.h for the assembler.
 2022-05-23 19:36:47 -07:00
Pokechu22 b06d38389b DSP: Remove some magic numbers for register IDs 2022-05-23 19:36:47 -07:00
Pokechu22 8b52c7315b DSP: Fix assembling x8/x9/xA/xB conditions 
The assembler upper-cases the mnemonic internally, so it never would match the lower-case x.
 2022-05-23 19:36:47 -07:00
Pokechu22 e7f6e19c61 DSPAssembler: Slightly improve readability of AssemblePass 
This should result in no behavior differences.
 2022-05-23 19:36:47 -07:00
Admiral H. Curtiss b18fd3d3ce
Core/State: Make memory layout of StateHeader more explicit. 2022-05-24 03:04:52 +02:00
Admiral H. Curtiss f68c3b758e
Common/Network: Use std::array in IPv4Header. 2022-05-23 02:01:59 +02:00
JMC47 3a3357444e
Merge pull request #8067 from endrift/hsp 
Preliminary HSP support
 2022-05-22 13:42:27 -04:00
Pokechu22 1c4a5d9fc9 GameList: Work around Qt bug regarding clicking in the background not setting the position used by page down/end 2022-05-21 23:33:46 -07:00
Admiral H. Curtiss 8d0f52032b
IOS/DI: Fake the error 001 read when running DirectoryBlobs or Riivolution-patched games. 2022-05-22 04:22:41 +02:00
Pokechu22 2d50ba0ca2 GameList: Have home/end keys move to first/last row 2022-05-21 18:11:24 -07:00
Admiral H. Curtiss 0e948f3e21
Merge pull request #10620 from phire/cmake_win_fixes 
Various fixes for msvc/cmake builds
 2022-05-22 03:08:17 +02:00
Pokechu22 8b3517a9f9
Merge pull request #10686 from Tilka/pikmin_demo 
DSPHLE: handle crc of Pikmin 1 GC US Demo
 2022-05-21 17:30:31 -07:00
Vicki Pfau 6a26b0ce8a HW: Initial HSP implementation with ARAM expansion 2022-05-21 17:05:49 -07:00
Admiral H. Curtiss 580c721c82
cmake: Don't use PCH with Qt6. 2022-05-22 01:19:44 +02:00
Admiral H. Curtiss a5e85627b0
cmake: Use Policy CMP0117 for more sensible RTTI flag configuration on MSVC. 2022-05-22 00:30:56 +02:00
Admiral H. Curtiss 9908219dc6
cmake: Add a few missing settings from the Visual Studio project files on MSVC. 2022-05-22 00:29:48 +02:00
Admiral H. Curtiss dbee810a04
cmake: Fixes for Qt6 on Windows. 2022-05-22 00:29:48 +02:00
Scott Mansell 876f6651b4
cmake: fix PCH to work with msvc/ninja 
Ninja puts way more effort into compiling targets in parallel, and
ignores dependenceis until link time.

So we need to jump though hoops to force ninja to compile
pch.cpp before any targets which depend on the PCH.
 2022-05-22 00:29:47 +02:00
Scott Mansell 0909e00117
cmake: fix MSVC PCH support 
I'm not sure if the previous implementation ever worked.
 2022-05-22 00:29:47 +02:00
Scott Mansell 2348017ee8
cmake: ignore external warnings in MSVC 
Since we also treat all warnings as errors, we need to
ignore these to successfully build.
 2022-05-22 00:29:46 +02:00
Scott Mansell 987f270083
cmake: fix buggy target sources on windows 
I have no idea why cmake supports PUBLIC on target_sources,
but it does. It causes all targets that depend on this target
to try and include the files in their sources.
Except it doesn't take paths into account, so it breaks. Mabye
it would work if you used an abolute source? But I'm not sure
there is a sane usecase.
 2022-05-22 00:29:46 +02:00
Sage King f0454ab2fa Added double click to add expressions when mapping 2022-05-21 14:08:49 -06:00
Tillmann Karras d7da4aca19 DSPHLE: handle crc of Pikmin 1 GC US Demo 
The DSP code only has minor differences to the final release.
 2022-05-21 16:48:34 +01:00
Pokechu22 863cb591fe MainSettings: Make MAIN_CUSTOM_RTC_VALUE default value less magical 2022-05-20 20:35:53 -07:00
Mai M 244e4acff2
Merge pull request #10674 from OatmealDome/mac-steam-overlay 
DolphinQt: Add com.apple.security.cs.allow-dyld-environment-variables to entitlements
 2022-05-19 22:43:57 -04:00
Pokechu22 151119cece DSPInterpreter: Fix typo in isOverflow comment 2022-05-19 16:36:39 -07:00
Mai M a98d0367d8
Merge pull request #10677 from Pokechu22/no-printf-log 
Remove printf-style logging
 2022-05-19 17:55:17 -04:00
Pokechu22 2aa0ae097b
Merge pull request #10672 from Pokechu22/xf-invtxspec 
Show panic alerts if the CP configuration doesn't match the XF configuration
 2022-05-19 13:13:53 -07:00
Pokechu22 8baeb75bd2
Merge pull request #10669 from Pokechu22/adapter-change-aa-mode-list-reload 
Fix antialiasing modes being determined from the wrong graphics adapter
 2022-05-19 13:13:22 -07:00
Pokechu22 5f9212dd84 Common/LogManager: Remove old printf-style logging functions 2022-05-19 12:41:58 -07:00
Pokechu22 0637c17b59 VideoCommon/FrameDump: printf-format messages before logging them 2022-05-19 12:41:58 -07:00
Pokechu22 35cb5c8f75 EXI_DeviceEthernet: Replace INFO_LOG with INFO_LOG_FMT 2022-05-19 12:41:58 -07:00
Pokechu22 2f5e69a94e JitArm64: Replace WARN_LOG with WARN_LOG_FMT 2022-05-19 12:41:57 -07:00
Pokechu22 642a1c1348 MainWindow: Replace WARN_LOG with WARN_LOG_FMT 2022-05-19 12:41:57 -07:00
Pokechu22 0faf0b80ad TAPServer_Apple: Use fmt logging 2022-05-19 12:41:57 -07:00
Dentomologist 6ffd938f98 UnitTests: Skip PageFaultTest if exception handlers are not supported 
Page faults should only occur on architectures that support exception
handlers, so skip the test on other architectures to avoid spurious test
failures.
 2022-05-19 12:26:41 -07:00
Pokechu22 a86fb9b475 Core/WGInput: Use fmt logging and include HRESULT in messages 2022-05-19 12:12:19 -07:00
OatmealDome 185188c009 DolphinQt: Add com.apple.security.cs.allow-dyld-environment-variables to entitlements 2022-05-18 20:23:17 -04:00
Pokechu22 8df55b492c Show a panic alert if the CP matrix indices don't match the XF matrix indices 
This almost certainly never happens, but if it does we want to know.
 2022-05-18 14:43:14 -07:00
Pokechu22 38a75f6a49 Show a panic alert if the CP vertex config doesn't match the XF vertex config 
This probably isn't triggered by real games, but it's possible to accidentally do it with libogc (which results in freezes on real hardware).
 2022-05-18 14:43:14 -07:00
Pokechu22 46bcdc4372 Rename CP and XF normal component count enums and update their descriptions 2022-05-18 14:43:14 -07:00
Pokechu22 736466a5d9 XFMemory: Rename hostinfo to invtxspec 2022-05-18 14:43:14 -07:00
Pokechu22 3949698acf Verify graphics config validity after populating the backend info 
... and refresh the config before populating the backend info, as the config (specifically iAdapter) needs to be set to correctly populate the backend info.

Before, the list of valid antialiasing modes was always determined from the first adapter on the list on startup, regardless of the adapter the user selected.
 2022-05-16 16:59:57 -07:00
Pokechu22 3950bc4620 Treat changing the graphics adapter the same as changing the backend 
This results in the list of available antialiasing modes being updated; before, it would only show the modes available for the adapter that was selected when the graphics window was opened (or the backend was last changed).

The list of available modes is updated by `GraphicsWindow::OnBackendChanged`'s call to `VideoBackendBase::PopulateBackendInfoFromUI`, and then `EnhancementsWidget::LoadSettings` updates the UI.  Both of these are connected to the `GraphicsWindow::BackendChanged` signal.
 2022-05-16 16:59:31 -07:00
Mai M 4085d463a1
Merge pull request #10661 from Tilka/ax_init 
AX: refactor buffer initialization
 2022-05-16 14:23:13 -04:00
Admiral H. Curtiss b10808d815
Merge pull request #8763 from JosJuice/panic-alert-deadlock-gpu 
DolphinQt: Fix the panic alert deadlock, dual core edition
 2022-05-16 02:21:14 +02:00
Tillmann Karras ac7aeeece6 AX: refactor buffer initialization 2022-05-15 00:24:38 +01:00
Pokechu22 b8cca8f598 ProcessorInterface: Implement PI_FIFO_RESET 
Fixes unknown opcodes 0x0f and 0xff when resetting titles, e.g. https://bugs.dolphin-emu.org/issues/12492
 2022-05-13 14:20:14 -07:00
Tilka fcb3f9e35b
Merge pull request #10652 from shuffle2/fmt 
update fmt and fix warnings that popped up with vs 17.2
 2022-05-13 22:09:01 +01:00
Tillmann Karras 855dbf88ca AX: handle DPL2 mixer control in old GameCube titles 
This fixes the audio test in Rogue Squadron 2 (issue 12902).
 2022-05-13 00:18:24 +01:00
Tillmann Karras 8438e647f2 AXWii: handle mixer control more precisely 
On GameCube, a ramp bit has no effect if its corresponding channel is
inactive. On Wii however, enabling just the ramp implicitly also enables
the channel. AXSetVoiceMix() never does that, so this commit should have
no impact on games unless they fiddle with the mixer control value
directly.
 2022-05-12 21:21:03 +01:00
Tilka 333659cefa
Merge pull request #10643 from Tilka/ax_cleanup 
AX: fix missing ramp of main surround channel
 2022-05-12 21:12:04 +01:00
Shawn Hoffman 7b8e6c5b36 fmt: do not define uint type in global namespace 2022-05-10 21:17:10 -07:00
Shawn Hoffman fa17153ebc fmt: use make_format_args instead of make_args_checked 
make_args_checked is deprecated
see https://github.com/fmtlib/fmt/pull/2760 and the linked comment
 2022-05-10 19:25:48 -07:00
Shawn Hoffman 56626f73bf fmt: fix 'ambigous overload' error 2022-05-10 19:19:52 -07:00
Tilka c41467a8eb
Merge pull request #10650 from AdmiralCurtiss/memory-widget-resize-fix 
Qt/MemoryViewWidget: Fix resizing.
 2022-05-10 21:25:33 +01:00
Admiral H. Curtiss 828ce0f3cf
Qt/MemoryViewWidget: Fix resizing. 2022-05-10 12:35:37 +02:00
Tilka a768dc6f80
Merge pull request #10374 from Pokechu22/slots-unused-warning 
Work around false SLOTS defined but not used warning on GCC
 2022-05-09 22:28:59 +01:00
Pokechu22 61a144ba06 Show a panic alert if movie is missing its starting savestate 2022-05-09 13:32:38 -07:00
Tilka d82f2d7314
Merge pull request #10612 from AdmiralCurtiss/memory-widget-refactoring-2 
Qt/MemoryViewWidget: Replace the click-to-center behavior with a scrollbar.
 2022-05-09 20:11:58 +01:00
Tilka 5ef17e60d0
Merge pull request #10633 from Minty-Meeo/generate-from-address-fix 
Index SymbolDB when generated from address
 2022-05-09 19:38:25 +01:00
Shawn Hoffman 5d459380d1 qt/win: remove hack for tab bar scroll buttons 2022-05-09 01:45:42 -07:00
Admiral H. Curtiss 7f94e62dd5
Qt/MemoryViewWidget: Remove the behavior that clicking anywhere in the table centers the table on that row. 2022-05-08 23:14:37 +02:00
Admiral H. Curtiss 88dd9e57f3
Qt/MemoryViewWidget: Add a custom scrollbar. 2022-05-08 23:14:37 +02:00
Admiral H. Curtiss 4e153212a0
Qt/MemoryViewWidget: Convert into QWidget that has the table as a member. 2022-05-08 23:14:36 +02:00
Admiral H. Curtiss 0e1e2323ea
Qt/MemoryViewWidget: Keyboard navigation should observe the number of bytes per row instead of assuming 16. 2022-05-08 23:14:36 +02:00
Admiral H. Curtiss b339c6cac1
Merge pull request #10594 from AdmiralCurtiss/gamecube-pane-signal-block 
Qt/GameCubePane: Don't trigger config change events when populating GUI.
 2022-05-08 20:54:51 +02:00
Admiral H. Curtiss 6e54233eb8
Merge pull request #10593 from AdmiralCurtiss/interface-pane-signal-block 
Qt/InterfacePane: Don't trigger config change events when populating GUI.
 2022-05-08 20:43:09 +02:00
JosJuice e19b995a1c
Merge pull request #10644 from shuffle2/hide-balloon 
Qt: hide balloon tooltip when parent gets hidden
 2022-05-08 17:46:12 +02:00
Admiral H. Curtiss 02ef946e81
HW/Memmap: Refuse to load savestate if memory settings are different. 2022-05-08 11:06:27 +02:00
Admiral H. Curtiss e2dee9c3f8
Qt/InterfacePane: Don't trigger config change events when populating GUI. 2022-05-08 11:04:39 +02:00
Admiral H. Curtiss 1d224d1da5
Qt/GameCubePane: Don't trigger config change events when populating GUI. 2022-05-08 11:03:33 +02:00
Admiral H. Curtiss 67ee78b9dc
Merge pull request #10621 from TryTwo/PR_Register_Column_Type 
Debugger RegisterWidget Add option to change column's display type
 2022-05-08 10:59:05 +02:00
Shawn Hoffman 1e033a4f73 Qt: hide balloon tooltip when parent gets hidden 
fixes balloon remaining onscreen when parent gets
hidden via escape key for example.
 2022-05-08 00:48:30 -07:00
JMC47 5f04ad5c3c
Merge pull request #10559 from shuffle2/qt6 
update to Qt6 on windows, support Qt6 elsewhere
 2022-05-08 01:29:46 -04:00
Mai M 997754bf3b
Merge pull request #10642 from JosJuice/refactor-mmu-read 
PowerPC: Refactor ReadFromHardware
 2022-05-07 17:18:17 -04:00
JosJuice b6b7030482 PowerPC: Add HW_PAGE_MASK constant 2022-05-07 19:37:44 +02:00
Tillmann Karras e6e283a11c AX: rename main depop fields and mixer flags 2022-05-07 18:30:32 +01:00
Tillmann Karras 048469f7c2 AX: fix missing ramp of main surround channel 2022-05-07 18:20:48 +01:00
JosJuice ed40b43960 PowerPC: Reorder code in ReadFromHardware 
This refactorization is done just to match the order that I made
WriteToHardware use in 543ed8a. For WriteToHardware, it's important that
things like MMIO and gather pipe are handled before we reach a special
piece of code that only should get triggered for writes that hit memory
directly, but for ReadFromHardware we don't have any code like that.
 2022-05-07 15:52:35 +02:00
JosJuice 3b3c60dc4c PowerPC: Check page crossing for non-translated reads 
This fixes a problem where Dolphin could crash if a non-translated
read crossed the end of a physical memory region.

The same change was applied to WriteToHardware in ecbce0a.
 2022-05-07 15:41:21 +02:00
Mai M 9858a79974
Merge pull request #10640 from JosJuice/jitarm64-low-dcbz 
JitArm64: Implement low DCBZ hack
 2022-05-07 09:39:49 -04:00
JosJuice 16eb188f1d JitArm64: Implement low DCBZ hack 
JitArm64 port of 76228fa.
 2022-05-07 15:37:50 +02:00
Tillmann Karras f65b7066f5 AX: put each volume and its ramp delta into a dedicated struct (NFC) 2022-05-07 13:19:15 +01:00
Tillmann Karras 83858e68d4 AX: clarify main LRS channel names (NFC) 2022-05-07 13:19:15 +01:00
OatmealDome baabd63f81 WiiUtils: Change default NUS Shop URL to Dolphin's fake NUS 2022-05-05 15:21:02 -04:00
OatmealDome 8c669efe76 MainSettings: Add setting to control Wii NUS Shop URL for system updates 2022-05-05 00:35:53 -04:00
Minty-Meeo 8fec3224fc Index SymbolDB when generated from address 
Otherwise every function will be the same color in the code view widget.
 2022-05-03 21:20:00 -05:00
Mai M d0ed09ab6f
Merge pull request #10632 from Tilka/ax_ub 
AX: prevent undefined behavior
 2022-05-03 20:13:07 -04:00
Tilka ac643825ce
Merge pull request #10628 from Minty-Meeo/force_inline-minor-change 
Change _WIN32 check to a _MSC_VER check in Inline.h
 2022-05-03 23:07:40 +01:00
Tilka f75f19ae6a
Merge pull request #10629 from Tilka/spaces 
DolphinTool: add missing spaces in help text
 2022-05-03 23:01:25 +01:00
Tillmann Karras aee547aa0e AX: prevent undefined behavior 
u16 gets promoted to s32 where changing the uppermost bit is UB.
 2022-05-03 22:17:24 +01:00
spycrab 004e8a80b2 Add support for building against Qt 6 2022-05-02 22:39:33 -07:00
Tillmann Karras 4b66ce6c4d DolphinTool: add missing spaces in help text 2022-05-02 12:19:01 +01:00
Minty-Meeo 9c22205ab1 Change _WIN32 check to a _MSC_VER check in Inline.h 
This is compiler dependent, not OS dependent.
 2022-05-02 01:57:36 -05:00
TryTwo 95175bbb96 Debugger RegisterWidget: Add context options to change entire column's display type. 2022-04-29 17:21:39 -07:00
Shawn Hoffman 64cd4cc86f msbuild: use default Project attrs 
maybe it makes the xml less scary :D
 2022-04-27 15:26:43 -07:00
Shawn Hoffman 2808909a97 msbuild: simplify lang/scm projects a bit 2022-04-27 15:06:04 -07:00
Mai M e4695e329c
Merge pull request #10616 from shuffle2/fmt-lib 
msbuild: fmt static library
 2022-04-26 23:25:58 -04:00
Shawn Hoffman 44951a4cbc use fmt as static library instead of headers 
reportedly improves compile time
 2022-04-26 16:32:29 -07:00
Admiral H. Curtiss 01d4a2e9cc
TextureCacheBase: Don't log error while measuring state size. 2022-04-26 21:26:42 +02:00
JMC47 c0488de482
Merge pull request #10251 from Pokechu22/negative-scissor 
Rework scissor handling
 2022-04-24 15:00:42 -04:00
Pokechu22 8e7c848425
Merge pull request #10601 from Pokechu22/vulkan-shader-compile-error 
Vulkan: Improve shader compile error handling
 2022-04-24 11:43:10 -07:00
JMC47 c42392c565
Merge pull request #10290 from OatmealDome/m1-earlyz-bug 
DriverDetails: Add broken discard with early-Z bug on Apple Silicon GPUs
 2022-04-24 13:30:04 -04:00
Admiral H. Curtiss 61edcf7e4f
Merge pull request #10606 from AdmiralCurtiss/memory-widget-refactoring-1 
Qt/MemoryWidget: Light refactoring and quality of life features.
 2022-04-24 18:02:19 +02:00
Admiral H. Curtiss 787e3efeb8
Qt/MemoryViewWidget: Detect row breakpoint cell by cell data instead of cell position. 2022-04-24 16:22:36 +02:00
Admiral H. Curtiss 6920a24f1d
Qt/MemoryViewWidget: Add option to copy the actually displayed cell value to clipboard. 2022-04-24 16:22:36 +02:00
Admiral H. Curtiss 54ec0bd0d0
Qt/MemoryViewWidget: Don't use a member variable to hold information about the current mouse click. 2022-04-24 16:14:42 +02:00
JosJuice 6abf367676
Merge pull request #10588 from JosJuice/jitarm64-psq-stxx-q0 
JitArm64: Always lock Q0 in psq_stXX
 2022-04-24 10:37:45 +02:00
Admiral H. Curtiss 26f9c8b847
Qt/MemoryWidget: Don't force a fixed size for the sidebar. 2022-04-24 05:24:20 +02:00
Admiral H. Curtiss 4c080b8451
Merge pull request #10578 from TryTwo/PR_MemoryWidget_Dual_Views 
Debugger MemoryWidget: Add dual views
 2022-04-23 22:23:31 +02:00
JosJuice e0afcb3b94
Merge pull request #10540 from nyanpasu64/fix-gcadapter-atomics 
Remove atomic usage and fix mutex locking in GCAdapter code
 2022-04-23 22:04:10 +02:00
Admiral H. Curtiss 8b5a61b8fd
Merge pull request #10599 from shuffle2/libusb 
Libusb fixups
 2022-04-23 20:32:47 +02:00
TryTwo a7111e3910 Dual View any size. 2022-04-23 02:46:25 -07:00
JosJuice 14f9ffeb02 JitArm64: Add documentation comment for EmitBackpatchRoutine 2022-04-23 11:37:52 +02:00
Pokechu22 784079853d VideoCommon: Add comment explaining why only the first normal gets normalized 
Co-authored-by: Scott Mansell <phiren@gmail.com>
 2022-04-22 16:54:38 -07:00
Pokechu22 2a5c77f43f VideoCommon: Handle emboss texgen with only a single normal 
Fixes a large number of effects in Rogue Squadron 2 and 3.
 2022-04-22 16:54:38 -07:00
Pokechu22 39b2854b98 VertexLoader: Convert count register to remaining register 
This more accurately represents what's going on, and also ends at 0 instead of 1, making some indexing operations easier.  This also changes it so that position_matrix_index_cache actually starts from index 0 instead of index 1.
 2022-04-22 16:54:38 -07:00
Pokechu22 97d0ff58c8 Convert vertex loader position cache to std::array 2022-04-22 16:54:38 -07:00
Pokechu22 f722bdf7f1 VertexLoaderX64: Refactor so that zfreeze is only in one place 
(Specifically, the copy for VertexLoaderManager::position_cache.  The position matrix index happens elsewhere, and the float path still has special logic to copy to scratch3.)
 2022-04-22 16:54:38 -07:00
Pokechu22 6f1350ae51 VertexLoaderARM64: Fix z-freeze position matrix index 
Before, it would always write to index 0 (which is unused).  Now it writes to the correct index.
 2022-04-22 16:54:38 -07:00
Pokechu22 04fdadd9d5 VideoCommon: Rename norm0/norm1/norm2 to normal/tangent/binormal 2022-04-22 16:54:36 -07:00
Pokechu22 88134a6786 VertexShaderGen: Simplify normal calculation 
This is a readability change; there should be no functional or performance differences.
 2022-04-22 16:51:58 -07:00
Pokechu22 0f92ab380e Vulkan: Include the info log in the shader compile error panic alert 
The other backends do this, and it is helpful for quickly identifying errors during development.
 2022-04-22 16:38:35 -07:00
Pokechu22 7ae71e643e Vulkan: Close the output stream on shader compile error before showing the panic alert 
This fixes the file showing up as 0 bytes in Windows Explorer (although the file would still display properly when opened).
 2022-04-22 16:37:43 -07:00
Shawn Hoffman 12cd81bdb3 GCAdapter: don't call libusb_detach_kernel_driver on apple 2022-04-22 09:56:47 -07:00
Shawn Hoffman 5cd3cf9072 GCAdapter: fix retval check of libusb_detach_kernel_driver 2022-04-22 09:56:47 -07:00
Shawn Hoffman 978c90845b GCAdapter: move libusb context teardown last 2022-04-22 09:56:47 -07:00
Shawn Hoffman 1c9dfb7bb6 GCAdapter: some macro cleanup 2022-04-22 09:56:47 -07:00
Shawn Hoffman f52d94832e GCAdapter: set read/write thread names 2022-04-22 07:12:09 -07:00
OatmealDome 259a5fc7c0 DriverDetails: Add broken discard with early-Z bug on Apple Silicon GPUs 2022-04-20 14:56:34 -04:00
OatmealDome e7f5e5172c DriverDetails: Introduce new VENDOR_APPLE for Apple GPUs 2022-04-19 10:55:27 -04:00
OatmealDome 80dfefb32e UberShaderPixel: Add support for non-dual source shader blending 2022-04-19 10:55:26 -04:00
OatmealDome c1d87db6fa PixelShaderGen: Add support for non-dual source shader blending 2022-04-19 10:55:26 -04:00
OatmealDome bad0283ff7 VKPipeline: Add shader blending support 2022-04-19 10:55:26 -04:00
Admiral H. Curtiss ef760ee012
Common/PointerWrap: Prevent reads/writes past the end of the buffer. 2022-04-18 23:48:00 +02:00
Admiral H. Curtiss 853cf4f818
Common/PointerWrap: Hide internals. 2022-04-18 03:41:14 +02:00
TryTwo cc22f1a558 MemoryWidget add dual views for two separate column types. Force first column to be Hex32. 2022-04-17 00:15:44 -07:00
Pokechu22 f3eff70e2f Implement ImGui window for scissor rectangles 
This is mainly for debugging, and is only exposed by manually editing the configuration.
 2022-04-16 12:35:00 -07:00
Pokechu22 4d1e1db3c5 Software: Fix scissor rectangle always being block-aligned 2022-04-16 12:35:00 -07:00
Pokechu22 8745d84949 Software: Disable clipping based on xfmem 
This fixes https://bugs.dolphin-emu.org/issues/12562, and is also needed for a hardware test of mine.
 2022-04-16 12:35:00 -07:00
Pokechu22 925ceab82f Software: Use new scissor logic 
Unlike the hardware backends, the software renderer can use multiple scissor rectangles (though this will result in extra rasterization).
 2022-04-16 12:34:58 -07:00
Pokechu22 076392a0f6 VideoCommon: Rework scissor handling 
This increases accuracy, fixing the white rendering in Major Minor's Majestic March.  However, the hardware backends can only have one viewport and scissor rectangle at a time, while sometimes multiple are needed to accurately emulate what is happening.  If possible, this will need to be fixed later.
 2022-04-16 10:26:11 -07:00
Pokechu22 4595b89ad8 VideoCommon: Remove bSupportsOversizedViewports 
I think this is a relic of D3D9.  D3D11 and D3D12 seem to work fine without it.  Plus, ViewportCorrectionMatrix just didn't work correctly (at least with the viewports being generated by the new scissor code).
 2022-04-16 10:26:11 -07:00
Pokechu22 b85b35d5ea VideoCommon: Create dedicated structs for scissor pos/offset 2022-04-16 10:26:10 -07:00
Admiral H. Curtiss 0ec3f3a6ae
Merge pull request #10563 from TryTwo/PR_MemoryWidget_Display_Types 
Debugger MemoryWidget: More display types, use combo box for options
 2022-04-16 14:35:29 +02:00
JosJuice 2ef2d4778d JitArm64: Always lock Q0 in psq_stXX 
Q0 is used as a scratch register by EmitBackpatchRoutine.

Fixes a vertex explosion in Spider-Man 2 that was uncovered by 20b2300.
 2022-04-16 13:22:36 +02:00
TryTwo a2aecc3794 Debugger MemoryWidget: More display types, use combo box for display options. Add alignment and riw length options. 2022-04-15 22:00:51 -07:00
Admiral H. Curtiss 0a4805c0b9
Merge pull request #10582 from AdmiralCurtiss/fmt-float 
Common/StringUtil: Use simpler formatting for floats and doubles.
 2022-04-16 03:42:55 +02:00
Scott Mansell c5c4169bc8
Merge pull request #10255 from Pokechu22/sw-zfreeze 
Software: Fix zfreeze with CullMode::All
 2022-04-15 11:12:49 +12:00
Admiral H. Curtiss 3fdc6cbffe
Merge pull request #10486 from ttttcrngyblflpp/negative-axis-scaling 
Make pos/neg analog axes symmetrical
 2022-04-13 12:18:41 +02:00
Admiral H. Curtiss 5c687fc2a3
Common/StringUtil: Use simpler formatting for floats and doubles. 2022-04-12 23:35:19 +02:00
Shawn Hoffman ef8e461ca2 windows: buildfix if pch not used 2022-04-12 12:28:57 -07:00
Admiral H. Curtiss 2f90a2c689
Merge pull request #10574 from EternityShack/master 
MemoryWidget: Load Files to Memory
 2022-04-11 04:09:02 +02:00
EternityShack c5b0b92513 MemoryWidget: Load Files to Memory 2022-04-10 21:02:33 -05:00
JosJuice abffa93a72 MoltenVK: Fix pixel shader typo 2022-04-10 20:51:20 +02:00
Mai M e932a1bfb7
Merge pull request #10571 from AdmiralCurtiss/ffmpeg-custom-pix-fmt 
VideoCommon/FrameDump: Allow user to specify a pixel format.
 2022-04-09 14:19:39 -04:00
Pokechu22 59f299d5d6 Software: Fix zfreeze with CullMode::All 2022-04-08 20:05:32 -07:00
Pokechu22 164e0f742d Software: Store offset in Slope 
This is needed since we need a separate offset for zfreeze to work correctly.  It also makes the code a bit less jank.
 2022-04-08 20:05:32 -07:00
Pokechu22 3a742e99bb Software: Remove config to disable ZComploc and ZFreeze 
These aren't particularly useful, and make the code a bit more confusing.  If for some reason someone wants to test what happens when these functions are disabled, it's easier to just edit the code that implements them.  They aren't exposed in the UI, so one would need to restart Dolphin to do it anyways.
 2022-04-08 20:05:32 -07:00
Pokechu22 4e9a314776 Round viewport coordinates when vertex rounding is enabled 
This should fix https://bugs.dolphin-emu.org/issues/9105
 2022-04-08 18:30:59 -07:00
Pokechu22 dbb857b175 VertexShaderManager: Use g_ActiveConfig.UseVertexRounding() 2022-04-08 18:30:59 -07:00
Pokechu22 f6ab317374 Fix typo (GFX_HACK_VERTEX_ROUDING -> GFX_HACK_VERTEX_ROUNDING) 2022-04-08 18:30:59 -07:00
Mai M 91192efe59
Merge pull request #10573 from AdmiralCurtiss/pr10472 
DolphinQt/HacksWidget: Re-enable texture accuracy slider if it was disabled because of a custom value.
 2022-04-08 21:24:59 -04:00
3t13nn3 5516d468ce
DolphinQt/HacksWidget: Re-enable texture accuracy slider if it was disabled because of a custom value. 
Fixes https://bugs.dolphin-emu.org/issues/12771
 2022-04-09 03:01:10 +02:00
Mai M 004e834c14
Merge pull request #10558 from shuffle2/lang 
windows: simplify handling of gettext
 2022-04-08 20:51:36 -04:00
Admiral H. Curtiss df214af8a1
VideoCommon/FrameDump: Fix log messages with arguments. 2022-04-09 01:42:02 +02:00
Admiral H. Curtiss 36134abd0e
Common/LogManager: Add generic printf-style log function that takes a va_list instead of va_args. 2022-04-09 01:41:40 +02:00
Admiral H. Curtiss 3382408b8e
VideoCommon/FrameDump: Allow user to specify a pixel format. 2022-04-09 00:45:49 +02:00
Pokechu22 120208ae03
Merge pull request #10543 from Minty-Meeo/initmmio-combine 
Combine InitMMIO and InitMMIOWii
 2022-04-08 14:35:03 -07:00
Admiral H. Curtiss 23508cafb2
Merge pull request #7675 from TryTwo/Debugger_Code_Features 
Debugger: Get target memory in load/store instructions
 2022-04-08 05:28:22 +02:00
Admiral H. Curtiss 5fda8ee8ec
Core/WGInput: Dynamically load winrt function addresses. 2022-04-08 03:26:09 +02:00
JMC47 e02194057b
Merge pull request #10412 from Pokechu22/sw-efb-peek-alpha 
Software: Implement pixel engine alpha read mode
 2022-04-07 17:01:56 -04:00
JosJuice 7a33659e7b
Merge pull request #10485 from JosJuice/real-ocol0-logic-ops 
Shadergen: Use real_ocol0 workaround for shader logic ops
 2022-04-07 21:00:24 +02:00
JosJuice 6a326a9f73
Merge pull request #10544 from AdmiralCurtiss/default-font-size-workaround 
Qt: Set font size for default debug font.
 2022-04-07 20:59:17 +02:00
Pokechu22 6e83e36beb msbuild: Move WGInput to DolphinLib.props 
It was accidentally put into the main DolphinLib.vcxproj in #7614.
 2022-04-07 11:37:12 -07:00
Sepalani 5b658e77df MemoryWidget: Fix preview of zero as float/double 2022-04-07 11:55:23 +04:00
Admiral H. Curtiss 368342cb9b
Merge pull request #10528 from TryTwo/PR_Debugger_Memory_Input_Types 
Debugger: MemoryWidget: add float and integer input types. Add input preview.
 2022-04-07 02:13:21 +02:00
TryTwo ed96b8e308 Debugger MemoryWidget: add float and integer inputs. Add input preview. Change input logic. Use combobox for options. 2022-04-06 16:20:55 -07:00
Admiral H. Curtiss 242cd4cbea
Merge pull request #10555 from Dentomologist/fix_manual_update_check_when_autoupdate_disabled 
Updater: Fix manual update check when autoupdate is disabled
 2022-04-06 14:38:25 +02:00
Jordan Woyak 566dfc1cf4 ControllerInterface: Update sort priorities. 2022-04-03 19:03:44 -05:00
Jordan Woyak 076a262b9e InputCommon: Add Windows.Gaming.Input to ControllerInterface. 2022-04-03 19:03:35 -05:00
Shawn Hoffman db4d81b9a8 windows: simplify handling of gettext 
fixes binplace on first build
 2022-04-02 15:24:46 -07:00
Dentomologist c8d953d0c6 Updater: Fix manual update check when autoupdate is disabled 2022-04-02 12:22:06 -07:00
Admiral H. Curtiss 113fdc959d
Merge pull request #10534 from AdmiralCurtiss/more-cheat-search-qol 
DolphinQt: More Cheat Search QoL
 2022-04-02 15:17:15 +02:00
Admiral H. Curtiss 25c173cefc
Merge pull request #8732 from dreamsyntax/debugger-function-differencing 
Qt/Debugger CodeWidget: Record and find specific functions by differencing
 2022-04-02 05:42:33 +02:00
Admiral H. Curtiss 1942629d9a
DolphinQt/CheatSearchWidget: Drop whitespace when parsing integers and floats from the user. 2022-03-31 05:40:51 +02:00
Admiral H. Curtiss 7f2fed0f68
DolphinQt/CheatsManager: Don't leak closed cheat search tabs. 2022-03-31 05:40:51 +02:00
Admiral H. Curtiss 48c4ebeee0
DolphinQt/CheatSearchWidget: Remember state of Hex checkboxes across sessions. 2022-03-31 05:40:51 +02:00
Admiral H. Curtiss 1ad7aac008
Qt: Set font size for default debug font. 2022-03-31 05:28:39 +02:00
Admiral H. Curtiss 4957b2edb9
Merge pull request #10530 from shuffle2/win-ffmpeg 
windows: move ffmpeg bins to submodule
 2022-03-31 05:24:00 +02:00
Admiral H. Curtiss cc3f8204da
Merge pull request #10542 from TryTwo/PR_MemoryViewWidget_Spacing 
Debugger MemoryViewWidget: fixed, tighter spacing
 2022-03-30 22:53:05 +02:00
Shawn Hoffman 4fad2c26e4 framedump: enable compat with utvideo codec 2022-03-29 17:27:59 -07:00
Shawn Hoffman decaea8f9b FrameDump: improve debug logging 2022-03-29 17:27:59 -07:00
Shawn Hoffman 09432ef098 windows: move ffmpeg bins to submodule 
udpate ffmpeg to b1cbeabf5e4b3234e895a58bafa371bfb792baf0
enable ffmpeg on arm64
 2022-03-29 17:27:46 -07:00
Pokechu22 af316f7bfe Software: Implement pixel engine alpha read mode 2022-03-29 15:34:43 -07:00
Pokechu22 8882eb040a PixelEngine: Convert to BitField and enum class 2022-03-29 15:34:43 -07:00
Pokechu22 45b8ebeb25 PixelEngine: Remove old comment 
This comment was added in 76d24f2c0d (the link was updated in 5799824b22, but both are dead now).  An archived version is at https://web.archive.org/web/20090830050441/http://developer.nvidia.com/object/General_FAQ.html#t6 but it's about the number of available texture units, which doesn't seem relevant to PixelEngine.
 2022-03-29 15:34:43 -07:00
TryTwo 8f85e384c3 Debugger MemoryViewWidget: fixed, tighter spacing 2022-03-29 14:16:25 -07:00
Minty-Meeo fbc9bf2342 Combine InitMMIO and InitMMIOWii 2022-03-29 01:21:17 -05:00
nyanpasu64 b5a7ae52b5 Fix locking the wrong mutex in GCAdapter_Android.cpp ResetRumble() 
I am not confident there are no race conditions between s_write_mutex,
s_controller_write_payload_size, and s_controller_write_payload. But
this code should be safer than before.
 2022-03-27 22:39:26 -07:00
nyanpasu64 7616027684 Remove unnecessary atomic usage in GCAdapter_Android.cpp 
s_controller_write_payload_size needs to remain an atomic because Read()
loads and stores without holding a mutex, Output() stores while holding
s_write_mutex, and ResetRumble() stores while holding s_read_mutex! I'm
pretty sure this code is wrong, specifically ResetRumble().
 2022-03-27 22:39:26 -07:00
nyanpasu64 871b01a5d9 Remove unnecessary atomic usage in GCAdapter.cpp 
You can safely read or write non-atomic integers on multiple threads,
as long as every thread reading or writing it holds the same mutex
while doing so (here, s_mutex).

Removing the atomic accesses makes the code faster, but the actual
performance difference is probably negligible.
 2022-03-27 22:27:57 -07:00
Admiral H. Curtiss b379df360a
Merge pull request #10497 from martinD2014/master 
Change the highlighted button on each window
 2022-03-27 16:05:23 +02:00
dreamsyntax 88a1acdfc0 implement CodeDiffTool Feature 
Add Diff button to CodeWidget
Add Code Diff Tool window for recording and differencing functions. Allows finding specific functions based on when they run.
 2022-03-26 11:41:08 -07:00
Admiral H. Curtiss 379de5de15
Merge pull request #10375 from Pokechu22/imgui-assert 
Externals: Use Common ASSERT for IM_ASSERT
 2022-03-26 05:53:59 +01:00
Admiral H. Curtiss 57d8f2112c
Merge pull request #10514 from JosJuice/datel-no-gametdb 
DiscIO: Don't return GameTDB ID for any Datel disc
 2022-03-26 03:38:57 +01:00
Pokechu22 30a34d06c1 RenderBase: Add call to IMGUI_CHECKVERSION() 2022-03-25 10:24:07 -07:00
Admiral H. Curtiss e58cf36ca1
Merge pull request #10079 from sepalani/neg-offset 
MemoryWidget: Add negative offset search support
 2022-03-25 07:09:08 +01:00
Sepalani d5916fd14c MemoryWidget: Add negative offset search support 2022-03-24 23:06:25 +04:00
JosJuice c8f4800fb2
Merge pull request #10531 from iwubcode/opengl_objlabel_fix 
VideoBackends: fix opengl object label identifier
 2022-03-24 18:02:32 +01:00
iwubcode 69e79045a3 VideoBackends: fix opengl object label which was given an invalid enumeration as the identifier parameter. Most implementations will warn in this case but there is an implementation that will crash (ANGLE) 2022-03-24 00:25:59 -05:00
Admiral H. Curtiss 1a5a52c00c
Merge pull request #10507 from JosJuice/convertcommand-non-gc-wii 
DolphinTool: Allow converting non-GC/Wii files
 2022-03-23 22:47:41 +01:00
Admiral H. Curtiss c661a75961
DolphinQt: Set emulation speed setting only when the combobox is actually touched. 2022-03-22 19:19:47 +01:00
JosJuice d0d27028a0 DolphinTool: Allow converting non-GC/Wii files 
This was requested by a forum user, and I thought why not.
It's a simple change to make since DiscIO already supports it,
and I assume command-line users know roughly what they're doing.
 2022-03-22 18:59:01 +01:00
Admiral H. Curtiss b466b9ef85
Merge pull request #10464 from Zarklord/override-wii-boot-ios 
Add Override for Boot IOS for Wii Titles
 2022-03-22 03:01:44 +01:00
JMC47 bb7f0e18dd
Merge pull request #10524 from JosJuice/angle-in 
VideoCommon: Remove redundant in qualifiers
 2022-03-21 19:16:13 -04:00
JosJuice f1f02180fa VideoCommon: Remove redundant in qualifiers 
ANGLE raises a compilation error otherwise.
 2022-03-21 22:16:25 +01:00
Zachary Lockwood 9130ad8fbe Add support for overriding the IOS that boots with a wii game 2022-03-20 09:47:06 -04:00
Admiral H. Curtiss 7b0d5f2df3
Merge pull request #10491 from Minty-Meeo/dolphin-tool-more-stuff 
More dolphin-tool features and options
 2022-03-20 05:43:53 +01:00
Minty-Meeo deba9ce256 Added a way to check Block Size, Compression Method, and Compression Level flags to dolphin-tool 
New dolphin-tool command: "header"
-b / --block_size
-c / --compression
-l / --compression_level

Informative RVZ/WIA header2 value "compression_level" is now a s32 instead of a u32, because negative compression is a thing.

Speaking of, it is now possible to use negative compression levels in dolphin-tool's convert command (not the GUI, though).
 2022-03-19 17:13:28 -05:00
Admiral H. Curtiss f5657d0a83
Merge pull request #10174 from dreamsyntax/panic-handles-restore-messages 
DolphinQt: Add "Reset Ignore Panic Handler" MenuBar Option
 2022-03-19 16:52:20 +01:00
JMC47 edd63d8c3f
Merge pull request #10519 from jordan-woyak/fix-hotkey-detections 
MappingCommon: Fix detection of hotkey and conjunction expressions.
 2022-03-19 00:41:00 -04:00
Pierre Bourdon f73b2d70a6
Merge pull request #10516 from OatmealDome/steam 
CMakeLists: Add flag to enable / disable automatic update support
 2022-03-18 08:33:13 +01:00
OatmealDome e23df9369d CMakeLists: Add option to disable automatic update support 2022-03-18 03:04:51 -04:00
TryTwo 53cf78d413 Gekko constistancy changes. Add context item to codeview to show or copy a load/store target memory address from instructions at or near PC when paused. 2022-03-17 12:53:38 -07:00
Jordan Woyak b589d720bf MappingCommon: Fix detection of hotkey and conjunction expressions. 2022-03-16 22:25:04 -05:00
JosJuice 479489c999 DiscIO: Don't return GameTDB ID for any Datel disc 
DTLX01 can be either a Freeloader or Action Replay, so it's
inappropriate to always use the same title and cover for it.
 2022-03-15 18:56:49 +01:00
Léo Lam bf261f6144
Merge pull request #10493 from jordan-woyak/netplay-show-traversal-external-port 
NetPlayDialog: Display external IP/Port as seen by the traversal server.
 2022-03-15 16:03:28 +01:00
Léo Lam e10967e918
Merge pull request #10502 from Pokechu22/defer-gcadapter 
GCAdapter: Defer initialization until MainWindow::InitControllers
 2022-03-15 16:00:28 +01:00
Léo Lam da6f86f381
Merge pull request #10496 from JosJuice/mappingcommon-split 
Move parts of MappingCommon out of DolphinQt
 2022-03-15 15:54:04 +01:00
Léo Lam a99c993f1d
Merge pull request #10509 from JosJuice/freeloader-too-small 
VolumeVerifier: Skip "lacks some data" check for Datel discs
 2022-03-15 15:47:55 +01:00
Léo Lam a39d11c47a
Merge pull request #10501 from jordan-woyak/dolphin-tool-no-need-for-a-unique-ptr 
DolphinTool: Kill an unnecessary unique_ptr.
 2022-03-15 15:46:35 +01:00
Léo Lam c883ec1c53
Merge pull request #10512 from stblr/device-change 
USBv5: Fix racy device change behavior
 2022-03-15 15:45:40 +01:00
Jordan Woyak c058c8e1a6 NetPlayDialog: Display external IP/Port as seen by the traversal server when it's used. 2022-03-15 01:56:16 -05:00
Techjar 302dedbd24 NetPlay: Introduce constant for peer timeout 2022-03-15 01:26:55 -04:00
Pablo Stebler 7e7b0971ab
USBv5: Fix racy device change behavior 
This prevents the device changes happening between 2 GETDEVICECHANGE
calls from being missed by the application.
 2022-03-14 22:32:30 +01:00
Techjar b1122ec94f NetPlay: Add timeout to traversal code path 
Amendment to 600c816 as I missed the traversal case.
 2022-03-14 00:19:54 -04:00
JosJuice 41adf3cd53 DiscIO: Treat game ID DTLX01 as a Datel disc 
Needed for the disc mentioned in the previous commit.
 2022-03-12 22:27:58 +01:00
JosJuice 6d1a344aab VolumeVerifier: Skip "lacks some data" check for Datel discs 
Turns out there's some Freeloader disc for the GC that triggers this
despite being a good dump. This warning is mostly intended to catch
Wii games that have been truncated at the 4.00 GiB or 4.38 GiB mark
anyway, and if someone does have a Datel dump that has been truncated,
they'll still get the "unusual size" warning.
 2022-03-12 22:24:38 +01:00
JosJuice 905e86d754
Merge pull request #10451 from JosJuice/skip-redundant-flushes 
Jit: Skip redundant flushes
 2022-03-12 12:32:02 +01:00
JosJuice 7a3c719739
Merge pull request #10453 from JosJuice/output-in-use 
PPCAnalyst: Count outputs as being in use
 2022-03-12 12:31:42 +01:00
Pokechu22 37806472e1 GCAdapter: Defer initialization until MainWindow::InitControllers 
If libusb fails to initialize, an assertion fails, but if that happens before the main window is created, then Dolphin just dies.  Now, the panic alert is properly shown and the user can ignore it.
 2022-03-10 10:35:45 -08:00
Pokechu22 0f3832dec6 Common/FileUtil: Change logging to debug level 
These messages hid other, more important, ones often.  I have left AttemptMaxTimesWithExponentialDelay and GetSysDirectory/SetSysDirectory as info, since those are called infrequently and can be useful to the end-user.
 2022-03-08 14:07:37 -08:00
Pokechu22 c657b80996 Software/EfbInterface: Remove logspam for RGB565_Z16 being unsupported 
This message would be logged, usually multiple times, for EVERY. SINGLE. PIXEL. That's pretty much useless and just makes the log unreadable. Plus, the current support (which acts as RGB8) is close enough that for end-user purposes, it's fine.  I don't think the hardware backends support RGB565_Z16 and its antialiasing functionality correctly either, but they don't have similar logspam.
 2022-03-08 13:59:55 -08:00
Jordan Woyak f711b8dbae DolphinTool: Kill an unnecessary unique_ptr. 2022-03-08 02:00:26 -06:00
Martin a4d031cfda Add NonDefaultQPushButton to set autoDefault of buttons to false 2022-03-08 08:51:29 +01:00
Shawn Hoffman a546c451b7 windows: wrap all main funcs with utf8 conversions 
fixes 12858
 2022-03-07 23:24:21 -08:00
JosJuice 1bc057614e Move parts of MappingCommon out of DolphinQt 
Some of the functions in MappingCommon would be useful to use on
mobile in the future.
 2022-03-06 14:30:49 +01:00
JosJuice 5446daaef9 Common: Make DynamicLibrary non-copyable 
The default implementations of DynamicLibrary's copy and move
constructors and assignment operators are unsafe.
 2022-03-05 23:40:41 +01:00
Léo Lam d32c72038a
Merge pull request #10467 from Dentomologist/fix_scalar_initializer_braces_warning 
Debugger: Fix warning on Debian builder
 2022-03-02 12:56:09 +01:00
Léo Lam c7361bc1b3
Merge pull request #10474 from Pokechu22/log-ogl-video-info 
OGLRender: Log video backend info, in addition to showing it via OSD
 2022-03-02 12:29:51 +01:00
Léo Lam bcc14d32b8
Merge pull request #10482 from Dentomologist/remove_redundant_statement 
FileUtil: Remove redundant statement
 2022-03-02 12:27:21 +01:00
Léo Lam ebfee3b2de
Merge pull request #10484 from AdmiralCurtiss/general-pane-signalblocker 
Qt/GeneralPane: Don't trigger config change events when populating GUI.
 2022-03-02 11:59:02 +01:00
Léo Lam 666db19436
Merge pull request #10322 from Starsam80/nand 
NANDImporter: Various improvements and cleanup
 2022-03-02 11:56:11 +01:00
Starsam80 41a3368889
NANDImporter: Only read the AES key once 
There is no need to constantly reset the key for every file entry.
 2022-03-01 19:24:59 -07:00
Starsam80 80012ae253
NANDImporter: Make superblocks less magical 
Create a struct describing the superblock layout and use it directly
without needing to specify offsets and such.
 2022-03-01 19:24:59 -07:00
Starsam80 73151a5753
NANDImporter: Don't pass paths if we don't need to 2022-03-01 19:24:59 -07:00
Starsam80 6758c77c39
NANDImporter: Reduce recursion in `ProcessEntry` 
It also simplifies the code flow, as it no longer goes backwards
through the filesystem chain.
 2022-03-01 19:24:59 -07:00
Starsam80 2ccd974471
NANDImporter: Improve NANDFSTEntry 
`uid` is a u32, not a u16. Also, everything is big endian, so we
can simplify the code a little bit.
 2022-03-01 19:24:59 -07:00
Pierre Bourdon 8ecfa537a2
Merge pull request #10473 from delroth/autoupdate-fail 
Fix manual update check which was hardcoded to "dev" track
 2022-03-02 00:10:48 +01:00
Starsam80 643057fea2
NANDImporter: Make a class variable for the NAND root 2022-03-01 15:07:59 -07:00
JMC47 ea116fbbdf
Merge pull request #9834 from AdmiralCurtiss/fastmem-reserve-region-linux 
MemArena: Keep fastmem memory region mapped on Linux to ensure nothing allocates within the fastmem space.
 2022-02-28 12:46:34 -05:00
JosJuice bbb64ff993 Shadergen: Use real_ocol0 workaround for shader logic ops 
Previously we were using this workaround when using framebuffer fetch
to emulate dual source blending, but it seems like we also need to use
it when using framebuffer fetch to emulate logic ops, otherwise some
Adreno devices get a crash when compiling OpenGL ES ubershaders.

Using the workaround in specialized shaders doesn't seem to be
necessary, but I've made the same change there for consistency.

This gets us closer to fixing https://bugs.dolphin-emu.org/issues/12791
but doesn't actually fix it.
 2022-02-28 18:32:19 +01:00
JMC47 f65dc6d525
Merge pull request #10441 from OatmealDome/improved-logic-op-workaround 
BlendingState: Set source and destination alpha factors in logic op workaround
 2022-02-28 12:17:25 -05:00
JosJuice 608799f1e4 PixelShaderGen: Check uid_data for use_shader_logic_op 
On devices which have hardware support for dual source blending
but not logic ops, this lets us skip performing the framebuffer
fetch in situations where the game isn't actually using logic ops.
 2022-02-28 00:04:31 +01:00
Tony Gong c95c43bfb6 Make pos/neg analog axes symmetrical 
Currently, the axes for the main and C sticks range from 0-255, with
128 being the mid-point; but this isn't symmetrical: the negative axis
has 128 values not including 0, while the positive axis has 127 values
not including 0.

Normalizing so that the range is 1-255 makes the positive and negative
axes symmetrical. The inability to yield 0 shouldn't be an issue as a
real GC controller cannot yield it anyway.
 2022-02-27 09:58:21 -08:00
Admiral H. Curtiss 1fd9a1117e
Qt/GeneralPane: Don't trigger config change events when populating GUI. 2022-02-27 17:56:35 +01:00
Admiral H. Curtiss aa0ac83997
Merge pull request #10468 from JosJuice/sd-card-callback 
Use config changed callback to detect SD insertion/ejection
 2022-02-26 17:31:31 +01:00
Dentomologist 01bd5e15ba FileUtil: Remove redundant statement 2022-02-25 21:16:07 -08:00
Pokechu22 7d76eea4ea OGLRender: Log video backend info, in addition to showing it via OSD 
This is mainly intended for debugging fifo.ci.
 2022-02-23 18:30:02 -08:00
Pierre Bourdon 281dfd3e6a
Fix manual update check which was hardcoded to "dev" track 2022-02-23 18:39:28 +01:00
Pokechu22 23cbd570a1 FramebufferManager: Flush pending EFB pokes in PopulateEFBCache 
I.e. flush pokes before running an EFB peek, if the cache tile isn't present.  If the cache tile is present, then EFB pokes should have been written to the cache tile and thus don't need to be flushed.
 2022-02-21 13:23:22 -08:00
JosJuice 128fa8aec3
Merge pull request #10388 from Dentomologist/android-fix-unused-variable-warning 
[Android] Fix unused variable warning
 2022-02-20 18:56:50 +01:00
JosJuice 90c576e075 Use config changed callback to detect SD insertion/ejection 
This saves the GUI from having to manually call SDIO_EventNotify.
With that out of the way, we can let users change the
"Insert SD Card" setting on Android while a game is running.
 2022-02-20 10:55:55 +01:00
Dentomologist d20f3c9e64 Debugger: Fix warning on Debian builder 
Fix "braces around scalar initializer [-Wbraced-scalar-init]" warning
 2022-02-19 08:50:15 -08:00
Léo Lam bb7475ee2a
Merge pull request #10429 from Zopolis4/mapurge 
Remove the Maps folder from the Sys directory
 2022-02-18 21:40:09 +01:00
Léo Lam 0c78167404
Merge pull request #10443 from JosJuice/port-wiimote-source 
Port Wiimote source settings to the new config system
 2022-02-18 21:38:02 +01:00
JosJuice aff45c91fc Port Wiimote source settings to the new config system 
This lets us finally get rid of BootManager's ConfigCache!
 2022-02-18 21:27:10 +01:00
JosJuice 9ebfdff6b4
Merge pull request #10423 from Pokechu22/improperly-exclusive-radio-buttons 
Fix improperly exclusive radio buttons
 2022-02-18 21:20:14 +01:00
JosJuice 35b436bd6b
Merge pull request #10377 from Pokechu22/warning-fixes-jan-2022 
Fix several compile warnings on GCC
 2022-02-18 21:05:42 +01:00
Léo Lam 92455f7cef
Merge pull request #10446 from AdmiralCurtiss/unbreak-shift 
HotkeyManager: Change defaults for GBA hotkeys so they don't conflict with common keyboard mappings.
 2022-02-18 19:09:36 +01:00
Léo Lam eb98bcd2ae
Merge pull request #10455 from Pokechu22/directly-map-fifo-breakpoint 
CommandProcessor: Add FIFO_BP_LO/HI to directly_mapped_vars
 2022-02-18 18:54:06 +01:00
Léo Lam fa059b20ba
Merge pull request #10460 from Dentomologist/convert_option_type_to_enum_class 
VideoCommon: Convert OptionType to enum class
 2022-02-18 18:40:59 +01:00
Léo Lam 067fbe8f86
Merge pull request #10376 from shuffle2/uidctor 
GXPipelineUid: remove explicit shallow copy where it's the default
 2022-02-18 18:39:59 +01:00
Mai M 8b0c6af75a
Merge pull request #10459 from Dentomologist/convert_movie_playmode_to_enum_class 
Movie: Convert PlayMode to enum class and move to cpp file
 2022-02-18 10:00:33 -05:00
Mai M 1e126d23e6
Merge pull request #10457 from Pokechu22/movie-no-pause-menubar-desync 
Fix menu bar becoming desynced when Pause at End of Movie is disabled
 2022-02-18 09:59:32 -05:00
Techjar 63181f0446 ShaderGenCommon: Add missing <functional> include 2022-02-18 06:34:01 -05:00
Dentomologist edbe202aa3 VideoCommon: Convert OptionType to enum class 2022-02-17 10:03:08 -08:00
Dentomologist f56251168e Movie: Convert PlayMode to enum class and move to cpp file 2022-02-16 16:04:36 -08:00
Merry be81fe86e1 JitRegister: Use fmt 
Prefer fmt to printf-style formatting.
 2022-02-16 20:09:38 +00:00
Pokechu22 a81b44f697 Fix menu bar becoming desynced when Pause at End of Movie is disabled 
Previously, when Pause at End of Movie was disabled, the game would continue running as it should, but the menu bar would think the game was paused, showing the play button instead of the pause button.  To make things worse, clicking the play button would then restart the game, instead of pausing or doing nothing.  F10 paused/unpaused as normal, though.

The old behavior was essentially to enable stepping/pause mode (via `CPU::Break()`) and then if Pause at End of Movie was disabled, to un-pause on the host thread (via `CPU::EnableStepping(false)`).  For reasons which aren't entirely clear to me, the first one notified the menu bar (through the `Host::UpdateDisasmDialog` callback, not the `Settings::EmulationStateChanged` one), and the second did not.  In any case, this approach does not particularly make sense; I don't see any reason to pause and unpause if Pause at End of Movie is disabled; instead, we should only pause when Pause at End of Movie is enabled.

This behavior was probably introduced in c1944f623b, though I haven't tested it.
 2022-02-16 11:07:12 -08:00
Pokechu22 68d987bbee CommandProcessor: Add FIFO_BP_LO/HI to directly_mapped_vars 
directly_mapped_vars was added in #69 (4129b30494), but for some reason FIFO_BP_LO/HI were split out from it in in #885 (65af90669b).  As far as I can tell, this code (and the code that existed at the time) is identical, so there's no reason to have it handled separately.
 2022-02-15 22:34:31 -08:00
Zopolis4 5e4d1f732d
Remove the Maps folder from the Sys directory 
It only had two out of date and game-specific maps from decades ago
 2022-02-16 12:32:25 +11:00
Admiral H. Curtiss ffbe6cb21f
MemArena: Keep fastmem region mapped on Linux. 2022-02-14 22:14:41 +01:00
JosJuice 20b2300ce1 PPCAnalyst: Count outputs as being in use 
In a code block where a guest register is accessed at least twice and the
last access is a write and the register is not discardable immediately
after the second-to-last instruction (perhaps there is an instruction
in between that can cause an exception), currently Dolphin's JITs will
flush the register after the second-to-last instruction.

It would be better if we replaced the flush after the second-to-last
instruction with a flush that only happens if the exception path is
taken. This change accomplishes that by marking guest registers as
"in use" not just when they are used as inputs but also when they are
used as outputs, preventing the loop in DoJit from flushing the
register until after the last access.
 2022-02-14 22:09:21 +01:00
Admiral H. Curtiss 4a9553bf6d
MemArena: Load UnmapViewOfFileEx dynamically to restore Windows 7 support. 2022-02-14 21:57:18 +01:00
Admiral H. Curtiss 3a4de2b306
MemArena: Use Common::DynamicLibrary for m_api_ms_win_core_memory_l1_1_6_handle. 2022-02-14 21:57:15 +01:00
JosJuice fd511a689f Jit: Skip redundant flushes 
This makes codegen faster (by perhaps 10-20% in the case of Jit64,
I didn't measure too closely), which helps speed up NBA Live 2005
a little. But the game still has serious performance issues.
 2022-02-14 19:17:59 +01:00