f2a4794105
Use source generation for SettingsUtil.SetDefaultValues
2023-10-25 22:52:06 -07:00
5ce0aa24a5
fix #3481
2023-10-25 21:02:08 +03:00
7ac9bc26cd
mame: add reset
2023-10-25 20:30:32 +03:00
edcd2cd548
fix Ctrl+C not SIGINT'ing, I think
2023-10-24 07:36:17 -07:00
736abf32ac
Ensure FFmpeg DL target is writable before downloading
2023-10-24 23:11:54 +10:00
542a0e08be
Fix `Process.Start` crash in Play Movie dialog on Linux
2023-10-24 22:50:44 +10:00
c7f438c240
Use loaded movie's filename for A/V filename
2023-10-24 22:46:22 +10:00
65060c00f1
Fix/mute code style warnings
2023-10-24 22:32:17 +10:00
b88c7e6baa
fix warning from last commit
2023-10-23 22:48:42 -07:00
cd4e58eaca
make CRC32/SHA1 hashers not die when on a non-x86_64 platform
2023-10-23 15:41:27 -07:00
12a63e27e6
give more memory to melonDS
...
fixing OOM with 512MB games
2023-10-23 05:52:36 -07:00
ee7fc95fac
fix some usings
2023-10-22 19:28:23 -07:00
8941bac1ce
remove BinaryQuickSerializer
...
see #3768
2023-10-22 19:23:32 -07:00
cfdf607373
fix #3807
2023-10-22 01:05:32 -07:00
19552d6408
update Silk.* packages to 2.18.0, remove Silk .config hack (unneeded with this update)
2023-10-21 20:51:42 -07:00
220268809c
Remove EvDevKeyInput. Pretty much useless in practice as apparently you need higher permissions (e.g. root) to access keyboard evdev files, direct evdev is more reserved for gamepads (already handled by SDL2)
...
Turn these OS specific key input impls into instantiable classes instead of a ton of static classes, a lot nicer to work with as don't need to constantly check CurrentOS to know which class to use, only the factory needs to check that!
2023-10-20 21:43:23 -07:00
62501ad859
do minor cleanup with EvDevKeyInput, add in define for switching from X11KeyInput to EvDevKeyInput
2023-10-16 16:08:19 -07:00
d4602cf831
add Quartz key input handler
...
unused of course since no macOS support, but there when we need it
2023-10-15 19:06:53 -07:00
b6d4b0dc81
remove some unused stuff
2023-10-15 04:17:06 -07:00
a35ee381d0
Add evdev keyboard handler. Untested and unused for now
2023-10-15 04:11:32 -07:00
f3796756bc
Add setting to control what happens when double-clicking RAM watch (squashed PR #3802 )
...
* Make RamWatch double click action configurable
* Make RamWatch Enter press share double-click behavior
* Make RamWatch double-click action default to poke
* Fix code style
* Reduce total diff size from extracting method
* Make sub-menu text more specific
2023-10-15 14:43:10 +10:00
b5ebee7cd5
move RAWINPUT imports to a new file
2023-10-12 20:49:17 -07:00
5fc37d6aac
add RAWInput keyboard handler, use it for OSTailoredKeyInputAdapter / SDL2
...
re-removes hard DirectInput dependency
2023-10-12 00:36:13 -07:00
a320928a6f
fix IOE in X11KeyInput.Update()
2023-10-11 17:48:23 -07:00
ac3913ded3
add user agent for cheevo stuff
2023-10-05 02:05:31 -07:00
c438faeec9
added more mame mnemonics
2023-10-04 19:07:20 +03:00
27c5b0e9b7
Also clear `GuiApi`'s image cache when restarting
2023-10-04 05:21:22 +10:00
0d4a1a6b26
fix #3781
2023-10-02 22:32:30 -07:00
af4e9200ed
fix memory leak when screenshotting/framedumping with osd with d3d9 display method
2023-10-02 21:08:48 -07:00
a71b228c70
reset "change" variables on tasproj load
...
Doing this fixes tasproj prompting for save on bk2->tasproj conversion (which makes no sense) and generally seems senseful to do; there is no point ever having a changelog or changes bool set just after loading a tasproj
2023-09-27 21:54:35 +02:00
cf809ed5aa
Override duration for onboarding OSD message
...
fixes a351dcc55
2023-09-26 23:52:52 +10:00
2b00e33560
add TransformPoint impl for NDS
2023-09-25 22:18:44 -07:00
f6a77a8410
Fix touch coord calc when OpenGL is not available, probably fix off by one here too (I think this is right?)
2023-09-25 05:35:15 -07:00
07126b1e48
c# changes for 3d5c2120f2
2023-09-25 05:26:17 -07:00
f63e50c91b
C# changes for melonDS OpenGL support
...
also add in a way to debug OpenGL stuff (only built when uncommenting a define)
also do various cleanup here
2023-09-24 04:28:42 -07:00
acff619034
add more mmap heap to melonds, check against 0 sized arrays in roms
2023-09-17 12:37:37 -07:00
0496d45e09
melonDS's logs already have a newline
2023-09-17 02:52:44 -07:00
0ad1f7feb2
waterbox has fun limitations
2023-09-17 02:16:25 -07:00
178939f76c
woops
2023-09-17 01:03:42 -07:00
d3dff6fe37
update c# side for melonDS changes
2023-09-17 00:58:49 -07:00
2fc9f719e5
Fix #3685 again
2023-09-12 16:44:31 +02:00
4f98bf101c
fix minor oops in previous commit
2023-09-11 22:57:04 -07:00
d788e603fd
force usage of bios on gambatte when recording a movie
...
(except when the rom cant be booted with bios, then enable bios sync setting is respected)
also cleanup this code a lot
2023-09-11 22:52:48 -07:00
ed0dbb77ae
expose SRAM for GBA rcheevos
...
see https://github.com/RetroAchievements/rcheevos/pull/265
2023-09-11 21:29:34 -07:00
e68a49aa51
Use absolute path to `ffmpeg` in `FFmpegWriter`
2023-09-11 16:31:23 +10:00
a7ee68f47d
Fix typo in Satellaview header model
...
see #3749
2023-09-10 22:38:19 +10:00
2647bb8300
Log FFmpeg download fails to stdout in Debug config
2023-09-09 16:56:06 +10:00
a351dcc557
Make the onboarding flow impossible to miss
...
This should motivate widening the scope of profiles, and may also inspire additional features for onboarding such as paths/firmware, screen layout, or keybinds.
2023-09-05 05:47:03 +10:00
ebe3cad66c
Change UI label for `Config.AcceptBackgroundInput`
...
see #671
2023-09-02 01:47:52 +10:00
362269c982
Establish basic style analyzer rules ( #3759 )
...
* Fix analyzer nullable error
can't disable them in CA1305 xdd
* .editorconfig -> .globalconfig
* Add basic set of style analyzer rules
* dotnet format output
* Some additional fixes
* Apply manual simplification
* Transform some enum comparisons
* fix typo
* add TODO
2023-08-30 23:08:21 +02:00
7193313e12
Comment-out unreachable code
...
fixes a315b122c
2023-08-25 11:59:35 +10:00
e86a0d6dda
When editing watches, select notes field
2023-08-25 11:41:51 +10:00
1575949762
upgrade these for c#10
2023-08-22 19:34:51 -07:00
19443040c4
slightly refactor OSD layer, no longer uses a render callback, rather it will do its logic itself and has its own enable drawing flag
2023-08-22 17:57:46 -07:00
53563657fe
Implement blending enable/disable for IGL_GDIPlus (more just moving it away from GDIPlusGuiRenderer)
...
Fix GDI+ used for display method (got broken in some cleanup commits ago)
Remove some things meant to be removed in the last commit (fixes debug build)
2023-08-22 17:16:48 -07:00
8c1d996b80
simplify IGL 3: Remove ability to make custom blend states (was never used), only have 2 functions for blending, one enabling "normal" blending, one disabling blending (with alpha copy semantics) (only 2 which actually were used)
2023-08-22 16:46:21 -07:00
757ae3293f
Resolve part 4 of #3735
2023-08-22 19:22:34 +02:00
54b1b2e421
Stop moving executables' pdbs to dll folder
2023-08-20 14:24:30 +10:00
d459aaaf6f
Dispose disks in Nyma cores ( #3751 )
2023-08-19 23:27:05 +02:00
c57657bbd4
Set inputdisplay correctly on LoadState ( #3747 )
...
* Set inputdisplay correctly on LoadState
* Add explanatory comment for future generations
2023-08-19 23:22:55 +02:00
ebf1950873
fix #3686
2023-08-18 04:58:38 +02:00
4fea6752f3
Fix #3685
2023-08-18 04:06:28 +02:00
ea7683a996
Bump LangVersion to 10
2023-08-16 16:30:06 +02:00
c17f65fb10
Slightly increase sleep time while paused, should resolve #3737
2023-08-14 20:11:22 -07:00
c10d2927ca
bump AnalysisModeUsage to Recommended
...
fixes CA2211, CA2215, CA2241, CA2251
silence CA1816 because it's unnecessary
reduce severity of CA2201 because I like the concept but don't wanna fix them all
2023-08-14 14:18:45 -07:00
71e08e27b9
bump AnalysisModePerformance to Recommended
...
fixes CA1841
silence CA1805 and CA1822 because of sheer amount of violations
reduce severity of CA1838 because I don't wanna fix it lol
2023-08-14 14:18:45 -07:00
6e20a3091c
Fix CA1305 and bump to error
2023-08-14 14:18:45 -07:00
8e557b0b9d
bump AnalysisModeGlobalization to Recommended
...
fixes CA1304, CA1309, CA1310, CA1311
temporarily silences CA1305
reduce severity of CA2101
2023-08-14 14:18:45 -07:00
44dce7dc08
remove unused experimental code
2023-08-13 14:24:03 -07:00
ae42858560
fix D3D9 crashing on minimize
2023-08-13 14:21:58 -07:00
56ac05f9a3
Allow migrating non-SHA1 hashes on movie import ( #3733 )
...
* Allow migrating non-SHA1 hashes on movie import
* Show more descriptive message on missing hash
* actually return null here
* Simplify LsmvImport
* add more hash HeaderKeys
* remove unnecessary IEmulator argument
this could potentially fix bugs even
* explicitly cast to ReadOnlySpan
2023-08-13 23:11:48 +02:00
b6f1bae7e1
Revert erroneous change to bk2 loading for now
...
fixes 0af4d125b2
2023-08-13 21:14:35 +02:00
9131c8ab2e
Change SmvImport to import to Snes9x core; various fixes
...
the importer is still far from perfect, but it should handle some things better than before
- closes #3177
2023-08-13 20:01:56 +02:00
0af4d125b2
revert bd9ec3c57d, fix bk2 framebuffer load
2023-08-12 18:16:54 +02:00
4ad7736ca7
add some kind of 3DS support to retroachievements, probably
2023-08-12 04:22:46 -07:00
72cc192661
Create a new project to house the IGL WinForms controls (Bizware.Graphics.Controls), thus allowing for Bizware.Graphics to be netstandard2.0
...
also move GDIPlus IGL stuff over from BizwareGL to Bizware.Graphics
2023-08-12 03:56:02 -07:00
9139870e7e
fix bug from 3622fe76f9, remove variable unused since 3622fe76f9
2023-08-11 16:59:14 -07:00
dfd7caaacb
use glBufferSubData when possible instead of glBufferData, gives a nice performance boost
2023-08-11 16:57:20 -07:00
3622fe76f9
simplify IGL 2: Combine BindArrayData and DrawArrays calls into one Draw call: only supports triangle strips (already limitation with D3D9), assumes start is 0, binding and drawing are implicitly merged into a single call (in practice BindArrayData would just save the vertex pointer to some class level variable for DrawArrays, so this is just better all around)
2023-08-11 15:33:08 -07:00
64abeddc2b
simplify IGL 1: Combine Clear and SetClearColor, remove support for non-color buffers (not supported by GDI+, never actually used)
2023-08-11 13:30:46 -07:00
f2942feb93
minor cleanup for 47c2d315ce
2023-08-11 00:34:07 -07:00
47c2d315ce
drop OpenGL 2.0 support (annoying to support given we already require FBO support, which is an extension pre-3.0, and VAOs also fall under that same group, polyfilling this is just bleh)
...
in practice this means nothing for any Windows user (since D3D9 would support whatever garbage GPUs that had OGL 2.0 support but not OGL 3.0 support), so it only affects Linux users with GPUs from 2004-2010 (~2011 GPUs supported at least OGL 3.0), and those users probably have options to still use BizHawk if they really wanted to anyways
With this, switch the GuiRenderer (main) pipeline to use VAOs/VBOs instead of the old legacy fixed pipeline crap (other shaders still need that crap for now, so there is still a fallback path there). Also add in way to "free" the vertex layout (since it now can hold a VAO/VBO which needs to be freed once the vertex layout is finished)
2023-08-11 00:30:47 -07:00
8260a59bcf
fix #3726
2023-08-10 00:07:10 -07:00
1cf5af83dd
Change Odyssey 2 framerate (squashed PR #3728 )
...
* change o2 framerate
* result
2023-08-10 04:11:02 +10:00
a496f09f07
Fix SmvImport CRC32 import
...
closes #3727
2023-08-09 11:14:31 +02:00
fe845ce8ef
Don't double-load movies from the PlayMovie dialog
2023-08-07 14:14:22 +02:00
20ca53dfd1
Apply e186514c39 for copy mechanism
...
Also fix the formatting of the string, we want : here not .
2023-08-07 02:45:54 -07:00
e186514c39
Display day length for 1+ day long movies
2023-08-07 11:40:24 +02:00
f8b3914126
fix broken movie length calculation
...
this happened to work by chance most of the time, but for movies which cant store the number of milliseconds in an int, it breaks down
2023-08-07 02:32:32 -07:00
97d9ce35e2
Disable Hybrid Screen setting in Citra for now
2023-08-06 03:21:22 -07:00
59fcdb04cd
Remove Bizware Vector2/3/4 and Matrix4 in favor of System.Numerics's implementation
...
Many many cleanups in BizwareGL and DisplayManager and GDI+ code
2023-08-06 03:21:22 -07:00
bb96825c60
System.Data.SQLite -> Microsoft.Data.Sqlite ( #3719 )
...
* Swap System.Data.SQLite with Microsoft.Data.Sqlite
Apparently this is supposed to be a kind of successor? https://learn.microsoft.com/en-us/dotnet/standard/data/sqlite/compare
* Add e_sqlite3 libs to Assets, prevent runtimes folder creation with OS tailored libs plopped in, delete System.Data.SQLite references
2023-08-05 17:45:40 -07:00
2150061c91
Update LuaConsole.cs
2023-08-06 03:01:44 +10:00
ca756a2df3
dont use ContextMenu
...
winforms net6 doesn't support it, and "replacement" ContextMenuStrip doesn't work for this use case, so just create a slim wrapper using CreatePopupMenu/DestroyMenu directly
2023-08-04 00:54:42 -07:00
ba8656e345
slight tastudio tweaks wrt 12830bab4e
2023-08-03 21:03:20 -07:00
1ebc006873
Update unit test to match new config schema
...
fixes 12830bab4
2023-08-02 18:03:06 +10:00
dc34b0b1a9
add in Wine/Proton detection, used to prevent D3D9 from being used if a user ends up using wine/proton (as often it seems D3D9 wine/proton just doesn't work and crashes in weird ways, sometimes *after* checking the renderer so it wouldn't fallback to OpenGL anyways)
...
Probably can add in some first time message box warning the user that wine/proton isnt supported, although we probably shouldn't block wine/proton (considering it's the only option for some distros with read-only filesystems, like the Steam Deck)
2023-07-31 23:02:30 -07:00
67e5505899
Rework OpenGL version support checking to be more robust, slightly rework OpenGL context creation request (they can now explicitly request the core profile)
2023-07-31 22:32:30 -07:00
a2ea86fae0
add NET6_0 guard for GetValueOrDefault backports
2023-07-31 22:01:05 -07:00
811275cca8
Rewire memory domain pointers after reset in Citra
...
Add 3DS framerate in PlatformFrameRates
2023-07-31 21:22:57 -07:00
1ee2ef928c
Prevent SDL from doing windows message pumping
...
Normally SDL doesn't do this as we don't ever call SDL_PumpEvents (or anything that calls that). However, OpenGL context creation code ends up calling WIN_PumpEvents regardless. This usually doesn't matter, however, in some cases, this can cause crashes, mainly with loading a state with Citra, as that ends up re-constructing its frame dumping OpenGL context (yeah that's dumb and useless but it's mostly harmless, outside of this message pumping). The WIN_PumpEvents calls appear to be unneeded anyways, so we can safely disable message pumping here.
2023-07-31 15:55:36 -07:00
a315b122c5
force OpenGL renderer in Citra for now
...
the software renderer doesn't seem to be functional and the code for blitting it is incomplete
2023-07-29 17:03:53 -07:00
33f1c5472a
add missing Dispose() for Citra ctor failure case
2023-07-29 16:26:29 -07:00
0a72dc046f
add in missing mnemonics for 3DS controls
2023-07-29 15:22:56 -07:00
e62c972ca3
Check in citra dll/so, add in build scripts/linux glslangValidator for citra, some minor cleanup handling with citra input handling
2023-07-29 15:09:17 -07:00
f1e9f10454
Minor reworking of IGL OpenGL context creation
...
Try to regain compat with < OpenGL 3.0 users, better checks against OpenGL availability
2023-07-28 23:26:51 -07:00
e7f4ad8220
fix exception popping up when Dispose()'ing DisplayManagerBase with OpenGL
2023-07-28 22:19:15 -07:00
12830bab4e
Add in flag to IStatable to hint to the frontend that it should avoid rewind (not entire sure with the name, maybe SlowStates would have been better? trivial to mass-rename anyways)
...
Add in logic to not create the main rewinder if this flag is true, and add in logic to tastudio to avoid the main greenzone captures (instead only capture on branch save/load)
2023-07-28 22:07:31 -07:00
1ad3ed2216
minor cleanups in IGL_OpenGL
2023-07-28 15:38:43 -07:00
7a2f1532bf
fix DS being shown upside down when ScreenControlNDS is used
...
fixes 78f5e75534
2023-07-28 14:54:02 -07:00
f7448495b0
correct 3DS rom check in XmlGame
...
fixes 8c41b09108
2023-07-28 05:37:47 -07:00
8c41b09108
Add in 3DS rom extensions to rom filter
...
make it so CIAs past index 0 will be "installed" (mostly only relevant for movies, as the temp user folder is wiped each session in deterministic mode)
ensure XMLs won't load 3DS roms into memory (same reasoning as other hack, might be >=2GiB)
do some cleanup with this code
2023-07-28 05:33:56 -07:00
4ff157f652
add in Citra for global core config menu
2023-07-27 22:41:03 -07:00
bd2c2ffc86
/s/_3DS/N3DS
2023-07-27 22:37:06 -07:00
5607845b24
Add in screen control filter for Citra port
2023-07-27 22:20:50 -07:00
ff57303821
Add in 3DS entry for SystemIDDisplayNames
2023-07-24 00:39:50 -07:00
89b387e50d
add memory domains for Citra
2023-07-24 00:14:11 -07:00
67510f3b56
cleanup 3DS firmware handling
...
seems these methods aren't really supported in citra, so I guess have fun dealing with manually setting firmware files
2023-07-23 21:22:26 -07:00
18b81a2011
Fixup OpenGL version reporting; add debug print for 3DS firm installing message
...
fixes 8ae947fed7
2023-07-23 20:09:17 -07:00
41ee99999a
Add 3DS firmware handling
2023-07-23 19:55:58 -07:00
739c35c174
fix #3692
2023-07-23 03:58:46 -07:00
dd5cbc92af
set WRAM as the main memory domain in SameBoy
...
see #3711
2023-07-23 03:44:09 -07:00
2d17290918
add in RetroAchievements support for Uzebox and TI83
2023-07-23 03:38:29 -07:00
01cc5ca476
fix a RetroAchievements PSX hashing edge case
2023-07-23 03:28:54 -07:00
e87536ea8f
commit C# parts for Citra port
...
not committing the dll yet until some more things are ready
2023-07-23 03:14:26 -07:00
cdfb8d67e8
commit citra submodule
2023-07-23 02:46:37 -07:00
bed66e2cd4
fix minor oopsies / dumbs with previous commit
2023-07-23 02:16:24 -07:00
8ae947fed7
prep work for easier OpenGL interop for cores
2023-07-23 01:54:36 -07:00
78f5e75534
Kill Bizware .NET Framework deps ( #3702 )
...
The main objective in this PR is to get rid of the main .NET Framework dependencies in Bizware packages. This PR doesn't do that completely per se, still having .NET Framework used for WinForms Controls, but that can easily be swapped over for whatever UI framework we use next as long as it exposes native window handles in some way.
For this PR, it does some reorganizing of Bizware, splitting Bizware.OpenTK3 and Bizware.DirectX into 3 packages based on usage; Bizware.Audio, Bizware.Graphics, and Bizware.Input. These packages in the future probably could have more functionality moved into them, but for now they are largely just a reshuffling of the Bizware.OpenTK3 and Bizware.DirectX packages.
As both SlimDX and OpenTK3 are .NET Framework, they have been removed in this PR. Their replacements are as follows:
SharpDX: DirectSound, Direct3D9
Vortice: XAudio2, DirectInput/XInput
Silk.NET: OpenAL, OpenGL
SDL2-CS / native SDL2: OpenGL context management, new gamepad backend (replacing OpenTK's role for gamepads)
native X11: New key input backend (replacing one of OpenTK's roles for keyboards)
GLControl has been replaced by custom made control which just uses SDL2 for context management.
The OpenTK input backend has been replaced with a combination of SDL2 and an OS tailored key input backend (DirectInput on Windows, X11 on Linux, and planned to be Quartz on macOS). This is just represented on the user side as "SDL2" without mentioning the key input backend. This does mean for a while DirectX will be mandatory on Windows again, until a RAWINPUT backend is written for handling key input on Windows for the SDL2 input backend.
2023-07-23 00:35:43 -07:00
fe47285394
trim cheat lines, since it's virtually impossible to copy text from a web browser without getting junk around it
2023-06-30 19:42:28 -04:00
6b87e3ac91
Fix being unable to open SubGBHawk via system menu ( fixes #3693 )
2023-06-25 01:23:14 +10:00
d8ea4547d4
Add StringFormat to pixeltext DrawString parameters (squashed PR #3690 )
...
* Add StringFormat to DrawString parameters
* Revert whitespace changes
* Code style nitpicks, cache `StringFormat`
---------
Co-authored-by: YoshiRulz <OSSYoshiRulz@gmail.com>
2023-06-21 09:20:54 +10:00
4ee7e4cad7
Add deduper utility to RAM Watch
2023-06-13 23:43:53 +10:00
25ad59d895
Replace type check with enum (int) comparison in `Watch`
2023-06-13 23:43:53 +10:00
ca8a183f38
Add `WatchList.InsertRange` and use when duplicating rows in RAM Watch
2023-06-13 23:43:53 +10:00
4d4887ee31
Fix `WatchList.Insert` not setting dirty flag
...
not sure if this was problematic in practice
2023-06-13 23:43:53 +10:00
13dd04a026
Fix #3679
2023-06-07 23:01:54 +02:00
9e5fb35f7a
Add in missing TMD for Cave Story Japan
2023-05-29 02:25:36 -07:00
c3ec8393d0
Optimize Remove[Prefix|Suffix] by using ordinal string comparison
2023-05-27 03:50:46 +02:00
f6135abe65
disabled log generator caching in bk2, it has playback problems not found it basic testing, need to revisist this later
2023-05-26 19:19:08 -05:00
fde16fa5a3
Hide D=>A TAStudio columns w/ Ares64, rename C* buttons in header
...
initial implementation by @thekovic
2023-05-27 03:01:49 +10:00
3d5b068c2f
QuickNES: Slightly tweak palette rounding computation
...
Fixes #3668
2023-05-26 07:01:56 -04:00
8a94204a2f
QuickNES: Fix loading 64 color palettes
...
Since ee0992158d
2023-05-26 06:46:56 -04:00
cb721a39da
de-engineer some movie stuff, ILogEntryGenerator is not an important abstrations now that Bkm is gone
2023-05-25 15:01:30 -05:00
33ed05b20c
BK2LogEntryGenerator - further optimize by doing the control ordering once
2023-05-25 13:32:58 -05:00
f697a828c8
Optimize CreateLogEntry
...
Surely this is safe, right?
2023-05-25 13:19:16 -05:00
05f8747321
optimize movie recording loop a bit, do not create a new instance of log entry generator every frame, avoids a lot of memory allocations with mnemonic lookups that do not change for the lifetime of the movie, also a slight optikmization in Bk2 controller, co-authored iwth morilli
2023-05-24 11:18:42 -05:00
9daac2c26f
Add and use extension method `string.StartsWith(char)`
...
reverts 333ce98a7bc16a2cda
2023-05-23 09:18:25 +10:00
333ce98a71
low hanging fruit speed up in inputlog loading using str[0] == c instead of str.StartsWith(c)
2023-05-22 12:50:30 -05:00
681ef72cd5
Change wording of checkbox for `Config.SuppressAskSave`
2023-05-21 16:22:54 +10:00
ccf2c61a23
fix #3664
2023-05-20 03:11:40 -07:00
08ead80385
make these callback delegate caches static (why didn't this warn that static was possible here?)
2023-05-19 22:30:17 -07:00
3c53f52c6d
remove some debugging crap from c9e30060d4
2023-05-19 22:28:32 -07:00
542cf2433a
Reduce allocation spam in Jaguar disassembly functions
2023-05-19 22:26:45 -07:00
c9e30060d4
Rework the Reader/Writer callbacks for the WaterboxHost, a bit nicer here working with the userdata
...
Also make it so initial loading uses the zstdstream or filestream directly instead of a memorystream with it all loaded
something of note, not really happy with how these read/write callbacks get used in practice, it seems they get spammed in small chunks
for initial loading, it's 8192 byte chunks each, which can be a LOT of callbacks, depending on core size (gpgx is ~500, MAME is ~22K)
similarly, savestates suffer a similar issue, although instead it's a ton of 4096 byte chunks (page size eh?)
The unmanaged <-> managed transitions obviously are not exactly performant, and I imagine are taking a significant portion of the time here
Perhaps some buffering strategy should come in on the native waterboxhost side to alleviate callback spam?
2023-05-19 22:26:45 -07:00
99a6b1d339
add hotkey for toggling the 'Display Nothing" feature
2023-05-19 20:05:16 -05:00
8a13793d00
Turn WaterboxHostNative ReturnData to a struct, misc cleanups elsewhere
2023-05-18 22:21:17 -07:00
332143ea8d
invalidate cram caches when poking, maybe
2023-05-18 21:14:57 -07:00
473d3cc294
fix #3662
2023-05-18 19:09:08 -07:00
ea854ff39d
make discohawk form a bit bigger
...
all the formats supported means the box wasn't big enough to display all of them lol
2023-05-18 07:28:10 -07:00
fe79b69123
(Partial) .nrg support
...
TAO support isn't complete, a lot of sanity checking isn't done yet
2023-05-18 07:14:14 -07:00
3d30f52e7c
Fix LogWindow treating everything as ascii
...
hopefully this doesn't break anything
2023-05-17 14:54:18 +02:00
f11b5bc9c4
fixup CDI generated subcode (not sure why I did that)
...
have it generate "leadin" and "leadout" tracks for multisession discs... this is almost certainly wrong for leadin (doesn't matter so far), leadout is probably right...
2023-05-12 20:47:29 -07:00
0e6d5fb708
minor addendum to 2012b083f6
2023-05-12 03:28:14 -07:00
2012b083f6
Fixup multisession handling with MDS and improve its track/sector size handling, also maybe fix it entirely? (not sure if this ever worked)
...
Move the various synths using the CUE SS_Base to a file, mostly just a nicer organizational change as MDS and CDI use one of these but not CUE
Misc improvements elsewhere
2023-05-12 02:44:05 -07:00
1f3068fe77
fix synthesizing disc tracks with multisession discs when the first session has a large amount of tracks
...
FirstRecordedTrackNumber only works here for the first session, for future sessions it doesn't work and may just result in out of range exception
2023-05-11 02:57:14 -07:00
858ea372a9
Fix Jaguar CD detection for Caves of Fear
2023-05-11 02:28:33 -07:00
e3c27813b6
fix the fix in 45a0c8cffb
2023-05-10 05:37:03 -07:00
45a0c8cffb
another fix for 9551394
2023-05-10 05:23:24 -07:00
c52a950c41
Fix dumping CCDs with multisession discs, fix oopsies with CDI parsing giving the wrong last recorded track number
2023-05-10 04:58:37 -07:00
2379650e1b
Implement error and verbose message callbacks for rcheevos (currently they just output to the console)
...
Implement debug option for hashing with more pure rcheevos logic, mostly just useful for figuring out disc hashing issues
2023-05-10 03:11:50 -07:00
d3a689c589
Resolve #3650 . Also fix a bug which caused overwriting lua scripts with a new lua script to fail (fixes 380e459bec)
2023-05-08 03:01:41 -07:00
f677e92504
fix TOC field mixup with Jaguar CD
2023-05-07 22:09:52 -07:00
40e21b716e
fix 955139454a
2023-05-07 02:59:38 -07:00
7d5a1d5c98
Lower CPU usage from RCheevos http stuff
2023-05-07 02:41:07 -07:00
68cd28c28a
fix directionals and other common buttons being dropped from controller inputs when hotkeys overrode controller inputs
2023-05-07 01:00:13 -07:00
4a752f66b7
Add Analyzer to require checking or discarding `TryGetValue`
...
I'm pretty sure all the existing instances were intended to use `default(T)` if
the key isn't present, except maybe the cheatcode converters but I don't care to
rewrite those at the moment
2023-05-05 06:27:15 +10:00
384a4e1e18
Bump version info post-release
2023-05-04 08:10:07 +10:00
36fae775d4
Prevent annoying waits when using firmware manager with DSi NANDs present
2023-05-03 02:19:56 -07:00
5f6d70ac46
Fix random crashes with rcheevos. The issue was that rc_runtime_t can store pointers to itself, which is bad when rcheevos expected the user to allocate that struct and did not provide functions for that. I've added that functionality and PR'd it (I'll fixup submodule to point to upstream when it's merged)
...
PR can be found here: https://github.com/RetroAchievements/rcheevos/pull/239
Also minor fixes wrt the ContinueWith usage in InternalDoRequest
2023-05-03 01:54:57 -07:00
248b8ab984
Fixup bad threading (no, you cannot access rcheevo's _runtime in a separate thread! main thread use only!). Should fix up some random crashes
...
Slightly change up the request model, now InternalDoRequest does not block
Fixup logic of ToSoftcoreMode (and comments so it isn't screwed up again)
2023-05-02 21:47:09 -07:00
8ef1d93891
Prevent UI thread deadlocking on Dispose()'ing rcheevos stuff
2023-05-02 17:18:31 -07:00
b9a983f1fe
Fix typo causing crash with SMSHawk with RetroAchievements & Hardcore Mode
2023-05-02 17:08:39 -07:00
41d94e4262
Change up multithreaded rendering in melonDS
...
Instead of creating a new Task and destroying it every frame, just create a new thread and call the delegate when needed.
Also allow for rendering a frame twice, this is actually possible anyways (albeit rarely done).
This should also help against a potential deadlock due to the Task.Wait call on the UI thread (which has special semantics in WinForms)
Also minor nitpicks in RCheevos code
2023-05-02 16:52:48 -07:00
b517228475
Refactor rcheevo http requests (again). This should better protect against the UI thread deadlocking due to Task semantics with WinForms
2023-05-01 03:50:49 -07:00
e065263ff2
MAME does mark bad dumps, but it only keeps their info if good dump is not known yet. once a good dump appears, its info replaces the bad one.
...
so simply sticking to newest rom sets is the safest, otherwise there's little user control, because there's no global list of all known dumps with indications which of them are bad and what to use instead.
2023-04-30 14:07:08 +03:00
2010f5e15c
disable leaderboard list form, for now, and revert efa6505
...
see that commit for details on issues with this form (this form is kind of useless anyways, meh)
2023-04-28 18:37:06 -07:00
8a5921182e
Add Analyzer to disallow discarding locals e.g. `_ = result;`
...
fixes 70bd081a9a2185d9ef
2023-04-29 01:52:43 +10:00
a2185d9ef0
fix 70bd081a93
...
The entire call is skipped in release mode if you place it inside a Debug.Assert.
2023-04-28 03:14:56 -07:00
66f26bb1c1
Create and use `IDictionary.GetValueOrPut{,New,New1}` extensions
2023-04-27 17:25:03 +10:00
fa48278354
Enable MEN014 and fix noncompliance
...
"Prefer TryGetValue"
2023-04-27 17:24:55 +10:00
c8589de5c6
fix #3648
2023-04-26 23:05:11 -07:00
102dee9622
Fix some SMS audio inaccuracies (squashed PR #3602 )
...
* fix noise audio channel on SMS VDP
* Update SN76489sms.cs
also, white noise is generated by XORing bits 0 and 3, not 0 and 1, on an SMS/GG VDP
* Update SN76489sms.cs
reverting commit #7b857e7
2023-04-27 15:46:52 +10:00
dd30a389a0
TAStudio/PatternsForm: Block deletion of loop entry which would cause a crash
2023-04-27 15:14:44 +10:00
07ba36956a
TAStudio/PatternsForm: Allow looping to entry zero
2023-04-27 15:14:44 +10:00
9cbd238997
Convert `GenericDebugger.DisasmOp` to a struct
2023-04-23 19:08:19 +10:00
70bd081a93
Refactor `ServiceInjector`
2023-04-23 17:41:55 +10:00
c5d6a66e01
Resolve TODO re: memoisation in `GenericDebugger`
2023-04-23 17:41:55 +10:00
4b001a48a9
Dedup `GenericDebugger.EngageDebugger`
2023-04-23 17:41:55 +10:00
ac3e76309f
Use helper prop here
2023-04-23 17:41:54 +10:00
bcdeec369a
Move commented-out code to `#if false`
2023-04-23 17:41:50 +10:00
396e876320
Optimize TAStudio column drawing by caching PlayerNumber for each column name
...
TAStudio previously called `PlayerNumber(...)` for each visible cell with the column's name, only to determine whether its player number is odd or even.
Because that function uses regex and is potentially called extremely often, this had a noticable impact on fps.
I've decided to just cache the odd/even playernumber result in a dictionary for faster access, which while not being my preferred way of handling this at least results in a decent speedup.
2023-04-23 00:15:43 +02:00
afb92870e4
TargetName -> AssemblyName
...
this fixes the winforms designer in Rider, let's hope it doesn't break anything though
2023-04-22 13:51:13 +02:00
a8aced4474
Workaround crashes in MAME's zlib decompression code ( #3639 )
...
* Workaround crashes in MAME's zlib decompression code (see https://github.com/TASEmulators/BizHawk/issues/3615 )
* Use using block, only catch InvalidDataException (what will be thrown if the zip entry has an unsupported (likely lzma) compression method)
2023-04-20 09:29:03 -07:00
efa6505826
prevent crashes when loading up leaderboard forms
...
apparently some game had 2002 leaderboards which caused a crash when making a form for every one of them in the leaderboard list, I guess windows has a limit on the amount of forms that can be active at once?
this is a quick hack to prevent such a crash, design needs to be rethought
2023-04-20 09:00:16 -07:00
1356bc6a3f
i guess this is required oops
...
fixes bc16a2cdaa
2023-04-20 12:31:33 +02:00
bc16a2cdaa
Implement IBasicMovieInfo interface for IMovie ( #3634 )
...
* Implement IBasicMovieInfo interface for IMovie
this allows parsing basic movie fields into an own class that is independent from Bk2Movie/TasMovie
This is mainly useful for the PlayMovie dialog which can now load movie information from files on disk without having to go through the entire Bk2Movie/TasMovie loading process
* don't potentially iterate input log twice
* Optimize LoadFramecount
2023-04-20 10:43:02 +02:00
cf88e61875
c# side changes to use the split ares' binaries
...
resolves #3614 and #3617
2023-04-19 23:23:12 -07:00
8cf820da4d
Don't send invalid paths to MAME
...
Waterbox cores can't create files anyways, and trying to send in ? might make MAME try to make the directory anyways (which crashes due to the syscall for that being unimplemented), while "" will not do that
2023-04-19 18:41:05 -07:00
b5e2a0c422
Move some .gitignore entries to nested dirs
2023-04-19 15:59:34 +10:00
955139454a
fix Jaguar CD homebrew hashing wrt retroachievements
2023-04-18 22:38:13 -07:00
4268c50617
Fix RetroAchievements rich presence not working
...
Cleanup this code so it plays nicer with BizHawk's "run everything on the main thread" (+ WinForms not playing nice with async methods)
Resend any game session start / achievement unlocks / leaderboard triggers if they failed. Wait for all achievement unlocks and leaderboard triggers to finish on Dispose() (mostly for catching them when user closes BizHawk)
Update rcheevos to 10.7.0
2023-04-18 21:35:58 -07:00
20e5c43bc8
Add `--socket_udp` CLI flag
2023-04-18 19:15:02 +10:00
0f2a76bd5e
lazy-initialize zstd contexts to reduce alloations
...
This becomes mostly apparent in the PlayMovie dialog where one zstd instance is created for every single movie, churning significant amounts of memory even though zstd isn't even used
2023-04-16 15:33:40 +02:00
98afdb8993
(Actually) Fix DeltaSerializer's `GetDelta`
...
fixes 2838a5412a
2023-04-15 22:04:21 -07:00
2838a5412a
Fix DeltaSerializer's `GetDelta`
...
Fixes AppleII/C64 states sometimes crashing when a disk change actually happens
2023-04-15 21:33:51 -07:00
ebd36f08b6
Downgrade `System.Drawing.Common` to 6.0.0 and enable Unix impl.
...
fixes 65ffa3fc2
2023-04-16 10:49:18 +10:00
6ffe99c006
Use the right `Sameboy` ctor in testroms project
...
This reverts commit 379eeeeed8
2023-04-16 10:14:46 +10:00
236c748b1a
Downgrade MSTest to 2.2.9
...
fixes 65ffa3fc2
2023-04-16 10:14:43 +10:00
a1fe557d31
Re-enable MA0020 and fix noncompliance
2023-04-16 09:02:40 +10:00
65ffa3fc2e
Blindly update NuGet deps
...
temporarily disabled MA0020
2023-04-16 09:02:40 +10:00
85a481f93f
Nes.Core now updates the DataBus in WriteMemory() ( #3633 )
...
* Nes.Core now updates the DataBus in WriteMemory()
This will fix open bus execution following write instructions.
* Properly formatted changes in previous commit
I have addressed the requested changes.
2023-04-15 21:24:27 +03:00
f2880d8325
Update `CoreComm` init in testroms project to new signature
...
fixes 76a29d356
2023-04-15 10:36:43 +10:00
379eeeeed8
Make `Sameboy` ctor public so testroms project can use it
...
fixes 9528a2030
2023-04-15 10:36:39 +10:00
c90fcbbd54
mame: numerator 0x4000'0000 and above breaks mp4 on youtube...
2023-04-14 19:32:29 +03:00
8e6eac7bfd
mame lua doesn't expose settings for optional dip switches, so hide them for now
...
38498868fc/src/mame/toaplan/toaplan2.cpp (L2960)
2023-04-14 19:23:50 +03:00
59562d8930
Fix `[RequiredService]`s checked for `null`
2023-04-13 08:53:14 +10:00
5f77a310c5
Remove `ServiceInjector.ClearServices`
...
This call in `ToolManager.Restart` was to set `[{Optional.Required}Service]`
props to `null`, but the tool form would get `Close`d immediately afterwards, so
it never gets the chance to hit the `null` path if one exists. However, some
tools are written as though they keep the stale value, for example attempting to
call a cleanup function on it in their `Closed` event handler. These will now
work as intended.
`[OptionalService]`s that can't be satisfied are set to `null` by
`ServiceInjector.UpdateServices`, so clearing those isn't necessary, and
`ClearServices` has no other usages.
2023-04-13 08:53:14 +10:00
ddc3e929e9
Use source generation for VersionInfo ( #3625 )
...
* Use source generator for VersionInfo
* Remove leftover hacks
* Use same fallbacks as NixHawk when Git not available
---------
Co-authored-by: YoshiRulz <OSSYoshiRulz@gmail.com>
2023-04-12 21:14:44 +02:00
03aa420bd5
fix last issue in #2951 properly
2023-04-09 23:43:28 -07:00
ffd8e6897a
don't keep multidisk flag on after it was set once
...
don't replace mame rom info icon and text with multidisk ones if there are emulation issues
2023-04-09 23:52:50 +03:00
fadc445f9c
mame: print more rom info
2023-04-09 23:40:59 +03:00
76a29d3563
allow setting OSD message duration for its callbacks
...
todo: simulate optional args for Action?
2023-04-09 22:08:37 +03:00
b4394af824
mame: report emulation status via rom info icon and text
...
mame won't care too much about how good the dump is, but it will warn you in orange that emulation is imperfect, and in red if it's broken. we happen to use rom status icon to inform the user about multidisk bundle, so using it for mame info feels natural, because it directly affects what users can safely submit to tasvideos. we warn them about bad dumps because it's banned for pub, so it's similar here.
2023-04-09 21:38:56 +03:00
8aa03c3059
mame: add emulation issues info to RomDetails
...
reorder file hashes and names so it looks aligned
2023-04-09 19:22:19 +03:00
0469c04372
If a PSX `.bin` is loaded, try synthesising a `.cue`
...
this works but takes forever, which I'm guessing is because somewhere it's
trying to hash the whole file. that's not a new problem though
2023-04-09 10:06:06 +10:00
5f0683c1ae
Fix #3616
...
This had two issues. One, relative pathing with dlls is a no-go. Our hackery with changing cwd seems to confuse lua, and while it can find the dll, it fails to load as Windows (at least) does not consider cwd for loading up dlls it appears. Secondly, people using luasockets never actually loaded up the luasockets dll, rather we were bundling it ourselves. From history it seems this was due to our lua being compiled with CLR/.NET and that didn't play nice with exceptions? Doesn't seem to be an issue anymore, but we should probably still bundle luasockets for the time being given it used in many different projects which use the same script with multiple different emulators (thus our own sockets are simply not usable).
2023-04-08 16:01:36 -07:00
8ef8d4efb9
Remove unused `kernel32` import
2023-04-09 08:02:35 +10:00
e06d32c70a
Revert "throttle shouldnt act as paused when rewinding"
...
This reverts commit 007442773afixes #3268 but unfixes #3053 , which should instead be fixed by something that doesn't lead to breaking other things and the author of the "fix" giving up on the project
2023-04-08 23:07:34 +03:00
45ab749caf
Fix N64 (Ares64) system menu having a blank space on Mono
2023-04-09 05:34:19 +10:00
4ea80410b8
mame: fix bios selection menu
...
api changed in 952b4ecc67
2023-04-08 10:46:28 +03:00
619c25b69a
Bump version
2023-04-08 05:12:57 +10:00
6e77c7348f
Improve error message when core does not implement mem callbacks
2023-04-08 02:16:29 +10:00
fbe1f9b53e
fix parameter order with DeltaUpdate calls
...
fixes 8737203f3a
2023-04-04 23:54:05 -07:00
389c6ebec5
fix 2mg detection
...
fixes 8737203f3a
2023-04-04 23:52:05 -07:00
8737203f3a
Add ISaveRam implementation for AppleII, fix bug which caused DiskIIController to not be correctly stated
2023-04-04 23:46:26 -07:00
9ae5f786de
fix #3610
2023-04-04 05:04:00 -07:00
b8f3f089f2
Add in ISaveRam implementation for C64, using the deltas of disks.
...
Add in better docs for `DeltaSerializer`.
Fix C64 not remembering disk changes when swapping disks (swapping disks essentially just reset the disk previously)
2023-04-04 04:28:47 -07:00
2fc4683e6b
Fix edge case with C64 states when CurrentDisk is different
2023-04-02 06:58:56 -07:00
d95cd4becb
mame: use biggest int multiple of 60 as a framerate numerator
...
denominator is determined by taking refresh attoseconts `as_ticks(numerator)` which reduces the initial 64bit value to what can be used for video
mame needs flat 60fps for screenless machines, so we use a numerator that is a multiple, while also being a tiny bit more accurate than with 1,000,000,000
2023-04-02 16:54:28 +03:00
df71de64c8
speedup delta stating with disks with simple track tracking, should be within acceptable performance bounds (more or less)
2023-04-02 03:48:24 -07:00
86b33bd3ce
fix DeltaSerializer validation checks and add one more
2023-04-02 02:19:52 -07:00
6f7f94a06e
don't give the same name to each track when stating
...
fixes 00e2fea901
2023-04-02 02:12:25 -07:00
00e2fea901
Create `DeltaSerializer`, uses simple RLE encoding so the serialized delta isn't huge, use it for C64 EasyFlash and Disks
2023-04-02 02:10:51 -07:00
5ca888a8af
misc cleanups with previous commit
2023-04-01 19:57:47 -07:00
a311b3b6f3
Change up AppleII's "main ram" domain, add aux ram domain
...
The main ram previously seemed to just be a slice of the system bus between 0 - 0xbfff. this posed two problems: that area is banked, and that area could represent main ram or aux ram. main ram now represents all of the ram main ram can possible represent, ordered like how the core orders it (which the way it does it happens to be very natural in any case), and a new aux ram domain does the same thing but with aux ram
Also some other changes put in so Rider wouldn't error on building Virtu
2023-04-01 19:54:26 -07:00
2a70b532d5
Disable Hex Editor's "Save [to rom file]" when not looking at rom
...
fixes 2e19451b0
2023-04-02 05:30:34 +10:00
cd4c3cc353
fix various C64 state issues
...
Main changes here would be with cartridges, as it appears cartridge stating was just broken since 4ffcc9654a
2023-04-01 07:06:56 -07:00
a31ecb7c0f
fix new BSNES with subbsnes
...
fixes 22e35c45fc
2023-04-01 01:26:38 -07:00
22e35c45fc
hook up RTC support for new BSNES, resolves #3577
2023-04-01 01:23:16 -07:00
116bc26556
add in entries for the various regions for DSi NAND, add in handling to autodetect region
...
tentatively add in the bios7i and bios9i hashes from nointro
2023-03-31 20:22:23 -07:00
6284c98d72
hook up clear NAND flag and dsiware saveram support
...
do various cleanups
enforce clear NAND flag for movie recording and retroachievements hardcore mode
2023-03-31 06:23:58 -07:00
7ae3f447d6
correct default for showing lightgun cursor (a casual player probably wants this on)
...
fixes c7ea4cbd0e
2023-03-30 20:33:00 -07:00
c7ea4cbd0e
Correct neutral Y position for SNES lightguns (fixes old BSNES lightguns), add in a controller button for offscreen shots for Snes9x and new BSNES, add UI option to disable drawing lightgun cursor for new BSNES
2023-03-30 20:25:26 -07:00
380e459bec
Copy from an editable template file when making a new Lua script
2023-03-30 21:43:27 +10:00
0a2d4405f0
Revamp Waterbox Setup ( #3529 )
...
* Waterbox setup has been revamped to use the latest llvm parts (llvm 16 for compiler_rt/libunwind/libcxx/libcxxabi).
* Clang is now possible to use, and is the preferred compiler (due to superior performance).
* Supported compilers are now clang 14/15/16, and gcc 12.
* Other core updates are mixed in.
---------
Co-authored-by: Morilli <35152647+Morilli@users.noreply.github.com>
2023-03-28 16:53:33 -07:00
44322e6a7d
Add comments to Gambatte's `ITraceable` impl.
2023-03-26 12:49:52 +10:00
eee8a7e0cc
Split `Config.AVWriterResize` tuple into 2 props
...
fixes 32d2f2311
2023-03-26 12:36:24 +10:00
32d2f23117
Persist A/V settings to disk properly ( resolves #1226 )
2023-03-25 22:36:50 +10:00
10423abdf9
Invert default of `LuaWinform.BlocksInputWhenFocused` ( resolves #3591 )
...
fixes 0591d2e2d; now matches 2.8 behaviour
just no pleasing you people
2023-03-24 09:46:24 +10:00
480b51b274
Add keybind (hardcoded) for MainForm context menu
2023-03-22 13:28:39 +10:00
4368629e67
Use bulk peek in `IMemoryApi.{ReadByteRange,HashRegion}`
2023-03-20 12:33:08 +10:00
a8bffab1b6
Add unit tests for `IMemoryApi.HashRegion`
2023-03-20 12:33:02 +10:00
32e36e28bb
Skip drawing RAM Watch OSD outside window bounds
2023-03-20 08:16:05 +10:00
291a14315d
Use a cache for `tastudio.onqueryitemicon`
2023-03-18 11:22:15 +10:00
cddc092b96
Improve docs for some `tastudio` Lua lib callback functions
2023-03-18 10:27:37 +10:00
52fd5e41f8
Improve docs for `event.on{save,load}state`
2023-03-18 10:11:55 +10:00
f28067e7fc
More improvements to mem hook docs
...
fixes 6b4f3355f
2023-03-18 10:00:50 +10:00
44bf67e8a3
Add Satellaview entry to path config
2023-03-17 10:40:09 +01:00
3c7fd55f70
Mode2/2336 support ( fixes #3387 )
2023-03-16 20:17:55 -07:00
6c8d4c536a
Clear `MovieSession._queuedMovie` if rom load fails ( resolves #3582 )
...
for #3582 , `MovieSession.QueuedCoreName`, which gets passed to `RomLoader`,
evaluated to a nonexistent core name and couldn't be cleared
2023-03-17 11:50:30 +10:00
f565eeef74
Add test case for mem callback removing itself
2023-03-17 07:32:04 +10:00
f021159931
Split `FirmwaresMenuItem_Click`
2023-03-17 06:37:38 +10:00
39fda0fa17
Change wording of missing firmware warning
2023-03-17 06:37:38 +10:00
7c3e35f3e7
Fix window title after loading rom via FW config ( fixes #3581 )
2023-03-17 06:37:38 +10:00
eb6f2864ff
Only set `<PathMap/>` for Release builds
...
fixes 5dc385e22; also skip `SolutionDir` override if building projects
individually
2023-03-17 06:37:38 +10:00
6b4f3355fd
Correct mem callbacks docs ( resolves #3522 )
2023-03-16 14:48:17 +10:00
565a0b9141
Implement specialized `IMemoryCallback` collection
2023-03-16 14:30:19 +10:00
06c06dd35c
Add some tests for MemoryCallbackSystem
2023-03-16 14:30:19 +10:00
5dc385e228
Set `<PathMap/>` so per-machine paths don't leak into build output
2023-03-16 12:39:26 +10:00
389fd5015f
s/ProjectDir/MSBuildProjectDirectory/ in MSBuild include files
...
I don't think anything was broken, this is just a precaution
2023-03-16 12:39:26 +10:00
38b5f16ccc
Refactor enable Roslyn Analyzers flag
...
kept the old name, but turns out `-p:RunAnalyzersDuringBuild=true` also works
...good thing the old name wasn't documented
2023-03-16 12:39:25 +10:00
a8f26ccf08
Add `.bps` patch applier
...
currently unused, like `.ips` patch applier; will return to hook up to loading
(currently flagged as good dump if base was), write unit tests, and add a way to
save patched rom to disk
2023-03-16 03:32:46 +10:00
eb13e46f45
Refactor `.ips` patch applier
...
`RomGame` is never initialised with a non-null `patch` so this was and is unused
2023-03-16 03:32:41 +10:00
c2297283f4
Add in CDI support in DiscoHawk
...
(just needed to allow the file to be drag n' dropped)
2023-03-14 20:55:17 -07:00
809523d465
fix cheevo hashing for Jaguar CD (accounting for the proper multisession support chances)
...
add some notes to CDI, suppress one of the parsing sanity checks (not sure if it's right)
2023-03-14 20:39:46 -07:00
d9ac4166cf
.cdi support, seems to work
...
also expand the search for the jaguar cd header a bit, seems it can sometimes be at the second sector?
2023-03-14 05:16:12 -07:00
825c144d6a
Add `--userdata` CLI flag
2023-03-14 14:51:41 +10:00
cb71de8de1
Fix typo in .NET 6+ implementation of `DescribeIsNull`
2023-03-13 10:14:11 +10:00
51dab92826
Improve error message shown for malformed `.bk2`/`.tasproj`
...
of course I didn't test it
2023-03-13 03:23:04 +10:00
9d6a732cb4
Many cleanups in disc system
...
Multisession support! (resolves #3400 )
The support is a bit lackluster given some constraints of our environment (e.g. the lack of a readable leadin entirely), but they don't matter for now
2023-03-11 01:28:32 -08:00
1ca1f4a397
Finalise sysID name and alphabetise
2023-03-11 07:29:23 +01:00
17a098dfa3
implement SatellaviewCartridge in BSNESOptions
2023-03-11 07:29:23 +01:00
3a6eda25dc
add baseCartridge info to gamedb
...
+ implement baseCartridge parameter in code
2023-03-11 07:29:23 +01:00
6329d6a6fd
add all satellaview roms as separate firmware files
...
also implement corresponding loading code in the core
2023-03-11 07:29:23 +01:00
c954a84cd8
Add Satellaview rom detection code
2023-03-11 07:29:23 +01:00
76cfee6396
rename bs memory domains (and fix rom domain)
...
- also some other renames for clarity
2023-03-11 07:29:23 +01:00
c906c830dd
Implement bsx + bs memory loading
...
connect satellaview when loading bsmemory
this makes rtc somewhat work
also mark SubBSNESv115 as BSX core
2023-03-11 07:29:23 +01:00
8c780e42cb
minor BSNESOptions cleanup
2023-03-10 02:24:46 +01:00
cb785c4cdb
resolve TODO regarding bsnes settings
2023-03-10 02:17:35 +01:00
eef190d332
make bsnes settings `record` for easier comparison
2023-03-10 01:56:30 +01:00
2fca4282a9
Make `ApiContainer` props return `null` if req. services unavailable
...
specifically `MemoryEvents` and `MemorySaveState`
now they behave like `[OptionalApi]` rather than `[RequiredApi]`
2023-03-10 04:30:52 +10:00
6387291e37
Deprecate `IGuiApi.DrawText` in favour of new method `PixelText`
...
to match Lua
2023-03-10 03:55:05 +10:00
132029d18f
Sort out docs for text-drawing APIs, flipping drawText=>drawString
2023-03-10 03:54:55 +10:00
16afcffe81
Clean up how SGB/SNES menus for BSNES are handled
...
makes Satellaview a 0 LOC change, and deleting old BSNES will be easier too
2023-03-09 23:35:26 +10:00
1a30f6551e
Use LuaPictureBox' custom resize in all cases
2023-02-26 14:35:35 +10:00
2c3fb68776
fix PictureBox when width or height is null
2023-02-24 13:29:18 -08:00
b45668ecea
Parse RTC in DsmImport
...
see #3555
2023-02-21 18:33:46 +01:00
5804ff04e7
Fix memory handling for DSi achievements
2023-02-20 12:10:58 -08:00
27eef71085
Fix some more edge cases against PSX RetroAchievements hashing (and do it a bit nicer)
...
Update rcheevos, and with that add in the new DSi console ID
Experimentally revamp the build system, I'm looking into cmake here and it seems to do a great job. The builds committed here were built with clang-cl 15.0.1 and clang 15.0.7 (for Windows and Linux respectively). gcc/clang with msys2 still works fine. gcc on Linux should still work fine. MSVC (cl) itself even works (although as a note, it doesn't work with lto (/GL) due to the force everything exported flag I set). The old Makefile is still kept for future reference.
2023-02-19 23:42:33 -08:00
7b4bd52150
fix edge case with PSX hashing with RetroAchievements
2023-02-15 16:23:39 -08:00
fcbc44b64f
Resolve part of #3506
2023-02-12 12:30:14 +01:00
a2ff685fc1
release the mame core
...
I asked others and nobody minds. it's not like we're releasing a raw core that has accuracy or integration problems. it mostly works, and it's just modern mame with its current level of accuracy. if integration needs further tweaks to support more games, they will duly arrive while people use it for games that already work.
tasvideos used to only accept hawk submissions for cores marked as released in the code, which usually means the core author (or porter) considers it ready for business. I'm the original porter, and tasvideos staff, and I consider it generally ready. again, the other porter (CPP) didn't seem to mind.
2023-02-12 10:37:20 +03:00
a137cc406b
Allow `EmuClientApi.SpeedMode(6400)` (to match GUI; Lua max was 6399)
...
logic broken since introduction in 858f133f95f9757d7d
2023-02-10 13:53:27 +10:00
2350dddb69
fix pause at end of movie when playing a tasproj without tastudio
...
old commits seem to suggest the IsPlayingOrFinished special logic was only intended for HandleFrameLoopForRecordMode. doing it otherwise causes issues with other end movie actions (e.g. if at pause at end of movie, it will just spam pause every time you unpause the movie). when in tastudio `Settings.MovieEndAction == MovieEndAction.Record` is always true, so this only affects playing tasprojs outside of tastudio
2023-02-09 12:26:10 -08:00
b48649a91b
fix Lower Is Better checkmark with RCheevosLeaderboardForm
2023-02-09 11:52:04 -08:00
8c2751bb58
fix PCECD and PCFX hashing for retroachievements
2023-02-09 10:26:25 -08:00
a61be6ba2b
fix incorrect memory being used with a2600 and retroachievements
2023-02-09 08:25:58 -08:00
b14a741ffe
Merge `Where` calls
...
fixes 0d02d5c49e7884f679
2023-02-09 00:47:49 +10:00
eafb1fdcf5
Clean up Windows version comparison
...
fixes 1b8158f4c
2023-02-09 00:47:46 +10:00
6ea9e37e33
NES PPU Viewer - SpriteViewer also needed to be drawn without getting blurred
2023-02-08 05:09:33 -05:00
6fe91ae56c
Nes PPU Viewer - undo part of ac20835172 which made ctrl+c no longer work on pattern viewer
2023-02-08 05:07:26 -05:00
8b38237948
fix jacked up blur in patternviewer
2023-02-08 04:59:58 -05:00
63310fcf3d
NES PPU viewer - size of palettes box had got messed up by my last commit. what's going on?
2023-02-08 04:45:30 -05:00
b7b60ae7b4
NES PPU viewer: fix calculations of hovered sprites from mouse coordinates. they were pretty crashy before
2023-02-08 01:32:24 -05:00
cb162f12d6
NES PPU viewer: fix too-small sprites window which hid a bunch of the sprites
2023-02-08 01:25:49 -05:00
1b8158f4c2
skip this stupid administrator check on old windows versions. windows isn't capable of being useful for non-administrators until windows 10.
2023-02-08 01:07:41 -05:00
4ba7b68e66
add missing using namespace NDS to fix building
2023-02-08 00:56:32 -05:00
67466be2f4
Have TAS profile also enable NDS BIOS
2023-02-08 10:08:19 +10:00
1ca610b424
Set default `Form.Icon` to corphawk
...
not sure about this, and I think it also affects ext. tools
2023-02-08 07:15:25 +10:00
e7884f6796
Hide debug tools from Tool Box and add ext. tools
2023-02-08 07:15:24 +10:00
8b7cba96bb
Use a single-source-of-truth for tools' icons in menus and Tool Box
...
reverts 733b6c49b
2023-02-08 07:15:24 +10:00
0d02d5c498
Refactor `ToolBox.SetTools`
2023-02-08 07:15:24 +10:00
b93eb948fd
Unindent `MainForm.DisplayDefaultCoreMenu`
2023-02-08 07:15:24 +10:00
15eed689d0
Misc. refactors in `ExternalToolManager`
2023-02-08 07:15:24 +10:00
a86860faaa
Fix `--open-ext-tool-dll`
...
fixes 4566b744d
2023-02-08 07:15:23 +10:00
3c3ab6578e
Use system's canonical framerate for rewind duration estimate
2023-02-05 21:00:04 +10:00
f473db56c3
Fix NaN propagation in RewindConfig
2023-02-05 20:56:22 +10:00
b1e8d93f5f
remove unused using from last commit
...
need to check what's going to be committed, the auto-using thing keeps tripping me up
2023-02-01 21:27:49 -08:00
46a086ed32
fix b109dc8605
2023-02-01 21:26:44 -08:00
b109dc8605
Mute audio when opening modal dialogs (see #3545 )
2023-02-02 05:41:44 +10:00
26991944ee
Fix `<NoWarn/>` overwriting instead of appending
2023-02-02 00:07:04 +10:00
d8d9abeacd
Update OpenTK
2023-02-02 00:07:04 +10:00
e7d349f48d
Update Windows version check to reflect 8.1 EOL
2023-02-02 00:07:04 +10:00
cf0ce0f5bb
fix GC killing rcheevo callbacks
2023-01-27 02:47:05 -08:00
c4f2bed9fd
sledgehammer fix any remaining issues with RAIntegration
2023-01-26 08:00:43 -08:00
e67e646ca5
fix deadlock when loading state with hotkeys and RAIntegration is active
...
hotkeys don't go through messages so unlike other methods of loading a state this caused a deadlock (load state implies memory peeking to restore state)
2023-01-26 07:12:54 -08:00
e8dd2e94f2
Fix crashes when using menu item for save/load quicksave
...
fixes 22ba0d5c25
2023-01-26 05:49:52 -08:00
66282a25aa
fix a NullReferenceException this time...
...
this thing is getting annoying now
2023-01-26 04:32:53 -08:00
0170d8f0f0
resolve ObjectDisposedException
...
fixes 713944724d
2023-01-26 01:24:34 -08:00
713944724d
fix deadlocks in RAIntegration for real this time (i hate this hack)
...
fixes f8a5adecb5
2023-01-25 23:36:46 -08:00
03077daf71
fix a crash when loading a quicksave right after shutting down retroachievements
2023-01-25 22:43:57 -08:00
f8a5adecb5
fix possible deadlocks with RAIntegration due to dumb threading bs, cleanup some of this code
...
also make sure to reboot core when starting up RetroAchievements with RAIntegration active (RAIntegration doesn't do this itself it seems)
2023-01-25 22:28:26 -08:00
95001d0baa
Hack to fix Nymashock analog stick range (see #3528 )
2023-01-26 14:57:57 +10:00
c66d0c746e
Document `IMemoryDomains` invariants
2023-01-25 02:04:10 +10:00
9e8b0c604d
Add debugging helper `DescribeIsNull`
2023-01-25 01:14:50 +10:00
b174c346d4
Hex editor: unset ROM domain when loading MAME ROM
...
Previously, last non-MAME ROM would still appear under "File on Disk"
2023-01-20 09:29:31 +10:00
b2ed03c90d
Fix NRE in `HexEditor` domain selection for MAME
...
Fix NRE when MAME ROM was loaded without Open Advanced
2023-01-20 09:29:31 +10:00
15056f11f2
Fix typo ( resolves #3520 )
...
fixes 007d862c5
2023-01-15 05:38:03 +10:00
8c32157547
hotkey for toggling on screen messages
2023-01-14 12:00:37 -06:00
566d47e263
Several changes to the About dialog
...
- s/BizHawk/EmuHawk/
- s/multi-platform/multi-system/ because, while the former is technically true,
it's very much a Windows app, and the latter is what was intended anyway
- replaced logo w/ a nice upscale courtesy of @DrD2k9
- added VCS branch to commit link
- changed window title from VCS info to "About EmuHawk"
- added build config after release version
2023-01-14 14:31:41 +10:00
abee97b449
Remove pixels array from `DisplaySurface`; faster clearing
2023-01-08 08:53:45 +10:00
bc823f4795
Clear props of type `ApiContainer` when clearing injected API props
2023-01-08 08:27:31 +10:00
3c00c24fcd
Fix `ApiInjector` trying to set get-only props of type `ApiContainer`
2023-01-08 08:26:27 +10:00
16ee704332
Deduplicate `MemoryDomainDelegateSysBusNES`
2023-01-08 07:54:20 +10:00
0bd2a1d89b
Resolve bigEndian nonsense for MemoryDomainDelegateSysBusNES too
...
TODO: This is just MemoryDomainDelegate but with a SendCheatToCore delegate allowed to be added, surely we could just add this to the existing MemoryDomainDelegate? Or better yet MemoryDomainDelegateSysBusNES could just inherit MemoryDomainDelegate if this wants to be separated (and reduce all this code duplication)
2023-01-06 10:10:14 -08:00
2a7cbda8c5
Correctly pass in bigEndian for MemoryDomainDelegate's BulkPeekUshort/BulkPeekUint, fixes #3516
2023-01-06 10:02:28 -08:00
a896471164
fix MAME memory domains
2023-01-05 18:47:49 -08:00
3f4aee0154
Return success bool from `OpenRom` APIs (squashed PR #3514 )
...
* Return success bool from `OpenRom` APIs
* Finish propagating, update docs for other recently changed methods too
Co-authored-by: YoshiRulz <OSSYoshiRulz@gmail.com>
2023-01-06 03:50:13 +10:00
0591d2e2d2
Pass through input/hotkeys while Lua form is focused
...
to restore previous behaviour, call `forms.setproperty(form_handle,
"BlocksInputWhenFocused", true);`
2023-01-05 02:09:49 +10:00
af9f5b9b9c
Add some sort of documentation for B/V gamedb flags
2023-01-05 00:41:25 +10:00
699ef428bf
Fix `mainmemory` lib keeping reference to unloaded core's memdomain
2023-01-03 23:46:02 +10:00
5827cbd829
`Trim()` when copying Log Window selection to clipboard
...
see e269bfd49
2023-01-03 23:26:36 +10:00
e7d95aa07d
Disable Lua tests in CI
2023-01-03 07:31:27 +10:00
ec6fe5fcf1
Change loadstate methods to return a bool indicating success
2023-01-03 06:49:29 +10:00
250b839e2c
Extract method from `LoadBranchToolStripMenuItem_Click`
2023-01-03 06:49:29 +10:00
007d862c58
Finish renaming quicksave slot 0 to 10 ( resolves #3112 )
2023-01-03 06:49:28 +10:00
7f33a8836d
Invert some conditionals in `MainForm` to reduce indent level
2023-01-03 06:49:28 +10:00
fcf7ac1fab
Change first param of `{Save,Load}QuickSave` from string to int
...
also swapped bool params of `SaveQuickSave`
2023-01-03 06:49:28 +10:00
22ba0d5c25
Dedup click handlers for `File` > `Save State` and `Load State`
...
`File` > `Save Slot` already did this
2023-01-03 06:49:28 +10:00
4b30cab993
Check the correct integer type for tastudio.setplayback
...
New lua actually has integers so this is a long instead of a double
2022-12-31 18:10:36 -08:00
05ff3ab40c
merge some mGBA upstream commits, partially revert c891cc2cb5 (upstream commits makes our changes not really needed)
2022-12-22 20:26:11 -08:00
00d450075e
oops forgot a colon here
2022-12-21 00:43:52 -08:00
c7c5ed229d
add pc2 extension for wonderswan
...
these are pocket challenge v2 roms, which is some handheld system which is actually just a wonderswan inside so these roms work anyways with cygne
2022-12-21 00:41:42 -08:00
603530d540
set gcAllowVeryLargeObjects to allow 2GB+ arrays
2022-12-21 07:43:34 +01:00
79857a3b71
Revert "make a new "FixedGrowthList" and use it for the StringLogs"
...
This reverts commit da5fae0b01
2022-12-21 07:42:31 +01:00
66c19cfcb2
Support marshalling arrays of length 0 through BizInvoker
...
Such arrays will be marshalled with valid and unique pointers that can be compared but not read from or written to.
2022-12-20 18:04:41 -05:00
5b0fe947df
fix #3498
2022-12-20 10:40:03 -08:00
6678fb4296
More cleanup of switch in `RetroAchievements.SystemIdToConsoleId`
2022-12-20 18:58:17 +10:00
7703ee5f37
Refactor `IGameboyCommon.IsCGBMode`
2022-12-20 18:58:17 +10:00
CasualPokePlayer