ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

use glBufferSubData when possible instead of glBufferData, gives a nice performance boost

This commit is contained in:
CasualPokePlayer 2023-08-11 16:57:20 -07:00
parent 3622fe76f9
commit dfd7caaacb
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/BizHawk.Bizware.Graphics/OpenGL/IGL_OpenGL.cs
View File

@ -332,6 +332,7 @@ namespace BizHawk.Bizware.Graphics
{
public uint vao;
public uint vbo;
public int bufferLen;
}
public VertexLayout CreateVertexLayout()
@ -340,6 +341,7 @@ namespace BizHawk.Bizware.Graphics
{
vao = GL.GenVertexArray(),
vbo = GL.GenBuffer(),
bufferLen = 0,
};
return new(this, vlw);
@ -443,7 +445,20 @@ namespace BizHawk.Bizware.Graphics
unsafe
{
GL.BufferData(GLEnum.ArrayBuffer, new UIntPtr((uint)(count * stride)), data.ToPointer(), GLEnum.StaticDraw);
var vertexes = new ReadOnlySpan<byte>(data.ToPointer(), count * stride);
// BufferData reallocs and BufferSubData doesn't, so only use the former if size changes
if (vertexes.Length != vlw.bufferLen)
{
GL.BufferData(GLEnum.ArrayBuffer, vertexes, GLEnum.DynamicDraw);
}
else
{
// I tried to do a CRC check to avoid BufferSubData calls, actually hurts performance
GL.BufferSubData(GLEnum.ArrayBuffer, 0, vertexes);
}
vlw.bufferLen = vertexes.Length;
foreach (var (i, item) in vertexLayout.Items)
{