ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MAME does mark bad dumps, but it only keeps their info if good dump is not known yet. once a good dump appears, its info replaces the bad one. 

so simply sticking to newest rom sets is the safest, otherwise there's little user control, because there's no global list of all known dumps with indications which of them are bad and what to use instead.
This commit is contained in:
vadosnaprimer 2023-04-30 14:07:02 +03:00
parent 2010f5e15c
commit e065263ff2
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/BizHawk.Emulation.Cores/Arcades/MAME/MAME.ISettable.cs
View File

@ -4,6 +4,7 @@ using System.ComponentModel;
using System.Linq;
using BizHawk.Common;
using BizHawk.Common.StringExtensions;
using BizHawk.Emulation.Common;
namespace BizHawk.Emulation.Cores.Arcades.MAME
@ -164,6 +165,12 @@ namespace BizHawk.Emulation.Cores.Arcades.MAME
}
else
{
if (hashdata.Contains("^"))
{
hashdata = hashdata.RemoveSuffix("^");
name = name + " (BAD DUMP)";
}
hashdata = hashdata.Replace("R", "CRC:").Replace("S", " SHA:");
_romHashes.Add(name, hashdata);
}

14
src/BizHawk.Emulation.Cores/Arcades/MAME/MAME.cs
View File

@ -99,7 +99,19 @@ namespace BizHawk.Emulation.Cores.Arcades.MAME
lp.Game.Name = _gameFullName;
lp.Game.Hash = SHA1Checksum.ComputeDigestHex(Encoding.ASCII.GetBytes(hashes));
lp.Game.Status = _romHashes.Values.Any(static s => s is "NO GOOD DUMP KNOWN") ? RomStatus.Unknown : RomStatus.GoodDump;
if (_romHashes.Values.Any(static s => s is "NO GOOD DUMP KNOWN"))
{
lp.Game.Status = RomStatus.Unknown;
}
else if (_romHashes.Keys.Any(static s => s.Contains("BAD DUMP")))
{
lp.Game.Status = RomStatus.BadDump;
}
else
{
lp.Game.Status = RomStatus.GoodDump;
}
_core.mame_info_get_warnings_string(_infoCallback);
_infoCallback = null;