ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Optimize Remove[Prefix|Suffix] by using ordinal string comparison

This commit is contained in:
Morilli 2023-05-27 03:50:46 +02:00
parent f6135abe65
commit c3ec8393d0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/BizHawk.Common/Extensions/StringExtensions.cs
View File

@ -45,7 +45,7 @@ namespace BizHawk.Common.StringExtensions
/// <paramref name="str"/> with the leading substring <paramref name="prefix"/> removed, or
/// <paramref name="notFoundValue"/> if <paramref name="str"/> does not start with <paramref name="prefix"/>
/// </returns>
public static string RemovePrefix(this string str, string prefix, string notFoundValue) => str.StartsWith(prefix) ? str.Substring(prefix.Length, str.Length - prefix.Length) : notFoundValue;
public static string RemovePrefix(this string str, string prefix, string notFoundValue) => str.StartsWith(prefix, StringComparison.Ordinal) ? str.Substring(prefix.Length, str.Length - prefix.Length) : notFoundValue;
/// <returns>
/// <paramref name="str"/> with the last char removed, or
@ -66,7 +66,7 @@ namespace BizHawk.Common.StringExtensions
/// <paramref name="str"/> with the trailing substring <paramref name="suffix"/> removed, or
/// <paramref name="notFoundValue"/> if <paramref name="str"/> does not end with <paramref name="suffix"/>
/// </returns>
public static string RemoveSuffix(this string str, string suffix, string notFoundValue) => str.EndsWith(suffix) ? str.Substring(0, str.Length - suffix.Length) : notFoundValue;
public static string RemoveSuffix(this string str, string suffix, string notFoundValue) => str.EndsWith(suffix, StringComparison.Ordinal) ? str.Substring(0, str.Length - suffix.Length) : notFoundValue;
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static bool StartsWith(this ReadOnlySpan<char> str, char c)