ccf2c61a23
fix #3664
2023-05-20 03:11:40 -07:00
08ead80385
make these callback delegate caches static (why didn't this warn that static was possible here?)
2023-05-19 22:30:17 -07:00
3c53f52c6d
remove some debugging crap from c9e30060d4
2023-05-19 22:28:32 -07:00
542cf2433a
Reduce allocation spam in Jaguar disassembly functions
2023-05-19 22:26:45 -07:00
c9e30060d4
Rework the Reader/Writer callbacks for the WaterboxHost, a bit nicer here working with the userdata
...
Also make it so initial loading uses the zstdstream or filestream directly instead of a memorystream with it all loaded
something of note, not really happy with how these read/write callbacks get used in practice, it seems they get spammed in small chunks
for initial loading, it's 8192 byte chunks each, which can be a LOT of callbacks, depending on core size (gpgx is ~500, MAME is ~22K)
similarly, savestates suffer a similar issue, although instead it's a ton of 4096 byte chunks (page size eh?)
The unmanaged <-> managed transitions obviously are not exactly performant, and I imagine are taking a significant portion of the time here
Perhaps some buffering strategy should come in on the native waterboxhost side to alleviate callback spam?
2023-05-19 22:26:45 -07:00
99a6b1d339
add hotkey for toggling the 'Display Nothing" feature
2023-05-19 20:05:16 -05:00
8a13793d00
Turn WaterboxHostNative ReturnData to a struct, misc cleanups elsewhere
2023-05-18 22:21:17 -07:00
332143ea8d
invalidate cram caches when poking, maybe
2023-05-18 21:14:57 -07:00
473d3cc294
fix #3662
2023-05-18 19:09:08 -07:00
ea854ff39d
make discohawk form a bit bigger
...
all the formats supported means the box wasn't big enough to display all of them lol
2023-05-18 07:28:10 -07:00
fe79b69123
(Partial) .nrg support
...
TAO support isn't complete, a lot of sanity checking isn't done yet
2023-05-18 07:14:14 -07:00
3d30f52e7c
Fix LogWindow treating everything as ascii
...
hopefully this doesn't break anything
2023-05-17 14:54:18 +02:00
f11b5bc9c4
fixup CDI generated subcode (not sure why I did that)
...
have it generate "leadin" and "leadout" tracks for multisession discs... this is almost certainly wrong for leadin (doesn't matter so far), leadout is probably right...
2023-05-12 20:47:29 -07:00
0e6d5fb708
minor addendum to 2012b083f6
2023-05-12 03:28:14 -07:00
2012b083f6
Fixup multisession handling with MDS and improve its track/sector size handling, also maybe fix it entirely? (not sure if this ever worked)
...
Move the various synths using the CUE SS_Base to a file, mostly just a nicer organizational change as MDS and CDI use one of these but not CUE
Misc improvements elsewhere
2023-05-12 02:44:05 -07:00
1f3068fe77
fix synthesizing disc tracks with multisession discs when the first session has a large amount of tracks
...
FirstRecordedTrackNumber only works here for the first session, for future sessions it doesn't work and may just result in out of range exception
2023-05-11 02:57:14 -07:00
858ea372a9
Fix Jaguar CD detection for Caves of Fear
2023-05-11 02:28:33 -07:00
e3c27813b6
fix the fix in 45a0c8cffb
2023-05-10 05:37:03 -07:00
45a0c8cffb
another fix for 9551394
2023-05-10 05:23:24 -07:00
c52a950c41
Fix dumping CCDs with multisession discs, fix oopsies with CDI parsing giving the wrong last recorded track number
2023-05-10 04:58:37 -07:00
2379650e1b
Implement error and verbose message callbacks for rcheevos (currently they just output to the console)
...
Implement debug option for hashing with more pure rcheevos logic, mostly just useful for figuring out disc hashing issues
2023-05-10 03:11:50 -07:00
d3a689c589
Resolve #3650 . Also fix a bug which caused overwriting lua scripts with a new lua script to fail (fixes 380e459bec)
2023-05-08 03:01:41 -07:00
f677e92504
fix TOC field mixup with Jaguar CD
2023-05-07 22:09:52 -07:00
40e21b716e
fix 955139454a
2023-05-07 02:59:38 -07:00
7d5a1d5c98
Lower CPU usage from RCheevos http stuff
2023-05-07 02:41:07 -07:00
68cd28c28a
fix directionals and other common buttons being dropped from controller inputs when hotkeys overrode controller inputs
2023-05-07 01:00:13 -07:00
4a752f66b7
Add Analyzer to require checking or discarding `TryGetValue`
...
I'm pretty sure all the existing instances were intended to use `default(T)` if
the key isn't present, except maybe the cheatcode converters but I don't care to
rewrite those at the moment
2023-05-05 06:27:15 +10:00
384a4e1e18
Bump version info post-release
2023-05-04 08:10:07 +10:00
36fae775d4
Prevent annoying waits when using firmware manager with DSi NANDs present
2023-05-03 02:19:56 -07:00
5f6d70ac46
Fix random crashes with rcheevos. The issue was that rc_runtime_t can store pointers to itself, which is bad when rcheevos expected the user to allocate that struct and did not provide functions for that. I've added that functionality and PR'd it (I'll fixup submodule to point to upstream when it's merged)
...
PR can be found here: https://github.com/RetroAchievements/rcheevos/pull/239
Also minor fixes wrt the ContinueWith usage in InternalDoRequest
2023-05-03 01:54:57 -07:00
248b8ab984
Fixup bad threading (no, you cannot access rcheevo's _runtime in a separate thread! main thread use only!). Should fix up some random crashes
...
Slightly change up the request model, now InternalDoRequest does not block
Fixup logic of ToSoftcoreMode (and comments so it isn't screwed up again)
2023-05-02 21:47:09 -07:00
8ef1d93891
Prevent UI thread deadlocking on Dispose()'ing rcheevos stuff
2023-05-02 17:18:31 -07:00
b9a983f1fe
Fix typo causing crash with SMSHawk with RetroAchievements & Hardcore Mode
2023-05-02 17:08:39 -07:00
41d94e4262
Change up multithreaded rendering in melonDS
...
Instead of creating a new Task and destroying it every frame, just create a new thread and call the delegate when needed.
Also allow for rendering a frame twice, this is actually possible anyways (albeit rarely done).
This should also help against a potential deadlock due to the Task.Wait call on the UI thread (which has special semantics in WinForms)
Also minor nitpicks in RCheevos code
2023-05-02 16:52:48 -07:00
b517228475
Refactor rcheevo http requests (again). This should better protect against the UI thread deadlocking due to Task semantics with WinForms
2023-05-01 03:50:49 -07:00
e065263ff2
MAME does mark bad dumps, but it only keeps their info if good dump is not known yet. once a good dump appears, its info replaces the bad one.
...
so simply sticking to newest rom sets is the safest, otherwise there's little user control, because there's no global list of all known dumps with indications which of them are bad and what to use instead.
2023-04-30 14:07:08 +03:00
2010f5e15c
disable leaderboard list form, for now, and revert efa6505
...
see that commit for details on issues with this form (this form is kind of useless anyways, meh)
2023-04-28 18:37:06 -07:00
8a5921182e
Add Analyzer to disallow discarding locals e.g. `_ = result;`
...
fixes 70bd081a9a2185d9ef
2023-04-29 01:52:43 +10:00
a2185d9ef0
fix 70bd081a93
...
The entire call is skipped in release mode if you place it inside a Debug.Assert.
2023-04-28 03:14:56 -07:00
66f26bb1c1
Create and use `IDictionary.GetValueOrPut{,New,New1}` extensions
2023-04-27 17:25:03 +10:00
fa48278354
Enable MEN014 and fix noncompliance
...
"Prefer TryGetValue"
2023-04-27 17:24:55 +10:00
c8589de5c6
fix #3648
2023-04-26 23:05:11 -07:00
102dee9622
Fix some SMS audio inaccuracies (squashed PR #3602 )
...
* fix noise audio channel on SMS VDP
* Update SN76489sms.cs
also, white noise is generated by XORing bits 0 and 3, not 0 and 1, on an SMS/GG VDP
* Update SN76489sms.cs
reverting commit #7b857e7
2023-04-27 15:46:52 +10:00
dd30a389a0
TAStudio/PatternsForm: Block deletion of loop entry which would cause a crash
2023-04-27 15:14:44 +10:00
07ba36956a
TAStudio/PatternsForm: Allow looping to entry zero
2023-04-27 15:14:44 +10:00
9cbd238997
Convert `GenericDebugger.DisasmOp` to a struct
2023-04-23 19:08:19 +10:00
70bd081a93
Refactor `ServiceInjector`
2023-04-23 17:41:55 +10:00
c5d6a66e01
Resolve TODO re: memoisation in `GenericDebugger`
2023-04-23 17:41:55 +10:00
4b001a48a9
Dedup `GenericDebugger.EngageDebugger`
2023-04-23 17:41:55 +10:00
ac3e76309f
Use helper prop here
2023-04-23 17:41:54 +10:00
bcdeec369a
Move commented-out code to `#if false`
2023-04-23 17:41:50 +10:00
396e876320
Optimize TAStudio column drawing by caching PlayerNumber for each column name
...
TAStudio previously called `PlayerNumber(...)` for each visible cell with the column's name, only to determine whether its player number is odd or even.
Because that function uses regex and is potentially called extremely often, this had a noticable impact on fps.
I've decided to just cache the odd/even playernumber result in a dictionary for faster access, which while not being my preferred way of handling this at least results in a decent speedup.
2023-04-23 00:15:43 +02:00
afb92870e4
TargetName -> AssemblyName
...
this fixes the winforms designer in Rider, let's hope it doesn't break anything though
2023-04-22 13:51:13 +02:00
a8aced4474
Workaround crashes in MAME's zlib decompression code ( #3639 )
...
* Workaround crashes in MAME's zlib decompression code (see https://github.com/TASEmulators/BizHawk/issues/3615 )
* Use using block, only catch InvalidDataException (what will be thrown if the zip entry has an unsupported (likely lzma) compression method)
2023-04-20 09:29:03 -07:00
efa6505826
prevent crashes when loading up leaderboard forms
...
apparently some game had 2002 leaderboards which caused a crash when making a form for every one of them in the leaderboard list, I guess windows has a limit on the amount of forms that can be active at once?
this is a quick hack to prevent such a crash, design needs to be rethought
2023-04-20 09:00:16 -07:00
1356bc6a3f
i guess this is required oops
...
fixes bc16a2cdaa
2023-04-20 12:31:33 +02:00
bc16a2cdaa
Implement IBasicMovieInfo interface for IMovie ( #3634 )
...
* Implement IBasicMovieInfo interface for IMovie
this allows parsing basic movie fields into an own class that is independent from Bk2Movie/TasMovie
This is mainly useful for the PlayMovie dialog which can now load movie information from files on disk without having to go through the entire Bk2Movie/TasMovie loading process
* don't potentially iterate input log twice
* Optimize LoadFramecount
2023-04-20 10:43:02 +02:00
cf88e61875
c# side changes to use the split ares' binaries
...
resolves #3614 and #3617
2023-04-19 23:23:12 -07:00
8cf820da4d
Don't send invalid paths to MAME
...
Waterbox cores can't create files anyways, and trying to send in ? might make MAME try to make the directory anyways (which crashes due to the syscall for that being unimplemented), while "" will not do that
2023-04-19 18:41:05 -07:00
b5e2a0c422
Move some .gitignore entries to nested dirs
2023-04-19 15:59:34 +10:00
955139454a
fix Jaguar CD homebrew hashing wrt retroachievements
2023-04-18 22:38:13 -07:00
4268c50617
Fix RetroAchievements rich presence not working
...
Cleanup this code so it plays nicer with BizHawk's "run everything on the main thread" (+ WinForms not playing nice with async methods)
Resend any game session start / achievement unlocks / leaderboard triggers if they failed. Wait for all achievement unlocks and leaderboard triggers to finish on Dispose() (mostly for catching them when user closes BizHawk)
Update rcheevos to 10.7.0
2023-04-18 21:35:58 -07:00
20e5c43bc8
Add `--socket_udp` CLI flag
2023-04-18 19:15:02 +10:00
0f2a76bd5e
lazy-initialize zstd contexts to reduce alloations
...
This becomes mostly apparent in the PlayMovie dialog where one zstd instance is created for every single movie, churning significant amounts of memory even though zstd isn't even used
2023-04-16 15:33:40 +02:00
98afdb8993
(Actually) Fix DeltaSerializer's `GetDelta`
...
fixes 2838a5412a
2023-04-15 22:04:21 -07:00
2838a5412a
Fix DeltaSerializer's `GetDelta`
...
Fixes AppleII/C64 states sometimes crashing when a disk change actually happens
2023-04-15 21:33:51 -07:00
ebd36f08b6
Downgrade `System.Drawing.Common` to 6.0.0 and enable Unix impl.
...
fixes 65ffa3fc2
2023-04-16 10:49:18 +10:00
6ffe99c006
Use the right `Sameboy` ctor in testroms project
...
This reverts commit 379eeeeed8
2023-04-16 10:14:46 +10:00
236c748b1a
Downgrade MSTest to 2.2.9
...
fixes 65ffa3fc2
2023-04-16 10:14:43 +10:00
a1fe557d31
Re-enable MA0020 and fix noncompliance
2023-04-16 09:02:40 +10:00
65ffa3fc2e
Blindly update NuGet deps
...
temporarily disabled MA0020
2023-04-16 09:02:40 +10:00
85a481f93f
Nes.Core now updates the DataBus in WriteMemory() ( #3633 )
...
* Nes.Core now updates the DataBus in WriteMemory()
This will fix open bus execution following write instructions.
* Properly formatted changes in previous commit
I have addressed the requested changes.
2023-04-15 21:24:27 +03:00
f2880d8325
Update `CoreComm` init in testroms project to new signature
...
fixes 76a29d356
2023-04-15 10:36:43 +10:00
379eeeeed8
Make `Sameboy` ctor public so testroms project can use it
...
fixes 9528a2030
2023-04-15 10:36:39 +10:00
c90fcbbd54
mame: numerator 0x4000'0000 and above breaks mp4 on youtube...
2023-04-14 19:32:29 +03:00
8e6eac7bfd
mame lua doesn't expose settings for optional dip switches, so hide them for now
...
38498868fc/src/mame/toaplan/toaplan2.cpp (L2960)
2023-04-14 19:23:50 +03:00
59562d8930
Fix `[RequiredService]`s checked for `null`
2023-04-13 08:53:14 +10:00
5f77a310c5
Remove `ServiceInjector.ClearServices`
...
This call in `ToolManager.Restart` was to set `[{Optional.Required}Service]`
props to `null`, but the tool form would get `Close`d immediately afterwards, so
it never gets the chance to hit the `null` path if one exists. However, some
tools are written as though they keep the stale value, for example attempting to
call a cleanup function on it in their `Closed` event handler. These will now
work as intended.
`[OptionalService]`s that can't be satisfied are set to `null` by
`ServiceInjector.UpdateServices`, so clearing those isn't necessary, and
`ClearServices` has no other usages.
2023-04-13 08:53:14 +10:00
ddc3e929e9
Use source generation for VersionInfo ( #3625 )
...
* Use source generator for VersionInfo
* Remove leftover hacks
* Use same fallbacks as NixHawk when Git not available
---------
Co-authored-by: YoshiRulz <OSSYoshiRulz@gmail.com>
2023-04-12 21:14:44 +02:00
03aa420bd5
fix last issue in #2951 properly
2023-04-09 23:43:28 -07:00
ffd8e6897a
don't keep multidisk flag on after it was set once
...
don't replace mame rom info icon and text with multidisk ones if there are emulation issues
2023-04-09 23:52:50 +03:00
fadc445f9c
mame: print more rom info
2023-04-09 23:40:59 +03:00
76a29d3563
allow setting OSD message duration for its callbacks
...
todo: simulate optional args for Action?
2023-04-09 22:08:37 +03:00
b4394af824
mame: report emulation status via rom info icon and text
...
mame won't care too much about how good the dump is, but it will warn you in orange that emulation is imperfect, and in red if it's broken. we happen to use rom status icon to inform the user about multidisk bundle, so using it for mame info feels natural, because it directly affects what users can safely submit to tasvideos. we warn them about bad dumps because it's banned for pub, so it's similar here.
2023-04-09 21:38:56 +03:00
8aa03c3059
mame: add emulation issues info to RomDetails
...
reorder file hashes and names so it looks aligned
2023-04-09 19:22:19 +03:00
0469c04372
If a PSX `.bin` is loaded, try synthesising a `.cue`
...
this works but takes forever, which I'm guessing is because somewhere it's
trying to hash the whole file. that's not a new problem though
2023-04-09 10:06:06 +10:00
5f0683c1ae
Fix #3616
...
This had two issues. One, relative pathing with dlls is a no-go. Our hackery with changing cwd seems to confuse lua, and while it can find the dll, it fails to load as Windows (at least) does not consider cwd for loading up dlls it appears. Secondly, people using luasockets never actually loaded up the luasockets dll, rather we were bundling it ourselves. From history it seems this was due to our lua being compiled with CLR/.NET and that didn't play nice with exceptions? Doesn't seem to be an issue anymore, but we should probably still bundle luasockets for the time being given it used in many different projects which use the same script with multiple different emulators (thus our own sockets are simply not usable).
2023-04-08 16:01:36 -07:00
8ef8d4efb9
Remove unused `kernel32` import
2023-04-09 08:02:35 +10:00
e06d32c70a
Revert "throttle shouldnt act as paused when rewinding"
...
This reverts commit 007442773afixes #3268 but unfixes #3053 , which should instead be fixed by something that doesn't lead to breaking other things and the author of the "fix" giving up on the project
2023-04-08 23:07:34 +03:00
45ab749caf
Fix N64 (Ares64) system menu having a blank space on Mono
2023-04-09 05:34:19 +10:00
4ea80410b8
mame: fix bios selection menu
...
api changed in 952b4ecc67
2023-04-08 10:46:28 +03:00
619c25b69a
Bump version
2023-04-08 05:12:57 +10:00
6e77c7348f
Improve error message when core does not implement mem callbacks
2023-04-08 02:16:29 +10:00
fbe1f9b53e
fix parameter order with DeltaUpdate calls
...
fixes 8737203f3a
2023-04-04 23:54:05 -07:00
389c6ebec5
fix 2mg detection
...
fixes 8737203f3a
2023-04-04 23:52:05 -07:00
8737203f3a
Add ISaveRam implementation for AppleII, fix bug which caused DiskIIController to not be correctly stated
2023-04-04 23:46:26 -07:00
9ae5f786de
fix #3610
2023-04-04 05:04:00 -07:00
b8f3f089f2
Add in ISaveRam implementation for C64, using the deltas of disks.
...
Add in better docs for `DeltaSerializer`.
Fix C64 not remembering disk changes when swapping disks (swapping disks essentially just reset the disk previously)
2023-04-04 04:28:47 -07:00
2fc4683e6b
Fix edge case with C64 states when CurrentDisk is different
2023-04-02 06:58:56 -07:00
d95cd4becb
mame: use biggest int multiple of 60 as a framerate numerator
...
denominator is determined by taking refresh attoseconts `as_ticks(numerator)` which reduces the initial 64bit value to what can be used for video
mame needs flat 60fps for screenless machines, so we use a numerator that is a multiple, while also being a tiny bit more accurate than with 1,000,000,000
2023-04-02 16:54:28 +03:00
df71de64c8
speedup delta stating with disks with simple track tracking, should be within acceptable performance bounds (more or less)
2023-04-02 03:48:24 -07:00
86b33bd3ce
fix DeltaSerializer validation checks and add one more
2023-04-02 02:19:52 -07:00
6f7f94a06e
don't give the same name to each track when stating
...
fixes 00e2fea901
2023-04-02 02:12:25 -07:00
00e2fea901
Create `DeltaSerializer`, uses simple RLE encoding so the serialized delta isn't huge, use it for C64 EasyFlash and Disks
2023-04-02 02:10:51 -07:00
5ca888a8af
misc cleanups with previous commit
2023-04-01 19:57:47 -07:00
a311b3b6f3
Change up AppleII's "main ram" domain, add aux ram domain
...
The main ram previously seemed to just be a slice of the system bus between 0 - 0xbfff. this posed two problems: that area is banked, and that area could represent main ram or aux ram. main ram now represents all of the ram main ram can possible represent, ordered like how the core orders it (which the way it does it happens to be very natural in any case), and a new aux ram domain does the same thing but with aux ram
Also some other changes put in so Rider wouldn't error on building Virtu
2023-04-01 19:54:26 -07:00
2a70b532d5
Disable Hex Editor's "Save [to rom file]" when not looking at rom
...
fixes 2e19451b0
2023-04-02 05:30:34 +10:00
cd4c3cc353
fix various C64 state issues
...
Main changes here would be with cartridges, as it appears cartridge stating was just broken since 4ffcc9654a
2023-04-01 07:06:56 -07:00
a31ecb7c0f
fix new BSNES with subbsnes
...
fixes 22e35c45fc
2023-04-01 01:26:38 -07:00
22e35c45fc
hook up RTC support for new BSNES, resolves #3577
2023-04-01 01:23:16 -07:00
116bc26556
add in entries for the various regions for DSi NAND, add in handling to autodetect region
...
tentatively add in the bios7i and bios9i hashes from nointro
2023-03-31 20:22:23 -07:00
6284c98d72
hook up clear NAND flag and dsiware saveram support
...
do various cleanups
enforce clear NAND flag for movie recording and retroachievements hardcore mode
2023-03-31 06:23:58 -07:00
7ae3f447d6
correct default for showing lightgun cursor (a casual player probably wants this on)
...
fixes c7ea4cbd0e
2023-03-30 20:33:00 -07:00
c7ea4cbd0e
Correct neutral Y position for SNES lightguns (fixes old BSNES lightguns), add in a controller button for offscreen shots for Snes9x and new BSNES, add UI option to disable drawing lightgun cursor for new BSNES
2023-03-30 20:25:26 -07:00
380e459bec
Copy from an editable template file when making a new Lua script
2023-03-30 21:43:27 +10:00
0a2d4405f0
Revamp Waterbox Setup ( #3529 )
...
* Waterbox setup has been revamped to use the latest llvm parts (llvm 16 for compiler_rt/libunwind/libcxx/libcxxabi).
* Clang is now possible to use, and is the preferred compiler (due to superior performance).
* Supported compilers are now clang 14/15/16, and gcc 12.
* Other core updates are mixed in.
---------
Co-authored-by: Morilli <35152647+Morilli@users.noreply.github.com>
2023-03-28 16:53:33 -07:00
44322e6a7d
Add comments to Gambatte's `ITraceable` impl.
2023-03-26 12:49:52 +10:00
eee8a7e0cc
Split `Config.AVWriterResize` tuple into 2 props
...
fixes 32d2f2311
2023-03-26 12:36:24 +10:00
32d2f23117
Persist A/V settings to disk properly ( resolves #1226 )
2023-03-25 22:36:50 +10:00
10423abdf9
Invert default of `LuaWinform.BlocksInputWhenFocused` ( resolves #3591 )
...
fixes 0591d2e2d; now matches 2.8 behaviour
just no pleasing you people
2023-03-24 09:46:24 +10:00
480b51b274
Add keybind (hardcoded) for MainForm context menu
2023-03-22 13:28:39 +10:00
4368629e67
Use bulk peek in `IMemoryApi.{ReadByteRange,HashRegion}`
2023-03-20 12:33:08 +10:00
a8bffab1b6
Add unit tests for `IMemoryApi.HashRegion`
2023-03-20 12:33:02 +10:00
32e36e28bb
Skip drawing RAM Watch OSD outside window bounds
2023-03-20 08:16:05 +10:00
291a14315d
Use a cache for `tastudio.onqueryitemicon`
2023-03-18 11:22:15 +10:00
cddc092b96
Improve docs for some `tastudio` Lua lib callback functions
2023-03-18 10:27:37 +10:00
52fd5e41f8
Improve docs for `event.on{save,load}state`
2023-03-18 10:11:55 +10:00
f28067e7fc
More improvements to mem hook docs
...
fixes 6b4f3355f
2023-03-18 10:00:50 +10:00
44bf67e8a3
Add Satellaview entry to path config
2023-03-17 10:40:09 +01:00
3c7fd55f70
Mode2/2336 support ( fixes #3387 )
2023-03-16 20:17:55 -07:00
6c8d4c536a
Clear `MovieSession._queuedMovie` if rom load fails ( resolves #3582 )
...
for #3582 , `MovieSession.QueuedCoreName`, which gets passed to `RomLoader`,
evaluated to a nonexistent core name and couldn't be cleared
2023-03-17 11:50:30 +10:00
f565eeef74
Add test case for mem callback removing itself
2023-03-17 07:32:04 +10:00
f021159931
Split `FirmwaresMenuItem_Click`
2023-03-17 06:37:38 +10:00
39fda0fa17
Change wording of missing firmware warning
2023-03-17 06:37:38 +10:00
7c3e35f3e7
Fix window title after loading rom via FW config ( fixes #3581 )
2023-03-17 06:37:38 +10:00
eb6f2864ff
Only set `<PathMap/>` for Release builds
...
fixes 5dc385e22; also skip `SolutionDir` override if building projects
individually
2023-03-17 06:37:38 +10:00
6b4f3355fd
Correct mem callbacks docs ( resolves #3522 )
2023-03-16 14:48:17 +10:00
565a0b9141
Implement specialized `IMemoryCallback` collection
2023-03-16 14:30:19 +10:00
06c06dd35c
Add some tests for MemoryCallbackSystem
2023-03-16 14:30:19 +10:00
5dc385e228
Set `<PathMap/>` so per-machine paths don't leak into build output
2023-03-16 12:39:26 +10:00
389fd5015f
s/ProjectDir/MSBuildProjectDirectory/ in MSBuild include files
...
I don't think anything was broken, this is just a precaution
2023-03-16 12:39:26 +10:00
38b5f16ccc
Refactor enable Roslyn Analyzers flag
...
kept the old name, but turns out `-p:RunAnalyzersDuringBuild=true` also works
...good thing the old name wasn't documented
2023-03-16 12:39:25 +10:00
a8f26ccf08
Add `.bps` patch applier
...
currently unused, like `.ips` patch applier; will return to hook up to loading
(currently flagged as good dump if base was), write unit tests, and add a way to
save patched rom to disk
2023-03-16 03:32:46 +10:00
eb13e46f45
Refactor `.ips` patch applier
...
`RomGame` is never initialised with a non-null `patch` so this was and is unused
2023-03-16 03:32:41 +10:00
c2297283f4
Add in CDI support in DiscoHawk
...
(just needed to allow the file to be drag n' dropped)
2023-03-14 20:55:17 -07:00
809523d465
fix cheevo hashing for Jaguar CD (accounting for the proper multisession support chances)
...
add some notes to CDI, suppress one of the parsing sanity checks (not sure if it's right)
2023-03-14 20:39:46 -07:00
d9ac4166cf
.cdi support, seems to work
...
also expand the search for the jaguar cd header a bit, seems it can sometimes be at the second sector?
2023-03-14 05:16:12 -07:00
825c144d6a
Add `--userdata` CLI flag
2023-03-14 14:51:41 +10:00
cb71de8de1
Fix typo in .NET 6+ implementation of `DescribeIsNull`
2023-03-13 10:14:11 +10:00
51dab92826
Improve error message shown for malformed `.bk2`/`.tasproj`
...
of course I didn't test it
2023-03-13 03:23:04 +10:00
9d6a732cb4
Many cleanups in disc system
...
Multisession support! (resolves #3400 )
The support is a bit lackluster given some constraints of our environment (e.g. the lack of a readable leadin entirely), but they don't matter for now
2023-03-11 01:28:32 -08:00
1ca1f4a397
Finalise sysID name and alphabetise
2023-03-11 07:29:23 +01:00
17a098dfa3
implement SatellaviewCartridge in BSNESOptions
2023-03-11 07:29:23 +01:00
3a6eda25dc
add baseCartridge info to gamedb
...
+ implement baseCartridge parameter in code
2023-03-11 07:29:23 +01:00
6329d6a6fd
add all satellaview roms as separate firmware files
...
also implement corresponding loading code in the core
2023-03-11 07:29:23 +01:00
c954a84cd8
Add Satellaview rom detection code
2023-03-11 07:29:23 +01:00
76cfee6396
rename bs memory domains (and fix rom domain)
...
- also some other renames for clarity
2023-03-11 07:29:23 +01:00
c906c830dd
Implement bsx + bs memory loading
...
connect satellaview when loading bsmemory
this makes rtc somewhat work
also mark SubBSNESv115 as BSX core
2023-03-11 07:29:23 +01:00
8c780e42cb
minor BSNESOptions cleanup
2023-03-10 02:24:46 +01:00
cb785c4cdb
resolve TODO regarding bsnes settings
2023-03-10 02:17:35 +01:00
eef190d332
make bsnes settings `record` for easier comparison
2023-03-10 01:56:30 +01:00
2fca4282a9
Make `ApiContainer` props return `null` if req. services unavailable
...
specifically `MemoryEvents` and `MemorySaveState`
now they behave like `[OptionalApi]` rather than `[RequiredApi]`
2023-03-10 04:30:52 +10:00
6387291e37
Deprecate `IGuiApi.DrawText` in favour of new method `PixelText`
...
to match Lua
2023-03-10 03:55:05 +10:00
132029d18f
Sort out docs for text-drawing APIs, flipping drawText=>drawString
2023-03-10 03:54:55 +10:00
16afcffe81
Clean up how SGB/SNES menus for BSNES are handled
...
makes Satellaview a 0 LOC change, and deleting old BSNES will be easier too
2023-03-09 23:35:26 +10:00
1a30f6551e
Use LuaPictureBox' custom resize in all cases
2023-02-26 14:35:35 +10:00
2c3fb68776
fix PictureBox when width or height is null
2023-02-24 13:29:18 -08:00
b45668ecea
Parse RTC in DsmImport
...
see #3555
2023-02-21 18:33:46 +01:00
5804ff04e7
Fix memory handling for DSi achievements
2023-02-20 12:10:58 -08:00
27eef71085
Fix some more edge cases against PSX RetroAchievements hashing (and do it a bit nicer)
...
Update rcheevos, and with that add in the new DSi console ID
Experimentally revamp the build system, I'm looking into cmake here and it seems to do a great job. The builds committed here were built with clang-cl 15.0.1 and clang 15.0.7 (for Windows and Linux respectively). gcc/clang with msys2 still works fine. gcc on Linux should still work fine. MSVC (cl) itself even works (although as a note, it doesn't work with lto (/GL) due to the force everything exported flag I set). The old Makefile is still kept for future reference.
2023-02-19 23:42:33 -08:00
7b4bd52150
fix edge case with PSX hashing with RetroAchievements
2023-02-15 16:23:39 -08:00
fcbc44b64f
Resolve part of #3506
2023-02-12 12:30:14 +01:00
a2ff685fc1
release the mame core
...
I asked others and nobody minds. it's not like we're releasing a raw core that has accuracy or integration problems. it mostly works, and it's just modern mame with its current level of accuracy. if integration needs further tweaks to support more games, they will duly arrive while people use it for games that already work.
tasvideos used to only accept hawk submissions for cores marked as released in the code, which usually means the core author (or porter) considers it ready for business. I'm the original porter, and tasvideos staff, and I consider it generally ready. again, the other porter (CPP) didn't seem to mind.
2023-02-12 10:37:20 +03:00
a137cc406b
Allow `EmuClientApi.SpeedMode(6400)` (to match GUI; Lua max was 6399)
...
logic broken since introduction in 858f133f95f9757d7d
2023-02-10 13:53:27 +10:00
2350dddb69
fix pause at end of movie when playing a tasproj without tastudio
...
old commits seem to suggest the IsPlayingOrFinished special logic was only intended for HandleFrameLoopForRecordMode. doing it otherwise causes issues with other end movie actions (e.g. if at pause at end of movie, it will just spam pause every time you unpause the movie). when in tastudio `Settings.MovieEndAction == MovieEndAction.Record` is always true, so this only affects playing tasprojs outside of tastudio
2023-02-09 12:26:10 -08:00
b48649a91b
fix Lower Is Better checkmark with RCheevosLeaderboardForm
2023-02-09 11:52:04 -08:00
8c2751bb58
fix PCECD and PCFX hashing for retroachievements
2023-02-09 10:26:25 -08:00
a61be6ba2b
fix incorrect memory being used with a2600 and retroachievements
2023-02-09 08:25:58 -08:00
b14a741ffe
Merge `Where` calls
...
fixes 0d02d5c49e7884f679
2023-02-09 00:47:49 +10:00
eafb1fdcf5
Clean up Windows version comparison
...
fixes 1b8158f4c
2023-02-09 00:47:46 +10:00
6ea9e37e33
NES PPU Viewer - SpriteViewer also needed to be drawn without getting blurred
2023-02-08 05:09:33 -05:00
6fe91ae56c
Nes PPU Viewer - undo part of ac20835172 which made ctrl+c no longer work on pattern viewer
2023-02-08 05:07:26 -05:00
8b38237948
fix jacked up blur in patternviewer
2023-02-08 04:59:58 -05:00
63310fcf3d
NES PPU viewer - size of palettes box had got messed up by my last commit. what's going on?
2023-02-08 04:45:30 -05:00
b7b60ae7b4
NES PPU viewer: fix calculations of hovered sprites from mouse coordinates. they were pretty crashy before
2023-02-08 01:32:24 -05:00
cb162f12d6
NES PPU viewer: fix too-small sprites window which hid a bunch of the sprites
2023-02-08 01:25:49 -05:00
1b8158f4c2
skip this stupid administrator check on old windows versions. windows isn't capable of being useful for non-administrators until windows 10.
2023-02-08 01:07:41 -05:00
4ba7b68e66
add missing using namespace NDS to fix building
2023-02-08 00:56:32 -05:00
67466be2f4
Have TAS profile also enable NDS BIOS
2023-02-08 10:08:19 +10:00
1ca610b424
Set default `Form.Icon` to corphawk
...
not sure about this, and I think it also affects ext. tools
2023-02-08 07:15:25 +10:00
e7884f6796
Hide debug tools from Tool Box and add ext. tools
2023-02-08 07:15:24 +10:00
8b7cba96bb
Use a single-source-of-truth for tools' icons in menus and Tool Box
...
reverts 733b6c49b
2023-02-08 07:15:24 +10:00
0d02d5c498
Refactor `ToolBox.SetTools`
2023-02-08 07:15:24 +10:00
b93eb948fd
Unindent `MainForm.DisplayDefaultCoreMenu`
2023-02-08 07:15:24 +10:00
15eed689d0
Misc. refactors in `ExternalToolManager`
2023-02-08 07:15:24 +10:00
a86860faaa
Fix `--open-ext-tool-dll`
...
fixes 4566b744d
2023-02-08 07:15:23 +10:00
3c3ab6578e
Use system's canonical framerate for rewind duration estimate
2023-02-05 21:00:04 +10:00
f473db56c3
Fix NaN propagation in RewindConfig
2023-02-05 20:56:22 +10:00
b1e8d93f5f
remove unused using from last commit
...
need to check what's going to be committed, the auto-using thing keeps tripping me up
2023-02-01 21:27:49 -08:00
46a086ed32
fix b109dc8605
2023-02-01 21:26:44 -08:00
b109dc8605
Mute audio when opening modal dialogs (see #3545 )
2023-02-02 05:41:44 +10:00
26991944ee
Fix `<NoWarn/>` overwriting instead of appending
2023-02-02 00:07:04 +10:00
d8d9abeacd
Update OpenTK
2023-02-02 00:07:04 +10:00
e7d349f48d
Update Windows version check to reflect 8.1 EOL
2023-02-02 00:07:04 +10:00
cf0ce0f5bb
fix GC killing rcheevo callbacks
2023-01-27 02:47:05 -08:00
c4f2bed9fd
sledgehammer fix any remaining issues with RAIntegration
2023-01-26 08:00:43 -08:00
e67e646ca5
fix deadlock when loading state with hotkeys and RAIntegration is active
...
hotkeys don't go through messages so unlike other methods of loading a state this caused a deadlock (load state implies memory peeking to restore state)
2023-01-26 07:12:54 -08:00
e8dd2e94f2
Fix crashes when using menu item for save/load quicksave
...
fixes 22ba0d5c25
2023-01-26 05:49:52 -08:00
66282a25aa
fix a NullReferenceException this time...
...
this thing is getting annoying now
2023-01-26 04:32:53 -08:00
0170d8f0f0
resolve ObjectDisposedException
...
fixes 713944724d
2023-01-26 01:24:34 -08:00
713944724d
fix deadlocks in RAIntegration for real this time (i hate this hack)
...
fixes f8a5adecb5
2023-01-25 23:36:46 -08:00
03077daf71
fix a crash when loading a quicksave right after shutting down retroachievements
2023-01-25 22:43:57 -08:00
f8a5adecb5
fix possible deadlocks with RAIntegration due to dumb threading bs, cleanup some of this code
...
also make sure to reboot core when starting up RetroAchievements with RAIntegration active (RAIntegration doesn't do this itself it seems)
2023-01-25 22:28:26 -08:00
95001d0baa
Hack to fix Nymashock analog stick range (see #3528 )
2023-01-26 14:57:57 +10:00
c66d0c746e
Document `IMemoryDomains` invariants
2023-01-25 02:04:10 +10:00
9e8b0c604d
Add debugging helper `DescribeIsNull`
2023-01-25 01:14:50 +10:00
b174c346d4
Hex editor: unset ROM domain when loading MAME ROM
...
Previously, last non-MAME ROM would still appear under "File on Disk"
2023-01-20 09:29:31 +10:00
b2ed03c90d
Fix NRE in `HexEditor` domain selection for MAME
...
Fix NRE when MAME ROM was loaded without Open Advanced
2023-01-20 09:29:31 +10:00
15056f11f2
Fix typo ( resolves #3520 )
...
fixes 007d862c5
2023-01-15 05:38:03 +10:00
8c32157547
hotkey for toggling on screen messages
2023-01-14 12:00:37 -06:00
566d47e263
Several changes to the About dialog
...
- s/BizHawk/EmuHawk/
- s/multi-platform/multi-system/ because, while the former is technically true,
it's very much a Windows app, and the latter is what was intended anyway
- replaced logo w/ a nice upscale courtesy of @DrD2k9
- added VCS branch to commit link
- changed window title from VCS info to "About EmuHawk"
- added build config after release version
2023-01-14 14:31:41 +10:00
abee97b449
Remove pixels array from `DisplaySurface`; faster clearing
2023-01-08 08:53:45 +10:00
bc823f4795
Clear props of type `ApiContainer` when clearing injected API props
2023-01-08 08:27:31 +10:00
3c00c24fcd
Fix `ApiInjector` trying to set get-only props of type `ApiContainer`
2023-01-08 08:26:27 +10:00
16ee704332
Deduplicate `MemoryDomainDelegateSysBusNES`
2023-01-08 07:54:20 +10:00
0bd2a1d89b
Resolve bigEndian nonsense for MemoryDomainDelegateSysBusNES too
...
TODO: This is just MemoryDomainDelegate but with a SendCheatToCore delegate allowed to be added, surely we could just add this to the existing MemoryDomainDelegate? Or better yet MemoryDomainDelegateSysBusNES could just inherit MemoryDomainDelegate if this wants to be separated (and reduce all this code duplication)
2023-01-06 10:10:14 -08:00
2a7cbda8c5
Correctly pass in bigEndian for MemoryDomainDelegate's BulkPeekUshort/BulkPeekUint, fixes #3516
2023-01-06 10:02:28 -08:00
a896471164
fix MAME memory domains
2023-01-05 18:47:49 -08:00
3f4aee0154
Return success bool from `OpenRom` APIs (squashed PR #3514 )
...
* Return success bool from `OpenRom` APIs
* Finish propagating, update docs for other recently changed methods too
Co-authored-by: YoshiRulz <OSSYoshiRulz@gmail.com>
2023-01-06 03:50:13 +10:00
0591d2e2d2
Pass through input/hotkeys while Lua form is focused
...
to restore previous behaviour, call `forms.setproperty(form_handle,
"BlocksInputWhenFocused", true);`
2023-01-05 02:09:49 +10:00
af9f5b9b9c
Add some sort of documentation for B/V gamedb flags
2023-01-05 00:41:25 +10:00
699ef428bf
Fix `mainmemory` lib keeping reference to unloaded core's memdomain
2023-01-03 23:46:02 +10:00
5827cbd829
`Trim()` when copying Log Window selection to clipboard
...
see e269bfd49
2023-01-03 23:26:36 +10:00
e7d95aa07d
Disable Lua tests in CI
2023-01-03 07:31:27 +10:00
ec6fe5fcf1
Change loadstate methods to return a bool indicating success
2023-01-03 06:49:29 +10:00
250b839e2c
Extract method from `LoadBranchToolStripMenuItem_Click`
2023-01-03 06:49:29 +10:00
007d862c58
Finish renaming quicksave slot 0 to 10 ( resolves #3112 )
2023-01-03 06:49:28 +10:00
7f33a8836d
Invert some conditionals in `MainForm` to reduce indent level
2023-01-03 06:49:28 +10:00
fcf7ac1fab
Change first param of `{Save,Load}QuickSave` from string to int
...
also swapped bool params of `SaveQuickSave`
2023-01-03 06:49:28 +10:00
22ba0d5c25
Dedup click handlers for `File` > `Save State` and `Load State`
...
`File` > `Save Slot` already did this
2023-01-03 06:49:28 +10:00
4b30cab993
Check the correct integer type for tastudio.setplayback
...
New lua actually has integers so this is a long instead of a double
2022-12-31 18:10:36 -08:00
05ff3ab40c
merge some mGBA upstream commits, partially revert c891cc2cb5 (upstream commits makes our changes not really needed)
2022-12-22 20:26:11 -08:00
00d450075e
oops forgot a colon here
2022-12-21 00:43:52 -08:00
c7c5ed229d
add pc2 extension for wonderswan
...
these are pocket challenge v2 roms, which is some handheld system which is actually just a wonderswan inside so these roms work anyways with cygne
2022-12-21 00:41:42 -08:00
603530d540
set gcAllowVeryLargeObjects to allow 2GB+ arrays
2022-12-21 07:43:34 +01:00
79857a3b71
Revert "make a new "FixedGrowthList" and use it for the StringLogs"
...
This reverts commit da5fae0b01
2022-12-21 07:42:31 +01:00
66c19cfcb2
Support marshalling arrays of length 0 through BizInvoker
...
Such arrays will be marshalled with valid and unique pointers that can be compared but not read from or written to.
2022-12-20 18:04:41 -05:00
5b0fe947df
fix #3498
2022-12-20 10:40:03 -08:00
6678fb4296
More cleanup of switch in `RetroAchievements.SystemIdToConsoleId`
2022-12-20 18:58:17 +10:00
7703ee5f37
Refactor `IGameboyCommon.IsCGBMode`
2022-12-20 18:58:17 +10:00
a54c94230f
Restore system menu behaviour re: SGB
...
fixes 81fe56fa6
2022-12-20 18:58:12 +10:00
81fe56fa6e
provide correct sysid in BsnesCore
2022-12-20 04:22:23 +01:00
aa0e2d6a5f
Use new CartRAM domain name in GBHawk's CDL impl. ( fixes #3497 )
...
fixes 7e00b7892
2022-12-19 13:20:37 +10:00
cee263e272
oops didn't mean to checkin this experiment (it doesn't do anything actually)
2022-12-17 21:53:47 -08:00
339915c013
check-in NLua to main repo
...
combine NLua with KeraLua (KeraLua is "gone" now I guess)
make it use the BizInvoker (so now it can properly handle the liblua5.4.so and lua54.dll names differing), also delete the liblua54.so.
minor speedup when creating a new empty table
make lua default to UTF8 internally, so we don't need to manually change the state's encoding
2022-12-17 21:51:10 -08:00
a1da5753ee
check-in NLua to main repo
...
combine NLua with KeraLua (KeraLua is "gone" now I guess)
make it use the BizInvoker (so now it can properly handle the liblua5.4.so and lua54.dll names differing), also delete the liblua54.so.
minor speedup when creating a new empty table
make lua default to UTF8 internally, so we don't need to manually change the state's encoding
2022-12-17 21:50:56 -08:00
55fdcbb3d1
Don't set modifiers for key release events
...
this fixes a bug in 1df6ce4e38
2022-12-18 06:03:55 +01:00
8db15d6951
Show warning dialog when running as Superuser/Administrator
2022-12-18 12:21:43 +10:00
767e30eee5
Also rename bundled CPC firmware files (see #3494 )
...
fixes 5be8b0aab
2022-12-18 12:02:23 +10:00
8d5f7b5478
make selecting user shaders not crash with the default empty string path
...
Path.GetDirectoryName throws if it is handed an empty string apparently
2022-12-17 12:16:03 -08:00
a680739c6e
Rename bundled ZX Spectrum firmware file ( resolves #3494 )
...
fixes 5be8b0aab
2022-12-17 22:47:57 +10:00
58beef8a46
remove speex use in melonDS (see 5f0e6a2242 for unmanaged side changes)
2022-12-16 23:04:35 -08:00
5e9e9ac289
remove libspeexdsp use in old bsnes core
2022-12-16 20:45:25 -08:00
c794d90878
Revert switch to system-wide Lua install on Linux
...
reverts ab355d46925795d237
2022-12-17 13:35:14 +10:00
25795d2372
remove GetErrorMessage call for Linux dep checks
2022-12-16 15:26:11 -08:00
ab355d4693
check some system lib deps on Linux and force user to provide their own liblua54 from package managers
2022-12-16 15:03:39 -08:00
767cc9059d
Improve handling of RA http requests, add some handling in case RA sound files are missing. Normally this shouldn't be needed as docs specify if the wav file fails to load it plays the default beep sound, except actually it just throws in practice???
...
The 2.9 rcs apparently have the "overlay" folder missing, so the sound files aren't present. I'm assuming there's some issue with build scripts there for releases...
2022-12-15 23:45:29 -08:00
f3ee3e7956
mGBA update, various cleanups and some reorg
2022-12-15 01:00:36 -08:00
f6503adfb8
Update virtualpads immediate when the movie status changes, huge improvement when using tastudio and virtualpad together as the record checkbox toggle now changes the readonly status of the pad
2022-12-13 08:39:29 +10:00
27f6800d45
fix #3489 (InitializeWork is called by itself for each gamedb file #include'd, so the event would have been set once the first gamedb file is loaded, oops), do some other cleanup here
2022-12-10 23:42:08 -08:00
b3c7f0fa48
IPlatformLuaLibEnv -> ILuaLibraries / Win32LuaLibraries -> LuaLibraries, cleanup usage of it, fix doc error in client.gettool
2022-12-10 21:46:22 -08:00
f101cb5a54
Additional corrections to newly-added Lua documentation
...
fixes 49cd836e1c7781d1c1
2022-12-11 13:35:29 +10:00
cbb335fec2
Fix Lua `require` not looking in Lua dir on Linux
...
see #3485
thanks to @CasualPokePlayer for research and initial implementation
2022-12-11 13:16:07 +10:00
9e4836d300
libretro handling cleanup, reorg some of this, fix some input cases, better domain names
...
funsie found in this cleanup: can't use `in` params with the BizInvoker as it doesn't like the read only semantics (results in some exception in CreateType)
2022-12-10 04:45:00 -08:00
64d693e63f
call retro_unload_game before retro_deinit (libretro api specifies retro_unload_game be called before retro_deinit, in practice cores don't really care but best fix this)
2022-12-08 23:18:37 -08:00
29443dae49
fix #3484
2022-12-08 14:26:23 -08:00
c4f4c793da
Remove unused `IPlatformLuaLibEnv` implementation
2022-12-09 05:41:49 +10:00
5197c36a5d
Remove `[Lua*StringParam]` as they're no longer relevant
...
fixes 45fbdb484
2022-12-09 05:40:31 +10:00
5c0143d6f6
Minor corrections to newly-added Lua documentation
...
fixes 1452f831a82c3b471ab687dea1b49cd836e1
2022-12-09 05:28:36 +10:00
49cd836e18
log warning when using the deprecated lua bit functions
2022-12-08 04:26:54 -08:00
56d66ca555
add reset support to libretro, resolves #3482
2022-12-07 19:54:59 -08:00
4caa99afe3
Remove Lua in Mono warning as it's no longer relevant
...
fixes 45fbdb484
2022-12-07 18:46:25 +10:00
01ab9416b5
Make script paths in .luases relative to .luases path
...
Restore behavior before 99dc0e03df
2022-12-07 18:24:21 +10:00
df4df517b8
Add `IMovieApi.PlayFromStart`/`movie.play_from_start` ( resolves #384 )
2022-12-07 18:16:13 +10:00
7fdc3f992d
Propagate success through to caller for movie load/restart
2022-12-07 18:16:13 +10:00
0076c8802b
Add `saveChanges` parameter to `IMovieApi.Stop`/`movie.stop`
2022-12-07 18:16:13 +10:00
e0a7a39b0d
Have `IMovieApi.Stop` implementation use `MainForm.StopMovie`
2022-12-07 18:16:13 +10:00
596e8d9198
Call `onexit` and cleanup when removing lua script
2022-12-07 18:15:31 +10:00
50fc7e28da
Make "Stop all scripts" behave the same as toggling them off
2022-12-07 18:15:31 +10:00
817b258a79
Remove relative path manipulation in `LuaConsole`
2022-12-07 18:15:31 +10:00
f625771cd0
Don't create FileSystemWatcher for missing directories
2022-12-07 18:15:31 +10:00
cf2b83b102
Disable lua script if loading fails
2022-12-07 18:15:31 +10:00
bd53807b0f
Store `LuaFile` `FileSystemWatcher` in dictionary
...
Avoid path string comparisons, `FileSystemWatcher` events may format relative paths differently
2022-12-07 18:15:31 +10:00
6aa7c48402
Update Lua registered functions window after restart
...
Make registered functions window show functions for new LuaImp after core restart/reopening the Lua console
2022-12-07 18:15:31 +10:00
ee66faba0b
Clean up old LuaImp before creating new one
...
Prevents memory/resource leak
Causes open forms to be closed on core restart
2022-12-07 18:15:31 +10:00
3a70fb65f8
Refactor disabling Lua script into separate method
2022-12-07 18:15:31 +10:00
7c7ac64ae6
Stop discarding Lua session save directory
...
Previously any path would into ".\foo.luases" and be saved in exe dir
2022-12-07 18:15:31 +10:00
9ee788195a
Improve Lua `FileSystemWatcher` thread safety
...
Make FSW invoke the entire event handler on main thread.
Avoids theoretical race condition and thread safety issues with the linq query.
2022-12-07 18:15:31 +10:00
733a8bee88
Dispose FileSystemWatchers in LuaConsole
2022-12-07 18:15:31 +10:00
28d6415190
Remove running scripts before loading session
...
Clean up scripts instead of just clearing script list
2022-12-07 18:15:31 +10:00
cc10de4033
Refactor removing Lua scripts into separate method
2022-12-07 18:15:31 +10:00
564a1e4a67
Remove obsolete `LuaConsole.RunLuaScripts`
...
Method is mostly a duplicate of `EnableLuaFile`, only called when loading a session or an already loaded script.
In either case it didn't actually start the scripts due to an inverted condition, and would stop running scripts without doing the required cleanup.
2022-12-07 18:15:31 +10:00
5d143ca879
Properly start scripts after loading Lua session
...
Previously, scripts would display as enabled but not actually run until toggled off and on.
2022-12-07 18:15:31 +10:00
0effd435f6
Fix issues when opening same Lua script multiple times
2022-12-07 18:15:31 +10:00
14e713837b
Change remaining `Config.DisableLuaScriptsOnLoad` refs to Settings
...
Resolve inconsistent use of duplicate property on `Config` and `LuaConsoleSettings`, finishes partial refactoring from 324a50a
2022-12-07 18:15:31 +10:00
a8e0192281
Use FLPs so UI scale doesn't break Record Movie dialog (see #2605 )
...
disables resizing the dialog; default is big enough and the `TextBox`es can
scroll
2022-12-07 15:43:25 +10:00
632f063073
Cleanup `RecordMovie` ctor
2022-12-07 15:43:24 +10:00
400b1b589b
Inline `RecordMovie.InitializeComponent` (Designer file)
2022-12-07 15:43:21 +10:00
102874e480
Fix N64 header detection being swapped ( fixes #3477 )
...
fixes abeaa2a10
2022-12-07 14:34:52 +10:00
62f6f3b471
Fix Win32LuaLibraries init'ing incorrectly on `DeveloperBuild = false`
2022-12-07 14:27:19 +10:00
def5df44fa
Fix double call to `UIHelper.ScaleX` in `ControllerConfig` (see #2605 )
...
fixes 93c47b87b
2022-12-07 05:29:27 +10:00
5e6c4a2bbd
fix justifier controller never working oops
2022-12-06 19:42:30 +01:00
96cc3f8745
BSNESv115: implement an extended gamepad controller with 4 extra buttons
...
this is a breaking change for existing movies, but only when a non-gamepad controller was used, which is rare
2022-12-06 19:21:08 +01:00
339994c5a7
change these to using var
2022-12-06 09:46:12 -08:00
b687dea1b0
change every IntPtr<->int cast to IntPtr<->long. we got 64 bit integers with lua now, and a pointer is 64 bits, so might avoid some dumb bug due to truncations and some ungodly amount of ram being used
...
TODO: see if we can skip this cast nonsense. the lua tests indicate IntPtr should pass through fine, being considered "userdata", probably better so the user can't just pass raw numbers for the handle.
2022-12-06 04:53:35 -08:00
bc79664461
fix implicit lua number to .net conversion
...
fix .net exceptions not halting the running script
fix inconsistency with stdout and lua console printing errors, both should end in a newline now
print the inner exception of a lua exception (i.e. the .net extension) if possible
2022-12-06 02:52:57 -08:00
eb00019c86
fix passing numbers for string args in .net lua functions (old engine had this behavior, granted "bad user" if they relied on this), add appropriate test
...
fix passing sbyte/char as args, add appropriate tests
cleanup the lua auto unlock hack, using a nice ref struct + dispose to handle it
2022-12-05 23:21:23 -08:00
920682688b
deprecate lua bit functions which have direct operator counterparts in new lua
2022-12-05 18:23:11 -08:00
dcd570bf87
fix mainmemory.write_bytes_as_dict
2022-12-05 16:46:22 -08:00
4a49fc174b
Improve LsmvImport in numerous ways
...
- previously, every second frame was empty (lol), since 2016 i believe
- now imports as (sub)bsnes115 movie instead of bsnes, allowing to import subframe inputs and delayed resets
- imports controller types correct(er)ly
2022-12-05 16:28:22 +01:00
10ba45d462
BSNESv115+: actually provide IBoardInfo properly
2022-12-04 22:48:29 +01:00
abeaa2a106
Be less lazy about N64 header detection in byteswapper
...
fixes 82c3b471a9660c16a0
2022-12-05 04:54:19 +10:00
9660c16a0a
fix N64 roms coming through multidisk bundler in ares
2022-12-04 01:35:58 -08:00
3dd36f5f07
revert the explicit try/finally use for PeekByte/PokeByte monitor domain methods, testing seems to show the ref struct use makes EnterExit allocation (now forced to the stack) a non-issue performance wise
2022-12-03 18:30:09 -08:00
f01463e2b3
Convert EnterExitWrapper to a readonly ref struct, this should be a speedup in all cases. Will need to experiment to see if this mean the try/finally from #3296 can be avoided
2022-12-03 17:46:49 -08:00
d508b734d6
Fix `MemoryApi.{Read,Write}ByteRange` edge cases
2022-12-04 09:23:28 +10:00
af44a85cfd
Add unit tests for `IMemoryApi.{Read,Write}ByteRange`
2022-12-04 09:23:28 +10:00
dc4efc3644
Fix typos and whitespace in `MemoryApi.cs`
2022-12-04 09:23:27 +10:00
1bdff05442
Use read-only collection types in `IMemoryApi`
2022-12-04 09:23:25 +10:00
cba206efec
Add `IUserDataApi.Keys`/`userdata.get_keys`
2022-12-04 04:06:58 +10:00
c2d5a9c931
Banish empty conditional blocks
2022-12-04 02:11:41 +10:00
84d2866f53
Clean up usage of `LuaFile.Enabled`/`Paused`
2022-12-04 01:43:02 +10:00
f798021bba
CloseRom acts like rebooting the core, so make it just reset Lua libs (more properly fixes #3226 without any yield nonsense)
...
Slight revert of 2efae13af4
2022-12-03 04:57:58 -08:00
15b2264cb4
Use LuaThread Yield here instead of directly using LuaState's
2022-12-02 19:45:29 -08:00
51f01efdc4
Properly handle errors when running a lua script, using Resume/Yield methods added to the LuaThread class (see f904fa0d53)
2022-12-02 14:44:05 -08:00
ae11dcc6af
replace default bsnes with bsnes115
2022-12-02 20:21:21 +01:00
6174398fb4
Also reset padding when removing last Lua script ( resolves #1509 )
2022-12-03 01:06:06 +10:00
a9756b60a2
Clear OSD + surfaces when removing a Lua script ( resolves #3014 )
...
they were already being cleared when closing the Lua Console
note the "Erase Stale/Stuck Lua Drawing Layers" button does not clear OSD,
leaving that as it is for now
2022-12-03 01:02:26 +10:00
2efae13af4
prevent some NREs occurring with the new Lua stuff
2022-12-01 14:59:36 -08:00
999e487557
Add `bizstring.pad_{start,end}` helpers
2022-12-02 06:18:32 +10:00
ca72f113df
Rename `event.onmemory*`, phase 1 ( resolves #759 )
2022-12-02 05:55:42 +10:00
6381448472
decimal is not floating-point
...
fixes fdbb34dff
2022-12-02 04:27:29 +10:00
5603e5ac01
Reorder items in Tools menu
2022-12-02 04:24:24 +10:00
3dcc3ff89f
Improve handling of exceptions thrown in `Form.Load` handlers
...
obviously only benefits forms inheriting `FormBase`
2022-12-02 03:48:36 +10:00
9393e1b764
Fix #3417 and improve handling of `default.tasproj` (squashed PR #3462 )
...
* Fix #3417 and improve handling of default.tasproj
* expose SetMovieController in the MovieSession interface (please don't rely on it anywhere else)
* don't use this explicit public in the interface
(is this mentioned anywhere? i assume this is proper style)
* use this helper function
2022-12-02 03:44:56 +10:00
10a38270e5
forgot a char
2022-12-01 19:12:45 +03:00
bace52c4f8
fix #2119
2022-12-01 19:10:57 +03:00
47c494a5a6
Bump System.Drawing.Common in main solution ( #3464 )
...
Bumps [System.Drawing.Common](https://github.com/dotnet/runtime ) from 5.0.2 to 5.0.3.
- [Release notes](https://github.com/dotnet/runtime/releases )
- [Commits](https://github.com/dotnet/runtime/compare/v5.0.2...v5.0.3 )
---
updated-dependencies:
- dependency-name: System.Drawing.Common
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-02 01:22:46 +10:00
45fbdb4844
Move to NLua/KeraLua/Lua5.4 ( #3361 )
2022-12-01 00:51:02 -08:00
fdbb34dff6
Lua tests ( #3373 )
2022-11-30 23:55:24 -08:00
92c1cdff22
RetroAchievements Support ( #3407 )
2022-11-30 23:51:17 -08:00
eb1cef1ffc
update mame to 0.250
2022-11-30 20:22:04 -08:00
8667dd9ee7
c# to previous commit
2022-11-27 23:29:54 -08:00
6baee38717
add n64 to multidisk bundler list
2022-11-27 05:51:47 -08:00
9420c8b21c
merge latest ares, hook up its new N64DD support, make ares use AxisContraint (see #3453 ), some other cleanups here
2022-11-27 05:44:00 -08:00
c23b063733
basic virtualpad + default controls for TIC80, mark it as released
2022-11-26 19:54:45 -08:00
c49a8d338c
Prefix `socketServerScreenShot` blob with length too ( resolves #3461 )
...
fixes b1602dae0
2022-11-26 18:42:10 +10:00
b8182f9149
Extract `ConcatArray` helper
2022-11-26 18:42:05 +10:00
1df6ce4e38
Fix key release events with modifiers not getting handled correctly ( #3402 )
2022-11-25 11:00:44 +01:00
bae71326bf
Fix hex editor for MAME when Open Advanced is not used
2022-11-25 01:31:02 -08:00
9a0403617b
Clean up SHA1
2022-11-24 20:15:35 +10:00
4566b744d9
Remember trusted ext. tools
2022-11-24 20:06:27 +10:00
f9ac3c4b32
Clean up `MainForm.ExternalToolMenuItem_DropDownOpening`
2022-11-24 20:06:20 +10:00
e269bfd49f
Log window - when copying pasting "MD5:2345" and Sha1, strip the md5 and sha1 out. I just want the number if I'm copying pasting the single line. If someone finds this objectionable, feel free to revert, but this savesme a lot of time
2022-11-23 10:54:59 -06:00
392d126173
remove an unused method
2022-11-23 10:11:45 -06:00
683aa263a0
Include `ControllerDefinition._orderedControls` in clone ctor
...
I don't think this is used, but as the caching was new in 2.8, going to include
this just in case
2022-11-23 15:35:45 +10:00
52acda9a02
Re-add an assignment in `InputManager.SyncControls` ( fixes #3458 )
...
partially reverts 781c152bf
2022-11-23 15:29:02 +10:00
3f352792a6
remove unused using from experiments in previous commit
2022-11-22 09:18:51 -08:00
da5fae0b01
make a new "FixedGrowthList" and use it for the StringLogs
...
this is mostly to workaround OOM issues with VERY large movies (>134217728 frames).
so large just the list of string references is "too big" and exceeds the .net 2GB limit.
even the on disk method fails here, as the offsets list (note, long and reference are the same size) becomes too big
this probably gives a bit of speedup for "normal" movies, as the generous 16MB growth amount would likely be plenty for the movie, although i haven't test this much
2022-11-22 09:10:19 -08:00
b967e6028d
Fix inconsistent application of colours from GTK theme, if available
...
still no idea why I can set dark theme on Ubuntu but not Manjaro, but now menus
won't use a white-to-black gradient with white text
2022-11-23 02:51:54 +10:00
589823d009
GPGX: add setting to disable per-line sprite limit
...
- resolves #3440
- includes manually cherry-picked e0ef0902e96bd9d71cb49c64505e755007e7452c
2022-11-22 14:44:39 +01:00
248e87b6d1
try to load a different core if an autodetected mame rom ends up failing to load
2022-11-21 18:28:56 -08:00
51826c4c17
Fix wrong MBC5 mapper being given a battery
...
0x1A is MBC5+RAM, 0x1B is MBC5+RAM+BATTERY
2022-11-19 20:44:55 -08:00
0cb63e8d6a
BSNESv115+: Implement overscan and aspect ratio correction settings
2022-11-18 13:08:27 +01:00
0bd182e6cc
properly handle "NO GOOD DUMP KNOWN" mame rom hashes
...
(note, these roms are not actually in the romset, so the singular hash in movies doesn't have to be affected here)
2022-11-17 17:45:49 -08:00
d507246033
c# side for previous commit
2022-11-16 21:33:55 -08:00
d0266816a5
Fix #3448 . Support MAME 7z romsets
2022-11-16 17:32:20 -08:00
4479fec74d
Add in the actual c# code for 5ae4470466
...
Apparently forgot to actually add this in for the commit >:
2022-11-16 15:35:37 -08:00
62c3b4b8e3
Use a small dll for handling the msabi<->sysv adapter ( #3451 )
...
make a small dll for handling the msabi<->sysv adapter, using only assembly (taken from generated optimized rustc output) and handcrafted unwind information (c# exceptions in a callback seem to work fine in testing)
additionally, allow floating point arguments. this really only needs to occur on the c# side. msabi and sysv agree on the first 4 floating point args and for returns, so no work actually has to be done adapting these
with assembly being used, we can guarantee rax will not be stomped by compiler whims (and avoid potential floating point args from being trashed)
2022-11-16 09:02:13 -08:00
a0de42b1b3
remove struct hack, it's not actually needed
...
out double is System.Double& while double is System.Double, so it doesn't actually trip paramenter verifier
2022-11-15 01:12:31 -08:00
eec86ad81a
Use actual doubles for figuring out aspect ratio
...
Fixes issues when mame sends over < 1 bounds which round down to 0 with a long cast (resulting in div by 0 exceptions)
Also fix some oopsies with incorrect function signatures.
Remove MAME string docs as they aren't really relevant anymore, as only MameGetString handles lua string handling now
2022-11-15 00:57:30 -08:00
715f4f497c
add some missing mame mnemonics
2022-11-11 08:45:02 -08:00
c21fedc76a
BSNESv115+: add option for disabling ppu sprite limit
2022-11-10 23:22:17 +01:00
066297d5e7
MAME Waterbox ( #3437 )
2022-11-10 00:05:25 -08:00
e7e587d625
Restore old behaviour of "Always use recent path for ROMs"
...
fixes 41d46dd37#1574
2022-11-08 06:30:12 +10:00
948084a97e
Use `Movie.NotActive` extension instead of negated `IsActive`
2022-11-07 06:10:37 +10:00
84cc71e454
Use `DialogResult.IsOk` extension everywhere and clean up
2022-11-07 06:03:55 +10:00
36cb62a792
Create and use `ToolStripDropDownItem.ReplaceDropDownItems` extension
2022-11-07 06:03:55 +10:00
5df9879842
Refactor `MultiDiskFileSelector.BrowseButton_Click`
2022-11-07 05:27:15 +10:00
04f34ac7af
Add `Util.BreakDebuggerIfAttached` helper
2022-11-07 04:37:34 +10:00
f1f0f1695c
Encapsulate `OpenFileDialog`/`SaveFileDialog`
2022-11-05 09:10:11 +10:00
2db5235319
Cache and reuse `FilesystemFilterSet`s
2022-11-05 09:10:11 +10:00
1232157cc1
Improve caching of `FilesystemFilterSet.ToString`
2022-11-05 09:10:11 +10:00
c153505b58
Invert some conditionals to reduce nesting
2022-11-05 09:10:10 +10:00
df63853cd5
Add `IDialogParent` interface to a couple of config dialogs
2022-11-05 09:10:05 +10:00
8949b1aa6b
Make sure `CheckLib` in `Program` static ctor disposes GUI properly
2022-11-04 07:08:54 +10:00
c891cc2cb5
Don't ignore mGBA skip BIOS setting when recording ( resolves #2465 )
...
also disable skip BIOS with TAS profile and enable with Casual profile
also removed `DeterministicEmulation ||= !SkipBios`, does it matter?
2022-11-03 12:04:16 +10:00
77f824ab55
Clean up `MGBAHawk.DeterministicEmulation` assignment
2022-11-03 11:56:01 +10:00
13a01340de
Refactor Libretro ControllerDef generation, fixing input display
...
see #3360
2022-11-03 11:02:53 +10:00
781c152bf6
Remove old ControllerDef copying that was messing with ControlsOrdered
2022-11-03 11:02:52 +10:00
a8f571f2d6
Reinstate `GameInfo.NullInstance`'s name, and only instantiate it once
...
reverts 8dcea2470
2022-11-03 11:02:44 +10:00
3e79e68d1d
Dedup in `CheatEdit.GetCheat`
2022-11-02 01:05:12 +10:00
414c21609b
Disallow updating cheats when multiple rows selected ( resolves #1726 )
2022-11-02 01:01:09 +10:00
5ae23c63bf
Change "Edit" button in Cheats dialog to read "Overwrite"
...
kept the mnemonic because idk
2022-11-02 01:00:16 +10:00
fd2772707b
Update `forms.drawImageRegion` documentation with a diagram
...
only embeds on TASVideos Wiki, which I held off on updating because there are a
lot of changes and we can do them all at once
2022-10-30 18:19:23 +10:00
8ee75879e6
Rework MAME integration a bit
...
The periodic callback is now used as a way to service "commands" sent from the main thread
Upon servicing a command, the mame thread will set the current command to NO_CMD then wait for the main thread allow the mame thread to continue
During this wait, the main thread may optionally set the next command (done here for STEP -> VIDEO), ensuring the next callback will service that command
A dummy "WAIT" command can be sent to trigger this waiting behavior, allowing the main thread to safely touch mame while the mame thread is frozen (important for mem accesses and probably savestates?)
A/V sync is also reworked. We can assume that 1/50 of a second worth of samples will be sent each sound callback. We can also assume 1/FPS of a second worth of time will be advanced each frame advance
So, we can just give hawk 1/FPS worth of samples every GetSamplesSync, if they are available. If we have less (probable on first few frames), we'll just give all the samples, and hope it balances out later.
2022-10-29 17:07:50 -07:00
cc71882059
BSNES Memory Domain Fixes ( #3423 )
...
* Use SameBoy submodule symlink for BSNES
* SGB memory domains
* Fix SGB saveram issues (extra data like rtc will be saved correctly now here)
* Various cleanups, avoid unneeded unsafe use, a little better EnterExit use
Co-authored-by: Morilli <35152647+Morilli@users.noreply.github.com>
2022-10-28 19:22:49 -07:00
256a8617e9
Fix #3399 by always calling UpdateViewerMouseover
2022-10-27 01:30:41 +02:00
dd33e92a9f
ensure ClockRate in the Bk2Header uses . instead of ,
2022-10-21 02:34:59 -07:00
c8d4e606af
suppress updates while rebooting core, fixes #3424
2022-10-21 02:19:22 -07:00
f29113287e
add Jaguar to MultiDiskBundler menu
2022-10-11 21:51:26 -07:00
2b4d9c0c7d
Add debug utility to byteswap N64 roms
2022-10-11 10:12:49 +10:00
5b859960e9
Move types for debug menu to own files
2022-10-11 10:12:49 +10:00
82c3b471a5
Minor refactors to byteswapping (N64 rom loading and Lua bit library)
2022-10-11 10:12:45 +10:00
bb4ba2184f
Fix `forms.*` acting on every LuaPictureBox, not the specified one
...
fixes #3395
this has been broken since introduction in 2ddadeae2
2022-10-08 11:11:40 +10:00
7930a79cef
Prompt to disable cheats when starting movie playback ( resolves #3389 )
2022-10-08 10:42:10 +10:00
28c53cfa21
Fix `APIContainer.Comm` not having `HTTP`/`Sockets` on first boot
2022-10-06 11:53:11 +10:00
2fa46efda6
add jaguar db, change db parser to prefer the strongest hash available, fix potential edge case if a crc32: prefix is present (and simplify the code)
2022-10-04 22:05:38 -07:00
c547a20f8e
Use `LoadOther` for GBS files, cleanup the code a little, update SameBoy version info
2022-10-03 15:49:09 -07:00
9528a2030f
GBS support using SameBoy
2022-10-03 01:55:14 -07:00
0c6f0523a0
Update sameboy, expose audio channel enable/disabling, cleanup settings to go through a single call/struct
2022-10-02 21:40:00 -07:00
8732e561a1
Better Jaguar Virtual Width/Height
...
Jaguar VPad
Proper Jaguar default controls
Remove a lot of unneeded `ReSharper disable once UnusedMember.Global` in vpads (Global has been gone for a while now...)
Set VirtualJaguar to released
2022-10-02 18:53:34 -07:00
2e5c62f632
default Jaguar bios to not be skipped, some games rely on Jaguar bios running on boot
2022-09-30 23:54:13 -07:00
be771c134c
default to KSeries bios instead of MSeries bios, as it seems to be more compatible
2022-09-30 21:56:19 -07:00
5f509525bc
[virtualjaguar] less screen changing spam
2022-09-30 21:44:34 -07:00
158c897702
Use `Google.FlatBuffers` NuGet package and check in new Nyma codegen
2022-09-30 05:33:18 +10:00
5544bc526a
Add missing import
...
fixes 9e9e041bb
2022-09-30 03:52:05 +10:00
9e9e041bba
Fix AOoRE when loading TAStudio w/ cheats(?)
...
partially reverts dd4f9aaf6
2022-09-30 03:25:13 +10:00
f8a4524df7
add in missing platform framerates, add in Jaguar CD iding for movie file, fix aspect ratio for jaguar
2022-09-28 17:25:34 -07:00
79d43dab1d
Extract constants used for `NamedLuaFunction.Event`
2022-09-29 08:54:23 +10:00
9815b377d1
Also protect against mutation of `IEnumerable` for `onconsoleclose`
...
see 7a26546cfdc66b4357
2022-09-29 08:54:16 +10:00
7a26546cfc
Maybe fix mutation of IEnumerable (`InvalidOperationException`)
...
fixes 3024bc0d0
2022-09-29 05:21:08 +10:00
70a21ee07e
push c# side for memtrack support
2022-09-28 03:28:01 -07:00
9fa38b8d78
Fix #3398
2022-09-27 13:58:56 +02:00
b2bacdecd2
Fix double call to pure method
2022-09-25 22:26:41 +10:00
3cbdd36fe0
Deduplicate some code in `MainForm`
2022-09-25 07:04:21 +10:00
728f393eb1
Clean up `MainForm.CheckHotkey`
2022-09-25 07:04:21 +10:00
d7c79a5f03
Fix "Toggle All Cheats" hotkey behaviour re: separators
2022-09-25 07:04:13 +10:00
3122078dfd
tweak jaguar cpu tracelogger
2022-09-24 06:23:24 -07:00
ff5c8d4e52
more jag disasm tweaks
2022-09-24 04:38:06 -07:00
c92c2bf661
fix jag risc disasm
2022-09-24 04:30:05 -07:00
38b4b98fc0
minor touchups to jag risc disassembler
2022-09-24 04:29:00 -07:00
c9618b3f92
c# side to jag debugging improvements
2022-09-24 04:15:05 -07:00
6113f3c17b
partial jagcd support (doesn't seem to completely work here)
...
fix some issues with vjaguar cleanup
add mem/trace callbacks and get/set reg support
2022-09-23 01:05:41 -07:00
71e3dfed74
fix #3388
2022-09-18 22:44:26 -07:00
38d3d36199
fix opcode address in exec callbacks + tracing (thanks prefetch)
...
sp/lr/pc for r13/r14/r15 for tracing
fix a bad for threaded renderer's thread start callback
2022-09-18 02:39:31 -07:00
5e34dc6166
Always savestate expansion pak regardless of settings.
...
All the disable expansion pak setting actually does is tell the game the expansion pak is not available.
However, not all games actually abide by this, some will use the expansion pak area anyways.
Video plugins also end up just using a "segfault test" to determine if the expansion pak is present or not
So video plugins may use the expansion pak area too
This ends up causing savestates sometimes just crashing the game if the expansion pak ends up used
Resolves #3092 , other state issues might be solved with this (I suspect #3328 is caused by this)
2022-09-17 13:11:31 -07:00
de38781081
Implement Rumble for Nyma
2022-09-17 01:36:51 -07:00
de1e7eef69
Document socket response format
2022-09-16 22:37:15 +10:00
afccbe8aa6
Fix hang with "Go to Address" dialog in RamSearch
...
resolves #3384 , fixes cc4acd9c64
2022-09-14 19:39:03 -07:00
1bf2bb758c
Change serialisation of Jaguar VSystemID
...
also fixed line ending
2022-09-12 17:13:15 +10:00
483258a04d
virtualjaguar port, resolves #1907
2022-09-11 21:38:46 -07:00
34c504d7b9
update ds disassembler
2022-09-10 20:53:05 -07:00
d2965c2185
If dummy sound chosen in config, try DirectSound (maybe fixes #3379 )
...
- if DirectSound fails (i.e. dummy is in config for a reason), then skip the
error dialog as the user has probably seen it already, and set it back to dummy
- if DirectSound succeeds, leave it, it will be written to config (there's a
mute setting for people who really don't want sound)
- copied the init config code so s/DirectSound/OpenAL/ on Linux
- could probably try OpenAL on Windows when DirectSound fails but whatever
2022-09-08 08:39:25 +10:00
707ec53bd5
Move `SoundConfig.ApplyNewSoundDevice` logic to callsite
2022-09-08 08:23:01 +10:00
6f0953aaa3
Implement snes graphics debugger for the new bsnes core ( #3367 )
...
* Partial port of graphics debugger to new BSNES
* minimal "working" copy-paste
* small fix for the previous commit
* Implement more stuff
* no idea whose responsibility "EnterExit" is but this should work
* add support for backdropcolor
i have 0% trust in this code
* implement mode7, apply backcolor on load
* 🙈
un-"implement" the nonfunctional scanlinehookmanager as well as the non-functional palette setting logic
- this may actually break config lol
* don't break libsnes config
* Provide IBSNESForGfxDebugger in the subbsnes core
* Remove redundant semicolon
* Clean up diff of `comboPalette_SelectedIndexChanged`
* Fix crash
Co-authored-by: YoshiRulz <OSSYoshiRulz@gmail.com>
2022-09-03 19:13:56 +02:00
28d62e69d7
Enable menu mnemonics (Alt+X) for MainForm on Linux
2022-09-03 19:59:08 +10:00
f024986ffc
Added 'Edit marker frame' feature (squashed PR #3351 )
...
* Added 'Edit marker frame' feature
* Changed Edit Marker Frame icon to clock
* Hotkey tooltip + Prevent changing to a frame that already has marker
* Forgot to delete this icon, was replaced by Clock.png
* De-rookie here and there
* Clean up diff
2022-09-03 12:08:23 +10:00
09e8c7a9b6
ensure ds firmware settings represent sync settings if real firmware isn't used
...
resolves possible cause for #3377
2022-09-02 15:11:34 -07:00
70906c9004
quick fail is the user is somehow running EmuHawk as a 32 bit process
2022-08-29 17:01:26 -07:00
b588212e17
remove unused using (cruft from experimentation), remove unneeded enum values
2022-08-29 16:36:32 -07:00
e198122691
output a more helpful error message on windows for GetErrorMessage
2022-08-29 16:33:41 -07:00
06226e78cf
add way to obtain error message in ILinkedLibManager, use it to display an error code for init lib checks
2022-08-29 15:34:44 -07:00
463780a875
more cleanly deal with dummy hashes
...
fixes a515672
2022-08-28 03:13:23 -07:00
a515672d4d
fix #3159
2022-08-28 02:56:31 -07:00
14f470a9a7
Improve encapsulation of `ToolFormBase` props
2022-08-28 03:39:18 +10:00
faf4a8b24f
Remove unused "TAStudio states" path
...
TAStudio prop unused since 5bf21e391b1296dd9b
2022-08-28 03:09:59 +10:00
c761d6d807
fix changing mupen expansion pack setting
2022-08-26 13:30:44 -07:00
a344ee2288
Fix modifier key check in `TAStudio.TasView_MouseDown`
2022-08-24 09:44:24 +10:00
61c34eca74
Minor refactor to not mutate local in `TAStudio.TasView_MouseDown`
2022-08-24 09:44:17 +10:00
352977c7ea
speedup HashRegion/ReadByteRange/WriteByteRange for waterbox cores (doesn't do anything for non-wbx cores)
2022-08-23 03:09:23 -07:00
5906fd154e
Fix typo
...
fixes a95c4f182
2022-08-22 01:21:22 +10:00
afdfa065bd
missed apostrophe somehow
2022-08-19 23:46:03 -07:00
9174d17bd8
tic80 settings for enabling/disabling controllers, proper mnemonics
2022-08-19 23:43:55 -07:00
98a8cdf693
remove gongshell, add "simple" code for opening win32 context menu (gongshell's only actual use), re: #2261
2022-08-19 00:24:50 -07:00
64bc762439
Mute new MSB3270 warnings
...
no sure if these are the result of a .NET SDK update or my NuGet experiment
2022-08-18 17:16:40 +10:00
3a3494aedb
Add missing attribute to `events.can_use_callback_params` param
2022-08-18 17:12:15 +10:00
8d484ac196
Hardcode edge cases in `MovieConversionExtensions` to pass test
...
the argument in every real call is from `IMovie.Filename`, which is never
assigned null, and I don't think it's assigned anything but an absolute path
2022-08-17 19:05:32 +10:00
2ecb572892
fix nyma light guns, resolves #3359
2022-08-17 01:57:40 -07:00
7cde8bb466
Add and use 2 extension methods for splitting path into dir+filename
2022-08-17 17:35:07 +10:00
dce961357a
Refactor `IGameInfo.FilesystemSafeName` extension
...
it doesn't make any sense to split this string into dir+filename, it shouldn't
contain a slash
2022-08-17 17:35:07 +10:00
2b59cfc1c4
Small refactor in `DiscMountJob.RunBizHawk`
2022-08-17 17:35:07 +10:00
10478e23f1
Remove redundant dir exists checks
2022-08-17 17:35:07 +10:00
f228b01bdf
Rename `IMainFormForTools.SetWindowText` to `UpdateWindowTitle`
...
in practice there is only one implementation and it just called the other method
(which is inherited from `FormBase`)
2022-08-17 17:35:06 +10:00
d5bf542a3c
Cache `ToolStripRenderer` used by `FormBase.FixBackColorOnControls`
2022-08-17 17:35:06 +10:00
322ed164bf
Remove backing field of `FormBase.BlocksInputWhenFocused`
2022-08-17 17:34:59 +10:00
3958348e94
Add auto save state on close (squashed PR #3218 )
...
resolves #1861
* Add configuration for auto-saving state on exit
* Update MainForm to auto save on close game if configured
* Fix config serialization test.
* Revert unnecessary changes to Designer file
* Move autosave configuration into Save States menu off of File
* Undo previous test changes
* Remove explicit size on menu item.
* Fix logic
2022-08-17 14:27:50 +10:00
7ffa605b28
BSNESv115: fix crash when audio output is disabled
...
(fixes 039d822144
2022-08-17 01:35:02 +02:00
039d822144
BSNESv115+: Replace the 'snes_audio_sample' callback with a dynamic audio sample vector to reduce callbacks ( #3010 )
...
* BSNESv115+: Replace the 'snes_audio_sample' callback with a dynamic audio sample vector to reduce callbacks
* fix integration for subbsnes core
* reduce buffer allocations
- also make frame setter private now that it's possible
2022-08-15 20:50:26 +02:00
f1e11dfc36
simplify Stream.ReadAllBytes extension and use it more
2022-08-15 20:35:57 +02:00
31c7f59e86
fix some edge cases with new zip compression
2022-08-15 10:59:27 -07:00
0ff4aca182
[Gambatte] Remote control controls and remote control emulation expanded to HuC1 IR and CGB IR (previously only done in HuC3)
2022-08-15 02:49:34 -07:00
aba3359dde
Add CPP's testroms to GB testroms project
2022-08-14 16:21:27 +10:00
18a7201004
Fix building testroms project
...
fixes b8d5dd899
2022-08-14 00:33:12 +10:00
a5652ee3bc
Backport `IEnumerable.Order`/`OrderDescending` shorthand
...
at time of writing, in .NET 7 preview
https://github.com/dotnet/runtime/pull/70525
2022-08-13 02:18:26 +10:00
929432086f
BSNESv115: add dedicated subframe core ( #3281 )
...
* BSNESv115: allow subframe inputs
* BSNESv115: Implement ICycleTiming
may be correct, not sure
* BSNESv115: add dedicated subframe core
I have probably overlooked something...
* Don't implement ICycleTiming in the non-subframe core
requires re-implementing the "FrameAdvance" function in the subframe core
* Register previously missing services in the subframe core as well
* Wire up SubBsnes everywhere in the frontend
* Change reset cycle to reset instruction
* Deduplicate some code
* Slightly rework frame advance logic. The main intent here is to prevent a case where two frames are ran within a single "frame." The current code probably wouldn't crash due to that, but best not to do that.
Also make SGB work here. A bit of a joke since you really can only abuse it for subframe resets, but might as well especially with the settings implying it's possible (and someone is bound to complain).
Co-authored-by: CasualPokePlayer <50538166+CasualPokePlayer@users.noreply.github.com>
2022-08-10 23:08:44 +02:00
1a27aae45b
update sameboy
2022-08-10 12:34:46 -07:00
afb0b8a435
maybe fix tests?
2022-08-10 02:55:01 -07:00
5be8b0aab9
Zstd Compression ( #3345 )
...
Deflate compression in rewinder is now zstd compression
Binary blobs in zip files are zstd compressed (text is uncompresed for user ease).
All wbx cores and resources are re-compressed with zstd, wbx build scripts are changed to account for this. Shaves off a bit with download size and it's faster to decompress to.
2022-08-09 23:33:28 -07:00
32e8afcedc
Implement hardware accelerated CRC32 and SHA1, using them if possible ( #3348 )
...
* Implement hardware accelerated CRC32 and SHA1, use them if possible.
CRC32's generic function is also replaced with zlib's as it is much more performant than our implementation
Full hash of a ~731MB disc took only ~369 ms with this, and the generic CRC32 isn't so far behind at ~659 ms
SHA1 should perform 4x faster if the user's CPU supports the SHA instructions.
Co-authored-by: YoshiRulz <OSSYoshiRulz@gmail.com>
Co-authored-by: Morilli <35152647+Morilli@users.noreply.github.com>
2022-08-09 23:30:17 -07:00
0236a820ec
Unindent `RomLoader.MakeGameFromDisc`
2022-08-06 09:22:51 +10:00
8f153fd503
Restore PS2 sysID and add some others from RomLoader
2022-08-06 09:22:51 +10:00
5cd37c76b2
dobie removal cleanup
...
fixes 89972a3579
2022-08-05 03:32:09 -07:00
1452f831af
Fix Lua Wiki export, add more notes to fill in some of the holes
...
frameadvance loop is documented now so for the first time you can write a script
without reading someone else's :O imagine that
2022-08-05 11:41:24 +10:00
7bb4b28093
Remove dumb in `MainForm.WindowTitle` so you can see FPS w/ chromeless
...
(window title is shown in the toolbar / application switcher on Win and Linux)
2022-08-05 07:23:43 +10:00
22a328cd36
Remove unused service props
...
unused since 1ce8a368d70e0954f2
2022-07-30 09:26:18 +10:00
5c48cb96fd
When starting new `.tasproj` from SaveRAM, don't clone array twice
2022-07-30 09:26:06 +10:00
d3c42f5dfc
Only shift right by 1 for volume with Gambatte, sounds very close to SameBoy, probably resolves #3338
2022-07-28 17:27:30 -07:00
ccc11be896
Explicitly discard required-but-unused `IStatable` service prop
2022-07-28 05:51:38 +10:00
787b413913
Change Basic Bot's addresses to `ulong?`
...
fixes empty address fields being saved as `0x0`, see #3326
2022-07-28 05:48:05 +10:00
5f572442c4
Save game info to `.bot` files and check when loading ( resolves #3340 )
2022-07-28 05:27:13 +10:00
140e340a8d
Add Analyzer rule to warn of `FirstOrDefault` on list of structs
2022-07-28 03:06:01 +10:00
8453c0e44d
Fix exception on opening Play Movie dialog with multiple movies
...
fixes 9211007a1
2022-07-27 05:08:33 +10:00
bd58bde07c
Hopefully block edge cases where global `GameInfo` is uninitialised
...
`Game == null` conditions in `MainForm` ctor looked unreachable, so I changed
them to `Game.IsNullInstance()` which is what I assume was intended, and added
an assert to `RomLoader` in case a bug is introduced later
2022-07-26 07:59:57 +10:00
d84da4ec4b
wire up sameboy's rumble
2022-07-25 00:10:46 -07:00
8dcea24703
Fix `GameInfo.NullInstance` having a name... why did it have a name
2022-07-25 11:15:19 +10:00
d796210437
Cancel tool loading when services aren't satisfied ( fixes #3329 )
...
also cleaned up other calls
2022-07-25 10:52:02 +10:00
070e7035b3
Ensure there can be no edge cases involving SGXCD sysID
...
breaks config, in case you care about setting a custom save dir for PCE
2022-07-25 08:15:24 +10:00
3d42b19797
Pass `VSystemID.Raw.NULL`, not `null`, for `SystemId`
2022-07-25 08:15:17 +10:00
cb468ba806
pull in latest sameboy master, add stub camera pixel callback to prevent nondeterminism, wire disabling joypad bounce as a sync setting, various cleanup
2022-07-24 04:35:03 -07:00
e2a36c7242
DisplayConfig defaults button should whack the padding back to 0
2022-07-22 16:38:42 -04:00
3b181ba6e4
DisplayManager - fix crashes when setting absurdly large padding values ( fixes #3321 )
2022-07-22 16:09:49 -04:00
6eafdf7156
Fixed issue where the Copy button in Basic Bot is not toggled on/off properly.
...
If the Copy button is enabled, but there is no best attempt recorded, it will crash BasicBot / EmuHawk if it attempts to copy a null Log of the best attempt.
2022-07-23 05:49:50 +10:00
d8fc32f1a8
[mGBA] Add in missing save types
2022-07-21 15:38:59 -07:00
0f6e6a5a03
Enable MA0084 and fix noncompliance (except in Cores)
...
"Local variable should not hide other symbols"
2022-07-22 07:28:32 +10:00
d142555ec3
Enable MA0066 and fix noncompliance
...
"Hash table unfriendly type is used in a hash table"
2022-07-22 07:28:31 +10:00
41d46dd37d
Fix `%recent%` in Paths config
...
broken since introduction in 017743133
2022-07-22 07:28:25 +10:00
9211007a18
Fix bug in `PlayMovie.PreHighlightMovie` heuristics
...
for the record, the bug was that it had `_movieList[indices[0]]` in the loop
instead of `_movieList[indices[i]]`
2022-07-22 05:06:05 +10:00
3f2a07e582
Fix remaining MA0098 code style warnings
...
"Use indexer instead of LINQ methods"
fixes 17df5673d
2022-07-22 04:51:56 +10:00
17df5673d2
Enable MA0098 and fix noncompliance
...
"Use indexer instead of LINQ methods"
2022-07-22 03:51:47 +10:00
ee11385f10
Enable MA0031 and fix noncompliance
...
"Optimize Enumerable.Count() usage"
2022-07-22 03:51:47 +10:00
b1ad34839a
Enable MA0029 and fix noncompliance
...
"Combine LINQ methods"
2022-07-22 03:51:47 +10:00
26b6a1c4a9
Enable MA0020 and fix noncompliance
...
"Use direct methods instead of LINQ methods"
2022-07-22 03:51:47 +10:00
697c10e3e6
Enable MA0015 and fix noncompliance
...
"Specify the parameter name in ArgumentException"
needed to update package because this rule was broken until now
2022-07-22 03:51:46 +10:00
92c4714be1
Enable CA2208 and MA0043 and fix noncompliance
...
"Instantiate argument exceptions correctly" and
"Use nameof operator in ArgumentException"
2022-07-22 03:51:45 +10:00
5a8a24e936
Enable MA0054 and fix noncompliance
...
"Embed the caught exception as innerException"
2022-07-22 03:51:43 +10:00
8ac4dabaf7
Enable MA0012 and MA0014 and fix noncompliance
...
"Do not raise reserved exception type" and
"Do not raise System.ApplicationException type"
now mostly compliant with
https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/using-standard-exception-types
2022-07-22 03:51:43 +10:00
a2fef59fe1
Add Analyzer rule to prohibit `typeof(T).ToString()`
2022-07-22 03:51:43 +10:00
f3f90a4cd5
Add Analyzer rules to prohibit `this.GetType()`
...
seriously Meziantou is a godsend
2022-07-22 03:51:42 +10:00
4956bae3a2
Improve error message for `IToolFormAutoConfig` ext. tool missing menu
2022-07-22 02:02:01 +10:00
480ce3b925
fix minor miscompilation of gambatte-linux, update LibGambatte to reflect API changes wrt CameraCallback
2022-07-20 23:35:29 -07:00
9bb96fbadc
Update doc comments to reflect thrown exception change
...
fixes 4f98733c2
2022-07-19 03:20:43 +10:00
6b325ff56c
Refactor `BasicBot.IsBetter`
2022-07-18 18:22:59 +10:00
008a5953f6
Fixed code logic error in BasicBot
...
It was comparing with itself when it's comparing the Tie Breaker 3 value.
2022-07-18 17:33:41 +10:00
89972a3579
Remove dobie core
...
This never really worked. Besides being unusuably slow and not very accurate, there was a miscompliation problem that caused release builds to not function.
2022-07-17 15:02:42 -04:00
8289c1051b
add hash for newly discovered GBC-GBA bootrom
2022-07-16 22:03:47 -07:00
aa708992e9
Use nicer error message for starting MAME in non-MAME build
2022-07-16 16:25:59 +10:00
efbef0bbda
Fixed Basic Bot anchor points.
...
Also fixed a misaligned label.
2022-07-16 16:20:39 +10:00
e2fb6017b7
Added missing NOT operators from the dropdown menu.
2022-07-16 16:11:16 +10:00
94e85f1079
Set `Form.Owner` to MainForm for Lua-made forms
2022-07-15 22:26:08 +10:00
CasualPokePlayer