ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Clean up `MGBAHawk.DeterministicEmulation` assignment

This commit is contained in:
YoshiRulz 2022-11-03 11:56:01 +10:00
parent 13a01340de
commit 77f824ab55
No known key found for this signature in database
GPG Key ID: C4DE31C245353FB7
1 changed files with 10 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/MGBAHawk.cs
View File

@ -27,30 +27,19 @@ namespace BizHawk.Emulation.Cores.Nintendo.GBA
{
_syncSettings = syncSettings ?? new SyncSettings();
_settings = settings ?? new Settings();
DeterministicEmulation = deterministic;
var bios = comm.CoreFileProvider.GetFirmware(new("GBA", "Bios"));
DeterministicEmulation &= bios != null;
if (bios is { Length: not 0x4000 }) throw new InvalidOperationException("BIOS must be exactly 16384 bytes!");
if (deterministic && bios is null) throw new MissingFirmwareException("A BIOS is required for deterministic recordings!");
DeterministicEmulation = deterministic
|| (bios is not null && !_syncSettings.RTCUseRealTime && !_syncSettings.SkipBios); // in this case, the core is deterministic even though it wasn't asked to be
if (DeterministicEmulation != deterministic)
{
throw new MissingFirmwareException("A BIOS is required for deterministic recordings!");
}
if (!DeterministicEmulation && bios != null && !_syncSettings.RTCUseRealTime && !_syncSettings.SkipBios)
{
// in these situations, this core is deterministic even though it wasn't asked to be
DeterministicEmulation = true;
}
if (bios != null && bios.Length != 16384)
{
throw new InvalidOperationException("BIOS must be exactly 16384 bytes!");
}
var skipBios = !DeterministicEmulation && _syncSettings.SkipBios;
Core = LibmGBA.BizCreate(bios, file, file.Length, GetOverrideInfo(_syncSettings), skipBios);
Core = LibmGBA.BizCreate(
bios,
file,
file.Length,
GetOverrideInfo(_syncSettings),
skipBios: _syncSettings.SkipBios && !DeterministicEmulation);
if (Core == IntPtr.Zero)
{
throw new InvalidOperationException($"{nameof(LibmGBA.BizCreate)}() returned NULL! Bad BIOS? and/or ROM?");