ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Refactor `IGameInfo.FilesystemSafeName` extension 

it doesn't make any sense to split this string into dir+filename, it shouldn't
contain a slash
This commit is contained in:
YoshiRulz 2022-08-07 11:18:18 +10:00
parent 2b59cfc1c4
commit dce961357a
No known key found for this signature in database
GPG Key ID: C4DE31C245353FB7
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/BizHawk.Emulation.Common/Extensions.cs
View File

@ -423,16 +423,12 @@ namespace BizHawk.Emulation.Common
}
public static string FilesystemSafeName(this IGameInfo game)
{
var pass1 = game.Name
.Replace('/', '+') // '/' is the path dir separator, obviously (methods in Path will treat it as such, even on Windows)
=> game.Name.Replace('/', '+') // '/' is the path dir separator, obviously (methods in Path will treat it as such, even on Windows)
.Replace('|', '+') // '|' is the filename-member separator for archives in HawkFile
.Replace(":", " -") // ':' is the path separator in lists (Path.GetFileName will drop all but the last entry in such a list)
.Replace("\"", ""); // '"' is just annoying as it needs escaping on the command-line
var filesystemDir = string.IsNullOrWhiteSpace(pass1) ? string.Empty : Path.GetDirectoryName(pass1);
var pass2 = Path.GetFileName(pass1).RemoveInvalidFileSystemChars();
return Path.Combine(filesystemDir, pass2.RemoveSuffix('.')); // trailing '.' would be duplicated when file extension is added
}
.Replace("\"", "") // '"' is just annoying as it needs escaping on the command-line
.RemoveInvalidFileSystemChars()
.RemoveSuffix('.'); // trailing '.' would be duplicated when file extension is added
/// <summary>
/// Adds an axis to the receiver <see cref="ControllerDefinition"/>, and returns it.