ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Enable MA0084 and fix noncompliance (except in Cores) 

"Local variable should not hide other symbols"
This commit is contained in:
YoshiRulz 2022-07-22 07:09:07 +10:00
parent d142555ec3
commit 0f6e6a5a03
No known key found for this signature in database
GPG Key ID: C4DE31C245353FB7
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Common.ruleset
View File

@ -363,7 +363,7 @@
<Rule Id="MA0083" Action="Error" />
<!-- Local variable should not hide other symbols -->
<Rule Id="MA0084" Action="Hidden" />
<Rule Id="MA0084" Action="Warning" />
<!-- Anonymous delegates should not be used to unsubscribe from Events -->
<Rule Id="MA0085" Action="Error" />

12
src/BizHawk.Client.EmuHawk/AVOut/AviWriter.cs
View File

@ -516,8 +516,8 @@ namespace BizHawk.Client.EmuHawk
AVIWriterImports.AVICOMPRESSOPTIONS comprOptions = new AVIWriterImports.AVICOMPRESSOPTIONS();
byte[] Format;
byte[] Parms;
byte[] format;
byte[] parms;
try
{
@ -534,8 +534,8 @@ namespace BizHawk.Client.EmuHawk
comprOptions.cbParms = b.ReadInt32();
comprOptions.dwInterleaveEvery = b.ReadInt32();
Format = b.ReadBytes(comprOptions.cbFormat);
Parms = b.ReadBytes(comprOptions.cbParms);
format = b.ReadBytes(comprOptions.cbFormat);
parms = b.ReadBytes(comprOptions.cbParms);
}
catch (IOException)
{
@ -550,8 +550,8 @@ namespace BizHawk.Client.EmuHawk
var ret = new CodecToken
{
_comprOptions = comprOptions,
Format = Format,
Parms = Parms,
Format = format,
Parms = parms,
codec = Decode_mmioFOURCC(comprOptions.fccHandler)
};
return ret;

2
src/BizHawk.Emulation.Cores/BizHawk.Emulation.Cores.csproj
View File

@ -5,7 +5,7 @@
<Import Project="../MainSlnCommon.props" />
<PropertyGroup>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<NoWarn>$(NoWarn);CA1806;CA1825;CA2214;SA1100;SA1120;SA1129;SA1137;SA1205;SA1208;SA1400</NoWarn>
<NoWarn>$(NoWarn);CA1806;CA1825;CA2214;MA0084;SA1100;SA1120;SA1129;SA1137;SA1205;SA1208;SA1400</NoWarn>
<Nullable>disable</Nullable>
</PropertyGroup>
<ItemGroup>