259a5fc7c0
DriverDetails: Add broken discard with early-Z bug on Apple Silicon GPUs
2022-04-20 14:56:34 -04:00
e7f5e5172c
DriverDetails: Introduce new VENDOR_APPLE for Apple GPUs
2022-04-19 10:55:27 -04:00
80dfefb32e
UberShaderPixel: Add support for non-dual source shader blending
2022-04-19 10:55:26 -04:00
c1d87db6fa
PixelShaderGen: Add support for non-dual source shader blending
2022-04-19 10:55:26 -04:00
ef760ee012
Common/PointerWrap: Prevent reads/writes past the end of the buffer.
2022-04-18 23:48:00 +02:00
853cf4f818
Common/PointerWrap: Hide internals.
2022-04-18 03:41:14 +02:00
f3eff70e2f
Implement ImGui window for scissor rectangles
...
This is mainly for debugging, and is only exposed by manually editing the configuration.
2022-04-16 12:35:00 -07:00
076392a0f6
VideoCommon: Rework scissor handling
...
This increases accuracy, fixing the white rendering in Major Minor's Majestic March. However, the hardware backends can only have one viewport and scissor rectangle at a time, while sometimes multiple are needed to accurately emulate what is happening. If possible, this will need to be fixed later.
2022-04-16 10:26:11 -07:00
4595b89ad8
VideoCommon: Remove bSupportsOversizedViewports
...
I think this is a relic of D3D9. D3D11 and D3D12 seem to work fine without it. Plus, ViewportCorrectionMatrix just didn't work correctly (at least with the viewports being generated by the new scissor code).
2022-04-16 10:26:11 -07:00
b85b35d5ea
VideoCommon: Create dedicated structs for scissor pos/offset
2022-04-16 10:26:10 -07:00
c5c4169bc8
Merge pull request #10255 from Pokechu22/sw-zfreeze
...
Software: Fix zfreeze with CullMode::All
2022-04-15 11:12:49 +12:00
abffa93a72
MoltenVK: Fix pixel shader typo
2022-04-10 20:51:20 +02:00
e932a1bfb7
Merge pull request #10571 from AdmiralCurtiss/ffmpeg-custom-pix-fmt
...
VideoCommon/FrameDump: Allow user to specify a pixel format.
2022-04-09 14:19:39 -04:00
59f299d5d6
Software: Fix zfreeze with CullMode::All
2022-04-08 20:05:32 -07:00
3a742e99bb
Software: Remove config to disable ZComploc and ZFreeze
...
These aren't particularly useful, and make the code a bit more confusing. If for some reason someone wants to test what happens when these functions are disabled, it's easier to just edit the code that implements them. They aren't exposed in the UI, so one would need to restart Dolphin to do it anyways.
2022-04-08 20:05:32 -07:00
4e9a314776
Round viewport coordinates when vertex rounding is enabled
...
This should fix https://bugs.dolphin-emu.org/issues/9105
2022-04-08 18:30:59 -07:00
dbb857b175
VertexShaderManager: Use g_ActiveConfig.UseVertexRounding()
2022-04-08 18:30:59 -07:00
f6ab317374
Fix typo (GFX_HACK_VERTEX_ROUDING -> GFX_HACK_VERTEX_ROUNDING)
2022-04-08 18:30:59 -07:00
df214af8a1
VideoCommon/FrameDump: Fix log messages with arguments.
2022-04-09 01:42:02 +02:00
3382408b8e
VideoCommon/FrameDump: Allow user to specify a pixel format.
2022-04-09 00:45:49 +02:00
e02194057b
Merge pull request #10412 from Pokechu22/sw-efb-peek-alpha
...
Software: Implement pixel engine alpha read mode
2022-04-07 17:01:56 -04:00
7a33659e7b
Merge pull request #10485 from JosJuice/real-ocol0-logic-ops
...
Shadergen: Use real_ocol0 workaround for shader logic ops
2022-04-07 21:00:24 +02:00
4fad2c26e4
framedump: enable compat with utvideo codec
2022-03-29 17:27:59 -07:00
decaea8f9b
FrameDump: improve debug logging
2022-03-29 17:27:59 -07:00
09432ef098
windows: move ffmpeg bins to submodule
...
udpate ffmpeg to b1cbeabf5e4b3234e895a58bafa371bfb792baf0
enable ffmpeg on arm64
2022-03-29 17:27:46 -07:00
8882eb040a
PixelEngine: Convert to BitField and enum class
2022-03-29 15:34:43 -07:00
45b8ebeb25
PixelEngine: Remove old comment
...
This comment was added in 76d24f2c0d5799824b22https://web.archive.org/web/20090830050441/http://developer.nvidia.com/object/General_FAQ.html#t6 but it's about the number of available texture units, which doesn't seem relevant to PixelEngine.
2022-03-29 15:34:43 -07:00
30a34d06c1
RenderBase: Add call to IMGUI_CHECKVERSION()
2022-03-25 10:24:07 -07:00
f1f02180fa
VideoCommon: Remove redundant in qualifiers
...
ANGLE raises a compilation error otherwise.
2022-03-21 22:16:25 +01:00
bbb64ff993
Shadergen: Use real_ocol0 workaround for shader logic ops
...
Previously we were using this workaround when using framebuffer fetch
to emulate dual source blending, but it seems like we also need to use
it when using framebuffer fetch to emulate logic ops, otherwise some
Adreno devices get a crash when compiling OpenGL ES ubershaders.
Using the workaround in specialized shaders doesn't seem to be
necessary, but I've made the same change there for consistency.
This gets us closer to fixing https://bugs.dolphin-emu.org/issues/12791
but doesn't actually fix it.
2022-02-28 18:32:19 +01:00
f65dc6d525
Merge pull request #10441 from OatmealDome/improved-logic-op-workaround
...
BlendingState: Set source and destination alpha factors in logic op workaround
2022-02-28 12:17:25 -05:00
608799f1e4
PixelShaderGen: Check uid_data for use_shader_logic_op
...
On devices which have hardware support for dual source blending
but not logic ops, this lets us skip performing the framebuffer
fetch in situations where the game isn't actually using logic ops.
2022-02-28 00:04:31 +01:00
23cbd570a1
FramebufferManager: Flush pending EFB pokes in PopulateEFBCache
...
I.e. flush pokes before running an EFB peek, if the cache tile isn't present. If the cache tile is present, then EFB pokes should have been written to the cache tile and thus don't need to be flushed.
2022-02-21 13:23:22 -08:00
eb98bcd2ae
Merge pull request #10455 from Pokechu22/directly-map-fifo-breakpoint
...
CommandProcessor: Add FIFO_BP_LO/HI to directly_mapped_vars
2022-02-18 18:54:06 +01:00
fa059b20ba
Merge pull request #10460 from Dentomologist/convert_option_type_to_enum_class
...
VideoCommon: Convert OptionType to enum class
2022-02-18 18:40:59 +01:00
067fbe8f86
Merge pull request #10376 from shuffle2/uidctor
...
GXPipelineUid: remove explicit shallow copy where it's the default
2022-02-18 18:39:59 +01:00
63181f0446
ShaderGenCommon: Add missing <functional> include
2022-02-18 06:34:01 -05:00
edbe202aa3
VideoCommon: Convert OptionType to enum class
2022-02-17 10:03:08 -08:00
be81fe86e1
JitRegister: Use fmt
...
Prefer fmt to printf-style formatting.
2022-02-16 20:09:38 +00:00
68d987bbee
CommandProcessor: Add FIFO_BP_LO/HI to directly_mapped_vars
...
directly_mapped_vars was added in #69 (4129b30494#885 (65af90669b
2022-02-15 22:34:31 -08:00
07578d8f1d
CommandProcessor: Log ignored unknown opcodes at warn level
...
Large amounts of logging can have an impact on performance, so moving the ones that have been determined to not matter to the warn level gives a way to hide those messages without hiding actual errors (and also gives a fast visual way of distinguishing between ignored and non-ignored ones due to the different colors).
2022-02-13 14:16:05 -08:00
4ea9287a09
CommandProcessor: Move unknown opcode log message before the panic alert
...
This way, the extra information is already in the log by the time the panic alert appears, which is slightly more convenient for debugging.
2022-02-13 14:15:54 -08:00
97482a61c6
CommandProcessor: Ignore unknown opcode for 0x3f
2022-02-12 23:38:20 -08:00
68cdceb4be
CommandProcessor: Log PC and LR on unknown opcodes
2022-02-12 23:38:20 -08:00
095803d1e9
CommandProcessor: Move contents of second unknown opcode panic alert to the log
...
This way, the information is always available, and users don't have to deal with a wall of meaningless information.
2022-02-12 23:38:19 -08:00
55f8aa9921
VideoCommon/Fifo: Use GPFifo::GATHER_PIPE_SIZE instead of magic 32
2022-02-12 23:38:19 -08:00
9ffe9d3dc1
CommandProcessor: Remove redundant GATHER_PIPE_SIZE constant
2022-02-12 16:17:03 -08:00
444f6fd0cb
Treat alpha as 0 if alpha is 1 for blending
...
This removes the white box in fortune street again, without causing Mario Kart Wii to regress.
2022-02-08 15:15:15 -08:00
0327e6acb4
Use the same logic for lerp bias for color and alpha
...
It doesn't make sense for alpha to add the bias ONLY when dividing by 2, while color doesn't apply the bias for divide by 2 only; hardware testing indicates that alpha should have the bias.
This fixes the menus in Mario Kart Wii (https://bugs.dolphin-emu.org/issues/11909 ) but reintroduces the white rectangle in Fortune Street.
This reverts commit 5aaa5141ed
2022-02-08 15:15:15 -08:00
bdc55f9557
RenderState: Set source and destination alpha factors in logic op workaround
2022-02-07 16:03:22 -05:00
09a0ba06c0
Merge pull request #10417 from jordan-woyak/libavformat-59-build-fix
...
VideoCommon/FrameDump: Build fix for libavformat major version 59 and newer.
2022-02-04 20:42:34 +01:00
4d1e6ff76a
Merge pull request #10422 from OatmealDome/opengl-shader-crash
...
VideoConfig: Add flag for whether the system supports setting object names
2022-01-31 01:25:46 -05:00
947b562e06
VideoConfig: Add flag for whether the system supports setting object names
2022-01-31 01:17:37 -05:00
a9a163657c
VideoCommon/FrameDump: Build fix for libavformat major version 59 and newer. av_guess_format now returns a pointer to const.
2022-01-30 13:16:51 -06:00
4aeef95746
Fix copy filter clamping when EFB VRAM copies are disabled
2022-01-29 12:23:32 -08:00
36cfcb530f
IOFile: Make origin parameter to Seek() an enum class.
2022-01-29 06:49:21 +01:00
c2d8191fbb
Merge pull request #10401 from JosJuice/adreno-primitive-restart
...
DriverDetails: Disable primitive restart on Adreno
2022-01-28 15:12:43 -05:00
4f292f5ade
DriverDetails: Disable primitive restart on Adreno
...
Turning off primitive restart increases performance a lot on
Adreno for some reason. We're talking numbers like 50%-100% faster
in situations which are bottlenecked by rendering.
2022-01-28 20:25:18 +01:00
f0136e0eb6
Merge pull request #10396 from Pokechu22/efb-copy-clamp
...
Fix copy filter clamping (again)
2022-01-27 20:12:34 -05:00
cc9ed4815d
UberShaderPixel: Fix typo in fog calculation
2022-01-26 20:23:35 -08:00
ab5e71abf3
Merge pull request #10387 from Pokechu22/geometry-shader-always-write-layer
...
GeometryShaderGen: Write the layer for every vertex
2022-01-26 13:37:40 -08:00
25c547e9e5
Fix incorrect copy filter clamping
...
We need to clamp to the center of pixels, or else things end up working out incorrectly. This also fixes an off-by-1 for the bottom line.
2022-01-25 19:53:25 -08:00
e741d4783a
TextureConverterShaderGen: Add missing newline
2022-01-25 13:22:56 -08:00
8d7eff2a8a
VideoCommon: Move logging/seen check for unknown opcodes into CommandProcessor
...
That way, they're in the same place the panic alerts are generated.
2022-01-22 22:04:15 -08:00
79b2185117
OpcodeDecoding: Don't raise panic alerts for unknown opcodes 0x01-0x07
...
A pop-up is no longer generated for the Wiggler capsule in Mario Party 5 (https://bugs.dolphin-emu.org/issues/8104 ).
2022-01-22 16:49:19 -08:00
6420845fcb
GeometryShaderGen: Write the layer for every vertex
...
At least in GLSL, after calling EmitVertex() the value of all 'out' variables (including gl_Layer and ps) becomes undefined. On OpenGL it seems like they were unchanged, but on Vulkan they became 0, resulting in bad rendering.
Fixes https://bugs.dolphin-emu.org/issues/12001
2022-01-22 12:16:48 -08:00
3175e38a2e
GXPipelineUid: remove explicit shallow copy where it's the default
2022-01-16 22:34:39 -08:00
29d6dd609c
Fix non-constexpr format strings
2022-01-13 11:11:08 -08:00
5465775d11
Fix ambiguous uses of format_to
...
At least in MSVC (which is not restricted from targetting C++20), these can be resolved to either std::format_to or fmt::format_to (though I'm not sure why the std one is available). We want the latter.
2022-01-13 11:11:08 -08:00
ac46b91673
Make all fmt::formatter constructors constexpr
2022-01-13 11:11:08 -08:00
78e43a4404
Make all custom fmt::formatter's format functions const
...
fmt 8.0.0 requires this.
2022-01-13 11:11:08 -08:00
0cc211d1ef
Use fmt::format_string
2022-01-13 11:11:08 -08:00
ff8965c40b
Replace uses of undocumented/deprecated fmt::format_to overload
...
This was deprecated in fmt 8.0.0.
2022-01-13 11:11:08 -08:00
fc0d958e26
PixelShaderGen: Fix invalid use of int3(0)
...
This syntax is allowed by GLSL, but HLSL doesn't allow it. This meant that games using R8 comparisons in equal mode would produce shaders that failed to compile. Super Mario Galaxy's water levels were affected by this.
2022-01-12 21:50:34 -08:00
c18abfaecc
Merge pull request #10356 from AdmiralCurtiss/config-port-core-4
...
Config: Port remaining Core settings to new config system (the rest).
2022-01-11 16:08:19 -05:00
161c627466
Treewide: Remove unused inclusions of <cinttypes>
...
Most of these became unneeded when fmt was introduced.
2022-01-09 12:43:11 -08:00
44e93e91d7
Common/Assert: Switch to fmt
2022-01-09 12:43:11 -08:00
c82b2dccb5
Config: Port SyncGPU settings to new config system.
2022-01-09 21:29:12 +01:00
d8825f5635
Config: Port dual core setting to new config system.
2022-01-09 21:29:11 +01:00
4c0dcf42b8
Merge pull request #10346 from iwubcode/fixed_shader_precompile_parallelization
...
VideoCommon: Fix shader precompilization detection
2022-01-06 16:28:15 -05:00
d98c6b0b1d
Config: Port GPUDeterminismMode setting to new config system.
2022-01-06 16:13:55 +01:00
fb47035f97
Config: Port emulation speed setting to new config system.
2022-01-06 16:13:54 +01:00
9b4e5b00ee
VideoCommon: assume the majority of os/drivers support parallel compiling of shaders, we can create bugs if there are issues. Android is assumed buggy
2022-01-04 20:40:07 -06:00
9a914d33d5
Merge pull request #9414 from DevJPM/master
...
Fix CPU Core Count detection and Enable Parallel Shader Compilation
2022-01-04 10:15:12 -05:00
0de008da11
Merge pull request #10332 from AdmiralCurtiss/config-port-general
...
Config: Port remaining General settings to new config system.
2022-01-03 01:40:37 +01:00
afd02b79a5
VideoCommon: Add names for textures and shaders
2022-01-01 11:38:56 -08:00
d590aa88a4
Config: Port remaining General settings to new config system.
2022-01-01 19:02:45 +01:00
aa437d9805
Config: Port Movie settings to new config system.
2021-12-30 20:16:17 +01:00
a96cfe2531
GLES: Fix LOD bias int/float mismatch
...
Another simple GLES shader compilation error.
2021-12-28 19:19:22 +01:00
01e8e950e8
Merge pull request #10292 from OatmealDome/lodbias-take-two
...
PixelShaderGen: Use LOD bias when sampling texture on Metal and OpenGL ES
2021-12-28 02:45:14 -05:00
056613ecc5
PixelShaderGen: Add LOD bias to texture() call on systems that don't support it in the sampler
2021-12-28 02:10:45 -05:00
4e12d6e871
ShaderGenCommon: Add bit for LOD bias
2021-12-28 02:10:39 -05:00
08396c56e5
VideoConfig: Add bool for sampler LOD bias support
2021-12-25 15:16:27 -05:00
1cd148d4c5
GeomeryShaderGen: Set gl_ClipDistance on Vulkan as well as OpenGL
...
Fixes https://bugs.dolphin-emu.org/issues/12548
2021-12-23 17:56:21 -08:00
85025612bc
LightingShaderGen: Make s_lighting_struct not inline
...
This generated warnings on the freebsd builder.
2021-12-22 15:17:52 -08:00
e6f40fa015
Merge pull request #10279 from Pokechu22/intensity-alpha
...
TextureConverterShaderGen: Set alpha to 1 on intensity formats if EFB lacks alpha
2021-12-23 00:14:06 +01:00
b1f79d9ecf
Merge pull request #10215 from OatmealDome/shader-logic-ops
...
VideoCommon: Support shader logic ops on Metal (Apple GPUs) and OpenGL ES
2021-12-22 16:39:54 -05:00
fd2324e40a
Fifo analyzer: Rename mipmap filter to half scale for EFB copies
...
The field itself is named half_scale, and it can be used for things unrelated to mipmaps, so reflecting that name in the fifo analyzer helps.
2021-12-20 11:34:05 -08:00
2f6953efb6
TextureConverterShaderGen: Set alpha to 1 on intensity formats if EFB lacks alpha
...
We were already doing this for non-intensity formats, but it seems like the same applies to intensity formats.
2021-12-20 11:34:05 -08:00
e7d5f8ad5c
TextureCacheBase: Re-wrap GetTexture comment
2021-12-18 15:21:48 -08:00
d1cc539476
BPMemory: Correct spelling of MaxAniso
2021-12-18 15:21:48 -08:00
27cb704466
Eliminate VarType for ComponentFormat
2021-12-18 15:21:48 -08:00
1a964891f8
VertexLoader_Color: Use Common::swap24
2021-12-18 15:21:48 -08:00
95e0f833f9
Fifo analyzer: Display equations for color/alpha combiners
2021-12-18 15:21:48 -08:00
0afe318b55
OpcodeDecoding: Make s_is_fifo_error_seen static
2021-12-18 15:21:48 -08:00
d039b1bc0d
VideoCommon: Move VertexLoaderManager logic out of CPState
2021-12-18 15:21:48 -08:00
d84d695fdf
Remove DataReader from LoadXFReg
2021-12-18 15:21:48 -08:00
b5fd35f951
Refactor OpcodeDecoding and FIFO analyzer to use callbacks
2021-12-18 15:21:36 -08:00
1914087998
Create and use CPArray enum class
2021-12-18 12:51:56 -08:00
3aaeb2b9ef
Convert OpcodeDecoder::Opcode and OpcodeDecoder::Primitive to enum class
2021-12-18 12:51:56 -08:00
205ab23d80
GeometryShaderGen: Convert to EnumMap
2021-12-18 12:51:55 -08:00
f53dc6564f
UberShaderPixel: Convert to EnumMap
2021-12-18 12:51:55 -08:00
380b333387
PixelShaderGen: Convert to EnumMap
2021-12-18 12:51:55 -08:00
2b1d1038a6
VertexLoader: Convert to EnumMap
2021-12-18 12:51:55 -08:00
327126d1e8
ShaderGenCommon: Add WriteSwitch
2021-12-18 12:51:55 -08:00
2025763420
Treewide: Adjust order of includes
2021-12-10 14:49:57 -08:00
74a979db09
UberShaderPixel: Add shader logic ops support on OpenGL ES
2021-12-06 22:36:40 -05:00
18b2f6953d
PixelShaderGen: Add shader logic ops support on OpenGL ES
...
To do this, I had to decouple framebuffer fetch from shader blending. We need to be able to access framebuffer fetch input when using shader logic ops.
2021-12-06 22:36:40 -05:00
a77ae14d94
UberShaderPixel: Add shader logic ops support on Metal
2021-12-06 22:36:40 -05:00
e0837cb847
PixelShaderGen: Add shader logic ops support on Metal
2021-12-06 22:36:40 -05:00
426c68b5a0
ShaderCache: Don't turn on logic ops approximation if framebuffer fetch is supported
2021-12-06 22:36:40 -05:00
c12b9b013b
PixelShaderGen: Add logic ops to pixel_shader_uid_data
2021-12-06 22:36:34 -05:00
0327bc2ab6
Merge pull request #10256 from malleoz/show-rerecord-count
...
Renderbase: Show rerecord count
2021-12-03 14:42:10 +13:00
c12e4e8ee0
Merge pull request #10244 from phire/ban-timetravel
...
Delay singlecore gpu interrupts; Fixes Bomberman Jetters in single core mode.
2021-12-02 07:21:41 -05:00
e4fed7cce8
Add Rerecord Count display
...
Simply shows Movie::s_rerecords in the ImGui Movie window
2021-11-30 20:08:29 -05:00
04ec02c06b
ConstantManager: Add logic ops to PixelShaderConstants
2021-11-24 17:52:26 -05:00
f5c550e9cb
Delay singlecore gpu interrupts
...
Fixes Bomberman Jetters in single core mode.
When single core mode pauses the CPU to execute the GPU
FIFO it greedily executes the whole thing. Before this commit,
Finish and Token interrupts would happen instantly, not even
taking into account how long the current FIFO window has
taken to execute. The interrupts would be effectively backdated
to the start of this execution window.
This commit does two things: It pipes the current FIFO window
execution time though to the interrupt scheduling and it enforces
a minimum delay of 500 cycles before an interrupt will be fired.
2021-11-25 11:11:01 +13:00
aa5cb35c86
Merge pull request #10143 from Pokechu22/png-compression-level
...
Add option for setting the PNG zlib compression level
2021-11-23 16:40:34 +01:00
f43122cd8a
Trust MacOS not to crash during shader pre-compilation
2021-11-22 15:32:28 +01:00
613c4563c2
VideoCommon: Gate Multi-Threaded Shader Pre-Compilation behind a bug entry
2021-11-22 09:34:28 +01:00
61cfd8696e
Fix CPU Core Count detection and Enable Parallel Shader Compilation
...
This does this following things:
- Default to the runtime automatic number of threads for pre-compiling shaders
- Adds a distinct automatic thread count computation for pre-compilation (which has less other things going on
and should scale better beyond 4 cores)
- Removes the unused logical_core_count field from the CPU detection
- Changes the semantics of num_cores from maximaum addressable number of cores to actually available CPU cores
(which is also how it was actually used)
- Updates the computation of the HTT flag now that AMD no longer lies about it for its Zen processors
- Background shader compilation is *not* enabled by default
2021-11-20 16:08:10 +01:00
dbaebdc585
Merge pull request #10222 from phire/fix-copy-filter-clamping
...
Fix copy filter clamping
2021-11-18 17:48:33 -05:00
94ccf765af
Add option for setting the PNG zlib compression level
2021-11-18 13:10:22 -08:00
1adff1c467
VideoCommon: Skip textureQueryLevels if it doesn't exist
2021-11-17 21:28:39 -08:00
bdcfb31187
VideoCommon: Handle custom texture sizes correctly
...
Specifically, when using Manual Texture Sampling, if textures sizes don't match the size the game specifies, things previously broke. That can happen with custom textures, and also with scaled EFB copies at non-native IRs. It breaks most obviously by not scaling the texture coordinates (so only part of the texture shows up), but the hardware wrapping functionality also assumes texture sizes are a power of 2 (or else it will behave weirdly in a way that matches how hardware behaves weirdly). The fix is to provide alternative texture wrapping logic when custom texture sizes are possible.
2021-11-17 21:28:36 -08:00
93eea7cb13
VideoCommon: Add option to use old behavior (Fast Texture Sampling)
...
Co-authored-by: JosJuice <josjuice@gmail.com>
2021-11-17 21:27:32 -08:00
ee80298ca4
VideoCommon: Implement diagonal LOD
...
Note that both GLSL and HLSL provide a fwidth (fragment width) function defined as `fwidth(p) = abs(dFdx(p)) + abs(dFdy(p))`. However, it's easy enough to implement this ourselves (and it makes the code a bit more obvious).
2021-11-17 20:04:34 -08:00
51e3334526
VideoCommon: Use coarse derivatives for Manual Texture Sampling if possible
2021-11-17 20:04:34 -08:00
ddf2691395
VideoCommon: Manually handle texture wrapping and sampling
2021-11-17 20:04:34 -08:00
4a9b26de86
VideoCommon: Expose SamplerState to shaders
...
The benefit to exposing this over the raw BP state is that adjustments Dolphin makes, such as LOD biases from arbitrary mipmap detection, will work properly.
2021-11-17 20:04:34 -08:00
9ef228503a
VideoCommon: Provide raw texdims to shaders
2021-11-17 20:04:34 -08:00
a273b65566
RenderState: Use operator== for operator!= and adjust constructors
2021-11-17 20:04:34 -08:00
6236a0d494
Eliminate SamplerCommon
2021-11-17 20:04:34 -08:00
3096f77ba0
Eliminate SamplerCommon::AreBpTexMode0MipmapsEnabled
...
This was added in 0b9a72a62d70f9fc4e75
2021-11-17 20:04:34 -08:00
d2041b4c2a
VideoCommon: Add signed version of BitfieldExtract
2021-11-17 20:04:33 -08:00
555a93057c
VideoCommon: Allow BitfieldExtract in specialized shaders
2021-11-17 20:04:33 -08:00
7128befb39
Fix copy filter clamping regression in Spyro
...
This fixes horizontal lines in the bloom effect of Spyro: A Hero's Tail,
which is a regression caused by PR #10204
Screenshot of regression:
https://user-images.githubusercontent.com/138484/142030503-90fcd8d5-63d3-4820-874a-72e9be0c4768.png
Fixed:
https://user-images.githubusercontent.com/138484/142031598-b85ff55c-1302-4e4d-bcb2-57848974056b.png
Spyro uses an 640x80 pixel sub-buffer within the EFB to calculate
it's bloom effects, which it places below the main 640x448 buffer.
EFB layout:
https://user-images.githubusercontent.com/138484/142030573-e933b6ae-c37e-4be6-86d4-0bc779b92535.png
Note: Colors are wrong because the main color buffer uses RGBA6,
while the bloom is calculated in RGB8
This allows it to do bloom without backing up part of the EFB to
main memory, as most games do.
But, since some of the sub-buffers used in the bloom effect are taller
than 80 pixels, they need to be sliced up into smaller sub, sub buffers
which get combined later when copied to main memory.
At one point, a 320x224 buffer is broken up into 320x80, 320x64 and
320x80 slices. These are copied out with the copy filter set to a
vertical blur.
Because there was an off-by-one errror in the clamping coordinates,
the bottom line of the color buffer would be blurred into
the top of each slice.
Final combined EFB copy:
https://user-images.githubusercontent.com/138484/142031360-2c076839-7c96-4b3b-a093-d899d0a2c7ae.png
Fixed version:
https://user-images.githubusercontent.com/138484/142031370-72e41a35-3b3e-4662-a483-79203e357ecc.png
Before #10204 the copy filter wasn't enabled for efb copies, and most
other games don't do this type of slicing.
FIFO CI shows that a few other games are effected, it's always just a minor difference to the top line where there was previously a slight hint of garbage.
2021-11-17 06:12:46 +13:00
868de78f16
VideoCommon: Use the copy filter for EFB copies as well as XFB copies
...
This fixes the pink screens in EA Sports Active. See https://gist.github.com/Pokechu22/49455f9094ed0ff017da64e3f7aa0404 for details.
2021-11-11 17:22:50 -08:00
6c72e6814d
Merge pull request #10169 from leoetlino/fmt-localtime
...
Use fmt::localtime instead of thread-unsafe std::localtime
2021-11-07 00:08:14 -04:00
5a1333026b
VideoCommon: Add missing algorithm include for std::none_of
...
Otherwise this is an error on gcc/libstdc++, and there are no transitive
includes for this header.
2021-11-02 13:50:21 +01:00
7590f07b80
FrameDump: Remove deprecated call to av_init_packet()
...
This function was deprecated in ffmpeg in January[1], while its
replacement got introduced in 2015[2], so now might be the time to start
using it in Dolphin. :)
[1] f7db77bd87a9a6010637
2021-11-02 13:50:21 +01:00
25b136ac17
VideoCommon: Fix a -Wclass-memaccess in gcc 11
2021-11-02 13:50:21 +01:00
db54e4f2b0
Externals: Update imgui to 1.85
2021-10-26 15:07:57 -07:00
fd7df2ccae
Use fmt::localtime instead of thread-unsafe std::localtime
...
fmt::localtime is also less awkward to use compared to std::localtime.
2021-10-15 22:49:13 +02:00
a372a5947b
VideoCommon: Fix color channel logic when per-pixel lighting is in use
...
This was broken in #10012 (specifically by 06579e4d53c3dec34391
2021-10-13 20:43:32 -07:00
78bfd25964
Fix all uninitialized variable warnings (C26495)
2021-10-13 12:32:16 -07:00
edb66dab84
TextureCache: Remove deleted textures from bound_textures
...
Fixes issue where vulkan might crash trying to bind a deleted
texture.
2021-10-12 15:51:24 +13:00
d771bee0fe
TMEM: Add some helpful comments
2021-10-12 15:51:24 +13:00
a33cf27885
TMEM: Handle savestate and init
2021-10-12 15:51:24 +13:00
88bd10cd30
Extend TMEM cache implementation
...
Now works with games that deliberately avoid invalidating TMEM because
they know textures are too large to fit:
* Sonic Riders
* Metal Arms: Glitch in the System
* Godzilla: Destroy All Monsters Melee
* NHL Slapshot
* Tak and the Power of Juju
* Night at the Museum: Battle of the Smithsonian
* 428: Fūsa Sareta Shibuya de
2021-10-12 15:51:24 +13:00
5a8455e8ce
BoundingBox: Add missing include
2021-10-10 13:21:31 +13:00
9fa26624b0
BPMemory: Refactor/consolidate TexUnit Addressing
...
Currently the logic for addressing the individual TexUnits is splattered all
across dolphin's codebase, this commit attempts to consolidate it all into a
single place and formalise it using our new TexUnitAddress struct.
2021-10-10 09:09:43 +13:00
ef0e401708
BPMem: Abstract TexUnit Addressing into struct
...
The addressing of the texture units is a bit non-obvious.
This struct abstracts the complexity away.
2021-10-10 09:01:57 +13:00
514475646d
VideoCommon: update Free Look camera's 'FieldOfView' function to 'FieldOfViewMultiplier' to better reflect usage
2021-10-08 18:17:20 -05:00
aa07fde8a0
VideoCommon: update fov multiplier variables and add constant variables for defaults to the Free Look camera
2021-10-08 18:17:20 -05:00
e70157474b
Core / VideoCommon: refactor FreeLookCamera to have the underlying controller handle all the logic (field-of-view, movement, etc)
2021-10-08 18:16:32 -05:00
ff1cb5a1c0
Merge pull request #9803 from Techjar/bbox-videocommon
...
VideoCommon: Abstract bounding box
2021-10-08 22:24:38 +02:00
90437d1574
Change how FFmpeg is imported for Apple computers.
...
Imports Apple libraries and also pulls swresample in, so when compiling Dolphin doesn't throw undefined symbols.
2021-10-06 18:11:32 -10:00
1161af8059
VideoCommon: Abstract bounding box
...
This moves much of the duplicated bounding box code into VideoCommon,
leaving only the specific buffer implementations in each backend.
2021-10-04 15:51:24 -04:00
e11fdaabf1
fix unused variable warning
2021-09-30 14:27:53 -04:00
30dcac15fa
RenderBase: Show input count on m_ShowFrameCount
...
Just to stay consistent, I believe it is best to show total input polls alongside the framecount.
2021-09-29 14:36:09 -04:00
a47b91e946
Merge pull request #9945 from OatmealDome/intel-broken-discard
...
DriverDetails: Add broken dual source blending bug to MoltenVK on Intel GPUs
2021-09-30 06:04:06 +13:00
53ca2ec274
RenderBase: show total framecount on movie playback
...
Previously, when playing back a movie, you could not see the total frame count of a movie, only the total number of input polls.
This change simply shows the total frame count on movie playback.
Note that this change also results in the framecount and framecount total ALWAYS being displayed if show_movie_window is true, regardless of whether or not m_ShowFrameCount is true. I believe this is fine, as TASers are much more likely to reference the framecount than the input poll count.
2021-09-28 22:15:25 -04:00
a256c11d2f
DriverDetails: Add broken dual source blending bug to MoltenVK on Intel GPUs
2021-09-20 19:14:41 -04:00
ce80a96aee
BPStructs: ensure side effects are same
...
Missed this side effect when fixing crash in Mario Kart Wii wifi
2021-09-18 23:58:24 +12:00
7e8f5208fe
VulkanContext: Disable subgroup reduction on macOS with AMD GPUs
2021-09-16 23:32:10 -04:00
7c7609f5b9
BPStructs: Ignore malformed efb copies
2021-09-17 12:42:23 +12:00
eb8bfabdfd
BPStructs: make copy width/height const
2021-09-15 11:54:40 +12:00
37b80e2170
BPStructs: fix out-of-range EFB copy clamping
...
Previous code from #7950 only clamps correctly when the efb copies
left and top coordinates are (0, 0)
Now we should handle all situations.
Spyro: A hero's tail is an example of a game that does an oversized
EFB copy with a non-zero origin.
2021-09-15 02:31:38 +12:00
05f86b9f5b
Merge pull request #10012 from Pokechu22/thps4-green-sky
...
UberShaderVertex: Fix Tony Hawk Pro Skater 4
2021-09-09 17:58:35 -04:00
52c82733f6
Use custom isnan implementation to avoid HLSL optimizer issues
...
This adjusts the NaN replacement logic introduced in #9928 to work around the HLSL compiler optimizing away calls to isnan, which caused that functionality to not work with ubershaders on D3D11 and D3D12 (it did work with specialized shaders, despite a warning being logged for both; that warning is also now gone). Note that the `D3DCOMPILE_IEEE_STRICTNESS` flag did not solve this issue, despite the warning suggesting that it might.
Suggested by @kayru and @jamiehayes.
2021-09-07 19:04:40 -07:00
f36fd5fa39
BPMemory: Make ZTexOp enum an enum class
...
Avoids placing generic names in the surrounding namespace.
2021-09-01 18:23:22 -04:00
1f2f505373
VideoBackends / VideoCommon: allow the ability to set debug names for shaders / textures. These names are visible in applications like RenderDoc
2021-08-30 13:47:48 -05:00
c3dec34391
UberShaderVertex: Simplify color channel logic
2021-08-18 10:40:54 -07:00
06579e4d53
VertexShaderGen: Simplify color channel logic
2021-08-18 10:40:54 -07:00
2519d14e36
UberShaderVertex: Fix Tony Hawk Pro Skater 4
...
Fixes https://bugs.dolphin-emu.org/issues/12620
The changed code did not match the corresponding code in VertexShaderGen. Some parts of the sky have 2 color channels in each vertex, while others only have 1, despite only color channel 0 being used and XFMEM_SETNUMCHAN being set to 1 for both of them. The old code (from #4601 ) caused channel 0 to be set to channel 1 if the vertex contained both color channels but the number of channels was set to 1, which is wrong.
2021-08-18 10:40:53 -07:00
f9d2d42a4c
VideoCommon: report games that set bits in XFMEM_CLIPDISABLE
...
The SDK only exposes the lowest bit. The Nintendo Channel intro is currently
broken because we don't implement this (see issue 12562).
2021-08-15 04:41:49 +01:00
c79757618d
Merge pull request #9993 from Techjar/late-vi-output
...
VI: Implement post-scanout XFB output
2021-08-07 12:41:59 +02:00
797d0b7b1b
VI: Implement post-scanout XFB output
...
This adds about a frame of latency, and since most games don't change
VI registers during scanout, we can get away with outputting the XFB at
the start of scanout. WWE Crush Hour is the (only currently known)
exception, which has flickering problems when doing it this way.
This adds a path to perform the output at the end of scanout, and gates
it behind an option which defaults to using the latency-reducing
pre-scanout path.
2021-08-03 23:37:50 -04:00
c9c5f7a89c
Merge pull request #9928 from Pokechu22/shadow-the-hedgehog-eyelids-NaN
...
Convert NaN to 1 when generating texture coordinates
2021-08-04 03:08:34 +02:00
35bf5e3839
Merge pull request #9962 from OatmealDome/macos-vulkan-default
...
VideoBackendBase: Prefer Vulkan over OGL on macOS Mojave and newer
2021-08-02 03:39:12 +02:00
f46fe77264
GeometryShaderGen: Rename ApiType to api_type
2021-08-01 15:17:21 -07:00
3b752c4d5d
UberShaderPixel: Rename ApiType to api_type
2021-08-01 15:09:20 -07:00
b6d2938731
Recompile shaders when 'Enable API Validation Layers' is toggled
2021-07-28 21:35:36 -07:00
eb81968fe6
Convert ShaderHostConfig to BitField
2021-07-28 21:35:36 -07:00
1640fa9096
Remove note about anisotropic filtering requiring edge LOD
...
This was added because YAGCD's info on MAXANISO (near TX_SETMODE0 in Section 5.11.1) claims it's the case, but Extrems says it does work. I haven't tested anything myself, and dolphin still does not actually implement anisotropic filtering based on this field.
2021-07-27 19:33:31 -07:00
46e331d000
VideoBackendBase: Prefer Vulkan over OGL on macOS Mojave and newer
2021-07-25 19:21:06 -04:00
3a4d8379bf
Convert NaN to 1 when generating texture coordinates
...
This fixes eyelids in Shadow the Hedgehog during cutscenes (https://bugs.dolphin-emu.org/issues/11458 )
2021-07-24 22:20:35 -07:00
19332575aa
WrapMode=3 behaves the same as Clamp
2021-07-20 19:23:23 -07:00
92fc4f1eca
PixelShaderGen: Fix OpenGL ES bounding box compilation error
2021-07-20 11:39:32 +02:00
OatmealDome
