7a1f676ef4
Always use configured root when installing WAD
...
This prevents Dolphin from writing to /sys/uid.sys (on the host; root
partition) when installing a WAD before starting emulation, because
the session root is not initialized at that moment.
Incidentally, this also gets rid of a singleton.
2017-02-10 19:12:08 +01:00
e07383a783
Core: Convert State enum into an enum class
2017-02-05 08:32:23 -05:00
017e8050b6
Merge pull request #4746 from JosJuice/volumedirectory-sort-case-insensitive
...
VolumeDirectory: Use case-insensitive comparison when sorting
2017-01-27 18:23:14 +13:00
104faa9fb3
VolumeDirectory: Use case-insensitive comparison when sorting
...
This fixes a regression from 5.0-1556, but I don't know why
the regression occurred or why this fixes it. (Many games
failed to fully boot - I tried Metroid Prime and Twilight
Princess (both GC), and they never got to the title screen.)
2017-01-25 15:07:07 +01:00
3d21280ab4
DiscIO: Fix out-of-bounds access in NANDContentDataBuffer
...
Accessing buffer[start + size] triggers an error (and a crash) in debug
builds. Using std::copy_n fixes this.
2017-01-23 21:49:26 +01:00
b892d78872
VolumeWad: Implement GetTMD()
...
This allows getting useful info like the required IOS version for WADs
(for showing it in the UI, for example).
2017-01-23 20:59:02 +01:00
f89aaee91a
VolumeWad: Remove useless else after return
2017-01-23 18:17:34 +01:00
2cd287baf7
VolumeWad: Add missing forward declaration
2017-01-23 18:17:34 +01:00
6128679396
VolumeWad: Clean up variable naming
2017-01-23 18:07:23 +01:00
6d909b3e30
VolumeWad: In-class initialise member variables
2017-01-23 18:07:21 +01:00
90ee85f4e8
Merge pull request #4714 from JosJuice/wbfs-file-entry
...
Fix -Wshadow warning for file_entry
2017-01-22 17:56:51 +01:00
79f3b5c5ff
Fix -Wshadow warning for file_entry
...
This struct didn't follow our naming convention,
so let's rename the struct itself instead of
the variable that triggered the warning.
2017-01-22 17:27:37 +01:00
07d1f18f53
CompressFileToBlob: add an explicit seek to make sure we're at the start
2017-01-21 21:42:58 +01:00
30e0f3d9ca
DecompressFileToBlob: don't assume success if decompression failed
2017-01-21 21:42:58 +01:00
24be8c0814
IsGCZBlob: try to leave the file position where it was before
...
callers that don't seek afterwards might be missing a few bytes that way.
2017-01-21 21:42:57 +01:00
334ddf754e
DiscIO: Export GetKeyFromTicket
...
This function has more uses than just in DiscIO (e.g. WFS).
2017-01-14 17:06:40 +01:00
650a1fdb1f
DiscIO: Implement functions to lookup tickets
...
These two functions load either a signed ticket or a raw ticket from the
emulated NAND.
The ticket signature skip is refactored out of the ticket writing in
order to be usable by the raw ticket reading function.
2017-01-14 17:06:40 +01:00
2ed352698f
IOS/ES: Implement ES_AddTicket.
...
Refactor the existing DiscIO::AddTicket to not require the caller to
pass the requested title ID. We do not have the title ID in the ES case,
and it needs to be extracted from the ticket. Since this is always a
safe operation to do (title ID is always in the ticket), the
implementation is made default.
2017-01-14 15:23:16 +01:00
9838afea41
Merge pull request #4479 from GerbilSoft/feature/RVT-R.dev-key
...
Support for RVT-R disc images
2017-01-13 09:56:50 +13:00
d346d4ced1
Merge pull request #4544 from JosJuice/region-enum
...
DiscIO: Add GetRegion function and Region enum
2017-01-13 09:19:27 +13:00
b1873264d7
WbfsBlob: Don't wrap file_entry in std::unique_ptr
...
There doesn't seem to be any reason for doing it.
2017-01-11 13:39:46 +01:00
0363be4320
WbfsBlob: Remove m_total_files
...
std::vector already keeps track of this for us.
2017-01-11 13:39:38 +01:00
5c02795af0
WbfsBlob: Only open each file once
...
The first file used to be opened once by
CreateBlobReader and once inside WbfsFileReader.
2017-01-11 13:33:27 +01:00
8d54bbc528
Don't create new IOFiles when creating a blob
...
...except for WBFS, which is special because
it has the ability to open multiple files.
2017-01-11 13:23:23 +01:00
d1ea00ed88
Only open file once when detecting blob type
2017-01-11 13:23:19 +01:00
a93861ab49
DiscScrubber: Don't take SFileInfo instances by value
...
Avoids unnecessary copies.
2017-01-04 20:12:49 -05:00
c52d1e735a
DiscScrubber: Use an unsigned loop index in ParseDisc
...
Prevents an implicit signed to unsigned conversion when assigning a
partition's group number.
2017-01-04 20:03:12 -05:00
6ff21c48cb
DiscScrubber: Correct printf specifiers
2017-01-04 19:56:39 -05:00
b1a2dec78a
DiscScrubber: Convert a #define into a typed constant
2017-01-04 19:53:31 -05:00
5b1aae0cbf
DiscScrubber: Make struct and variable names conformant to the coding style
2017-01-04 17:04:41 -05:00
4a9bc2340b
DiscScrubber: Convert into a class
...
Allows potential multiple scrubbers to run at once. Also gets rid of the
need to explicitly clean up resources.
2017-01-04 16:06:21 -05:00
f85266df20
SConfig: Replace bNTSC with m_region
...
This lets us get rid of VideoInterface::SetRegionReg,
a huge hack in CEXIMemoryCard, and some minor things.
2017-01-02 20:57:48 +01:00
66ea9f5cc1
DiscIO: Add GetRegion function and Region enum
...
Instead of needing different switch cases for
converting countries to regions in multiple places,
we now only need a single country-to-region switch case
(in DiscIO/Enums.cpp), and we get a nice Region type.
2017-01-02 20:57:11 +01:00
8e4a781974
VolumeDirectory: Modernize variable names
2016-12-26 11:45:22 +01:00
00aa2d37e9
VolumeDirectory: Don't use references inappropriately
...
Integers should be passed as pointers when a function
modifies them (to make it clear that they get modified).
2016-12-26 09:52:18 +01:00
9c8e27e3bb
Merge pull request #4558 from JosJuice/volumedirectory-fst-sort
...
VolumeDirectory: Sort the FST
2016-12-25 17:38:58 -05:00
3196f697bb
VolumeDirectory: Use a range-based for loop in ComputeNameSize
2016-12-25 23:01:42 +01:00
f3987d13ea
VolumeDirectory: Make m_totalNameSize a local variable
...
After BuildFST finishes executing, it's never needed again.
2016-12-25 22:57:14 +01:00
a502f069e8
VolumeDirectory: Sort the FST
...
We can't rely on the OS returning files and directories
in a deterministic order, so we should sort them on our own
if we want VolumeDirectory to work for movies and netplay.
2016-12-25 22:35:38 +01:00
9bd514ed1c
Add TGC disc image compatibility
2016-12-18 18:57:36 +01:00
31ccfffd38
Common: Add alignment header
...
Gets rid of duplicated alignment code.
2016-12-06 20:33:53 +01:00
25fe999a79
Added support for Wii RVT-R disc images.
...
These disc images are encrypted and signed using a different set of keys.
We only care about the master key, so we check the signature issuer. If
it matches the debug issuer, then we'll use the RVT-R key. Otherwise,
the previous set of common and Korean keys are used.
2016-12-01 07:51:29 -05:00
d5ca153c26
Merge pull request #4401 from JosJuice/rename-getuniqueid
...
DiscIO/SConfig: Rename GetUniqueID to GetGameID
2016-10-31 12:39:27 +01:00
1081497cad
DiscIO/SConfig: Rename GetUniqueID to GetGameID
...
We call this "game ID" everywhere else, and it's not
actually completely unique.
2016-10-29 15:24:02 +02:00
d6731d34ef
Remove VolumeCreator logs
...
These logs are very rarely useful and cause the issue
https://bugs.dolphin-emu.org/issues/9767
2016-10-29 13:08:24 +02:00
d9eb7c4e80
NANDContentLoader: Add IOFile forward declaration
...
This would previously fail to compile when included in files that do not
include FileUtil.h due to lack of a type declaration.
This moves the constructor and destructor into the cpp file in order to
satisfy the requirements of unique_ptr construction and deletion. That is,
unique_ptr requires a concrete type at the point of construction and
destruction. If the constructor or destructor is left in the header, then
at the point of construction or destruction, IOFile will still be
considered an incomplete type, as unique_ptr's deleter will still only be
able to see the forward declaration, which it can't use.
2016-10-14 20:27:22 -04:00
cc66f0336f
Merge pull request #3963 from JosJuice/banner-loaded-failure
...
VolumeGC: Set m_banner_loaded when banner loading fails
2016-10-03 06:33:52 -07:00
ccfc081697
Merge pull request #4245 from aldelaro5/logs-levels-changes
...
Lots of Logs levels changes (also enable INFO level in every build)
2016-10-02 16:51:44 -04:00
f0aa9b3751
Reorganise a ton of logs level
...
Most of this commits changes performance decreasing logs from info to debug and also cleans up innacurate levels.
2016-10-01 15:50:28 -04:00
61b977c914
WiiWad: Make WiiWAD constructor explicit
2016-09-25 18:04:11 -04:00
7de0d51345
WiiWad: Move static implementation details to cpp file
...
These functions don't actually depend on any state from the class
instance, so they don't really belong in the header, and are just
an implementation detail.
2016-09-25 18:04:04 -04:00
144c23dead
Filesystem: Return strings from GetFileName without the const qualifier
...
This is mostly pointless and can inhibit move construction
2016-09-18 12:56:25 -04:00
5aeedcd27c
NANDContentLoader: Remove unnecessary trailing semicolons
2016-09-14 20:12:25 -04:00
b43a26b90c
NANDContentLoader: Remove virtual specifier from CNANDContentLoader destructor
...
This class is marked final, so there's no need to declare it as virtual.
2016-09-14 19:45:52 -04:00
3196bf5392
NANDContentLoader: Specify constructors as explicit where applicable
...
Prevents implicit conversion.
2016-09-14 19:44:44 -04:00
89c65be703
NANDContentLoader: Delay vector construction until needed in Get()
...
No need to construct the vector right off the bat.
2016-09-14 19:41:41 -04:00
b1ffa74043
NANDContentLoader: Make CNANDContentData's Get function return by non-const value
...
const specifiers like this are practically pointless and can inhibit move construction.
2016-09-14 19:15:31 -04:00
eccec3c6d3
DiscIO: Fix NAND Memory Leak
...
CNANDContentData is a base class with a non-virtual destructor so
derived classes don't get destroyed causing them to leak resources.
2016-09-14 15:54:05 +10:00
c1184957a5
Run clang-format on missed files
...
`clang-format`s files that lint missed because of the bug. Fortunately,
not much.
2016-08-11 21:14:39 +02:00
0a15aaaa12
Move DiscIO enums to a new file
...
At first there weren't many enums in Volume.h, but the number has been
growing, and I'm planning to add one more for regions. To not make
Volume.h too large, and to avoid needing to include Volume.h in code
that doesn't use volume objects, I'm moving the enums to a new file.
I'm also turning them into enum classes while I'm at it.
2016-07-13 17:29:27 +02:00
f4d2626d2b
Merge pull request #4005 from EmptyChaos/blockcache-bug
...
SectorReader: Minor cache bias bug
2016-07-13 12:11:19 +02:00
53e7eed28d
DiscScrubber: Fix issue 9356
2016-07-11 11:46:15 +02:00
9036b9d8e8
SectorReader: Fix cache line bias
...
Minor bug where SectorReader::GetEmptyCacheLine was biased towards
the first hit.
2016-07-09 02:27:35 +10:00
31226b8503
DiscScrubber: Replace unused blocks with 0x00 instead of 0xFF
2016-07-07 11:51:58 +02:00
202c9d58cd
VolumeGC: Set m_banner_loaded when banner loading fails
...
If banner loading fails once, it will very likely fail again.
Setting m_banner_loaded to true when banner loading fails
prevents LoadBannerFile from wasting time if it's called again.
Banner loading requires loading the file system, which takes a
noticeable amount of time, so this matters.
2016-06-28 18:05:44 +02:00
1878605d77
Undo some comment formatting changes from b5104a7
2016-06-25 18:07:10 +02:00
b5104a79f1
GCVolume: supports reading all opening.bnr information
...
DQT2: Game properties dialog contains info tab giving information about the selected iso.
2016-06-26 00:03:59 +10:00
3570c7f03a
Reformat all the things. Have fun with merge conflicts.
2016-06-24 10:43:46 +02:00
c4240692b6
SectorReader: Fix reading the last block of the disc.
...
Regression from PR #3795 .
2016-05-29 18:26:04 +02:00
97d570f0c9
DriveReader: Fix View > Show Drives
...
DriveReader::m_size was never initialized which was indirectly
causing CGameListCtrl to crash Dolphin when it tried to insert a
character at a negative index in a string.
Reading one sector at a time is very inefficient and appears to
be causing timing issues during boot so SectorReader has been
enhanced to support batching.
SectorReader has been given a working cache system.
2016-04-26 21:24:08 +10:00
a449ef4e11
properly open/close the file to avoid rapid open/close cycles
...
ES_OPENCONTENT and ES_CLOSECONTENT now call Open and Close respectively,
as the old code did.
2016-03-20 13:10:51 +01:00
8a6d9e1e0b
hide the distinction between WAD and File from ES
...
instead, leave all the management with the NANDContentLoader.
for file data (directly on the NAND), this opens the file on-demand and
returns the requested chunk when asked for it.
for on-the-fly decrypted WAD data, we just keep the decoded buffer in
memory, like we've done before - except that we don't give away any objects
we don't want to.
2016-03-20 13:10:50 +01:00
1e28d06f26
fix some style inconsistencies that drove me nuts
2016-03-20 13:10:47 +01:00
92278886b9
DiscIO: Use specified Wii region for discs
2016-01-15 03:35:10 +08:00
bff79df363
Merge pull request #3429 from sepalani/debug_vector_fix
...
Debug Builds: Fixed vector assertion
2016-01-07 00:48:40 +01:00
81466d7fa3
DolphinWX: Stop using XPM images
...
Using the XPM format for images has become a maintenance problem because
people don't know how to create them. This commit removes all XPM images
and all C files that contain PNG images. DolphinWX now uses the PNGs
in the Resources folder instead, just like DolphinQt and DolphinQt2 do.
2016-01-05 19:11:58 +01:00
ba794272f5
Debug Builds: Fixed vector assertion
2016-01-03 13:17:26 +01:00
1b69743ba1
Merge pull request #3362 from lioncash/memory
...
NANDContentLoader/WiiWAD: Get rid of raw delete and new
2015-12-22 06:39:12 -05:00
aaa89d4f73
Silence -Wshadow and -Wmaybe-uninitialized warnings.
2015-12-21 10:06:07 -06:00
cbeb7034eb
Volume: Make GetTMD return a vector
2015-12-19 18:00:44 -05:00
c78c54c546
NANDContentLoader/WiiWAD: Get rid of raw delete and new
2015-12-19 17:37:09 -05:00
c310b3f0e6
Merge pull request #3309 from JosJuice/reload-banner-without-volume
...
Don't read from volume when reloading Wii banners
2015-12-15 18:48:49 +01:00
2990df3f59
Merge pull request #3265 from JosJuice/volumedirectory-simplifications
...
DiscIO: Small VolumeDirectory simplifications
2015-12-15 18:36:49 +01:00
25a584626f
Merge pull request #3127 from JosJuice/read-return
...
DiscIO: Improve error handling for reading integers
2015-12-15 18:16:40 +01:00
e4b83d17bf
Merge pull request #3270 from JosJuice/more-translations
...
Mark more strings for translation
2015-12-15 18:13:26 +01:00
cbfab2a754
DiscIO: Improve DiscScrubber::ReadFromVolume error handling
2015-12-14 10:01:38 +01:00
bd67333da9
DiscIO: Improve CBlobBigEndianReader error handling
2015-12-14 09:56:44 +01:00
c01265db34
DiscIO: Unify CBlobBigEndianReader
2015-12-14 09:38:23 +01:00
c7e747d775
DiscIO: Improve IVolume::Read32 error handling
...
Callers can now check whether reads fail, either by checking the return
value or by setting the buffer to a known bad value and seeing if it stays
untouched. I've added error checks to FileSystemGCWii and Boot_BS2Emu,
but not to Boot since it doesn't check any of its other reads either.
2015-12-14 09:38:21 +01:00
5a7e0aba70
Fix building with PCH disabled.
2015-12-08 16:57:37 -06:00
6295297ab3
DiscIO: Get rid of a few explicit deletes
2015-12-08 04:35:56 -05:00
edbbf493f8
DiscIO: Make factory methods return unique_ptrs
...
Rather than rely on the developer to do the right thing,
just make the default behavior safely deallocate resources.
If shared semantics are ever needed in the future, the
constructor that takes a unique_ptr for shared_ptr can
be used.
2015-12-07 05:57:37 -05:00
a0cd753060
Don't read from volume when reloading Wii banners
...
Should make loading cached Wii games that lack banners slightly faster.
2015-12-03 17:29:59 +01:00
f9af58a388
DiscIO: Don't use PlainFileReader in VolumeDirectory
...
Blobs are not for regular file reading.
2015-11-28 09:18:22 +01:00
941125699c
Added info for Rodea The Sky Soldier
2015-11-21 11:40:03 -05:00
74ea765427
Mark more strings for translation
2015-11-20 11:33:47 +01:00
584ea8b320
Merge pull request #3206 from JosJuice/limit-filesystem-size-2
...
Limit size of loaded file systems
2015-11-18 10:43:47 +01:00
3a9e382661
DiscIO: Small VolumeDirectory simplifications
2015-11-17 10:09:54 +01:00
eddea7f15f
Merge pull request #3181 from JosJuice/scrub-directories
...
Don't reserve space for directories when scrubbing
2015-11-17 10:37:09 +13:00
df79398445
DiscIO: drop unused stuff
2015-11-10 17:03:08 +01:00
6dce8b4deb
DiscScrubber: Add another nullptr check
2015-11-01 20:30:49 +01:00
6c25c63301
Limit size of loaded file systems
...
If a disc image is malformed in a specific way, Dolphin
will try to allocate a lot of memory, making it crash.
To avoid that, this change adds an artificial limit for
the size of file systems that Dolphin will try to load.
2015-10-28 21:47:19 +01:00
4d77d12f01
Remove length parameter from DiscScrubber::ReadFromVolume
...
The function only makes sense when the length is 4. All current callers
use the length 4, so this change doesn't affect any behavior.
2015-10-18 09:24:31 +02:00
618ccf6109
Remove DiscScrubber::GetDOLSize in favor of IFileSystem::GetBootDOLSize
...
IFileSystem::GetBootDOLSize acts the same. The only difference is that it
reads the DOL offset on its own, but this change makes that optional.
2015-10-17 20:52:26 +02:00
1ec9c6393a
Don't reserve space for directories when scrubbing
...
The offset in a directory FileInfo is an FST offset, not a disc offset.
Treating it as a disc offset doesn't make sense. Directories don't take
up space outside of the FST, so they don't need to be marked as used. The
old behavior may have prevented some scrubbable areas from being scrubbed.
2015-10-17 17:30:23 +02:00
05e339a605
Merge pull request #3139 from JosJuice/fix-wii-root
...
Mark which Wii root to use in the NAND path code
2015-10-16 16:49:34 +02:00
c22d1d68ab
Mark which Wii root to use in the NAND path code.
...
It's used by both the GUI to do things like install WADs and check up on
the system menu, in which case the global root should be used, and by
/dev/es, in which case the local one should. The latter isn't
*terribly* useful today, since no contents will ever be installed in
temporary roots (although it's still relevant for data directories), but
converting the whole thing makes sense because then it will Just Work
once the entire NAND is synced.
Because it would have been a bit of work to split it up (but I can if
desired), this commit also contains some basic cleanup of
NANDContentLoader:
(1) The useless interface class INANDContentLoader is removed and the
methods are changed to just return CNANDContentLoader (the only
implementation);
(2) CNANDContentManager is changed to use unique_ptr and cleaned up a
bit.
2015-10-16 09:10:39 +02:00
00aefa5e08
DolphinWX: decompress discs to calculate MD5 hash
2015-10-12 02:35:43 +02:00
efe71e686b
DiscIO: implement CISOBlob::GetDataSize()
...
This is a best-effort approach, since the CISO format does not save the
original file size.
2015-10-12 02:33:38 +02:00
1a8e2e16e3
DiscIO: implement WbfsBlob::GetDataSize()
2015-10-12 02:33:04 +02:00
a92b4bda95
DiscIO: fix reading the last sector in WBFS
...
Instead of rounding down, round up.
2015-10-12 02:31:51 +02:00
3a2efc9f4f
DiscIO: merge initial WBFS reads
2015-10-12 02:31:51 +02:00
f416106eec
DiscIO: pre-swap WLBA
2015-10-12 02:31:51 +02:00
b1100e4aa0
DiscIO: use std::min() in WBFS
2015-10-12 02:31:51 +02:00
5f181957b3
NANDContentLoader: Replace a string rbegin() call with a back() call
2015-10-07 09:47:26 -04:00
a6f04b0e15
Merge pull request #3091 from Tilka/mbedtls
...
Update mbed TLS (PolarSSL)
2015-10-03 18:00:58 -07:00
5464e698fc
Merge pull request #3102 from rohit-n/build-pch
...
Fix building with PCH disabled.
2015-10-03 13:30:51 -04:00
d5ec7124e4
Merge pull request #3099 from lioncash/banner
...
VolumeGC: Get rid of banner pointer casts
2015-09-29 03:49:08 +02:00
aaa48e19fe
Merge pull request #3097 from JosJuice/blob-type
...
Fix blob type detection for game right-click menu
2015-09-29 03:46:29 +02:00
3b75f45cf6
Fix building with PCH disabled.
2015-09-28 11:51:08 -05:00
7317dd4be2
VolumeGC: Get rid of banner pointer casts
...
Prefer reading the data into the reified struct instead.
2015-09-28 04:31:43 -04:00
be7e0554d2
DiscIO: Add a way to get blob type
2015-09-27 20:54:31 +02:00
ce493b897d
Merge pull request #2271 from revel8n/fixes
...
Fix for alignment of zero-length files within directory based virtual disk
2015-09-28 05:28:38 +13:00
34c020352f
Merge pull request #3092 from JosJuice/compressed-blobs
...
Display all compressed formats in blue in GUI
2015-09-27 12:57:19 +02:00
d4c2ca46a4
- Fix for alignment of 0-length files when volume directory is created from directory on disk
...
Updating constant value representation
Explicitly state data type in std:max usage
2015-09-26 18:29:29 -05:00
cc036ca86c
Common: Remove other Common prefixed headers from Common.h
2015-09-26 18:51:58 -04:00
19ac565e0d
Common: Move asserts to their own header
2015-09-26 18:51:27 -04:00
6935d28112
Display all compressed formats in blue in GUI
...
In the past, only GCZ was shown as compressed, not CISO and WBFS.
2015-09-26 15:24:29 +02:00
94ee720a07
Rename IsCompressedBlob to IsGCZBlob for clarity
...
GCZ is just one of the several compressed formats that Dolphin supports.
2015-09-26 14:46:53 +02:00
ac5f56df7e
mbedTLS: adapt Dolphin's Visual Studio files
2015-09-25 03:46:41 +02:00
063446c46f
mbedTLS: run rename.pl script and fix errors
2015-09-25 03:46:41 +02:00
4b9b82e000
DiscIO: Do swapping in GetTitleID implementations
...
Gets rid of external swaps at every usage.
2015-09-22 13:50:35 -04:00
113cc119de
Merge pull request #2829 from JosJuice/fix-wii-fst-size-2
...
Fix reading Wii FST size (for real this time)
2015-09-12 00:50:00 -04:00
19459e827f
Partially revert "General: Toss out PRI macro usage"
2015-09-11 09:49:00 -04:00
623df9b5ca
DiscIO/VS: Remove an empty filter
2015-09-06 13:23:33 -04:00
be4caa3dc0
Merge pull request #2961 from lioncash/printf
...
General: Toss out PRI macro usage
2015-09-06 21:02:22 +12:00
4a2e680ed2
VolumeGC: Initialize a variable
...
Silences an uninitialized variable warning
2015-09-05 23:05:28 -04:00
633be0387d
General: Remove unimplemented function prototypes
2015-09-05 22:01:07 -04:00
8fdb013d54
General: Toss out PRI macro usage
...
Now that VS supports more printf specifiers, these aren't necessary
2015-09-05 16:02:35 -04:00
aa7208e270
[windows] Update projects to vs2015.
2015-09-03 04:23:01 -07:00
222b33f0a3
VolumeCreator: Fix a typo in VolumeKeyForPartition's name
2015-08-31 20:01:51 -04:00
1db1a8aacf
VolumeCreator: Use a unique_ptr in CreateVolumeFromFilename
2015-08-31 20:01:44 -04:00
faedf1bc5c
Implemented .elf and .dol support in gamelist
...
Fixed a TON of structuring, formatting.
removed README.txt files from themes at MaJoR's request
Added platform icon for ELFs/DOLs
2015-08-28 11:10:03 -07:00
3469694b46
Merge pull request #2676 from Stevoisiak/SpellingCorrections
...
Minor spelling corrections
2015-08-15 18:36:56 +02:00
e0a47c11f5
Fix reading Wii FST size (for real this time)
...
04fcb72#2820 - the size must be shifted left by 2.
DiscScrubber and Boot already do this correctly using separate code.
2015-08-10 16:35:23 +02:00
7ee0e75633
Remove unnecessary virtual keywords
2015-07-30 10:33:08 -04:00
a12a4520d8
Merge pull request #2684 from TraceBullet/master
...
DiscIO: Check if m_Disc is null in ParsePartitionData()
2015-07-14 10:56:12 +10:00
dc25277a2f
Merge branch 'stable' into 'master'
2015-07-13 12:40:38 +12:00
9018b546c7
WbfsBlob: Don't enter an infinite loop when reading beyond end of disc
...
read_size remained 0 when the "Read beyond end of disc" error occurs,
which made the while (nbytes) loop never end. As a fix, SeekToCluster
now explicitly sets available to 0 when the error occurs, and Read
checks for it.
2015-07-06 15:41:37 +02:00
64bd20aba7
DiscIO: Check if m_Disc is null in ParsePartitionData()
2015-07-02 11:45:22 -04:00
7248f9b524
Minor spelling corrections
2015-06-29 14:51:21 -04:00
daa205990f
Use emplace() instead of insert() where applicable for maps.
2015-06-28 19:52:40 -04:00
156fb82117
Merge pull request #2620 from JosJuice/more-decodestring
...
Volume: Use DecodeString more
2015-06-18 14:57:10 +02:00
a825c7ddfe
Volume: Use DecodeString more
...
DecodeString handles the case where there is no trailing null byte,
so using it lets the code be a bit simpler.
2015-06-18 14:45:26 +02:00
fff81fecb1
Reinstate format string.
...
Avoid the consequences in the unlikely event the path includes a %.
2015-06-14 16:49:35 +10:00
ec0370d2d1
Volume: Add prefer_long parameter to GetNames
...
GC games with long names store two variations of the name in
opening.bnr. This makes the shorter of those names available.
For volumes other than GC discs, prefer_long is ignored.
2015-06-08 12:00:34 +02:00
a81d1c250a
Merge pull request #2512 from JosJuice/bnr-size-match
...
VolumeGC: Check that opening.bnr size matches type
2015-06-07 23:20:54 -04:00
0ed3118141
Volume: Return volume type as an enum
...
ISOFile and GameFile were using IsWiiDisc() and IsWadFile() to set
an enum value. The volume might as well return an enum directly.
I increased the Qt CACHE_REVISION because m_platform now is saved as u32
instead of int, but increasing the wx CACHE_REVISION is not necessary.
2015-06-04 16:26:36 +02:00
95a2abc1ce
Use PanicAlertT instead of PanicAlert when appropriate
...
I tried to change messages that contained instructions for users,
while avoiding messages that are so technical that most users
wouldn't understand them even if they were in the right language.
2015-06-04 13:25:06 +02:00
78b6ed0218
VolumeGC: Check that opening.bnr size matches type
...
The old code would accept files with BNR1 length and BNR2 type, which
can be a problem when GetNames tries to read the extra BNR2 strings.
2015-06-03 11:35:05 +02:00
349f9d5493
Merge pull request #2484 from JosJuice/volume-return-types
...
Volume: Use more appropriate types for some returned values
2015-06-02 20:29:08 -04:00
2ae6fb9240
Merge pull request #2338 from JosJuice/getfilelist-return
...
Filesystem: Return file list reference instead of modifying argument
2015-06-02 20:28:25 -04:00
a3b3f0522b
Merge pull request #1556 from comex/project-moration
...
Rudimentary version of Wii IPC determinism. Ported from my old udpnet branch.
2015-06-02 18:38:19 -04:00
301218a103
Volume: Use more appropriate types for some returned values
...
Disc number is changed from bool to u8, and revision is changed from
int to u16 (WADs can use all 16 bits, but discs can only use 8 bits).
2015-05-29 21:14:02 +02:00
9a000f4085
Volume: Mark ReadWiiNames parameter as const
...
I forgot it when I added the method.
2015-05-29 20:19:11 +02:00
ac26f8e79f
Pass strings by const reference where possible
2015-05-28 20:54:55 -04:00
dc91e8b607
Add a mode to use a dummy Wii NAND.
...
Eventually, netplay will be able to use the host's NAND, but this could
still be useful in some cases; for TAS it definitely makes sense to have
a way to avoid using any preexisting NAND.
In terms of implementation: remove D_WIIUSER_IDX, which was just WIIROOT
+ "/", as well as some other indices which are pointless to have as
separate variables rather than just using the actual path (fixed, since
they're actual Wii NAND paths) at the call site. Then split off
D_SESSION_WIIROOT_IDX, which can point to the dummy NAND directory, from
D_WIIROOT_IDX, which always points to the "real" one the user
configured.
2015-05-28 19:14:42 -04:00
a225426510
Rewrite FileSearch and improve ScanDirectoryTree.
...
- FileSearch is now just one function, and it converts the original glob
into a regex on all platforms rather than relying on native Windows
pattern matching on there and a complete hack elsewhere. It now
supports recursion out of the box rather than manually expanding
into a full list of directories in multiple call sites.
- This adds a GCC >= 4.9 dependency due to older versions having
outright broken <regex>. MSVC is fine with it.
- ScanDirectoryTree returns the parent entry rather than filling parts
of it in via reference. The count is now stored in the entry like it
was for subdirectories.
- .glsl file search is now done with DoFileSearch.
- IOCTLV_READ_DIR now uses ScanDirectoryTree directly and sorts the
results after replacements for better determinism.
2015-05-28 19:14:42 -04:00
5911dd528a
Merge pull request #2361 from JosJuice/filesystem-read32
...
Remove CFileSystemGCWii::Read32
2015-05-25 23:40:28 -04:00
4ba430951a
Merge pull request #2439 from JosJuice/company-from-id
...
Use an ID-to-name map when volume has no company string
2015-05-25 23:32:55 -04:00
1d6375b71f
Merge pull request #2339 from JosJuice/fix-wii-fst-size
...
Fix reading Wii FST size
2015-05-25 23:27:25 -04:00
30ebb2459e
Set copyright year to when a file was created
2015-05-25 13:22:31 +02:00
cefcb0ace9
Update license headers to GPLv2+
2015-05-25 13:22:31 +02:00
d2e6adb045
Use an ID-to-name map when volume has no company string
...
This is written so that the result of GetCompanyFromID never is cached
(except on Android?). Caching is unnecessary because the string can be
obtained quickly at runtime, and not caching it means that the cache
doesn't have to be invalidated when GetCompanyFromID is edited.
2015-05-24 17:41:53 +02:00
383b104af0
WiiWad: Use correct form of delete for arrays
2015-05-22 17:52:54 -04:00
bad09fc358
Volume: Rename GetName to GetInternalName
...
This is intended to better separate it from GetNames and to clarify
that this name originally wasn't meant to be shown to users.
The ISOProperties GUI is also updated, mainly because labeling
the long banner name "short name" was confusing.
2015-05-11 11:19:30 +02:00
2d5d5fa83e
Read opening.bnr to get names from Wii discs
...
This makes Dolphin display the same names as the Disc Channel.
2015-05-03 15:58:35 +02:00
272f9d3cbc
FileSystemGCWii: Allow reading files partially
2015-05-03 15:44:24 +02:00
0d9ca081bb
Remove CFileSystemGCWii::Read32
...
A function that does the same thing was added to IVolume in 4cd00e3
2015-05-03 11:39:20 +02:00
ee694e327a
Get rid of banner loaders and move their functionality to volumes
...
Having some data available in banner loaders and some other data
data available in volumes gets messy, especially with GetNames(),
which is available in both but returns different results
depending on which one is used. This change drops support
for reading names and descriptions from Wii save data.
2015-04-28 23:44:29 +02:00
04fcb72e0b
Fix reading Wii FST size
2015-04-28 17:20:33 +02:00
d43a920924
Filesystem: Return file list reference instead of modifying argument
2015-04-28 12:48:05 +02:00
235ecfbed7
Return GetNames languages, to avoid hardcoded language lists in callers
...
This makes the code cleaner and also leads to some user-visible changes:
The wx game properties will no longer let the user
select WAD languages that don't have any names.
The Qt game list will now display names using the languages
set in the configuration instead of always using
English for PAL GC games and Japanese for WADs.
If a WAD doesn't have a name in the user's preferred language,
English is now selected as a fallback before Japanese.
2015-04-23 08:14:39 +02:00
f5c72c5b1a
DiscIO: Add a missing header to Volume.h
2015-04-20 21:10:31 -04:00
571eee8648
Merge pull request #2225 from JosJuice/remove-volumehandler
...
Get rid of VolumeHandler
2015-04-21 11:18:57 +12:00
7c1ab2911a
Move down Country_World
...
The countries are sorted alphabetically. This should have been changed
when the variable was renamed from Country_International to
Country_World
2015-04-08 18:55:16 -04:00
4cd00e366c
Get rid of VolumeHandler
...
VolumeHandler is basically just a wrapper around a single IVolume object.
This change moves that object to DVDInterface, moves the Read32
function to IVolume, and gets rid of the rest of VolumeHandler.
2015-04-05 10:09:48 +02:00
9387603fcf
Improve error handling in DiscIO::CompressFileToBlob and DecompressBlobToFile
2015-03-17 09:01:26 +01:00
66bb3000c2
Don't construct NANDContentLoader classes before Main.cpp runs
...
The cUIDsys constructor writes to <Wii user path>/sys/uid.sys.
This must not be done before Main.cpp sets the correct user paths.
2015-03-09 16:08:32 +01:00
b7514955e5
Merge pull request #2113 from Stevoisiak/VolumeCleanup
...
Basic volume code cleanup
2015-03-05 12:18:53 -05:00
96c4b332f6
FileMonitor: Check log level in addition to FileMonitor checkbox
...
This is good for performance when FileMontior is selected
but the log level only is set to notice or warning.
The ability to do this wasn't available until recently:
1ed41672f5
2015-03-03 11:33:16 +01:00
492aa5c391
DiscIO: Get rid of unsafe cast
2015-02-28 22:03:53 -05:00
5346e791bc
VolumeWad: change titlever to title_version
2015-02-28 21:42:16 -05:00
eff924e9e2
General Formatting
2015-02-28 19:33:27 -05:00
ede4977d12
VolumeWiiCrypted: Implement IsDiscTwo()
...
Allows us to check if a Wii game is marked as Disc 2.
2015-02-26 17:10:18 -05:00
f72a559958
Rearranged Volume header files
2015-02-26 16:57:32 -05:00
06cb85991e
De-capitalized CountryCode
2015-02-26 16:57:31 -05:00
df2f6d137e
VolumeWad: Move country identification to GetCountry()
...
Brings the code more in line with the rest of the game volume code
2015-02-26 16:55:17 -05:00
d3190ec4f1
VolumeWad: Private variables for offset values
2015-02-26 16:55:16 -05:00
793abccb5e
Merge pull request #1942 from Buddybenj/No-Intro
...
Replace Country Names With No-Intro Names
2015-02-23 12:56:28 +11:00
95c48b2be7
Merge pull request #2018 from JosJuice/gameini-region-wildcard
...
Support game INIs that match all regions
2015-02-21 15:47:57 +01:00
265a21a565
Replace Country Names With No-Intro Names
2015-02-17 18:50:10 -06:00
61b19bda3e
Merge pull request #2042 from unknownbrackets/gcz-fix
...
DiscIO: On decompress to file, write last blocks correctly
2015-02-14 13:46:06 +11:00
4ceae57713
Merge pull request #2015 from Stevoisiak/WAD-Version-Check
...
VolumeWad: Return version number for WADs
2015-02-13 22:09:30 +01:00
df5857b5af
DiscIO: On decompress to file, write last blocks.
2015-02-12 20:30:11 -08:00
e186104960
Don't use revision-specific unique ID strings outside of CoreParameter
2015-02-11 19:01:04 +01:00
0f96a0104e
Merge pull request #1752 from Buddybenj/clean-up
...
Clean Up
2015-02-10 11:39:14 -08:00
28b441ebea
VolumeWiiCrypted: Replace some hardcoded values with constants
2015-02-08 10:31:17 +01:00
b578abfbaa
VolumeWad: Return version number for WADs
2015-02-05 11:27:57 -05:00
521ccd7b44
VolumeWiiCrypted: Decryption optimization
...
The block doesn't have to be read if it already is in m_pBuffer.
2015-01-26 15:59:25 +01:00
4f324ad742
Clean Up
2015-01-24 17:10:21 -06:00
80e6367e46
Merge pull request #1869 from Stevoisiak/GeneralConsistency
...
Minor consistency changes
2015-01-21 13:46:53 -06:00
f9fc9d47c0
Merge pull request #1895 from JosJuice/isvolumewiidisc
...
Don't read from disk when checking volume type
2015-01-21 13:45:28 -06:00
6f61f90dab
Merge pull request #1777 from JosJuice/filemonitor-volumedirectory
...
Add FileMonitor support for VolumeDirectory
2015-01-20 12:32:42 +11:00
ace060748b
Don't read from disk when checking volume type
...
Should be faster than relying on the OS to cache the magic words.
Also gets rid of the odd recursive call in VolumeDirectory.
2015-01-17 13:21:02 +01:00
f31b688cf5
More minor consistency changes
2015-01-12 22:28:12 -05:00
b3474c8218
Merge pull request #1796 from Stevoisiak/cacheRevisionNote
...
Added CACHE_REVISION warnings
2015-01-13 08:36:50 +13:00
e3e290123b
Fix compiler error for win64 (SFileInfo doesn't get used much so a copy won't kill us)
2015-01-11 15:59:50 -08:00
8ee601d32b
Fix variable name ambiguity
2015-01-11 13:54:20 -08:00
9e541f6d2d
Reduce number of allocations in CFileSystemGCWii::BuildFilenames
...
Modify SFileInfo to use a default move constructor, and no copy constructor.
Modify SFileInfo to use member initializers.
2015-01-11 13:42:50 -08:00
fe49427688
Additional CACHE_REVISION increment warnings
...
GameFile.cpp warnings for DolphinQt,
ISOFile.cpp warnings for DolphinWX
2015-01-11 00:25:36 -05:00
358183e34a
Fix 4.0-4901 VolumeDirectory stack overflow
...
I actually fixed this once, but then I broke it in a
failed attempt to optimize. VolumeHandler::IsWii calls
CVolumeDirectory::Read(0x18, 4, &MagicWord, false);
2015-01-09 22:50:07 +01:00
3738d27b24
Merge pull request #1776 from JosJuice/cleanrip-wii-discs
...
Fix CleanRip reading Wii discs
2015-01-03 10:42:51 +11:00
2e1d8d7ac0
Added identifier for country code 'B'
...
Only used by the American version of Ufouria: The Saga
2014-12-30 19:57:14 -05:00
bb93336ecf
DiscIO: Replace "raw" functions with "decrypt" parameters
...
This is intended to make decryption look less implicit in the code.
2014-12-28 10:35:48 +01:00
7f04a23e23
Add FileMonitor support for VolumeDirectory
2014-12-27 20:13:31 +01:00
72f8f243c7
Never decrypt data when using DI command 0xA8
...
CleanRip relies on this when ripping Wii discs.
2014-12-27 13:49:25 +01:00
1618d31523
FileMonitor: Get rid of "GC" from names and comments
2014-12-25 11:12:04 +01:00
8624461315
Re-add FileMonitor support for Wii discs
...
This in done in the same way as GC discs, unlike the previous implementation.
2014-12-25 11:01:18 +01:00
467b3e6baf
DiscIO: Clear error status when reading file
2014-12-14 13:16:21 +01:00
f14f0caea6
DiscIO: Remove some explicit deletes
2014-12-04 11:39:20 -05:00
b9b3277fb5
Merge pull request #1618 from JosJuice/dvd-low-open-partition
...
Fix Wii disc partitions
2014-12-03 21:24:56 +11:00
a2566bd397
DiscIO: Safety check when allocating memory for TMD
2014-12-03 10:54:09 +01:00
4bb48d09dd
DiskIO: Clean up GetTMD() API.
2014-11-30 16:38:13 +01:00
b1df4e5986
Make DVDLowOpenPartition actually change partitions.
2014-11-30 16:01:05 +01:00
815b7bec96
DiscIO: Change a memset() to zero initialization.
2014-11-27 11:12:17 -08:00
f54bf81520
DiscIO: Avoid zeroing buffer when compressing gcz.
...
This saves 6% time.
2014-11-27 08:58:09 -08:00
2635e7d9ea
DiscIO: Decompress to file using a larger buffer.
...
This improves performance by around 20% for me, and the memory use impact
is negligible considering Dolphin is otherwise unusable.
2014-11-27 08:34:44 -08:00
f2f83a0c60
DolphinWX: Allow cancelling gcz compression.
2014-11-27 07:53:28 -08:00
6da394a4d0
More formatting and consistency fixes
2014-11-24 17:16:59 -05:00
695bbac36a
Removed SDK flag
...
SDK is not an official Nintendo country code, and is not actually used
by any official software.
2014-11-18 19:44:17 -05:00
f1a26ff654
Various country flag improvements
...
* Added country flags for games from Netherlands and Spain
* Added separate category for Region Free games (Uses European flag as placeholder)
* Added missing country filter options in "show regions" menu
* Rearranged country filters for readability
* Incremented CACHE_REVISION
Also fixed various country filters not showing up as options in the "Show regions" menu.
2014-11-18 19:44:16 -05:00
fa18518cef
Fix reading wii revisions.
2014-11-15 00:39:54 -05:00
fa5e3ec292
Implement GetRevision() for wii disks.
2014-11-14 21:06:26 -05:00
b25e1a2eb4
Various formatting and consistency fixes
2014-11-13 22:42:18 -05:00
7747c9efbb
Merge pull request #1429 from lioncash/concat
...
FileSystemGCWii: Shorten some string concatenations
2014-10-28 23:38:58 -04:00
3247f28048
Merge pull request #1430 from lioncash/voldir
...
VolumeDirectory: Pass std::string by reference for SetUniqueID/SetName
2014-10-28 23:38:21 -04:00
00620ea729
Added flags for Russia and Australia
2014-10-28 23:04:24 -04:00
56bc58b9f4
VolumeDirectory: Pass std::string by reference for SetUniqueID/SetName
2014-10-28 14:18:54 -04:00
d1d70c1a7d
FileSystemGCWii: Shorten some string concatenations
...
Just does it all on one line instead.
2014-10-28 13:41:42 -04:00
00b3cc3b09
VolumeCreator: Make master key arrays static
...
Only used within this translation unit.
2014-10-12 15:07:39 -04:00
6cfa579870
VolumeGC: Use regular return type declaration for GetStringDecoder
2014-10-07 21:15:14 -04:00
46057db37d
Fix build failing when disabling precompiled headers.
2014-09-19 18:17:51 -04:00
4db2af2d42
DiscIO: Remove unnecessary break statements.
2014-09-12 11:34:34 -04:00
4cb25633e1
Merge pull request #1048 from lioncash/discio
...
DiscIO: Minor changes to VolumeDirectory.
2014-09-12 11:31:29 +10:00
b06ec302d1
Remove some unnecessary semicolons
2014-09-11 13:05:31 -04:00
9601f5ec5f
DiscIO: Get rid of some casts and a c_str call in VolumeDirectory
2014-09-09 19:01:20 -04:00
b34f2a78f5
DiscIO: Simplify GetUniqueID in VolumeDirectory
2014-09-09 18:57:45 -04:00
fbc64984ca
Include CommonTypes.h instead of Common.h.
2014-09-08 15:39:58 -04:00
9302218a19
Merge pull request #851 from lioncash/logg
...
Common: Kill off duplicate log warning definitions
2014-09-06 12:35:19 -07:00
690ed8580c
Common: Kill off duplicate log warning definitions
...
Also embed the log checks rather than using macros
2014-09-06 15:11:29 -04:00
cf8d1c9197
FileHandlerARC: Remove FileHandlerARC.
2014-09-05 12:53:41 -04:00
a3d9b22c27
BannerLoaderWii: Removed #if 0'd code.
2014-09-05 12:52:29 -04:00
532b7bb7da
Merge pull request #893 from rohitnirmal/scan-build-fixes
...
Scan build fixes
2014-09-02 23:15:18 -07:00
266992684d
msvc: remove some remnants of SDL and DSound from projects and general cleanup.
2014-09-01 21:27:44 -07:00
1977ea42ae
DiscIO: Prefix class member variables with "m_"
2014-09-01 15:48:02 -04:00
4cb46879bc
DiscIO: Move some raw pointers over to unique_ptr
2014-08-31 14:48:57 -04:00
55a0034dd5
DiscIO: Clean up brace placements
2014-08-30 18:06:43 -04:00
77aef014a0
Merge pull request #909 from lioncash/void
...
Get rid of C-style empty function parameter indicators
2014-08-30 15:28:47 -04:00
1d706b2311
Get rid of C-style empty function parameter indicators
2014-08-30 15:23:48 -04:00
cee3362e33
DiscIO: Get rid of unnecessary struct differencing
2014-08-29 20:07:55 -04:00
6955e023a0
Merge pull request #877 from lioncash/voldir
...
DiscIO: Move VolumeDirectory off of raw pointers
2014-08-28 04:11:33 -04:00
9e340b1c81
Initialize variables to silence garbage return warning from scan-build.
2014-08-27 20:35:20 -05:00
5082afa670
DiscIO: Move VolumeDirectory off of raw pointers
2014-08-26 00:23:16 -04:00
f18fec81fe
DiscIO: Make the unordered set in IsSoundFile static
...
Doesn't need to be instantiated every time the function is called.
2014-08-25 19:56:09 -04:00
f1b82a34b2
Windows: Use a shared precompiled header for dolphin code under Source/
2014-08-14 23:51:13 -07:00
4fa71dd59e
Remove fakepoll.h.
...
It was only used for Windows XP and lower.
This also bumps the _WIN32_WINNT define in the stdafx precompiled headers to set the minimum version as Windows Vista.
2014-07-26 22:53:40 -04:00
d4a2afe345
Fix another protential issue with casting.
...
Another issue from #334 with the casting moved from the output of
min to it's inputs.
This is a non-issue on 64 bit machines, but if dolphin is compiled
on an OS with size_t == u32 (say ARM) then remainingSize could be
truncated.
Restored the casting to the original order before #334 .
2014-07-15 01:38:05 +12:00
6d3f249dcc
mark all local variables as static
2014-07-11 16:10:20 +02:00
22e1aa5bb4
mark all local functions as static
2014-07-11 16:07:23 +02:00
d3fa8a6167
Reorder class initializer lists
2014-07-04 03:53:22 +02:00
0332d4d76f
Merge pull request #539 from jordan-woyak/fix-extract-directory
...
Fix ISO Directory extraction.
2014-06-29 21:35:46 -04:00
f78b94077e
DiscIO: Centralize the banner pointer and validity boolean into IBannerLoader
...
These are both used within the banner loaders, and IsValid is exactly the
same. So this makes sense.
2014-06-29 15:40:18 -04:00
d800b5fb74
DiscIO: Fix extra tabs in the banner loader headers
2014-06-29 15:31:44 -04:00
3805c4967f
Fix ISO Directory extraction.
2014-06-29 14:22:06 -05:00
ca5340ebde
Centralize the logging code into its own folder in Common.
2014-06-25 22:11:42 -04:00
8b13afbb8e
Remove the 32-bit config platform from the VS solution and projects
2014-06-24 22:07:26 -04:00
ce54c1e571
Kill off replaceable usages of s[n]printf.
2014-06-18 19:53:38 -04:00
5d793881b0
Fix the capitalization of "GameCube" throughout the project.
2014-06-08 11:24:49 +09:00
49b0eef393
Remove the min/max functions in CommonFuncs.
...
The algorithm header has the same functions.
2014-05-29 21:44:41 -04:00
664c8d30a0
Remove all trailing whitespaces from our codebase.
2014-03-29 11:05:44 +01:00
5310d6d2ea
Fix a crash that got recently introduced.
...
When CFileSystemGCWii::GetFileName can't find a valid filename it would return nullptr.
nullptr as a std::string throws an assert within the std lib.
So return an empty string and check if it is empty or not
2014-03-23 22:29:30 -05:00
bd1ce18f90
Simplify file tree building for the filesystem view.
...
Technically this also simplifies on disc filename building in general.
2014-03-16 16:54:00 -04:00
f325fc9634
Clean up FileHandlerARC.cpp/.h
...
- Removed parentheses from the returns.
- Put the function declaration headers back on a single line.
- Make FindFileInfo's parameter a const string reference.
2014-03-15 02:14:49 -04:00
a82675b7d5
Kill off some usages of c_str.
...
Also changes some function params, but this is ok.
Some simplifications were also able to be made (ie. killing off strcmps with ==, etc).
2014-03-14 13:51:23 -04:00
31cfc73a09
Fixes spacing for "for", "while", "switch" and "if"
...
Also moved && and || to ends of lines instead of start.
Fixed misc vertical alignments and some { needed newlining.
2014-03-11 00:35:07 +13:00
e05eca71ea
Merge pull request #149 from lioncash/filemonitor-song-types
...
Add more sound file extensions to FileMonitor's IsSoundFile.
2014-03-10 13:45:23 +13:00
d802d39281
clang-modernize -use-nullptr
...
and s/\bNULL\b/nullptr/g for *.cpp/h/mm files not compiled on my machine
2014-03-09 21:14:26 +01:00
f28116b7da
clang-modernize -add-override
2014-03-09 21:12:01 +01:00
c89f04a7c5
clang-modernize -loop-convert
...
and some manual adjustments
2014-03-09 21:11:59 +01:00
b027c4d64e
Add more sound file extensions to FileMonitor's IsSoundFile.
2014-03-09 12:46:01 -04:00
2c8b9735ae
Add two other formats to the list of extensions in IsSoundFile
...
.adx is used in various games, so this should definitely be here.
2014-03-04 08:57:07 -05:00
f39c757edf
Simplify ShowSound() in FileMonitor.cpp.
...
Now if more sound types are found, they just need to simply be added to
the unordered set.
- Also changed ShowSound() to IsSoundFile()
- Fixed IsSoundFile’s definition in FileMonitor.h. This whole time it
has been defined as a void method, when in reality it was a bool
function.
- Changed the FileMonitor’s string parameters to be constant references.
2014-03-04 08:39:25 -05:00
315a8ba1c0
Various changes suggested by cppcheck
...
- remove unused variables
- reduce the scope where it makes sense
- correct limits (did you know that strcat()'s last parameter does not
include the \0 that is always added?)
- set some free()'d pointers to NULL
2014-02-28 12:43:20 +01:00
6914eca167
Fix various warnings reported by clang
...
- mostly remove unused variables
- rename some generic JIT identifiers
2014-02-28 12:28:19 +01:00
c698c07755
Make DiscIO/ mostly IWYU clean (and fix errors in rest of the project detected by this change).
2014-02-22 23:37:29 +01:00
8ea8da6ebc
Fix more header sorting issues in DiscIO/ (now check-includes clean).
2014-02-20 01:01:10 +01:00
2afe215271
Convert all includes to relative paths.
2014-02-18 02:19:10 -05:00
3fd87a7636
Second and final pass of clearing out tabs.
2014-02-17 02:19:41 -05:00
6c4ee1753a
Fix some vertical alignments
...
ie. uses spaces for alignment.
2014-02-16 20:12:05 -05:00
d6f6672522
Kill auto usage in CISOBlob.cpp per request.
2014-02-13 16:09:58 -06:00
cec8ac20fc
Fixed issue 7020. CISO >4GB failure. Caused by integer overflow.
2014-02-13 15:47:42 -06:00
404624bf0b
Turn loops into range-based form
...
and some things suggested by cppcheck and compiler warnings.
2014-02-13 09:05:50 +01:00
d2038049f5
Replace all include guard ifdefs with "#pragma once"
2014-02-10 18:07:16 -05:00
32bfcc034f
Some tidy up of sprintf to StringFromFormat
...
Includes a small fix to SetupWiiMemory
2014-02-10 17:25:18 +13:00
40182a48a5
Cleanup enum indentations.
2014-02-09 16:16:10 -05:00
e59f770ccb
Revert "Merge pull request #49 from Parlane/sprintf_tidy"
...
Change broke the build on Debian stable.
This reverts commit 28755439b364e01ec763
2014-02-09 16:14:13 +01:00
ebff7974c3
Some tidy up of sprintf to StringFromFormat
2014-02-08 14:32:48 +13:00
34692ab826
Remove unnecessary Src/ folders
2013-12-31 14:03:19 -05:00
43e618682e
Convert all vcxproj files to UNIX line endings
2013-12-31 14:03:18 -05:00
c405d92c41
fixed issue 6852.
2013-12-07 16:07:47 +09:00
4867937355
Add Read16/Read8 to the CBlobBigEndianReader so the key check is reading 8bit from the correct location to determin which key to use. Also change check to == 1 as suggested in the IRC channel on first implementation. Potentially fixes 6852.
2013-12-06 20:40:12 -06:00
268bdf19ce
Fix format string warnings
2013-11-13 04:01:16 +01:00
68ba0f7f4e
Add a comment to the magic value reading location.
2013-11-11 17:17:49 +00:00
22fef0da9b
Fixed a bug that incorrectly recognized as 'GameCube'. when you open the Korean Wii Disc, which is re-encrypted with a common-key(g_MasterKey).
2013-11-12 01:05:30 +09:00
e15f628935
Fix {Read,Write}FileToString.
...
We should be using binary always.
2013-11-05 00:33:41 +13:00
21610c2e54
Run code through clang-modernize -add-override to add 'override' decls.
2013-11-03 20:54:05 -05:00
c579637eaf
Run code through the advanced tool 'sed' to remove trailing whitespace.
2013-11-03 20:54:05 -05:00
965b32be9c
Run code through clang-modernize -loop-convert to create range-based for loops, and manually fix some stuff up.
2013-11-03 20:54:01 -05:00
82729fcc8f
Merge remote-tracking branch 'shuffle2/vc12'
...
Conflicts:
Source/Core/Common/Common.vcxproj
Source/Core/Common/Common.vcxproj.filters
2013-10-31 16:51:56 -04:00
8e73e8ae5f
Wipe all traces of OpenSSL's AES implementation. Use polarssl instead.
2013-10-27 18:27:07 +00:00
ccd30024b3
Update to VS2013 and a slew of build-related updates. Notes:
...
* Currently there is no DEBUGFAST configuration. Defining DEBUGFAST as a preprocessor definition in Base.props (or a global header) enables it for now, pending a better method. This was done to make managing the build harder to screw up. However it may not even be an issue anymore with the new .props usage.
* D3DX11SaveTextureToFile usage is dropped and not replaced.
* If you have $(DXSDK_DIR) in your global property sheets (Microsoft.Cpp.$(PlatformName).user), you need to remove it. The build will error out with a message if it's configured incorrectly.
* If you are on Windows 8 or above, you no longer need the June 2010 DirectX SDK installed to build dolphin. If you are in this situation, it is still required if you want your built binaries to be able to use XAudio2 and XInput on previous Windows versions.
* GLew updated to 1.10.0
* compiler switches added: /volatile:iso, /d2Zi+
* LTCG available via msbuild property: DolphinRelease
* SDL updated to 2.0.0
* All Externals (excl. OpenAL and SDL) are built from source.
* Now uses STL version of std::{mutex,condition_variable,thread}
* Now uses Build as root directory for *all* intermediate files
* Binary directory is populated as post-build msbuild action
* .gitignore is simplified
* UnitTests project is no longer compiled
2013-10-26 17:55:38 -07:00
207547b425
Clean up includes in DiscIO as much as possible.
...
Also turned a long iterator declaration in VolumeDirectory.cpp to using auto in order to shorten it.
2013-10-19 19:59:02 -04:00
82fd579506
Remove unnecessary include of "../../Core/Src/ConfigManager.h" from BannerLoaderGC.cpp. In actuality, all that was needed here was an include of CommonTypes.h.
...
Also change Common.h to CommonTypes in BannerLoaderWii.cpp.
2013-10-19 19:59:01 -04:00
de1773affb
Basic precompiled header support for Linux/OS X. Shaves 20-30% off full rebuild time on my system.
2013-10-17 00:07:35 -04:00
1ec4894bc5
[Common] Abstract out the decode5A3Image and decodeCI8Image functions in BannerLoaderGC, BannerLoaderWii, and GCMemcard into ColorUtil.cpp. Makes for less copied code and remains functionally the same.
2013-10-02 18:18:54 -04:00
f57ff0a569
Support a gcm revision-specific game ini for cheats + partially fix gecko codes in default ini.
...
The local ini is not revision-specific because it would require renaming
everything. Meh.
2013-09-28 23:38:25 -04:00
bea76ac129
No need to std::move a return value. Thanks Billiard.
2013-09-26 21:15:35 -04:00
18abc33306
2x banner images!
2013-09-25 03:06:27 -04:00
5d202ae9ea
proper fix for issue 6206
2013-09-14 15:09:58 -07:00
4f5729dd59
MSVC warnings.
2013-09-01 22:59:32 -04:00
fd7cf5bb71
A bunch of trivial changes to fix clang warnings.
2013-09-01 22:58:33 -04:00
5209abeb03
Better error reporting for ES / NANDContentLoader.
2013-08-31 23:49:29 -04:00
04c41c1d38
Fix loading DLC using IOCTL_ES_OPENTITLECONTENT & /dev/es state save.
...
(Intertwined enough that's it's easier to do in one patch.)
(1) /dev/es did not support state save, which could cause crashes and
incorrect behavior after loading.
(2) NANDContentLoader tried to read all of a title's contents into
memory when it was first opened. Two issues:
- If any contents were missing, it bailed out. However, with DLC,
only some of the contents may be downloaded, as determined by the
permission bits in the ticket. Instead, return an appropriate error
when a content is accessed that doesn't exist on the filesystem
(don't bother checking the permission bits though).
- Everything was loaded into memory - even if it consisted of 3 GB of
songs, which caused Dolphin to lag out for quite a while (and would
fail on 32-bit). Instead, open content on demand.
2013-08-31 01:38:52 -04:00
59e060aba2
Missed some VS build options.
2013-08-16 21:42:31 +12:00
d6ec6ae97a
Fix polarssl on Windows.
2013-08-16 00:24:10 +12:00
d8b39b9dcf
Support PolarSSL on *nix
...
Removed unneeded PolarSSL directories.
Remove duplicate sha1 and md5 files.
Define out SSL test file writing.
Fix format string bug and warning.
2013-08-15 23:36:17 +12:00
d244bca1f5
Fix a bunch of random typos in comments and logging.
...
Also update the comment headers for two functions in GCMemcard.cpp.
2013-04-19 09:21:45 -04:00
bab9963b00
New license header introduced for DiscIO, AudioCommon, InputCommon, VideoCommon, and Common projects.
2013-04-17 23:09:55 -04:00
1e6dacf1e4
Make dolphin aware of disc revision numbers. Display them under game properties and use them in netplay.
...
Patch by johnwchadwick.
Fixed issue 6243.
2013-04-16 22:39:05 -05:00
2316cb6876
Remove all tab/space mismatches from the Core project. For anyone working on a branch that heavily involves the core, I am so sorry.
...
- Also killed off some trailing spaces/tabs.
- Updated the license header to be consistent with the rest of the project (All projects are now done moving over to this)
- Also, killed some dangling else's (where appropriate)
Now all the tab fixing is done. No more of this crap should be needed to be pushed. Rejoice!
2013-04-16 23:14:36 -04:00
ef85b9af45
Update the license file text (change SVN to Git) in all projects except Core since I was told a merge was happening soon. So for the sake of the merge going smoothly, I'll fix that when I remove the tab/space mismatches from the Core project.
...
Also, some tab/space mismatches removed from VideoOGL, and some places I missed in VideoDX[number] projects.
Now, the Core is literally the only project with tab/space mismatches (on a large scale).
2013-04-15 16:28:55 -04:00
385d8e2b15
ChunkFile has allowed me to accidentally "Do" a non-POD for the last time!
2013-04-09 19:02:22 -05:00
98d35e590e
Fixed split WBFS file size display. (probably)
...
Fixed issue 6222.
2013-04-09 12:58:56 -05:00
f432d6038e
Fix some typos and correct some capitalizations in the log messages.
...
Makes the logging look more orderly and less spammy when spitting out things.
2013-03-31 19:13:30 -04:00
0e3d8e2e9f
Clean up some space/tab mismatches in DiscIO and InputCommon.
...
Keeps the files consistent.
2013-03-19 09:59:41 -04:00
279e3c7e14
Fix a potential memory leak in function DecompressBlobToFile in CompressedBlob.cpp
2013-03-07 10:59:50 -05:00
33a13b1a37
Fixed issue 5270. Don't ask me how, I just clean up code and then it works! I think it was int overflow.
2013-03-05 00:35:24 -06:00
6b2818199c
Fix WAD volume name extracting.
2013-03-03 19:00:29 -06:00
c07b8a6e37
Fix more of what I broke.
2013-03-03 17:08:41 -06:00
aeb4fc9846
Fix what I broke.
2013-03-03 02:12:24 -06:00
6c8adf6130
Eliminate the wstring game name.
...
Some cleanup throughout related code. (try to make logic in ISOFile understandable by a human)
Encode strings in UTF-8 rather than somehow trying to determine the encoding in the GUI code.
Non-windows OSes temporarily broken.
2013-03-02 20:00:36 -06:00
2b1af36900
Merge branch 'master' into windows-unicode
2013-03-02 15:33:32 -06:00
e079d24912
Kill wstring version of game description.
2013-03-01 22:45:10 -06:00
99cf57eb39
Fixes two memory leaks, one is pretty bad for OSX.
...
Yell at pauldachz if this doesn't work.
Or... say thanks.
2013-03-01 19:21:34 +13:00
536c110b31
Fix "DiscIO" to build with "Unicode".
2013-02-27 20:04:07 -06:00
717b976875
ARM Support without GLSL
2013-02-26 13:49:00 -06:00
bf4be1d8d1
Change some CNANDContentLoader logic to what was probably intended. Kills some warn logs when opening Dolphin.
2013-02-17 01:57:25 -06:00
f7fa33f2d6
Fix remaining compiler warnings.
2013-01-31 15:29:29 -06:00
0ffdd2607f
Fix the majority of the compiler warnings unearthed by the addition of
...
the new warning flags.
2013-01-29 23:24:51 -06:00
1e006b5b99
Better implementation of revision 2cc1a97a66. Works with .gcz files now.
2013-01-25 21:28:04 -05:00
7e5d877858
Merge branch 'ES_LAUNCH'
...
Games that are now playable:
Back to the Future: The Game
CSI - Hard Evidence
CSI - Deadly Intent
CSI - Fatal Conspiracy
Red Steel
Metroid Prime: Trilogy
Wii Sports + Wii Sports Resort pack
Sam & Max: Season One
Sam & Max: Beyond Time and Space
Kirby's Dream Collection: Classic Collection
Indiana Jones and the Staff of Kings: Fate of Atlantis
* ES_LAUNCH:
Fixed SSBB from starting at the mini-games screen.
Build fix
Corrected a state bug where newly loaded dols did not have their patches applied.
Changed the HLE system to allow it to hook the beginning, the end or replace the entire function without changing the GC memory. Fixes Kirby's Return to Dreamland. Added a way to categorise the type of HLE function. Currently, there are debug, floating point, memory and generic functions. Added a HLE function for OSGetResetCode (Warm reset). Fixes the CSI games. Added a switch to disable all of the HLE functions if the idle skipping option is disabled.
Added some IOS version checks and code to clear memory before loading the dol.
Added support for Reset (from menu). Fixes Sam & Max.
Added an IOS check as games which use IOS older than IOS30 do not need to be HLE'd. Added some stubs for Reset to Menu and SSBB's load from disc partition. Fixed loading Fate of Atlantis from the Indiana Jones and the Staff of Kings game.
Added argument detection and passing to the loaded dol. This fixes the Wii Sports+Wii Sports Resort bundle pack.
Added preliminary support for ES_LAUNCH (Wii Multi-boot games) by using HLE to hijack the OSBootDol function.
Conflicts:
Source/Core/DiscIO/Src/FileSystemGCWii.cpp
2013-01-16 20:22:29 +11:00
a167bccb03
Apparently the order here was important, cached somewhere I guess.
2013-01-10 18:59:15 -06:00
14b8d3f107
Add support for german region flag. Still need to change image. (currently using a copy of europe flag)
2013-01-09 22:53:04 -06:00
6598462aba
Display error messages when failing to compress/decompress games.
...
Fixes issue 4681.
2013-01-09 20:02:46 -06:00
32855a289c
Actually export 0-sized files.
...
Fixes issue 5177.
2013-01-09 01:31:40 -06:00
0c845728cc
Added support for Reset (from menu). Fixes Sam & Max.
2012-12-26 23:10:40 +11:00
54fc4029dd
Use do { ... } while (0) for the *_LOG macros
...
Without this patch, such code would not compile:
if (cond)
WARN_LOG(FOO, "msg");
else
WARN_LOG(FOO, "msg2");
2012-08-20 13:12:49 +02:00
86a1899b9e
Fix a wrong data type in the WBFS Blob reader causing issues on x86 systems
...
Fixes issue 5489.
2012-08-05 19:35:49 +02:00
04bde406d3
Fix DVD root path for Wii games. Now Wii games can be booted using extracted files instead of a disc image.
2012-05-11 22:19:57 +02:00
77f47866df
Add Wii DVD integrity checking to Dolphin
...
This allows users to easily check whether their Wii dump is corrupted or not
using the Dolphin properties window. Right click on a game, Properties,
Filesystem tab, then right click on the game partition and select "Check
partition integrity".
This may have some false negatives due to the unused clusters heuristic (see
the comment in VolumeWiiCrypted.cpp). False positives are unlikely.
2012-05-04 16:27:42 +02:00
7885e63deb
Added wbfs support. Thanks to lordlyhobo for the patch. Fixes issue 859.
2012-05-04 00:09:01 +10:00
330f63df80
Corrected the file offset within the FST of virtual disks (used by the DVD Root path function).
2012-04-28 11:21:55 +10:00
26521aa66a
force VolumeDirectory to align files to 32KB (only streaming audio files really need to be aligned...)
2012-04-23 00:50:44 -07:00
404a6b9ba8
Fixes issue 5330.
2012-03-30 20:10:48 -07:00
56b1373baf
Remove scons-related files
2012-03-25 12:55:02 -07:00
d15740daf1
Merge branch 'wxw3-update'
2012-03-25 12:27:38 -07:00
fab037446c
Forward "raw" reads of GC discs to the normal read function, since they are not encrypted in the first place.
2012-03-22 23:04:45 -07:00
f7423a0a4f
Merge branch 'master' into wxw3-update
...
Conflicts:
Source/Core/DolphinWX/Src/LogWindow.cpp
2012-03-22 17:57:38 -07:00
2d75d7a8be
Fixes issue 5278. Thanks to megazig for finding the bug :)
2012-03-22 21:15:05 +13:00
c5d746f3d8
remove scons files from VS projects
2012-03-18 06:41:12 -07:00
8e332948bf
less log noise from CNandContentLoader
2012-02-01 00:04:06 -08:00
3fb42f6bb6
split adding the ticket to its own function (installing a wad)
2012-02-01 00:03:16 -08:00
bef3d7229e
Ensure comment strings in CBannerLoaderWii::SWiiBanner are null-terminated. Fixes issue 5012.
...
Signed-off-by: Shawn Hoffman <godisgovernment@gmail.com>
2012-01-17 23:59:48 -08:00
825e2ea4df
fix an ascii/wxstring in gamelistctrl, replace fromascii("") with wxemptystring, don't push_back 0 at the end of wstrings
2011-12-22 14:28:12 -08:00
7f4efa094e
add the function to read the game name and description from the banner as unicode
2011-12-18 21:56:13 -08:00
a73ad3554c
add the function to read all unicode gamenames from a wad file
2011-12-18 21:42:20 -08:00
95517a9741
vs2010: Disable LTCG for realz
2011-09-05 09:43:23 -07:00
7135dba54e
Add the DSPTool and UnitTests to the cmake build. They are optional, and to enable them add -DDSTPTOOL and -DUNITTESTS to the cmake command line.
...
Also, don't check to see if a directory is a wad file. They aren't. This removes an annoying and invalid debug assertion with the debug build.
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7682 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-07-18 01:47:55 +00:00
b808af1d7f
fix infinitely recursive deletion from r7587 and actually update locations of content.map and uid.sys
...
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7588 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-05 07:42:40 +00:00
Léo Lam