Pokechu22
2d53b73643
VertexLoaderTester: Add assertions for position/binormal/tangent caches
2023-01-13 15:38:00 -08:00
Pokechu22
c681d96d46
VertexLoaderTester: Use asserts instead of logs
...
Logs don't show up in unit tests, and since this is debugging functionality (though not enabled for tests by default) it's better to do it this way.
2023-01-13 15:38:00 -08:00
Sam Belliveau
e849172dc9
Limit Throttling to 1200hz
2023-01-13 18:17:24 -05:00
Sam Belliveau
e95c1d55e8
Limit Sleep Calls to 8192hz at most
2023-01-13 11:59:32 -05:00
Pokechu22
7abee1a97b
DolphinQt: Fix typo in GBA TAS input window
...
This generated a warning on GCC about the operation being potentially undefined (-Wsequence-point). I'm not sure if that was actually the case, but either way it is a mistake.
2023-01-12 14:33:58 -08:00
OatmealDome
5c80a9fd87
CMakeLists: Copy LICENSE files when building for Steam Runtime
2023-01-10 23:21:24 -05:00
OatmealDome
fff13c385f
CMakeLists: Copy entire plugins folder on Steam Runtime build
2023-01-10 23:21:24 -05:00
Shawn Hoffman
d51e4e5236
get rid of HAS_STD_FILESYSTEM
...
just use std::filesystem
2023-01-10 05:17:43 -08:00
UltraHDR
18454906cf
Set LSApplicationCategoryType to games
...
https://developer.apple.com/documentation/bundleresources/information_property_list/lsapplicationcategorytype
This makes it show up in the Launchpad Games folder
2023-01-10 11:34:42 +00:00
Admiral H. Curtiss
653e0ccf28
Merge pull request #11365 from iwubcode/cheat_manager_freeze_value
...
DolphinQt: add ability to lock / freeze values in the watches window
2023-01-09 18:41:28 +01:00
Admiral H. Curtiss
993d2ab173
PatchEngine: Use std::span in ApplyMemoryPatches().
2023-01-09 17:24:41 +01:00
Admiral H. Curtiss
21c29bad6b
Merge pull request #11407 from AdmiralCurtiss/globals-gpfifo
...
HW/GPFifo: Refactor to class, move to Core::System.
2023-01-09 17:09:48 +01:00
Admiral H. Curtiss
eeeab3c3be
Merge pull request #11183 from TheLordScruffy/write-back-cache
...
Implement PowerPC data cache
2023-01-09 17:09:32 +01:00
Sam Belliveau
901e4c7697
Reset Throttle Variables In Init
2023-01-09 11:06:12 -05:00
Sam Belliveau
f7de0e4147
Fix issue that would disable Throttling
2023-01-08 01:20:19 -05:00
TheLordScruffy
d85f6c8298
DolphinAnalytics: Remove ICACHE_MATTERS
2023-01-08 00:17:46 -05:00
TheLordScruffy
825bacde43
PPCCache: Change u32 to u8 for plru, valid, modified
2023-01-07 20:18:59 -05:00
TheLordScruffy
811d942222
Improve PPCCache lookup table
2023-01-07 07:30:42 -05:00
Pokechu22
d20b71c296
Move x64 DSP JIT into DolphinLib.x64.props
...
Before, it was also compiled on ARM builds, but since it was unused it wasn't linked (and thus its dependency on the nonexistent x64Emitter didn't cause any link issues).
2023-01-06 22:42:21 -08:00
Sam Belliveau
bc1cc9eeb4
CoreTiming: Throttle Before Every Event Using Chrono
2023-01-06 17:21:17 -05:00
Sam Belliveau
588a72a4fc
PerformanceTracker: Add ownership of m_log_name.
2023-01-06 20:27:25 +01:00
Sam Belliveau
bc46089ab0
PerformanceTracker: Use shared_mutex instead of mutex so multiple threads can read at the same time.
2023-01-06 20:27:25 +01:00
Sam Belliveau
9143eb00fb
PerformanceMetrics: Fix Line Width Issue on Non HiDPI Screens
2023-01-06 20:27:17 +01:00
Admiral H. Curtiss
d33416fc35
HW/Memmap: Zero-initialize members by default.
2023-01-06 05:33:21 +01:00
Admiral H. Curtiss
fbcaf83d30
HW/GPFifo: Refactor to class, move to Core::System.
2023-01-06 05:33:21 +01:00
Mai
cc14d60bbb
Merge pull request #11402 from Pokechu22/too-many-indices
...
IndexGenerator: Fix off-by-one in GetRemainingIndices
2023-01-05 15:15:09 +00:00
Admiral H. Curtiss
7b04a6b958
Merge pull request #11089 from sepalani/pcap-share
...
NetworkCaptureLogger: Allow PCAP shared read access on Windows
2023-01-05 04:06:35 +01:00
Pokechu22
cefcd9c93c
IndexGenerator: Fix off-by-one in GetRemainingIndices
...
Fixes https://bugs.dolphin-emu.org/issues/13136 .
2023-01-04 10:42:00 -08:00
Pokechu22
6c58ba353c
IndexGenerator: Add assertion for overflow in GetRemainingIndices
...
This assertion is currently triggered by Pocoyo Racing (https://bugs.dolphin-emu.org/issues/13136 ).
2023-01-04 10:41:14 -08:00
Admiral H. Curtiss
2fdaf0a86e
HW/ProcessorInterface: Rename member variables to fit naming convention.
2023-01-04 03:17:26 +01:00
Admiral H. Curtiss
74e1577a2c
HW/ProcessorInterface: Refactor to class, move to Core::System.
2023-01-04 03:00:10 +01:00
Pokechu22
d91f340c86
VertexManagerBase: Move free space check to after the buffer is reset
...
Fixes incorrect logspam when the buffer needed to be reset on flushes (which we already were doing, but 52feed04db
moved it to after the check was made). This is https://bugs.dolphin-emu.org/issues/10312 .
I also converted it to an assert, as if this does happen, things are going to render incorrectly, so we want to make it obvious.
2023-01-03 17:06:51 -08:00
Admiral H. Curtiss
908cec04cb
Merge pull request #11396 from Pokechu22/fbfetch-analytics
...
DolphinAnalytics: Track support of framebuffer fetch
2023-01-03 18:11:17 +01:00
Admiral H. Curtiss
ed9915308b
Merge pull request #11386 from Pokechu22/manual-texture-sampling-stereoscopic-layer-bounds-check
...
PixelShaderGen: Clamp texture layer when using manual texture sampling with stereoscopic 3D
2023-01-03 18:07:06 +01:00
Pokechu22
c1b1d8d783
DolphinAnalytics: Track support of framebuffer fetch
2023-01-02 23:17:17 -08:00
Pokechu22
c645970578
VideoBackends/OGL: Always check for fbfetch support, not just on GLES
...
GL_EXT_shader_framebuffer_fetch is not restricted to GLES (although GL_ARM_shader_framebuffer_fetch is), and is available on Intel GPUs.
2023-01-02 23:17:08 -08:00
Pokechu22
277518837a
DolphinAnalytics: Track support of logic ops
2023-01-02 23:17:02 -08:00
Pokechu22
f433da6083
DolphinAnalytics: Fix comment wrapping
...
This was broken in 3570c7f03a
.
2023-01-02 23:15:04 -08:00
Admiral H. Curtiss
d949aa60bb
Merge pull request #11397 from TellowKrinkle/QuartzMousePos
...
InputCommon:QuartzKB&M: Fix mouse y coordinates
2023-01-02 23:04:12 +01:00
Admiral H. Curtiss
f13f54e3db
Merge pull request #11363 from TheConfuZzledDude/xinput2-scroll-axis
...
InputCommon/XInput2: Added an axis output for the scroll wheel
2023-01-02 23:02:12 +01:00
TheLordScruffy
9d39647f9e
Fix PPC cache code formatting
2023-01-02 02:33:57 -05:00
TellowKrinkle
8659de4d71
InputCommon:QuartzKB&M: Fix mouse y coordinates
...
Cocoa uses a different coordinate system from Carbon (Carbon's origin is the top left while Cocoa's is the bottom left)
2022-12-31 23:42:11 -06:00
Mai
20ac2cf781
Merge pull request #11375 from JosJuice/mmu-inf-write
...
PowerPC: Fix theoretically possible infinite loop in WriteToHardware
2022-12-31 18:55:11 +00:00
Mai
e31722db1c
Merge pull request #11380 from Pokechu22/performance-sample-window-title
...
AdvancedWidget: Add title for performance sample window tooltip
2022-12-31 18:54:43 +00:00
Mai
acdf76bf16
Merge pull request #11374 from JosJuice/jitarm64-breakpoints
...
JitArm64: Implement breakpoints
2022-12-31 18:53:25 +00:00
Admiral H. Curtiss
f6fbeaf355
Merge pull request #11364 from jordan-woyak/udraw-lift
...
WiimoteEmu: Expose mappings for lifted UDraw and Drawsome stylus.
2022-12-29 21:16:57 +01:00
JMC47
a20e41d340
Merge pull request #11389 from Pokechu22/sw-no-alpha-1-hack
...
Software: Remove alpha=1 blending special-case
2022-12-29 13:08:04 -05:00
Admiral H. Curtiss
c20bb01b47
Merge pull request #11372 from JosJuice/m3u-backslash
...
Boot: Fix handling of M3U file paths containing backslashes
2022-12-29 17:09:38 +01:00
Admiral H. Curtiss
4bc94e4629
Merge pull request #11353 from noahpistilli/fix-mail-account-generation
...
Set checksum for NWC24Config during creation
2022-12-29 17:08:10 +01:00
Admiral H. Curtiss
cb0a603c72
VideoCommon: De-globalize GeometryShaderManager class.
2022-12-29 15:33:19 +01:00
Admiral H. Curtiss
a164c47caf
Core/Boot: Pass System instance to BootUp() and related.
2022-12-29 05:49:26 +01:00
Mai
7552deeff4
Merge pull request #11388 from AdmiralCurtiss/globals-vertexshadermanager
...
VideoCommon: De-globalize VertexShaderManager class.
2022-12-29 04:48:24 +00:00
Pokechu22
ed5015fa24
Software: Remove alpha=1 blending special-case
...
This was added in #10394 for both the hardware and software backends to work around an issue with Mario Kart Wii, Fortune Street, and Baten Kaitos. However, it seems like the software renderer handles blending well enough that we don't need this (and in any case, it's easy to change blending in the software renderer).
Some experimentation with #11387 (not pushed) showed that the software renderer's logic would also produce correct results on the hardware backends with this hack removed, but would require fbfetch (currently); if a better solution is found the hack can also be removed from the hardware backends.
2022-12-28 14:21:33 -08:00
JMC47
82e5f438f9
Merge pull request #11219 from K0bin/android-vk-alidation
...
VideoBackends:Vulkan: Migrate to VK_EXT_debug_utils
2022-12-28 14:16:51 -05:00
Admiral H. Curtiss
7e55cc9e90
VideoCommon/VertexShaderManager: Rename private variables.
2022-12-28 16:00:15 +01:00
Admiral H. Curtiss
50625728e0
VideoCommon: De-globalize VertexShaderManager class.
2022-12-28 15:52:29 +01:00
Mai
0900e68986
Merge pull request #11384 from AdmiralCurtiss/globals-pixelshadermanager
...
VideoCommon: De-globalize PixelShaderManager class.
2022-12-28 00:59:03 +00:00
Pokechu22
f3df3a7727
PixelShaderGen: Clamp texture layer when using manual texture sampling with stereoscopic 3D
...
Otherwise, texelFetch() will use an out-of-bounds layer for game textures (that have 1 layer; EFB copies have 2 layers in stereoscopic 3D mode), which is undefined behavior (often resulting in a black image). The fast texture sampling path uses texture(), which always clamps (see https://www.khronos.org/opengl/wiki/Array_Texture#Access_in_shaders ), so it was unaffected by this difference.
2022-12-27 13:45:13 -08:00
Admiral H. Curtiss
c8202043b6
IOS/NWC24Config: Combine WriteConfig() and WriteCBK().
2022-12-27 21:21:06 +01:00
Admiral H. Curtiss
4549fb4acb
VideoCommon/PixelShaderManager: Rename s_ variables.
2022-12-27 20:20:27 +01:00
Admiral H. Curtiss
725bd64ec2
VideoCommon: De-globalize PixelShaderManager class.
2022-12-27 20:13:24 +01:00
Sketch
929fba08e7
Fix ESDevice::GetTitlesWithTickets always returning 0 titles owned
2022-12-27 12:18:44 -05:00
Robin Kertels
19a4653203
VideoBackends:Vulkan: Replace debug_report with debug_utils
...
The former is deprecated and pretty much all modern drivers
support VK_EXT_debug_utils.
Android drivers dont support it. On those drivers,
we use the implementation provided by the validation layers.
2022-12-27 02:48:50 +01:00
Floogle
c689e9cde0
Netplay: When connecting, ignore packets from traversal server
2022-12-26 23:35:42 +01:00
Pokechu22
4e05c569d4
AdvancedWidget: Fix typo in performance sample window tooltip
2022-12-26 14:28:48 -08:00
Pokechu22
b675e49c0e
AdvancedWidget: Add title for performance sample window tooltip
2022-12-26 14:20:06 -08:00
Sam Belliveau
6052a5ca9b
Fix Speed Counter Sample Size
2022-12-26 16:47:12 -05:00
TheConfuZzledDude
288fa635f9
InputCommon/XInput2: Changed axis value reading to be more correct
2022-12-26 17:27:48 +00:00
Admiral H. Curtiss
f4b1155b4d
Merge pull request #11373 from JosJuice/gba-tas-input-turbo
...
DolphinQt: Add settings to GBA TAS input window
2022-12-26 04:37:25 +01:00
Jordan Woyak
4f4285cf5e
WiimoteEmu/DrawsomeTablet: Expose mapping for lifted stylus.
2022-12-25 19:03:15 -06:00
Jordan Woyak
ab9fc3f2e4
WiimoteEmu/UDrawTablet: Expose mapping for lifted stylus.
2022-12-25 19:03:15 -06:00
JosJuice
cf16f49068
PowerPC: Fix theoretically possible infinite loop in WriteToHardware
...
`em_address + size` can overflow and become 0. It shouldn't happen with
the kinds of memory mappings games use in practice, though.
2022-12-25 12:29:13 +01:00
JosJuice
e0fba20f1f
Merge pull request #11360 from shuffle2/vs
...
msvc: remove workaround for arm64 sha1 compiler bug
2022-12-24 22:55:47 +01:00
JosJuice
c744ff4934
JitArm64: Implement breakpoints
...
Plus two miscellaneous debugger features that I found along the way when
reading Jit64's code for comparison: bJITNoBlockLinking and tracing.
Fixes https://bugs.dolphin-emu.org/issues/13127 .
2022-12-24 13:24:01 +01:00
JosJuice
0659827485
Jit64: Check for breakpoint without disabling block link
...
Small optimization. By not calling WriteExit, the block linking system
never finds out about the exit we're doing, saving us from having to
disable block linking.
2022-12-24 13:01:29 +01:00
JosJuice
494b041b34
DolphinQt: Add settings to GBA TAS input window
...
We should expose Enable Controller Input and the turbo settings for
GBA just like we do for GameCube controllers and Wii Remotes.
I just forgot about it when implementing the GBA TAS input window.
2022-12-24 11:30:25 +01:00
JosJuice
71f1b1db34
Boot: Fix handling of M3U file paths containing backslashes
...
Previously, if a user on Windows launched Dolphin from the command line
and specified a path to an M3U file and included backslashes in this path,
Dolphin would fail to resolve relative paths in the M3U file.
2022-12-24 11:13:27 +01:00
JosJuice
3611045a6c
DolphinQt: Add more i18n comments
2022-12-24 08:32:49 +01:00
Sam Belliveau
e1d078ada6
Remove Redundant Access Specifiers
2022-12-23 20:13:01 -05:00
Sam Belliveau
673f81c18a
New FrameTime/VBlank Analyzer + Graph
2022-12-23 19:52:53 -05:00
TheConfuZzledDude
27d596b89c
InputCommon/Xinput: Cleaned up a bit
2022-12-23 22:35:09 +00:00
TheConfuZzledDude
c3018fdc3b
InputCommon/XInput2: Added an axis output for the scroll wheel
2022-12-23 22:10:28 +00:00
Pierre Bourdon
2345ba178d
Merge pull request #11356 from Sam-Belliveau/update-dear-implot
...
Externals: Add Dear Implot
2022-12-23 22:05:29 +01:00
iwubcode
31bf9d0019
Core: add option to apply memory patch to not store the existing value (used during locking)
2022-12-23 12:31:33 -06:00
iwubcode
190cf5af30
DolphinQt: add multiselection to WatchWidget
2022-12-23 12:31:33 -06:00
iwubcode
c8a6ff6309
DolphinQt: add a 'add to watch' context menu item that allows you to add a memory location found in a cheat search to be added to the watch list
2022-12-23 12:31:33 -06:00
iwubcode
7d7fcdddd3
DolphinQt: add lock state to WatchWidget
2022-12-23 12:31:33 -06:00
iwubcode
8f3e8e4ca3
Core: add locked state to watches
2022-12-23 11:59:23 -06:00
iwubcode
41c9d706cb
DolphinQt: cleanup WatchWidget
2022-12-23 11:59:23 -06:00
iwubcode
3081a781fd
Core: when scheduling an invalidate cpu cache, no need to schedule if we're already on the cpu thread
2022-12-23 11:59:23 -06:00
iwubcode
2f2f906bf5
Core: add ability to add memory patches to the patch engine that will be executed each frame
2022-12-23 03:13:03 -06:00
iwubcode
1f87bcd202
Core: add ability to apply memory patches during a frame update in the PatchEngine
2022-12-23 03:13:03 -06:00
iwubcode
4743d74985
Core: add helper function to apply a memory patch and mark the 'PPCPatches' as final
2022-12-23 03:13:03 -06:00
Minty-Meeo
14179f7565
Follow-up on a four-year-old Android NDK workaround
...
Surely this is fixed by now.
2022-12-22 19:54:46 -06:00
Sam Belliveau
5ca438dd97
Add Dear ImPlot Library
2022-12-22 14:32:42 -05:00
Shawn Hoffman
9dcae0b1c3
msvc: remove workaround for arm64 sha1 compiler bug
2022-12-22 00:44:29 -08:00
Minty-Meeo
05bebee802
Replace BitUtils with C++20: Counting Zeroes
...
With the upgrade to C++20, std::countl_zero and std::countr_zero can replace these home-spun implementations from the BitUtil.h library.
2022-12-21 04:17:00 -06:00
Admiral H. Curtiss
d853da3b0b
Merge pull request #11354 from Pokechu22/desert-bus-asnd-ucode
...
DSPHLE: Add Desert Bus libasnd ucode variants
2022-12-20 20:01:21 +01:00
Pokechu22
66b3686d84
DSPHLE: Add Desert Bus libasnd ucode variants
2022-12-20 10:02:53 -08:00
Mai
5348c8b2c6
Merge pull request #11344 from JosJuice/jitarm64-mw-deps
...
JitArm64: Improve pipelining of lmw/stmw
2022-12-20 15:11:29 +00:00
Mai
43366d2384
Merge pull request #11351 from JosJuice/bitset-cpp20
...
Common: Use C++20 <bit> header in BitSet.h
2022-12-20 15:02:38 +00:00
Sketch
c01ec96c92
Set checksum for NWC24Config during creation
2022-12-19 20:18:34 -05:00
JMC47
fb8aa9744e
Merge pull request #11286 from K0bin/vk-query-fix
...
VideoBackends: Query fixes and cleanups
2022-12-19 03:15:48 -05:00
JosJuice
547d956278
Common: Use C++20 <bit> header in BitSet.h
2022-12-18 16:51:32 +01:00
Sketch
b56411b84b
Fix MemoryViewWidget background colour
2022-12-17 10:37:37 +01:00
Mai
a1c4861ad8
Merge pull request #10950 from JosJuice/replace-bitutils-rotate
...
Replace BitUtils with C++20: RotateLeft/RotateRight
2022-12-11 21:19:43 +00:00
Mai
aa57d53c90
Merge pull request #11345 from AdmiralCurtiss/globals-pe
...
VideoCommon/PixelEngine: Refactor to class, move to Core::System.
2022-12-11 21:07:30 +00:00
Admiral H. Curtiss
c486baffe6
VideoCommon/PixelEngine: Pass Core::System to methods.
2022-12-11 21:57:30 +01:00
Admiral H. Curtiss
ec8aaf1f30
VideoCommon/PixelEngine: Refactor to class, move to Core::System.
2022-12-11 21:57:19 +01:00
JosJuice
701ba7cd43
JitArm64: Improve pipelining of lmw/stmw
...
The calculation of each address in lmw/stmw currently has a dependency
on the calculation of the previous address. By removing this dependency,
the host CPU should be able to pipeline the loads/stores better. The cost
we pay for this is up to one extra register and one extra MOV instruction
per guest instruction, but often nothing.
Making EmitBackpatchRoutine support using any register as the address
register would let us get rid of the MOV, but I consider that to be too
big of a task to do in one go at the same time as this.
2022-12-11 17:08:12 +01:00
Merry
17c14ac4b9
MachineContext: Fix USE_SIGACTION_ON_APPLE on arm64
2022-12-11 13:36:44 +00:00
JosJuice
454537d53e
Replace BitUtils with C++20: RotateLeft/RotateRight
...
Now that we've flipped the C++20 switch, let's start making use of
the nice new <bit> header.
I'm planning on handling this move away from BitUtils.h incrementally
in a series of PRs. There may be a few functions remaining in
BitUtils.h by the end that C++20 doesn't have any equivalents for.
2022-12-11 08:59:18 +01:00
JosJuice
1fd8d476e8
Merge pull request #11325 from t895/extra-dark
...
Android: Add black backgrounds toggle
2022-12-10 21:09:26 +01:00
Charles Lombardo
fd7a84b794
Android: Add black backgrounds toggle
...
Makes all background colors black in dark mode when enabled through a ThemeOverlay. Applied the same way as a theme/mode.
2022-12-10 14:53:01 -05:00
Mai
54e01c660e
Merge pull request #11334 from AdmiralCurtiss/globals-fifo
...
VideoCommon/Fifo: Refactor to class, move to Core::System.
2022-12-10 19:13:23 +00:00
Mai
48ce5318e1
Merge pull request #11338 from JosJuice/jitarm64-revert-supposed-tail
...
Revert "JitArm64: Optimize a few tail calls"
2022-12-10 19:11:23 +00:00
Mai
c3bed35468
Merge pull request #11337 from JosJuice/aarch64-shrn
...
Arm64Emitter: Fix SHRN/SHRN2
2022-12-10 19:09:33 +00:00
Admiral H. Curtiss
ceae4242fc
VideoCommon/Fifo: Pass Core::System to methods.
2022-12-10 17:16:26 +01:00
Admiral H. Curtiss
5624dd6d39
VideoCommon/Fifo: Refactor to class, move to Core::System.
2022-12-10 17:16:19 +01:00
JosJuice
64bc150b8c
Revert "JitArm64: Optimize a few tail calls"
...
This reverts commit 351d095fff
.
In hindsight, my attempted optimization messes with the return
predictor, unlike real tail calls. So I think it does more bad than
good.
2022-12-10 11:35:52 +01:00
JosJuice
b5b8871bce
Arm64Emitter: Fix SHRN/SHRN2
...
The "vector shift by immediate" category encodes the shift amount for
right shifts as `size - amount`, whereas left shifts use `amount`.
We're not actually using SHRN/SHRN2 anywhere, which is why this has gone
undetected.
2022-12-10 11:20:23 +01:00
Admiral H. Curtiss
1d199f4664
Qt/EnhancementsWidget: Combine texture filtering and anisotropic filtering.
2022-12-09 02:02:17 +01:00
Admiral H. Curtiss
ff2cc4d02b
Qt/EnhancementsWidget: Convert texture filtering option to a ComboBox.
2022-12-09 02:02:16 +01:00
Admiral H. Curtiss
8a3b8a925e
Core: Add option to force linear texture filtering.
2022-12-09 02:02:16 +01:00
TheLordScruffy
e97d380437
Implement PPC write-back data cache
2022-12-08 18:18:32 -05:00
Admiral H. Curtiss
b207611c33
Merge pull request #11274 from TryTwo/PR_Conditional_BP_Add_Memory
...
Debugger: Add conditional breakpoints to memory BPs
2022-12-07 19:55:04 +01:00
Mai
000c6c4813
Merge pull request #11321 from JosJuice/jitarm64-accurate-nans
...
JitArm64: Implement accurate NaNs
2022-12-07 00:58:13 +00:00
Mai
94faad0d37
Merge pull request #11320 from AdmiralCurtiss/globals-memory
...
HW/Memmap: Refactor Memory to class, move to Core::System.
2022-12-07 00:52:31 +00:00
Mai
a9a603b8cb
Merge pull request #11268 from jordan-woyak/ascii-controller
...
Rename "Keyboard" to "Keyboard Controller"
2022-12-04 21:05:52 +00:00
TryTwo
a17fbe7c65
Expand conditional breakpoints to memory breakpoints
2022-12-04 11:25:33 -07:00
Mai
b23eb1f550
Merge pull request #11322 from JosJuice/jit64-madds-nan
...
Jit64: Correctly handle NaNs for ps_maddsX
2022-12-04 17:58:16 +00:00
Mai
f21edf6d5a
Merge pull request #11270 from t895/theme-mode
...
Android: Add theme mode switcher
2022-12-04 17:56:59 +00:00
Admiral H. Curtiss
c9f31ad6a6
Merge pull request #11262 from K0bin/present-sync
...
VideoBackends:Vulkan: Synchronize presentation
2022-12-04 14:30:59 +01:00
Admiral H. Curtiss
2b93d5e0d7
Merge pull request #11273 from TryTwo/PR_Conditional_BP_Callstack
...
Debugger: add callstack to conditional breakpoints
2022-12-04 14:16:12 +01:00
Admiral H. Curtiss
2bd47d1435
Merge pull request #11232 from TryTwo/PR_MemoryView_highlighting
...
Debugger MemoryViewWidget: always highlight target address
2022-12-04 14:07:19 +01:00
TryTwo
76bf1b5f7d
Add callstack to conditional breakpoints. Checks entire stack for value.
...
Use: callstack(0x80000000).
!callstack(value) works as a 'does not contain'.
Add strings to expr.h conditionals.
Use quotations: callstack("anim") to check symbols/name.
2022-12-03 20:52:17 -07:00
JosJuice
eeef5363e4
Jit64: Correctly handle NaNs for ps_maddsX
2022-12-03 21:05:05 +01:00
JosJuice
06e60ac327
JitArm64: Implement accurate NaNs
...
For quite some time now, we've had a setting on x86-64 that makes Dolphin
handle NaNs in a more accurate but slower way. There's only one game that
cares about this, Dragon Ball: Revenge of King Piccolo, and what that game
cares about more specifically is that the default NaN (or "generated NaN"
as I believe it's called in PowerPC documentation) is the same as on
PowerPC. On ARM, the default NaN is the same as on PowerPC, so for the
longest time we didn't need to do anything special to get Dragon Ball:
Revenge of King Piccolo working. However, in 93e636a
I changed how we
handle FMA instructions in a way that resulted in the sign of NaNs
becoming inverted for nmadd/nmsub instructions, breaking the game.
To fix this, let's implement the AccurateNaNs setting, like on x86-64.
2022-12-03 19:41:32 +01:00
JosJuice
5c41d3b602
JitArm64: Refactor temp reg handling in fp_arith/ps_arith
2022-12-03 19:08:27 +01:00
Admiral H. Curtiss
839db591d9
HW/Memmap: Refactor Memory to class, move to Core::System.
2022-12-03 13:27:02 +01:00
Mai
6b514e81f9
Merge pull request #11316 from Pokechu22/jit-widget-fixes
...
Jit widget fixes
2022-12-02 20:54:48 +00:00
Charles Lombardo
b9fffa2e66
Android: Add theme mode switcher
...
Similar to app themes, theme modes have to be loaded before directory initialization is ready. So we save the proper key the same way.
2022-12-02 13:31:57 -05:00
Pokechu22
3d6bfcd236
JITWidget: Convert to fmt
2022-12-01 17:44:41 -08:00
Pokechu22
6a6d24550e
Clean up DisassembleBlock and JitInterface::GetHostCode
2022-12-01 17:43:35 -08:00
Pokechu22
5842b90bee
Show JIT blocks widget when selecting 'PPC vs Host' in code widget
...
Before, I just assumed this feature was broken since I didn't know what widget it used. Now, it behaves like show memory and show code elsewhere.
2022-12-01 17:43:35 -08:00
Pokechu22
0ccfa31ec8
Fix code widget not becoming visible when selecting 'view code' or similar
...
This affected the memory and registers widgets (and possibly others). I'm pretty sure it regressed in 5f629abd8b
.
The SetCodeVisible line is a new fix, but the equivalent already existed in the memory widget.
2022-12-01 17:43:35 -08:00
Pokechu22
4f4bd57fe9
Fix crash when stopping emulation while the JIT widget is in use
...
The call to analyzer.Analyze breaks when it attempts to read an instruction, as it eventually tries to read memory when Memory::m_pRAM is nullptr. Trying to read when execution is not paused in general seems like a bad idea (especially as analyzer.Analyze uses PowerPC::TryReadInstruction which can update icache - this is probably still a problem).
2022-12-01 17:43:34 -08:00
TellowKrinkle
ffb73f43e1
VideoBackends:Metal: Fix min/max lod when setting non-zero-based samplers
2022-11-30 21:11:37 -06:00
TryTwo
700eca1baa
MemoryViewWidget set target address as selected. Fix focus call. Always color selected item blue.
2022-11-30 16:38:56 -07:00
Robin Kertels
35a6d16d9e
VideoBackends: Rename query_type to query_group
2022-11-29 23:14:23 +01:00
Robin Kertels
df2e07ad29
VideoBackends:Vulkan: Fix incorrect barriers in StagingBuffer
...
HOST barriers need to be issued regardless of
whether the memory type is coherent
and we need to properly synchronize writes to the buffer.
2022-11-29 23:14:23 +01:00
Robin Kertels
57b2ea663e
VideoBackends:D3D12: Set query type
2022-11-29 23:14:23 +01:00
Robin Kertels
6ba7573877
VideoBackends:Vulkan: Fix queries
...
Fixes both checking whether queries are done
and actually resets query pools.
2022-11-29 23:14:07 +01:00
Mai
7cd9a78ebf
Merge pull request #11304 from JosJuice/jit64-nan-c
...
Jit64: Correctly handle NaNs for ps_mulsX/ps_sumX
2022-11-29 12:57:43 +00:00
Mai
5f22a0054f
Merge pull request #11305 from JosJuice/jitarm64-optimize-ps-merge
...
JitArm64: Optimize ps_mergeXX
2022-11-29 12:57:10 +00:00
Mai
ff830c08b6
Merge pull request #11307 from AdmiralCurtiss/globals-command-processor
...
VideoCommon/CommandProcessor: Refactor to class, move to Core::System.
2022-11-29 12:56:30 +00:00
Admiral H. Curtiss
6941d2e7e6
VideoCommon/CommandProcessor: Refactor to class, move to Core::System.
2022-11-29 08:15:01 +01:00
TellowKrinkle
e3cc42069f
VideoBackends:OGL: Creating vertex formats shouldn't unbind anything
2022-11-28 21:28:24 -06:00
JosJuice
2f1a8ee1b9
Jit64: Skip HandleNaNs for operations that can't generate NaN
...
Operations that have two operands and can't generate a default NaN,
i.e. addition and subtraction, already have the desired NaN handling
on x86. We just need to make sure to not reverse the operands.
This fixes ps_sum0/ps_sum1 outputting NaNs in cases where they shouldn't.
(HandleNaNs assumes that a NaN in a ps0 input always results in a NaN in
the ps0 output, and correspondingly for ps1.)
2022-11-27 11:30:10 +01:00
JosJuice
cbceae9176
Jit64: Correctly handle NaNs for ps_mulsX
2022-11-27 11:30:10 +01:00
JosJuice
d3180e3516
Jit64: Refactor HandleNaNs operand passing
2022-11-27 11:30:05 +01:00
Mai
44f8b8c100
Merge pull request #11303 from AdmiralCurtiss/coretiming-class
...
CoreTiming: Refactor to class.
2022-11-27 06:00:46 +00:00
Admiral H. Curtiss
64bb9ae9a9
Correctly call CoUninitialize() on Cubeb helper class destruction.
2022-11-27 03:58:50 +01:00
Admiral H. Curtiss
daa70533cd
CoreTiming: Store Globals in CoreTimingManager.
2022-11-27 03:47:12 +01:00
Admiral H. Curtiss
c9558ecb4c
CoreTiming: Refactor to class.
2022-11-27 03:47:12 +01:00
Admiral H. Curtiss
3cdc6e3d4a
Merge pull request #10343 from AdmiralCurtiss/cubeb-2021
...
Update cubeb to mozilla/cubeb@27d2a102b0
2022-11-27 03:26:11 +01:00
JosJuice
f45d3a6a2c
JitArm64: Optimize ps_mergeXX
...
1. In some cases, ps_merge01 can be implemented using one instruction.
2. When we need two instructions for ps_merge01, it's best to start with
a MOV to avoid false dependencies on the destination register.
3. ps_merge10 can be implemented using a single EXT instruction.
2022-11-26 18:14:58 +01:00
Admiral H. Curtiss
e085bf14f9
Core: Use extra thread for Cubeb on Windows to not disturb the CoInitialize state of whatever thread happens to call a Cubeb function.
2022-11-26 05:05:57 +01:00
Admiral H. Curtiss
ca10e92ab9
Core: Abide by COM MTA requirement for cubeb on Windows. Partially based on https://github.com/dolphin-emu/dolphin/pull/8920#discussion_r459746604
...
Co-authored-by: Michael M <mchtly@gmail.com>
2022-11-26 05:05:56 +01:00
Admiral H. Curtiss
59b1419a8e
Externals: Update cubeb to mozilla/cubeb@773f16b7ea and make it a submodule.
...
CMakeLists.txt has been extracted and modified a bit to work with Dolphin's typical build settings.
2022-11-26 05:05:52 +01:00
Admiral H. Curtiss
4273d3754c
CoreTiming: Move static variables into Core::System.
2022-11-26 04:22:32 +01:00
Admiral H. Curtiss
86f17511fc
CoreTiming: Move the 'Globals' instance into Core::System.
2022-11-26 04:22:32 +01:00
Admiral H. Curtiss
70f353fb37
Merge pull request #11283 from AdmiralCurtiss/netplay-save-sync-log
...
Netplay: Add more logging to save syncing.
2022-11-26 03:53:17 +01:00
Admiral H. Curtiss
d189c70d4d
Merge pull request #11230 from AdmiralCurtiss/gci-filenames
...
GCMemcardDirectory: GCI filename cleanup and fixes.
2022-11-26 03:52:43 +01:00
JoshuaMK
dd2282324b
Debugger BreakpointWidget: Allow editing breakpoints
2022-11-26 03:38:25 +01:00
TellowKrinkle
72eadc6520
InputCommon:SDL: Add SDL 2.26 left and right motion inputs
2022-11-24 15:12:07 -06:00
Mai
7be4c90f67
Merge pull request #11166 from AdmiralCurtiss/mmio-system
...
HW: Pass System to MMIO handlers.
2022-11-24 00:58:45 +00:00
Pokechu22
f5d11c1e38
VideoBackends/D3D11: Simplify vertex attribute code
2022-11-23 13:45:43 -08:00
Pokechu22
cc5640245c
Fix build errors related to formatting non-scoped enums
2022-11-23 13:45:43 -08:00
Admiral H. Curtiss
545fee9c94
Core/CommandProcessor: Reformat single/dual core dependent MMIO handlers.
2022-11-23 21:58:18 +01:00
Admiral H. Curtiss
0a6fdb9c13
HW: Pass System to MMIO handlers.
2022-11-23 05:52:21 +01:00
Mai
0ef6d30a0d
Merge pull request #11165 from AdmiralCurtiss/audiocommon-pass-system
...
AudioCommon: Pass Core::System to AudioCommon functions.
2022-11-23 04:49:31 +00:00
Mai
a47ed2124f
Merge pull request #11253 from AdmiralCurtiss/core-timing-events-pass-system
...
CoreTiming: Pass Core::System to Events.
2022-11-23 04:46:11 +00:00
Mai
677121bdbc
Merge pull request #11292 from JosJuice/jit64-imm-ra-update
...
Jit64: Use MOV instead of ADD for updating imm Ra
2022-11-23 04:42:46 +00:00
Mai
e573a0bbc2
Merge pull request #11294 from JosJuice/jitarm64-movpage2r
...
Arm64Emitter: Add MOVPage2R utility function
2022-11-23 04:41:31 +00:00
Mai
cb232155d9
Merge pull request #11298 from Pokechu22/vertexloader-no-DataReader
...
VertexLoader: Eliminate use of DataReader
2022-11-23 04:40:53 +00:00
Pokechu22
e13094766d
Fix VertexLoader.cpp using the wrong size for texture matrix indices without a corresponding texture
...
This regressed in 0a906f553f
, I think (though I haven't confirmed it). Mario Tennis and Luigi's Mansion both use these for some reason (as far as I can tell, the data isn't actually used; it's just extra data included for no reason)
2022-11-22 17:49:54 -08:00
Pokechu22
0bcd3c79bb
VertexLoader: Eliminate use of DataReader
...
DataReader is generally jank - it has a start and end pointer, but the end pointer is generally not used, and all of the vertex loaders mostly bypassed it anyways.
Wrapper code (the vertex loaer test, as well as Fifo.cpp and OpcodeDecoding.cpp) still uses it, as does the software vertex loader (which is not a subclass of VertexLoader). These can probably be eliminated later.
2022-11-22 17:17:11 -08:00
Sam Belliveau
edb2c90b38
Improve FPS/VPS Counting and Revamp Appearance
2022-11-23 00:11:47 +01:00
Admiral H. Curtiss
5e442f6ffa
Merge pull request #11281 from AdmiralCurtiss/updater-admin-check
...
Updater: Check for write permissions in directory of Updater.exe.
2022-11-22 23:50:13 +01:00
Admiral H. Curtiss
19b6251a3c
Merge pull request #11291 from JosJuice/gba-tas-input
...
DolphinQt: Add GBA TAS input window
2022-11-22 23:49:43 +01:00
Admiral H. Curtiss
81557f611a
Qt/GameCubePane: Display a warning if a GCI folder override is set.
2022-11-22 17:53:20 +01:00
Admiral H. Curtiss
c18d6c3deb
Config: Use JPN for custom GCI folder paths.
2022-11-22 17:53:20 +01:00
Admiral H. Curtiss
86d01c3399
Config: Add option to use JPN as the Japanese region directory in GetDirectoryForRegion().
...
See https://bugs.dolphin-emu.org/issues/13076 for motivation for this.
2022-11-22 17:53:19 +01:00
Admiral H. Curtiss
1089d3cab6
GCMemcardDirectory: Compare GCI files in GetFileNamesForGameID() by their identity instead of their default filename.
2022-11-22 10:54:11 +01:00
Admiral H. Curtiss
4b0312ecf8
GCMemcardDirectory: Decode and strip strings for GCI filenames.
2022-11-22 10:54:11 +01:00
Admiral H. Curtiss
c517e92719
GCMemcardDirectory: Use HasSameIdentity() in LoadGCI().
...
This is cheaper and more accurate than comparing default GCI filenames.
2022-11-22 10:54:11 +01:00
Admiral H. Curtiss
b31b2db5fa
GCMemcard: Remove unused methods.
2022-11-22 10:54:10 +01:00
Admiral H. Curtiss
2132e005c3
Core: Add config setting for base GCI folder path.
2022-11-22 10:48:37 +01:00
Admiral H. Curtiss
5ebb894685
Updater: Delete the file we check for write rights with on Windows.
2022-11-22 02:38:42 +01:00