6fe621f203
Merge pull request #4589 from ligfx/cleaninputconfigdiag
...
InputConfigDiag: move function bodies out of header
2017-01-05 14:29:35 -05:00
0de4ad334f
Merge pull request #4605 from PEmu1/tas-gamecube-contro
...
Clarify GameCube Controller in TAS Input
2017-01-05 14:28:54 -05:00
495580637f
Merge pull request #4606 from BhaaLseN/clang-format-union
...
specify custom brace style to fix unions
2017-01-05 14:27:27 -05:00
9da6982ac3
Merge pull request #4608 from RisingFog/input_display_newlines
...
Add missing new lines for OSD
2017-01-05 14:25:24 -05:00
189e5f87fb
Merge pull request #4612 from PEmu1/memcard-menu
...
Don't Use Abbreviation for "Memory Card"
2017-01-05 14:22:54 -05:00
a10bb15f17
HLE: Add explicit initializers for OSBreakPoints' stub entry
...
No behavior change, this just makes implicit values explicit.
2017-01-05 14:15:45 -05:00
2941468857
HLE: Align table formatting
2017-01-05 14:13:30 -05:00
6d195f3d65
Don't Use Abbreviation for "Memory Card"
2017-01-05 10:06:46 -08:00
23d99f2f2c
specify custom brace style to fix unions
...
BreakBeforeBraces: Allman apparently includes all styles,
except for AfterUnion (which is false) when using clang-format -dump-config
2017-01-05 12:55:13 +01:00
41101be545
Merge pull request #4611 from lioncash/fileutil
...
IOFile: Minor changes
2017-01-05 09:17:03 +01:00
a93861ab49
DiscScrubber: Don't take SFileInfo instances by value
...
Avoids unnecessary copies.
2017-01-04 20:12:49 -05:00
c52d1e735a
DiscScrubber: Use an unsigned loop index in ParseDisc
...
Prevents an implicit signed to unsigned conversion when assigning a
partition's group number.
2017-01-04 20:03:12 -05:00
6ff21c48cb
DiscScrubber: Correct printf specifiers
2017-01-04 19:56:39 -05:00
b1a2dec78a
DiscScrubber: Convert a #define into a typed constant
2017-01-04 19:53:31 -05:00
a15be890e1
WII_IPC_HLE: Update the "IOS basics" comment
...
The codebase has changed since it was written, so it needed
a small update.
2017-01-05 01:11:52 +01:00
00268443ca
WII_IPC_HLE: Replace #defines with constexpr
2017-01-05 01:04:20 +01:00
9abfa54c9d
IOS HLE: Remove s_es_inuse
...
We don't really have to keep track of device opens/closes manually,
since we can already check that by calling IsOpened() on the device.
This also replaces some loops with for range loops.
2017-01-05 01:04:19 +01:00
045a8400e6
IOFile: Make the move constructor and move assignment operator noexcept
...
Certain parts of the standard library try to determine whether or not a
transfer operation should either be a copy or a move. The prevalent notion
of move constructors/assignment operators is that they should not throw,
they simply move an already existing resource somewhere else.
This is typically done with 'std::move_if_noexcept'. Like the name says,
if a type's move constructor is noexcept, then the functions retrieves an
r-value reference (for move semantics), or an l-value (for copy semantics)
if it is not noexcept.
As IOFile deletes the copy constructor and copy assignment operators,
using IOFile with certain parts of the standard library can fail in
unexcepted ways (especially when used with various container
implementations). This prevents that.
2017-01-04 18:37:48 -05:00
9b8f5bce22
IOFile: Change 'operator void*' into 'explicit operator bool'
...
'operator void*' is basically a pre-C++11-ism that was used, as C++03
only had the notion of implicit type-conversion operators, but not explicit type
conversion operators (allowing implicit conversion of a file handle to
bool can go downhill pretty quickly).
2017-01-04 18:10:21 -05:00
c541e1099e
IOFile: Make class variables private
...
Internals shouldn't be directly exposed.
2017-01-04 17:48:46 -05:00
c21dad9e83
IOFile: Get rid of unnecessary unimplemented copy constructor/assignment operator.
...
IOFile already inherits NonCopyable.
2017-01-04 17:47:40 -05:00
443815df16
DolphinWX: pass wxMsgAlert to main thread on non-GTK too
...
Fixes an issue on macOS where wxMessageBox always returns wxCANCEL when
not called from main thread.
2017-01-04 14:06:31 -08:00
5b1aae0cbf
DiscScrubber: Make struct and variable names conformant to the coding style
2017-01-04 17:04:41 -05:00
4a9bc2340b
DiscScrubber: Convert into a class
...
Allows potential multiple scrubbers to run at once. Also gets rid of the
need to explicitly clean up resources.
2017-01-04 16:06:21 -05:00
41b0c74e30
VideoCommon: Make dst_alpha state implicit.
2017-01-04 20:02:31 +01:00
b7d8bd13a6
OGL/Vulkan: Drop dual pass alpha.
2017-01-04 19:59:41 +01:00
b65ad538ba
IOS HLE: Refactor ExecuteCommand
...
ExecuteCommand was becoming pretty confusing with unused variables
for some commands, confusing names (device ID != IOS file descriptor),
duplicated checks, not keeping the indentation level low, and having
tons of things into a single function.
This commit gives more correct names to variables, deduplicates the
device checking code, and splits ExecuteCommand so that it's
easier to read.
It's worth noting that some device checks have been forgotten in the
past, which has caused a bug (which was recently fixed in 288e75f6
2017-01-04 19:33:50 +01:00
c5e731644c
Don't use GetEmulatedTime in GCMemcard
...
GCMemcard is only used outside of the core and has
no real reason to use the core's RTC. GetEmulatedTime
isn't designed to be called when the core isn't running.
Should fix https://bugs.dolphin-emu.org/issues/9871
2017-01-04 19:17:51 +01:00
2cfc0dc8b6
DSPDisassembler: directly initialize AssemblerSettings struct members
...
Same thing, less code.
2017-01-04 12:53:22 -05:00
afdcddc0c5
Add missing new lines for OSD
2017-01-04 10:49:52 -05:00
9f164d7c33
Merge pull request #4593 from lioncash/enum
...
JitRegCache: Move FlushMode enum into RegCache
2017-01-04 16:21:21 +01:00
176177af49
GeometryShaderGen: Use lower-left origin for point texture coordinates
...
From what I can tell, the emulated GPU places (0,0) at the lower left of
the image, and we were generating texture coordinates so that (0,0) was
at the upper-left in the expansion geometry shader, causing textures
used by point sprites to be flipped vertically.
Fixes the upside-down A button in Mario Golf.
2017-01-04 20:23:07 +10:00
2dae72f817
Clarify GameCube Controller in TAS Input
2017-01-03 18:03:17 -08:00
5518c6625b
PatchEngine: Get rid of a global variable
2017-01-03 18:59:33 -05:00
18792b2328
FifoPlayer: Don't set BPMEM_PRELOAD_MODE on load
...
Since in this case we're setting it based on the state at record start
time, not when a register is loaded, UseMemory would not be called, so
this could potentially wipe out texture memory that was valid.
2017-01-03 21:16:05 +10:00
5f3c878ba2
FifoPlayer: Save/restore texture memory state for fifo logs
2017-01-03 21:16:05 +10:00
438989668e
FifoDataFile: Add support for storing texture memory state
...
This bumps the file version to 4.
2017-01-03 21:16:04 +10:00
5b315b7bb4
FifoPlayer: Reload initial state when looping back to first frame
...
This should ensure that when playing with loop enabled, the first frame is
in the same state each time. There is potentially still issues when the
start frame is set to something other than zero, but I'm not sure how we
could work around this without capturing the entire state on each frame.
2017-01-03 17:32:45 +10:00
cc7c410cf1
Add debugging hotkeys
...
They are separated into 3 groups and will only be shown in the input config dialog if the emulator was in debug mode.
2017-01-02 18:16:52 -05:00
00e03f1436
Update the breakpoint list after an add from the parent
...
Doing it from the add dialogs instead would prevent the call to these dialogs outside of a breakpointWindow which would be necessary for hotkeys binding.
2017-01-02 15:39:21 -05:00
ec969da6bd
EXI_DeviceIPL: Remove m_bNTSC
...
It's only used in the constructor.
2017-01-02 21:08:24 +01:00
342b76a594
DSPJitRegCache: Make single argument constructor explicit
...
Prevents implicit conversions.
2017-01-02 15:03:31 -05:00
f85266df20
SConfig: Replace bNTSC with m_region
...
This lets us get rid of VideoInterface::SetRegionReg,
a huge hack in CEXIMemoryCard, and some minor things.
2017-01-02 20:57:48 +01:00
66ea9f5cc1
DiscIO: Add GetRegion function and Region enum
...
Instead of needing different switch cases for
converting countries to regions in multiple places,
we now only need a single country-to-region switch case
(in DiscIO/Enums.cpp), and we get a nice Region type.
2017-01-02 20:57:11 +01:00
f8c6b3b5f1
JitRegCache: Move FlushMode enum into RegCache
...
This also makes it a strongly-typed enum.
Considering that the flushing mode is a trait/behavior for the register
cache, it doesn't really make sense to have the enum separate from it.
This also has the benefit of removing constants from global scope.
2017-01-02 13:43:37 -05:00
3b4290b5b7
DSPJitRegCache: Make class variables conform to the coding style
2017-01-02 12:16:29 -05:00
6aef0630f7
Merge pull request #4588 from JosJuice/isoproperties-title-encoding
...
ISOProperties: Fix encoding errors in window title
2017-01-02 12:33:58 +01:00
96314a0ec1
Merge pull request #4574 from stenzek/vulkan-alpha-clear
...
Vulkan: Clear alpha channel to 0 when pixel format has no alpha channel
2017-01-02 12:29:36 +01:00
b46dcc7768
Merge pull request #4495 from slashiee/dump-textures-hotkey
...
Add a hotkey for toggling texture dumps
2017-01-01 17:28:56 -08:00
3f5f7fc564
Merge pull request #4590 from hthh/macos-no-pch-fix
...
macOS: Add missing includes to fix no-PCH build
2017-01-01 20:27:30 -05:00
a7f7ccc9d2
Merge pull request #4523 from RisingFog/overwrite_audio_warning
...
Display warning when dumping audio if file exists
2017-01-01 17:20:39 -08:00
387164a999
macOS: Add missing includes to fix no-PCH build
2017-01-02 11:45:24 +11:00
b10a0de769
Merge pull request #4535 from lioncash/regcache
...
Jit64: Make register caches not rely on the global jit variable
2017-01-01 18:01:29 -05:00
6c5063c76b
Merge pull request #4585 from lioncash/dspnamespace
...
DSP: Namespace remaining un-namespaced DSP code
2017-01-01 17:54:39 -05:00
4c90ad7514
Merge pull request #4490 from leoetlino/wii-dsy
...
Add common Wii SDK function signatures to the signature DB
2016-12-31 16:31:50 -08:00
e8052fbf78
Merge pull request #4587 from aldelaro5/fix-hidpi-mic
...
Add an empty spacer in the Mic Input config dialog
2016-12-31 16:24:46 -08:00
35fe8f762a
InputConfigDiag: move function bodies out of header
2016-12-31 15:47:56 -08:00
65d88776db
ISOProperties: Fix encoding errors in window title
...
It seems to be a regression, but I haven't bisected it.
2017-01-01 00:34:29 +01:00
d6674223db
Fix some margin discrepancies
2016-12-31 17:58:39 -05:00
3eb25cea6f
DSP: Namespace remaining un-namespaced DSP code
2016-12-31 17:20:14 -05:00
42e4dde960
Add an empty spacer in the Mic Input config dialog
...
This is done to not have the device combo box be too small in width when making the main sizer fit into the window. Not fitting the sizer would alternatively break Hidpi so it was best to just add an empty sizer to workaround this problem.
2016-12-31 16:17:47 -05:00
15de7d507f
Merge pull request #4519 from sepalani/fix_import_save
...
Fixes WiiSave import
2016-12-31 12:33:45 +01:00
a447213420
Remove the menu hotkeys of the debug menu bar
...
I think it's best to remove these if we are going to be adding new hotkeys since these would work no matter what so I can simply make these the default one instead.
2016-12-30 14:18:10 -05:00
a2e191649d
Merge pull request #4471 from Armada651/hybrid-depth
...
VideoCommon: Don't process the depth range in the vertex shader if it's not oversized.
2016-12-29 18:49:27 +01:00
efbf261e97
DSPAnalyzer: Fix two clang warnings about sign mismatched types
2016-12-29 10:10:38 -05:00
2aefa29941
DSP: Add the interpreter to the DSP namespace
2016-12-29 07:05:17 -05:00
c79cc3f470
DSP: Namespace the JIT
2016-12-28 20:38:41 -05:00
407f3af8c3
JitRegCache: Get rid of reliance on the jit global variable
2016-12-28 17:52:58 -05:00
8ece485a2f
JitRegCache: Make member variables conform to our coding style
2016-12-28 17:47:26 -05:00
e291e8f1a7
JitRegCache: Convert #define macro into a typed constant
2016-12-28 17:47:26 -05:00
4ae23fc45c
JitRegCache: Remove unused typedefs
2016-12-28 17:47:26 -05:00
b629eb300a
JitRegCache: Remove unused Flush function
...
This was kind of a pointless function, considering the parameter wasn't
used at all, so the other Flush() function could have been just directly
used instead.
2016-12-28 17:47:26 -05:00
41d47dda93
JitRegCache: Move implementation details into the cpp file where applicable
...
Any future changes to these register cache functions won't require everything that includes the register cache header to also be recompiled.
2016-12-28 17:47:26 -05:00
d1fc694c02
JitRegCache: Move protected interface below public interface
2016-12-28 17:47:26 -05:00
1a34376f3a
JitRegCache: Separate FPURegCache and GPRRegCache into their own files
...
Keeps them separated from one another and makes it less annoying to find
member functions (which were previously spread out all over the place).
2016-12-28 17:47:25 -05:00
10b4f6a250
Merge pull request #4568 from degasus/texcache
...
TextureCache: Add a dirty bit for partial updates on overlapping EFB copies.
2016-12-28 16:38:16 +01:00
905750553f
ControllerEmu: Fix LoadDefaults to use ciface argument
2016-12-27 17:46:40 -08:00
5c938ed41f
DSPTables: Move function type aliases into DSPOPCTemplate
...
Gets two typedefs out of global scope
2016-12-27 18:31:42 -05:00
ee7a2edf35
Update comments
2016-12-27 21:32:52 +01:00
65b5765858
VideoBackends: Clamp the range to the maximum depth value supported in the z buffer.
2016-12-27 20:25:40 +01:00
d0a73c1d90
TextureCache: Add a dirty bit for partial updates on overlapping EFB copies.
2016-12-27 17:26:04 +01:00
2ab6711f43
VideoBackends: Use the full depth range when inverted depth range is unsupported.
2016-12-27 14:31:17 +01:00
ef82aebb97
VideoCommon: Don't process the depth range in the vertex shader if it's not oversized.
2016-12-27 14:31:17 +01:00
8e506cb974
Merge pull request #4572 from lioncash/flags
...
DSPAnalyzer: Hide implementation details
2016-12-27 10:36:12 +01:00
e6249619a0
Vulkan/GL: Set the alpha channel to 0 when creating the EFB framebuffer
2016-12-27 13:06:08 +10:00
dd00f9ea34
Should fix being unable to change memory card slot A
2016-12-26 22:03:14 -05:00
d1dd910f17
Vulkan: Clear alpha channel to 0 when pixel format has no alpha channel
2016-12-27 12:59:52 +10:00
12e335025d
DSPEmitter: Make FlagsNeeded() a const member function
...
This doesn't modify any class data.
2016-12-26 21:18:24 -05:00
a8459fc189
DSPAnalyzer: Hide implementation details
...
Makes accessing flags a part of the function interface instead of exposing
an internal variable.
2016-12-26 21:18:18 -05:00
cd29d565c4
Merge pull request #4570 from lioncash/dspemit
...
DSPEmitter: Minor cleanup
2016-12-27 02:05:10 +01:00
6b65344ccf
axwii: re-add the missing sync -- might work better with the new MailHandler implementation
2016-12-27 02:03:58 +01:00
7c4bbcf22f
ax: switch to new style interrupt triggering
2016-12-27 02:03:55 +01:00
fd54d4f767
Merge pull request #4569 from degasus/texcache2
...
TextureCache: Extract BP enum check to VideoCommon.
2016-12-27 01:43:57 +01:00
50b1fcb1ed
DSPEmitter: Initialize compileSR in the initializer list
2016-12-26 19:42:09 -05:00
f3d353a85d
DSPEmitter: Move typedefs into DSPEmitter
...
Keeps them associated with the emitter itself, rather than just letting
them sit in global scope.
2016-12-26 19:19:39 -05:00
646d96a216
DSPEmitter: Convert defines into typed constants
...
Also moves them into more qualified scopes where possible.
2016-12-26 19:16:01 -05:00
c37889efcb
DSPEmitter: Use std::vector instead of raw allocation
2016-12-26 19:03:35 -05:00
400d5f6940
DSPEmitter: In-class initialize variables
2016-12-26 18:07:15 -05:00
abf9bb170b
TextureCache: Drop unused parameter in backend API.
2016-12-26 22:10:32 +01:00
04f319066d
TextureCache: Extract BP enum check to VideoCommon.
...
We have TOO many video backends.
2016-12-26 22:10:21 +01:00
1af9f68240
Merge pull request #4566 from JosJuice/charset-terminology
...
Remove incorrect usage of "ASCII" and "ANSI"
2016-12-26 15:40:45 -05:00
0f1ce0e1f4
Remove incorrect usage of "ASCII" and "ANSI"
...
Windows-1252 was sometimes being referred to as ASCII or ANSI
in Dolphin, which is incorrect. ASCII is only a subset of
Windows-1252, and ANSI is (rather improperly) used in Windows
to refer to the current code page (which often is 1252 on
Western systems, but can also be something entirely different).
The commit also replaces "SJIS" with "Shift JIS". "SJIS"
isn't misleading, but "Shift JIS" is more commonly used.
2016-12-26 15:49:39 +01:00
8f9f2b1f76
DSPHLE: Seperate HLE construction and initialization.
...
We must be able to construct the HLE without emulating the initialization
on loading a savestate.
2016-12-26 12:25:57 +01:00
4ebd369218
Merge pull request #4564 from JosJuice/volumedirectory-references
...
VolumeDirectory: Don't use references inappropriately
2016-12-26 11:48:38 +01:00
8e4a781974
VolumeDirectory: Modernize variable names
2016-12-26 11:45:22 +01:00
00aa2d37e9
VolumeDirectory: Don't use references inappropriately
...
Integers should be passed as pointers when a function
modifies them (to make it clear that they get modified).
2016-12-26 09:52:18 +01:00
2d1bdae1f0
Merge pull request #4563 from lioncash/dspemit
...
DSPEmitter: Get rid of an unused member variable
2016-12-26 04:07:07 +01:00
042045012b
DSPEmitter: Get rid of an unused member variable
2016-12-25 21:31:17 -05:00
57a005ff3e
evdev: reduce startup time
...
GetName() creates a new evdev device which calls tons of ioctls. But the
main culprit is close() which for input devices appears to be a slow
path in the kernel.
This commit reduces PopulateDevices() by 50% on my laptop, but ~730 ms
is still ridiculously slow for something that isn't needed right away.
2016-12-26 01:24:35 +01:00
9c8e27e3bb
Merge pull request #4558 from JosJuice/volumedirectory-fst-sort
...
VolumeDirectory: Sort the FST
2016-12-25 17:38:58 -05:00
81d452ecda
Merge pull request #4551 from JosJuice/movie-controller-comment
...
Movie: Replace incorrect name and comment for numControllers
2016-12-25 17:36:27 -05:00
40e36ebd1e
Merge pull request #4550 from linkmauve/no-readdir_r
...
Common: Replace deprecated readdir_r with readdir
2016-12-25 17:34:50 -05:00
8ad6c3e911
Merge pull request #4555 from JosJuice/right-click-host-name
...
Fix player name not being loaded when using "Host with Netplay..."
2016-12-25 17:32:26 -05:00
8da0396fc4
Merge pull request #4559 from JosJuice/volumedirectory-totalnamesize-local
...
VolumeDirectory: Make m_totalNameSize a local variable
2016-12-25 17:30:21 -05:00
29ec069ac6
Merge pull request #4552 from JosJuice/pr-4461-translations
...
Mark strings added by PR #4461 for translation
2016-12-25 17:06:32 -05:00
3196f697bb
VolumeDirectory: Use a range-based for loop in ComputeNameSize
2016-12-25 23:01:42 +01:00
f3987d13ea
VolumeDirectory: Make m_totalNameSize a local variable
...
After BuildFST finishes executing, it's never needed again.
2016-12-25 22:57:14 +01:00
d1defd71df
Merge pull request #4557 from JosJuice/scandirectorytree-comments
...
Fix outdated comments in ScanDirectoryTree
2016-12-25 16:48:17 -05:00
a502f069e8
VolumeDirectory: Sort the FST
...
We can't rely on the OS returning files and directories
in a deterministic order, so we should sort them on our own
if we want VolumeDirectory to work for movies and netplay.
2016-12-25 22:35:38 +01:00
e56bec9c87
Fix outdated comments in ScanDirectoryTree
2016-12-25 21:57:33 +01:00
190c6218ab
Merge pull request #4493 from Tilka/evdev
...
Fix evdev threading
2016-12-25 20:55:50 +01:00
44acd9fdb9
VideoCommon: use u32 for texture addresses
2016-12-25 18:48:19 +01:00
70d9440d10
Fix player name not being loaded when using "Host with Netplay..."
2016-12-25 16:36:19 +01:00
c0710d3593
Mark strings added by PR #4461 for translation
...
Also fix the HKGP_FRANE_ADVANCE typo.
2016-12-24 19:26:21 +01:00
55fe77e986
Movie: Replace incorrect name and comment for numControllers
...
Also add similar comments to the variables memcards and bongos.
2016-12-24 18:27:56 +01:00
1963996dd0
Change RasterFont static const names
...
Fixes build issue with GCC/CPP 6.2.1 build issues on Fedora 26
2016-12-24 11:58:07 -05:00
495dfdb16c
Common: Replace deprecated readdir_r with readdir
...
Fixes a warning under recent glibc.
2016-12-24 16:18:47 +01:00
abfa297166
Merge pull request #4545 from leoetlino/stop-recording
...
Stop Movie/Netplay before triggering STM shutdown
2016-12-24 06:14:51 -05:00
c5243d6d12
CommandProcessor: Remove unimplemented prototypes
2016-12-24 01:15:50 -05:00
ec729e2ee3
Stop Movie/Netplay before triggering STM shutdown
...
This fixes a bug which caused Movie (input recording or playback) or
netplay not to be stopped. DolphinWX previously triggered a STM power
event, and then the STM directly stopped the emulation; the code
which stops Movie/Netplay was completely skipped.
This is fixed by moving it /before/ sending the shutdown event.
2016-12-24 00:44:30 +01:00
01c2c50f6a
Merge pull request #4540 from lioncash/dspemit
...
DSP: Move DSPEmitter into the Jit subdirectory
2016-12-23 12:13:47 +01:00
9160be50db
Merge pull request #4224 from lioncash/tcache
...
TextureCacheBase: Eliminate static state
2016-12-23 04:33:42 -05:00
a309449a7f
Silences an error during compilation due to an unused (but set) variable
2016-12-22 19:44:47 -06:00
5852e3961d
DSPMemoryMap: Move function implementations into the cpp file
...
This allows removing DSPCore and DSPTables includes from the header file.
Doing allows resolving quite a bit of indirect includes that were present
throughout the DSP source files.
Another plus with this is that changes to the DSPEmitter don't require an
almost total rebuild of all DSP source files. The underlying reason for
most of the files being rebuilt it because DSPMemoryMap is used quite
extensively, however its header includes DSPTables.h. DSPTables.h includes
DSPEmitter.h as it uses the DSPEmitter type in a typedef. So any change to
the emitter would propagate through the DSPMemoryMap header. This will no
longer happen.
2016-12-22 20:09:52 -05:00
af28ce7ecb
DSP: Move DSPEmitter into the Jit directory
...
This is actually used as the DSP JIT, so this should be with the other JIT
source files.
This commit also makes it so changes to the JIT emitter don't require
recompiling all of the DSP core (i.e. changing the JIT won't require the
interpreter to be rebuilt).
2016-12-22 19:50:03 -05:00
a4cd11ec87
DSP: Move interpreter source files to their own directory
...
Keeps code organized similar to the DSP JIT.
2016-12-22 18:18:48 -05:00
9131b994bb
DSPTables: Move interpreter specifics to DSPInterpreter
2016-12-21 15:40:45 -05:00
a5e555e609
DSPInterpreter: Alphabetically sort opcode function definitions
...
Makes browsing slightly nicer.
2016-12-21 14:43:38 -05:00
7ecf3d6955
DSPTables: Amend table formatting
...
Restores them to what they were before the codebase-wide reformatting and
adds annotations to specifically not format them.
2016-12-21 03:51:53 -05:00
8192af9b3d
Merge pull request #4533 from lioncash/jits
...
Jit64/JitIL: Get rid of trivial global jit variable usages
2016-12-20 21:09:50 -05:00
ca91b6df52
Merge pull request #4521 from JosJuice/tgc
...
Add TGC disc image compatibility
2016-12-20 17:45:39 -06:00
a98fd57da7
JitArm64: Add missing override specifiers
2016-12-20 17:30:13 -05:00
cd4449f881
Merge pull request #4501 from flibitijibibo/disabletooltips
...
DolphinWX: Add 'DisableTooltips' config option (R2)
2016-12-20 17:20:24 -05:00
513ace1c0c
JitIL: Get rid of trivial global jit variable usages
2016-12-20 12:56:06 -05:00
66034de20b
Jit64: Get rid of trivial global jit variable usages
...
Jit64 inherits from Jitx86Base which inherits from JitBase. JitBase
contains jo and js, which are instances of the JitOptions and JitState
structs. Because of the inheritance, there's no actual need to access the
jit global in order to get to these instances. They're already accessible
via the class hierarchy.
2016-12-20 12:55:58 -05:00
b5fe0b5b83
Merge pull request #4528 from stenzek/vulkan-descriptor-crash
...
Vulkan: Fix crash where a potentially deleted buffer is referenced
2016-12-20 11:11:54 +01:00
05af5b292f
EmuCodeBlock: Amend member variable names to conform to coding style
2016-12-19 17:55:44 -05:00
e373a48a51
EmuCodeBlock: Make farcode and nearcode protected
...
This is the only context they're used in.
2016-12-19 17:36:29 -05:00
2c8cc0f648
Merge pull request #4527 from leoetlino/fix-dvd-backup
...
DolphinWX: Fix booting from DVD
2016-12-19 16:22:29 -05:00
8d812db9ad
SymbolDB: Use set to map hash with symbols
2016-12-19 21:03:29 +00:00
7e974f1064
SymbolDB: GetSymbolsFromHash added
2016-12-19 21:03:28 +00:00
d778b8a820
SymbolDB: GetSymbolsFromName added
2016-12-19 21:02:23 +00:00
0b12c6986a
SignatureDB: Add missing license headers
2016-12-19 15:57:21 -05:00
10862cd0e8
Merge pull request #4522 from lioncash/jitutil
...
Jit64Common: Split Jit64Util contents into separate files
2016-12-19 15:49:49 -05:00
4e405010a3
Merge pull request #4497 from sepalani/totaldb.csv
...
Import/Export signature files as CSV
2016-12-19 15:45:21 -05:00
b9dc73d9cd
Merge pull request #4529 from RisingFog/remove_dead_code
...
Remove leftover SkipIdle function
2016-12-19 15:32:43 -05:00
2e2ba37bc1
Remove leftover SkipIdle function
2016-12-19 15:20:56 -05:00
01047319f8
Merge pull request #4517 from stenzek/mp3-blotches
...
TextureCache: Use same color coefficients for EFB2Tex as EFB2RAM
2016-12-19 22:11:38 +10:00
9290bf5844
Vulkan: Fix crash where a potentially deleted buffer is referenced
...
This happened when the geometry shader was disabled, and the uniform
buffer was grown to a larger size. The update would be skipped, leaving
the old buffer to be included in the descriptor set.
2016-12-19 22:00:42 +10:00
344f2e57f6
VideoCommon: Use avg(color1, color2) for color3 in CMPR textures
2016-12-19 20:17:44 +10:00
adcfefecde
DolphinWX: Fix booting from DVD
...
OnBootDrive used the "drives" member std::vector for drive paths, but
since PR #4363 , this vector is not populated anymore, so we were
accessing it out of bounds.
Actually, drives was not needed in the first place, since we can
get the wxMenu from the event, and from there, get the label directly.
2016-12-19 10:45:33 +01:00
989cdc0929
Merge pull request #4505 from hthh/macos-likes-pbos
...
OpenGL: Always use a PBO in EncodeToRamUsingShader
2016-12-19 09:47:40 +01:00
b4bc1c9339
WiiSave: Fixes vector assertions
2016-12-18 19:44:00 +00:00
9774b3f640
WiiSave: Fixes directory issues
2016-12-18 19:43:55 +00:00
9bd514ed1c
Add TGC disc image compatibility
2016-12-18 18:57:36 +01:00
94237b694b
Jit64Common: Split Jit64Util contents into separate files
...
Much of Jit64Util consists of essentials, not utilities. Breaking these
out into their own files also prevents unrelated includes from being
present near other classes.
This also makes it easier to find and change certain components of the
x86-64 JIT, should it be necessary.
2016-12-18 02:27:58 -05:00
debc40e85b
Display warning when dumping audio if file exists
2016-12-17 22:45:01 -05:00
a6114bad34
Import/Export signature files as CSV
2016-12-18 00:27:10 +00:00
f431b18675
Merge pull request #4491 from leoetlino/debugger-symbol-filter
...
DolphinWX: Add ability to filter symbols (by name)
2016-12-17 11:13:28 -06:00
accce4294a
TextureCache: Use same color coefficients for EFB2Tex as EFB2RAM
2016-12-15 02:20:46 +10:00
d6cdf49769
VideoSoftware: Don't drop least significant bit of 5-bit blue channels
2016-12-14 23:56:06 +10:00
8b6f8892d6
TrampolineCache: Make constant constexpr
2016-12-14 04:43:32 -05:00
d0c54fe15e
Jit64Util: Make constants constexpr
2016-12-14 04:43:31 -05:00
9c1ad3dde6
Jit64Base: Replace #defines with concrete constants
2016-12-14 04:43:31 -05:00
d010246af2
Jit64Base: Clean up casting
...
Mostly intended to clean up HandleFault than anything else.
2016-12-14 04:43:31 -05:00
1aff8c4eb1
BlockCache: Use const_cast
2016-12-14 04:43:30 -05:00
36c99df9f5
Jit: Move most x86-64-specific code out of JitCommon
2016-12-14 04:43:25 -05:00
5aaa5141ed
PixelShaderGen: Fix incorrect indexing of tevLerpBias
...
Fixes the white box in the fortune street fifolog.
2016-12-13 00:03:25 +10:00
d64c9dd5c9
Merge pull request #4419 from degasus/master
...
Jit64: Fix a few trivial PIE issues.
2016-12-12 10:58:16 +01:00
801d1d1876
OpenGL: Always use a PBO in EncodeToRamUsingShader
...
This improves performance significantly on macOS, particularly
noticeably in the Super Mario Sunshine transition, which goes
from ~5FPS to ~17FPS.
2016-12-12 20:33:41 +11:00
607ce40f0b
OGL: Fix black screen when MSAA is enabled
2016-12-12 17:51:19 +10:00
863aeb383a
Merge pull request #4509 from lioncash/assign
...
ShaderManagers: Use aggregate initialization for some variables.
2016-12-11 13:53:28 +01:00
6ed462a059
Merge pull request #4511 from lioncash/ac
...
AudioCommon: Remove unnecessary headers
2016-12-11 13:52:59 +01:00
87f2a74c08
AudioCommon: Remove unnecessary headers
...
Now AudioCommon code won't need to be recompiled if the TAS movie header
is ever modified.
2016-12-11 06:11:37 -05:00
8dcb05802b
ShaderManagers: Use aggregate initialization for some variables.
...
These provide the same semantics, however aggregate initialization
doesn't force the structs to be trivially copyable. memset, on the other
hand, does.
2016-12-10 17:33:51 -05:00
993e029f75
Merge pull request #4506 from stenzek/vulkan-no-depth-clamp
...
Vulkan: Fix viewport depth when depth clamp is unsupported
2016-12-11 01:57:25 +10:00
a0920afd5b
Merge pull request #4500 from leoetlino/fileio-fix
...
IPC_HLE: Fix incorrect file path for IOCTL_SET_ATTR
2016-12-09 17:48:21 -05:00
09fdab7fb4
HLE: Add a hook for JUTWarningConsole_f
...
JUTWarningConsole_f calls vprintf, but in a way we currently don't
handle (which messes up the printed message). However, it is a standard
debug print function, so we can directly hook it instead of waiting for
the vprintf call.
This is necessary to fix debug output in a few games now that vprintf
is properly detected in more games.
2016-12-09 23:40:06 +01:00
58a5395173
TextureCacheBase: Eliminate static state
2016-12-09 16:50:37 -05:00
7a5bb46016
Merge pull request #4030 from clinchergt/fix-setfocus-rendertowindow
...
Fix focus bug when using the "render to main window" feature
2016-12-09 15:39:31 -06:00
1fa61af413
Merge pull request #4492 from aldelaro5/gc-mic-ui-reimplement
...
Move the GameCube mic button configuration to the GameCube config dialog
2016-12-09 14:53:47 -06:00
b042377393
Merge pull request #4494 from lioncash/isoproperties
...
ISOProperties: Separate the filesystem tab out into its own class
2016-12-09 07:55:36 -05:00
af706efaef
Vulkan: Fix viewport depth when depth clamp is unsupported
2016-12-09 22:45:10 +10:00
7cfead6429
DolphinWX: Add 'DisableTooltips' config option
...
(Revision 2: Remove checkbox from WX GUI)
2016-12-07 13:20:37 -05:00
10c7e56689
IPC_HLE: Fix incorrect file path for IOCTL_SET_ATTR
...
We were reading the string from the wrong location…
2016-12-07 13:52:44 +01:00
31ccfffd38
Common: Add alignment header
...
Gets rid of duplicated alignment code.
2016-12-06 20:33:53 +01:00
9ff95c58fa
Add a special input configuration dialog for the GameCube Mic
...
This is more logical as the mic is plugged into an EXI slot so it should be configured via the GameCube config dialog. This also allows to pass the right port number for the new dialog.
2016-12-05 18:09:31 -05:00
431929fa1d
Moved the Mic button of the GCPad to its own group.
...
This is needed to separate it from the GCPad input configuration dialog as it would be moved to its own dialog.
2016-12-05 18:09:23 -05:00
e31aa70ff8
Add a hotkey for dumping textures
2016-12-05 08:20:45 -08:00
7192789c11
Merge pull request #4486 from stenzek/gl-minimize-assert
...
OGL: Fix assertion when minimizing window
2016-12-05 12:46:29 +01:00
ddeccf2622
ISOProperties: Separate the filesystem tab out into its own class
2016-12-04 22:35:01 -05:00
bff394ec8a
Merge pull request #4489 from stenzek/vulkan-minor-fixes
...
Vulkan: Minor fixes
2016-12-05 12:19:49 +10:00
f575902cf3
evdev: set flag in a thread-safe way
2016-12-05 00:47:26 +00:00
3c090a37d4
evdev: fix shutdown hang
...
Note: This probably means our approach of populating from udev isn't
safe to be called multiple times.
2016-12-05 00:47:26 +00:00
0043bd3547
Remove two unused variables
2016-12-05 00:47:26 +00:00
59abfee11d
DolphinWX: Add ability to filter symbols (by name)
...
This allows the user to filter symbols by name, instead of having to
scroll through a very, very long listbox…
2016-12-04 18:18:07 +01:00
5082a664c8
VertexLoaderX64: Avoid unchecked pointer cast.
2016-12-04 13:09:16 +01:00
21f3e97435
Jit64: Avoid pointer casts if possible.
2016-12-04 13:09:16 +01:00
f325d41def
DSPJit: Use tmp register for pointer immediate.
...
PIE.
2016-12-04 13:09:16 +01:00
d26709f713
Jit64: Use ImmPtr for mtcrf.
...
Only a small overhead, but PIE compatible.
2016-12-04 13:09:16 +01:00
8189ef432b
Jit64: Use ImmPtr for mcrxr.
...
Only a small overhead, but PIE compatible.
2016-12-04 13:09:16 +01:00
23c284c081
Jit64: Use ImmPtr for inst.OE handling.
...
A bit slower, but PIE compatible and *very* rarely.
2016-12-04 13:09:15 +01:00
8f97a24904
Vulkan: Enable GS instancing
2016-12-04 20:53:49 +10:00
9736198c3b
Vulkan: Use explicit barriers instead of dependancies
...
At least on NV, some of these don't seem to have the intended effect. One
known instance of this is in texture conversion.
2016-12-04 20:10:13 +10:00
a475792163
Vulkan: Fix incorrect logic in readback preemption
...
This could have been causing a large number of command buffer
submissions per frame, depending on when the readbacks occured.
2016-12-04 20:10:13 +10:00
58978c1440
Vulkan: Faster path for decoding XFB data
...
Using a texel buffer as the copy destination removes the need to copy to
an intermediate texture first.
2016-12-04 20:10:13 +10:00
804cd0ff03
Vulkan: Move XFB encoding/decoding to TextureConverter
2016-12-04 20:10:13 +10:00
d67463e0a7
Vulkan: Simplify palette texture conversion
2016-12-04 20:10:13 +10:00
add638538b
Vulkan: Combine PaletteTextureConverter and TextureEncoder classes
2016-12-04 20:10:13 +10:00
804af42ccc
Vulkan: Support binding texel buffers in UtilityShaderDraw
2016-12-04 20:10:13 +10:00
e241ec6666
Vulkan: Implement StagingTexture2D on top of StagingBuffer
...
Greatly simplifies things, and we weren't using the linear texture
implementation anyway.
2016-12-04 20:10:13 +10:00
4bc0e14995
Vulkan: Use an enumeration to index pipeline layouts
2016-12-04 20:10:13 +10:00
cd3481fbc7
Vulkan: Differentiate between descriptor set layouts and bind points
...
This also moves the pipeline and descriptor set layouts used for texture
conversion (texel buffers) to ObjectCache, and shares a binding location
with the SSBO set.
2016-12-04 20:10:13 +10:00
4e9018049d
Vulkan: Support logging debug reports without enabling validation layers
...
There is a caveat, Host GPU must be checked prior to starting the game, as
we can't enable the extension at runtime without recreating the instance.
2016-12-04 19:55:12 +10:00
1cfb0a1185
Vulkan: Fix deadlock in some resize scenarios
...
Only have experienced this on a few occasions when using the anv driver.
2016-12-04 19:12:33 +10:00
d1c89db8c8
Merge pull request #4448 from lioncash/isoproperties
...
DolphinWX: Separate the information panel from ISOProperties
2016-12-03 19:15:25 -05:00
2ef884893a
Vulkan: Fix map error when texture dumping is enabled
2016-12-04 00:23:34 +10:00
4c860ddb70
Vulkan: Fix typo in PopulateBackendInfoMultisampleModes
2016-12-04 00:23:30 +10:00
730ec3809a
Vulkan: Remove unused variable
2016-12-04 00:23:25 +10:00
107e8c8ee7
OGL: Fix assertion when minimizing window
...
Also fixes a potential divide by zero in Renderer::RenderText.
2016-12-03 20:35:14 +10:00
f798bcd5c0
DolphinQt2: InfoWidget: explicit type for std::min
...
Avoids errors on macOS:
```
Source/Core/DolphinQt2/Config/InfoWidget.cpp:190:21: error: no matching function for call to 'min'
u64 read_size = std::min(file_data.size(), game_size - read_offset);
^~~~~~~~
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/algorithm:2589:1: note: candidate template ignored: deduced conflicting types for parameter '_Tp' ('unsigned long' vs. 'unsigned long long')
min(const _Tp& __a, const _Tp& __b)
```
2016-12-02 21:26:18 -08:00
7b1966a680
Vulkan: Fix assertion triggering when geometry shaders are unsupported
...
Happened when loading the pipeline UID cache.
2016-12-02 17:37:10 +10:00
20fcfd0ed8
DolphinWX: Separate the information panel from ISOProperties
...
Makes the information panel self-contained.
This was done first, as opposed to isolating the GameConfig panel--the
first panel in the group--as this panel had code all over the place in
ISOProperties, so I figured it'd be best to fix this one up first.
2016-12-01 21:21:46 -05:00
2e7c90eeb5
Merge pull request #4450 from PEmu1/fifo-player-capitalization
...
Update FIFO Player Window Capitalization
2016-12-01 21:09:44 -05:00
0705c53681
Merge pull request #4340 from sepalani/step_timeout
...
CodeWindow: Fix step out issues
2016-12-01 13:32:44 -06:00
25fe999a79
Added support for Wii RVT-R disc images.
...
These disc images are encrypted and signed using a different set of keys.
We only care about the master key, so we check the signature issuer. If
it matches the debug issuer, then we'll use the RVT-R key. Otherwise,
the previous set of common and Korean keys are used.
2016-12-01 07:51:29 -05:00
ffe20705dd
Merge pull request #4362 from ligfx/osxhotplug
...
ControllerInterface: enable hotplugging on macOS
2016-12-01 00:29:56 -06:00
7ed8fb95c5
ControllerInterface: enable hotplugging on macOS
2016-11-30 22:27:46 -08:00
a95e3c875e
Merge pull request #4343 from ligfx/fixsdlcrash
...
ControllerInterface: Fix crashes when using SDL controllers
2016-11-30 20:47:38 -06:00
e2018f2208
Merge pull request #4480 from stenzek/vulkan-streambuffer-reuse
...
Vulkan: Fix stream buffer re-use problems
2016-12-01 12:38:31 +10:00
3e69d066f5
ControllerInterface: replace Reinitialize with RefreshDevices
...
The SDL backend crashes when you close a joystick after SDL_Quit has
been called. Some backends don't need to be shutdown and
re-initialized everytime, we can just ask to enumerate devices again.
2016-11-30 16:07:55 -08:00
cebb4d84f2
ControllerInterface: clear devices before shutting down backends
...
The SDL backend faults if it tries to close a joystick after SDL_Quit
has been called.
2016-11-30 16:07:54 -08:00
90c2dec02d
Wii IPC HLE: do not clobber memory when launching a new title
...
It's questionable whether ES_LAUNCH should write *anything* to the
command structure at all, ever, given that it never actually returns
it back through the mailbox. But it *definitely* shouldn't write
anything to it if it has just launched a DOL, because otherwise it might
clobber code/data from the just-loaded application.
2016-12-01 06:55:15 +09:00
288e75f672
Wii IPC HLE: Fix IPC missing reply fail
2016-12-01 06:38:51 +09:00
2b906e3fc4
DOL/ELF loaders: enable HID4.SBE in Wii mode
...
When booting "cooked" executables, BATs should already be set up and
enabled. They should only really be disabled when booting NAND contents
in real mode.
2016-12-01 06:36:53 +09:00
a6742d9cf7
ELF boot: scan segments for Wii mode detection, not sections
2016-12-01 06:36:53 +09:00
3f11879640
ES HLE / WAD boot: hardcode the entrypoint
...
NAND titles are always started at address 0x3400 with translation off.
The entrypoint in the DOL is ignored.
2016-12-01 06:36:53 +09:00
ca691a9d95
Vulkan: Allow re-use of uniform buffers when doing per-stage uploads
...
This is safe now because we invalidate the pointers after submitting a
command buffer.
2016-11-30 23:34:46 +10:00
6a4eba1153
Vulkan: Replace explicit command buffer submits with wrapper function
...
Should we ever introduce anything else that has to be done when a command
buffer is executed (e.g. invalidating constants from previous commit), we
don't have to update all the callers.
2016-11-30 23:14:36 +10:00
3adeacb78d
Vulkan: Fix case where uniforms could be overwritten
...
If a draw caused a command buffer submission, the current uniform storage
should not be used for the new command buffer.
2016-11-30 23:14:35 +10:00
4c11735bd5
Vulkan: Fix case where a draw's vertices could be overwritten
...
This could happen because the vertex memory was already committed, if a
uniform buffer allocation failed and caused a command buffer to be
executed, it would be associated with the previous command buffer rather
than the buffer containing the draw that consumed these vertices.
2016-11-30 22:45:00 +10:00
37550501cc
Vulkan: Fix incorrect handling of buffer wrap-around in StreamBuffer
...
This was happening when a fence wait happened mid-frame. The data written
between the fence being queued and the allocation occuring was incorrectly
assumed to be consumed by the GPU.
2016-11-30 22:44:52 +10:00
8647639746
Android: Fix Wii bindings resetting everything
2016-11-29 22:27:40 -05:00
3cfc49a613
Merge pull request #4472 from JosJuice/revert-absolute-path
...
IOS HLE: Replace broken path traversal prevention
2016-11-29 18:34:22 +01:00
f705d8378e
Fix the order of the name of the hotkeys
2016-11-29 11:51:55 -05:00
aadc77c493
Merge pull request #3649 from stenzek/wgl-core-shared
...
GLInterface: Implement core and shared context creation for WGL
2016-11-29 22:59:31 +10:00
eebe4ef1fd
Merge pull request #4461 from aldelaro5/hotkey-config-redo
...
Redo every input configuration dialog
2016-11-29 07:39:28 -05:00
7353cae707
GLInterface: Implement core and shared context creation for WGL
2016-11-29 20:04:32 +10:00
32a0dae257
Completely redo All configuration dialog
...
Hotkeys
Make a new class that inherits from InputConfigDialog with a specialised constructor. The changes are mainly the top portion and it now uses tabs to categorise the hotkeys.
Redo the GCPad configuration dialog
The layout is similar, but it now allows flexibility to change it more easily.
Redo the GC Keyboard configuration dialog
Same layout.
Redo completely the Wiimote configuration dialog
Separated the controls into 2 tabs to make them less imposing overall.
Redo the Nunchuk configuration dialog
Similar layout, except for 2 control group sizers.
Redo the Classic controller configuration dialog
Same layout.
Redo the Guitar input configuration dialog
Stacked 2 sets of group together.
Redo the Turntable configuration dialog
More stacked groups and the window is much less wide.
2016-11-28 08:26:34 -05:00
03e0cae9b7
Prepare for having different extensions dialogs
...
Just setting up a switch on the type so that different dialogs can be instantiated. This also makes the extension type an enum because I don't see why not here and finally, it removes ControlGroupSizer. This removal allows to not dynamically generate the UI, but instead, let the specialised constructors do the layout.
2016-11-28 08:26:34 -05:00
00f680b830
Add flexibility to InputConfigDialog
...
Removed the unecessary forced tabbed layout, removed the layout part of the constructor and remade some method in preparation for tabbed styled input dialog such as the new hotkey configuration one. It breaks every inputconfigDialog, but this will get fixed in the next commits.
Also moved to a folder since there will be many more files created in the next commits so it gives better separation.
2016-11-28 08:26:27 -05:00
0212741574
Merge pull request #4436 from stenzek/vulkan-full-ir-framedump
...
VideoBackends: Internal resolution frame dumping
2016-11-28 22:05:16 +10:00
49e807b71f
Merge pull request #4459 from stenzek/nogui-resize-notify
...
DolphinNoGUI: Receive resize events and notify backend when this occurs
2016-11-28 22:04:21 +10:00
b81dee8b9a
OGL: Support full-resolution frame dumping
2016-11-28 21:54:56 +10:00
93221e7f48
OGL: Move frame rendering procedures to seperate methods
2016-11-28 21:54:56 +10:00
1c1a686f63
Vulkan: Support full resolution frame dumping
2016-11-28 21:54:55 +10:00
adc22a5e20
VideoCommon: Add method for calculating full-scale framedump rectangles
2016-11-28 21:54:54 +10:00
8d48319414
Vulkan: Validate the pipeline cache before using it
...
This ensures that if a user changes adapters or vendors we're not passing
invalid data to the driver.
2016-11-28 21:21:55 +10:00
9604b336c8
Vulkan: Don't destroy the device's pipeline cache on MSAA mode change
...
The user could switch back again, and this would mean this data would be
lost. Disk space is cheap, and it's not going to be much.
2016-11-28 21:21:54 +10:00
aac66a1b61
Vulkan: Implement a pipeline UID cache
...
This stores enough information to recreate the pipeline, including the
shader UIDs, blend/depth/rasterization state, primitive and vertex format.
2016-11-28 21:21:53 +10:00
6db0ee9561
VideoCommon: Remove backbuffer size parameters from methods
...
We have the s_backbuffer_{width,height} fields to represent this, so
there's no point in passing them as parameters every time.
2016-11-28 20:14:59 +10:00
a83ca587c6
VideoCommon: Make FramebufferManagerBase::GetTargetSize public
2016-11-28 20:14:59 +10:00
a0a62c0f46
VideoConfig: Add option for full-resolution frame dumping
2016-11-28 20:14:59 +10:00
681294586b
Merge pull request #4455 from stenzek/png-frame-dumping
...
VideoCommon: Support dumping frames to images
2016-11-28 20:03:50 +10:00
e66373b7ff
Merge pull request #4456 from stenzek/vulkan-framedump-fix-2
...
Vulkan: Fix black borders in frame dumps
2016-11-28 20:03:08 +10:00
8dddc00ab0
Merge pull request #4474 from leoetlino/fewer-config-includes
...
Remove unnecessary ConfigManager includes
2016-11-28 10:01:13 +01:00
72e3f1ecec
Remove unnecessary ConfigManager includes
...
Making changes to ConfigManager.h has always been a pain, because
it means rebuilding half of Dolphin, since a lot of files depend on
and include this header.
However, it turns out some includes are unnecessary. This commit
removes ConfigManager includes from files which don't contain
SConfig or GPUDeterminismMode or GPU_DETERMINISM (which means the
ConfigManager include is not used).
(I've also had to get rid of some indirect includes.)
2016-11-27 22:38:38 +01:00
0c6fd47460
Add unit test for StringUtil's newly added JoinStrings
2016-11-27 22:11:14 +01:00
841e5893f4
IOS HLE: Add unit test for path/filename escaping
2016-11-27 22:11:05 +01:00
7a4f19ed98
IOS HLE: Correct handling of paths that don't start with /
2016-11-27 22:10:41 +01:00
6c275d472e
Merge pull request #4410 from SeannyM/android-inputbind
...
Android: Reimplement input binding
2016-11-26 18:00:57 -06:00
a90731e2ae
Android: Add input binding menus
2016-11-26 18:29:33 -05:00
d10b336b0a
Android: Add InputBindingSetting class
...
Also update MotionAlertDialog to work with the new setting, and remove the
old InputBindingPreference.
2016-11-26 18:29:25 -05:00
c74c317ab5
IOS HLE: More robust escaping of NAND paths
...
Prevents path traversal without needing an absolute path
function, and also improves accuracy (character sequences
like ../ appear to have no special meaning in IOS).
This removes the creation and usage of /sys/replace,
because the new escapes are too complicated to all
be representable in its format and because no other
NAND handling software seems to use /sys/replace.
2016-11-26 22:49:46 +01:00
de355a8521
Revert "IOS HLE: Prevent accessing host file system"
...
This reverts commit 141f3bfb3a
2016-11-26 15:50:28 +01:00
c84ab13e81
Merge pull request #4375 from leoetlino/ipc-hle-small-cleanup
...
IPC_HLE: Small cleanup
2016-11-25 17:50:14 -06:00
6473a485d0
Merge pull request #4460 from linkmauve/no-miniupnpc
...
NetPlay: Fix build when miniupnpc is disabled
2016-11-25 16:28:27 -06:00
7e99d03b7f
Add the ability to get partial input group
...
For hotkeys, changed HotkeyManager to allow to get and make partial groups of hotkeys.
Also preserved the old configuration naming scheme for the ini, this is done to preserve compatibility with the older groups structure.
Add the ability to get GCPad control groups
Used like the HotkeyManager methods, this is used for the new GCPad configuration dialog.
Add the ability to get groups of Keyboard input
Same reasons as the previous ones.
Add ability to get groups of Wiimote input
Add the ability to get extensions group
This needed to pass to 3 classes. Will be used for their respective dialogs.
2016-11-25 02:37:22 -05:00
11243ac358
Merge pull request #4470 from aldelaro5/fix-slowdown-logs
...
Change the patch engine log to be debug level log
2016-11-24 16:25:53 -06:00
5b44b37902
IPC_HLE: USB_KBD: Use the correct log type
...
Fixes logging to use the correct log type; it was originally STM
(likely an oversight).
2016-11-24 20:23:52 +01:00
20f2955ad9
IPC_HLE: Remove dead code (Wiimote and emulated BT)
...
Neither needed or used in the emulated Bluetooth code.
2016-11-24 20:23:52 +01:00
f82051a365
IPC_HLE: In-class initialise member variables
2016-11-24 20:23:52 +01:00
3263831928
IPC_HLE: Clean up includes (IWYU)
...
Apply automated fixes by include-what-you-use (IWYU) (with some minor
changes).
IPC_HLE should now be essentially free of indirect includes.
2016-11-24 20:23:51 +01:00
1e94fdba3c
IPC_HLE: Device: Separate implementation from declaration
...
I know there is already #3521 , but it currently needs a rebase and I
needed to add something to IPC_HLE_Device properly, that is, without
putting everything in the header, so this commit cleans up
IPC_HLE_Device first. (And only IPC_HLE_Device: the rest will still
be handled by #3521.)
Also fixes a few indirect includes (removing unused header includes
from IPC_HLE_Device.h broke building)
2016-11-24 20:19:19 +01:00
741a638f3e
IPC_HLE: USB_VEN: Clean up (includes and naming)
2016-11-24 20:19:18 +01:00
b0377f02f0
IPC_HLE: Deduplicate syscall reply enqueue function
...
This is something that was copy-pasted across the IPC_HLE code
(because it's often used). Since all of the duplicated pieces of code
do the same thing as the previous EnqueueReply, except that they also
write to command_address + 0 and + 8 (to write the correct reply type),
this commit changes EnqueueReply to do that instead of having it
duplicated all over IPC HLE.
2016-11-24 20:19:18 +01:00
9bfea4a0f2
Merge pull request #4447 from JosJuice/hthh-hle-issues
...
Fix exploitable HLE problems reported by hthh
2016-11-24 15:53:23 +01:00
c6b3c67ea1
Change the patch engine log to be debug level log
...
It was apparently causing heavy slowdowns on game even though it wouldn't spam much, probably caused by the amount of additional check caused by the logs levels changes.
2016-11-23 00:58:07 -05:00
6d0b9b816f
VideoCommon: Support dumping frames to images
...
This is mainly for potential Android fifoci usage, and thus is not
exposed anywhere in the UI. To enable, set DumpFramesAsImages under
Settings in GFX.ini.
2016-11-23 12:07:49 +10:00
6d55aebcf7
Typo_Fix
2016-11-21 23:23:48 -05:00
c4cd0d444a
NetPlay: Fix build when miniupnpc is disabled.
2016-11-19 15:36:26 +00:00
1aecf90765
DolphinNoGUI: Receive resize events and notify backend when this occurs
...
Solves the viewport sizing issue for backends that cannot tell when the
window is resized (Vulkan on NV at least).
2016-11-19 23:03:20 +10:00
d6d3341183
D3D: Fix strided XFB copies
2016-11-19 20:29:51 +10:00
6b88a854a7
Vulkan: Handle strided XFB copies
...
Where src_rect.width * 2 != dst_stride.
2016-11-19 20:29:47 +10:00
165e3a9936
IPC_HLE: Fix emulated BT crash (uninitialised memory)
...
When the emulated BT device is created, m_HCIEndpoint (which is a
CtrlBuffer)'s m_cmd_address is not initialised to 0. So it ends up
being a random value. This is normally not an issue… but the
emulated Bluetooth code relies on m_cmd_address to know whether the
HCI endpoint is still valid.
This is a problem with ES_Launch, because the bt_emu class is
destructed and re-constructed, and while m_cmd_address is still
uninitialised, the ES_Launch code disconnects all Wii remotes,
which triggers a HCI event and hence the bug.
2016-11-19 00:11:41 +01:00
725ef4c5dc
Vulkan: Pass target_rect to framebuffer draw methods
...
Fixes the black borders in frame dumps when the window was not sized to
the framebuffer aspect ratio.
2016-11-18 22:55:22 +10:00
4d2f058fe8
DolphinWX: Fix toolbar creation on macOS
2016-11-18 21:32:12 +11:00
6c16f1be8a
Merge pull request #4416 from stenzek/vulkan-cmdpool
...
Vulkan: Use multiple command pools, one per frame
2016-11-16 10:25:10 +01:00
71be84e074
Merge pull request #4452 from stenzek/jmp-self-idle-loop
...
Jit64: Treat branch-to-self instruction as an idle loop
2016-11-16 10:24:29 +01:00
128c1f04ad
Android: Specify ini file for every setting
...
Load all the inis at once, choose which one to write to, and save them all
at the same time. This allows us to modify settings from different files
on the same settings page.
2016-11-14 18:34:06 -05:00
3c92b35422
Vulkan: Use multiple command pools, one per frame
...
Instead of resetting two command buffers, now we only have to call
vkResetCommandPool once at the start of a frame.
NV's recommends using one pool per frame/thread. May offer a very small
boost in performance on some systems.
2016-11-15 00:40:15 +10:00
e83bf5705a
JitArm64: Don't emit normal block exit for branch-to-self instructions
...
The normal block exit is redundant as the exception exit will jump out of
the block first, meaning this code is never executed.
2016-11-15 00:28:14 +10:00
c657134c86
Jit64: Treat branch-to-self instruction as an idle loop
2016-11-15 00:26:59 +10:00
bd67adb362
Vulkan: Use correct sample count for EFB pokes with MSAA enabled
2016-11-14 20:24:16 +10:00
89176fe2ab
Vulkan: Fix crash on EFB poke
2016-11-14 20:19:59 +10:00
6a2e1e9986
Merge pull request #4429 from SeannyM/android-invert-settings
...
Android: Fix inverted EFB settings
2016-11-14 10:07:10 +01:00
f848418efa
Update FIFO Player Window Capitalization
2016-11-13 20:44:18 -08:00
99de9fbe33
Merge pull request #4443 from Armada651/exclusive-ui
...
D3D: Move exclusive mode switching to UI thread.
2016-11-14 01:45:07 +01:00
7e35a47b51
Cosmetics.
2016-11-13 22:17:40 +01:00
bc98ec77be
Merge pull request #4441 from stenzek/vulkan-max-image-count
...
Vulkan: Handle maxImageCount of zero when creating swap chain
2016-11-13 14:12:32 +01:00
c723532f0d
Merge pull request #4430 from stenzek/vulkan-no-relaxed-vsync
...
Vulkan: Don't use FIFO_RELAXED present mode for vsync.
2016-11-13 14:10:58 +01:00
141f3bfb3a
IOS HLE: Prevent accessing host file system
2016-11-13 10:03:23 +01:00
a79c449493
Avoid buffer over-reads in /dev/net/ip/top
...
Also fixes the less serious problem of buffer overflows
in emulated memory when BufferOutSize is less than 2.
2016-11-13 08:44:05 +01:00
b47e607105
HLE_OS: More bounds checking in GetStringVA
2016-11-12 19:17:15 +01:00
3d80d454ce
HLE_OS: Implement %n in GetStringVA
...
%n writes to a pointer that's provided as a parameter.
We didn't have a custom implementation of this before,
meaning that %n would trigger a write to the host
memory instead of the emulated memory!
2016-11-12 19:16:55 +01:00
656999d4c2
Correct bounds checking for /dev/sdio/slot0
...
The bounds checks in IOCtl were using 0x200 as the size of
m_Registers, which is more than the actual size, 0x200 / 4.
This commit turns m_Registers into an std::array to allow
for a correct and obvious way of getting its size.
2016-11-12 19:09:03 +01:00
aa0e4472c0
Frame: Move exclusive mode switching to helper function.
2016-11-11 21:24:08 +01:00
f207c01586
NetPlayLauncher: Add missing #pragma once
2016-11-11 14:58:20 -05:00
aab6b70868
MainAndroid: Remove obsolete Host_RequestFullscreen() function
2016-11-11 20:48:19 +01:00
d8201a7e8b
Frame: Remove exclusive mode OSD messages.
2016-11-11 20:36:11 +01:00
d7cf5e28b6
Frame: Use PauseAndLock when switching fullscreen modes.
...
This allows us to regain exclusive mode directly from OnActive().
2016-11-11 20:36:10 +01:00
9909babe2c
D3DBase: Create the swapchain in fullscreen mode if enabled.
2016-11-11 20:36:10 +01:00
0028ee96b3
Host: Remove the Host_RequestFullscreen() method.
...
No longer needed, since the exclusive mode switch is now handled synchronously on the CPU thread.
2016-11-11 20:36:09 +01:00
0a194f8a3e
VideoConfig: Remove fullscreen flags.
...
These weren't actually settings, they were used as a bad way to communicate with the GPU thread.
2016-11-11 20:36:09 +01:00
c21efa0cad
D3D: Move exclusive mode switching to UI thread.
...
This prevents deadlocks when switching to exclusive mode.
And it also allows the CPU thread to block until we've completed the switch.
2016-11-11 20:36:04 +01:00
f0ce3275af
Merge pull request #4439 from Armada651/yield-ui
...
CPU: Fix deadlocks by periodically yielding to the UI message pump.
2016-11-11 20:30:31 +01:00
cd9520f458
CodeWindow: In-class initialize variables where applicable
2016-11-11 13:31:36 -05:00
492b82042d
CodeWindow: Remove unused parameter from constructor
2016-11-11 13:20:47 -05:00
160fee6791
Vulkan: Handle maxImageCount of zero when creating swap chain
...
anv seems to set this to zero, which is fine according to the spec, but
we were using it as a maximum, which was resulting in a swap chain
without any buffers being created.
2016-11-11 23:33:40 +10:00
20d49ba97f
DolphinQt2: Implement Host_YieldToUI().
2016-11-11 13:42:18 +01:00
05a3f927ee
CPU: Fix deadlocks by periodically yielding to the UI message pump.
2016-11-11 13:37:03 +01:00
8203ea929b
BlockingLoop: Yield to UI message pump while waiting.
2016-11-11 13:37:02 +01:00
2d9ef3412a
GCAdapterConfigDiag: Mark OnUpdateAdapter parameter as unused.
2016-11-10 20:19:53 -05:00
1ae9027a6b
GCAdapterConfigDiag: Rename UpdateAdapter to OnUpdateAdapter
...
Uses the general naming convention for event functions.
2016-11-10 20:18:59 -05:00
c5c7ff9fd6
GCAdapterConfigDiag: Make functions private where applicable
...
These don't need to be in the public interface.
2016-11-10 20:12:02 -05:00
c77d4a765d
Merge pull request #4425 from lioncash/ipc
...
IPC_HLE: Move NWC24Config and WiiNetConfig to their own source files
2016-11-10 16:55:43 -05:00
03878a44e1
Merge pull request #4433 from Armada651/the-emu-that-runs-faster-than-its-race-condition
...
FrameTools: Avoid deadlock in UpdateGUI().
2016-11-10 16:50:13 +01:00
97bd77c928
Frame: Remove unused menu variable
...
This has been unused since the introduction of the MainMenuBar class
that abstracts away all of the wxMenuBar UI loading.
2016-11-10 07:33:52 -05:00
0b9562b0d5
Merge pull request #4434 from lioncash/path
...
PathConfigPane: Eliminate main frame global usage
2016-11-10 07:31:31 -05:00
193dd97759
VideoCommon: Drop FlipImageData.
...
This function isn't used any more, and good code shouldn't use it at all. Use negative strides instead.
2016-11-10 12:59:22 +01:00
Mat M