b5f4b0dffe
Merge pull request #10803 from Zopolis4/clangingaround
...
Resolve additional warnings generated by clang
2022-07-02 03:12:34 -04:00
0f07deb0ef
Remove unused variable in SI_DeviceKeyboard.h left over from SI_DeviceGCController.h
2022-07-02 16:16:54 +10:00
66f5085800
DolphinQt: add word wrap to graphics mods description
2022-07-01 19:31:19 -05:00
8dd4e916a7
DolphinQt: save changes to disk before refreshing mod list
2022-07-01 19:31:19 -05:00
bd59b0a490
Debugger MemoryViewWidget: Allow direct editing of memory cells.
2022-07-01 17:30:24 -07:00
bf68211878
RegisterWidget: Fix crash when right-clicking when there is no selected cell
2022-07-01 17:13:00 -07:00
69e32dea52
Resolve GCC Warnings
2022-06-30 15:26:48 -05:00
4788a05c76
VideoCommon: fix projection graphics mod affecting more than the intended draw call
2022-06-29 20:04:59 -05:00
5d04e1e1de
Merge pull request #10518 from iwubcode/draw-mod
...
Introducing a 'GraphicsMod' system for creators
2022-06-28 13:35:39 -04:00
e50e45f400
Merge pull request #10700 from sepalani/ssl-handshake
...
Socket: Fix some non-blocking connect edge cases
2022-06-27 21:39:36 -04:00
8aef0015fd
DolphinQt: add warning if graphics mods are not enabled
2022-06-27 18:28:28 -05:00
f3054aa99f
DolphinQt: add widget in game properties to list the various graphics mods available
2022-06-27 18:22:06 -05:00
1480b78f64
VideoCommon: dump EFB with size and texture format details and dump XFB with size details. Finally move count to front of image for XFB/EFB dumps so as to make it easier to see them in order. Change the count value prefix to 'n'
2022-06-27 18:20:52 -05:00
69839df1eb
VideoCommon: support dynamically updating game mods at runtime
2022-06-27 18:20:52 -05:00
892678648e
VideoCommon: trigger mod calls in TextureCacheBase (efb/xfb calls), VertexManagerBase (draw calls), and VertexShaderManager (projection calls)
2022-06-27 18:20:52 -05:00
62c186e14b
VideoCommon: add UninitializeEFBMemory to mirror XFB function
2022-06-27 18:20:52 -05:00
0f88155729
Core / DolphinQt / VideoCommon: add setting for enabling graphic mods
2022-06-27 18:20:52 -05:00
f416b71925
VideoCommon: add logic to handle a GraphicsMod while Dolphin is running
2022-06-27 18:20:52 -05:00
254246b814
VideoCommon: add logic to read a GraphicsMod from configuration
2022-06-27 18:20:52 -05:00
87fb42b64c
DolphinQt: Renamed "Range" to "Multiplier" in advanced mapping window. Removed the slider. Moved the spin box.
2022-06-26 22:52:20 -05:00
4c409411ed
DolphinQt: Don't show the advanced input settings on the main dialog.
2022-06-26 22:48:13 -05:00
80d9e79cf1
ControllerEmu: Allow settings to be categorized as "advanced". Make "Virtual Notches" and "Gate Size" categorized as such.
2022-06-26 22:42:16 -05:00
643f82539c
ControllerEmu: Expose gate size setting for octagon analog sticks.
2022-06-26 22:33:44 -05:00
f92beb611f
VideoCommon: add game mod constants
2022-06-26 21:53:21 -05:00
3857e1fa66
Core: add GraphicsMod directory
2022-06-26 21:53:21 -05:00
4fbbd85ef4
VideoCommon: create variables for EFB/XFB copy prefix. Reword prefix to 'efb1' and 'xfb1' to match textures
2022-06-26 21:53:21 -05:00
b9995b04a0
VideoCommon: add a way to get have a graphics directory count for all games by using a special 'all.txt' instead of a 'gameid.txt' file
2022-06-26 00:45:13 -05:00
7854afe512
VideoCommon: add support for setting and getting the stage from the texture info
2022-06-26 00:45:13 -05:00
a1892a9c68
VideoCommon: add function to check whether TextureFormat is a valid value
2022-06-26 00:45:13 -05:00
76401e8ffb
BS2Emu: Initialize the last rows of postMatrices to the identity matrix
...
This fixes Datel titles having missing textures (which was an issue with the previous commit).
2022-06-25 17:29:49 -07:00
b2ddffeeb1
BS2Emu: Set HID0/1/2/4 and MSR with correct default values
...
These values were obtained by setting a breakpoint at a game's entry point, and then observing the register values with Dolphin's register widget.
There are other registers that aren't handled by this PR, including CR, XER, SRR0, SRR1, and "Int Mask" (as well as most of the GPRs). They could be added in a later PR if it turns out that their values matter, but probably most of them don't.
This fixes Datel titles booting with the IPL skipped (see https://bugs.dolphin-emu.org/issues/8223 ), though when booted this way they are currently missing textures. Due to somewhat janky code, Datel overwrites the syscall interrupt handler and then immediately triggers it (with the `sc` instruction) before they restore the correct one. This works on real hardware due to icache, and also works in Dolphin when the IPL runs due to icache, but prior to this change `HID0.ICE` defaulted to 0 so icache was not enabled when the IPL was skipped.
2022-06-25 14:27:29 -07:00
9675faa232
DSPHLE: Properly reflect initial halt state in mail handler
...
DSPHLE::Initialize sets the halt and init bits to true (i.e. m_dsp_control.Hex starts as 0x804), which is reasonable behavior (this is the state the DSP will be in when starting a game from the IPL, as after `__OSStopAudioSystem` the control register is 0x804).
However, CMailHandler::m_halted defaults to false, and we only call CMailHandler::SetHalted in DSPHLE::DSP_WriteControlRegister when m_dsp_control.DSPHalt changes, so since DSPHalt defaults to true, if the first thing that happens is writing true to DSPHalt, we won't properly halt the mail handler.
Now, we call CMailHandler::SetHalted on startup. This fixes Datel titles when the IPL is skipped with DSP HLE (though this configuration only works once https://bugs.dolphin-emu.org/issues/8223 is fixed).
2022-06-25 14:06:55 -07:00
caf0e5b3e8
DSPHLE: Add variables in CMailHandler to savestate.
2022-06-25 19:15:21 +02:00
52f32e61dc
DSPHLE: Fix build error in the libasnd uCode
...
This was a conflict between 8a144a735fb063f15dcc
2022-06-24 19:29:31 -07:00
75943a7a2c
Merge pull request #10763 from Pokechu22/dsp-hle-asnd
...
DSPHLE: Add HLE version of libasnd ucode
2022-06-24 21:51:27 -04:00
a8b5266347
VideoCommon: enable optimizer and remove debug details when converting GLSL to SPIR-V with validation layers turned off
2022-06-24 18:09:53 -05:00
dda1479ecf
VideoBackends / VideoCommon: refactor Vulkan to use new SPIRV functionality
2022-06-24 18:09:53 -05:00
c2d3b7e7f5
VideoCommon: update pixel shader output to match old D3D code
2022-06-24 18:09:53 -05:00
0eb9352579
D3D: update BoundingBox to match generated shader code
2022-06-24 18:09:53 -05:00
cad1d6ce90
VideoCommon: fix support of stereoscopic rendering after moving d3d to SPIRV generation
2022-06-24 18:09:53 -05:00
993fa3bf94
VideoCommon: update UberShaderPixel to properly support logic ops, matching the specialized shader
2022-06-24 18:09:53 -05:00
5dd2704416
D3D / VideoCommon: generate HLSL from SPIRV
2022-06-24 18:09:53 -05:00
3790c99a7d
VideoCommon: add common spirv helper functions
...
Co-authored-by: tellowkrinkle <tellowkrinkle@gmail.com>
2022-06-24 17:52:31 -05:00
1faca4bfc7
Merge pull request #10752 from tellowkrinkle/BetterShaderNames
...
VideoCommon: Better shader names
2022-06-24 15:50:48 -07:00
76f890f6b0
Merge pull request #10761 from Pokechu22/dsp-halt-mail
...
DSPHLE: Handle mail more accurately
2022-06-24 18:46:20 -04:00
ffa3bf86fb
Merge pull request #10760 from tellowkrinkle/std430
...
VideoCommon: Fix SSBO layout and remove associated "bug"
2022-06-24 18:40:47 -04:00
5d2290ba3c
Removed unused variable MAX_MSGLEN in LogManager.cpp
2022-06-24 14:57:03 +10:00
8a144a735f
DSPHLE: Add HLE version of libasnd ucode
2022-06-23 10:50:24 -07:00
0a2aabe6ec
Merge pull request #10753 from Pokechu22/dsp-hle-cdd1-constants
...
DSPHLE: Move CDD1 constants to UCodes.h
2022-06-23 13:43:57 +02:00
2bd72dfc6f
Merge pull request #10758 from shuffle2/x64-on-arm64
...
windows: detect and warn if running x64 dolphin on arm64
2022-06-23 07:34:34 +02:00
f3c8e75666
DSPHLE: Move CDD1 constants to UCodes.h
...
These are used by *all* uCodes, though not all uCodes support MAIL_RESUME or MAIL_CONTINUE.
2022-06-22 22:01:13 -07:00
29ddd0e6f0
windows: detect and warn if running x64 dolphin on arm64
2022-06-22 15:33:12 -07:00
a72fa4b9cc
DSPHLE: Don't generate new mail if the DSP is halted
...
This fixes booting Datel titles with DSPHLE (see https://bugs.dolphin-emu.org/issues/12943 ). Datel messed up their DSP initialization code, so it only works by receiving a mail later on, but if halting isn't implemented then it receives the mail too early and hangs.
2022-06-22 09:57:33 -07:00
3aeafcc70b
DSPHLE: Return last mail with top bit cleared if there is no new mail
...
This is an accuracy improvement, though I don't think it matters for anything in practice.
2022-06-22 09:56:51 -07:00
bdbb23fa1a
DSPHLE: Rename CMailHandler::m_Mails to m_pending_mails
2022-06-22 09:56:51 -07:00
0fec8ffb3c
DSPHLE: Remove empty destructors
...
Most of these were made unnecessary by the previous commit.
2022-06-22 09:56:51 -07:00
567f9bede4
DSPHLE: Remove unneeded calls to m_mail_handler.Clear()
...
It's cleared whenever the uCode changes, so there's no reason to clear it in a destructor or during initialization.
I've also renamed it to ClearPending.
2022-06-22 09:56:50 -07:00
b063f15dcc
DSPHLE: Replace CMailHandler::IsEmpty with CMailHandler::HasPending
2022-06-22 09:56:50 -07:00
c8e716234e
Merge pull request #10732 from Pokechu22/dsp-init
...
Increase accuracy of DSP initialization process
2022-06-22 14:36:04 +02:00
6ddff87d42
Merge pull request #10755 from tellowkrinkle/DebugUID
...
VideoCommon: Don't add garbage to shader uids in debug builds
2022-06-22 14:33:23 +02:00
dc61f87fe4
Merge pull request #10772 from shuffle2/morepch
...
msbuild: add pch for dolphinqt
2022-06-22 14:27:44 +02:00
ceef02ed2a
Merge pull request #10750 from Pokechu22/hermes-test
...
Enhance DSPAssemblyTest, and fix various DSPTool bugs discovered while doing so
2022-06-22 14:26:50 +02:00
430c58cf27
IOS: Use host nameserver on more BSDs
2022-06-21 21:49:02 -05:00
a2530e3b93
IOS: Use first available IPv4 nameserver
2022-06-21 21:49:02 -05:00
b39a11e23b
msbuild: add pch for dolphinqt
...
since this now includes Qt headers it's better than only using
the vanilla DolphinLib one alone (previous behavior before Qt6)
2022-06-21 13:35:14 -07:00
a334883c47
Qt/MemoryViewWidget: Don't elide text
...
Before, the Hex 32 display would get truncated on Linux.
2022-06-20 18:53:23 -07:00
f441e3ab98
Merge pull request #10723 from Pokechu22/dsp-lle-unsigned-loop-counter
...
DSP LLE Recompiler: Fix LOOP and BLOOP when the counter is between 0x8001 and 0xFFFF
2022-06-21 02:01:13 +02:00
c317f7fd22
DSPLLE: Don't log when DIRQ is set to 0
...
No interrupt is generated in this case. The homebrew liband uCode writes zero fairly frequently, so logging it results in spam.
2022-06-19 10:46:41 -07:00
2b2b8e932d
Rename FPS_REFRESH_INTERVAL in VideoCommon/FPSCounter
2022-06-17 20:11:53 -06:00
f79ac768d8
VideoCommon:ShaderCache: Add const to some local variables
2022-06-17 20:14:32 -05:00
23ed611077
Merge pull request #10729 from Pokechu22/libusb-error-wrap
...
Improve libusb error logging
2022-06-17 16:01:46 +02:00
b199108964
Merge pull request #10520 from AdmiralCurtiss/resource-pack-init-crash
...
ResourcePack: Avoid crashes on invalid packs during Init().
2022-06-17 13:55:16 +02:00
efbf5a450b
ResourcePack: Avoid crashes on invalid packs during Init().
2022-06-17 03:49:05 +02:00
26529a31ab
VideoCommon: Fix SSBO layout and remove associated "bug"
2022-06-16 20:26:11 -05:00
896d5454f0
updater: use new platform id for win-arm64
2022-06-16 14:55:51 -07:00
053b3e725b
DSPHLE: More accurately handle initialization behavior
...
This improves timing, but does not fix Datel titles.
2022-06-16 12:18:05 -07:00
072913bbad
DSPLLE: More accurately handle initialization behavior
2022-06-16 12:18:05 -07:00
c38c2b1aaa
DSPLLE: Fix debug logging in ReadMailboxLow
...
The # option means that 0x is prepended already, so the old code resulted in 0x0xDEADBEEF instead of the intended 0xDEADBEEF. WriteMailboxLow was already correct.
2022-06-16 12:18:05 -07:00
3ceda1df8c
DSPLLE: Rename cr to control_reg
...
Before, there were two distinct fields called cr and r.cr, which is needlessly confusing (see the comment in DSPCore.h).
2022-06-16 12:18:05 -07:00
c7892d7371
VideoCommon: Name ubershaders
2022-06-16 02:08:45 -05:00
23c1721fbd
VideoCommon: Reduce duplicates of non-palette-requiring texture decode shaders
2022-06-16 02:08:45 -05:00
107a928452
Merge pull request #10748 from tellowkrinkle/SDL22Fun
...
InputCommon: SDL 2.0.22 init crash workaround
2022-06-15 18:02:59 +02:00
ac3920a0da
Qt/GameCubePane: Fix swapping memory cards mid-emulation.
2022-06-15 10:42:14 +02:00
3fe1a1a3d7
VideoCommon: Don't add garbage to shader uids in debug builds
...
There wasn't anything stopping compilers from doing it in release builds either, but most optimizations would make the padding zero
2022-06-14 21:51:58 -05:00
994210e369
InputCommon: SDL 2.0.22 init crash workaround
...
See https://github.com/libsdl-org/SDL/pull/5598
2022-06-14 21:02:45 -05:00
431d757151
Merge pull request #10743 from tellowkrinkle/LargeBlockRVZ
...
Fix creation of rvz with > 2mb chunk size
2022-06-14 16:17:24 -04:00
8a8e9c5ef6
Merge pull request #10742 from tellowkrinkle/Xcode
...
Improve incremental build time for Xcode projects
2022-06-14 16:14:54 -04:00
41939eeaf9
DSPDisassembler: Fix disassembly of LSR and ASR
...
Before, both 1441 and 147f would disassemble as `lsr $acc0, #1`, when the second should be `lsr $acc0, #-1`, and both 14c1 and 14ff would be `asr $acc0, #1` when the second should be `asr $acc0, #-1`. I'm not entirely sure whether the minus signs actually make sense here, but this change is consistent with the assembler so that's an improvement at least.
devkitPro previously changed the formatting to not require negative signs for lsr and asr; this is probably something we should do in the future: 8a65c85c9b
2022-06-14 12:22:06 -07:00
2d774010c3
DSPCodeUtil: Include the PC and hex in the "Extra code words" section
...
It's included in the section before, so it's helpful to supply here too.
2022-06-14 12:22:06 -07:00
087d89225c
DSPCodeUtil: Give better output when comparing instructions with large immediates
2022-06-14 12:22:06 -07:00
cad9801ded
DSPDisassembler: Fix out-of-bounds read when the last word is an instruction with a large immediate
...
For instance, ending with 0x009e (which you can do with CW 0x009e) indicates a LRI $ac0.m instruction, but there is no immediate value to load, so before whatever garbage in memory existed after the end of the file was used.
The bounds-checking also previously assumed that IRAM or IROM was being used, both of which were exactly 0x1000 long.
2022-06-14 12:22:06 -07:00
693a29f8ce
DSPCodeUtil: Use fmt::print instead of logging in DSP::Compare
2022-06-14 12:22:05 -07:00
25929789c1
VideoCommon: Don't pass State by inout
...
Spirv-cross's MSL codegen makes the amazing choice of compiling calls to inout functions as `State temp = s; call_function(temp); s = temp`. Not all Metal backends handle this mess well. In particular, it causes register spills on Intel, losing about 5% in performance.
2022-06-14 00:48:47 -05:00
db6e928c8d
VideoCommon: Fix Intel GPUs on Metal/Vulkan locking up in ubershaders
2022-06-14 00:48:47 -05:00
9315ac7071
Merge pull request #10587 from AdmiralCurtiss/memcard-path-unify
...
Raw Memory Card Path handling unification and consistency fixes.
2022-06-13 20:18:36 -04:00
f96e91119a
Merge pull request #10735 from CasualPokePlayer/audio_dump_volume_fix
...
Have audio dumps apply volume
2022-06-13 17:09:58 -04:00
1fc86cacd7
WiimoteEmu: Expose IMU pointing accelerometer weight setting.
2022-06-13 00:07:00 -05:00
59dfc43949
Common: replace std::aligned_storage_t with alignas
...
C++23 deprecates std::aligned_storage_t while alignas works since C++11.
This fixes issue 12925.
2022-06-13 00:06:19 +01:00
62ec19c1ba
JitArm64: Remove redundant line in the EmitBackpatchRoutine comment
...
All stores clobber X0, so that stores clobber X0 when emitting_routine
is true is nothing special.
2022-06-12 11:03:38 +02:00
75e897c40e
JitArm64: Fix a minor mistake in the EmitBackpatchRoutine comment
...
X30 is used in fewer situations than the comment was claiming.
(I think that when I wrote the comment I was counting the use of X30
as a temp variable in the slowmem code as clobbering X30, but that
happens after pushing X30, so it doesn't actually get clobbered.)
2022-06-12 11:03:37 +02:00
3de49dee78
JitArm64: Properly reserve scratch register for soft MMU
...
Cleans up a hack from the previous commit.
2022-06-12 11:03:35 +02:00
3dce1df00e
JitArm64: Implement "soft MMU"
...
This is used when fastmem isn't available. Instead of always falling
back to the C++ code in MMU.cpp, the JIT translates addresses on its
own by looking them up in a table that Dolphin constructs. This is
slower than fastmem, but faster than the old non-fastmem code.
This is primarily useful for iOS, since that's the only major platform
nowadays where you can't reliably get fastmem. I think it would make
sense to merge this feature to master despite this, since there's
nothing actually iOS-specific about the feature. It would be of use
for me when I have to disable fastmem to stop Android Studio from
constantly breaking on segfaults, for instance.
Co-authored-by: OatmealDome <julian@oatmealdome.me>
2022-06-12 11:03:25 +02:00
3e5f1a4f99
MemTools: Always provide a valid pointer in send_msg for mach_msg_overwrite
...
This cannot be nullptr in macOS Ventura and iOS 16.
2022-06-12 00:19:09 -04:00
7cf5547b97
CMake: Make bundled MoltenVK optional
...
Adds ~20s to incremental build time in Xcode projects
2022-06-11 16:34:33 -05:00
26fc167a44
DiscIO: Fix creation of rvz with > 2mb chunk size
2022-06-11 16:10:32 -05:00
e4614067b3
CMake: Respect SKIP_POSTPROCESS_BUNDLE
2022-06-11 15:46:38 -05:00
ad892176d0
have audio dumps apply volume (fixes cases of audio dumps being "too loud" and in game audio controls having no effect)
2022-06-10 21:27:10 -07:00
7faf5ea170
Clear the UI after async shader compilation
2022-06-10 17:19:59 +02:00
dcad3ec892
Allow to interrupt shader precompilation by stopping emulation
2022-06-10 17:11:32 +02:00
bcc64a05b3
Memmap: Remove outdated comments for 32-bit
2022-06-09 19:51:36 +02:00
63283dcc72
JitArm64: Refactor EmitBackpatchRoutine parameters, part 2
2022-06-09 19:51:36 +02:00
27ed2a99a0
JitArm64: Refactor EmitBackpatchRoutine parameters, part 1
2022-06-09 19:51:36 +02:00
27772e01d9
GCAdapter: Compare with LIBUSB_SUCCESS instead of 0
2022-06-08 15:30:22 -07:00
83afaba785
IOS/USB: Use LibusbUtils::ErrorWrap and LIBUSB_SUCCESS
2022-06-08 15:29:11 -07:00
5d301cc206
BTReal: Log warnings when libusb calls fail
2022-06-08 15:29:11 -07:00
eeab51e3a4
Log warnings when LibusbUtils::MakeConfigDescriptor fails
2022-06-08 15:29:11 -07:00
15cbb5c8f9
Log warnings when LibusbUtils::GetDeviceList fails
2022-06-08 15:29:11 -07:00
91a7c4bdf2
LibusbUtils: Log warnings when libusb_set_option or libusb_handle_events_timeout_completed fail
2022-06-08 13:18:31 -07:00
d7135daff5
Socket: Fix some errors related to non-blocking connect
2022-06-08 19:06:42 +04:00
c53a4c8c1a
Socket: Keep track of the socket connection progress
...
Workaround for mbedtls handshake issues with partially connected sockets
2022-06-08 19:06:42 +04:00
cbadc6e81a
NetworkCaptureLogger: Move ErrorState struct to Common/Network
2022-06-08 19:06:42 +04:00
41ce3a83d5
Socket: Refactor WiiSockMan::Convert
2022-06-08 19:06:42 +04:00
daf8e3ddde
Merge pull request #10462 from OatmealDome/steam-runtime
...
DolphinQt: Add support for a Steam Runtime build
2022-06-06 20:18:06 -04:00
79a7bf02eb
CMake: rename minizip to minizip-ng
...
minizip-ng is the new name used by the upstream project as well as all
distros other than Fedora (but it looks like it will be renamed there).
2022-06-06 14:21:43 +02:00
d03b277403
DSP LLE Recompiler: Fix LOOP and BLOOP when the counter is between 0x8001 and 0xFFFF
2022-06-05 19:34:31 -07:00
4fd18cf207
DolphinQt: Unify handling of raw memory card path.
2022-06-05 21:48:13 +02:00
deb9964333
Core: Unify handling of raw memory card path.
2022-06-05 21:43:48 +02:00
b1d1f2aa06
Common/StringUtil: Add convenience function for converting paths to use forward slashes on Windows.
2022-06-05 21:24:45 +02:00
2081e2f2a1
Config: Move ToGameCubeRegion(), GetDirectoryForRegion(), and GetBootROMPath() to new config system namespace.
2022-06-05 21:24:45 +02:00
664663e8de
Merge pull request #10604 from Pokechu22/gcadapter-refactor
...
Refactor GCAdapter, part 1
2022-06-04 16:30:25 -04:00
96f9d1000d
Merge pull request #10721 from Dentomologist/fix_warnings_on_generic_builder
...
Fix warnings on generic builder
2022-06-04 21:51:58 +02:00
92af703f29
DSPAssembler: Fix -Wswitch warning
2022-06-04 12:08:09 -07:00
d7cda67462
Merge pull request #10716 from Pokechu22/dsp-lle-loop-saturation
...
DSP LLE: Apply saturation to LOOP and BLOOP with $ac0.m and $ac1.m
2022-06-04 15:30:06 +01:00
9fb17b5a48
Merge pull request #10718 from shuffle2/hotkeys
...
qt: unregister Settings' DevicesChanged callback during shutdown
2022-06-03 13:48:28 +02:00
b16711f2af
qt: fix wiipane usb list layout
2022-06-02 23:58:13 -07:00
27dd2c4aa4
qt: unregister Settings' DevicesChanged callback during shutdown
...
fixes a crash on close
2022-06-02 23:32:21 -07:00
6823b4d7a0
GCAdapter: Use LibusbUtils::ErrorWrap in log messages
2022-06-02 19:39:36 -07:00
457fcbaf5e
LibusbUtils: Create ErrorWrap
2022-06-02 19:39:36 -07:00
0d8772ccbe
GCAdapter: Make local variables const where possible
2022-06-02 19:39:36 -07:00
cd9edeacda
GCAdapter: Merge Read logic
2022-06-02 19:39:36 -07:00
9ec65baf46
GCAdapter: Have the read thread control the write thread
...
This was done for Android in 6cc40b1235
2022-06-02 19:39:36 -07:00
0fa92694d1
GCAdapter: Exit early if the adapter fails to open on Android
...
This is only so that indentation is consistent with the non-android code.
2022-06-02 19:39:36 -07:00
749a4ad1ef
GCAdapter: Remove check on write size on android
...
It was removed for non-android in 56239d1ae1
2022-06-02 19:39:36 -07:00
27947046af
GCAdapter: Harmonize read/write thread variable names
2022-06-02 19:39:36 -07:00
279888da8c
GCAdapter: Remove unused includes
2022-06-02 19:39:36 -07:00
3ae775e574
GCAdapter: Use determinism hack on Android
...
This hack was added in 8f0cbefbe5
2022-06-02 19:39:36 -07:00
55922e6d17
GCAdapter: Convert ControllerType to an enum class
2022-06-02 19:39:36 -07:00
682d86f4da
GCAdapter: Fix rumble enabled config on Android
...
I believe the setting already existed in the UI; it just wasn't implemented in GCAdapter_Android.cpp.
2022-06-02 19:39:36 -07:00
36d4ee0939
GCAdapter: Use std::array for controller read and write payloads
2022-06-02 19:39:36 -07:00
dd6592698e
GCAdapter: Merge GCAdapter.cpp and GCAdapter_Android.cpp
...
This is mostly a brainless merge, #ifdef-ing anything that doesn't match between the two while preserving common logic. I didn't rename any variables (although similar ones do exist), but I did change one log that was ERROR on android and NOTICE elsewhere to just always be NOTICE. Further merging will follow.
2022-06-02 19:39:36 -07:00
f7f47d3cd0
Merge pull request #10692 from Pokechu22/dsp-manual-set40-and-write-backlog
...
docs/DSP: Add sections on 16-bit and 40-bit modes and on main and extended opcode writing to the same register
2022-06-02 20:26:31 -04:00
c8ab236e0a
Merge pull request #10709 from Pokechu22/dsp-lle-update-sr-16
...
DSP LLE JIT: Fix Update_SR_Register16_OverS32
2022-06-02 20:22:36 -04:00
84944625df
Merge pull request #10714 from OatmealDome/macos-mojave-bump
...
BuildMacOSUniversalBinary: Bump minimum macOS to 10.14
2022-06-02 20:20:52 -04:00
0fc1fb023f
Merge pull request #10678 from Dentomologist/skip_pagefault_test_if_no_exception_handler
...
UnitTests: Skip PageFaultTest if exception handlers aren't supported
2022-06-02 16:21:21 -07:00
7ce1a5717a
UICommon: Add support for portable.txt on macOS
2022-06-02 14:56:09 -04:00
a58bb2aa24
Merge pull request #10701 from TryTwo/PR_Memory_Widget_Connections
...
Debugger MemoryWidget: Navigate to memory from breakpoint widget and cheat search.
2022-06-02 20:50:44 +02:00
4bc42ded80
DSP LLE Interpreter: Remove OpReadRegisterAndSaturate
...
Instead, saturate in OpReadRegister, as all uses of OpReadRegisterAndSaturate called OpReadRegister for other registers (and there isn't anything that writes to $ac0.m or $ac1.m without saturation).
2022-06-01 22:01:49 -07:00
928f745e36
DSP LLE Interpreter: Fix typo in 'LS
...
This was introduced in fc1db5eaa0
2022-06-01 22:01:49 -07:00
e7f78379ec
DSP LLE Recompiler: Apply saturation to LOOP and BLOOP with $ac0.m and $ac1.m
2022-06-01 22:01:49 -07:00
bc206b7a27
DSP LLE Interpreter: Apply saturation to LOOP and BLOOP with $ac0.m and $ac1.m
2022-06-01 22:01:49 -07:00
803a0de5a4
VKMain: Remove check for macOS 10.14
2022-06-01 22:57:56 -04:00
1cb3058abe
MemoryUtil: Remove __builtin_available for macOS 10.14
2022-06-01 22:57:56 -04:00
6e2febd404
VideoBackendBase: Remove __builtin_available for macOS 10.14
2022-06-01 22:57:51 -04:00
177dae6a1a
Add options for BreakpointWidget, WatchWidget, and CheatSearches to send address to Memory Widget
2022-06-01 01:53:15 -07:00
f9c6eb7b98
InputCommon/ControllerEmu: Use more locks
...
Loading configs while another thread is messing with stuff just doesn't feel like a good idea
Hopefully fixes Wiimote Scanning Thread crashes on startup
2022-05-31 20:17:37 -05:00
e0c9ae16b9
FileUtil: Refactor CreateSysDirectoryPath()
2022-05-31 16:18:08 -07:00
c2be78079c
FileUtil: Remove GetSysDirectory log spam
...
Create and log path the first time GetSysDirectory is called, then just
return the path on future calls.
2022-05-31 16:18:08 -07:00
4d563ce4d1
Android: Ensure File::s_android_sys_directory is set only once
2022-05-31 16:18:08 -07:00
f88b7ab6b3
DSP LLE JIT: Fix Update_SR_Register16_OverS32
...
There were 3 bugs here:
- The input register for the full register wasn't actually being used; it was read into RCX but RCX wasn't used by Update_SR_Register16_OverS32 (except as a scratch register). The way the DSP LLE recompiler uses registers is in general confusing, so this commit changes a few uses to have a variable for the register being used, to make code a bit more readable. (Default parameter values were also removed so that they needed to be explicitly specified).
- Update_SR_Register16 was doing a 64-bit test, when it should have been doing a 16-bit test. For the most part this doesn't matter due to sign-extension, but it does come up with e.g. `ORI` or `ANDI`.
- Update_SR_Register16_OverS32 did the over s32 check, and then called Update_SR_Register16. Update_SR_Register16 masks $sr with ~SR_CMP_MASK, clearing the over s32 bit. Now the over s32 check is performed after calling Update_SR_Register16 (without masking a second time). No official uCode cares about the over s32 bit.
2022-05-30 20:10:55 -07:00
7c63bd1893
docs/DSP: Fix inconsistency with ADDI and CMPI
...
We don't have anything called $amD, though we do have $acsD. However, these instructions affect flags based on the whole accumulator, so it's better to just use $acD.
2022-05-29 15:00:09 -07:00
baf2c710ff
DSP: Fix typo with TST
2022-05-29 15:00:09 -07:00
4dc7208195
docs/DSP: Fix typo with arithmetic instructions that take a 16-bit immediate
...
These instructions used an 'r' in their bit list, but a 'd' in the operands.
2022-05-29 15:00:09 -07:00
b349254ff4
docs/DSP: Document the behavior when main and extended opcodes both write to the same register (the write backlog)
...
For more information, ApplyWriteBackLog, WriteToBackLog, and ZeroWriteBackLog were added in b787f5f8f7fd40513fed
2022-05-29 15:00:09 -07:00
df22439826
FS: Reshuffle Rename to fix steamrt unit test failure
2022-05-29 13:50:32 -04:00
09875c6403
DolphinQt: Copy qt.conf into Binaries output folder on Steam builds for Linux
2022-05-29 13:50:32 -04:00
5c4122ec2a
DolphinQt: Copy Sys into Binaries output folder on Steam builds for Linux
2022-05-29 13:50:32 -04:00
77fb5fa7dc
DolphinQt: Copy all Qt libraries into Binaries output folder on Steam builds for Linux
2022-05-29 13:50:32 -04:00
6b05f5cca8
DolphinQt: Set the executable's rpath to a lib directory in $ORIGIN on Steam builds for Linux
...
We will store our Qt shared libraries here.
2022-05-29 13:50:32 -04:00
e679502a5d
GLX: Guard against redefinition of PFNGLXSWAPINTERVALEXTPROC
...
This type is already declared in glxext.h in the Steam Runtime.
2022-05-29 13:50:32 -04:00
e17a4f49f5
Merge pull request #10668 from Dentomologist/convert_pointerwrap_mode_to_enum_class
...
Convert PointerWrap::Mode to enum class
2022-05-29 00:57:43 +01:00
3dbc18060b
Merge pull request #10694 from Pokechu22/dsp-assembler-error-messages-etc
...
DSPAssembler: Rework errors and warnings, and related cleanup
2022-05-29 00:16:23 +01:00
57e444cd5d
Merge pull request #10697 from Dentomologist/windows_remove_qt5_code_and_references
...
Windows: Remove unused Qt5 block and reference
2022-05-29 00:14:34 +01:00
d307c34af1
DSP LLE: Rename CMPAR to CMPAXH
2022-05-27 18:22:38 -07:00
059cd5f6e1
Windows: Remove unused Qt 5 code and references
2022-05-25 17:51:17 -07:00
c8e20c569b
Convert PointerWrap::Mode to enum class
2022-05-25 13:16:46 -07:00
f6b9acccfc
Common: Refactor PointerWrap
2022-05-25 13:06:41 -07:00
2341ff00ab
NetPlay: Make messages about non-matching games clearer
2022-05-24 23:20:45 -07:00
ea9b0bff08
NetPlay: Delete NetPlayClient::GetPlayerList
...
It's been unused since DolphinWX was removed in 44b22c90df
2022-05-24 14:44:28 -07:00
b6ad5c5902
Merge pull request #10683 from Pokechu22/gamelist-home-end
...
GameList: Have home/end keys move to first/last row
2022-05-24 22:10:38 +01:00
bd3173e344
DSPAssembler: Rework errors and warnings
...
Among other things, this trims trailing newline characters. Before (on windows) the \r would corrupt the output and make them very hard to understand (as the error message would be drawn over the code line, but part of the code line would peek out from behind it).
2022-05-23 20:27:17 -07:00
db3d457e5f
DSPDisassembler: Remove redundant definition of CW
...
CW is used as a fallback to write a full instruction as hex, but we already declare it in DSPTables.h for the assembler.
2022-05-23 19:36:47 -07:00
b06d38389b
DSP: Remove some magic numbers for register IDs
2022-05-23 19:36:47 -07:00
8b52c7315b
DSP: Fix assembling x8/x9/xA/xB conditions
...
The assembler upper-cases the mnemonic internally, so it never would match the lower-case x.
2022-05-23 19:36:47 -07:00
e7f6e19c61
DSPAssembler: Slightly improve readability of AssemblePass
...
This should result in no behavior differences.
2022-05-23 19:36:47 -07:00
b18fd3d3ce
Core/State: Make memory layout of StateHeader more explicit.
2022-05-24 03:04:52 +02:00
f68c3b758e
Common/Network: Use std::array in IPv4Header.
2022-05-23 02:01:59 +02:00
3a3357444e
Merge pull request #8067 from endrift/hsp
...
Preliminary HSP support
2022-05-22 13:42:27 -04:00
1c4a5d9fc9
GameList: Work around Qt bug regarding clicking in the background not setting the position used by page down/end
2022-05-21 23:33:46 -07:00
8d0f52032b
IOS/DI: Fake the error 001 read when running DirectoryBlobs or Riivolution-patched games.
2022-05-22 04:22:41 +02:00
2d50ba0ca2
GameList: Have home/end keys move to first/last row
2022-05-21 18:11:24 -07:00
0e948f3e21
Merge pull request #10620 from phire/cmake_win_fixes
...
Various fixes for msvc/cmake builds
2022-05-22 03:08:17 +02:00
8b3517a9f9
Merge pull request #10686 from Tilka/pikmin_demo
...
DSPHLE: handle crc of Pikmin 1 GC US Demo
2022-05-21 17:30:31 -07:00
6a26b0ce8a
HW: Initial HSP implementation with ARAM expansion
2022-05-21 17:05:49 -07:00
580c721c82
cmake: Don't use PCH with Qt6.
2022-05-22 01:19:44 +02:00
a5e85627b0
cmake: Use Policy CMP0117 for more sensible RTTI flag configuration on MSVC.
2022-05-22 00:30:56 +02:00
9908219dc6
cmake: Add a few missing settings from the Visual Studio project files on MSVC.
2022-05-22 00:29:48 +02:00
dbee810a04
cmake: Fixes for Qt6 on Windows.
2022-05-22 00:29:48 +02:00
876f6651b4
cmake: fix PCH to work with msvc/ninja
...
Ninja puts way more effort into compiling targets in parallel, and
ignores dependenceis until link time.
So we need to jump though hoops to force ninja to compile
pch.cpp before any targets which depend on the PCH.
2022-05-22 00:29:47 +02:00
0909e00117
cmake: fix MSVC PCH support
...
I'm not sure if the previous implementation ever worked.
2022-05-22 00:29:47 +02:00
2348017ee8
cmake: ignore external warnings in MSVC
...
Since we also treat all warnings as errors, we need to
ignore these to successfully build.
2022-05-22 00:29:46 +02:00
987f270083
cmake: fix buggy target sources on windows
...
I have no idea why cmake supports PUBLIC on target_sources,
but it does. It causes all targets that depend on this target
to try and include the files in their sources.
Except it doesn't take paths into account, so it breaks. Mabye
it would work if you used an abolute source? But I'm not sure
there is a sane usecase.
2022-05-22 00:29:46 +02:00
f0454ab2fa
Added double click to add expressions when mapping
2022-05-21 14:08:49 -06:00
d7da4aca19
DSPHLE: handle crc of Pikmin 1 GC US Demo
...
The DSP code only has minor differences to the final release.
2022-05-21 16:48:34 +01:00
863cb591fe
MainSettings: Make MAIN_CUSTOM_RTC_VALUE default value less magical
2022-05-20 20:35:53 -07:00
244e4acff2
Merge pull request #10674 from OatmealDome/mac-steam-overlay
...
DolphinQt: Add com.apple.security.cs.allow-dyld-environment-variables to entitlements
2022-05-19 22:43:57 -04:00
151119cece
DSPInterpreter: Fix typo in isOverflow comment
2022-05-19 16:36:39 -07:00
a98d0367d8
Merge pull request #10677 from Pokechu22/no-printf-log
...
Remove printf-style logging
2022-05-19 17:55:17 -04:00
2aa0ae097b
Merge pull request #10672 from Pokechu22/xf-invtxspec
...
Show panic alerts if the CP configuration doesn't match the XF configuration
2022-05-19 13:13:53 -07:00
8baeb75bd2
Merge pull request #10669 from Pokechu22/adapter-change-aa-mode-list-reload
...
Fix antialiasing modes being determined from the wrong graphics adapter
2022-05-19 13:13:22 -07:00
5f9212dd84
Common/LogManager: Remove old printf-style logging functions
2022-05-19 12:41:58 -07:00
0637c17b59
VideoCommon/FrameDump: printf-format messages before logging them
2022-05-19 12:41:58 -07:00
35cb5c8f75
EXI_DeviceEthernet: Replace INFO_LOG with INFO_LOG_FMT
2022-05-19 12:41:58 -07:00
2f5e69a94e
JitArm64: Replace WARN_LOG with WARN_LOG_FMT
2022-05-19 12:41:57 -07:00
642a1c1348
MainWindow: Replace WARN_LOG with WARN_LOG_FMT
2022-05-19 12:41:57 -07:00
0faf0b80ad
TAPServer_Apple: Use fmt logging
2022-05-19 12:41:57 -07:00
6ffd938f98
UnitTests: Skip PageFaultTest if exception handlers are not supported
...
Page faults should only occur on architectures that support exception
handlers, so skip the test on other architectures to avoid spurious test
failures.
2022-05-19 12:26:41 -07:00
a86fb9b475
Core/WGInput: Use fmt logging and include HRESULT in messages
2022-05-19 12:12:19 -07:00
185188c009
DolphinQt: Add com.apple.security.cs.allow-dyld-environment-variables to entitlements
2022-05-18 20:23:17 -04:00
8df55b492c
Show a panic alert if the CP matrix indices don't match the XF matrix indices
...
This almost certainly never happens, but if it does we want to know.
2022-05-18 14:43:14 -07:00
38a75f6a49
Show a panic alert if the CP vertex config doesn't match the XF vertex config
...
This probably isn't triggered by real games, but it's possible to accidentally do it with libogc (which results in freezes on real hardware).
2022-05-18 14:43:14 -07:00
46bcdc4372
Rename CP and XF normal component count enums and update their descriptions
2022-05-18 14:43:14 -07:00
736466a5d9
XFMemory: Rename hostinfo to invtxspec
2022-05-18 14:43:14 -07:00
3949698acf
Verify graphics config validity after populating the backend info
...
... and refresh the config before populating the backend info, as the config (specifically iAdapter) needs to be set to correctly populate the backend info.
Before, the list of valid antialiasing modes was always determined from the first adapter on the list on startup, regardless of the adapter the user selected.
2022-05-16 16:59:57 -07:00
3950bc4620
Treat changing the graphics adapter the same as changing the backend
...
This results in the list of available antialiasing modes being updated; before, it would only show the modes available for the adapter that was selected when the graphics window was opened (or the backend was last changed).
The list of available modes is updated by `GraphicsWindow::OnBackendChanged`'s call to `VideoBackendBase::PopulateBackendInfoFromUI`, and then `EnhancementsWidget::LoadSettings` updates the UI. Both of these are connected to the `GraphicsWindow::BackendChanged` signal.
2022-05-16 16:59:31 -07:00
4085d463a1
Merge pull request #10661 from Tilka/ax_init
...
AX: refactor buffer initialization
2022-05-16 14:23:13 -04:00
b10808d815
Merge pull request #8763 from JosJuice/panic-alert-deadlock-gpu
...
DolphinQt: Fix the panic alert deadlock, dual core edition
2022-05-16 02:21:14 +02:00
ac7aeeece6
AX: refactor buffer initialization
2022-05-15 00:24:38 +01:00
b8cca8f598
ProcessorInterface: Implement PI_FIFO_RESET
...
Fixes unknown opcodes 0x0f and 0xff when resetting titles, e.g. https://bugs.dolphin-emu.org/issues/12492
2022-05-13 14:20:14 -07:00
fcb3f9e35b
Merge pull request #10652 from shuffle2/fmt
...
update fmt and fix warnings that popped up with vs 17.2
2022-05-13 22:09:01 +01:00
855dbf88ca
AX: handle DPL2 mixer control in old GameCube titles
...
This fixes the audio test in Rogue Squadron 2 (issue 12902).
2022-05-13 00:18:24 +01:00
8438e647f2
AXWii: handle mixer control more precisely
...
On GameCube, a ramp bit has no effect if its corresponding channel is
inactive. On Wii however, enabling just the ramp implicitly also enables
the channel. AXSetVoiceMix() never does that, so this commit should have
no impact on games unless they fiddle with the mixer control value
directly.
2022-05-12 21:21:03 +01:00
333659cefa
Merge pull request #10643 from Tilka/ax_cleanup
...
AX: fix missing ramp of main surround channel
2022-05-12 21:12:04 +01:00
7b8e6c5b36
fmt: do not define uint type in global namespace
2022-05-10 21:17:10 -07:00
fa17153ebc
fmt: use make_format_args instead of make_args_checked
...
make_args_checked is deprecated
see https://github.com/fmtlib/fmt/pull/2760 and the linked comment
2022-05-10 19:25:48 -07:00
56626f73bf
fmt: fix 'ambigous overload' error
2022-05-10 19:19:52 -07:00
c41467a8eb
Merge pull request #10650 from AdmiralCurtiss/memory-widget-resize-fix
...
Qt/MemoryViewWidget: Fix resizing.
2022-05-10 21:25:33 +01:00
828ce0f3cf
Qt/MemoryViewWidget: Fix resizing.
2022-05-10 12:35:37 +02:00
a768dc6f80
Merge pull request #10374 from Pokechu22/slots-unused-warning
...
Work around false SLOTS defined but not used warning on GCC
2022-05-09 22:28:59 +01:00
61a144ba06
Show a panic alert if movie is missing its starting savestate
2022-05-09 13:32:38 -07:00
d82f2d7314
Merge pull request #10612 from AdmiralCurtiss/memory-widget-refactoring-2
...
Qt/MemoryViewWidget: Replace the click-to-center behavior with a scrollbar.
2022-05-09 20:11:58 +01:00
JMC47