4ccac53e9f
X64EmitterTest: Check bytes instead of disassembly in JMP test
...
Check bytes directly to avoid ambiguity in the disassembly between short
and near jumps, which could hypothetically cause the test to pass when
it shouldn't.
2023-08-05 13:51:42 -07:00
dcd5ba6587
x64EmitterTest: add J/J_CC/CALL unit tests
2023-08-05 13:51:42 -07:00
83f307ec7e
D3D12: Only use framebuffer integer descriptor if allocated
...
Verify that DXFramebuffer's integer RTV descriptor's cpu_handle has been
allocated before using it, and if it hasn't use the non-integer RTV
descriptor instead. This fixes a Dolphin crash in Twilight Princess, and
possibly other games (Issue 13312).
As an optimization to save space in the descriptor heap, DXFramebuffer's
integer descriptor is only initialized if the given abstract texture
format has different integer and non-integer RTV formats. This
previously wasn't accounted for by GetIntRTVDescriptorArray, which could
cause DX12::Gfx::BindFramebuffer to call OMSetRenderTargets with an
invalid descriptor which would lead to a crash.
Triggering the bug was fortunately rare because integer formats are only
used when blending is disabled and logic ops are enabled. Furthermore,
the standard integer abstract format is RGBA8 which has different
integer and non-integer RTV formats, causing the integer descriptor to
be initialized and avoiding the bug.
The crash started appearing in a2702c6
2023-08-04 13:17:33 -07:00
02b0e287cb
InputConfig: Update IsControllerControlledByGamepadDevice for Android input overhaul
...
This only matters for analytics, but still.
2023-08-01 19:35:55 +02:00
a912a2c3f5
Merge pull request #12047 from AdmiralCurtiss/nand-stats-user
...
Add file size stats to NAND Check.
2023-07-30 21:51:07 +02:00
d2c5d79614
JitArm64: Use farcode in WriteLinkBlock
...
Now block link nearcode is back to a length of three instructions.
Unfortunately, the code I'm adding to Jit.cpp ends up being a bit messy
because we need to handle the case of already being in farcode...
2023-07-30 15:00:07 +02:00
1813f0fdb5
Jit: Remove checkedEntry
...
It's now always identical to normalEntry.
2023-07-30 14:28:02 +02:00
f78ba9ac55
JitArm64: Never check downcount on block entry
...
Jumping between linked blocks currently works as follows: First, at the
end of the first block, we check if the downcount is greater than zero.
If it is, we jump to the `normalEntry` of the block. So far so good. But
if the downcount wasn't greater than zero, we jump to the `checkedEntry`
of the block, which checks the downcount *again* and then jumps to
`do_timing` if it's less than zero (which seems like an off by one error
- Jit64 doesn't do anything like this). This second check is rather
redundant. Let's jump to `do_timing` where we previously jumped to
`checkedEntry`.
Jit64 doesn't check the downcount on block entry. See 5236dc3
2023-07-30 14:20:44 +02:00
9f817911fd
HLE_OS: Manually handle printfs from emulated software to prevent emulated software from crashing Dolphin with an invalid printf formatting string.
2023-07-29 20:06:09 +02:00
30c4ac34b0
Merge pull request #12073 from AdmiralCurtiss/wiimote-win32error
...
WiimoteReal/IOWin: Use correct error type in the default case.
2023-07-29 18:54:10 +02:00
7f29f0398c
MMU: Add a HostGetU16String() function for wide strings used by emulated software.
2023-07-29 15:11:00 +02:00
dca7c67105
VideoCommon: update NetplayChatUI's chat message input to use a hidden label. This avoids an error thrown by imgui
2023-07-29 00:27:07 -05:00
a2a6473962
Merge pull request #12065 from iwubcode/imgui_update
...
Externals / VideoCommon: update imgui to 1.89.7 (and implot to 0.15)
2023-07-28 17:22:20 -04:00
ed8911b204
Merge pull request #12019 from Dentomologist/gekkodisassembler_remove_unused_member_and_parameter
...
GekkoDisassembler: Remove unused member and parameters
2023-07-28 20:02:19 +02:00
b5b8282ca9
Android: Fix SettingsActivity.onActivityResult
...
`or` is the bitwise or operator.
Fixes file pickers in the settings not saving your choice.
2023-07-28 18:45:07 +02:00
8bfcd2deb7
JitArm64/Jit64: Load the memory register without jumps and only when necessary.
2023-07-28 14:24:53 +03:00
fb9274c359
WiimoteReal/IOWin: Use correct error type in the default case.
2023-07-28 08:10:54 +02:00
cd923718c3
CommonFuncs: Add GetWin32ErrorString().
2023-07-28 08:10:01 +02:00
3c6ea825c2
GekkoDisassembler: Remove unused parameter dmode from fdabc function
...
With the removal of m_flags, dmode is no longer used in fdabc.
2023-07-27 10:47:46 -07:00
33dc2a9e6a
GekkoDisassembler: Remove unused parameter dmode from ldst function
...
With the removal of m_flags, dmode is no longer used in ldst.
2023-07-27 10:47:46 -07:00
b3c5021fc4
GekkoDisassembler: Remove unused parameter dmode from rrn function
...
With the removal of m_flags, dmode is no longer used in rrn.
2023-07-27 10:47:46 -07:00
a177c8bcb1
GekkoDisassembler: Remove unused parameter dmode from dab function
...
With the removal of m_flags, dmode is no longer used in dab.
2023-07-27 10:47:45 -07:00
a732647e5a
GekkoDisassembler: Remove unused parameter dmode from nooper function
...
With the removal of m_flags, dmode is no longer used in nooper.
2023-07-27 10:47:45 -07:00
317bb629b9
GekkoDisassembler: Remove unread variable m_flags
...
Writes to m_flags are pointless as it's never read.
2023-07-27 10:47:41 -07:00
350e51951b
VideoCommon: update imgui to 1.89.7 (and implot to 0.15); fix issues with upgrade; keep the demo code in case someone wants to reference it but don't compile it by enabling 'IMGUI_DISABLE_DEMO_WINDOWS' in config
2023-07-27 11:47:34 -05:00
17fa9dfc4e
Merge pull request #12046 from AdmiralCurtiss/nand-stats-unit-test
...
UnitTests: Enable cluster check in FileSystemTest.GetDirectoryStats.
2023-07-27 18:44:34 +02:00
ec5d2a4f41
[Core] Prevent SD data loss from silent resync failure
2023-07-26 13:58:01 -06:00
1e5e319783
Qt/GameConfigWidget: Add Manual Texture Sampling
2023-07-25 00:45:13 +02:00
41f81aca69
Qt/GameConfigWidget: Rename `m_enable_fast_disc` to `m_emulate_disc_speed`
2023-07-25 00:45:10 +02:00
0892998af1
Qt/GameConfigWidget: Add `reverse` argument for `{Save,Load}CheckBox`
...
In order to not hard code `if (key == "FastDiscSpeed")`
2023-07-24 20:48:32 +02:00
0a2afa48b7
Merge pull request #12045 from tupfold/master
...
[Minor Bugfix] Extremely rare HostID collision bugfix
2023-07-24 03:55:45 +02:00
553824e5aa
Merge pull request #11853 from noahpistilli/update-curl
...
Externals: Update libcurl
2023-07-24 02:27:36 +02:00
2b80605e7e
Merge pull request #12067 from Pokechu22/debugging-ui-text-show-enable
...
Rename "Show Debugging UI" to "Enable Debugging UI"
2023-07-24 01:15:04 +02:00
c468ca2107
Merge pull request #12057 from iwubcode/config_core_timing_refresh_only
...
Core: save core timing parameters into variables updated during refresh
2023-07-24 01:14:18 +02:00
7e38ff496c
Rename "Show Debugging UI" to "Enable Debugging UI"
...
This will hopefully reduce confusion on e.g. https://bugs.dolphin-emu.org/issues/13306 .
2023-07-23 15:17:04 -07:00
e54b7ac356
Core: save core timing parameters into variables updated during refresh
2023-07-23 14:03:21 -05:00
eb79bf37e2
Merge pull request #12052 from mitaclaw/profiling-is-something
...
Announce RSCRATCH clobbering in Jit64::Cleanup() when profiling is enabled
2023-07-23 20:12:43 +02:00
a76cc146e1
Merge pull request #12055 from iwubcode/skip_dump_async
...
VideoCommon: skip the texture dump if a custom texture is available, regardless if it is loaded or not
2023-07-23 19:53:25 +02:00
c1a4b3f350
Merge pull request #12051 from mandar1jn/J-documentation-improvements
...
Skylanders: Update J command documentation
2023-07-23 19:23:29 +02:00
dd3caa48b2
Merge pull request #12063 from SuperSamus/audio-name
...
cubeb: Change name to "Dolphin Emulator"
2023-07-23 19:15:24 +02:00
a486168448
JitArm64: Use LogicalImm in boolX
...
ARM64 has a special logical immediate encoding scheme, that can be used
with AND, ORR, and EOR. By taking advantage of this, we no longer need
to materialize the immediate value in a register, saving instructions
and/or reducing register pressure.
- orx
Before:
mov w23, #0x1
orr w23, w25, w23
After:
orr w23, w25, #0x1
- andx
Before:
mov w26, #-0x80000000
and w27, w27, w26
sxtw x24, w27
After:
and w27, w27, #0x80000000
sxtw x26, w27
- eqvx
Before:
mov w23, #0x4
eon w26, w23, w22
After:
eor w26, w22, #0xfffffffb
- xorx
Before:
mov w23, #0x1e
eor w23, w27, w23
After:
eor w23, w27, #0x1e
- norx
Before:
mov w25, #-0x2001
orr w23, w23, w25
mvn w23, w23
After:
orr w23, w23, #0xffffdfff
mvn w23, w23
2023-07-23 18:40:53 +02:00
8c2a1c191e
Remove force disable WC24 Standby
2023-07-22 22:24:09 -04:00
e3ef3cb752
Merge pull request #12062 from iwubcode/custom_textures_debug
...
VideoCommon: add startup message to know if custom textures are installed
2023-07-23 03:45:22 +02:00
b5be399fd4
cubeb: Change name to "Dolphin Emulator"
...
To avoid conflicts with KDE's file manager.
2023-07-22 23:12:34 +02:00
3d9bc85912
Merge pull request #12058 from noahpistilli/android-wiilink
...
Add Enable WiiLink checkbox to Android GUI
2023-07-22 08:14:18 +02:00
6f55e44365
Update libcurl to 8.1.2
2023-07-21 21:59:55 -04:00
fb2b3753b5
Merge pull request #12015 from nyanpasu64/gc-adapter-sleep-detach
...
Fix GC Adapter breaking and burning a full CPU core after sleep-wake on Linux
2023-07-22 03:38:45 +02:00
fd74244339
VideoCommon: add custom texture message to provide a dirty means of debugging whether custom textures are installed correctly
2023-07-21 20:13:27 -05:00
e892b7f1ac
VideoBackends: add support for cube maps for OGL, Vulkan, and D3D
2023-07-21 19:09:40 -05:00
2569d10b3d
Add Enable WiiLink checkbox to Android GUI
2023-07-21 17:46:37 -04:00
7a7e0ab2f5
Fixed Leaderboard Scored message format
...
Refactored the message displayed when a leaderboard is submitted to so that it properly generates and uses a FormattedValue.
2023-07-21 01:45:50 -04:00
eba5291ec7
Skylanders: Update J command documentation
...
I initially thought the 0x01 side was both sides (equavalent to just C. However, this turned out to be something I forgot I implemented in my personal interface. 0x01 does not seem to change any colors.
Recently discovered how exactly the last 2 bytes of the J command for timing data
2023-07-20 23:58:33 +02:00
f7e78742cf
VideoCommon: skip the texture dump if the texture is using a custom texture, regardless of whether or not it is loaded yet
2023-07-19 23:44:41 -05:00
70b3db93e0
Announce RSCRATCH clobbering in Jit64 when profiling is enabled
2023-07-19 14:15:42 -07:00
79f202ea5c
VideoCommon: fix some compiler warnings for CustomAsset. FreeBSD compiler complained about a defaulted move constructor due to the mutex being implicitly deleted. Additionally, the const owning library deleted the copy constructor.
2023-07-16 19:45:55 -05:00
9ebfcebdde
Merge pull request #12049 from iwubcode/initialize_asset_load_info
...
VideoCommon: initialize load info variables in CustomAssetLibrary
2023-07-16 23:32:13 +02:00
2814e4e283
Merge pull request #12033 from mbc07/ColorCorrectionGUI_fixes
...
Qt: Color Correction window fixes
2023-07-16 23:31:59 +02:00
d7e79683cc
Qt: Color Correction window fixes
2023-07-16 16:48:08 -04:00
5740be15f9
VideoCommon: initialize load info variables
2023-07-16 12:56:03 -05:00
cd5aebe5ac
Qt: Add file size stats to NAND Check.
2023-07-14 05:24:29 +02:00
efae5827f2
IOS/FS: Implement GetExtendedDirectoryStats().
...
Behaves like GetDirectoryStats() but doesn't clamp to the Wii limits, so we can tell the user exactly how overfull their NAND is.
2023-07-14 04:48:23 +02:00
0d9e027a0b
IOS/FS: Move NAND size related constants to FileSystem.h.
...
That way they're available for calculating NAND stats to display to the user. This also adds a few more constants.
2023-07-14 04:47:47 +02:00
17f2072e1c
UnitTests: Enable cluster check in FileSystemTest.GetDirectoryStats.
2023-07-14 04:20:57 +02:00
c4978edaf6
Fixed a bug where in the extremely unlikely change that HostIDs collide, a new HostID is generated.
2023-07-13 21:33:36 +10:00
550b9782e1
Do not try portmapping when using traversal server
...
using portmapping with hosting while using traversal server (which is possible by checking the option while under "direct connect" and flipping back to traversal server) causes dolphin to request a mapping to external port 0.
In UPnP a mapping to external port 0 is actually the wildcard, which means that connection requests on all
external ports (that are not otherwise mapped) will be forwarded to the client.
Additionally it seems like using port mapping with traversal server is probably not expected behavior, as the option checkbox disappears when traversal server is used.
2023-07-13 01:15:12 -07:00
cbb76c1d4f
Common/Network: Use StrErrorWrapper
2023-07-12 20:52:35 +04:00
92be54d57a
Common/CommonFuncs: Add StrErrorWrapper function
2023-07-12 20:52:35 +04:00
423c7c58cd
Merge pull request #12042 from JosJuice/logic-op-no-win7
...
D3D: Remove Windows 7 mention in logic ops warning
2023-07-11 20:23:16 -04:00
5acebc71c4
D3D: Remove Windows 7 mention in logic ops warning
...
Dolphin no longer supports Windows 7, so the fact that there are (were?)
more people who use Windows 7 than who use a GPU that doesn't support
the required feature is no longer relevant.
2023-07-11 22:41:51 +02:00
93c8db66d6
Skylanders: More List Fixes
2023-07-10 09:59:00 +01:00
fe8a9ac707
Merge pull request #12024 from iwubcode/material_asset
...
VideoCommon: add material asset
2023-07-09 21:49:16 +02:00
77511e8e7c
VideoCommon: add material asset. A material is similar to other graphics engines where it provides data to be used in conjunction with a shader asset to generate a runtime AbstractShader
2023-07-09 12:21:34 -05:00
bd90f6be78
Merge pull request #12017 from Dentomologist/remove_unused_flowlayout
...
QtUtils: Remove unused FlowLayout
2023-07-09 16:06:35 +02:00
90b1f5c60a
Merge pull request #12020 from Dentomologist/gekkodisassembler_remove_unread_variables
...
GekkoDisassembler: Remove unread variables
2023-07-09 16:00:26 +02:00
80c44ea597
Merge pull request #12034 from MaverickAmon02/controller-update-race
...
Fix unsafe netplay code in SI_DeviceGCController
2023-07-09 14:13:44 +02:00
7bb04ff1dc
Merge pull request #12022 from iwubcode/texture_create_gmod_impl
...
VideoCommon: call into graphics mods create texture callback
2023-07-09 04:20:43 +02:00
d122492db7
Fix unsafe netplay code in SI_DeviceGCController
...
By misusing Config, this netplay-related code opened up a race condition between Config::OnConfigChanged() and SerialInterface::SerialInterfaceManager::UpdateDevices() that could cause iterator invalidation.
2023-07-06 11:34:08 -04:00
c8df26554b
Fix GC adapter not being detected when you enable controller in settings
...
GCAdapter::UseAdapter() reads s_is_adapter_wanted, which gets
initialized by config_guard.~ConfigChangeCallbackGuard(). So we must
wait until after destroying the config guard to know whether we have any
controllers set to GC Adapter.
2023-07-05 20:38:22 -07:00
5d0f1bd10b
Switch libusb_config_descriptor to RAII type
2023-07-05 20:38:22 -07:00
c893ccca58
Workaround GC adapter detection breaking when reset fails
2023-07-05 20:38:22 -07:00
559a16da49
Reset GC adapter upon IO error after sleep-wake
...
Fixes GC adapter breaking on sleep-wake on Linux and burning a full CPU
core. This is cleaner than alternative approaches.
2023-07-05 20:38:22 -07:00
afb5eff426
Don't burn a CPU core and spam logs when GC Adapter fails
2023-07-05 20:38:22 -07:00
54850e936c
Fix memory leak in libusb code
2023-07-05 20:38:22 -07:00
79a4b91d68
Skylander Portal: Simple List Fixes
2023-07-04 16:48:51 +01:00
0366122306
Merge pull request #12009 from iwubcode/shader_asset
...
VideoCommon: add a pixel shader asset
2023-07-03 03:24:11 +02:00
da2784a391
Merge pull request #11878 from LillyJadeKatrin/retroachievements-achievements-tab
...
RetroAchievements - Achievement Progress Tab
2023-07-03 03:23:18 +02:00
a2ad3ca6f7
VideoCommon: don't do pointer copies during graphics mod callback iteration
2023-07-02 13:58:07 -05:00
0539bb4a3e
VideoCommon: call into graphics mods create texture callback, providing additional asset dependencies that trigger the texture to be reloaded
2023-07-02 13:45:09 -05:00
6d7bf60071
Merge pull request #11991 from iwubcode/tcache_multiple_texture_dependencies
...
VideoCommon: allow multiple texture assets to associate with a texture cache entry
2023-07-02 20:14:32 +02:00
a93e6e7397
VideoCommon: add support for allowing a TextureCache entry to be associated with multiple assets
2023-07-02 12:50:07 -05:00
c8e276c6f5
GekkoDisassembler: Remove unread variable m_displacement
2023-07-01 20:09:10 -07:00
98c9049184
GekkoDisassembler: Remove unread variable m_sreg
2023-07-01 20:09:09 -07:00
ccc9d0e5ea
Synchronized Achievement Window
...
Expanded the use of the lock mutex already used for loading the player's existing unlock status to guard against races involving the Achievements dialog window reading from data AchievementManager might be in the process of updating. The lock has been exposed publicly and the AchievementsWindow uses it in its UpdateData method, and anywhere else that might modify data used to render that window has also been wrapped with it.
2023-07-01 22:26:30 -04:00
fbaeaf305b
Add UpdateCallback to AchievementManager
...
AchievementManager now has a SetUpdateCallback method for providing a single universal callback for anytime something important changes in the achievement state, such as logging in/out, game load/close, or events such as achievement unlocks. AchievementsWindow sets this callback in its own init to its UpdateData method so that the AchievementsWindow gets updated when one of these changes takes place.
2023-07-01 22:26:29 -04:00
582042de1f
Added AchievementProgressWidget to AchievementsWindow
...
This widget is a tab in the AchievementsWindow that displays the player's current achievement progress: which achievements are locked or unlocked, and the progress of achievements that have progress metrics.
2023-07-01 22:26:29 -04:00
ebe77f149f
Added AchievementHeaderWidget to AchievementsWindow
...
This widget displays a header on the AchievementsWindow dialog above the tabs that shows the currently logged in user (if there is one) and the game they are playing (if there is one).
2023-07-01 22:26:29 -04:00
f700faf6ab
Expose Achievements Data for Display
...
Added some small methods to AchievementManager to expose useful data for displaying in an achievement UI. Also moved a couple things from private to public for the same purpose.
2023-07-01 22:26:29 -04:00
6fe3cfe245
QtUtils: Remove unused FlowLayout
...
FlowLayout hasn't been used since
b65faa0549
2023-07-01 11:33:54 -07:00
eedc1144c1
Merge pull request #11923 from iwubcode/multi-texture-compute-support
...
VideoBackends: support multiple compute images for some backends
2023-07-01 17:47:55 +02:00
179d823852
Merge pull request #11992 from Dentomologist/remove_mtype_and_associated_enum
...
GekkoDisassembler: Remove unread variable and associated enum
2023-07-01 09:00:42 +02:00
ed4403537f
Merge pull request #11916 from JosJuice/ppcanalyst-reorder-loop
...
PPCAnalyst: Reduce number of iterations in ReorderInstructionsCore
2023-07-01 01:06:53 +02:00
82c986816f
Merge pull request #11978 from AdmiralCurtiss/wiimote-S_FALSE
...
WiimoteReal/IOWin: Don't try to print error message for non-errors.
2023-07-01 00:58:42 +02:00
e71f42f819
Merge pull request #11997 from Dentomologist/dspemulator_remove_pauseandlock_parameter
...
DSPEmulator: Remove unused PauseAndLock parameter
2023-07-01 00:56:45 +02:00
94f34260a6
Merge pull request #12001 from Filoppi/patch-21
...
Qt: Fix some Post Process Configuration Widget issues #3-4
2023-06-30 19:11:10 +02:00
fa81006b51
Merge pull request #11955 from TellowKrinkle/CMakeDependencies
...
CMake: Allow ignoring system packages
2023-06-30 19:06:04 +02:00
e4d7ba5554
Merge pull request #12007 from AdmiralCurtiss/cmake-scmrev-at-build-time
...
CMake: Generate scmrev.h at build time instead of configure time.
2023-06-30 18:59:33 +02:00
6ea49c6746
VideoCommon: add a pixel shader asset
2023-06-30 01:32:53 -05:00
ff324ef660
Merge pull request #12010 from TellowKrinkle/AlignUpOpt
...
Common: Better AlignUp implementation
2023-06-29 20:30:13 -04:00
bfb90b7eec
Video: increase the max HDR brightness multiplier to a more appropriate value (400 nits can be too dark in a bright room)
2023-06-29 14:24:28 +03:00
28fafbeef2
Qt: Fix some Post Process Configuration Widget issues n3
...
1 ) When first opened, the (user selected) post process shader config widget would print the wrong values on the text label next to int range sliders. For example if the range was from 1 to 6, and the value loaded from the config was 1, the label would print 0 when first opened, to then start showing the correct value once the slider was first moved.
This mirrors the behaviour of the float slider code below:
```auto* const value_box = new QLineEdit(QString::asprintf("%f", m_config_option->m_float_values[i]));```
2 ) The defautl int slider value would also be set wrong on first load, as it was being divided by the slider max instead of the slider step amount (again, just like for the float implementation). This is a mistake I had made with my previous submission.
2023-06-29 14:13:38 +03:00
d844317a6d
Common: Better AlignUp implementation
2023-06-29 02:35:44 -05:00
4774fe3445
VKGfx: Add parentheses around ambiguous if statements.
2023-06-29 03:59:18 +02:00
2a6f4d879c
CMake: Generate scmrev.h at build time instead of configure time.
2023-06-29 03:23:31 +02:00
3627398cf5
VideoBackends: support multiple compute images for some backends (D3D, OGL, Vulkan)
2023-06-28 17:15:31 -05:00
61c45e8d68
Merge pull request #12002 from JosJuice/i18n-empty-string
...
DolphinQt: Don't translate empty strings
2023-06-28 18:56:35 +02:00
e185dbf857
Merge pull request #11989 from JosJuice/android-title-on-shutdown
...
Android: Handle game shutdown in onTitleChanged
2023-06-28 12:48:54 -04:00
3384e02098
DolphinQt: Don't translate empty strings
...
Trying to translate an empty string will return a long metadata string
for the loaded translation file rather than the expected empty string.
2023-06-28 18:43:52 +02:00
fc4036af80
VideoBackends:Metal: Multi render target support
2023-06-28 00:11:37 -05:00
766b8605f8
Merge pull request #11994 from JosJuice/skylanders-i18n
...
DolphinQt: Add i18n comments for Skylanders strings
2023-06-27 22:40:14 +02:00
a7aee396f6
Merge pull request #11929 from t895/gradle-updates
...
Android: Gradle updates
2023-06-26 19:44:23 +02:00
ee684b0798
DSPEmulator: Remove unused PauseAndLock parameter
2023-06-25 20:29:23 -07:00
f151ae3c2a
EXI: Remove pointless PauseAndLock functions
...
The ExpansionInterfaceManager::PauseAndLock function does nothing but
call other functions that have no effect.
ExpansionInterfaceManager::PauseAndLock calls CEXIChannel::PauseAndLock,
which in turn calls IEXIDevice::PauseAndLock. None of the classes
deriving from IEXIDevice override PauseAndLock, and the implementation
in IEXIDevice does nothing.
2023-06-25 20:08:08 -07:00
3a8e7de214
Merge pull request #11903 from noahpistilli/wiilink
...
IOS/KD: Add WiiLink as WC24 service provider by default
2023-06-26 02:27:47 +02:00
f9f8e94e30
Add default support for WiiLink + configuration
2023-06-25 14:57:15 -04:00
ac53ab184c
Merge pull request #11952 from K0bin/no-per-game-driver
...
Android: Remove GPU driver from per-game settings
2023-06-25 19:00:01 +02:00
09f8f29ae0
DolphinQt: Add i18n comments for Skylanders strings
...
Also changed the spelling of "Superchargers" to "SuperChargers".
2023-06-25 15:38:30 +02:00
2472269d06
GekkoDisassembler: Remove unused enum InstructionType
2023-06-24 13:45:26 -07:00
2cf48bc32c
GekkoDisassembler: Remove unread variable m_type
...
Writes to m_type are pointless because it's never read.
2023-06-24 13:45:26 -07:00
50c929928c
Merge pull request #11920 from Minty-Meeo/kill-ascii-to-hex
...
Kill AsciiToHex
2023-06-23 18:20:36 -07:00
b5e197e2dc
Android: Handle game shutdown in onTitleChanged
2023-06-23 20:40:04 +02:00
38a5774a85
Android: Remove GPU driver from per-game settings
2023-06-23 20:13:14 +02:00
c04536c5d0
Merge pull request #11982 from iwubcode/graphics_mod_create_texture_callback
...
VideoCommon: add graphics mod callback interface for when a texture is created
2023-06-23 18:10:59 +02:00
02909bd1a5
Merge pull request #11850 from Filoppi/post_process_fixes
...
Video: implement color correction to match the Wii/GC NTSC/PAL color spaces (and gamma)
2023-06-23 18:08:23 +02:00
5bf3d55d38
Merge pull request #11981 from iwubcode/move_cached_asset_to_common
...
VideoCommon: move cached texture asset to 'CustomAsset' common code
2023-06-23 17:59:24 +02:00
b5ba51c60a
Core: Remove host thread assert in PauseAndLock().
...
Fixing all the places it's used turned out to be a more complicated task than anticipated. So let's remove this for now so we don't confuse users with cryptic error messages...
2023-06-23 01:18:56 +02:00
445bf8d2c6
Kill AsciiToHex
...
Now superseded by Common::FromChars
2023-06-22 00:06:50 -05:00
1f130bf8a3
Android: Declare host thread when generating analytics ID
...
Another instance of the host thread check failing.
2023-06-21 18:16:46 +02:00
bc0e8158b3
IOS/KD/Time: Take into account DST for AdjustedUTC
2023-06-20 22:49:33 -04:00
1d767c3a5b
VideoCommon: add graphics mod callback interface for when a texture is created
2023-06-20 19:26:53 -05:00
2dc24a9148
VideoCommon: move cached texture asset to 'CustomAsset' common code
2023-06-20 18:59:55 -05:00
5ad2d86cc7
Merge pull request #11979 from nicovank/master
...
Minor fix: Rename Symbol constructor parameter to prevent shadowing
2023-06-21 00:54:30 +02:00
deb37f0846
Merge pull request #11964 from JosJuice/android-hide-infinity
...
Android: Hide Infinity Base in MenuFragment when not relevant
2023-06-20 17:11:18 -04:00
4ef2f2c710
Rename Symbol constructor parameter to prevent shadowing
2023-06-20 13:38:31 -04:00
00bf5f55de
WiimoteReal/IOWin: Don't try to print error message for non-errors.
2023-06-20 01:54:59 +02:00
27db8d4123
Merge pull request #11935 from nitanmarcel/patch-1
...
Use getCacheDir if getExternalCacheDir returns null.
2023-06-19 20:47:27 +02:00
cff3e22f84
Merge pull request #11926 from JosJuice/android-host-check
...
Android: Re-add host thread check
2023-06-19 20:37:59 +02:00
5d7b5822c9
Merge pull request #11972 from Minty-Meeo/string-improvements-part-1c
...
Replace std::ostringstream usage with fmt::format
2023-06-19 02:18:30 +02:00
ffabb6c57b
Replace std::ostringstream usage with fmt::format
2023-06-18 18:37:32 -05:00
daddf4cd9c
Qt: add color correction and HDR Qt settings widgets
2023-06-19 01:34:42 +03:00
a2702c6e27
Video: implement color correction to match the NTSC and PAL color spaces (and gamma) that GC and Wii targeted.
...
To further increase the accuracy of the post process phase, I've added (scRGB) HDR support, which is necessary
to fully display the PAL and NTSC-J color spaces, and also to improve the quality of post process texture samplings and
do them in linear space instead of gamma space (which is very important when playing at low resolutions).
For SDR, the quality is also slightly increased, at least if any post process runs, as the buffer is now
R10G10B10A2 (on Vulkan, DX11 and DX12) if supported; previously it was R8G8B8A8 but the alpha bits were wasted.
Gamma correction is arguably the most important thing as Dolphin on Windows outputted in "sRGB" (implicitly)
as that's what Windows expects by default, though sRGB gamma is very different from the gamma commonly used
by video standards dating to the pre HDR era (roughly gamma 2.35).
Additionally, the addition of HDR support (which is pretty straight forward and minimal), added support for
our own custom AutoHDR shaders, which would allow us to achieve decent looking HDR in Dolphin games without
having to use SpecialK or Windows 11 AutoHDR. Both of which don't necessarily play nice with older games
with strongly different and simpler lighting. HDR should also be supported in Linux.
Development of my own AutoHDR shader is almost complete and will come next.
This has been carefully tested and there should be no regression in any of the different features that Dolphin
offers, like multisampling, stereo rendering, other post processes, etc etc.
Fixes: https://bugs.dolphin-emu.org/issues/8941
Co-authored-by: EndlesslyFlowering <EndlesslyFlowering@protonmail.com>
Co-authored-by: Dogway <lin_ares@hotmail.com>
2023-06-19 01:34:42 +03:00
9e06b6964b
Merge pull request #11963 from iwubcode/d3d12_fix
...
VideoBackends: fix d3d12 error when validation layers enabled
2023-06-19 00:33:40 +02:00
8039d10994
Merge pull request #11966 from Dentomologist/convert_xemitter_prefetchlevel_to_enum_class
...
xEmitter: Convert PrefetchLevel to enum class
2023-06-18 15:17:02 +02:00
2d18c9e079
Merge pull request #11976 from JosJuice/emitter-nodiscard
...
Arm64Emitter/x64Emitter: Use nodiscard for FixupBranch
2023-06-18 15:16:42 +02:00
0584f8ae2a
Video: fix Vulkan RGBA10_2 format to the actual most common one (used as swapchain format)
2023-06-18 12:58:40 +03:00
39a8219767
Arm64Emitter/x64Emitter: Use nodiscard for FixupBranch
...
This should prevent future occurrences of the type of problem that was
fixed in b713042
2023-06-18 09:10:20 +02:00
80575c4489
DITConfiguration: Use File::ReadFileToString
2023-06-17 19:38:15 -05:00
04fcf68176
xEmitter: Convert PrefetchLevel to enum class
2023-06-17 16:41:32 -07:00
b71304230c
Jit64: Fix trampolines after #11834 .
2023-06-18 01:31:44 +02:00
93d9e90798
Merge pull request #11962 from Minty-Meeo/to-underlying
...
EnumUtils: Add Common::ToUnderlying
2023-06-17 20:04:25 +02:00
696087cae0
Qt/NetworkWidget: Get rid of some trivial sign conversions
...
In all instances, these variables should be signed rather than unsigned.
2023-06-17 10:48:49 -04:00
7523a62105
Change unnamed enum in NativeVertexFormat.h to u32
2023-06-17 08:13:57 -05:00
79d5850e6a
Merge pull request #11960 from Minty-Meeo/dolphin-tool-code-review-4
...
DolphinTool: Use {fmt} library
2023-06-17 14:18:21 +02:00
07ad75f34f
EnumUtils: Add Common::ToUnderlying
...
Mirrors the C++23 <utility> function, std::to_underlying
2023-06-17 07:15:33 -05:00
f16381adc5
Android: Hide Infinity Base in MenuFragment when not relevant
2023-06-17 11:57:53 +02:00
ba74902bca
VideoBackends: fix d3d12 validation layer error introduced by multi-output texture breaking logic ops support
2023-06-17 01:48:59 -05:00
e67c196d2a
DolphinTool: Less string copies
2023-06-16 21:51:06 -05:00
410c4ffe75
DolphinTool: Use {fmt} library
2023-06-16 21:45:59 -05:00
5029924ba1
Merge pull request #11954 from Minty-Meeo/dolphin-tool-code-review-3
...
DolphinTool: Use EXIT_SUCCESS and EXIT_FAILURE
2023-06-17 04:44:09 +02:00
1aef85a985
Merge pull request #11918 from TellowKrinkle/DPIScale
...
Improved DPI change handling
2023-06-17 04:07:13 +02:00
089d433996
Merge pull request #11956 from JosJuice/jitarm64-12-bit-asm
...
JitArm64: Micro-optimizations in fres routine
2023-06-17 04:00:22 +02:00
969eeb4b52
DolphinTool: Use EXIT_SUCCESS and EXIT_FAILURE
2023-06-16 21:00:10 -05:00
25c020cbe2
DolphinTool: Ditch OOP design
2023-06-16 20:39:16 -05:00
98b5d72ef1
Merge pull request #11951 from Minty-Meeo/dolphin-tool-code-review-1
...
DolphinTool: Sensible changes
2023-06-17 03:03:26 +02:00
31e78c40a1
DolphinTool: Sensible changes
2023-06-16 18:28:03 -05:00
cbcf5bfac1
Merge pull request #11889 from Filoppi/patch-18
...
Fix video output having small black borders all the times
2023-06-16 17:59:51 +02:00
50301bf1d1
Merge pull request #11957 from lioncash/resource
...
UICommon/ResourcePack: Allow priority helpers to take arguments by const reference
2023-06-16 17:01:19 +02:00
653d6d059f
UICommon/ResourcePack: Allow priority helpers to take arguments by const reference
...
There's nothing going on with behavior here that would prevent these
from being const qualified.
Also better communicates that this function isn't intended to modify the
given resource pack.
2023-06-16 10:20:50 -04:00
f5eea4a957
Merge pull request #11834 from Dentomologist/xemitter_use_pseudonamed_parameter_force5bytes
...
XEmitter: Add enum class Force5Bytes
2023-06-16 15:46:36 +02:00
9c13436e2b
JitArm64: Improve instruction scheduling in fres routine
...
We want to have a low number of instructions between the LDP and the
MADD so that the MADD can start immediately after the LDP finishes
even if we're on a lower-end in-order CPU.
2023-06-15 22:02:39 +02:00
f0f8225ff8
Merge pull request #11424 from Pokechu22/jit-imm-loadstore-update
...
Jit64: Attempt to fix updating stores with an immediate value
2023-06-15 11:32:30 -04:00
5b10a80401
CMake: Use targets for all optionally-external dependencies
2023-06-15 01:41:41 -05:00
5b5124d9ff
JitArm64: Use immediates more in fres routine
...
Not sure why I didn't do this to begin with. Maybe I was under the
impression that the most significant bit of a 12-bit immediate was a
sign bit.
2023-06-14 23:27:58 +02:00
bd125733f0
Merge pull request #11946 from Dentomologist/convert_fromwhichroot_to_enum_class
...
Common: Convert FromWhichRoot to enum class
2023-06-14 13:29:07 +02:00
88ff00a05c
Merge pull request #11942 from Dentomologist/convert_controlleremu_translatability_to_enum_class
...
ControllerEmu: Convert Translatability to enum class
2023-06-14 13:27:47 +02:00
79073c1a40
Merge pull request #11944 from lioncash/casts
...
PPCCache: Remove redundant reinterpret_casts
2023-06-14 13:25:48 +02:00
7ff7c9e84f
Common: Convert FromWhichRoot to enum class
2023-06-13 13:25:22 -07:00
cff7a4bfd2
Use getCacheDir if getExternalCacheDir returns null.
2023-06-13 18:44:27 +00:00
ae4d52c838
Android: Fix overlay d-pad not working until finger moves
...
A switch case fallthrough was overlooked when translating from Java to
Kotlin.
2023-06-13 20:37:59 +02:00
c961c6c35a
Android: Fix pressing up on overlay d-pad
2023-06-13 20:37:59 +02:00
708c986693
PPCCache: Remove redundant reinterpret_casts
...
The pointer is being passed to functions that take arguments as void*,
so we don't need to cast here.
2023-06-13 08:25:26 -04:00
6d16a09707
Merge pull request #11941 from Dentomologist/convert_blockingloop_stopmode_to_enum_class
...
Common: Convert BlockingLoop::StopMode to enum class
2023-06-13 11:47:20 +02:00
74c0519c54
Merge pull request #11930 from iwubcode/game_texture_validation
...
VideoCommon: don't reject game textures which have the wrong size
2023-06-13 11:43:35 +02:00
3e27fc7c0b
VideoCommon: don't treat incorrect aspect ratio or sizes that aren't a multiple of native textures as an error
2023-06-12 21:19:29 -05:00
527f8e783c
ControllerEmu: Convert Translatability to enum class
2023-06-12 18:11:04 -07:00
3c80f821c0
Common: Convert BlockingLoop::StopMode to enum class
2023-06-12 17:12:25 -07:00
63090d411d
Merge pull request #11940 from lioncash/debugiface
...
Common: Move DebugInterface.h into Core
2023-06-13 01:59:33 +02:00
f11175d117
Revert "Android: Temporarily disable host thread check"
...
This reverts commit 361171fce0
2023-06-12 23:39:42 +02:00
03f2f57edf
Android: Add HostThreadLock where necessary
2023-06-12 23:39:42 +02:00
3519a7070d
Android: And Lock and Unlock wrappers to HostThreadLock
...
This way we can ensure DeclareAsHostThread and UndeclareAsHostThread
are called when locking and unlocking.
2023-06-12 23:39:42 +02:00
5524042922
Android: Move host thread lock to a separate file
2023-06-12 23:39:42 +02:00
4c2759f541
XEmitter: Add enum class Jump
...
Replace the bool parameter force5bytes in J, JMP, and J_CC with an enum
class Jump::Short/Near. Many callers set that parameter to the literal
'true', which was unclear if you didn't already know what it did.
2023-06-12 13:04:18 -07:00
c8559a7933
Merge pull request #11863 from Minty-Meeo/nkit-extract
...
Remove NKit data when extracting a GCN/Wii disc volume
2023-06-12 15:37:02 -04:00
635bce2e7b
Merge pull request #11939 from lioncash/condition
...
BreakpointDialog: Mark breakpoint help text as translatable
2023-06-12 20:13:07 +02:00
b4d161ff29
Merge pull request #11938 from lioncash/inits
...
ParallelProgressDialog: Initialize all data members
2023-06-12 20:07:57 +02:00
b3f4006bb7
Merge pull request #11937 from lioncash/sky
...
SkylanderPortalWindow: Detranslate unnecessary strings
2023-06-12 20:07:37 +02:00
41df38cb7c
Common: Move DebugInterface.h into Core
...
The base DebugInterface now depends on the Core's CPUThreadGuard, and
utilities in Common shouldn't be depending on Core facilities. So, we
can move this into the core library instead.
2023-06-12 10:35:31 -04:00
6e9afd9a73
BreakpointDialog: Mark breakpoint help text as translatable
...
We already mark the title of the dialog box as translatable, so it
would be a bit odd to not mark the containing text as translatable too.
2023-06-12 09:50:17 -04:00
9c0cd5c81a
ParallelProgressDialog: Mark WasCanceled() as const
...
This doesn't alter any class state.
2023-06-12 09:38:10 -04:00
b70894b950
ParallelProgressDialog: Initialize all data members
...
Ensures we always have a deterministic state.
2023-06-12 09:36:51 -04:00
001fe6ff61
SkylanderPortalWindow: Detranslate unnecessary strings
...
This doesn't need to be handled by translators, since they're not
user-displayed text or just don't need to be translated.
While we're at it, we don't need to copy each entry of the resulting
list.
2023-06-12 09:26:16 -04:00
cbd2a720bb
InfinityBaseWindow: Remove unnecessary system instance accessor
...
GetFigureList() is a static member function, so we can just call it
directly instead of going through the system instance.
2023-06-12 09:02:20 -04:00
9a7e1652f3
Android: Target Java 17
2023-06-11 23:44:44 -04:00
7822e662f5
Android: Update Kotlin to 1.8.21
...
Additionally updates the serialization plugin to match
2023-06-11 23:44:44 -04:00
4934b6e30b
Android: Update dependencies
2023-06-11 23:44:44 -04:00
7c2c558646
Android: Upgrade to AGP 8.0.2
2023-06-11 23:44:44 -04:00
4e4705e983
Merge pull request #11931 from t895/build-flag-fix
...
Android: Fix use of deprecated JVM flag
2023-06-11 23:37:53 -04:00
1a0a1e8f12
Merge pull request #10976 from TellowKrinkle/StackFrames
...
Improve stack frames for profilers
2023-06-12 05:00:08 +02:00
78f7463363
Android: Fix use of deprecated JVM flag
2023-06-11 22:54:31 -04:00
fc53dca7bd
Qt: Send SizeChanged on DPI changes
2023-06-11 20:05:27 -05:00
d3110b9521
VideoCommon: Update imgui scale when dpi changes
2023-06-11 20:05:27 -05:00
157deb5864
Merge pull request #11928 from K0bin/adrenotools-release-build-fix
...
Android: Fix Adrenotools in release builds
2023-06-11 17:02:36 -04:00
8db5775a1b
Merge pull request #11927 from JosJuice/android-custom-file-extension-locale
...
Android: Check file name extensions locale-independently
2023-06-11 16:52:50 -04:00
6f55b26751
Android: Fix Adrenotools in release builds
2023-06-11 22:44:48 +02:00
5c0581e990
Merge pull request #11867 from K0bin/adrenotools
...
Implement loading custom drivers on Android
2023-06-11 14:17:39 -04:00
fee86e8536
Android: Check file name extensions locale-independently
...
A very minor bug that became more obvious when this code was translated
to Kotlin.
2023-06-11 19:03:49 +02:00
2da7d16b7c
Android: Implement a UI for Adrenotools
2023-06-11 13:53:31 +02:00
23bebc5270
VideoBackends:Vulkan: Allow loading custom drivers on Android
...
... using libadrenotools
2023-06-11 13:52:34 +02:00
28785c5fad
Android: Convert SaveLoadStateFragment to Kotlin
2023-06-11 00:53:26 -04:00
d26eddd4e2
Android: Convert MenuFragment to Kotlin
2023-06-11 00:53:26 -04:00
afb6719a1a
Android: Convert EmulationFragment to Kotlin
2023-06-11 00:53:26 -04:00
7e7cd6ff76
Android: Convert CustomFilePickerFragment to Kotlin
2023-06-11 00:53:26 -04:00
28ed1f8be1
Common:AGL: Support making temporary contexts from the main thread
...
- Don't crash when making contexts from the main thread
- Don't focus the window when making a context
2023-06-10 14:25:45 -05:00
7752e247f7
Merge pull request #11911 from TellowKrinkle/MTLParallelCompilation
...
VideoBackends:Metal: Enable shouldMaximizeConcurrentCompilation when available
2023-06-10 19:39:24 +02:00
03ec86f248
Qt: Add float config tooltip slider
2023-06-09 22:07:12 +02:00
061ec365a8
PPCAnalyst: Reduce number of iterations in ReorderInstructionsCore
...
We can utilize the fact that if swapping two instructions causes another
swap to become possible, that swap involves one of the two instructions
we just swapped. There's need to search for new swap opportunities as
far back as the beginning of the block; we can just go one step back.
2023-06-09 19:45:51 +02:00
8f51a9d2d8
Merge pull request #11699 from Pokechu22/gl-check-maximum-samples
...
OpenGL: Check the list of supported AA modes instead of hardcoding
2023-06-09 15:07:07 +02:00
092773ad0c
Merge pull request #11859 from iwubcode/backend-multi-output
...
VideoBackends: add support to allow rendering to multiple output targets
2023-06-09 13:40:21 +02:00
ac48b2eea4
EnhancementsWidget: Handle gaps in AA mode list
...
Mesa (llvmpipe) only reports 4x MSAA, and doesn't report 2x (or 1x, but we implicitly add that). The old logic did not handle this correctly, causing selecting 4x to fail and fall back to None.
This also removes VideoUtils::GetAvailableAntialiasingModes, and thus VideoUtils entirely, as its only other function was removed in 1f74653501
2023-06-08 22:07:41 -07:00
b246a634d4
OpenGL: Check the list of supported AA modes instead of hardcoding
2023-06-08 22:07:41 -07:00
c63f0f37cd
VideoCommon: Pass WindowSystemInfo to InitBackendInfo
2023-06-08 22:07:39 -07:00
afa498fa2f
VideoCommon: update DirectFilesystemAssetLibrary to not throw exceptions when a file no longer exists
2023-06-08 22:20:52 -05:00
429b2eca8a
VideoCommon: add logging for loading texture assets
2023-06-08 19:48:45 -05:00
e7f4b7679b
VideoBackends:Metal: Enable shouldMaximizeConcurrentCompilation when available
2023-06-08 18:57:41 -05:00
7845fb00ee
Merge pull request #11681 from iwubcode/asset_management
...
VideoCommon: migrate texture packs to use the asset loader system
2023-06-08 22:21:12 +02:00
f561bd4285
Merge pull request #11910 from lioncash/construct
...
PowerPC/ConditionRegister: Mark PPCToInternal() as constexpr
2023-06-08 21:26:07 +02:00
0d07ebab25
Merge pull request #11908 from lioncash/strcopy
...
Debugger: Remove some trivial string copies
2023-06-08 20:54:21 +02:00
e8c87dc4fd
Merge pull request #11902 from Minty-Meeo/regex-best-practices
...
static const std::regex
2023-06-08 20:52:11 +02:00
e3cae72c18
Merge pull request #11909 from lioncash/spans
...
GCMemcardUtils: Make use of std::span where applicable
2023-06-08 20:46:08 +02:00
09271f365a
PowerPC/ConditionRegister: Mark PPCToInternal() as constexpr
...
This allows the compiler to eliminate a static constructor that
initializes the table, and instead precompute all of the data ahead of
time.
e.g. We get something like so on GCC without constexpr:
_GLOBAL__sub_I_PowerPC::ConditionRegister::s_crTable:
movdqa xmm0, XMMWORD PTR .LC0[rip]
movaps XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip], xmm0
movdqa xmm0, XMMWORD PTR .LC1[rip]
movaps XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+16], xmm0
movdqa xmm0, XMMWORD PTR .LC2[rip]
movaps XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+32], xmm0
movdqa xmm0, XMMWORD PTR .LC3[rip]
movaps XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+48], xmm0
movdqa xmm0, XMMWORD PTR .LC4[rip]
movaps XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+64], xmm0
movdqa xmm0, XMMWORD PTR .LC5[rip]
movaps XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+80], xmm0
movdqa xmm0, XMMWORD PTR .LC6[rip]
movaps XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+96], xmm0
movdqa xmm0, XMMWORD PTR .LC7[rip]
movaps XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+112], xmm0
ret
PowerPC::ConditionRegister::s_crTable:
.zero 128
.LC0:
.quad -9223372032559808511
.quad -8646911280256385023
.LC1:
.quad -9223372032559808512
.quad -8646911280256385024
.LC2:
.quad 4294967297
.quad 576460756598390785
.LC3:
.quad 4294967296
.quad 576460756598390784
.LC4:
.quad -4611686014132420607
.quad -4035225261828997119
.LC5:
.quad -4611686014132420608
.quad -4035225261828997120
.LC6:
.quad 4611686022722355201
.quad 5188146775025778689
.LC7:
.quad 4611686022722355200
.quad 5188146775025778688
and with constexpr, this all get collapsed into:
PowerPC::ConditionRegister::s_crTable:
.quad -9223372032559808511
.quad -8646911280256385023
.quad -9223372032559808512
.quad -8646911280256385024
.quad 4294967297
.quad 576460756598390785
.quad 4294967296
.quad 576460756598390784
.quad -4611686014132420607
.quad -4035225261828997119
.quad -4611686014132420608
.quad -4035225261828997120
.quad 4611686022722355201
.quad 5188146775025778689
.quad 4611686022722355200
.quad 5188146775025778688
completely eliminating the static constructor. MSVC also exhibits this,
whereas clang is a little better and does this anyway, even without
constexpr.
2023-06-08 14:33:13 -04:00
349add0f81
GCMemcardManager: Shorten-up EnumMap definitions
...
We can make a small alias that gets rid of the need to repeat the long
constant.
2023-06-08 13:05:13 -04:00
Dentomologist