Admiral H. Curtiss
9a51215af3
Merge pull request #12083 from JosJuice/android-controlled-by-gamepad
...
InputConfig: Update IsControllerControlledByGamepadDevice for Android input overhaul
2023-08-18 21:27:26 +02:00
xujibbs
b3902397cb
DolphinQt/TASInputWindow: Make 'Enable Controller Input' translatable.
2023-08-18 21:02:30 +02:00
Admiral H. Curtiss
3441fe6efc
Merge pull request #11999 from Filoppi/post_process_fixes
...
Video: implement output resampling (upscaling/downscaling) methods
2023-08-18 20:33:09 +02:00
JosJuice
a9ec2a6e41
Merge pull request #12116 from AdmiralCurtiss/log-colors
...
DolphinQt/LogWidget: Restore log window colors.
2023-08-18 09:00:43 +02:00
Filoppi
8bca9a864f
Video: The `Auto` internal resolution scaling wasn't working correctly if the window weird aspect ratios (e.g. 32:9), beacuse it would account for the the portion of the image that will show black bars into the calcuations to find the best matching resolution
2023-08-18 02:14:00 +03:00
Filoppi
6c7f34d5da
Video: The `Auto-Adjust Window Size` setting was calculating the window size based on the resolution of the window in the previous frame if we used the "stretch" aspect ratio setting, so it's result would be self influence in a loop and behave unreliably (e.g. when changing resolution between Auto/Native/2x the automatic window scaling would behave randomly)
2023-08-18 02:14:00 +03:00
Filoppi
cb34d1aafe
Video: There was always a black line around one of the 4 edges (top/left/bottom/right) of the window because the final output size wasn't calculated right (unless the aspect ratio was set to stretch)
2023-08-18 02:14:00 +03:00
Filoppi
fae3aee9e0
Video: The `% 4` that was done on the rendering resolution was only meant to be done when recording videos (due to encoding limitations) but one case was missed (this had no consequences really, as it was just in the code that automatically resizes the window). The hardcoded `4` has been replaced with `VIDEO_ENCODER_LMC` for clarity.
2023-08-18 02:14:00 +03:00
Filoppi
80b453082d
Video: fix post process shaders with parameters failing to build on OpenGL
...
This was because the shader uniforms between the pixel and vertex shaders
were willingly left different, to avoid filling the vertex shader with unnecessary
params. Turns out all backends are fine with this except OGL.
The new behaviour is now much more consistent and well explained,
the "default" shaders are the ones that always run, and the non default
ones are the user selected ones (if any).
2023-08-18 02:00:56 +03:00
Sam Belliveau
39d96a21a8
Video: Improved Tooltips & Bicubic ( #5 )
...
Edited by Filoppi
2023-08-18 02:00:56 +03:00
Sam Belliveau
ca93a5191f
Video: Added Box Resampling
...
Edited by Filoppi
2023-08-18 02:00:56 +03:00
Filoppi
2edf81cdb0
Video: implement output resampling (upscaling/downscaling) methods
2023-08-18 02:00:55 +03:00
Admiral H. Curtiss
1854ff0142
Merge pull request #12003 from Filoppi/auto_hdr
...
Add AutoHDR post process shader
2023-08-18 00:20:08 +02:00
Admiral H. Curtiss
ecf5870a91
Merge pull request #12115 from AdmiralCurtiss/advanced-config
...
DolphinQt/AdvancedPane: UI improvements.
2023-08-18 00:16:59 +02:00
Admiral H. Curtiss
42e893d6be
Merge pull request #12114 from AdmiralCurtiss/color-correction-button
...
DolphinQt/EnhancementsWidget: Use custom tooltip for Color Correction button.
2023-08-18 00:16:47 +02:00
Admiral H. Curtiss
fc7ef66669
Merge pull request #12110 from JosJuice/android-dir-init-toast
...
Android: Move DirectoryInitialization toast to UI thread
2023-08-18 00:15:15 +02:00
Admiral H. Curtiss
a08792033a
Merge pull request #12103 from iwubcode/asset_load_system_time
...
VideoCommon: asset load time is now stored as a chrono system_clock time
2023-08-18 00:14:29 +02:00
JosJuice
b62c25864f
CPUThreadConfigCallback: Remove some CPU thread asserts
...
Turns out that we have two subsystems that want to register CPU thread
callbacks from a different thread than the CPU thread: FreeLookConfig
and VideoConfig. Both seem to happen from the host thread before the CPU
thread starts, so there's no thread safety issue. But ideally, if we
want to allow registering callbacks from threads other than the CPU
thread, we should make registering callbacks actually thread-safe. This
is an unsolved problem for the regular Config system, so I would like to
leave it outside the scope of this PR.
2023-08-17 19:19:26 +02:00
JosJuice
7197e3abd0
Use structs for config callback IDs
...
This way you can't mix up regular config callback IDs and CPU thread
config callback IDs. (It would be rather bad if you did!)
2023-08-17 19:19:26 +02:00
JosJuice
1104b93ee4
UnitTests: Declare as CPU thread when using CPUThreadConfigCallback
...
This fixes a bunch of DEBUG_ASSERTs in the unit tests.
2023-08-17 19:19:25 +02:00
JosJuice
2b17e89336
Config: Don't clear callbacks on shutdown
...
This fixes a problem that started happening in CoreTimingTest after the
previous commit. CPUThreadConfigCallback registers a Config callback
only once per run of the process, but CoreTimingTest calls
Config::Shutdown after each test, and Config::Shutdown was clearing all
callbacks, preventing the callback from running after that.
2023-08-17 19:19:25 +02:00
JosJuice
71ce8bb6f0
Don't call RunAsCPUThread in config callbacks
...
In theory, our config system supports calling Set from any thread. But
because we have config callbacks that call RunAsCPUThread, it's a lot
more restricted in practice. Calling Set from any thread other than the
host thread or the CPU thread is formally thread unsafe, and calling Set
on the host thread while the CPU thread is showing a panic alert causes
a deadlock. This is especially a problem because 04072f0
made the
"Ignore for this session" button in panic alerts call Set.
Because so many of our config callbacks want their code to run on the
CPU thread, I thought it would make sense to have a centralized way to
move execution to the CPU thread for config callbacks. To solve the
deadlock problem, this new way is non-blocking. This means that threads
other than the CPU thread might continue executing before the CPU thread
is informed of the new config, but I don't think there's any problem
with that.
Intends to fix https://bugs.dolphin-emu.org/issues/13108 .
2023-08-17 19:19:25 +02:00
Admiral H. Curtiss
a9cba9be36
DolphinQt/LogWidget: Restore log window colors.
2023-08-16 19:55:18 +02:00
Admiral H. Curtiss
a34f221782
Core/PowerPC: Return AvailableCPUCores() as a std::span.
2023-08-16 19:25:03 +02:00
Admiral H. Curtiss
51f807b63a
DolphinQt/AdvancedPane: Update all GUI elements from config in Update().
2023-08-16 19:25:03 +02:00
Admiral H. Curtiss
ccee66dc80
DolphinQt/AdvancedPane: Use ConfigBool for MMU, Pause on Panic, and Write-Back Cache.
2023-08-16 19:25:03 +02:00
Admiral H. Curtiss
23ae8c439c
Merge pull request #12112 from JosJuice/hires-texture-encoding
...
VideoCommon: Fix std::filesystem::path encoding conversion
2023-08-16 18:39:18 +02:00
JosJuice
86910f406e
VideoCommon: Fix std::filesystem::path encoding conversion
...
In std::string, you can store strings using any encoding, but in Dolphin
we have decided to use UTF-8. The problem is that if you convert between
std::string and std::filesystem::path using the built-in methods, the
standard library will make up its own assumption of what encoding you're
using in the std::string. On most OSes this is UTF-8, but on Windows
it's whatever the user's code page is.
What I believe is the C++ standard authors' intended solution to this is
to use std::u8string instead of std::string, but that's a big hassle to
move over to, because there's no convenient way to convert between
std::string and std::u8string. Instead, in Dolphin, we have added helper
functions that convert between std::string and std::filesystem::path in
the manner we want. You *always* have to use these when converting
between std::string and std::filesystem::path, otherwise we get these
kinds of encoding problems that we've been having with custom textures.
Fixes https://bugs.dolphin-emu.org/issues/13328 .
2023-08-16 09:56:56 +02:00
JosJuice
177ac0cd44
Merge pull request #12111 from OatmealDome/old-amd-bug
...
Remove `BUG_BROKEN_FRAGMENT_SHADER_INDEX_DECORATION`
2023-08-16 09:20:49 +02:00
Pokechu22
10c5da6f62
Merge pull request #12107 from MikeIsAStar/retrieve-page-table-information-from-data-cache
...
Retrieve page table information from the data cache
2023-08-15 22:01:01 -07:00
takayhan-AMD
b969282b72
Remove out-dated hack of AMD driver issue WRT dual-source blending output index.
2023-08-15 23:58:29 -04:00
iwubcode
eeb73460ab
VideoCommon: asset load time is now stored as a chrono system_clock time, so that times can be fabricated in a future feature (without creating a file to do so)
2023-08-15 22:02:28 -05:00
Admiral H. Curtiss
a10d768c63
Merge pull request #12104 from iwubcode/descriptor_sample_size_constant_dx12
...
VideoBackends: update SRVDescriptorTable size in DX12 to use pixel sampler constant
2023-08-15 23:15:19 +02:00
Admiral H. Curtiss
a44606692a
Merge pull request #12096 from Dentomologist/nandpaths_resolve_android_warning
...
NandPaths: Resolve Android tautological comparison warning
2023-08-15 22:23:57 +02:00
Admiral H. Curtiss
2cbc1e6f3e
Merge pull request #12109 from JosJuice/android-adddevice-null
...
ControllerInterface/Android: Add null check to AddDevice
2023-08-15 22:22:45 +02:00
MikeIsAStar
0bb5c88a22
Retrieve page table information from the data cache
...
Thanks to @mkwcat for identifying the problematic code.
2023-08-15 12:44:55 -04:00
JosJuice
4b1b5881b0
Android: Move DirectoryInitialization toast to UI thread
...
You're not allowed to just show toasts on any thread you want.
2023-08-15 14:03:08 +02:00
JosJuice
1d77bddc3b
ControllerInterface/Android: Add null check to AddDevice
...
The Google Play Console is showing some users getting a crash here,
and indeed, InputDevice.getDevice can return null.
2023-08-15 13:31:18 +02:00
iwubcode
89e2fc1dd3
VideoBackends: update SRVDescriptorTable size in DX12 to use pixel sampler constant
2023-08-13 17:23:26 -05:00
Admiral H. Curtiss
5635a0bdef
DolphinQt/EnhancementsWidget: Use custom tooltip for Color Correction button.
2023-08-13 22:46:46 +02:00
Admiral H. Curtiss
2537f4db91
Merge pull request #12100 from AdmiralCurtiss/tooltip-pushbutton
...
DolphinQt: Add ToolTipPushButton.
2023-08-13 21:44:24 +02:00
JMC47
4549091f56
Merge pull request #12090 from mandar1jn/figures-split
...
Skylanders: expand and improve character list
2023-08-13 14:29:46 -04:00
Mandar1jn
31d6aa5117
Skylanders: expand and improve character list
...
The previous list had some issues. A lot of variant id's were set to 0x0000. Althought this works for some figures, on a technicallity implemented into the games, they are technically wrong and don't result in exactly the same experience as the real figures. For example, the previous small fry got a "series 1" text in the summon screen. The real small fry does not have this. I also added figure types so I can add seperate generation logic later.
The Kaos element only applies to 3 items. So, I decided to throw it under others since it's not listed as an element in the manual and you can easily search for Kaos
2023-08-13 19:55:10 +02:00
Admiral H. Curtiss
1c1d2b0873
Merge pull request #12098 from Dentomologist/gcadapter_fix_android_unused_constant_warning
...
Gcadapter: fix Android unused constant warning
2023-08-13 18:58:39 +02:00
Admiral H. Curtiss
5bf760fa0b
Merge pull request #12069 from riidefi/silent-sd-failure
...
Prevent SD data loss from silent resync failure
2023-08-13 18:57:11 +02:00
JosJuice
d50494b88d
Merge pull request #12060 from Sintendo/arm64-bool-logimm
...
JitArm64: Use LogicalImm in boolX
2023-08-13 18:51:05 +02:00
JMC47
0495a6af4e
Merge pull request #12066 from Pokechu22/main-window-right-click-menu
...
Disable right-click menu on main window
2023-08-13 12:49:56 -04:00
Dentomologist
720191d1f7
AbstractFramebuffer: Fix Android reorder-ctor warning
...
Move declaration of m_additional_color_attachments so its initialization
order matches that of the constructor.
2023-08-12 20:48:47 -07:00
Dentomologist
274b11e4e9
GCAdapter: Fix Android unused constant warning
...
CONTROLLER_OUTPUT_INIT_PAYLOAD_SIZE is only used by the libusb
implementation.
2023-08-12 20:20:42 -07:00
Dentomologist
77d33d61de
GCAdapter: Fix spelling of constants
2023-08-12 20:20:41 -07:00
Dentomologist
9ef79dd2f5
IOS: Remove unused member variable from SharedContentMap and UIDSys
...
Resolve unused-private-field warnings on Android.
2023-08-12 14:37:52 -07:00
Dentomologist
9ad0d9ca6a
NandPaths: Use initializer_list instead of unordered_set
2023-08-12 14:00:41 -07:00
Dentomologist
9955a06dbd
NandPaths: Resolve Android tautological comparison warning
...
Android interprets char as unsigned char, so comparing with 0 triggers a
tautological-unsigned-char-zero-compare warning.
Casting c to an unsigned char and removing the comparison with 0
resolves the warning while needing one less comparison on all platforms.
2023-08-12 14:00:41 -07:00
Admiral H. Curtiss
e6c7f4e14b
DolphinQt: Add ToolTipPushButton.
2023-08-12 21:33:43 +02:00
Admiral H. Curtiss
bc47a28653
Merge pull request #12093 from Hark64/exportWiiSaveErrorFix
...
Disable Wii Save Options When Emulation Is Running
2023-08-12 20:34:47 +02:00
Harkaran Mann
783ff26edd
DolphinQt: Turn of wii save options during emulation
2023-08-12 20:18:22 +02:00
Admiral H. Curtiss
24012cfc7f
DolphinQt: Adjust panel-specific colors and syntax highlighting for dark theme.
2023-08-12 19:43:12 +02:00
Admiral H. Curtiss
c2e29153e9
DolphinQt: Set the theme before constructing the MainWindow, some panels that explicitly request palette colors get the wrong colors otherwise.
2023-08-12 16:54:54 +02:00
Admiral H. Curtiss
d725aaa5bc
DolphinQt: Set the application palette to a matching one when the Windows dark theme is in use.
2023-08-12 16:54:54 +02:00
Admiral H. Curtiss
250d5f55de
DolphinQt: Switch dark/light theme when Windows theme changes.
2023-08-12 16:54:54 +02:00
Admiral H. Curtiss
e2fb8fab2f
DolphinQt: Set window decorations for all top-level QWidgets.
2023-08-12 16:54:54 +02:00
Admiral H. Curtiss
e8d23af0f2
DolphinQt: Add function to set a QWidget's window decorations to dark ones on Windows.
2023-08-12 16:54:53 +02:00
Admiral H. Curtiss
adbe56ce15
DolphinQt: Auto-load embedded dark theme on Windows if the user uses a system-wide dark theme.
2023-08-12 16:54:53 +02:00
Admiral H. Curtiss
ea30651cd7
DolphinQt: Embed custom dark theme for Windows.
2023-08-12 16:54:53 +02:00
Admiral H. Curtiss
5d33f2abd1
DolphinQt: On Windows, detect whether the system is using a dark theme.
...
Co-authored-by: FearlessTobi <thm.frey@gmail.com>
2023-08-12 16:54:53 +02:00
Admiral H. Curtiss
f2300d89cc
CMake: Turn on rcc file embedding.
2023-08-12 16:54:53 +02:00
Shawn Hoffman
a202d84570
msbuild: auto generate and embed qt rcc files
2023-08-12 16:54:53 +02:00
Pokechu22
1f8f3840ac
Disable right-click menu on main window
...
Before, right-clicking on the toolbar would allow toggling all dock widgets, including the debugger ones even when they are disabled. (See https://doc.qt.io/qt-5/qmainwindow.html#createPopupMenu for this behavior, and https://bugs.dolphin-emu.org/issues/13306 for an example of where it caused issues.)
2023-08-11 10:45:31 -07:00
iwubcode
246b7c5bdb
VideoCommon: fix regression with texture load order where the custom texture code was always updating the asset map for each texture with each entry, making it so the last value actually would be loaded instead of the first
2023-08-11 00:36:41 -05:00
JMC47
5512d19d4b
Merge pull request #12061 from iwubcode/cubemap_backends_only
...
VideoBackends: add support for cube maps for OGL, Vulkan, and D3D
2023-08-10 18:36:48 -04:00
JMC47
032c77b462
Merge pull request #12064 from noahpistilli/wc24-standby
...
Remove force disable WC24 Standby
2023-08-10 16:07:47 -04:00
Admiral H. Curtiss
b0dc067717
Merge pull request #12087 from Dentomologist/dx12_use_correct_framebuffer_descriptor
...
D3D12: Only use framebuffer integer descriptor if allocated
2023-08-10 19:09:25 +02:00
JosJuice
1ebec40e4d
JitArm64: Prefer MOVI with 64-bit elements for zeroing
...
The Cortex-X2 and Cortex-X3 (and possibly others) recognize MOVI with
64-bit elements as a zeroing idiom, but not MOVI with other sizes.
2023-08-06 12:11:37 +02:00
Dentomologist
4ccac53e9f
X64EmitterTest: Check bytes instead of disassembly in JMP test
...
Check bytes directly to avoid ambiguity in the disassembly between short
and near jumps, which could hypothetically cause the test to pass when
it shouldn't.
2023-08-05 13:51:42 -07:00
Dentomologist
dcd5ba6587
x64EmitterTest: add J/J_CC/CALL unit tests
2023-08-05 13:51:42 -07:00
Dentomologist
83f307ec7e
D3D12: Only use framebuffer integer descriptor if allocated
...
Verify that DXFramebuffer's integer RTV descriptor's cpu_handle has been
allocated before using it, and if it hasn't use the non-integer RTV
descriptor instead. This fixes a Dolphin crash in Twilight Princess, and
possibly other games (Issue 13312).
As an optimization to save space in the descriptor heap, DXFramebuffer's
integer descriptor is only initialized if the given abstract texture
format has different integer and non-integer RTV formats. This
previously wasn't accounted for by GetIntRTVDescriptorArray, which could
cause DX12::Gfx::BindFramebuffer to call OMSetRenderTargets with an
invalid descriptor which would lead to a crash.
Triggering the bug was fortunately rare because integer formats are only
used when blending is disabled and logic ops are enabled. Furthermore,
the standard integer abstract format is RGBA8 which has different
integer and non-integer RTV formats, causing the integer descriptor to
be initialized and avoiding the bug.
The crash started appearing in a2702c6
because it changed the
swapchain's abstract texture format from RGBA8 to RGB10_A2. Unlike
RGBA8, RGB10_A2 has the same integer and non-integer RTV formats and so
the bug can be triggered if the other requirements are met.
2023-08-04 13:17:33 -07:00
JosJuice
02b0e287cb
InputConfig: Update IsControllerControlledByGamepadDevice for Android input overhaul
...
This only matters for analytics, but still.
2023-08-01 19:35:55 +02:00
JosJuice
262a3be08a
JitArm64: Store PC on debug exit
...
Should fix https://bugs.dolphin-emu.org/issues/13178 .
Jit64 doesn't need to do this because it stores PC directly into
ppcState instead of first storing it in a register.
2023-07-31 16:50:49 +02:00
JosJuice
a912a2c3f5
Merge pull request #12047 from AdmiralCurtiss/nand-stats-user
...
Add file size stats to NAND Check.
2023-07-30 21:51:07 +02:00
JosJuice
d2c5d79614
JitArm64: Use farcode in WriteLinkBlock
...
Now block link nearcode is back to a length of three instructions.
Unfortunately, the code I'm adding to Jit.cpp ends up being a bit messy
because we need to handle the case of already being in farcode...
2023-07-30 15:00:07 +02:00
JosJuice
1813f0fdb5
Jit: Remove checkedEntry
...
It's now always identical to normalEntry.
2023-07-30 14:28:02 +02:00
JosJuice
f78ba9ac55
JitArm64: Never check downcount on block entry
...
Jumping between linked blocks currently works as follows: First, at the
end of the first block, we check if the downcount is greater than zero.
If it is, we jump to the `normalEntry` of the block. So far so good. But
if the downcount wasn't greater than zero, we jump to the `checkedEntry`
of the block, which checks the downcount *again* and then jumps to
`do_timing` if it's less than zero (which seems like an off by one error
- Jit64 doesn't do anything like this). This second check is rather
redundant. Let's jump to `do_timing` where we previously jumped to
`checkedEntry`.
Jit64 doesn't check the downcount on block entry. See 5236dc3
.
2023-07-30 14:20:44 +02:00
Admiral H. Curtiss
9f817911fd
HLE_OS: Manually handle printfs from emulated software to prevent emulated software from crashing Dolphin with an invalid printf formatting string.
2023-07-29 20:06:09 +02:00
JosJuice
30c4ac34b0
Merge pull request #12073 from AdmiralCurtiss/wiimote-win32error
...
WiimoteReal/IOWin: Use correct error type in the default case.
2023-07-29 18:54:10 +02:00
Admiral H. Curtiss
7f29f0398c
MMU: Add a HostGetU16String() function for wide strings used by emulated software.
2023-07-29 15:11:00 +02:00
iwubcode
dca7c67105
VideoCommon: update NetplayChatUI's chat message input to use a hidden label. This avoids an error thrown by imgui
2023-07-29 00:27:07 -05:00
JMC47
a2a6473962
Merge pull request #12065 from iwubcode/imgui_update
...
Externals / VideoCommon: update imgui to 1.89.7 (and implot to 0.15)
2023-07-28 17:22:20 -04:00
JosJuice
ed8911b204
Merge pull request #12019 from Dentomologist/gekkodisassembler_remove_unused_member_and_parameter
...
GekkoDisassembler: Remove unused member and parameters
2023-07-28 20:02:19 +02:00
JosJuice
b5b8282ca9
Android: Fix SettingsActivity.onActivityResult
...
`or` is the bitwise or operator.
Fixes file pickers in the settings not saving your choice.
2023-07-28 18:45:07 +02:00
Franz-Josef Haider
8bfcd2deb7
JitArm64/Jit64: Load the memory register without jumps and only when necessary.
2023-07-28 14:24:53 +03:00
Admiral H. Curtiss
fb9274c359
WiimoteReal/IOWin: Use correct error type in the default case.
2023-07-28 08:10:54 +02:00
Admiral H. Curtiss
cd923718c3
CommonFuncs: Add GetWin32ErrorString().
2023-07-28 08:10:01 +02:00
Dentomologist
3c6ea825c2
GekkoDisassembler: Remove unused parameter dmode from fdabc function
...
With the removal of m_flags, dmode is no longer used in fdabc.
2023-07-27 10:47:46 -07:00
Dentomologist
33dc2a9e6a
GekkoDisassembler: Remove unused parameter dmode from ldst function
...
With the removal of m_flags, dmode is no longer used in ldst.
2023-07-27 10:47:46 -07:00
Dentomologist
b3c5021fc4
GekkoDisassembler: Remove unused parameter dmode from rrn function
...
With the removal of m_flags, dmode is no longer used in rrn.
2023-07-27 10:47:46 -07:00
Dentomologist
a177c8bcb1
GekkoDisassembler: Remove unused parameter dmode from dab function
...
With the removal of m_flags, dmode is no longer used in dab.
2023-07-27 10:47:45 -07:00
Dentomologist
a732647e5a
GekkoDisassembler: Remove unused parameter dmode from nooper function
...
With the removal of m_flags, dmode is no longer used in nooper.
2023-07-27 10:47:45 -07:00
Dentomologist
317bb629b9
GekkoDisassembler: Remove unread variable m_flags
...
Writes to m_flags are pointless as it's never read.
2023-07-27 10:47:41 -07:00
iwubcode
350e51951b
VideoCommon: update imgui to 1.89.7 (and implot to 0.15); fix issues with upgrade; keep the demo code in case someone wants to reference it but don't compile it by enabling 'IMGUI_DISABLE_DEMO_WINDOWS' in config
2023-07-27 11:47:34 -05:00
JosJuice
17fa9dfc4e
Merge pull request #12046 from AdmiralCurtiss/nand-stats-unit-test
...
UnitTests: Enable cluster check in FileSystemTest.GetDirectoryStats.
2023-07-27 18:44:34 +02:00
riidefi
ec5d2a4f41
[Core] Prevent SD data loss from silent resync failure
2023-07-26 13:58:01 -06:00
Martino Fontana
1e5e319783
Qt/GameConfigWidget: Add Manual Texture Sampling
2023-07-25 00:45:13 +02:00
Martino Fontana
41f81aca69
Qt/GameConfigWidget: Rename `m_enable_fast_disc` to `m_emulate_disc_speed`
2023-07-25 00:45:10 +02:00
Martino Fontana
0892998af1
Qt/GameConfigWidget: Add `reverse` argument for `{Save,Load}CheckBox`
...
In order to not hard code `if (key == "FastDiscSpeed")`
2023-07-24 20:48:32 +02:00
Admiral H. Curtiss
0a2afa48b7
Merge pull request #12045 from tupfold/master
...
[Minor Bugfix] Extremely rare HostID collision bugfix
2023-07-24 03:55:45 +02:00
Admiral H. Curtiss
553824e5aa
Merge pull request #11853 from noahpistilli/update-curl
...
Externals: Update libcurl
2023-07-24 02:27:36 +02:00
Admiral H. Curtiss
2b80605e7e
Merge pull request #12067 from Pokechu22/debugging-ui-text-show-enable
...
Rename "Show Debugging UI" to "Enable Debugging UI"
2023-07-24 01:15:04 +02:00
Admiral H. Curtiss
c468ca2107
Merge pull request #12057 from iwubcode/config_core_timing_refresh_only
...
Core: save core timing parameters into variables updated during refresh
2023-07-24 01:14:18 +02:00
Pokechu22
7e38ff496c
Rename "Show Debugging UI" to "Enable Debugging UI"
...
This will hopefully reduce confusion on e.g. https://bugs.dolphin-emu.org/issues/13306 .
2023-07-23 15:17:04 -07:00
iwubcode
e54b7ac356
Core: save core timing parameters into variables updated during refresh
2023-07-23 14:03:21 -05:00
JosJuice
eb79bf37e2
Merge pull request #12052 from mitaclaw/profiling-is-something
...
Announce RSCRATCH clobbering in Jit64::Cleanup() when profiling is enabled
2023-07-23 20:12:43 +02:00
Admiral H. Curtiss
a76cc146e1
Merge pull request #12055 from iwubcode/skip_dump_async
...
VideoCommon: skip the texture dump if a custom texture is available, regardless if it is loaded or not
2023-07-23 19:53:25 +02:00
Admiral H. Curtiss
c1a4b3f350
Merge pull request #12051 from mandar1jn/J-documentation-improvements
...
Skylanders: Update J command documentation
2023-07-23 19:23:29 +02:00
Admiral H. Curtiss
dd3caa48b2
Merge pull request #12063 from SuperSamus/audio-name
...
cubeb: Change name to "Dolphin Emulator"
2023-07-23 19:15:24 +02:00
Bram Speeckaert
a486168448
JitArm64: Use LogicalImm in boolX
...
ARM64 has a special logical immediate encoding scheme, that can be used
with AND, ORR, and EOR. By taking advantage of this, we no longer need
to materialize the immediate value in a register, saving instructions
and/or reducing register pressure.
- orx
Before:
mov w23, #0x1
orr w23, w25, w23
After:
orr w23, w25, #0x1
- andx
Before:
mov w26, #-0x80000000
and w27, w27, w26
sxtw x24, w27
After:
and w27, w27, #0x80000000
sxtw x26, w27
- eqvx
Before:
mov w23, #0x4
eon w26, w23, w22
After:
eor w26, w22, #0xfffffffb
- xorx
Before:
mov w23, #0x1e
eor w23, w27, w23
After:
eor w23, w27, #0x1e
- norx
Before:
mov w25, #-0x2001
orr w23, w23, w25
mvn w23, w23
After:
orr w23, w23, #0xffffdfff
mvn w23, w23
2023-07-23 18:40:53 +02:00
Sketch
8c2a1c191e
Remove force disable WC24 Standby
2023-07-22 22:24:09 -04:00
Admiral H. Curtiss
e3ef3cb752
Merge pull request #12062 from iwubcode/custom_textures_debug
...
VideoCommon: add startup message to know if custom textures are installed
2023-07-23 03:45:22 +02:00
Martino Fontana
b5be399fd4
cubeb: Change name to "Dolphin Emulator"
...
To avoid conflicts with KDE's file manager.
2023-07-22 23:12:34 +02:00
JosJuice
3d9bc85912
Merge pull request #12058 from noahpistilli/android-wiilink
...
Add Enable WiiLink checkbox to Android GUI
2023-07-22 08:14:18 +02:00
Sketch
6f55e44365
Update libcurl to 8.1.2
2023-07-21 21:59:55 -04:00
Admiral H. Curtiss
fb2b3753b5
Merge pull request #12015 from nyanpasu64/gc-adapter-sleep-detach
...
Fix GC Adapter breaking and burning a full CPU core after sleep-wake on Linux
2023-07-22 03:38:45 +02:00
iwubcode
fd74244339
VideoCommon: add custom texture message to provide a dirty means of debugging whether custom textures are installed correctly
2023-07-21 20:13:27 -05:00
iwubcode
e892b7f1ac
VideoBackends: add support for cube maps for OGL, Vulkan, and D3D
2023-07-21 19:09:40 -05:00
SketchMaster2001
2569d10b3d
Add Enable WiiLink checkbox to Android GUI
2023-07-21 17:46:37 -04:00
LillyJadeKatrin
7a7e0ab2f5
Fixed Leaderboard Scored message format
...
Refactored the message displayed when a leaderboard is submitted to so that it properly generates and uses a FormattedValue.
2023-07-21 01:45:50 -04:00
Mandar1jn
eba5291ec7
Skylanders: Update J command documentation
...
I initially thought the 0x01 side was both sides (equavalent to just C. However, this turned out to be something I forgot I implemented in my personal interface. 0x01 does not seem to change any colors.
Recently discovered how exactly the last 2 bytes of the J command for timing data
2023-07-20 23:58:33 +02:00
iwubcode
f7e78742cf
VideoCommon: skip the texture dump if the texture is using a custom texture, regardless of whether or not it is loaded yet
2023-07-19 23:44:41 -05:00
mitaclaw
70b3db93e0
Announce RSCRATCH clobbering in Jit64 when profiling is enabled
2023-07-19 14:15:42 -07:00
iwubcode
79f202ea5c
VideoCommon: fix some compiler warnings for CustomAsset. FreeBSD compiler complained about a defaulted move constructor due to the mutex being implicitly deleted. Additionally, the const owning library deleted the copy constructor.
2023-07-16 19:45:55 -05:00
Admiral H. Curtiss
9ebfcebdde
Merge pull request #12049 from iwubcode/initialize_asset_load_info
...
VideoCommon: initialize load info variables in CustomAssetLibrary
2023-07-16 23:32:13 +02:00
Admiral H. Curtiss
2814e4e283
Merge pull request #12033 from mbc07/ColorCorrectionGUI_fixes
...
Qt: Color Correction window fixes
2023-07-16 23:31:59 +02:00
Mateus B. Cassiano
d7e79683cc
Qt: Color Correction window fixes
2023-07-16 16:48:08 -04:00
iwubcode
5740be15f9
VideoCommon: initialize load info variables
2023-07-16 12:56:03 -05:00
Admiral H. Curtiss
cd5aebe5ac
Qt: Add file size stats to NAND Check.
2023-07-14 05:24:29 +02:00
Admiral H. Curtiss
efae5827f2
IOS/FS: Implement GetExtendedDirectoryStats().
...
Behaves like GetDirectoryStats() but doesn't clamp to the Wii limits, so we can tell the user exactly how overfull their NAND is.
2023-07-14 04:48:23 +02:00
Admiral H. Curtiss
0d9e027a0b
IOS/FS: Move NAND size related constants to FileSystem.h.
...
That way they're available for calculating NAND stats to display to the user. This also adds a few more constants.
2023-07-14 04:47:47 +02:00
Admiral H. Curtiss
17f2072e1c
UnitTests: Enable cluster check in FileSystemTest.GetDirectoryStats.
2023-07-14 04:20:57 +02:00
Upfoldian
c4978edaf6
Fixed a bug where in the extremely unlikely change that HostIDs collide, a new HostID is generated.
2023-07-13 21:33:36 +10:00
jmlee337
550b9782e1
Do not try portmapping when using traversal server
...
using portmapping with hosting while using traversal server (which is possible by checking the option while under "direct connect" and flipping back to traversal server) causes dolphin to request a mapping to external port 0.
In UPnP a mapping to external port 0 is actually the wildcard, which means that connection requests on all
external ports (that are not otherwise mapped) will be forwarded to the client.
Additionally it seems like using port mapping with traversal server is probably not expected behavior, as the option checkbox disappears when traversal server is used.
2023-07-13 01:15:12 -07:00
Sepalani
cbb76c1d4f
Common/Network: Use StrErrorWrapper
2023-07-12 20:52:35 +04:00
Sepalani
92be54d57a
Common/CommonFuncs: Add StrErrorWrapper function
2023-07-12 20:52:35 +04:00
OatmealDome
423c7c58cd
Merge pull request #12042 from JosJuice/logic-op-no-win7
...
D3D: Remove Windows 7 mention in logic ops warning
2023-07-11 20:23:16 -04:00
JosJuice
5acebc71c4
D3D: Remove Windows 7 mention in logic ops warning
...
Dolphin no longer supports Windows 7, so the fact that there are (were?)
more people who use Windows 7 than who use a GPU that doesn't support
the required feature is no longer relevant.
2023-07-11 22:41:51 +02:00
Joshua de Reeper
93c8db66d6
Skylanders: More List Fixes
2023-07-10 09:59:00 +01:00
Admiral H. Curtiss
fe8a9ac707
Merge pull request #12024 from iwubcode/material_asset
...
VideoCommon: add material asset
2023-07-09 21:49:16 +02:00
iwubcode
77511e8e7c
VideoCommon: add material asset. A material is similar to other graphics engines where it provides data to be used in conjunction with a shader asset to generate a runtime AbstractShader
2023-07-09 12:21:34 -05:00
JosJuice
bd90f6be78
Merge pull request #12017 from Dentomologist/remove_unused_flowlayout
...
QtUtils: Remove unused FlowLayout
2023-07-09 16:06:35 +02:00
JosJuice
90b1f5c60a
Merge pull request #12020 from Dentomologist/gekkodisassembler_remove_unread_variables
...
GekkoDisassembler: Remove unread variables
2023-07-09 16:00:26 +02:00
Admiral H. Curtiss
80c44ea597
Merge pull request #12034 from MaverickAmon02/controller-update-race
...
Fix unsafe netplay code in SI_DeviceGCController
2023-07-09 14:13:44 +02:00
Admiral H. Curtiss
7bb04ff1dc
Merge pull request #12022 from iwubcode/texture_create_gmod_impl
...
VideoCommon: call into graphics mods create texture callback
2023-07-09 04:20:43 +02:00
Amon Neander
d122492db7
Fix unsafe netplay code in SI_DeviceGCController
...
By misusing Config, this netplay-related code opened up a race condition between Config::OnConfigChanged() and SerialInterface::SerialInterfaceManager::UpdateDevices() that could cause iterator invalidation.
2023-07-06 11:34:08 -04:00
nyanpasu64
c8df26554b
Fix GC adapter not being detected when you enable controller in settings
...
GCAdapter::UseAdapter() reads s_is_adapter_wanted, which gets
initialized by config_guard.~ConfigChangeCallbackGuard(). So we must
wait until after destroying the config guard to know whether we have any
controllers set to GC Adapter.
2023-07-05 20:38:22 -07:00
nyanpasu64
5d0f1bd10b
Switch libusb_config_descriptor to RAII type
2023-07-05 20:38:22 -07:00
nyanpasu64
c893ccca58
Workaround GC adapter detection breaking when reset fails
2023-07-05 20:38:22 -07:00
nyanpasu64
559a16da49
Reset GC adapter upon IO error after sleep-wake
...
Fixes GC adapter breaking on sleep-wake on Linux and burning a full CPU
core. This is cleaner than alternative approaches.
2023-07-05 20:38:22 -07:00
nyanpasu64
afb5eff426
Don't burn a CPU core and spam logs when GC Adapter fails
2023-07-05 20:38:22 -07:00
nyanpasu64
54850e936c
Fix memory leak in libusb code
2023-07-05 20:38:22 -07:00
Joshua de Reeper
79a4b91d68
Skylander Portal: Simple List Fixes
2023-07-04 16:48:51 +01:00
Admiral H. Curtiss
0366122306
Merge pull request #12009 from iwubcode/shader_asset
...
VideoCommon: add a pixel shader asset
2023-07-03 03:24:11 +02:00
Admiral H. Curtiss
da2784a391
Merge pull request #11878 from LillyJadeKatrin/retroachievements-achievements-tab
...
RetroAchievements - Achievement Progress Tab
2023-07-03 03:23:18 +02:00
iwubcode
a2ad3ca6f7
VideoCommon: don't do pointer copies during graphics mod callback iteration
2023-07-02 13:58:07 -05:00
iwubcode
0539bb4a3e
VideoCommon: call into graphics mods create texture callback, providing additional asset dependencies that trigger the texture to be reloaded
2023-07-02 13:45:09 -05:00
Admiral H. Curtiss
6d7bf60071
Merge pull request #11991 from iwubcode/tcache_multiple_texture_dependencies
...
VideoCommon: allow multiple texture assets to associate with a texture cache entry
2023-07-02 20:14:32 +02:00
iwubcode
a93e6e7397
VideoCommon: add support for allowing a TextureCache entry to be associated with multiple assets
2023-07-02 12:50:07 -05:00
Dentomologist
c8e276c6f5
GekkoDisassembler: Remove unread variable m_displacement
2023-07-01 20:09:10 -07:00
Dentomologist
98c9049184
GekkoDisassembler: Remove unread variable m_sreg
2023-07-01 20:09:09 -07:00
LillyJadeKatrin
ccc9d0e5ea
Synchronized Achievement Window
...
Expanded the use of the lock mutex already used for loading the player's existing unlock status to guard against races involving the Achievements dialog window reading from data AchievementManager might be in the process of updating. The lock has been exposed publicly and the AchievementsWindow uses it in its UpdateData method, and anywhere else that might modify data used to render that window has also been wrapped with it.
2023-07-01 22:26:30 -04:00
LillyJadeKatrin
fbaeaf305b
Add UpdateCallback to AchievementManager
...
AchievementManager now has a SetUpdateCallback method for providing a single universal callback for anytime something important changes in the achievement state, such as logging in/out, game load/close, or events such as achievement unlocks. AchievementsWindow sets this callback in its own init to its UpdateData method so that the AchievementsWindow gets updated when one of these changes takes place.
2023-07-01 22:26:29 -04:00
LillyJadeKatrin
582042de1f
Added AchievementProgressWidget to AchievementsWindow
...
This widget is a tab in the AchievementsWindow that displays the player's current achievement progress: which achievements are locked or unlocked, and the progress of achievements that have progress metrics.
2023-07-01 22:26:29 -04:00
LillyJadeKatrin
ebe77f149f
Added AchievementHeaderWidget to AchievementsWindow
...
This widget displays a header on the AchievementsWindow dialog above the tabs that shows the currently logged in user (if there is one) and the game they are playing (if there is one).
2023-07-01 22:26:29 -04:00
LillyJadeKatrin
f700faf6ab
Expose Achievements Data for Display
...
Added some small methods to AchievementManager to expose useful data for displaying in an achievement UI. Also moved a couple things from private to public for the same purpose.
2023-07-01 22:26:29 -04:00
Dentomologist
6fe3cfe245
QtUtils: Remove unused FlowLayout
...
FlowLayout hasn't been used since
b65faa0549
.
2023-07-01 11:33:54 -07:00
Admiral H. Curtiss
eedc1144c1
Merge pull request #11923 from iwubcode/multi-texture-compute-support
...
VideoBackends: support multiple compute images for some backends
2023-07-01 17:47:55 +02:00
JosJuice
179d823852
Merge pull request #11992 from Dentomologist/remove_mtype_and_associated_enum
...
GekkoDisassembler: Remove unread variable and associated enum
2023-07-01 09:00:42 +02:00
Admiral H. Curtiss
ed4403537f
Merge pull request #11916 from JosJuice/ppcanalyst-reorder-loop
...
PPCAnalyst: Reduce number of iterations in ReorderInstructionsCore
2023-07-01 01:06:53 +02:00
Admiral H. Curtiss
82c986816f
Merge pull request #11978 from AdmiralCurtiss/wiimote-S_FALSE
...
WiimoteReal/IOWin: Don't try to print error message for non-errors.
2023-07-01 00:58:42 +02:00
Admiral H. Curtiss
e71f42f819
Merge pull request #11997 from Dentomologist/dspemulator_remove_pauseandlock_parameter
...
DSPEmulator: Remove unused PauseAndLock parameter
2023-07-01 00:56:45 +02:00
Admiral H. Curtiss
94f34260a6
Merge pull request #12001 from Filoppi/patch-21
...
Qt: Fix some Post Process Configuration Widget issues #3-4
2023-06-30 19:11:10 +02:00
Admiral H. Curtiss
fa81006b51
Merge pull request #11955 from TellowKrinkle/CMakeDependencies
...
CMake: Allow ignoring system packages
2023-06-30 19:06:04 +02:00
Admiral H. Curtiss
e4d7ba5554
Merge pull request #12007 from AdmiralCurtiss/cmake-scmrev-at-build-time
...
CMake: Generate scmrev.h at build time instead of configure time.
2023-06-30 18:59:33 +02:00
iwubcode
6ea49c6746
VideoCommon: add a pixel shader asset
2023-06-30 01:32:53 -05:00
JMC47
ff324ef660
Merge pull request #12010 from TellowKrinkle/AlignUpOpt
...
Common: Better AlignUp implementation
2023-06-29 20:30:13 -04:00
Filoppi
bfb90b7eec
Video: increase the max HDR brightness multiplier to a more appropriate value (400 nits can be too dark in a bright room)
2023-06-29 14:24:28 +03:00
Filippo Tarpini
28fafbeef2
Qt: Fix some Post Process Configuration Widget issues n3
...
1 ) When first opened, the (user selected) post process shader config widget would print the wrong values on the text label next to int range sliders. For example if the range was from 1 to 6, and the value loaded from the config was 1, the label would print 0 when first opened, to then start showing the correct value once the slider was first moved.
This mirrors the behaviour of the float slider code below:
```auto* const value_box = new QLineEdit(QString::asprintf("%f", m_config_option->m_float_values[i]));```
2 ) The defautl int slider value would also be set wrong on first load, as it was being divided by the slider max instead of the slider step amount (again, just like for the float implementation). This is a mistake I had made with my previous submission.
2023-06-29 14:13:38 +03:00
TellowKrinkle
d844317a6d
Common: Better AlignUp implementation
2023-06-29 02:35:44 -05:00
Admiral H. Curtiss
4774fe3445
VKGfx: Add parentheses around ambiguous if statements.
2023-06-29 03:59:18 +02:00
Admiral H. Curtiss
2a6f4d879c
CMake: Generate scmrev.h at build time instead of configure time.
2023-06-29 03:23:31 +02:00
iwubcode
3627398cf5
VideoBackends: support multiple compute images for some backends (D3D, OGL, Vulkan)
2023-06-28 17:15:31 -05:00
Admiral H. Curtiss
61c45e8d68
Merge pull request #12002 from JosJuice/i18n-empty-string
...
DolphinQt: Don't translate empty strings
2023-06-28 18:56:35 +02:00
Charles Lombardo
e185dbf857
Merge pull request #11989 from JosJuice/android-title-on-shutdown
...
Android: Handle game shutdown in onTitleChanged
2023-06-28 12:48:54 -04:00
JosJuice
3384e02098
DolphinQt: Don't translate empty strings
...
Trying to translate an empty string will return a long metadata string
for the loaded translation file rather than the expected empty string.
2023-06-28 18:43:52 +02:00
TellowKrinkle
fc4036af80
VideoBackends:Metal: Multi render target support
2023-06-28 00:11:37 -05:00
JosJuice
766b8605f8
Merge pull request #11994 from JosJuice/skylanders-i18n
...
DolphinQt: Add i18n comments for Skylanders strings
2023-06-27 22:40:14 +02:00
JosJuice
a7aee396f6
Merge pull request #11929 from t895/gradle-updates
...
Android: Gradle updates
2023-06-26 19:44:23 +02:00
Dentomologist
ee684b0798
DSPEmulator: Remove unused PauseAndLock parameter
2023-06-25 20:29:23 -07:00
Dentomologist
f151ae3c2a
EXI: Remove pointless PauseAndLock functions
...
The ExpansionInterfaceManager::PauseAndLock function does nothing but
call other functions that have no effect.
ExpansionInterfaceManager::PauseAndLock calls CEXIChannel::PauseAndLock,
which in turn calls IEXIDevice::PauseAndLock. None of the classes
deriving from IEXIDevice override PauseAndLock, and the implementation
in IEXIDevice does nothing.
2023-06-25 20:08:08 -07:00
Admiral H. Curtiss
3a8e7de214
Merge pull request #11903 from noahpistilli/wiilink
...
IOS/KD: Add WiiLink as WC24 service provider by default
2023-06-26 02:27:47 +02:00
Sketch
f9f8e94e30
Add default support for WiiLink + configuration
2023-06-25 14:57:15 -04:00
JosJuice
ac53ab184c
Merge pull request #11952 from K0bin/no-per-game-driver
...
Android: Remove GPU driver from per-game settings
2023-06-25 19:00:01 +02:00
JosJuice
09f8f29ae0
DolphinQt: Add i18n comments for Skylanders strings
...
Also changed the spelling of "Superchargers" to "SuperChargers".
2023-06-25 15:38:30 +02:00
Dentomologist
2472269d06
GekkoDisassembler: Remove unused enum InstructionType
2023-06-24 13:45:26 -07:00
Dentomologist
2cf48bc32c
GekkoDisassembler: Remove unread variable m_type
...
Writes to m_type are pointless because it's never read.
2023-06-24 13:45:26 -07:00
Pokechu22
50c929928c
Merge pull request #11920 from Minty-Meeo/kill-ascii-to-hex
...
Kill AsciiToHex
2023-06-23 18:20:36 -07:00
JosJuice
b5e197e2dc
Android: Handle game shutdown in onTitleChanged
2023-06-23 20:40:04 +02:00
Robin Kertels
38a5774a85
Android: Remove GPU driver from per-game settings
2023-06-23 20:13:14 +02:00
Admiral H. Curtiss
c04536c5d0
Merge pull request #11982 from iwubcode/graphics_mod_create_texture_callback
...
VideoCommon: add graphics mod callback interface for when a texture is created
2023-06-23 18:10:59 +02:00
Admiral H. Curtiss
02909bd1a5
Merge pull request #11850 from Filoppi/post_process_fixes
...
Video: implement color correction to match the Wii/GC NTSC/PAL color spaces (and gamma)
2023-06-23 18:08:23 +02:00
Admiral H. Curtiss
5bf3d55d38
Merge pull request #11981 from iwubcode/move_cached_asset_to_common
...
VideoCommon: move cached texture asset to 'CustomAsset' common code
2023-06-23 17:59:24 +02:00
Admiral H. Curtiss
b5ba51c60a
Core: Remove host thread assert in PauseAndLock().
...
Fixing all the places it's used turned out to be a more complicated task than anticipated. So let's remove this for now so we don't confuse users with cryptic error messages...
2023-06-23 01:18:56 +02:00
get
445bf8d2c6
Kill AsciiToHex
...
Now superseded by Common::FromChars
2023-06-22 00:06:50 -05:00
JosJuice
1f130bf8a3
Android: Declare host thread when generating analytics ID
...
Another instance of the host thread check failing.
2023-06-21 18:16:46 +02:00
Sketch
bc0e8158b3
IOS/KD/Time: Take into account DST for AdjustedUTC
2023-06-20 22:49:33 -04:00
iwubcode
1d767c3a5b
VideoCommon: add graphics mod callback interface for when a texture is created
2023-06-20 19:26:53 -05:00
iwubcode
2dc24a9148
VideoCommon: move cached texture asset to 'CustomAsset' common code
2023-06-20 18:59:55 -05:00
Admiral H. Curtiss
5ad2d86cc7
Merge pull request #11979 from nicovank/master
...
Minor fix: Rename Symbol constructor parameter to prevent shadowing
2023-06-21 00:54:30 +02:00
Charles Lombardo
deb37f0846
Merge pull request #11964 from JosJuice/android-hide-infinity
...
Android: Hide Infinity Base in MenuFragment when not relevant
2023-06-20 17:11:18 -04:00
Nicolas van Kempen
4ef2f2c710
Rename Symbol constructor parameter to prevent shadowing
2023-06-20 13:38:31 -04:00
Admiral H. Curtiss
00bf5f55de
WiimoteReal/IOWin: Don't try to print error message for non-errors.
2023-06-20 01:54:59 +02:00
JosJuice
27db8d4123
Merge pull request #11935 from nitanmarcel/patch-1
...
Use getCacheDir if getExternalCacheDir returns null.
2023-06-19 20:47:27 +02:00
JosJuice
cff3e22f84
Merge pull request #11926 from JosJuice/android-host-check
...
Android: Re-add host thread check
2023-06-19 20:37:59 +02:00
Admiral H. Curtiss
5d7b5822c9
Merge pull request #11972 from Minty-Meeo/string-improvements-part-1c
...
Replace std::ostringstream usage with fmt::format
2023-06-19 02:18:30 +02:00
get
ffabb6c57b
Replace std::ostringstream usage with fmt::format
2023-06-18 18:37:32 -05:00
Filoppi
daddf4cd9c
Qt: add color correction and HDR Qt settings widgets
2023-06-19 01:34:42 +03:00
Filoppi
a2702c6e27
Video: implement color correction to match the NTSC and PAL color spaces (and gamma) that GC and Wii targeted.
...
To further increase the accuracy of the post process phase, I've added (scRGB) HDR support, which is necessary
to fully display the PAL and NTSC-J color spaces, and also to improve the quality of post process texture samplings and
do them in linear space instead of gamma space (which is very important when playing at low resolutions).
For SDR, the quality is also slightly increased, at least if any post process runs, as the buffer is now
R10G10B10A2 (on Vulkan, DX11 and DX12) if supported; previously it was R8G8B8A8 but the alpha bits were wasted.
Gamma correction is arguably the most important thing as Dolphin on Windows outputted in "sRGB" (implicitly)
as that's what Windows expects by default, though sRGB gamma is very different from the gamma commonly used
by video standards dating to the pre HDR era (roughly gamma 2.35).
Additionally, the addition of HDR support (which is pretty straight forward and minimal), added support for
our own custom AutoHDR shaders, which would allow us to achieve decent looking HDR in Dolphin games without
having to use SpecialK or Windows 11 AutoHDR. Both of which don't necessarily play nice with older games
with strongly different and simpler lighting. HDR should also be supported in Linux.
Development of my own AutoHDR shader is almost complete and will come next.
This has been carefully tested and there should be no regression in any of the different features that Dolphin
offers, like multisampling, stereo rendering, other post processes, etc etc.
Fixes: https://bugs.dolphin-emu.org/issues/8941
Co-authored-by: EndlesslyFlowering <EndlesslyFlowering@protonmail.com>
Co-authored-by: Dogway <lin_ares@hotmail.com>
2023-06-19 01:34:42 +03:00
Admiral H. Curtiss
9e06b6964b
Merge pull request #11963 from iwubcode/d3d12_fix
...
VideoBackends: fix d3d12 error when validation layers enabled
2023-06-19 00:33:40 +02:00
Admiral H. Curtiss
8039d10994
Merge pull request #11966 from Dentomologist/convert_xemitter_prefetchlevel_to_enum_class
...
xEmitter: Convert PrefetchLevel to enum class
2023-06-18 15:17:02 +02:00
Admiral H. Curtiss
2d18c9e079
Merge pull request #11976 from JosJuice/emitter-nodiscard
...
Arm64Emitter/x64Emitter: Use nodiscard for FixupBranch
2023-06-18 15:16:42 +02:00
Filoppi
0584f8ae2a
Video: fix Vulkan RGBA10_2 format to the actual most common one (used as swapchain format)
2023-06-18 12:58:40 +03:00
JosJuice
39a8219767
Arm64Emitter/x64Emitter: Use nodiscard for FixupBranch
...
This should prevent future occurrences of the type of problem that was
fixed in b713042
.
2023-06-18 09:10:20 +02:00
get
80575c4489
DITConfiguration: Use File::ReadFileToString
2023-06-17 19:38:15 -05:00
Dentomologist
04fcf68176
xEmitter: Convert PrefetchLevel to enum class
2023-06-17 16:41:32 -07:00
Admiral H. Curtiss
b71304230c
Jit64: Fix trampolines after #11834 .
2023-06-18 01:31:44 +02:00
Admiral H. Curtiss
93d9e90798
Merge pull request #11962 from Minty-Meeo/to-underlying
...
EnumUtils: Add Common::ToUnderlying
2023-06-17 20:04:25 +02:00
Lioncash
696087cae0
Qt/NetworkWidget: Get rid of some trivial sign conversions
...
In all instances, these variables should be signed rather than unsigned.
2023-06-17 10:48:49 -04:00
get
7523a62105
Change unnamed enum in NativeVertexFormat.h to u32
2023-06-17 08:13:57 -05:00
Admiral H. Curtiss
79d5850e6a
Merge pull request #11960 from Minty-Meeo/dolphin-tool-code-review-4
...
DolphinTool: Use {fmt} library
2023-06-17 14:18:21 +02:00
get
07ad75f34f
EnumUtils: Add Common::ToUnderlying
...
Mirrors the C++23 <utility> function, std::to_underlying
2023-06-17 07:15:33 -05:00
JosJuice
f16381adc5
Android: Hide Infinity Base in MenuFragment when not relevant
2023-06-17 11:57:53 +02:00
iwubcode
ba74902bca
VideoBackends: fix d3d12 validation layer error introduced by multi-output texture breaking logic ops support
2023-06-17 01:48:59 -05:00
get
e67c196d2a
DolphinTool: Less string copies
2023-06-16 21:51:06 -05:00
get
410c4ffe75
DolphinTool: Use {fmt} library
2023-06-16 21:45:59 -05:00
Admiral H. Curtiss
5029924ba1
Merge pull request #11954 from Minty-Meeo/dolphin-tool-code-review-3
...
DolphinTool: Use EXIT_SUCCESS and EXIT_FAILURE
2023-06-17 04:44:09 +02:00
Admiral H. Curtiss
1aef85a985
Merge pull request #11918 from TellowKrinkle/DPIScale
...
Improved DPI change handling
2023-06-17 04:07:13 +02:00
Admiral H. Curtiss
089d433996
Merge pull request #11956 from JosJuice/jitarm64-12-bit-asm
...
JitArm64: Micro-optimizations in fres routine
2023-06-17 04:00:22 +02:00
get
969eeb4b52
DolphinTool: Use EXIT_SUCCESS and EXIT_FAILURE
2023-06-16 21:00:10 -05:00
get
25c020cbe2
DolphinTool: Ditch OOP design
2023-06-16 20:39:16 -05:00
Admiral H. Curtiss
98b5d72ef1
Merge pull request #11951 from Minty-Meeo/dolphin-tool-code-review-1
...
DolphinTool: Sensible changes
2023-06-17 03:03:26 +02:00
get
31e78c40a1
DolphinTool: Sensible changes
2023-06-16 18:28:03 -05:00
Admiral H. Curtiss
cbcf5bfac1
Merge pull request #11889 from Filoppi/patch-18
...
Fix video output having small black borders all the times
2023-06-16 17:59:51 +02:00
Admiral H. Curtiss
50301bf1d1
Merge pull request #11957 from lioncash/resource
...
UICommon/ResourcePack: Allow priority helpers to take arguments by const reference
2023-06-16 17:01:19 +02:00