Sepalani
faa1eb71ef
IP/Top: Add SO_LINGER optname
2020-09-20 11:40:25 +04:00
Jordan Woyak
8587ebba86
WiimoteReal: Only duplicate data reports when speaker data is enabled.
2020-09-19 20:04:27 -05:00
Jordan Woyak
2e753abcc9
Update state version.
2020-09-19 18:02:25 -05:00
Jordan Woyak
32ef8a46a1
Core/BTEmu: Change a member variable to a local variable.
2020-09-19 18:00:22 -05:00
Jordan Woyak
0ca73355a8
ControllerEmu: Improve and simplify UpdateCalibrationData.
2020-09-19 08:40:55 -05:00
Techjar
29460b946e
Qt/MappingWindow: Add support for built-in profiles
2020-09-18 06:32:42 -04:00
Shawn Hoffman
fc88809b50
add some file to pch
2020-09-16 23:59:16 -07:00
Shawn Hoffman
31cddb4389
require msvc 19.27.29111 and Windows SDK 10.0.19041
2020-09-16 23:38:05 -07:00
JMC47
6ada03fca2
Merge pull request #9075 from JosJuice/android-osd-left-margin
...
Android: Move OSD out of the way when menu is open
2020-09-16 16:42:04 -04:00
JMC47
097a4f4ecf
Merge pull request #9077 from JosJuice/android-settings-initialized
...
Android: Wait for initialization before launching EmulationActivity
2020-09-16 16:37:28 -04:00
JMC47
655308255e
Merge pull request #9073 from darkain/patch-1
...
Adding AmdPowerXpressRequestHighPerformance
2020-09-16 15:56:04 -04:00
JosJuice
7749e8c10c
Only automatically override SYSCONF settings when it has an effect
...
Any call to Config::SetCurrent will cause the relevant setting
to show up as overridden in the Android GUI, which can be confusing,
so let's not do it when the new value is the same as the original.
2020-09-16 20:34:14 +02:00
JosJuice
5ba0832158
Android: Add workaround for conversion progress in dark mode
2020-09-16 18:48:25 +02:00
JosJuice
f01ccfdb82
Android: Only allow conversion when appropriate
2020-09-16 18:48:25 +02:00
JosJuice
23ea47d4df
Android: Refactor GamePropertiesDialog.onCreateDialog
2020-09-16 18:48:25 +02:00
JosJuice
5d13f3675f
Android: Pass GameFile to GamePropertiesDialog::newInstance
2020-09-16 18:48:20 +02:00
JosJuice
8c999cf3b1
Android: Let the user select where to save disc images
2020-09-16 18:38:53 +02:00
JosJuice
3805b84906
Android: Add content provider support to File::Delete
2020-09-16 18:38:53 +02:00
JosJuice
6e1e6d2311
Android: Add content provider support to File::IOFile
...
Taking the hit now to prepare us for when Google Play will
force us to use scoped storage...
2020-09-16 18:38:53 +02:00
JosJuice
d9f3e382fe
Android: Add a progress dialog for disc image conversion
2020-09-16 18:38:52 +02:00
JosJuice
7d6debb907
Android: Add disc image conversion
2020-09-16 18:38:07 +02:00
JosJuice
ca46028cde
DiscIO: Use std::function for compression callback
2020-09-16 18:36:50 +02:00
JosJuice
161f99b864
Android: Move OSD out of the way when menu is open
...
https://bugs.dolphin-emu.org/issues/12256
2020-09-16 18:36:15 +02:00
JosJuice
6e6446be83
Android: Add Wii SYSCONF settings to GUI
...
Now that PR 8975 is merged, we can finally add this without hacks.
https://bugs.dolphin-emu.org/issues/11605
2020-09-16 12:49:55 +02:00
JosJuice
9c97654603
Config: Add SYSCONF to IsSettingSaveable
...
SYSCONF very much is saveable. Whether it's in IsSettingSaveable
or not hasn't mattered until now since the SYSCONF settings use
separate config loader code that doesn't check IsSettingSaveable,
but the next commit will require SYSCONF to be marked as saveable.
2020-09-16 12:15:50 +02:00
JosJuice
fb2e633e1e
Android: Don't assume SliderSetting minimum is 0
2020-09-16 11:59:38 +02:00
JosJuice
a7b9e6857b
Merge pull request #8975 from JosJuice/android-new-config
...
Android: Hook up the new config system
2020-09-16 09:49:16 +02:00
JMC47
e4e50691fb
Merge pull request #9086 from JosJuice/wiimote-init-order
...
Core: Run Wiimote::Initialize before HW::Init to avoid crash
2020-09-16 02:26:17 -04:00
JosJuice
744c0b13cf
Android: Display default path when no path is set
2020-09-15 19:10:57 +02:00
JosJuice
003696fd78
Android: Fix race condition when exiting emulation
...
The main activity loads settings essentially as soon as it
starts, in order to determine which tab to show. If the process
of stopping emulation has not finished at this point, a race
condition may be triggered where two IOS kernels are created
at once due to the emulation thread loading or saving the
SYSCONF while the GUI thread is loading the SYSCONF. To fix
this, we can wait for emulation to fully end before returning.
Because this race condition is hard to reproduce, I have not
been able to test that this actually fixes the race condition,
or even that the cause of the race condition is exactly what I
believe it is. But I am relatively confident.
2020-09-15 19:10:56 +02:00
JosJuice
9c19309a03
Android: Allow editing settings during emulation
2020-09-15 19:10:56 +02:00
JosJuice
736505f020
Android: Show overridden game settings in bold
2020-09-15 19:10:56 +02:00
JosJuice
e24d50e881
Android: Hook up game settings to the new config system
2020-09-15 19:10:56 +02:00
JosJuice
a538301891
Android: Hook up global settings to the new config system
2020-09-15 19:10:55 +02:00
JMC47
e0117a86ad
Merge pull request #8819 from JosJuice/panic-alert-deadlock-pause-on-focus-loss
...
DolphinQt: Fix the panic alert deadlock, Pause on Focus Loss edition
2020-09-15 11:46:46 -04:00
JosJuice
de7ef47548
Core: Run Wiimote::Initialize before HW::Init to avoid crash
...
Fixes a crash on Android (probably nogui too?) caused by PR 8985:
std::__ndk1::__throw_out_of_range(char const*) stdexcept:265
std::__ndk1::__vector_base_common<true>::__throw_out_of_range() const vector:319
InputConfig::GetController(int) InputConfig.cpp:160
WiimoteCommon::GetHIDWiimoteSource(unsigned int) Wiimote.cpp:71
IOS::HLE::WiimoteDevice::WiimoteDevice(IOS::HLE::Device::BluetoothEmu*, int, std::__ndk1::array<unsigned char, 6ul>) WiimoteDevice.cpp:71
IOS::HLE::Device::BluetoothEmu::BluetoothEmu(IOS::HLE::Kernel&, std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&) BTEmu.cpp:64
IOS::HLE::Kernel::AddStaticDevices() IOS.cpp:435
IOS::HLE::Init() IOS.cpp:837
Core::EmuThread(std::__ndk1::unique_ptr<BootParameters, std::__ndk1::default_delete<BootParameters> >, WindowSystemInfo) Core.cpp:442
2020-09-15 12:19:00 +02:00
LC
9e3c08394a
Merge pull request #9085 from Techjar/better-monospace
...
Qt: Use better method of getting default monospace font
2020-09-15 05:01:15 -04:00
LC
f0422512e6
Merge pull request #9082 from JosJuice/android-touch-pointer-recreate
...
Android: Fix touch pointer not working after activity recreation
2020-09-15 04:58:41 -04:00
LC
601ff182db
Merge pull request #9084 from Techjar/custom-rtc-tz-fix
...
Qt/AdvancedPane: Force UTC time for custom RTC entry
2020-09-15 04:58:26 -04:00
Techjar
0759ead9b6
Qt: Use better method of getting default monospace font
...
This should give us a nicer font on Windows, while also not severely
impacting the existing behavior on Linux.
2020-09-15 04:48:44 -04:00
Techjar
4d15fb62d9
Qt/AdvancedPane: Force UTC time for custom RTC entry
2020-09-14 22:09:14 -04:00
JosJuice
c8a76e6928
Android: Fix touch pointer not working after activity recreation
...
The only place where initTouchPointer was called automatically
was Host_RequestRenderWindowSize, which is called at least once
after emulation start, but not after activity recreation.
2020-09-14 14:13:29 +02:00
JMC47
4f1f849c9d
Merge pull request #8985 from jordan-woyak/btemu-cleanup
...
BTEmu/Wiimote: Fixes and Cleanups.
2020-09-14 02:09:27 -04:00
LC
eae68194b3
Merge pull request #9076 from iwubcode/qt_graphics_controls_destruction
...
DolphinQt: properly remove slot connection for ConfigChange when object is destructed
2020-09-13 10:39:44 -04:00
Ryan Meredith
d643723d3a
Android: Improve WRITE_EXTERNAL_STORAGE denial
2020-09-13 10:08:04 -04:00
JosJuice
8bd704304e
Android: Check for granted permission when returning to MainActivity
2020-09-13 14:25:14 +02:00
iwubcode
2bb7d207b7
DolphinQt: fix other widgets that use lambdas (capturing this) without setting the receiver
2020-09-12 17:53:17 -05:00
iwubcode
a83bf8bc59
DolphinQt: properly remove slot connection for ConfigChange when object is destructed
2020-09-12 17:35:58 -05:00
JosJuice
f011e859b4
Android: Centralize default values for settings
...
I was hoping we would be able to pull in the default values
from C++, but it seems like more trouble than it's worth,
partially because of different settings having default values
of different types and partially because we don't have any
convenient way to get a list of all C++ settings.
2020-09-12 14:59:34 +02:00
JosJuice
13d1ef6681
Android: Centralize setting definitions
...
Except controller settings, because those would be annoying
to fit into the same system, and I only need the non-controller
settings to be brought over for the next commits to work.
2020-09-12 14:29:34 +02:00
JosJuice
d51f58f828
Android: Wait for initialization before launching EmulationActivity
...
...instead of waiting for it after launching EmulationActivity.
We need this because there is code that runs very early in
EmulationActivity that accesses the settings.
2020-09-12 14:25:19 +02:00
JMC47
b1fecbb71c
Merge pull request #9004 from JosJuice/android-menu-back
...
Android: Use Back to open the emulation menu on all devices
2020-09-12 08:17:23 -04:00
JMC47
1335df8eb5
Merge pull request #9039 from shuffle2/bt-dll
...
windows: keep an extra reference to BluetoothApis.dll
2020-09-11 04:28:55 -04:00
JMC47
dcbe9da279
Merge pull request #8743 from Techjar/apple-pls-support-standard-api
...
VideoBackends: Disable GPU Texture Decoding under MoltenVK
2020-09-10 09:54:11 -04:00
Vincent Milum Jr
4e443ed857
Adding AmdPowerXpressRequestHighPerformance
...
Adding AmdPowerXpressRequestHighPerformance
This will allow AMD drivers to detect the request to use the dGPU instead of the iGPU on compatible hybrid graphics systems.
Reference: https://community.amd.com/thread/169965
2020-09-09 22:09:34 -07:00
Admiral H. Curtiss
c74ea6696e
Settings: Fix incorrect config key for enabled analytics.
2020-09-09 20:19:30 +02:00
JMC47
a31c204ca8
Merge pull request #8765 from AdmiralCurtiss/jit-reuse-memory
...
Jit64 codegen space reuse.
2020-09-09 08:16:09 -04:00
orbea
2bfbc4d79f
cmake: Silence warnings.
2020-09-08 21:18:40 -07:00
Techjar
8423f848d0
ControllerInterface: Combine evdev devices with the same physical location in addition to unique ID
2020-09-08 18:52:15 -04:00
JosJuice
cecec756ec
Android: Always show Exit Emulation at bottom of menu
...
To make it easier to access on touchscreens.
2020-09-08 16:39:34 +02:00
JosJuice
6b68b76aed
Android: Remove redundant pause/unpause code
2020-09-08 16:39:34 +02:00
JosJuice
1fdabc7481
Android: Exit emulation by long pressing Back
2020-09-08 16:39:34 +02:00
JosJuice
a03f40ab15
Android: Change "Exit" to "Exit Emulation"
2020-09-08 16:39:34 +02:00
JosJuice
29bb51c456
Android: Adjust margins for game title in menu
2020-09-08 16:39:34 +02:00
JosJuice
7aa9222dac
Android: Hide Refresh Wii Remotes menu entry for GameCube games
2020-09-08 16:39:34 +02:00
JosJuice
36a3b54c1f
Android: Port over settings from the old menu
2020-09-08 16:39:34 +02:00
JosJuice
364b9702f4
Android: Use narrow layout for savestate slot picker in portrait
2020-09-08 16:35:26 +02:00
JosJuice
772a98e853
Android: Ensure menu is always wide enough
...
25% of the screen isn't necessarily wide enough on phones,
especially not in portrait mode.
2020-09-08 16:35:26 +02:00
JosJuice
48de1333df
Android: Close the menu when tapping outside of it
2020-09-08 16:35:26 +02:00
JosJuice
48c34bba8a
Android: Don't hide the menu when pressing Exit
...
Removing the menu for a split second before showing the transition
back to the main activity looks janky.
2020-09-08 16:27:09 +02:00
JosJuice
27554d2f26
Android: Remove inappropriate leanback checks
...
Android TV devices aren't the only devices without touchscreens.
Regarding MotionAlertDialog, I could've replaced the leanback
check with a touchscreen check instead of just removing it,
but I thought there was no reason to prevent people with
touchscreens from doing a long back press if they want to.
2020-09-08 16:27:09 +02:00
JosJuice
cf51642c17
Android: Use Back to open the emulation menu on all devices
...
https://bugs.dolphin-emu.org/issues/12029
We currently have one way of opening the menu on touch screen
devices (swiping down from the top of the screen to bring up the
action bar and selecting the menu in the action bar), and another
way of opening the menu on Android TV (pressing Back). However,
some devices that claim to support touch (or don't support
leanback? Dolphin currently conflates the two) don't actually let
you swipe down from the top of the screen in the way that Dolphin
expects, notably Chromebooks. There are also some phones where you
can swipe down from the top of the screen but this for some reason
doesn't lead to the action bar becoming visible, though we are
getting less reports about this nowadays than in the past.
This change makes us use the Back method on all devices,
since it should work on all devices with no significant drawbacks.
Unfortunately, we not only have two different ways of triggering
the menu but actually two entirely different menus, with the
non-touch menu not implementing options that only are revelant
when using a touch screen. A later commit will add the missing
features to the menu that we now use on all devices.
2020-09-08 16:27:09 +02:00
LC
67761c7d31
Merge pull request #9067 from Ebola16/Fixes4
...
Android: Optimize imports
2020-09-08 09:47:59 -04:00
Ryan Meredith
1aacb575de
Android: Remove calling create immediately before show
2020-09-08 06:20:19 -04:00
Ryan Meredith
10e85ff40c
Android: Remove unnecessary getString calls
2020-09-08 06:14:58 -04:00
Ryan Meredith
255e8ff007
Android: Optimize imports
2020-09-08 06:01:34 -04:00
Ryan Meredith
1ec2ac780d
Android: Update code-style-java for androidx files
2020-09-08 05:59:08 -04:00
JMC47
3d33b1c2c5
Merge pull request #9060 from Pokechu22/ignore-pi-reset-code
...
Ignore PI_RESET_CODE resetting DI in Wii mode
2020-09-08 01:56:19 -04:00
LC
b350cf043b
Merge pull request #8976 from JosJuice/port-some-settings
...
Port some settings to the new config system
2020-09-07 22:37:46 -04:00
LC
fa91b47863
Merge pull request #9054 from sepalani/hle-cleanup
...
HLE cleanup
2020-09-07 22:36:19 -04:00
LC
8e505ad8d5
Merge pull request #9055 from JosJuice/gc-sample-rate
...
AudioInterface: Use 32029/48043 Hz in more places
2020-09-07 22:35:00 -04:00
LC
a3dfb228fd
Merge pull request #9062 from JosJuice/android-dir-init-fail-message
...
Android: Optional AfterDirectoryInitializationRunner failure message
2020-09-07 22:33:52 -04:00
LC
95376208a1
Merge pull request #9064 from JosJuice/android-filepicker-normal
...
Android: Make FilePicker act like a normal setting
2020-09-07 22:33:10 -04:00
LC
48cfc32bf3
Merge pull request #8935 from JosJuice/di-read-latency
...
DVDInterface: Increase the latency for read commands
2020-09-07 22:31:18 -04:00
Techjar
69358b2186
VideoBackends: Disable GPU Texture Decoding under MoltenVK
...
It's broken and causes spectacular artifacts and crashes.
2020-09-07 17:28:05 -04:00
JMC47
e7e5175606
Merge pull request #8861 from JosJuice/netplay-hash
...
Make netplay's "same game" check more robust
2020-09-06 17:14:08 -04:00
JMC47
344fdabf23
Merge pull request #8943 from JosJuice/android-horizontal-wiimote-buttons
...
Android: Fix saving Horizonal Wii Remote overlay A/B/1/2 positions
2020-09-06 17:09:51 -04:00
JosJuice
bd44106fec
AudioCommon: Get initial sample rates from AudioInterface
2020-09-06 15:37:20 +02:00
JosJuice
00a8f4faaa
Android: Make FilePicker act like a normal setting
...
The reason why the finish() call was added no longer exists.
(Also, there was never a duplicate SettingsActivity as far as
I can tell, only a duplicate SettingsFragment.)
2020-09-06 14:41:01 +02:00
JosJuice
ee9444a8f9
Android: Create separate InvertedCheckBoxSetting and PercentSliderSetting classes
...
This way we don't have to hardcode any keys inside the classes.
2020-09-06 13:29:57 +02:00
JosJuice
c6a308380c
Android: Replace Java INI parser with C++ INI parser
...
Fixes https://bugs.dolphin-emu.org/issues/12096 .
2020-09-06 13:29:56 +02:00
JosJuice
74f197caed
Android: Expose a proper interface for C++ IniFile class
...
Replaces the inflexible INI functions in NativeLibrary.
2020-09-06 13:29:52 +02:00
JMC47
c8c4ec28ce
Merge pull request #8644 from JosJuice/rework-tgc
...
DiscIO: Rework the implementation of TGC reading
2020-09-06 07:06:26 -04:00
JosJuice
6eefc3c524
Make default graphics backend not show up as empty
...
Fixes https://bugs.dolphin-emu.org/issues/12245 .
I considered making a change to DolphinQt instead of
the core, but then additional effort would've been
required to add the same fix to the Android GUI once
we start using the new config system there.
2020-09-06 12:56:45 +02:00
JosJuice
2959e76f4a
Android: Optional AfterDirectoryInitializationRunner failure message
...
This centralizes the code for showing the write_permission_needed
and external_storage_not_mounted toasts.
2020-09-06 00:47:36 +02:00
Pokechu22
8142712c88
Ignore PI_RESET_CODE resetting DI in Wii mode
...
Fixes bug 12241
2020-09-04 16:54:00 -07:00
LC
db067104ed
Merge pull request #9047 from JosJuice/wia-header-heuristic
...
DiscIO: Adjust WIA/RVZ header size heuristic
2020-09-01 17:58:51 -04:00
LC
936702bd04
Merge pull request #9033 from leoetlino/scan-thread
...
IOS/USB: Move scan thread logic into a separate class
2020-09-01 17:56:33 -04:00
Sepalani
c63ac38c83
Socket: Abort pending operations on shutdown
2020-09-01 19:26:44 +04:00
LC
fb32f1ab88
Merge pull request #9042 from Ebola16/FP
...
Android: Minor cleanup
2020-09-01 07:27:07 -04:00
LC
d17c407f09
Merge pull request #9052 from Ebola16/GCAT
...
Android: Better GCAdapter scanning thread management
2020-09-01 07:25:59 -04:00
LC
42a7c959e1
Merge pull request #9056 from JosJuice/supportsreadwiidecrypted-parameter
...
DiscIO: Add parameters to BlobReader::SupportsReadWiiDecrypted
2020-09-01 07:25:31 -04:00
LC
6bd7687893
Merge pull request #9050 from stblr/memory-watcher-fix
...
MemoryWatcher: Do not follow invalid pointers
2020-09-01 07:24:05 -04:00
Ryan Meredith
05f3c4d579
Android: Remove unused files
2020-08-31 11:42:27 -04:00
Ryan Meredith
85ddb8fc86
Android: Minor cleanup 2
2020-08-31 11:23:59 -04:00
JosJuice
bdd28c0edf
DiscIO: Expand WIA/RVZ header size heuristic comments
2020-08-31 14:46:13 +02:00
Ryan Meredith
30ea98177a
Android: Minor cleanup
2020-08-31 07:20:02 -04:00
Ryan Meredith
7d39ed9bcc
Android: res cleanup
2020-08-31 06:49:10 -04:00
Jordan Woyak
e0b64e0ef8
Merge pull request #9049 from Ebola16/GCAC
...
GCAdapter_Android: Minor cleanup
2020-08-30 19:48:07 -05:00
Shawn Hoffman
e601bc5532
windows: keep an extra reference to BluetoothApis.dll
2020-08-30 17:46:32 -07:00
Jordan Woyak
0a63340c20
Merge pull request #9037 from shuffle2/code-cleanup
...
Code cleanup
2020-08-30 19:43:23 -05:00
Pablo Stebler
ff168469b7
MemoryWatcher: Do not follow invalid pointers
2020-08-30 10:29:40 +02:00
JosJuice
047bb80337
DiscIO: Add parameters to BlobReader::SupportsReadWiiDecrypted
...
It's possible (but rare) for a WIA or RVZ file to support
this for some partitions but not all, and for the game and
the blob code to disagree on how large a partition is.
2020-08-29 15:18:52 +02:00
JosJuice
1a1b89e7e8
AudioInterface: Use 32029/48043 Hz in more places
...
In particular, I wanted to do change this in
AudioInterface::Init so that dumped GC audio doesn't need
to have a file split (changing from 32000 Hz to 32029 Hz)
when the emulated software initializes the AI registers.
I've also made the same change to DI's DTK code.
2020-08-29 13:24:39 +02:00
Sepalani
4c75b96254
HLE: Improve naming
...
Replace 'function' with 'hook' when appropriate
2020-08-28 20:29:05 +04:00
Shawn Hoffman
24e8ed8e27
msbuild: add experimental:deterministic for safety
2020-08-28 01:39:38 -07:00
Shawn Hoffman
5d334d4756
msbuild: explicitly disable incremental linking
...
Previously the default was used, which would
enable incremental linking for debug builds.
2020-08-27 23:59:22 -07:00
Shawn Hoffman
969ea6e4f5
msvc: enable /Zc:preprocessor and make build compile cleanly
2020-08-27 21:58:48 -07:00
Shawn Hoffman
4db06bf85b
ogl: init ProgramShaderCache::s_ubo_align to 1.
...
silences a warning that it may cause div-by-zero.
2020-08-27 15:15:52 -07:00
Shawn Hoffman
8068ff92bf
msbuild: use x64-hosted toolchain
2020-08-27 15:15:52 -07:00
Shawn Hoffman
9888adad54
msbuild: always enable /Gy and /Gw
2020-08-27 15:15:52 -07:00
Shawn Hoffman
9717a418b9
msbuild: properly enable /Brepro
2020-08-27 15:15:52 -07:00
Shawn Hoffman
d35514399e
msbuild: fix a typo
2020-08-27 15:15:52 -07:00
Shawn Hoffman
7279f31b24
msbuild: re-enable C4996 and C4351
...
C4996 enables warnings about deprecated items
C4351 was phased out (thus a no-op) years ago
2020-08-27 15:15:52 -07:00
Shawn Hoffman
ae061276d6
msbuild: enable /Zc:externConstexpr,lambda note about preprocessor
2020-08-27 15:15:34 -07:00
Kate
5981a1929d
Add support for FreeBSD/arm64
2020-08-27 21:54:04 +01:00
Sepalani
17ad2ac719
HLE: Rename GetFunctionIndex functions
2020-08-27 22:12:15 +04:00
Sepalani
6b05e48bd6
HLE: Make naming closer to the current coding style
2020-08-27 22:01:04 +04:00
Sepalani
e0605d7911
HLE: Remove unused OSBreakPoints
2020-08-27 21:41:32 +04:00
Sepalani
79bfb48d68
HLE: Remove unused function
2020-08-27 21:07:42 +04:00
Ryan Meredith
9fe6466c79
Android: Better GCAdapter scanning thread management
2020-08-27 07:43:20 -04:00
Ryan Meredith
acd717ffae
GCAdapter_Android: Minor cleanup
2020-08-26 16:40:22 -04:00
Admiral H. Curtiss
4b91c071c1
Qt/GCMemcardCreateNewDialog: Use zero values for formatting instead of accessing g_SRAM.
2020-08-24 19:33:28 +02:00
Admiral H. Curtiss
b175c203e4
GCMemcardDirectory: Avoid undefined behavior in ClearBlock().
2020-08-24 19:32:10 +02:00
Admiral H. Curtiss
131eb9107b
GCMemcard: Avoid undefined behavior in the static Format().
2020-08-24 19:32:10 +02:00
Admiral H. Curtiss
87135db492
GCMemcardDirectory: Clarify data writing in FlushToFile().
2020-08-24 19:32:10 +02:00
Admiral H. Curtiss
306a5e6990
Jit64: Keep track of free code regions and reuse space when possible.
2020-08-24 19:31:32 +02:00
Admiral H. Curtiss
fdab9783c7
Externals: Add rangeset.
2020-08-24 19:31:32 +02:00
Admiral H. Curtiss
5b52b3e9cb
x64Emitter: Check end of allocated space when emitting code.
2020-08-24 19:31:32 +02:00
Shawn Hoffman
fcc8dfd189
Common/Assert: no longer needs special impl for msvc
2020-08-23 13:57:05 -07:00
Shawn Hoffman
89b6a4cbee
DolphinQt: resolve Qt5.15 deprecations
2020-08-23 13:57:05 -07:00
Shawn Hoffman
c629af6319
replace is_pod with is_standard_layout && is_trivially_copyable
2020-08-23 13:57:05 -07:00
Shawn Hoffman
2c2fd21d41
msbuild: silence warnings about deprecated codecvt items
2020-08-23 13:57:05 -07:00
Shawn Hoffman
12ea56a6b2
remove extraneous WIN32_LEAN_AND_MEAN definition
2020-08-23 13:57:05 -07:00
Shawn Hoffman
181e0dba21
apply `if constexpr` in a couple places
2020-08-23 13:57:05 -07:00
Shawn Hoffman
ccbc4c2d99
fix possible dangling shared_ptr ptr in ios
2020-08-23 13:57:05 -07:00
Shawn Hoffman
3ee4c53d65
wiimotereal: add some error handling. replace malloc with make_unique
2020-08-23 13:57:05 -07:00
Shawn Hoffman
938fd4e438
use constexpr for some compile-time expressions
2020-08-23 13:57:05 -07:00
Shawn Hoffman
79f5ea0474
initialize some variables which need to be
2020-08-23 13:57:05 -07:00
Shawn Hoffman
c22748dc38
windows: fix some incorrect string lengths
2020-08-23 13:55:15 -07:00
Shawn Hoffman
b021573a70
GekkoDisassembler: fix rld*
2020-08-23 13:55:14 -07:00
Shawn Hoffman
49590c9a42
FileUtil: handle some error conditions
2020-08-23 13:55:14 -07:00
Shawn Hoffman
3bc8a26083
don't use std::move on const variables
2020-08-23 13:55:14 -07:00
Shawn Hoffman
1b1fc39f02
handle to GetFileVersionInfoW must be zero
2020-08-23 13:55:14 -07:00
Shawn Hoffman
6ef9d70701
name some threads
2020-08-22 17:22:07 -07:00
Shawn Hoffman
a769dff1d0
windows: additionally set thread name via SetThreadDescription
2020-08-22 17:22:07 -07:00
LC
4a34b74e68
Merge pull request #9035 from shuffle2/vs-pretty
...
misc vcxproj cleanup
2020-08-22 20:13:25 -04:00
LC
f3431f3ff8
Merge pull request #9043 from Ebola16/GS
...
Android: Prevent getSetting ClassCastExceptions in ItemViews
2020-08-22 19:44:13 -04:00
Shawn Hoffman
cff4806d8d
windows: fix build if pch were to be disabled
2020-08-22 16:18:24 -07:00
Shawn Hoffman
1104fcf807
msbuild: allow _WIN32_WINNT to be naturally defined by headers
2020-08-22 16:17:51 -07:00
Shawn Hoffman
c88d832e05
msbuild: prettify include paths
2020-08-22 16:17:51 -07:00
Shawn Hoffman
af55938538
msbuild: use the moc dispatcher from Qt's vstools
...
The new method supports build parallelism and cleaner
integration into msbuild dependency flows.
2020-08-22 16:17:51 -07:00
Shawn Hoffman
03a263db20
msbuild: fixup linking of discord-rpc
2020-08-22 16:17:50 -07:00
Shawn Hoffman
2f47f486af
msbuild: re-enable standalone vcxproj processing
2020-08-22 16:17:50 -07:00
Shawn Hoffman
1f8cda6281
DolphinQt: sort the files in vcxproj
2020-08-22 16:17:50 -07:00
Shawn Hoffman
390f509bbf
windows: disable C4200 directly in libusb.h
2020-08-22 16:17:50 -07:00
Shawn Hoffman
94bf48b67c
msbuild: refactor stuff out of project files (for dolphin)
2020-08-22 16:17:50 -07:00
Shawn Hoffman
3a0d8c0208
msbuild: enable D3DCommon to use pch
2020-08-22 16:17:50 -07:00
Shawn Hoffman
36ace8eb52
prettify some constructs in vcxproj files
2020-08-22 16:17:50 -07:00
JosJuice
f7f0fa2d85
DiscIO: Adjust WIA/RVZ header size heuristic
...
The heuristic was not allocating enough space for Metroid: Other M,
at least when using the default settings. (This didn't break the
file, it just caused some headers to be placed at the end of the
file instead of at the start and wasted a few hundred kilobytes.)
2020-08-22 22:26:55 +02:00
Admiral H. Curtiss
f859da112e
Update Windows build to use Qt 5.15.0.
2020-08-22 20:08:38 +02:00
Ryan Meredith
d5ea4b4b80
Android: Prevent getSetting ClassCastExceptions in ItemViews
2020-08-21 11:09:24 -04:00
JosJuice
fc6c1931fa
VolumeVerifier: Adjust problem descriptions for new netplay check
...
The new hash check catches essentially all desync problems
that VolumeVerifier can catch, so from the user's perspective,
such problems will result in Dolphin refusing to start the
game on netplay rather than actually getting a desync.
2020-08-19 17:21:38 +02:00
LC
905df6756b
Merge pull request #9024 from JosJuice/android-wiimote-false
...
Android: Fix defaults for WiimoteContinuousScanning/EnableSpeaker
2020-08-17 15:25:23 -04:00
LC
24ff8b8d1e
Merge pull request #9034 from JosJuice/android-menu-animation-rtl
...
Android: Take RTL layout into account for menu animations
2020-08-17 15:24:52 -04:00
JosJuice
ac17e49243
Android: Take RTL layout into account for menu animations
2020-08-17 19:37:40 +02:00
Léo Lam
d1439a1fa9
IOS/USB: Move scan thread logic into a separate class
...
This moves the scan thread logic and variables into a separate
ScanThread class. By turning ScanThread instances into members of the
most derived class, this ensures that the scan thread is always
properly stopped when the most derived class is destructed and fixes
a race condition that could cause the scan thread to call virtual
member functions from a derived class whose members have already
been destructed.
A drawback of this approach is that the scan thread must be the last
member variable, so this commit also adds static assertions to ensure
that the assumption stays valid.
2020-08-17 15:14:45 +02:00
Léo Lam
55c931d624
Merge pull request #8995 from Tilka/warnings
...
Fix some more GCC warnings
2020-08-17 14:49:28 +02:00
Léo Lam
6104018fe1
Merge pull request #9020 from Tilka/usb
...
IOS/USB: fix potential race condition
2020-08-17 12:15:26 +02:00
Shawn Hoffman
d40ae8a84b
UnitTests: expliticly list files to be compiled.
...
Fixes VS warning / bad behavior.
2020-08-16 15:17:11 -07:00
Shawn Hoffman
9a5a705d01
Fix comparison to invalidated vector iterator.
...
GetFstEntryForPath may modify the children vector,
so do it before taking an iterator to the vector.
2020-08-16 15:17:11 -07:00
Shawn Hoffman
9d880c2db3
UnitTests: quiet warnings
2020-08-16 15:17:11 -07:00
Shawn Hoffman
deb73d0167
msvc: temporary workaround for C4789 false positive
2020-08-16 12:49:00 -07:00
Jordan Woyak
0ad123bdbb
BTEmu: Fix home menu inquiry assigning multiple wii remotes to wrong slots.
2020-08-16 11:38:13 -05:00
Jordan Woyak
6a6f1451ff
Update state version.
2020-08-16 11:38:13 -05:00
Jordan Woyak
13ee6bd7bb
BTEmu/Wiimote: Cleanups/Fixes.
2020-08-16 11:38:13 -05:00
LC
2c5920dccc
Merge pull request #9028 from cristian64/netplaybrowser_deadlock_on_exit
...
DolphinQt: Prevent deadlock when exiting the NetPlay Session Browser dialog
2020-08-16 08:57:35 -04:00
Christian Aguilera
ddeb2236ae
Removed RunOnObject() usage to prevent deadlock on exiting the NetPlay Session Browser dialog.
2020-08-16 12:32:50 +01:00
LC
6fc7135047
Merge pull request #8855 from shuffle2/dol
...
DolReader: treat overly large data segment as bss
2020-08-16 06:02:39 -04:00
Jordan Woyak
89ca9b51ad
Bluetooth/WiimoteDevice: Remove some silly comments.
2020-08-15 21:23:37 -05:00
Jordan Woyak
1cddf9c527
BTEmu: Remove a wrong INFO_LOG.
2020-08-15 21:23:37 -05:00
Christian Aguilera
eee1589aa3
Restoring NetPlay Session Browser dialog's settings before connecting widgets, to prevent multiple refresh requests on change.
2020-08-15 22:29:23 +01:00
JosJuice
07a0d44b36
Merge pull request #8571 from Pokechu22/di-interrupts
...
Fix gamecube games not noticing disc changes
2020-08-11 20:03:41 +02:00
JosJuice
bd87285f3a
FrameDump: Don't ignore the time base numerator
...
Fixes a regression where f72b756
made all dumped video super long.
2020-08-11 11:17:22 +02:00
cyrozap
c2de1d041a
Fix builds with system LZMA when using versions of CMake before 3.14
...
The "FindLibLZMA.cmake" module in CMake versions prior to 3.14 do not
set an alias like how Externals/liblzma/CMakeLists.txt does, so builds
performed using one of those older CMake versions will fail if the
system LZMA library is detected. To fix this, we need to link against
"lzma" instead of "LibLZMA::LibLZMA".
Fixes: b59ef81a7e
("WIA: Implement bzip2, LZMA, and LZMA2 decompression")
2020-08-11 02:53:16 -05:00
JosJuice
bd9d0964cd
Android: Fix defaults for WiimoteContinuousScanning/EnableSpeaker
...
The default values need to match the default values defined in C++.
2020-08-11 09:18:15 +02:00
JosJuice
02fe1cdec4
Android: Rewrite GetRenderSurfaceScale in Java
...
Long sequences of JNI calls are both hard to read and slow.
2020-08-09 21:07:22 +02:00
Tillmann Karras
ca61b6c1ab
DiscIO: make use of std::nullopt
...
This also fixes a bogus GCC warning.
2020-08-08 21:53:27 +01:00
Tillmann Karras
d2b06f4786
Fix various -Wshadow warnings
2020-08-08 21:45:03 +01:00
Tillmann Karras
ee0d4661ab
IOS/USB: deduplicate scan thread stopping
...
Unlike other functions, base ctors/dtors are always called automatically.
2020-08-08 21:40:23 +01:00
Tillmann Karras
1f4b9adbf5
ISO/USB: fix potential race condition
2020-08-08 21:40:23 +01:00
Tilka
a161e58591
Merge pull request #8914 from JosJuice/jit64-low-dcbz
...
Jit64: Implement low DCBZ hack
2020-08-08 21:19:16 +01:00
Tilka
8b236fc8f8
Merge pull request #8986 from jordan-woyak/button-pressed-no-ext
...
WiimoteEmu: Don't check extension button press for Wii remote reconnection.
2020-08-08 21:06:46 +01:00
Tilka
c0fde32d80
Merge pull request #9019 from JosJuice/verify-wad-split-tmd-ticket
...
VolumeVerifier: Split TMD error from ticket error for WADs
2020-08-08 21:05:21 +01:00
JosJuice
76228fa482
Jit64: Implement low DCBZ hack
...
I was hoping this would improve the performance of Cars 2 by
avoiding interpreter fallbacks, but it doesn't seem to have
made any measurable impact.
2020-08-08 22:03:34 +02:00
Tilka
3101d957b6
Merge pull request #8886 from JosJuice/stack-check-instruction
...
PatchEngine: Attempt to fix crash in IsStackSane
2020-08-08 20:59:48 +01:00
Tilka
6356cc8b08
Merge pull request #8910 from OatmealDome/os-deprecated-cleanup
...
Analytics: Replace usage of Gestalt for retrieving macOS version
2020-08-08 20:53:14 +01:00
Tilka
f17b5dd41b
Merge pull request #8804 from iwubcode/dsu-improvements
...
DolphinQt / InputCommon - Support multiple DSU servers
2020-08-08 20:45:57 +01:00
JosJuice
7ef0bc0359
VolumeVerifier: Split TMD error from ticket error for WADs
...
When I first made VolumeVerifier, I figured that the distinction
between an unsigned ticket and an unsigned TMD was a technical
detail that users would have no reason to care about. However,
while this might be true for discs, it isn't equally true for
WADs, due to the widespread practice of fakesigning tickets to
set the console ID to 0. This practice does not require
fakesigning the TMD (though apparently people do it anyway,
at least sometimes...), and the presence of a correctly signed
TMD is a useful indicator that the contents have not been
tampered with, even if the ticket isn't correctly signed.
2020-08-08 21:15:51 +02:00
Tilka
76b955e090
Merge pull request #8940 from RenaKunisaki/master
...
add Break On Hit and Log On Hit for instruction breakpoints
2020-08-08 19:46:10 +01:00
Tilka
6d0bc03e00
Merge pull request #8992 from Sintendo/fselx-avx
...
Jit64: Avoid unnecessary MOVAPS instructions
2020-08-08 19:38:48 +01:00
Tilka
d7a96f927c
Merge pull request #9002 from OatmealDome/renderwidget-sheet
...
MainWindow: Attach quit emulation sheet to RenderWidget if shown on macOS
2020-08-08 19:18:32 +01:00
Tilka
4c64446afe
Merge pull request #9005 from OatmealDome/macos-psn-arg
...
DolphinQt: Ignore "-psn" command line option on macOS
2020-08-08 19:11:39 +01:00
Tilka
340c08a88d
Merge pull request #9008 from Sintendo/dspjitlea
...
DSPJit: Various minor improvements
2020-08-08 19:08:24 +01:00
Tilka
3201944208
Merge pull request #9016 from JosJuice/jitarm64-fctiwzx-fcvt
...
JitArm64: Avoid double rounding in fctiwzx
2020-08-08 17:55:49 +01:00
JosJuice
8b4f16a310
JitArm64: Avoid double rounding in fctiwzx
...
FCVT doesn't necessarily round to zero, so the result
might be inaccurate if we use it. To ensure correct
rounding, we use FCVTS from double FPR to 32-bit GPR.
Unfortunately, FCVTS can't do double FPR to single FPR.
2020-08-07 22:44:04 +02:00
Jordan Woyak
a77977d0aa
Merge pull request #8999 from AdmiralCurtiss/input-expression-math
...
Add a few input expression functions (trigonometry, sqrt, pow, min, max, clamp)
2020-08-07 14:40:29 -05:00
LC
5ec65a20d6
Merge pull request #9009 from JosJuice/android-settings-recreation
...
Android: Fix SettingsActivity lifecycle management
2020-08-06 19:46:16 -04:00
LC
d8c0344ee8
Merge pull request #9010 from JosJuice/android-settingsadapter-redundant-static
...
Android: Remove some static variables from SettingsAdapter
2020-08-06 19:45:54 -04:00
LC
7b3056fee0
Merge pull request #9011 from JosJuice/android-settings-viewmodel
...
Android: Persist Settings using ViewModel
2020-08-06 19:45:17 -04:00
LC
de5d0e54be
Merge pull request #9013 from JosJuice/savescreenshot-wait-for-completion
...
Remove wait_for_completion parameter from Renderer::SaveScreenshot
2020-08-06 19:44:43 -04:00
JosJuice
7385e9129c
Remove wait_for_completion parameter from Renderer::SaveScreenshot
...
This is now unused. Seems like it was an improper fix
(there would be a race if saving the screenshot took longer
than 2 seconds) back when it was used too.
2020-08-06 21:57:12 +02:00
JosJuice
05e49b13ef
Android: Fix SettingsActivity back stack behavior after stop+start
...
Fixes the behavior where the settings activity would go back to
the top-level menu after switching to a different app and back.
2020-08-05 21:21:45 +02:00
JosJuice
a427eafa7b
Android: Persist Settings using ViewModel
...
Just for maintainability. This is a shorter and more standard
solution compared to our current one where the Fragment
persists the Settings and passes it to the Activity.
2020-08-05 19:50:11 +02:00
JosJuice
e3911736c2
Android: Remove some static variables from SettingsAdapter
...
All of these have non-static equivalents (mView and mClickedItem).
2020-08-05 18:47:17 +02:00
JosJuice
c727f03590
Android: Properly restore state of SettingsActivityPresenter
...
Fixes https://bugs.dolphin-emu.org/issues/10815
2020-08-05 13:21:07 +02:00
Sintendo
363f3f82bb
DSPJitRegCache: Simplify WriteReg
...
The intent here is to generate a more compact instruction if a 32-bit
immediate can be zero-extended to the desired 64-bit immediate.
Nowadays the emitter is smart enough to do this for us, so this logic is
redundant.
2020-08-05 10:23:28 +02:00
Sintendo
618d261b91
DSPJitMultiplier: addpaxz - AND constant directly
...
There's no need to load the 64-bit immediate into a temporary register.
x64 will sign-extend 32-bit immediates to 64 bits, giving us the exact
value we need in this case.
48 C7 C0 00 00 FF FF mov rax,0FFFFFFFFFFFF0000h
48 21 C2 and rdx,rax
48 81 E2 00 00 FF FF and rdx,0FFFFFFFFFFFF0000h
2020-08-05 10:22:51 +02:00
Sintendo
49a4e09719
DSPJit: Replace/optimize LEAs
...
- LEA is a bit silly when the source and the destination are the same. A
simple ADD or SHL will do in those cases.
66 8D 04 45 00 00 00 00 lea ax,[rax*2]
66 03 C0 add ax,ax
48 8D 04 00 lea rax,[rax+rax]
48 03 C0 add rax,rax
66 8D 14 D5 00 00 00 00 lea dx,[rdx*8]
66 C1 E2 03 shl dx,3
- When scaling by 2, consider summing the register with itself instead.
The former always needs a 32-bit displacement, so the sum is more
compact.
66 8D 14 45 00 00 00 00 lea dx,[rax*2]
66 8D 14 00 lea dx,[rax+rax]
2020-08-05 10:22:50 +02:00
OatmealDome
5c1693587f
DolphinQt: Ignore "-psn" command line option on macOS
2020-08-04 15:55:51 -04:00
JosJuice
b0f9bb9f13
Port some settings to the new config system
...
Other than the controller settings and JIT debug settings,
these are the only settings which were defined in Java code
but not defined in the new config system in C++. (There are
still a lot of settings that are defined in the new config
system but not yet saveable in the new config system, though.)
2020-08-03 15:07:53 +02:00
OatmealDome
fae8f8d68b
MainWindow: Attach quit emulation sheet to RenderWidget on macOS
2020-08-03 05:48:57 -04:00
Ryan Meredith
6020133f5b
LogManager: Add missing include
2020-08-02 19:52:10 -04:00
JosJuice
5cad82137d
Allow translations and custom names in GameFile::GetNetPlayName
...
There is no longer any major reason for why this function would
need to return the same result for all players.
2020-08-02 22:46:53 +02:00
JosJuice
a41166bb37
Make netplay's "same game" check more robust
...
Instead of comparing the game ID, revision, disc number and name,
we can compare a hash of important parts of the disc including
all the aforementioned data but also additional data such as the
FST. The primary reason why I'm making this change is to let us
catch more desyncs before they happen, but this should also fix
https://bugs.dolphin-emu.org/issues/12115 . As a bonus, the UI can
now distinguish the case where a client doesn't have the game at
all from the case where a client has the wrong version of the game.
2020-08-02 22:46:53 +02:00
Admiral H. Curtiss
cdf2a29b5e
Qt/IOWindow: Add a handful of math functions to the function dropdown.
2020-08-02 22:09:09 +02:00
Admiral H. Curtiss
2281cde28b
InputCommon: Add a handful of math functions to the expression parser.
2020-08-02 22:09:09 +02:00
JosJuice
7414020563
Merge pull request #8966 from Ebola16/WP
...
Android: Clear game profiles and GameSettings
2020-08-02 22:06:16 +02:00
JosJuice
e33876fbe2
Merge pull request #8978 from Ebola16/RS
...
Android: Settings and Emulation activities skip (Tv)MainActivity library rescan
2020-08-02 22:05:38 +02:00
JosJuice
234eaa0ff9
Merge pull request #7252 from Ebola16/Log
...
Android: Add Log Configuration to UI
2020-08-02 22:00:48 +02:00
JosJuice
bf3d1fa2d8
Merge pull request #8858 from Ebola16/PUP
...
Android: Add Pause / Unpause Emulation Toggle
2020-08-02 21:56:25 +02:00
Sintendo
08bdeefe05
Jit64AsmCommon: Use AVX in ConvertDoubleToSingle
...
Using AVX we can eliminate another MOVAPS instruction here.
Before:
0F 28 C8 movaps xmm1,xmm0
66 0F DB 0D CF 2C 00 00 pand xmm1,xmmword ptr [1F8D283B220h]
After:
C5 F9 DB 0D D2 2C 00 00 vpand xmm1,xmm0,xmmword ptr [271835FB220h]
2020-08-02 18:07:47 +02:00
Felk
f775e9b99d
OnScreenDisplay: fix names rgba -> argb
2020-08-02 01:37:20 +02:00
Tilka
dbacffd75d
Merge pull request #8731 from Pokechu22/dsp-lle-cpu-int-crash
...
Fix crash when using DSP LLE with CPU interpreter (or fastmem off)
2020-08-01 15:26:27 +01:00
JosJuice
13f20ecd34
DolphinQt: Don't capture local pointer by reference
...
This may be the cause of a crash that has been reported on the
forums, but I'm not sure since I can't reproduce it myself.
2020-07-31 11:33:48 +02:00
LC
0f4cf4a84d
Merge pull request #8991 from JosJuice/android-rumble-without-touchscreen
...
Android: Remove touchscreen check for rumble
2020-07-30 21:45:56 -04:00
LC
0aaddf8b19
Merge pull request #8990 from JosJuice/wia-conversion-warning
...
DiscIO: Fix conversion warning
2020-07-30 21:45:24 -04:00
JosJuice
9be5fe5996
CMake: Add -D_SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING
...
The CMake Windows build was broken because of me adding a usage
of std::codecvt_utf8_utf16 to StringUtil.cpp. Kinda silly to have
a warning for an API with no standard replacement available...
2020-07-30 20:22:57 +02:00
Pokechu22
9183c0c482
Bump state version
2020-07-29 16:57:37 -07:00
Pokechu22
e5e23c6b27
Mark several DVDInterface functions as static
2020-07-29 16:57:36 -07:00
Pokechu22
4415df463f
Remove DVDInterface::Reset
...
It only resets the registers, which isn't something that needs to be done except for in DVDInterface::Init
2020-07-29 16:57:36 -07:00
Pokechu22
0fa96df818
Remove DriveState::DiscChangeDetected hack
...
Since both GameCube and Wii resets now work correctly, this hack is not needed anymore.
2020-07-29 16:57:36 -07:00
Pokechu22
a73eaf5712
Fix DVDLowReset spinup flag being read incorrectly
2020-07-29 16:57:35 -07:00
Pokechu22
9a8d426645
Implement PI_RESET_CODE resetting DI
2020-07-29 16:57:35 -07:00
Pokechu22
b8715b42d2
Only reset drive chip state (not DI registers) when changing discs
...
Resetting the DI registers disables interrupts, which means any errors reported (for instance) are just not sent though.
2020-07-29 16:57:35 -07:00
Pokechu22
537e40afb5
Only update DIMAR and DILENGTH if transfer completed without error
...
Turns out, Gamecube games actually do check DILENGTH, and if DILENGTH is at 0, they'll think the transfer completed successfully even if DEINT is used, since after all, surely that means everything was sent. That caused all sorts of issues, from audio looping when a disc is removed since it's re-using the same buffer to just flat-out crashing instead of showing the disc removed screen.
2020-07-29 16:57:35 -07:00
Pokechu22
fba51b2956
Split drive state and drive error into 2 fields, and fix some inaccuracies
...
In particular:
- Trying to play audio in a non-ready state returns the state-specific error, not an audio buf error
- Audio status cannot be requested in non-ready states
- The audio buffer cannot be configured in states other than ReadyNoReadsMade
- Using the stop motor command while the motor is already stopped doesn't change states
Additionally, the internal state IDs are used (which distinguish ReadyNoReadsMade and Ready), instead of the state IDs exposed in request error. This makes some of the weird behavior a bit more obvious.
State and error behavior of the seek command was not implemented in this commit.
2020-07-29 16:57:34 -07:00
JosJuice
2e8c5b4521
DolphinQt: Show a warning when launching an NKit disc image
...
It is my opinion that nobody should use NKit disc images without
being aware of the drawbacks of them. Since it seems like almost
nobody who is using NKit disc images knows what NKit is (hmm, now
how could that have happened...?), I am adding a warning to Dolphin
so that you can't run NKit disc images without finding out about the
drawbacks. In case someone really does want to use NKit disc images,
the warning has a "Don't show this again" option. Unfortunately, I
can't retroactively add the warning where it's most needed:
in Dolphin 5.0, which does not support Wii NKit disc images.
2020-07-29 21:05:57 +02:00
Ryan Meredith
12d277b4a0
Android: Add Pause / Unpause Emulation Toggle
2020-07-29 13:03:52 -04:00
JosJuice
709031bb1d
Android: Remove touchscreen check for rumble
...
That a device doesn't have a touchscreen doesn't necessarily mean
that it doesn't support rumble (though it is usually the case).
setPhoneVibrator already contains a check for whether the device
supports rumble, so we can simply remove the touchscreen check.
2020-07-29 17:48:56 +02:00
Sintendo
31755bc13a
Jit64: fselx - Optimize SSE4.1 packed
...
Pretty much the same optimization we did for AVX, although slightly more
constrained because we're stuck with the two-operand instruction where
destination and source have to match.
We could also specialize the case where registers b, c, and d are all
distinct, but I decided against it since I couldn't find any game that
does this.
Before:
66 0F 57 C0 xorpd xmm0,xmm0
66 41 0F C2 C1 06 cmpnlepd xmm0,xmm9
41 0F 28 CE movaps xmm1,xmm14
66 41 0F 38 15 CC blendvpd xmm1,xmm12,xmm0
44 0F 28 F1 movaps xmm14,xmm1
After:
66 0F 57 C0 xorpd xmm0,xmm0
66 41 0F C2 C1 06 cmpnlepd xmm0,xmm9
66 45 0F 38 15 F4 blendvpd xmm14,xmm12,xmm0
2020-07-29 17:28:48 +02:00
Sintendo
afb86a12ab
Jit64: fselx - Optimize AVX packed
...
For the packed variant, we can skip the final MOVAPS and write the
result directly into the destination register.
Before:
66 0F 57 C0 xorpd xmm0,xmm0
66 41 0F C2 C1 06 cmpnlepd xmm0,xmm9
C4 C3 09 4B CC 00 vblendvpd xmm1,xmm14,xmm12,xmm0
44 0F 28 F1 movaps xmm14,xmm1
After:
66 0F 57 C0 xorpd xmm0,xmm0
66 41 0F C2 C1 06 cmpnlepd xmm0,xmm9
C4 43 09 4B F4 00 vblendvpd xmm14,xmm14,xmm12,xmm0
2020-07-29 17:06:52 +02:00
JosJuice
a05b1f9ab9
DiscIO: Fix conversion warning
...
Should fix https://bugs.dolphin-emu.org/issues/12208 .
2020-07-29 10:55:02 +02:00
LC
b354e343a7
Merge pull request #8988 from JosJuice/no-refresh-rate-round
...
VideoCommon: Don't round the refresh rate
2020-07-28 17:17:34 -04:00
Sintendo
a52774ca63
Jit64: fselx - Add AVX path
...
AVX has a four-operand VBLENDVPD instruction, which allows for the first
input and the destination to be different. By taking advantage of this,
we no longer need to copy one of the inputs around and we can just
reference it directly, provided it's already in a register (I have yet
to see this not be the case).
Before:
66 0F 57 C0 xorpd xmm0,xmm0
F2 41 0F C2 C6 06 cmpnlesd xmm0,xmm14
41 0F 28 CE movaps xmm1,xmm14
66 41 0F 38 15 CA blendvpd xmm1,xmm10,xmm0
F2 44 0F 10 F1 movsd xmm14,xmm1
After:
66 0F 57 C0 xorpd xmm0,xmm0
F2 41 0F C2 C6 06 cmpnlesd xmm0,xmm14
C4 C3 09 4B CA 00 vblendvpd xmm1,xmm14,xmm10,xmm0
F2 44 0F 10 F1 movsd xmm14,xmm1
2020-07-28 23:17:18 +02:00
LC
5066d4d239
Merge pull request #8989 from JosJuice/android-minimal-post-processing
...
Android: Set preferMinimalPostProcessing="true"
2020-07-28 17:16:47 -04:00
JosJuice
9c44ad11e3
Android: Set preferMinimalPostProcessing="true"
...
When using the combination of Android 11 and HDMI 2.1,
this will send a signal to the TV suggesting it to switch to
a low latency mode ("game mode").
2020-07-28 22:21:57 +02:00
JosJuice
f72b756778
VideoCommon: Don't round the refresh rate
...
We now provide a double to the FPS counter and exact values
to FIFO recording and frame dumping.
2020-07-28 21:01:38 +02:00
Jordan Woyak
bdfb320b3d
WiimoteEmu: Don't check extension button press for wii remote reconnection. A real remote doesn't. We won't either.
2020-07-26 11:20:23 -05:00
Pokechu22
1ca3710bd2
DSPLLE: Use Memory functions isntead of directly using Memory::physical_base
...
Fixes bug 11980
2020-07-24 15:06:39 -07:00
Pokechu22
59dc7cfe7d
Use size_t in some DSP code code
2020-07-24 15:06:39 -07:00
Lioncash
f9b856aeda
WiimoteEmu: Mark several getters as const
...
These don't modify internal class state, so they can be made const.
2020-07-24 15:48:27 -04:00
Ryan Meredith
fdcc6a436b
Android: Add Log Configuration to UI
2020-07-24 13:59:13 -04:00
Lioncash
4b21bc7508
LightingShaderGen: Transition over to fmt
2020-07-24 13:50:09 -04:00
Ryan Meredith
e7d53224b2
Android: Clear game profiles and GameSettings
2020-07-24 13:36:38 -04:00
Lioncash
7f7db6d3e7
VertexShaderGen: Transition over to using fmt
2020-07-24 13:34:47 -04:00
Tillmann Karras
062dd5ab0a
DolphinQt: fix -Wunused-variable warning
2020-07-24 17:44:32 +01:00
Tillmann Karras
5bd2b2699c
DolphinQt: fix -Wsign-compare warning
2020-07-24 17:44:32 +01:00
Tillmann Karras
750cb1f830
DolphinQt: fix -Wunused-but-set-variable warning
2020-07-24 17:41:37 +01:00
Tillmann Karras
bf5b1092b2
DiscIO: fix -Wreorder warning
2020-07-24 17:41:37 +01:00
Tillmann Karras
04b31e7eee
IOS: work around incorrect -Wunused-but-set-variable warning
...
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96311
2020-07-24 16:38:54 +01:00
Tillmann Karras
fbd34f72ad
EXI: fix -Wunused-variable warning
2020-07-24 15:35:35 +01:00
Tillmann Karras
7b2e93eea8
EXI: fix -Wreorder warning
2020-07-24 15:35:24 +01:00
Ryan Meredith
a0ab90f4c6
Android: Settings and Emulation activities skip (Tv)MainActivity library rescan
2020-07-24 04:04:31 -04:00
JMC47
781662c6ad
Merge pull request #8793 from iwubcode/dump-texture-options
...
DolphinQt / VideoCommon: Add additional texture dumping options
2020-07-24 01:38:10 -04:00
JosJuice
213c1841f7
Merge pull request #8903 from AdmiralCurtiss/gcmemcard-file-identity-check
...
GCMemcard: Change behavior of TitlePresent() to more closely resemble how saves are actually identified.
2020-07-23 17:44:16 +02:00
iwubcode
9c8338ec4c
DolphinQt / VideoCommon: Add additional texture dumping options. Specifically, this enables users to choose whether to dump mip maps, base level textures, or both.
2020-07-22 19:30:27 -05:00
LC
d7a91316da
Merge pull request #8974 from Filoppi/patch-4
...
Fix disc image conversion button not being clear #3
2020-07-22 17:24:23 -04:00
LC
bf49849f88
Merge pull request #8971 from JosJuice/simplify-issettingsaveable
...
Config: Simplify IsSettingSaveable
2020-07-22 16:27:34 -04:00
Filippo Tarpini
f6ba54b74e
Fix disc image conversion button not being clear #3
...
It wasn't clear whether the conversion would create a new file or replace the old one
Recreated #8952 directly from github
2020-07-22 23:00:20 +03:00
Ryan Meredith
9ac24a0580
Android: Some simple Clang-Tidy suggestions
2020-07-22 15:38:45 -04:00
JosJuice
26536832c3
Config: Simplify IsSettingSaveable
...
Should make it both easier to edit and faster to run.
2020-07-22 11:46:47 +02:00
JosJuice
e9cc89af83
Android: Remove hacks for Wii Remote extension and video backend settings
2020-07-20 15:25:53 +02:00
LC
ae2348023b
Merge pull request #8964 from JosJuice/list-wad-file-type
...
DolphinQt: Show WAD as "WAD" instead of "" in file format column
2020-07-19 17:35:34 -04:00
JosJuice
fe5e92f706
DolphinQt: Show WAD as "WAD" instead of "" in file format column
...
https://bugs.dolphin-emu.org/issues/12190
2020-07-19 21:30:48 +02:00
Jordan Woyak
ae44f17667
HW/GCPadEmu: Adjust gate radius values to more closely match the real hardware.
2020-07-19 09:45:33 -05:00
LC
487cd7abd9
Merge pull request #8905 from JosJuice/jni-encoding
...
Android: Use correct encoding when converting strings
2020-07-18 22:13:14 -04:00
Filip Gawin
0ede5d1537
Use range loop (if possible)
2020-07-18 18:29:16 -05:00
iwubcode
97c9cf3e21
DolphinQt / InputCommon - add DSU string validator to avoid crashes, limited backwards compatibility support
2020-07-17 14:53:39 -05:00
iwubcode
58aa0150e1
DolphinQt / InputCommon: Support multiple DSU servers
2020-07-17 14:53:39 -05:00
JosJuice
aa4896fb3f
DolphinQt: Add i18n comment for "Surround"
2020-07-17 19:10:31 +02:00
Jordan Woyak
8b3e9e6a81
DolphinQt: Replace unusual Qt::InitialSortOrderRole usage with a custom role.
2020-07-16 20:27:07 -05:00
LC
a7e475e57b
Merge pull request #8958 from jordan-woyak/sort-fix
...
DolphinQt: Fix default sort direction of game list.
2020-07-16 21:20:43 -04:00
Jordan Woyak
ecf016e80a
DolphinQt: Fix default sort direction of game list.
2020-07-16 19:21:14 -05:00
Techjar
037aa2192f
NetPlay: Limit nickname length
...
Ridiculously long nicknames cause UI silliness, so 30 characters seems
like a reasonable limit, as it's the same as the forum.
2020-07-16 19:03:54 -04:00
Techjar
92812d0b0b
QtUtils: Add UTF8CodePointCountValidator
2020-07-16 19:03:46 -04:00
LC
c59648337a
Merge pull request #8955 from JosJuice/android-no-ashmem
...
Android: Don't access /dev/ashmem on newer Android versions
2020-07-16 14:23:51 -04:00
JosJuice
00cde7cbbd
Android: Don't access /dev/ashmem on newer Android versions
...
Fixes a critical regression where 95945a0
made us unable to
start emulation on Android 10 and newer. Android is restricting
direct access to /dev/ashmem starting with the new SDK version,
but we can use the new (and simpler) ASharedMemory API instead.
We have to keep using the /dev/ashmem approach on old versions
of Android, though.
2020-07-16 20:06:58 +02:00
JosJuice
f2cc3a2948
Add Android check for strerror_r variant
...
I don't know why Android does it like this, but at least
it's easy to fix. (We are currently at __ANDROID_API__ == 21.)
2020-07-16 18:51:58 +02:00
nyanpasu64
1a2b6ca2d6
Fix Windows CMake builds with shared zlib
...
On Linux, if shared zlib is present, zlib.h is always available and -lz
links to zlib, even if you don't run find_package(ZLIB).
For some reason I have zlib installed on Windows (possibly from vcpkg),
so find_package(ZLIB) succeeds and ZLIB_FOUND is true.
When Dolphin uses shared zlib on Windows, the problem is that zlib.h
is not in the default include path, and the CMake target is called
ZLIB::ZLIB and there's neither a target nor a library called z.
However, both find_package(ZLIB) and add_subdirectory(Externals/zlib)
create a target called ZLIB::ZLIB, so I'll switch to that instead.
Hopefully this change doesn't break anyone's build.
2020-07-15 23:25:18 -07:00
Admiral H. Curtiss
556e93f357
GCMemcard: Change behavior of TitlePresent() to more closely resemble how saves are actually identified.
...
This modifies GCMemcard::TitlePresent() to match my findings of how the GC BIOS and various games behave when you alter the fields in the directory entry.
It looks like for a save to be recognized by a game, the following have to be true:
- Game code and maker code must exactly match what the game expects.
- Filename is only checked up to the first null byte. All bytes afterwards can be whatever.
The BIOS itself does a full compare of the filename when checking for whether it should allow copying a file from one card to another, but behaves oddly in some cases when there's non-null bytes after the first null. See the big comment in `HasSameIdentity()` for details.
2020-07-15 19:17:22 +02:00
LC
b6ee3228be
Merge pull request #8953 from JosJuice/android-target-sdk-29
...
Android: Increase targetSdkVersion to 29
2020-07-14 12:51:44 -04:00
Tilka
a98df567b1
Merge pull request #8949 from JosJuice/android-cache
...
Android: Use system cache directory as cache directory
2020-07-13 12:21:21 +01:00
Tilka
695a96498a
Merge pull request #8922 from Filoppi/timer-fixes
...
Timer fixes
2020-07-13 00:16:45 +01:00
JMC47
3c70fb7277
Merge pull request #8950 from jordan-woyak/double-time-fix
...
Common/Timer: Fix integer underflow in Timer::GetDoubleTime for dates before ~2008.
2020-07-12 15:52:15 -04:00
Jordan Woyak
eab07866a3
Common/Timer: Fix integer underflow in Timer::GetDoubleTime for dates before ~2008.
2020-07-12 12:55:02 -05:00
LC
4d36f6a5b0
Merge pull request #8936 from jordan-woyak/wiimote-extension-calibration-fix
...
ControllerInterface/Wiimote: Provide fallback values for extensions with bad calibration.
2020-07-12 12:46:15 -04:00
JosJuice
05da2e30ad
Android: Use system cache directory as cache directory
...
This lets Android automatically delete data in the cache
directory when the device is running low on space or
when Dolphin is uninstalled.
2020-07-12 13:33:07 +02:00
JosJuice
95945a000e
Android: Increase targetSdkVersion to 29
...
Since updating to 28 took us so long that Google Play started
requiring updates to target 28 before we actually merged the PR that
made us target 28, I'm trying to get the update to 29 done early.
Setting targetSdkVersion to 28 would normally force scoped storage
on us, which we do not support yet. However, we can easily
avoid this by setting android:requestLegacyExternalStorage="true".
There will be no such luxury with targetSdkVersion 30, however...
2020-07-12 12:02:37 +02:00
Jordan Woyak
d9e7d0514c
WiimoteEmu: Allow writes of the i2c bus to play speaker data.
2020-07-11 21:19:16 -05:00
Jordan Woyak
5299e902aa
ControllerInterface/Wiimote: Provide fallback values for extensions with bad calibration data.
2020-07-11 19:55:14 -05:00
Rena Kunisaki
a553f22385
Add Break On Hit and Log On Hit for instruction breakpoints
2020-07-11 13:38:58 -04:00
LC
ed32a2a1fe
Merge pull request #8946 from jordan-woyak/unbreak-mayflash
...
InputCommon/GCAdapter: Unbreak Mayflash GCAdapters by allowing libusb_control_transfer call to fail.
2020-07-11 11:56:30 -04:00
JosJuice
f7c32bc04e
RVZ: Fix split seed reads
...
This could cause read errors if chunks were laid out a certain
way in the file and the whole chunk wasn't being read at once.
Should fix https://bugs.dolphin-emu.org/issues/12184 .
2020-07-11 17:45:16 +02:00
Jordan Woyak
b350d3cca3
InputCommon/GCAdapter: Unbreak Mayflash GCAdapters by allowing libusb_control_transfer call to fail.
2020-07-09 17:17:44 -05:00
JosJuice
9c7704c0ac
DolphinQt: Attempt to fix ParallelProgressDialog constantly reopening
...
I believe the value returned by value() resets when we call
setValue() with the maximum (due to auto-reset). I have been
unable to test this because I can't reproduce the issue, which is
described at https://bugs.dolphin-emu.org/issues/12158#note-9 .
2020-07-09 15:45:29 +02:00
JosJuice
aeeb85aa3a
DolphinQt: Replace QTBUG-10561 workaround with better workaround
...
This workaround is not timing sensitive, unlike the old one.
Hopefully fixes https://bugs.dolphin-emu.org/issues/12158
and https://bugs.dolphin-emu.org/issues/12180 .
2020-07-08 20:29:26 +02:00
JosJuice
a23e14fe76
Android: Fix saving Horizonal Wii Remote overlay A/B/1/2 positions
...
saveControlPosition was not applying the _H part of the key.
2020-07-08 15:51:11 +02:00
JosJuice
f5da6e07d7
Android: Use correct encoding when converting strings
...
The functions with "UTF" in the name use "modified UTF-8" rather
than the standard UTF-8 which Dolphin uses, at least according
to Oracle's documentation, so it is incorrect for us to use them.
This change fixes the problem by converting between UTF-8 and
UTF-16 manually instead of letting JNI do it for us.
2020-07-08 14:52:05 +02:00
JosJuice
38791eec18
Common: Never convert from UCS-2 in WStringToUTF8
...
Probably not something we would run into in practice since
Windows uses a separate implementation, but let's do it
for the sake of correctness.
2020-07-08 14:51:35 +02:00
JosJuice
15d9fab0bb
Common: Rename UTF16ToUTF8
...
This function does *not* always convert from UTF-16. It converts
from UTF-16 on Windows and UTF-32 on other operating systems.
Also renaming UTF8ToUTF16 for consistency, even though it
technically doesn't have the same problem since it only was
implemented on Windows.
2020-07-08 14:51:35 +02:00
LC
87287181dd
Merge pull request #8907 from JosJuice/android-overlay-stick-gate
...
Android: Use octagonal stick gate in overlay
2020-07-08 08:50:47 -04:00
LC
a5166be995
Merge pull request #8896 from JosJuice/android-game-details-scroll
...
Android: Wrap game details dialog in ScrollView
2020-07-08 08:48:42 -04:00
LC
5a696f4934
Merge pull request #8906 from JosJuice/android-button-id-typo
...
Android: Fix button ID typo
2020-07-08 08:47:33 -04:00
LC
4c50eadf34
Merge pull request #8908 from jordan-woyak/wiimote-battery-hax
...
WiimoteCommon: Tweak battery level math.
2020-07-08 08:46:58 -04:00
LC
b9ae7c350e
Merge pull request #8926 from JosJuice/sysconf-sound
...
DolphinQt: Expose SYSCONF sound setting
2020-07-08 08:41:23 -04:00
LC
0bff77d9e4
Merge pull request #8925 from JosJuice/tas-turbo-interval
...
DolphinQt: Allow customizing TAS input turbo interval
2020-07-08 08:40:46 -04:00
LC
25118e2acc
Merge pull request #8928 from Ebola16/ADSL
...
Android: Update "Speed Limit" for "Unlimited" value
2020-07-08 08:39:44 -04:00
LC
a1195fbf91
Merge pull request #8933 from jordan-woyak/gcadapter-nyko
...
InputCommon/GCAdapter: Fix offbrand "GCAdapters".
2020-07-08 08:38:52 -04:00
LC
cd51552fe4
Merge pull request #8939 from JosJuice/oops
...
Android: Convert some files to LF
2020-07-08 08:35:09 -04:00
JosJuice
6f298378a1
Reword "Please avoid forcing Dolphin to use MSAA by the driver" message
...
Some users who get this error don't seem to gain much understanding
of how to resolve the problem from reading the error message.
2020-07-08 11:34:36 +02:00
Jordan Woyak
f2fd5c7f90
InputCommon/GCAdapter: Fix offbrand "GCAdapters" with a libusb_control_transfer call.
2020-07-07 14:45:19 -05:00
JosJuice
c89828b22e
Android: Convert some files to LF
...
I wonder why lint didn't catch this...
2020-07-06 17:04:58 +02:00
JosJuice
327b985718
DVDInterface: Increase the latency for read commands
...
Hardware tested using cached reads.
Fixes Ed, Edd n Eddy. https://bugs.dolphin-emu.org/issues/10373
2020-07-05 18:57:39 +02:00
JosJuice
7a45ca0334
DolphinQt: Mark Zstandard as recommended for RVZ
2020-07-05 12:52:59 +02:00
JosJuice
74f74ac928
DiscIO: Use Volume::IsDatelDisc in VolumeVerifier
...
I forgot to do this in the PR where I added Volume::IsDatelDisc.
2020-07-04 20:24:26 +02:00
Tilka
4f98653ec6
Merge pull request #8930 from JosJuice/datel-scrub-ignored
...
DolphinQt: Fix scrubbing not being disabled for Datel discs
2020-07-04 14:49:34 +01:00
Tilka
c5a3882617
Merge pull request #8929 from JosJuice/datel-covers
...
DiscIO: Fix downloading covers for non-GNHE5d Datel discs
2020-07-04 14:07:46 +01:00
JosJuice
5360ec80c8
DolphinQt: Fix scrubbing not being disabled for Datel discs
...
The code for disabling scrubbing for RVZ was overriding the code
for disabling scrubbing for Datel discs.
2020-07-04 15:06:05 +02:00
JosJuice
fb922781e7
RedumpVerifier: Treat Datel game IDs as empty
...
Replacement for the reverted commit
f9705fd117
.
2020-07-04 15:00:02 +02:00