a92003c1ab
ARM64: Make getters within ArithOption const.
2014-09-12 20:55:26 -04:00
eae38fd339
ConfigManager.cpp: Removed three elements from platform-ifdef
2014-09-12 17:15:46 -07:00
edd63c14a4
CBoot: Use vectors instead of raw pointers in ELF functions.
2014-09-12 12:03:06 -04:00
322f033c97
DolphinWX: Get rid of fallthrough in ScanForISOs
2014-09-12 11:52:36 -04:00
4db2af2d42
DiscIO: Remove unnecessary break statements.
2014-09-12 11:34:34 -04:00
e883a6fb2e
Fix all the current issues with the AArch64 register cache.
...
Fixes all the current issues I've been experiencing.
Scaled back the register cache idea for now so I can actually work on some real instructions.
Tested this work with unit tests so I know it works.
Unit tests are pretty great things.
2014-09-12 06:39:15 -05:00
17d31ecd6c
Fix AArch64 MOVI2R helper function.
...
In the case of a zero immediate, it wouldn't generate code at all.
Also in the case of max u32/u64, use ORN to optimize it.
2014-09-12 05:45:10 -05:00
a6c9515b00
JIT: unify subfcx and addcx code
...
Again, shorter and should make future optimizations easier.
2014-09-12 00:04:42 -07:00
5d80145dc0
JIT: unify subfe/submex/subfex/adde/addmex/addzex code
...
Shorter, plus should make future optimizations easier.
2014-09-12 00:04:42 -07:00
64b21a4812
Merge pull request #1054 from comex/i-hate-warnings
...
Fix warnings.
2014-09-12 12:35:47 +10:00
d6ef8dc8c6
Merge pull request #1052 from Sonicadvance1/fix-ppcAnalyst-return
...
Fix the return value of PPCAnalyst.
2014-09-11 21:12:38 -05:00
5061a33c29
Merge pull request #1051 from Sonicadvance1/ARM-Common
...
Include a missing include in the ARM emitter's common code.
2014-09-11 21:12:21 -05:00
4cb25633e1
Merge pull request #1048 from lioncash/discio
...
DiscIO: Minor changes to VolumeDirectory.
2014-09-12 11:31:29 +10:00
669a118063
Merge pull request #1058 from lioncash/semicolon
...
Remove some unnecessary semicolons
2014-09-11 19:56:08 -04:00
a96618b2e6
Merge pull request #1036 from phire/save-jitil
...
Save JitIL! Fix bug so JitIL actually runs again.
2014-09-11 23:27:59 +02:00
428ee10463
include CommonTypes.h instead of Common.h, remove unused using.
2014-09-11 17:23:59 -04:00
9f82df0364
Move "using namespace ArmGen" from headers to sources.
2014-09-11 16:46:43 -04:00
18d83a310e
X64Emitter: support shorter mov reg, imm opcodes
...
Also refactor WriteNormalOp a little bit and add comments.
2014-09-11 11:40:30 -07:00
b06ec302d1
Remove some unnecessary semicolons
2014-09-11 13:05:31 -04:00
784d3937dd
Fix IsMMIOAddress Check.
2014-09-11 19:12:34 +12:00
42acd61ccb
Fix warnings.
2014-09-11 01:55:43 -04:00
5726e0cdfb
JIT: use XCHG in MOVTwo
...
Roughly the same speed or slightly faster depending on CPU; mostly just cleaner
since we don't have to pass in a temp.
2014-09-10 22:17:38 -07:00
b8d4834cb1
Fix the return value of PPCAnalyst.
...
In situations where conditional continue isn't supported + if a JIT doesn't implement a instruction that has the FL_ENDBLOCK flag. This would cause an
infinite loop.
In reality all the JITs should implement every FL_ENDBLOCK instruction regardless, but JITIL doesn't implement tw/twi which are FL_ENDBLOCK
instructions.
2014-09-10 21:33:17 -05:00
67f7e7e28b
Merge pull request #1040 from RachelBryk/movie-cleanup
...
Movie cleanup
2014-09-11 11:47:55 +10:00
44baab30cf
Include a missing include in the ARM emitter's common code.
2014-09-10 20:39:19 -05:00
581c81ce1c
Merge pull request #1050 from Sonicadvance1/AArch64-sign-extend
...
Add sign extending aliases to the ARM64Emitter.
2014-09-10 20:17:50 -05:00
24f6c98a55
Add sign extending aliases to the ARM64Emitter.
2014-09-10 17:52:54 -05:00
c0f7cab3f5
Remove extra semicolons at the ends of some lines.
2014-09-10 12:17:38 -04:00
71cb09f1ca
Merge pull request #1027 from rohit-n/change-include
...
Include CommonTypes.h instead of Common.h.
2014-09-10 00:35:16 -05:00
08db8c646b
Cleanup Movie.h/cpp.
2014-09-09 21:23:54 -04:00
571727a5ad
Mass rename static variables to s_*.
2014-09-09 21:22:32 -04:00
b3a57ff396
JIT: remove op merging code that served no purpose
...
Dolphin already tracks propagation of immediates, so this code didn't really do
anything useful.
2014-09-09 18:09:23 -07:00
d1439bc1db
Merge pull request #1041 from RachelBryk/kill-g_CoreStartupParameter
...
Kill Core::g_CoreStartupParameter.
2014-09-10 11:00:42 +10:00
16f054db47
Merge pull request #1033 from Sonicadvance1/fix-android-x86_64
...
Fix building x86_64 on Android.
2014-09-09 18:52:27 -05:00
9601f5ec5f
DiscIO: Get rid of some casts and a c_str call in VolumeDirectory
2014-09-09 19:01:20 -04:00
b34f2a78f5
DiscIO: Simplify GetUniqueID in VolumeDirectory
2014-09-09 18:57:45 -04:00
09c1ad1631
Merge pull request #753 from FioraAeterna/integeropts
...
JIT64: various integer optimizations
2014-09-09 04:10:30 -05:00
6a7e8899d3
Merge pull request #1035 from FioraAeterna/fixcrxxx
...
JIT: fix a corner case in crXXX
2014-09-09 00:58:53 -05:00
e8d8713e03
Merge pull request #1017 from zhuowei/tw_fallback_if_constant_ra
...
Fix various issues with the twi/tw instructions
2014-09-09 15:16:25 +10:00
3a205d663c
Fix building x86_64 on Android.
...
Missed a define in x64MemTools for when the thought process was Android == ARM
Also changes the variable we use for choosing which folders to copy to and from our jni file.
This has changed since the x86_64 build target uses the library folder x86-64, which is stupid and annoying.
2014-09-09 00:11:08 -05:00
f09cb723c5
Merge pull request #1044 from lioncash/pedantry
...
Common: Fix code styling in Arm64Emitter
2014-09-08 23:29:19 -05:00
f93aa7087c
Kill Core::g_CoreStartupParameter.
2014-09-09 00:24:49 -04:00
44c4bc134a
Merge pull request #1046 from FioraAeterna/fixdebug
...
JIT: fix running in debug mode
2014-09-09 14:15:35 +10:00
0af1352020
JIT: fix running in debug mode
...
Regression in 7fb6628
2014-09-08 21:11:41 -07:00
d9ddc0d9ad
Merge pull request #1042 from lioncash/unnecessary
...
InputCommon: Remove unnecessary breaks in XInput's GetName function
2014-09-08 22:46:58 -05:00
af732dea39
Merge pull request #1043 from lioncash/unused
...
Common: Remove unused variable in MemoryMap_Setup
2014-09-08 22:46:04 -05:00
cfb2c3db28
Merge pull request #1045 from Sonicadvance1/fix-generic
...
Fix Generic build from AArch64 merge.
2014-09-08 22:43:30 -05:00
d5da60619e
Merge pull request #1034 from Sonicadvance1/fix-android-arm-ndk64bit
...
Fix building ARMv7 on the 64bit Android NDK.
2014-09-08 22:42:31 -05:00
bc331ee809
Common: Fix code styling in Arm64Emitter
2014-09-08 23:39:20 -04:00
ed476c997c
Fix Generic build from AArch64 merge.
...
I had missed this file and hadn't tested the branch on my new build system.
2014-09-08 22:24:23 -05:00
8fc57d61ba
JIT64: support merged branching for rlwinmx, too
...
Not quite as common a branch instruction as cmpwi, but close.
2014-09-08 20:16:41 -07:00
b56117de05
JIT64: optimize some special cases of srawix
...
Shift by 31 and 1, both of which are pretty common, can be done in a few less
instructions. Tested with a hwtest.
2014-09-08 20:15:49 -07:00
a95d8cbcb4
JIT64: optimize carry handling
...
Carries are rather common and unpredictable, so do them branchlessly wherever
we can.
2014-09-08 20:15:49 -07:00
a570c6b4a4
JIT64: tweak srwx/slwx BindToRegister arguments
...
Register B gets immediately moved into the shift register, so even if a == b
it doesn't need to be loaded.
2014-09-08 20:15:49 -07:00
5b77617069
JIT64: use LEA for the "a = b + imm" case of addi
2014-09-08 20:15:48 -07:00
9977da0550
JIT64: avoid using LEA for adds when not necessary
2014-09-08 20:15:48 -07:00
298f85e152
JIT64: optimize sign-extend
...
Remove some code duplication.
Also remove some comments that no longer apply since x86_32 was dropped.
2014-09-08 20:15:47 -07:00
faf6bdfd96
JIT64: Optimize cmpXX
...
Use TEST instead of CMP if we're comparing against 0 (rather common), and
optimize the case of immediate compares further.
2014-09-08 20:15:47 -07:00
de662a79b7
JIT64: optimize rlwinmx/rlwinix and friends
...
Take advantage of movzx as a replacement for anding with 0xff or 0xffff, and
abuse loads from the register cache to save ops.
2014-09-08 20:15:46 -07:00
858296e1c7
JIT64: optimize multiplication by immediate constants
...
Factor out common code and handle a few more common cases.
2014-09-08 20:15:46 -07:00
94c20db369
Rename Log2 and add IsPow2 to MathUtils for future use
...
Also remove unused pow2/pow2f functions.
2014-09-08 20:15:45 -07:00
0926f1d344
Merge pull request #897 from Sonicadvance1/AArch64-jit
...
Initial AArch64 JIT
2014-09-09 12:34:58 +10:00
22800dc711
Common: Remove unused variable in MemoryMap_Setup
2014-09-08 21:44:03 -04:00
c2578d0668
InputCommon: Remove unnecessary breaks in XInput's GetName function
2014-09-08 21:36:04 -04:00
859f86ac2d
Merge pull request #1037 from lioncash/mem_fn
...
AudioCommon: Remove unnecessary usages of mem_fn
2014-09-08 18:01:33 -05:00
fbc64984ca
Include CommonTypes.h instead of Common.h.
2014-09-08 15:39:58 -04:00
bf0c4a644b
Merge pull request #1002 from waddlesplash/wx-fixup
...
WiiSaveCrypted: migrate to Core/HW.
2014-09-08 15:20:12 -04:00
789a500ddc
AudioCommon: Remove unnecessary usages of mem_fn
2014-09-08 13:41:02 -04:00
e601b6f2c5
WiiSaveCrypted: migrate to Core/HW.
...
There's really no reason to have this in DolphinWX, as it does
not use any DolphinWX code.
2014-09-08 13:31:23 -04:00
1bbc7b4dbb
JitIL: Fix matching bug in Store Paired.
...
Most non-wii, non-mmu games run now.
2014-09-08 23:57:00 +12:00
199377db43
Fix bug in Load Paired so JitIL actually runs again.
...
Was broken in the PowerPCState Register PR a few days ago.
2014-09-08 23:25:18 +12:00
ce494a5e4f
JIT: fix a corner case in crXXX
...
It didn't behave correctly with an input of zero, resulting in some games
breaking (at the least, Fight Night 2). This should be fixed now.
Also clean it up, add a few comments, and fix some variants of the instruction
that are so rare that they probably never got tested.
2014-09-08 04:16:50 -07:00
652b8602d3
Fix building ARMv7 on the 64bit Android NDK.
...
Google has gotten their act together and fixes a few of the signal handling headers.
Change over to a header that works on both r10 32bit and r10 64bit.
32bit has the old "broken" headers as in some didn't even exist.
64bit has the "fixed" headers that one would expect on any regular unix system.
2014-09-08 06:05:03 -05:00
9529667eae
Merge pull request #1032 from FioraAeterna/fixnocc
...
JIT: fix conditional-continue=off
2014-09-08 17:34:28 +10:00
3855396422
JIT: fix conditional-continue=off
2014-09-08 00:28:56 -07:00
d3a742eb38
Merge pull request #1028 from Sonicadvance1/fix-android-cmake
...
Fix a few minor bugs that appeared in the latest android cmake script
2014-09-08 02:28:21 -05:00
dae162c2b5
Merge pull request #971 from TurboK234/EFB_copies_togglefix
...
Remove "EFB Copies Disabled" option from hotkey toggling cycle.
2014-09-08 17:05:52 +10:00
7fb6628789
Merge pull request #1024 from comex/abi-cleanup
...
ABI cleanup
2014-09-08 01:03:36 -04:00
4dc090643d
Remove ABI_AlignStack/ABI_RestoreStack and the noProlog option to ABI_CallFunctionRR.
...
The latter being true was the only case where the former would do
anything, and it was never true. They became obsolete with x86's
removal.
2014-09-08 01:00:10 -04:00
c5c0b36046
Remove the inaccurately named ABI_PushAllCalleeSavedRegsAndAdjustStack (it didn't preserve FPRs!) and replace with ABI_PushRegistersAndAdjustStack.
...
To avoid FPRs being pushed unnecessarily, I checked the uses: DSPEmitter
doesn't use FPRs, and VertexLoader doesn't use anything but RAX, so I
specified the register list accordingly. The regular JIT, however, does
use FPRs, and as far as I can tell, it was incorrect not to save them in
the outer routine. Since the dispatcher loop is only exited when
pausing or stopping, this should have no noticeable performance impact.
2014-09-08 01:00:10 -04:00
2dafbfb3ef
Improve code and clarify parameters to ABI_Push/PopRegistersAndAdjustStack.
...
- Factor common work into a helper function.
- Replace confusingly named "noProlog" with "rsp_alignment". Now that
x86 is not supported, we can just specify it explicitly as 8 for
clarity.
- Add the option to include more frame size, which I'll need later.
- Revert a change by magumagu in March which replaced MOVAPD with MOVUPD
on account of 32-bit Windows, since it's no longer supported. True,
apparently recent processors don't execute the former any faster if the
pointer is, in fact, aligned, but there's no point using MOVUPD for
something that's guaranteed to be aligned...
(I discovered that GenFrsqrte and GenFres were incorrectly passing false
to noProlog - they were, in fact, functions without prologs, the
original meaning of the parameter - which caused the previous change to
break. This is now fixed.)
2014-09-08 00:58:56 -04:00
707d21e36b
Fix a few minor bugs that appeared in the latest android cmake script
2014-09-07 23:18:43 -05:00
262fa1de02
Merge pull request #1026 from lioncash/str
...
DolphinWX: Use std::string over char arrays in MemoryView
2014-09-08 10:40:16 +10:00
9db370ea40
DolphinWX: Use std::string over char arrays in MemoryView
2014-09-07 20:36:02 -04:00
c70f31cca9
Merge pull request #1016 from lioncash/vardecl
...
Common: Inline declare some loop variables in ArmEmitter
2014-09-08 10:24:38 +10:00
e63f7c01a3
Fix twi/tw instructions being switched in Jit64 and JitArm; downgrade the ERROR_LOG printed when tw is ran in the interpreter to DEBUG
2014-09-07 13:35:18 -04:00
b70c0ae521
for tw/twi instructions, force propagated constant into a register to avoid "a1 cannot be immediate" errors from the emitter
2014-09-07 11:31:51 -04:00
e218c38721
DolphinWX: Remove unnecessary unique_ptr get calls in InputConfigDiag
2014-09-07 01:59:56 -04:00
a38093729e
Common: Inline declare some loop variables in ArmEmitter
2014-09-07 00:26:26 -04:00
7863295555
Used a constant for the default high value.
2014-09-07 14:25:06 +10:00
8abe9622fd
Route the wiimote speaker to the sound mixer (the host system's speakers). Emulated Wiimote speaker sounds will go to the host system's speakers. Real Wiimotes will continue to use their own speaker for Wiimote speaker sounds. All Wiimote speaker sound can be disabled by unchecking the "Enable Speaker Data" option.
...
Each emulated Wiimote can have its speaker routed from left to right via the "Speaker Pan" setting in the emulated wiimote settings dialog. Use any value from -127 for leftmost to 127 for rightmost with 0 being the centre.
Added code in the InputConfig to use a spin control for non-boolean values.
Defaulted the setting of "Enable Speaker Data" to disabled.
2014-09-07 14:16:20 +10:00
3caab10df8
Hooked up the emulated Wiimote speaker.
...
The Wiimotes are positioned as follows:
Wiimote 0 = Center
Wiimote 1 = Left
Wiimote 2 = Right
Wiimote 3 = Center
The Wiimote speaker output can be disabled via the "Enable Speaker Data" checkbox in the Wiimote settings.
2014-09-07 14:16:20 +10:00
b801c7f8f1
Merge pull request #1015 from zhuowei/update_debugger_menu_at_startup
...
Update debugger button states at startup to disable non-functional JIT menu items
2014-09-07 14:14:11 +10:00
a21ad12f1e
Merge pull request #1014 from RachelBryk/active-movie
...
Add an IsMovieActive function.
2014-09-07 14:05:59 +10:00
5a163ec5e6
Add an IsMovieActive function.
...
Makes things a bit simpler, since this is a common check.
2014-09-06 23:44:25 -04:00
741c0e2d50
Merge pull request #587 from RachelBryk/recording-race
...
Don't allow starting recording in states that will cause a crash or othe...
2014-09-07 13:41:57 +10:00
e0a909c076
Update debugger button states at startup to disable non-functional JIT menu entries
2014-09-06 23:38:22 -04:00
213c9a6ba7
Merge pull request #1011 from zhuowei/remove_twi_spam
...
Downgrade the ERROR log printed when twi is executed in interpreter to DEBUG
2014-09-07 13:33:31 +10:00
28253f4538
Merge pull request #1013 from lioncash/string
...
AudioCommon: Use std::string for the filename parameter of StartLogAudio
2014-09-07 13:32:55 +10:00
daddc3317e
AudioCommon: Use std::string for the filename parameter of StartLogAudio
2014-09-06 23:26:08 -04:00
2ac2cbbcf6
Downgrade the ERROR log printed when twi is executed in interpreter to DEBUG
2014-09-06 22:36:17 -04:00
cdd2bd6cdc
Add a couple of asserts to the Arm64 JIT to make sure we can load everything.
2014-09-06 20:14:53 -05:00
82dae72b63
Add AArch64 target to the backpatch header.
...
This fixes the issue of a million warnings spawning from this header.
2014-09-06 20:14:53 -05:00
5233c87dec
Add immediate support to the GPR cache.
2014-09-06 20:14:53 -05:00
2b06257e16
Beginning of the AArch64 JIT branch.
...
This is the bare minimum required to run a few games on AArch64.
Was able to run starfield and Animal Crossing to the Nintendo logo.
QEmu emulation is literally the slowest thing in the world, it maxes out at around 12mhz on my Core i7-4930MX.
2014-09-06 20:14:52 -05:00
f107b5e176
[AArch64-emitter] Initial work on a emitter for 64bit ARM.
...
I've tested a few instruction encodings and am expecting most to work as long as one stays away from VFP/SIMD.
This implements mostly instructions to bring up an initial JIT with integer support.
This can be improved to allow ease of use functions in the future, dealing with the raw imms/immr encodings is probably the worst thing ever.
2014-09-06 20:13:44 -05:00
9a9fd8752a
Quiet initialization order warning in CFrame
2014-09-06 13:01:24 -07:00
9302218a19
Merge pull request #851 from lioncash/logg
...
Common: Kill off duplicate log warning definitions
2014-09-06 12:35:19 -07:00
01b90c1007
Fix ArmEmitter's asserts from failing to compile.
...
Changed them all from debug asserts to regular asserts, since they shouldn't only be run at debug time.
2014-09-06 15:11:39 -04:00
690ed8580c
Common: Kill off duplicate log warning definitions
...
Also embed the log checks rather than using macros
2014-09-06 15:11:29 -04:00
85fd8c2bec
Merge pull request #983 from lioncash/lol-str
...
Common: Fix a potential infinite loop in ReplaceAll
2014-09-06 12:00:23 -07:00
227b79bf84
Merge pull request #1004 from comex/warning-fixes-2
...
Two trivial warning fixes
2014-09-06 11:56:32 -07:00
1b23432d34
Merge pull request #990 from rohit-n/fix-formatting
...
Fix formatting
2014-09-06 11:54:17 -07:00
218adb5515
Merge pull request #1003 from lioncash/wii-save-import
...
DolphinWX: Fix Wii save importing
2014-09-06 11:52:33 -07:00
d0d6f70980
Merge pull request #996 from RachelBryk/clear-mc-bongos
...
Clear movie variables that might have been set from a previous run.
2014-09-06 11:46:21 -07:00
f2237ecd64
Merge pull request #985 from skidau/dsp-loop-hle
...
Moved the loop check back to a post-loop condition in DSP HLE AX ucode.
2014-09-06 11:44:27 -07:00
87b6c8d991
Merge pull request #988 from shuffle2/hide-menubar
...
Fix render to main crashing in fullscreen.
2014-09-06 11:43:50 -07:00
30e577fda7
Revert "Merge pull request #993 from phire/fix_getOpInfo"
...
This reverts commit a8f724e7c27a1eca149f
2014-09-06 13:46:17 -04:00
48ef6fcad1
Fix signed/unsigned warning in GeckoCode.cpp.
...
No actual bug here.
2014-09-06 13:34:00 -04:00
917c6d324a
Remove unused functions in TextureDecoder.
2014-09-06 13:32:54 -04:00
6c382f6627
Merge pull request #926 from comex/ppcstate-reg
...
PowerPCState register (and rationalize register usage, and add some registers to replace it)
2014-09-06 13:24:38 -04:00
6fd0333c14
Symbolicize explicit uses of x86 registers where possible (GPRs only for now).
...
Uses are split into three categories:
- Arbitrary (except for size savings) - constants like RSCRATCH are
used.
- ABI (i.e. RAX as return value) - ABI_RETURN is used.
- Fixed by architecture (RCX shifts, RDX/RAX for some instructions) -
explicit register is kept.
In theory this allows the assignments to be modified easily. I verified
that I was able to run Melee with all the registers changed, although
there may be issues if RSCRATCH[2] and ABI_PARAM{1,2} conflict.
2014-09-06 13:18:31 -04:00
100a7ac97b
Actually add RCX, plus RDI and RSI on Unix.
...
And switch to a register order that consistently prefers callee-save to
caller-save. phire suggested putting rdi/rsi first, even though they're
caller-save, to save code space; this is more conservative and I can do
that later.
2014-09-06 13:16:21 -04:00
8dea26762d
Rationalize temporary register usage.
...
Rather than using a variety of registers including RSI, ABI_PARAM1
(either RCX or RDI), RCX, and RDX, the rule is:
- RDI and RSI are never used. This allows them to be allocated on Unix,
bringing parity with Windows.
- RDX is a permanent temporary register along with RAX (and is thus not
FlushLocked). It's used frequently enough that allocating it would
probably be a bad idea, as it would constantly get flushed.
- RCX is allocatable, but is flushed in two situations:
- Non-immediate shifts (rlwnm), because x86 requires RCX to be used.
- Paired single loads and stores, because they require three
temporary registers: the helper functions take two integer
arguments, and another register is used as an index to get the
function address.
These should be relatively rare.
While we're at it, in stores, use the registers directly where possible
rather than always using temporaries (by making SafeWriteRegToReg
clobber less). The address doesn't need to be clobbered in the usual
case, and on CPUs with MOVBE, neither does the value.
Oh, and get rid of a useless MEMCHECK.
This commit does not actually add new registers to the allocation order;
it is intended to test for any performance or correctness issues
separately.
2014-09-06 13:16:20 -04:00
67cdb6e07a
Factor code from ABI_CallFunctionRR and GetWriteTrampoline into a helper, and fix a special case.
...
The special case is where the registers are actually to be swapped (i.e.
func(ABI_PARAM2, ABI_PARAM1); this was previously impossible but would
be ugly not to handle anyway.
2014-09-06 13:16:20 -04:00
487eb967eb
Fix a bug with update loads in memcheck mode.
...
In two cases, my old code was using a temporary register but not saving
it properly; it basically worked by accident (an otherwise useless
FlushLock was causing CallerSavedRegistersInUse to think it was in use
by the GPR cache, even though it was actually a temporary).
I'm going to modify this in the next commit to use RDX, but I didn't
want to leave a broken revision in the middle.
2014-09-06 13:16:20 -04:00
48891c6359
Reserve a register for ppcState.
...
The register is RBP, previously in the GPR allocation order. The next
commit will investigate whether there are too few GPRs (now or before),
but for now there is no replacement.
Previously, it was accessed RIP relatively; using RBP, anything in the
first 0x100 bytes of ppcState (including all the GPRs) can be accessed
with three fewer bytes. Code to access ppcState is generated constantly
(mostly by register save/load), so in principle, this should improve
instruction cache footprint significantly. It seems that this makes a
significant performance difference in practice.
The vast majority of this commit is mechanically replacing
M(&PowerPC::ppcState.x) with a new macro PPCSTATE(x).
Version 2: gets most of the cases which were using the register access
macros.
2014-09-06 13:16:18 -04:00
5b837a11e4
DolphinWX: Fix Wii save importing
...
Calls to reserve don't resize the array to accomodate the given data size.
These vectors should be initialized with the size directly.
2014-09-06 12:44:11 -04:00
d75bb614e7
Merge pull request #998 from waddlesplash/wx-fixup
...
Migrate PNGs from DolphinWX to the Data/Resources directory.
2014-09-06 18:07:20 +02:00
06bdc49957
Merge pull request #999 from lioncash/copy-assign
...
AudioCommon: Make WaveFileWriter inherit NonCopyable
2014-09-06 17:52:11 +02:00
2333532aab
Merge pull request #1000 from lioncash/preproc
...
Common: Remove HAVE_CXX11_SYNTAX define from Common.h
2014-09-06 17:50:15 +02:00
a15d9ed0b6
Migrate PNGs from DolphinWX to the Data/Sys/Resources directory.
...
* Aren't used by anything (yet) as DolphinWX compiles XPM versions into the build
* Moved the .desktop file as well, adjusted INSTALL rule accordingly
2014-09-06 11:47:21 -04:00
1d66b1d3f4
Common: Remove HAVE_CXX11_SYNTAX define from Common.h
...
All the compilers we support have C++11 support now, so this isn't needed.
2014-09-06 11:32:19 -04:00
27cecf46a8
AudioCommon: Make WaveFileWriter inherit NonCopyable
2014-09-06 11:27:36 -04:00
629ceaf2b1
Split some parts of UpdateBoundingBox into multiple lines. Also,
...
fix issues causing failure on Lint.
2014-09-06 09:49:27 -05:00
2a82b591e1
Clear movie variables that might have been set from a previous run.
2014-09-06 07:10:41 -04:00
a8f724e7c2
Merge pull request #993 from phire/fix_getOpInfo
...
GetOpInfo: Assert on all invalid Ops.
2014-09-06 19:50:15 +10:00
23b54117cd
GetOpInfo: Assert on all invalid Ops.
...
GetOpInfo was returning null pointers for invalid ops in subtables
instead of asserting an error. This was causing segfaults when the
jit tried to jit invalid code.
2014-09-06 20:09:30 +12:00
e035ac5591
Merge pull request #992 from phire/betterassert
...
Make Invalid instruction debug assert a non-debug assert.
2014-09-06 03:12:19 -04:00
50657548b1
Make Invalid instruction debug assert a non-debug assert.
...
Users need to be able to see this error message. Otherwise they can't
report bugs.
2014-09-06 19:04:34 +12:00
1ecb318bcc
Fix some formatting (new lines on collapsed single-line conditionals,
...
new lines for opening braces).
2014-09-06 01:23:05 -05:00
b7f19ca740
Merge pull request #989 from lioncash/param
...
AudioCommon: Remove unused parameter from OpenSLESStream constructor
2014-09-06 01:15:59 -05:00
cc9e881844
Merge pull request #987 from rohit-n/more-dead-code
...
Remove more dead and redundant code.
2014-09-06 01:15:20 -05:00
019ef844d4
AudioCommon: Remove unused parameter from OpenSLESStream constructor
2014-09-06 01:42:56 -04:00
a831121683
Merge pull request #979 from shuffle2/fix-memcard-flush3
...
raw memcards: revert last change so flushes are still time-driven.
2014-09-05 22:27:12 -07:00
7308b809d8
Fix render to main crashing in fullscreen.
...
When hiding the menubar (for going fullscreen with render to main),
keep a functionally-duplicate menubar around for servicing menubar
actions.
2014-09-05 22:21:09 -07:00
debe3999b5
Remove more dead and redundant code.
2014-09-05 23:22:48 -05:00
96d7b642f4
raw memcards: revert last change so flushes are still time-driven.
...
It turns out the actual slowdown was from memcpy'ing the entire
memcard buffer...not synchronization overhead or the flush itself.
2014-09-05 21:16:59 -07:00
9800252a28
Re-added the acc_end_reached logic for AXWii.
2014-09-06 11:57:37 +10:00
387e1e3f21
Merge pull request #984 from FioraAeterna/fixmergedbclr
...
JIT: fix branch merging with bclr
2014-09-06 03:22:08 +02:00
0154b8edfd
Moved the loop check back to a post-loop condition in DSP HLE AX ucode. This brings DSP HLE in line with DSP LLE and fixes issue 7627. This effectively reverts ef501137be which is not needed as the loop check is now corrected.
2014-09-06 11:02:32 +10:00
4ec8f83a1a
JIT: fix branch merging with bclr
2014-09-05 13:58:06 -07:00
3e0c04a83e
Common: Fix a potential infinite loop in ReplaceAll
...
Prior to this change, it was possible to cause an infinite loop by making the string to be replaced and the replacing string the same thing.
e.g.
std::string some_str = "test";
ReplaceAll(some_str, "test", "test");
This also changes the replacing in a way that doesn't require starting from the beginning of the string on each replacement iteration.
2014-09-05 15:12:17 -04:00
674494e472
Merge pull request #980 from rohit-n/remove-dead-code
...
Remove dead code.
2014-09-05 11:09:04 -07:00
0576046fdd
Merge pull request #972 from Sonicadvance1/fix-intel-windows
...
Work around Intel's failings with buffer_storage
2014-09-05 11:06:49 -07:00
801153301f
Remove debug printf from earlier commit
2014-09-05 10:31:29 -07:00
07e0c917c6
Revert "JIT64: optimize CA calculations"
2014-09-05 10:26:30 -07:00
cf8d1c9197
FileHandlerARC: Remove FileHandlerARC.
2014-09-05 12:53:41 -04:00
a3d9b22c27
BannerLoaderWii: Removed #if 0'd code.
2014-09-05 12:52:29 -04:00
97420c6ec6
Merge pull request #852 from FioraAeterna/optimizeca
...
JIT64: optimize CA calculations
2014-09-05 11:52:02 -04:00
aa1df21bb6
Merge pull request #947 from FioraAeterna/rsqrte
...
JIT: implement frsqte
2014-09-05 11:48:00 -04:00
e7f03dd066
Merge pull request #948 from comex/vao-fix
...
Don't switch to a vertex array object of 0.
2014-09-05 11:46:28 -04:00
d4b1d42a21
Merge pull request #975 from FioraAeterna/jittimerinline
...
JIT: completely inline timer reading
2014-09-05 11:45:22 -04:00
3d88dfbad9
Merge pull request #701 from LPFaint99/memcard
...
GCI Folder: try to reserve space for new saves from the current game
2014-09-04 23:02:23 -07:00
ee450acb54
Merge pull request #973 from rohitnirmal/remove-using-namespace
...
Controller Interface: Remove "using namespace" in header file.
2014-09-04 22:58:22 -07:00
30fef298bb
Revert "Don't sleep in the event thread"
2014-09-05 00:50:40 -05:00
2f9e9bf1fc
JIT: completely inline timer reading
...
Should be a bit faster on games that heavily use the timer.
2014-09-04 21:55:36 -07:00
b0060e5184
Controller Interface: Remove "using namespace" in header file.
2014-09-04 23:02:25 -05:00
e6e50ee621
GCI Folder: try to leave 10% of the blocks free. only applies if the save is not for the current game
2014-09-04 20:59:38 -07:00
a9a6270982
Merge pull request #774 from magcius/texdecode-cleanup
...
Clean up the TextureDecoder and some related things
2014-09-04 19:37:49 -07:00
fb3a668767
Merge pull request #974 from lioncash/wiki-links
...
DolphinWX: Simplify wiki link construction
2014-09-04 19:35:28 -07:00
9c41b17b41
Merge pull request #945 from MikeRavenelle/inputConfig
...
Edit Auto iterate through configuration inputs with toggle
2014-09-04 19:34:01 -07:00
f09978ddeb
Merge pull request #896 from magcius/event-thread-bozo
...
Don't sleep in the event thread
2014-09-04 19:33:49 -07:00
76b4dbdf28
TextureDecoder: Clean up the code style
...
For a long time, we've had ugly and inconsistent function names here as
helpers, names like "decodebytesRGB5A3rgba" which are absolutely
incomprehensible to understand. Fix this by introducing a new consistent
naming scheme, where the above function now becomes "DecodeBytes_RGB5A3".
2014-09-04 18:36:57 -07:00
0b7bed4a52
TextureDecoder: Simplify how the reference texture decoder works
...
Instead of having three separate functions and checking the tlutfmt in a
variety of places, just do it once in a helper method. This is already
for the slow path either in our Generic decoder or in our Software
renderer, so it doesn't matter that this is slower.
x64 will continue using the separate functions for speed.
2014-09-04 18:36:57 -07:00
ea1245d191
TextureDecoder: Pass the TLUT address straight into the texture decoder
...
This removes the requirement for the TextureDecoder to have access to
global texture memory.
2014-09-04 18:36:57 -07:00
fcd4ecc942
TextureDecoder: Add an enum for the TLUT formats
...
Quick code cleanup. The enum names and values come from libogc.
2014-09-04 18:36:56 -07:00
32da01edec
TextureDecoder: Rearrange header slightly
...
Put the two Decode APIs together.
2014-09-04 18:36:56 -07:00
f975307016
TextureDecoder: Add some statics to some of our helper functions
...
I know these are already inline, but this makes it more clear that
they're helper functions to be used in this file only.
2014-09-04 18:36:56 -07:00
a8e591dc73
VideoCommon: Remove support for decoding to ARGB textures
...
The D3D / OGL backends only ever used RGBA textures, and the Software
backend uses its own custom code for sampling. The ARGB path seems to
just be dead code.
Since ARGB and RGBA formats are similar, I don't think this will make
the code more difficult to read or unable to be used as
reference. Somebody who wants to use this code to output ARGB can simply
modify the MakeRGBA function to put the shift at the other end.
2014-09-04 18:36:56 -07:00
9438a30384
VideoCommon: Start putting common texture decoding code in TextureDecoder_Common
...
This pulls all the duplicate code from TextureDecoder_Generic /
TextureDecoder_x64 out and puts it in a common file. Out custom font
used for debugging the texture cache is also pulled out and put in a
common "sfont.inc" file. At some point we should also combine this font
with the other six binary fonts we ship.
2014-09-04 18:36:53 -07:00
6369173981
DolphinWX: Simplify wiki link construction
2014-09-04 21:30:33 -04:00
73fc45db68
Merge pull request #967 from skidau/SyncGPU-SaveState
...
Added the EmuRunningState check to the GPU thread's FIFO loop
2014-09-05 11:24:46 +10:00
bfb2c04ace
TextureDecoder: Remove unused function
...
GetPC_TexFormat was never used. It was added in commit d02426a9893122
2014-09-04 17:32:06 -07:00
6682a2fadd
TextureDecoder: Fix a RGBA/BGRA copy/paste typo
...
We were decoding to BGRA32 textures in our RGBA32 texture decoder. Since
this is the same for the BGRA32 decoder implementation, this is most
likely a copy/paste typo, rather than the texture actually being
bit-swapped. Fix this.
I'm not sure of any games that use the C14X2 texture format, so I'm not
sure this fixes any games, but it does make the code cleaner for when we
clean it up in the future, and merge some of these similar loops.
2014-09-04 17:30:53 -07:00
a5297f6da8
PixelEngine: Remove unused AllowIdleSkipping and all references to it
2014-09-04 17:25:59 -07:00
5cb5a6ecd2
Don't sleep in the event thread
...
The person who wrote this seemed to misunderstand how XPending and
XNextEvent actually work. XNextEvent will wait in poll if there's
no event yet, meaning that we don't need to sleep after we process
all the events; the kernel will sleep for us.
This changes indentation, so view with -w or a similar feature to
understand what's actually changed here.
2014-09-04 17:24:51 -07:00
411c060504
Checkbox for iteration
...
Added the option to handle whether the user wants to iterate through the
assignment of button mappings or assign them one at a time.
fixed formatting issues and code style.
I excluded this option from the config file. This stopped the check box value and the boolean from becoming offset. Since the option should always start as false.
This still causes an issue with the Wiimote input, since the class variable that keeps the state will be wiped, but the check box value will stay the same after closing/reopening without closing the entire Wiimote configuration. I am looking for a way to resolve this.
I also reduced wait time to 2.5 seconds vs. the 5 seconds previously. Seemed to be a little long.
These changes apparently did not go through.
This should fix the Wiimote issue.
2014-09-04 19:23:04 -05:00
ffa6572116
Auto iterate through configuration inputs
...
Allows user to map all inputs seamlessly without having to
click on each button.
Also increased button timeout to 5 seconds from 1.5 due to pita.
Motion controls are not included since they will be special cases.
2014-09-04 19:05:52 -05:00
e32b2e1771
Work around Intel's failings with with buffer_storage
2014-09-04 19:03:49 -05:00
b7ecaf6111
Added OSD comment if EFB Copies are disabled.
2014-09-05 01:42:40 +03:00
18e13aacf7
Remove "EFB Copies Disabled" option from hotkey toggling cycle.
2014-09-05 00:12:04 +03:00
d8d9bc8c6c
Render: Implemented simple render target pool
...
This avoids creating and destroying render targets every frame,
which is a significant CPU overhead.
Old render targets are destroyed after 3 frames.
2014-09-04 22:21:06 +02:00
830a03c540
Merge pull request #957 from degasus/frame_skipping
...
VideoCommon: rewrite frame skipping code
2014-09-04 18:27:19 +02:00
af7881474e
Merge pull request #958 from degasus/xf_cleanup
...
VideoCommon: remove XFReg copy optimization
2014-09-04 09:22:19 -07:00
8b84ddce9a
VideoCommon: rewrite frame skipping code
2014-09-04 18:07:39 +02:00
ef6f6a7fa9
VideoCommon: remove XFReg copy optimization
...
This code is just ugly and I doubt there is a way that copying twice is faster.
2014-09-04 17:56:17 +02:00
127fc1bdc1
Merge pull request #965 from FioraAeterna/srawixzero
...
JIT: remove srawix fallback
2014-09-04 08:44:33 -07:00
b5e18993f9
Merge pull request #964 from RachelBryk/typo
...
Fix a typo introduced by 5adbc83
2014-09-04 08:42:22 -07:00
9f48f02514
Core: Make the tables in ARDecrypt.cpp static
2014-09-04 09:29:34 -04:00
b2c743157d
Merge pull request #969 from lioncash/windows-stuff
...
Common: Remove unused header from Thread.cpp
2014-09-04 23:22:52 +10:00
bd91e8b0c8
Common: Remove unused header from Thread.cpp
...
This define isn't even used in the Windows builds.
2014-09-04 09:15:18 -04:00
4b329a0a75
Core: Fix variable prefixing of statics in Core.cpp
...
These aren't globals.
2014-09-04 08:26:15 -04:00
86db0bf8c3
Added the EmuRunningState check to the GPU thread's FIFO loop so that the GPU thread services any waiting save states. This is needed for games that have the Sync GPU option enabled.
2014-09-04 22:02:21 +10:00
1cc153b4ed
Fix a typo introduced by 5adbc83 in ControllerEmu.cpp.
2014-09-04 05:00:53 -04:00
345b608d64
Change IniFile::Section::Set() with default value to use a template.
2014-09-04 03:29:49 -04:00
a63b9f6713
JIT: remove srawix fallback
...
As far as I can tell, this has literally been here since the start of the git
history; maybe it was stubbed out because the author wasn't sure it was right?
It matches the PPC/Broadway manuals perfectly, though.
2014-09-03 23:39:52 -07:00
f6d89c5c98
GCI Folder: if there are too many files in the folder, try to leave free directory entries.
...
Rule: Load first 112 files, any remaining files in the folder are ignored unless they are the same gameid as the current game
2014-09-03 21:15:41 -07:00
46c18aa909
Merge pull request #836 from lioncash/initlist
...
Core: Initialize all JITIL RegInfo members in the initializer list.
2014-09-03 21:03:48 -07:00
329410074c
Merge pull request #962 from lioncash/casing
...
OGL: Fix constant casing in RasterFont.
2014-09-03 21:03:29 -07:00
732bb7beb1
Change NULL to nullptr.
2014-09-03 22:22:12 -05:00
ffe6bcf22f
VSProps: Add C4351 to the list of disabled warnings in Base.props
2014-09-03 23:07:19 -04:00
956b0708b4
Core: Initialize all JITIL RegInfo members in the initializer list.
2014-09-03 23:06:05 -04:00
cf390ba537
OGL: Make rasters 2D array static in RasterFont
2014-09-03 22:59:13 -04:00
89557f6c2f
OGL: Fix constant casing in RasterFont
2014-09-03 22:59:05 -04:00
4fcb633df5
Merge pull request #961 from RachelBryk/logs
...
Read the config file before enabling logs.
2014-09-03 17:20:11 -07:00
22d2c7d053
Read the config file before enabling logs.
2014-09-03 19:50:02 -04:00
1f6f01e2a0
Merge pull request #955 from skidau/geckocodes-mmio
...
Added code to patch the codehandler's MMIO address
2014-09-03 15:33:57 -07:00
05cd06539b
Merge pull request #960 from lioncash/preproc-stuff
...
Common: Make TITLEID_SYSMENU a static const variable in NandPaths.h
2014-09-03 15:22:32 -07:00
29ef22fd81
Merge pull request #871 from shuffle2/hide-menubar
...
Re-implement hiding of the menubar in fullscreen with render to main.
2014-09-03 15:21:33 -07:00
7a18add39f
Merge pull request #959 from FioraAeterna/fixtimer
...
JIT: fix regression in timer patch
2014-09-04 00:20:28 +02:00
a687cc556b
Common: Make TITLEID_SYSMENU a static const variable in NandPaths.h
2014-09-03 18:03:23 -04:00
0da22d687d
Added code to patch the codehandler's MMIO address to the currently running system. Added code to detect the location of where the code list should be. This allows any Gecko code handler to be used. Replace the codehandler.bin file with the code handler to be used (e.g. codehandleronly.bin).
2014-09-04 07:44:45 +10:00
068b5c26f4
JIT: fix regression in timer patch
2014-09-03 14:36:38 -07:00
1b50f9df14
JIT: implement fres
...
Mostly a straightforward translation of the interpreter code, with a few
tricksy optimizations and fallbacks for rare paths.
2014-09-03 12:15:30 -07:00
c72a133206
JIT: implement frsqrte
...
Mostly a straightforward translation of the interpreter code, with a few
tricksy optimizations and fallbacks for rare paths.
2014-09-03 11:21:04 -07:00
e1248599eb
Merge pull request #868 from FioraAeterna/bmi
...
x64Emitter: add BMI1/BMI2 support
2014-09-03 19:24:27 +02:00
f69e6ef16f
Common: Remove unnecessary define check in Log2
2014-09-03 13:04:48 -04:00
5088a2b4e2
x64Emitter: add BMI1/BMI2 support
...
TZCNT and LZCNT use a completely different encoding scheme, so they should
probably go in a separate patch.
Also add some tests.
2014-09-03 10:04:01 -07:00
08715167a8
Added code to patch the codehandler's MMIO address to the currently running system. Added code to detect the location of where the code list should be. This allows any Gecko code handler to be used. Replace the codehandler.bin file with the code handler to be used (e.g. codehandleronly.bin).
2014-09-04 00:48:52 +10:00
b583879c2a
Merge pull request #944 from delroth/x64emittertest
...
x64EmitterTest: Fake support for all CPU extensions
2014-09-03 03:37:46 -07:00
fd2343e431
Re-implement hiding of the menubar in fullscreen with render to main.
2014-09-03 03:02:13 -07:00
46c1a0f03b
Merge pull request #733 from lioncash/readability
...
DolphinWX: More readable variable names in BreakpointView
2014-09-03 01:28:17 -07:00
30dd2809a7
Prevent changing adapters during emulation and VideoConfigDiag cleanup
...
Author: https://github.com/Anti-Ultimate/dolphin
2014-09-03 00:35:23 -07:00
6e2b873ec1
Merge pull request #781 from RachelBryk/ControlState
...
Change ControlState typedef to double, and change all related floats/dou...
2014-09-03 09:15:51 +02:00
db84a22109
Merge pull request #770 from lioncash/panic
...
Core: Fix case where a panic alert wouldn't be shown in MemoryUtil.cpp
2014-09-03 00:10:12 -07:00
60a772c5e8
Merge pull request #901 from Sonicadvance1/64bit-android-cmake
...
Update the android cmake toolchain file to support 64bit.
2014-09-03 00:09:03 -07:00
5adbc83453
Change ControlState typedef to double, and change all related floats/doubles to use it.
...
Fixes an off by 1 issue related to double->float->double conversion, and eliminates numerous warnings.
2014-09-03 03:08:09 -04:00
64575d565a
Merge pull request #923 from FioraAeterna/fixcallersave
...
JIT: Fix caller-save registers on WIN64
2014-09-03 02:27:44 -04:00
e2dfa603a0
Merge pull request #891 from RachelBryk/netplay-time
...
Allow system time to move forward during netplay.
2014-09-03 08:26:51 +02:00
51a5311d6a
Merge pull request #949 from comex/eviction-policy
...
Evict registers from the cache based on LRU.
2014-09-03 02:22:45 -04:00
50879f5624
Merge pull request #905 from RachelBryk/status-bar-messages
...
Add OSD messages back to status bar.
2014-09-02 23:21:58 -07:00
de71db4864
Merge pull request #925 from shuffle2/xbcd-compat
...
Revert changes to how DInput filters out XInput devices.
2014-09-02 23:21:47 -07:00
532b7bb7da
Merge pull request #893 from rohitnirmal/scan-build-fixes
...
Scan build fixes
2014-09-02 23:15:18 -07:00
d20f5fb861
Merge pull request #946 from ChuckRozhon/fix_cast_bug
...
Fixed bug introduced in PR#803 caused by casting
2014-09-02 22:58:53 -07:00
5468b535c1
Merge pull request #941 from FioraAeterna/eaxemit
...
x64Emitter: add support for shorter EAX forms of instructions
2014-09-02 22:54:53 -07:00
1ad1a9062a
Remove PowerPCState::DebugCount.
...
This value was "helpful" for debugging when the stack got corrupted.
Helpful that if gpr[1](Which is the stack pointer with PPC ABI) is zero then the interpreter would spam huge amounts of annoy text saying that we
managed to get in to a "corrupted" state.
This is incremented every instruction on the interpreter, or every block run on the JIT64....Only if debugging is enabled(JIT64 it is a const
variable)
The message is only outputted when interpreter is used and debugging is enabled.
2014-09-03 00:26:57 -05:00
f5c7f676dc
Evict registers from the cache based on LRU.
...
The old method would always evict the first suitable register, i.e. the
same register every time once the cache got full. The cache doesn't get
terribly often, but the result is pathological...
2014-09-03 01:06:14 -04:00
fa29b18e3e
Merge pull request #840 from FioraAeterna/jittimer
...
JIT: implement timer support in mtspr
2014-09-03 07:01:20 +02:00
9e4419e786
x64Emitter: add support for shorter EAX forms of instructions
...
Should save a few bytes of code size here and there.
2014-09-02 21:52:41 -07:00
Lioncash