Commit Graph

13781 Commits

Author SHA1 Message Date
JosJuice bf2676a1b1 Simplify getting DI pointer in IOCtl callback
Gets rid of an odd code construct, and fixes the "Trying to run two DI
devices at once" ERROR_LOG appearing at the wrong times.
2015-10-03 11:35:29 +02:00
shuffle2 f33fae574f Fix WiiSockMan::DecodeError 2015-10-03 01:56:42 -07:00
Scott Mansell a10a3ecbac ALSA: Don't block on Clear() call.
snd_pcm_writei() is meant to block block until all samples are written,
but apparently in some situations it can block for much longer, prehaps
even a infinite time, in the case of virtual machine FifoCI runs in.

Because it grabed a mutex before blocking, it could also block the
Clear() call for an infinite length of time, blocking dolphin's emu
thread.

snd_pcm_writei() also takes 10-15 seconds if you run dolphin under GDB
and can randomly take 5 or so seconds during normal usage.

By moving all the pause code to the ALSA thread, Clear() no-longer
blocks and everyone keeps their sanity.
2015-10-03 16:31:55 +13:00
Scott Mansell f1a43dc6d4 Merge pull request #3118 from lioncash/junk
WiimoteEmu: Get rid of an unused clamp function
2015-10-03 16:21:00 +13:00
Scott Mansell bcee41b65d Merge pull request #3123 from lioncash/null
Core: Replace 0 literals with nullptr
2015-10-03 16:19:46 +13:00
Rohit Nirmal 6001366aac Alsa: Silence -Wsign-compare warning. 2015-10-02 21:10:06 -05:00
Lioncash 0f6c4653a4 Core: Replace 0 literals with nullptr 2015-10-02 22:06:17 -04:00
Lioncash a30681834c InputCommon: Use NSNumber numeric literals in Obj-C code 2015-10-02 13:23:46 -04:00
Lioncash 5d8e422d82 WiimoteEmu: Get rid of an unused clamp function 2015-10-02 10:33:29 -04:00
Lioncash 75907d83c6 DSPCore: Get rid of division for determining array size in VerifyRoms 2015-10-01 11:49:30 -04:00
Lioncash 73f312863d DSPCore: Compress common fill loops into std::fill 2015-10-01 11:23:01 -04:00
Scott Mansell 58d893e56f Merge pull request #3075 from waddlesplash/no-regexp
FileSearch: Don't use RegExes, just do string comparisons.
2015-10-02 04:00:23 +13:00
Lioncash ccc3cd884e DSPCore: Use std::array to represent ifx_regs 2015-10-01 10:26:16 -04:00
Lioncash 7f9cb1b6a8 ControllerConfigDiag: Remove superfluous arguments 2015-10-01 09:37:48 -04:00
Lioncash b3da7e81bd ControllerConfigDiag: Amend button sizing issues 2015-10-01 09:34:32 -04:00
Lioncash 449c57a8e0 InputCommon: Get rid of multiple identical define macros 2015-10-01 08:45:22 -04:00
flacs 696d6eae09 Merge pull request #3108 from lioncash/cstyle-array
ChunkFile: Provide additional helpers for C-style arrays
2015-10-01 01:55:54 +02:00
Lioncash a10be26972 Tev: Don't savestate Zero16
It's an array of zeroes. There's no need.
2015-09-30 19:45:50 -04:00
Lioncash c6678687b0 ChunkFile: Provide additional helpers for C-style arrays
Gets rid of magic numbers in cases where the array size is known at compile time.
This is also useful for future entries that are stack allocated arrays as these
functions prevent incorrect sizes being provided.
2015-09-30 19:45:46 -04:00
flacs 6305437327 Merge pull request #3110 from booto/alsa-buffer-type
AlsaSound: fix buffer type, clean up macros
2015-10-01 00:01:26 +02:00
Lioncash 473188a2c3 WII_IPC_HLE_Device_fs: Get rid of a pointer cast 2015-09-30 16:04:53 -04:00
Ryan Houdek 0764971feb Merge pull request #3109 from OrdinaryMagician/miniupnpc14
Update to support miniupnpc 1.9 API version 14
2015-09-30 11:08:58 -04:00
Marisa Kirisame 8c5744bca7 miniupnpc API version 14 changed the upnpDiscover functions, adding an argument for TTL (should default to 2)
this enables support for that should the build system have that specific version installed, the miniupnpc bundled in the project is unchanged
2015-09-30 16:50:58 +02:00
Ryan Houdek ebf2420c6b Merge pull request #3057 from booto/finicky-vert-beam-position
VI: Fix vert beam position inaccuracy
2015-09-30 08:26:31 -04:00
booto 6c28ea58ab AlsaSound: fix buffer type, clean up macros 2015-09-30 19:14:03 +08:00
flacs 16957fcaec Merge pull request #3107 from lioncash/pragma
TextureDecoder_x64: Remove now-unnecessary clang #pragma warning suppression
2015-09-29 19:53:12 +02:00
booto ea6af0e98b VI: Fix vert beam position inaccuracy 2015-09-30 00:21:33 +08:00
Lioncash 50a7390622 TextureDecoder_x64: Remove unnecessary commented out header 2015-09-29 11:04:00 -04:00
Lioncash 80c7e3ebc0 TextureDecoder_x64: Remove clang warning suppression
This was an issue two years ago on clang 3.3
2015-09-29 11:00:59 -04:00
Lioncash d6ff75d71d OGL: Remove unnecesary FPSCounter include from Render.cpp 2015-09-29 10:01:38 -04:00
Lioncash 4a981e3a04 FPSCounter: Change Update's return type to void
Its returned value is never used.
2015-09-29 10:01:37 -04:00
Lioncash 55c7754738 FPSCounter: Give the refresh interval a concrete type 2015-09-29 10:01:37 -04:00
Lioncash e82b6a8532 FPSCounter: Direct initialize class members 2015-09-29 10:01:37 -04:00
Lioncash bf23fcfc1f FPSCounter: Don't provide direct access to m_fps 2015-09-29 09:43:03 -04:00
Tillmann Karras 2f6f30a939 Fix -Wuninitialized warnings 2015-09-29 04:27:27 +02:00
flacs 43e60073d1 Merge pull request #3100 from lioncash/printf
Get rid of some casts used with logging for size_t
2015-09-29 03:50:48 +02:00
flacs d5ec7124e4 Merge pull request #3099 from lioncash/banner
VolumeGC: Get rid of banner pointer casts
2015-09-29 03:49:08 +02:00
flacs aaa48e19fe Merge pull request #3097 from JosJuice/blob-type
Fix blob type detection for game right-click menu
2015-09-29 03:46:29 +02:00
Rohit Nirmal 3b75f45cf6 Fix building with PCH disabled. 2015-09-28 11:51:08 -05:00
Lioncash 311c76647d Get rid of some casts used with logging for size_t
Replaces them with the now-valid %z specifiers
2015-09-28 08:43:53 -04:00
Lioncash 7317dd4be2 VolumeGC: Get rid of banner pointer casts
Prefer reading the data into the reified struct instead.
2015-09-28 04:31:43 -04:00
shuffle2 2cb5c41fed HostGetString: Actually fill a string with data 2015-09-28 05:40:52 +02:00
JosJuice 21cb13828c Fix blob type detection for game right-click menu
I forgot to update it after changing how IsCompressed() works.
Also, checking file name extensions is a bad way of checking blob types.
2015-09-27 21:06:19 +02:00
JosJuice be7e0554d2 DiscIO: Add a way to get blob type 2015-09-27 20:54:31 +02:00
ghost cd19d5392e SaveState: Fix for race condition ("wait" didn't actually waited for file to flush/close).
g_compressAndDumpStateSyncEvent was Set() before destruction of file object (i.e. before flushing changes and closing file).

Also, adds Common::ScopeGuard wrapper for RAII.
2015-09-27 21:40:32 +03:00
waddlesplash 06c6f60f5b OGL: Use SplitPath() instead of std::regex. 2015-09-27 13:26:19 -04:00
waddlesplash 5643fe5d1f FileSearch: Don't use RegExs, just do string comparisons.
Nothing used the RegEx feature of FileSearch, and GCC < 4.9
doesn't support C++11 RegEx properly, so get rid of it.
2015-09-27 13:25:51 -04:00
Scott Mansell ce493b897d Merge pull request #2271 from revel8n/fixes
Fix for alignment of zero-length files within directory based virtual disk
2015-09-28 05:28:38 +13:00
Scott Mansell be3851b72e Merge pull request #3090 from LPFaint99/gcifolder
GCI Folder: Skip 'header-only' writes
2015-09-28 05:26:12 +13:00
Scott Mansell af327aec79 Merge pull request #3036 from mimimi085181/hash-respecting-stride
Respect the stride for efb copies when hashing them
2015-09-28 05:23:55 +13:00
Scott Mansell 4817118028 Merge pull request #3084 from JosJuice/cpu-core-clock
SystemTimers: Don't name non-constant variables as if they are constant
2015-09-28 05:22:54 +13:00
flacs 34c020352f Merge pull request #3092 from JosJuice/compressed-blobs
Display all compressed formats in blue in GUI
2015-09-27 12:57:19 +02:00
Lioncash 457a398c33 MemoryWindow: Adjust control alignment
Aligns controls so that their widths remain the same with one another
2015-09-26 22:46:57 -04:00
Lioncash 5aa19ad051 MemoryWindow: Change the address search wxTextCtrl into a wxSearchCtrl 2015-09-26 22:46:53 -04:00
Lioncash 7ba171a497 CodeWindow: Ignore search error highlighting on empty string
Doesn't make sense to flag these as errors, since someone might search for another address.
2015-09-26 22:38:08 -04:00
Lioncash 6866373202 CodeWindow: Replace wxStaticText/wxTextCtrl combo with a wxSearchCtrl
Same thing, one control.
2015-09-26 22:38:07 -04:00
flacs 8ea9b07b59 Merge pull request #3093 from lioncash/header_shuffle
Common: Trim Common.h
2015-09-27 03:18:03 +02:00
revel8n d4c2ca46a4 - Fix for alignment of 0-length files when volume directory is created from directory on disk
Updating constant value representation

Explicitly state data type in std:max usage
2015-09-26 18:29:29 -05:00
Lioncash cc036ca86c Common: Remove other Common prefixed headers from Common.h 2015-09-26 18:51:58 -04:00
Lioncash 19ac565e0d Common: Move asserts to their own header 2015-09-26 18:51:27 -04:00
Lioncash 867df74b52 Common: Remove strdup define
It's not used anywhere.
2015-09-26 18:50:42 -04:00
Lioncash 1d42db2439 Common: Move NonCopyable to its own header 2015-09-26 18:50:35 -04:00
Lioncash bb927ad738 Atomic_GCC: Throw out old code 2015-09-26 15:59:36 -04:00
Lioncash d67ea484f7 Common: Get rid of compiler semantic asserts
They were never used.
2015-09-26 15:57:13 -04:00
mimimi085181 e24b8c4ab7 Respect the stride for efb copies when hashing them 2015-09-26 20:19:02 +02:00
Scott Mansell a91810ba3b Merge pull request #3042 from booto/audio-timing
AI: reduce overhead of sample counter
2015-09-27 05:03:55 +13:00
Ryan Houdek be667e7de8 Merge pull request #3035 from aserna3/SSAAImprovements
Improved OGL and D3D's AA options in UI
2015-09-26 09:27:39 -04:00
JosJuice 6935d28112 Display all compressed formats in blue in GUI
In the past, only GCZ was shown as compressed, not CISO and WBFS.
2015-09-26 15:24:29 +02:00
JosJuice 94ee720a07 Rename IsCompressedBlob to IsGCZBlob for clarity
GCZ is just one of the several compressed formats that Dolphin supports.
2015-09-26 14:46:53 +02:00
LPFaint99 ddc523b81d GCI Folder: Skip 'header-only' writes
issue #8961
2015-09-25 22:12:40 -07:00
Tillmann Karras f6795466e7 mbedTLS: adapt Dolphin code 2015-09-26 07:09:19 +02:00
Anthony Serna df189c3ea3 Improved D3D and OGL AA option UI
Removed Quality Levels from D3D AA options

Dropdown text now shows whether you're applying MSAA or SSAA

Added a description for SSAA

Moved SSAA checkbox

Cleaned up AA in backends slightly. Supported modes is now a list of ints.
2015-09-25 09:05:18 -07:00
Tillmann Karras ac5f56df7e mbedTLS: adapt Dolphin's Visual Studio files 2015-09-25 03:46:41 +02:00
Tillmann Karras 063446c46f mbedTLS: run rename.pl script and fix errors 2015-09-25 03:46:41 +02:00
Lioncash 7e69a0ce79 CommandProcessor: Remove unused extern 2015-09-24 11:35:46 -04:00
JosJuice ab8f75f000 SystemTimers: Don't name non-constant variables as if they are constant 2015-09-24 14:57:25 +02:00
ghost 7c1565b201 VideoConfig/LocalConfig/HotkeyManager: Added hotkeys for switching stereo-3d presets.
Added 3 depth/convergence presets. They are adjustable via (existing) hotkeys - changes to depth and convergence are applied to current preset.
Added 3 hotkeys for activating presets. Added hotkey for toggle between first and second preset.
Added OSD message for convergence/depth changes.
Presets are saved into per-game configs.
2015-09-24 15:19:55 +03:00
Lioncash d694994874 BoundingBox: Remove unnecessary headers 2015-09-24 03:19:43 -04:00
Tillmann Karras aba083dd3a FifoPlayer: remove leftover code 2015-09-24 05:09:41 +02:00
flacs c1ee0e7829 Merge pull request #3078 from lioncash/titleid
DiscIO: Do swapping in GetTitleID implementations
2015-09-23 18:56:57 +02:00
flacs cf131b133e Merge pull request #3079 from lioncash/emit
x64Emitter: Minor changes
2015-09-23 18:55:24 +02:00
flacs 40da69d5a2 Merge pull request #3081 from lioncash/si-enum
SI_Device: Convert define constants over to enums
2015-09-23 18:55:10 +02:00
Rohit Nirmal a48e425f41 Silence -Wshadow warning. 2015-09-23 11:02:24 -05:00
JosJuice 3fdae38e26 Use correct GetTicksPerSecond() value in IPC delays
The constant IPC_DEFAULT_DELAY used a value from GetTicksPerSecond(),
which in turn uses a value from CPU_CORE_CLOCK... but CPU_CORE_CLOCK
isn't actually a constant! It's first initialized to 486 MHz and then
changed to 729 MHz in SystemTimers::PreInit if emulating a Wii. This
means that the IPC delays always used 486 MHz and thus were wrong.
To fix this, the IPC reply constants are changed to functions.
2015-09-23 18:02:09 +02:00
Lioncash c7148c9660 SI_Device: Convert define constants over to enums 2015-09-23 11:13:03 -04:00
booto 0e0fec3075 AI: reduce overhead of sample counter 2015-09-23 20:39:28 +08:00
Lioncash 7890b38c15 x64Emitter: Remove unimplemented function prototype in OpArg 2015-09-22 19:54:46 -04:00
Lioncash 6e5f60bab7 x64Emitter: Make single argument constructor explicit 2015-09-22 19:51:14 -04:00
Lioncash 213d11dc62 Merge pull request #2939 from lioncash/find
FramebufferManagerBase: Compress a loop into a find_if
2015-09-22 18:56:38 -04:00
Lioncash 4b9b82e000 DiscIO: Do swapping in GetTitleID implementations
Gets rid of external swaps at every usage.
2015-09-22 13:50:35 -04:00
Lioncash 5d774df1e8 Merge pull request #3074 from JosJuice/isoproperties-gettitleid
Remove odd way of getting ID in ISOProperties
2015-09-22 12:24:19 -04:00
Markus Wick 3930c929cb Merge pull request #3062 from phire/moveGL
Move GL interface code out of the OpenGL video backend.
2015-09-22 15:32:48 +02:00
Scott Mansell a537ca7543 Merge pull request #2997 from phire/FixFifoRecorder
FifoRecorder: Use Texture Cache to record efb copies correctly.
2015-09-23 00:17:37 +12:00
Scott Mansell aa1fec6fc3 FifoPlayer: Fixup style of types. 2015-09-23 00:03:43 +12:00
Scott Mansell a355d9868e FifoRecorder: Use Video Common to record efb2ram correctly.
Texture updates have been moved into TextureCache, while
TMEM updates where moved into bpmem. Code for handling
efb2ram updates was added to TextureCache.

There was a bug for preloaded RGBA8 textures, it only copied
half the texture. The TODO was wrong too.
2015-09-22 23:59:16 +12:00
ghost 07e4b4f7c4 VideoBackend: Video config filename is now exposed in VideoBackends.
It reduces redundancy. Needed make possible to save current video config.
2015-09-22 09:47:19 +03:00
JosJuice 42db9e2897 Remove odd way of getting ID in ISOProperties
Other code (like GameListItem) simply calls GetUniqueID,
and I've never seen that lead to any problems.
2015-09-21 17:46:05 +02:00
Scott Mansell c9836ff592 EGL: Don't depend on VideoCommon or Core 2015-09-22 00:36:48 +12:00
Scott Mansell 72249b8085 GLX: Don't depend on Core or VideoCommon 2015-09-22 00:36:47 +12:00
Scott Mansell 01ed925fec AGL: Don't depend on VideoCommon 2015-09-22 00:36:46 +12:00
Scott Mansell 93f6563789 WGL: Don't depend on Core/VideoCommon 2015-09-22 00:36:45 +12:00
Scott Mansell 95f3c956a8 Move GL interface code out of the OpenGL video backend. 2015-09-22 00:36:45 +12:00
Lioncash bddcdd9d94 Jit_Util: Replace two MDisp usages with MatR
Same thing, less to read.
2015-09-21 08:20:35 -04:00
flacs 3df83e5717 Merge pull request #3069 from degasus/master
VideoSW: Don't raise a PanicAlert because of indices
2015-09-21 11:58:13 +02:00
Lioncash 67cfadf0bb DSPJitUtil: Use SCALE constants instead of magic numbers 2015-09-21 04:50:25 -04:00
Lioncash 29c674848d DSPJitRegCache: Make GetFreeXReg return by value
There's no reason to only modify an enum value by reference.
2015-09-21 04:24:09 -04:00
degasus be16901ae1 VideoSW: Don't raise a PanicAlert because of indices
It's not panic, it may just render wrong. And this case seems to happen often.
2015-09-20 13:13:47 +02:00
flacs 63c373c843 Merge pull request #3063 from lioncash/func
DSPJitRegCache: Fix function casing
2015-09-20 03:32:11 +02:00
flacs 403df299a6 Merge pull request #3066 from degasus/master
GLInterface: Fix VideoSW on linux + OSX (v2)
2015-09-20 03:30:46 +02:00
Markus Wick 1c502b76a5 Merge pull request #3065 from JosJuice/wad-id-exception
Fix 4.0-7767 regression: exception when handling short WAD IDs
2015-09-19 13:49:21 +02:00
degasus c976e14277 GLInterface: Fix VideoSW on linux + OSX (v2)
Our Video Software backend isn't OpenGL Core compatible, so we need a flag to alloc a compatible one.

v2: Fix AGL profile selection.
2015-09-19 13:22:55 +02:00
JosJuice e2e7fc9029 Fix 4.0-7767 regression: exception when handling short WAD IDs 2015-09-19 09:23:52 +02:00
flacs 9b08de9522 Merge pull request #3064 from phire/no_xp
VideoBackendBase: Remove check for XP.
2015-09-18 21:18:07 +02:00
Scott Mansell b6cd78a370 VideoBackendBase: Remove check for XP. 2015-09-19 07:10:44 +12:00
Lioncash c2cc8d7cd8 DSPJitRegCache: Fix function casing 2015-09-18 13:23:32 -04:00
Lioncash 9f389fdccb Gekko: Make sign-extension functions constexpr 2015-09-18 11:14:45 -04:00
Markus Wick b293bd22d6 Merge pull request #3060 from dolphin-emu/revert-3054-master
Revert "GLInterface: Fix VideoSW on linux + OSX"
2015-09-18 13:48:47 +02:00
Markus Wick 8bd1be643c Merge pull request #3059 from lioncash/vtx
VertexLoaderUtils: Get rid of pointer casts
2015-09-18 13:45:14 +02:00
Markus Wick a7e9a154a5 Revert "GLInterface: Fix VideoSW on linux + OSX" 2015-09-18 13:40:09 +02:00
Scott Mansell 3f56480903 Merge pull request #3037 from JosJuice/titles-txt-sort
DolphinWX: Fix sorting games by custom titles
2015-09-18 17:41:32 +12:00
Lioncash c3332604fa ControllerInterface: Fix -Winconsistent-missing-override warnings on OSX 2015-09-17 15:15:15 -04:00
Lioncash 28d1001ff8 VertexLoaderUtils: Get rid of pointer casts
Eliminates most ubsan asserts that stem from VideoCommon when running starfield.
2015-09-17 14:24:11 -04:00
degasus baf09c3af6 VideoSW: Remove unused function 2015-09-17 19:44:44 +02:00
flacs e4dfb2f6bf Merge pull request #3054 from degasus/master
GLInterface: Fix VideoSW on linux + OSX
2015-09-17 19:21:16 +02:00
degasus 3b5b80bf3c VideoSW: Drop SW bbox code
The hardware backends don't use this shared code any more, and it's not needed for video sw either. So this was just dead code.
2015-09-17 18:21:37 +02:00
degasus e3e0399af2 VideoSW: Drop HwRasterizer
I don't remember it being working, and nobody cares about performance of videosw.
2015-09-17 18:21:37 +02:00
degasus 48279c1840 GLInterface: Fix VideoSW on linux + OSX
Our Video Software backend isn't OpenGL Core compatible, so we need a flag to alloc a compatible one.
2015-09-17 17:52:56 +02:00
Lioncash cfa43f64bf x64Emitter: Remove pointer cast
No more ubsan asserts in the JIT and x64 emitter code paths when running starfield.
2015-09-17 09:35:13 -04:00
Lioncash a94300dd86 Rasterizer: Use multiplication instead of shifts in DrawTriangleFrontFace
The left-hand-side is negative at some point which is considered undefined by the standard.
2015-09-17 01:46:29 -04:00
Lioncash 00ffc47751 Jit_Util: Mark a class function as const 2015-09-17 00:21:50 -04:00
flacs 6940fc5ab9 Merge pull request #2947 from Rukario/my_branch
Updated terms in Netplay window.
2015-09-17 03:02:59 +02:00
Lioncash c6ea9eb7c3 JitCache: Remove unused define 2015-09-16 19:15:47 -04:00
Tillmann Karras b8f3519e49 Fix -Wunused-private-field warning 2015-09-16 23:31:53 +02:00
flacs 49ea15b950 Merge pull request #2873 from lioncash/netleaks
NetPlay: Fix a memory leak
2015-09-16 21:56:17 +02:00
Markus Wick 295b869304 Merge pull request #3028 from mimimi085181/sonic-fighters-regression-fix2
Fix performance regression in Sonic the Fighters, introduced by PR#2001
2015-09-16 21:53:03 +02:00
flacs 9e5f2ded86 Merge pull request #3040 from lioncash/arraysize
AX: Use ArraySize over sizeof division
2015-09-16 21:25:29 +02:00
flacs 29a0a2b626 Merge pull request #3043 from lioncash/jitalign
JitCache: Get rid of pointer casts
2015-09-16 21:22:01 +02:00
flacs 84f4c446de Merge pull request #3045 from lioncash/state
State: Increase savestate version
2015-09-16 21:19:21 +02:00
flacs ca7b999968 Merge pull request #3046 from phire/dx11-segfault
Remove segfault from DX11 backend.
2015-09-16 21:18:22 +02:00
Scott Mansell deeb1d8370 Remove segfault from DX11 backend.
Instead of blindly using the expected width, clamp it to the stride of the
buffer which dx11 returns. This prevents use from reading invalid memory
at the end of textures.

This doesn't solve the base issue of what to do when a game tries to copy
from outside the efb. On real hardware it returns random noise (biased
to all ones)
2015-09-17 02:22:00 +12:00
Lioncash 227c3aa259 State: Increase savestate version
This should have been done when GC_ALIGN macros were replaced.
2015-09-16 09:04:44 -04:00
Lioncash 8aac59418b JitCache: Get rid of pointer casts
Silences more ubsan runtime asserts
2015-09-16 06:25:48 -04:00
degasus 3ae466a33c JitArm64: Fix lmw + stmw 2015-09-16 08:11:18 +02:00
flacs 955bef226e Merge pull request #3041 from lioncash/align
Common: Get rid of a few pointer casts
2015-09-15 20:40:05 +02:00
Lioncash 2c5c99ec71 Common: Get rid of a few pointer casts 2015-09-15 12:28:59 -04:00
Lioncash 77d3bed058 AX: Use ArraySize over sizeof division
Also gets rid of magic numbers in volume ramp generation.
2015-09-14 23:55:09 -04:00
Lioncash b7739f5d85 VideoCommon: Remove unnecessary enum typedef 2015-09-14 19:43:31 -04:00
Lioncash 56560403bd BreakPoints: Remove unimplemented function declarations 2015-09-14 11:50:34 -04:00
JosJuice 210aa774d5 DolphinWX: Only read titles.txt once
titles.txt is read into a map and passed to the GameListItem
constructor, making game list scanning a bit more efficient.

ISOPropreties's constructor is changed to take a GameListItem as an
argument instead of creating one on its own, because ISOPropreties
doesn't have the titles.txt map that the GameListItem constructor wants.
2015-09-13 14:17:58 +02:00
JosJuice 10aafff5b9 DolphinWX: Fix sorting games by custom titles
The custom title reading code is moved so that custom titles are
returned by GameListItem::GetName(). The comparison code is changed
to use GetName() instead of GetName(DiscIO::IVolume::ELanguage).

GetName(DiscIO::IVolume::ELanguage) must not return custom titles,
because netplay relies on it returning the same name for all players.
2015-09-13 12:45:06 +02:00