9aea481e59
ExpressionParser: Make use of std::erase_if
2023-12-12 13:31:58 -05:00
196f8e5123
MappingCommon: Make use of std::erase_if
2023-12-12 13:31:18 -05:00
888a8692b4
SysConf: Make use of std::erase_if
2023-12-12 13:30:39 -05:00
01d15994fe
PatchEngine: Make use of std::erase
2023-12-12 13:30:08 -05:00
e69ac2d43e
Socket: Make use of std::erase_if
2023-12-12 13:29:33 -05:00
96eac73d11
NetKDRequest: Make use of std::erase
2023-12-12 13:27:54 -05:00
e7f7dde546
Formats: Make use of std::erase_if
2023-12-12 13:27:17 -05:00
df227aa03c
I2CBus: Make use of std::erase_if
2023-12-12 13:26:47 -05:00
ff0e7fbf08
GeckoCodeConfig: Make use of std::erase_if
2023-12-12 13:26:16 -05:00
84ae0c1c7e
ActionReplay: Make use of std::erase_if
2023-12-12 13:25:26 -05:00
50e4dc5dba
Watches: Make use of std::erase_if
2023-12-12 13:24:40 -05:00
b728e37086
RiivolutionParser: Remove usages of global system accessor
...
We can retrieve the encompassing system instance through the
CPUThreadGuard instance instead.
2023-12-12 12:48:40 -05:00
c2e39e0d68
RiivolutionParser: Make use of std::span where applicable
...
The main interface for these only take in patches and iterate over them
in a contiguous sequence, so we can reasonably generify the interface.
2023-12-12 12:38:43 -05:00
4c7a4831cb
CustomAssetLibrary: Remove unused GetAssetSize() function
...
There's a direct analogue of this function within
DirectFilesystemAssetLibrary that *is* used, however, so we can get rid
of this one.
2023-12-11 22:00:52 -05:00
2c6bf2d224
Merge pull request #12394 from lioncash/compare
...
General: Resolve -Wsign-compare warnings
2023-12-12 03:43:12 +01:00
e011c3b383
Core/SyncIdentifier: Default operator==
...
Lets us remove a bunch of code and a dependency on the <tuple> header.
2023-12-11 19:39:55 -05:00
6699acf10c
Merge pull request #12386 from lioncash/setting
...
Common/SettingsHandler: Minor convenience changes
2023-12-12 00:02:21 +00:00
f04d834e8f
Merge pull request #12393 from lioncash/tls
...
DolphinQT/Host: Remove unused TLS variable tls_is_host_thread
2023-12-12 00:29:21 +01:00
0e51c0f8fc
JitArm64_RegCache: Resolve -Wsign-compare warning
2023-12-11 18:15:50 -05:00
4c3a5eb1c5
JitArm64_SystemRegisters: Resolve -Wsign-compare warning
2023-12-11 18:11:34 -05:00
f97316a1e6
TraversalClient: Resolve -Wsign-compare warning
2023-12-11 18:01:29 -05:00
49f44c1334
VertexManagerBase: Resolve -Wsign-compare warning
2023-12-11 18:00:34 -05:00
b48af86148
Merge pull request #12390 from lioncash/string
...
GraphicsModListWidget: Add string specifier to By and Description fields
2023-12-11 23:47:53 +01:00
4f02f526b8
Merge pull request #12392 from lioncash/decl
...
General: Resolve -Wmissing-declaration warnings
2023-12-11 23:39:23 +01:00
54301d709a
Merge pull request #12389 from lioncash/cheeve
...
AchievementManager: Make GetInstance() and GetLock() return a reference
2023-12-11 23:37:29 +01:00
f490b990f5
DolphinQT/Host: Remove unimplemented prototypes
...
Remnants of prior existing code.
2023-12-11 17:30:56 -05:00
d705c31d1a
DolphinQT/Host: Remove unused TLS variable tls_is_host_thread
...
This is never accessed or read from.
2023-12-11 17:27:57 -05:00
16ba56a34b
Merge pull request #12388 from lioncash/compare
...
GameFile: Default GameBanner operator==
2023-12-11 23:25:27 +01:00
e8b4796273
PostProcessing: Mark helper functions as static
...
These didn't have any prototypes and were generating
-Wmissing-declaration warnings.
2023-12-11 17:07:59 -05:00
abb5cc3a3a
ShaderAsset: Mark ParseShaderProperties() as static
...
This had no function prototype, so this can be internally linked.
Resolves a -Wmissing-declaration warning.
2023-12-11 17:05:06 -05:00
b4b624b97b
WC24PatchEngine: Mark LoadPatches() as static
...
Resolves a -Wmissing-declaration warning, since no prototype existed for
the function.
2023-12-11 17:02:15 -05:00
2b2ee61e79
CustomShaderCache: Resolve -Wreorder warnings
...
Lays out the initializer lists to be in the same order that
initialization would occur in.
2023-12-11 16:59:03 -05:00
9472da788d
ConfigFloatSlider: Resolve -Wreorder warnings
...
Orders the initializer list the way that the members would actually be
initialized in.
Resolves some -Wreorder warnings
2023-12-11 16:15:48 -05:00
5d1514418e
GraphicsModListWidget: Add string specifier to By and Description fields
...
Translators should always know where text is going to be appended and
have the ability to move things around to fit the language better.
2023-12-11 15:43:41 -05:00
d90537cc18
AchievementManager: Return by reference from GetLock()
...
This makes the API a little nicer to use, since you don't need to do
a mandatory dereference when passing the lock into any kind of scope
guard.
2023-12-11 13:51:50 -05:00
3c7fa0738c
AchievementsWindow: Add missing override specifier
2023-12-11 13:47:59 -05:00
dbf28df64c
DolphinQT: Remove unnecessary includes from achievement files
...
Reduces the amount of dependencies being pulled in on both local and
external headers.
2023-12-11 13:40:55 -05:00
e55f9ed102
AchievementManager: Make GetInstance() return a reference
...
The internal static member will always have a valid lifetime. Makes this
consistent with other instance based objects in our code.
2023-12-11 13:36:39 -05:00
cdf8849e17
GameFile: Default GameBanner operator==
...
Same behavior, but less code.
2023-12-11 11:36:35 -05:00
ff38362216
GameFileCache: Use std::span with Update()
...
All we're really doing is iterating over a sequence of strings, so we
don't need to tie this specifically to std::vector.
2023-12-11 11:12:09 -05:00
2ca80adeb2
GameFileCache: Pass std::function by reference rather than by value
...
std::function is internally allowed to allocate, and these functions
aren't being stored anywhere (only called), so we can freely get rid
of some minor overhead here by passing by reference.
This change also creates aliases for the functions, so that there isn't
a lot of visual noise when reading the function signatures.
2023-12-11 11:09:18 -05:00
88a973131c
Common/SettingsHandler: Use std::string_view more
...
We don't need to enforce the use of std::string instances with
AddSetting(). We can accept views and only construct one string,
rather than three temporaries.
2023-12-11 07:54:43 -05:00
04b9f6c28d
Common/SettingsHandler: Use std::erase in Decrypt()
...
Same behavior, way less verbose code.
2023-12-11 07:49:43 -05:00
d84ed054ee
Merge pull request #12374 from iwubcode/custom_texture_potential_crash_fix
...
VideoCommon: prevent a potential custom texture crash
2023-12-11 07:42:48 -05:00
694b3b4ea1
HW/CEXIIPL: Fix loading files at nonzero offset in LoadFileToIPL().
2023-12-11 02:22:06 +01:00
c2b642d0b7
Merge pull request #12381 from AdmiralCurtiss/re-enable-achievement-nag
...
AchievementManager: Only nag user about disabled achievements when they were actually enabled before.
2023-12-10 20:16:24 -05:00
bdd28f1f26
Merge pull request #12378 from JosJuice/jitarm64-a-early-discard
...
JitArm64: Add additional condition for lmw/stmw a discard
2023-12-10 20:15:57 -05:00
70cd0040a3
AchievementManager: Only nag user about disabled achievements when they were actually enabled before.
2023-12-10 21:10:49 +01:00
c55f21729f
Add "large entry points map" setting
...
To aid in debugging, this makes it possible to disable the recently
added 32/64 GiB region which hasn't had a proper name so far.
2023-12-10 21:07:27 +01:00
0ec12f9e7e
JitArm64: Add additional condition for lmw/stmw a discard
...
If a is one of the registers that will be loaded/stored, we must not
discard it early. Sorry for this fixup of a fixup...
2023-12-10 19:13:35 +01:00
13a4f1b799
JitArm64: Guard against discarding a in lmw/stmw
...
If a_is_addr_base_reg is true, discarding a before the end of the
instruction would result in the instruction being miscompiled.
2023-12-10 17:58:15 +01:00
f4b1a199e8
VFFUtil: Use std::span with WriteToVFF
...
Same behavior, but allows different containers to be used.
In one case it also gets rid of needing to construct a std::vector.
2023-12-10 10:17:39 -05:00
e2472e4f50
Merge pull request #12352 from JosJuice/jitarm64-flush-in-long-inst
...
JitArm64: Flush in the middle of lmw/stmw/mfcr
2023-12-10 09:15:07 -05:00
f249e414ad
Merge pull request #12366 from AdmiralCurtiss/exi-ipl-fixes
...
HW/CEXIIPL: Various fixes.
2023-12-10 09:12:18 -05:00
a0da6788a3
MMU: Use MSR.IR for instruction reads.
2023-12-10 14:18:25 +01:00
c12725c916
MMU: Assert that the given XCheckTLBFlag is valid for the operation.
2023-12-10 14:18:25 +01:00
0d6a0724fd
MMU: Always use data read for the PTE lookup in TranslatePageAddress.
2023-12-10 14:18:24 +01:00
5d2fc0147e
MMU: Mark IsOpcodeFlag() and IsNoExceptionFlag() as constexpr.
2023-12-10 14:18:24 +01:00
8194b53166
HW/CEXIIPL: Check for errors when reading font.
2023-12-10 14:17:38 +01:00
57e166dbef
HW/CEXIIPL: Consider that the loaded file may not actually contain a nullterminated string.
2023-12-10 14:17:37 +01:00
7d53916466
HW/CEXIIPL: Respect bounds in LoadFileToIPL().
2023-12-10 14:17:37 +01:00
f284bfca45
Merge pull request #12336 from AdmiralCurtiss/lazymemory-ringbuffer
...
Common/MemArenaWin: Rewrite LazyMemoryRegion by repeatedly mapping the same block of memory for unwritten regions.
2023-12-10 13:00:09 +01:00
02756be381
VideoCommon: prevent a potential custom texture crash that can occur when a shared_ptr gets released while a pointer to its member data is still being used
2023-12-09 23:43:40 -06:00
ccedeb4936
Merge pull request #12373 from lioncash/present
...
VideoCommon/Present: Remove use of g_presenter inside Presenter class
2023-12-10 03:55:30 +01:00
0df7908025
VideoCommon/Present: Remove use of g_presenter inside Presenter class
...
There's no need to self reference a global of the class itself when we
can just call the function directly.
2023-12-09 20:15:32 -05:00
5f6c76af51
VideoCommon: Use std::span for BoundingBox::Write()
...
Crosses off a lingering TODO.
Also amends a few nearby cases where a u32 cast was being repromoted to
size_t.
2023-12-09 16:33:21 -05:00
3364d571cc
Common/MemArenaWin: Rewrite LazyMemoryRegion to manually map memory blocks into the large memory region as needed.
...
Internal details: The large region is split into individual same-sized blocks of memory. On creation, we allocate a single block of memory that will always remain zero, and map that into the entire memory region. Then, the first time any of these blocks is written to, we swap the mapped zero block out with a newly allocated block of memory. On clear, we swap back to the zero block and deallocate the data blocks. That way we only actually allocate one zero block as well as a handful of real data blocks where the JitCache actually writes to.
2023-12-09 21:11:31 +01:00
eb235d6ee3
Common/MemArenaWin: Move the advanced Windows memory function address initialization into its own struct and function so it can be reused.
2023-12-09 20:58:07 +01:00
6197902dc3
IOS/KD/Mail: Add missing includes.
2023-12-09 17:07:03 +01:00
636b892b7c
Merge pull request #12360 from TryTwo/bugfix_wiimote_signal_spam
...
WiimoteDevice. Bugfix. Remove signal spam while starting a game.
2023-12-08 21:07:51 -05:00
3b8737d2d7
Fix out of bound write in EfbCopy::ClearEfb
2023-12-09 02:15:42 +01:00
e992225b88
Bugfix - small square in bottom right corner
...
Fixed a bug in OSUI created by the challenge icons that caused a small rectangle to appear in the bottom right corner of the screen.
2023-12-08 00:33:29 -05:00
3a4cf579ff
Merge pull request #12247 from LillyJadeKatrin/retroachievements-challenges
...
RetroAchievements - Challenge Icons
2023-12-07 16:46:43 -05:00
caa729f84a
Display Active Challenges On Screen
...
The active challenges, aka the primed achievements, are displayed on screen as a series of icons in the bottom right corner of the screen via OnScreenUI.
2023-12-07 16:02:15 -05:00
6bd9488e0a
WiimoteDevice. bugfix. Remove signal spam while starting a game.
...
Emulation state changed signals also update the wiimote connection. The signal here is only needed for wiimote connects/disconnects.
Can fix erroneous debugger behavior during booting, as dolphin will sometimes incorrectly report the state as paused, which leads the debugger widgets to run when they shouldn't.
2023-12-07 12:15:57 -07:00
2ece642cf8
Merge pull request #12357 from AdmiralCurtiss/ipl-bounds
...
Core/Boot: Check bounds in Load_BS2().
2023-12-06 19:57:26 -05:00
8fbc5960e7
Handle Achievement Un/Primed Events
...
When an achievement is "primed", a challenge is active, for example completing a portion of the game in under a time limit or without taking damage or using certain items. This is stored in a map in the Achievement Manager (and removed when the achievement is unprimed) so a later commit can display it on screen.
2023-12-06 08:21:06 -05:00
fff538e563
Core/Boot: Check bounds in Load_BS2().
2023-12-05 22:34:35 +01:00
2bf6ebcb90
Added achievement hash to non-disc boot paths.
2023-12-05 16:17:18 -05:00
ebf2ef1d82
Refactored hash process to check prior game ID
...
If the new game ID is a different title than the previous game ID, the achievement manager is compromised.
2023-12-05 16:17:18 -05:00
c8d8ca2ff7
Added Disabled flag to Achievement Manager
...
The Disabled state sits between Game Closed and completely Shutdown - stronger than the former, as it refuses to let a game be opened again until AchievementManager is restored (which only happens upon a fresh core boot) but it isn't completely shut down and will still allow the player to be logged in and access the achievement settings and their (global) achievement header.
2023-12-05 16:17:17 -05:00
148c2f3c0d
Refactored AchievementManager hash code to take a volume.
...
This change splits LoadGameAsync into three methods: two HashGame methods to accept either a string filepath or a volume, and a common LoadGameSync that both HashGames call to actually process the code. In the process, some minor cleanup, and the hash resolution now takes place on the work queue asynchronously.
2023-12-05 16:17:11 -05:00
a65246ec3f
Merge pull request #11988 from JosJuice/jit-feature-flags
...
Jit: Replace "msrBits" with "featureFlags" and use for performance monitor
2023-12-05 03:13:50 -05:00
6e6695c24b
Merge pull request #11904 from LillyJadeKatrin/retroachievements-hardcore-v2
...
RetroAchievements - Hardcore Mode (V2)
2023-12-05 01:31:54 -05:00
7dfea144b9
Merge pull request #12324 from Pokechu22/vertex-loader-dummy-tex-coords
...
VertexLoader: Fixes and cleanup related to skipped components
2023-12-04 13:06:19 +00:00
e204b3c8ee
VideoCommon: add additional data types (int, int2, float, bool, etc) as properties of materials and some helper functions to support sending the data to the GPU
2023-12-04 00:12:31 -06:00
1c62ebc9fb
Use ExtensionNumber in Movie.cpp
2023-12-03 11:36:54 -08:00
8368a397ee
JitArm64: Flush in the middle of lmw/stmw/mfcr
...
Normally we only flush registers right at the end of each PPC
instruction. However, for PPC instructions that use a lot of registers
one at a time, it's beneficial to do this flushing work in the middle
of the instruction instead, reducing the risk of register starvation
and improving pipelining.
2023-12-03 18:42:42 +01:00
27be8c087e
Merge pull request #12295 from sepalani/arp-check
...
BBA/HLE: Fix GC homebrew if_config not working
2023-12-03 11:26:00 -05:00
98eda4dc9f
Merge pull request #12351 from TryTwo/bugfix_data_symbols
...
PPCSymbolDB. Bugfix. Fix .data symbols not loading
2023-12-03 11:17:44 -05:00
05864ceddd
PPCAnalyst: Clear crInUse on HLE
...
This should have been done when rebasing 6cc4f593e53a00ff625e
2023-12-03 14:20:45 +01:00
92532c8d3a
PPCSymbolDB. Bugfix. Fix .data symbols not loading, unless they were aligned to 4 bytes.
...
.data symbols point to memory values and can be any byte or length of bytes (such as a string).
2023-12-03 00:03:28 -07:00
69cf8b3470
VertexLoader: Use Common::SmallVector
2023-12-02 15:54:52 -08:00
4116344785
VertexLoader: Remove unnecessary calls to VertexLoader_TextCoord::GetDummyFunction
2023-12-02 15:54:52 -08:00
36796abc08
VertexLoader: Fix wrong array being used if color 1 is present but color 0 isn't
...
This worked correctly on the JIT vertex loaders, and for the equivalent case with texture coordinates. I'm not aware of any games this affects (but libogc does mention a semi-related scenario at 6bc0317c7d/gc/ogc/gx.h (L1855-L1857)
2023-12-02 15:54:52 -08:00
1ee6824324
VertexLoaderTest: Add test for skipped texture coordinates
...
Jimmie Johnson's Anything with an Engine is known to use texture coordinate 7 (and only texture coordinate 7) in some cases. There are a lot of possible edge-cases, so this test brute-forces all combinations with coordinates 0, 1, and 2.
2023-12-02 15:54:52 -08:00
4f3f208fe4
Merge pull request #12348 from JosJuice/jitarm64-imm-msr-fastmem
...
JitArm64: Fix updating MEM_REG with imm MSR without fastmem
2023-12-02 17:53:28 -05:00
2cb14edafa
Add Hardcore switch to Achievement Settings dialog
...
This adds the actual switch to turn on Hardcore Mode to the settings tab of the Achievements dialog. It is accompanied by a large tooltip warning explaining what it does and when it can be enabled.
The switch is only enabled to be turned on when no game is running, so that games are started in hardcore mode and can only be loaded via the console's memory card, as in the original hardware. Hardcore may be turned off while a game is running, but cannot be turned back on until the game is disabled.
The toggle trigger for hardcore mode also automatically disables the settings that are not allowed during hardcore mode.
Finally, the original flag in AchievementSettingsWidget to set whether things are enabled in hardcore mode (primarily Leaderboards) is replaced with the actual Hardcore Mode setting.
2023-12-02 16:41:17 -05:00
6f7e02e201
Disable TAS recording playback in hardcore mode
...
Play Input Recording would potentially unlock achievements without any player input and needs to be disabled. If a recording is already playing, hardcore mode cannot be enabled.
2023-12-02 16:41:17 -05:00
3aebbbb3e7
Disable cheats in hardcore mode
...
RetroAchievements does not allow cheats such as Action Replay or Gecko in hardcore mode, for fairness.
2023-12-02 16:41:17 -05:00
Lioncash