ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #12394 from lioncash/compare 

General: Resolve -Wsign-compare warnings
This commit is contained in:
Admiral H. Curtiss 2023-12-12 03:43:12 +01:00 committed by GitHub
parent 9326186d2c 0e51c0f8fc
commit 2c6bf2d224
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Source/Android/jni/AndroidCommon/AndroidCommon.h
View File

@ -19,8 +19,9 @@ jobjectArray VectorToJStringArray(JNIEnv* env, const std::vector<std::string>& v
template <typename T, typename F>
jobjectArray VectorToJObjectArray(JNIEnv* env, const std::vector<T>& vector, jclass clazz, F f)
{
jobjectArray result = env->NewObjectArray(vector.size(), clazz, nullptr);
for (jsize i = 0; i < vector.size(); ++i)
const auto vector_size = static_cast<jsize>(vector.size());
jobjectArray result = env->NewObjectArray(vector_size, clazz, nullptr);
for (jsize i = 0; i < vector_size; ++i)
{
jobject obj = f(env, vector[i]);
env->SetObjectArrayElement(result, i, obj);

2
Source/Core/Common/TraversalClient.cpp
View File

@ -373,7 +373,7 @@ void TraversalClient::HandleTraversalTest()
waitCondition = 0;
break;
}
else if (rv < sizeof(packet) || raddr.host != m_ServerAddress.host ||
else if (rv < int(sizeof(packet)) || raddr.host != m_ServerAddress.host ||
raddr.host != m_portAlt || packet.requestId != m_TestRequestId)
{
// irrelevant packet, ignore

2
Source/Core/Core/PowerPC/JitArm64/JitArm64_RegCache.cpp
View File

@ -248,7 +248,7 @@ void Arm64GPRCache::FlushRegisters(BitSet32 regs, bool maintain_state, ARM64Reg
ASSERT_MSG(DYNA_REC, m_guest_registers[GUEST_GPR_OFFSET + i].GetType() != RegType::Discarded,
"Attempted to flush discarded register");
if (i + 1 < GUEST_GPR_COUNT && regs[i + 1])
if (i + 1 < int(GUEST_GPR_COUNT) && regs[i + 1])
{
// We've got two guest registers in a row to store
OpArg& reg1 = m_guest_registers[GUEST_GPR_OFFSET + i];

4
Source/Core/Core/PowerPC/JitArm64/JitArm64_SystemRegisters.cpp
View File

@ -236,9 +236,9 @@ void JitArm64::twx(UGeckoInstruction inst)
constexpr std::array<CCFlags, 5> conditions{{CC_LT, CC_GT, CC_EQ, CC_VC, CC_VS}};
Common::SmallVector<FixupBranch, conditions.size()> fixups;
for (int i = 0; i < conditions.size(); i++)
for (size_t i = 0; i < conditions.size(); i++)
{
if (inst.TO & (1 << i))
if (inst.TO & (1U << i))
{
FixupBranch f = B(conditions[i]);
fixups.push_back(f);

2
Source/Core/VideoCommon/VertexManagerBase.cpp
View File

@ -598,7 +598,7 @@ void VertexManagerBase::Flush()
std::optional<CustomPixelShader> custom_pixel_shader;
std::vector<std::string> custom_pixel_texture_names;
std::span<u8> custom_pixel_shader_uniforms;
for (int i = 0; i < texture_names.size(); i++)
for (size_t i = 0; i < texture_names.size(); i++)
{
const std::string& texture_name = texture_names[i];
const u32 texture_unit = texture_units[i];

2
Source/UnitTests/Common/FloatUtilsTest.cpp
View File

@ -85,7 +85,7 @@ TEST(FloatUtils, ApproximateReciprocalSquareRoot)
0x7FF8'0000'0000'0000, 0x7FF8'0000'0000'0000, 0x3FEA'2040'0000'0000, 0x3FA0'3108'0000'0000,
0x7FF8'0000'0000'0000};
for (int i = 0; i < double_test_values.size(); ++i)
for (size_t i = 0; i < double_test_values.size(); ++i)
{
u64 ivalue = double_test_values[i];
double dvalue = Common::BitCast<double>(ivalue);