55e066a0cc
Use a consistent format for file extensions throughout HawkFile
...
also cleanup `Bind*` overloads
2021-01-20 16:31:09 +10:00
bf5833a1bf
vecrex - report 50fps in play movie dialog
2021-01-18 17:24:16 -06:00
496d6e0f94
Grey-out checkbox for single-instance mode in Config > Customize...
2021-01-19 02:46:05 +10:00
6cffc9a7cd
Add core name and system readout to Emulation menu
2021-01-19 02:27:03 +10:00
a0ebb2f551
Ensure surfaces are unlocked when disposing of GuiApi
...
actually properly fixes #2571 for real this time
2021-01-19 01:14:49 +10:00
bba4286123
Dispose of disposable ApiHawk libs when reinitialising
2021-01-19 01:12:50 +10:00
5c89d0cb15
Cache ApiContainer instead of GuiApi in Win32LuaLibraries
2021-01-19 01:09:52 +10:00
253a24edd6
Pass tool.Config.PathEntryCollection instead of the whole tool
2021-01-18 14:49:31 +10:00
ef76d8510e
Cleanup project files
2021-01-18 09:26:51 +10:00
8331ac799b
Update default hotkey bindings to use new names ( fixes #2576 )
...
fixes e2ac1aca8
2021-01-18 09:06:04 +10:00
fa07dc898f
Remove single-instance feature (keeping config and UI)
2021-01-18 08:55:54 +10:00
76b4ef6016
fix year in release date, doesn't matter for releases but dev builds might as well be accurate
2021-01-17 11:57:29 -06:00
7749d02382
Refactor DisplaySurface locking as used by ApiHawk (and Lua) ( #2575 )
...
* Refactor how the "emu" drawing surface is automatically opened/closed
fixes #2571 again
`gui.DrawNew("native")` now throws (I will replace this with something better).
`gui.DrawNew("emu")` and `gui.DrawFinish()` do nothing but print warning
messages, for backwards compatibility. This removes the feature which allowed
scripts to draw as soon as they became enabled. It also removes the feature to
draw without clearing the surface, though that wasn't working.
* Reimplement drawing to "client" surface (see desc.)
Changed surface names in APIs to "emucore" and "client" (not in DisplayManager
yet because I can't be bothered).
Via ApiHawk, `IGuiApi.WithEmuSurface(Action)` has been replaced with
`IGuiApi.WithSurface(DrawingSurfaceID, Action)`, the first param being an enum.
Via Lua (or ApiHawk), pass an extra string param (`DrawingSurfaceID` enum for
ApiHawk) to each `gui.draw*` call.
To make it less verbose, omitting the param is treated as using the default
"emucore" surface, *unless* the helper `gui.use_surface("client")` had been
called, which persists the chosen surface until Lua restarts or it's
overwritten. (The same is done when using `WithSurface` in ApiHawk, though it's
cleared once `WithSurface` returns.)
Along with the new surface names, the old names are still valid in the `surface`
params and `gui.use_surface` for now.
* Propogate enum to DisplayManager, s/Lua/ApiHawk/ in DisplayManager
2021-01-17 11:16:48 -06:00
58d24cd899
update release version and date
2021-01-17 10:44:21 -06:00
070cc59dbf
NES: Fix battery backup in certain bootgod identified games
...
If the wram with the battery backup on it is internal to the mapper asic, and not a separate ram chip, bootgod will have <chip battery=1> and not <wram battery=1>. Fixes #2570 .
2021-01-17 09:06:33 -05:00
b8a0720121
Remove old ext. tool attributes and the code using them
...
it just detected old tools and displayed a specialised error message
2021-01-17 23:44:34 +10:00
db7150642a
Remove ClientApi, deprecated in favour of IEmuClientApi
2021-01-17 23:35:05 +10:00
476eafc66f
Slightly change wording on prereq checker error message
2021-01-17 23:32:20 +10:00
742f182c32
Remove unnecessary clearing of dict entries in joypad Lua lib
...
this was done long enough ago (78d8effcf
2021-01-17 23:16:30 +10:00
187cf46670
Revert "Repair the mental damage with ZwinderStateManager having a method called HasState that doesn't actually tell you whether it has a state"
...
This reverts commit 7204eeb533
2021-01-16 18:48:19 -06:00
7204eeb533
Repair the mental damage with ZwinderStateManager having a method called HasState that doesn't actually tell you whether it has a state
...
Reverts commit 4a58ff2a0c
2021-01-16 19:26:06 -05:00
c218cf302f
MelonDS: fix system bus reporting itself as big endian when it isn't (and 4-byte read/write methods)
2021-01-16 13:59:31 -06:00
de0d0d19e2
Revert "Remove GuiLibrary from Win32LuaLibraries ( fixes #2571 )"
...
This reverts commit 9cca7c4a31
2021-01-16 13:15:27 -06:00
4a58ff2a0c
Tastudio - rework StateHistory integrity check to not use HasState() removing any possibility of a cache mismatch causing a false positive of a bad savestate
2021-01-16 13:15:02 -06:00
9cca7c4a31
Remove GuiLibrary from Win32LuaLibraries ( fixes #2571 )
...
Wrapping draw calls in DrawNew/DrawFinish is the responsibility of the script
author. This removes the feature which allowed scripts to draw as soon as they
became enabled. see also #2501 (still broken)
2021-01-17 04:25:45 +10:00
c28a12a410
fix previous commit, new up a new state manager, also pop up a message to the user. Anyone can feel free to improve the error message
2021-01-16 11:12:20 -06:00
2f6bbd155f
add natt suggestion of a try/catch attempts to load tasproj greenzone, puts a big ol piece of duct tape on the real problem but at least users can continue to use their file, fixes #2479 about as well as we can since we have no info as to how the greenzone got corrupted in the first place
2021-01-16 11:00:30 -06:00
97e4d42b7b
TAStudio macros: fix regression from commit 5bbdf2a caused by bad order of operations (remove ?? operator entirely since we have already checked that the values exist)
2021-01-16 10:10:34 -06:00
dda09dd713
MovieZone: refactor constructors, reducing duplicate code (fixes regression from commit aa80c3a)
2021-01-16 10:10:34 -06:00
2834f8aa39
TAStudio:
...
-Dis/enable recent macros menu along with other macro menu items.
-Remove redundant code from commit 350724a, make use of existing method.
-Fix regressions from commits 0d72cd9cb912be
2021-01-16 10:10:34 -06:00
4d06fb1fde
TAStudio: don't rely on a broken instance of a tool form for macro saving/loading
2021-01-16 10:10:34 -06:00
5641757b98
Bounds check index on background color check, fixes #2572
2021-01-16 09:26:33 -05:00
26fb9b9694
InputRoll: fix comparing of cells with null column names
2021-01-15 17:47:57 -06:00
764f4ad81e
InputRoll: fix right-click cell selection (use OnMouseMove instead of a separate logic that was being used purely because MouseMove wasn't being triggered, display the new selection so the user knows what's up, invoke SelectedIndexChanged event)
2021-01-15 17:42:49 -06:00
3ccd10bb36
Add missing access modifier
2021-01-16 07:35:55 +10:00
f2747b31b0
add an option to capture the Lua without capturing the full OSD, when… ( #2527 )
...
* add an option to capture the Lua without capturing the full OSD, when recording an AVI
* revert designer changes from commit 146022c
2021-01-15 15:03:46 -06:00
889d3262b1
Input roll scrolling ( #2528 )
...
* Change the BranchView's ScrollSpeed property to 1. The MarkerControl's is 1, and I assume that ScrollSpeed used to be pixel-based and the value of 13 is an accidental left-over.
* Standard behavior for scroll bars across a majority of other applications is for the up/down buttons to scroll 1 unit at a time while wheel may scroll multiple units at a time. So, do this. (Previous behavior was that both methods of scrolling would scroll by the same amount.)
2021-01-15 15:03:18 -06:00
b3e69782dd
Drive states2 ( #2542 )
...
* Expose new backing store type functionality for ZwinderBuffer.
* implement drive states for reserved states
* Include version numbers in Zwinder custom file formats, and for newer files rely on the separately loaded settings. With this, TempFile store types are supported when saving/loading.
2021-01-15 15:02:00 -06:00
6c5447f5da
ZwinderStateManager: Use the gap buffer for forced capture to avoid crowding the "current" buffer and thus reducing it's actual span of covered frames. ( #2569 )
...
also remove a redundant conditional
2021-01-15 14:54:47 -06:00
961e7f2808
move this piece of init code; fixes: opening TAStudio after starting a .tasproj would fail
2021-01-15 11:52:04 -06:00
302cda6d17
ZwinderStateManager: don't erase states that should be reserved!
2021-01-15 11:36:35 -06:00
69af966a2d
TAStudio undo history form: make use of TAStudio methods, so that rewinds necessary to stay inside the greenzone happen. (also refresh after "to here" un/redo)
2021-01-15 11:16:23 -06:00
b6d77586af
Do not attempt to remove what isn't there. (fixes: removing a marker before a state was reserved would throw an exception.)
2021-01-15 09:38:08 -06:00
6424e35c6a
Revert "Replace unnecessary init props w/ ctors, remove hack for init props"
...
This reverts commit af8a330422
2021-01-15 08:47:09 -05:00
dd39e95be6
Fix passing the wrong string as param for Bk2LogEntryGenerator ctor
...
fixes 0d2f01462#2567
not sure if the fallback in LogGeneratorInstance is a good idea but it works
2021-01-15 22:44:39 +10:00
85f24ca486
Remove file extension check from SharpCompressDearchivalMethod
...
caused .lsmv to not be recognised (it's .zip), wasn't strictly necessary anyway
2021-01-15 22:14:43 +10:00
af8a330422
Replace unnecessary init props w/ ctors, remove hack for init props
2021-01-15 21:39:43 +10:00
7f0947108c
Fix importing DSM files, fixes #2114
2021-01-14 21:32:47 -05:00
7a5408995e
sameboy: a bit more cleanup with the printer callback
2021-01-14 19:24:06 -05:00
6981dc781b
Make a few small GBHawk cleanups I forgot from the other commit
...
No need to preemptively LockGPU before calling a scanline callback, that all Just Werkz now.
2021-01-14 19:20:20 -05:00
0b432994df
Rework GB GPU memory areas API ( #2566 )
...
* Rework GB GPU memory areas API
All cores can easily implement it now with no copying or awkward garbage. Also fix the scanline callback and printer callback in Sameboy, which had been broken for some time.
Fixes #2564
2021-01-14 19:17:40 -05:00
e71506ac6a
Refactor OpenTK gamepad management (the static stuff)
...
maybe fixes #2429
2021-01-15 05:39:24 +10:00
d2fb794340
Pass forced core through other paths in RomLoader
...
fixes c0b6bf61b; not sure if this matters currently (PCE-CD maybe?) but it may
become important if we add more alternate cores
2021-01-15 04:33:14 +10:00
e65e77e7cd
GB GPU Viewer: Bounds check tile drawing for OBJ window, seems to resolve random crashing
2021-01-14 09:50:46 -05:00
c0b6bf61b1
Pass through queued movie's Core header to RomLoader and load only it
2021-01-14 03:52:32 +10:00
428e2fe006
GBHawk: Onl save audio cycles in SubGBHawk where it's needed, fixes state integrity checker in TAStudio
2021-01-13 09:11:40 -05:00
72e8fa031e
Fix for state gap when frame advancing and painting input ( #2563 )
...
* Fix for state gap when frame advancing and painting input
* simplify
2021-01-12 20:32:44 -06:00
39c0011d09
Move around some error messages
...
See #2561 . From the point of view of romloader, this is all pretty simple: It asks for a particular settings type. It should either get null back (indicating there was nothing, use defaults), or an object of that type. Providing a completely unrelated type is baloney. So this check here is a stupid defensive check that shouldn't be needed. MainForm cannot be trusted.
2021-01-12 09:32:58 -05:00
47c98c6a5e
GBHawk: fix debugger disassembler
2021-01-10 14:02:01 -05:00
f79b7e5be4
Fix order of arguments to GetRelativePath
...
These have been backwards since the feature was added (5f2e2f39b
2021-01-10 22:43:40 +10:00
ea0d6b04d8
Fix code style
2021-01-10 19:30:18 +10:00
bcee6d4d39
Fix syncless recorder
2021-01-09 22:20:16 -05:00
a67d01f04d
Update cheat inde on button press: Fixes #2550
2021-01-09 20:05:10 -05:00
75a655fdd8
Fix screwup in romloader xmlgame handling
...
This may have only affected Saturn in practice. Whoops! Fixes #2557 .
2021-01-09 11:45:16 -05:00
9ed56cdc6e
Remove cached global ICodeDataLogger (emu core) in CDL ( fixes #2553 )
...
fixes 234642ed0; this was never going to work because the setter will only be
called by `ServiceInjector.UpdateServices` during a core restart, at which time
the previous core should already have been `Dispose`d. If you want to call
`.SetCDL(null)` on the core when restarting (even though closing the CDL window
already does that three times?), do it in the core's `Dispose` implementation.
2021-01-09 23:13:36 +10:00
71ad6deff3
Ensure existing global IEmulator is disposed when reassigning it
2021-01-09 23:02:22 +10:00
5078ac392b
Simplify null-safety checks in GetEnumFromDescription<T : Enum>
2021-01-09 05:13:57 +10:00
979afcb54d
Do something cleverer than throwing NRE in a few places
2021-01-09 05:08:09 +10:00
e976e0c2ad
Use nameof in DeepEquality, fix typo
2021-01-09 04:54:02 +10:00
ecafbde89d
Let's not break the entire fucking program brahs
2021-01-08 13:41:15 -05:00
0272684cdf
Fix domain names in GBHawk CDL ( fixes #2552 )
...
fixes 7e00b7892
2021-01-09 02:55:14 +10:00
5a8c58de3c
Look mom, I'm using the new C#
2021-01-08 08:52:24 -05:00
cbdcba9643
Fix BS93 garbage
...
Probably. Not sure what this does anymore, but 4 is right and 6 is wrong.
2021-01-06 11:20:37 -05:00
0ea597ded5
Fix GBA Game Shark code conversion ( fixes #2545 )
2021-01-06 18:47:05 +10:00
fa5ed36f63
Add boilerplate for unit testing GameSharkDecoder
...
should fail without the following commit
2021-01-06 18:46:36 +10:00
ab3846906f
Use type checks for DecodeResult/InvalidCheatCode
2021-01-06 17:25:05 +10:00
966b8a974a
string.Trim doesn't remove NUL
...
I'm also skeptical of the `if (bs93/*=br.ReadBytes(6)*/ == "BS93") { ... }` just
after this, it doesn't seem the condition can ever be met...
2021-01-06 16:54:23 +10:00
c1a734a04d
Update the NuGet deps which should be safe to update
2021-01-02 20:31:54 +10:00
4e668612c7
Convert LoadCueJob.TrackInfo to a readonly struct
2021-01-02 20:15:17 +10:00
84a6c5a426
Convert CUE_File.Command.* to readonly structs with a superinterface
2021-01-02 20:05:06 +10:00
277f57eebd
Convert CompileCueJob.CompiledCueIndex to a readonly struct
2021-01-02 18:35:00 +10:00
d87066c634
Convert Blob_ECM.IndexEntry to a readonly struct
2021-01-02 18:14:12 +10:00
bb1f7da864
Remove duplicate class Blob_WaveFile.Blob_RawFile
2021-01-02 17:52:23 +10:00
449130e081
Move inner classes of Disc up a level, make Disc not partial
2021-01-02 17:40:39 +10:00
e24c4c3971
Move CDFS (iso-parser) to new external project, update upstream info
2021-01-02 17:34:13 +10:00
333cae15cd
Convert IN_* props of jobs to ctor-initialised readonly fields
2021-01-02 16:10:57 +10:00
f284fda3a6
Object.Equals(object) overrides should not throw
...
Especially not if you pass null. null is simply not equal to this, that's all. The post condition is satisfiable; you can return false.
2021-01-01 17:06:59 -05:00
51b62629c6
Enable nullability in most of the remaining files in BizHawk.Common
2021-01-02 02:39:13 +10:00
021d8e6e92
Fix: LuaSandbox wasn't reverting current directory after sandboxed operations. Appears to be a regression from commit 5e89e56.
2021-01-01 06:34:05 -06:00
89c69c382c
GBHawk: implement LCDC write glitch for gbc-acid-hell
2020-12-30 19:31:30 -05:00
90c0214d5e
Add prop IMemoryApi.MainMemoryName, further delegate mainmemory lib
2020-12-30 16:02:05 +10:00
1619b33e8e
Fix overlapping/duplicate controls in FirmwaresConfig's menu on Mono
2020-12-30 01:25:30 +10:00
a80dbfa76b
Fix crash when clicking on column headers in FirmwaresConfig on Mono
2020-12-30 00:07:47 +10:00
d0edf350f2
Finish my nullability pass over ControlExtensions.cs
2020-12-30 00:03:39 +10:00
2de32ed59a
Move more sound classes to Client.Common
2020-12-29 17:04:02 +10:00
9cfe9485ef
Fix covariant arrays (passing ASupertype[] where AType[] is expected)
2020-12-29 16:53:31 +10:00
206a3e30c8
Cleanup instantiation of FirmwaresManager and PathConfig
...
and remove unused MainForm interface prop
2020-12-29 16:26:01 +10:00
18ebfecc97
Move GuiApi (impl.) to Client.Common
2020-12-29 15:53:47 +10:00
7edf3b36ad
Extract a tiny interface from DisplayManager for ApiHawk
2020-12-29 15:52:57 +10:00
0704db5940
Move OSDManager to Client.Common and move types to own files
2020-12-29 15:40:13 +10:00
23a8387dc1
Replace IBlitterFont w/ the type wrapped by its sole inheritor
2020-12-29 15:36:37 +10:00
47670714b5
Remove WinForms dep from GuiApi (impl.)
2020-12-29 15:08:01 +10:00
8e67d82bd5
Rename file to match type name
2020-12-29 15:00:55 +10:00
f431faf65c
Move some DiscoHawk logic to Emulation.DiscSystem
2020-12-29 15:00:25 +10:00
1a21765be6
Fix assembly resolution in DiscoHawk on Mono
...
without this the program wouldn't open at all, I assume all of its actual
functions will just workTM now
2020-12-29 01:33:57 +10:00
a0c7e9c7fb
Fix non-string resource in DiscoHawk
2020-12-29 01:26:56 +10:00
c0cf40b68e
Check for MAME's lib before instantiating the MAME core ( fixes #2538 )
2020-12-29 01:04:36 +10:00
f4e98fd9bd
Refactor ZWinderBuffer to allow use of arbitrary backing Streams ( #2536 )
2020-12-27 18:36:42 -05:00
bcf5347823
Use C# 9 improvements to switch / "pattern matching"
2020-12-28 00:07:06 +10:00
96f9e8f6e4
Encapsulate MessageBox.Show using IDialogController and some helpers
...
a lot of the calls to `DialogController.ShowMessageBox` from `ToolFormBase`
inheritors could be replaced with `this.ModalMessageBox` (i.e. add self as
parent window)
2020-12-28 00:03:00 +10:00
9cafddb1e0
Minor cleanup to improve readability
2020-12-28 00:00:39 +10:00
a928d1887f
fix: Attempted to evict state 0, and attempted to modify collection while enumerating
2020-12-25 09:59:32 -06:00
62f90f11f2
Make anything inheriting FormBase slightly less ugly on Linux
2020-12-26 00:44:21 +10:00
515f5cf9b0
GBHawk: update RAM state for GBA mode
2020-12-24 19:45:44 -05:00
42fc895e12
Update EmuHawk project file
...
these files were removed in b9b1e2d23
2020-12-23 16:46:03 +10:00
b9b1e2d237
Move Quantize to new external project, update upstream info
2020-12-23 16:37:47 +10:00
faba9035b7
Update attribution of ported code
2020-12-23 15:55:50 +10:00
28c35a6274
GBHawk:set initial HRAM to 0, this provides consistent sync when clearing RAM on console, where as 0xFF does not
2020-12-22 20:20:00 -05:00
60d2bfa85c
Bump C# language level for ReSharper/Rider
2020-12-22 20:07:35 +10:00
b9c9144358
Fix new dep not being copied to output, causing crashes
...
fixes 1e37350e9
2020-12-22 19:57:55 +10:00
1e37350e99
Use NuGet package instead of copy-pasted code in BizwareGL/Borrowed
...
Our copy was equivalent to version 1.0.0 + a patch which allowed Stream instead
of requiring a filename, so I've used 1.0.2 as it has the author's
implementation of the same feature.
There are more recent versions available (note, 1.0.2 isn't for .NET Core).
NuGet: https://www.nuget.org/packages/Cyotek.Drawing.BitmapFont
Project repo: https://github.com/cyotek/Cyotek.Drawing.BitmapFont
2020-12-22 19:48:50 +10:00
a5fd5f5d78
Return the tool from IToolApi.GetTool instead of its type
...
also affects Lua client.gettool; this has been broken for quite a while
2020-12-22 18:47:32 +10:00
5a098055d7
Fix Lua client.createinstance calling the wrong ApiHawk method
...
fixes e6cb74d31
2020-12-22 18:46:42 +10:00
03b4ae18e0
Move Virtual Pads schemata to Cores
2020-12-22 18:37:27 +10:00
790a09067e
Cleanup LINQ in VirtualpadTool.CreatePads
2020-12-22 18:34:27 +10:00
9124b0f3b5
Pass MessageBox.Show to Virtual Pads schemata as callback
2020-12-22 18:18:40 +10:00
0ff60220f7
Use enum to represent button images in Virtual Pads schemata
2020-12-22 15:35:26 +10:00
50b17096e1
Remove WinForms dep from Virtual Pads schemata
2020-12-22 14:07:28 +10:00
9168b59382
Add base interface for *CheckBoxEx and *RadioButtonEx controls
2020-12-21 16:58:49 +10:00
56b158e72a
minor comment clarification
2020-12-20 21:06:22 -05:00
b5b1e17851
Fix eviction logic for _gapFiller. (we were attempting to remove the wrong value from StateCache, and also weren't checking for reserved)
2020-12-20 18:06:50 -06:00
01bcf22802
Deal with this TODO. Removing from the StateCache here was removing extra frames. (frames between the old last gap frame and new last gap frame which were in another buffer)
2020-12-20 18:04:02 -06:00
55c08dc77f
Revert "misc cleanups in neshawk boards, mostly removing redundant else's"
...
This reverts commit 2b5d0b6219
2020-12-20 15:26:08 -05:00
3d84812341
add a Lua method to get inputs from the movie ( #2526 )
2020-12-20 13:16:28 -06:00
2b5d0b6219
misc cleanups in neshawk boards, mostly removing redundant else's
2020-12-20 13:12:51 -06:00
374f646f75
CoreInventory tweaks
...
When constructing a core using ConstructorInfo.Invoke, any exceptions thrown by the core are packaged inside TargetInvocationExceptions. This has no value to us -- the fact that reflection is used is an implementation detail, and it breaks checking specific exceptions for specific information. Accordingly, consumers have to deal with e.InnerException checks. Fix this up so that we only expose the actual exception thrown.
In addition, undo a bad change in 6225e7854b
2020-12-20 09:15:22 -05:00
7bb5506ba8
remove 2 deprecated nes library methods (add/remove game genie), they were marked deprecated for enough releases that I think we can go ahead and remove them
2020-12-19 20:17:26 -06:00
6225e7854b
a few cleanups in CoreInventory.cs
2020-12-19 20:07:09 -06:00
68f9ac9730
remove unused usings in Emulation.Cores
2020-12-19 20:03:37 -06:00
aaa1c8e7a8
AutofireController - remove autofire flag that was always true
2020-12-19 18:55:22 -06:00
c730a78994
remove redundant null check before assigning null
2020-12-19 13:43:04 -06:00
ec5e88c808
fix: loading a tasproj wouldn't set autofire (despite the gui showing it did)
2020-12-19 13:42:10 -06:00
3cc9684ebd
GBHawk: better initial RAM state
2020-12-17 21:02:41 -05:00
fe5655d1e3
misc cleanups in BizHawk.Common
2020-12-15 17:54:44 -06:00
cb6ef03982
use explicit private/internal modifiers
2020-12-15 16:49:23 -06:00
b83556fc6f
make fields readonly where possible
2020-12-15 16:00:55 -06:00
213729550d
remove redundant array initializers
2020-12-15 16:00:55 -06:00
eeca40e072
libsnes: Cache region from core once at start
...
The region value in the comm struct is set once and then gets wiped out later. I don't know what wipes it, but so many things have their hands on that, it's not surprising. Someone knew about this and handled _mapper appropriately, but not _region.
Fixes #2503
2020-12-15 08:51:08 -05:00
a8e2a420f0
GBHawk: cleanup
2020-12-14 19:32:22 -05:00
08f1b69197
GBHawk: prep for future audio work
2020-12-14 19:30:22 -05:00
YoshiRulz