Remove cached global ICodeDataLogger (emu core) in CDL (fixes #2553)
fixes 234642ed0; this was never going to work because the setter will only be called by `ServiceInjector.UpdateServices` during a core restart, at which time the previous core should already have been `Dispose`d. If you want to call `.SetCDL(null)` on the core when restarting (even though closing the CDL window already does that three times?), do it in the core's `Dispose` implementation.
This commit is contained in:
parent
71ad6deff3
commit
9ed56cdc6e
|
@ -49,18 +49,8 @@ namespace BizHawk.Client.EmuHawk
|
|||
[RequiredService]
|
||||
private IMemoryDomains MemoryDomains { get; set; }
|
||||
|
||||
private ICodeDataLogger _icdlogger;
|
||||
|
||||
[RequiredService]
|
||||
private ICodeDataLogger CodeDataLogger
|
||||
{
|
||||
get => _icdlogger;
|
||||
set
|
||||
{
|
||||
_icdlogger?.SetCDL(null);
|
||||
_icdlogger = value;
|
||||
}
|
||||
}
|
||||
private ICodeDataLogger CodeDataLogger { get; set; }
|
||||
|
||||
private string _currentFilename;
|
||||
private CodeDataLog _cdl;
|
||||
|
|
Loading…
Reference in New Issue