Pokechu22
f3f466ae82
DSPDisassembler: Fix LSR/ASR formatting
...
Originally, 1479 (for example) would disassemble as `lsr $ACC0, #-7`. At some point (likely the conversion to fmt), this regressed to `lsr $ACC0, #4294967289`. Now, it disassembles as `lsr $ACC0, #7`.
2021-07-31 13:18:07 -07:00
Léo Lam
3b88ffbe60
Merge pull request #9978 from JosJuice/jit-ibat-table
...
Jit: Use ibat_table for dcbf/dcbi/dcbst address check
2021-07-31 18:59:17 +02:00
JosJuice
5c5de35568
Jit: Use ibat_table for dcbf/dcbi/dcbst address check
...
Minor mistake in 92d1d60
. We should be using ibat_table instead
of dbat_table, since we're dealing with invalidating icache.
2021-07-31 14:30:03 +02:00
Tilka
0470be5884
Merge pull request #9972 from Pokechu22/validation-layer
...
Recompile shaders when 'Enable API Validation Layers' is toggled
2021-07-31 10:16:47 +01:00
Mai M
bef1fdb4cb
Merge pull request #9974 from JosJuice/jitarm64-mtfsfix
...
JitArm64: Implement mtfsfix
2021-07-31 03:56:51 -04:00
Tillmann Karras
655bff5d44
DSPHLE: include compressor state in save states
2021-07-31 04:16:26 +01:00
Pokechu22
d36282ae61
Qt: Un-maximize GBA widget before resizing it
2021-07-30 18:50:45 -07:00
Léo Lam
a208ff5aab
Merge pull request #9957 from JosJuice/dcbx-faster
...
Jit: Perform BAT lookup in dcbf/dcbi/dcbst
2021-07-31 03:27:24 +02:00
Tilka
48af29f4ce
Merge pull request #9968 from Tilka/ax2
...
DSPHLE: add support for dynamic range compression
2021-07-31 00:43:17 +01:00
Tillmann Karras
09faf0987d
DSPHLE: add support for dynamic range compression
...
The CPU-side AX library enables it by default and uses hardcoded parameters.
CMD_COMPRESSOR_TABLE_ADDR (0x0A) was incorrect. It's always a nop on the
GameCube and was probably confused with the Wii version.
2021-07-31 00:05:49 +01:00
JosJuice
0e62dac4bb
JitArm64: Implement mtfsfix
...
Part 5 of 6 of implementing the FPSCR system register instructions.
2021-07-30 10:24:41 +02:00
JosJuice
08b358a829
Jit64: Fix minor fmaddXX inefficiencies
2021-07-29 23:34:20 +02:00
JosJuice
93e636abc3
Jit: Use accurate negation order for FMA instructions
...
It was believed that this only mattered when the rounding mode was
set to round to infinity, which games generally don't do, but it
can also affect the sign of the output when the inputs are all zero.
2021-07-29 23:33:35 +02:00
Pokechu22
087ddfca83
Mention 'Enable API Validation Layers' also enabling symbols for D3D
2021-07-28 21:35:36 -07:00
Pokechu22
6db519793a
AdvancedWidget: Fix strange text wrapping
2021-07-28 21:35:36 -07:00
Pokechu22
b6d2938731
Recompile shaders when 'Enable API Validation Layers' is toggled
2021-07-28 21:35:36 -07:00
Pokechu22
eb81968fe6
Convert ShaderHostConfig to BitField
2021-07-28 21:35:36 -07:00
Mai M
c86c02e46b
Merge pull request #9960 from JosJuice/jitarm64-mtfsb1x
...
JitArm64: Implement mtfsb1x
2021-07-28 20:46:09 -04:00
Mai M
28ee0af9a3
Merge pull request #9970 from JosJuice/jit64-fmaddxx-accurate-nan
...
Jit64: Fix fmaddXX with accurate NaNs
2021-07-28 20:45:00 -04:00
Léo Lam
11d126965a
Merge pull request #9967 from Pokechu22/max-aniso-note
...
Remove note about anisotropic filtering requiring edge LOD
2021-07-29 02:02:30 +02:00
Léo Lam
0553b4a241
Merge pull request #9954 from Tilka/ax
...
DSPHLE: fix problems with older ucodes
2021-07-29 01:42:24 +02:00
JosJuice
3bb4a4e344
Jit64: Fix fmaddXX with accurate NaNs
...
So it turns out you have to pass XMM0 as the clobber register
to HandleNaNs, because HandleNaNs uses BLENDVPD and BLENDVPD
implicitly uses XMM0, and nobody noticed when I broke this in
2c38d64
because nobody plays the one game that needs accurate NaNs.
2021-07-28 23:03:03 +02:00
Pokechu22
1640fa9096
Remove note about anisotropic filtering requiring edge LOD
...
This was added because YAGCD's info on MAXANISO (near TX_SETMODE0 in Section 5.11.1) claims it's the case, but Extrems says it does work. I haven't tested anything myself, and dolphin still does not actually implement anisotropic filtering based on this field.
2021-07-27 19:33:31 -07:00
JosJuice
ca55d599e8
Jit: Mark ValidBlockBitSet::Test as const
2021-07-27 11:11:30 +02:00
Tilka
7fe97b27de
Merge pull request #9958 from Tilka/dspspy
...
DSPSpy: fix $prod printing
2021-07-26 00:43:17 +01:00
OatmealDome
46e331d000
VideoBackendBase: Prefer Vulkan over OGL on macOS Mojave and newer
2021-07-25 19:21:06 -04:00
Simonx22
9a33fd3f7f
Android: update dependencies
2021-07-25 16:23:18 -04:00
JosJuice
c9a4021537
JitArm64: Implement mtfsb1x
...
Part 4 of implementing the FPSCR system register instructions.
2021-07-25 19:18:43 +02:00
Tilka
3e04cb6e6b
Merge pull request #9959 from Bonta0/gba-qol
...
Qt: GBA QoL improvements
2021-07-25 17:23:57 +01:00
Tillmann Karras
14da138ed9
DSPHLE: fix and re-enable polyphase resampling
...
This fixes the title screen music of Snowpack Park.
2021-07-25 15:45:06 +01:00
Tillmann Karras
a5dfd65eb4
DSPSpy: fix $prod printing
2021-07-25 15:15:15 +01:00
JosJuice
92d1d60ff1
Jit: Perform BAT lookup in dcbf/dcbi/dcbst
...
When 66b992c
fixed https://bugs.dolphin-emu.org/issues/12133 ,
it did so by removing the broken address calculation entirely and
always using the slow path. This caused a performance regression,
https://bugs.dolphin-emu.org/issues/12477 .
This commit instead replaces the broken address calculation with
a BAT lookup. If the BAT lookup succeeds, we can use the old fast
path. Otherwise we use the slow path.
Intends to improve https://bugs.dolphin-emu.org/issues/12477 .
2021-07-25 15:15:15 +02:00
JosJuice
b84a0704cd
Revert "Jit: Fix correctness issue in dcbf/dcbi/dcbst"
...
This reverts commit 66b992cfe4
.
A new (additional) correctness issue was revealed in the old
AArch64 code when applying it on top of modern JitArm64:
LSR was being used when LSRV was intended. This commit uses LSRV.
2021-07-25 15:13:57 +02:00
Pokechu22
3a4d8379bf
Convert NaN to 1 when generating texture coordinates
...
This fixes eyelids in Shadow the Hedgehog during cutscenes (https://bugs.dolphin-emu.org/issues/11458 )
2021-07-24 22:20:35 -07:00
Tilka
55a465c6e6
Merge pull request #9949 from JosJuice/wia-ice-3
...
DiscIO: Fix broken workaround for MSVC ARM64 ICE
2021-07-25 05:14:10 +01:00
Tilka
c42b1c1b9f
Merge pull request #9921 from Pokechu22/non-power-of-2-wrap
...
Software: Handle texture wrapping more accurately
2021-07-25 05:08:11 +01:00
Bonta
cfd0f4661f
Qt: Implement GBA Interframe Blending
2021-07-24 20:34:26 +02:00
Tillmann Karras
f7948ce7c9
DSPHLE: fix Wii System Menu 1.0 ucode
2021-07-24 19:04:39 +01:00
Bonta
6fc060bdca
Qt: AlwaysOnTop GBA widget option
2021-07-24 20:00:16 +02:00
Bonta
501868ace0
Qt: Make GBA widgets movable with left click in borderless mode
2021-07-24 19:37:39 +02:00
Bonta
63ff86adff
Qt: Borderless GBA windows
2021-07-24 19:12:17 +02:00
Tillmann Karras
b1185fb239
DSPHLE: handle Wii Startup Menu ucode correctly
2021-07-24 16:57:12 +01:00
Bonta
ee64e217f4
Qt/Core: Refactor GBA Core accessors
2021-07-24 14:54:57 +02:00
JosJuice
5fe23ccc3e
DiscIO: Fix broken workaround for MSVC ARM64 ICE
...
The workaround added in 30f9f31
caused a regression where Dolphin
incorrectly replaced runs of one byte with runs of another byte
when writing WIA and RVZ files. ReuseID::operator< was always
returning false unless the ReuseIDs being compared had different
partition keys, which caused std::map<ReuseID, GroupEntry>
to treat all ReuseIDs with the same partition key as equal.
2021-07-24 13:29:03 +02:00
Dentomologist
cb127509e1
WiimoteReal: Fix Dolphin shutdown crash
...
Clear m_scan_thread_running later to avoid accessing m_backends after it
has been cleared.
2021-07-23 17:17:11 -07:00
JosJuice
f70df930a6
Android: Adjust DSP selection names
...
The Android strings were not updated in 59e6048
along with the
DolphinQt strings.
2021-07-23 08:57:39 +02:00
Mai M
f380c23fda
Merge pull request #9890 from JosJuice/jitarm64-mtfsb0x
...
JitArm64: Implement mtfsb0x
2021-07-22 21:41:01 -04:00
Mai M
971f110b99
Merge pull request #9937 from Techjar/netplay-split-save-sd-write
...
NetPlay: Split save and SD card write settings
2021-07-22 21:40:31 -04:00
Mai M
4f87821f21
Merge pull request #9938 from Pokechu22/e-reader-context-menu-item
...
GBA: Add "Scan e-Reader Card(s)" context menu item
2021-07-22 21:39:10 -04:00
Mai M
885a4646f8
Merge pull request #9941 from JMC47/dsprecommendations
...
AudioPane: Adjust DSP selection names
2021-07-22 21:37:49 -04:00
JMC47
59e6048200
AudioPane: Adjust DSP selection names
2021-07-22 20:59:35 -04:00
Pokechu22
bcf2c6b9b9
MemoryViewWidget: Remove unnecessary column
...
This column would end up containing junk data after changing the data type.
2021-07-22 17:39:35 -07:00
Markus Wick
5af5656383
Merge pull request #9932 from JosJuice/jitarm64-dcbz-backpatch
...
JitArm64: Fix dcbz backpatch
2021-07-23 01:58:59 +02:00
Markus Wick
8ad7508620
Merge pull request #9767 from JosJuice/jitarm64-fpr-callee-saved
...
JitArm64: Improve Arm64FPRCache::GetCallerSavedUsed
2021-07-23 01:53:44 +02:00
Pokechu22
50109d70b6
GBA: Add "Scan e-Reader Card(s)" context menu item
2021-07-22 12:18:07 -07:00
JosJuice
db5a78781f
Merge pull request #9929 from Tilka/ax
...
DSPHLE: re-enable low-pass filter
2021-07-22 19:05:29 +02:00
JosJuice
484279f013
Merge pull request #9933 from Dentomologist/remove_stringutil_buildcompletefilename
...
StringUtil: Remove unused function BuildCompleteFilename
2021-07-22 19:05:07 +02:00
JosJuice
fdcea8566d
JitArm64: Improve Arm64FPRCache::GetCallerSavedUsed
...
If we're only using the lower 64 bits of a callee-saved
register, GetCallerSavedUsed can return false for it.
2021-07-22 10:42:44 +02:00
Techjar
3ce5caf887
NetPlay: Split save and SD card write settings
...
This actually eliminates any setting pertaining to SD cards from the
NetPlay dialog, as it would effectively just be a duplicate of the
setting in the Wii pane, potentially causing confusion.
This also enables save data writing by default, as this is probably
what most players want, and should avoid them losing hours of progress
because they forgot to tick a checkbox.
2021-07-22 01:16:20 -04:00
Dentomologist
f5e5e8553c
StringUtil: Remove unused function BuildCompleteFilename
2021-07-21 12:39:00 -07:00
JosJuice
1df3456267
JitArm64: Remove a comment in dcbz implementation
...
This implementation is pretty efficient in my opinion. And "As
long as we aren't falling back to interpreter we're winning a lot"
applies to basically every instruction to some degree anyway.
2021-07-21 19:24:41 +02:00
JosJuice
d91d6fcdc5
JitArm64: Fix dcbz backpatch
...
The dcbz instruction needs to lock W30 so that the slowmem code will
push and pop it when calling into C++. Also, the slowmem code expects
that the address is present in W0, so replace the use of W0 as a scratch
register in the fastmem code with the now locked W30.
2021-07-21 19:19:52 +02:00
JosJuice
302b47f5e6
JitArm64: Add temp reg parameter to Arm64RegCache::Flush
...
We currently have a bug when calling Arm64GPRCache::Flush with
FlushMode::MaintainState, zero free host registers, and at least
one guest register containing an immediate. We end up grabbing
a temporary register from the register cache in order to be
able to write the immediate to memory, but grabbing a temporary
register when there are zero free registers causes the least
recently used register to be flushed in a way which does not
maintain the state of the register cache.
To get around this, require callers to pass in a temporary
register in the GPR MaintainState case. In other cases,
passing in a temporary register is not required but can help
avoid spilling a register (if the caller already had a
temporary register at hand anyway, which in particular will
be the case in my upcoming memcheck pull request).
2021-07-21 16:28:19 +02:00
CrystalGamma
c991904e04
PowerPC: Add reservation monitor to save state
2021-07-21 12:14:07 +02:00
CrystalGamma
d763d693e8
PowerPC: Move lwarx/stwcxd. reservation into PowerPCState
2021-07-21 12:12:19 +02:00
Léo Lam
9a91b867ab
Merge pull request #9912 from Pokechu22/memory-viewer-physical-mem2
...
Fix MEM2 in the memory viewer in physical mode
2021-07-21 11:37:15 +02:00
JosJuice
a3c8fb06c5
NetPlayClient: Remove a designated initializer
...
release-ubu-x64 currently fails with "sorry, unimplemented: non-trivial
designated initializers not supported". pr-ubu-x64 doesn't for some
reason, but we might as well remove the designated initializer.
2021-07-21 09:36:52 +02:00
JosJuice
b2d87c49b6
JitArm64: Implement mtfsb0x
...
Part 3 of implementing the FPSCR system register instructions.
2021-07-21 09:22:13 +02:00
JMC47
a1e806ed76
Merge pull request #9600 from Bonta0/mgba-pr
...
Full GBA Controllers Integration with mGBA
2021-07-21 02:36:43 -04:00
Tillmann Karras
4a5c723114
DSPHLE: re-enable low-pass filter
...
Maybe this got fixed? Sonic Colors probably needs it for underwater audio.
2021-07-21 03:59:25 +01:00
Pokechu22
fa9c43cfaa
Software: Handle texture wrapping more accurately
...
This fixes various texture offsetting issues with negative texture coordinates (bringing the software renderer in line with the hardware renderers). It also handles the invalid wrap mode accurately (as was done for the hardware renderers in the previous commit). Lastly, it handles wrapping with non-power-of-2 texture sizes in a hardware-accurate way (which is somewhat broken looking, as games aren't supposed to use wrapping with non-power-of-2 sizes); this has not been done for the hardware renderers.
2021-07-20 19:23:23 -07:00
Pokechu22
19332575aa
WrapMode=3 behaves the same as Clamp
2021-07-20 19:23:23 -07:00
JMC47
b515786c8d
Merge pull request #9927 from OatmealDome/double-usbgecko
...
GeckoSockServer: Only join connectionThread if it is joinable
2021-07-20 22:18:33 -04:00
OatmealDome
48bcd96526
GeckoSockServer: Only join connectionThread if it is joinable
2021-07-20 14:56:09 -04:00
JosJuice
92fc4f1eca
PixelShaderGen: Fix OpenGL ES bounding box compilation error
2021-07-20 11:39:32 +02:00
Techjar
5e0520b6e0
VideoCommon: Expand vector comparisons instead of overloading any()
...
For whatever stupid reason, Mali drivers do not allow overloading
built-in functions.
2021-07-20 05:24:47 -04:00
Dentomologist
fe670a3e68
FileUtil: Remove duplication in FileInfo constructor
2021-07-19 11:50:17 -07:00
Pokechu22
2d460b8e31
Fix MEM2 in the memory viewer in physical mode
2021-07-18 13:09:42 -07:00
Tillmann Karras
c948d7f436
PostProcessing: fix link error when switching shaders
...
Switching to a post-processing shader with different configuration options will
change the UBO, so we need to recompile the vertex shader as well.
2021-07-18 04:08:48 +01:00
Shawn Hoffman
8bddd8c675
remove SetRoundMode
...
we only care about SSE rounding mode, and set
that manually in SetSIMDMode
2021-07-17 19:29:22 -07:00
Tilka
3c90b657f3
Merge pull request #9907 from shuffle2/roundmode-bitfield
...
make FPSCR.RN an enum
2021-07-18 03:12:28 +01:00
Shawn Hoffman
197075293d
make FPSCR.RN an enum
2021-07-17 18:55:06 -07:00
Shawn Hoffman
e1bddd4c18
remove DSP::Profiler*
...
this is not used anywhere and seems trivial to
ressurect if it's ever needed again.
2021-07-17 18:26:32 -07:00
Shawn Hoffman
c89ae53677
msvc: remove warning disables which no longer fire
2021-07-17 18:24:36 -07:00
Tilka
d7a5558dc5
Merge pull request #9905 from shuffle2/msvc-outdated-comment
...
remove an outdated comment
2021-07-18 02:20:56 +01:00
Shawn Hoffman
f5b05ae080
remove an outdated comment
...
seems to have been solved 5 years ago by
b707e199c2
2021-07-17 17:46:57 -07:00
Shawn Hoffman
1009825cb2
unittests: remove some msvc-specific casts
...
compiles on contemporary msvc
checked there is still a mul in release codegen
2021-07-17 17:41:41 -07:00
Shawn Hoffman
7117bd5772
msbuild: remove deprecated MinimalRebuild
...
we were explicitly disabling it, which is
effectively the new behavior
2021-07-17 14:29:03 -07:00
Léo Lam
5021a13aa9
DSPHLE: Fix running and is_stream checks in AX HLE
...
A voice is considered running if and only if `running` equals 1,
not if `running` is not equal to 0.
This fixes https://bugs.dolphin-emu.org/issues/12508 because for some
reason *The Sims 2 - Castaway* sets `running` to 8 when a stream
finishes playing; previously our AX HLE would just loop the voice
and eventually crash after accessing invalid memory addresses.
Thanks to JMC47 and delroth's help, I've verified that this is the
correct check for the following ucodes:
GC:
* 0x3ad3b7ac
* 0x3daf59b9
* 0x4e8a8b21
* 0x07f88145
* 0xe2136399
* 0x3389a79e
Wii:
* 0x347112ba
* 0xfa450138
* 0xadbc06bd
And while I was fixing the running check, I noticed that the is_stream
field was also being handled incorrectly, so I've fixed that as well.
2021-07-14 19:21:35 +02:00
Léo Lam
887fcfc99a
DSPHLE: Remove redundant accelerator end check for AX Wii
2021-07-14 19:20:25 +02:00
Connor McLaughlin
9b17805be9
Merge pull request #9881 from blaahaj/postprocessing-fix
...
PostProcessing: Fix OpenGL UBO linking with configuration options
2021-07-14 13:14:17 +10:00
Bonta
b8f0e97c02
Movie: GBA Support
2021-07-13 16:44:04 +02:00
Bonta
45f2461a53
NetPlay: GBA Support
2021-07-13 16:43:59 +02:00
Bonta
b73d16a71a
Qt/Core: Implement GBA Hotkeys
2021-07-13 16:43:42 +02:00
Bonta
d6f86e1754
Qt: Implement GBA host and widget
2021-07-13 16:43:28 +02:00
Bonta
9b80fb7deb
Qt: GBA Pad config
2021-07-13 16:43:00 +02:00
Bonta
d0f0b4c0e0
SI: Implement GBAEmu device
2021-07-13 16:42:57 +02:00
Bonta
9a22ff653f
Core: Implement GBA Core using libmgba
2021-07-13 16:42:52 +02:00
Bonta
2d744da68c
Core: Add GBA host interface
2021-07-13 16:42:49 +02:00
Bonta
d849d56695
SI/DeviceGBA: Expose GetTransferTime
2021-07-13 16:42:44 +02:00
Bonta
fdcee30a3d
SI: Expose Commands constants and switch to enum class
2021-07-13 16:42:40 +02:00
Bonta
8ee21acf34
Pad: GBA config
2021-07-13 16:42:35 +02:00
Bonta
d2353c79ea
MappingWidget: Support for boxes with multiple columns
2021-07-13 16:42:31 +02:00
Bonta
27eab609dc
GCController: Make HandleMoviePadStatus static
2021-07-13 16:42:27 +02:00
Bonta
ec5d557895
Qt: GBA Config dialog
2021-07-13 16:42:23 +02:00
Bonta
110887435c
Config: GBA settings
2021-07-13 16:41:18 +02:00
Bonta
502def7f71
Mixer: Support GBA samples mixing
2021-07-13 16:40:07 +02:00
Bonta
1b27f22cbc
SI: Allow devices to schedule events
2021-07-13 16:40:01 +02:00
Bonta
44aaf108d1
Externals: Integrate mGBA as a submodule
2021-07-13 16:39:29 +02:00
Léo Lam
b0d2df727a
Merge pull request #9686 from Dentomologist/convert_adapter_tooltip_to_balloontip
...
GeneralWidget: Convert Adapter tooltip to BalloonTip
2021-07-13 03:33:42 +02:00
Léo Lam
de54856fbb
Merge pull request #9846 from jordan-woyak/report-dup-setting
...
Config: Add an ini setting to control real Wii Remote report duplication.
2021-07-13 03:32:49 +02:00
Léo Lam
162af2a7bb
Merge pull request #9870 from OatmealDome/ui-thread
...
macOS: Move UI API calls to the main thread
2021-07-13 03:29:49 +02:00
Léo Lam
b09347c160
Merge pull request #9877 from JosJuice/android-early-panic
...
Android: Avoid crash on early panic alert
2021-07-13 03:27:12 +02:00
Tilka
8fcda4c315
Merge pull request #9889 from leoetlino/ax-symbols
...
DSPHLE: Prevent AX GC and AX Wii symbol mixups
2021-07-13 01:41:44 +01:00
Markus Wick
edc4396603
Merge pull request #9888 from JosJuice/jitarm64-logicalimm-everywhere
...
JitArm64: Stop using hand-encoded logical immediates
2021-07-12 23:03:31 +02:00
JosJuice
3af21d3d22
JitArm64: Optimize FloatCompare's CR value emitting
...
Setting bit 32 is only needed in the case where EQ and GT are set
but SO and LT are not, which is not a possible outcome of a compare.
2021-07-12 22:54:37 +02:00
JosJuice
8af5095ff4
JitArm64: Stop using hand-encoded logical immediates
2021-07-12 22:25:49 +02:00
Léo Lam
474adcc601
DSPHLE: Prevent AX GC and AX Wii symbol mixups
...
Putting AX functions from AXVoice.h in an anonymous namespace does
successfully prevent compilers from merging those functions and
allows us to avoid ODR violations.
However, tools such as gdb still mix up AX GC and AX Wii functions
and variables because those have the exact same symbol names.
This can be fixed by using inline namespaces which are transparent
at the source code level but forces AX GC and AX Wii symbols to be
different.
2021-07-12 16:30:15 +02:00
CrystalGamma
beb6ec0569
VideoCommon: fix generic build
...
On x86/ARM Common/Assert.h is included by way of
VideoCommon/VertexLoader{X64,ARM64}.h, on other platforms it is missing.
2021-07-12 04:30:43 +02:00
Pokechu22
b880be0aa5
Use separate fmt::formatters for each indirect matrix column
...
This also fixes a bug where the float version of row 1 actually showed row 0 again.
2021-07-11 15:01:42 -07:00
Pokechu22
f467c02d1a
Ignore the top bit of the indirect texture matrix scale
...
This fixes the Zora eye coloration in Twilight Princess.
2021-07-11 15:01:37 -07:00
Tilka
20a8e9c872
Merge pull request #9876 from Pokechu22/skyward-sword-map
...
Fix indirect textures when format is not ITF_8
2021-07-11 22:59:23 +01:00
Tillmann Karras
bd5c604718
GameFile: don't download covers for empty game IDs
2021-07-11 17:14:43 +01:00
JosJuice
6fe96d12c6
Jits: Don't use fast double-to-single when input is double precision
...
The fast path of using CVTSD2SS/FCVTN rounds the significand if it
can't be exactly represented as a single, whereas the accurate path
instead truncates the significand. So we should only use the fast
path if we know that the lower bits of the significand are not set.
This is not known to affect any games.
2021-07-11 13:04:02 +02:00
Markus Wick
88fd9fd577
Merge pull request #9869 from JosJuice/jitarm64-constexpr-isimmlogical
...
JitArm64: Encode logical immediates at compile-time where possible
2021-07-11 12:55:48 +02:00
JosJuice
f903853cf7
JitArm64: Fix ps_cmpXX
...
Passing a width of 64 and registers encoded as double to
DUP resulted in an invalid instruction. The registers should
be encoded as quads in this situation.
Fixes https://bugs.dolphin-emu.org/issues/12575 .
2021-07-11 11:43:19 +02:00
JosJuice
0f3b9a8874
JitArm64: Minor mcrfs optimization
2021-07-10 20:44:22 +02:00
JosJuice
9e80db123f
JitArm64: Encode logical immediates at compile-time where possible
...
Manually encoding and decoding logical immediates is error-prone.
Using ORRI2R and friends lets us avoid doing the work manually,
but in exchange, there is a runtime performance penalty. It's
probably rather small, but still, it would be nice if we could
let the compiler do the work at compile-time. And that's exactly
what this commit does, so now I have no excuse for trying to
manually write logical immediates anymore.
2021-07-10 20:43:59 +02:00
JosJuice
10861ed8ce
JitArm64: Turn IsImmLogical into a constexpr constructor
2021-07-10 20:31:28 +02:00
JosJuice
ab024b218e
JitArm64: Accept LogicalImm struct as bitwise inst parameter
2021-07-10 20:13:11 +02:00
Markus Wick
f6ca70d094
Merge pull request #9822 from JosJuice/jitarm64-ps-cmpxx
...
JitArm64: Implement ps_cmpXX
2021-07-10 19:20:48 +02:00
JosJuice
adbf6d55da
JitArm64: Implement ps_cmpXX
2021-07-10 19:08:55 +02:00
Markus Wick
4ba4d7cc7d
Merge pull request #9878 from JosJuice/jitarm64-addmex
...
JitArm64: Implement addmex/subfmex
2021-07-10 10:11:20 +02:00
Dentomologist
59292a5c65
GeneralWidget: Convert Adapter tooltip to BalloonTip
...
Use a BalloonTip to inform the user when their selected backend (i.e.
OpenGL or NULL) doesn't support adapters, instead of using the default
tooltips.
2021-07-09 10:10:36 -07:00
JosJuice
afe9c6fb9a
Merge pull request #9880 from OatmealDome/windows-updater
...
UpdaterCommon: Use File::Copy() on non-macOS platforms
2021-07-09 19:02:42 +02:00
OatmealDome
a39b7a45c0
UpdaterCommon: Use File::Copy() on non-macOS platforms
2021-07-09 12:56:23 -04:00
JosJuice
fc60e62622
JitArm64: Implement addmex/subfmex
2021-07-09 16:44:33 +02:00
Admiral H. Curtiss
c9e4489e17
Core/MMU: Fix inverted condition in HostIsInstructionRAMAddress().
2021-07-09 05:48:17 +02:00
Pokechu22
a379456f38
Fix indentation for alphabump
2021-07-08 15:48:14 -07:00
Pokechu22
2feced2e33
Fix indirect textures when format is not ITF_8
2021-07-08 15:48:14 -07:00
Markus Wick
cfcc994f6c
Merge pull request #9840 from JosJuice/jitarm64-mffsx
...
JitArm64: Implement mffsx
2021-07-08 14:15:24 +02:00
Markus Wick
a390d3f327
Merge pull request #9820 from JosJuice/jitarm64-simplify-addex
...
JitArm64: Simplify addex/subfex
2021-07-08 13:46:48 +02:00
Markus Wick
f67f0488d2
Merge pull request #9844 from JosJuice/jitarm64-fctiwzx-constant
...
JitArm64: Improve fctiwzx constant generation in double case
2021-07-08 13:43:09 +02:00
Markus Wick
9df6f65834
Merge pull request #9867 from JosJuice/jitarm64-unconditional-exception-exit
...
JitArm64: Add the ability to emit an unconditional exception exit
2021-07-08 13:08:05 +02:00
Markus Wick
1827cb9cd8
Merge pull request #9874 from JosJuice/jitarm64-unconditional-farcode
...
JitArm64: Get rid of an unconditional branch to farcode
2021-07-08 13:01:21 +02:00
JosJuice
44c99f8cc1
Android: Avoid crash on early panic alert
2021-07-08 10:37:36 +02:00
Markus Wick
98098edad7
Merge pull request #9859 from JosJuice/jitarm64-stwbrx-sthbrx
...
JitArm64: Implement stwbrx/sthbrx
2021-07-07 21:45:06 +02:00
blåhaj
debeb09dee
PostProcessing: Fix OpenGL UBO linking with configuration options
2021-07-07 21:28:22 +02:00
JosJuice
a6700a074d
JitArm64: Get rid of an unconditional branch to farcode
...
If a branch is unconditional, its target should not be in farcode,
since that defeats the purpose of farcode (putting seldom executed
code in farcode to keep it out of the icache when possible).
2021-07-07 14:11:07 +02:00
Léo Lam
de12890588
Merge pull request #9873 from JosJuice/jitarm64-tbz-encoding
...
Arm64Emitter: Fix 64-bit TBZ/TBNZ encoding
2021-07-07 12:39:07 +02:00