Adds const to variables that could use them but currently don't and replaces 256 literal uses with Qt::UserRole to be clear what it is for and how this number is used as currently it's a bit confusing.
Previously when double clicking a memory search result it would go to the address but not switch to the memory view tab if the user wasn't already on it.
Now it ensures the user moves to the memory view widget, as this is almost always going to be the user's intention.
Adds a tab widget to the debugger that allows saving/bookmarking memory addresses and giving them labels/descriptions for convenience. Includes the ability to jump back to memory addresses from the Saved Addresses tab, and adding Saved Addresses from memory search search results context menu and the memory view context menu.
Also supports importing and exporting the saved addresses as CSV format.
This used to be off by default, but was changed to show found patches/cheats for all CRCs for a game serial. However, this also clutters and shows cheats for CRCs that may not be applicable without a way to hide them.
This puts this setting behind a toggle to choose if this should be enabled/disabled so the user has choice. Still defaults to enabled to keep current behavior.
Adds the ability to do Not Equals filter searches for arrays and strings. Refactors array search function for easily adding new search types.
Adds error message that informs the user that Not Equals can not be used for initial searches and can only be used for filter searches.
- Combines the start and end address inputs for memory search into a single line to not take up unnecessary space and allow room for other UI elements.
- Adds 'Comparison' label to memory search UI to describe the comparison input dropdown.
The 'Clear Settings' button will now disable all cheats and patches from the configuration. This will allow quickly resetting to having no game altering pnach patches/cheats.
* Debugger: Fix Importing Breakpoints CSV functionality
This resolves a few issues with the Breakpoint CSV importing functionality.
Makes the following changes/fixes:
- Assembly instructions with commas caused part of the instruction text to be considered the start of a new column (comma is the CSV delimiter), resulting in "too many columns errors" and failing to import. Now puts values in quotes and detects the true start and end of the values, so that no extra columns are created.
- The import function was using the incorrect columns to load since the Enabled column was moved to be the first one but the import function had not been updated. Fixed this by using the column enum values instead of hardcoded numbers, so if ordering in the model changes it will still import fine.
- Updates the beginRemoveRows function to not remove an extra row. With this function you would want a "count" of 0 to remove 1, so "row, row" deletes one, "row, row+1" deletes 2. Updates it to subtract one so that the range is not including one more than it is intended to.
-
* Misc: Cleanup regex string & add explicit imports
Uses raw string literal to make the regular expression easier to read since regex is ugly enough as it is, we really don't need escaping characters in a string on top.
Also explicitly includes used Qt classes.
* Make memory search search type handling more clear with enum
Adds an enum class to represent the Search type used in a memory search. Prior, this was just handled with an integer to represent each type, but it was very unclear what corresponded to which type at first glance.
Made this easier to follow by using an enum to represent the type.
* Debugger : Add support for greater than/less than/not equal search types
Adds support for basic greater than/greater than or equal/less than/less than or equal/not equal search types for the debugger's Memory Scan.
This adds a new input to allow selecting the search comparison type, which defaults to Equals, and allows switching to the above mentioned comparisons.
It's set up to allow for adding more easily. Restructures some of the functions to make having multiple comparisons quite manageable.
Adds an enum for search comparison types for easy logic handling.
* Debugger: Update Array/String search type error to mention not handling Not Equals
Currently array/string searches don't support Not Equals searches, so this needs to be removed.
* Debugger: Code cleanup + feedback changes
Sets up if expressions to use constexpr for compile time evaluation and makes the is greater/less than logic simpler to read for int. Also removes an unneeded QPushButton cast and simply compares the pointers directly.
- Adding translation support for all the substrings related to the single/multiframe GS Dump message.
- Correcting the None option in the Deinterlacing settings according to what was talked about in Crowdin, unified that string with the Big Picture mode.
- Minor English text fixes reported in Crowdin.
Second attempt at doing this PR after the former, https://github.com/PCSX2/pcsx2/pull/10253 , was mangled by bad squashing and rebasing.
Adds the ability to remove individual search results from the Memory Search results list. Right clicking a result will give the "Remove Result" option in the context menu.
Allows user to right click a memory search result in order to go to that memory address location in the disassembly view. This saves several step and makes it easier to do.
Also adds precedent for the memory search result context menu which will be used in future features.
Addresses feedback to use consistent naming conventions as most variables are using snake_case. Also no longer passes string_view by reference as per feedback.
Bundled patches don't display when unlabeled patches are loaded (since we can't guarantee they don't collide). This warns the user that bundled patches are hidden when unlabeled patches are loaded. (The warning hides when no unlabeled patches are loaded)
Add the ability to copy a function name when you right click the first instruction of a function (the line where the function name displays).
Instructions inside the function that are not the first instruction will not show the copy option, partly because it's less clear what will be copied but also to not needlessly overpopulate the context menu.
The Cheats Settings menu was failing to reload cheats when pressing the button. This meant if you enabled a cheat, made changes, and clicked reload, there would be no updates in behavior.
This was due to the reload button getting wired to the function that refreshes the list of cheats, rather than the function that refreshes the list AND reloads the actual enabled cheats.
This now calls the right function and when reloading, any changes thart were saved to the cheat will now be present.
Also improves behaviour parity between Qt and Fullscreen UI,
since the latter used to prompt for system reset even if the game had
no RetroAchievements entry.
* Pad: Get rid of redundant object lookup
* Pad: Serialize 'stage' state
[SAVEVERSION+]
* Pad: Reduce Freeze duplication and add markers
Catch any possible unhandled device type change.
[SAVEVERSION+]
* Pad: Localize controller type names
* Pad: Handle mismatch between state and current config
* Misc: Drop .at() from vector/array access
We don't use exceptions.
* Pad: Remove redundant GetUnifiedSlot()
Sio has routines for converting these.
* Sio2: Remove redundant optional in Pad()
* Pad: Constify and finalize controller classes
* Pad: Move PadManager to Pad namespace
No point having a class when there's only a single instance.
* Pad: Move PadConfig to Pad namespace
* Pad: Move PadMacros to Pad namespace
* Pad: Re-localize controller bindings/settings
* Pad: Make controller info local
Don't want to create duplicates.
* Pad: Use span for ControllerInfo settings/bindings
* Pad: Fix auto-toggled macro buttons
* Pad: Fix pressure for macros
* Pad: Merge PadConfig/PadManager/PadMacros
Faster compile time.
* Pad: Fix incorrect condition in Sio0::SetTxData()
* Pad: Add deadzone for macro triggers
Force pushed because git hates me
[SAVEVERSION+] Bump savestate version
CI: Update locations of pad/memcard sources
Discard leftover old PAD code
Fix additional merge oddities
Add translations for OSD messages
Copyright headers
Version bump
Fix a whole boatload of concurrency problems from file moves and other miscellaneous update problems
Partial redo of PS1 pad support
Fix incorrect mode due to analog behavior at startup
Mostly reimplement SIO0 memory card logic
Still needs pocketstation
Use new runtime wrapped translate function
Dead code
Fix multiple port/slot/presence issues for PS1
Save State version bump
Clean up some duplicate/unused headers
More header consistency
Remove old stray files
Fix incorrect return
Fix uninitialized array
Add missing overrides
Switch to init/close model used by other subsystems
Remove old input recording references
Rename SIO globals
Rename SIO2 FIFO globals
Remove commented SIO0 code for illegal write
Add guitar icon