fe5655d1e3
misc cleanups in BizHawk.Common
2020-12-15 17:54:44 -06:00
cb6ef03982
use explicit private/internal modifiers
2020-12-15 16:49:23 -06:00
b83556fc6f
make fields readonly where possible
2020-12-15 16:00:55 -06:00
213729550d
remove redundant array initializers
2020-12-15 16:00:55 -06:00
eeca40e072
libsnes: Cache region from core once at start
...
The region value in the comm struct is set once and then gets wiped out later. I don't know what wipes it, but so many things have their hands on that, it's not surprising. Someone knew about this and handled _mapper appropriately, but not _region.
Fixes #2503
2020-12-15 08:51:08 -05:00
a8e2a420f0
GBHawk: cleanup
2020-12-14 19:32:22 -05:00
08f1b69197
GBHawk: prep for future audio work
2020-12-14 19:30:22 -05:00
3df6dfb350
GBHawk: update clearing screen for subgbhawk and linked modes
2020-12-14 11:41:19 -05:00
b85e7cac2c
O2; set released to true
2020-12-14 11:40:23 -05:00
1c27943707
Make SNES rom memory domain writeable
...
Use at your own risk
2020-12-13 20:11:58 -05:00
fbee96c76b
GPGX: Allow writing to rom memory domains
...
Don't let the diff fool you, a massive amount of work went into making this possible.
2020-12-13 19:49:04 -05:00
72ea5ce866
Waterbox: Allow SEH unwinding through guest calls. ( #2519 )
...
The goal of the separate stacks was to allow this, but I never quite finished the job. Now, when a SEH exception (generally a Rust panic in a guest syscall handler, or a C# Exception in a callback) tries to unwind through guest code, it works. Note that we don't actually unwind the guest stack, as there's nothing useful to be gained from that; When an emulator core throws an exception like this, it should be considered completely hosed. Throw it out and get a new one.
There were two bugs stopping this from working.
First of all, we had custom thunks that lacked sufficient unwind information for RtlUnwind to get through. For the sysv <-> msabi adapter, this was fixed by making it regular Rust code instead of hand assembled junkus. So the compiler generates valid unwind information for all of that. Then we just JIT a small stub on top in the MsHostSysVGuest code, which needs no unwind information because it won't throw an exception itself and transparently passes execution to something with valid unwind information without invalidating that information. (NB: Clr JIT stubs use the same strategy.) For the host <-> guest stack transition code, a small hand generated unwind stub was added to interop.s that is registered with `RtlAddFunctionTable`. I've seen the unwind work successfully without this second set of unwind information, but better safe than sorry.
Secondly, our misuse of SubSystemTib caught up with us. It's an old field, allegedly from OS/2, that we repurposed to hold TLS information needed for the waterbox stack transitions. Most people think nothing uses it any more, but in fact if it's set to a non-NULL value, but doesn't contain valid information, `KERNELBASE!GetModuleFileNameW` will crash when it tries to get a module name from there. The fix here was to simply tighten up our usage of SubSystemTib: We were already nulling it out when returning from guest code, but not when calling back to host code in guest code.
Fixes #2487 . Unwinding of this sort has never worked well in waterbox; the reason why that issue is more recent is that the particular reproducing case of firmware didn't cause an exception in a callback in older code; the exception happened in pure managed code.
2020-12-13 19:12:16 -05:00
fa6fd88d62
Import and use OSTailoredCode in DiscoHawk program class
2020-12-14 06:40:06 +10:00
24f90c922f
Fix incorrect import
...
I blame Rider
2020-12-14 06:33:46 +10:00
28f161ce18
remove unnecessary string interpolation in a few places
2020-12-13 12:12:42 -06:00
10d4f66248
Hex Editor - some small cleanups
2020-12-13 11:44:10 -06:00
2f2f104e3d
Update nyma cores to Mednafen 1.26.1
...
See Mednafen release notes for full changes. Mostly just Sega Saturn stuff.
Closes #2464
Closes #2162
2020-12-12 10:50:18 -05:00
4447d5ddc7
GBHawk: bug fix, initial ram change, and double speed mode input dumping
2020-12-09 22:54:12 -05:00
58cbec6dd6
[PSX] Make Octoshock more debuggable ( #2508 )
...
* [PSX] Bodge in a system bus memory domain
Fixes: debugger window crashes when adding a breakpoint
* [PSX] Use Octoshock's built-in disassembler
* [PSX] Add support for execute memcbs to the core
* [PSX] Have memcbs include actual values
* [PSX] Use SafeHandles instead of raw pointers
* [PSX] Use core's internal peek and poke functions for System Bus
* [PSX] Move memory maps into IDebuggable impl to be next to memory map hooks
* [PSX] Revert using SafeHandles
* [PSX] Fire execution callback after trace callback instead of at end of fetch
2020-12-08 11:34:24 -06:00
e81fa92f80
GBHawk: forgot a commit
2020-12-08 11:04:03 -05:00
401d635afc
GBHawk: properly fade to white in GBC mode
2020-12-08 10:41:37 -05:00
28af57de18
fix mistake in libsnes CARTROM-D CDL block
2020-12-07 15:55:15 -05:00
699fb1171c
GBHawk: more mode 1 work
2020-12-06 19:39:25 -05:00
a46ffefc77
GBHawk: mode 1 overhaul, fixes several bugs
2020-12-06 15:50:21 -05:00
96aa3e85c0
libsnes - remove pointless registers
2020-12-05 23:37:16 -05:00
f580773342
add CARTROM-DB and CARTROM-D blocks to libsnes CDL
2020-12-05 23:37:16 -05:00
b7c821f8d6
GBHawk: mode1 bug fix
2020-12-05 19:32:34 -05:00
877c11d5f9
Merge UpdateChecker.ParseVersion into VersionInfo.VersionStrToInt
2020-12-06 07:35:12 +10:00
66e0d4b214
Misc. cleanups in VersionInfo
2020-12-06 07:28:31 +10:00
508dc4a9d9
Use readonly instead of const in VersionInfo
2020-12-06 07:28:23 +10:00
9dcc8f56f4
Move VersionStrToInt helper to VersionInfo
2020-12-06 07:27:54 +10:00
98e2d494a2
Bump supported Windows versions
2020-12-06 07:12:27 +10:00
eeae3f023f
Merge Sound.Instance into MainForm.Sound and pass back to Program
...
now I don't have to feel bad about sweeping a global under the rug
2020-12-06 05:59:36 +10:00
cf901753ba
Update Lua libs' ApiContainer when updating services
...
I don't think this mattered unless the tool restart was triggered by reloading
the rom with client.reboot_core(), which in my defence has always been jank
2020-12-06 05:41:58 +10:00
febd4f1340
Remove unused prop EventsLibrary
2020-12-06 05:34:46 +10:00
ce7aa1ff64
Convert abstract class LuaLibraries to an interface
2020-12-05 07:51:14 +10:00
e42a021215
Move props from LuaLibraries to Win32LuaLibraries
2020-12-05 07:51:11 +10:00
c46719c602
Do type checks on LuaConsole.LuaImp
...
this is more safe than is strictly necessary but it's not really less code to
use a direct cast
2020-12-05 07:51:08 +10:00
bf116f3ecf
Inline LuaLibraries.RunningScripts
2020-12-05 07:51:05 +10:00
c3c02eaad3
Inline LuaLibraries.EnableUpdate/SupressUpdate
...
"suppress" isn't even speled corectly
2020-12-05 07:51:02 +10:00
e4a0175351
Extract interface from NamedLuaFunction
2020-12-05 07:50:59 +10:00
8f10ce66a6
Merge EventsLuaLibrary.RegisteredFunctions into Win32LuaLibraries
2020-12-05 07:50:56 +10:00
6aefa75cff
Add helpers for manipulating NamedLuaFunctions
2020-12-05 07:50:53 +10:00
3024bc0d0f
Inline some methods from EventsLuaLibrary into Win32LuaLibraries
2020-12-05 07:50:50 +10:00
a54aa0706d
Deprecate emu.getluacore in favour of new func client.get_lua_engine
2020-12-05 07:50:46 +10:00
f57897515e
Add prop EngineName to abstract class LuaLibraries
2020-12-05 07:50:43 +10:00
89a66563f1
Cleanup FormsLuaLibrary.WindowClosed and usages
2020-12-05 07:50:40 +10:00
d51f9c3e88
Use LINQ instead of dumb in FormsLuaLibrary implementations
2020-12-05 07:50:37 +10:00
30d9a8b458
Inline Designer and resource files for LuaCanvas
2020-12-05 07:50:33 +10:00
b541fe5b40
Use NLuaTableHelper for more conversion to/from LuaTable
...
also fix indexing that I broke in c8e10120d
2020-12-05 07:50:28 +10:00
46504b4880
Add and use more extensions for IDialogParent
2020-12-05 07:47:01 +10:00
b752b09d62
Implement IDialogParent in some more forms
2020-12-05 07:47:01 +10:00
8a6c7be6aa
Cleanup MainForm interfaces, move ShowDialogAsChild to extension
2020-12-05 07:47:01 +10:00
f0664ce018
Add and use interface IDialogParent
2020-12-05 07:47:01 +10:00
f0657b358d
Inline ShowHawkDialog
...
there were 8 unnecessary double-mutes where ShowHawkDialog was called with a
InputPrompt receiver
2020-12-05 07:47:01 +10:00
9d620116f3
Shoehorn IDialogController into ShowHawkDialog call chains
2020-12-05 07:47:01 +10:00
dd44ff7f6c
Ensure owner param of ShowHawkDialog overloads are never null
2020-12-05 07:47:01 +10:00
aad612593b
Add and use helper method DoWithTempMute (void and generic flavours)
2020-12-05 07:47:01 +10:00
cc4acd9c64
Move Start/StopSound calls from InputPrompt to callers
2020-12-05 07:47:01 +10:00
2295d47192
Add superinterface IDialogController for IMainFormForConfig/Tools
2020-12-05 07:47:01 +10:00
e0c1fc4a4d
misc cleanups in Client.Common
2020-12-04 15:39:52 -06:00
81ef9ed88b
GB layers ( #2490 )
...
* Fixed OBJ layer toggle message
(it was using the flag from BG toggle)
* Added hotkey option for GB Window layer toggle
* Added hotkey option for GB Window layer toggle
* GB object viewer prototype [Gambatte]
GPU Viewer add-on to display sprite tiles on the real position, just like what you have for the bsnes core
Has several issues:
- Drawing is identical to the current sprite display, so it doesn't have the transparency it should have;
- Drawing doesn't take priority into account, so overlapping is usually wrong;
- The drawing flickers, probably the way of refreshing (with `.Clear()`) is bad.
2020-12-04 14:37:36 -06:00
0aea6191ae
GBHawk: HDMA fixes and implement reads for GBC visualizer
2020-12-04 11:20:56 -05:00
a060c4e600
Fix building on non-AppVeyor machines without breaking AppVeyor
...
hopefully
2020-12-04 06:12:06 +10:00
ec61aad159
as requested, try it with netcoreapp3.1
2020-12-03 14:05:00 -05:00
0fda93acea
revert targetframework on bizhawk.tests too
2020-12-03 13:17:08 -05:00
c8e10120db
Encapsulate conversion to/from LuaTable, stop passing NLua to Lua libs
2020-12-03 22:54:47 +10:00
e69cab3297
Cleanup Win32LuaLibraries init
2020-12-03 22:15:07 +10:00
76f03a9508
Merge DelegatingLuaLibrary into LuaLibraryBase
2020-12-03 21:37:17 +10:00
d4349aefd4
Allow ext. tools to recieve an ApiContainer
2020-12-03 18:58:34 +10:00
608d7dcff8
Add ApiContainer prop to IExternalApiProvider
2020-12-03 18:46:07 +10:00
29bceb272f
Merge MouseWheelTracker from MainForm interface into InputManager
2020-12-03 18:35:24 +10:00
f6d465a1ac
Move InputApi to Client.Common project
2020-12-03 18:31:45 +10:00
6be371aadd
Use callbacks to get mouse pos+buttons to InputApi via InputManager
2020-12-03 18:14:49 +10:00
4ade496de5
Move EmuClientApi to Client.Common project
2020-12-03 17:59:30 +10:00
56c681ef0c
Use IWindowCoordsTransformer in EmuClient and Input API impl.
2020-12-03 17:50:13 +10:00
999df1b041
Extract interface IWindowCoordsTransformer from DisplayManager
2020-12-03 17:48:38 +10:00
6b30fb826c
Move ClientLuaLibrary to Client.Common project
2020-12-03 17:35:54 +10:00
cfbdde4cc7
GBHawk: more hdma improvements
2020-12-01 19:03:11 -05:00
239fa0b22c
Rename files of MainForm interfaces to match type name
...
oops
2020-12-01 02:51:28 +10:00
928ea057d8
Enable SA1137 and fix noncompliance (except in Cores)
...
"Elements should have the same indentation"
2020-11-30 21:36:48 +10:00
be36c60e9e
Enable SA1208 and fix noncompliance (except in Cores)
...
"System using directives should be placed before other using directives"
2020-11-30 21:26:36 +10:00
1a020ba0f5
Make the getters of the 6 ToolFormBase props protected
...
and it only cost a callback and a `public new` hack
2020-11-30 20:56:06 +10:00
85faec638a
Update or remove comments mentioning GlobalWin
2020-11-30 20:45:21 +10:00
bf968acd57
Move static GlobalWin.Sound to static Sound.Instance, mirroring Input
2020-11-30 20:42:23 +10:00
c3a7ec047f
Remove GlobalWin.Config by cleaning up Sound
2020-11-30 20:37:11 +10:00
0a9f93c433
Fix encapsulation of Config in FFmpegWriterForm
2020-11-30 20:30:26 +10:00
756f9f50e8
Use EmulationApi's config hack in ClientLuaLibrary
2020-11-30 20:19:27 +10:00
3b120e7184
Delegate ClientLuaLibrary.GetWindowSize/SetWindowSize to ApiHawk
...
the impls were the same but for getting the global config
2020-11-30 20:19:23 +10:00
a393c7d368
Remove weird double-updating of EmuClientApi
...
changes signatures in IEmuClientApi but they were never meant to be called
outside MainForm anyway
2020-11-30 20:14:28 +10:00
a1ccac4d67
Delegate ClientLuaLibrary.FrameSkip to ApiHawk
...
the ApiHawk copy was the bad one
2020-11-30 19:57:13 +10:00
7c85aee53b
Init global Input instance from MainForm ctor
...
* Input.MainFormInputAllowedCallback is now readonly, set in ctor
* call to Input.Adapter.FirstInitAll is also in the Input ctor
2020-11-30 19:48:25 +10:00
709d78d8e0
Use local var instead of GlobalWin.Config in Program
2020-11-30 19:30:15 +10:00
f314aa3d61
Pass global Config to BatchRun/BatchRunner
2020-11-30 19:24:17 +10:00
32f571144e
Encapsulate GlobalWin.Config access in Input
2020-11-30 19:21:13 +10:00
4e38028b49
Fix typo, global access when global is passed as param
2020-11-30 19:15:59 +10:00
453ea2b1bb
Pass globals to DisplayManager as with OSDManager
...
* moved initialisation of global `OSDManager` to `DisplayManager` ctor again
* `DisplayManager.UpdateGlobals` calls `DisplayManager.OSD.UpdateGlobals`
* goodbye `GlobalWin.Emulator` and `GlobalWin._mainForm` :)
2020-11-30 19:11:59 +10:00
c991babdce
Use MainForm instead of GlobalWin in Lua internals
2020-11-30 19:03:50 +10:00
3ccdfa8289
Pass MainForm to UI helpers instead of using GlobalWin.Sound
2020-11-30 16:44:27 +10:00
636a9a4735
Pass a callback to some sound internals to read the global IEmulator
2020-11-30 16:16:22 +10:00
6d22cdc15f
Pass global MovieSession from MainForm ctor to Program with an out param
2020-11-30 16:02:48 +10:00
3a7ca89311
Remove GlobalWin.InputManager
2020-11-30 15:58:50 +10:00
a83642fab2
Pass globals to OSDManager via ctor and new UpdateGlobals method
...
also instantiate OSDManager in MainForm and pass it to DisplayManager because
that's how we did it until recently and it's also just easier
2020-11-30 15:55:23 +10:00
b9a5c5796d
Pass global InputManager to remaining Virtual Pads controls
2020-11-30 15:43:33 +10:00
e3f7519e15
replace unnecessary GlobalWin usage in BookmarksBranchesBox.cs
2020-11-29 22:04:00 -06:00
792b317118
add Start/StopSound methods to IEmuHawkMainFormToTools interface and use it in tools instead of GlobalWin.Sound
2020-11-29 19:34:57 -06:00
ac93f28939
Do not attempt to report >100% seek progress. (This could happen if the user starts a seek which results in loading a savestate past the frame previously being seeked.)
2020-11-29 12:29:38 -06:00
e1186d9253
Remove this. It isn't necessary, and is a copy-pasted line from some converted code in commit 2535207a.
2020-11-29 12:29:38 -06:00
8d6cb7685e
TasClipboardEntry, move some logic to Tastudio, fix filename, and move to Client.Common
2020-11-29 12:25:26 -06:00
8e70bece16
TAStudioClipboard - remove unused and dubious ToString() override
2020-11-29 12:16:51 -06:00
ceade5be5a
move some logic from TAStudioLuaLibrary to TAStudio
2020-11-29 12:13:12 -06:00
592cedba1d
make fields readonly where possible in EmuHawk project
2020-11-29 11:26:41 -06:00
488409a2ad
MovieZone - remove usage of GlobalWin.Config
2020-11-29 10:57:50 -06:00
8bbd6b2d8b
Remove final reference to GlobalWin.Game by hacking an existing hack
2020-11-29 19:15:01 +10:00
f7a7b722c5
Pass globals to ExternalToolManager via ctor and Restart method
2020-11-29 19:06:45 +10:00
84f0d57fd5
Add restarting to ExternalToolManager, called when replacing Config
2020-11-29 18:58:12 +10:00
bed5142ddc
Make ExternalToolManager not static
2020-11-29 17:30:19 +10:00
d2c514bc51
Move more ApiHawk impl. classes to Client.Common
2020-11-29 16:50:31 +10:00
ebef47203d
Allow ApiHawk impl classes to have any param order in their ctors
2020-11-29 16:39:26 +10:00
1f9188da5e
Pass global Config and GameInfo to Emu and GameInfo APIs via ctors
2020-11-29 14:26:19 +10:00
85d4d5ed4d
Pass global InputManager to JoypadApi via ctor
2020-11-29 14:18:40 +10:00
8ad3ea9cc6
Move GlobalWin.GL to MainForm, passing it through from Program
2020-11-29 14:09:37 +10:00
7bf879c095
Explicitly pass first Config through SingleInstanceController
2020-11-29 14:05:23 +10:00
a34dde7c4f
Pass global IGL to DisplayConfig (and then to RetroShaderChain)
2020-11-29 13:59:30 +10:00
b26aa2e893
Rewrite GlobalWin.GL init with local functions
2020-11-29 13:50:49 +10:00
3150cc4493
Remove GlobalWin.IGL_GL, only init OpenTK when using that disp. method
...
also, if it's too old, dispose it before continuing with fallback
2020-11-29 13:50:49 +10:00
60022ab146
Move OpenTK configuration to dedicated static ctor
2020-11-29 13:50:49 +10:00
f38c75f06d
GBHawk: some accuracy improvements
2020-11-28 18:58:33 -05:00
e0eb572e74
misc cleanups, mostly IDE nags, in files I had open
2020-11-28 14:32:05 -06:00
bdf1838ac8
pass Config around to various AV writer and form classes, instead of using GlobalWin.Config
2020-11-28 13:57:40 -06:00
84002f1232
Make the menu items for FDS disk changing better named
2020-11-28 13:30:00 -05:00
8550d2bd0d
fix previous commit, fix dependencies in PathConfig and remove usage of GlobalWin in FirmwaresConfig
2020-11-28 11:03:38 -06:00
be8825fefc
GBPrefs/DGBPrefs - pass in dependencies
2020-11-28 10:53:27 -06:00
342164d05c
ColorChooserForm - a bit of cleanup
2020-11-28 10:04:24 -06:00
3be90efd57
Make some GlobalWin props read from MainForm instead of the reverse
...
these props' setters were only called from MainForm
2020-11-28 23:28:32 +10:00
0899369d1a
Sort out the mess that is creating and updating the global Config
...
hopefully this kills a few subtle bugs re: `Config` > `Load Config`
2020-11-28 23:04:49 +10:00
3de87af5de
Pass MovieSession to APIs via ctor
2020-11-28 22:48:02 +10:00
c203edba17
Move prop GlobalWin.UserBag to global MovieSession
...
and weaken to IDict<K, V>
2020-11-28 22:39:13 +10:00
56df80bb5a
Move prop GlobalWin.OSD to global DisplayManager
2020-11-28 22:27:26 +10:00
b0b2b8fa63
Remove GlobalWin.DisplayManager, pass it through from MainForm instead
2020-11-28 22:10:48 +10:00
78daf4913d
Move ArgParser to Client.Common and split ParsedCLIFlags into own file
2020-11-28 21:45:52 +10:00
251f0e7af8
Move init of network helpers from ArgParser to MainForm ctor
2020-11-28 21:41:33 +10:00
1c1aa348cf
Add a new field to MainForm for _autoDumpLength
...
now ParsedCLIFlags can be properly readonly :)
2020-11-28 21:01:17 +10:00
35d6bca6c6
Cleanup ArgParser without changing usage
...
(apart from its init in the MainForm ctor)
2020-11-28 20:47:35 +10:00
750e1d8980
Sounds.cs - pass in some dependencies instead of using GlobalWIn
2020-11-27 15:53:52 -06:00
bae75157f2
remove some unnecessary GlobalWin usages
2020-11-27 15:09:04 -06:00
0223c11504
cleanups
2020-11-27 15:07:10 -06:00
e640b11e49
remove some unused methods in ToolFormBase
2020-11-27 15:00:28 -06:00
e9ca84f8bd
remove GlobalWin.Game usage in ToolFormBase
2020-11-27 14:59:50 -06:00
cd146c0f79
remove GlobalWin usage in HeaderEditor
2020-11-27 11:17:47 -06:00
adelikat