Léo Lam
f82145d9dd
EXI_DeviceMemoryCard: Use std::array
2020-11-20 19:41:23 +01:00
Léo Lam
f81062f561
EXI_DeviceMemoryCard: Use enum class for Command
2020-11-20 19:38:07 +01:00
Léo Lam
b2f00be637
EXI_DeviceMemoryCard: Fix member variable names
2020-11-20 19:37:39 +01:00
Léo Lam
1f15119f80
EXI_DeviceMemoryCard: Use override rather than virtual
2020-11-20 19:36:34 +01:00
Léo Lam
279197b278
EXI_DeviceMemoryCard: Use more efficient overload of find_last_of
2020-11-20 19:36:34 +01:00
Léo Lam
4ad88ce2e4
EXI_DeviceMemoryCard: Clean up casts and implicit conversions
2020-11-20 19:36:33 +01:00
Léo Lam
e144d20dd6
EXI_DeviceMemoryCard: Remove unused include
2020-11-20 18:51:16 +01:00
Léo Lam
2631243379
EXI_DeviceMemoryCard: Rename variables to follow our naming conventions
2020-11-20 18:51:16 +01:00
JosJuice
730f9cb7bd
Android: Fix IllegalStateException on startup
...
See https://github.com/dolphin-emu/dolphin/pull/9095#pullrequestreview-535576465
2020-11-20 18:33:00 +01:00
Léo Lam
542c49bab0
Core: Fix invalid lambda captures
...
PR #9260 made the MsgAlert macros use lambdas so that local
constexpr variables can be added while keeping the ability to
return a boolean from the macros.
Unfortunately, C++17 forbids referring to structured bindings in lambda
captures. This is fixed in P1091R3 but we cannot rely on C++20 yet...
2020-11-20 18:27:56 +01:00
Léo Lam
f45a4a5916
Merge pull request #9263 from lioncash/core-log2
...
Core: Convert logging over to fmt pt.2
2020-11-20 16:36:47 +01:00
Léo Lam
88cc1b7c8a
DSP: Fix one DEBUG_LOG call
2020-11-20 16:21:05 +01:00
Lioncash
a0f9b041a0
Core: Convert logging over to fmt pt.2
...
Continues the core migration of logs up to the EXI handling code.
2020-11-20 10:05:44 -05:00
Léo Lam
419dfe4be4
Merge pull request #9260 from leoetlino/fmt-checks
...
Common/Log: Add compile-time format string checks
2020-11-20 16:05:25 +01:00
Jonathan Marek
a20e69ff51
Vulkan: fix validation error in bSupportsGeometryShaders=false case
...
In CreateDescriptorSetLayouts(), one less dynamic binding is created when
bSupportsGeometryShaders=false. Reduce the dynamicOffsetCount argument by
one in that case. Avoids this validation error:
Attempting to bind 3 descriptorSets with 2 dynamic descriptors, but
dynamicOffsetCount is 3. It should exactly match the number of dynamic
descriptors. The Vulkan spec states: dynamicOffsetCount must be equal to
the total number of dynamic descriptors in pDescriptorSets
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
[Applied clang-format]
Signed-off-by: Léo Lam <leo@leolam.fr>
2020-11-20 12:23:34 +01:00
Léo Lam
c580a70a12
Merge pull request #9210 from Dentomologist/regions-show-hide-all
...
DolphinQt: Add Show/Hide All options to gamelist region menu
2020-11-20 11:35:22 +01:00
Dentomologist
7ded075561
DolphinQt: Add Show/Hide All options to gamelist region menu
2020-11-19 20:39:49 -08:00
Léo Lam
858d7612ef
Merge pull request #9170 from JosJuice/android-extension-hack-2
...
Android: Remove hacks for Wii Remote extension setting, round 2
2020-11-20 02:47:23 +01:00
Léo Lam
30bffca5c3
Merge pull request #9193 from JosJuice/android-clear-motioncontrolsenabled
...
Android: Re-add motionControlsEnabled to clearWiimoteNewIniLinkedPreferences
2020-11-20 02:37:51 +01:00
Léo Lam
7f7fd4d8d3
Merge pull request #9220 from jordan-woyak/ext-crypto
...
WiimoteEmu: Implement extension encryption edge case.
2020-11-20 02:28:17 +01:00
Léo Lam
bca82bb942
Merge pull request #9239 from altimumdelta/FFDUMP_Separate_Logging
...
FrameDump Logging: Separate log type and migrate to fmt
2020-11-20 02:21:57 +01:00
Léo Lam
5921a93d71
Merge pull request #9247 from Dentomologist/fix-updater-temporary-folder
...
Fix updater not always cleaning up temp directory
2020-11-20 02:01:43 +01:00
Léo Lam
eff566b318
Merge pull request #9258 from lioncash/core-log
...
Core: Convert logging over to fmt pt. 1
2020-11-19 20:32:19 +01:00
Lioncash
958cbf38a4
Core: Convert logging over to fmt pt. 1
...
Converts up to the DSP-related files for easier reviewing, the rest will
be progressively moved over after this change gets merged.
2020-11-19 14:21:06 -05:00
Léo Lam
e3247b567d
Merge pull request #9185 from Losuc/skipEFBaccessHotkey
...
Add a Skip EFB Access Hotkey
2020-11-19 17:28:45 +01:00
Léo Lam
dde6090e98
Common/MsgHandler: Add compile-time format string checks
2020-11-19 17:09:24 +01:00
Léo Lam
62eeb05519
Common: Validate the number of {} fields in format strings
...
Unfortunately, {fmt} allows passing too many arguments to a format call
without raising any runtime or compile-time error [1].
As this is a common source of bugs since we started migrating to {fmt},
this commit adds some custom logic to validate the number of
replacement fields in format strings in addition to {fmt}'s own checks.
[1] https://github.com/fmtlib/fmt/issues/492
2020-11-19 17:09:24 +01:00
Léo Lam
47c91696ee
Common/Log: Check format strings
...
Helps with catching incorrect format strings.
PanicAlertFmt already uses FMT_STRING and fmt::make_args_checked.
2020-11-19 17:09:24 +01:00
Admiral H. Curtiss
83c235b7cb
WiiUtils: Create Wii Shop log files when installing a WAD.
...
Fixes https://bugs.dolphin-emu.org/issues/12269
2020-11-19 03:26:27 +01:00
Léo Lam
4eecb8fd11
Merge pull request #9248 from lioncash/video-fmt
...
VideoCommon: Migrate over to fmt
2020-11-18 11:10:48 +01:00
Lioncash
3d9b2aa005
VideoCommon: Migrate over to fmt
...
Migrates off the printf-based formatting where applicable.
2020-11-17 21:23:58 -05:00
Léo Lam
eb1581bbcc
Merge pull request #9246 from JosJuice/translation-eot
...
DolphinQt: Don't return 0x04 bytes from tr
2020-11-18 02:31:13 +01:00
Léo Lam
31d7be521c
Merge pull request #7714 from cristian64/avoid_leaking_gamelistmodel
...
DolphinQt: Avoid leaking the GameListModel instance to gracefully shutdown the GameTracker and prevent a crash on exit
2020-11-18 02:14:51 +01:00
Léo Lam
0339889806
Merge pull request #9251 from sepalani/sockopt
...
IP/Top: Add missing sockopt
2020-11-18 02:10:37 +01:00
Léo Lam
b8bc6c3c86
Merge pull request #9256 from JosJuice/android-keep
...
Android: Add @Keep annotation to things accessed using JNI
2020-11-18 01:01:34 +01:00
JosJuice
52c615f1b1
Remove a redundant i18n comment
2020-11-17 18:23:27 +01:00
JosJuice
a8d385c705
Android: Add @Keep annotation to things accessed using JNI
...
This acts as a hint to both people and automated tools
that a variable or method shouldn't be renamed or removed.
2020-11-17 14:11:51 +01:00
JosJuice
9a01c3fb9f
Use positional arguments in all translatable fmt strings
...
We want to use positional arguments in translatable strings
that have more than one argument so that translators can change
the order of them, but the question is: Should we also use
positional arguments in translatable strings with only one
argument? I think it makes most sense that way, partially
so that translators don't even have to be aware of the
non-positional syntax and partially because "translatable
strings use positional arguments" is an easier rule for us
to remember than "transitional strings which have more than
one argument use positional arguments". But let me know if
you have a different opinion.
2020-11-16 13:28:11 +01:00
Dentomologist
6dcf7643e5
Fix updater not always cleaning up temp directory
...
Updater was only deleting TempUpdate folder when an error occured.
2020-11-13 12:25:53 -08:00
JosJuice
53da97208a
DolphinQt: Don't return 0x04 bytes from tr
...
tr calls with more than one argument would have a 0x04 byte
in the returned string when no translation was found
(which always is the case when using Dolphin in English).
2020-11-12 19:44:44 +01:00
Léo Lam
8a621c2d5e
Merge pull request #9236 from lioncash/log-backend
...
VideoBackends: Migrate logging over to fmt
2020-11-12 14:51:28 +01:00
Léo Lam
ec5313fe24
Merge pull request #9204 from fbastos1/master
...
fix emulator issue #12139
2020-11-12 14:43:35 +01:00
Lioncash
d8e1921b57
InputCommon: Migrate over to fmt-capable panic alerts
...
Continues the migration over to fmt.
2020-11-12 02:29:26 -05:00
LC
93212049ac
Merge pull request #9242 from lioncash/disc-panic
...
DiscIO: Make use of fmt-capable panic alerts
2020-11-12 02:22:21 -05:00
JosJuice
161f8c3fad
Android: Warn when path in config is unavailable
...
Content URIs stop working if Dolphin loses permissions,
which happens for instance when reinstalling Dolphin.
2020-11-11 18:56:15 +01:00
JosJuice
9e3e325add
Merge pull request #9243 from JosJuice/android-input-overlay-null
...
Android: Add null check for InputOverlay
2020-11-11 11:22:41 +01:00
JosJuice
32ad2dcec3
Android: Add null check for InputOverlay
...
Hopefully fixes https://bugs.dolphin-emu.org/issues/12316 .
2020-11-11 10:38:49 +01:00
Lioncash
689eec5304
DiscIO: Make use of fmt-capable panic alerts
...
Migrates the DiscIO code over to fmt.
2020-11-11 01:09:42 -05:00
LC
ae83685b0b
Merge pull request #9237 from lioncash/msghandler
...
Common/MsgHandler: Add fmt-capable variants of the alert macros
2020-11-11 00:34:45 -05:00
altimumdelta
f44b13ffcd
FrameDump Logging: Separate log type and migrate to fmt
2020-11-10 17:17:43 +01:00
LC
0a2564a89d
Merge pull request #9234 from lioncash/rename-fmt
...
ShaderGenCommon: Rename WriteFmt() to Write()
2020-11-09 22:08:42 -05:00
JosJuice
ff4b7ca7f4
Remove Android-specific settings from UISettings.cpp
...
They are unused, since there is no C++ code that touches
these settings. See the discussion in PR 9152, which is
a PR that adds a lot more Android-specific settings.
2020-11-09 21:41:00 +01:00
JosJuice
e260f9815c
Android: Move orientation setting to main settings screen
...
I moved it from the main settings screen to the in-game menu
in PR 8439 so that it could be changed while a game is running,
but now that the main settings can be accessed while a game is
running, there's no reason to not put it in the main settings.
https://bugs.dolphin-emu.org/issues/12067
2020-11-09 21:41:00 +01:00
Lioncash
7b21f7af2e
Common/MsgHandler: Add fmt-capable variants of the alert macros
...
Adds an interface that uses fmt under the hood, which is much more
flexible than printf, particularly for localization purposes, given fmt
supports positional formatters in a cross-platform manner out of the box
with no configuration necessary.
2020-11-09 08:48:17 -05:00
LC
43e2f0e88f
Merge pull request #9235 from lioncash/ui-log
...
UICommon: Migrate logging over to fmt
2020-11-09 07:28:28 -05:00
JosJuice
8181a7b3dd
Android: Remove unnecessary ANativeWindow_release call
...
This is already handled by SurfaceDestroyed. In the worst case,
the extra code could even race with SurfaceDestroyed if they
are triggered at the same time, but this is highly improbable.
2020-11-09 10:38:50 +01:00
JosJuice
d982afd1ef
Android: Fix alert messages when EmulationActivity is being destroyed
...
The previous commit made this easy to reproduce when launching
an invalid disc image with the phone rotated incorrectly.
2020-11-09 10:38:50 +01:00
JosJuice
ee52f465b1
Android: Fix rotating EmulationActivity after boot fails
...
Time for yet another new iteration of working around the
"surface destruction during boot" problem...
This time, the strategy is to use a mutex in MainAndroid.cpp.
2020-11-09 10:38:49 +01:00
JosJuice
d06830b274
Android: Only show emulation menu toast if boot succeeds
2020-11-09 10:33:53 +01:00
JosJuice
0280f3557c
Android: Finish EmulationActivity from C++
...
This makes EmulationActivity automatically close if booting
fails, and lets us get rid of s_emulation_end_event.
2020-11-09 10:33:52 +01:00
Lioncash
21dd7a8ebb
Vulkan: Migrate logging over to fmt
...
Migrates the vulkan backend over to the fmt-capable logger.
2020-11-09 03:26:16 -05:00
Lioncash
23a8baa605
Software: Migrate logging over to fmt
...
Migrates the software backend over to the fmt-capable logger.
2020-11-09 03:14:01 -05:00
Lioncash
413d64e7fc
OpenGL: Migrate logging over to fmt
...
Migrates over to the fmt-capable logger.
2020-11-09 03:09:09 -05:00
Lioncash
4d9a7c7a54
D3DCommon: Migrate logging over to fmt
...
Migrates the logging over to the fmt-capable logger.
2020-11-09 03:03:26 -05:00
Lioncash
2345d5f98d
D3D: Migrate logging over to fmt
...
Migrates the logging over to the fmt-capable logger.
2020-11-09 03:02:00 -05:00
Lioncash
d7834bd6b4
D3D12: Migrate logging over to fmt
...
Migrates the logging over to the fmt-capable logger.
2020-11-09 02:59:51 -05:00
Lioncash
52f2fadb36
UICommon: Migrate logging over to fmt
...
A very simple change that continues the migration of the logs over to
fmt.
2020-11-09 02:39:55 -05:00
Lioncash
a5b28f1f07
ShaderGenCommon: Rename WriteFmt() to Write()
...
Now that we've converted all of the shader generators over to using fmt,
we can drop the old Write() member function and perform a rename
operation on the WriteFmt() to turn it into the new Write() function.
All changes within this are the removal of a <cstdarg> header, since the
previous printf-based Write() required it, and renaming. No functional
changes are made at all.
2020-11-09 02:31:49 -05:00
LC
a9ef7e0e43
Merge pull request #9225 from JosJuice/android-convertfragment-path
...
Android: Rename path variable in ConvertFragment
2020-11-09 02:16:59 -05:00
LC
db83c7ec8d
Merge pull request #9227 from JosJuice/android-menu-scrollbar
...
Android: Make scrollbar for in-game menu always visible
2020-11-09 02:16:34 -05:00
LC
98726400bc
Merge pull request #9230 from JosJuice/android-savesettings-onstop
...
Android: Call saveSettings in EmulationActivity.onStop
2020-11-09 02:15:21 -05:00
LC
418f9faa9d
Merge pull request #9228 from JosJuice/android-jclass
...
Android: Fix jobject/jclass warnings
2020-11-09 02:15:04 -05:00
LC
766fab2561
Merge pull request #9231 from Ebola16/ASW
...
Android: Remove unnecessary WrongConstant warning suppression
2020-11-09 02:14:26 -05:00
LC
add2b44eb7
Merge pull request #9197 from lioncash/uber-pixel
...
UberShaderPixel: Migrate over to fmt
2020-11-09 02:13:57 -05:00
JosJuice
6df543fbc9
Android: Catch SecurityException in ContentHandler
2020-11-08 23:05:34 +01:00
JosJuice
713d309386
Android: Call notifyItemChanged after file picker
2020-11-08 23:05:33 +01:00
JosJuice
62e6bedd25
Android: Show warning after picking file with wrong extension
2020-11-08 23:05:31 +01:00
JosJuice
73f013e3cc
Android: Use storage access framework for custom SD card paths
...
This is part of my efforts to add support for scoped storage.
2020-11-08 17:51:59 +01:00
altimumdelta
77dc289517
CPUDetect: Indicate slow PDEP/PEXT only for Zen1/+/2 (Family 23)
2020-11-08 14:27:24 +01:00
Admiral H. Curtiss
cae741584b
InputCommon: Return error, if any, from ControlReference::SetExpression().
2020-11-08 01:04:33 +01:00
JosJuice
e4793cfb39
Android: Don't name unused JNIEnv/jobject/jclass parameters
2020-11-07 12:08:48 +01:00
JosJuice
57dc54144d
Android: Fix jobject/jclass warnings
...
Static methods use jclass, and non-static methods use jobject.
2020-11-07 12:06:57 +01:00
Ryan Meredith
cd52da959c
Android: Remove unnecessary WrongConstant warning suppression
2020-11-07 01:35:59 -05:00
JosJuice
a1a4d12b62
Android: Call saveSettings in EmulationActivity.onStop
...
I didn't realize that onSaveInstanceState doesn't get called
when finishing the activity.
2020-11-06 22:40:29 +01:00
JosJuice
2acd3abe35
Merge pull request #9223 from Ebola16/D
...
Android: Suppress warnings in EmulationActivity
2020-11-06 19:57:06 +01:00
JosJuice
5afda5efe3
Merge pull request #9209 from Ebola16/AIRSDS
...
Android: Update IR sensitivity default values
2020-11-06 19:56:53 +01:00
JosJuice
70df5446d3
Android: Make the handling of SAF open modes more robust
2020-11-06 17:40:03 +01:00
JosJuice
b6e236ef86
Android: Make scrollbar for in-game menu always visible
...
Some users aren't noticing that the in-game menu can be scrolled.
I hope this will help with that, though I'm not sure by how much.
2020-11-06 11:40:38 +01:00
JosJuice
a348efe947
Fix dereferencing nullptr BootParameters
2020-11-06 09:34:53 +01:00
JosJuice
56122f38bb
Android: Rename path variable in ConvertFragment
...
Not sure why I named it path, because it isn't a path.
2020-11-05 18:16:07 +01:00
Sepalani
4e32ec35a7
IP/Top: Add missing sockopt
2020-11-05 19:51:20 +04:00
Ryan Meredith
0a239cc1bd
Android: Suppress warnings in EmulationActivity
2020-11-04 20:34:25 -05:00
JosJuice
28aa04312c
Common/LinearDiskCache: Replace std::fstream with File::IOFile
...
File::IOFile is better suited to this type of task.
Split out from a future PR.
2020-11-05 00:31:17 +01:00
Jordan Woyak
a9c643e698
WiimoteEmu: Implement extension encryption edge case.
2020-11-04 15:22:06 -06:00
Markus Wick
069840fb7e
Merge pull request #9218 from JosJuice/aarch64-hle-hooks
...
JitArm64: Implement HLE function hooking
2020-11-04 10:29:37 +01:00
Jordan Woyak
3cd4c56645
Merge pull request #9203 from nick-michael/virtual-notches
...
Logic & UI for "Virtual Notches"
2020-11-03 17:10:54 -06:00
Nick Michael
55dd3d7337
Virtual Notch settings and UI for octagonal stick
2020-11-03 22:06:27 +00:00
Jordan Woyak
d2f80a4595
Merge pull request #9138 from martymac/VK_NULL_HANDLE-fix
...
Fix build on FreeBSD i386 - nullptr vs VK_NULL_HANDLE
2020-11-03 08:28:11 -06:00
JosJuice
fe986b6161
JitArm64: Implement HLE function hooking
...
Closely based on the x86-64 implementation.
Fixes https://bugs.dolphin-emu.org/issues/10965 .
2020-11-03 09:48:22 +01:00
Ganael Laplanche
d456e2e391
Resolve VkDeviceMemory/nullptr type mismatch to fix build on FreeBSD i386
2020-11-03 07:47:43 +01:00
LC
d5c0a9a185
Merge pull request #9215 from JosJuice/android-pointer-portrait
...
Android/InputOverlayPointer: Don't assume surface covers whole screen
2020-11-02 18:05:47 -05:00
LC
4e2875eec3
Merge pull request #9217 from JosJuice/android-touch-checks
...
Android: Remove some touchscreen checks from EmulationActivity
2020-11-02 18:05:15 -05:00
Léo Lam
cbaf8f82ec
Merge pull request #9214 from OatmealDome/macos-bind
...
Top: Set port when connecting a socket to find the default interface
2020-11-02 22:17:38 +01:00
Léo Lam
5b9cd83137
Merge pull request #8758 from sepalani/so-shutdown
...
Socket: Abort pending operations on shutdown
2020-11-02 21:52:28 +01:00
OatmealDome
dd688f4eb0
Top: Set port when connecting a socket to find the default interface
2020-11-02 13:27:38 -05:00
JosJuice
8123263631
Android: Remove some touchscreen checks from EmulationActivity
...
It's better to directly check whether we have an InputOverlay
than to check a proxy for it.
2020-11-02 11:05:21 +01:00
JosJuice
f6ef6a317d
Android: Don't reset savestate time on load
2020-11-02 10:47:39 +01:00
JosJuice
a66afc864f
Android/InputOverlayPointer: Don't assume surface covers whole screen
...
This assumption is false both in portrait mode (where it only
covers the top half of the screen) and when using two apps at once.
Fixes https://bugs.dolphin-emu.org/issues/12307 .
2020-11-02 10:23:57 +01:00
JosJuice
4bb0ac918b
Simplify Arm64GPRCache::Flush
...
`flush = cond ? flush : true` makes little sense when `flush`
is always true at that point.
2020-11-01 19:48:57 +01:00
Losucaru
407ef8b596
Add a Skip EFB Access from CPU Hotkey
2020-10-29 21:03:06 -03:00
Ryan Meredith
9999cf05f3
Android: Update IR sensitivity default values
2020-10-29 17:58:16 -04:00
Léo Lam
f665ddae51
Merge pull request #9202 from WamWooWam/patch-http-requests
...
Fix logger related crash when HTTP response is empty.
2020-10-29 22:07:24 +01:00
Léo Lam
650638c069
Merge pull request #9091 from shuffle2/pch
...
Add some files to pch
2020-10-29 21:29:28 +01:00
Thomas May
72e1131123
Common: Fix logger related crash when HTTP response is empty
2020-10-29 21:20:59 +01:00
Felipe
d7fa75ef64
modify file export to create folder in OS when explicitly extracting a directory
2020-10-29 15:20:46 -04:00
LC
fe727ed1d0
Merge pull request #9194 from leoetlino/offsetof-warning
...
IOS/USB: Fix -Winvalid-offset warnings
2020-10-29 12:53:11 -04:00
LC
3a5b921008
Merge pull request #9206 from Ebola16/SOMC
...
Android: Minor cleanups
2020-10-29 12:52:40 -04:00
LC
752b1048df
Merge pull request #9196 from Dentomologist/update-register-view-debug-font
...
DolphinQt: Update register view font when Debug Font changes
2020-10-29 12:52:02 -04:00
Dentomologist
5fe7528855
DolphinQt: Update register view font when Debug Font changes
...
Resolves https://bugs.dolphin-emu.org/issues/12261
Co-authored-by: Léo Lam <leo@leolam.fr>
2020-10-29 09:31:14 -07:00
JMC47
6a3a71cfd7
Merge pull request #9141 from Techjar/but-for-how-long
...
Re-enable GPU Texture Decoding under MoltenVK
2020-10-29 01:22:13 -04:00
Ryan Meredith
cc53249591
Android: showMotionControlsOptions cleanup
2020-10-28 06:17:11 -04:00
Sergei Trofimovich
447de580ab
Source/Core/Common/Config/Config.cpp: add missing <mutex> include
...
Noticed missing include as a build failure on gcc-11:
```
[ 15%] Building CXX object Source/Core/Common/CMakeFiles/common.dir/Config/Config.cpp.o
Source/Core/Common/Config/Config.cpp:23:24:
error: 'unique_lock' in namespace 'std' does not name a template type
23 | using WriteLock = std::unique_lock<std::shared_mutex>;
| ^~~~~~~~~~~
Source/Core/Common/Config/Config.cpp:11:1:
note: 'std::unique_lock' is defined in header '<mutex>';
did you forget to '#include <mutex>'?
```
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
2020-10-28 08:53:15 +00:00
Ryan Meredith
df4cef44fd
Android: Remove unused imports
2020-10-28 02:14:30 -04:00
LC
23e6980b7b
Merge pull request #9200 from shuffle2/nomoc
...
dolphinqt msbuild: do not moc TASSlider.h
2020-10-27 13:28:16 -04:00
Lioncash
dc72edf0e2
UberShaderPixel: Migrate over to fmt
...
Completes the migration over to using the fmt-formatting WriteFmt
function. The next PR will rename all usages of WriteFmt, while
simultaneously getting rid of the old printf code.
2020-10-27 13:25:11 -04:00
Ryan Meredith
721f3bef69
Android: Fix initTouchPointer
2020-10-27 05:15:17 -04:00
Shawn Hoffman
2ebe02fd1b
dolphinqt msbuild: do not moc TASSlider.h
2020-10-26 18:37:46 -07:00
Léo Lam
2d921da860
FileUtil: Fix format string
...
Fixes a recent regression: https://github.com/dolphin-emu/dolphin/pull/9187#issuecomment-716835091
2020-10-26 22:47:56 +01:00
Léo Lam
d2a2ec870d
Merge pull request #9171 from lioncash/pixel
...
PixelShaderGen: Migrate over to fmt
2020-10-26 20:35:47 +01:00
Léo Lam
07e6d008bd
Merge pull request #9187 from lioncash/commonlog
...
Common: Migrate logging to fmt
2020-10-26 19:01:26 +01:00
Léo Lam
7f66de062c
Merge pull request #9188 from jordan-woyak/stop-caring-about-old-avcodec-versions
...
VideoCommon/FrameDump: Remove code for older versions of avcodec.
2020-10-26 18:55:48 +01:00
Léo Lam
aae72c3e75
Merge pull request #9195 from jordan-woyak/mem-warning
...
DolphinQt: Add a warning to the MEM1/MEM2 override setting description.
2020-10-26 18:49:33 +01:00
Léo Lam
23c9179fb6
Merge pull request #9071 from orbea/cmake
...
cmake: Silence warnings.
2020-10-26 18:48:42 +01:00
Jordan Woyak
15914b749c
DolphinQt: Add a warning to the MEM1/MEM2 override setting description.
2020-10-25 12:54:42 -05:00
JosJuice
3a119e1ec7
Android: Update WiimoteNew.ini preferences instead of deleting
2020-10-24 22:45:02 +02:00
Léo Lam
8b9a0c9e09
IOS/USB: Fix -Winvalid-offset warnings
...
Unfortunately, compilers will issue warnings when using offsetof with
non-standard layout types even when offsetof actually works fine here;
just having a virtual function is enough to trigger the warning...
Let's just stop the scan threads explicitly in destructors instead of
relying on member destruction order.
2020-10-24 14:02:38 +02:00
JosJuice
563d9365b5
Android: Re-add motionControlsEnabled to clearWiimoteNewIniLinkedPreferences
...
This was removed in cc5802b
when it should have
been converted to the new setting instead,
and it seems like I didn't notice when reviewing it.
I'm changing the DirectoryInitialization logic a little
so that clearWiimoteNewIniLinkedPreferences also is called
when there was no WiimoteNew.ini previously, in case the
user deleted WiimoteNew.ini but not Dolphin.ini.
2020-10-24 13:08:29 +02:00
iwubcode
8a4773bc91
VideoCommon: update vcproj file to set HAS_OPENGL
2020-10-23 17:08:53 -05:00
iwubcode
a34745926e
VideoCommon: remove HAS_OPENGL from VideoBackendBase
2020-10-23 17:00:32 -05:00
iwubcode
272717b3f4
VideoCommon: update vcproj file to set HAS_VULKAN
2020-10-23 17:00:05 -05:00
iwubcode
d12380f26b
VideoCommon: rename USE_VULKAN to HAS_VULKAN in VideoBackendBase
2020-10-23 16:59:22 -05:00
Lioncash
5de2244acf
PixelShaderGen: Migrate over to fmt
...
Continues the migration of the shader generators over to fmt.
After this, all that remains in the Ubershader pixel generator.
2020-10-23 17:17:55 -04:00
Jordan Woyak
4902146329
VideoCommon/FrameDump: Remove code for older versions of avcodec.
2020-10-23 14:43:50 -05:00
Lioncash
4e8df93f41
Common: Migrate logging to fmt
...
Continues the migration of our code over to the fmt logger.
2020-10-23 14:58:03 -04:00
Léo Lam
285b926e92
Merge pull request #8782 from Pokechu22/missing-serial-version-data
...
Explain how to fix "Serial and/or version data is missing"
2020-10-23 20:44:06 +02:00
Léo Lam
e89db89d9e
Merge pull request #9098 from jordan-woyak/wm-report-duplication
...
WiimoteReal: Only duplicate data reports when speaker data is enabled.
2020-10-23 20:38:25 +02:00
mazes-80
f375ee72a2
CMake: Add option to enable/disable Vulkan video backend
2020-10-23 20:14:46 +02:00
JosJuice
908d6f8fa0
Merge pull request #9179 from leoetlino/available-video-backends
...
VideoCommon: Get rid of the global g_available_video_backends
2020-10-23 20:02:21 +02:00
LC
4f5c8bb42a
Merge pull request #9177 from JosJuice/android-savestate-time
...
Android: Show how long ago each savestate was created
2020-10-23 13:59:43 -04:00
Léo Lam
ce6eda7c71
Merge pull request #9184 from lioncash/inputlog
...
InputCommon: Migrate logging over to fmt
2020-10-23 19:59:22 +02:00
LC
87e4a0785a
Merge pull request #9182 from jordan-woyak/frame-dump-cleanup
...
VideoCommon: FrameDump fixes/cleanups.
2020-10-23 13:59:00 -04:00
LC
c42b80a156
Merge pull request #9186 from JosJuice/rtl-pot
...
DolphinQt: Move QT_LAYOUT_DIRECTION string to qt-strings.pot
2020-10-23 13:37:10 -04:00
Lioncash
a5e1415e74
InputCommon: Migrate logging over to fmt
...
Continues the migration of the logging calls over to the fmt capable
ones.
2020-10-23 13:16:18 -04:00
JosJuice
7841fb7337
DolphinQt: Move QT_LAYOUT_DIRECTION string to qt-strings.pot
...
Now that we have a .pot file specifically for strings from
Qt itself, it makes sense to move this into it.
2020-10-23 18:45:35 +02:00
Léo Lam
64f7a4448b
Merge pull request #9178 from lioncash/disclog
...
DiscIO: Migrate logging over to fmt
2020-10-22 22:07:53 +02:00
Lioncash
e93fbb7c5e
DiscIO: Migrate logging over to fmt
...
Eliminates quite a bit of the PRI* macros used for handling 64-bit
values.
2020-10-22 15:41:42 -04:00
Jordan Woyak
e8bb88c2a1
DolphinQt: Don't call UICommon::InhibitScreenSaver if already in desired state.
2020-10-22 13:19:01 -05:00
Jordan Woyak
4807a5e157
VideoCommon: FrameDump fixes/cleanups.
2020-10-22 12:17:26 -05:00
JosJuice
ba2aeb99d6
Android: Remove hacks for Wii Remote extension setting, round 2
...
It's still not exactly pretty, but now all the mess
is contained in one place and has a proper interface.
Fixes https://bugs.dolphin-emu.org/issues/12218 .
2020-10-22 11:37:56 +02:00
Léo Lam
89b01cd6d3
Merge pull request #9169 from lioncash/uber-vert
...
UberShaderVertex: Migrate over to fmt
2020-10-22 01:21:31 +02:00
Léo Lam
08f9ed043b
Merge pull request #8846 from nyanpasu64/fix-cmake-zlib
...
Fix Windows CMake builds with shared zlib
2020-10-22 01:11:27 +02:00
Léo Lam
96ce3e5f49
Merge pull request #9176 from lioncash/audiofmt
...
AudioCommon: Migrate logging over to fmt
2020-10-22 01:03:16 +02:00
Pokechu22
88bc32b638
Explain how to fix "Serial and/or version data is missing"
2020-10-21 15:39:26 -07:00
Lioncash
dcb0c910af
Common/Matrix: Allow TVec classes to be used in constexpr contexts
...
Much of these classes are operating on integral types and are pretty
standard behavior as far as vectors go. Some member functions can be
made constexpr to make them more flexible and allow them to be used in
constexpr contexts.
2020-10-21 17:44:02 -04:00
LC
de96fe0860
Merge pull request #9162 from jordan-woyak/quaternion
...
Replace stateful rotational matrices with quaternions.
2020-10-21 17:34:11 -04:00
Léo Lam
e553197c67
Merge pull request #8880 from AdmiralCurtiss/gcmemcard-sketchy-code-cleanup
...
Sketchy code cleanup in GCMemcard and GCMemcardDirectory.
2020-10-21 23:13:22 +02:00
JosJuice
21d3ea523c
Android: Show how long ago each savestate was created
2020-10-21 22:49:59 +02:00
Léo Lam
a8b7c3b577
Merge pull request #8893 from JosJuice/android-jni-declarations
...
Android: Remove unnecessary JNI function declarations
2020-10-21 22:46:58 +02:00
Léo Lam
7b9a464c93
Merge pull request #8895 from sepalani/card
...
GCMemcard: Rename unknown field to m_dtv_status
2020-10-21 22:32:09 +02:00
Léo Lam
18b2553538
Merge pull request #9078 from JosJuice/android-metadata-from-core
...
Android: Get game metadata from core
2020-10-21 22:29:21 +02:00
Léo Lam
d08b80828d
VideoCommon: Simplify VideoBackendBase::GetDefaultBackendName
...
Now we can just call GetDefaultVideoBackend to get the default backend
and get its name by calling GetName.
2020-10-21 22:00:10 +02:00
Léo Lam
aaaa3896c0
VideoCommon: Get rid of the global g_available_video_backends
...
Replace it with a function-local static that is initialized on first
use. This gets rid of a global variable and removes the need for
manual initialization in UICommon.
This commit also replaces the weird find_if that looks for a non-null
unique_ptr with a simple "is vector empty" check considering that
none of the pointers can be null by construction.
2020-10-21 22:00:10 +02:00
JosJuice
e86d713600
Android: Attach CPU thread to JVM early
2020-10-21 21:10:28 +02:00
Léo Lam
fd5f9f4c26
Merge pull request #8927 from Filoppi/wiimote-pan-fix
...
Fixed volume of emulated wii mote speakers not being native.
2020-10-21 21:02:39 +02:00
Filoppi
cf8b52735f
Fix volume of emulated wii mote speakers not being native
...
As in the comment, the panning was denaturalizing the volume (when the panning was at 0).
Unless users actually want to use panning, their wii mote volume should not be reduced, it should come out at the same volume the samples were.
If users want to reduce the volume of the wii mote speakers, they can do so from the wii home menu.
I opted for this instead of adding another setting "Enable Panning" as it would have been confusing, and the changes in the panning formula are unlikely to have any negative effect, as it still works.
2020-10-21 20:54:21 +02:00
Léo Lam
97de366b0f
Merge pull request #9160 from jordan-woyak/xinput2-stuck-keys
...
Linux/XInput2: Fix keys being stuck pressed on focus loss.
2020-10-21 20:47:32 +02:00
JosJuice
3a0917371e
Android: Don't show game ID after game title
2020-10-21 20:02:52 +02:00
JosJuice
0dc29c743b
Android: Get game metadata from core
...
Trying to get it from a GameFile before emulation starts is unreliable.
2020-10-21 20:02:52 +02:00
JosJuice
b6fcfcb9c9
Core: Always call Host_TitleChanged on boot
...
A title change to a title with no game ID is still a title change.
2020-10-21 19:57:27 +02:00
JosJuice
1ddf7277b9
Core: Set bWii before calling Host_TitleChanged
2020-10-21 19:57:27 +02:00
Lioncash
22a79289d3
AudioCommon: Migrate logging over to fmt
...
printf specifiers, begone!
2020-10-21 13:32:28 -04:00
Léo Lam
43d11ca3eb
Merge pull request #8962 from JosJuice/android-saf-wad
...
Android: Use storage access framework for importing WADs
2020-10-21 19:16:10 +02:00
Léo Lam
09e87b79f1
Merge pull request #9173 from lioncash/fmtlog
...
Common/Log: Add basic fmt-capable functions to the interface.
2020-10-21 19:11:19 +02:00
Lioncash
425f2aa013
Common/Log: Add basic fmt-capable functions to the interface.
...
Provides a basic extension to the interface to begin migration off of
the printf-based logging system.
Everything will go through macros with the same style naming as the old
logging system, except the macros will have the _FMT suffix, while the
migration is in process.
This allows for peacemeal migration over time instead of pulling
everything out and replacing it all in a single pull request, which
makes for much easier reviewing.
2020-10-21 10:49:35 -04:00
Léo Lam
f265c412b4
Merge pull request #9152 from Ebola16/SP1
...
Android: Convert SharedPreferences to INI Settings (simple cases)
2020-10-21 16:48:18 +02:00
Léo Lam
642eccbfd0
Merge pull request #9174 from lioncash/os
...
Common: Move OSThreads into Core
2020-10-21 15:39:29 +02:00
Lioncash
57534777d4
Common: Move OSThreads into core
...
Common shouldn't be depending on APIs in Core (in this, case depending
on the PowerPC namespace). Because of the poor separation here, this
moves OSThread functionality into core, so that it resolves the implicit
dependency on core.
2020-10-21 07:35:42 -04:00
Lioncash
144f799bbb
ARDecrypt: Resolve seedtable at compile-time
...
We can boot the formation of the table off to the compiler at
compile-time, rather than building the table at run-time.
2020-10-20 19:11:04 -04:00
Jordan Woyak
7e197186b9
Merge pull request #9172 from lioncash/compile
...
ExpressionParser: Add missing <functional> include
2020-10-20 15:23:14 -05:00
Lioncash
faf509e315
ExpressionParser: Add missing <functional> include
...
Unbreaks Windows CMake builds.
2020-10-20 16:18:32 -04:00
Ryan Meredith
353a67824d
Android: Add AndroidOverlayButtons INI section
2020-10-20 12:03:41 -04:00
Ryan Meredith
69adfe0218
Android: Add "Default Values" button for overlay seekbars
2020-10-20 11:59:57 -04:00
Ryan Meredith
cc5802ba04
Android: Convert SharedPreferences to INI Settings (simple cases)
2020-10-20 11:58:54 -04:00
Lioncash
751d67a59a
UberShaderVertex: Migrate over to fmt
...
Continues migration of the shader generators over to fmt.
With this, all that's left to move over are the pixel shaders (regular
and ubershader variants)
2020-10-20 09:24:10 -04:00
Léo Lam
ce59b026c0
Merge pull request #9168 from lioncash/ifconst
...
DataReader: Make use of if constexpr where applicable
2020-10-20 14:56:24 +02:00
Léo Lam
299adf537d
Merge pull request #9021 from AdmiralCurtiss/gui-memcard-format-sram
...
Qt/GCMemcardCreateNewDialog: Use zero values for formatting instead of accessing g_SRAM.
2020-10-20 14:55:23 +02:00
Léo Lam
70ab3bf7b3
Merge pull request #9025 from cyrozap/fix-build-with-older-cmake
...
Fix builds with system LZMA when using versions of CMake before 3.14
2020-10-20 14:51:15 +02:00
Lioncash
7bc2bbc508
DataReader: Make use of if constexpr where applicable
...
We can make use of if constexpr for cases where booleans will always
statically be known at compile-time.
2020-10-20 08:42:32 -04:00
Léo Lam
dc5ae5ee66
Merge pull request #9165 from lioncash/ubercommon
...
UberShaderCommon: Migrate over to fmt
2020-10-20 14:42:19 +02:00
Léo Lam
f653bd7559
Merge pull request #9142 from jordan-woyak/expose-fov
...
WiimoteEmu: Expose IR camera FOV to adjust IMU pointing sensitivity.
2020-10-20 14:32:02 +02:00
Léo Lam
b2709b81a0
Merge pull request #9166 from JosJuice/encryption-cache-move
...
DiscIO: Make WiiEncryptionCache moveable
2020-10-20 14:29:46 +02:00
Léo Lam
96cb27842a
Merge pull request #9048 from shuffle2/msvc-version
...
require msvc 19.27.29111 and Windows SDK 10.0.19041
2020-10-20 13:35:18 +02:00
Léo Lam
2e86e1a998
Merge pull request #9146 from JosJuice/android-disable-cover-download
...
Android: Allow disabling cover downloading
2020-10-20 13:31:01 +02:00
Léo Lam
49b7f10b39
Merge pull request #9163 from lioncash/fbgen
...
FramebufferShaderGen: Migrate over to fmt
2020-10-20 13:25:50 +02:00
Lioncash
83db7a707c
UberShaderCommon: Migrate over to fmt
...
Continues migration of the shader generators over to fmt.
2020-10-20 06:22:48 -04:00
Léo Lam
7b1e0dba9b
Merge pull request #9164 from lioncash/geoshader
...
GeometryShaderGen: Migrate over to fmt
2020-10-20 11:59:45 +02:00
JosJuice
5b6f604d90
DiscIO: Make WiiEncryptionCache moveable
...
Fixes the following warning:
../../../../../../Core\DiscIO/DirectoryBlob.h:156:3: warning: explicitly defaulted move constructor is implicitly deleted [-Wdefaulted-function-deleted]
DirectoryBlobReader(DirectoryBlobReader&&) = default;
^
../../../../../../Core\DiscIO/DirectoryBlob.h:205:22: note: move constructor of 'DirectoryBlobReader' is implicitly deleted because field 'm_encryption_cache' has a deleted move constructor
WiiEncryptionCache m_encryption_cache;
^
2020-10-20 11:33:38 +02:00
Léo Lam
409230e088
Merge pull request #9061 from Ebola16/Fixes3
...
Android: Improve WRITE_EXTERNAL_STORAGE denial
2020-10-20 02:15:08 +02:00
Léo Lam
fc3b474cce
Merge pull request #8318 from iwubcode/dynamic_input_textures
...
InputCommon: Dynamic Input Textures
2020-10-20 02:10:29 +02:00
Léo Lam
911704611e
Merge pull request #9096 from jordan-woyak/calibration-cleanup
...
ControllerEmu: Improve and simplify UpdateCalibrationData.
2020-10-20 02:01:16 +02:00
Léo Lam
98875346bd
Merge pull request #9104 from JosJuice/cmd-unicode
...
DolphinQt: Handle non-ASCII characters in Windows cmd arguments
2020-10-20 01:45:28 +02:00
Léo Lam
680ff4d168
Merge pull request #9136 from JosJuice/volumeverifier-partition-invalid-override
...
VolumeVerifier: Make "no valid data in partition" hide some other errors
2020-10-20 01:39:18 +02:00
Lioncash
5475a8d6eb
GeometryShaderGen: Migrate over to fmt
...
Continues migration of the shader generators over to fmt.
2020-10-19 19:22:02 -04:00
Léo Lam
8a8dc3db83
Merge pull request #8613 from jordan-woyak/expose-disable-ss
...
Config: Expose "DisableScreenSaver" in the UI and default it to true.
2020-10-20 01:20:24 +02:00
Léo Lam
d448bd5bdf
Merge pull request #9154 from Ebola16/RR
...
Android: ConfirmRunnable to RunRunnable with optional confirmation
2020-10-20 00:50:10 +02:00
Lioncash
df11615bde
FramebufferShaderGen: Migrate over to fmt
...
Continures the migration of the shader generators over to fmt.
2020-10-19 18:49:01 -04:00
Jordan Woyak
1dae834c62
WiimoteEmu: Tweak IMUCursor total yaw setting tool-tip.
2020-10-19 17:08:02 -05:00
Jordan Woyak
6b2eebf1f9
WiimoteEmu: Expose IR camera FOV to adjust IMU pointing sensitivity.
2020-10-19 17:08:02 -05:00
Jordan Woyak
907fdd26fc
WiimoteEmu: Use quaternions for orientation.
2020-10-19 16:34:45 -05:00
Jordan Woyak
09431635f3
InputCommon/WiimoteEmu: Replace stateful rotational matrices with quaternions.
2020-10-19 16:33:55 -05:00
Jordan Woyak
39030ea33c
Common/Matrix: Add Quaternion class.
2020-10-19 16:18:31 -05:00
JosJuice
bb03280462
VolumeVerifier: Make "no valid data in partition" hide some other errors
...
Not much use in knowing that the H3 hashes are wrong when the
partition consists of complete garbage.
2020-10-19 21:15:49 +02:00
JosJuice
439866d257
Android: Remove unnecessary JNI function declarations
...
We generally have no reason to call these functions on our own, so
there's not much reason to declare them, especially not in the cpp
file where they're defined. In case we ever do get a reason to do
it, we can add declarations for just the functions that need them.
2020-10-19 20:55:13 +02:00
Admiral H. Curtiss
b93adeaad7
VertexShaderGen: Fix unescaped { in D3D shader.
2020-10-19 20:05:07 +02:00
JosJuice
6380c65ff8
Android: Refetch game metadata after returning from settings
2020-10-19 20:03:47 +02:00
JosJuice
5e70dda4cc
Android: Allow disabling cover downloading
...
In case someone wants to be very careful with how much bandwidth
they use or with what data GameTDB.com collects on you.
This is already an option in DolphinQt (though in DolphinQt it
will switch entirely from using covers to banners when turned off).
2020-10-19 20:03:47 +02:00
JosJuice
195b551d87
Android: Allow reading global settings without a Settings object
...
This makes things more convenient for code that just
wants to read the current value of a setting.
2020-10-19 20:03:47 +02:00
Jordan Woyak
bbb12a7560
Linux/XInput2: Fix keys being stuck pressed on focus loss.
2020-10-19 11:46:01 -05:00
JosJuice
cb14b65aad
CMake: Fix build errors exposed by making common dependent on fmt
2020-10-19 14:36:09 +02:00
JosJuice
1084cfec1a
Add helper function for fmt::format(GetStringT(...
2020-10-19 14:36:08 +02:00
JosJuice
d100c1dc37
DiscIO: Make use of fmt where applicable
...
Once nice benefit of fmt is that we can use positional arguments
in localizable strings. This a feature which has been
requested for the Korean translation of strings like
"Errors were found in %zu blocks in the %s partition."
and which will no doubt be useful for other languages too.
2020-10-19 14:30:47 +02:00
LC
c9b2fbb64b
Merge pull request #9099 from sepalani/so-linger
...
IP/Top: Add SO_LINGER optname
2020-10-19 07:58:51 -04:00
LC
abfae46a2c
Merge pull request #9100 from sepalani/gethostid-log
...
IP/Top: Log IOCTL_SO_GETHOSTID properly
2020-10-19 07:58:15 -04:00
LC
49c7a5b289
Merge pull request #9121 from Sammi-Husky/bat-registers
...
DolphinQt/Debugger: Fix DBAT and IBAT registers in RegisterWidget
2020-10-19 07:56:42 -04:00
LC
fc5fbf5134
Merge pull request #9127 from Sintendo/fselx-movsd
...
Jit64: Optimize fsel a bit more
2020-10-19 07:55:40 -04:00
LC
cec47b9c32
Merge pull request #8981 from lioncash/vtx-fmt
...
LightingShaderGen/VertexShaderGen: Migrate over to fmt
2020-10-19 07:52:55 -04:00
LC
5722c680a4
Merge pull request #8006 from JosJuice/qt-rtl
...
DolphinQt: Enable RTL layout
2020-10-19 07:46:40 -04:00
Léo Lam
0de6a32f4c
Qt/QtUtils: Fix accidental recursion in ParallelProgressDialog
...
Seems to be a typo.
2020-10-19 12:39:10 +02:00
Léo Lam
a209410e70
Merge pull request #9148 from JosJuice/android-active-layer
...
Android: Fix setting read during play with local game layer active
2020-10-19 12:17:59 +02:00
Léo Lam
b3cb08830b
Merge pull request #9155 from JosJuice/tas-slider-right-click
...
DolphinQt: Reset TAS input slider to default on right-click
2020-10-19 12:09:23 +02:00
Léo Lam
150282f7b2
Merge pull request #9156 from JosJuice/android-alertmsg-outside-emulation
...
Android: Show alert messages as toasts outside of emulation
2020-10-19 11:55:24 +02:00
Jordan Woyak
50ec747840
Clean up screen saver inhibition and apply setting change immediately.
2020-10-18 16:31:48 -05:00
Jordan Woyak
fa83a3a114
DolphinQt: Expose "DisableScreenSaver" setting in the UI.
2020-10-18 16:31:46 -05:00
Jordan Woyak
50384cfab7
Config: Make "DisableScreenSaver" default to true.
2020-10-18 12:26:00 -05:00
JosJuice
8d91b4ea8c
Android: Show alert messages as toasts outside of emulation
...
It would be difficult to use the AlertMessage class for
messages that need to be showed outside of emulation,
but showing them as toasts is better than not showing them.
2020-10-18 16:06:46 +02:00
Ryan Meredith
d8c5f4323b
Android: ConfirmRunnable to RunRunnable with optional confirmation
2020-10-18 07:48:35 -04:00
JosJuice
6670226a44
DolphinQt: Reset TAS input slider to default on right-click
...
This is a feature which existed in DolphinWX. Seems like it got
implemented in DolphinQt for IRWidget/StickWidget but not sliders.
2020-10-18 13:47:00 +02:00
Sergei Trofimovich
af2a881a85
Source/Core/DiscIO/WIACompression.cpp: add missing <limits> include
...
Noticed missing include as a build failure on gcc-11:
```
[ 26%] Building CXX object Source/Core/DiscIO/CMakeFiles/discio.dir/WIACompression.cpp.o
../../../../Source/Core/DiscIO/WIACompression.cpp: In lambda function:
../../../../Source/Core/DiscIO/WIACompression.cpp:170:31: error: 'numeric_limits' is not a member of 'std'
170 | std::min<size_t>(std::numeric_limits<unsigned int>().max(), x));
| ^~~~~~~~~~~~~~
../../../../Source/Core/DiscIO/WIACompression.cpp:170:46: error: expected primary-expression before 'unsigned'
170 | std::min<size_t>(std::numeric_limits<unsigned int>().max(), x));
| ^~~~~~~~
```
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
2020-10-15 19:56:53 +01:00
JosJuice
16f5a50cfc
Merge pull request #9144 from JosJuice/confirm-runnable-finish
...
Android: Remove finish from ConfirmRunnableViewHolder
2020-10-15 18:44:01 +02:00
Léo Lam
ab2e226df8
Merge pull request #9105 from JosJuice/volumeverifier-small-low-severity
...
VolumeVerifier: Make high severity "too small" hide low severity "too small"
2020-10-14 12:41:57 +02:00