da0be24b2f
DSP: Reword inappropriate references to Global User Directory
...
These messages apply to the User directory regardless of
whether it's global or local, so we shouldn't specify "global".
Also changing "directory" to "folder", just for consistency
with "GC folder" in the same sentence.
2021-11-14 22:55:50 +01:00
2209dc0355
MoltenVK: Use an external project instead of a pre-compiled dylib
...
Also, update MoltenVK to match Vulkan SDK 1.2.189.
2021-11-13 11:43:23 -08:00
3e84279919
Merge pull request #10208 from thatSteveFan/patch-1
...
Minor comment fix in Matrix.cpp
2021-11-13 15:09:28 +01:00
868de78f16
VideoCommon: Use the copy filter for EFB copies as well as XFB copies
...
This fixes the pink screens in EA Sports Active. See https://gist.github.com/Pokechu22/49455f9094ed0ff017da64e3f7aa0404 for details.
2021-11-11 17:22:50 -08:00
58dc9e7049
msvc: fix compile warning on arm64
2021-11-11 08:01:39 -08:00
4008188654
msvc: update to vs2022 and windows sdk 10.0.22000
2021-11-11 08:01:26 -08:00
834a59d89b
Minor comment fix in Matrix.cpp
...
Fix comment to say (NxM times MxP).
2021-11-08 15:30:39 -08:00
850d281cb8
Jit_Integer: Fix pure rotation rlwimix case
...
We are writing to a.
2021-11-07 14:10:19 +00:00
6c72e6814d
Merge pull request #10169 from leoetlino/fmt-localtime
...
Use fmt::localtime instead of thread-unsafe std::localtime
2021-11-07 00:08:14 -04:00
c89226cbd4
Merge pull request #10203 from merryhime/ctx_lr
...
MachineContext: Correct CTX_LR for Apple ARM64
2021-11-07 00:06:24 -04:00
c385e7e57b
MachineContext: Correct CTX_LR for Apple ARM64
2021-11-06 21:46:35 +00:00
9c75957319
JitArm64_FloatingPoint: Implement fctiwx in ARM64 JIT
...
We implement this by first rounding to nearest integer using the current
rouding mode, then converting this value from floating point to an integral
value.
2021-11-06 20:54:26 +00:00
7c2b09e156
Arm64Emitter: Add FRINTI instruction
2021-11-06 19:15:26 +00:00
2c5d11cace
Merge pull request #9721 from linkmauve/fix-warnings
...
Fix some warnings found with gcc 11 and ffmpeg master
2021-11-06 14:38:07 +01:00
dfb32040bf
Jit64: divwx - Micro-optimize division by 2
...
Prefer using eax to isolate the sign bit. This saves a byte when the
destination ends up as r8-15, because those require a REX prefix.
Before:
41 8B C5 mov eax,r13d
41 C1 ED 1F shr r13d,1Fh
44 03 E8 add r13d,eax
41 D1 FD sar r13d,1
After:
41 8B C5 mov eax,r13d
C1 E8 1F shr eax,1Fh
44 03 E8 add r13d,eax
41 D1 FD sar r13d,1
2021-11-03 21:01:41 +01:00
f18f6cd0a2
Jit64: divwx - Improve comments
2021-11-02 21:50:28 +01:00
5a1333026b
VideoCommon: Add missing algorithm include for std::none_of
...
Otherwise this is an error on gcc/libstdc++, and there are no transitive
includes for this header.
2021-11-02 13:50:21 +01:00
7590f07b80
FrameDump: Remove deprecated call to av_init_packet()
...
This function was deprecated in ffmpeg in January[1], while its
replacement got introduced in 2015[2], so now might be the time to start
using it in Dolphin. :)
[1] f7db77bd87a9a6010637
2021-11-02 13:50:21 +01:00
24db6e467a
DolphinQt: Fix a -Wunused-result in gcc 11
...
Also use the correct error check for other similar calls in the same
file, despite nothing being doable on error.
2021-11-02 13:50:21 +01:00
25b136ac17
VideoCommon: Fix a -Wclass-memaccess in gcc 11
2021-11-02 13:50:21 +01:00
7e39a0405b
DolphinQt, VideoBackends: Fix all cases of -Wswitch in gcc 11
2021-11-02 13:50:21 +01:00
3d662e746b
Core: Fix a -Wshadow warning in gcc 11
...
This moves the only direct call to zlib’s crc32() into its own
translation unit, but that operation is cold enough that this won’t
matter in the slightest. crc32_z() would be more appropriate, but
Android has an older zlib version…
2021-11-02 13:50:21 +01:00
ab252aedfa
Core, DolphinQt, UICommon: Fix all cases of -Wrange-loop-construct in gcc 11
2021-11-02 13:50:21 +01:00
96a6d6fd95
Merge pull request #10184 from JosJuice/android-riivolution
...
Android: Allow starting game with Riivolution patches from the GUI
2021-10-31 23:44:54 +01:00
fb8b9f3251
Merge pull request #10194 from AdmiralCurtiss/riivolution-edge-cases
...
Fix some Riivolution file patching edge cases.
2021-10-31 21:24:03 +01:00
e51119c4ce
HLE: Fix hooks overlapping Riivolution patches
2021-11-01 00:07:14 +04:00
e91e04fe1e
RiivolutionPatcher: More closely match behavior of filename searching file patches to actual Riivolution.
2021-10-31 05:47:39 +01:00
335a1b5cb5
RiivolutionPatcher: More closely match behavior of folder patches to actual Riivolution.
2021-10-31 05:47:39 +01:00
34021b5ebc
Android: Allow starting game with Riivolution patches from the GUI
2021-10-30 23:24:36 +02:00
ef80d51df1
RenderWidget: Change "imgui.h" to <imgui.h>
...
This was originally intended to fix https://bugs.dolphin-emu.org/issues/12717 but this ended up not being the issue (instead it seems like files just weren't recompiled when imgui was updated due to MSVC weirdness). Still, using brackets instead of quotes is preferable as this is a library include.
2021-10-29 12:05:21 -07:00
5bb71760d7
Core/CheatSearchSession: Mark class as final.
2021-10-28 06:50:57 +02:00
b154ba513c
Core/CheatSearchSession: Make a few methods const.
2021-10-28 02:16:19 +02:00
6e814cbb8f
Qt/CheatSearchWidget: Add a checkbox to force parsing a value as hexadecimal.
2021-10-28 02:00:38 +02:00
b3e17d2772
Qt/CheatSearchFactoryWidget: Refuse to start standard memory region searches when no game is running because the memory size and console type may not be accurate.
2021-10-28 01:59:52 +02:00
d6ad3fbcb5
Qt/CheatsManager: Save and restory geometry.
2021-10-28 01:03:30 +02:00
db54e4f2b0
Externals: Update imgui to 1.85
2021-10-26 15:07:57 -07:00
05b4aecf18
Merge pull request #10186 from leoetlino/hle-hbreload
...
HLE: Fix hook flag for HBReload
2021-10-26 22:00:25 +02:00
7073a90474
Merge pull request #10177 from Dentomologist/gamelist_grid_mode_fix_select_all
...
GameList: Fix duplicate selections with ctrl+a in grid view
2021-10-25 17:22:58 +02:00
8cb51f276c
HLE: Fix hook flag for HBReload
...
The reload stub is at a fixed address (0x80001800) so its hook flag
should be HookFlag::Fixed.
Otherwise the hook is installed by HLE::PatchFixedFunctions but
immediately removed by HLE::PatchFunctions (which is called by
HLE::Reload right after PatchFixedFunctions).
Should fix https://bugs.dolphin-emu.org/issues/12716
2021-10-25 16:54:25 +02:00
04d8cdfe88
Convert LOG_TYPE and LOG_LEVELS to enum class
2021-10-24 11:48:36 -07:00
ba107819ec
Create EnumMap
2021-10-24 11:48:36 -07:00
4f82810845
RiivolutionPatcher: Use FileInfo instead of IOFile when only checking for filesize.
2021-10-24 00:09:09 +02:00
0efff5167d
IOS/FS: On NAND redirected files, the source and target of a Rename operation may be on different partitions or devices. Implement a fallback for that.
2021-10-24 00:09:09 +02:00
fe7f3a6f26
RiivolutionPatcher: Protect against three or more dots in path traversal.
2021-10-24 00:09:09 +02:00
22c6f2fe3b
RiivolutionPatcher: Handle the possibility of the FST already containing a main.dol file.
2021-10-24 00:09:09 +02:00
ba3373b476
RiivolutionPatcher: Modify memory patching logic to be more accurate to actual Riivolution.
2021-10-24 00:09:09 +02:00
dd64c0e423
Core: Deduplicate Riivolution Patch to BootParameters apply logic.
2021-10-24 00:09:08 +02:00
a76fdeee93
DolphinQt: Act like Riivolution and pre-select the last selected patch options when launching via the RiivolutionBootWidget.
2021-10-24 00:09:08 +02:00
2be62d94fc
RiivolutionParser: Add code to read and write the Riivolution config XMLs that remember the last selection.
2021-10-24 00:09:08 +02:00
2d3ed2c3ad
DolphinQt: Add ability to edit the Riivolution XML root directory when launching a patch.
2021-10-24 00:09:08 +02:00
d0c11f76b5
Core/BootManager: Disable loading time emulation for Riivolution-patched games until we have proper emulation for that.
2021-10-24 00:09:07 +02:00
6394960f54
Core: Add ability to specify and launch a riivolution-modded game via a .json file.
2021-10-24 00:09:07 +02:00
fe242f79ee
Core: Implement Wii NAND path redirects for Riivolution savegame patches.
2021-10-24 00:09:07 +02:00
588c31acb6
RiivolutionPatcher: Ignore last two bits of offset in file patches to match console behavior.
2021-10-24 00:09:07 +02:00
6ec4af7ea4
RiivolutionPatcher: Load external files with a layer of indirection during the patching process to properly resolve the paths given in the XML.
...
This also may eventually allow loading patches from sources other than the 1:1 expected file structure host file system, such as memory or an archive file.
2021-10-24 00:09:07 +02:00
175f225ac1
DolphinQt: Add ability to start a game with Riivolution patches from the GUI.
2021-10-24 00:09:06 +02:00
783b180dc8
Core: Add RiivolutionPatcher to apply Riivolution-style patches to a game's file system and memory.
2021-10-24 00:09:06 +02:00
e26b59bab3
Core: Add RiivolutionParser to parse a Riivolution XML.
2021-10-24 00:09:06 +02:00
a4da56e5e6
CommonPaths: Add a Riivolution subfolder in Load.
2021-10-24 00:09:06 +02:00
09fc39e2e5
DiscIO: Add CreateDisc/WAD/Volume() overloads that take a BlobReader directly.
2021-10-24 00:09:05 +02:00
e3f1de023f
DiscIO/DirectoryBlob: Add a callback that allows patching the main.dol and FST of the game partition during blob construction.
2021-10-24 00:09:05 +02:00
00ef9f2b4f
DiscIO/DirectoryBlob: Allow constructing a DirectoryBlobReader from a VolumeDisc.
2021-10-24 00:09:05 +02:00
3a72a39efd
DiscIO/DirectoryBlob: Allow constructing a DirectoryBlobPartition from a VolumeDisc.
2021-10-24 00:09:00 +02:00
b1802f6daa
DiscIO/DirectoryBlob: Add a content source representing a run of padding bytes.
2021-10-23 23:51:23 +02:00
f8611f7139
DiscIO/DirectoryBlob: Add a content source that reads data from a DiscIO::Volume.
2021-10-23 16:51:45 +02:00
b7a9cc37b1
DiscIO/DirectoryBlob: Add ability to have an offset for a partition ContentSource.
2021-10-23 16:51:45 +02:00
a14436fe3f
DiscIO/DirectoryBlob: Add ability to have a start-of-file offset for a file ContentSource.
2021-10-23 16:51:45 +02:00
885e6690c5
DiscIO/DirectoryBlob: Add explanations for DiscContent members.
2021-10-23 16:51:44 +02:00
b988ab4441
DiscIO/DirectoryBlob: Consolidate functions that take data for ContentSource to just take a ContentSource.
2021-10-23 16:51:44 +02:00
7f57c24172
DiscIO/DirectoryBlob: Rename the vector-reference variant of DiscContentContainer::Add() to AddReference() to make it clearer at call sites that the given vector must remain in memory.
2021-10-23 16:51:44 +02:00
b997048cfe
Merge pull request #10142 from aldelaro5/gdb-stub-rework
...
Rework the entire logic of the GDB stub
2021-10-24 01:51:29 +13:00
f972ddf32f
Common/FileUtil: Fix incorrect (32-bit) stat struct being used on Windows, which was hidden by a define in CommonFuncs.h.
2021-10-23 03:50:47 +02:00
6a4d607e09
GDBStub: Add log when break is sent
2021-10-21 08:26:50 -04:00
7ad586fe2c
GDBStub: Make step force pausing even if play was pressed
2021-10-21 08:26:50 -04:00
2f7a3e59e5
GDBStub: upgrade some logs from debug to info
2021-10-21 08:26:50 -04:00
1b92f81379
GDBStub: Refactor the whole code
2021-10-21 08:26:50 -04:00
94a0f416eb
GDBStub: remove the cmake option and the ifdefs
2021-10-21 08:26:42 -04:00
657bb00c01
GDBStub: Cleanly shut down on stop
2021-10-21 08:26:42 -04:00
b8395280d3
GDBStub: Correctly inform the CPU thread if we are stepping
2021-10-21 08:26:28 -04:00
b9b7c4ac80
GDBStub: Add support for the T command
2021-10-21 08:26:28 -04:00
7d3ea4c3a1
GDBStub: rework the breakpoint and the control logic
2021-10-21 08:26:28 -04:00
994847f09c
GDBStub: move the stalling logic to CPU::Run
2021-10-21 08:26:16 -04:00
e3b978cf20
GDBStub: boot to pause
2021-10-21 08:26:16 -04:00
e03ddc2116
Let the GDB stub listen for commands while running
...
This is needed to send ctrl+C signals while the CPU thread is running.
2021-10-21 08:26:16 -04:00
1e4b2daedb
GameList: Fix duplicate selections with ctrl+a in grid view
...
Make grid view use selectedRow() instead of selectedIndexes() to ensure
one selection per game.
2021-10-19 14:50:58 -07:00
f0faf3712d
Merge pull request #10171 from malleoz/fix-frame-advance-speed
...
Fix swapped frame advance speed increase/decrease
2021-10-16 11:36:07 +02:00
8195d0bda1
Merge pull request #10144 from malleoz/dsp-onion
...
Port Main.DSP to MainSettings
2021-10-16 11:32:38 +02:00
8ea6bef98f
Port Main.DSP to MainSettings
...
While trying to work on adding audiodump support for CLI, I was alerted that it was important to first try moving the DSP configs to the new config before continuing, as that makes it substantially easier to write clean code to add such a feature.
This commit aims to allow for Dolphin to only rely on the new config for DSP-related settings.
2021-10-15 23:24:46 -04:00
ea81346fc3
Fix swapped frame advance speed increase/decrease
...
Frame Advance Speed hotkeys were swapped. This likely occurred because speed and delay are inverses (i.e. a speed increase should DECREASE the delay and vice versa).
2021-10-15 23:22:22 -04:00
9a6f0bd9b2
Merge pull request #10168 from JosJuice/jitarm64-gcc-float-null
...
JitArm64: Work around a GCC warning promoted to error
2021-10-15 23:03:57 +02:00
fd7df2ccae
Use fmt::localtime instead of thread-unsafe std::localtime
...
fmt::localtime is also less awkward to use compared to std::localtime.
2021-10-15 22:49:13 +02:00
7855e5f73b
Turn MAX_LOGLEVEL into a true constant (and fix self-comparison warning)
...
This replaces the MAX_LOGLEVEL define with a constexpr variable
in order to fix self-comparison warnings in the logging macros
when compiling with Clang. (Without this change, the log level check
in the logging macros is expanded into something like this:
`if (LINFO <= LINFO)`, which triggers a tautological compare warning.)
2021-10-15 21:51:01 +02:00
7c88ca7c4e
JitArm64: Work around a GCC warning promoted to error
...
GCC complains about float_emit being null when inlining
ByteswapAfterLoad into MMIOLoadToReg. ByteswapAfterLoad
does dereference float_emit, but only when passing FLAG_FLOAT,
which MMIOLoadToReg has an assert for and does not support.
Also cleaning up some unnecessarily specified namespaces while
I'm at it.
2021-10-15 21:32:46 +02:00
6bf10e0276
Merge pull request #10149 from malleoz/audiodump-add-timecode
...
Add Game ID, timecode to dspdump and dtkdump filenames
2021-10-15 19:42:30 +02:00
7d6393332d
Merge pull request #10164 from Pokechu22/per-pixel-lighting-vertex-color
...
VideoCommon: Fix color channel logic when per-pixel lighting is in use
2021-10-14 14:17:06 -04:00
f16e9045a2
Silence the -Wswitch warnings in Tev
...
The compiler was loudly announcing each and every branch Tev was not checking in
a switch statement, but Tev has learned it's lesson and will produce that
warning no more.
2021-10-13 23:54:06 -07:00
a372a5947b
VideoCommon: Fix color channel logic when per-pixel lighting is in use
...
This was broken in #10012 (specifically by 06579e4d53c3dec34391
2021-10-13 20:43:32 -07:00
2d1674cd56
JitArm64: Keep track of free code regions and reuse space when possible
...
JitArm64 port of 306a5e6
2021-10-13 21:52:16 +02:00
44beaeaff5
Arm64Emitter: Check end of allocated space when emitting code
...
JitArm64 port of 5b52b3e
2021-10-13 21:52:16 +02:00
867cd99de1
JitArm64: Remove the ability to reuse backpatch slowmem handlers
...
Reusing the slowmem handlers of existing blocks meshes badly
with reusing the empty space left when destroying blocks.
I don't think reusing slowmem handlers was much of a gain anyway.
2021-10-13 21:51:45 +02:00
JosJuice