Commit Graph

436 Commits

Author SHA1 Message Date
adelikat d4c8615e95 remove unused usings and other redundancies 2020-04-23 20:33:18 -05:00
adelikat 2b281116ed misc cleanups 2020-04-08 16:03:35 -05:00
adelikat 22f6df3a70 NesHawk - CartInfo - turn into properties 2020-03-19 21:20:53 -05:00
adelikat daab35fc39 NesHawk- move CartInfo into its own file 2020-03-19 21:15:07 -05:00
adelikat dc56dd87e8 simplify MapperPropAttribute 2020-03-19 21:12:23 -05:00
adelikat 291275fe8c NesHawk - move MapperPropAttribute to its own file 2020-03-19 21:11:01 -05:00
adelikat f8acb61136 NesHawk - make boards and related classes internal, and sealed where possible 2020-03-19 21:06:54 -05:00
adelikat 620c38af73 NesHawk - move some enums out of NesBoardBase, simplifies a lot of usages 2020-03-19 20:29:15 -05:00
adelikat 720a2dce02 NesHawk - move NesBoardImpl attributes to their own file 2020-03-19 20:21:29 -05:00
adelikat 0d4dd3855b NesHawk - more missing variables in savestates 2020-03-19 20:02:22 -05:00
adelikat 659831c534 fix missing savestate data in some NESHawk mappers, note this is a breaking savestate change for these boards, but they were broken anyway, these were critical fields to savestate 2020-03-19 19:51:59 -05:00
adelikat 8bcab5af79 NESHawk - break off INesBoard and NesBoardBase into separate files 2020-03-19 19:06:03 -05:00
adelikat d60a00d682 NES mappers - remove documentation comments in favor of the nesdev wiki link 2020-03-19 08:24:05 -05:00
adelikat d953318160
Remove cbuffer (#1883)
* delete unused ShortBuffer

* convert IntBuffer to int[] in the Atari2600 core

* remove IntBuffer from NES mappers, and delete class

* convert ByteBuffer to byte[] in atari 2600 mappers

* remove ByteBuffer usages in NESHawk, remove ByteBuffer class

* remove Buffer.cs

* remove IDisposable from NES.NESBoardBase

* remove Dispose from Atari2600 MapperBase, note, it wasn't event being called
2020-03-18 08:55:02 -05:00
adelikat 46d05de51f nothing to see here 2020-02-28 12:52:48 -06:00
adelikat cdcc1eabde use inline out variables in Emulation.Cores 2020-02-18 15:10:29 -06:00
adelikat 606c3bf1c2
use more advanced language features in Emulation.Cores (#1852)
* Use expression bodies in Emulation.Cores, and a few other misc cleanups

* remove unused usings in Emulation.Common

* cleanups in Tables_Direct.cs

* some cleanups in nes boards - redundant code

* remove some redundant array initializers in Emulation.Cores

* cleanup AmstradCPC.Controllers

* use object initializers in a lot of places

* nes mappers - remove disch's notes comments in favor of the nesdev wiki link

* cleanup CdtConverter.cs, mostly use of object initializers

* remove redundant .ToString() calls in Emulation.Cores

* using var in Emulation.Cores

* AmstradCPC/ZXSpectrum - simplify some linq, tabs instead of spaces, a few other misc cleanups

* Use null-propagation in Emulation.Cores
2020-02-17 16:54:51 -06:00
YoshiRulz 24e6cc14f0
Enable SA1206 and fix noncompliance
"Declaration keywords should follow order"
2020-01-25 19:37:28 +10:00
YoshiRulz b1e02fbdce
Enable SA1106 and fix noncompliance
"Code should not contain empty statements"
i.e. don't put a semicolon there
2020-01-25 18:06:34 +10:00
YoshiRulz 6f3f01125c
Enable SA1504 and fix noncompliance
"All accessors should be single-line or multi-line"
i.e. no block form on one line
2020-01-25 14:56:56 +10:00
YoshiRulz a8170ca183
Fix mismatching namespaces 2020-01-13 07:19:06 +10:00
alyosha-tas f544c044bf NES MMC3: Mapper test indicates IRQ was happening one ppu tick too late. 2019-07-08 08:16:43 -04:00
YoshiRulz 4dd40305bc
Merge branch 'master' into interp_cores 2019-06-15 02:11:24 +10:00
YoshiRulz 2642ef4049
Remove empty docs 2019-06-06 16:41:10 +10:00
YoshiRulz 9af93be0d3
Use string interpolation 2019-04-04 02:41:18 +10:00
James Groom 4e91f88af3
Use nameof in cores 2019-03-28 14:18:58 +11:00
alyosha-tas 6d0973ca7e
Merge pull request #1429 from YoshiRulz/master
Inconsequential changes (no whitespace)

looks good to me
2019-03-09 17:32:10 -06:00
alyosha-tas 1981877487 NESHawk: Remove GOTOs 2019-01-27 17:18:16 -06:00
alyosha-tas 9696a75839
Merge pull request #1439 from TASVideos/subneshawkfixattempt
SubNESHawk
2019-01-19 09:48:43 -06:00
Brad Smith 65ce3abaa9 NES Mapper034.cs is missing SyncState (#1451)
* NES Mapper034.cs is missing SyncState
2019-01-17 16:42:27 -05:00
alyosha-tas c19c7cd5c3 SubNESHawk
also Input register shift fix

# Conflicts:
#	BizHawk.Client.EmuHawk/MainForm.Designer.cs
#	BizHawk.Client.EmuHawk/MainForm.Events.cs
#	BizHawk.Emulation.Cores/Computers/AmstradCPC/AmstradCPC.IEmulator.cs
#	BizHawk.Emulation.Cores/Computers/SinclairSpectrum/ZXSpectrum.IEmulator.cs
#	BizHawk.Emulation.Cores/Consoles/Nintendo/NES/PPU.run.cs
2019-01-10 18:25:59 +03:00
YoshiRulz c0a28a320b
Inconsequential changes (no whitespace)
Remove useless semicolon, remove useless `? true : false`, move period to next
line
2019-01-07 22:02:02 +10:00
adelikat a8e85f742c SxROM - some small cleanup/simplification 2018-11-01 10:27:51 -05:00
alyosha-tas 57c6149274 NESHawk: Fix VRC IRQ timing 2018-07-07 09:02:56 -04:00
alyosha-tas 71499e5310 NESHawk: Mapper 219 savestates 2018-04-13 18:09:36 -04:00
alyosha-tas f2529fa0e0 NESHawk: Fix mapper 219 2018-04-09 12:48:47 -04:00
alyosha-tas 8a48073a9b NESHawk: Mapper 63 2017-12-02 18:39:52 -05:00
alyosha-tas 5ba647a632 NESHawk: Implement mapper 43 and UNIF_UNL-SMB2J 2017-12-02 12:22:48 -05:00
alyosha-tas 5e481a6083 NESHawk: Fix some unlicensed games 2017-12-02 10:03:27 -05:00
alyosha-tas ad66699b23
Update Mapper116.cs
Fixes Kart Fighter
Not sure why I added that condition in the first place, it doesn't break Somari.
2017-10-31 11:41:50 -04:00
alyosha-tas ec848f2c43
NESHawk: Update Mapper 114 2017-10-31 10:36:00 -04:00
alyosha-tas 12d002fcf1 NESHawk: Add mapper 114
Aladdin Super Game
2017-10-26 21:11:21 -04:00
alyosha-tas 961723ef32 NESHawk Fix ACtion 52 2017-09-27 22:17:38 -04:00
alyosha-tas 171022529d NES: Fix mapper 36
fixes #953
2017-08-06 10:12:04 -04:00
alyosha-tas ad85143c8c NESHawk: Rambo-1 IRQ work
-maintains compatibility with skull and crossbones and klax.
-Fixes hard Drivin'
-More work to do here
2017-08-02 21:58:54 -04:00
alyosha-tas fac8761194 Delete Mapper035.cs
-duplicate of mapper 90
2017-08-01 12:07:18 -04:00
alyosha-tas b8f502f670 NES Mappers: Make mapper 90 cover mapper 35
Mapper 35 is identical in function, fixes Warioland 2 (unl)
2017-08-01 12:06:33 -04:00
alyosha-tas ab818f1b93 Update BxROM 2017-06-09 20:43:02 -04:00
alyosha-tas 31192e15cb Update BxROM 2017-06-07 21:35:18 -04:00
alyosha-tas 27fd41a5d2 Fix mapper 112 2017-06-06 07:53:33 -04:00