10bceeb0dc
Nope, I think it's a good idea now.
...
Revert "This reverts commit c878c85daeaaf0cae3e28f24bc1a8b511293d7b6."
This reverts commit 1d1f2a18c6
2020-04-23 21:20:59 -04:00
1d1f2a18c6
This reverts commit c878c85dae.
2020-04-23 21:06:12 -04:00
c878c85dae
for your consideration: sync settings return flags instead of a bool, so we can have more granularity in what needs resetting than just "reboot core". for instance, we would like to minimize the number of times the window layout is redone by not doing it when the screen settings havent changed. HOWEVER, while I was writing this commit message, I realized, I should probably do it just by being more cautious in kicking off the layout (unless the data coming from the core has changed, a layout shouldnt happen). So I am going to make this commit, in case it inspires anyone, and then revert it.
2020-04-23 21:05:56 -04:00
325551ecd0
consistently check if callbacks exist before calling memory callbacks, across all cores
2020-04-21 16:42:57 -05:00
b736d48911
use constants for core string names and simplify core core name getting logic
2020-04-18 09:55:57 -05:00
faf4b02c26
Undo Previous PR on Gambatte Colors and Implement an Option ( #1918 )
...
* Revert "New GBC LCD correction for Gambatte palette from documented shader research https://forums.libretro.com/t/real-gba-and-ds-phat-colors/1540 "
This reverts commit 88cda24876
2020-04-08 20:41:50 -04:00
0bfe178650
New GBC LCD correction for Gambatte palette from documented shader research https://forums.libretro.com/t/real-gba-and-ds-phat-colors/1540 ( #1917 )
2020-04-08 19:19:18 -04:00
7e00b7892f
gameboy memory domains: make consistent between gambatte and GBhawk
2020-03-20 20:04:58 -04:00
20b99d4ae2
fix typo in GambatteLink file
2020-03-15 18:24:42 -05:00
d3f37a5beb
remove CoreComm.Clone(), it is now safe to pass around into subcores
2020-03-15 10:12:20 -05:00
028bc83c88
refactor CoreComm usage in some Gameboy cores
2020-03-15 09:28:27 -05:00
da95c1f56f
remove RomAnnotation fields on CoreComm and use the service instead
2020-03-14 22:10:57 -05:00
a884282fa4
remove CoreComm NominalX/Y, those values never different from buffer w/h for cores that set them which were only the gb/gba platforms and the original dualGb. The result defaulted to a very random 640x480. Instead just use the buffer w/h, which is a very reasonable video default
2020-03-14 17:06:42 -05:00
870d7df6f2
cleanup some unneeded code
2020-03-14 16:09:25 -05:00
211883889b
simplify CoreCom copying by implementing a Clone method, simplifies all the cores that have cores in them, this copies a lot more things than the original code had but it seems that's either fine or fixing broken stuff
2020-03-14 15:08:24 -05:00
5196b97459
Fix resources for BizHawk.Emulation.Cores and cleanup
2020-03-07 07:45:19 +10:00
cdcc1eabde
use inline out variables in Emulation.Cores
2020-02-18 15:10:29 -06:00
3afcf416e8
Follow attribute class best practices, cleanup docs on attributes
2020-02-19 03:54:50 +10:00
606c3bf1c2
use more advanced language features in Emulation.Cores ( #1852 )
...
* Use expression bodies in Emulation.Cores, and a few other misc cleanups
* remove unused usings in Emulation.Common
* cleanups in Tables_Direct.cs
* some cleanups in nes boards - redundant code
* remove some redundant array initializers in Emulation.Cores
* cleanup AmstradCPC.Controllers
* use object initializers in a lot of places
* nes mappers - remove disch's notes comments in favor of the nesdev wiki link
* cleanup CdtConverter.cs, mostly use of object initializers
* remove redundant .ToString() calls in Emulation.Cores
* using var in Emulation.Cores
* AmstradCPC/ZXSpectrum - simplify some linq, tabs instead of spaces, a few other misc cleanups
* Use null-propagation in Emulation.Cores
2020-02-17 16:54:51 -06:00
027dc01c8b
create StateSerializer as a base implementation of IStatable ( #1850 )
...
* create StateSerializer, an ITextStatable implementation using the Serializer class, and wire it up to the TI83 core
* wire StateSerializer to A2600 core
* wire up StateSerializer to AmstradCPC, C64, and ZXS
* wire up StateSerializer to MSX, A27800, and Coleco
* wire up state serializer to ChannelF, Vectrex, Intellivision
* fix GambatteLink to implement ITextStatable, implement TextSerializer in O2
* StateSerializer - wire up a loadstate callback and implement StateSerializer for NesHawk, a bit of rework to subNesHawk as a result
* fix subneshawk text savestates
* StateSerializer - implement byte[] buffer storing (optionally), wire up to PCE
* implement StateSerializer to SMS, tweak GGLink accordingly
* implement StateSerializer in GBHawk, fix link cores accordingly
* StateSerializer - use Serializer static methods to create serializers
2020-02-16 12:05:57 -06:00
4b7a7dd293
Make Binary states default and Textstates opt-in for cores ( #1848 )
...
* Rewind & State config - remove the default option
* remove the savestate type of default, not that this is a breaking config change for anyone that had specifically set savestates to text
* remove BinaryStatesPreferred from IStatable and use config setting when starting movies from "Now" in record movie dialog
* remove BinaryStatesPreferred from cores
* make text savestates an extension method off of IStatable and an inteface ITextStatable it uses if the core implements it. This will allow cores to opt in to text states if desired
* make cores with actual text savestate impleemntations get ITextStatable, remove text state logic from cores that just have a binary as as text implementation
2020-02-15 10:22:26 -06:00
24e6cc14f0
Enable SA1206 and fix noncompliance
...
"Declaration keywords should follow order"
2020-01-25 19:37:28 +10:00
b1e02fbdce
Enable SA1106 and fix noncompliance
...
"Code should not contain empty statements"
i.e. don't put a semicolon there
2020-01-25 18:06:34 +10:00
6f3f01125c
Enable SA1504 and fix noncompliance
...
"All accessors should be single-line or multi-line"
i.e. no block form on one line
2020-01-25 14:56:56 +10:00
c7801b8ce2
Move BizHawk.Common.BizInvoke namespace to separate project
2020-01-23 14:54:23 +10:00
a8170ca183
Fix mismatching namespaces
2020-01-13 07:19:06 +10:00
90b0574bc3
Remove unnecessary calls to ToList (e.g. in foreach)
...
squashed PR #1591
2019-10-13 15:50:57 +00:00
fca98ffe34
Various code cleanup
2019-07-21 09:05:07 -04:00
067477ce18
Merge branch 'master' into clean_docs
2019-06-14 13:28:39 +00:00
2c6ecb68bd
Merge branch 'master' into brian/mem_callback_addr_value
2019-06-06 02:11:04 -07:00
d41bd867b8
flags
2019-06-06 02:04:47 -07:00
2642ef4049
Remove empty docs
2019-06-06 16:41:10 +10:00
a93916e24c
Gambatte core: Add RTC divisor offset support.
2019-06-02 13:24:54 +02:00
7d33d604ae
cycle-based RTC
2019-05-28 22:56:39 +02:00
7e851b19f3
Gambatte core: unify DMG and CGB bios handling
2019-05-26 20:11:50 +02:00
4e91f88af3
Use nameof in cores
2019-03-28 14:18:58 +11:00
cb517aaded
Game Linking: resolve #321
2019-02-10 16:22:29 -06:00
a8f293eec8
Call mem callbacks with addr, value
2019-01-24 03:23:21 -08:00
9fdeb9f5eb
SubNESHawk: fix gambatte frameadvancepost, allow ppuviewer and nametableviewer
2019-01-12 08:12:21 -06:00
c19c7cd5c3
SubNESHawk
...
also Input register shift fix
# Conflicts:
# BizHawk.Client.EmuHawk/MainForm.Designer.cs
# BizHawk.Client.EmuHawk/MainForm.Events.cs
# BizHawk.Emulation.Cores/Computers/AmstradCPC/AmstradCPC.IEmulator.cs
# BizHawk.Emulation.Cores/Computers/SinclairSpectrum/ZXSpectrum.IEmulator.cs
# BizHawk.Emulation.Cores/Consoles/Nintendo/NES/PPU.run.cs
2019-01-10 18:25:59 +03:00
b480476932
Gambatte: Make initial colors grey scale
...
Also make equal length frames false by default, fixes #1176
2018-05-26 11:54:01 -04:00
e8145af463
i hope this breaks something
2018-05-12 12:55:42 -04:00
f968cbdd73
Gambatte: implement TotalExecutedCycles
2018-04-02 18:19:10 -04:00
bd23975201
Hackadoodle to change the initial value of the DIV register? This is probably a bad idea
2018-02-20 18:30:27 -05:00
2cc092270d
Gambatte: Palette selection for GB mode
2018-02-02 18:42:09 -05:00
296b88f155
GB minor clean ups
2018-01-16 20:00:42 -05:00
e5ded9b139
Gambatte: Merge improvements from gifvex(mcmaeve)
...
Restores Bios support and loading GB games into GBC
Accuracy imrpovements
2018-01-15 07:45:15 -05:00
34a17570d6
Gambatte: Properly dispose of GPUViewer memory pointers
...
-Still doesn't point to correct memory but at least doesn't crash
2017-11-26 09:25:16 -05:00
63ef676251
GameBoy:
...
-Remove BIOS support from Gambatte
-Fix GBHawk audio desync
-Fix controllers
2017-11-20 12:14:13 -05:00
b0095927b6
Make Gambatte use new disassembler
2017-11-19 10:36:38 -05:00
zeromus