ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remove CoreComm NominalX/Y, those values never different from buffer w/h for cores that set them which were only the gb/gba platforms and the original dualGb. The result defaulted to a very random 640x480. Instead just use the buffer w/h, which is a very reasonable video default

This commit is contained in:
adelikat 2020-03-14 17:06:42 -05:00
parent dd062b3ca7
commit a884282fa4
6 changed files with 9 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
BizHawk.Client.EmuHawk/AVOut/VideoWriterChooserForm.cs
View File

@ -12,14 +12,20 @@ namespace BizHawk.Client.EmuHawk
/// </summary>
public partial class VideoWriterChooserForm : Form
{
private readonly int _captureWidth, _captureHeight;
private readonly int _captureWidth = 640;
private readonly int _captureHeight = 480;
private VideoWriterChooserForm(MainForm mainForm, IEmulator emulator, Config config)
{
InitializeComponent();
_captureWidth = emulator.CoreComm.NominalWidth;
_captureHeight = emulator.CoreComm.NominalHeight;
// TODO: do we want to use virtual w/h?
if (emulator.HasVideoProvider())
{
var videoProvider = emulator.AsVideoProvider();
_captureWidth = videoProvider.BufferWidth;
_captureHeight = videoProvider.BufferHeight;
}
if (config.AviCaptureOsd)
{

4
BizHawk.Emulation.Common/CoreComms.cs
View File

@ -25,10 +25,6 @@ namespace BizHawk.Emulation.Common
public string RomStatusAnnotation { get; set; }
public string RomStatusDetails { get; set; }
// size hint to a/v out resizer. this probably belongs in VideoProvider? but it's somewhat different than VirtualWidth...
public int NominalWidth { get; set; } = 640;
public int NominalHeight { get; set; } = 480;
/// <summary>
/// Gets a message to show. reasonably annoying (dialog box), shouldn't be used most of the time
/// </summary>

2
BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/MGBAHawk.cs
View File

@ -53,8 +53,6 @@ namespace BizHawk.Emulation.Cores.Nintendo.GBA
ServiceProvider = ser;
CoreComm = comm;
CoreComm.NominalWidth = 240;
CoreComm.NominalHeight = 160;
PutSettings(_settings);
_tracer = new TraceBuffer

3
BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/VBANext.cs
View File

@ -69,9 +69,6 @@ namespace BizHawk.Emulation.Cores.Nintendo.GBA
};
ser.Register<ITraceable>(Tracer);
CoreComm.NominalWidth = 240;
CoreComm.NominalHeight = 160;
GameCode = Encoding.ASCII.GetString(file, 0xac, 4);
Console.WriteLine("Game code \"{0}\"", GameCode);

3
BizHawk.Emulation.Cores/Consoles/Nintendo/Gameboy/Gambatte.cs
View File

@ -36,9 +36,6 @@ namespace BizHawk.Emulation.Cores.Nintendo.Gameboy
InitMemoryCallbacks();
CoreComm = comm;
comm.NominalWidth = 160;
comm.NominalHeight = 144;
ThrowExceptionForBadRom(file);
BoardName = MapperName(file);

2
BizHawk.Emulation.Cores/Consoles/Nintendo/Gameboy/GambatteLink.cs
View File

@ -31,8 +31,6 @@ namespace BizHawk.Emulation.Cores.Nintendo.Gameboy
R.ConnectMemoryCallbackSystem(_memorycallbacks);
comm.RomStatusDetails = "LEFT:\r\n" + L.CoreComm.RomStatusDetails + "RIGHT:\r\n" + R.CoreComm.RomStatusDetails;
comm.NominalWidth = L.CoreComm.NominalWidth + R.CoreComm.NominalWidth;
comm.NominalHeight = L.CoreComm.NominalHeight;
LinkConnected = true;