Addresses feedback to use consistent naming conventions as most variables are using snake_case. Also no longer passes string_view by reference as per feedback.
Bundled patches don't display when unlabeled patches are loaded (since we can't guarantee they don't collide). This warns the user that bundled patches are hidden when unlabeled patches are loaded. (The warning hides when no unlabeled patches are loaded)
The Cheats Settings menu was failing to reload cheats when pressing the button. This meant if you enabled a cheat, made changes, and clicked reload, there would be no updates in behavior.
This was due to the reload button getting wired to the function that refreshes the list of cheats, rather than the function that refreshes the list AND reloads the actual enabled cheats.
This now calls the right function and when reloading, any changes thart were saved to the cheat will now be present.
Also improves behaviour parity between Qt and Fullscreen UI,
since the latter used to prompt for system reset even if the game had
no RetroAchievements entry.
* Pad: Get rid of redundant object lookup
* Pad: Serialize 'stage' state
[SAVEVERSION+]
* Pad: Reduce Freeze duplication and add markers
Catch any possible unhandled device type change.
[SAVEVERSION+]
* Pad: Localize controller type names
* Pad: Handle mismatch between state and current config
* Misc: Drop .at() from vector/array access
We don't use exceptions.
* Pad: Remove redundant GetUnifiedSlot()
Sio has routines for converting these.
* Sio2: Remove redundant optional in Pad()
* Pad: Constify and finalize controller classes
* Pad: Move PadManager to Pad namespace
No point having a class when there's only a single instance.
* Pad: Move PadConfig to Pad namespace
* Pad: Move PadMacros to Pad namespace
* Pad: Re-localize controller bindings/settings
* Pad: Make controller info local
Don't want to create duplicates.
* Pad: Use span for ControllerInfo settings/bindings
* Pad: Fix auto-toggled macro buttons
* Pad: Fix pressure for macros
* Pad: Merge PadConfig/PadManager/PadMacros
Faster compile time.
* Pad: Fix incorrect condition in Sio0::SetTxData()
* Pad: Add deadzone for macro triggers
Force pushed because git hates me
[SAVEVERSION+] Bump savestate version
CI: Update locations of pad/memcard sources
Discard leftover old PAD code
Fix additional merge oddities
Add translations for OSD messages
Copyright headers
Version bump
Fix a whole boatload of concurrency problems from file moves and other miscellaneous update problems
Partial redo of PS1 pad support
Fix incorrect mode due to analog behavior at startup
Mostly reimplement SIO0 memory card logic
Still needs pocketstation
Use new runtime wrapped translate function
Dead code
Fix multiple port/slot/presence issues for PS1
Save State version bump
Clean up some duplicate/unused headers
More header consistency
Remove old stray files
Fix incorrect return
Fix uninitialized array
Add missing overrides
Switch to init/close model used by other subsystems
Remove old input recording references
Rename SIO globals
Rename SIO2 FIFO globals
Remove commented SIO0 code for illegal write
Add guitar icon
Polish were neglected, that ends now. Flag will be used when it sees a Polish entry in the gamelist.
Fixes https://github.com/PCSX2/pcsx2/issues/9137
Bumps the gamelist cache version from 32 to 33
Adds to enumeration
And make it visible in both gamelist and per-game summary view
Update GameList.cpp
[SAVEVERSION+] VM struct changes.
- Serial/title is now linked to disc, instead of running ELF.
- Save states can be created during BIOS boot.
- Patches now apply based on the executing CRC, and only after the
entry point starts executing (fixes multi-game discs).
- Add "Fast Forward Boot" option.
- Split achievements download and activation, downloads occur on
initialization, but are not activated until after the ELF loads.
- Prevent HostFS access while in PS1 mode.
- Remove multiple sources of truth for ELF/CRC/etc.
- Move ELF state from global scope to VMManager.
- Prevent game fixes and hw fixes being active while booting game.
- Simplify game update.
- Flush recompilers after ELF loads. No point keeping boot code around
which gets overwritten.
Move files from Frontend directory to pcsx2 and/or subdirectories.
Get rid of double GS init.
Combine HostSettings and Host.
Combine Frontend/Achievements.h and Achievements.h.
GS/DX11: Don't throw bad_alloc on surface creation fail
GS: Link device and host display construction/destruction
FullscreenUI: Replace HostDisplayTexture with GSTexture
GS: Purge HostDisplayTexture
GS: Move everything in HostDisplay to GSDevice
GS: Move ImGui rendering to GSDevice
GS: Get rid of reset/store API state
- Adding the actual corrections from #8048 that were not added by #8119.
- Fixing typos and missing ending periods.
- Unifying the writing of certain terms:
- Memory Card uppercased following Sony's writing (taken from PS2 manual).
- gamefixes/game fixes -> game fixes
- fast forward/fastforward/fast-forward -> fast-forward (taken from Oxford)
- slowmotion/slow motion/slow-motion -> slow-motion (following the same convention as before, as I could not find this in Oxford's)
- framebuffer/frame buffer -> framebuffer
- Xbox name properly uppercased (for Controller settings)
- Correcting RA's Rich Presence to separate it from Discord's Rich Presence (after discussions in the Translations channel).
- Unification of option names in the option area and the hint area.
- Adding a fix for the (currently broken) Stretch Height/Vertical Stretch tooltip.
Eventually hopefully we can make this the default, but it breaks too
much at the moment.
Fixes missing/corrupted textures in True Crime: New York City.
Unfortunately it's too risky to enable by default all the time. So,
we'll make it a hw fix, and hopefully one day can make it default on.
Also makes save states readback the TC as well.
Playable rating was missing which is the most common rating for PCSX2. There are some other issues like the images look bad for star rating and some other stuff. Also resize the compatibility table width a bit.
Per-game settings store the global setting as placeholderText.
If no per-game setting is present we can prefill the dialog with the global setting, before falling back to a default value