Commit Graph

7313 Commits

Author SHA1 Message Date
Gregory Hainaut 345a538c84 pcsx2: Clarify calculation precedence for '>>' and '?'
(cppcheck)
2015-11-06 23:01:58 +01:00
Gregory Hainaut 3e4c3353ce gsdx-ogl: missing break 2015-11-06 23:01:58 +01:00
Gregory Hainaut 9f1649ae57 gsdx: use a type in sizeof
(warning) Suspicious usage of 'sizeof' with a numeric constant as parameter.
2015-11-06 23:01:58 +01:00
Gregory Hainaut e4e68a6179 debug: 'ostr' is used as parameter and destination in s[n]printf(). 2015-11-06 23:01:58 +01:00
Gregory Hainaut 7c6d2361af gsdx: use scalar delete
(error) Mismatching allocation and deallocation: data
2015-11-06 23:01:58 +01:00
Gregory Hainaut f3394b16b8 gsdx: use standard quote character
Nicer with tool that support ANSII text (cppcheck)
2015-11-06 23:01:58 +01:00
Gregory Hainaut 1aa6749956 cdvd: remove break after return
cppcheck:[pcsx2/CDVD/CDVD.cpp:1120]: (style) Consecutive return, break, continue, goto or throw statements are unnecessary.
2015-11-06 23:01:58 +01:00
Gregory Hainaut d4e088b726 build: add clang-tidy support
Slow and generate a 100k log!

Better to fix cppcheck/coverity/gcc(/clang) report first.

Anyway, clang-tidy incorporates clang-modernize (port code
to use some C++11 features)
2015-11-06 23:01:58 +01:00
Jonathan Li 4ab092d011 Merge pull request #911 from ssakash/gsdx_debug
Gsdx: Add Mipmap (Software mode) and preload data frame to GUI.
2015-11-06 13:01:49 +00:00
Akash 754a7eb7de GSDX: Update toggle key messages 2015-11-06 01:47:53 +05:30
Akash d866b5592e GSDX: Add two new options to GUI.
The following patch adds Mipmap option (software mode exclusive) and Preload Data Frame (Hardware mode exclusive) to the GSDX plugin settings for debug purposes.
2015-11-06 01:47:44 +05:30
Jonathan Li 372db4b539 Merge pull request #946 from turtleli/linux-console
gui:linux: Redirect stdout/stderr to the PCSX2 console
2015-11-05 18:15:50 +00:00
Jonathan Li 5f5556ee69 gui:linux: Show plugin stdout/stderr in pcsx2 console
Behaviour is now similar to Windows, except we can also show messages in
the terminal as well.
2015-11-05 18:12:45 +00:00
Gregory Hainaut fa487474d2 build: s/\t/ / 2015-11-05 18:24:36 +01:00
Gregory Hainaut 41081e1b40 build: add a nice cppcheck option 2015-11-05 09:49:06 +01:00
Jonathan Li 45fb0ebcdf Merge pull request #952 from PCSX2/hyperlink-copyright
spu2x: remove hyperlink in windows about box
2015-11-04 17:50:26 +00:00
Gregory Hainaut d0ea904cdf spu2x: remove hyperlink in windows about box
Code isn't free (and kinda useless)
2015-11-04 07:43:00 +01:00
Gregory Hainaut 6e7962e06a pcsx2: replace memset_sse_a by standard memset
Code is only enabled in dev build.

In the future allocation (therefore the memset) will be done at startup anyway.
2015-11-03 09:17:31 +01:00
Gregory Hainaut 8ab9cea3f7 pcsx2: comment set but unused variable 2015-11-02 07:54:24 +01:00
Gregory Hainaut 82520555b3 cmake: reduce warning level on strict-overflow
It is quite verbose
2015-11-02 07:44:11 +01:00
Gregory Hainaut 5ba41306ea gsdx-tc: HasSharedBits uses PSM not address
Nice heap overflow. I'm surprised that it kinda worked.
2015-11-02 07:36:37 +01:00
Gregory Hainaut 6a38e1d06e onepad: init sigaction struct 2015-11-02 07:36:17 +01:00
Gregory Hainaut a9af374be6 onepad: don't touch autorepeat setup
When X autorepeat is enabled, it will generate down/up, down/up, ... sequences

So it was decided to disable it. Unfortunately the configuration is for
the full system which is very annoying (state isn't restored after an
ASSERT or EXCEPTION)

Initially the plugin handles the event from the X loop. However since
the GSopen2 switch events are already intercepted by the WX core GUI.
The core will route them back to the input plugin.

Wx filters automatically generated event so initial sequence is now
down, down, down/up. No more autorepeat issue, so no need to screw up
the system.

Close #945
2015-11-01 10:48:54 +01:00
refractionpcsx2 83549e6f61 Merge pull request #940 from ssakash/dothack_fix
MicroVU: check for VF write on mvu flag hack .
2015-11-01 09:21:32 +00:00
Akash 6bf901faee MicroVU: check for VF write before flag set.
Fixes flickering issues on .Hack games, don't do a early break when Reg Index hasn't been written to a valid destination.
2015-11-01 04:38:58 +05:30
Gregory Hainaut c3d8cc0978 Merge pull request #897 from PCSX2/coverity-spu2x-mixer
spu2x: correctly apply the volume to the external source
2015-10-31 20:10:43 +01:00
Jonathan Li 08dfa20da1 utilities:linux: Add function to change stdout stream
stdout is not necessarily at stdout - at least not after I'm done with it.
2015-10-31 13:50:02 +00:00
ramapcsx2 49688e2b0d Merge pull request #944 from ssakash/coverity_EE
EE: Prevent usage of uninitialized scalar variable
2015-10-31 13:39:19 +01:00
Gregory Hainaut 36361f04c6 Merge pull request #929 from PCSX2/spu-sdl-api-config
Spu sdl api config
2015-10-31 11:39:45 +01:00
Jonathan Li e31cb8cbcd spu2x-sdl: restore WX2.8 build compilation
Signed-off-by: Gregory Hainaut <gregory.hainaut@gmail.com>
2015-10-31 11:06:15 +01:00
Akash 491efd91a5 EE: Prevent usage of uninitialized scalar variable
Fixes CID 153601 , CID 153602 , CID 153603
2015-10-31 15:26:34 +05:30
Gregory Hainaut 2f0077a081 pcsx2-ee: more cleaning of BaseBlockArray
* Remove useless erase(first)
* Move reserve in private section
* if 0 GetByX86
2015-10-30 21:59:06 +01:00
Gregory Hainaut 9c75c84e83 pcsx2-ee: Use a single constructor for BaseBlockArray
Directly reserve the array instead to rely on the reserve function.

+ add a couple of comments
2015-10-30 18:57:46 +01:00
Gregory Hainaut b215885188 pcsx2-ee: remove unused ManualPageTracking struct 2015-10-30 18:19:46 +01:00
Gregory Hainaut 66259dee17 spu2x-sdl: always use 16 bit formats
32 bits range is too big and requires to maximize the volume.
2015-10-30 17:38:12 +01:00
Gregory Hainaut 2a68c3585c spu2x-sdl: fiddle with SDL to init the selected API
Note: SDL_Init is mandatory oterwise SDL_OpenAudio will redo the init.
So the only sane way is to initialize pulseaudio, close everything, and finally
init the requested driver.

V2:
* ifdef SDL2 code

V3:
* use std::string for m_api (avoid issue issue with wx2.8)
* call the good function to properly close subsystem avoid crashes
2015-10-30 17:37:25 +01:00
Gregory Hainaut 84c6455c95 spu2x-sdl: add a gui setting to select the API
The purpose is to workaround bug with default API

Code is not ideal because SDL/gui are mixed. But it would be enough
for future release.

V2: ifdef SDL2 code
2015-10-30 17:13:45 +01:00
Gregory Hainaut fee3d7c151 pcsx2: sed /branch/g_branch/
Be nice with grep.
2015-10-29 22:35:48 +01:00
Jonathan Li 618ef8b549 pcsx2:linux: Use narrow characters for stdout
Things seem to break when you mix wide and narrow characters.

Plugins messages sent to stdout are now viewable.
2015-10-29 19:09:49 +00:00
Gregory Hainaut 96fc260488 linux: restore default INT/TERM signal handler
Allow to use CTRL-C to quit PCSX2 ("regression" of SDL2)
2015-10-29 15:04:55 +01:00
Jonathan Li 6f4ba08d4a pcsx2:windows: Fix stdout/stderr redirection
The current redirection code doesn't work on VS2015:
 - It relies on undefined behaviour (*stdout/*stderr = *fp)
 - stdin/stdout/stderr are not pre-opened when compiled with the v140*
   toolkits
 - It seems to be the reason PCSX2 fails to terminate properly.

Use a combination of named pipes and freopen to redirect stdout/stderr.

Note: The redirect stuff doesn't seem to work in debug builds, both
before and after the change.
2015-10-28 19:27:15 +00:00
Gregory Hainaut 17e3c570ba pcsx2-ee: properly set the running variable
Fix exception propagation. Behavior is now equivalent to Windows.
2015-10-28 14:25:12 +01:00
Gregory Hainaut 2194685d76 memset-linux: use std memset for memset_8
This memset is only used in the init (to clear the page that will
contains the dynarec dispatcher
2015-10-28 14:25:12 +01:00
Jonathan Li 344d6c201e pcsx2|utilities: Remove Windows wx2.8 code
It's not used anymore.
2015-10-28 00:02:11 +00:00
refractionpcsx2 dc5885790a Merge pull request #816 from ssakash/EE_Control
Speedhacks: Add Overclock function for EE cycle rate.
2015-10-27 15:01:40 +00:00
Akash 156f573842 R5900: Add Overclock function for EE cycle rate.
Pratically, use lower scalar values which eventually increases the clockspeed of the R5900.
2015-10-27 16:24:00 +05:30
Gregory Hainaut d81481a974 Merge pull request #926 from kust2708/onepad-gui-images
Onepad GUI for Linux - New wxWidget interface (Images)
2015-10-26 21:21:12 +01:00
Gregory Hainaut b7c51922e8 pcsx2: print a nice message when SYSCALL 2 is called
This syscall is used to setup the CRTC display. Maybe the information
can be useful for GS rendering.
2015-10-26 17:53:25 +01:00
kust2708 9dff864de8 onepad:
Add images for the new GUI

Onepad : wxWidget GUI
Replace headers by png files.

OnePad: wxWidget HUI (Images)
Fix l2.png file (white background instead to a transparent one).
2015-10-26 14:28:32 +01:00
Gregory Hainaut 59be6c8710 gsdx: protect some options to avoid buffer overflow
Keep TVShader/interlace/aspectratio in the legal range.

Avoid a crash if the user (aka me) edit the ini file with bad value.
2015-10-25 21:44:20 +01:00