Filoppi
574477866f
InputCommon: fix serialization of control expression with line breaks
...
The control expression editor allows line breaks, but the serialization was
losing anything after the first line break (/r /n).
Instead of opting to encode them and decode them on serialization
(which I tried but was not safe, as it would lose /n written in the string by users),
I opted to replace them with a space.
2021-05-12 18:25:56 +03:00
JMC47
eb5cd9be78
Merge pull request #9694 from iwubcode/xfb-tcache-hash
...
VideoCommon: update TextureCache logic for finding oversized XFBs
2021-05-09 15:20:53 -04:00
JMC47
a66852d37c
Merge pull request #9651 from Pokechu22/oob-texcoord
...
Fix out of bounds tex coord behavior; always apply fb_addprev and tex coord wrapping
2021-05-09 15:00:40 -04:00
iwubcode
6fd7867c56
VideoCommon: simplify TextureCacheBase by comparing a xfb's hash against a newly calculated one. This fixes games like Teenage Mutant Ninja Turtles (Wii) which use oversized textures where the stride doesn't match the BytesPerRow and that resulted in a different hash algorithm being used. By not hashing the texture before, we improve performance by hashing at most once in all direct XFB lookup scenarios.
2021-05-08 01:29:48 -05:00
Pokechu22
e1d45e9ba6
UberShaderPixel: always run indirect stage logic
...
Hardware testing has confirmed that fb_addprev and wrapping both run even when the indirect stage is disabled.
2021-05-07 16:37:47 -07:00
Pokechu22
b5844ab195
PixelShaderGen: always run indirect stage logic
...
Hardware testing has confirmed that fb_addprev and wrapping both run even when the indirect stage is disabled.
2021-05-07 16:37:47 -07:00
Pokechu22
5e3360c2cc
UberShaderPixel: Fix OOB tex coord indices
...
Previously we set the texture coordinate to zero, now we set
the texture coordinate *index* to zero. This fixes the ripple
effect of the Mario painting in Luigi's Mansion.
2021-05-07 16:37:47 -07:00
Pokechu22
ed02034967
UberShaderPixel: Return fixed-point values from selectTexCoord
...
This change should have no behavioral differences itself, but allows for changing the behavior of out of bounds tex coord indices more easily in the next commit. Without this change, returning tex0 for out of bounds cases and then applying the fixed-point logic would use the wrong tex dimension info (tex0 with I_TEXDIMS[1] or such), which is inaccurate.
2021-05-07 16:37:10 -07:00
Pokechu22
16c17ed9ce
Software: Fix OOB tex coord indices
...
Previously we set the texture coordinate to zero, now we set
the texture coordinate *index* to zero. This fixes the ripple
effect of the Mario painting in Luigi's Mansion.
2021-05-07 16:28:09 -07:00
Tillmann Karras
f6cf85a8bc
PixelShaderGen: Fix OOB tex coord indices
...
Previously we set the texture coordinate to zero, now we set
the texture coordinate *index* to zero. This fixes the ripple
effect of the Mario painting in Luigi's Mansion.
Co-authored-by: Pokechu22 <Pokechu022@gmail.com>
2021-05-07 16:28:09 -07:00
Pokechu22
002ff4e4dd
PixelShaderGen: Remove unused num_texgens argument
...
It became unused in f039149198
.
2021-05-07 16:28:08 -07:00
Pokechu22
c3668e179c
Split TevStageIndirect::mid into matrix_index and matrix_id
2021-05-07 16:27:52 -07:00
Pokechu22
1d628d087b
Add 1 when displaying the number of TEV stages
2021-05-07 16:14:19 -07:00
Pokechu22
072304404c
Correct indirect stage ref typos
...
YAGCD uses BI0/BC0/BI1/BC1/BI2/BC2/BI3/BC3, so I'm pretty sure the BI2/BC3/BI4/BC4 names are a typo that just was propagated.
2021-05-07 16:14:18 -07:00
Léo Lam
a6f6211dde
Merge pull request #9633 from Pokechu22/BitfieldExtract-pointer-to-member
...
Change BitfieldExtract to use a pointer to the bitfield member
2021-05-08 00:21:15 +02:00
Pokechu22
0f7c9ef767
Change BitfieldExtract to use a pointer to the bitfield member
2021-05-07 15:11:17 -07:00
Léo Lam
049b92b7ef
Merge pull request #9417 from Filoppi/input-1
...
Fix FPS counter and Game Window speed % breaking on pause/unpause
2021-05-07 15:08:01 +02:00
Léo Lam
8547de2593
Merge pull request #9615 from Dentomologist/updater_documentation
...
Updater: Add code documentation
2021-05-07 15:05:14 +02:00
Léo Lam
2b632f6d5d
Merge pull request #9641 from lynlevenick/ash/texture-cache-opt
...
Remove spurious memory allocations in TextureCacheBase::SerializeTexture and DeserializeTexture
2021-05-07 15:01:23 +02:00
Léo Lam
70d8a78edc
Merge pull request #9683 from JosJuice/ppc-test-values
...
UnitTests: Put PowerPC test values in a separate file
2021-05-07 14:44:27 +02:00
Léo Lam
aa8ddcfc92
Merge pull request #9684 from JosJuice/move-unit-tests
...
UnitTests: Move some unit tests to where they should be
2021-05-07 14:31:09 +02:00
Léo Lam
19580c3841
Merge pull request #9692 from JosJuice/android-not-debuggable
...
Android: Don't set android:debuggable="true"
2021-05-06 22:16:59 +02:00
JosJuice
c2917417fe
Android: Don't set android:debuggable="true"
...
In 5a1a642
, I explicitly set android:debuggable="true" for Dolphin.
(By default, it's set for debug builds but not release builds.)
The reason I made the change is because debuggable must be set to
true in order to allow adb backup to be used with apps which target
Android 12. We have no reason to want to stop users from debugging
Dolphin and certainly no reason to stop users from using adb backup
(especially not after forced storage is going to force us to store
the User folder in app-specific external storage!), but,
it turns out that setting debuggable to true is forbidden by
Google Play "for security reasons". Go figure. The beta build
which was tagged earlier today was rejected because of this.
2021-05-06 20:15:27 +02:00
JosJuice
f60d29f2b7
Translation resources sync with Transifex
2021-05-06 09:16:54 +02:00
Mat M
9286b57d84
Merge pull request #9691 from JosJuice/jitarm64-register-call
...
JitArm64: Fix JitRegister::Register call for cstd
2021-05-05 19:44:36 -04:00
JosJuice
b305e4cfc1
JitArm64: Fix JitRegister::Register call for cstd
...
Seems like I made a little copy-paste error.
2021-05-06 00:20:47 +02:00
Filoppi
818672b585
Fix FPS counter and Game Window speed % breaking on pause/unpause
...
-Add pause state to FPSCounter.
-Add ability to have more than one "OnStateChanged" callback in core.
-Add GetActualEmulationSpeed() to Core. Returns 1 by default. It's used by my input PRs.
2021-05-06 01:10:04 +03:00
JMC47
4b827f3ae9
Merge pull request #9673 from phire/z16peeks
...
Implement EFB Peeks for compressed z16 formats
2021-05-04 21:07:21 -04:00
Scott Mansell
ab55c948a1
Update zcompression format change TODO
2021-05-05 11:32:42 +12:00
Scott Mansell
a4796e512a
Implement EFB Peeks for compressed z16 formats
...
This fixes an issue in RS3 where engine lens flares would shine
though ships during cutscenes
2021-05-05 11:32:29 +12:00
JMC47
a8c40eb510
Merge pull request #9682 from JosJuice/fix-wii-netplay
...
IOS: Don't let Kernel initialize WiiRoot if already initialized
2021-05-02 17:40:52 -04:00
JosJuice
bb39f75093
UnitTests: Put PowerPC test values in a separate file
...
We use more or less the same values for all PowerPC float unit
tests. Let's put them in one place instead of duplicating them.
2021-05-02 22:12:28 +02:00
Jordan Woyak
9e92d6ddcb
Merge pull request #9685 from JMC47/InputMappingDelay
...
Remove Input Mapping Delay
2021-05-02 15:10:09 -05:00
JMC47
21113e5839
This removes a delay for input mapping.
...
It was causing more harm than good for users. Anyone doing complex
expressions is already using the advanced editor for more control over
it.
2021-05-02 15:27:11 -04:00
JosJuice
1f6bb06f2c
UnitTests: Move some unit tests to where they should be
...
Two unit tests were in the root UnitTests folder
and were not being built when using CMake.
2021-05-02 18:07:02 +02:00
Léo Lam
ade9d6c954
Merge pull request #9679 from JosJuice/disable-verify
...
DolphinQt: Disable verify button when emulation is running
2021-05-02 10:52:46 +02:00
JosJuice
3397f49a0a
IOS: Don't let Kernel initialize WiiRoot if already initialized
...
The SaveToSYSCONF call in BootManager.cpp was unintentionally
overriding the temporary NAND set by the preceding
InitializeWiiRoot call. Fixes
https://bugs.dolphin-emu.org/issues/12500 .
2021-05-02 10:30:32 +02:00
Mat M
1f26b694dc
Merge pull request #9680 from Pokechu22/more-git-blame-ignore-revs
...
Add even more commits to .git-blame-ignore-revs
2021-04-30 21:13:27 -04:00
Pokechu22
56ab9ae5f2
Add even more commits to .git-blame-ignore-revs
2021-04-30 17:29:42 -07:00
Jordan Woyak
1daefeb20a
Merge pull request #9674 from Filoppi/fix_hotkey_suppresion_crash
...
Fix hotkey suppression crash
2021-04-28 18:21:07 -05:00
JosJuice
55ef1069f1
DolphinQt: Disable verify button when emulation is running
...
Verifying a Wii game creates an instance of IOS, and Dolphin
can't handle more than one instance of IOS at the same time.
Properly supporting it is probably more effort than it's worth.
Fixes https://bugs.dolphin-emu.org/issues/12494 .
2021-04-28 21:58:07 +02:00
Léo Lam
20301592ad
Merge pull request #9677 from iwubcode/profile-drop-down
...
DolphinQt: fix input profile drop down not resizing
2021-04-27 14:01:12 +02:00
iwubcode
626c686fee
DolphinQt: update device drop down size policy so that the input profile resizes properly
...
This also keeps the device profile at a minimum so that it doesn't
completely disappear (which was originally why it was changed to expanding)
2021-04-27 12:50:45 +02:00
Léo Lam
219f66c6e9
Merge pull request #9672 from JosJuice/jit-naming-scheme
...
DolphinQt/Android: Unify the JIT naming scheme
2021-04-27 12:00:23 +02:00
JMC47
4d10023727
Merge pull request #9552 from endrift/gba-timing
...
SI/DeviceGBA: Fix SI timings to actually closely match hardware
2021-04-26 21:20:06 -04:00
JosJuice
c09427ccdf
Merge pull request #9676 from leoetlino/colon
...
DolphinQt: Get rid of an extraneous colon in About dialog
2021-04-27 00:46:09 +02:00
Léo Lam
08215cc975
DolphinQt: Get rid of an extraneous colon in About dialog
2021-04-27 00:24:24 +02:00
Léo Lam
51bf2dca21
Merge pull request #9675 from JosJuice/jit64-div-80000000
...
Jit64: Fix UB/infinite loop when compiling division by 0x80000000
2021-04-26 23:50:27 +02:00
JosJuice
7d4b87e7ae
Jit64: Fix UB/infinite loop when compiling division by 0x80000000
2021-04-26 23:42:03 +02:00
Filoppi
799a368a7c
InputCommon: small hotkey threshold symmetry fix
2021-04-26 19:45:13 +03:00