Commit Graph

14069 Commits

Author SHA1 Message Date
Stenzek 5dcd3cd4fd D3D: Fix crash when taking screenshot with crop enabled
This was due to specifying negative source coordinates for the texture copy, which must lie within the bounds of the source and destination textures.

The behavior now is to clamp the copy region to [0 <= size <= backbuffer size], resulting in a copy region that can be smaller than the backbuffer, but never larger.
2015-12-09 02:38:24 +10:00
JosJuice a27610ff17 MainAndroid: Fix size logging 2015-12-08 12:37:51 +01:00
Markus Wick 49cd777fce Merge pull request #3324 from lioncash/alloc
DiscIO: Get rid of a few explicit deletes
2015-12-08 12:03:54 +01:00
Lioncash 6295297ab3 DiscIO: Get rid of a few explicit deletes 2015-12-08 04:35:56 -05:00
Markus Wick 3e3e6073f7 Merge pull request #3316 from sepalani/fix_poll
WSAPoll: Fixed - invalid argument was supplied
2015-12-08 09:01:52 +01:00
Bartosz Kaszubowski 4655cd01fa minor General Config GUI improvements
- theme and language selectors wrapped into one GridBagSizer for better
appearance
- missing left padding added to checkbox on Advanced Pane
2015-12-08 02:13:32 +01:00
Markus Wick 9719804cd2 Merge pull request #3320 from lioncash/factory
DiscIO: Make factory methods return unique_ptrs
2015-12-07 19:12:15 +01:00
Lioncash edbbf493f8 DiscIO: Make factory methods return unique_ptrs
Rather than rely on the developer to do the right thing,
just make the default behavior safely deallocate resources.

If shared semantics are ever needed in the future, the
constructor that takes a unique_ptr for shared_ptr can
be used.
2015-12-07 05:57:37 -05:00
Lioncash e7b98e27ab EXI: Use std::array and std::unique_ptr for managing channels 2015-12-06 14:51:55 -05:00
Julian Löhr e076098a95 Fix "-TR" Wiimotes on Windows 8/8.1/10, by using WriteFile for sending
"-TR" Wiimotes don't accept output reports via the Control Channel. HidP_SetOutputReports will send the data via the Control Channel, whereas WriteFile will send it via the Interrupt Channel. Therefore using WriteFile enables "-TR" Wiimotes on Windows. There are some issues to be aware of. First the Toshiba Bluetooth Stack needs the output report buffer to have the size of the largest output report supported by the device. This requirement is also enforced by the Windows 7 default stack. However the Toshiba Stack, will only send the actual report bytes to the device, whereas on Windows 7 the full resized buffer is sent, resulting in an error on the Wiimote. This issue renders WriteFile unusable on Windows 7 with the  default stack. On Windows 8/8.1/10 this requirement is somehow not implemented and it is possible to send smaller buffers via WriteFile to the device, enabling "-TR" Wiimotes.
2015-12-06 20:17:58 +01:00
Julian Löhr 03fc048006 Add Methods to check for Toshiba Stack
Check is done by checking the driver provider property of the HID Class Driver. As the Toshiba Bluetooth Stack provides its own.
The initial enumerated device node is a empty hid interface node. Therefore first one node is moved up and then the provider property check is done.
2015-12-06 18:19:05 +01:00
Julian Löhr 2b39219367 Remove explicit Wait on Overlap Event
GetOverlappedResult also waits on the event internally (See https://msdn.microsoft.com/en-us/library/windows/desktop/ms683209(v=vs.85).aspx). So instead of explicitly waiting for it before, use its wait. To distinguish between cancel and complete, the status of the request is used, which is saved in the "Internal" member (See https://msdn.microsoft.com/en-us/library/windows/desktop/ms684342(v=vs.85).aspx).
2015-12-06 18:16:08 +01:00
degasus f511e539c2 VideoSW: Use Zero for undefined colors. 2015-12-06 12:39:18 +01:00
degasus 7b34319e53 ShaderGen: Toggle value of uninitialized color.
SMS seems to need 0, no regressions either.
2015-12-06 12:39:18 +01:00
Lioncash 7762d68c4b Rasterizer: Mark some references as const 2015-12-06 02:51:36 -05:00
Lioncash 0608ed5130 Rasterizer: Specify internal linkage on Draw
It's not exposed in the header.
2015-12-06 02:51:34 -05:00
Lioncash a0924b5e1b Rasterizer: Convert BLOCK_SIZE into a constant variable 2015-12-06 02:51:33 -05:00
Lioncash 2793785e0c Rasterizer: Get rid of a clamp macro 2015-12-06 02:51:28 -05:00
Lioncash 9b921c2e7c Rasterizer: Get rid of a trivial pointer cast 2015-12-06 02:44:06 -05:00
Lioncash 0917db7fc0 NullSound: Use std::array for the buffer 2015-12-05 18:13:55 -05:00
Lioncash 0d4baa0744 NullSound: Replace header define with private constant 2015-12-05 18:13:49 -05:00
Lioncash f6c247d10e WII_IPC_HLE_Device_usb: const correctness for function parameters
The data passed in isn't modified in these functions

Also normalizes variables with prefixed underscores in the modified
functions (and normalizes outliers to our current coding style), as
single-underscore followed by any lowercased/uppercased character is
reserved for use in the global namespace (it's a common misconception this
is assumed to only be the case for underscores followed by a capital
character, but this is only the case in C, not C++).
2015-12-05 16:14:37 -05:00
Sepalani e1e6d2ba2c WSAPoll: Fixed - invalid argument was supplied 2015-12-05 19:39:17 +01:00
spxtr a06b0d87a7 Refactor proxy models and toolbar.
Remove the ugly LARGE_ICON column hack from the table proxy and use a
list proxy. Move the toolbar into its own file.
2015-12-03 20:41:17 -08:00
Pringo b6f16b3049 Remove Google Code Reference and Fix Grammar 2015-12-03 18:20:59 -08:00
JosJuice a0cd753060 Don't read from volume when reloading Wii banners
Should make loading cached Wii games that lack banners slightly faster.
2015-12-03 17:29:59 +01:00
Markus Wick 297f6a097d Merge pull request #3307 from Pringo/update-url
Update Issue Tracker URL in Comment
2015-12-03 17:27:43 +01:00
Lioncash e0eef7bef4 WaveFile: Get rid of an explicit delete 2015-12-02 20:05:18 -05:00
Scott Mansell a759883ae5 Merge pull request #3126 from phire/remove-logging-lock
Refactor logging code to get rid of a mutex.
2015-12-03 13:32:07 +13:00
Markus Wick 6425ddcbe7 Merge pull request #3253 from Phatcat/master
More wiimote controls (+extensions) for android
2015-12-02 22:50:29 +01:00
Phatcat ca9c9b7135 Wiimote + Extensions for Android 2015-12-02 21:58:54 +01:00
degasus f3b6afe1c5 ConfigManager: initialize m_revision
FifoPlayer don't set it, and don't need it. But it's used...
2015-12-02 21:37:12 +01:00
degasus d28c9ae354 VideoSW: Wipe output vertices
They shall be overwritten afterwards.
2015-12-02 21:37:12 +01:00
Pringo aaa67ca57e Update Issue Tracker Link in Comment 2015-12-02 09:01:28 -08:00
JosJuice f41990af38 Remove incorrect usage of _trans
It only marks a string for translation. It doesn't actually do anything
at runtime, so the message will always be displayed in English. Even if
we would've had a way to make the translation work, we shouldn't
translate this, because OSD doesn't support non-ASCII characters.

Caused by the recent merge 1c95cd5.
2015-12-02 17:13:04 +01:00
Markus Wick abbc25f662 Merge pull request #2788 from TurboK234/3d_hotkeys
Added hotkeys for toggling different stereoscopy modes
2015-12-02 15:24:59 +01:00
Markus Wick 3ed29cce0c Merge pull request #2733 from AdmiralCurtiss/string-from-float
IniFile: Fix floating point number locale issues.
2015-12-02 15:22:42 +01:00
Markus Wick 1c95cd5ad5 Merge pull request #2745 from AdmiralCurtiss/wiimote-disconnect-message
Display a message on screen when the emulated software disconnects a Wiimote.
2015-12-02 15:13:29 +01:00
Markus Wick a3433e162a Merge pull request #3149 from ShadowsFriend/fname_column
DolphinWX: Add a filename column
2015-12-02 15:04:36 +01:00
Markus Wick ec6a48ff76 Merge pull request #2876 from CastellaFactory/master
[Netplay] Add "Force Netplay Listen Port" feature that was in old netplay branch
2015-12-02 14:20:47 +01:00
Markus Wick b0dbb6ef46 Merge pull request #3067 from JosJuice/cheat-manager-regression
Fix Cheat Manager not saving created codes
2015-12-02 14:08:32 +01:00
Markus Wick 4a40e7b405 Merge pull request #3111 from JosJuice/wx-banner-scaling
DolphinWX: Improve HBC banner scaling
2015-12-02 13:59:13 +01:00
Pringo d8d6c0122e Update Error Log to Remove Old Issue Tracker URL 2015-12-01 19:57:10 -08:00
Markus Wick 52204c7296 Merge pull request #3299 from phire/JJ_Abrams
Fix lens flares in Mario Kart Wii.
2015-12-01 09:07:09 +01:00
Andrew Wickham d9f1523a7b Make cast from int to float explicit in shader
This should fix this panic message I saw when playing Super Mario Strikers:

Failed to compile pixel shader [...]: error C7011: implicit cast from "int" to "float"
2015-11-30 13:35:46 -08:00
Scott Mansell 03461915a7 Fix lens flares in Mario Kart Wii. 2015-12-01 05:25:38 +13:00
Markus Wick 02d5981b22 Merge pull request #3290 from JosJuice/compression-condition
DolphinWX: Correct a compression condition
2015-11-30 13:53:50 +01:00
Ryan Houdek 21b708106c Make sure not to use a GL texture buffer past the max size.
The spec says that vendors can set the max texture size to be 65KB and we want 1MB.
Check the maximum supported and drop to the max if it is less than 1MB
2015-11-30 01:18:03 -06:00
Brian Bowman 507b7920e9 Fix typo in anti-aliasing dropdown description 2015-11-29 14:28:26 -06:00
Scott Mansell 97231aa221 Merge pull request #3294 from spxtr/DQt2-GameProxyModel
DolphinQt2: Use a proxy model for the GameList
2015-11-30 07:48:54 +13:00
spxtr 59bdeb411c Use a proxy model for the GameList.
This lets us sort by the underlying integers while only displaying the
icons. Currently, in both DolphinQt and DolphinQt2, we display both the
icon and the integer, but cut off the column width to not show the
integer. We also currently sort by the size's formatted string, not by
the size itself, which leads to "1 MB" sorting to less than "2 KB". This
commit fixes these issues.

In the future, we can use the filter methods here to allow for
searching for games.
2015-11-28 10:00:03 -08:00
Scott Mansell 97cd723492 Merge pull request #3286 from jloehr/Wiimote-Rumble-LED-Fix
Fix Prepare (Set LEDs and Rumble) on Connect and Refresh
2015-11-29 00:58:18 +13:00
Julian Löhr 31a4b2ed03 Fix Prepare (Set LEDs and Rumble) on Connect and Refresh
m_need_prepare needs to be set before the Device thread is started.
Otherwise the thread blocks on IORead and the LEDs and Rumble is executed
after the user presses a button on the Wiimote.
Also the Prepare-Call on Refresh doesn't need to reset the Index, because it is
set once on the initial Connect/Prepare. Therefore the index assignment
was refactored.
2015-11-28 12:38:19 +01:00
Scott Mansell 861bd98e3a Merge pull request #3291 from JosJuice/memset-error-check
Memmap: More error checking for Memset
2015-11-28 22:38:24 +13:00
JosJuice 0d3c763126 State/Movie: Use char instead of u8 for game ID
Gets rid of casts.
2015-11-28 09:36:48 +01:00
JosJuice 0cb5c4637a Memmap: Replace ValidCopyRange with GetPointerForRange 2015-11-28 09:26:48 +01:00
JosJuice b5f32b9699 DolphinWX: Correct a compression condition
The volume type check didn't handle DOL/ELF files, and the blob type
check didn't handle formats like CISO and relied on filename extensions.
2015-11-28 09:24:15 +01:00
JosJuice f9af58a388 DiscIO: Don't use PlainFileReader in VolumeDirectory
Blobs are not for regular file reading.
2015-11-28 09:18:22 +01:00
JosJuice 2e3735b772 Memmap: More error checking for Memset
It now uses the same error checking as CopyFromEmu and CopyToEmu.
2015-11-27 18:28:53 +01:00
JosJuice 2b0bdc361f State: Don't use memcpy and memcmp with strings 2015-11-27 17:36:34 +01:00
Scott Mansell 5a1729877e Merge pull request #3211 from JosJuice/themes-to-resources
Move nobanner and fileplatform from Themes to Resources
2015-11-27 23:47:44 +13:00
JosJuice 9b2fe62bc9 Move nobanner and fileplatform from Themes to Resources
fileplatform is moved so it's in the same place as the other platform
icons, and nobanner is moved just because it fits better in Resources.
Both of them were identical in all of Dolphin's themes.
2015-11-27 11:09:20 +01:00
JosJuice 4249d9ef77 ISOFile/GameFile: Simplify IsElfOrDol 2015-11-27 10:50:19 +01:00
spxtr 949f25175b DolphinQt2 2015-11-27 00:33:07 -08:00
waddlesplash 4acd90d570 DolphinQt: Get rid of unneeded abbreviation macros. 2015-11-25 23:16:54 -05:00
degasus 0b02dc4f81 FramebufferManager: check for g_framebuffer_manager 2015-11-24 22:48:56 +01:00
degasus 0f26cdd31b FramebufferManager: Allow CreateXFBSource to return nullptr 2015-11-24 22:48:55 +01:00
degasus c9dc5fb376 TextureCache: Allow the backends to return nullptr for textures. 2015-11-24 22:48:55 +01:00
degasus fc00598785 NativeVertexFormat: Inline Initialize in contructor
They were only called at once, so no need to seperate them.

This also removes the only dereference of the NativeVertexFormat in VideoCommon, so backends may just return nullptr.
2015-11-24 22:48:49 +01:00
degasus df799dd124 VideoCommon: Create default implementation for state setters
It's fine to pull those within the backends, so there is no need to enforce them to implement this interface.
2015-11-24 22:39:10 +01:00
Markus Wick f560e8e283 Merge pull request #3285 from jloehr/Wiimote-Index-LED-Fix
Fix Wiimote Index LED
2015-11-24 18:31:57 +01:00
Stenzek d1b132731d D3D: Remove redundant cast, move pitch calculation to caller 2015-11-24 21:54:19 +10:00
Stenzek 6be4608a0d D3D: Fix crash on some drivers with small textures 2015-11-24 21:15:19 +10:00
Scott Mansell 211169e307 Merge pull request #3269 from JosJuice/purge-cache
Rename "Purge Cache" to "Purge Game List Cache"
2015-11-24 14:17:49 +13:00
Scott Mansell 83bda3be46 Merge pull request #1474 from phire/DSPHLE_cleanups
DSPHLE: Remove individual byteswaps and replace with generic function.
2015-11-24 13:33:59 +13:00
Julian Löhr aace2f694f Fix Wiimote Index LED 2015-11-23 23:24:49 +01:00
Matthew Parlane f92a36d86c Merge pull request #3283 from RisingFog/patch-1
Fix Frame Advance Hold Delay Changes
2015-11-24 10:44:52 +13:00
Ryan Houdek d27dcdba48 We shouldn't be trying to enable the SSBO extension in ES. 2015-11-23 14:47:43 -06:00
Chris Burgener 1ea9b36e3b Fix Frame Advance Hold Delay Changes
Fixes the issues of modifying the frame advance speed increase/decrease not actually doing anything
2015-11-23 13:53:14 -05:00
Scott Mansell ffb9722f2d Merge pull request #3032 from waddlesplash/dolphin-qt
Lots more minor DolphinQt stuffs.
2015-11-23 21:45:28 +13:00
Lioncash 35b02db39d ISOFile: Get rid of explicit deletes 2015-11-21 21:15:01 -05:00
Tony Drake 941125699c Added info for Rodea The Sky Soldier 2015-11-21 11:40:03 -05:00
JosJuice 74ea765427 Mark more strings for translation 2015-11-20 11:33:47 +01:00
Matthew Parlane 0e258d4621 Merge pull request #3152 from ShadowsFriend/ipl_checksum
Use CRC32 for IPL checks and update hashes
2015-11-20 14:37:13 +13:00
Pierre Bourdon f571bdd7e3 Merge pull request #3274 from JosJuice/menu-capitalization
DolphinWX: More consistent capitalization in menus
2015-11-19 14:00:46 +01:00
Scott Mansell 2ca07f3485 Merge pull request #3272 from Sonicadvance1/we_love_traps
Use __builtin_trap for our crash define instead of int3/exit
2015-11-20 01:11:29 +13:00
Markus Wick 41f9d4f5fa Merge pull request #3271 from Sonicadvance1/es_sampler_cache
Enable Anisotropic filtering in ES.
2015-11-19 12:42:16 +01:00
JosJuice 3778793df5 DolphinWX: More consistent capitalization in menus 2015-11-19 12:25:17 +01:00
Ryan Houdek ed5e3c054e Enable Anisotropic filtering in ES.
This adds a check to make sure the vendor supports anisotropic filtering.
Pretty much all vendors support this, even the mobile ones.
2015-11-19 02:00:43 -06:00
Lioncash b9975694ab InputConfig: Clean up controller management 2015-11-19 02:41:33 -05:00
Ryan Houdek 5f1fcf4c8d Use __builtin_trap for our crash define instead of int3/exit 2015-11-19 00:49:42 -06:00
mathieui 680ebfeaa8 Reset the GC adapter rumble when stopping a game
And when loading a savestate, pausing, and starting dolphin as well
(right after the libusb initialization).

Intended fix for issue 9001
2015-11-18 20:48:48 +01:00
JosJuice 1c8938cd59 Rename "Purge Cache" to "Purge Game List Cache"
Users who have heard about the shader cache but not the game list cache
might think that "Purge Cache" will affect the shader cache.
2015-11-18 19:08:19 +01:00
Markus Wick 584ea8b320 Merge pull request #3206 from JosJuice/limit-filesystem-size-2
Limit size of loaded file systems
2015-11-18 10:43:47 +01:00
Markus Wick f172cda50f Merge pull request #3191 from lioncash/rekt
MathUtil: Minor changes to Rectangle
2015-11-18 10:40:54 +01:00
Markus Wick 0b123605de Merge pull request #3235 from JosJuice/ssaa-checkbox
Remove SSAA checkbox and add SSAA to AA dropdown
2015-11-18 10:36:11 +01:00
degasus ee2223c4a0 TextureCache: Fix crash for invalid textures. 2015-11-17 23:29:54 +01:00
JosJuice 2005409229 Do nothing when calling CopyToEmu with a length of 0
Gecko apparently tries to read 0 bytes from the DVD to 0x00000000.
2015-11-17 21:39:46 +01:00
JosJuice 3a9e382661 DiscIO: Small VolumeDirectory simplifications 2015-11-17 10:09:54 +01:00
Markus Wick 24c7d23073 Merge pull request #2149 from JosJuice/async-disc-io
Read disc data asynchronously in a new thread
2015-11-17 10:01:34 +01:00