This reverts commit 2b5d0b6219.
A lot of these make things harder to read:
- Extra empty lines in large switch stacks mean they're more likely to go off one screen
- `if` and its condition on the same line is super hard to read, please never do that. (Are the extra empty lines an attempt to mitigate the above)
- Removing terenaries obscures intent, and now there's more copy paste than before
- """Redundant""" else clauses on if...return kept things nice and lined up.
That was a huge churning diff with no value; let's stop it from spreading.
* first round of GameShark.cs cleanups, redundant code and stylecop cleanup
* simplify how gba readonly values are set
* a few more cleanups
* GameShark - use NESGameGenieDecoder for nes logic
* remove now unused NESGameGeneie tool
* Client.Common - move nes encode/decoder to a cheats folder
* GameShark - move genesis game genie coding logic to its own class
* remove NesGameGenieEncoder that i snow unused
* fix naming
* remove GenGameGenie in favor of using the unified Cheat Code decoder
* move Gameboy/GameGear decoding logic from GameShark to its own class, cleanup
* remove GBGameGenie, was only exposed via the toolbox, GameShark tool does all of this logic
* GameShark - move snes game genie decoding logic to its own class
* cleanup
* remove unused snes GameGenie tool
* move Gb GameShark decoding to its own class
* cleanup
* move Genesis action replay decoding logic to its own class
* cleanup
* cleanup
* cleanup
* cleanup
* move Sms ActionReplay decoding to its own class, cleanlup
* cleanup
* move snes action replay decoding to its own class
* cleanup with a helper method
* cleanup
* more cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* move Psx GameShark decoding to its own class
* Move saturn gameshark parsing to its own class
* cleanup
* cleanup
* move N64 decoder logic to its own class
* remove GBA cheat code that hasn't been ready for 5 years, easier to try to implement this in the re-architected code, so delete for now at least
* start to detangle GBA gameshark mess
* Gameshark - remove most gba cheat code functionality for now, easier to rebuild it later
* Gameshark - cleanup
* cleanup
* cleanup
* cleanup
* redesign nes decoder to simpler design
* simplify more
* convert psx and saturn decoders and simplify
* convert more decoders
* convert more decoders
* convert more decoders
* convert more decoders
* convert gba decoder
* convert more decoders
* convert and simplify N64 decoder
* GameShark - simplify more
* Use expression bodies in Emulation.Cores, and a few other misc cleanups
* remove unused usings in Emulation.Common
* cleanups in Tables_Direct.cs
* some cleanups in nes boards - redundant code
* remove some redundant array initializers in Emulation.Cores
* cleanup AmstradCPC.Controllers
* use object initializers in a lot of places
* nes mappers - remove disch's notes comments in favor of the nesdev wiki link
* cleanup CdtConverter.cs, mostly use of object initializers
* remove redundant .ToString() calls in Emulation.Cores
* using var in Emulation.Cores
* AmstradCPC/ZXSpectrum - simplify some linq, tabs instead of spaces, a few other misc cleanups
* Use null-propagation in Emulation.Cores
Morilli