As noted in the FindThreads documentation[0], CMAKE_THREAD_LIBS_INIT
may be empty if no special flags are needed to use thread support.
Instead, use Threads_FOUND to determine if threads are supported.
[0] https://cmake.org/cmake/help/latest/module/FindThreads.html
If we don't skip past the following separator when the destination
is empty, then `./file` gets canonicalized as `/file`.
Also, consider the case where we end up with an empty string (for
example, from `foo/..`). Canonicalize this as `.`.
The previous implementation had a few issues in certain edge cases:
- If the path contained no '/' or '\', then the string_view constructor
is called with a count that exceeds the length of the string
(effectively `title_end - (char *)0`, which is undefined behavior,
at least in C).
- If the only '/' was the filesystem root, the last character of
the title was truncated, and the '/' remained. For example,
"/title.bin" resulted in "/titl".
- At least in C, it is undefined behavior to use the the < operator
with a null pointer, which is done in std::max if the path did
not have both '/' and '\'.
The first issue results in a std::bad_alloc exception on my machine.
Address increment is a u8 and value increment is a u16. The changes will make this work correctly:-
50000AA4 FFFF
801CC760 0400
which is a example slide code representing:-
801CC760 0400
801CC804 03FF
801CC8A8 03FE
801CC94C 03FD
801CC9F0 03FC
801CCA94 03FB
801CCB38 03FA
801CCBDC 03F9
801CCC80 03F8
801CCD24 03F7
* Adding PGXP CPU for 2 games
* Revert "Adding PGXP CPU for 2 games"
This reverts commit 35e9ad743f.
* Update gamesettings.ini
Adding 2 more games that need CPU PGXP
1. Cleaned up and added cheats for non-softwarelist games, mainly for PAL regions this has doubled the size of the database.
2. Added information about the various 32 bit by 32 bit cheat types to the cheat file header.
3. Added information for cheat types 31, 32 ,81, 82, 91 & 92 which are BIT set and clear cheat types - I'll do a PR for these in the next week.
4. Grouped some more cheats
Connor McLaughlin