ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
dolphin/Source/Core/DolphinQt
History
JosJuice 72cf2bdb87 Audit uses of IsRunning and GetState 
Some pieces of code are calling IsRunning because there's some
particular action that only makes sense when emulation is running, for
instance showing the state of the emulated CPU. IsRunning is appropriate
to use for this. Then there are pieces of code that are calling
IsRunning because there's some particular thing they must avoid doing
e.g. when the CPU thread is running or IOS is running. IsRunning isn't
quite appropriate for this. Such code should also be checking for the
states Starting and Stopping. Keep in mind that:

* When the state is Starting, the state can asynchronously change to
  Running at any time.
* When we try to stop the core, the state gets set to Stopping before we
  take any action to actually stop things.

This commit adds a new method Core::IsUninitialized, and changes all
callers of IsRunning and GetState that look to me like they should be
changed.
 		2024-06-21 20:52:55 +02:00
..
Achievements Audit uses of IsRunning and GetState 2024-06-21 20:52:55 +02:00
Config Audit uses of IsRunning and GetState 2024-06-21 20:52:55 +02:00
Debugger Audit uses of IsRunning and GetState 2024-06-21 20:52:55 +02:00
FIFO Audit uses of IsRunning and GetState 2024-06-21 20:52:55 +02:00
GameList Audit uses of IsRunning and GetState 2024-06-21 20:52:55 +02:00
InfinityBase DolphinQt: Fix double argument in Infinity error message 2024-05-19 21:52:49 +02:00
NetPlay Audit uses of IsRunning and GetState 2024-06-21 20:52:55 +02:00
QtUtils PPCSymbolDB: GetDescription by std::string_view 2024-04-13 00:19:01 -07:00
Settings Audit uses of IsRunning and GetState 2024-06-21 20:52:55 +02:00
SkylanderPortal Change Default Skylander File Selection Types 2024-05-17 02:52:50 +01:00
Styles/Dark Dark style: add QTableCornerButton. Fix padding for tables. 2023-11-04 15:00:07 -07:00
TAS Core::IsRunning: Avoid Global System Accessor 2024-05-01 08:54:17 -07:00
AboutDialog.cpp DolphinQt: Update AboutDialog to include number of commits ahead of master. 2024-03-23 16:48:52 -05:00
AboutDialog.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
CMakeLists.txt Merge pull request #12728 from OatmealDome/mac-version-numbers-2 2024-05-30 01:13:32 -04:00
CheatSearchFactoryWidget.cpp Audit uses of IsRunning and GetState 2024-06-21 20:52:55 +02:00
CheatSearchFactoryWidget.h DolphinQt: Rewrite cheat search GUI. 2021-09-15 19:05:49 +02:00
CheatSearchWidget.cpp DolphinQt: Properly Delete (Some) Widgets 2024-04-30 11:17:28 -07:00
CheatSearchWidget.h DolphinQt: Allow Cheat Search to create multiple AR codes when selecting multiple lines. 2024-03-17 01:29:39 -05:00
CheatsManager.cpp Audit uses of IsRunning and GetState 2024-06-21 20:52:55 +02:00
CheatsManager.h CheatsManager/CheatSearchWidget: Avoid Global System Accessor 2024-03-11 20:51:15 -07:00
ConvertDialog.cpp DolphinQt: Remove unnecessary qOverloads 2023-11-04 14:14:14 -07:00
ConvertDialog.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
DiscordHandler.cpp DolphinQt: Set window decorations for all top-level QWidgets. 2023-08-12 16:54:54 +02:00
DiscordHandler.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
DiscordJoinRequestDialog.cpp Remove most uses of StringFromFormat in favor of fmt 2022-10-12 16:50:47 -07:00
DiscordJoinRequestDialog.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
DolphinEmu.entitlements DolphinQt: Add com.apple.security.cs.allow-dyld-environment-variables to entitlements 2022-05-18 20:23:17 -04:00
DolphinEmuDebug.entitlements DolphinQt: Add com.apple.security.cs.allow-dyld-environment-variables to entitlements 2022-05-18 20:23:17 -04:00
DolphinQt.manifest DolphinQt: dont set dpi awareness in manifest 2023-04-25 10:49:46 -07:00
DolphinQt.rc Move DolphinQt2 to DolphinQt 2018-07-07 00:48:38 +02:00
DolphinQt.vcxproj Created AchievementBox Qt object 2024-05-01 06:43:20 -04:00
DolphinQt.vcxproj.user msbuild: use default Project attrs 2022-04-27 15:26:43 -07:00
GBAHost.cpp Qt/Core: Refactor GBA Core accessors 2021-07-24 14:54:57 +02:00
GBAHost.h Qt: Implement GBA host and widget 2021-07-13 16:43:28 +02:00
GBAWidget.cpp Core::RunOnCPUThread: Avoid Global System Accessor 2024-03-28 10:10:03 -07:00
GBAWidget.h GBAWidget: Add missing override specifiers 2023-12-13 10:12:18 -05:00
GCMemcardCreateNewDialog.cpp Add wrapper function to disable hotkeys for QFileDialog 2021-10-09 22:43:56 -04:00
GCMemcardCreateNewDialog.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
GCMemcardManager.cpp DolphinQt: Set window decorations for all top-level QWidgets. 2023-08-12 16:54:54 +02:00
GCMemcardManager.h GCMemcardManager: Shorten-up EnumMap definitions 2023-06-08 13:05:13 -04:00
Host.cpp Core::GetState: Avoid Global System Accessor 2024-04-08 16:23:23 -07:00
Host.h DolphinQt: A Ubiquitous Signal For When Symbols Change 2024-03-28 09:57:22 -07:00
HotkeyScheduler.cpp Audit uses of IsRunning and GetState 2024-06-21 20:52:55 +02:00
HotkeyScheduler.h Add Hotkeys for Skylanders Portal and Infinity Base Menus 2023-05-26 13:36:08 -07:00
Info.plist.in Set LSApplicationCategoryType to games 2023-01-10 11:34:42 +00:00
Main.cpp Core: Remove RunAsCPUThread 2024-03-23 03:33:26 -07:00
MainWindow.cpp Audit uses of IsRunning and GetState 2024-06-21 20:52:55 +02:00
MainWindow.h Merge pull request #11497 from vyuuui/debugger_assembler_ui 2023-12-16 21:15:31 +00:00
MenuBar.cpp Audit uses of IsRunning and GetState 2024-06-21 20:52:55 +02:00
MenuBar.h Audit uses of IsRunning and GetState 2024-06-21 20:52:55 +02:00
NANDRepairDialog.cpp Qt: Make custom dialog for NAND Repair. 2022-08-28 03:11:17 +02:00
NANDRepairDialog.h Qt: Make custom dialog for NAND Repair. 2022-08-28 03:11:17 +02:00
NKitWarningDialog.cpp DolphinQt: Set window decorations for all top-level QWidgets. 2023-08-12 16:54:54 +02:00
NKitWarningDialog.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
RenderWidget.cpp Core: Store current state in less places 2024-06-21 20:46:44 +02:00
RenderWidget.h Remove rounded corners on emulation render window 2024-04-28 12:41:39 +03:00
ResourcePackManager.cpp DolphinQt: Set window decorations for all top-level QWidgets. 2023-08-12 16:54:54 +02:00
ResourcePackManager.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
Resources.cpp DolphinQt: cache icons instead of single pixmaps 2023-04-25 12:34:27 -07:00
Resources.h DolphinQt: cache icons instead of single pixmaps 2023-04-25 12:34:27 -07:00
RiivolutionBootWidget.cpp Disable memory patches in hardcore mode 2023-12-02 16:41:16 -05:00
RiivolutionBootWidget.h Disable memory patches in hardcore mode 2023-12-02 16:41:16 -05:00
SearchBar.cpp treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
SearchBar.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
Settings.cpp Use a stub AchivementManager when USE_RETRO_ACHIEVEMENTS isn't defined 2024-06-06 08:26:20 +02:00
Settings.h InterfacePane: Add BalloonTip to cursor visible radio buttons 2024-05-31 19:09:00 +02:00
ToolBar.cpp Core::GetState: Avoid Global System Accessor 2024-04-08 16:23:23 -07:00
ToolBar.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
Translation.cpp Remove most uses of StringFromFormat in favor of fmt 2022-10-12 16:50:47 -07:00
Translation.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
Updater.cpp DolphinQt: Properly Delete (Some) Widgets 2024-04-30 11:17:28 -07:00
Updater.h Qt/Updater: Remove unused member variable. 2022-11-15 00:56:08 +01:00
WiiUpdate.cpp DolphinQt: Set window decorations for all top-level QWidgets. 2023-08-12 16:54:54 +02:00
WiiUpdate.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
pch_qt.cpp msbuild: add pch for dolphinqt 2022-06-21 13:35:14 -07:00
pch_qt.h msbuild: add pch for dolphinqt 2022-06-21 13:35:14 -07:00
qt.conf Move DolphinQt2 to DolphinQt 2018-07-07 00:48:38 +02:00
qt.conf.win DolphinQt/CMake: Building on Windows 2019-05-12 00:05:10 +02:00
qt6.natvis Add support for building against Qt 6 2022-05-02 22:39:33 -07:00
resource.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00