dolphin/Source/Core
JosJuice 72cf2bdb87 Audit uses of IsRunning and GetState
Some pieces of code are calling IsRunning because there's some
particular action that only makes sense when emulation is running, for
instance showing the state of the emulated CPU. IsRunning is appropriate
to use for this. Then there are pieces of code that are calling
IsRunning because there's some particular thing they must avoid doing
e.g. when the CPU thread is running or IOS is running. IsRunning isn't
quite appropriate for this. Such code should also be checking for the
states Starting and Stopping. Keep in mind that:

* When the state is Starting, the state can asynchronously change to
  Running at any time.
* When we try to stop the core, the state gets set to Stopping before we
  take any action to actually stop things.

This commit adds a new method Core::IsUninitialized, and changes all
callers of IsRunning and GetState that look to me like they should be
changed.
2024-06-21 20:52:55 +02:00
..
AudioCommon Android: Implement OpenSLESStream::SetRunning 2024-06-04 19:32:04 +02:00
Common Merge pull request #12830 from VampireFlower/aliases 2024-06-10 18:35:40 +02:00
Core Audit uses of IsRunning and GetState 2024-06-21 20:52:55 +02:00
DiscIO Use a stub AchivementManager when USE_RETRO_ACHIEVEMENTS isn't defined 2024-06-06 08:26:20 +02:00
DolphinNoGUI Merge pull request #12760 from AdmiralCurtiss/win-cmake-fix 2024-05-05 19:40:25 +02:00
DolphinQt Audit uses of IsRunning and GetState 2024-06-21 20:52:55 +02:00
DolphinTool Suppress extract success message when quiet flag is set 2024-06-06 17:55:59 -04:00
InputCommon Merge pull request #12711 from jordan-woyak/modifier-range-ini-default 2024-05-21 22:11:42 +02:00
MacUpdater ScmRevGen: Generate Info.plist for MacUpdater 2024-04-21 13:28:21 -04:00
UICommon Merge pull request #12736 from mitaclaw/minizip-ng-update 2024-05-21 22:21:56 +02:00
UpdaterCommon CMake: Use targets for all optionally-external dependencies 2023-06-15 01:41:41 -05:00
VideoBackends Merge pull request #12537 from TellowKrinkle/MTLSubgroup 2024-05-21 22:17:22 +02:00
VideoCommon Audit uses of IsRunning and GetState 2024-06-21 20:52:55 +02:00
WinUpdater StringUtil: Move CommandLineToUtf8Argv() into Common namespace 2023-05-16 14:23:21 -04:00
CMakeLists.txt CMakeLists: Add option to disable automatic update support 2022-03-18 03:04:51 -04:00
DolphinLib.ARM64.props msbuild: use default Project attrs 2022-04-27 15:26:43 -07:00
DolphinLib.props VideoCommon: Use GetSpanForAddress safely in texture decoding 2024-04-20 18:31:08 +02:00
DolphinLib.vcxproj Externals: Convert minizip-ng To Submodule 2024-05-03 12:43:33 -07:00
DolphinLib.vcxproj.user msbuild: use default Project attrs 2022-04-27 15:26:43 -07:00
DolphinLib.x64.props Move x64 DSP JIT into DolphinLib.x64.props 2023-01-06 22:42:21 -08:00