f09b71582e
Core: Avoid (Some) Global System Accessor
2024-03-18 01:35:42 -07:00
f7a0147176
prevent backpressure when m_read_enabled is not set
2024-03-17 18:37:55 -07:00
3e9ac1aaf3
fix tapserver SIGPIPE handling on Linux
2024-03-17 18:37:55 -07:00
5d8a01cba7
respond to further review feedback
2024-03-17 18:37:55 -07:00
7775ea325f
close modem socket after joining read thread
2024-03-17 18:37:55 -07:00
9d0d2f0a40
handle ATH0 command
2024-03-17 18:37:55 -07:00
12a7e17a41
fix warnings in windows build
2024-03-17 18:37:55 -07:00
9cf8131b23
respond to review feedback on tapserver implementation
2024-03-17 18:37:55 -07:00
dcb7a72c14
add modem files to windows build
2024-03-17 18:37:55 -07:00
02deaa6748
Implement GC modem adapter
...
This implements the GameCube modem adapter. This implementation is stable but not perfect; it drops frames if the receive FIFO length is exceeded. This is probably due to the unimplemented interrupt mentioned in the comments. If the tapserver end of the connection is aware of this limitation, it's easily circumvented by lowering the MTU of the link, but ideally this wouldn't be necessary.
This has been tested with a couple of different versions of Phantasy Star Online, including Episodes 1 & 2 Trial Edition. The Trial Edition is the only version of the game that supports the Modem Adapter and not the Broadband Adapter, which is what made this commit necessary in the first place.
2024-03-17 18:37:55 -07:00
083116a89c
rewrite tapserver interface for better error handling
2024-03-17 18:37:55 -07:00
a36600ae50
add TAPServer.cpp to Windows build
2024-03-17 18:37:55 -07:00
0c364cbb4c
implement tapserver BBA on all platforms
...
This expands the tapserver BBA interface to be available on all platforms. tapserver itself is still macOS-only, but newserv (the PSO server) is not, and it can directly accept local and remote tapserver connections as well. This makes the tapserver interface potentially useful on all platforms.
2024-03-17 18:37:55 -07:00
85dee300b5
Merge pull request #12644 from jordan-woyak/ar-multi
...
DolphinQt: Allow Cheat Search to create multiple AR codes.
2024-03-17 16:26:38 +01:00
c964d552c9
Merge pull request #12616 from mitaclaw/dvd-interface-cpu-thread-guard
...
DVDInterface: Modernize With CPUThreadGuard
2024-03-17 16:14:56 +01:00
c202b55bd4
DolphinQt: Allow Cheat Search to create multiple AR codes when selecting multiple lines.
2024-03-17 01:29:39 -05:00
1ee923fd3d
Merge pull request #12630 from mitaclaw/ppc-symbols-global
...
PPCSymbolDB: Move instance to PowerPCManager
2024-03-17 06:03:05 +01:00
d933e58d9a
Cubeb: check correct log level
2024-03-17 01:33:42 +00:00
ac5c2d9bf2
VideoCommon: Prefer D3D11/12 over OpenGL on Windows.
2024-03-15 19:51:04 -05:00
3a85725ffa
SDL: Remove duplicate button/hat Inputs. Hide duplicate Axis Inputs.
2024-03-14 23:50:17 -05:00
ee43c9508c
ControllerInterface: Add IsHidden function to Control interface.
2024-03-14 23:43:58 -05:00
0538366326
SDL: Deduplicate Motor logic with templates.
2024-03-14 23:43:58 -05:00
0fff8374d0
SDL: Move class definition out of header.
2024-03-14 23:43:58 -05:00
369502b49b
Merge pull request #12635 from jordan-woyak/ir-passthrough-indicator
...
DolphinQt: Add IRPassthrough indicator.
2024-03-15 03:07:19 +01:00
9cdd571745
Merge pull request #12633 from LillyJadeKatrin/retroachievements-toggle-spam
...
Added locks to achievement runtime calls
2024-03-15 02:58:02 +01:00
2620f73b8c
Merge pull request #12638 from Tilka/cubeb
...
Cubeb: change log level from NOTICE to INFO
2024-03-15 02:55:28 +01:00
08ecefe0f7
Added locks to achievement runtime calls
...
Testing found that spamming toggles for Enable Leaderboards etc risked leaderboards being deleted while the runtime was in the process of recalculating them; this should clear up those conflicts.
2024-03-14 14:32:47 -04:00
c24fa93965
PPCSymbolDB: Move instance to PowerPCManager
2024-03-13 22:58:14 -07:00
4d9038c7c3
Cubeb: change log level from NOTICE to INFO
...
Cubeb logs a message at CUBEB_LOG_NORMAL verbosity every time you start
or stop a stream which can get a bit annoying when using frame advance
at Dolphin's default verbosity.
2024-03-14 00:31:02 +00:00
c377c1e21e
CheatsManager/CheatSearchWidget: Avoid Global System Accessor
...
OnResetClicked and GenerateARCode appear to have been using the CPUThreadGuard in error.
2024-03-11 20:51:15 -07:00
551dcec0b1
Merge pull request #12602 from mitaclaw/qt-memory-global-system
...
Memory(View)Widget: Avoid Global System Accessor
2024-03-12 04:12:52 +01:00
6ccf35ad4d
Merge pull request #12600 from lioncash/dspreg
...
DSPJitRegCache: Take DynamicReg instances by reference in FlushRegs()
2024-03-12 04:02:09 +01:00
62caa24d40
DolphinQt: Add IRPassthrough indicator.
2024-03-11 21:40:53 -05:00
d35a88564f
Merge pull request #12608 from mitaclaw/bootmanager-global-system
...
BootManager: Avoid Global System Accessor
2024-03-12 03:39:48 +01:00
72bcdadc16
Merge pull request #12492 from AdmiralCurtiss/wiimote-ir-passthrough
...
Implement IR passthrough for emulated Wiimotes
2024-03-12 03:27:07 +01:00
cda008bd10
Merge pull request #12533 from sepalani/bba-psh-ack
...
BBA/HLE: Add missing PSH flag
2024-03-12 03:09:11 +01:00
f86e9e9cbd
Merge pull request #12610 from mitaclaw/branch-watch-dialog-gcc
...
BranchWatchDialog: Fix GCC Warnings
2024-03-11 17:36:21 -05:00
f6f435e624
WiimoteEmu: Set sensible defaults for IR Object expressions.
2024-03-11 22:51:57 +01:00
617fcc3cf8
WiimoteEmu: Add user-accessible controls that report the desired state of the IR camera objects.
2024-03-11 22:49:19 +01:00
c3903fcc7e
InputCommon/WiimoteController: Add inputs that report the raw IR objects seen by the Wiimote.
2024-03-11 22:46:05 +01:00
9c68b156d1
Core/HW/WiimoteCommon: Add a method to DataReport to query the format of the stored IR data.
2024-03-11 22:27:16 +01:00
eced34f3f3
Core/HW/WiimoteEmu: Allow storing and reporting up to 4 camera objects, like a real Wiimote.
2024-03-11 22:27:16 +01:00
5c656a2b6f
Merge pull request #12623 from eltociear/patch-1
...
WiimoteReal: fix typo in WiimoteReal.cpp
2024-03-11 12:19:46 -05:00
b23dbad098
InputCommon: Remove some IOKit leftovers.
2024-03-11 01:11:13 -05:00
153d0201a8
Add HDR to Metal
2024-03-10 03:25:33 -04:00
b89a88afbc
Merge pull request #12615 from mitaclaw/ppc-symbol-db-member
...
PPCSymbolDB: Eliminate Redundant Member
2024-03-10 06:18:23 +01:00
ef75a6ff23
Merge pull request #12622 from mitaclaw/branch-watch-dialog-errata
...
BranchWatchDialog: Fix Misc. Errata
2024-03-10 00:06:21 +01:00
5418e89523
Adjusted achievement progress updates to duration short
2024-03-08 23:26:56 -05:00
fe61efcd7a
DVDInterface: Modernize With CPUThreadGuard
2024-03-08 15:17:41 -08:00
0645b4d579
BranchWatchDialog: Fix Misc. Errata
...
Window icon was missing from QDialog lacking a parent.
Giving the QDialog a parent revealed I had failed to make it properly non-modal, necessitating further changes.
Settings save less often, now only upon destruction.
Construction of BranchWatchDialog is now deferred.
2024-03-07 15:59:03 -08:00
0f36654d2b
PPCSymbolDB: Eliminate Redundant Member
...
This can be accessed through the CPUThreadGuard.
2024-03-06 21:44:53 -08:00
7b0d4f0578
WiimoteReal: fix typo in WiimoteReal.cpp
...
continous -> continuous
2024-03-07 01:27:39 +09:00
4568446398
JitInterface::ClearCache: Modernize With CPUThreadGuard
...
It is recommended to view this diff with whitespace changes hidden.
2024-03-04 19:45:34 -08:00
085c17aed4
Remove the update callback on all events
...
Not only was the extra call to the update callback in the AchievementEventHandler method unnecessary, it was getting called on events that don't even need to be tracked here, causing a lot of lag when it turned out one achievement was repeatedly spamming Achievement Reset Events as a shortcut.
2024-03-04 20:04:08 -05:00
aba9b110e8
Merge pull request #12612 from LillyJadeKatrin/retroachievements-logout-bug
...
Don't Publish Unofficial Achievements
2024-03-03 14:51:04 -05:00
93c95ee1a3
Merge pull request #12592 from LillyJadeKatrin/retroachievements-enable-hardcore
...
Properly enable RetroAchievements hardcore mode
2024-03-03 13:20:23 -05:00
f556f646a2
Don't Publish Unofficial Achievements
...
Check an achievement's category and only request RetroAchievements to award if it is CORE and not UNOFFICIAL.
2024-03-03 12:58:20 -05:00
8d5e39751e
BranchWatchDialog: Fix GCC Warnings
...
GCC can't lambda right.
2024-03-02 07:53:23 -08:00
58616a6e4c
Merge pull request #12438 from Filoppi/custom_relative_aspect_ratio
...
Add Custom Relative and Raw (Squared Pixels) aspect ratios
2024-03-02 14:14:19 +01:00
f2e04e0603
Merge pull request #12359 from mitaclaw/code-diff-dialog-refresh
...
BranchWatchDialog: A Total Replacement for CodeDiffDialog
2024-03-02 14:13:54 +01:00
8840f7f8bc
Merge pull request #12599 from lioncash/vertman
...
VertexManagerBase: Initialize m_ticks_elapsed on construction
2024-03-02 14:11:23 +01:00
16c609dcd4
BootManager: Avoid Global System Accessor
2024-03-01 23:39:04 -08:00
f208b320a3
AesDevice: fix key & iv arrays
2024-03-01 15:00:28 -05:00
0d4cb5ddc7
State: Avoid Global System Accessor
2024-03-01 10:52:50 -08:00
26141eece8
Memory(View)Widget: Avoid Global System Accessor
2024-03-01 07:09:20 -08:00
41b19e262f
Add custom relative and raw (squared pixels) aspect ratio modes
2024-02-29 21:11:19 +02:00
e52109a356
DSPJitRegCache: Take DynamicReg instances by reference in FlushRegs()
...
A DynamicReg instance is 80 bytes in size, so this just gets rid of some
unnecessary copy churn.
2024-02-28 10:27:35 -05:00
7bf77a56f4
VertexManagerBase: Initialize m_ticks_elapsed on construction
...
Ensures that this always has a deterministic value on construction like
everything else in the class.
2024-02-28 10:21:08 -05:00
5a81916ee9
Merge pull request #12598 from mitaclaw/case-insensitive
...
CodeWidget: Simplify Case-Insensitive Contains
2024-02-28 08:48:10 -05:00
8eeb93d51a
CodeWidget: Simplify Case-Insensitive Contains
2024-02-27 12:03:38 -08:00
8134c8a572
BranchWatchDialog: A Total Replacement for CodeDiffDialog
...
With a purpose-built Branch Watch feature built into the emulated system: BranchWatchDialog, replacing CodeDiffDialog, is now better than ever!
2024-02-27 11:40:58 -08:00
fd8f2c7822
JitArm64: Install BranchWatch
2024-02-26 19:38:27 -08:00
7cccedca1e
Jit64: Install BranchWatch
2024-02-26 19:38:27 -08:00
2aa250a68a
Interpreter: Install BranchWatch
2024-02-26 19:38:27 -08:00
67f60bec7e
PowerPC: Implement BranchWatch
...
This new component can track code paths by watching branch hits.
2024-02-26 19:38:27 -08:00
56b82e764c
Clear active challenges when game closes
...
Failing to do this was causing challenge icons to carry over into the next game if a game was closed while the icons were active, even if the next game to run was a completely different game entirely with completely different badges.
2024-02-26 22:21:05 -05:00
5090a028e6
Merge pull request #12435 from Filoppi/fix-aspect-ratio-stuck
...
Fix aspect ratio heuristics getting stuck to a state
2024-02-20 21:36:43 +01:00
48fbbdba7c
Video: update widescreen heuristic code to never get stuck to specific old values when changing settings
2024-02-20 22:26:19 +02:00
d66b96b1c0
Properly enable RetroAchievements hardcore mode
...
RetroAchievements plans to use the user_agent in unlock requests to determine which software version was used to play the game, and can filter older software versions out. As such, I have been given the go-ahead to remove the hardcoded line that forces hardcore to always be false.
2024-02-20 12:59:01 -05:00
3f102ea8c2
Video: Make the game resolution (within the window) snap to the XFB size if they are within a ~1 pixel treshold on one axis only.
...
This takes care of making the image clearer in some edge cases where the game was already running at near perfect
4:3 with no stretching, and the VI aspect ratio didn't match the XFB by one pixel, making the image stretched and blurry.
-Video: Fix `FindClosestIntegerResolution() using the window aspect ratio and not the draw aspect ratio, causing it to prefer
stretching over black bars in cases when it wasn't desirable.
2024-02-20 03:09:11 +02:00
95ee0ac781
Video: Fix aspect ratio heuristics getting stuck to widescreen (or to non widescreen) (`m_is_game_widescreen` variable) if the user first forced the aspect ratio to 16:9/4:3 and then set it back to Auto.
2024-02-20 02:42:52 +02:00
ccf2435047
Merge pull request #12586 from LillyJadeKatrin/retroachievements-pointspread-fix
...
Fixes to Achievement points count/mastery
2024-02-19 02:41:14 +01:00
e5b73fec08
Fixes to Achievement points count/mastery
...
Two minor updates to improve the Achievement Manager's handling of a player's completion rate.
One, UnlockStatus and the unlock map now track achievement category, such that TallyScore does not count unofficial achievements in counts/points.
Two, the determinations for mastery/completion are now improved to check (1) that the achievement triggering this is CORE (not UNOFFICIAL) and (2) that it has not already been unlocked at this level on the site, which should be sufficient to determine that the unlocking of this particular achievement completes/masters the game.
2024-02-18 19:27:18 -05:00
22d96ef5b5
Merge pull request #12590 from iwubcode/graphics_mod_action_factory_name
...
VideoCommon: move factory names to be a static inside each action class
2024-02-18 17:13:03 -05:00
27415b0ba1
Merge pull request #12587 from AdmiralCurtiss/localtime
...
Core: Fix crash when inspecting a savestate with a timestamp that causes localtime() to error out
2024-02-18 17:12:29 -05:00
a1147dae6e
VideoCommon: move factory names to be a static inside each action class, so that they can be reused in the future for serialization
2024-02-18 15:45:10 -06:00
638808c944
IOS/FS: Display the invalid path in the ASSERT in BuildFilename().
2024-02-18 20:06:32 +01:00
0157166940
Merge pull request #12585 from iwubcode/json_util_vec3
...
Common: add json utility functions for Vec3 serialization
2024-02-18 19:02:59 +01:00
edbf8f1772
Common: add json utility functions for Vec3 serialization
2024-02-17 22:06:06 -06:00
d3140e72c3
Core: Fix crash when inspecting a savestate with a timestamp that causes localtime() to error out.
2024-02-18 04:45:37 +01:00
52410813f2
Common: Add utility function that wraps localtime_s() or localtime_t().
2024-02-18 04:40:25 +01:00
982ad93355
Merge pull request #12582 from LillyJadeKatrin/retroachievements-bugfix-2
...
Improved achievements disabled messaging
2024-02-18 03:49:44 +01:00
9b5fd5d34e
Merge pull request #12281 from TellowKrinkle/AsahiGL33
...
VideoCommon: Don't use indexed output for fbfetch
2024-02-18 02:33:50 +01:00
56ff19c513
BalloonTip: Rework BalloonTip drawing
...
* Fix irregularly shaped corners
* Remove extra space for BalloonTips with no message or no title
* When the target tip location is not on a screen, put the tooltip on
the mouse's screen instead of the primary screen
* Fix description getting cut off when the title was too long
* Expose border width as a parameter
* Fix spacing and sizing issues with larger border widths
2024-02-17 12:36:19 -08:00
21300bb21b
Merge pull request #12457 from iwubcode/asset_memory_limit
...
VideoCommon: handle asset memory going over reserved limit correctly
2024-02-16 15:46:52 -05:00
394af40db5
Improved achievements disabled messaging
...
Most obviously, there is no longer a warning message to the player in the achievement window that achievements are disabled if a game is not currently running.
2024-02-15 16:33:18 -05:00
a1d6a54eaa
DolphinTool: Fix parsing of command line bzip2 flag
...
Use "bzip2" instead of "bzip" in optparse's compression choices for the
convert command. This is both more accurate and matches what the
ParseCompressionTypeString function expects.
The mismatch between the two parsing functions prevented compression
using bzip2 because either ParseCompressionTypeString or optparse would
generate an error when using "bzip" or "bzip2" respectively.
Fixes https://bugs.dolphin-emu.org/issues/13427
2024-02-13 12:44:03 -08:00
a583526a1c
Merge pull request #12575 from n8pjl/werror-nonnull
...
IOFile: avoid clearing errors on null file struct
2024-02-13 07:43:19 -05:00
9e6d701fbc
Merge pull request #12577 from iwubcode/mesh_for_asset_loader
...
VideoCommon: make mesh asset data loadable by asset loader
2024-02-13 07:42:57 -05:00
2ab877586d
VideoCommon: make mesh asset data loadable by asset loader
2024-02-12 21:45:32 -06:00
mitaclaw