58238e75a7
Vulkan: Fix subgroup reduction
...
It seems that we were writing values from helper invocations, which
produces wrong results.
2021-06-07 22:32:25 -04:00
ec8257ebe1
Merge pull request #9794 from Filoppi/fix_input_focus_bug
...
Fix input focus checks being wrong (issue 12540)
2021-06-07 20:08:09 -04:00
a2e1ddc354
AudioPane: Remove main layout vertical stretching
2021-06-07 15:57:02 -07:00
5fc3cb2379
Interpreter: deduplicate integer comparisons
2021-06-07 22:39:15 +01:00
8f9bb5612a
Merge pull request #9798 from JosJuice/android-wad-crash
...
Android: Fix WAD import crashing
2021-06-07 17:32:23 -04:00
d42cec0d19
Android: Fix WAD import crashing
...
progressMessage can have the invalid value of 0. That
progressMessage was being used for the thread name was
a typo anyway – it's supposed to use progressTitle.
2021-06-07 23:09:29 +02:00
702f86ccc0
InputCommon: fix 2nd+ controller not defaulting to the default device
2021-06-07 19:31:38 +03:00
edc18e60ad
Merge pull request #9785 from Dentomologist/fix_gamelist_grid_zoom_in
...
GameList: Fix grid mode zoom keybind inconsistency
2021-06-07 14:00:21 +02:00
7c83b745c5
Qt: fix input focus checks being wrong
...
When rendering to main and going full screen, we aren't using the main window handle
as the code assumed, but the other, detached, render widget.
2021-06-07 14:35:59 +03:00
5e371bb4be
Merge pull request #9792 from sepalani/lint
...
Lint: End of namespace
2021-06-07 12:16:08 +02:00
8ca6ffd908
Merge pull request #9702 from Filoppi/controller_interface_fixes
...
Controller Interface refactor
2021-06-07 12:15:15 +02:00
1d48a33aed
MMIOHandlers: Move method definitions to MMIO.cpp
2021-06-07 13:42:39 +04:00
ce8004c9c1
Lint: End of namespace
2021-06-07 12:55:52 +04:00
83ea16f402
Qt: Fix IOWindow keeping a shared ptr to devices even after them being removed by the ControllerInterface
...
this prevented some devices from being recreated correctly, as they were exclusive (e.g. DInput Joysticks)
This is achieved by calling Settings::ReleaseDevices(), which releases all the UI devices shared ptrs.
If we are the host (Qt) thread, DevicesChanged() is now called in line, to avoid devices being hanged onto by the UI.
For this, I had to add a method to check whether we are the Host Thread to Qt.
Avoid calling ControllerInterface::RefreshDevices() from the CPU thread if the emulation is running
and we manually refresh devices from Qt, as that is not necessary anymore.
Refactored the way IOWindow lists devices to make it clearer and hold onto disconnected devices.
There were so many issues with the previous code:
-Devices changes would not be reflected until the window was re-opened
-If there was no default device, it would fail to select the device at index 0
-It could have crashed if we had 0 devices
-The default device was not highlighted as such
2021-06-07 11:48:30 +03:00
a77e3b4a9b
InputCommon: Make Wiimote rumble variable thread safe
2021-06-07 11:48:30 +03:00
08f8c27927
ControllerInterface: fix DSU thread safety and use PlatformPopulateDevices()
2021-06-07 11:48:29 +03:00
8b53af9cbc
ControllerInterface: polish DInput Keyboard and Mouse (add comments and logs)
...
Also fix the cursor axis not being updated when the mouse device had failed aquiring,
despite them being completely unrelated
2021-06-07 11:07:06 +03:00
038b57fecc
ControllerInterface: DInput Joystick fix non thread safe static variable
...
also fix devices being added to its own custom list of devices even when rejected by the CI
2021-06-07 11:07:06 +03:00
a0ecca1a84
ControllerInterface: Implement ChangeWindow on DInput without recreating the devices
...
Also polished DInput code in general to try and mitigate issue 11702.
Added a lot of logging and comments.
2021-06-07 11:07:06 +03:00
dcc345400e
ControllerInterface: devices population is now async so implement devices sorting priority
...
This helps us keeping the most important devices (e.g. Mouse and Keyboard) on the top
of the list of devices (they still are on all OSes supported by dolphin
and to make hotplug devices like DSU appear at the bottom.
2021-06-07 11:07:06 +03:00
0718cfd7d7
ControllerInterface: make evdev use PlatformPopulateDevices
...
Also fix evdev non thread safe acces to static variables
2021-06-07 11:07:06 +03:00
2aa941081e
ControllerInterface: make SDL use PlatformPopulateDevices()
...
and avoid waiting on SDL async population being finished for no reason
2021-06-07 11:07:06 +03:00
1d816f8f26
ControllerInterface: make real Wiimote use PlatformPopulateDevices()
2021-06-07 11:07:06 +03:00
c238e49119
ControllerInterface: Remove OSX window handle
...
also make it more thread safe (avoid rare deadlock)
and fix it trying to add devices before the CI has init
2021-06-07 11:07:05 +03:00
2376aec135
ControllerInterface: Refactor
...
-Fix Add/Remove/Refresh device safety, devices could be added and removed at the same time, causing missing or duplicated devices (rare but possible)
-Fix other devices population race conditions in ControllerInterface
-Avoid re-creating all devices when dolphin is being shut down
-Avoid re-creating devices when the render window handle has changed (just the relevantr ones now)
-Avoid sending Devices Changed events if devices haven't actually changed
-Made most devices populations will be made async, to increase performance and avoid hanging the host or CPU thread on manual devices refresh
2021-06-07 11:07:05 +03:00
f90d851e25
ControllerInterface: mixed comments
2021-06-07 11:07:05 +03:00
c285ae57fb
ControllerInterface: fix rare deadlock
...
A "devices changed" callback could have ended up waiting on another thread that was also populating devices
and waiting on the previous thread to release the callbacks mutex.
2021-06-07 11:07:05 +03:00
ebe3fbe04c
Merge pull request #9771 from Filoppi/dsu_fixes
...
DSU improvements
2021-06-07 03:50:50 -04:00
4866002c9b
VideoCommon: Perform OpenGL bounding box inversion in pixel shader
...
Running the min/max operation on the upside down, quad-rounded pixel
coordinates before inverting them to the standard upper-left origin
produces wrong results. Therefore, we need to do the inversion before
rounding to pixel quads.
2021-06-06 20:55:06 -04:00
a208d529de
Merge pull request #9790 from AdmiralCurtiss/cheat-manager-config-change
...
CheatsManager: Avoid recreating child widgets on every OnStateChanged(), and take running game info directly from SConfig.
2021-06-07 02:37:11 +02:00
c3560f033e
UPnP: Improve error messages on initialization failure.
2021-06-07 00:36:35 +02:00
fd4efd3787
Merge pull request #9791 from JosJuice/jitarm64-carbon
...
JitArm64: Fix clobbering LR in FakeLKExit
2021-06-06 23:15:24 +02:00
4ef4ac41d1
JitArm64: Fix clobbering LR in FakeLKExit
...
Fixes Need for Speed: Carbon accessing invalid memory when
branch following and BLR optimization are enabled simultaneously.
2021-06-06 22:43:57 +02:00
441d304317
CheatsManager: Use game information directly from SConfig, and only recreate widgets if game changes.
2021-06-06 21:56:34 +02:00
414e0f4598
GeckoCodeWidget: Take game ID and revision directly instead of through GameFile.
2021-06-06 21:25:37 +02:00
1fbe56210a
ARCodeWidget: Take game ID and revision directly instead of through GameFile.
2021-06-06 21:23:17 +02:00
684d09b342
Merge pull request #9789 from AdmiralCurtiss/netplay-efb-access-tile-size-bool
...
NetPlay: Sync the EFB access tile size as an integer instead of a boolean.
2021-06-06 19:20:38 +02:00
9fd16a93c5
NetPlay: Sync the EFB access tile size as an integer instead of a boolean.
2021-06-06 19:02:07 +02:00
7a6098a7f6
GameList: Fix grid mode zoom keybind inconsistency
...
Add keybind to make 'control plus' zoom in as per convention, and also
'control shift minus' zoom out to maintain consistency.
2021-06-06 09:21:41 -07:00
eaf8e30008
AudioInterface: Fix AIDFR initialization
2021-06-06 18:57:32 +04:00
8139967768
Merge pull request #9787 from JosJuice/jitarm64-slwx-top
...
JitArm64: Discard top 32 bits in slwx result
2021-06-06 08:46:16 +01:00
5470aceb63
Merge pull request #9786 from Tilka/dsp
...
DSP: small cleanup
2021-06-06 00:48:28 -04:00
89af7b82f2
Merge pull request #9770 from JosJuice/jits-accidental-gt
...
Jits: Fix accidentally setting GT in CR when clearing EQ
2021-06-06 05:17:25 +01:00
6c0180fc61
Merge pull request #9748 from JosJuice/fma-accuracy
...
Interpreter/Jit64: Emulate FMA accurately in more cases
2021-06-06 02:29:42 +01:00
f2c4041d39
DSPHLE: remove unused function
2021-06-06 01:09:30 +01:00
a13df9b251
DSP: use CR_* enum values
2021-06-06 01:08:45 +01:00
44206b7702
Update buffer_storage warning message
2021-06-05 15:08:47 -07:00
86de3df072
JitArm64: Discard top 32 bits in slwx result
...
srwx would like to be able to assume that the top 32 bits
are zero, and cmpl is already doing so.
2021-06-05 23:15:08 +02:00
2f8c9a7735
Translation resources sync with Transifex
2021-06-05 21:11:37 +02:00
acc7d3710d
Merge pull request #9780 from Techjar/freelook-config-fix
...
Common/FileUtil: Add some missing configs to D_CONFIG_IDX
2021-06-05 13:40:37 +02:00
Techjar